Page MenuHomePhabricator

yuhan (Yuhan Luo)
Logistics

Projects

User does not belong to any projects.

User Details

User Since
Feb 28 2020, 11:37 PM (13 w, 1 d)

Recent Activity

Fri, May 29

yuhan committed R1:c86aa0b366bb: persist solid selection throught dagit in tags (authored by yuhan).
persist solid selection throught dagit in tags
Fri, May 29, 9:18 PM
yuhan closed D3170: persist solid selection throught dagit in tags.
Fri, May 29, 9:18 PM
yuhan requested review of D3170: persist solid selection throught dagit in tags.
Fri, May 29, 5:58 PM

Thu, May 28

yuhan accepted D3018: Add config mapping example.
Thu, May 28, 5:15 PM
yuhan committed R1:72095f5b882f: selector 2/ allow solid_subset to take DSL syntax in python api… (authored by yuhan).
selector 2/ allow solid_subset to take DSL syntax in python api…
Thu, May 28, 12:06 AM
yuhan closed D3113: selector 2/ allow solid_subset to take DSL syntax in python api execute_pipeline and execute_pipeline_iterator.
Thu, May 28, 12:06 AM
yuhan retitled D3113: selector 2/ allow solid_subset to take DSL syntax in python api execute_pipeline and execute_pipeline_iterator from selector 2/ add solid_subset_query to python api execute_pipeline and execute_pipeline_iterator to selector 2/ allow solid_subset to take DSL syntax in python api execute_pipeline and execute_pipeline_iterator.
Thu, May 28, 12:05 AM
yuhan committed R1:08e1ef534471: selector 1/ subselection query to solid_subset (authored by yuhan).
selector 1/ subselection query to solid_subset
Thu, May 28, 12:03 AM
yuhan closed D3112: selector 1/ subselection query to solid_subset.
Thu, May 28, 12:03 AM

Wed, May 27

yuhan updated the summary of D3113: selector 2/ allow solid_subset to take DSL syntax in python api execute_pipeline and execute_pipeline_iterator.
Wed, May 27, 10:52 PM
yuhan updated the diff for D3113: selector 2/ allow solid_subset to take DSL syntax in python api execute_pipeline and execute_pipeline_iterator.
  • instead of making it an extra arg, we use the existing solid_subset: execute_pipeline(pipeline, solid_subset=['*some_solid', 'other_solid_a', 'other_solid_b+'])
  • more tests to cover multiple clauses (disjoint, overlapping) and invalid queries
Wed, May 27, 10:50 PM
yuhan updated the summary of D3112: selector 1/ subselection query to solid_subset.
Wed, May 27, 10:05 PM
yuhan added inline comments to D3113: selector 2/ allow solid_subset to take DSL syntax in python api execute_pipeline and execute_pipeline_iterator.
Wed, May 27, 9:58 PM
yuhan updated the diff for D3112: selector 1/ subselection query to solid_subset.
  • get_solid_subset_from_query(pipeline_def, query) where query is str => parse_solid_subset(pipeline_def, solid_subset) where solid_subset is List[str]
  • dedup
  • more tests to cover multiple clauses, invalid syntax, and duplication
Wed, May 27, 9:58 PM
yuhan added inline comments to D3112: selector 1/ subselection query to solid_subset.
Wed, May 27, 7:50 PM
yuhan added inline comments to D3113: selector 2/ allow solid_subset to take DSL syntax in python api execute_pipeline and execute_pipeline_iterator.
Wed, May 27, 6:25 PM
yuhan updated the diff for D3113: selector 2/ allow solid_subset to take DSL syntax in python api execute_pipeline and execute_pipeline_iterator.

up

Wed, May 27, 6:04 AM
yuhan committed R1:7a032d85a078: bug fix - step selection query in tags (authored by yuhan).
bug fix - step selection query in tags
Wed, May 27, 6:01 AM
yuhan closed D3102: bug fix - step selection query in tags.
Wed, May 27, 6:01 AM
yuhan requested review of D3113: selector 2/ allow solid_subset to take DSL syntax in python api execute_pipeline and execute_pipeline_iterator.
Wed, May 27, 12:54 AM
yuhan updated the diff for D3112: selector 1/ subselection query to solid_subset.

up

Wed, May 27, 12:41 AM
yuhan requested review of D3112: selector 1/ subselection query to solid_subset.
Wed, May 27, 12:13 AM
yuhan added a reviewer for D3102: bug fix - step selection query in tags: prha.
Wed, May 27, 12:13 AM

Tue, May 26

yuhan accepted D3111: [0.7.15] [docs] Deprecate RTD -- add meta refresh to redirect to new site.
Tue, May 26, 11:37 PM
yuhan requested review of D3102: bug fix - step selection query in tags.
Tue, May 26, 5:05 AM

Sat, May 23

yuhan committed R1:48f20b5186ea: [dagit] shift-click to multi select steps #2470 (authored by yuhan).
[dagit] shift-click to multi select steps #2470
Sat, May 23, 12:02 AM
yuhan closed D3060: [dagit] shift-click to multi select steps #2470.
Sat, May 23, 12:02 AM
yuhan committed R1:248c63f7344c: run grouping - persist step selection query in tags (authored by yuhan).
run grouping - persist step selection query in tags
Sat, May 23, 12:00 AM
yuhan closed D3065: run grouping - persist step selection query in tags.
Sat, May 23, 12:00 AM

Fri, May 22

yuhan requested review of D3065: run grouping - persist step selection query in tags.
Fri, May 22, 10:54 PM
yuhan requested review of D3060: [dagit] shift-click to multi select steps #2470.
Fri, May 22, 7:44 PM
yuhan committed R1:26a712c15f01: [dagit] make log filter follow the step selection DSL #2472 (authored by yuhan).
[dagit] make log filter follow the step selection DSL #2472
Fri, May 22, 5:54 PM
yuhan closed D3046: [dagit] make log filter follow the step selection DSL #2472.
Fri, May 22, 5:54 PM
yuhan added a comment to D3046: [dagit] make log filter follow the step selection DSL #2472.

@max i can maybe make the input a multi-select dropdown so it won't get too crowded for many tags. but gonna land this now cos the iteration of this isn't a blocker for 0.8.0

Fri, May 22, 5:45 PM
yuhan committed R1:be13b8b3818e: [docs] deploy 2/ convert versions page to json and update script (authored by yuhan).
[docs] deploy 2/ convert versions page to json and update script
Fri, May 22, 4:35 PM
yuhan closed D3054: [docs] deploy 2/ convert versions page to json and update script.
Fri, May 22, 4:35 PM
yuhan requested review of D3054: [docs] deploy 2/ convert versions page to json and update script.
Fri, May 22, 6:21 AM
yuhan committed R1:9c87ffbb8a15: bump doc versions (authored by yuhan).
bump doc versions
Fri, May 22, 4:09 AM
yuhan closed D3050: bump doc versions.
Fri, May 22, 4:09 AM
yuhan requested review of D3050: bump doc versions.
Fri, May 22, 3:27 AM
yuhan closed D3013: add new re-execution capability in changelog.

merged into feature branch https://dagster.phacility.com/D3015

Fri, May 22, 3:20 AM
yuhan committed R1:83d8f4b3f136: [docs] deploy 1/ update version script (authored by yuhan).
[docs] deploy 1/ update version script
Fri, May 22, 1:58 AM
yuhan closed D3032: [docs] deploy 1/ update version script.
Fri, May 22, 1:58 AM
yuhan updated the summary of D3046: [dagit] make log filter follow the step selection DSL #2472.
Fri, May 22, 12:37 AM
yuhan requested review of D3046: [dagit] make log filter follow the step selection DSL #2472.
Fri, May 22, 12:34 AM

Thu, May 21

yuhan updated the summary of D3032: [docs] deploy 1/ update version script.
Thu, May 21, 10:25 PM
yuhan updated the diff for D3032: [docs] deploy 1/ update version script.

up

Thu, May 21, 10:19 PM
yuhan updated the diff for D3032: [docs] deploy 1/ update version script.

add test

Thu, May 21, 10:19 PM
yuhan requested review of D3032: [docs] deploy 1/ update version script.
Thu, May 21, 8:43 PM
yuhan committed R1:7720913a97f9: [docs] Deprecate RTD -- add meta refresh to redirect to new site (authored by yuhan).
[docs] Deprecate RTD -- add meta refresh to redirect to new site
Thu, May 21, 12:04 AM

Wed, May 20

yuhan committed R1:2fc807d31c98: [0.7.14] dagit enable multi-step re-execution via step subset selector (authored by yuhan).
[0.7.14] dagit enable multi-step re-execution via step subset selector
Wed, May 20, 10:38 PM
yuhan closed D3015: [0.7.14] dagit enable multi-step re-execution via step subset selector.
Wed, May 20, 10:38 PM
yuhan requested review of D3015: [0.7.14] dagit enable multi-step re-execution via step subset selector.
Wed, May 20, 10:20 PM
yuhan requested review of D3013: add new re-execution capability in changelog.
Wed, May 20, 9:46 PM
yuhan committed R1:2657a3d1f3f6: [docs] Deprecate RTD -- add meta refresh to redirect to new site (authored by yuhan).
[docs] Deprecate RTD -- add meta refresh to redirect to new site
Wed, May 20, 6:55 PM
yuhan closed D3001: [docs] Deprecate RTD -- add meta refresh to redirect to new site.
Wed, May 20, 6:55 PM
yuhan committed R1:36340d5380ec: [docs] move small examples out of dagster_examples (authored by yuhan).
[docs] move small examples out of dagster_examples
Wed, May 20, 4:56 PM
yuhan closed D3002: [docs] move small examples out of dagster_examples.
Wed, May 20, 4:56 PM
yuhan accepted D3005: Add create example command.
Wed, May 20, 4:53 PM
yuhan requested review of D3002: [docs] move small examples out of dagster_examples.
Wed, May 20, 5:16 AM
yuhan requested review of D3001: [docs] Deprecate RTD -- add meta refresh to redirect to new site.
Wed, May 20, 5:09 AM
yuhan accepted D2998: make sure menu items are each on their own line.
Wed, May 20, 4:47 AM

Tue, May 19

yuhan committed R1:50a7f3062b49: clean up console.log (authored by yuhan).
clean up console.log
Tue, May 19, 4:59 PM
yuhan closed D2982: clean up console.log.
Tue, May 19, 4:59 PM

Mon, May 18

yuhan requested review of D2982: clean up console.log.
Mon, May 18, 11:54 PM
yuhan committed R1:f7cdf4cd3c4d: dagit run viewer - step text label unselectable #2471 (authored by yuhan).
dagit run viewer - step text label unselectable #2471
Mon, May 18, 11:21 PM
yuhan closed D2981: dagit run viewer - step text label unselectable #2471.
Mon, May 18, 11:21 PM
yuhan committed R1:97bcefeb0420: [dagit] enable multi-step re-execution via step subset selector #2453 (authored by yuhan).
[dagit] enable multi-step re-execution via step subset selector #2453
Mon, May 18, 11:20 PM
yuhan closed D2959: [dagit] enable multi-step re-execution via step subset selector #2453.
Mon, May 18, 11:20 PM
yuhan added a comment to D2959: [dagit] enable multi-step re-execution via step subset selector #2453.

One last thing that may not feel cohesive is that the filter won't follow the changes in the DSL selector. issue: https://github.com/dagster-io/dagster/issues/2472

Mon, May 18, 11:16 PM
yuhan requested review of D2981: dagit run viewer - step text label unselectable #2471.
Mon, May 18, 10:58 PM
yuhan updated the diff for D2959: [dagit] enable multi-step re-execution via step subset selector #2453.

rebase

Mon, May 18, 10:49 PM
yuhan accepted D2444: Add query to get runs grouped by root run id.
Mon, May 18, 9:51 PM
yuhan accepted D2969: Add tooltip for disabled re-executions.
Mon, May 18, 6:24 PM
yuhan added a comment to D2969: Add tooltip for disabled re-executions.

lg2m. shall we do the same to "Open in Playground..."?

Mon, May 18, 5:17 PM

Sat, May 16

yuhan updated the diff for D2959: [dagit] enable multi-step re-execution via step subset selector #2453.

rebase

Sat, May 16, 11:39 PM
yuhan abandoned D2948: 1/ separate step selection and log filter.
Sat, May 16, 11:35 PM
yuhan updated the diff for D2959: [dagit] enable multi-step re-execution via step subset selector #2453.

update snapshot

Sat, May 16, 11:33 PM
yuhan updated the diff for D2959: [dagit] enable multi-step re-execution via step subset selector #2453.

up

Sat, May 16, 11:29 PM
yuhan updated the summary of D2959: [dagit] enable multi-step re-execution via step subset selector #2453.
Sat, May 16, 11:24 PM
yuhan updated the diff for D2959: [dagit] enable multi-step re-execution via step subset selector #2453.
  1. the selector syntax is linked to all types of step selection:
  2. single click: stepKey
  3. double click: *stepKey*
  4. type in the selector
  5. Have a checkbox which optionally hides unselected steps. The default should be to show all steps.
Sat, May 16, 11:14 PM

Fri, May 15

yuhan requested review of D2959: [dagit] enable multi-step re-execution via step subset selector #2453.
Fri, May 15, 7:56 AM
yuhan updated the diff for D2948: 1/ separate step selection and log filter.

up

Fri, May 15, 12:12 AM

Thu, May 14

yuhan requested review of D2948: 1/ separate step selection and log filter.
Thu, May 14, 9:35 PM
yuhan added a comment to D2444: Add query to get runs grouped by root run id.

I think it makes sense to return a group where ANY child runs that can be applied to the filter, rather than a group where ALL child runs or the root applied. -- thinking about the email filter machinery: it shows the entire thread as long as there's one message matches the filter. also, it could be very real that I filter "status: failure" and I expect to see all the groups where at least one child run failed.

Thu, May 14, 9:11 PM

Tue, May 12

yuhan accepted D2889: Remove extra line at beginning of sitemap file.
Tue, May 12, 9:37 PM
yuhan accepted D2886: Renaming all *RuntimeType* types to *DagsterType*.
Tue, May 12, 8:51 PM
yuhan accepted D2883: Rename runtime type to dagster type in graphql layer and dagit.
Tue, May 12, 8:51 PM
yuhan accepted D2862: [docs] Error when missing literal includes file.
Tue, May 12, 6:26 PM
yuhan committed R1:30d7685f250b: [doc] next deployment manual process (authored by yuhan).
[doc] next deployment manual process
Tue, May 12, 6:12 PM
yuhan closed D2875: [doc] next deployment manual process.
Tue, May 12, 6:12 PM
yuhan updated the diff for D2875: [doc] next deployment manual process.

up

Tue, May 12, 5:53 PM
yuhan accepted D2876: [docs] Copy and Github buttons for code snippets.

chefkiss

Tue, May 12, 4:43 PM
yuhan accepted D2856: [docs] Add dead links test to CI.
Tue, May 12, 4:33 PM
yuhan requested review of D2875: [doc] next deployment manual process.
Tue, May 12, 6:34 AM
yuhan committed R1:4faf3e1c36fc: [doc] code block fix (authored by yuhan).
[doc] code block fix
Tue, May 12, 6:11 AM
yuhan closed D2874: [doc] code block fix.
Tue, May 12, 6:11 AM
yuhan updated the summary of D2874: [doc] code block fix.
Tue, May 12, 6:10 AM
yuhan requested changes to D2856: [docs] Add dead links test to CI.

back to you queue. all look good. lets rebase and then make the tests green

Tue, May 12, 6:09 AM
yuhan added inline comments to D2874: [doc] code block fix.
Tue, May 12, 5:39 AM