Page MenuHomePhabricator

yuhan (Yuhan Luo)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 28 2020, 11:37 PM (47 w, 2 d)

Recent Activity

Sat, Jan 23

yuhan accepted D6121: Remove Kubernetes part 2.
Sat, Jan 23, 12:55 AM

Fri, Jan 22

yuhan accepted D6114: Dagstermill CLI housekeeping.
Fri, Jan 22, 7:41 PM

Thu, Jan 21

yuhan resigned from D6025: [Documentation] Refresh the Contributing guides.

resigning as the adoption folks have more context to sign off the copy :)

Thu, Jan 21, 6:35 PM
yuhan accepted D6052: Actually document breaking change to Dagstermill.
Thu, Jan 21, 6:34 PM
yuhan closed D6077: [docs] loose the link tests to not fail on anchored apidocs links.
Thu, Jan 21, 3:18 AM
yuhan committed R1:97df9befadf1: [docs] loose the link tests to not fail on anchored apidocs links (authored by yuhan).
[docs] loose the link tests to not fail on anchored apidocs links
Thu, Jan 21, 3:18 AM

Wed, Jan 20

yuhan requested review of D6077: [docs] loose the link tests to not fail on anchored apidocs links.
Wed, Jan 20, 11:49 PM
yuhan added inline comments to D6052: Actually document breaking change to Dagstermill.
Wed, Jan 20, 12:38 AM

Tue, Jan 19

yuhan added inline comments to D6047: 8/ Miscellaneous Dagstermill cleanup.
Tue, Jan 19, 11:55 PM
yuhan abandoned D5533: intermediate-deprecation-1 ObjectStoreBackcompatObjectManager & InMemoryBackcompatObjectManager.
Tue, Jan 19, 7:56 PM

Fri, Jan 15

yuhan closed D6026: [docs] fix broken API reference links.
Fri, Jan 15, 6:21 PM
yuhan committed R1:decaaa1818f3: [docs] fix broken API reference links (authored by yuhan).
[docs] fix broken API reference links
Fri, Jan 15, 6:21 PM
yuhan added a comment to D6026: [docs] fix broken API reference links.

done re-release with this change just now

Fri, Jan 15, 6:21 PM
yuhan requested review of D6026: [docs] fix broken API reference links.
Fri, Jan 15, 4:50 AM

Thu, Jan 14

yuhan accepted D6011: Remove dangling references to SystemStorageDefinition.
Thu, Jan 14, 9:36 PM
yuhan accepted D5986: Add mailing list subscription button (via Revue).
Thu, Jan 14, 9:35 PM
yuhan accepted D6008: Revert "Deprecate FileManager and FileHandle #3535".
Thu, Jan 14, 8:42 PM
yuhan closed D6009: [docs] dagit overview refresh using demo.elmentl.
Thu, Jan 14, 8:41 PM
yuhan committed R1:6ad81450e4e2: [docs] dagit overview refresh using demo.elmentl (authored by yuhan).
[docs] dagit overview refresh using demo.elmentl
Thu, Jan 14, 8:41 PM
yuhan published D6009: [docs] dagit overview refresh using demo.elmentl for review.
Thu, Jan 14, 8:38 PM
yuhan closed D5981: Deprecate FileManager and FileHandle #3535.
Thu, Jan 14, 6:26 PM
yuhan committed R1:54fcccbb0ae4: Deprecate FileManager and FileHandle #3535 (authored by yuhan).
Deprecate FileManager and FileHandle #3535
Thu, Jan 14, 6:26 PM
yuhan accepted D5997: handle latest version of nbformat, which adds random string ids.

thankyou

Thu, Jan 14, 6:23 PM
yuhan closed D5992: fix master - pin nbformat.
Thu, Jan 14, 4:03 AM
yuhan committed R1:e3ea9b8bf462: fix master - pin nbformat (authored by yuhan).
fix master - pin nbformat
Thu, Jan 14, 4:03 AM
yuhan requested review of D5992: fix master - pin nbformat.
Thu, Jan 14, 3:23 AM
yuhan closed D5984: context.log paths in default IO manager implementations #3531.
Thu, Jan 14, 2:21 AM
yuhan committed R1:a7f2fe326728: context.log paths in default IO manager implementations #3531 (authored by yuhan).
context.log paths in default IO manager implementations #3531
Thu, Jan 14, 2:21 AM
yuhan updated the test plan for D5984: context.log paths in default IO manager implementations #3531.
Thu, Jan 14, 1:39 AM
yuhan closed D5990: keep AssetStoreOperationType in GRAVEYARD.
Thu, Jan 14, 1:34 AM
yuhan committed R1:d62e08b02299: keep AssetStoreOperationType in GRAVEYARD (authored by yuhan).
keep AssetStoreOperationType in GRAVEYARD
Thu, Jan 14, 1:34 AM
yuhan requested review of D5984: context.log paths in default IO manager implementations #3531.
Thu, Jan 14, 1:29 AM
yuhan requested review of D5990: keep AssetStoreOperationType in GRAVEYARD.
Thu, Jan 14, 1:20 AM
yuhan requested review of D5988: [NOT release-blocking] RFC convert OBJECT_STORE_OPERATION to LOADED_INPUT/HANDLED_OUTPUT.
Thu, Jan 14, 1:05 AM

Wed, Jan 13

yuhan accepted D5980: mark root input managers as experimental.
Wed, Jan 13, 11:00 PM
yuhan requested review of D5981: Deprecate FileManager and FileHandle #3535.
Wed, Jan 13, 10:50 PM
yuhan closed D5966: [docs[ fix API Docs sidebar nav.
Wed, Jan 13, 9:19 PM
yuhan committed R1:fa0618f984a4: [docs[ fix API Docs sidebar nav (authored by yuhan).
[docs[ fix API Docs sidebar nav
Wed, Jan 13, 9:19 PM
yuhan accepted D5942: deprecate has_configurable_inputs, has_configurable_outputs, and has_config_entry.

lg2m. had comments about mentioning the version number

Wed, Jan 13, 9:18 PM
yuhan accepted D5965: Cast to int for sorting cereals by calories.
Wed, Jan 13, 9:16 PM
yuhan resigned from D5967: improve IO manager docstrings.

lg2m. will let max sign off

Wed, Jan 13, 9:14 PM
yuhan accepted D5973: 7/ Fix solid_config fetching.
Wed, Jan 13, 9:12 PM
yuhan accepted D5972: 6/ Add type annotations to Dagstermill context.
Wed, Jan 13, 9:11 PM
yuhan accepted D5971: 5/ Upgrade moto.
Wed, Jan 13, 9:07 PM
yuhan accepted D5970: 4/ Clarify return types and interfaces.
Wed, Jan 13, 9:06 PM
yuhan accepted D5969: 3/ Modernize pandas example.
Wed, Jan 13, 9:03 PM
yuhan accepted D5968: 2/ Modernize examples.

for posterity, this would address one of the follow ups listed in D5922

Wed, Jan 13, 9:02 PM
yuhan accepted D5960: close input load user boundary before return.
Wed, Jan 13, 7:46 PM
yuhan published D5966: [docs[ fix API Docs sidebar nav for review.
Wed, Jan 13, 7:38 PM
yuhan closed D5947: cleanup memoization copy_required_intermediates_for_execution.
Wed, Jan 13, 6:11 PM
yuhan committed R1:126a633aa2ac: cleanup memoization copy_required_intermediates_for_execution (authored by yuhan).
cleanup memoization copy_required_intermediates_for_execution
Wed, Jan 13, 6:11 PM
yuhan closed D5948: [docs] mention IO manager docs in the migration guide #3455.
Wed, Jan 13, 5:56 PM
yuhan committed R1:4acaa7517c1d: [docs] mention IO manager docs in the migration guide #3455 (authored by yuhan).
[docs] mention IO manager docs in the migration guide #3455
Wed, Jan 13, 5:56 PM
yuhan requested review of D5947: cleanup memoization copy_required_intermediates_for_execution.
Wed, Jan 13, 2:48 AM
yuhan published D5948: [docs] mention IO manager docs in the migration guide #3455 for review.
Wed, Jan 13, 2:42 AM
yuhan accepted D5918: manager_key -> io_manager_key.
Wed, Jan 13, 2:34 AM

Tue, Jan 12

yuhan updated subscribers of D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.
Tue, Jan 12, 11:08 PM
yuhan abandoned D5519: introduce HandledOutput and LoadedInput events.

merged in D5474

Tue, Jan 12, 11:02 PM
yuhan closed D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.
Tue, Jan 12, 10:57 PM
yuhan committed R1:46a6feb25742: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput (authored by sandyryza).
ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput
Tue, Jan 12, 10:56 PM
yuhan closed D5922: [docs] Eliminate 'intermediates' in docs #3516.
Tue, Jan 12, 10:52 PM
yuhan committed R1:a2c3c566cde4: [docs] Eliminate 'intermediates' in docs #3516 (authored by yuhan).
[docs] Eliminate 'intermediates' in docs #3516
Tue, Jan 12, 10:52 PM
yuhan updated the diff for D5922: [docs] Eliminate 'intermediates' in docs #3516.

comments

Tue, Jan 12, 10:32 PM
yuhan requested review of D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.
Tue, Jan 12, 10:24 PM
yuhan updated the diff for D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.

handle_back_compat for AssetStoreOperation

Tue, Jan 12, 10:24 PM
yuhan updated the summary of D5922: [docs] Eliminate 'intermediates' in docs #3516.
Tue, Jan 12, 9:59 PM
yuhan added inline comments to D5925: InputManager -> RootInputManager.
Tue, Jan 12, 9:56 PM
yuhan updated the diff for D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.

up

Tue, Jan 12, 9:55 PM
yuhan updated the summary of D5922: [docs] Eliminate 'intermediates' in docs #3516.
Tue, Jan 12, 9:54 PM
yuhan updated the diff for D5922: [docs] Eliminate 'intermediates' in docs #3516.

up

Tue, Jan 12, 9:52 PM
yuhan updated the diff for D5922: [docs] Eliminate 'intermediates' in docs #3516.

up

Tue, Jan 12, 9:51 PM
yuhan resigned from D5937: rename s3_io_manager to s3_pickled_io_manager, adls2_io_manager to adls2_pickled_io_manager, and gcs_io_manager to gcs_pickled_io_manager..

lg2m. but i don't feel strongly either way so i defer to people who hold stronger opinions :)

Tue, Jan 12, 9:35 PM
yuhan added inline comments to D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.
Tue, Jan 12, 9:33 PM
yuhan updated the diff for D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.

yield DagsterEvent in load_input_value

Tue, Jan 12, 9:06 PM
yuhan updated the diff for D5922: [docs] Eliminate 'intermediates' in docs #3516.

up

Tue, Jan 12, 8:41 PM
yuhan planned changes to D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.
Tue, Jan 12, 8:41 PM
yuhan added a comment to D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.

@sandyryza re:

The pattern that we had with ObjectStoreOperation where we put the obj on it and then call serializable to strip it out is a little confusing. Now that the user code isn't responsible for generating the event, do we need this pattern anymore?

without this pattern, we would involve DagsterEvent in the inputs.py.

Tue, Jan 12, 7:33 PM
yuhan updated the diff for D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.

rebase only

Tue, Jan 12, 7:23 PM
yuhan closed D5832: fix import dagster intermediate storage deprecation warning #3478.
Tue, Jan 12, 7:10 PM
yuhan committed R1:d66be0690445: fix import dagster intermediate storage deprecation warning #3478 (authored by yuhan).
fix import dagster intermediate storage deprecation warning #3478
Tue, Jan 12, 7:10 PM
yuhan added a comment to D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.

I like LoadResult

Tue, Jan 12, 6:38 PM
yuhan added inline comments to D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.
Tue, Jan 12, 6:33 PM
yuhan updated the diff for D5832: fix import dagster intermediate storage deprecation warning #3478.

rebase

Tue, Jan 12, 6:32 PM
yuhan closed D5834: RFC: fix result.result_for_solid when using mem_io_manager + default to mem_io_manager.
Tue, Jan 12, 6:27 PM
yuhan committed R1:c012c054cf9b: RFC: fix result.result_for_solid when using mem_io_manager + default to… (authored by yuhan).
RFC: fix result.result_for_solid when using mem_io_manager + default to…
Tue, Jan 12, 6:27 PM
yuhan added inline comments to D5834: RFC: fix result.result_for_solid when using mem_io_manager + default to mem_io_manager.
Tue, Jan 12, 5:53 PM
yuhan updated the diff for D5834: RFC: fix result.result_for_solid when using mem_io_manager + default to mem_io_manager.

resource_instances_to_override

Tue, Jan 12, 5:53 PM
yuhan requested review of D5922: [docs] Eliminate 'intermediates' in docs #3516.
Tue, Jan 12, 9:54 AM
yuhan added reviewers for D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput: sandyryza, schrockn, alangenfeld.
Tue, Jan 12, 4:07 AM
yuhan updated the diff for D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.

guard all log.dagster_event.event_type_value with log.is_dagster_event

Tue, Jan 12, 3:50 AM
yuhan removed reviewers for D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput: alangenfeld, schrockn, sandyryza.
Tue, Jan 12, 3:48 AM
yuhan updated the diff for D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.

up

Tue, Jan 12, 3:14 AM
yuhan updated the diff for D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.

up

Tue, Jan 12, 1:47 AM
yuhan updated the diff for D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.

up

Tue, Jan 12, 1:45 AM
yuhan updated the summary of D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.
Tue, Jan 12, 1:40 AM
yuhan updated the diff for D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.

squashed D5519 in because D5519 solo can't be tested

Tue, Jan 12, 1:34 AM
yuhan updated the diff for D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.

up

Tue, Jan 12, 1:31 AM
yuhan updated the diff for D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.

up

Tue, Jan 12, 1:28 AM

Mon, Jan 11

yuhan updated the summary of D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.
Mon, Jan 11, 11:39 PM
yuhan updated the diff for D5474: ObjectStoreOperation/AssetStoreOperation -> HandledOutput/LoadedInput.

rebase

Mon, Jan 11, 11:10 PM