Page MenuHomePhabricator

yichendai (Yichen Dai)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 21 2020, 5:15 PM (5 w, 3 d)

Recent Activity

Yesterday

yichendai updated the summary of D4960: [Docs] Corrected the path to fan_in_fan_out.py.
Thu, Oct 29, 11:39 PM
yichendai requested review of D4960: [Docs] Corrected the path to fan_in_fan_out.py.
Thu, Oct 29, 7:27 PM

Wed, Oct 28

yichendai updated the summary of D4677: Replaced outdated images in Parametrizing Solids wiht Config.
Wed, Oct 28, 7:02 PM

Wed, Oct 21

yichendai closed D4859: Fixed a typo.
Wed, Oct 21, 10:10 PM
yichendai committed R1:8513a57fd7ea: Fixed a typo (authored by yichendai).
Fixed a typo
Wed, Oct 21, 10:10 PM
yichendai updated the summary of D4859: Fixed a typo.
Wed, Oct 21, 10:07 PM
yichendai requested review of D4859: Fixed a typo.
Wed, Oct 21, 9:57 PM
yichendai planned changes to D4641: Replace custom_types_figure_one image to highlight SimpleDataFrame.
Wed, Oct 21, 3:35 AM
yichendai planned changes to D4677: Replaced outdated images in Parametrizing Solids wiht Config.
Wed, Oct 21, 3:31 AM
yichendai planned changes to D4665: Show a screenshot of the error as it displays in dagit for Complex Type Checks.
Wed, Oct 21, 3:30 AM
yichendai abandoned D4844: [Docs] Rewrite Parametrizing Solids with Config with new examples and test..
Wed, Oct 21, 3:30 AM
yichendai closed D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
Wed, Oct 21, 3:20 AM
yichendai committed R1:bb7ab5752e47: Revised the Parametrizing Solid with Config in Docs Basics of Solids (authored by yichendai).
Revised the Parametrizing Solid with Config in Docs Basics of Solids
Wed, Oct 21, 3:20 AM
yichendai updated the diff for D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.

Update last fix

Wed, Oct 21, 2:40 AM
yichendai requested review of D4844: [Docs] Rewrite Parametrizing Solids with Config with new examples and test..
Wed, Oct 21, 2:23 AM
yichendai added a comment to D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.

Wed, Oct 21, 12:23 AM

Tue, Oct 20

yichendai updated the summary of D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
Tue, Oct 20, 12:54 AM
yichendai updated the summary of D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
Tue, Oct 20, 12:53 AM
yichendai updated the summary of D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
Tue, Oct 20, 12:52 AM
yichendai added a comment to D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.

Created another config_more_details.py to hold the optional config. The config.py contains the least verbose example.

Tue, Oct 20, 12:49 AM
yichendai updated the diff for D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.

Update: Start with the least verbose config example

Tue, Oct 20, 12:46 AM

Mon, Oct 19

yichendai updated the summary of D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
Mon, Oct 19, 7:12 PM
yichendai updated the diff for D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.

Update: fix typo

Mon, Oct 19, 7:09 PM
yichendai updated the summary of D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
Mon, Oct 19, 7:07 PM
yichendai updated the diff for D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.

Update: modified context.log.info and set reverse to True in config.py and its yaml

Mon, Oct 19, 7:03 PM

Sat, Oct 17

yichendai updated the summary of D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
Sat, Oct 17, 2:24 AM
yichendai updated the diff for D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.

Update: Add how to specify config by python api and yaml file

Sat, Oct 17, 1:25 AM
yichendai added inline comments to D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
Sat, Oct 17, 1:13 AM

Thu, Oct 15

yichendai added a comment to D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.

Here're three screenshots for preview of the page.

Thu, Oct 15, 10:20 PM
yichendai added a reviewer for D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids: schrockn.
Thu, Oct 15, 6:07 PM
yichendai updated the summary of D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
Thu, Oct 15, 5:32 PM
yichendai updated the summary of D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
Thu, Oct 15, 5:31 PM
yichendai retitled D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids from [Part1] Revised the Parametrizing Solid with Config in Docs Basics of Solids to Revised the Parametrizing Solid with Config in Docs Basics of Solids.
Thu, Oct 15, 5:31 PM
yichendai requested review of D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
Thu, Oct 15, 5:24 PM

Wed, Oct 7

yichendai added a comment to D4641: Replace custom_types_figure_one image to highlight SimpleDataFrame.
Wed, Oct 7, 4:45 PM
yichendai added a comment to D4641: Replace custom_types_figure_one image to highlight SimpleDataFrame.
In D4641#126638, @max wrote:

this is fine as a standalone change, i am requesting changes just so we can discuss some of the broader issues. if we are going to use this green circle highlight idiom, we should use it elsewhere in the tutorial as well - it doesn't really make sense for this to be the only screenshot with salient elements highlighted. i also think we need a plan for how we're going to recreate these screenshots when the UI changes. the previous screenshots were generated automatically using a script: https://github.com/dagster-io/dagster/blob/master/docs/generate_screenshots.test.js -- if we aren't going to update this script to generate the highlights as well, i think we should consider writing instructions for whatever manual work is required to highlight the screenshots.

Wed, Oct 7, 4:44 PM
yichendai added a comment to D4645: Add Code Snippet for Metadata and custom Type Checks.
In D4645#126650, @max wrote:

This is ok as a standalone change, req'ing changes for discussion. Do we want to provide config for *all* of the examples on this page? If not, why not? Seems inconsistent.

Wed, Oct 7, 4:35 PM

Tue, Oct 6

yichendai requested review of D4677: Replaced outdated images in Parametrizing Solids wiht Config.
Tue, Oct 6, 6:15 PM
yichendai closed D4676: fix some outstanding typo and wording.
Tue, Oct 6, 6:01 PM
yichendai committed R1:254bf541ed94: fix some outstanding typo and wording (authored by yichendai).
fix some outstanding typo and wording
Tue, Oct 6, 6:01 PM
yichendai requested review of D4676: fix some outstanding typo and wording.
Tue, Oct 6, 1:33 AM

Mon, Oct 5

yichendai closed D4644: Replace the previous img which displays unwanted keyboard shortcuts.
Mon, Oct 5, 11:13 PM
yichendai committed R1:10ce35f05a25: Replace the previous img which displays unwanted keyboard shortcuts (authored by yichendai).
Replace the previous img which displays unwanted keyboard shortcuts
Mon, Oct 5, 11:13 PM
yichendai updated the diff for D4644: Replace the previous img which displays unwanted keyboard shortcuts.

cherry pick

Mon, Oct 5, 11:11 PM
yichendai closed D4642: Remind the user of add config to launch execution and update ERROR message for running custom_types_2.py.
Mon, Oct 5, 7:43 PM
yichendai committed R1:4ece6cc6afa6: Remind the user of add config to launch execution and update ERROR message for… (authored by yichendai).
Remind the user of add config to launch execution and update ERROR message for…
Mon, Oct 5, 7:43 PM
yichendai updated the diff for D4641: Replace custom_types_figure_one image to highlight SimpleDataFrame.

Modifed custom_types_figure_one image to fix dead link

Mon, Oct 5, 6:46 PM
yichendai updated the diff for D4642: Remind the user of add config to launch execution and update ERROR message for running custom_types_2.py.

Rebase

Mon, Oct 5, 5:12 PM
yichendai requested review of D4665: Show a screenshot of the error as it displays in dagit for Complex Type Checks.
Mon, Oct 5, 4:27 AM
yichendai updated the diff for D4645: Add Code Snippet for Metadata and custom Type Checks.

Updating D4645: Add Code Snippet for Metadata and custom Type Checks

Mon, Oct 5, 3:51 AM
yichendai updated the diff for D4643: Modify Making Your Pipelines Testable in Docs.

Updating D4643: Modify Making Your Pipelines Testable in Docs

Mon, Oct 5, 3:25 AM
yichendai abandoned D4622: Add Code Snippet for Metadata and custom Type Checks.
Mon, Oct 5, 1:05 AM
yichendai updated the diff for D4641: Replace custom_types_figure_one image to highlight SimpleDataFrame.

Updating D4641: Replace custom_types_figure_one image to highlight SimpleDataFrame

Mon, Oct 5, 1:02 AM
yichendai updated the diff for D4641: Replace custom_types_figure_one image to highlight SimpleDataFrame.

Update impage - Delete old image custom_types_figure_one

Mon, Oct 5, 12:33 AM
yichendai abandoned D4607: Fix Docs Small Bugs in Dagster Types Chapter.
Mon, Oct 5, 12:32 AM
yichendai updated the diff for D4607: Fix Docs Small Bugs in Dagster Types Chapter.
  • Replace custom_types_figure_one image to highlight SimpleDataFrame
  • Delete old image custom_types_figure_one
Mon, Oct 5, 12:31 AM
yichendai abandoned D4619: Modify Making Your Pipelines Testable in Docs.
Mon, Oct 5, 12:03 AM
yichendai abandoned D4607: Fix Docs Small Bugs in Dagster Types Chapter.
Mon, Oct 5, 12:00 AM

Fri, Oct 2

yichendai closed D4648: Changed the title of Tutorials to Before We Start.
Fri, Oct 2, 10:21 PM
yichendai committed R1:e93c5f8fd738: Changed the title of Tutorials to Before We Start (authored by yichendai).
Changed the title of Tutorials to Before We Start
Fri, Oct 2, 10:21 PM
yichendai requested review of D4648: Changed the title of Tutorials to Before We Start.
Fri, Oct 2, 6:03 PM
yichendai requested review of D4645: Add Code Snippet for Metadata and custom Type Checks.
Fri, Oct 2, 5:56 PM
yichendai requested review of D4644: Replace the previous img which displays unwanted keyboard shortcuts.
Fri, Oct 2, 5:53 PM
yichendai requested review of D4643: Modify Making Your Pipelines Testable in Docs.
Fri, Oct 2, 5:51 PM
yichendai requested review of D4642: Remind the user of add config to launch execution and update ERROR message for running custom_types_2.py.
Fri, Oct 2, 5:44 PM
yichendai requested review of D4641: Replace custom_types_figure_one image to highlight SimpleDataFrame.
Fri, Oct 2, 5:33 PM
yichendai updated the diff for D4607: Fix Docs Small Bugs in Dagster Types Chapter.
  • Replace custom_types_figure_one image to highlight SimpleDataFrame
Fri, Oct 2, 5:12 PM
yichendai updated the diff for D4607: Fix Docs Small Bugs in Dagster Types Chapter.

Update

Fri, Oct 2, 4:38 PM
yichendai requested review of D4622: Add Code Snippet for Metadata and custom Type Checks.
Fri, Oct 2, 7:04 AM
yichendai updated the diff for D4607: Fix Docs Small Bugs in Dagster Types Chapter.
  • Replace the previous img which displays unwanted keyboard shortcuts
Fri, Oct 2, 5:15 AM
yichendai requested review of D4619: Modify Making Your Pipelines Testable in Docs.
Fri, Oct 2, 5:10 AM
yichendai retitled D4607: Fix Docs Small Bugs in Dagster Types Chapter from Changed the Subtitle "Tutorials" to "Before We Start" and Replace a Image to Highlight the Concept "SimpleDataFrame" to Fix Docs Small Bugs in Dagster Types Chapter.
Fri, Oct 2, 12:50 AM
yichendai updated the diff for D4607: Fix Docs Small Bugs in Dagster Types Chapter.
  • Remind the user of add config to launch execution and update ERROR message for running custom_types_2.py
Fri, Oct 2, 12:39 AM

Thu, Oct 1

yichendai retitled D4607: Fix Docs Small Bugs in Dagster Types Chapter from Changed the title of Tutorials to Before We Start to Changed the Subtitle "Tutorials" to "Before We Start" and Replace a Image to Highlight the Concept "SimpleDataFrame" .
Thu, Oct 1, 10:54 PM
yichendai updated the diff for D4607: Fix Docs Small Bugs in Dagster Types Chapter.
  • Replace custom_types_figure_one image to highlight SimpleDataFrame
Thu, Oct 1, 10:44 PM
yichendai published D4607: Fix Docs Small Bugs in Dagster Types Chapter for review.
Thu, Oct 1, 12:08 AM