Page MenuHomePhabricator

themissinghlink (Abhinava Singh)
Disabled

Projects

User does not belong to any projects.

User Details

User Since
Oct 22 2019, 4:39 PM (36 w, 2 d)
Roles
Disabled

Recent Activity

Apr 17 2020

themissinghlink added a comment to D2582: Add StringSourceType and IntSourceType support to config type snap deserialization.

Fixed. Also RE your comment on custom config types, see this: https://dagster.phacility.com/D2588

Apr 17 2020, 6:31 AM
themissinghlink updated the summary of D2588: support snapshot backed config validation.
Apr 17 2020, 6:30 AM
themissinghlink abandoned D2585: Container execution prototype.

q mgmt

Apr 17 2020, 6:30 AM
themissinghlink added reviewers for D2588: support snapshot backed config validation: schrockn, alangenfeld.
Apr 17 2020, 6:27 AM
themissinghlink updated the diff for D2588: support snapshot backed config validation.
  • finally....holy guacamole
Apr 17 2020, 6:24 AM
themissinghlink updated the diff for D2582: Add StringSourceType and IntSourceType support to config type snap deserialization.
  • use int source/str source directly
Apr 17 2020, 6:17 AM
themissinghlink updated the diff for D2588: support snapshot backed config validation.
  • fix bug with registry
Apr 17 2020, 6:04 AM
themissinghlink updated the diff for D2588: support snapshot backed config validation.
  • up
Apr 17 2020, 5:47 AM
themissinghlink updated the summary of D2588: support snapshot backed config validation.
Apr 17 2020, 5:41 AM
themissinghlink updated the diff for D2588: support snapshot backed config validation.
  • rename
Apr 17 2020, 5:39 AM
themissinghlink updated the diff for D2588: support snapshot backed config validation.
  • added customer config scalar registry
Apr 17 2020, 5:38 AM
themissinghlink updated the summary of D2588: support snapshot backed config validation.
Apr 17 2020, 5:02 AM
themissinghlink updated the diff for D2588: support snapshot backed config validation.
  • up
Apr 17 2020, 4:51 AM
themissinghlink updated the diff for D2588: support snapshot backed config validation.
  • added gcp config type support
Apr 17 2020, 4:49 AM
themissinghlink updated the diff for D2586: Fetch presets from user containers.
  • back presets with preset definition data
Apr 17 2020, 4:18 AM
themissinghlink updated the diff for D2588: support snapshot backed config validation.
  • rebase
Apr 17 2020, 3:45 AM
themissinghlink updated the diff for D2588: support snapshot backed config validation.
  • up
Apr 17 2020, 3:38 AM
themissinghlink updated the summary of D2588: support snapshot backed config validation.
Apr 17 2020, 3:29 AM
themissinghlink updated the diff for D2588: support snapshot backed config validation.
  • fixed leaking of shape interfaces
Apr 17 2020, 3:25 AM

Apr 16 2020

themissinghlink updated the diff for D2588: support snapshot backed config validation.
  • fix lint issues
Apr 16 2020, 4:19 PM
themissinghlink removed reviewers for D2588: support snapshot backed config validation: alangenfeld, schrockn.
Apr 16 2020, 7:13 AM
themissinghlink added reviewers for D2588: support snapshot backed config validation: alangenfeld, schrockn.
Apr 16 2020, 7:12 AM
themissinghlink created D2588: support snapshot backed config validation.
Apr 16 2020, 7:11 AM
themissinghlink abandoned D2587: Utilize snapshots to perform config validation.
Apr 16 2020, 6:52 AM
themissinghlink created D2587: Utilize snapshots to perform config validation.
Apr 16 2020, 6:51 AM
themissinghlink added reviewers for D2586: Fetch presets from user containers: alangenfeld, schrockn.
Apr 16 2020, 6:39 AM
themissinghlink created D2586: Fetch presets from user containers.
Apr 16 2020, 6:34 AM
themissinghlink created D2585: Container execution prototype.
Apr 16 2020, 6:19 AM
themissinghlink added a comment to D2582: Add StringSourceType and IntSourceType support to config type snap deserialization.

Would love resolution here btw. Unsure where we landed?

Apr 16 2020, 1:33 AM
themissinghlink abandoned D2562: (container-execution-1)-refactor-environment-schema-fetch [RFC].

whoops

Apr 16 2020, 1:32 AM
themissinghlink added a comment to D2562: (container-execution-1)-refactor-environment-schema-fetch [RFC].

Ok it took me a bit of reading to get here, but you are right. We can use the pipeline snapshot for the parse step in config validation but nothing else. I am going to get going now that a path has become clear.

Apr 16 2020, 1:32 AM

Apr 15 2020

themissinghlink added a comment to D2582: Add StringSourceType and IntSourceType support to config type snap deserialization.

I wonder if it makes sense for config types serdes to live with their corresponding ConfigType. That way when folks do build their own custom config type, they are on the hook for providing a way to read/write from ConfigTypeSnap?

Apr 15 2020, 11:27 PM
themissinghlink added inline comments to D2582: Add StringSourceType and IntSourceType support to config type snap deserialization.
Apr 15 2020, 10:55 PM
themissinghlink updated the diff for D2582: Add StringSourceType and IntSourceType support to config type snap deserialization.
  • pass through key
Apr 15 2020, 10:54 PM
themissinghlink accepted D2580: (graphql-changes-for-snapshot-explore-view-1) Add pipelineSnapshotId to IPipelineSnapshot and PipelineRun.

nidoking

Apr 15 2020, 10:43 PM
themissinghlink added reviewers for D2582: Add StringSourceType and IntSourceType support to config type snap deserialization: schrockn, alangenfeld.
Apr 15 2020, 9:57 PM
themissinghlink created D2582: Add StringSourceType and IntSourceType support to config type snap deserialization.
Apr 15 2020, 9:56 PM
themissinghlink committed R1:b68b862ab8cf: added default value to config field map (authored by themissinghlink).
added default value to config field map
Apr 15 2020, 8:51 PM
themissinghlink closed D2561: added default value to config field map.
Apr 15 2020, 8:51 PM
themissinghlink updated the diff for D2561: added default value to config field map.
  • rebased and fixed tuple declaration
Apr 15 2020, 8:40 PM
themissinghlink updated the diff for D2561: added default value to config field map.
  • up
Apr 15 2020, 5:52 PM
themissinghlink updated the diff for D2561: added default value to config field map.
  • up
Apr 15 2020, 5:40 PM
themissinghlink updated the diff for D2561: added default value to config field map.
  • made serdes complicments clear and added invariant checks
Apr 15 2020, 5:38 PM
themissinghlink added inline comments to D2561: added default value to config field map.
Apr 15 2020, 4:46 PM
themissinghlink updated the summary of D2562: (container-execution-1)-refactor-environment-schema-fetch [RFC].
Apr 15 2020, 6:58 AM
themissinghlink updated the summary of D2562: (container-execution-1)-refactor-environment-schema-fetch [RFC].
Apr 15 2020, 6:57 AM
themissinghlink updated the summary of D2562: (container-execution-1)-refactor-environment-schema-fetch [RFC].
Apr 15 2020, 6:56 AM
themissinghlink updated the diff for D2562: (container-execution-1)-refactor-environment-schema-fetch [RFC].
  • up
Apr 15 2020, 6:55 AM
themissinghlink retitled D2562: (container-execution-1)-refactor-environment-schema-fetch [RFC] from (container-execution-1)-refactor-environment-schema-fetch to (container-execution-1)-refactor-environment-schema-fetch [RFC].
Apr 15 2020, 6:49 AM
themissinghlink updated the diff for D2562: (container-execution-1)-refactor-environment-schema-fetch [RFC].
  • up
Apr 15 2020, 6:44 AM
themissinghlink updated the diff for D2562: (container-execution-1)-refactor-environment-schema-fetch [RFC].
  • enum investigation
Apr 15 2020, 6:41 AM
themissinghlink updated the diff for D2561: added default value to config field map.
  • up
Apr 15 2020, 4:27 AM
themissinghlink added inline comments to D2561: added default value to config field map.
Apr 15 2020, 2:00 AM
themissinghlink created D2562: (container-execution-1)-refactor-environment-schema-fetch [RFC].
Apr 15 2020, 12:37 AM

Apr 14 2020

themissinghlink added reviewers for D2561: added default value to config field map: schrockn, alangenfeld.
Apr 14 2020, 11:35 PM
themissinghlink updated the diff for D2561: added default value to config field map.
  • update snapshots
Apr 14 2020, 11:26 PM
themissinghlink updated the diff for D2561: added default value to config field map.
  • rebase
Apr 14 2020, 11:12 PM
themissinghlink committed R1:50683b1782bf: fix config type snapshot tests (authored by themissinghlink).
fix config type snapshot tests
Apr 14 2020, 11:11 PM
themissinghlink closed D2560: fix config type snapshot tests.
Apr 14 2020, 11:11 PM
themissinghlink edited reviewers for D2560: fix config type snapshot tests, added: nate; removed: prha.
Apr 14 2020, 11:08 PM
themissinghlink created D2561: added default value to config field map.
Apr 14 2020, 11:07 PM
themissinghlink updated the diff for D2560: fix config type snapshot tests.
  • up
Apr 14 2020, 10:52 PM
themissinghlink edited reviewers for D2560: fix config type snapshot tests, added: max, prha; removed: schrockn.
Apr 14 2020, 10:51 PM
themissinghlink added a reviewer for D2560: fix config type snapshot tests: schrockn.
Apr 14 2020, 10:44 PM
themissinghlink created D2560: fix config type snapshot tests.
Apr 14 2020, 10:41 PM
themissinghlink committed R1:8961d65197e2: (container-execution-preparation) - Add config type deserialization (authored by themissinghlink).
(container-execution-preparation) - Add config type deserialization
Apr 14 2020, 8:45 PM
themissinghlink closed D2540: (container-execution-preparation) - Add config type deserialization.
Apr 14 2020, 8:45 PM
themissinghlink updated the diff for D2540: (container-execution-preparation) - Add config type deserialization.
  • cleanuped tests and dict code
Apr 14 2020, 8:32 PM
themissinghlink abandoned D2554: got rid of none type resolution and modified callsites.

Ack. Good to know. Going to abandon this then.

Apr 14 2020, 8:05 PM
themissinghlink added reviewers for D2554: got rid of none type resolution and modified callsites: schrockn, alangenfeld.
Apr 14 2020, 5:59 PM
themissinghlink updated the diff for D2540: (container-execution-preparation) - Add config type deserialization.
  • up
Apr 14 2020, 5:58 PM
themissinghlink created D2554: got rid of none type resolution and modified callsites.
Apr 14 2020, 5:40 PM
themissinghlink added a comment to D2540: (container-execution-preparation) - Add config type deserialization.
_CONFIG_MAP_BY_NAME = {
    enum.__name__ if enum is not BuiltinEnum.ANY else 'Any': built_in_type
    for enum, built_in_type in _CONFIG_MAP.items()
}
Apr 14 2020, 5:01 PM
themissinghlink updated the diff for D2540: (container-execution-preparation) - Add config type deserialization.
  • up
Apr 14 2020, 4:59 PM
themissinghlink updated the diff for D2540: (container-execution-preparation) - Add config type deserialization.
  • added snapshot tests and consolidated code
Apr 14 2020, 3:55 PM
themissinghlink added inline comments to D2540: (container-execution-preparation) - Add config type deserialization.
Apr 14 2020, 3:55 PM
themissinghlink updated the diff for D2540: (container-execution-preparation) - Add config type deserialization.
  • threw the sink at it
Apr 14 2020, 3:00 AM
themissinghlink added a comment to D2540: (container-execution-preparation) - Add config type deserialization.

Ah another thing that came up. It seems default values are being lost in our serialization format. The ConfigFieldSnap doesn't have a default value field. It just has a default_provided field which is a boolean. So I know if a default was provided, but I am missing what the value was.

Apr 14 2020, 2:08 AM
themissinghlink added inline comments to D2540: (container-execution-preparation) - Add config type deserialization.
Apr 14 2020, 1:50 AM
themissinghlink added a comment to D2540: (container-execution-preparation) - Add config type deserialization.

Whew. Now that was a whirlwind tour of our config system. Lessons were learned. XD

Apr 14 2020, 1:18 AM
themissinghlink updated the diff for D2540: (container-execution-preparation) - Add config type deserialization.
  • updated code to work with different subtypes of config types
Apr 14 2020, 1:17 AM

Apr 13 2020

themissinghlink planned changes to D2540: (container-execution-preparation) - Add config type deserialization.
Apr 13 2020, 9:35 PM
themissinghlink added inline comments to D2540: (container-execution-preparation) - Add config type deserialization.
Apr 13 2020, 9:15 PM
themissinghlink accepted D2534: (add-snapshot-persistence-7) Refresh all snapshots.

lgtm

Apr 13 2020, 8:14 PM
themissinghlink added inline comments to D2535: (add-snapshot-persistence-6) Refactor pipeline snapshot tests as a fixture.
Apr 13 2020, 7:47 PM
themissinghlink added reviewers for D2540: (container-execution-preparation) - Add config type deserialization: schrockn, alangenfeld.
Apr 13 2020, 7:32 PM
themissinghlink updated the diff for D2540: (container-execution-preparation) - Add config type deserialization.
  • added composite support
Apr 13 2020, 7:32 PM
themissinghlink removed reviewers for D2540: (container-execution-preparation) - Add config type deserialization: alangenfeld, schrockn.
Apr 13 2020, 6:54 PM
themissinghlink added reviewers for D2540: (container-execution-preparation) - Add config type deserialization: alangenfeld, schrockn.
Apr 13 2020, 6:54 PM
themissinghlink created D2540: (container-execution-preparation) - Add config type deserialization.
Apr 13 2020, 6:53 PM

Apr 10 2020

themissinghlink committed R1:535ee06b5228: (container-supported-dagit)-support-used-solids (authored by themissinghlink).
(container-supported-dagit)-support-used-solids
Apr 10 2020, 10:53 PM
themissinghlink closed D2512: (container-supported-dagit)-support-used-solids.
Apr 10 2020, 10:53 PM
themissinghlink updated the diff for D2512: (container-supported-dagit)-support-used-solids.
  • move check call to simplify invariant logic
Apr 10 2020, 10:41 PM
themissinghlink added inline comments to D2512: (container-supported-dagit)-support-used-solids.
Apr 10 2020, 10:31 PM
themissinghlink updated the diff for D2512: (container-supported-dagit)-support-used-solids.
  • up
Apr 10 2020, 9:59 PM
themissinghlink updated the diff for D2512: (container-supported-dagit)-support-used-solids.
  • cleaned up solid code to use map.
Apr 10 2020, 9:28 PM
themissinghlink added inline comments to D2512: (container-supported-dagit)-support-used-solids.
Apr 10 2020, 8:53 PM
themissinghlink added reviewers for D2512: (container-supported-dagit)-support-used-solids: schrockn, alangenfeld.
Apr 10 2020, 6:33 PM
themissinghlink updated the diff for D2512: (container-supported-dagit)-support-used-solids.
  • order pipeline indexes to have proper solid ordering
Apr 10 2020, 6:25 PM
themissinghlink updated the diff for D2512: (container-supported-dagit)-support-used-solids.
  • revert changes during experimentation
Apr 10 2020, 5:30 PM