Page MenuHomePhabricator

themissinghlink (Abhinava Singh)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 22 2019, 4:39 PM (23 w, 2 d)

Recent Activity

Today

themissinghlink committed R1:f401bfccd10c: unpin grpcio in examples. (authored by themissinghlink).
unpin grpcio in examples.
Thu, Apr 2, 4:16 PM
themissinghlink closed D2414: unpin grpcio in examples..
Thu, Apr 2, 4:16 PM
themissinghlink added a reviewer for D2414: unpin grpcio in examples.: schrockn.
Thu, Apr 2, 4:07 PM
themissinghlink updated the summary of D2414: unpin grpcio in examples..
Thu, Apr 2, 3:56 PM
themissinghlink created D2414: unpin grpcio in examples..
Thu, Apr 2, 3:35 PM
themissinghlink committed R1:6efa4e3a83e1: bugfix - fixed container tests which fail for windows (authored by themissinghlink).
bugfix - fixed container tests which fail for windows
Thu, Apr 2, 4:38 AM
themissinghlink closed D2413: bugfix - fixed container tests which fail for windows.
Thu, Apr 2, 4:38 AM
themissinghlink updated the diff for D2413: bugfix - fixed container tests which fail for windows.
  • added link to issue
Thu, Apr 2, 4:24 AM
themissinghlink added a comment to D2413: bugfix - fixed container tests which fail for windows.

On it. Thanks Phil!

Thu, Apr 2, 4:06 AM
themissinghlink updated the summary of D2413: bugfix - fixed container tests which fail for windows.
Thu, Apr 2, 3:45 AM
themissinghlink updated the summary of D2413: bugfix - fixed container tests which fail for windows.
Thu, Apr 2, 3:37 AM
themissinghlink updated the diff for D2413: bugfix - fixed container tests which fail for windows.
  • grpcio 1.28.0 might be broken, testing
Thu, Apr 2, 3:35 AM
themissinghlink updated the diff for D2413: bugfix - fixed container tests which fail for windows.

up

Thu, Apr 2, 3:23 AM
themissinghlink created D2413: bugfix - fixed container tests which fail for windows.
Thu, Apr 2, 2:43 AM
themissinghlink committed R1:7df4b539bc88: bugfix - use os "agnostic" tmp directory (authored by themissinghlink).
bugfix - use os "agnostic" tmp directory
Thu, Apr 2, 1:08 AM
themissinghlink closed D2412: bugfix - use os "agnostic" tmp directory.
Thu, Apr 2, 1:08 AM
themissinghlink added reviewers for D2412: bugfix - use os "agnostic" tmp directory: alangenfeld, schrockn.
Thu, Apr 2, 1:01 AM
themissinghlink updated the diff for D2412: bugfix - use os "agnostic" tmp directory.
  • fix tests
Thu, Apr 2, 12:57 AM
themissinghlink updated the summary of D2412: bugfix - use os "agnostic" tmp directory.
Thu, Apr 2, 12:54 AM
themissinghlink created D2412: bugfix - use os "agnostic" tmp directory.
Thu, Apr 2, 12:54 AM

Yesterday

themissinghlink committed R1:e94a15fe2368: (2-read-only-containers)-link-to-pipelin-cli-print-command (authored by themissinghlink).
(2-read-only-containers)-link-to-pipelin-cli-print-command
Wed, Apr 1, 11:12 PM
themissinghlink closed D2392: (2-read-only-containers)-link-to-pipelin-cli-print-command.
Wed, Apr 1, 11:12 PM
themissinghlink removed a reviewer for D2392: (2-read-only-containers)-link-to-pipelin-cli-print-command: alangenfeld.
Wed, Apr 1, 11:12 PM
themissinghlink updated the diff for D2392: (2-read-only-containers)-link-to-pipelin-cli-print-command.
  • rebase and address feedback
Wed, Apr 1, 10:17 PM
themissinghlink committed R1:4aa3dbd735ef: (1-read-only-containers)-container-snapshot-provider-scaffolding (authored by themissinghlink).
(1-read-only-containers)-container-snapshot-provider-scaffolding
Wed, Apr 1, 10:06 PM
themissinghlink closed D2381: (1-read-only-containers)-container-snapshot-provider-scaffolding.
Wed, Apr 1, 10:06 PM
themissinghlink removed a reviewer for D2381: (1-read-only-containers)-container-snapshot-provider-scaffolding: alangenfeld.
Wed, Apr 1, 10:00 PM
themissinghlink removed a reviewer for D2392: (2-read-only-containers)-link-to-pipelin-cli-print-command: nate.
Wed, Apr 1, 8:58 PM
themissinghlink added a reviewer for D2392: (2-read-only-containers)-link-to-pipelin-cli-print-command: nate.
Wed, Apr 1, 8:58 PM
themissinghlink updated the diff for D2381: (1-read-only-containers)-container-snapshot-provider-scaffolding.
  • up
Wed, Apr 1, 8:23 PM
themissinghlink updated the diff for D2381: (1-read-only-containers)-container-snapshot-provider-scaffolding.
  • relax entrypoint constraint
Wed, Apr 1, 8:16 PM
themissinghlink added a comment to D2381: (1-read-only-containers)-container-snapshot-provider-scaffolding.
Wed, Apr 1, 5:09 PM
themissinghlink updated the diff for D2392: (2-read-only-containers)-link-to-pipelin-cli-print-command.
  • rebased
Wed, Apr 1, 4:15 PM
themissinghlink updated the diff for D2381: (1-read-only-containers)-container-snapshot-provider-scaffolding.
  • converted to function
Wed, Apr 1, 4:12 PM
themissinghlink added inline comments to D2381: (1-read-only-containers)-container-snapshot-provider-scaffolding.
Wed, Apr 1, 3:40 AM

Tue, Mar 31

themissinghlink added a comment to D2392: (2-read-only-containers)-link-to-pipelin-cli-print-command.

Fixes have been made. Ready to rock!

Tue, Mar 31, 11:31 PM
themissinghlink updated the summary of D2392: (2-read-only-containers)-link-to-pipelin-cli-print-command.
Tue, Mar 31, 11:30 PM
themissinghlink updated the diff for D2392: (2-read-only-containers)-link-to-pipelin-cli-print-command.
  • got rid of all none, also not needed anymore because we are going a different route
Tue, Mar 31, 11:17 PM
themissinghlink updated the diff for D2392: (2-read-only-containers)-link-to-pipelin-cli-print-command.

rebase

Tue, Mar 31, 11:13 PM
themissinghlink updated the diff for D2381: (1-read-only-containers)-container-snapshot-provider-scaffolding.

rebase

Tue, Mar 31, 11:06 PM
themissinghlink closed D2395: rename definition/container.py to definition/solid_container.py.
Tue, Mar 31, 11:01 PM
themissinghlink committed R1:167e42655e7b: rename definition/container.py to definition/solid_container.py (authored by themissinghlink).
rename definition/container.py to definition/solid_container.py
Tue, Mar 31, 11:01 PM
themissinghlink added reviewers for D2395: rename definition/container.py to definition/solid_container.py: alangenfeld, schrockn.
Tue, Mar 31, 10:51 PM
themissinghlink added a comment to D2395: rename definition/container.py to definition/solid_container.py.

Once this lands, merge this into https://dagster.phacility.com/D2381 and https://dagster.phacility.com/D2392

Tue, Mar 31, 10:49 PM
themissinghlink created D2395: rename definition/container.py to definition/solid_container.py.
Tue, Mar 31, 10:48 PM
themissinghlink added inline comments to D2392: (2-read-only-containers)-link-to-pipelin-cli-print-command.
Tue, Mar 31, 10:22 PM
themissinghlink updated the diff for D2392: (2-read-only-containers)-link-to-pipelin-cli-print-command.
  • added output support
Tue, Mar 31, 10:18 PM
themissinghlink added inline comments to D2392: (2-read-only-containers)-link-to-pipelin-cli-print-command.
Tue, Mar 31, 9:13 PM
themissinghlink added reviewers for D2392: (2-read-only-containers)-link-to-pipelin-cli-print-command: alangenfeld, schrockn.
Tue, Mar 31, 9:10 PM
themissinghlink updated the diff for D2392: (2-read-only-containers)-link-to-pipelin-cli-print-command.
  • lint fixes
Tue, Mar 31, 8:56 PM
themissinghlink updated the summary of D2392: (2-read-only-containers)-link-to-pipelin-cli-print-command.
Tue, Mar 31, 8:47 PM
themissinghlink created D2392: (2-read-only-containers)-link-to-pipelin-cli-print-command.
Tue, Mar 31, 8:46 PM
themissinghlink added a comment to D2381: (1-read-only-containers)-container-snapshot-provider-scaffolding.

Alright, ready to rock. Yeah this is a lot simpler to mantain XD. Who knew!

Tue, Mar 31, 8:32 PM
themissinghlink updated the diff for D2381: (1-read-only-containers)-container-snapshot-provider-scaffolding.
  • got rid of entrypoints so that container provider just takes the image and assumes the repository.yaml file is just there
Tue, Mar 31, 8:23 PM
themissinghlink added inline comments to D2381: (1-read-only-containers)-container-snapshot-provider-scaffolding.
Tue, Mar 31, 7:01 PM
themissinghlink added reviewers for D2381: (1-read-only-containers)-container-snapshot-provider-scaffolding: schrockn, alangenfeld.
Tue, Mar 31, 6:56 AM
themissinghlink updated the diff for D2381: (1-read-only-containers)-container-snapshot-provider-scaffolding.
  • up
Tue, Mar 31, 6:41 AM
themissinghlink updated the summary of D2381: (1-read-only-containers)-container-snapshot-provider-scaffolding.
Tue, Mar 31, 6:39 AM
themissinghlink created D2381: (1-read-only-containers)-container-snapshot-provider-scaffolding.
Tue, Mar 31, 6:38 AM
themissinghlink created D2380: end to end pipeline list cli with read only image.
Tue, Mar 31, 5:09 AM

Mon, Mar 30

themissinghlink accepted D2373: Make callable in default_value illegal.

prettygood

Mon, Mar 30, 10:48 PM
themissinghlink committed R1:5cf8f159183a: Prepare bay bikes for production (authored by themissinghlink).
Prepare bay bikes for production
Mon, Mar 30, 10:35 PM
themissinghlink closed D2356: Prepare bay bikes for production.
Mon, Mar 30, 10:35 PM
themissinghlink committed R1:2f3a732435e3: Add repository snapshot CLI (authored by themissinghlink).
Add repository snapshot CLI
Mon, Mar 30, 10:26 PM
themissinghlink closed D2358: Add repository snapshot CLI.
Mon, Mar 30, 10:26 PM
themissinghlink added a comment to D2358: Add repository snapshot CLI.

Leaving this as a comment, eventually, when we move towards using pytest snapshots for the PipelineSnapshot and RepositorySnapshot, we are going to find that comparing serialized snapshots across versions will fail because of an OrderedDict issue.

Mon, Mar 30, 10:15 PM
themissinghlink updated the diff for D2358: Add repository snapshot CLI.
  • fixed repo name
Mon, Mar 30, 10:13 PM
themissinghlink updated the diff for D2358: Add repository snapshot CLI.
  • got rid of snapshots since they weren't very stable across versions and because pipeline snapshot tests are doing ti manually
Mon, Mar 30, 10:04 PM
themissinghlink updated the diff for D2358: Add repository snapshot CLI.

rebase

Mon, Mar 30, 9:40 PM
themissinghlink updated the diff for D2358: Add repository snapshot CLI.
  • enforce that cli only supports repositories and also use snapshots
  • fixed lint issues
  • change core serdes callsites
  • fixed snapshot bug
Mon, Mar 30, 9:36 PM
themissinghlink updated the diff for D2358: Add repository snapshot CLI.
  • change core serdes callsites
Mon, Mar 30, 8:58 PM
themissinghlink added inline comments to D2358: Add repository snapshot CLI.
Mon, Mar 30, 8:34 PM
themissinghlink updated the diff for D2358: Add repository snapshot CLI.
  • enforce that cli only supports repositories and also use snapshots
  • fixed lint issues
Mon, Mar 30, 8:33 PM
themissinghlink added a comment to D2361: (stable-hash-2) Make PipelineSnapshot serializable via serdes.

ah yes, to be clear, this lgtm and can be done in a follow-up. Wasn't sure if Nick was gonna follow up in this revision or not.

Mon, Mar 30, 7:51 PM
themissinghlink added a comment to D2358: Add repository snapshot CLI.

@schrockn and I doubled up a bit here. Once his revision goes through, I will rebase, so ignore the whitelist for serdes changes. I am leaving them in so that this can remain a working revision.

Mon, Mar 30, 4:03 PM

Sun, Mar 29

themissinghlink accepted D2360: (stable-hash-1) Move dagster.core.serdes to dagster.serdes.

seems legit!

Sun, Mar 29, 11:45 PM
themissinghlink added inline comments to D2361: (stable-hash-2) Make PipelineSnapshot serializable via serdes.
Sun, Mar 29, 11:45 PM
themissinghlink added inline comments to D2361: (stable-hash-2) Make PipelineSnapshot serializable via serdes.
Sun, Mar 29, 11:15 PM
themissinghlink added inline comments to D2361: (stable-hash-2) Make PipelineSnapshot serializable via serdes.
Sun, Mar 29, 6:57 PM
themissinghlink added a comment to D2361: (stable-hash-2) Make PipelineSnapshot serializable via serdes.

Ah good call. I ended up doing this yesterday in https://dagster.phacility.com/D2358. Once builds work let me know and I will approve it!

Sun, Mar 29, 6:48 PM
themissinghlink added reviewers for D2358: Add repository snapshot CLI: alangenfeld, schrockn.
Sun, Mar 29, 3:31 AM
themissinghlink added inline comments to D2358: Add repository snapshot CLI.
Sun, Mar 29, 3:30 AM
themissinghlink updated the summary of D2358: Add repository snapshot CLI.
Sun, Mar 29, 3:21 AM
themissinghlink created D2358: Add repository snapshot CLI.
Sun, Mar 29, 3:20 AM

Sat, Mar 28

themissinghlink added reviewers for D2356: Prepare bay bikes for production: nate, schrockn.
Sat, Mar 28, 7:56 PM
themissinghlink updated the diff for D2356: Prepare bay bikes for production.
  • update snapshots
Sat, Mar 28, 7:36 PM
themissinghlink created D2356: Prepare bay bikes for production.
Sat, Mar 28, 7:11 PM

Fri, Mar 27

themissinghlink abandoned D2343: [prototype rfc] User Code Container Entrypoints in Dagit.

I am gonna abandon this revision for queue management.

Fri, Mar 27, 5:15 PM
themissinghlink added a comment to D2343: [prototype rfc] User Code Container Entrypoints in Dagit.

Sounds good. I am going to take you all off as reviewers. Based on our meeting yesterday the milestone is to modify all CLI commands in the dagster pipeline group by letting users pass in a --image <image name> option and get results from a read only container with their user code. For this to happen, I am going to get the following revisions out:

Fri, Mar 27, 5:15 PM

Thu, Mar 26

themissinghlink updated the summary of D2343: [prototype rfc] User Code Container Entrypoints in Dagit.
Thu, Mar 26, 6:47 PM
themissinghlink added a comment to D2343: [prototype rfc] User Code Container Entrypoints in Dagit.

Moving forward. If this all looks good, I can start with refining and producing land-able diffs for the following:

Thu, Mar 26, 5:51 PM
themissinghlink retitled D2343: [prototype rfc] User Code Container Entrypoints in Dagit from [prototype] User Code Container Entrypoints in Dagit to [prototype rfc] User Code Container Entrypoints in Dagit.
Thu, Mar 26, 5:04 PM
themissinghlink added reviewers for D2343: [prototype rfc] User Code Container Entrypoints in Dagit: alangenfeld, nate, schrockn.
Thu, Mar 26, 5:03 PM
themissinghlink updated the diff for D2343: [prototype rfc] User Code Container Entrypoints in Dagit.
  • self review fixes
Thu, Mar 26, 5:03 PM
themissinghlink updated the diff for D2343: [prototype rfc] User Code Container Entrypoints in Dagit.
  • added docker as a dependency
Thu, Mar 26, 4:56 PM
themissinghlink created D2343: [prototype rfc] User Code Container Entrypoints in Dagit.
Thu, Mar 26, 4:52 PM

Wed, Mar 25

themissinghlink accepted D2332: inner_plan_iterator diff bug fixes.

rubberstamp

Wed, Mar 25, 12:25 AM

Tue, Mar 24

themissinghlink committed R1:27d3c06c47f5: add structured logging to bay bikes (authored by themissinghlink).
add structured logging to bay bikes
Tue, Mar 24, 11:52 PM
themissinghlink closed D2291: add structured logging to bay bikes.
Tue, Mar 24, 11:52 PM
themissinghlink added a comment to D2291: add structured logging to bay bikes.

Yeah that makes sense. However, the first bullet is ready to go. After writing out, you are right, this is a lot neater.

Tue, Mar 24, 6:04 PM