Page MenuHomeElementl

sidkmenon (Sid Menon)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 19 2021, 9:41 PM (12 w, 5 d)

Recent Activity

Fri, Apr 16

sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/3].

rebasing

Fri, Apr 16, 9:19 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3].

Trying installation of dagster-graphql to fix build

Fri, Apr 16, 9:10 PM
sidkmenon abandoned D7343: [Draft] [RFC] [dagster-graphql] Initial Python Client implementation.
Fri, Apr 16, 8:33 PM
sidkmenon updated the test plan for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/3].
Fri, Apr 16, 8:30 PM
sidkmenon added reviewers for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3]: alangenfeld, catherinewu.
Fri, Apr 16, 8:30 PM
sidkmenon added a reviewer for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/3]: catherinewu.
Fri, Apr 16, 8:29 PM
sidkmenon added a reviewer for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/3]: alangenfeld.
Fri, Apr 16, 8:29 PM
sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/3].

Rebasing

Fri, Apr 16, 8:11 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3].

Adding dagster-graphql to tox.ini and setup.py in automation

Fri, Apr 16, 8:03 PM
sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/3].

Moving submit_pipeline_execution tests to the GraphQL python client's test suite

Fri, Apr 16, 7:54 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3].

Fixing are_queries_compatible

Fri, Apr 16, 7:43 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3].

Added regex check to remove redundant spacing from query strings as well

Fri, Apr 16, 7:41 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3].

Adding checks for redundant dagster-graphql-client query snapshot calls and refactoring

Fri, Apr 16, 7:18 PM
sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/3].

Rebasing

Fri, Apr 16, 6:05 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3].

Responding to comments - refactoring cli to dagster-graphql-client cli

Fri, Apr 16, 5:59 PM
sidkmenon added inline comments to D7409: [RFC] [dagster-graphql] Python Client Implementation [1/3].
Fri, Apr 16, 3:03 PM
sidkmenon updated the diff for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/3].

Adding to bk python scripts

Fri, Apr 16, 3:00 PM
sidkmenon updated the diff for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/3].

Adding marker to pytest.ini

Fri, Apr 16, 12:45 AM
sidkmenon updated the diff for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/3].

Addressing comments, including seperating tests into their own tox suite

Fri, Apr 16, 12:30 AM

Thu, Apr 15

sidkmenon published D7424: [dagster-graphql] Dagster GraphQL Python Client [3/3] for review.
Thu, Apr 15, 2:29 PM

Wed, Apr 14

sidkmenon updated the summary of D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3].
Wed, Apr 14, 5:37 PM
sidkmenon published D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3] for review.
Wed, Apr 14, 4:58 PM

Tue, Apr 13

sidkmenon requested review of D7409: [RFC] [dagster-graphql] Python Client Implementation [1/3].
Tue, Apr 13, 6:43 PM

Fri, Apr 9

sidkmenon accepted D7370: K8sRunLauncher make postgres optional.

LGTM!

Fri, Apr 9, 5:18 PM

Wed, Apr 7

sidkmenon retitled D7343: [Draft] [RFC] [dagster-graphql] Initial Python Client implementation from [RFC] [dagster-graphql] Initial Python Client implementation to [Draft] [RFC] [dagster-graphql] Initial Python Client implementation.
Wed, Apr 7, 9:18 PM
sidkmenon requested review of D7343: [Draft] [RFC] [dagster-graphql] Initial Python Client implementation.
Wed, Apr 7, 9:09 PM

Mar 18 2021

sidkmenon updated the test plan for D7019: [docs] Instance Config YAML refactor.
Mar 18 2021, 5:22 PM
sidkmenon updated the diff for D7019: [docs] Instance Config YAML refactor.

Also updating MySQL docs

Mar 18 2021, 5:21 PM
sidkmenon updated the diff for D7019: [docs] Instance Config YAML refactor.

Updating API docs to include Consolidated Sqlite Storage

Mar 18 2021, 5:11 PM
sidkmenon updated the summary of D7019: [docs] Instance Config YAML refactor.
Mar 18 2021, 4:38 PM
sidkmenon updated the diff for D7019: [docs] Instance Config YAML refactor.

Ran a make build and seemed to work for MySQL stuff

Mar 18 2021, 7:53 AM
sidkmenon updated the summary of D7019: [docs] Instance Config YAML refactor.
Mar 18 2021, 7:49 AM
sidkmenon updated the diff for D7019: [docs] Instance Config YAML refactor.

Fixing more typos

Mar 18 2021, 7:38 AM
sidkmenon requested review of D7019: [docs] Instance Config YAML refactor.
Mar 18 2021, 7:35 AM

Mar 17 2021

sidkmenon updated the diff for D6898: [core] 0.11.0 Schema migrations for MySQL support.

Rebase conflicts, so making sure no issues w. build

Mar 17 2021, 8:21 PM

Mar 16 2021

sidkmenon updated the diff for D6898: [core] 0.11.0 Schema migrations for MySQL support.

UNIQUE_TEXT => UniqueText

Mar 16 2021, 11:13 PM
sidkmenon updated the diff for D6898: [core] 0.11.0 Schema migrations for MySQL support.

Adding MySQLCompatabilityTypes.UNIQUE_TEXT as a replacement for passing around UNIQUE_VARCHAR_LEN

Mar 16 2021, 6:16 PM
sidkmenon abandoned D6917: [dagster-pg] flaky test fix.
Mar 16 2021, 5:42 PM
sidkmenon added a comment to D6943: Unpin sqlalchemy: Update select label to not be `count`.

Yup, added back pin locally and still seems to work.

Mar 16 2021, 5:38 PM
sidkmenon added a comment to D6943: Unpin sqlalchemy: Update select label to not be `count`.

(you could double check by leaving in the pin locally and verifying that tests still pass after changing it to scalar)

Mar 16 2021, 5:33 PM
sidkmenon accepted D6965: Attempted fix for flaky postgres tests.

Macro absolute-win:

Mar 16 2021, 5:27 PM
sidkmenon added a comment to D6965: Attempted fix for flaky postgres tests.

So I just checked https://www.postgresql.org/docs/9.1/sql-notify.html and verified that for a NOTIFY (registered on store_event) to be registered, LISTEN must first be called; LISTEN is first called in the pynotify loop, so all events after that will be registered & checked in the loop body. This solution looks great, since it ensures that the watcher thread is ready to listen before the event storing/notifier thread can continue.

Mar 16 2021, 5:24 PM

Mar 15 2021

sidkmenon updated the diff for D6943: Unpin sqlalchemy: Update select label to not be `count`.

Updating scalar call

Mar 15 2021, 9:19 PM
sidkmenon updated the summary of D6943: Unpin sqlalchemy: Update select label to not be `count`.
Mar 15 2021, 9:18 PM
sidkmenon commandeered D6943: Unpin sqlalchemy: Update select label to not be `count`.
Mar 15 2021, 9:17 PM
sidkmenon added inline comments to D6943: Unpin sqlalchemy: Update select label to not be `count`.
Mar 15 2021, 7:44 PM
sidkmenon accepted D6931: Try increasing timeouts on postgres event log tests a bit.

This looks great to me, since only the PG tests have shown to be flaky right? Though honestly I'm pretty puzzled why test_event_log_storage_watch was flaky and why test_event_log_storage_two_watchers was not flaky? They're both such similar tests - the latter is just a more complex one than the former.

Mar 15 2021, 3:46 PM

Mar 12 2021

sidkmenon updated the diff for D6917: [dagster-pg] flaky test fix.

again

Mar 12 2021, 5:14 PM
sidkmenon requested review of D6917: [dagster-pg] flaky test fix.
Mar 12 2021, 5:05 PM
sidkmenon updated the diff for D6810: [core][dagster-mysql] Fixing @experimental tag to work for classes.

rebase

Mar 12 2021, 3:09 AM
sidkmenon added inline comments to D6898: [core] 0.11.0 Schema migrations for MySQL support.
Mar 12 2021, 2:26 AM
sidkmenon updated the diff for D6810: [core][dagster-mysql] Fixing @experimental tag to work for classes.

Adding @experimental tag to dagster-pandas as per @rexledesma's comment

Mar 12 2021, 12:49 AM
sidkmenon updated the test plan for D6898: [core] 0.11.0 Schema migrations for MySQL support.
Mar 12 2021, 12:33 AM
sidkmenon updated the test plan for D6898: [core] 0.11.0 Schema migrations for MySQL support.
Mar 12 2021, 12:33 AM
sidkmenon updated the test plan for D6898: [core] 0.11.0 Schema migrations for MySQL support.
Mar 12 2021, 12:33 AM
sidkmenon updated the test plan for D6898: [core] 0.11.0 Schema migrations for MySQL support.
Mar 12 2021, 12:26 AM
sidkmenon requested review of D6898: [core] 0.11.0 Schema migrations for MySQL support.
Mar 12 2021, 12:22 AM

Mar 11 2021

sidkmenon abandoned D6892: [dagster-postgres] Removing dead signal handling code from pynotify.
Mar 11 2021, 8:32 PM
sidkmenon updated the summary of D6892: [dagster-postgres] Removing dead signal handling code from pynotify.
Mar 11 2021, 8:31 PM
sidkmenon updated the diff for D6862: [dagster-postgres] Cleanup Event Log.

Getting rid of D6892 & just removing signal handling logic here

Mar 11 2021, 8:26 PM
sidkmenon requested review of D6892: [dagster-postgres] Removing dead signal handling code from pynotify.
Mar 11 2021, 8:12 PM
sidkmenon updated the diff for D6863: [dagster-postgres] Fixing cursor issues (GH issue #3744).

rebasing

Mar 11 2021, 6:20 PM
sidkmenon updated the diff for D6862: [dagster-postgres] Cleanup Event Log.

Rebasing

Mar 11 2021, 6:19 PM
sidkmenon added inline comments to D6863: [dagster-postgres] Fixing cursor issues (GH issue #3744).
Mar 11 2021, 6:06 AM
sidkmenon added inline comments to D6862: [dagster-postgres] Cleanup Event Log.
Mar 11 2021, 6:03 AM
sidkmenon updated the diff for D6863: [dagster-postgres] Fixing cursor issues (GH issue #3744).

up

Mar 11 2021, 5:55 AM
sidkmenon updated the diff for D6862: [dagster-postgres] Cleanup Event Log.

Adding test for pynotify

Mar 11 2021, 5:55 AM

Mar 10 2021

sidkmenon added inline comments to D6863: [dagster-postgres] Fixing cursor issues (GH issue #3744).
Mar 10 2021, 5:58 PM
sidkmenon requested review of D6863: [dagster-postgres] Fixing cursor issues (GH issue #3744).
Mar 10 2021, 2:02 AM
sidkmenon requested review of D6862: [dagster-postgres] Cleanup Event Log.
Mar 10 2021, 2:02 AM

Mar 8 2021

sidkmenon added inline comments to D6810: [core][dagster-mysql] Fixing @experimental tag to work for classes.
Mar 8 2021, 6:38 PM
sidkmenon updated the diff for D6810: [core][dagster-mysql] Fixing @experimental tag to work for classes.

new_init => warn_and_init, old_init => dunder_init

Mar 8 2021, 6:34 PM
sidkmenon added a comment to D6784: [core] Adding destructor to SqlPollingEventWatcher.
In D6784#180814, @prha wrote:

we were seeing a memory leak with this?

Mar 8 2021, 5:38 PM
sidkmenon requested review of D6810: [core][dagster-mysql] Fixing @experimental tag to work for classes.
Mar 8 2021, 4:54 PM
sidkmenon added a reviewer for D6784: [core] Adding destructor to SqlPollingEventWatcher: prha.
Mar 8 2021, 4:34 PM
sidkmenon updated the test plan for D6784: [core] Adding destructor to SqlPollingEventWatcher.
Mar 8 2021, 4:34 PM

Mar 5 2021

sidkmenon accepted D6799: Turns relative imports into absolute imports, and removes imports in __init__ (for generated project skeleton)..

LGTM (let's get this money)

Mar 5 2021, 4:30 PM
sidkmenon added reviewers for D6784: [core] Adding destructor to SqlPollingEventWatcher: catherinewu, rexledesma, bob.
Mar 5 2021, 2:10 AM

Mar 4 2021

sidkmenon requested review of D6784: [core] Adding destructor to SqlPollingEventWatcher.
Mar 4 2021, 9:40 PM
sidkmenon added a comment to D6783: [core][dagster-graphql] Fixing flaky dagster-graphql Polling Event Watcher tests.

TEST PLAN
bk

might be good to try to run the specific test a whole bunch of times to verify

Mar 4 2021, 5:20 PM
sidkmenon requested review of D6783: [core][dagster-graphql] Fixing flaky dagster-graphql Polling Event Watcher tests.
Mar 4 2021, 4:10 PM
sidkmenon updated the diff for D6766: [dagster-mysql] Fixing schedule storage stamp_alembic_rev error.

rebase

Mar 4 2021, 5:02 AM

Mar 3 2021

sidkmenon updated the diff for D6766: [dagster-mysql] Fixing schedule storage stamp_alembic_rev error.

Removing "schedules" as per prha's comment

Mar 3 2021, 10:13 PM
sidkmenon requested review of D6766: [dagster-mysql] Fixing schedule storage stamp_alembic_rev error.
Mar 3 2021, 7:05 PM
sidkmenon updated the diff for D6734: [dagster-mysql] Adding experimental warnings to dagster-mysql.

Using @experimental warning instead

Mar 3 2021, 6:44 PM

Mar 2 2021

sidkmenon accepted D6749: Remove duplicate test in run storage.

Makes sense to me - sorry for not checking internal!

Mar 2 2021, 7:02 PM
sidkmenon requested review of D6734: [dagster-mysql] Adding experimental warnings to dagster-mysql.
Mar 2 2021, 3:46 AM

Mar 1 2021

sidkmenon updated the diff for D6703: [core] SqlPollingEventWatcher housekeeping.

Removing linter checks!

Mar 1 2021, 7:06 PM
sidkmenon updated the diff for D6617: [dagster-mysql] Add dagster-mysql to libraries.

Two small changes:

Mar 1 2021, 6:32 PM
sidkmenon updated the diff for D6701: [core] Adding shared Event Log storage test suite.

Naming / test refactoring as per Phil's comments

Mar 1 2021, 6:22 PM
sidkmenon requested review of D6714: [core][dagster-postgres] Adding dagster-postgres tests to `TestRunStorage` suite.
Mar 1 2021, 5:46 PM
sidkmenon updated the summary of D6617: [dagster-mysql] Add dagster-mysql to libraries.
Mar 1 2021, 3:41 AM
sidkmenon updated the diff for D6617: [dagster-mysql] Add dagster-mysql to libraries.

Fixing alembic config to match D6684

Mar 1 2021, 3:33 AM
sidkmenon updated the diff for D6703: [core] SqlPollingEventWatcher housekeeping.

Adding lint checks to prevent regressions as per Rex's comment

Mar 1 2021, 1:55 AM

Feb 26 2021

sidkmenon updated the summary of D6617: [dagster-mysql] Add dagster-mysql to libraries.
Feb 26 2021, 11:38 PM
sidkmenon updated the diff for D6617: [dagster-mysql] Add dagster-mysql to libraries.

Addressing the rest of @prha's comments in refactoring test suite & general cleanup

Feb 26 2021, 11:28 PM
sidkmenon added inline comments to D6617: [dagster-mysql] Add dagster-mysql to libraries.
Feb 26 2021, 11:27 PM
sidkmenon requested review of D6715: [dagster-postgres] cleaning up ScheduleStorage suite.
Feb 26 2021, 11:15 PM
sidkmenon requested review of D6714: [core][dagster-postgres] Adding dagster-postgres tests to `TestRunStorage` suite.
Feb 26 2021, 11:12 PM
sidkmenon updated the summary of D6701: [core] Adding shared Event Log storage test suite.
Feb 26 2021, 10:59 PM