rebasing

Trying installation of dagster-graphql to fix build

Rebasing

Adding dagster-graphql to tox.ini and setup.py in automation

Moving submit_pipeline_execution tests to the GraphQL python client's test suite

Fixing are_queries_compatible

Added regex check to remove redundant spacing from query strings as well

Adding checks for redundant dagster-graphql-client query snapshot calls and refactoring

Rebasing

Responding to comments - refactoring cli to dagster-graphql-client cli

Adding to bk python scripts

Adding marker to pytest.ini

Addressing comments, including seperating tests into their own tox suite

LGTM!

Also updating MySQL docs

Updating API docs to include Consolidated Sqlite Storage

Ran a make build and seemed to work for MySQL stuff

Fixing more typos

Rebase conflicts, so making sure no issues w. build

UNIQUE_TEXT => UniqueText

Adding MySQLCompatabilityTypes.UNIQUE_TEXT as a replacement for passing around UNIQUE_VARCHAR_LEN

Yup, added back pin locally and still seems to work.

In D6943#184182, @dgibson wrote:

(you could double check by leaving in the pin locally and verifying that tests still pass after changing it to scalar)

So I just checked https://www.postgresql.org/docs/9.1/sql-notify.html and verified that for a NOTIFY (registered on store_event) to be registered, LISTEN must first be called; LISTEN is first called in the pynotify loop, so all events after that will be registered & checked in the loop body. This solution looks great, since it ensures that the watcher thread is ready to listen before the event storing/notifier thread can continue.

Updating scalar call

This looks great to me, since only the PG tests have shown to be flaky right? Though honestly I'm pretty puzzled why test_event_log_storage_watch was flaky and why test_event_log_storage_two_watchers was not flaky? They're both such similar tests - the latter is just a more complex one than the former.

again

rebase

Adding @experimental tag to dagster-pandas as per @rexledesma's comment

Getting rid of D6892 & just removing signal handling logic here

rebasing

Rebasing

up

Adding test for pynotify

new_init => warn_and_init, old_init => dunder_init

In D6784#180814, @prha wrote:

we were seeing a memory leak with this?

LGTM (let's get this money)

In D6783#179953, @alangenfeld wrote:

TEST PLAN
bk

might be good to try to run the specific test a whole bunch of times to verify

rebase

Removing "schedules" as per prha's comment

Using @experimental warning instead

Makes sense to me - sorry for not checking internal!

Removing linter checks!

Two small changes:

Naming / test refactoring as per Phil's comments

Fixing alembic config to match D6684

Adding lint checks to prevent regressions as per Rex's comment

Addressing the rest of @prha's comments in refactoring test suite & general cleanup