User Details
User Details
- User Since
- Mar 20 2019, 8:23 PM (67 w, 1 d)
- Roles
- Administrator
Today
Today
Fix install order in root Makefile
schrockn requested review of D3754: Fix install order in root Makefile.
Yesterday
Yesterday
schrockn added a comment to D3670: Remove ability to load modules resolved by the working directory.
do we have a test for python_package?
schrockn added inline comments to D3670: Remove ability to load modules resolved by the working directory.
schrockn requested review of D3752: Port build and push scripts to python.
schrockn committed R1:84b41e7143b0: bug fix (authored by Leor <leor.fishman@gmail.com>).
bug fix
schrockn commandeered D3744: bug fix.
schrockn committed R1:8a5806254ee7: (kubernetes-testability-4) More tests. %100 code coverage for… (authored by schrockn).
(kubernetes-testability-4) More tests. %100 code coverage for…
schrockn added inline comments to D3737: (kubernetes-testability-4) More tests. %100 code coverage for wait_for_job_success.
schrockn committed R1:e30b3da6e9ac: (kubernetes-testability-3) Mock out wait_job_for_success. Found bug with first… (authored by schrockn).
(kubernetes-testability-3) Mock out wait_job_for_success. Found bug with first…
schrockn committed R1:bd16016179a9: (kubernetes-testability-2) Split out unit tests and integration tests (authored by schrockn).
(kubernetes-testability-2) Split out unit tests and integration tests
schrockn committed R1:b2e08b019bea: (kubernetes-testability-1) Create DagsterKubernetesClient (authored by schrockn).
(kubernetes-testability-1) Create DagsterKubernetesClient
schrockn added a comment to D3715: (kubernetes-testability-1) Create DagsterKubernetesClient.
Yeah for these "moving stuff around diffs" generally doing zero code changes best practice. Bug fixes and code changes always done in subsequent diffs
schrockn updated the diff for D3737: (kubernetes-testability-4) More tests. %100 code coverage for wait_for_job_success.
up
schrockn updated the diff for D3737: (kubernetes-testability-4) More tests. %100 code coverage for wait_for_job_success.
up
schrockn requested changes to D3670: Remove ability to load modules resolved by the working directory.
schrockn updated the diff for D3727: (kubernetes-testability-2) Split out unit tests and integration tests.
rebase
schrockn updated the diff for D3715: (kubernetes-testability-1) Create DagsterKubernetesClient.
rebase
Wed, Jul 1
Wed, Jul 1
schrockn updated the diff for D3727: (kubernetes-testability-2) Split out unit tests and integration tests.
up
schrockn updated the diff for D3727: (kubernetes-testability-2) Split out unit tests and integration tests.
up
schrockn updated the diff for D3727: (kubernetes-testability-2) Split out unit tests and integration tests.
up
schrockn updated the diff for D3715: (kubernetes-testability-1) Create DagsterKubernetesClient.
up
schrockn added inline comments to D3670: Remove ability to load modules resolved by the working directory.
schrockn committed R1:2176538542fe: Actually use docker images during test image build. Use pex for aws cli tool. (authored by schrockn).
Actually use docker images during test image build. Use pex for aws cli tool.
schrockn requested review of D3727: (kubernetes-testability-2) Split out unit tests and integration tests.
schrockn updated the diff for D3715: (kubernetes-testability-1) Create DagsterKubernetesClient.
up
schrockn added a comment to D3670: Remove ability to load modules resolved by the working directory.
i'm a bit confused by this
no consolidation necessary
schrockn updated the diff for D3723: Actually use docker images during test image build. Use pex for aws cli tool..
up
schrockn updated the diff for D3723: Actually use docker images during test image build. Use pex for aws cli tool..
up
schrockn updated the diff for D3723: Actually use docker images during test image build. Use pex for aws cli tool..
up
schrockn updated the diff for D3715: (kubernetes-testability-1) Create DagsterKubernetesClient.
up
schrockn requested changes to D3714: rename input_hydration_config and output_materialization_config.
CHANGES.md and any relavant docs changes plz
schrockn requested review of D3715: (kubernetes-testability-1) Create DagsterKubernetesClient.
schrockn committed R1:42640d80bfba: (build-image-improvement-2) Add slimmer bootstrap test builder image for faster… (authored by schrockn).
(build-image-improvement-2) Add slimmer bootstrap test builder image for faster…
schrockn committed R1:c23ce4f3f2cb: (build-image-improvement-1) Move docker to integration (authored by schrockn).
(build-image-improvement-1) Move docker to integration
schrockn updated the diff for D3717: (build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds.
up
schrockn added inline comments to D3717: (build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds.
schrockn added a comment to D3717: (build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds.
before:
schrockn updated the diff for D3717: (build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds.
up
schrockn updated the diff for D3716: (build-image-improvement-1) Move docker to integration.
up
schrockn requested review of D3716: (build-image-improvement-1) Move docker to integration.
Tue, Jun 30
Tue, Jun 30
schrockn added a comment to D3703: GE demo.
the demo should not live in the production module. i suggest making it an an example in examples
schrockn committed R1:7042cf400f29: (celery-k8s-refactor-3.5) Changelog and minimal docs for dagster-celery refactor (authored by schrockn).
(celery-k8s-refactor-3.5) Changelog and minimal docs for dagster-celery refactor
schrockn committed R1:4ddc294a9f8e: (celery-k8s-refactor-3.4) Move celery_docker_executor into dagster-celery-docker (authored by schrockn).
(celery-k8s-refactor-3.4) Move celery_docker_executor into dagster-celery-docker
schrockn committed R1:4867b1fdd46a: (celery-k8s-refactor-3.3) Add dagster-celery-docker scaffold (authored by schrockn).
(celery-k8s-refactor-3.3) Add dagster-celery-docker scaffold
schrockn committed R1:6b8532d3ca4d: (celery-k8s-refactor-3.2) Move celery_k8s_job_executor to dagster_celery_k8s (authored by schrockn).
(celery-k8s-refactor-3.2) Move celery_k8s_job_executor to dagster_celery_k8s
schrockn committed R1:09250f4ba11d: (celery-k8s-refactor-3.1) Move CeleryK8sRunLauncher to dagster_celery_k8s (authored by schrockn).
(celery-k8s-refactor-3.1) Move CeleryK8sRunLauncher to dagster_celery_k8s
schrockn updated the diff for D3680: (celery-k8s-refactor-3.1) Move CeleryK8sRunLauncher to dagster_celery_k8s.
up
schrockn updated the diff for D3684: (celery-k8s-refactor-3.4) Move celery_docker_executor into dagster-celery-docker.
rebase
schrockn updated the diff for D3683: (celery-k8s-refactor-3.3) Add dagster-celery-docker scaffold.
rebase
schrockn updated the diff for D3681: (celery-k8s-refactor-3.2) Move celery_k8s_job_executor to dagster_celery_k8s.
rebase
schrockn updated the diff for D3680: (celery-k8s-refactor-3.1) Move CeleryK8sRunLauncher to dagster_celery_k8s.
up
schrockn committed R1:27dcf9371f2f: (celery-k8s-refactor-3) Move app to dagster_celery_k8s (authored by schrockn).
(celery-k8s-refactor-3) Move app to dagster_celery_k8s
schrockn committed R1:466f5a36d958: (celery-k8s-refactor-2) Separate global app and task instances into own file (authored by schrockn).
(celery-k8s-refactor-2) Separate global app and task instances into own file
schrockn added a comment to D3704: Wrap ts, tsx files at 100 characters for better readability.
yeah don't ask me why it exists because i have no explanation for it
schrockn updated the diff for D3684: (celery-k8s-refactor-3.4) Move celery_docker_executor into dagster-celery-docker.
rebase
schrockn updated the diff for D3683: (celery-k8s-refactor-3.3) Add dagster-celery-docker scaffold.
rebase
schrockn updated the diff for D3681: (celery-k8s-refactor-3.2) Move celery_k8s_job_executor to dagster_celery_k8s.
up
schrockn updated the diff for D3673: (celery-k8s-refactor-3) Move app to dagster_celery_k8s.
up
this is great.
schrockn accepted D3703: GE demo.
k looks good. plz change the tag name before commit. thanks!