Page MenuHomePhabricator

schrockn (Nick Schrock)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Mar 20 2019, 8:23 PM (67 w, 1 d)
Roles
Administrator

Recent Activity

Today

schrockn committed R1:9bee8c88a12a: Fix install order in root Makefile (authored by schrockn).
Fix install order in root Makefile
Fri, Jul 3, 3:17 PM
schrockn closed D3754: Fix install order in root Makefile.
Fri, Jul 3, 3:17 PM
schrockn updated the diff for D3754: Fix install order in root Makefile.

up

Fri, Jul 3, 3:03 PM
schrockn updated the diff for D3752: Port build and push scripts to python.

up

Fri, Jul 3, 2:48 PM
schrockn requested review of D3754: Fix install order in root Makefile.
Fri, Jul 3, 1:26 PM

Yesterday

schrockn added a comment to D3670: Remove ability to load modules resolved by the working directory.

do we have a test for python_package?

Thu, Jul 2, 11:59 PM
schrockn added inline comments to D3670: Remove ability to load modules resolved by the working directory.
Thu, Jul 2, 11:08 PM
schrockn updated the diff for D3752: Port build and push scripts to python.

up

Thu, Jul 2, 11:03 PM
schrockn requested review of D3752: Port build and push scripts to python.
Thu, Jul 2, 10:52 PM
schrockn committed R1:84b41e7143b0: bug fix (authored by Leor <leor.fishman@gmail.com>).
bug fix
Thu, Jul 2, 7:21 PM
schrockn closed D3744: bug fix.
Thu, Jul 2, 7:21 PM
schrockn commandeered D3744: bug fix.
Thu, Jul 2, 7:20 PM
schrockn committed R1:8a5806254ee7: (kubernetes-testability-4) More tests. %100 code coverage for… (authored by schrockn).
(kubernetes-testability-4) More tests. %100 code coverage for…
Thu, Jul 2, 7:19 PM
schrockn closed D3737: (kubernetes-testability-4) More tests. %100 code coverage for wait_for_job_success.
Thu, Jul 2, 7:18 PM
schrockn added inline comments to D3737: (kubernetes-testability-4) More tests. %100 code coverage for wait_for_job_success.
Thu, Jul 2, 7:18 PM
schrockn committed R1:e30b3da6e9ac: (kubernetes-testability-3) Mock out wait_job_for_success. Found bug with first… (authored by schrockn).
(kubernetes-testability-3) Mock out wait_job_for_success. Found bug with first…
Thu, Jul 2, 7:17 PM
schrockn closed D3736: (kubernetes-testability-3) Mock out wait_job_for_success. Found bug with first test.
Thu, Jul 2, 7:17 PM
schrockn closed D3727: (kubernetes-testability-2) Split out unit tests and integration tests.
Thu, Jul 2, 7:16 PM
schrockn committed R1:bd16016179a9: (kubernetes-testability-2) Split out unit tests and integration tests (authored by schrockn).
(kubernetes-testability-2) Split out unit tests and integration tests
Thu, Jul 2, 7:16 PM
schrockn committed R1:b2e08b019bea: (kubernetes-testability-1) Create DagsterKubernetesClient (authored by schrockn).
(kubernetes-testability-1) Create DagsterKubernetesClient
Thu, Jul 2, 7:16 PM
schrockn closed D3715: (kubernetes-testability-1) Create DagsterKubernetesClient.
Thu, Jul 2, 7:16 PM
schrockn accepted D3731: eliminate hydration/materialization warnings for basic run.
Thu, Jul 2, 6:57 PM
schrockn added a comment to D3715: (kubernetes-testability-1) Create DagsterKubernetesClient.

Yeah for these "moving stuff around diffs" generally doing zero code changes best practice. Bug fixes and code changes always done in subsequent diffs

Thu, Jul 2, 4:35 PM
schrockn updated the diff for D3737: (kubernetes-testability-4) More tests. %100 code coverage for wait_for_job_success.

up

Thu, Jul 2, 3:13 PM
schrockn updated the diff for D3737: (kubernetes-testability-4) More tests. %100 code coverage for wait_for_job_success.

up

Thu, Jul 2, 3:07 PM
schrockn updated the diff for D2155: Warm the BK cluster.

up

Thu, Jul 2, 1:24 PM
schrockn requested changes to D3670: Remove ability to load modules resolved by the working directory.
Thu, Jul 2, 1:12 PM
schrockn accepted D3724: rename input hydration and output materialization in docs.

thumbsup

Thu, Jul 2, 1:07 PM
schrockn requested review of D3736: (kubernetes-testability-3) Mock out wait_job_for_success. Found bug with first test.
Thu, Jul 2, 12:50 AM
schrockn requested review of D3737: (kubernetes-testability-4) More tests. %100 code coverage for wait_for_job_success.
Thu, Jul 2, 12:48 AM
schrockn updated the diff for D3727: (kubernetes-testability-2) Split out unit tests and integration tests.

rebase

Thu, Jul 2, 12:32 AM
schrockn updated the diff for D3715: (kubernetes-testability-1) Create DagsterKubernetesClient.

rebase

Thu, Jul 2, 12:31 AM
schrockn abandoned D3726: Revert "(build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds".
Thu, Jul 2, 12:21 AM

Wed, Jul 1

schrockn updated the diff for D3727: (kubernetes-testability-2) Split out unit tests and integration tests.

up

Wed, Jul 1, 11:45 PM
schrockn updated the diff for D3727: (kubernetes-testability-2) Split out unit tests and integration tests.

up

Wed, Jul 1, 11:39 PM
schrockn updated the diff for D3727: (kubernetes-testability-2) Split out unit tests and integration tests.

up

Wed, Jul 1, 11:32 PM
schrockn updated the diff for D3715: (kubernetes-testability-1) Create DagsterKubernetesClient.

up

Wed, Jul 1, 11:25 PM
schrockn added inline comments to D3670: Remove ability to load modules resolved by the working directory.
Wed, Jul 1, 11:23 PM
schrockn committed R1:2176538542fe: Actually use docker images during test image build. Use pex for aws cli tool. (authored by schrockn).
Actually use docker images during test image build. Use pex for aws cli tool.
Wed, Jul 1, 11:19 PM
schrockn closed D3723: Actually use docker images during test image build. Use pex for aws cli tool..
Wed, Jul 1, 11:19 PM
schrockn accepted D3721: remove references to InputHydrationConfig and OutputMaterializationConfig.
Wed, Jul 1, 11:19 PM
schrockn requested review of D3727: (kubernetes-testability-2) Split out unit tests and integration tests.
Wed, Jul 1, 9:28 PM
schrockn updated the diff for D3715: (kubernetes-testability-1) Create DagsterKubernetesClient.

up

Wed, Jul 1, 8:47 PM
schrockn added a comment to D3670: Remove ability to load modules resolved by the working directory.

i'm a bit confused by this

Wed, Jul 1, 8:42 PM
schrockn accepted D3714: rename input_hydration_config and output_materialization_config.

no consolidation necessary

Wed, Jul 1, 8:40 PM
schrockn updated the diff for D3723: Actually use docker images during test image build. Use pex for aws cli tool..

up

Wed, Jul 1, 8:34 PM
schrockn updated the diff for D3723: Actually use docker images during test image build. Use pex for aws cli tool..

up

Wed, Jul 1, 8:32 PM
schrockn updated the diff for D3723: Actually use docker images during test image build. Use pex for aws cli tool..

up

Wed, Jul 1, 8:31 PM
schrockn requested review of D3723: Actually use docker images during test image build. Use pex for aws cli tool..
Wed, Jul 1, 7:54 PM
schrockn requested review of D3726: Revert "(build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds".
Wed, Jul 1, 7:29 PM
schrockn added a reverting change for R1:42640d80bfba: (build-image-improvement-2) Add slimmer bootstrap test builder image for faster…: D3726: Revert "(build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds".
Wed, Jul 1, 7:17 PM
schrockn added a reverting change for D3717: (build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds: D3726: Revert "(build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds".
Wed, Jul 1, 7:17 PM
schrockn updated the diff for D3715: (kubernetes-testability-1) Create DagsterKubernetesClient.

up

Wed, Jul 1, 7:04 PM
schrockn requested changes to D3714: rename input_hydration_config and output_materialization_config.

CHANGES.md and any relavant docs changes plz

Wed, Jul 1, 6:52 PM
schrockn requested review of D3715: (kubernetes-testability-1) Create DagsterKubernetesClient.
Wed, Jul 1, 6:19 PM
schrockn committed R1:42640d80bfba: (build-image-improvement-2) Add slimmer bootstrap test builder image for faster… (authored by schrockn).
(build-image-improvement-2) Add slimmer bootstrap test builder image for faster…
Wed, Jul 1, 4:50 PM
schrockn closed D3717: (build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds.
Wed, Jul 1, 4:50 PM
schrockn committed R1:c23ce4f3f2cb: (build-image-improvement-1) Move docker to integration (authored by schrockn).
(build-image-improvement-1) Move docker to integration
Wed, Jul 1, 4:49 PM
schrockn closed D3716: (build-image-improvement-1) Move docker to integration.
Wed, Jul 1, 4:48 PM
schrockn updated the diff for D3717: (build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds.

up

Wed, Jul 1, 2:54 PM
schrockn added inline comments to D3717: (build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds.
Wed, Jul 1, 2:50 PM
schrockn updated the summary of D3717: (build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds.
Wed, Jul 1, 2:37 PM
schrockn added a comment to D3717: (build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds.

before:

Wed, Jul 1, 2:37 PM
schrockn updated the diff for D3717: (build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds.

up

Wed, Jul 1, 2:28 PM
schrockn requested review of D3717: (build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds.
Wed, Jul 1, 2:21 PM
schrockn updated the diff for D3716: (build-image-improvement-1) Move docker to integration.

up

Wed, Jul 1, 2:16 PM
schrockn updated the diff for D2155: Warm the BK cluster.

up

Wed, Jul 1, 2:08 PM
schrockn requested changes to D3154: configured.

Actually one more thing:

Wed, Jul 1, 1:33 PM
schrockn accepted D3154: configured.

most excellent

Wed, Jul 1, 1:33 PM
schrockn requested review of D3716: (build-image-improvement-1) Move docker to integration.
Wed, Jul 1, 1:10 PM

Tue, Jun 30

schrockn accepted D3710: cleanup docker-compose in pre-exit.

yaytests

Tue, Jun 30, 10:51 PM
schrockn added a comment to D3703: GE demo.

the demo should not live in the production module. i suggest making it an an example in examples

Tue, Jun 30, 10:11 PM
schrockn committed R1:7042cf400f29: (celery-k8s-refactor-3.5) Changelog and minimal docs for dagster-celery refactor (authored by schrockn).
(celery-k8s-refactor-3.5) Changelog and minimal docs for dagster-celery refactor
Tue, Jun 30, 9:49 PM
schrockn closed D3685: (celery-k8s-refactor-3.5) Changelog and minimal docs for dagster-celery refactor.
Tue, Jun 30, 9:49 PM
schrockn committed R1:4ddc294a9f8e: (celery-k8s-refactor-3.4) Move celery_docker_executor into dagster-celery-docker (authored by schrockn).
(celery-k8s-refactor-3.4) Move celery_docker_executor into dagster-celery-docker
Tue, Jun 30, 9:49 PM
schrockn closed D3684: (celery-k8s-refactor-3.4) Move celery_docker_executor into dagster-celery-docker.
Tue, Jun 30, 9:49 PM
schrockn committed R1:4867b1fdd46a: (celery-k8s-refactor-3.3) Add dagster-celery-docker scaffold (authored by schrockn).
(celery-k8s-refactor-3.3) Add dagster-celery-docker scaffold
Tue, Jun 30, 9:48 PM
schrockn closed D3683: (celery-k8s-refactor-3.3) Add dagster-celery-docker scaffold.
Tue, Jun 30, 9:48 PM
schrockn committed R1:6b8532d3ca4d: (celery-k8s-refactor-3.2) Move celery_k8s_job_executor to dagster_celery_k8s (authored by schrockn).
(celery-k8s-refactor-3.2) Move celery_k8s_job_executor to dagster_celery_k8s
Tue, Jun 30, 9:47 PM
schrockn closed D3681: (celery-k8s-refactor-3.2) Move celery_k8s_job_executor to dagster_celery_k8s.
Tue, Jun 30, 9:47 PM
schrockn committed R1:09250f4ba11d: (celery-k8s-refactor-3.1) Move CeleryK8sRunLauncher to dagster_celery_k8s (authored by schrockn).
(celery-k8s-refactor-3.1) Move CeleryK8sRunLauncher to dagster_celery_k8s
Tue, Jun 30, 9:47 PM
schrockn closed D3680: (celery-k8s-refactor-3.1) Move CeleryK8sRunLauncher to dagster_celery_k8s.
Tue, Jun 30, 9:47 PM
schrockn updated the diff for D3680: (celery-k8s-refactor-3.1) Move CeleryK8sRunLauncher to dagster_celery_k8s.

up

Tue, Jun 30, 9:31 PM
schrockn updated the diff for D3684: (celery-k8s-refactor-3.4) Move celery_docker_executor into dagster-celery-docker.

rebase

Tue, Jun 30, 9:18 PM
schrockn updated the diff for D3683: (celery-k8s-refactor-3.3) Add dagster-celery-docker scaffold.

rebase

Tue, Jun 30, 9:17 PM
schrockn updated the diff for D3681: (celery-k8s-refactor-3.2) Move celery_k8s_job_executor to dagster_celery_k8s.

rebase

Tue, Jun 30, 9:16 PM
schrockn updated the diff for D3680: (celery-k8s-refactor-3.1) Move CeleryK8sRunLauncher to dagster_celery_k8s.

up

Tue, Jun 30, 9:14 PM
schrockn committed R1:27dcf9371f2f: (celery-k8s-refactor-3) Move app to dagster_celery_k8s (authored by schrockn).
(celery-k8s-refactor-3) Move app to dagster_celery_k8s
Tue, Jun 30, 9:09 PM
schrockn closed D3673: (celery-k8s-refactor-3) Move app to dagster_celery_k8s.
Tue, Jun 30, 9:09 PM
schrockn committed R1:466f5a36d958: (celery-k8s-refactor-2) Separate global app and task instances into own file (authored by schrockn).
(celery-k8s-refactor-2) Separate global app and task instances into own file
Tue, Jun 30, 9:08 PM
schrockn closed D3646: (celery-k8s-refactor-2) Separate global app and task instances into own file.
Tue, Jun 30, 9:08 PM
schrockn requested review of D3685: (celery-k8s-refactor-3.5) Changelog and minimal docs for dagster-celery refactor.
Tue, Jun 30, 8:48 PM
schrockn added a comment to D3704: Wrap ts, tsx files at 100 characters for better readability.

yeah don't ask me why it exists because i have no explanation for it

Tue, Jun 30, 8:46 PM
schrockn updated the diff for D3684: (celery-k8s-refactor-3.4) Move celery_docker_executor into dagster-celery-docker.

rebase

Tue, Jun 30, 8:32 PM
schrockn updated the diff for D3683: (celery-k8s-refactor-3.3) Add dagster-celery-docker scaffold.

rebase

Tue, Jun 30, 8:31 PM
schrockn updated the diff for D3681: (celery-k8s-refactor-3.2) Move celery_k8s_job_executor to dagster_celery_k8s.

up

Tue, Jun 30, 8:28 PM
schrockn updated the diff for D3673: (celery-k8s-refactor-3) Move app to dagster_celery_k8s.

up

Tue, Jun 30, 8:20 PM
schrockn accepted D3704: Wrap ts, tsx files at 100 characters for better readability.

didntread

Tue, Jun 30, 8:18 PM
schrockn accepted D3699: wean the airline demo from the system storage file manager.

this is great.

Tue, Jun 30, 8:17 PM
schrockn accepted D3703: GE demo.

k looks good. plz change the tag name before commit. thanks!

Tue, Jun 30, 8:12 PM