Page MenuHomePhabricator

schrockn (Nick Schrock)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Mar 20 2019, 8:23 PM (29 w, 5 d)
Roles
Administrator

Recent Activity

Yesterday

schrockn updated the diff for D1282: Minor improvements to phw demo.

upmessage

Mon, Oct 14, 8:16 PM
schrockn created D1282: Minor improvements to phw demo.
Mon, Oct 14, 8:14 PM

Sat, Oct 12

schrockn committed R1:2d05434f9c50: Make dagster examples work in aws out-of-the-box (authored by schrockn).
Make dagster examples work in aws out-of-the-box
Sat, Oct 12, 9:40 PM
schrockn closed D1275: Make dagster examples work in aws out-of-the-box.
Sat, Oct 12, 9:39 PM
schrockn created Image Macro "thereifixedit".
Sat, Oct 12, 9:12 PM
schrockn updated the diff for D1275: Make dagster examples work in aws out-of-the-box.

up

Sat, Oct 12, 9:12 PM
schrockn created D1275: Make dagster examples work in aws out-of-the-box.
Sat, Oct 12, 7:37 PM
schrockn created D1274: fix output materializations for composite solids.
Sat, Oct 12, 6:50 PM
schrockn requested changes to D1273: Improve type inference.

major point of discussion around the nonce

Sat, Oct 12, 12:35 AM
schrockn requested changes to D1270: Rename execution_epoch_time.

we should hold off on this until @sashank makes forward progress with the date-time partitioning next week (tied to the scheduler). i think "Execution time" sounds like the time that the computation is occuring. I.e. if the computation were happening on oct-1 but processing the data from sept 15, I would guess that "Execution time" means oct 1, which is the opposite of this as I understand it.

Sat, Oct 12, 12:26 AM

Fri, Oct 11

schrockn committed R1:a3a576ce8d41: Fix infinite recursion in inst_data property of SQLite run storage (authored by schrockn).
Fix infinite recursion in inst_data property of SQLite run storage
Fri, Oct 11, 10:06 PM
schrockn closed D1271: Fix infinite recursion in inst_data property of SQLite run storage.
Fri, Oct 11, 10:06 PM
schrockn created D1271: Fix infinite recursion in inst_data property of SQLite run storage.
Fri, Oct 11, 9:56 PM
schrockn accepted D1269: Fix Spark configs duplication (#1823).
Fri, Oct 11, 9:11 PM
schrockn accepted D1266: allow composites in execute_solid.

would prefer to see startswith shenanigans go away

Fri, Oct 11, 8:32 PM
schrockn requested changes to D1266: allow composites in execute_solid.

this is much less invasive than anticipated 👏🏻👏🏻👏🏻

Fri, Oct 11, 7:58 PM
schrockn abandoned D1251: [RFC] Alias Builder.

with your new stuff I don't think this is necessary

Fri, Oct 11, 7:56 PM
schrockn accepted D1261: [core] autoalias in composition functions.

Macro winclap:

Fri, Oct 11, 7:55 PM
schrockn committed R1:1f6eeccc6c4d: Make construction of ConfigurableClass-derived classes less error prone (authored by schrockn).
Make construction of ConfigurableClass-derived classes less error prone
Fri, Oct 11, 5:50 PM
schrockn closed D1265: Make construction of ConfigurableClass-derived classes less error prone.
Fri, Oct 11, 5:50 PM
schrockn requested changes to D1266: allow composites in execute_solid.

use diff approach per in-person convo

Fri, Oct 11, 5:49 PM
schrockn requested changes to D1261: [core] autoalias in composition functions.

this is pretty great. i just think we can just go for it and get rid of bool flag

Fri, Oct 11, 12:30 AM
schrockn added a comment to D1261: [core] autoalias in composition functions.

opt-in bool just because it's experimental? seems like we want this or we don't.

Fri, Oct 11, 12:29 AM
schrockn requested changes to D1242: RFC: Add dagster schedule wipe command.

looks good but some tests would be good

Fri, Oct 11, 12:27 AM
schrockn committed R1:6e228604d9ba: Rename PySpark Dataframe and use dense config for join (authored by schrockn).
Rename PySpark Dataframe and use dense config for join
Fri, Oct 11, 12:25 AM
schrockn closed D1250: Rename PySpark Dataframe and use dense config for join.
Fri, Oct 11, 12:25 AM

Thu, Oct 10

schrockn updated the diff for D1265: Make construction of ConfigurableClass-derived classes less error prone.

up

Thu, Oct 10, 11:21 PM
schrockn created D1265: Make construction of ConfigurableClass-derived classes less error prone.
Thu, Oct 10, 11:21 PM
schrockn committed R1:233ddb4294bc: Actually fill in string template in many events pipeline (authored by schrockn).
Actually fill in string template in many events pipeline
Thu, Oct 10, 10:58 PM
schrockn closed D1264: Actually fill in string template in many events pipeline.
Thu, Oct 10, 10:58 PM
schrockn created D1264: Actually fill in string template in many events pipeline.
Thu, Oct 10, 10:09 PM

Wed, Oct 9

schrockn added a comment to D1260: Add css ellipsis for run pipeline name.

can you post screenshot?

Wed, Oct 9, 11:31 PM
schrockn accepted D1256: [take 2] capture_dauphin_error returns PythonError.

thx my b.

Wed, Oct 9, 10:20 PM
schrockn added a reverting change for D1232: [RFC] capture_dauphin_error returns PythonError: R1:5f8541a1c4b6: Revert "[RFC] capture_dauphin_error returns PythonError".
Wed, Oct 9, 5:25 PM
schrockn added a reverting change for R1:65503e06f77d: [RFC] capture_dauphin_error returns PythonError: R1:5f8541a1c4b6: Revert "[RFC] capture_dauphin_error returns PythonError".
Wed, Oct 9, 5:25 PM
schrockn committed R1:5f8541a1c4b6: Revert "[RFC] capture_dauphin_error returns PythonError" (authored by schrockn).
Revert "[RFC] capture_dauphin_error returns PythonError"
Wed, Oct 9, 5:25 PM
schrockn closed D1249: Revert "[RFC] capture_dauphin_error returns PythonError".
Wed, Oct 9, 5:25 PM
schrockn added a reverting change for D1216: Consolidate split panel handling, save divider locations to local storage: R1:c77468e64ff2: Revert "Consolidate split panel handling, save divider locations to local….
Wed, Oct 9, 5:24 PM
schrockn added a reverting change for R1:ef23ea3c3aa8: Consolidate split panel handling, save divider locations to local storage: R1:c77468e64ff2: Revert "Consolidate split panel handling, save divider locations to local….
Wed, Oct 9, 5:24 PM
schrockn committed R1:c77468e64ff2: Revert "Consolidate split panel handling, save divider locations to local… (authored by schrockn).
Revert "Consolidate split panel handling, save divider locations to local…
Wed, Oct 9, 5:24 PM
schrockn closed D1248: Revert "Consolidate split panel handling, save divider locations to local storage".
Wed, Oct 9, 5:24 PM
schrockn updated the summary of D1248: Revert "Consolidate split panel handling, save divider locations to local storage".
Wed, Oct 9, 5:23 PM
schrockn updated the diff for D1251: [RFC] Alias Builder.

upmessage

Wed, Oct 9, 4:35 AM
schrockn updated the diff for D1251: [RFC] Alias Builder.

up

Wed, Oct 9, 4:33 AM
schrockn created D1251: [RFC] Alias Builder.
Wed, Oct 9, 4:33 AM
schrockn created D1250: Rename PySpark Dataframe and use dense config for join.
Wed, Oct 9, 4:29 AM
schrockn added a reverting change for D1232: [RFC] capture_dauphin_error returns PythonError: D1249: Revert "[RFC] capture_dauphin_error returns PythonError".
Wed, Oct 9, 4:01 AM
schrockn added a reverting change for R1:65503e06f77d: [RFC] capture_dauphin_error returns PythonError: D1249: Revert "[RFC] capture_dauphin_error returns PythonError".
Wed, Oct 9, 4:01 AM
schrockn created D1249: Revert "[RFC] capture_dauphin_error returns PythonError".
Wed, Oct 9, 4:01 AM
schrockn added a comment to D1248: Revert "Consolidate split panel handling, save divider locations to local storage".

This is what happens on the runs page on master right now

Wed, Oct 9, 3:51 AM
schrockn added a reverting change for R1:ef23ea3c3aa8: Consolidate split panel handling, save divider locations to local storage: D1248: Revert "Consolidate split panel handling, save divider locations to local storage".
Wed, Oct 9, 3:50 AM
schrockn added a reverting change for D1216: Consolidate split panel handling, save divider locations to local storage: D1248: Revert "Consolidate split panel handling, save divider locations to local storage".
Wed, Oct 9, 3:50 AM
schrockn created D1248: Revert "Consolidate split panel handling, save divider locations to local storage".
Wed, Oct 9, 3:50 AM

Tue, Oct 8

schrockn accepted D1244: Reenable disabled examples.
Tue, Oct 8, 12:22 AM

Mon, Oct 7

schrockn committed R1:4bd21bd70abb: Default to none for environment_dict in ScheduleDefinition (authored by schrockn).
Default to none for environment_dict in ScheduleDefinition
Mon, Oct 7, 10:57 PM
schrockn closed D1240: Default to none for environment_dict in ScheduleDefinition.
Mon, Oct 7, 10:56 PM
schrockn updated the diff for D1240: Default to none for environment_dict in ScheduleDefinition.

up

Mon, Oct 7, 10:27 PM
schrockn updated the diff for D1240: Default to none for environment_dict in ScheduleDefinition.

up

Mon, Oct 7, 9:20 PM
schrockn created D1240: Default to none for environment_dict in ScheduleDefinition.
Mon, Oct 7, 9:19 PM
schrockn accepted D1239: Fixes for dbt/werkzeug version conflict.

Would love to see jaffle test working with this in follow on diff.

Mon, Oct 7, 8:37 PM
schrockn accepted D1232: [RFC] capture_dauphin_error returns PythonError.

very nice

Mon, Oct 7, 6:00 PM
schrockn accepted D1234: Display most recent run in scheduler UI.

our first off-by-one error!

Mon, Oct 7, 5:37 PM

Sun, Oct 6

schrockn abandoned D1156: Remove -qqq from dev install script.
Sun, Oct 6, 4:46 PM
schrockn added a comment to D1226: Fix schedule --start-all command.

Can you also add that this fixes this issue in the release notes for 0.6.1?

Sun, Oct 6, 4:46 PM
schrockn accepted D1229: [docs] Remove more --no-watch from docs.
Sun, Oct 6, 4:43 PM
schrockn accepted D1230: Fix issue with public images (#1814).
Sun, Oct 6, 4:43 PM
schrockn committed R1:aa1490e8c61d: Use correct config for hourly-scheduled pandas_hello_world (authored by schrockn).
Use correct config for hourly-scheduled pandas_hello_world
Sun, Oct 6, 4:42 PM
schrockn closed D1218: Use correct config for hourly-scheduled pandas_hello_world.
Sun, Oct 6, 4:42 PM

Fri, Oct 4

schrockn accepted D1224: [Makefile] Add install target which pip installs in verbose mode.
Fri, Oct 4, 11:09 PM
schrockn created D1218: Use correct config for hourly-scheduled pandas_hello_world.
Fri, Oct 4, 7:47 PM
schrockn accepted D1214: [input mapping] fix input reuse.
Fri, Oct 4, 4:59 PM
schrockn accepted D1213: turn coverage back on.
Fri, Oct 4, 4:23 PM
schrockn committed R1:9ac40d7a6def: Fix requirements.txt and comment out problematic pipelines to get… (authored by schrockn).
Fix requirements.txt and comment out problematic pipelines to get…
Fri, Oct 4, 2:25 PM
schrockn closed D1212: Fix requirements.txt and comment out problematic pipelines to get dagster/examples working against public modules.
Fri, Oct 4, 2:25 PM
schrockn retitled D1212: Fix requirements.txt and comment out problematic pipelines to get dagster/examples working against public modules from Fix requirements and comment out problematic pipelines to Fix requirements.txt and comment out problematic pipelines to get dagster/examples working against public modules.
Fri, Oct 4, 1:41 AM
schrockn created D1212: Fix requirements.txt and comment out problematic pipelines to get dagster/examples working against public modules.
Fri, Oct 4, 1:37 AM
schrockn accepted D1208: Disable pipenv tests for releases.

you can be so clever with buildkite

Fri, Oct 4, 12:20 AM
schrockn accepted D1206: Update deployment docs.
Fri, Oct 4, 12:17 AM
schrockn accepted D1207: Add scheduler docs.

good stuff. a couple minor edits

Fri, Oct 4, 12:08 AM

Thu, Oct 3

schrockn committed R1:32c0a1b88dda: Loosen dep of pandas from dagster-pandas (authored by schrockn).
Loosen dep of pandas from dagster-pandas
Thu, Oct 3, 11:49 PM
schrockn closed D1205: Loosen dep of pandas from dagster-pandas.
Thu, Oct 3, 11:49 PM
schrockn updated the diff for D1205: Loosen dep of pandas from dagster-pandas.

up

Thu, Oct 3, 11:43 PM
schrockn created D1205: Loosen dep of pandas from dagster-pandas.
Thu, Oct 3, 11:42 PM
schrockn accepted D1204: Update ScheduleDefinition API.

cool

Thu, Oct 3, 11:36 PM
schrockn accepted D1196: [dagster-aws] Only install dagster/dagit during dagster-aws up w/ requirements.txt parsing.

verygood

Thu, Oct 3, 11:05 PM
schrockn added a comment to D1204: Update ScheduleDefinition API.

this is better

Thu, Oct 3, 10:51 PM
schrockn requested changes to D1196: [dagster-aws] Only install dagster/dagit during dagster-aws up w/ requirements.txt parsing.
Thu, Oct 3, 10:30 PM
schrockn accepted D1196: [dagster-aws] Only install dagster/dagit during dagster-aws up w/ requirements.txt parsing.

seems reasonable

Thu, Oct 3, 10:29 PM
schrockn requested changes to D1196: [dagster-aws] Only install dagster/dagit during dagster-aws up w/ requirements.txt parsing.

yeah let's not mutate requirements.txt

Thu, Oct 3, 10:22 PM
schrockn accepted D1203: [dagster-aws] Fix CLI.
Thu, Oct 3, 10:17 PM
schrockn added inline comments to D1202: release notes updates.
Thu, Oct 3, 9:57 PM
schrockn accepted D1202: release notes updates.
Thu, Oct 3, 9:35 PM
schrockn accepted D1201: Fix lint error in RunTable.
Thu, Oct 3, 9:23 PM
schrockn committed R1:651ee30d9f07: Remove __init__ methods in EventLogStorage and RunStorage abcs (authored by schrockn).
Remove __init__ methods in EventLogStorage and RunStorage abcs
Thu, Oct 3, 9:16 PM
schrockn closed D1200: Remove __init__ methods in EventLogStorage and RunStorage abcs.
Thu, Oct 3, 9:16 PM
schrockn accepted D1199: remove pin.
Thu, Oct 3, 9:08 PM
schrockn updated the diff for D1200: Remove __init__ methods in EventLogStorage and RunStorage abcs.

up

Thu, Oct 3, 9:07 PM
schrockn added a comment to D1200: Remove __init__ methods in EventLogStorage and RunStorage abcs.

yeah i started an issue to track https://github.com/dagster-io/dagster/issues/1804

Thu, Oct 3, 9:03 PM
schrockn updated the summary of D1200: Remove __init__ methods in EventLogStorage and RunStorage abcs.
Thu, Oct 3, 9:02 PM
schrockn created D1200: Remove __init__ methods in EventLogStorage and RunStorage abcs.
Thu, Oct 3, 9:00 PM