Page MenuHomePhabricator

sashank (Sashank Thupukari)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2019, 5:19 PM (39 w, 1 d)
Roles
Administrator

Recent Activity

Today

sashank committed R1:c0ec209f4108: Fix tests for intro tutorial (authored by sashank).
Fix tests for intro tutorial
Wed, Apr 8, 3:28 AM
sashank closed D2471: Fix tests for intro tutorial.
Wed, Apr 8, 3:28 AM
sashank planned changes to D2469: [RFC] Parallelize long running buildkite steps.

Hm the speedup isn't that significant when we run all the tests, but it does seem like at least 1 - 2 minute speedup. Doesn't feel like it's worth it. Will play around with this more

Wed, Apr 8, 3:15 AM
sashank added a reviewer for D2471: Fix tests for intro tutorial: nate.
Wed, Apr 8, 3:13 AM
sashank committed R1:728c0774443b: [docs] Move docs file conversion to process script (authored by sashank).
[docs] Move docs file conversion to process script
Wed, Apr 8, 3:12 AM
sashank closed D2462: [docs] Move docs file conversion to process script.
Wed, Apr 8, 3:12 AM
sashank committed R1:6301540b79bb: Render step execution times in longitudinal view (authored by sashank).
Render step execution times in longitudinal view
Wed, Apr 8, 3:12 AM
sashank closed D2404: Render step execution times in longitudinal view.
Wed, Apr 8, 3:12 AM
sashank updated the diff for D2469: [RFC] Parallelize long running buildkite steps.

tweaking some numbers

Wed, Apr 8, 3:09 AM
sashank retitled D2469: [RFC] Parallelize long running buildkite steps from Parallelize long running buildkite steps to [RFC] Parallelize long running buildkite steps.
Wed, Apr 8, 1:51 AM
sashank added inline comments to D2469: [RFC] Parallelize long running buildkite steps.
Wed, Apr 8, 1:50 AM
sashank retitled D2469: [RFC] Parallelize long running buildkite steps from Timing to Parallelize long running buildkite steps.
Wed, Apr 8, 1:50 AM
sashank updated the diff for D2469: [RFC] Parallelize long running buildkite steps.

rebase

Wed, Apr 8, 1:47 AM
sashank created D2471: Fix tests for intro tutorial.
Wed, Apr 8, 1:47 AM
sashank updated the diff for D2404: Render step execution times in longitudinal view.

Reset cursor if stepping up to a bigger page size

Wed, Apr 8, 1:30 AM
sashank updated the diff for D2404: Render step execution times in longitudinal view.

rebase

Wed, Apr 8, 12:40 AM
sashank updated the diff for D2469: [RFC] Parallelize long running buildkite steps.

cleanup

Wed, Apr 8, 12:36 AM
sashank updated the diff for D2469: [RFC] Parallelize long running buildkite steps.

turn down parallelism

Wed, Apr 8, 12:22 AM
sashank updated the diff for D2469: [RFC] Parallelize long running buildkite steps.

tox env syntax

Wed, Apr 8, 12:20 AM
sashank updated the diff for D2469: [RFC] Parallelize long running buildkite steps.

double quotes

Wed, Apr 8, 12:07 AM

Yesterday

sashank updated the diff for D2469: [RFC] Parallelize long running buildkite steps.

up

Tue, Apr 7, 11:59 PM
sashank updated the diff for D2469: [RFC] Parallelize long running buildkite steps.

up

Tue, Apr 7, 11:54 PM
sashank updated the diff for D2469: [RFC] Parallelize long running buildkite steps.

up

Tue, Apr 7, 11:44 PM
sashank committed R1:a57421c05a2b: Paginate longitudinal views (authored by sashank).
Paginate longitudinal views
Tue, Apr 7, 11:44 PM
sashank closed D2370: Paginate longitudinal views.
Tue, Apr 7, 11:44 PM
sashank updated the diff for D2370: Paginate longitudinal views.

rerun tests

Tue, Apr 7, 11:24 PM
sashank created D2469: [RFC] Parallelize long running buildkite steps.
Tue, Apr 7, 11:05 PM
sashank updated the diff for D2370: Paginate longitudinal views.

up

Tue, Apr 7, 11:04 PM
sashank updated the diff for D2370: Paginate longitudinal views.

mgql

Tue, Apr 7, 10:45 PM
sashank updated the diff for D2370: Paginate longitudinal views.

rebase

Tue, Apr 7, 10:33 PM
sashank committed R1:3b2ac45c1de0: Assert run order in run storage tests (authored by sashank).
Assert run order in run storage tests
Tue, Apr 7, 10:29 PM
sashank closed D2445: Assert run order in run storage tests.
Tue, Apr 7, 10:29 PM
sashank added inline comments to D2462: [docs] Move docs file conversion to process script.
Tue, Apr 7, 5:50 AM
sashank created D2462: [docs] Move docs file conversion to process script.
Tue, Apr 7, 5:46 AM
sashank committed R1:2f47ac17d364: [docs] Test nextjs build on buildkite (authored by sashank).
[docs] Test nextjs build on buildkite
Tue, Apr 7, 1:54 AM
sashank closed D2386: [docs] Test nextjs build on buildkite.
Tue, Apr 7, 1:54 AM
sashank added inline comments to D2386: [docs] Test nextjs build on buildkite.
Tue, Apr 7, 1:53 AM
sashank added a reviewer for D2386: [docs] Test nextjs build on buildkite: kevinrodriguez.
Tue, Apr 7, 1:48 AM
sashank updated the diff for D2386: [docs] Test nextjs build on buildkite.

up

Tue, Apr 7, 1:39 AM
sashank updated the diff for D2386: [docs] Test nextjs build on buildkite.

up

Tue, Apr 7, 1:33 AM
sashank updated the diff for D2386: [docs] Test nextjs build on buildkite.

up

Tue, Apr 7, 1:32 AM
sashank updated the diff for D2386: [docs] Test nextjs build on buildkite.

test

Tue, Apr 7, 1:28 AM
sashank updated the diff for D2386: [docs] Test nextjs build on buildkite.

Up

Tue, Apr 7, 1:07 AM

Mon, Apr 6

sashank added inline comments to D2386: [docs] Test nextjs build on buildkite.
Mon, Apr 6, 9:49 PM
sashank updated the diff for D2386: [docs] Test nextjs build on buildkite.

Up

Mon, Apr 6, 8:58 PM
sashank updated the diff for D2386: [docs] Test nextjs build on buildkite.

Up

Mon, Apr 6, 8:23 PM
sashank updated the diff for D2386: [docs] Test nextjs build on buildkite.

Up

Mon, Apr 6, 8:19 PM
sashank updated the diff for D2386: [docs] Test nextjs build on buildkite.

Up

Mon, Apr 6, 8:17 PM
sashank added inline comments to D2449: docs-next-snippet-syntax Adding emphasize lines.
Mon, Apr 6, 6:52 PM
sashank accepted D2449: docs-next-snippet-syntax Adding emphasize lines.

Nice!

Mon, Apr 6, 6:49 PM

Sun, Apr 5

sashank committed R1:327c0f2e94d2: [docs] Syntax highlighting (authored by sashank).
[docs] Syntax highlighting
Sun, Apr 5, 7:01 PM
sashank closed D2446: [docs] Syntax highlighting.
Sun, Apr 5, 7:01 PM
sashank updated the diff for D2446: [docs] Syntax highlighting.

Remove unecessary fragment

Sun, Apr 5, 6:59 PM
sashank added inline comments to D2446: [docs] Syntax highlighting.
Sun, Apr 5, 6:58 PM
sashank abandoned D2442: [docs] Syntax highlighting.
Sun, Apr 5, 6:50 PM
sashank added a comment to D2442: [docs] Syntax highlighting.

Abandoning in favor of https://dagster.phacility.com/D2446

Sun, Apr 5, 6:49 PM
sashank created D2446: [docs] Syntax highlighting.
Sun, Apr 5, 5:31 PM
sashank added inline comments to D2370: Paginate longitudinal views.
Sun, Apr 5, 6:49 AM
sashank abandoned D2441: [docs] Improve literal includes syntax.

Implemented in https://dagster.phacility.com/D2430

Sun, Apr 5, 6:46 AM
sashank added a comment to D2444: Add query to get runs grouped by root run id.

Make sure you add get_run_groups to the RunStorage base class.

Sun, Apr 5, 6:45 AM
sashank accepted D2430: next-docs - tutorials section and limitSnippetLines.

Great! Let's get this landed 🙌

Sun, Apr 5, 6:17 AM
sashank updated the summary of D2445: Assert run order in run storage tests.
Sun, Apr 5, 1:47 AM
sashank updated the diff for D2445: Assert run order in run storage tests.

Actually, it was my mistake in writing the test. Run order is good 👍

Sun, Apr 5, 1:47 AM
sashank updated the diff for D2445: Assert run order in run storage tests.

Up

Sun, Apr 5, 1:39 AM
sashank created D2445: Assert run order in run storage tests.
Sun, Apr 5, 1:27 AM

Sat, Apr 4

sashank updated the summary of D2442: [docs] Syntax highlighting.
Sat, Apr 4, 4:59 AM
sashank retitled D2442: [docs] Syntax highlighting from Syntax highlighting to [docs] Syntax highlighting.
Sat, Apr 4, 4:58 AM
sashank created D2442: [docs] Syntax highlighting.
Sat, Apr 4, 4:58 AM
sashank updated the diff for D2441: [docs] Improve literal includes syntax.

Fix line numbers

Sat, Apr 4, 3:50 AM
sashank created D2441: [docs] Improve literal includes syntax.
Sat, Apr 4, 3:48 AM
sashank accepted D2440: Factor out shared query logic.
Sat, Apr 4, 2:20 AM

Fri, Apr 3

sashank added inline comments to D2430: next-docs - tutorials section and limitSnippetLines.
Fri, Apr 3, 4:49 PM
sashank added inline comments to D2430: next-docs - tutorials section and limitSnippetLines.
Fri, Apr 3, 5:54 AM
sashank requested changes to D2430: next-docs - tutorials section and limitSnippetLines.
Fri, Apr 3, 5:52 AM
sashank added a comment to D2430: next-docs - tutorials section and limitSnippetLines.

Awesome work! Super impressed by the attention to detail. I love what you did with the literal include.

Fri, Apr 3, 5:51 AM

Thu, Apr 2

sashank added inline comments to D2426: Changelog for 0.7.6.
Thu, Apr 2, 11:45 PM
sashank added inline comments to D2426: Changelog for 0.7.6.
Thu, Apr 2, 11:43 PM
sashank added a comment to D2417: Move run creation logic from launcher into instance.

A quick hack might be to expose a validation method on the RunLauncher, and only call create_run on the instance if launcher.validate() returns True.

Thu, Apr 2, 6:10 PM
sashank added a comment to D2417: Move run creation logic from launcher into instance.

You probably already considered this, but just to flag: this would change the behavior of RemoteDagitRunLauncher.

Thu, Apr 2, 6:05 PM
sashank added inline comments to D2400: Add SQL-native implementation for run step stats.
Thu, Apr 2, 5:02 PM
sashank added inline comments to D2400: Add SQL-native implementation for run step stats.
Thu, Apr 2, 4:49 PM
sashank accepted D2400: Add SQL-native implementation for run step stats.

Awesome stuff :)

Thu, Apr 2, 4:45 PM

Wed, Apr 1

sashank updated the diff for D2404: Render step execution times in longitudinal view.

Cleanup

Wed, Apr 1, 4:00 PM
sashank committed R1:b2de8f48167c: Fix eslint warnings on schedule page (authored by sashank).
Fix eslint warnings on schedule page
Wed, Apr 1, 3:58 PM
sashank closed D2403: Fix eslint warnings on schedule page.
Wed, Apr 1, 3:58 PM
sashank created D2404: Render step execution times in longitudinal view.
Wed, Apr 1, 3:55 PM
sashank added a reviewer for D2403: Fix eslint warnings on schedule page: nate.
Wed, Apr 1, 3:33 PM
sashank created D2403: Fix eslint warnings on schedule page.
Wed, Apr 1, 3:32 PM
sashank committed R1:5592b60f4c80: Ignore unmatched partitions in schedule view (authored by sashank).
Ignore unmatched partitions in schedule view
Wed, Apr 1, 2:54 PM
sashank closed D2402: Ignore unmatched partitions in schedule view.
Wed, Apr 1, 2:54 PM
sashank accepted D2397: Schedule docs.

Thank you for this

Wed, Apr 1, 2:19 PM
sashank created D2402: Ignore unmatched partitions in schedule view.
Wed, Apr 1, 2:04 PM

Tue, Mar 31

sashank committed R1:35bc09315938: Fix docs makefile (authored by sashank).
Fix docs makefile
Tue, Mar 31, 10:48 PM
sashank closed D2391: Fix docs makefile.
Tue, Mar 31, 10:48 PM
sashank updated the diff for D2391: Fix docs makefile.

Add back string replacement

Tue, Mar 31, 8:47 PM
sashank created D2391: Fix docs makefile.
Tue, Mar 31, 8:37 PM
sashank accepted D2348: naive implementation of per-step run stats.

Looks good! Definitely enough here to start building the view

Tue, Mar 31, 7:30 PM
sashank added inline comments to D2377: add pipeline run tags from dagster CLI.
Tue, Mar 31, 5:40 PM
sashank requested changes to D2377: add pipeline run tags from dagster CLI.
Tue, Mar 31, 5:39 PM
sashank updated the summary of D2370: Paginate longitudinal views.
Tue, Mar 31, 5:37 PM