Page MenuHomePhabricator

sashank (Sashank Thupukari)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2019, 5:19 PM (86 w, 23 h)
Roles
Administrator

Recent Activity

Today

sashank requested review of D6736: [docs] Instance and Daemon pages.
Tue, Mar 2, 7:38 AM

Yesterday

sashank committed R1:c66a836e6841: Docs changes (authored by sashank).
Docs changes
Mon, Mar 1, 8:20 PM
sashank closed D6690: black.
Mon, Mar 1, 8:20 PM
sashank committed R1:64855a726447: Docs changes (authored by sashank).
Docs changes
Mon, Mar 1, 8:20 PM
sashank committed R1:0deb194bac4b: black (authored by sashank).
black
Mon, Mar 1, 8:20 PM
sashank committed R1:3e2f36e27c28: Remove extra file (authored by sashank).
Remove extra file
Mon, Mar 1, 8:19 PM
sashank committed R1:995ceaa107cd: More content (authored by sashank).
More content
Mon, Mar 1, 8:19 PM
sashank accepted D6666: [docs-infra] broken link test.
Mon, Mar 1, 7:56 PM

Sat, Feb 27

sashank accepted D6665: [docs-infra] versioned github link.

Nice!

Sat, Feb 27, 1:28 AM
sashank added a comment to D6666: [docs-infra] broken link test.

Wow, nice work! This is great. I don't want you to rewrite a large portion of this, but just a few tips in case you want to clean some of the logic up here and have this logic be consistent with some of the other AST parsing we do:

Sat, Feb 27, 1:26 AM

Fri, Feb 26

sashank requested review of D6690: black.
Fri, Feb 26, 2:15 AM
sashank committed R1:fb90292d4c4c: Rebase master into 0110 (authored by sashank).
Rebase master into 0110
Fri, Feb 26, 12:23 AM

Wed, Feb 24

sashank committed R1:5a67b3289e22: Update json (authored by sashank).
Update json
Wed, Feb 24, 8:16 PM
sashank committed R1:3ffbb69d56c0: Pull in new API changes (authored by sashank).
Pull in new API changes
Wed, Feb 24, 8:05 PM

Tue, Feb 23

sashank accepted D6642: [dagit] Enable react/jsx-no-target-blank.

Just curious, why do we want noreferrer on some of these links, especially docs links? Seems like it would be helpful for analytics.

Tue, Feb 23, 4:54 PM

Mon, Feb 22

sashank accepted D6626: [easy] No logspew in Repository Location Handle cleanup.
Mon, Feb 22, 8:38 PM

Wed, Feb 17

sashank committed R1:86f2aded5e42: Improve snapshot output (authored by sashank).
Improve snapshot output
Wed, Feb 17, 6:05 PM
sashank accepted D6533: [easy] Make WorkspaceLoadTarget responsible for creating its origins, rather than a big switch statement.
Wed, Feb 17, 4:05 PM
sashank added a comment to D6451: Scaffold workspace when creating new dagster repo.

I agree, we should have a workspace.yaml. Users will need to add one anyway very soon after getting started.

Wed, Feb 17, 3:20 PM

Tue, Feb 16

sashank added inline comments to D6497: Pass in WorkspaceLoadTarget to workspace rather than a list of origins.
Tue, Feb 16, 4:46 PM
sashank accepted D6497: Pass in WorkspaceLoadTarget to workspace rather than a list of origins.

This is great! Being able to reload a workspace will be so useful

Tue, Feb 16, 4:46 PM
sashank committed R1:49a04e40eb57: Fix more lint (authored by sashank).
Fix more lint
Tue, Feb 16, 3:49 AM
sashank committed R1:73860c92dd7b: Fix lint warnings (authored by sashank).
Fix lint warnings
Tue, Feb 16, 3:38 AM
sashank updated the diff for D6504: Run complex_grpc_cycle tests in their own processs.

remove loop for flake testing

Tue, Feb 16, 3:29 AM
sashank updated the diff for D6504: Run complex_grpc_cycle tests in their own processs.

one more flake test against bk

Tue, Feb 16, 3:28 AM
sashank requested review of D6504: Run complex_grpc_cycle tests in their own processs.
Tue, Feb 16, 12:33 AM

Mon, Feb 15

sashank closed D6503: Skip test_grpc_watch_thread_server_complex_cycle.
Mon, Feb 15, 11:13 PM
sashank committed R1:28dc17e5530a: Skip test_grpc_watch_thread_server_complex_cycle (authored by sashank).
Skip test_grpc_watch_thread_server_complex_cycle
Mon, Feb 15, 11:13 PM

Fri, Feb 12

sashank updated the diff for D6433: Fix workspace property on WorkspaceProcessContext.

up

Fri, Feb 12, 3:06 PM

Thu, Feb 11

sashank accepted D6439: [new-docs] seo - mark all pages to noindex in dark launch.
Thu, Feb 11, 10:01 PM
sashank accepted D6425: [dagit] Preserve solid selection when refreshing config.
Thu, Feb 11, 8:22 PM
sashank published D6433: Fix workspace property on WorkspaceProcessContext for review.
Thu, Feb 11, 7:21 PM
sashank accepted D6424: [new-docs] migrate-5 "Getting Started".
Thu, Feb 11, 6:15 PM

Wed, Feb 10

sashank accepted D6420: Add overridable method to workspace that allows for changing the logic for turning origins into handles.

Makes sense :)

Wed, Feb 10, 11:40 PM
sashank committed R1:0a05687108ba: Fix grid (authored by sashank).
Fix grid
Wed, Feb 10, 11:28 PM
sashank accepted D6414: add location_name and origin abstract properties on repo origins/handles.
Wed, Feb 10, 8:38 PM
sashank accepted D6396: [new-docs] migrate-4 fix literalincldues -> new code snippet format.
Wed, Feb 10, 6:56 PM
sashank committed R1:d3d6d9cc2c79: guides page (authored by sashank).
guides page
Wed, Feb 10, 6:56 PM
sashank committed R1:4dab77d7b2af: more content (authored by sashank).
more content
Wed, Feb 10, 6:43 PM
sashank committed R1:1aee060cc7c6: more color fixes (authored by sashank).
more color fixes
Wed, Feb 10, 8:50 AM
sashank committed R1:ce6d58df01a3: better prose colors (authored by sashank).
better prose colors
Wed, Feb 10, 8:48 AM
sashank committed R1:c41eeac7bef3: fix colors (authored by sashank).
fix colors
Wed, Feb 10, 8:41 AM
sashank committed R1:8e0d3bbd9e6b: dark mode (authored by sashank).
dark mode
Wed, Feb 10, 8:37 AM
sashank committed R1:21c2638f0c9f: Fix anchor links on api docs (authored by sashank).
Fix anchor links on api docs
Wed, Feb 10, 7:22 AM
sashank committed R1:202f9bdd5ff4: Remove bottom padding (authored by sashank).
Remove bottom padding
Wed, Feb 10, 4:02 AM
sashank committed R1:a3495582d297: Improve mobile transitions (authored by sashank).
Improve mobile transitions
Wed, Feb 10, 4:00 AM
sashank committed R1:d451cb5aff78: Fix mobile (authored by sashank).
Fix mobile
Wed, Feb 10, 3:42 AM
sashank closed D6398: Skip flakey grpc watch test.
Wed, Feb 10, 12:26 AM
sashank committed R1:aa8f66669d7b: Skip flakey grpc watch test (authored by sashank).
Skip flakey grpc watch test
Wed, Feb 10, 12:26 AM

Tue, Feb 9

sashank committed R1:c077a580c79f: Add changelog (authored by sashank).
Add changelog
Tue, Feb 9, 11:16 PM
sashank committed R1:dcc6d6fdf6d2: Add changelog (authored by sashank).
Add changelog
Tue, Feb 9, 11:12 PM
sashank accepted D6387: Move ProcessContext and RequestContext from dagster_graphql => dagster, add Workspace prefix.
Tue, Feb 9, 10:24 PM
sashank added a comment to D6387: Move ProcessContext and RequestContext from dagster_graphql => dagster, add Workspace prefix.

Everything here looks good. Thanks for cleaning up the unused context arguments.

Tue, Feb 9, 10:24 PM
sashank committed R1:182371804ac9: Fix formatting (authored by sashank).
Fix formatting
Tue, Feb 9, 9:43 PM
sashank committed R1:508c16ffaffe: Fix snapshot script to update all files (authored by sashank).
Fix snapshot script to update all files
Tue, Feb 9, 9:36 PM
sashank requested review of D6361: Test flakiness of gc tests.
Tue, Feb 9, 8:47 PM
sashank accepted D6363: Remove RepositoryLocation.create_from_handle.
Tue, Feb 9, 5:46 PM
sashank accepted D6351: Remove RepositoryLcoationHandle.create_from_repository_location_origin.

This is definitely much cleaner. +1

Tue, Feb 9, 5:09 PM

Mon, Feb 8

sashank accepted D6358: Fix typo in AssetMaterialization docstring.
Mon, Feb 8, 8:46 PM
sashank closed D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.
Mon, Feb 8, 6:00 PM
sashank committed R1:2f25099676eb: Split DagterGraphQLContext into ProcessContext and RequestContext (authored by sashank).
Split DagterGraphQLContext into ProcessContext and RequestContext
Mon, Feb 8, 6:00 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

re-enable events test

Mon, Feb 8, 5:39 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

remove flake check loop

Mon, Feb 8, 5:27 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

make sure tests aren't flakey

Mon, Feb 8, 5:26 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

hammer bk

Mon, Feb 8, 5:25 PM
sashank accepted D6346: Fixes typo in docs/next/README.md..
Mon, Feb 8, 5:16 PM
sashank updated the summary of D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.
Mon, Feb 8, 3:58 PM
sashank added a comment to D6340: Update k8s docs with new images.

Ah I think this is happening because people have different markdown formatting settings locally. Will make sure it's standardized w/ prettie

Mon, Feb 8, 3:53 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

up

Mon, Feb 8, 3:36 PM

Sat, Feb 6

sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

up

Sat, Feb 6, 6:54 PM

Fri, Feb 5

sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

up

Fri, Feb 5, 10:40 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

Rebase on new graphql changes

Fri, Feb 5, 10:33 PM
sashank committed R1:cd2beaac0e8c: CSS updates (authored by sashank).
CSS updates
Fri, Feb 5, 5:34 PM
sashank committed R1:dadff5dcbbf9: [docs] Update styling (authored by sashank).
[docs] Update styling
Fri, Feb 5, 5:31 PM

Thu, Feb 4

sashank committed R1:3a9a9e596e3c: Fix github link (authored by sashank).
Fix github link
Thu, Feb 4, 9:30 PM
sashank committed R1:ae7e48127a07: Solids (authored by sashank).
Solids
Thu, Feb 4, 9:22 PM
sashank closed D6307: Update --max-worker default to be None.
Thu, Feb 4, 7:03 PM
sashank committed R1:095514de6bde: Update --max-worker default to be None (authored by sashank).
Update --max-worker default to be None
Thu, Feb 4, 7:03 PM
sashank published D6307: Update --max-worker default to be None for review.
Thu, Feb 4, 6:08 PM
sashank accepted D6306: [docs] fix old solid guide link.

Thanks :)

Thu, Feb 4, 6:05 PM
sashank closed D6303: Increase gRPC server max_worker count to default.
Thu, Feb 4, 6:01 PM
sashank committed R1:bacda3a8d4ca: Increase gRPC server max_worker count to default (authored by sashank).
Increase gRPC server max_worker count to default
Thu, Feb 4, 6:01 PM
sashank updated the diff for D6303: Increase gRPC server max_worker count to default.
  • Add changelog entry
Thu, Feb 4, 6:00 PM
sashank added inline comments to D6303: Increase gRPC server max_worker count to default.
Thu, Feb 4, 5:55 PM
sashank updated the diff for D6303: Increase gRPC server max_worker count to default.
  • error formatting
Thu, Feb 4, 5:40 PM
sashank added a reviewer for D6303: Increase gRPC server max_worker count to default: dgibson.
Thu, Feb 4, 5:35 PM
sashank requested review of D6303: Increase gRPC server max_worker count to default.
Thu, Feb 4, 5:25 PM
sashank closed D6302: More main concepts content + full static generation.
Thu, Feb 4, 7:02 AM
sashank committed R1:4a3036d3e05f: More main concepts content + full static generation (authored by sashank).
More main concepts content + full static generation
Thu, Feb 4, 7:01 AM
sashank closed D6300: [docs] Versioned sidebar.
Thu, Feb 4, 6:30 AM
sashank committed R1:67db77a7f631: [docs] Versioned sidebar (authored by sashank).
[docs] Versioned sidebar
Thu, Feb 4, 6:30 AM
sashank closed D6296: [docs] Custom Versioning.
Thu, Feb 4, 6:30 AM
sashank committed R1:a61b8db4af1d: [docs] Custom Versioning (authored by sashank).
[docs] Custom Versioning
Thu, Feb 4, 6:30 AM
sashank requested review of D6300: [docs] Versioned sidebar.
Thu, Feb 4, 5:26 AM
sashank updated the diff for D6296: [docs] Custom Versioning.

up

Thu, Feb 4, 5:01 AM
sashank requested review of D6296: [docs] Custom Versioning.
Thu, Feb 4, 2:11 AM

Wed, Feb 3

sashank committed R1:1a9a120f5ef4: fix (authored by sashank).
fix
Wed, Feb 3, 9:00 PM
sashank committed R1:06061e2e9737: Fix static path (authored by sashank).
Fix static path
Wed, Feb 3, 8:57 PM
sashank committed R1:78d8fec82391: Add few versions (authored by sashank).
Add few versions
Wed, Feb 3, 8:55 PM
sashank committed R1:93e45bef96e1: remove hr (authored by sashank).
remove hr
Wed, Feb 3, 8:47 PM