Page MenuHomePhabricator

sashank (Sashank Thupukari)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2019, 5:19 PM (22 w, 5 d)
Roles
Administrator

Recent Activity

Yesterday

sashank created D1655: Partition selector in dagit config editor.
Fri, Dec 13, 7:11 PM

Thu, Dec 12

sashank added inline comments to D1646: Add graphql interface for PartitionSets.
Thu, Dec 12, 11:13 PM
sashank updated the diff for D1646: Add graphql interface for PartitionSets.

rename commit + make graphql

Thu, Dec 12, 11:08 PM
sashank retitled D1646: Add graphql interface for PartitionSets from Add grqphql interface for PartitionSets to Add graphql interface for PartitionSets.
Thu, Dec 12, 11:07 PM
sashank retitled D1646: Add graphql interface for PartitionSets from Add grqphal interface for PartitionSets to Add grqphql interface for PartitionSets.
Thu, Dec 12, 11:07 PM
sashank created D1646: Add graphql interface for PartitionSets.
Thu, Dec 12, 11:02 PM

Wed, Dec 11

sashank updated the diff for D1636: Rename Scheduler graphql schema file.

Up

Wed, Dec 11, 11:05 PM
sashank updated the diff for D1636: Rename Scheduler graphql schema file.

Update import in create_schema

Wed, Dec 11, 11:03 PM
sashank updated the summary of D1636: Rename Scheduler graphql schema file.
Wed, Dec 11, 11:00 PM
sashank updated the summary of D1636: Rename Scheduler graphql schema file.
Wed, Dec 11, 10:58 PM
sashank updated the diff for D1636: Rename Scheduler graphql schema file.

Add new file

Wed, Dec 11, 10:57 PM
sashank updated the diff for D1636: Rename Scheduler graphql schema file.

Move fetch functions to fetch_schedules

Wed, Dec 11, 10:57 PM
sashank retitled D1636: Rename Scheduler graphql schema file from Rename Scheduler graphql schema file to Reorganize scheduler grqphql code.
Wed, Dec 11, 10:57 PM
sashank created D1636: Rename Scheduler graphql schema file.
Wed, Dec 11, 10:51 PM
sashank accepted D1634: fix pipeline definition doc to reference solid.
Wed, Dec 11, 9:39 PM
sashank planned changes to D1617: Remove execution_params from ScheduleDefinition.
Wed, Dec 11, 12:29 AM
sashank updated the diff for D1612: Create resource for partitions.

raise errors when partition_resource cannot be initialized

Wed, Dec 11, 12:28 AM
sashank updated the diff for D1612: Create resource for partitions.

rerun tests

Wed, Dec 11, 12:12 AM

Tue, Dec 10

sashank added inline comments to D1612: Create resource for partitions.
Tue, Dec 10, 11:39 PM
sashank accepted D1630: fix console warnings about accessibility.

👍👍👍

Tue, Dec 10, 11:38 PM
sashank updated the diff for D1612: Create resource for partitions.

Add missing files + lint

Tue, Dec 10, 11:33 PM
sashank updated the diff for D1612: Create resource for partitions.

formatting

Tue, Dec 10, 11:25 PM
sashank updated the diff for D1612: Create resource for partitions.

Up

Tue, Dec 10, 11:21 PM
sashank updated the summary of D1612: Create resource for partitions.
Tue, Dec 10, 11:16 PM
sashank updated the diff for D1612: Create resource for partitions.

cleanup

Tue, Dec 10, 11:13 PM
sashank updated the diff for D1612: Create resource for partitions.

Update tests, use tags to get partition in partition_resource

Tue, Dec 10, 11:05 PM
sashank added inline comments to D1617: Remove execution_params from ScheduleDefinition.
Tue, Dec 10, 9:54 PM
sashank planned changes to D1612: Create resource for partitions.
Tue, Dec 10, 7:18 PM
sashank updated the diff for D1612: Create resource for partitions.

rebase

Tue, Dec 10, 6:57 PM
sashank updated the diff for D1615: Update datetime partition example to use Partition API.

Rebase

Tue, Dec 10, 6:52 PM
sashank added inline comments to D1617: Remove execution_params from ScheduleDefinition.
Tue, Dec 10, 10:17 AM
sashank accepted D1566: add backfill cli script.

Seems good to land! Can keep iterating on the fancy interactive experience

Tue, Dec 10, 2:20 AM
sashank added inline comments to D1617: Remove execution_params from ScheduleDefinition.
Tue, Dec 10, 2:16 AM
sashank updated the summary of D1617: Remove execution_params from ScheduleDefinition.
Tue, Dec 10, 2:12 AM
sashank updated the summary of D1617: Remove execution_params from ScheduleDefinition.
Tue, Dec 10, 2:11 AM
sashank created D1617: Remove execution_params from ScheduleDefinition.
Tue, Dec 10, 2:10 AM
sashank updated the diff for D1613: Add tag for partition set name.

Re-run tests

Tue, Dec 10, 12:53 AM

Mon, Dec 9

sashank updated the diff for D1615: Update datetime partition example to use Partition API.

formatting

Mon, Dec 9, 11:58 PM
sashank added inline comments to D1615: Update datetime partition example to use Partition API.
Mon, Dec 9, 11:55 PM
sashank updated the diff for D1615: Update datetime partition example to use Partition API.

Add dash_stat_date_set to set of repository partitions

Mon, Dec 9, 11:53 PM
sashank added inline comments to D1615: Update datetime partition example to use Partition API.
Mon, Dec 9, 11:50 PM
sashank updated the diff for D1615: Update datetime partition example to use Partition API.

Fix cron_schedule to be every day, not every minute

Mon, Dec 9, 11:49 PM
sashank created D1615: Update datetime partition example to use Partition API.
Mon, Dec 9, 11:48 PM
sashank updated the diff for D1613: Add tag for partition set name.

Format

Mon, Dec 9, 11:28 PM
sashank updated the diff for D1613: Add tag for partition set name.

Add test

Mon, Dec 9, 11:20 PM
sashank created D1613: Add tag for partition set name.
Mon, Dec 9, 11:19 PM
sashank planned changes to D1612: Create resource for partitions.

After discussion with @max: Instead of passing in the partition_set_definition_name and partition_name through resource config, we can grab these two things off tags. We already have the dagster/partition_name tag, so we should add the dagster/partition_set_definition_name tag.

Mon, Dec 9, 11:10 PM
sashank updated the diff for D1612: Create resource for partitions.

Fix imports

Mon, Dec 9, 10:35 PM
sashank added a reviewer for D1612: Create resource for partitions: max.
Mon, Dec 9, 10:33 PM
sashank added inline comments to D1612: Create resource for partitions.
Mon, Dec 9, 10:33 PM
sashank added inline comments to D1612: Create resource for partitions.
Mon, Dec 9, 10:32 PM
sashank updated the diff for D1612: Create resource for partitions.

Up

Mon, Dec 9, 10:31 PM
sashank updated the summary of D1612: Create resource for partitions.
Mon, Dec 9, 10:29 PM
sashank updated the summary of D1612: Create resource for partitions.
Mon, Dec 9, 10:28 PM
sashank updated the summary of D1612: Create resource for partitions.
Mon, Dec 9, 10:28 PM
sashank updated the diff for D1612: Create resource for partitions.

Formatting

Mon, Dec 9, 10:27 PM
sashank created D1612: Create resource for partitions.
Mon, Dec 9, 10:27 PM

Sat, Dec 7

sashank added a comment to D1566: add backfill cli script.

This is awesome. The interactive part is really nice to use.

Sat, Dec 7, 12:50 AM
sashank created D1570: Add retries to SqliteRunStorage add_run.
Sat, Dec 7, 12:40 AM
sashank added inline comments to D1566: add backfill cli script.
Sat, Dec 7, 12:28 AM
sashank added inline comments to D1566: add backfill cli script.
Sat, Dec 7, 12:09 AM

Fri, Dec 6

sashank added a comment to D1430: Introduce Partition API.

finallydone

Fri, Dec 6, 11:30 PM
sashank updated the diff for D1430: Introduce Partition API.

rebase on origin/master

Fri, Dec 6, 11:28 PM
sashank updated the diff for D1430: Introduce Partition API.

Remove instance parameter from dash_stats_datetime_partition_config function

Fri, Dec 6, 11:11 PM
sashank updated the diff for D1430: Introduce Partition API.

Fix typo

Fri, Dec 6, 11:09 PM
sashank added inline comments to D1430: Introduce Partition API.
Fri, Dec 6, 11:09 PM
sashank updated the diff for D1430: Introduce Partition API.

make black

Fri, Dec 6, 11:08 PM
sashank updated the diff for D1430: Introduce Partition API.

Add tests

Fri, Dec 6, 10:28 PM
sashank planned changes to D1430: Introduce Partition API.
Fri, Dec 6, 1:57 AM
sashank updated the diff for D1430: Introduce Partition API.

fix tests

Fri, Dec 6, 1:57 AM
sashank updated the diff for D1430: Introduce Partition API.

Remove use of instance in envvironment_config_fn, tags_fn, and PartitionSelector

Fri, Dec 6, 1:28 AM
sashank planned changes to D1430: Introduce Partition API.
Fri, Dec 6, 1:28 AM
sashank planned changes to D1430: Introduce Partition API.
Fri, Dec 6, 1:10 AM
sashank updated the diff for D1430: Introduce Partition API.
  • Fix validation on ScheduleDefinition
  • Throw DagsterInvariantViolationError if selected_partition == None
Fri, Dec 6, 1:10 AM
sashank added inline comments to D1430: Introduce Partition API.
Fri, Dec 6, 1:02 AM
sashank added inline comments to D1430: Introduce Partition API.
Fri, Dec 6, 12:36 AM
sashank updated the diff for D1430: Introduce Partition API.

up

Fri, Dec 6, 12:11 AM
sashank planned changes to D1430: Introduce Partition API.
Fri, Dec 6, 12:11 AM

Thu, Dec 5

sashank planned changes to D1430: Introduce Partition API.
Thu, Dec 5, 11:16 PM
sashank updated the diff for D1430: Introduce Partition API.
  • Add environment_dict_fn_for_partition and tags_fn_for_partition to PartitionSet.
  • Add method to PartitionSet to create a ScheduleDefinition from a PartitionSet. This allowed us to move all the partition logic from start_scheduled_execution to environment_dict_fn_for_partition and tags_fn_for_partition.
  • Add tags_fn to ScheduleDefinition
  • Add deprecation warnings for environment_dict and tags arguments to ScheduleDefinition. We should remove them in 0.7.0 to simplify the API.
Thu, Dec 5, 11:16 PM

Tue, Dec 3

sashank accepted D1527: link schedule page.

Looks great! Just two minor suggestions

Tue, Dec 3, 9:04 PM
sashank requested changes to D1527: link schedule page.

From Slack: Would be nice for the 5th column in the top bar to show attempts instead of runs, so that the colors match up with the attempts list

Tue, Dec 3, 12:27 AM
sashank accepted D1527: link schedule page.

This is great!

Tue, Dec 3, 12:23 AM
sashank updated the diff for D1430: Introduce Partition API.

Update date_partition_range to store datetime objects

Tue, Dec 3, 12:18 AM
sashank updated the diff for D1430: Introduce Partition API.

Up

Tue, Dec 3, 12:12 AM
sashank added inline comments to D1430: Introduce Partition API.
Tue, Dec 3, 12:08 AM
sashank updated the diff for D1430: Introduce Partition API.
  • Remove partition_environment_dict_fn
  • Readd partition argument to environment_dict_fn
  • Update existing example
  • Add value to Partition
Tue, Dec 3, 12:00 AM

Mon, Dec 2

sashank commandeered D1430: Introduce Partition API.
Mon, Dec 2, 10:31 PM

Fri, Nov 15

sashank updated the diff for D1431: Add UI for partitions in Dagit.

update snapshots

Fri, Nov 15, 10:13 PM
sashank updated the diff for D1431: Add UI for partitions in Dagit.

refactor

Fri, Nov 15, 10:12 PM
sashank updated the diff for D1431: Add UI for partitions in Dagit.

Remove re-execute button

Fri, Nov 15, 10:06 PM
sashank updated the summary of D1431: Add UI for partitions in Dagit.
Fri, Nov 15, 10:06 PM
sashank updated the summary of D1431: Add UI for partitions in Dagit.
Fri, Nov 15, 10:05 PM
sashank updated the diff for D1431: Add UI for partitions in Dagit.

rebase

Fri, Nov 15, 10:04 PM
sashank updated the diff for D1430: Introduce Partition API.

rebase off origin/master

Fri, Nov 15, 10:03 PM
sashank updated the diff for D1431: Add UI for partitions in Dagit.

rebase

Fri, Nov 15, 9:50 PM
sashank updated the diff for D1430: Introduce Partition API.

make graphql

Fri, Nov 15, 9:48 PM
sashank updated the diff for D1430: Introduce Partition API.

up

Fri, Nov 15, 9:48 PM
sashank updated the diff for D1431: Add UI for partitions in Dagit.

rebase

Fri, Nov 15, 9:39 PM
sashank updated the diff for D1430: Introduce Partition API.

update test

Fri, Nov 15, 9:38 PM