Page MenuHomePhabricator

sashank (Sashank Thupukari)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2019, 5:19 PM (6 w, 3 d)
Roles
Administrator

Recent Activity

Today

sashank updated the diff for D878: Pass --log argument to dagit in dagit service.

Rerun tests

Fri, Aug 23, 12:33 AM
sashank updated the diff for D879: Fix python3 bug with cron schedule script.

typo

Fri, Aug 23, 12:23 AM
sashank created D879: Fix python3 bug with cron schedule script.
Fri, Aug 23, 12:21 AM
sashank created D878: Pass --log argument to dagit in dagit service.
Fri, Aug 23, 12:16 AM

Yesterday

sashank updated the diff for D877: Set environment variables on ScheduleDefinition.

Rebase

Thu, Aug 22, 11:26 PM
sashank updated the diff for D873: Add repo yaml directory to python path in dagster-graphql cli.

Move add to path before loading module

Thu, Aug 22, 11:13 PM
sashank updated the diff for D873: Add repo yaml directory to python path in dagster-graphql cli.

Only add if not already in sys.path

Thu, Aug 22, 10:50 PM
sashank updated the diff for D873: Add repo yaml directory to python path in dagster-graphql cli.

Move to LoaderEntrypoint

Thu, Aug 22, 10:44 PM
sashank updated the diff for D877: Set environment variables on ScheduleDefinition.

Rebase

Thu, Aug 22, 10:07 PM
sashank updated the diff for D873: Add repo yaml directory to python path in dagster-graphql cli.

Move to ExecutionTargetHandle

Thu, Aug 22, 10:07 PM
sashank created D877: Set environment variables on ScheduleDefinition.
Thu, Aug 22, 9:46 PM
sashank updated the diff for D873: Add repo yaml directory to python path in dagster-graphql cli.

Rebase

Thu, Aug 22, 8:25 PM
sashank updated the test plan for D873: Add repo yaml directory to python path in dagster-graphql cli.
Thu, Aug 22, 6:49 PM
sashank created D873: Add repo yaml directory to python path in dagster-graphql cli.
Thu, Aug 22, 6:48 PM
sashank updated the diff for D872: Fix FilesystemRunStorage instantiations.

Move changes to branch

Thu, Aug 22, 6:28 PM
sashank updated the diff for D872: Fix FilesystemRunStorage instantiations.

Fix test

Thu, Aug 22, 6:19 PM
sashank updated the diff for D872: Fix FilesystemRunStorage instantiations.

Add test

Thu, Aug 22, 6:13 PM
sashank created D872: Fix FilesystemRunStorage instantiations.
Thu, Aug 22, 6:07 PM
sashank planned changes to D855: [WIP] Create scaffolding for dagit scheduler UI.
Thu, Aug 22, 4:49 PM
sashank accepted D867: [4/N] dagster-aws CLI: nuke.
Thu, Aug 22, 4:23 AM

Wed, Aug 21

sashank accepted D866: [3/N] dagster-aws CLI fix for make dev_install.
Wed, Aug 21, 11:34 PM
sashank added inline comments to D858: Overhauled run history view.
Wed, Aug 21, 10:50 PM
sashank accepted D864: [2/N] dagster-aws CLI fixes: use existing keypair if possible.
Wed, Aug 21, 10:44 PM
sashank updated the diff for D865: Set dagster home in dagit service.

Remove $

Wed, Aug 21, 10:30 PM
sashank updated the diff for D865: Set dagster home in dagit service.

Rebase

Wed, Aug 21, 10:29 PM
sashank created D865: Set dagster home in dagit service.
Wed, Aug 21, 10:28 PM
sashank accepted D863: [1/N] dagster-aws CLI fixes.
Wed, Aug 21, 10:25 PM
sashank accepted D860: Let user choose name of instance.
Wed, Aug 21, 9:17 PM
sashank added a comment to D860: Let user choose name of instance.

Macro redfordnod:

Wed, Aug 21, 9:17 PM
sashank accepted D857: Move dagster-aws AWS utilities to a separate file.
Wed, Aug 21, 6:04 PM
sashank accepted D856: Fix dagster_home in dagster-aws CLI.
Wed, Aug 21, 5:20 PM
sashank updated the diff for D855: [WIP] Create scaffolding for dagit scheduler UI.

make graphql

Wed, Aug 21, 5:00 PM
sashank updated the diff for D855: [WIP] Create scaffolding for dagit scheduler UI.

Remove state

Wed, Aug 21, 4:29 PM
sashank created D855: [WIP] Create scaffolding for dagit scheduler UI.
Wed, Aug 21, 4:23 PM

Tue, Aug 20

sashank updated the diff for D842: Create ScheduleDefinition and dagster CLI scheduler commands.

make graphql

Tue, Aug 20, 9:31 PM
sashank updated the diff for D842: Create ScheduleDefinition and dagster CLI scheduler commands.

Rerun tests

Tue, Aug 20, 9:27 PM
sashank updated the diff for D842: Create ScheduleDefinition and dagster CLI scheduler commands.

Remove _schedule_names, change ScheduleDefinition to namedtuple, fix nits

Tue, Aug 20, 9:22 PM
sashank updated the diff for D842: Create ScheduleDefinition and dagster CLI scheduler commands.

Bug fix

Tue, Aug 20, 9:11 PM
sashank added inline comments to D842: Create ScheduleDefinition and dagster CLI scheduler commands.
Tue, Aug 20, 9:08 PM
sashank updated the summary of D842: Create ScheduleDefinition and dagster CLI scheduler commands.
Tue, Aug 20, 8:57 PM
sashank updated the diff for D842: Create ScheduleDefinition and dagster CLI scheduler commands.

Rename start + end schedule mutations

Tue, Aug 20, 8:53 PM
sashank updated the diff for D842: Create ScheduleDefinition and dagster CLI scheduler commands.

Feedback

Tue, Aug 20, 8:51 PM
sashank updated the diff for D842: Create ScheduleDefinition and dagster CLI scheduler commands.

Improve error handling and messages

Tue, Aug 20, 5:54 PM
sashank updated the summary of D842: Create ScheduleDefinition and dagster CLI scheduler commands.
Tue, Aug 20, 5:36 PM
sashank updated the summary of D842: Create ScheduleDefinition and dagster CLI scheduler commands.
Tue, Aug 20, 5:36 PM
sashank retitled D842: Create ScheduleDefinition and dagster CLI scheduler commands from [WIP] Create ScheduleDefinition and dagster CLI scheduler commands to Create ScheduleDefinition and dagster CLI scheduler commands.
Tue, Aug 20, 5:36 PM
sashank updated the diff for D842: Create ScheduleDefinition and dagster CLI scheduler commands.

Update documentation

Tue, Aug 20, 5:24 PM
sashank updated the diff for D842: Create ScheduleDefinition and dagster CLI scheduler commands.

Remove schedules from toys, Update tests

Tue, Aug 20, 5:22 PM
sashank updated the diff for D842: Create ScheduleDefinition and dagster CLI scheduler commands.

Update paths

Tue, Aug 20, 5:10 PM
sashank updated the diff for D842: Create ScheduleDefinition and dagster CLI scheduler commands.

Move scheduler from dagster_graphql to dagster.core

Tue, Aug 20, 1:07 AM
sashank updated the diff for D842: Create ScheduleDefinition and dagster CLI scheduler commands.

Fix graphql errors

Tue, Aug 20, 12:47 AM
sashank updated the diff for D842: Create ScheduleDefinition and dagster CLI scheduler commands.

Rebase

Tue, Aug 20, 12:44 AM
sashank updated the diff for D842: Create ScheduleDefinition and dagster CLI scheduler commands.

Delete GraphQL queries for schedule create + delete, fix tests

Tue, Aug 20, 12:39 AM
sashank updated the diff for D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.

Rebase

Tue, Aug 20, 12:08 AM

Mon, Aug 19

sashank updated the diff for D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.

Use kwargs for RunSchedule

Mon, Aug 19, 11:56 PM
sashank updated the diff for D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.

Remove use of kwargs

Mon, Aug 19, 11:51 PM
sashank planned changes to D842: Create ScheduleDefinition and dagster CLI scheduler commands.
Mon, Aug 19, 11:14 PM
sashank updated the diff for D842: Create ScheduleDefinition and dagster CLI scheduler commands.

Rebase

Mon, Aug 19, 11:13 PM
sashank updated the diff for D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.

Rebase

Mon, Aug 19, 11:12 PM
sashank created D842: Create ScheduleDefinition and dagster CLI scheduler commands.
Mon, Aug 19, 11:11 PM
sashank added inline comments to D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.
Mon, Aug 19, 8:53 PM
sashank updated the diff for D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.

Make RunSchedule immutable and remove is_running for now

Mon, Aug 19, 8:47 PM

Fri, Aug 16

sashank updated the diff for D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.

Add mock to dagster-graphql dev requirements

Fri, Aug 16, 10:54 PM
sashank updated the diff for D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.

rebase

Fri, Aug 16, 10:01 PM
sashank added inline comments to D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.
Fri, Aug 16, 9:55 PM
sashank updated the diff for D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.

Remove use of kwargs in start and end schedule mutations

Fri, Aug 16, 9:40 PM
sashank updated the diff for D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.

Add bash script deletion check in test_start_and_end_schedule()

Fri, Aug 16, 9:19 PM
sashank retitled D826: Implement start_schedule and end_schedule for SystemCronTabScheduler from Implement crontab scheduler start and end to Implement start_schedule and end_schedule for SystemCronTabScheduler.
Fri, Aug 16, 9:16 PM
sashank updated the diff for D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.

Mock $DAGSTER_HOME for test

Fri, Aug 16, 9:15 PM
sashank retitled D826: Implement start_schedule and end_schedule for SystemCronTabScheduler from [WIP] Implement crontab scheduler start and end to Implement crontab scheduler start and end.
Fri, Aug 16, 9:08 PM
sashank updated the diff for D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.

make graphql

Fri, Aug 16, 8:55 PM
sashank updated the diff for D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.

Fix end_schedule, and remove hardcoded DAGSTER_HOME

Fri, Aug 16, 8:55 PM
sashank updated the diff for D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.

Write to log file with filename {schedule name}_{schedule id}.log in the same directory as the bash script and metadata file

Fri, Aug 16, 8:31 PM
sashank updated the diff for D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.

Mutations for start and end schedule, create TestSystemCronScheduler, and write tests for all new queries and mutations

Fri, Aug 16, 8:18 PM

Thu, Aug 15

sashank updated the diff for D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.

Add dependency

Thu, Aug 15, 10:58 PM
sashank updated the diff for D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.

Add flag to RunSchedule to indictate whether a schedule is runnning

Thu, Aug 15, 10:16 PM
sashank updated the diff for D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.

Get repository path from DagsterGraphQLContext, and python path from sys.executable, and store both on RunSchedule

Thu, Aug 15, 9:04 PM
sashank planned changes to D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.
Thu, Aug 15, 7:08 PM
sashank created D826: Implement start_schedule and end_schedule for SystemCronTabScheduler.
Thu, Aug 15, 7:08 PM
sashank added a reviewer for D825: Fix state update error in ConfigEditorModePicker: bengotow.
Thu, Aug 15, 7:03 PM
sashank updated the summary of D825: Fix state update error in ConfigEditorModePicker.
Thu, Aug 15, 7:00 PM
sashank created D825: Fix state update error in ConfigEditorModePicker.
Thu, Aug 15, 7:00 PM

Wed, Aug 14

sashank updated the diff for D804: Create Scheduler GraphQL interface.

Rebase

Wed, Aug 14, 10:42 PM
sashank updated the diff for D804: Create Scheduler GraphQL interface.

Rebase

Wed, Aug 14, 9:22 PM
sashank updated the diff for D804: Create Scheduler GraphQL interface.

Rename execution_params to execution_params_string in DauphinRunSchedule

Wed, Aug 14, 9:19 PM
sashank added inline comments to D804: Create Scheduler GraphQL interface.
Wed, Aug 14, 9:05 PM

Tue, Aug 13

sashank updated the diff for D804: Create Scheduler GraphQL interface.

Cleanup

Tue, Aug 13, 11:28 PM
sashank updated the diff for D804: Create Scheduler GraphQL interface.

Remove timestamp from schedule filenames, removing the need for a wrapper around schedules in SystemCronScheduler

Tue, Aug 13, 11:19 PM
sashank updated the diff for D804: Create Scheduler GraphQL interface.

Fix diff

Tue, Aug 13, 10:44 PM
sashank added inline comments to D804: Create Scheduler GraphQL interface.
Tue, Aug 13, 8:56 PM
sashank updated the diff for D804: Create Scheduler GraphQL interface.

make graphql

Tue, Aug 13, 8:51 PM
sashank updated the diff for D804: Create Scheduler GraphQL interface.

Change type of execution_params to String

Tue, Aug 13, 8:48 PM
sashank planned changes to D804: Create Scheduler GraphQL interface.
Tue, Aug 13, 6:55 PM
sashank updated the diff for D798: Add Scheduler to dagit and DagsterGraphQLContext.

Rerun tests

Tue, Aug 13, 6:54 PM
sashank updated the diff for D804: Create Scheduler GraphQL interface.

Use namedtuple instead of dict to store schedule and file_path

Tue, Aug 13, 6:41 PM
sashank updated the diff for D798: Add Scheduler to dagit and DagsterGraphQLContext.

make graphql

Tue, Aug 13, 6:26 PM
sashank updated the diff for D798: Add Scheduler to dagit and DagsterGraphQLContext.

Use six.raise_from in SystemCronScheduler (from last diff)

Tue, Aug 13, 6:22 PM
sashank added inline comments to D791: Create Scheduler API.
Tue, Aug 13, 6:18 PM
sashank updated the diff for D798: Add Scheduler to dagit and DagsterGraphQLContext.

Make get_enabled_features() private

Tue, Aug 13, 6:14 PM
sashank updated the diff for D791: Create Scheduler API.

Rethrow exception

Tue, Aug 13, 6:10 PM