Page MenuHomePhabricator

sashank (Sashank Thupukari)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2019, 5:19 PM (72 w, 5 d)
Roles
Administrator

Recent Activity

Wed, Nov 25

sashank requested review of D5306: [dagit] Remove refetch from WorkspaceContext.
Wed, Nov 25, 11:18 PM
sashank closed D5299: Fix apollo cache reset race condition.
Wed, Nov 25, 10:59 PM
sashank committed R1:1d91ee8bccdb: Fix apollo cache reset race condition (authored by sashank).
Fix apollo cache reset race condition
Wed, Nov 25, 10:59 PM
sashank updated the diff for D5299: Fix apollo cache reset race condition.

Add comment

Wed, Nov 25, 10:59 PM
sashank added inline comments to D5299: Fix apollo cache reset race condition.
Wed, Nov 25, 10:57 PM
sashank added a comment to D5304: Fix undo functionatlity in Dagit playground.

Double check that switching tabs in the editor doesn't create a continuous undo history

Wed, Nov 25, 10:00 PM
sashank updated the diff for D5304: Fix undo functionatlity in Dagit playground.

up

Wed, Nov 25, 9:46 PM
sashank published D5304: Fix undo functionatlity in Dagit playground for review.
Wed, Nov 25, 9:35 PM
sashank accepted D5302: del stale todo.
Wed, Nov 25, 9:31 PM
sashank closed D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.
Wed, Nov 25, 9:09 PM
sashank committed R1:1d3359632e5f: (config-scaffold 2/n) Add scaffold config button to Dagit playground (authored by sashank).
(config-scaffold 2/n) Add scaffold config button to Dagit playground
Wed, Nov 25, 9:09 PM
sashank updated the diff for D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.

up

Wed, Nov 25, 9:01 PM
sashank updated the diff for D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.

up

Wed, Nov 25, 8:46 PM
sashank updated the diff for D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.

up

Wed, Nov 25, 8:34 PM
sashank added inline comments to D5299: Fix apollo cache reset race condition.
Wed, Nov 25, 7:21 PM
sashank requested review of D5299: Fix apollo cache reset race condition.
Wed, Nov 25, 6:28 PM
sashank updated the diff for D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.

up

Wed, Nov 25, 6:25 PM
sashank closed D5189: (dagit-reload-4) Dagit location reloading UI.
Wed, Nov 25, 3:51 PM
sashank committed R1:1b945e6c989b: (dagit-reload-4) Dagit location reloading UI (authored by sashank).
(dagit-reload-4) Dagit location reloading UI
Wed, Nov 25, 3:51 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Wed, Nov 25, 12:00 AM

Tue, Nov 24

sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Tue, Nov 24, 11:39 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Tue, Nov 24, 10:20 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Tue, Nov 24, 9:43 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Tue, Nov 24, 9:39 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Tue, Nov 24, 8:10 PM
sashank closed D5266: Deflake grpc server watch tests.
Tue, Nov 24, 8:08 PM
sashank committed R1:b2f5185010ed: Deflake grpc server watch tests (authored by sashank).
Deflake grpc server watch tests
Tue, Nov 24, 8:08 PM
sashank updated the diff for D5266: Deflake grpc server watch tests.

up

Tue, Nov 24, 7:51 PM
sashank updated the diff for D5266: Deflake grpc server watch tests.

up

Tue, Nov 24, 7:23 PM
sashank updated the diff for D5266: Deflake grpc server watch tests.

up

Tue, Nov 24, 7:19 PM
sashank updated the diff for D5266: Deflake grpc server watch tests.

up

Tue, Nov 24, 6:40 PM
sashank updated the diff for D5266: Deflake grpc server watch tests.

up

Tue, Nov 24, 6:38 PM
sashank added a reviewer for D5266: Deflake grpc server watch tests: alangenfeld.
Tue, Nov 24, 6:38 PM
sashank requested review of D5266: Deflake grpc server watch tests.
Tue, Nov 24, 6:33 PM

Mon, Nov 23

sashank accepted D5250: Add FutureTicks connection to ScheduleDefinition.
Mon, Nov 23, 11:36 PM
sashank added a comment to D5250: Add FutureTicks connection to ScheduleDefinition.

This is very cool. Are we eventually going to expose runConfig under each FutureTickResult, so that we can preview what the scheduler is going to run?

Mon, Nov 23, 11:35 PM
sashank accepted D5248: Pull out logic for determining next ticks from scheduler to ExternalSchedule.
Mon, Nov 23, 11:28 PM
sashank accepted D5255: [dagit] Repair endless scrolling Gaant.

With this change, the Gaant will no longer be affected by filtering the logs. Is this the correct behavior?

Mon, Nov 23, 11:23 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Mon, Nov 23, 5:48 PM
sashank accepted D5227: Try to resolve graphql schema loading race conditions in Jest.
Mon, Nov 23, 5:42 PM
sashank closed D5231: Remove PageInfo gqp types.
Mon, Nov 23, 5:41 PM
sashank committed R1:7981c266acfd: Remove PageInfo gqp types (authored by sashank).
Remove PageInfo gqp types
Mon, Nov 23, 5:41 PM

Sat, Nov 21

sashank added a comment to D5227: Try to resolve graphql schema loading race conditions in Jest.

How is it any different to move the function call outside of the function?

Sat, Nov 21, 5:00 PM

Fri, Nov 20

sashank published D5231: Remove PageInfo gqp types for review.
Fri, Nov 20, 11:16 PM
sashank closed D5230: Mark complex cycle grpc test as skipped due to flakiness.
Fri, Nov 20, 11:03 PM
sashank committed R1:cd1fc735b376: Mark complex cycle grpc test as skipped due to flakiness (authored by sashank).
Mark complex cycle grpc test as skipped due to flakiness
Fri, Nov 20, 11:03 PM
sashank published D5230: Mark complex cycle grpc test as skipped due to flakiness for review.
Fri, Nov 20, 10:24 PM
sashank retitled D5189: (dagit-reload-4) Dagit location reloading UI from [WIP] (dagit-reload-4) Dagit location reloading UI to (dagit-reload-4) Dagit location reloading UI.
Fri, Nov 20, 7:04 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Fri, Nov 20, 7:02 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Fri, Nov 20, 6:22 PM
sashank updated the summary of D5189: (dagit-reload-4) Dagit location reloading UI.
Fri, Nov 20, 6:21 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Fri, Nov 20, 6:20 PM
sashank retitled D5189: (dagit-reload-4) Dagit location reloading UI from [WIP] (dagit-reload-4) Dagit location reloading UI to (dagit-reload-4) Dagit location reloading UI.
Fri, Nov 20, 6:20 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Fri, Nov 20, 6:19 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Fri, Nov 20, 5:57 PM
sashank added a comment to D5214: add general_tests to windows tests.

It looks like there's also daemon_tests and utils_tests that we want to run

Fri, Nov 20, 5:47 PM
sashank accepted D5214: add general_tests to windows tests.

Nice catch 👍

Fri, Nov 20, 5:46 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Fri, Nov 20, 5:45 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

network only query

Fri, Nov 20, 4:57 PM
sashank closed D5107: (dagit-reload-3) Add subscriber to GraphQL context.
Fri, Nov 20, 3:59 PM
sashank committed R1:0a60a53ee4f5: (dagit-reload-3) Add subscriber to GraphQL context (authored by sashank).
(dagit-reload-3) Add subscriber to GraphQL context
Fri, Nov 20, 3:59 PM
sashank updated the diff for D5107: (dagit-reload-3) Add subscriber to GraphQL context.

Update error message. Will addresss rename later in the stack

Fri, Nov 20, 3:41 PM
sashank updated the diff for D5107: (dagit-reload-3) Add subscriber to GraphQL context.

Remove add subscriber from event handler

Fri, Nov 20, 3:38 PM
sashank updated the diff for D5107: (dagit-reload-3) Add subscriber to GraphQL context.

Move down re-attaching event subscriber

Fri, Nov 20, 3:33 PM
sashank closed D5212: Fix server id test flakiness.
Fri, Nov 20, 12:05 AM
sashank committed R1:8b8740d472af: Fix server id test flakiness (authored by sashank).
Fix server id test flakiness
Fri, Nov 20, 12:05 AM
sashank updated the diff for D5212: Fix server id test flakiness.

revert flake test

Fri, Nov 20, 12:04 AM

Thu, Nov 19

sashank added a comment to D4949: Allow users to override k8s job container command.

We would also need to surface this configuration in the helm chart

Thu, Nov 19, 11:49 PM
sashank updated the diff for D5212: Fix server id test flakiness.

flake test

Thu, Nov 19, 11:44 PM
sashank added a comment to D5212: Fix server id test flakiness.

that's a really good idea, I'll try that

Thu, Nov 19, 11:38 PM
sashank published D5212: Fix server id test flakiness for review.
Thu, Nov 19, 11:33 PM
sashank closed D5198: fix step restart atempts stats calculation.
Thu, Nov 19, 9:48 PM
sashank committed R1:c58339e964e7: fix step restart atempts stats calculation (authored by alangenfeld).
fix step restart atempts stats calculation
Thu, Nov 19, 9:48 PM
sashank updated the diff for D5198: fix step restart atempts stats calculation.

add comment

Thu, Nov 19, 9:46 PM
sashank accepted D4785: Allow PipelineRunFilters on multiple statuses.

Nice!

Thu, Nov 19, 9:31 PM
sashank requested review of D5198: fix step restart atempts stats calculation.

@prha updated to use count

Thu, Nov 19, 7:57 PM
sashank updated the diff for D5198: fix step restart atempts stats calculation.
  • use count instead of iteration
Thu, Nov 19, 7:55 PM
sashank added inline comments to D5198: fix step restart atempts stats calculation.
Thu, Nov 19, 7:50 PM
sashank updated the diff for D5198: fix step restart atempts stats calculation.
  • fix test case and set default to 1
Thu, Nov 19, 7:41 PM
sashank added inline comments to D5198: fix step restart atempts stats calculation.
Thu, Nov 19, 7:25 PM
sashank added inline comments to D5198: fix step restart atempts stats calculation.
Thu, Nov 19, 7:24 PM
sashank requested review of D5198: fix step restart atempts stats calculation.

requesting review again @alangenfeld

Thu, Nov 19, 7:22 PM
sashank updated the diff for D5198: fix step restart atempts stats calculation.

up

Thu, Nov 19, 7:22 PM
sashank updated the diff for D5198: fix step restart atempts stats calculation.

add step keys filter, update test to have one other retry step

Thu, Nov 19, 7:20 PM
sashank planned changes to D5189: (dagit-reload-4) Dagit location reloading UI.
Thu, Nov 19, 6:54 PM
sashank updated the diff for D4949: Allow users to override k8s job container command.

up

Thu, Nov 19, 6:49 PM
sashank commandeered D5198: fix step restart atempts stats calculation.
Thu, Nov 19, 5:36 PM
sashank retitled D5189: (dagit-reload-4) Dagit location reloading UI from [WIP] (dagit-reload-3) Dagit location reloading UI to [WIP] (dagit-reload-4) Dagit location reloading UI.
Thu, Nov 19, 5:32 PM
sashank updated the summary of D5189: (dagit-reload-4) Dagit location reloading UI.
Thu, Nov 19, 5:21 PM
sashank requested review of D5189: (dagit-reload-4) Dagit location reloading UI.
Thu, Nov 19, 5:19 PM
sashank updated the diff for D4949: Allow users to override k8s job container command.

up

Thu, Nov 19, 5:13 PM
sashank added a reviewer for D4949: Allow users to override k8s job container command: rexledesma.
Thu, Nov 19, 4:56 PM
sashank added a reviewer for D4949: Allow users to override k8s job container command: johann.
Thu, Nov 19, 4:56 PM
sashank published D4949: Allow users to override k8s job container command for review.
Thu, Nov 19, 4:56 PM
sashank closed D5106: (dagit-reload-2/n) gRPC server watch thread.
Thu, Nov 19, 4:41 PM
sashank committed R1:fd6338d76f68: (dagit-reload-2/n) gRPC server watch thread (authored by sashank).
(dagit-reload-2/n) gRPC server watch thread
Thu, Nov 19, 4:41 PM
sashank updated the diff for D5106: (dagit-reload-2/n) gRPC server watch thread.

feedback

Thu, Nov 19, 7:18 AM
sashank added inline comments to D5106: (dagit-reload-2/n) gRPC server watch thread.
Thu, Nov 19, 7:17 AM

Wed, Nov 18

sashank accepted D5194: ButtonLink.

Beautiful, thanks for this :)

Wed, Nov 18, 10:39 PM
sashank requested review of D5107: (dagit-reload-3) Add subscriber to GraphQL context.
Wed, Nov 18, 9:51 PM