Page MenuHomePhabricator

sashank (Sashank Thupukari)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2019, 5:19 PM (29 w, 1 d)
Roles
Administrator

Recent Activity

Today

sashank updated the diff for D1890: Remove repository from scheduler storage.

up

Tue, Jan 28, 10:51 PM
sashank updated the diff for D1890: Remove repository from scheduler storage.

up

Tue, Jan 28, 10:31 PM
sashank updated the diff for D1890: Remove repository from scheduler storage.

up

Tue, Jan 28, 10:26 PM
sashank added a comment to D1908: Re-order schedule rotues in dagit.

Is this RE https://github.com/dagster-io/dagster/issues/2093?

Tue, Jan 28, 9:40 PM
sashank updated the summary of D1908: Re-order schedule rotues in dagit.
Tue, Jan 28, 9:38 PM
sashank created D1908: Re-order schedule rotues in dagit.
Tue, Jan 28, 9:31 PM
sashank updated the diff for D1905: Wrap cron descriptions in schedules page.

rebase again

Tue, Jan 28, 9:14 PM
sashank updated the diff for D1905: Wrap cron descriptions in schedules page.

rebase

Tue, Jan 28, 7:34 PM
sashank updated the test plan for D1905: Wrap cron descriptions in schedules page.
Tue, Jan 28, 9:42 AM
sashank created D1905: Wrap cron descriptions in schedules page.
Tue, Jan 28, 9:42 AM

Yesterday

sashank created D1890: Remove repository from scheduler storage.
Mon, Jan 27, 6:23 PM

Sat, Jan 25

sashank updated the diff for D1875: Remove status argument from schedule methods.

rebase

Sat, Jan 25, 1:02 AM
sashank planned changes to D1867: [RFC] Remove schedule id.
Sat, Jan 25, 12:39 AM
sashank updated the diff for D1867: [RFC] Remove schedule id.

Fix pylint

Sat, Jan 25, 12:39 AM

Fri, Jan 24

sashank updated the diff for D1879: [RFC] Add util to execute remote pipeline runs.

up

Fri, Jan 24, 11:55 PM
sashank updated the diff for D1879: [RFC] Add util to execute remote pipeline runs.

Remove extra fields from mocked value

Fri, Jan 24, 11:50 PM
sashank added inline comments to D1879: [RFC] Add util to execute remote pipeline runs.
Fri, Jan 24, 11:49 PM
sashank updated the diff for D1879: [RFC] Add util to execute remote pipeline runs.

Correctly add pytest-mock

Fri, Jan 24, 11:48 PM
sashank updated the diff for D1879: [RFC] Add util to execute remote pipeline runs.

Add mock to dagster-graphql setup.py

Fri, Jan 24, 11:36 PM
sashank updated the test plan for D1879: [RFC] Add util to execute remote pipeline runs.
Fri, Jan 24, 11:28 PM
sashank updated the diff for D1879: [RFC] Add util to execute remote pipeline runs.

Move print out of execute_query_against_remote

Fri, Jan 24, 11:22 PM
sashank added inline comments to D1879: [RFC] Add util to execute remote pipeline runs.
Fri, Jan 24, 11:20 PM
sashank updated the diff for D1879: [RFC] Add util to execute remote pipeline runs.
  • Add checks
  • Add test
Fri, Jan 24, 11:19 PM
sashank retitled D1875: Remove status argument from schedule methods from Remove status argument from methods to Remove status argument from schedule methods.
Fri, Jan 24, 8:41 PM
sashank abandoned D1612: Create resource for partitions.
Fri, Jan 24, 8:40 PM
sashank updated subscribers of D1612: Create resource for partitions.

After working more with partitions, I think introducing this would encourage implementing partitioned-based schedules using the anti-pattern @max mentioned. We can hold off on it until we see a clear need for a partition resource.

Fri, Jan 24, 8:40 PM
sashank planned changes to D1867: [RFC] Remove schedule id.

Yup, working on a stack that's based on this. Will also add to the changelog

Fri, Jan 24, 8:30 PM
sashank retitled D1879: [RFC] Add util to execute remote pipeline runs from [RFC] Add util to execute remote pipelie runs to [RFC] Add util to execute remote pipeline runs.
Fri, Jan 24, 1:39 AM
sashank updated the summary of D1879: [RFC] Add util to execute remote pipeline runs.
Fri, Jan 24, 1:34 AM
sashank updated the summary of D1879: [RFC] Add util to execute remote pipeline runs.
Fri, Jan 24, 1:34 AM
sashank created D1879: [RFC] Add util to execute remote pipeline runs.
Fri, Jan 24, 1:33 AM

Thu, Jan 23

sashank created D1875: Remove status argument from schedule methods.
Thu, Jan 23, 10:20 PM
sashank updated the diff for D1867: [RFC] Remove schedule id.

rebase

Thu, Jan 23, 7:37 PM
sashank updated the diff for D1865: Fix example schedules.

Up

Thu, Jan 23, 7:13 PM
sashank updated the diff for D1865: Fix example schedules.

up

Thu, Jan 23, 6:53 PM
sashank updated the diff for D1866: Move dagster_graphql_test context utils to dagster_graphql.

Fix merge conflict

Thu, Jan 23, 6:27 PM
sashank added a comment to D1867: [RFC] Remove schedule id.

This shouldn't break existing running schedules because the scheduler manages those all by name, correct?

Thu, Jan 23, 6:23 PM
sashank updated the diff for D1865: Fix example schedules.

Add comment about why we need to do scheduler_handle.up

Thu, Jan 23, 6:21 PM
sashank updated the diff for D1866: Move dagster_graphql_test context utils to dagster_graphql.

Rebase again

Thu, Jan 23, 6:19 PM
sashank updated the diff for D1866: Move dagster_graphql_test context utils to dagster_graphql.

Rebase on master

Thu, Jan 23, 6:16 PM
sashank updated the diff for D1867: [RFC] Remove schedule id.

rebase on master

Thu, Jan 23, 1:46 AM
sashank updated the diff for D1867: [RFC] Remove schedule id.

Fix AppCache dataIdFromObject for RunningSchedule

Thu, Jan 23, 12:25 AM
sashank retitled D1867: [RFC] Remove schedule id from [RFC} Remove schedule id to [RFC] Remove schedule id.
Thu, Jan 23, 12:11 AM

Wed, Jan 22

sashank updated the diff for D1867: [RFC] Remove schedule id.

Up

Wed, Jan 22, 11:05 PM
sashank updated the diff for D1867: [RFC] Remove schedule id.

pylint

Wed, Jan 22, 11:04 PM
sashank updated the diff for D1867: [RFC] Remove schedule id.

Up

Wed, Jan 22, 11:00 PM
sashank retitled D1867: [RFC] Remove schedule id from [RFC} Remove schedule id to [RFC] Remove schedule id.
Wed, Jan 22, 11:00 PM
sashank updated the diff for D1867: [RFC] Remove schedule id.

Up

Wed, Jan 22, 10:51 PM
sashank updated the diff for D1867: [RFC] Remove schedule id.

Up

Wed, Jan 22, 10:49 PM
sashank updated the diff for D1867: [RFC] Remove schedule id.

Up

Wed, Jan 22, 10:42 PM
sashank created D1867: [RFC] Remove schedule id.
Wed, Jan 22, 10:25 PM
sashank updated the diff for D1866: Move dagster_graphql_test context utils to dagster_graphql.

Move to .utils instead of making a new context.py file

Wed, Jan 22, 10:00 PM
sashank updated the diff for D1866: Move dagster_graphql_test context utils to dagster_graphql.

Replace SynchronousExecutionManager with SubprocessExecutionManager in define_subprocess_context_for_file

Wed, Jan 22, 9:40 PM
sashank requested review of D1865: Fix example schedules.

Requesting review for tests

Wed, Jan 22, 8:08 PM
sashank updated the diff for D1865: Fix example schedules.

Add tests

Wed, Jan 22, 8:08 PM
sashank created D1866: Move dagster_graphql_test context utils to dagster_graphql.
Wed, Jan 22, 7:58 PM
sashank awarded Lover of k8s to recipient: max.
Wed, Jan 22, 7:42 PM
sashank created Lover of k8s.
Wed, Jan 22, 7:42 PM
sashank added a comment to D1865: Fix example schedules.

@prha what do you think is the proper way to test this?

Wed, Jan 22, 6:46 PM
sashank updated the summary of D1865: Fix example schedules.
Wed, Jan 22, 6:44 PM
sashank created D1865: Fix example schedules.
Wed, Jan 22, 6:44 PM

Fri, Jan 17

sashank accepted D1858: [k8s] dont hardcode service account name.

ty!

Fri, Jan 17, 11:15 PM
sashank abandoned D1850: Pass inputs to commpute_fn based on input name.
Fri, Jan 17, 9:59 PM
sashank added a comment to D1850: Pass inputs to commpute_fn based on input name.

Abandoning for https://dagster.phacility.com/D1853

Fri, Jan 17, 9:58 PM
sashank added inline comments to D1853: handle differing arg and input def ordering.
Fri, Jan 17, 7:59 PM
sashank added a reviewer for D1855: Gaant-style execution plan visualization behind feature flag: sashank.
Fri, Jan 17, 7:36 PM
sashank updated the diff for D1844: RFC: Eliminate ConfigMappingContext.

Actually isort

Fri, Jan 17, 12:37 AM
sashank updated the diff for D1844: RFC: Eliminate ConfigMappingContext.

isort

Fri, Jan 17, 12:32 AM

Thu, Jan 16

sashank updated the diff for D1844: RFC: Eliminate ConfigMappingContext.

remove trailing space

Thu, Jan 16, 11:48 PM
sashank updated the diff for D1829: Fix runtime type comparison.

rebase

Thu, Jan 16, 11:08 PM
sashank added a comment to D1832: RFC: Update TypeStoragePluginRegistry to take list of tuples instead of dict.

I think it might be best to leave it for type documentation purposes, even though it's being checked right after again.

Thu, Jan 16, 11:03 PM
sashank updated the diff for D1854: Remove dagster_tests import.

Remove TODO

Thu, Jan 16, 10:08 PM
sashank created D1854: Remove dagster_tests import.
Thu, Jan 16, 10:06 PM
sashank updated the diff for D1851: Change tests using add to subtract.

Remove extra files

Thu, Jan 16, 7:11 PM
sashank updated the diff for D1851: Change tests using add to subtract.

up

Thu, Jan 16, 8:07 AM
sashank updated the diff for D1851: Change tests using add to subtract.

Remove cereal files

Thu, Jan 16, 4:09 AM
sashank updated the diff for D1851: Change tests using add to subtract.

up

Thu, Jan 16, 4:07 AM
sashank created D1851: Change tests using add to subtract.
Thu, Jan 16, 3:52 AM
sashank created D1850: Pass inputs to commpute_fn based on input name.
Thu, Jan 16, 3:37 AM

Wed, Jan 15

sashank updated the diff for D1844: RFC: Eliminate ConfigMappingContext.

Try CHANGES.md fix again

Wed, Jan 15, 11:58 PM
sashank updated the diff for D1844: RFC: Eliminate ConfigMappingContext.

Rebase on CHANGES.md fix

Wed, Jan 15, 11:56 PM
sashank added inline comments to D1844: RFC: Eliminate ConfigMappingContext.
Wed, Jan 15, 11:39 PM
sashank created D1848: Fix changelog formatting.
Wed, Jan 15, 11:36 PM
sashank abandoned D1570: Add retries to SqliteRunStorage add_run.

It seems like the wal changes removs the need for this.

Wed, Jan 15, 10:21 PM

Tue, Jan 14

sashank updated the diff for D1844: RFC: Eliminate ConfigMappingContext.

make black (always forget to do this after a codemod)

Tue, Jan 14, 11:00 PM
sashank updated the diff for D1836: Convert gcp_pipeline to use partitions.

Rebase

Tue, Jan 14, 10:57 PM
sashank updated the diff for D1835: Fix errors with GCP pipeline.

Remove _START constant

Tue, Jan 14, 10:55 PM
sashank added inline comments to D1835: Fix errors with GCP pipeline.
Tue, Jan 14, 10:55 PM
sashank updated the diff for D1844: RFC: Eliminate ConfigMappingContext.

Add breaking change to CHANGES.md

Tue, Jan 14, 10:50 PM
sashank added inline comments to D1844: RFC: Eliminate ConfigMappingContext.
Tue, Jan 14, 10:39 PM
sashank retitled D1844: RFC: Eliminate ConfigMappingContext from Eliminate ConfigMappingContext to RFC: Eliminate ConfigMappingContext.
Tue, Jan 14, 10:33 PM
sashank added reviewers for D1844: RFC: Eliminate ConfigMappingContext: schrockn, alangenfeld.
Tue, Jan 14, 10:33 PM
sashank updated the summary of D1844: RFC: Eliminate ConfigMappingContext.
Tue, Jan 14, 10:33 PM
sashank updated the summary of D1843: Eliminate execution_epoch_time.
Tue, Jan 14, 10:31 PM
sashank updated the summary of D1843: Eliminate execution_epoch_time.
Tue, Jan 14, 10:31 PM
sashank updated the summary of D1844: RFC: Eliminate ConfigMappingContext.
Tue, Jan 14, 10:27 PM
sashank created D1844: RFC: Eliminate ConfigMappingContext.
Tue, Jan 14, 10:26 PM
sashank updated the diff for D1843: Eliminate execution_epoch_time.

up

Tue, Jan 14, 10:05 PM
sashank created D1843: Eliminate execution_epoch_time.
Tue, Jan 14, 10:02 PM
sashank updated the diff for D1836: Convert gcp_pipeline to use partitions.

Up

Tue, Jan 14, 9:57 PM