Page MenuHomeElementl

sashank (Sashank Thupukari)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2019, 5:19 PM (96 w, 3 d)
Roles
Administrator

Recent Activity

Yesterday

sashank accepted D7905: Fix bad assert in workspace cleanup.
Thu, May 13, 8:33 PM
sashank added inline comments to D7899: Fix race condition when reload workspace is called from a background thread.
Thu, May 13, 7:16 PM
sashank accepted D7899: Fix race condition when reload workspace is called from a background thread.
Thu, May 13, 6:49 PM
sashank published D7899: Fix race condition when reload workspace is called from a background thread for review.
Thu, May 13, 6:48 PM
sashank accepted D7892: Put run coordinator instance yaml under test.
Thu, May 13, 2:28 AM

Mon, May 10

sashank accepted D7846: Expose Workspace on WorkspaceProcessContext.
Mon, May 10, 9:38 PM

Fri, May 7

sashank accepted D7785: [docs] use class in search config.
Fri, May 7, 12:46 PM

Thu, May 6

sashank accepted D7769: Fix duplicated doc blocks on IOManagers concepts page.
Thu, May 6, 6:15 PM

Wed, May 5

sashank accepted D7742: Add dagster-celery-k8s to Api docs.
Wed, May 5, 3:40 PM

Tue, May 4

sashank added inline comments to D7711: Add override for env_name for TestPosgresInstance.docker_compose_up.
Tue, May 4, 9:01 PM
sashank accepted D7705: Move grpc server watcher to workspace rather than repo location.

Amazing, this is great. Thanks for improving this substantially. One small control flow comment below.

Tue, May 4, 2:19 PM

Mon, May 3

sashank requested review of D7692: [easy] Fix bad merge for location subscriber.
Mon, May 3, 4:17 PM
sashank updated the diff for D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.

up

Mon, May 3, 5:32 AM

Fri, Apr 30

sashank updated the diff for D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.

up

Fri, Apr 30, 7:39 PM
sashank updated the diff for D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.

up

Fri, Apr 30, 6:10 PM
sashank updated the diff for D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.

up

Fri, Apr 30, 5:54 PM
sashank planned changes to D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.
Fri, Apr 30, 5:52 PM
sashank updated the diff for D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.

up

Fri, Apr 30, 5:51 PM
sashank updated the diff for D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.

feedback

Fri, Apr 30, 5:51 PM
sashank updated the summary of D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.
Fri, Apr 30, 5:41 PM
sashank updated the diff for D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.

feedback

Fri, Apr 30, 5:40 PM
sashank published D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made for review.
Fri, Apr 30, 5:26 PM
sashank published D7680: [RFC] DagsterAuthManager for run attribution for review.
Fri, Apr 30, 4:41 PM

Thu, Apr 29

sashank accepted D7649: [docs] remove rc versioned content.
Thu, Apr 29, 6:00 PM

Wed, Apr 28

sashank accepted D7517: [Docs] Reorganize deployment pages.
Wed, Apr 28, 8:24 PM

Mon, Apr 26

sashank accepted D7605: [Docs] Fix header of Solids/Pipeline testing.
Mon, Apr 26, 8:06 PM

Fri, Apr 23

sashank accepted D7545: Run make build from same directory as the README.
Fri, Apr 23, 1:23 AM
sashank accepted D7554: remove unused tutorial python files.
Fri, Apr 23, 1:23 AM

Tue, Apr 20

sashank accepted D7520: Add container_kwargs to DockerRunLauncher.
Tue, Apr 20, 2:39 PM

Mon, Apr 19

sashank accepted D7508: Ignore the .env file.
Mon, Apr 19, 8:18 PM

Thu, Apr 15

sashank accepted D7458: Add some overridable methods to ProcessGrpcServerRegistry to make it extendable to support different origin types.
Thu, Apr 15, 9:57 PM

Apr 12 2021

sashank accepted D7381: [RFC] rm all legacy_examples.
Apr 12 2021, 8:53 PM

Apr 10 2021

sashank requested changes to D7381: [RFC] rm all legacy_examples.

Just to make sure @yuhan gets to take a look at this (she was ooo), just to make sure this doesn't have any affect on docs and the removed examples are tracked

Apr 10 2021, 6:53 PM

Apr 9 2021

sashank abandoned D7366: Add MayHaveInstanceWeakref mixin to GrpcServerRegistry.
Apr 9 2021, 11:56 AM
sashank published D7366: Add MayHaveInstanceWeakref mixin to GrpcServerRegistry for review.
Apr 9 2021, 11:30 AM

Apr 6 2021

sashank accepted D7256: [docs-infra] version images.
Apr 6 2021, 2:13 PM

Apr 1 2021

sashank accepted D7240: Allow passing in a custom GrpcServerRegistry to Workspace.
Apr 1 2021, 2:44 PM
sashank requested review of D7258: [docs-infra] Compress images.
Apr 1 2021, 2:30 PM

Mar 31 2021

sashank accepted D7138: [docs-infra] auto convert md images to next/image.

Very well done! This should speed up the site significantly.

Mar 31 2021, 11:12 PM
sashank accepted D7207: [docs-infra] set up mdx prettier `yarn format`.

I like that better because on wide screens it's easier to edit. Thank you!

Mar 31 2021, 11:09 PM

Mar 30 2021

sashank accepted D7214: [docs] refer to SolidExecutionContext.
Mar 30 2021, 6:15 PM
sashank added a comment to D7214: [docs] refer to SolidExecutionContext.

will make it so this fails hard going foward

Mar 30 2021, 6:15 PM
sashank added a comment to D7207: [docs-infra] set up mdx prettier `yarn format`.

require("remark-gfm"), { tablePipeAlign: false }: i disabled the GitHub Flavored Markdown's table pipe alignment bc some cells could get very long which resulted in a lot of ----------- in mdx files.

Mar 30 2021, 4:00 PM
sashank accepted D7205: Fix inaccurate repo locations docs.
Mar 30 2021, 3:59 PM
sashank accepted D7202: [docs-infra] check broken anchors and ban non-abs links.

๐Ÿ™ ๐Ÿ™ ๐Ÿ™

Mar 30 2021, 7:05 AM

Mar 29 2021

sashank accepted D7187: Add twitter logo to docs site.
Mar 29 2021, 8:03 PM
sashank added a comment to D7187: Add twitter logo to docs site.

Maybe the order should be: Github, Slack, Twitter, Stack Overflow, Email

Mar 29 2021, 8:03 PM
sashank accepted D7170: Combine RepositoryLocationHandle and RepositoryLocation.

Impressive refactor, this is much cleaner and I'm all for this.

Mar 29 2021, 5:39 PM

Mar 25 2021

sashank accepted D7146: Fix typos and alter some working in the Solids concept section.
Mar 25 2021, 7:23 PM
sashank added a comment to D7109: remove deprecated examples.

also, nothing changed after make snapshot - which means no literal includes in the mdx files

Mar 25 2021, 1:34 PM
sashank accepted D7109: remove deprecated examples.
Mar 25 2021, 1:33 PM
sashank added a comment to D7109: remove deprecated examples.

Amazing!! Feels great to get rid of these

Mar 25 2021, 1:33 PM
sashank accepted D7140: Clarify dagster/priority docs.
Mar 25 2021, 1:33 PM

Mar 24 2021

sashank closed D7130: [docs] Add migration guide to docs site.
Mar 24 2021, 11:00 PM
sashank committed R1:57f6d55516e2: [docs] Add migration guide to docs site (authored by sashank).
[docs] Add migration guide to docs site
Mar 24 2021, 11:00 PM
sashank added inline comments to D7130: [docs] Add migration guide to docs site.
Mar 24 2021, 10:57 PM
sashank published D7130: [docs] Add migration guide to docs site for review.
Mar 24 2021, 10:56 PM

Mar 23 2021

sashank accepted D7115: [docs] bottom nav.
Mar 23 2021, 8:24 PM
sashank added inline comments to D7111: [graphql] handle float NaN metadata entry.
Mar 23 2021, 7:36 PM
sashank accepted D7111: [graphql] handle float NaN metadata entry.
Mar 23 2021, 7:33 PM
sashank closed D7085: [docs-infra] Fix heading for non-docs dagster_bot issues.
Mar 23 2021, 4:33 PM
sashank committed R1:674def17beea: [docs-infra] Fix heading for non-docs dagster_bot issues (authored by sashank).
[docs-infra] Fix heading for non-docs dagster_bot issues
Mar 23 2021, 4:33 PM
sashank closed D7107: [docs] Fix color of search icon.
Mar 23 2021, 4:31 PM
sashank committed R1:bf7af35ee545: [docs] Fix color of search icon (authored by sashank).
[docs] Fix color of search icon
Mar 23 2021, 4:31 PM
sashank requested review of D7107: [docs] Fix color of search icon.
Mar 23 2021, 12:44 AM

Mar 22 2021

sashank closed D7103: [docs] 0.11.1 docs release.
Mar 22 2021, 10:39 PM
sashank committed R1:8c4f0cd6a59b: [docs] 0.11.1 docs release (authored by sashank).
[docs] 0.11.1 docs release
Mar 22 2021, 10:39 PM
sashank accepted D7104: [docs-infra] feedback "cancel" button.

Oof, good catch

Mar 22 2021, 10:22 PM
sashank published D7103: [docs] 0.11.1 docs release for review.
Mar 22 2021, 10:01 PM
sashank accepted D7101: 0.11.1 Changelog.
Mar 22 2021, 9:59 PM
sashank closed D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.
Mar 22 2021, 9:52 PM
sashank committed R1:fac4b234c243: [dagster-k8s] Have job image from executor config take precedence instead ofโ€ฆ (authored by sashank).
[dagster-k8s] Have job image from executor config take precedence instead ofโ€ฆ
Mar 22 2021, 9:52 PM
sashank updated the diff for D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.

up

Mar 22 2021, 9:24 PM
sashank updated the diff for D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.

final tox fixes to make dagster-test work...

Mar 22 2021, 9:08 PM
sashank updated the diff for D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.

up

Mar 22 2021, 9:04 PM
sashank updated the diff for D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.

up

Mar 22 2021, 9:01 PM
sashank updated the diff for D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.

up

Mar 22 2021, 8:54 PM
sashank updated the diff for D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.

up

Mar 22 2021, 8:36 PM
sashank updated the diff for D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.

up

Mar 22 2021, 8:35 PM
sashank accepted D7099: [docs] update dagit screenshots.
Mar 22 2021, 7:59 PM
sashank updated the summary of D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.
Mar 22 2021, 7:53 PM
sashank added inline comments to D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.
Mar 22 2021, 7:52 PM
sashank added inline comments to D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.
Mar 22 2021, 7:51 PM
sashank updated the diff for D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.

add tests

Mar 22 2021, 7:50 PM
sashank added a comment to D7094: Fix typos in kubernetes db migration guide.

Should these these things be under test (or are they too hard to put under test)

Mar 22 2021, 6:46 PM
sashank accepted D7094: Fix typos in kubernetes db migration guide.
Mar 22 2021, 6:46 PM
sashank accepted D7095: [docs] misc issues.
Mar 22 2021, 6:40 PM
sashank planned changes to D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.

add test

Mar 22 2021, 4:13 PM
sashank updated the diff for D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.

up

Mar 22 2021, 4:13 PM
sashank updated the diff for D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.

blind rebase

Mar 22 2021, 4:08 PM
sashank reclaimed D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.

Oof this was a mistake cleaning up my old diffs. Thank you for remembering this diff

Mar 22 2021, 4:03 PM
sashank added a comment to D7079: [dagit] Back to relative paths.

Also curious about why builds are easier with relative paths

Mar 22 2021, 3:18 AM
sashank accepted D7075: [docs] issue: aws and gcp io manager mixed up.

We should just back port everything at once tomorrow

Mar 22 2021, 3:16 AM
sashank added a comment to D7085: [docs-infra] Fix heading for non-docs dagster_bot issues.

BK is down for maintenance:

image.png (517ร—1 px, 81 KB)

Mar 22 2021, 2:57 AM
sashank requested review of D7085: [docs-infra] Fix heading for non-docs dagster_bot issues.
Mar 22 2021, 2:56 AM

Mar 19 2021

sashank accepted D7066: [docs] more in versioned content.
Mar 19 2021, 7:54 PM
sashank closed D7072: [docs-infra] Improve search ranking and API docs parsing.
Mar 19 2021, 7:22 PM
sashank committed R1:116bdd0f1a2a: [docs-infra] Improve search ranking and API docs parsing (authored by sashank).
[docs-infra] Improve search ranking and API docs parsing
Mar 19 2021, 7:22 PM
sashank added inline comments to D7072: [docs-infra] Improve search ranking and API docs parsing.
Mar 19 2021, 7:22 PM
sashank updated the diff for D7072: [docs-infra] Improve search ranking and API docs parsing.

up

Mar 19 2021, 7:22 PM