Page MenuHomePhabricator

sashank (Sashank Thupukari)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2019, 5:19 PM (62 w, 6 d)
Roles
Administrator

Recent Activity

Thu, Sep 17

sashank added a comment to D4336: Add dbt cli module.

I wasn't able to take a close look at the code here yet, but just commenting on a few things in your description and other comments.

Thu, Sep 17, 6:44 AM

Mon, Sep 14

sashank added a comment to D4418: [dagit] schedule specific page clarity.

@sashank you think it would also be good to surface a reconcile button for new defs in the instance level scheduler page ?

Mon, Sep 14, 4:04 PM
sashank accepted D4418: [dagit] schedule specific page clarity.
Mon, Sep 14, 4:03 PM

Fri, Sep 11

sashank accepted D4397: 0.9.6 docs + helm version.
Fri, Sep 11, 2:05 AM

Thu, Sep 10

sashank committed R1:0757129e4fa5: (config-editor-2) Add button to automatically remove extra config (authored by sashank).
(config-editor-2) Add button to automatically remove extra config
Thu, Sep 10, 8:44 PM
sashank closed D4379: (config-editor-2) Add button to automatically remove extra config.
Thu, Sep 10, 8:44 PM
sashank updated the diff for D4379: (config-editor-2) Add button to automatically remove extra config.

Add comments

Thu, Sep 10, 8:44 PM
sashank accepted D4389: [hotfix] fix create_databricks_job_solid.
Thu, Sep 10, 6:12 PM
sashank accepted D4385: [docs] add literalinclude anchors to emr pyspark example.
Thu, Sep 10, 5:39 PM
sashank committed R1:f688cf2606cb: (config-editor-1) Don't mark config sections as invalid due to parent config… (authored by sashank).
(config-editor-1) Don't mark config sections as invalid due to parent config…
Thu, Sep 10, 5:36 PM
sashank closed D4377: (config-editor-1) Don't mark config sections as invalid due to parent config errors.
Thu, Sep 10, 5:36 PM
sashank accepted D4386: update docsite blog link.
Thu, Sep 10, 4:02 PM
sashank added inline comments to D4379: (config-editor-2) Add button to automatically remove extra config.
Thu, Sep 10, 4:13 AM
sashank updated the diff for D4379: (config-editor-2) Add button to automatically remove extra config.

Improve wording and confirmation modal description

Thu, Sep 10, 4:12 AM
sashank updated the test plan for D4379: (config-editor-2) Add button to automatically remove extra config.
Thu, Sep 10, 4:11 AM

Wed, Sep 9

sashank added a comment to D4377: (config-editor-1) Don't mark config sections as invalid due to parent config errors.

This is a good call out - thank you. Updated the description and made sure "required but missing" errors are still displayed correctly.

Wed, Sep 9, 11:13 PM
sashank updated the test plan for D4377: (config-editor-1) Don't mark config sections as invalid due to parent config errors.
Wed, Sep 9, 11:12 PM
sashank added a reviewer for D4379: (config-editor-2) Add button to automatically remove extra config: catherinewu.
Wed, Sep 9, 6:33 PM
sashank updated the summary of D4377: (config-editor-1) Don't mark config sections as invalid due to parent config errors.
Wed, Sep 9, 6:33 PM
sashank added a comment to D4379: (config-editor-2) Add button to automatically remove extra config.

TODO from Slack conversation: improve confirmation dialogue messaging and button wording

Wed, Sep 9, 6:31 PM
sashank updated the summary of D4379: (config-editor-2) Add button to automatically remove extra config.
Wed, Sep 9, 6:30 PM
sashank requested review of D4379: (config-editor-2) Add button to automatically remove extra config.
Wed, Sep 9, 6:12 PM
sashank requested review of D4377: (config-editor-1) Don't mark config sections as invalid due to parent config errors.
Wed, Sep 9, 3:51 PM
sashank accepted D4324: add remaining editable images.
Wed, Sep 9, 3:26 PM
sashank accepted D4307: [trigger-6] add execution-time based graphs on the trigger dashboard.
Wed, Sep 9, 3:25 PM
sashank accepted D4368: validate that tag values are strings at PipelineRun creation time.
Wed, Sep 9, 5:02 AM
sashank added a comment to D4368: validate that tag values are strings at PipelineRun creation time.

Nice catch

Wed, Sep 9, 5:01 AM
sashank accepted D4360: [docs] fix multiple outputs lines.
Wed, Sep 9, 5:01 AM

Tue, Sep 8

sashank commandeered D3981: [2] run-scoped file manager resources.
Tue, Sep 8, 9:45 PM
sashank added inline comments to D4365: Pin pyrsistent.
Tue, Sep 8, 7:55 PM
sashank added a comment to D4365: Pin pyrsistent.
0.17.0, 2020-09-08
 * Remove Python 2 support code. This includes dropping some compatibility code and the dependency on
   six. Thanks @djailla for this.
Tue, Sep 8, 7:51 PM
sashank added a comment to D4365: Pin pyrsistent.

Ah gotcha - I thought it might have been a temporary pin

Tue, Sep 8, 7:50 PM
sashank accepted D4365: Pin pyrsistent.

Might be a good idea to have a tracking issue as well

Tue, Sep 8, 7:42 PM
sashank published D4365: Pin pyrsistent for review.
Tue, Sep 8, 7:42 PM

Mon, Sep 7

sashank updated the diff for D4360: [docs] fix multiple outputs lines.

make black

Mon, Sep 7, 8:14 PM
sashank requested changes to D4308: [docs] config overview improvements.
Mon, Sep 7, 8:02 PM
sashank accepted D4361: add bay bikes schedules to repository.
Mon, Sep 7, 8:01 PM
sashank added a comment to D4360: [docs] fix multiple outputs lines.

The error here is real - you'll need to run make black once more

Mon, Sep 7, 8:01 PM

Sat, Sep 5

sashank updated the diff for D4360: [docs] fix multiple outputs lines.

fix

Sat, Sep 5, 12:31 AM
sashank added a comment to D4360: [docs] fix multiple outputs lines.

I replied to your comment in slack with instructions. If you saw it earlier, I just edited the example I had there – I forgot the # in the startBefore and startAfter.

Sat, Sep 5, 12:01 AM
sashank accepted D4355: fix docs links.
Sat, Sep 5, 12:00 AM

Fri, Sep 4

sashank requested changes to D4360: [docs] fix multiple outputs lines.

Do you want to try using the anchor links for this one?

Fri, Sep 4, 11:48 PM
sashank committed R1:6e40d7ba0f2b: remove references to Path type from documentation (authored by aj.nadel).
remove references to Path type from documentation
Fri, Sep 4, 11:47 PM
sashank closed D4313: remove references to Path type from documentation.
Fri, Sep 4, 11:47 PM
sashank commandeered D4313: remove references to Path type from documentation.
Fri, Sep 4, 11:40 PM
sashank requested review of D4354: Git blame ignore revs.
Fri, Sep 4, 6:05 PM

Thu, Sep 3

sashank accepted D4306: [trigger-5] add UI presence for triggers in left nav, dashboard.
Thu, Sep 3, 11:57 PM
sashank accepted D4348: fix dagster-release script.
Thu, Sep 3, 11:16 PM
sashank added a comment to D4308: [docs] config overview improvements.

Sorry for the late reply here. I was thinking that we explain each of the different types here: https://docs.dagster.io/_apidocs/config with examples. It's pretty hard to understand how to use all these different types today, so it's worth doing a deeper dive into how to use them and how to build more complex schemas using a bunch of types together.

Thu, Sep 3, 10:37 PM
sashank committed R1:b0003e2634c7: Make release work with new black settings (authored by sashank).
Make release work with new black settings
Thu, Sep 3, 10:34 PM
sashank closed D4298: Make release work with new black settings.
Thu, Sep 3, 10:34 PM
sashank updated the diff for D4298: Make release work with new black settings.

up

Thu, Sep 3, 10:32 PM

Wed, Sep 2

sashank accepted D4328: add book clip art to docsite favicon.
Wed, Sep 2, 6:26 PM

Tue, Sep 1

sashank accepted D4316: remove apidoc for output_selector_schema and input_selector_schema, which no longer exist.
Tue, Sep 1, 8:39 PM

Fri, Aug 28

sashank updated the summary of D4298: Make release work with new black settings.
Fri, Aug 28, 12:23 AM
sashank published D4298: Make release work with new black settings for review.
Fri, Aug 28, 12:23 AM
sashank committed R1:acb9c58bc2a5: Format version files (authored by sashank).
Format version files
Fri, Aug 28, 12:16 AM
sashank committed R1:b04d38d36940: [Docs] 0.9.4 (authored by sashank).
[Docs] 0.9.4
Fri, Aug 28, 12:09 AM
sashank closed D4297: [Docs] 0.9.4.
Fri, Aug 28, 12:09 AM

Thu, Aug 27

sashank committed R1:0c65c9758f11: 0.9.4 (authored by sashank).
0.9.4
Thu, Aug 27, 11:51 PM
sashank accepted D4248: require explicit names for configured solids.
Thu, Aug 27, 10:10 PM
sashank accepted D4294: add local_dbt_rpc_resource to dagster_dbt.
Thu, Aug 27, 9:29 PM
sashank added inline comments to D4285: [trigger-3] Add graphql endpoint to trigger execution based off trigger name.
Thu, Aug 27, 9:01 PM
sashank accepted D4248: require explicit names for configured solids.

As discussed on slack, might want a slightly better error message instead of just a check error that also includes the name of the composite solid

Thu, Aug 27, 8:39 PM
sashank accepted D4285: [trigger-3] Add graphql endpoint to trigger execution based off trigger name.

Seems good to get this out as experimental

Thu, Aug 27, 8:38 PM

Wed, Aug 26

sashank accepted D4284: [trigger-2] host representation for triggers.
Wed, Aug 26, 7:30 PM
sashank accepted D4283: [trigger-1] define triggered execution in repository.
Wed, Aug 26, 7:28 PM
sashank added inline comments to D4283: [trigger-1] define triggered execution in repository.
Wed, Aug 26, 3:11 AM
sashank added inline comments to D4283: [trigger-1] define triggered execution in repository.
Wed, Aug 26, 1:07 AM
sashank accepted D4258: allow specifying run config in json for dagster pipeline launch cli.

Discussed different tradeoffs offline - final call on naming and merging up to you

Wed, Aug 26, 1:02 AM
sashank added inline comments to D4258: allow specifying run config in json for dagster pipeline launch cli.
Wed, Aug 26, 12:47 AM

Tue, Aug 25

sashank requested changes to D4258: allow specifying run config in json for dagster pipeline launch cli.
Tue, Aug 25, 8:29 PM

Aug 21 2020

sashank committed R1:96037ab07905: [Docs] 0.9.3 (authored by sashank).
[Docs] 0.9.3
Aug 21 2020, 12:43 AM
sashank closed D4247: [Docs] 0.9.3.
Aug 21 2020, 12:43 AM

Aug 20 2020

sashank committed R1:61661429918b: (k8s-config-3) Add more user defined k8s config tags (authored by sashank).
(k8s-config-3) Add more user defined k8s config tags
Aug 20 2020, 11:05 PM
sashank closed D4239: (k8s-config-3) Add more user defined k8s config tags.
Aug 20 2020, 11:05 PM
sashank committed R1:2ead7f450699: (k8s-config-2) Add new dagster-k8s/config tag with backcompat (authored by sashank).
(k8s-config-2) Add new dagster-k8s/config tag with backcompat
Aug 20 2020, 10:47 PM
sashank closed D4234: (k8s-config-2) Add new dagster-k8s/config tag with backcompat.
Aug 20 2020, 10:47 PM
sashank closed D4209: (k8s-config-1) Change K8s resource requirements tag to be validated using config schema.
Aug 20 2020, 10:46 PM
sashank committed R1:81d528854f36: (k8s-config-1) Change K8s resource requirements tag to be validated using… (authored by sashank).
(k8s-config-1) Change K8s resource requirements tag to be validated using…
Aug 20 2020, 10:46 PM
sashank updated the diff for D4239: (k8s-config-3) Add more user defined k8s config tags.

update config

Aug 20 2020, 10:46 PM
sashank committed R1:827988506a55: Add GraphQL API Docs (authored by sashank).
Add GraphQL API Docs
Aug 20 2020, 9:22 PM
sashank closed D4231: Add GraphQL API Docs.
Aug 20 2020, 9:22 PM
sashank updated the diff for D4231: Add GraphQL API Docs.

spelling

Aug 20 2020, 9:21 PM
sashank published D4239: (k8s-config-3) Add more user defined k8s config tags for review.
Aug 20 2020, 7:54 PM
sashank published D4234: (k8s-config-2) Add new dagster-k8s/config tag with backcompat for review.
Aug 20 2020, 7:17 PM
sashank retitled D4209: (k8s-config-1) Change K8s resource requirements tag to be validated using config schema from Change K8s resource requirements tag to be validated using config schema to (k8s-config-1) Change K8s resource requirements tag to be validated using config schema.
Aug 20 2020, 4:37 PM
sashank updated subscribers of D4178: made it unnecessary to require run config for storages when the storage has no config schema..

cc @aj.nadel bc he knows this codepath well

Aug 20 2020, 4:15 PM
sashank accepted D4154: implement configured composite solids.
Aug 20 2020, 4:11 PM
sashank accepted D4230: show partition tab on pipeline root.
Aug 20 2020, 2:18 PM
sashank added inline comments to D4231: Add GraphQL API Docs.
Aug 20 2020, 2:16 PM
sashank added a comment to D4231: Add GraphQL API Docs.

I would copy and paste into google docs or something for a spell check

Aug 20 2020, 2:11 PM
sashank accepted D4205: patch cronjob instead of deleting + creating cronjob.
Aug 20 2020, 12:08 PM
sashank requested review of D4231: Add GraphQL API Docs.
Aug 20 2020, 11:58 AM

Aug 19 2020

sashank accepted D4219: scaffold and port dagster-dbt for rpc.
Aug 19 2020, 6:57 PM

Aug 18 2020

sashank retitled D4209: (k8s-config-1) Change K8s resource requirements tag to be validated using config schema from Change resource to use config schema to Change K8s resource requirements tag to be validated using config schema.
Aug 18 2020, 9:48 PM
sashank requested review of D4209: (k8s-config-1) Change K8s resource requirements tag to be validated using config schema.
Aug 18 2020, 9:36 PM
sashank requested changes to D4154: implement configured composite solids.
Aug 18 2020, 3:02 AM
sashank accepted D4187: [partition-backfill-3] refactor partitions components into partitions folder.
Aug 18 2020, 2:58 AM

Aug 16 2020

sashank accepted D4190: use sphinx line selection syntax in mdx.

This is awesome, thank you for adding. Could you maybe add an examples of multi line selection as well as an example of startAfter and endBefore? Then we can show the team how to do it so that all of our literal includes start using it.

Aug 16 2020, 12:01 AM