Page MenuHomeElementl
People sashank

sashank (Sashank Thupukari)
DisabledAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2019, 5:19 PM (119 w, 3 d)
Roles
Administrator, Disabled

Recent Activity
View All

Jul 8 2021

• sashank abandoned D7680: [RFC] DagsterAuthManager for run attribution.
Jul 8 2021, 5:53 PM
• sashank abandoned D8628: [dagit] Update permissions to be an Enum.
Jul 8 2021, 5:52 PM

Jul 2 2021

• sashank updated the diff for D8672: Unpin urllib3 in automation.

up

Jul 2 2021, 3:30 PM
• sashank published D8672: Unpin urllib3 in automation for review.
Jul 2 2021, 3:14 PM

Jul 1 2021

• sashank accepted D8658: Changelog for 0.11.16.
Jul 1 2021, 8:13 PM
• sashank published D8658: Changelog for 0.11.16 for review.
Jul 1 2021, 8:12 PM

Jun 30 2021

• sashank updated the diff for D8628: [dagit] Update permissions to be an Enum.

up

Jun 30 2021, 11:31 PM
• sashank added a reviewer for D8628: [dagit] Update permissions to be an Enum: dish.
Jun 30 2021, 7:52 PM
• sashank published D8628: [dagit] Update permissions to be an Enum for review.
Jun 30 2021, 7:49 PM

Jun 29 2021

• sashank accepted D8415: 1/ load versioned mdx files from s3 instead of local .versioned_content folder.
Jun 29 2021, 3:55 PM
• sashank accepted D8558: 2/ load versioned images from public s3 bucket.
Jun 29 2021, 3:55 PM
• sashank accepted D8571: [docs infra] remove latest versioned content.
Jun 29 2021, 3:54 PM

Jun 26 2021

• sashank accepted D8547: [docs] pipeline execution concept page 1/.
Jun 26 2021, 6:17 PM
• sashank accepted D8538: Remove SystemCronScheduler.

RIP

Jun 26 2021, 6:16 PM
• sashank accepted D8539: Remove K8sScheduler.
Jun 26 2021, 6:15 PM

Jun 18 2021

• sashank accepted D8446: Make WorkspaceRequestContext a base class.
Jun 18 2021, 3:39 PM

Jun 16 2021

• sashank updated the diff for D8413: [docs] Fix layout issues for docs site.

up

Jun 16 2021, 7:21 PM
• sashank published D8413: [docs] Fix layout issues for docs site for review.
Jun 16 2021, 5:31 PM

Jun 3 2021

• sashank accepted D8195: Update Dagster CLI help descriptions.

Nice! Thanks for taking a thorough pass at this

Jun 3 2021, 7:13 PM

Jun 1 2021

• sashank accepted D8176: Fix mysql docs event log module.
Jun 1 2021, 3:34 PM

May 28 2021

• sashank accepted D8160: restore instance param on WorkspaceProcessContext.
May 28 2021, 5:38 PM

May 24 2021

• sashank abandoned D6504: Run complex_grpc_cycle tests in their own processs.

Really old diff that was forgotten. Will revisit testing this in a new diff given new thread safe changes

May 24 2021, 3:38 AM
• sashank added inline comments to D8042: Dagit --read-only helm support.
May 24 2021, 12:37 AM
• sashank resigned from D8042: Dagit --read-only helm support.

Flag name looks good to me. Will let @rexledesma sign off after taking a look

May 24 2021, 12:37 AM

May 21 2021

• sashank accepted D8035: add missing docs link.
May 21 2021, 11:44 PM

May 20 2021

• sashank accepted D8021: Resolve circular import issue.
May 20 2021, 8:51 PM
• sashank published D8021: Resolve circular import issue for review.
May 20 2021, 8:51 PM
• sashank updated the diff for D8004: Add --read-only flag to Dagit that turns off all mutations.

up

May 20 2021, 6:10 PM
• sashank updated the diff for D8004: Add --read-only flag to Dagit that turns off all mutations.

up

May 20 2021, 5:26 PM
• sashank updated the diff for D8004: Add --read-only flag to Dagit that turns off all mutations.

up

May 20 2021, 5:09 PM
• sashank updated the diff for D8004: Add --read-only flag to Dagit that turns off all mutations.

up

May 20 2021, 4:39 PM
• sashank updated the diff for D8004: Add --read-only flag to Dagit that turns off all mutations.

up

May 20 2021, 4:03 PM
• sashank updated the diff for D8004: Add --read-only flag to Dagit that turns off all mutations.

address dish's feedback

May 20 2021, 3:48 PM
• sashank updated the diff for D8004: Add --read-only flag to Dagit that turns off all mutations.

up

May 20 2021, 3:44 PM
• sashank updated the diff for D8004: Add --read-only flag to Dagit that turns off all mutations.

up

May 20 2021, 3:10 PM
• sashank updated the diff for D8004: Add --read-only flag to Dagit that turns off all mutations.

up

May 20 2021, 2:54 PM
• sashank updated the diff for D8004: Add --read-only flag to Dagit that turns off all mutations.

up

May 20 2021, 2:47 PM
• sashank updated the diff for D8004: Add --read-only flag to Dagit that turns off all mutations.

up

May 20 2021, 12:58 PM
• sashank updated the diff for D8004: Add --read-only flag to Dagit that turns off all mutations.

up

May 20 2021, 12:57 PM
• sashank updated the diff for D8004: Add --read-only flag to Dagit that turns off all mutations.

up

May 20 2021, 12:52 PM
• sashank updated the diff for D8004: Add --read-only flag to Dagit that turns off all mutations.

up

May 20 2021, 12:50 PM

May 19 2021

• sashank updated the diff for D8004: Add --read-only flag to Dagit that turns off all mutations.

fix typos

May 19 2021, 11:50 PM
• sashank updated the summary of D8003: [dagster-graphql] Rename readonly variants to non_launchable.
May 19 2021, 11:47 PM
• sashank published D8004: Add --read-only flag to Dagit that turns off all mutations for review.
May 19 2021, 11:46 PM
• sashank updated the diff for D8003: [dagster-graphql] Rename readonly variants to non_launchable.

up

May 19 2021, 11:41 PM
• sashank published D8003: [dagster-graphql] Rename readonly variants to non_launchable for review.
May 19 2021, 11:12 PM

May 17 2021

• sashank accepted D7910: Use route handlers instead of 404s for routing.
May 17 2021, 8:46 PM

May 14 2021

• sashank accepted D7917: [dagit] Increase hit area to expand error logs.

Looks good!

May 14 2021, 4:59 PM

May 13 2021

• sashank accepted D7905: Fix bad assert in workspace cleanup.
May 13 2021, 8:33 PM
• sashank added inline comments to D7899: Fix race condition when reload workspace is called from a background thread.
May 13 2021, 7:16 PM
• sashank accepted D7899: Fix race condition when reload workspace is called from a background thread.
May 13 2021, 6:49 PM
• sashank published D7899: Fix race condition when reload workspace is called from a background thread for review.
May 13 2021, 6:48 PM
• sashank accepted D7892: Put run coordinator instance yaml under test.
May 13 2021, 2:28 AM

May 10 2021

• sashank accepted D7846: Expose Workspace on WorkspaceProcessContext.
May 10 2021, 9:38 PM

May 7 2021

• sashank accepted D7785: [docs] use class in search config.
May 7 2021, 12:46 PM

May 6 2021

• sashank accepted D7769: Fix duplicated doc blocks on IOManagers concepts page.
May 6 2021, 6:15 PM

May 5 2021

• sashank accepted D7742: Add dagster-celery-k8s to Api docs.
May 5 2021, 3:40 PM

May 4 2021

• sashank added inline comments to D7711: Add override for env_name for TestPosgresInstance.docker_compose_up.
May 4 2021, 9:01 PM
• sashank accepted D7705: Move grpc server watcher to workspace rather than repo location.

Amazing, this is great. Thanks for improving this substantially. One small control flow comment below.

May 4 2021, 2:19 PM

May 3 2021

• sashank requested review of D7692: [easy] Fix bad merge for location subscriber.
May 3 2021, 4:17 PM
• sashank updated the diff for D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.

up

May 3 2021, 5:32 AM

Apr 30 2021

• sashank updated the diff for D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.

up

Apr 30 2021, 7:39 PM
• sashank updated the diff for D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.

up

Apr 30 2021, 6:10 PM
• sashank updated the diff for D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.

up

Apr 30 2021, 5:54 PM
• sashank planned changes to D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.
Apr 30 2021, 5:52 PM
• sashank updated the diff for D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.

up

Apr 30 2021, 5:51 PM
• sashank updated the diff for D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.

feedback

Apr 30 2021, 5:51 PM
• sashank updated the summary of D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.
Apr 30 2021, 5:41 PM
• sashank updated the diff for D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made.

feedback

Apr 30 2021, 5:40 PM
• sashank published D7682: Re-rache repository locations on WorkspaceProcessContext everytime a request is made for review.
Apr 30 2021, 5:26 PM
• sashank published D7680: [RFC] DagsterAuthManager for run attribution for review.
Apr 30 2021, 4:41 PM

Apr 29 2021

• sashank accepted D7649: [docs] remove rc versioned content.
Apr 29 2021, 6:00 PM

Apr 28 2021

• sashank accepted D7517: [Docs] Reorganize deployment pages.
Apr 28 2021, 8:24 PM

Apr 26 2021

• sashank accepted D7605: [Docs] Fix header of Solids/Pipeline testing.
Apr 26 2021, 8:06 PM

Apr 23 2021

• sashank accepted D7545: Run make build from same directory as the README.
Apr 23 2021, 1:23 AM
• sashank accepted D7554: remove unused tutorial python files.
Apr 23 2021, 1:23 AM

Apr 20 2021

• sashank accepted D7520: Add container_kwargs to DockerRunLauncher.
Apr 20 2021, 2:39 PM

Apr 19 2021

• sashank accepted D7508: Ignore the .env file.
Apr 19 2021, 8:18 PM

Apr 15 2021

• sashank accepted D7458: Add some overridable methods to ProcessGrpcServerRegistry to make it extendable to support different origin types.
Apr 15 2021, 9:57 PM

Apr 12 2021

• sashank accepted D7381: [RFC] rm all legacy_examples.
Apr 12 2021, 8:53 PM

Apr 10 2021

• sashank requested changes to D7381: [RFC] rm all legacy_examples.

Just to make sure @yuhan gets to take a look at this (she was ooo), just to make sure this doesn't have any affect on docs and the removed examples are tracked

Apr 10 2021, 6:53 PM

Apr 9 2021

• sashank abandoned D7366: Add MayHaveInstanceWeakref mixin to GrpcServerRegistry.
Apr 9 2021, 11:56 AM
• sashank published D7366: Add MayHaveInstanceWeakref mixin to GrpcServerRegistry for review.
Apr 9 2021, 11:30 AM

Apr 6 2021

• sashank accepted D7256: [docs-infra] version images.
Apr 6 2021, 2:13 PM

Apr 1 2021

• sashank accepted D7240: Allow passing in a custom GrpcServerRegistry to Workspace.
Apr 1 2021, 2:44 PM
• sashank requested review of D7258: [docs-infra] Compress images.
Apr 1 2021, 2:30 PM

Mar 31 2021

• sashank accepted D7138: [docs-infra] auto convert md images to next/image.

Very well done! This should speed up the site significantly.

Mar 31 2021, 11:12 PM
• sashank accepted D7207: [docs-infra] set up mdx prettier `yarn format`.

I like that better because on wide screens it's easier to edit. Thank you!

Mar 31 2021, 11:09 PM

Mar 30 2021

• sashank accepted D7214: [docs] refer to SolidExecutionContext.
Mar 30 2021, 6:15 PM
• sashank added a comment to D7214: [docs] refer to SolidExecutionContext.

will make it so this fails hard going foward

Mar 30 2021, 6:15 PM
• sashank added a comment to D7207: [docs-infra] set up mdx prettier `yarn format`.

require("remark-gfm"), { tablePipeAlign: false }: i disabled the GitHub Flavored Markdown's table pipe alignment bc some cells could get very long which resulted in a lot of ----------- in mdx files.

Mar 30 2021, 4:00 PM
• sashank accepted D7205: Fix inaccurate repo locations docs.
Mar 30 2021, 3:59 PM
• sashank accepted D7202: [docs-infra] check broken anchors and ban non-abs links.

🙏 🙏 🙏

Mar 30 2021, 7:05 AM

Mar 29 2021

• sashank accepted D7187: Add twitter logo to docs site.
Mar 29 2021, 8:03 PM
• sashank added a comment to D7187: Add twitter logo to docs site.

Maybe the order should be: Github, Slack, Twitter, Stack Overflow, Email

Mar 29 2021, 8:03 PM
• sashank accepted D7170: Combine RepositoryLocationHandle and RepositoryLocation.

Impressive refactor, this is much cleaner and I'm all for this.

Mar 29 2021, 5:39 PM

Mar 25 2021

• sashank accepted D7146: Fix typos and alter some working in the Solids concept section.
Mar 25 2021, 7:23 PM
• sashank added a comment to D7109: remove deprecated examples.

also, nothing changed after make snapshot - which means no literal includes in the mdx files

Mar 25 2021, 1:34 PM
• sashank accepted D7109: remove deprecated examples.
Mar 25 2021, 1:33 PM
• sashank added a comment to D7109: remove deprecated examples.

Amazing!! Feels great to get rid of these

Mar 25 2021, 1:33 PM