I wasn't able to take a close look at the code here yet, but just commenting on a few things in your description and other comments.

@sashank you think it would also be good to surface a reconcile button for new defs in the instance level scheduler page ?

Add comments

Improve wording and confirmation modal description

This is a good call out - thank you. Updated the description and made sure "required but missing" errors are still displayed correctly.

TODO from Slack conversation: improve confirmation dialogue messaging and button wording

Nice catch

Ah gotcha - I thought it might have been a temporary pin

Might be a good idea to have a tracking issue as well

make black

The error here is real - you'll need to run make black once more

fix

I replied to your comment in slack with instructions. If you saw it earlier, I just edited the example I had there – I forgot the # in the startBefore and startAfter.

Do you want to try using the anchor links for this one?

Sorry for the late reply here. I was thinking that we explain each of the different types here: https://docs.dagster.io/_apidocs/config with examples. It's pretty hard to understand how to use all these different types today, so it's worth doing a deeper dive into how to use them and how to build more complex schemas using a bunch of types together.

up

As discussed on slack, might want a slightly better error message instead of just a check error that also includes the name of the composite solid

Seems good to get this out as experimental

Discussed different tradeoffs offline - final call on naming and merging up to you

update config

spelling

cc @aj.nadel bc he knows this codepath well

I would copy and paste into google docs or something for a spell check

This is awesome, thank you for adding. Could you maybe add an examples of multi line selection as well as an example of startAfter and endBefore? Then we can show the team how to do it so that all of our literal includes start using it.