Page MenuHomePhabricator

sashank (Sashank Thupukari)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2019, 5:19 PM (51 w, 3 d)
Roles
Administrator

Recent Activity

Today

sashank committed R1:dfb79c5facf8: Change /apidocs route to /_apidocs (authored by sashank).
Change /apidocs route to /_apidocs
Fri, Jul 3, 3:35 AM
sashank closed D3753: Change /apidocs route to /_apidocs.
Fri, Jul 3, 3:35 AM
sashank updated the diff for D3753: Change /apidocs route to /_apidocs.

up

Fri, Jul 3, 2:21 AM
sashank requested review of D3753: Change /apidocs route to /_apidocs.
Fri, Jul 3, 2:15 AM

Yesterday

sashank added a comment to D3713: add postgress context variant to dagster-graphql.

Woah this cleaned up nicely, great job! Glad to see the extra boolean flag and conditional mark go away.

Thu, Jul 2, 11:22 PM
sashank added reviewers for D3713: add postgress context variant to dagster-graphql: sashank, nate.
Thu, Jul 2, 9:55 PM
sashank committed R1:5228e1c04b74: Add github links to examples (authored by sashank).
Add github links to examples
Thu, Jul 2, 8:46 PM
sashank closed D3749: Add github links to examples.
Thu, Jul 2, 8:46 PM
sashank committed R1:e85521c63691: Move pandas and dagstermill guides to overview/packages (authored by sashank).
Move pandas and dagstermill guides to overview/packages
Thu, Jul 2, 8:43 PM
sashank closed D3747: Move pandas and dagstermill guides to overview/packages.
Thu, Jul 2, 8:43 PM
sashank requested review of D3749: Add github links to examples.
Thu, Jul 2, 8:43 PM
sashank requested review of D3747: Move pandas and dagstermill guides to overview/packages.
Thu, Jul 2, 8:23 PM
sashank committed R1:6e24226af4d4: Fix scheduling section of tutorial (authored by sashank).
Fix scheduling section of tutorial
Thu, Jul 2, 8:18 PM
sashank closed D3741: Fix scheduling section of tutorial.
Thu, Jul 2, 8:18 PM
sashank committed R1:a0c461b65069: Add literalincludes for pipeline_unittesting example (authored by sashank).
Add literalincludes for pipeline_unittesting example
Thu, Jul 2, 8:17 PM
sashank closed D3743: Add literalincludes for pipeline_unittesting example.
Thu, Jul 2, 8:17 PM
sashank requested review of D3741: Fix scheduling section of tutorial.
Thu, Jul 2, 7:34 PM
sashank accepted D3745: [dagit] show repository on scoped schedule view.

Nice nice πŸ‘

Thu, Jul 2, 6:44 PM
sashank accepted D3744: bug fix.
Thu, Jul 2, 6:38 PM
sashank requested review of D3743: Add literalincludes for pipeline_unittesting example.
Thu, Jul 2, 6:11 PM
sashank added a comment to D3733: parallelize dagster_tests/.

hmm, can you just move all of the other dagster tests under dagster_tests/general_tests? then you shouldn't need the ignores, right?

Thu, Jul 2, 5:28 PM
sashank added a comment to D3713: add postgress context variant to dagster-graphql.

Nice work! It’s great to see the graphql tests finally run against Buildkite.

Thu, Jul 2, 4:11 PM
sashank requested changes to D3567: [docs] Add introduction page with code example.
Thu, Jul 2, 2:18 AM
sashank committed R1:ac76e77b00c2: 085 docs (authored by sashank).
085 docs
Thu, Jul 2, 2:15 AM
sashank closed D3682: 085 docs.
Thu, Jul 2, 2:15 AM
sashank abandoned D3730: Fix broken link test.
Thu, Jul 2, 2:11 AM
sashank added a reviewer for D3733: parallelize dagster_tests/: nate.
Thu, Jul 2, 2:09 AM

Wed, Jul 1

sashank requested review of D3730: Fix broken link test.
Wed, Jul 1, 11:44 PM
sashank committed R1:e0cd21225885: [docs] Remove landing page and /docs path (authored by sashank).
[docs] Remove landing page and /docs path
Wed, Jul 1, 11:11 PM
sashank closed D3725: [docs] Remove landing page and /docs path.
Wed, Jul 1, 11:11 PM
sashank updated the diff for D3725: [docs] Remove landing page and /docs path.

up

Wed, Jul 1, 11:09 PM
sashank updated the diff for D3725: [docs] Remove landing page and /docs path.

up

Wed, Jul 1, 11:02 PM
sashank requested review of D3725: [docs] Remove landing page and /docs path.
Wed, Jul 1, 7:44 PM
sashank added inline comments to D3698: [docs] Move examples doc under docs folder.
Wed, Jul 1, 4:14 PM

Tue, Jun 30

sashank accepted D3701: add literalincludes, add readme.md to direct traffic to docs site.
Tue, Jun 30, 4:10 PM

Mon, Jun 29

sashank accepted D3652: reconcile testing execution_queries with cli/query.

As discussed on Slack, might be worth to get rid of the scrub_key_from_dict helper and just do the dummy value replacement inline. Otherwise, looks great!

Mon, Jun 29, 6:42 PM

Sun, Jun 28

sashank requested review of D3682: 085 docs.
Sun, Jun 28, 1:36 AM

Fri, Jun 26

sashank accepted D3657: [docs] prune install section.
Fri, Jun 26, 5:54 PM
sashank requested changes to D3652: reconcile testing execution_queries with cli/query.

Awesome job consolidating these – I can tell it wasn't easy. Added an inline question about the use of the snapshot_friendly flag.

Fri, Jun 26, 5:22 PM
sashank committed R1:1bae334bbc21: 0.8.5 (authored by sashank).
0.8.5
Fri, Jun 26, 1:12 AM
sashank committed R1:397b073d40fc: 0.8.5.pre0 (authored by sashank).
0.8.5.pre0
Fri, Jun 26, 1:03 AM
sashank committed R1:6495d424acc2: [docs] hide incomplete overview sections (authored by sandyryza).
[docs] hide incomplete overview sections
Fri, Jun 26, 12:58 AM
sashank closed D3649: [docs] hide incomplete overview sections.
Fri, Jun 26, 12:58 AM
sashank commandeered D3649: [docs] hide incomplete overview sections.
Fri, Jun 26, 12:58 AM
sashank committed R1:13f6d8673aee: 0.8.5 Changelog (authored by sashank).
0.8.5 Changelog
Fri, Jun 26, 12:33 AM
sashank closed D3655: 0.8.5 Changelog.
Fri, Jun 26, 12:33 AM
sashank requested review of D3655: 0.8.5 Changelog.
Fri, Jun 26, 12:24 AM

Thu, Jun 25

sashank committed R1:0edcb68f24f2: Extract reconcile button to component (authored by sashank).
Extract reconcile button to component
Thu, Jun 25, 11:23 PM
sashank closed D3654: Extract reconcile button to component.
Thu, Jun 25, 11:23 PM
sashank updated the summary of D3654: Extract reconcile button to component.
Thu, Jun 25, 11:17 PM
sashank requested review of D3654: Extract reconcile button to component.
Thu, Jun 25, 11:16 PM
sashank committed R1:5b65f2622559: [docs] Scheduling section (authored by sashank).
[docs] Scheduling section
Thu, Jun 25, 10:12 PM
sashank closed D3651: [docs] Scheduling section.
Thu, Jun 25, 10:12 PM
sashank added a comment to D3651: [docs] Scheduling section.

Yeah good point. In reality they are pretty connected though, so I'll form the connection in the next rev

Thu, Jun 25, 10:09 PM
sashank committed R1:439971f2a19e: [docs][overview] Repository and Workspaces overview (authored by sashank).
[docs][overview] Repository and Workspaces overview
Thu, Jun 25, 9:40 PM
sashank closed D3627: [docs][overview] Repository and Workspaces overview.
Thu, Jun 25, 9:40 PM
sashank updated the diff for D3627: [docs][overview] Repository and Workspaces overview.

feedback

Thu, Jun 25, 9:34 PM
sashank requested review of D3651: [docs] Scheduling section.
Thu, Jun 25, 9:29 PM
sashank updated the diff for D3627: [docs][overview] Repository and Workspaces overview.

fix lazy loading

Thu, Jun 25, 9:26 PM
sashank accepted D3638: Add test coverage for examples.
Thu, Jun 25, 9:20 PM
sashank accepted D3633: add overview section for asset materializations / expectations.

I think this is a more than solid first pass, and can address schrock's comments in the next one. Would be great to get this landed for today's release.

Thu, Jun 25, 9:19 PM
sashank added inline comments to D3643: [docs] Overview -> Overviews.
Thu, Jun 25, 9:18 PM
sashank accepted D3643: [docs] Overview -> Overviews.
Thu, Jun 25, 9:18 PM
sashank accepted D3649: [docs] hide incomplete overview sections.
Thu, Jun 25, 9:17 PM
sashank planned changes to D3627: [docs][overview] Repository and Workspaces overview.
Thu, Jun 25, 5:07 PM
sashank committed R1:068847ca8fa5: Update example script (authored by sashank).
Update example script
Thu, Jun 25, 4:31 PM
sashank closed D3596: Update example script.
Thu, Jun 25, 4:31 PM
sashank updated the diff for D3596: Update example script.

feedback

Thu, Jun 25, 4:30 PM
sashank committed R1:a9a58353dbe1: [docs] Add packages section (authored by sashank).
[docs] Add packages section
Thu, Jun 25, 4:24 PM
sashank closed D3591: [docs] Add packages section.
Thu, Jun 25, 4:24 PM
sashank added inline comments to D3627: [docs][overview] Repository and Workspaces overview.
Thu, Jun 25, 4:18 PM
sashank added a reviewer for D3591: [docs] Add packages section: sandyryza.
Thu, Jun 25, 4:17 PM
sashank committed R1:60ca3bc119dd: [docs][overview] Principles and Types (authored by sashank).
[docs][overview] Principles and Types
Thu, Jun 25, 4:17 PM
sashank closed D3642: [docs][overview] Principles and Types.
Thu, Jun 25, 4:17 PM
sashank requested review of D3642: [docs][overview] Principles and Types.
Thu, Jun 25, 4:09 PM
sashank added inline comments to D3633: add overview section for asset materializations / expectations.
Thu, Jun 25, 4:05 PM
sashank accepted D3609: [docs] modes & resources overview.

Looks great! Solid, self contained example with the DBs πŸ‘

Thu, Jun 25, 4:01 PM
sashank updated the diff for D3627: [docs][overview] Repository and Workspaces overview.

Address feedback, fix lint errors, add tests

Thu, Jun 25, 3:47 PM
sashank accepted D3628: mark places outside examples where examples/ are mentioned.

You may want to add a simple # TODO: remove dependency on legacy_examples inline right before the issue message.

Thu, Jun 25, 3:22 PM
sashank requested changes to D3638: Add test coverage for examples.
Thu, Jun 25, 3:20 PM
sashank added a comment to D3638: Add test coverage for examples.

Looks great. These tests are supposed to show users how to test their code, so it's worth cleaning them up. What do you think about just checking pipeline success status, rather than checking that each solid was successful?

Thu, Jun 25, 3:20 PM

Wed, Jun 24

sashank accepted D3630: remove generated example mdx files.
Wed, Jun 24, 10:14 PM
sashank accepted D3626: literalinclude for pyspark examples.

Nice!

Wed, Jun 24, 10:14 PM
sashank accepted D3625: remove unused examplePaths.ts.
Wed, Jun 24, 10:14 PM
sashank requested review of D3627: [docs][overview] Repository and Workspaces overview.
Wed, Jun 24, 5:40 PM
sashank accepted D3624: gitignore generated example pages.
Wed, Jun 24, 4:31 PM
sashank accepted D3617: [docs] Add instances overview page.
Wed, Jun 24, 4:00 PM
sashank committed R1:83d6b51d53ea: Add scheduler test for adding new schedule (authored by sashank).
Add scheduler test for adding new schedule
Wed, Jun 24, 12:46 AM
sashank closed D3605: Add scheduler test for adding new schedule.
Wed, Jun 24, 12:46 AM
sashank accepted D3615: [docs] SEO: add meta tags for dynamic pages.

Niceee

Wed, Jun 24, 12:45 AM

Tue, Jun 23

sashank committed R1:f94ed13dc7d7: Remove dagster-cron from dagster tox.ini (authored by sashank).
Remove dagster-cron from dagster tox.ini
Tue, Jun 23, 8:30 PM
sashank closed D3606: Remove dagster-cron from dagster tox.ini.
Tue, Jun 23, 8:29 PM
sashank updated the diff for D3605: Add scheduler test for adding new schedule.

up

Tue, Jun 23, 8:29 PM
sashank added a comment to D3605: Add scheduler test for adding new schedule.

My bad - must have been a bad amend

Tue, Jun 23, 8:28 PM
sashank accepted D3607: [cron] refresh CronTab on each method.

Looks good. Did you see any staleness issues?

Tue, Jun 23, 8:21 PM
sashank requested review of D3605: Add scheduler test for adding new schedule.
Tue, Jun 23, 6:59 PM
sashank accepted D3608: elevate asset methods onto instance.

This is great! Nice to see all those protected accesses go away.

Tue, Jun 23, 6:43 PM
sashank committed R1:049f608f50b6: [docs] Render examples in docs (authored by sashank).
[docs] Render examples in docs
Tue, Jun 23, 6:11 PM
sashank closed D3565: [docs] Render examples in docs.
Tue, Jun 23, 6:11 PM
sashank updated the diff for D3565: [docs] Render examples in docs.

up

Tue, Jun 23, 6:00 PM