Page MenuHomeElementl

sandyryza (Sandy Ryza)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 3 2020, 4:04 PM (54 w, 1 d)

Recent Activity

Fri, Apr 16

sandyryza added a comment to D7419: Improved error message when missing config.

This will be a huge approachability and general usability win.

Fri, Apr 16, 5:52 PM
sandyryza added inline comments to D7261: [RFC] change DagsterInstance.get behavior.
Fri, Apr 16, 5:46 PM
sandyryza requested review of D7446: default config schema to Any.
Fri, Apr 16, 5:57 AM
sandyryza accepted D7468: [mypy] pipeline & graph definitions.
Fri, Apr 16, 12:37 AM

Thu, Apr 15

sandyryza requested review of D7474: clarify API doc for InputDefinition and OutputDefinition dagster_type args.
Thu, Apr 15, 10:16 PM
sandyryza closed D7386: update solid concepts page to use less boilerplate.
Thu, Apr 15, 7:46 PM
sandyryza committed R1:48acdd5abe27: update solid concepts page to use less boilerplate (authored by sandyryza).
update solid concepts page to use less boilerplate
Thu, Apr 15, 7:46 PM
sandyryza updated the diff for D7438: Revamp the configuration concept section.

address nick feedback

Thu, Apr 15, 5:19 PM
sandyryza closed D7407: advanced tutorial changes.
Thu, Apr 15, 5:00 PM
sandyryza committed R1:f829072011c0: advanced tutorial changes (authored by sandyryza).
advanced tutorial changes
Thu, Apr 15, 5:00 PM
sandyryza added inline comments to D7407: advanced tutorial changes.
Thu, Apr 15, 4:59 PM
sandyryza added inline comments to D7416: only run example tests on py3.8.
Thu, Apr 15, 4:19 PM
sandyryza updated the summary of D7407: advanced tutorial changes.
Thu, Apr 15, 4:13 PM
sandyryza updated the summary of D7407: advanced tutorial changes.
Thu, Apr 15, 4:12 PM
sandyryza closed D7445: some type annotations for config-related code.
Thu, Apr 15, 4:08 PM
sandyryza committed R1:6ede87c8c43c: some type annotations for config-related code (authored by sandyryza).
some type annotations for config-related code
Thu, Apr 15, 4:08 PM
sandyryza updated the diff for D7445: some type annotations for config-related code.

up

Thu, Apr 15, 3:41 PM
sandyryza requested review of D7438: Revamp the configuration concept section.
Thu, Apr 15, 1:14 AM
sandyryza requested review of D7445: some type annotations for config-related code.
Thu, Apr 15, 12:34 AM
sandyryza requested review of D7444: fix non-required fields in IOManager output_config_schemas.
Thu, Apr 15, 12:33 AM

Tue, Apr 13

sandyryza added a reviewer for D7416: only run example tests on py3.8: alangenfeld.
Tue, Apr 13, 10:01 PM
sandyryza requested review of D7416: only run example tests on py3.8.
Tue, Apr 13, 9:44 PM
sandyryza accepted D7399: add view switcher for directory vs flat views of the asset catalog.

Ah cool - those look good to me.

Tue, Apr 13, 9:28 PM
sandyryza added a comment to D7399: add view switcher for directory vs flat views of the asset catalog.

That icon looks good to me. I also just noticed that Finder has the four vertical lines for a non-nav use case, so maybe I'm overreacting.

Tue, Apr 13, 9:13 PM
sandyryza requested review of D7407: advanced tutorial changes.
Tue, Apr 13, 8:48 PM
sandyryza added a comment to D7399: add view switcher for directory vs flat views of the asset catalog.

Two thoughts:

  • Can we add tool-tips?
  • The four stacked lines reminds me of a hamburger menu, which makes me suspect that clicking it would open up a nav or something. I don't have any bright ideas, but is there an icon that would be less likely to have that connotation.
Tue, Apr 13, 8:07 PM
sandyryza updated the diff for D7386: update solid concepts page to use less boilerplate.

up

Tue, Apr 13, 8:03 PM
sandyryza updated the diff for D7386: update solid concepts page to use less boilerplate.

up

Tue, Apr 13, 5:32 PM
sandyryza updated the diff for D7386: update solid concepts page to use less boilerplate.

up

Tue, Apr 13, 4:29 PM
sandyryza added inline comments to D7386: update solid concepts page to use less boilerplate.
Tue, Apr 13, 3:28 PM

Mon, Apr 12

sandyryza accepted D7377: Switch partition run matrix to simpler “square color = status in last run”.

Thanks for making this change!

Mon, Apr 12, 3:34 PM
sandyryza requested review of D7386: update solid concepts page to use less boilerplate.
Mon, Apr 12, 3:26 PM
sandyryza closed D7359: "using output manager" -> "using IO manager".
Mon, Apr 12, 3:06 PM
sandyryza committed R1:fe401272f4b9: "using output manager" -> "using IO manager" (authored by sandyryza).
"using output manager" -> "using IO manager"
Mon, Apr 12, 3:06 PM
sandyryza closed D7360: f-string in getting started.
Mon, Apr 12, 3:05 PM
sandyryza committed R1:24bb5dc88ddb: f-string in getting started (authored by sandyryza).
f-string in getting started
Mon, Apr 12, 3:05 PM
sandyryza updated the summary of D7384: RFC: remove the airline demo.
Mon, Apr 12, 3:05 PM

Sat, Apr 10

sandyryza updated the summary of D7384: RFC: remove the airline demo.
Sat, Apr 10, 3:19 PM
sandyryza updated the summary of D7384: RFC: remove the airline demo.
Sat, Apr 10, 3:12 PM
sandyryza updated the summary of D7384: RFC: remove the airline demo.
Sat, Apr 10, 3:11 PM

Fri, Apr 9

sandyryza requested review of D7384: RFC: remove the airline demo.
Fri, Apr 9, 11:53 PM
sandyryza accepted D7381: [RFC] rm all legacy_examples.
Fri, Apr 9, 10:59 PM
sandyryza retitled D7359: "using output manager" -> "using IO manager" from using output manager -> using IO manager to "using output manager" -> "using IO manager".
Fri, Apr 9, 10:36 PM
sandyryza closed D7269: Improve executor/IO manager error message.
Fri, Apr 9, 8:15 PM
sandyryza committed R1:ed8f5a86c923: Improve executor/IO manager error message (authored by sandyryza).
Improve executor/IO manager error message
Fri, Apr 9, 8:15 PM
sandyryza updated the diff for D7269: Improve executor/IO manager error message.

up

Fri, Apr 9, 5:54 PM
sandyryza retitled D7269: Improve executor/IO manager error message from Add missing space in executor/IO manager error message to Improve executor/IO manager error message.
Fri, Apr 9, 5:48 PM
sandyryza abandoned D5896: build dagster graph from dbt graph.
Fri, Apr 9, 12:46 AM

Thu, Apr 8

sandyryza accepted D7347: fix optional solid config for input config.

Ok I think I now understand 85% of what's going on here. Going to settle with that and trust you on the last 15%.

Thu, Apr 8, 11:19 PM
sandyryza requested review of D7359: "using output manager" -> "using IO manager".
Thu, Apr 8, 10:17 PM
sandyryza requested review of D7360: f-string in getting started.
Thu, Apr 8, 9:48 PM
sandyryza updated the diff for D7269: Improve executor/IO manager error message.

up

Thu, Apr 8, 9:22 PM
sandyryza added a comment to D7347: fix optional solid config for input config.

I'm finding this diff a little difficult to parse - the test name refers to unsatisfied inputs, and the changes are to get_inputs_field, but the test body uses regular solid config, not solid input config?

Thu, Apr 8, 6:06 PM
sandyryza accepted D7351: [1/2] Fix re-execution if execution plan is delegated.

lgtm!

Thu, Apr 8, 5:55 PM
sandyryza added a comment to D7348: [RFC] Add all executable steps to known execution state.

step_keys_to_execute is already part of PipelineRun right? If that's the case, would we be able to just access it "statically" instead of needing to pass it via KnownState?

Thu, Apr 8, 4:38 PM
sandyryza added a comment to D6822: [execute_in_process improvements 2/n] provide resource instances, split out config and inputs..

I'm pretty happy with the direction that this has taken. My main lingering concern is the verbosity. As we've talked about before, I think it's worth exploring making nodes directly invoke-able.

Thu, Apr 8, 1:11 AM

Wed, Apr 7

sandyryza accepted D7330: better error message for @resource param issues.
Wed, Apr 7, 10:08 PM
sandyryza accepted D7342: [mypy] environment_configs.py.
Wed, Apr 7, 5:32 PM
sandyryza accepted D7338: [dagit] Backfill dialog: separate names from statuses.
Wed, Apr 7, 3:04 PM

Mon, Apr 5

sandyryza added a comment to D7248: RFC: Change asset catalog to have combined selector/filter capability.

@dish I think what bothers me in particular is the statefulness. In gmail search, if I'm not mistaken, the set of results you see are purely a function of the text that appears in the search box. If I correctly understand how this asset search box works, the filters you add inside the search box become long-lived filters that sit outside of the search box, and the results you see depend both on the contents of the search box and on the filters that sit outside the search box.

Mon, Apr 5, 4:48 PM
sandyryza added a comment to D7248: RFC: Change asset catalog to have combined selector/filter capability.

IMO this is a fairly complicated mental model for a search box, which may not match expectations of users who have used search boxes in other apps. Are there examples of this pattern in other apps that are worth comparing to? Also, would we want to use a similar pattern for a search box in our pipelines view? If the goal here is no-mouse navigation, I feel like the universal search satisfies that pretty well?

Mon, Apr 5, 3:36 PM

Sun, Apr 4

sandyryza accepted D7296: Remove no-op input defs.
Sun, Apr 4, 7:20 PM

Fri, Apr 2

sandyryza abandoned D7271: disable azure data lake storage tests.
Fri, Apr 2, 4:22 PM

Thu, Apr 1

sandyryza requested review of D7271: disable azure data lake storage tests.
Thu, Apr 1, 11:35 PM
sandyryza closed D7263: clarify apidoc for mode arg of sensor decorator.
Thu, Apr 1, 9:36 PM
sandyryza committed R1:d82b92927553: clarify apidoc for mode arg of sensor decorator (authored by sandyryza).
clarify apidoc for mode arg of sensor decorator
Thu, Apr 1, 9:36 PM
sandyryza requested review of D7263: clarify apidoc for mode arg of sensor decorator.
Thu, Apr 1, 9:11 PM

Wed, Mar 31

sandyryza closed D7217: fix doc for partitioned schedule decorators.
Wed, Mar 31, 12:53 AM
sandyryza committed R1:b37d7b994015: fix doc for partitioned schedule decorators (authored by sandyryza).
fix doc for partitioned schedule decorators
Wed, Mar 31, 12:53 AM

Tue, Mar 30

sandyryza requested review of D7217: fix doc for partitioned schedule decorators.
Tue, Mar 30, 11:48 PM
sandyryza abandoned D6271: example pipelines that read/write assets.
Tue, Mar 30, 9:23 PM
sandyryza closed D7204: expose PartitionScheduleDefinition.
Tue, Mar 30, 5:11 PM
sandyryza committed R1:395a940828a5: expose PartitionScheduleDefinition (authored by sandyryza).
expose PartitionScheduleDefinition
Tue, Mar 30, 5:11 PM
sandyryza requested review of D7204: expose PartitionScheduleDefinition.
Tue, Mar 30, 3:32 PM
sandyryza abandoned D6224: toy pipeline that generates a partitioned asset.
Tue, Mar 30, 2:26 AM
sandyryza resigned from D6017: initial async solids support.
Tue, Mar 30, 12:11 AM

Mon, Mar 29

sandyryza accepted D7165: reorient backfill progress around partitions instead of runs.
Mon, Mar 29, 3:09 PM
sandyryza closed D7167: add test for longitudinal pipeline.
Mon, Mar 29, 3:08 PM
sandyryza committed R1:7415cc3d3ce9: add test for longitudinal pipeline (authored by sandyryza).
add test for longitudinal pipeline
Mon, Mar 29, 3:08 PM

Fri, Mar 26

sandyryza requested review of D7167: add test for longitudinal pipeline.
Fri, Mar 26, 11:12 PM

Thu, Mar 25

sandyryza closed D7151: don't say we're going to deprecate file manager.
Thu, Mar 25, 9:11 PM
sandyryza committed R1:426745d3eea0: don't say we're going to deprecate file manager (authored by sandyryza).
don't say we're going to deprecate file manager
Thu, Mar 25, 9:11 PM
sandyryza requested review of D7151: don't say we're going to deprecate file manager.
Thu, Mar 25, 7:19 PM
sandyryza closed D7144: longitudinal pipeline reframing.
Thu, Mar 25, 5:54 PM
sandyryza committed R1:c8a6fb89b9a3: longitudinal pipeline reframing (authored by sandyryza).
longitudinal pipeline reframing
Thu, Mar 25, 5:54 PM
sandyryza accepted D7145: enable fromFailure toggle in backfill selector.
Thu, Mar 25, 5:54 PM
sandyryza accepted D7135: fix should_skip_step.
Thu, Mar 25, 5:16 PM
sandyryza added inline comments to D7144: longitudinal pipeline reframing.
Thu, Mar 25, 5:09 PM
sandyryza updated the diff for D7144: longitudinal pipeline reframing.

up

Thu, Mar 25, 5:09 PM
sandyryza requested review of D7144: longitudinal pipeline reframing.
Thu, Mar 25, 5:03 PM
sandyryza closed D7142: add space to instance error message.
Thu, Mar 25, 4:30 PM
sandyryza committed R1:cd48cc39e445: add space to instance error message (authored by sandyryza).
add space to instance error message
Thu, Mar 25, 4:30 PM
sandyryza requested review of D7142: add space to instance error message.
Thu, Mar 25, 4:23 PM
sandyryza closed D7120: fix Type Not Found for hint-inferred dagster types.
Thu, Mar 25, 4:04 PM
sandyryza committed R1:f28618bcfa1d: fix Type Not Found for hint-inferred dagster types (authored by sandyryza).
fix Type Not Found for hint-inferred dagster types
Thu, Mar 25, 4:04 PM

Wed, Mar 24

sandyryza requested review of D7120: fix Type Not Found for hint-inferred dagster types.
Wed, Mar 24, 9:05 PM

Tue, Mar 23

sandyryza accepted D7113: link to instance backfill page from the partition view.
Tue, Mar 23, 9:40 PM
sandyryza closed D7063: infer solid description from fn docstring if description is not set.
Tue, Mar 23, 1:50 AM
sandyryza committed R1:a10df220070d: infer solid description from fn docstring if description is not set (authored by sandyryza).
infer solid description from fn docstring if description is not set
Tue, Mar 23, 1:50 AM
sandyryza updated the summary of D7063: infer solid description from fn docstring if description is not set.
Tue, Mar 23, 1:49 AM