User Details
User Details
- User Since
- Apr 3 2020, 4:04 PM (94 w, 6 d)
- Roles
- Disabled
Aug 24 2021
Aug 24 2021
• sandyryza committed R1:211b178db535: update type annotations on context properties (authored by • sandyryza).
update type annotations on context properties
• sandyryza updated the diff for D9221: update type annotations on context properties.
up
• sandyryza committed R1:c9cb915168a4: better error when wrong type supplied in deps dictionary (authored by • sandyryza).
better error when wrong type supplied in deps dictionary
• sandyryza committed R1:2073cf90bc41: Add docstring and type annotation to merger.merge_dicts (authored by • sandyryza).
Add docstring and type annotation to merger.merge_dicts
Aug 23 2021
Aug 23 2021
• sandyryza added a comment to D9200: [crag] missing api references in graph/job/op migration guide.
@cdecarolis - ping on this in case it got lost in the github transition.
• sandyryza added a comment to D9221: update type annotations on context properties.
@cdecarolis - ping on this in case it got lost with the Github transition.
Aug 20 2021
Aug 20 2021
LGTM! Thanks for working on this @dgibson .
Aug 17 2021
Aug 17 2021
Input/OutputContext.asset_key
fix dagster-mlflow hook
Aug 16 2021
Aug 16 2021
• sandyryza requested review of D9225: better error when wrong type supplied in deps dictionary.
• sandyryza requested review of D9227: fix dagster-mlflow hook.
• sandyryza added reviewers for D9173: [crag] [RFC] accept job as a string when constructing schedules: • cdecarolis, alangenfeld.
Abandoning because this is now part of the caprisun branch.
• sandyryza planned changes to D9074: [caprisun] Run ops after assets.
• sandyryza updated the summary of D9226: Input/OutputContext.asset_key.
• sandyryza committed R1:4df4a7411bba: [demo pipelines] remove unneeded pylint disable (authored by • sandyryza).
[demo pipelines] remove unneeded pylint disable
Aug 15 2021
Aug 15 2021
Aug 14 2021
Aug 14 2021
• sandyryza requested review of D9226: Input/OutputContext.asset_key.
Aug 13 2021
Aug 13 2021
• sandyryza requested review of D9224: Add docstring and type annotation to merger.merge_dicts.
• sandyryza requested review of D9221: update type annotations on context properties.
Aug 12 2021
Aug 12 2021
• sandyryza added inline comments to D9219: [memoization 13/13] revamp memoization docs.
• sandyryza added a comment to D9219: [memoization 13/13] revamp memoization docs.
@cdecarolis would you mind submitting this as a github PR? Submitting docs changes as a github PR lets us preview the build docs using Vercel.
Aug 10 2021
Aug 10 2021
• sandyryza committed R1:c1c75887b743: [demo pipelines] remove dynamic download pipeline (authored by • sandyryza).
[demo pipelines] remove dynamic download pipeline
• sandyryza added a comment to D9217: [Memoization 10/13] Add top level exports for memoization + API reference page.
Do these have accompanying entries in the API reference?
Aug 9 2021
Aug 9 2021
• sandyryza requested review of D9215: [demo pipelines] remove dynamic download pipeline.
• sandyryza requested review of D9214: [demo pipelines] remove unneeded pylint disable.
• sandyryza added a comment to D9187: [crag] use non-Nothing inputs in crag toys.
Does this mean that unlinked inputs would generally make sense to display in an accent color now? (re: https://github.com/dagster-io/dagster/issues/4407)
• sandyryza committed R1:d68613f25f68: [crag] use non-Nothing inputs in crag toys (authored by • sandyryza).
[crag] use non-Nothing inputs in crag toys
Aug 4 2021
Aug 4 2021
• sandyryza committed R1:5b279196a578: add composite solids to graph/job/op migration guide (authored by • sandyryza).
add composite solids to graph/job/op migration guide
• sandyryza added a comment to D9195: add composite solids to graph/job/op migration guide.
@alangenfeld good point - I updated to give the graphs inputs and outputs
• sandyryza added inline comments to D9195: add composite solids to graph/job/op migration guide.
• sandyryza updated the diff for D9195: add composite solids to graph/job/op migration guide.
up
• sandyryza updated the diff for D9195: add composite solids to graph/job/op migration guide.
up
• sandyryza committed R1:4c68172cfcd0: [demo pipelines] remove slack on success hook (authored by • sandyryza).
[demo pipelines] remove slack on success hook
• sandyryza requested review of D9205: [demo pipelines] remove slack on success hook.
• sandyryza added a comment to D9203: Dockerfile/deployment instructions for deploying hacker-news to k8s.
Thanks a ton for putting this together @dgibson!
• sandyryza committed R1:56cb2f549956: [crag] add GraphDefinition to the public API (authored by • sandyryza).
[crag] add GraphDefinition to the public API
Aug 3 2021
Aug 3 2021
• sandyryza requested review of D9201: [crag] add GraphDefinition to the public API.
• sandyryza requested review of D9200: [crag] missing api references in graph/job/op migration guide.
• sandyryza committed R1:b064af1e2f94: [crag] remove job arg from partitioned schedule decorators (authored by • sandyryza).
[crag] remove job arg from partitioned schedule decorators
• sandyryza added inline comments to D9172: [crag] remove job arg from partitioned schedule decorators.
• sandyryza updated the diff for D9172: [crag] remove job arg from partitioned schedule decorators.
up
• sandyryza requested review of D9195: add composite solids to graph/job/op migration guide.
• sandyryza updated the diff for D9172: [crag] remove job arg from partitioned schedule decorators.
up
• sandyryza retitled D9187: [crag] use non-Nothing inputs in crag toys from use non-Nothing inputs in crag toys to [crag] use non-Nothing inputs in crag toys.
I like it
Aug 2 2021
Aug 2 2021
• sandyryza added reviewers for D9188: [caprisun] use @asset in the story recommender pipeline: • cdecarolis, • bengotow, • prha.
• sandyryza requested review of D9188: [caprisun] use @asset in the story recommender pipeline.
• sandyryza added reviewers for D9187: [crag] use non-Nothing inputs in crag toys: • bengotow, • cdecarolis.
• sandyryza updated the diff for D8969: [caprisun] @asset and build_assets_job.
up
• sandyryza requested review of D9187: [crag] use non-Nothing inputs in crag toys.
split up test_decorators
• sandyryza committed R1:1f936709ec27: [crag] allow non-string tag values in to_job (authored by • sandyryza).
[crag] allow non-string tag values in to_job
• sandyryza retitled D9171: [crag] allow non-string tag values in to_job from allow non-string tag values in to_job to [crag] allow non-string tag values in to_job.
• sandyryza retitled D9173: [crag] [RFC] accept job as a string when constructing schedules from [RFC] accept job as a string when constructing schedules to [crag] [RFC] accept job as a string when constructing schedules.
• sandyryza retitled D9172: [crag] remove job arg from partitioned schedule decorators from remove job arg from partitioned schedule decorators to [crag] remove job arg from partitioned schedule decorators.
• sandyryza retitled D7722: [crag] cragitize the IO manager concepts page from cragitize the IO manager concepts page to [crag] cragitize the IO manager concepts page.
• sandyryza retitled D9070: [caprisun] RepositoryDefinition.asset_definition_graph from RepositoryDefinition.asset_definition_graph to [caprisun] RepositoryDefinition.asset_definition_graph.
• sandyryza retitled D9074: [caprisun] Run ops after assets from Run ops after assets to [caprisun] Run ops after assets.
• sandyryza retitled D8969: [caprisun] @asset and build_assets_job from @asset and build_assets_job to [caprisun] @asset and build_assets_job.
• sandyryza requested review of D9172: [crag] remove job arg from partitioned schedule decorators.
• sandyryza requested review of D9184: split up test_decorators.
• sandyryza requested review of D9173: [crag] [RFC] accept job as a string when constructing schedules.
• sandyryza committed R1:5e59e859a2cd: type check failures often include two adjacent periods (authored by • sandyryza).
type check failures often include two adjacent periods
• sandyryza updated the diff for D9171: [crag] allow non-string tag values in to_job.
up
Jul 31 2021
Jul 31 2021
• sandyryza requested review of D9171: [crag] allow non-string tag values in to_job.
• sandyryza updated the diff for D9174: type check failures often include two adjacent periods.
up
• sandyryza updated the diff for D9174: type check failures often include two adjacent periods.
up
• sandyryza requested review of D9174: type check failures often include two adjacent periods.
Jul 30 2021
Jul 30 2021
I think this makes sense. I feel like there might be an edge case out there where this causes trouble, but having trouble thinking of it. With this, are we able to get rid of VersionedPickledObjectFilesystemIOManager?
I'm going to defer to others on this
Jul 29 2021
Jul 29 2021
• sandyryza requested review of D9156: [caprisun] asset in.