This will be a huge approachability and general usability win.

address nick feedback

up

Ah cool - those look good to me.

That icon looks good to me. I also just noticed that Finder has the four vertical lines for a non-nav use case, so maybe I'm overreacting.

Two thoughts:

• Can we add tool-tips?
• The four stacked lines reminds me of a hamburger menu, which makes me suspect that clicking it would open up a nav or something. I don't have any bright ideas, but is there an icon that would be less likely to have that connotation.

up

up

up

Thanks for making this change!

up

Ok I think I now understand 85% of what's going on here. Going to settle with that and trust you on the last 15%.

up

I'm finding this diff a little difficult to parse - the test name refers to unsatisfied inputs, and the changes are to get_inputs_field, but the test body uses regular solid config, not solid input config?

lgtm!

step_keys_to_execute is already part of PipelineRun right? If that's the case, would we be able to just access it "statically" instead of needing to pass it via KnownState?

I'm pretty happy with the direction that this has taken. My main lingering concern is the verbosity. As we've talked about before, I think it's worth exploring making nodes directly invoke-able.

@dish I think what bothers me in particular is the statefulness. In gmail search, if I'm not mistaken, the set of results you see are purely a function of the text that appears in the search box. If I correctly understand how this asset search box works, the filters you add inside the search box become long-lived filters that sit outside of the search box, and the results you see depend both on the contents of the search box and on the filters that sit outside the search box.

IMO this is a fairly complicated mental model for a search box, which may not match expectations of users who have used search boxes in other apps. Are there examples of this pattern in other apps that are worth comparing to? Also, would we want to use a similar pattern for a search box in our pipelines view? If the goal here is no-mouse navigation, I feel like the universal search satisfies that pretty well?

up