Page MenuHomePhabricator

rexledesma (Rex Ledesma)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 21 2020, 5:44 PM (5 w, 3 d)

Recent Activity

Yesterday

rexledesma closed D4963: Skip telemetry upload test on windows.
Thu, Oct 29, 8:01 PM
rexledesma committed R1:ea3f7388488b: Skip telemetry upload test on windows (authored by rexledesma).
Skip telemetry upload test on windows
Thu, Oct 29, 8:01 PM
rexledesma retitled D4963: Skip telemetry upload test on windows from Skip telemetry tests on windows to Skip telemetry upload test on windows.
Thu, Oct 29, 8:00 PM
rexledesma updated the diff for D4963: Skip telemetry upload test on windows.

up

Thu, Oct 29, 7:56 PM
rexledesma added inline comments to D4963: Skip telemetry upload test on windows.
Thu, Oct 29, 7:51 PM
rexledesma closed D4910: Prevent telemetry from being written in test environments.
Thu, Oct 29, 7:15 PM
rexledesma committed R1:335d294145c6: Prevent telemetry from being written in test environments (authored by rexledesma).
Prevent telemetry from being written in test environments
Thu, Oct 29, 7:15 PM
rexledesma added a comment to Tamer of YAMLs.

we love yaml 😍
humanity

Thu, Oct 29, 6:39 PM
rexledesma created Image Macro "humanity".
Thu, Oct 29, 6:38 PM
rexledesma updated the diff for D4910: Prevent telemetry from being written in test environments.

rebase

Thu, Oct 29, 6:36 PM
rexledesma retitled D4910: Prevent telemetry from being written in test environments from Prevent telemetry from being written in bk to Prevent telemetry from being written in test environments.
Thu, Oct 29, 6:33 PM
rexledesma updated the diff for D4910: Prevent telemetry from being written in test environments.

up

Thu, Oct 29, 5:46 PM

Wed, Oct 28

rexledesma added inline comments to D4920: [2/n] Add helm schema validation for Scheduler configuration.
Wed, Oct 28, 6:54 PM
rexledesma added a reviewer for D4920: [2/n] Add helm schema validation for Scheduler configuration: Restricted Project.
Wed, Oct 28, 6:52 PM
rexledesma closed D4895: [1/n] Add helm schema validation for Dagit configuration.
Wed, Oct 28, 6:51 PM
rexledesma committed R1:c91e921f0a73: [1/n] Add helm schema validation for Dagit configuration (authored by rexledesma).
[1/n] Add helm schema validation for Dagit configuration
Wed, Oct 28, 6:51 PM
rexledesma updated the diff for D4920: [2/n] Add helm schema validation for Scheduler configuration.

rebase

Wed, Oct 28, 6:45 PM
rexledesma updated the diff for D4895: [1/n] Add helm schema validation for Dagit configuration.

up

Wed, Oct 28, 6:29 PM
rexledesma updated the diff for D4895: [1/n] Add helm schema validation for Dagit configuration.

up

Wed, Oct 28, 6:28 PM
rexledesma updated the diff for D4910: Prevent telemetry from being written in test environments.

up

Wed, Oct 28, 6:21 PM
rexledesma added inline comments to D4910: Prevent telemetry from being written in test environments.
Wed, Oct 28, 6:02 PM
rexledesma updated the diff for D4910: Prevent telemetry from being written in test environments.

up

Wed, Oct 28, 8:43 AM
rexledesma updated the diff for D4910: Prevent telemetry from being written in test environments.

up

Wed, Oct 28, 8:41 AM
rexledesma added inline comments to D4895: [1/n] Add helm schema validation for Dagit configuration.
Wed, Oct 28, 1:38 AM
rexledesma added a comment to D4895: [1/n] Add helm schema validation for Dagit configuration.

@alangenfeld Thanks for the suggestion - I added a cli tool to generate the schema file. Also, the buildkite step that was added will ensure the following things:

  1. dagster-helm schema --command=apply was checked into git if there was change to the pydantic schema
  2. Our values.yaml is well formed according to our generated schema. This makes use of a deeper integration in helm, so that we can apply the schema.
Wed, Oct 28, 1:36 AM
rexledesma updated the summary of D4895: [1/n] Add helm schema validation for Dagit configuration.
Wed, Oct 28, 1:30 AM
rexledesma retitled D4920: [2/n] Add helm schema validation for Scheduler configuration from [2/n] Add helm schema for Scheduler configuration to [2/n] Add helm schema validation for Scheduler configuration.
Wed, Oct 28, 1:28 AM
rexledesma updated the diff for D4920: [2/n] Add helm schema validation for Scheduler configuration.

up

Wed, Oct 28, 1:25 AM
rexledesma updated the diff for D4920: [2/n] Add helm schema validation for Scheduler configuration.

rebase

Wed, Oct 28, 1:22 AM
rexledesma updated the diff for D4920: [2/n] Add helm schema validation for Scheduler configuration.

rebase

Wed, Oct 28, 1:16 AM
rexledesma updated the diff for D4920: [2/n] Add helm schema validation for Scheduler configuration.

rebase

Wed, Oct 28, 1:06 AM
rexledesma updated the diff for D4895: [1/n] Add helm schema validation for Dagit configuration.

rebase

Wed, Oct 28, 12:56 AM
rexledesma updated the diff for D4920: [2/n] Add helm schema validation for Scheduler configuration.

rebase

Wed, Oct 28, 12:46 AM
rexledesma updated the diff for D4895: [1/n] Add helm schema validation for Dagit configuration.

up

Wed, Oct 28, 12:40 AM
rexledesma retitled D4920: [2/n] Add helm schema validation for Scheduler configuration from [3/n] Add schema for scheduler to [2/n] Add helm schema for Scheduler configuration.
Wed, Oct 28, 12:20 AM
rexledesma updated the diff for D4920: [2/n] Add helm schema validation for Scheduler configuration.
  • use pydantic DSL
Wed, Oct 28, 12:17 AM

Tue, Oct 27

rexledesma updated the diff for D4895: [1/n] Add helm schema validation for Dagit configuration.

black

Tue, Oct 27, 10:59 PM
rexledesma retitled D4895: [1/n] Add helm schema validation for Dagit configuration from Add helm schema validation for Dagit configuration to [1/n] Add helm schema validation for Dagit configuration.
Tue, Oct 27, 10:57 PM
rexledesma abandoned D4897: Add buildkite step to validate helm schema.
Tue, Oct 27, 10:44 PM
rexledesma updated the diff for D4895: [1/n] Add helm schema validation for Dagit configuration.

ignore lint issues - https://github.com/samuelcolvin/pydantic/issues/1961

Tue, Oct 27, 10:44 PM
rexledesma updated the diff for D4895: [1/n] Add helm schema validation for Dagit configuration.
  • Adds dagster-helm cli to programatically generate schema file
  • Add buildkite from D4897
Tue, Oct 27, 10:27 PM
rexledesma removed reviewers for D4895: [1/n] Add helm schema validation for Dagit configuration: catherinewu, sashank, johann, alangenfeld, bob.
Tue, Oct 27, 7:13 PM
rexledesma added inline comments to D4895: [1/n] Add helm schema validation for Dagit configuration.
Tue, Oct 27, 7:13 PM
rexledesma requested review of D4920: [2/n] Add helm schema validation for Scheduler configuration.
Tue, Oct 27, 6:12 PM
rexledesma added reviewers for D4910: Prevent telemetry from being written in test environments: alangenfeld, nate, catherinewu.
Tue, Oct 27, 3:09 PM
rexledesma requested review of D4910: Prevent telemetry from being written in test environments.
Tue, Oct 27, 6:28 AM

Mon, Oct 26

rexledesma requested review of D4895: [1/n] Add helm schema validation for Dagit configuration.
Mon, Oct 26, 8:36 PM
rexledesma updated the diff for D4897: Add buildkite step to validate helm schema.

rebase

Mon, Oct 26, 8:20 PM
rexledesma accepted D4904: k8s-integration fix.
Mon, Oct 26, 6:50 PM

Sat, Oct 24

rexledesma requested review of D4897: Add buildkite step to validate helm schema.
Sat, Oct 24, 2:05 AM

Fri, Oct 23

rexledesma closed D4886: Fix yamllint include/exclude paths in arclint.
Fri, Oct 23, 7:54 PM
rexledesma committed R1:ae303c9356be: Fix yamllint include/exclude paths in arclint (authored by rexledesma).
Fix yamllint include/exclude paths in arclint
Fri, Oct 23, 7:54 PM
rexledesma added a comment to D4880: Add release notes url in slackbot release notification.

@max From https://dagster.phacility.com/w/releasing/, the url will be available after step (7). The slack bot sends the message on step (8). We can just shift step (11) to be before (8). Then there's one source of truth for release notes.

Fri, Oct 23, 7:53 PM
rexledesma requested review of D4886: Fix yamllint include/exclude paths in arclint.
Fri, Oct 23, 7:37 PM
rexledesma requested review of D4880: Add release notes url in slackbot release notification.
Fri, Oct 23, 12:57 AM
rexledesma closed D4862: Enforce strict rules for yamllint.
Fri, Oct 23, 12:38 AM
rexledesma committed R1:3dee7dff7076: Enforce strict rules for yamllint (authored by rexledesma).
Enforce strict rules for yamllint
Fri, Oct 23, 12:38 AM
rexledesma accepted D4879: add community contributions.
Fri, Oct 23, 12:12 AM
rexledesma published D4879: add community contributions for review.
Fri, Oct 23, 12:12 AM

Thu, Oct 22

rexledesma accepted D4877: Changelog 0.9.16.
Thu, Oct 22, 11:11 PM
rexledesma published D4877: Changelog 0.9.16 for review.
Thu, Oct 22, 11:11 PM
rexledesma updated the diff for D4862: Enforce strict rules for yamllint.

up

Thu, Oct 22, 10:08 PM
rexledesma updated the diff for D4862: Enforce strict rules for yamllint.

fix bk

Thu, Oct 22, 9:53 PM
rexledesma committed R1:25dd4aa33856: Support slackclient 2.x (authored by rexledesma).
Support slackclient 2.x
Thu, Oct 22, 9:33 PM
rexledesma closed D4873: Revert D4797.
Thu, Oct 22, 9:30 PM
rexledesma committed R1:4e96b9e44b71: Revert D4797 (authored by rexledesma).
Revert D4797
Thu, Oct 22, 9:30 PM
rexledesma added a reverting change for D4797: Support slackclient 2.x: R1:4e96b9e44b71: Revert D4797.
Thu, Oct 22, 9:30 PM
rexledesma closed D4840: [2/2] Expose config for k8s run launcher in helm chart.
Thu, Oct 22, 9:09 PM
rexledesma committed R1:78e48302acb1: [2/2] Expose config for k8s run launcher in helm chart (authored by rexledesma).
[2/2] Expose config for k8s run launcher in helm chart
Thu, Oct 22, 9:09 PM
rexledesma created Image Macro "bateman".
Thu, Oct 22, 9:03 PM
rexledesma disabled Image Macro "sweet".
Thu, Oct 22, 9:00 PM
rexledesma created Image Macro "sweet".
Thu, Oct 22, 8:59 PM
rexledesma closed D4797: Support slackclient 2.x.
Thu, Oct 22, 8:50 PM
rexledesma committed R1:a785b00781d5: Support slackclient 2.x (authored by rexledesma).
Support slackclient 2.x
Thu, Oct 22, 8:50 PM
rexledesma retitled D4797: Support slackclient 2.x from Support slackclient 2.x when the python version is 3.x to Support slackclient 2.x.
Thu, Oct 22, 8:49 PM
rexledesma closed D4718: [1/2] Configure celeryless deploy on helm.
Thu, Oct 22, 8:44 PM
rexledesma committed R1:531bcb62f2ad: [1/2] Configure celeryless deploy on helm (authored by rexledesma).
[1/2] Configure celeryless deploy on helm
Thu, Oct 22, 8:44 PM
rexledesma updated the diff for D4862: Enforce strict rules for yamllint.

add bk step

Thu, Oct 22, 8:43 PM
rexledesma added inline comments to D4718: [1/2] Configure celeryless deploy on helm.
Thu, Oct 22, 8:12 PM
rexledesma updated the diff for D4797: Support slackclient 2.x.

rebase

Thu, Oct 22, 8:10 PM
rexledesma updated the diff for D4840: [2/2] Expose config for k8s run launcher in helm chart.

update docs

Thu, Oct 22, 8:04 PM
rexledesma updated the diff for D4718: [1/2] Configure celeryless deploy on helm.

up

Thu, Oct 22, 8:01 PM
rexledesma updated the diff for D4797: Support slackclient 2.x.

up

Thu, Oct 22, 7:34 PM
rexledesma updated the diff for D4840: [2/2] Expose config for k8s run launcher in helm chart.

up

Thu, Oct 22, 7:29 PM
rexledesma updated the diff for D4862: Enforce strict rules for yamllint.

add formatter to makefile

Thu, Oct 22, 5:56 PM
rexledesma added inline comments to D4797: Support slackclient 2.x.
Thu, Oct 22, 5:06 PM
rexledesma updated the diff for D4797: Support slackclient 2.x.

remove wrapper class

Thu, Oct 22, 5:04 PM
rexledesma updated the diff for D4797: Support slackclient 2.x.

up

Thu, Oct 22, 1:08 AM
rexledesma requested review of D4862: Enforce strict rules for yamllint.
Thu, Oct 22, 12:51 AM
rexledesma updated the diff for D4840: [2/2] Expose config for k8s run launcher in helm chart.

up

Thu, Oct 22, 12:15 AM

Wed, Oct 21

rexledesma updated the diff for D4840: [2/2] Expose config for k8s run launcher in helm chart.

up

Wed, Oct 21, 10:49 PM
rexledesma updated the diff for D4797: Support slackclient 2.x.

up

Wed, Oct 21, 10:47 PM
rexledesma updated the diff for D4797: Support slackclient 2.x.

up

Wed, Oct 21, 10:45 PM
rexledesma added a comment to D4797: Support slackclient 2.x.

Looks like the consensus here is to just release it as a breaking change, without the conditional import. I guess the warning can be in the release notes lol

Wed, Oct 21, 10:29 PM
rexledesma added inline comments to D4840: [2/2] Expose config for k8s run launcher in helm chart.
Wed, Oct 21, 10:04 PM
rexledesma updated the diff for D4840: [2/2] Expose config for k8s run launcher in helm chart.

address comments

Wed, Oct 21, 9:57 PM
rexledesma added a reviewer for D4840: [2/2] Expose config for k8s run launcher in helm chart: catherinewu.
Wed, Oct 21, 2:32 AM
rexledesma requested review of D4840: [2/2] Expose config for k8s run launcher in helm chart.
Wed, Oct 21, 2:31 AM
rexledesma retitled D4797: Support slackclient 2.x from Update slackclient to >=2,<3 to Support slackclient 2.x when the python version is 3.x.
Wed, Oct 21, 12:14 AM

Tue, Oct 20

rexledesma updated the diff for D4797: Support slackclient 2.x.

use python2 syntax :(

Tue, Oct 20, 11:47 PM