User Details
User Details
- User Since
- Sep 21 2020, 5:44 PM (5 w, 3 d)
Yesterday
Yesterday
rexledesma committed R1:ea3f7388488b: Skip telemetry upload test on windows (authored by rexledesma).
Skip telemetry upload test on windows
rexledesma retitled D4963: Skip telemetry upload test on windows from Skip telemetry tests on windows to Skip telemetry upload test on windows.
rexledesma added inline comments to D4963: Skip telemetry upload test on windows.
rexledesma committed R1:335d294145c6: Prevent telemetry from being written in test environments (authored by rexledesma).
Prevent telemetry from being written in test environments
rexledesma updated the diff for D4910: Prevent telemetry from being written in test environments.
rebase
rexledesma retitled D4910: Prevent telemetry from being written in test environments from Prevent telemetry from being written in bk to Prevent telemetry from being written in test environments.
rexledesma updated the diff for D4910: Prevent telemetry from being written in test environments.
up
Wed, Oct 28
Wed, Oct 28
rexledesma added inline comments to D4920: [2/n] Add helm schema validation for Scheduler configuration.
rexledesma added a reviewer for D4920: [2/n] Add helm schema validation for Scheduler configuration: Restricted Project.
rexledesma committed R1:c91e921f0a73: [1/n] Add helm schema validation for Dagit configuration (authored by rexledesma).
[1/n] Add helm schema validation for Dagit configuration
rexledesma updated the diff for D4920: [2/n] Add helm schema validation for Scheduler configuration.
rebase
rexledesma updated the diff for D4895: [1/n] Add helm schema validation for Dagit configuration.
up
rexledesma updated the diff for D4895: [1/n] Add helm schema validation for Dagit configuration.
up
rexledesma updated the diff for D4910: Prevent telemetry from being written in test environments.
up
rexledesma added inline comments to D4910: Prevent telemetry from being written in test environments.
rexledesma updated the diff for D4910: Prevent telemetry from being written in test environments.
up
rexledesma updated the diff for D4910: Prevent telemetry from being written in test environments.
up
rexledesma added inline comments to D4895: [1/n] Add helm schema validation for Dagit configuration.
rexledesma added a comment to D4895: [1/n] Add helm schema validation for Dagit configuration.
@alangenfeld Thanks for the suggestion - I added a cli tool to generate the schema file. Also, the buildkite step that was added will ensure the following things:
- dagster-helm schema --command=apply was checked into git if there was change to the pydantic schema
- Our values.yaml is well formed according to our generated schema. This makes use of a deeper integration in helm, so that we can apply the schema.
rexledesma updated the summary of D4895: [1/n] Add helm schema validation for Dagit configuration.
rexledesma retitled D4920: [2/n] Add helm schema validation for Scheduler configuration from [2/n] Add helm schema for Scheduler configuration to [2/n] Add helm schema validation for Scheduler configuration.
rexledesma updated the diff for D4920: [2/n] Add helm schema validation for Scheduler configuration.
up
rexledesma updated the diff for D4920: [2/n] Add helm schema validation for Scheduler configuration.
rebase
rexledesma updated the diff for D4920: [2/n] Add helm schema validation for Scheduler configuration.
rebase
rexledesma updated the diff for D4920: [2/n] Add helm schema validation for Scheduler configuration.
rebase
rexledesma updated the diff for D4895: [1/n] Add helm schema validation for Dagit configuration.
rebase
rexledesma updated the diff for D4920: [2/n] Add helm schema validation for Scheduler configuration.
rebase
rexledesma updated the diff for D4895: [1/n] Add helm schema validation for Dagit configuration.
up
rexledesma retitled D4920: [2/n] Add helm schema validation for Scheduler configuration from [3/n] Add schema for scheduler to [2/n] Add helm schema for Scheduler configuration.
rexledesma updated the diff for D4920: [2/n] Add helm schema validation for Scheduler configuration.
- use pydantic DSL
Tue, Oct 27
Tue, Oct 27
rexledesma updated the diff for D4895: [1/n] Add helm schema validation for Dagit configuration.
black
rexledesma retitled D4895: [1/n] Add helm schema validation for Dagit configuration from Add helm schema validation for Dagit configuration to [1/n] Add helm schema validation for Dagit configuration.
rexledesma updated the diff for D4895: [1/n] Add helm schema validation for Dagit configuration.
ignore lint issues - https://github.com/samuelcolvin/pydantic/issues/1961
rexledesma updated the diff for D4895: [1/n] Add helm schema validation for Dagit configuration.
- Adds dagster-helm cli to programatically generate schema file
- Add buildkite from D4897
rexledesma removed reviewers for D4895: [1/n] Add helm schema validation for Dagit configuration: catherinewu, sashank, johann, alangenfeld, bob.
rexledesma added inline comments to D4895: [1/n] Add helm schema validation for Dagit configuration.
rexledesma requested review of D4920: [2/n] Add helm schema validation for Scheduler configuration.
rexledesma added reviewers for D4910: Prevent telemetry from being written in test environments: alangenfeld, nate, catherinewu.
rexledesma requested review of D4910: Prevent telemetry from being written in test environments.
Mon, Oct 26
Mon, Oct 26
rexledesma requested review of D4895: [1/n] Add helm schema validation for Dagit configuration.
rexledesma updated the diff for D4897: Add buildkite step to validate helm schema.
rebase
Sat, Oct 24
Sat, Oct 24
rexledesma requested review of D4897: Add buildkite step to validate helm schema.
Fri, Oct 23
Fri, Oct 23
rexledesma committed R1:ae303c9356be: Fix yamllint include/exclude paths in arclint (authored by rexledesma).
Fix yamllint include/exclude paths in arclint
rexledesma added a comment to D4880: Add release notes url in slackbot release notification.
@max From https://dagster.phacility.com/w/releasing/, the url will be available after step (7). The slack bot sends the message on step (8). We can just shift step (11) to be before (8). Then there's one source of truth for release notes.
rexledesma requested review of D4886: Fix yamllint include/exclude paths in arclint.
rexledesma requested review of D4880: Add release notes url in slackbot release notification.
Enforce strict rules for yamllint
rexledesma published D4879: add community contributions for review.
Thu, Oct 22
Thu, Oct 22
rexledesma published D4877: Changelog 0.9.16 for review.
Support slackclient 2.x
Revert D4797
rexledesma added a reverting change for D4797: Support slackclient 2.x: R1:4e96b9e44b71: Revert D4797.
rexledesma committed R1:78e48302acb1: [2/2] Expose config for k8s run launcher in helm chart (authored by rexledesma).
[2/2] Expose config for k8s run launcher in helm chart
Support slackclient 2.x
rexledesma retitled D4797: Support slackclient 2.x from Support slackclient 2.x when the python version is 3.x to Support slackclient 2.x.
rexledesma committed R1:531bcb62f2ad: [1/2] Configure celeryless deploy on helm (authored by rexledesma).
[1/2] Configure celeryless deploy on helm
rexledesma updated the diff for D4862: Enforce strict rules for yamllint.
add bk step
rexledesma added inline comments to D4718: [1/2] Configure celeryless deploy on helm.
rexledesma updated the diff for D4840: [2/2] Expose config for k8s run launcher in helm chart.
update docs
rexledesma updated the diff for D4718: [1/2] Configure celeryless deploy on helm.
up
rexledesma updated the diff for D4840: [2/2] Expose config for k8s run launcher in helm chart.
up
rexledesma updated the diff for D4862: Enforce strict rules for yamllint.
add formatter to makefile
rexledesma added inline comments to D4797: Support slackclient 2.x.
rexledesma updated the diff for D4797: Support slackclient 2.x.
remove wrapper class
rexledesma requested review of D4862: Enforce strict rules for yamllint.
rexledesma updated the diff for D4840: [2/2] Expose config for k8s run launcher in helm chart.
up
Wed, Oct 21
Wed, Oct 21
rexledesma updated the diff for D4840: [2/2] Expose config for k8s run launcher in helm chart.
up
rexledesma added a comment to D4797: Support slackclient 2.x.
Looks like the consensus here is to just release it as a breaking change, without the conditional import. I guess the warning can be in the release notes lol
rexledesma added inline comments to D4840: [2/2] Expose config for k8s run launcher in helm chart.
rexledesma updated the diff for D4840: [2/2] Expose config for k8s run launcher in helm chart.
address comments
rexledesma added a reviewer for D4840: [2/2] Expose config for k8s run launcher in helm chart: catherinewu.
rexledesma requested review of D4840: [2/2] Expose config for k8s run launcher in helm chart.
rexledesma retitled D4797: Support slackclient 2.x from Update slackclient to >=2,<3 to Support slackclient 2.x when the python version is 3.x.
Tue, Oct 20
Tue, Oct 20
rexledesma updated the diff for D4797: Support slackclient 2.x.
use python2 syntax :(