Page MenuHomeElementl

prha (Phil Rha)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2019, 9:56 PM (88 w, 5 d)
Roles
Administrator

Recent Activity

Fri, Apr 16

prha requested review of D7493: change run view to show compute log panel with log type toggle.
Fri, Apr 16, 11:23 PM
prha closed D7486: change test to customize timeout to minimize test flakes.
Fri, Apr 16, 9:41 PM
prha committed R1:b1b34612d917: change test to customize timeout to minimize test flakes (authored by prha).
change test to customize timeout to minimize test flakes
Fri, Apr 16, 9:41 PM
prha added reviewers for D7486: change test to customize timeout to minimize test flakes: max, alangenfeld.
Fri, Apr 16, 8:31 PM
prha requested review of D7486: change test to customize timeout to minimize test flakes.
Fri, Apr 16, 8:23 PM
prha closed D7483: fix compute log subscriptions.
Fri, Apr 16, 7:18 PM
prha committed R1:22a848c07564: fix compute log subscriptions (authored by prha).
fix compute log subscriptions
Fri, Apr 16, 7:18 PM
prha requested review of D7483: fix compute log subscriptions.
Fri, Apr 16, 5:51 PM
prha accepted D7479: Add a default gRPC timeout to better handle slow/hanging sensors in the daemon.
Fri, Apr 16, 5:00 PM
prha added a comment to D7479: Add a default gRPC timeout to better handle slow/hanging sensors in the daemon.

I think this is good. We might eventually want to fork a process for each evaluation, and then change the timeout based on the min interval? But better to make this change and then think through the ramifications of the other stuff.

Fri, Apr 16, 5:00 PM
prha accepted D7477: Fix issue with error handling in ProcessGrpcServerRegistry.
Fri, Apr 16, 3:30 PM

Thu, Apr 15

prha requested review of D7461: Show failure status with python stack trace for failed backfills.
Thu, Apr 15, 5:26 PM
prha requested review of D7460: Recover from failed backfills, populate backfill errors.
Thu, Apr 15, 5:21 PM
prha closed D7399: add view switcher for directory vs flat views of the asset catalog.
Thu, Apr 15, 4:17 AM
prha committed R1:8b04bdb2969f: add view switcher for directory vs flat views of the asset catalog (authored by prha).
add view switcher for directory vs flat views of the asset catalog
Thu, Apr 15, 4:17 AM
prha accepted D7423: [dagit] Split the bundle.
Thu, Apr 15, 4:16 AM
prha accepted D7418: [dagit] Eject CRA.

herewego

Thu, Apr 15, 4:10 AM

Wed, Apr 14

prha accepted D7433: [dagit] Fix left nav schedules/sensors filtering.
Wed, Apr 14, 10:51 PM

Tue, Apr 13

prha added a comment to D7399: add view switcher for directory vs flat views of the asset catalog.

You have to wait a little bit longer, but it's nice because it's using normal HTML instead of some popup shenanigans.

Tue, Apr 13, 9:24 PM
prha added a comment to D7414: fix dagit.

spicemustflow

Tue, Apr 13, 9:22 PM
prha added a comment to D7399: add view switcher for directory vs flat views of the asset catalog.

@sandyryza, we have titles.... do you think we need tooltips? Or were you thinking that they'd have a longer text description?

Tue, Apr 13, 9:09 PM
prha added a comment to D7395: Provide more detailed SkipReasons.

I think this makes sense. At first it was a little jarring to have the selector return a SkipReason, but I think we can get by if we have this documented reasonably.

Tue, Apr 13, 4:15 PM
prha closed D7401: correctly update runs with utc timestamps.
Tue, Apr 13, 3:30 PM
prha committed R1:a2189a056b62: correctly update runs with utc timestamps (authored by prha).
correctly update runs with utc timestamps
Tue, Apr 13, 3:30 PM
prha requested review of D7401: correctly update runs with utc timestamps.
Tue, Apr 13, 2:56 AM
prha updated the summary of D7399: add view switcher for directory vs flat views of the asset catalog.
Tue, Apr 13, 12:41 AM
prha requested review of D7399: add view switcher for directory vs flat views of the asset catalog.
Tue, Apr 13, 12:40 AM

Mon, Apr 12

prha closed D7390: fix main content margin for wide screens.
Mon, Apr 12, 4:41 PM
prha committed R1:cab3a8afaf06: fix main content margin for wide screens (authored by prha).
fix main content margin for wide screens
Mon, Apr 12, 4:41 PM
prha updated the diff for D7390: fix main content margin for wide screens.

update

Mon, Apr 12, 4:31 PM
prha closed D7315: add bulk actions to asset view, for asset wipe.
Mon, Apr 12, 4:26 PM
prha committed R1:1d56a5e726f8: add bulk actions to asset view, for asset wipe (authored by prha).
add bulk actions to asset view, for asset wipe
Mon, Apr 12, 4:26 PM
prha requested review of D7390: fix main content margin for wide screens.
Mon, Apr 12, 4:17 PM
prha accepted D7369: [dagit] Fix path prefix in dev.
Mon, Apr 12, 3:51 PM

Fri, Apr 9

prha closed D7365: fix partition run matrix to handle composite solids / dynamic solids.
Fri, Apr 9, 8:03 PM
prha committed R1:31729f5f2ce0: fix partition run matrix to handle composite solids / dynamic solids (authored by prha).
fix partition run matrix to handle composite solids / dynamic solids
Fri, Apr 9, 8:03 PM
prha added inline comments to D7365: fix partition run matrix to handle composite solids / dynamic solids.
Fri, Apr 9, 8:00 PM
prha abandoned D7372: fix the app_path_prefix on the dev server by ignoring the uninterpolated value.
Fri, Apr 9, 6:00 PM
prha requested review of D7372: fix the app_path_prefix on the dev server by ignoring the uninterpolated value.
Fri, Apr 9, 5:52 PM
prha accepted D7368: [dagit] Delete commented code in AssetView.
Fri, Apr 9, 4:01 PM
prha updated the summary of D7365: fix partition run matrix to handle composite solids / dynamic solids.
Fri, Apr 9, 2:11 AM
prha requested review of D7365: fix partition run matrix to handle composite solids / dynamic solids.
Fri, Apr 9, 1:29 AM

Thu, Apr 8

prha accepted D7355: [dagit] Break apart Asset materialization query.

This is good.

Thu, Apr 8, 8:41 PM

Wed, Apr 7

prha accepted D7344: [dagit] Asset: swap "By Partition" and "By Timestamp" default.
Wed, Apr 7, 7:34 PM
prha added inline comments to D7261: [RFC] change DagsterInstance.get behavior.
Wed, Apr 7, 7:20 PM
prha closed D7283: fix compute log tail for a base directory with spaces in the path.
Wed, Apr 7, 4:01 PM
prha committed R1:c071ca413dc1: fix compute log tail for a base directory with spaces in the path (authored by prha).
fix compute log tail for a base directory with spaces in the path
Wed, Apr 7, 4:01 PM
prha accepted D7340: pin against bad jupyter-client.
Wed, Apr 7, 4:00 PM
prha accepted D7332: Add property to storage tables to turn auto-create behavior on and off.

Consider should_autocreate_tables instead of autocreate_tables?

Wed, Apr 7, 3:45 PM

Tue, Apr 6

prha updated the summary of D7315: add bulk actions to asset view, for asset wipe.
Tue, Apr 6, 4:38 PM
prha updated the diff for D7315: add bulk actions to asset view, for asset wipe.
  • switch to button from selector
Tue, Apr 6, 4:29 PM
prha added inline comments to D7315: add bulk actions to asset view, for asset wipe.
Tue, Apr 6, 3:51 PM
prha requested review of D7283: fix compute log tail for a base directory with spaces in the path.
Tue, Apr 6, 4:08 AM
prha updated the summary of D7315: add bulk actions to asset view, for asset wipe.
Tue, Apr 6, 12:39 AM

Mon, Apr 5

prha requested review of D7315: add bulk actions to asset view, for asset wipe.
Mon, Apr 5, 11:01 PM
prha accepted D7299: [dagit] Left nav experiment cleanup.

killitwithfire

Mon, Apr 5, 5:31 PM
prha added a comment to D7248: RFC: Change asset catalog to have combined selector/filter capability.

It's definitely a little weird.

Mon, Apr 5, 5:10 PM

Fri, Apr 2

prha abandoned D7291: add fragment to chunked partitions query.
Fri, Apr 2, 10:44 PM
prha requested review of D7291: add fragment to chunked partitions query.
Fri, Apr 2, 10:29 PM
prha accepted D7290: [dagit] Disallow imports from graphql-tag.
Fri, Apr 2, 10:21 PM
prha closed D7286: pin great_expectations.
Fri, Apr 2, 8:05 PM
prha committed R1:df18ec6f171c: pin great_expectations (authored by prha).
pin great_expectations
Fri, Apr 2, 8:05 PM
prha updated the summary of D7286: pin great_expectations.
Fri, Apr 2, 7:59 PM
prha published D7286: pin great_expectations for review.
Fri, Apr 2, 7:58 PM

Thu, Apr 1

prha accepted D7260: Pass a workspace into daemon iterations rather than a gRPC server registry.
Thu, Apr 1, 10:00 PM
prha added inline comments to D7260: Pass a workspace into daemon iterations rather than a gRPC server registry.
Thu, Apr 1, 9:13 PM

Wed, Mar 31

prha requested review of D7248: RFC: Change asset catalog to have combined selector/filter capability.
Wed, Mar 31, 8:57 PM

Tue, Mar 30

prha accepted D7222: [dagit] Add id to Asset.
Tue, Mar 30, 9:37 PM
prha accepted D7219: [dagit] Downgrade faker to avoid type warnings.
Tue, Mar 30, 7:11 PM
prha accepted D7218: [dagit] Add assets to global search.
Tue, Mar 30, 7:02 PM

Mon, Mar 29

prha updated the diff for D7160: add compute log manager api to more directly expose file-like object.

rebase, kick off new bk

Mon, Mar 29, 10:13 PM
prha closed D7191: add babel plugin to resolve typescript error.
Mon, Mar 29, 8:59 PM
prha committed R1:5aaf44355937: add babel plugin to resolve typescript error (authored by prha).
add babel plugin to resolve typescript error
Mon, Mar 29, 8:59 PM
prha requested review of D7191: add babel plugin to resolve typescript error.
Mon, Mar 29, 8:45 PM
prha closed D7149: start storing last_materialization event record data.
Mon, Mar 29, 8:00 PM
prha committed R1:0918869c8297: start storing last_materialization event record data (authored by prha).
start storing last_materialization event record data
Mon, Mar 29, 8:00 PM
prha added a comment to D7149: start storing last_materialization event record data.

we need the timestamp, which is only on the event record, not the materialization

Mon, Mar 29, 7:02 PM
prha updated the diff for D7160: add compute log manager api to more directly expose file-like object.
  • add library tests
Mon, Mar 29, 5:55 PM
prha closed D7165: reorient backfill progress around partitions instead of runs.
Mon, Mar 29, 3:31 PM
prha committed R1:85ccd17b64ea: reorient backfill progress around partitions instead of runs (authored by prha).
reorient backfill progress around partitions instead of runs
Mon, Mar 29, 3:31 PM
prha closed D7127: change sensor/schedule/backfill grpc calls to use streaming query to avoid limit on message size.
Mon, Mar 29, 3:24 AM
prha committed R1:2d1cdb460dda: change sensor/schedule/backfill grpc calls to use streaming query to avoid… (authored by prha).
change sensor/schedule/backfill grpc calls to use streaming query to avoid…
Mon, Mar 29, 3:24 AM

Fri, Mar 26

prha retitled D7127: change sensor/schedule/backfill grpc calls to use streaming query to avoid limit on message size from change sensors evaluation grpc call to use streaming query to change sensor/schedule/backfill grpc calls to use streaming query to avoid limit on message size.
Fri, Mar 26, 11:40 PM
prha accepted D7167: add test for longitudinal pipeline.
Fri, Mar 26, 11:28 PM
prha updated the diff for D7127: change sensor/schedule/backfill grpc calls to use streaming query to avoid limit on message size.

add schedule streaming
add backfill partition set config

Fri, Mar 26, 11:26 PM
prha requested review of D7165: reorient backfill progress around partitions instead of runs.
Fri, Mar 26, 8:42 PM
prha added a comment to D7160: add compute log manager api to more directly expose file-like object.

Motivation I think might be related to commercialization? https://github.com/dagster-io/dagster/issues/3935

Fri, Mar 26, 7:54 PM
prha requested review of D7160: add compute log manager api to more directly expose file-like object.
Fri, Mar 26, 5:22 PM
prha added a comment to D7127: change sensor/schedule/backfill grpc calls to use streaming query to avoid limit on message size.

yeah, actually not sure about breaking changes.... should I first add a separate endpoint with the streaming response, then switch the client in a later release?

Fri, Mar 26, 3:58 PM

Thu, Mar 25

prha requested review of D7149: start storing last_materialization event record data.
Thu, Mar 25, 7:11 PM
prha closed D7145: enable fromFailure toggle in backfill selector.
Thu, Mar 25, 5:56 PM
prha committed R1:9227c5e783ab: enable fromFailure toggle in backfill selector (authored by prha).
enable fromFailure toggle in backfill selector
Thu, Mar 25, 5:56 PM
prha requested review of D7145: enable fromFailure toggle in backfill selector.
Thu, Mar 25, 5:29 PM
prha accepted D7144: longitudinal pipeline reframing.
Thu, Mar 25, 5:27 PM
prha added inline comments to D7144: longitudinal pipeline reframing.
Thu, Mar 25, 5:05 PM

Wed, Mar 24

prha added a comment to D7127: change sensor/schedule/backfill grpc calls to use streaming query to avoid limit on message size.

As I was writing this diff up, I was even kind of thinking that there's no reason not to make this streaming call the default implementation (unless I'm missing something) for all grpc calls. Any particular grpc request could plausible return a problematically large payload, and we'd have to think about how to handle how to chop that up.

Wed, Mar 24, 9:04 PM
prha added a comment to D7127: change sensor/schedule/backfill grpc calls to use streaming query to avoid limit on message size.

I kinda viewed this as more of a "how do we get around the max request size" problem rather than a logical grouping problem. This solves both the large number of run requests problem as well as the not that many run requests but *really* large config.

Wed, Mar 24, 9:01 PM
prha accepted D7124: [dagster-graphql] EventIntMetadataEntry.intRepr.

I'm sad we have to think about this.... we may need to consider adding some disclaimers on some of the numeric graph displays precision, but could be a later-problem

Wed, Mar 24, 7:24 PM
prha requested review of D7127: change sensor/schedule/backfill grpc calls to use streaming query to avoid limit on message size.
Wed, Mar 24, 7:16 PM
prha closed D7116: Add check-manifest tests for package contents.
Wed, Mar 24, 3:18 PM