Page MenuHomePhabricator

prha (Phil Rha)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2019, 9:56 PM (68 w, 5 d)
Roles
Administrator

Recent Activity

Wed, Nov 25

prha committed R1:7f347aecd782: fix toy sensor directory name (authored by prha).
fix toy sensor directory name
Wed, Nov 25, 8:45 PM
prha closed D5301: fix bug in toy sensor.
Wed, Nov 25, 8:38 PM
prha committed R1:dee511780178: fix bug in toy sensor (authored by prha).
fix bug in toy sensor
Wed, Nov 25, 8:38 PM
prha published D5301: fix bug in toy sensor for review.
Wed, Nov 25, 8:37 PM
prha closed D5296: add sensor mutation, fix sensorOrError.
Wed, Nov 25, 6:32 PM
prha committed R1:d255c089b844: add sensor mutation, fix sensorOrError (authored by prha).
add sensor mutation, fix sensorOrError
Wed, Nov 25, 6:32 PM
prha requested review of D5296: add sensor mutation, fix sensorOrError.
Wed, Nov 25, 6:08 PM
prha closed D5294: fix sensor argument.
Wed, Nov 25, 5:18 PM
prha committed R1:3d7672e89b43: fix sensor argument (authored by prha).
fix sensor argument
Wed, Nov 25, 5:18 PM
prha published D5294: fix sensor argument for review.
Wed, Nov 25, 5:16 PM
prha closed D5262: [sensors-9] add graphql queries for jobs / sensors.
Wed, Nov 25, 6:41 AM
prha committed R1:f9e2bf39ba96: [sensors-9] add graphql queries for jobs / sensors (authored by prha).
[sensors-9] add graphql queries for jobs / sensors
Wed, Nov 25, 6:41 AM
prha updated the diff for D5262: [sensors-9] add graphql queries for jobs / sensors.

web schema

Wed, Nov 25, 6:16 AM
prha updated the diff for D5262: [sensors-9] add graphql queries for jobs / sensors.

update

Wed, Nov 25, 5:29 AM
prha updated the diff for D5262: [sensors-9] add graphql queries for jobs / sensors.

resolve weird graphql tests

Wed, Nov 25, 2:57 AM

Tue, Nov 24

prha planned changes to D5262: [sensors-9] add graphql queries for jobs / sensors.
Tue, Nov 24, 11:56 PM
prha added a comment to D5262: [sensors-9] add graphql queries for jobs / sensors.

Actually, I got rid of jobs and made it specifically sensors. Can combine them pretty easily if we want to start merging them together.

Tue, Nov 24, 11:27 PM
prha updated the diff for D5262: [sensors-9] add graphql queries for jobs / sensors.

update

Tue, Nov 24, 11:26 PM
prha accepted D5221: asset catalog overview.
Tue, Nov 24, 11:06 PM
prha closed D5215: [sensors-8] file toy sensor.
Tue, Nov 24, 10:59 PM
prha committed R1:da1919436131: [sensors-8] file toy sensor (authored by prha).
[sensors-8] file toy sensor
Tue, Nov 24, 10:58 PM
prha closed D5228: [sensors-7.5] rename SensorRunParams/SensorSkipData => RunRequest/SkipReason.
Tue, Nov 24, 10:57 PM
prha committed R1:a88b71f9eba9: [sensors-7.5] rename SensorRunParams/SensorSkipData => RunRequest/SkipReason (authored by prha).
[sensors-7.5] rename SensorRunParams/SensorSkipData => RunRequest/SkipReason
Tue, Nov 24, 10:57 PM
prha closed D5140: [sensors-7] external job storage for schedules.
Tue, Nov 24, 9:25 PM
prha committed R1:9ac680e84561: [sensors-7] external job storage for schedules (authored by prha).
[sensors-7] external job storage for schedules
Tue, Nov 24, 9:25 PM
prha updated the diff for D5215: [sensors-8] file toy sensor.

rebase

Tue, Nov 24, 9:16 PM
prha closed D5117: [sensors-6] add cli test command.
Tue, Nov 24, 9:14 PM
prha committed R1:83c5687e9a76: [sensors-6] add cli test command (authored by prha).
[sensors-6] add cli test command
Tue, Nov 24, 9:14 PM
prha updated the diff for D5228: [sensors-7.5] rename SensorRunParams/SensorSkipData => RunRequest/SkipReason.

update

Tue, Nov 24, 9:12 PM
prha updated the diff for D5140: [sensors-7] external job storage for schedules.

pylint

Tue, Nov 24, 9:04 PM
prha updated the diff for D5140: [sensors-7] external job storage for schedules.

rebase

Tue, Nov 24, 8:56 PM
prha updated the diff for D5117: [sensors-6] add cli test command.

rebase

Tue, Nov 24, 8:52 PM
prha committed R1:ecc475d2b232: [sensors-5] Redefine sensors in terms of SensorTickData / SensorRunParams (authored by prha).
[sensors-5] Redefine sensors in terms of SensorTickData / SensorRunParams
Tue, Nov 24, 8:41 PM
prha added a reverting change for R1:ba4f320f6236: [sensors-5] Redefine sensors in terms of SensorTickData / SensorRunParams: R1:c3496ef9464f: Revert "[sensors-5] Redefine sensors in terms of SensorTickData /….
Tue, Nov 24, 6:27 PM
prha added a reverting change for D5026: [sensors-5] Redefine sensors in terms of SensorTickData / SensorRunParams: R1:c3496ef9464f: Revert "[sensors-5] Redefine sensors in terms of SensorTickData /….
Tue, Nov 24, 6:27 PM
prha committed R1:c3496ef9464f: Revert "[sensors-5] Redefine sensors in terms of SensorTickData /… (authored by prha).
Revert "[sensors-5] Redefine sensors in terms of SensorTickData /…
Tue, Nov 24, 6:27 PM
prha updated the diff for D5228: [sensors-7.5] rename SensorRunParams/SensorSkipData => RunRequest/SkipReason.

rename execution_key => run_key

Tue, Nov 24, 6:10 PM
prha updated the diff for D5117: [sensors-6] add cli test command.

rebase

Tue, Nov 24, 6:04 PM
prha closed D5026: [sensors-5] Redefine sensors in terms of SensorTickData / SensorRunParams.
Tue, Nov 24, 5:57 PM
prha committed R1:ba4f320f6236: [sensors-5] Redefine sensors in terms of SensorTickData / SensorRunParams (authored by prha).
[sensors-5] Redefine sensors in terms of SensorTickData / SensorRunParams
Tue, Nov 24, 5:57 PM
prha updated the diff for D5026: [sensors-5] Redefine sensors in terms of SensorTickData / SensorRunParams.

enforce execution key parameter

Tue, Nov 24, 5:34 PM
prha updated the diff for D5228: [sensors-7.5] rename SensorRunParams/SensorSkipData => RunRequest/SkipReason.

pylint

Tue, Nov 24, 5:12 PM
prha added inline comments to D5026: [sensors-5] Redefine sensors in terms of SensorTickData / SensorRunParams.
Tue, Nov 24, 5:00 PM
prha updated the diff for D5026: [sensors-5] Redefine sensors in terms of SensorTickData / SensorRunParams.

dgibson

Tue, Nov 24, 5:00 PM
prha retitled D5228: [sensors-7.5] rename SensorRunParams/SensorSkipData => RunRequest/SkipReason from RFC: rename SensorRunParams/SensorSkipData => RunParams/RunSkippedData to [sensors-7.5] rename SensorRunParams/SensorSkipData => RunRequest/SkipReason.
Tue, Nov 24, 4:12 PM
prha updated the diff for D5228: [sensors-7.5] rename SensorRunParams/SensorSkipData => RunRequest/SkipReason.

update

Tue, Nov 24, 4:02 PM
prha updated the diff for D5140: [sensors-7] external job storage for schedules.

rebase

Tue, Nov 24, 3:36 PM
prha updated the summary of D5262: [sensors-9] add graphql queries for jobs / sensors.
Tue, Nov 24, 3:12 PM
prha requested review of D5262: [sensors-9] add graphql queries for jobs / sensors.
Tue, Nov 24, 3:08 PM
prha accepted D5248: Pull out logic for determining next ticks from scheduler to ExternalSchedule.
Tue, Nov 24, 2:51 PM
prha accepted D5250: Add FutureTicks connection to ScheduleDefinition.

I think this looks good and we should merge to unblock the frontend.

Tue, Nov 24, 1:55 AM

Mon, Nov 23

prha added inline comments to D5221: asset catalog overview.
Mon, Nov 23, 11:52 PM
prha updated the diff for D5117: [sensors-6] add cli test command.

rebase, update

Mon, Nov 23, 11:11 PM
prha requested review of D5026: [sensors-5] Redefine sensors in terms of SensorTickData / SensorRunParams.
Mon, Nov 23, 11:07 PM
prha updated the diff for D5026: [sensors-5] Redefine sensors in terms of SensorTickData / SensorRunParams.

update, add run tag checking to help with sensor failure recovery, added tests

Mon, Nov 23, 10:44 PM
prha updated the diff for D5026: [sensors-5] Redefine sensors in terms of SensorTickData / SensorRunParams.

rebase

Mon, Nov 23, 5:43 PM
prha closed D5022: [sensors-4] add sensors to scheduler event loop.
Mon, Nov 23, 3:49 PM
prha committed R1:1c105eaad5b6: [sensors-4] add sensors to scheduler event loop (authored by prha).
[sensors-4] add sensors to scheduler event loop
Mon, Nov 23, 3:49 PM
prha updated the diff for D5022: [sensors-4] add sensors to scheduler event loop.

undo bad rebase

Mon, Nov 23, 3:46 PM
prha closed D5020: [sensors-3] add sensor cli, stored state.
Mon, Nov 23, 3:41 PM
prha committed R1:49f333c06f9c: [sensors-3] add sensor cli, stored state (authored by prha).
[sensors-3] add sensor cli, stored state
Mon, Nov 23, 3:41 PM
prha closed D5019: [sensors-2] sensor def.
Mon, Nov 23, 3:34 PM
prha committed R1:549b4d42a377: [sensors-2] sensor def (authored by prha).
[sensors-2] sensor def
Mon, Nov 23, 3:34 PM
prha updated the diff for D5022: [sensors-4] add sensors to scheduler event loop.

rebase

Mon, Nov 23, 3:32 PM
prha updated the diff for D5022: [sensors-4] add sensors to scheduler event loop.

rebase

Mon, Nov 23, 3:29 PM
prha updated the diff for D5020: [sensors-3] add sensor cli, stored state.

rebase

Mon, Nov 23, 3:13 PM
prha updated the diff for D5019: [sensors-2] sensor def.

rebase

Mon, Nov 23, 3:04 PM
prha committed R1:ac3a79e6da8e: [sensors-1] redefine schedules as jobs (authored by prha).
[sensors-1] redefine schedules as jobs
Mon, Nov 23, 2:52 PM

Sat, Nov 21

prha added a reverting change for D5011: [sensors-1] redefine schedules as jobs: R1:da65e1da65d2: Revert "[sensors-1] redefine schedules as jobs".
Sat, Nov 21, 4:29 AM
prha added a reverting change for R1:7e4c53bd2498: [sensors-1] redefine schedules as jobs: R1:da65e1da65d2: Revert "[sensors-1] redefine schedules as jobs".
Sat, Nov 21, 4:29 AM
prha committed R1:da65e1da65d2: Revert "[sensors-1] redefine schedules as jobs" (authored by prha).
Revert "[sensors-1] redefine schedules as jobs"
Sat, Nov 21, 4:29 AM
prha closed D5011: [sensors-1] redefine schedules as jobs.
Sat, Nov 21, 2:27 AM
prha committed R1:7e4c53bd2498: [sensors-1] redefine schedules as jobs (authored by prha).
[sensors-1] redefine schedules as jobs
Sat, Nov 21, 2:27 AM

Fri, Nov 20

prha closed D5222: Remove graphql support for schedule-level run config.
Fri, Nov 20, 11:45 PM
prha committed R1:2e934b7fe4c4: Remove graphql support for schedule-level run config (authored by prha).
Remove graphql support for schedule-level run config
Fri, Nov 20, 11:44 PM
prha added inline comments to D5083: [Asset Store Versioning 3 of 3] Enable use of asset store to decide which steps to rerun during memoized execution, and enable retrieval of versioned assets..
Fri, Nov 20, 11:41 PM
prha updated the diff for D5222: Remove graphql support for schedule-level run config.

pylint

Fri, Nov 20, 11:26 PM
prha updated the diff for D5222: Remove graphql support for schedule-level run config.

rip out ScheduleExecutionDataMode

Fri, Nov 20, 11:21 PM
prha updated the diff for D5215: [sensors-8] file toy sensor.

fstrings

Fri, Nov 20, 10:57 PM
prha updated the diff for D5215: [sensors-8] file toy sensor.

update

Fri, Nov 20, 10:52 PM
prha requested review of D5228: [sensors-7.5] rename SensorRunParams/SensorSkipData => RunRequest/SkipReason.
Fri, Nov 20, 10:43 PM
prha requested review of D5222: Remove graphql support for schedule-level run config.
Fri, Nov 20, 8:00 PM
prha added a comment to D5208: [dagit] Clean up some dead code.

cleanup

Fri, Nov 20, 7:44 PM
prha accepted D5208: [dagit] Clean up some dead code.
Fri, Nov 20, 7:44 PM
prha abandoned D5210: fixup repo code pointer.
Fri, Nov 20, 7:32 PM
prha accepted D5220: [dagit] Remove config/playground affordances for Schedules.
Fri, Nov 20, 7:14 PM
prha requested changes to D5220: [dagit] Remove config/playground affordances for Schedules.

Can you also remove FETCH_SCHEDULE_YAML?

Fri, Nov 20, 6:05 PM
prha accepted D4941: Split RepositoryOrigin/PipelineOrigin hierarchy into ExternalOrigins and PythonOrigins.
Fri, Nov 20, 5:55 PM
prha added inline comments to D5215: [sensors-8] file toy sensor.
Fri, Nov 20, 4:43 PM
prha requested review of D5215: [sensors-8] file toy sensor.
Fri, Nov 20, 3:48 PM
prha updated the diff for D5210: fixup repo code pointer.

use metadata dict

Fri, Nov 20, 3:43 PM

Thu, Nov 19

prha updated the diff for D5140: [sensors-7] external job storage for schedules.

fix graphql error

Thu, Nov 19, 11:32 PM
prha updated the diff for D5140: [sensors-7] external job storage for schedules.

fix rebase issues

Thu, Nov 19, 11:15 PM
prha added a comment to D4941: Split RepositoryOrigin/PipelineOrigin hierarchy into ExternalOrigins and PythonOrigins.

See https://dagster.phacility.com/D5210 (or commandeer)

Thu, Nov 19, 11:06 PM
prha requested review of D5210: fixup repo code pointer.
Thu, Nov 19, 10:19 PM
prha requested changes to D4941: Split RepositoryOrigin/PipelineOrigin hierarchy into ExternalOrigins and PythonOrigins.
Thu, Nov 19, 9:03 PM
prha added a comment to D5198: fix step restart atempts stats calculation.

Should note that there is a logical difference here in the attempts count, depending on what the right behavior is when there is no start event

Thu, Nov 19, 8:37 PM
prha accepted D5198: fix step restart atempts stats calculation.
Thu, Nov 19, 8:34 PM
prha updated the diff for D5140: [sensors-7] external job storage for schedules.

rebased on top of D4941

Thu, Nov 19, 8:08 PM
prha accepted D5199: [dagit] Fix pipeline explorer invocation table.
Thu, Nov 19, 7:57 PM