- User Since
- Aug 5 2019, 9:56 PM (47 w, 3 d)
update changes, docs
- switch tests to pass in overriding remove_path_fn instead of using mocks
- rename fn_name
- add python package load-from arg
On reflection, I think the only reason that person in #general hit that case (CWD-dependent imports) was because we were manually adding the working directory to the path in python_modules/dagster/dagster/cli/__init__.py.
clean up, simplify path manipulation, add more comments
check against ImportError instead, to support py27
add mock to stub out sys.path replacements
remove ability to load modules resolved by local directory
Wed, Jul 1
- add test, address schema query
- resolve introspection query
- comments, changes
Tue, Jun 30
This looks great. We should fix the cursor typo, but o.w. lgtm
Mon, Jun 29
- split out directory-aware module code pointer
- remove default working directory, resolve working_directory relative to workspace.yaml
Yeah, I think we need to somehow force a schedule reconcile upon version update.
Also, yes, the defaults are the part that I'm most unsure about...
I'm not sure about changing the file-based code pointer... What's the error case we're handling there? I guess the name working_directory could mean that it should allow relative paths there...
- add working directory to origin repo args
Fri, Jun 26
I made sure we had a test for loading relative modules, but found it hard to test some of the other flows involving PYTHONPATH...
Thu, Jun 25
Wed, Jun 24
Can also approve this if you want this to be separate diffs....
I think for completeness, you probably want to be able to query this off of the preset in graphql in the ConfigEditorConfigPicker, similar to the partition tags (except no need to make the call over the API). This should pre-fill the tag section in the playground.
Tue, Jun 23
restored wrapping *ErrorData namedtuples
Mon, Jun 22
What tests were failing? Just trying to get a sense of when this would pop up...
Sat, Jun 20
Fri, Jun 19
feel free to comment with your own changes and will add them in...
- split out error class
Okay. I *think* this is causing some confusion because it's easy to confuse attempts with runs and execution time with partition date. I think something that looks more like a streaming logfile that people need to click into to debug would be more useful.