Page MenuHomeElementl

prha (Phil Rha)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2019, 9:56 PM (98 w, 1 d)
Roles
Administrator

Recent Activity

Sat, Jun 19

prha accepted D8455: Pin dagster-XXX libraries to the same version as dagster.

Yeah, I think this makes sense.

Sat, Jun 19, 1:40 AM
prha accepted D8464: get rid of 'environment config' phrasing.
Sat, Jun 19, 1:39 AM

Fri, Jun 18

prha closed D8448: remove 0.11.14 pre-release version from the docs version.
Fri, Jun 18, 3:18 PM
prha committed R1:8fbab1904209: remove 0.11.14 pre-release version from the docs version (authored by prha).
remove 0.11.14 pre-release version from the docs version
Fri, Jun 18, 3:18 PM
prha requested review of D8448: remove 0.11.14 pre-release version from the docs version.
Fri, Jun 18, 1:55 AM

Thu, Jun 17

prha accepted D8423: rename StoredEventRecord -> EventLogRecord.
Thu, Jun 17, 9:25 PM
prha closed D8438: 0.11.14 changelog.
Thu, Jun 17, 7:49 PM
prha committed R1:5e3f834e05a6: 0.11.14 changelog (authored by prha).
0.11.14 changelog
Thu, Jun 17, 7:49 PM
prha requested review of D8438: 0.11.14 changelog.
Thu, Jun 17, 7:32 PM
prha accepted D8418: get_event_rows -> get_event_records.
Thu, Jun 17, 5:33 PM
prha requested changes to D8362: rename SensorExecutionContext to SensorEvaluationContext.

returning for queue management

Thu, Jun 17, 5:31 PM
prha requested changes to D8423: rename StoredEventRecord -> EventLogRecord.

Would feel more comfortable with this being EventLogRecord (as per the discussion in D8422)

Thu, Jun 17, 2:23 PM
prha accepted D8422: rename EventRecord -> EventLogEntry.
Thu, Jun 17, 2:22 PM
prha added inline comments to D8422: rename EventRecord -> EventLogEntry.
Thu, Jun 17, 4:17 AM

Wed, Jun 16

prha added a comment to D8387: RFC: single asset sensor definition.

Yes, we'll have to provide a way to handle multi-asset sensors, but I think the guarantees provided by the single asset API are valuable enough that this should be pulled out separately.

Wed, Jun 16, 10:59 PM
prha closed D8383: ensure legacy `Materialization` event has a default tags value.
Wed, Jun 16, 7:07 PM
prha committed R1:56a4240675ce: ensure legacy `Materialization` event has a default tags value (authored by prha).
ensure legacy `Materialization` event has a default tags value
Wed, Jun 16, 7:06 PM

Tue, Jun 15

prha requested review of D8387: RFC: single asset sensor definition.

^^ spurious

Tue, Jun 15, 10:11 PM
prha requested review of D8383: ensure legacy `Materialization` event has a default tags value.

spurious ^^

Tue, Jun 15, 8:49 PM
prha requested review of D8385: RFC: add instance log manager interface.
Tue, Jun 15, 6:25 PM
prha added a comment to D8362: rename SensorExecutionContext to SensorEvaluationContext.

I think this looks good, but now just concerned about whether we can land this without announcing a breaking change. It's a pretty trivial transform (codemod), but we will break folks who are using typing for their evaluation function signatures.

Tue, Jun 15, 6:13 PM
prha accepted D7895: monitor sensor 4/[dagit] show origin runs on the sensor's page.
Tue, Jun 15, 12:06 AM

Mon, Jun 14

prha added a comment to D8362: rename SensorExecutionContext to SensorEvaluationContext.

+1 on moving way from ExecutionContext.

Mon, Jun 14, 7:40 PM
prha accepted D8303: [dagit] More optimistic switch behavior for schedules/sensors.
Mon, Jun 14, 5:22 PM
prha added inline comments to D8324: get_stored_events and get_stored_runs.
Mon, Jun 14, 5:22 PM
prha closed D8354: add option to skip uploading empty files to improve perf with minio.
Mon, Jun 14, 3:53 PM
prha committed R1:288c4c072ea4: add option to skip uploading empty files to improve perf with minio (authored by prha).
add option to skip uploading empty files to improve perf with minio
Mon, Jun 14, 3:53 PM

Fri, Jun 11

prha requested review of D8354: add option to skip uploading empty files to improve perf with minio.
Fri, Jun 11, 11:30 PM
prha accepted D8334: [dagit] Clean up package.jsons.
Fri, Jun 11, 5:20 PM
prha accepted D8342: [dagit] Upgrade to Typescript 4.3.2.
Fri, Jun 11, 4:43 PM
prha abandoned D8338: RETEST: Add CLI command to reset migration state.
Fri, Jun 11, 2:30 AM
prha added a comment to D8321: Add CLI command to reset migration state.

This isn't the cleanest solution, because it requires a bunch of manual resolving, but I don't think there's a better way of building up this mapping.

Fri, Jun 11, 2:28 AM
prha requested review of D8338: RETEST: Add CLI command to reset migration state.
Fri, Jun 11, 12:47 AM
prha updated the diff for D8321: Add CLI command to reset migration state.

add mapping from dagster version => alembic version on a per-storage basis

Fri, Jun 11, 12:38 AM

Thu, Jun 10

prha added a comment to D8283: [crag] partitions on modes.

We talked about this a bit offline. I think this is right. The partition space doesn't make much sense independent of the pipeline, in that it provides the config for a pipeline execution which must be mode-aware.

Thu, Jun 10, 10:24 PM
prha planned changes to D8321: Add CLI command to reset migration state.

Oh, I have an idea of how to do this mapping....

Thu, Jun 10, 7:33 PM
prha added a comment to D8321: Add CLI command to reset migration state.

^^ spurious

Thu, Jun 10, 7:31 PM
prha updated the diff for D8321: Add CLI command to reset migration state.

fix black

Thu, Jun 10, 7:02 PM
prha updated the diff for D8321: Add CLI command to reset migration state.

add backcompat tests for resetting all snapshots and reapplying

Thu, Jun 10, 6:14 PM
prha added a comment to D8321: Add CLI command to reset migration state.

The specific migration revision is a bit tricky, because you could have three different physical dbs for the different storages, all with a different alembic version.

Thu, Jun 10, 6:13 PM
prha requested review of D8321: Add CLI command to reset migration state.
Thu, Jun 10, 4:38 AM

Wed, Jun 9

prha added a comment to D8303: [dagit] More optimistic switch behavior for schedules/sensors.

@dish were you able to repro the laggy behavior before?

Wed, Jun 9, 3:21 PM

Tue, Jun 8

prha accepted D8295: [dagit] Fix Run page.
Tue, Jun 8, 10:54 PM
prha closed D8296: add specific error message for pipeline invocation.
Tue, Jun 8, 10:42 PM
prha committed R1:7757caf977eb: add specific error message for pipeline invocation (authored by prha).
add specific error message for pipeline invocation
Tue, Jun 8, 10:42 PM
prha requested review of D8296: add specific error message for pipeline invocation.
Tue, Jun 8, 9:50 PM
prha accepted D8264: Do Postgres/MySQL table creation in a transaction.

whynot

Tue, Jun 8, 8:34 PM
prha abandoned D7160: add compute log manager api to more directly expose file-like object.

going to abandon in favor of a new ProcessLogManager API or something similar.

Tue, Jun 8, 8:25 PM
prha edited reviewers for D7945: RFC: add new api hooks for compute log manager to capture logs outside of a pipeline context, support process-based capture, added: johann; removed: sandyryza.
Tue, Jun 8, 6:11 PM
prha added a reviewer for D7160: add compute log manager api to more directly expose file-like object: johann.
Tue, Jun 8, 6:10 PM
prha added a comment to D7895: monitor sensor 4/[dagit] show origin runs on the sensor's page.

mostly nits... biggest question is around the term "Reacted Runs". Just catching up to the latest thinking on it.

Tue, Jun 8, 6:06 PM
prha accepted D8273: [dagit] Fix stdout/stderr log view.
Tue, Jun 8, 3:55 PM

Fri, May 28

prha requested review of D8165: allow backfill actions to cancel runs.
Fri, May 28, 8:05 PM

Thu, May 27

prha added inline comments to D8119: [retry] backoff and jitter.
Thu, May 27, 8:42 PM
prha accepted D8128: Thread schedule decorator params to partition params.
Thu, May 27, 5:50 PM
prha accepted D8114: add test for overriding pipeline def tags.
Thu, May 27, 5:18 PM
prha closed D8141: make sure has_repository_location check can handle completely unknown location names.
Thu, May 27, 5:15 PM
prha committed R1:ff9fd9727dab: make sure has_repository_location check can handle completely unknown location… (authored by prha).
make sure has_repository_location check can handle completely unknown location…
Thu, May 27, 5:15 PM
prha requested review of D8141: make sure has_repository_location check can handle completely unknown location names.
Thu, May 27, 5:10 PM
prha closed D8127: surface python error if partition names not loading.
Thu, May 27, 4:37 PM
prha committed R1:dabee8592018: surface python error if partition names not loading (authored by prha).
surface python error if partition names not loading
Thu, May 27, 4:37 PM
prha added a comment to D8127: surface python error if partition names not loading.

@dgibson I think unrelated... digging into that right now.

Thu, May 27, 4:36 PM

Wed, May 26

prha requested review of D8127: surface python error if partition names not loading.
Wed, May 26, 8:59 PM
prha closed D8117: Tweak grammar nit of approachability post.
Wed, May 26, 8:37 PM
prha accepted D8119: [retry] backoff and jitter.

I think this looks pretty good!

Wed, May 26, 8:19 PM
prha accepted D8058: [docs] Expand section on testing sensors.

animated_excited_guy

Wed, May 26, 8:09 PM
prha accepted D8067: [dagit] Repair ReactMarkdown callsites.
Wed, May 26, 8:06 PM
prha requested review of D8117: Tweak grammar nit of approachability post.
Wed, May 26, 5:06 PM
prha accepted D8112: get_execution_data -> evaluate_tick.
Wed, May 26, 4:04 PM
prha accepted D6865: Housekeeping and code coverage.

thankyou

Wed, May 26, 3:43 PM
prha added inline comments to D8058: [docs] Expand section on testing sensors.
Wed, May 26, 3:42 PM
prha accepted D8047: Upgrade mypy.

Looks fine to me...

Wed, May 26, 3:37 PM
prha added a comment to D8112: get_execution_data -> evaluate_tick.

I have a somewhat averse reaction to do_X function names.

Wed, May 26, 3:17 PM
prha accepted D8109: show container image in repo location display metadata.
Wed, May 26, 2:18 AM
prha accepted D8107: [dagit] Force Asset `asOf` to behave inclusively.
Wed, May 26, 12:37 AM
prha added a comment to D8107: [dagit] Force Asset `asOf` to behave inclusively.

I think need this same logic in AssetMaterializations.tsx.

Wed, May 26, 12:37 AM
prha accepted D8091: [dagit] AssetDetails test.
Wed, May 26, 12:31 AM
prha added a reverting change for D8090: change asset events parameters from before_timestamp to asof_timestamp, which is inclusive: R1:45eefc8a6673: Revert "change asset events parameters from before_timestamp to asof_timestamp….
Wed, May 26, 12:20 AM
prha added a reverting change for R1:f1c6328113c9: change asset events parameters from before_timestamp to asof_timestamp, which…: R1:45eefc8a6673: Revert "change asset events parameters from before_timestamp to asof_timestamp….
Wed, May 26, 12:20 AM
prha committed R1:45eefc8a6673: Revert "change asset events parameters from before_timestamp to asof_timestamp… (authored by prha).
Revert "change asset events parameters from before_timestamp to asof_timestamp…
Wed, May 26, 12:20 AM

Tue, May 25

prha closed D8101: resolve resume backfill merge conflict with readonly.
Tue, May 25, 11:57 PM
prha committed R1:9c69548a48de: resolve resume backfill merge conflict with readonly (authored by prha).
resolve resume backfill merge conflict with readonly
Tue, May 25, 11:57 PM
prha closed D8090: change asset events parameters from before_timestamp to asof_timestamp, which is inclusive.
Tue, May 25, 11:50 PM
prha committed R1:f1c6328113c9: change asset events parameters from before_timestamp to asof_timestamp, which… (authored by prha).
change asset events parameters from before_timestamp to asof_timestamp, which…
Tue, May 25, 11:50 PM
prha requested review of D8101: resolve resume backfill merge conflict with readonly.
Tue, May 25, 11:44 PM
prha accepted D8096: [dagit] Some spacing tweaks on Instance status.
Tue, May 25, 11:15 PM
prha added inline comments to D8096: [dagit] Some spacing tweaks on Instance status.
Tue, May 25, 11:14 PM
prha closed D8104: fix bad commit for capture logs.
Tue, May 25, 11:09 PM
prha committed R1:6f07da9e7dd3: fix bad commit for capture logs (authored by prha).
fix bad commit for capture logs
Tue, May 25, 11:09 PM
prha closed D7939: add log capture event.
Tue, May 25, 9:48 PM
prha committed R1:fa6a1bfdd5b0: add log capture event (authored by prha).
add log capture event
Tue, May 25, 9:48 PM
prha closed D8088: Change ScheduleDefinition.get_execution_data to return a structured namedtuple data class.
Tue, May 25, 9:35 PM
prha committed R1:425de497cb0f: Change ScheduleDefinition.get_execution_data to return a structured namedtuple… (authored by prha).
Change ScheduleDefinition.get_execution_data to return a structured namedtuple…
Tue, May 25, 9:35 PM
prha added a comment to D8090: change asset events parameters from before_timestamp to asof_timestamp, which is inclusive.

I think technically this is a breaking change, but I think it's okay because it's not publicly documented anywhere and only used internally since 0.11.8

Tue, May 25, 9:28 PM
prha updated the summary of D8090: change asset events parameters from before_timestamp to asof_timestamp, which is inclusive.
Tue, May 25, 9:26 PM
prha requested review of D8090: change asset events parameters from before_timestamp to asof_timestamp, which is inclusive.
Tue, May 25, 9:03 PM
prha updated the diff for D8088: Change ScheduleDefinition.get_execution_data to return a structured namedtuple data class.

switch to more terse internal namedtuple representation (thanks @sandyryza)

Tue, May 25, 6:52 PM
prha added inline comments to D8088: Change ScheduleDefinition.get_execution_data to return a structured namedtuple data class.
Tue, May 25, 6:30 PM
prha added a comment to D8088: Change ScheduleDefinition.get_execution_data to return a structured namedtuple data class.

@dgibson this will probably break old user code deployments in the same way that https://dagster.phacility.com/D7613 did...

Tue, May 25, 6:23 PM
prha requested review of D8088: Change ScheduleDefinition.get_execution_data to return a structured namedtuple data class.
Tue, May 25, 6:19 PM