Page MenuHomeElementl

prha (Phil Rha)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2019, 9:56 PM (121 w, 2 d)
Roles
Administrator

Recent Activity

Aug 9 2021

prha accepted D9211: [dagit] Extract ContentRoot to be an App child.

This is so that the cloud index can add cloud-specific routes?

Aug 9 2021, 4:36 PM
prha accepted D9210: [dagit] Enable limited frame-src.
Aug 9 2021, 2:56 PM

Aug 3 2021

prha abandoned D9169: skip failing windows test for grpc/ipc failures on empty dir.
Aug 3 2021, 4:13 PM
prha added a comment to D9192: Make a new port in the gRPC test.

winclap

Aug 3 2021, 2:03 AM
prha accepted D9192: Make a new port in the gRPC test.
Aug 3 2021, 2:03 AM

Jul 31 2021

prha accepted D9170: [dagit] Stop overfetching schedule/sensor in JobMetadata.
Jul 31 2021, 12:02 AM
prha accepted D9174: type check failures often include two adjacent periods.
Jul 31 2021, 12:01 AM

Jul 30 2021

prha closed D9152: fix run stats for backfill progress.
Jul 30 2021, 10:02 PM
prha committed R1:6d7ed0a2db01: fix run stats for backfill progress (authored by prha).
fix run stats for backfill progress
Jul 30 2021, 10:02 PM
prha accepted D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.
Jul 30 2021, 9:59 PM
prha updated the diff for D9169: skip failing windows test for grpc/ipc failures on empty dir.

update

Jul 30 2021, 9:58 PM
prha published D9169: skip failing windows test for grpc/ipc failures on empty dir for review.
Jul 30 2021, 9:56 PM
prha accepted D9167: Bring back "Load execution plan from the snapshot on the run when resume retrying"".
Jul 30 2021, 9:53 PM
prha accepted D9168: Insert solid_selection into pipeline snapshots in sorted order.
Jul 30 2021, 9:51 PM
prha added a comment to D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.

This makes sense to me... thanks for cleaning this up.

Jul 30 2021, 9:49 PM
prha accepted D9166: [bug] fix dynamic outputs issue with adls2 io manager.

oddish

Jul 30 2021, 8:49 PM
prha planned changes to D8321: Add CLI command to reset migration state.
Jul 30 2021, 5:38 PM
prha closed D9155: show schedules/sensors that are not in storage.
Jul 30 2021, 3:44 PM
prha committed R1:7d8527e86e88: show schedules/sensors that are not in storage (authored by prha).
show schedules/sensors that are not in storage
Jul 30 2021, 3:44 PM

Jul 29 2021

prha requested review of D9155: show schedules/sensors that are not in storage.
Jul 29 2021, 11:37 PM
prha closed D9153: fix tooltip content for sensor timeline.
Jul 29 2021, 10:24 PM
prha committed R1:db87c40dbe8d: fix tooltip content for sensor timeline (authored by prha).
fix tooltip content for sensor timeline
Jul 29 2021, 10:24 PM
prha updated the diff for D9153: fix tooltip content for sensor timeline.

noticed that the future tick colors were also off

Jul 29 2021, 10:08 PM
prha requested review of D9152: fix run stats for backfill progress.
Jul 29 2021, 9:48 PM
prha closed D9138: enable backfills to recover from failed partitioned solid selection runs.
Jul 29 2021, 5:46 PM
prha committed R1:9652d966c5c2: enable backfills to recover from failed partitioned solid selection runs (authored by prha).
enable backfills to recover from failed partitioned solid selection runs
Jul 29 2021, 5:45 PM
prha added inline comments to D9070: [caprisun] RepositoryDefinition.asset_definition_graph.
Jul 29 2021, 5:40 PM
prha accepted D9124: [dagit] Repair layout worker, large DAG loading.

just to confirm then... was this not broken on prod?

Jul 29 2021, 4:51 PM
prha added inline comments to D9116: [Easy] Adding serialization decorators & convenience methods.
Jul 29 2021, 4:47 PM
prha requested review of D9138: enable backfills to recover from failed partitioned solid selection runs.
Jul 29 2021, 4:35 PM
prha closed D9137: Revert "Load execution plan from the snapshot on the run when resume retrying".
Jul 29 2021, 4:02 PM
prha added a reverting change for D9041: Load execution plan from the snapshot on the run when resume retrying: R1:bfb90e8b0b44: Revert "Load execution plan from the snapshot on the run when resume retrying".
Jul 29 2021, 4:02 PM
prha added a reverting change for R1:718f1d090831: Load execution plan from the snapshot on the run when resume retrying: R1:bfb90e8b0b44: Revert "Load execution plan from the snapshot on the run when resume retrying".
Jul 29 2021, 4:01 PM
prha committed R1:bfb90e8b0b44: Revert "Load execution plan from the snapshot on the run when resume retrying" (authored by prha).
Revert "Load execution plan from the snapshot on the run when resume retrying"
Jul 29 2021, 4:01 PM
prha requested review of D9137: Revert "Load execution plan from the snapshot on the run when resume retrying".
Jul 29 2021, 2:26 AM
prha added a reverting change for R1:718f1d090831: Load execution plan from the snapshot on the run when resume retrying: D9137: Revert "Load execution plan from the snapshot on the run when resume retrying".
Jul 29 2021, 1:44 AM
prha added a reverting change for D9041: Load execution plan from the snapshot on the run when resume retrying: D9137: Revert "Load execution plan from the snapshot on the run when resume retrying".
Jul 29 2021, 1:44 AM

Jul 28 2021

prha added a comment to D9124: [dagit] Repair layout worker, large DAG loading.

Yeah, I think the important piece is not being reliant on webpack, so that we can actually do the imports asynchronously from the webworker.

Jul 28 2021, 7:32 PM
prha added a comment to D9124: [dagit] Repair layout worker, large DAG loading.

Is there a way to test that the layout worker doesn't have imports (direct or transitive) that will break it?

Jul 28 2021, 5:45 PM
prha accepted D9119: [dagit] TS 4.3.5.
Jul 28 2021, 3:39 PM

Jul 27 2021

prha accepted D9065: [dagit] Modify App initialization config.
Jul 27 2021, 3:20 PM
prha accepted D8810: [dag-star] graphql websocket endpoint.
Jul 27 2021, 3:19 PM
prha abandoned D8165: allow backfill actions to cancel runs.
Jul 27 2021, 3:18 PM

Jul 23 2021

prha closed D9043: handle wiped assets for asset index migration.
Jul 23 2021, 5:10 PM
prha committed R1:dde81ac00d59: handle wiped assets for asset index migration (authored by prha).
handle wiped assets for asset index migration
Jul 23 2021, 5:10 PM
prha requested review of D9043: handle wiped assets for asset index migration.
Jul 23 2021, 4:52 PM
prha closed D9035: tailwind config for highlighting back links in source snippets.
Jul 23 2021, 4:51 PM
prha committed R1:d83aae80f45b: tailwind config for highlighting back links in source snippets (authored by prha).
tailwind config for highlighting back links in source snippets
Jul 23 2021, 4:51 PM
prha requested review of D9035: tailwind config for highlighting back links in source snippets.
Jul 23 2021, 1:13 AM

Jul 22 2021

prha added inline comments to D8969: [caprisun] @asset and build_assets_job.
Jul 22 2021, 4:21 PM

Jul 20 2021

prha closed D8967: fix postgres backcompat test flakiness (stable set comparison).
Jul 20 2021, 9:16 PM
prha committed R1:a26ded525684: fix postgres backcompat test flakiness (stable set comparison) (authored by prha).
fix postgres backcompat test flakiness (stable set comparison)
Jul 20 2021, 9:16 PM
prha accepted D8962: [dagit] Delete some dead JS.

killitwithfire

Jul 20 2021, 5:37 PM
prha requested review of D8967: fix postgres backcompat test flakiness (stable set comparison).
Jul 20 2021, 3:44 PM
prha accepted D8961: [dagit] Delete /flags.
Jul 20 2021, 3:22 PM

Jul 19 2021

prha accepted D8948: Add utility to deserialize json to specific namedtuple class.

porygon

Jul 19 2021, 5:58 PM

Jul 16 2021

prha accepted D8930: [dagit] Introduce a CSP.

cloyster

Jul 16 2021, 6:34 PM
prha accepted D8911: bugfix: catch more dynamic output restrictions with graphs.
Jul 16 2021, 4:17 PM

Jul 15 2021

prha accepted D8908: [dagit] Repair storybook.
Jul 15 2021, 6:23 PM
prha updated the diff for D8840: convert local compute log manager.

more mypy, renaming for clarity

Jul 15 2021, 4:51 PM
prha added inline comments to D8840: convert local compute log manager.
Jul 15 2021, 4:44 PM
prha updated the diff for D8845: have AzureComputeLogManager implement CapturedLogManager interface.

rebase

Jul 15 2021, 4:32 PM
prha updated the diff for D8844: have GcsComputeLogManager implement CapturedLogManager interface.

rebase

Jul 15 2021, 4:32 PM
prha updated the diff for D8843: have S3ComputeLogManager implement CapturedLogManager interface.

rebase

Jul 15 2021, 4:31 PM
prha updated the diff for D8842: Make implement NoopComputeLogManager implement CapturedLogManager interface.

rebase

Jul 15 2021, 4:30 PM
prha updated the diff for D8840: convert local compute log manager.

rebase

Jul 15 2021, 4:30 PM
prha added inline comments to D8840: convert local compute log manager.
Jul 15 2021, 4:27 PM
prha abandoned D7945: RFC: add new api hooks for compute log manager to capture logs outside of a pipeline context, support process-based capture.

In favor of D8385

Jul 15 2021, 4:22 PM
prha abandoned D8905: testtt.
Jul 15 2021, 4:11 PM
prha updated the diff for D8385: add captured log manager interface.

added comments, renamed some methods, dropped is_enabled

Jul 15 2021, 4:11 PM
prha requested review of D8905: testtt.
Jul 15 2021, 3:59 PM
prha accepted D8714: SolidHandle -> NodeHandle.
Jul 15 2021, 3:29 PM
prha closed D8902: disable flaky test_partial_backfill in windows.
Jul 15 2021, 2:26 PM
prha committed R1:2238cb5af063: disable flaky test_partial_backfill in windows (authored by prha).
disable flaky test_partial_backfill in windows
Jul 15 2021, 2:26 PM

Jul 14 2021

prha added a comment to D8900: RunStatusSensorDefinition and @run_status_sensor.

It gets a little hairy if we allow arbitrary dagster event types, because the current implementation (with the RunShardedEventsCursor) implicitly assumes a 1-to-1 event to run mapping.

Jul 14 2021, 11:37 PM
prha requested review of D8902: disable flaky test_partial_backfill in windows.
Jul 14 2021, 11:10 PM
prha added a comment to D8900: RunStatusSensorDefinition and @run_status_sensor.

The run status => event mapping feels a little weird to me, but maybe results in the desired behavior.

Jul 14 2021, 11:04 PM
prha accepted D8896: consolidate event type to run status lookup.
Jul 14 2021, 10:48 PM
prha closed D8877: asset catalog perf: use wipe_timestamp for asset_key filtering.
Jul 14 2021, 5:19 PM
prha committed R1:eed3e11bbb6c: asset catalog perf: use wipe_timestamp for asset_key filtering (authored by prha).
asset catalog perf: use wipe_timestamp for asset_key filtering
Jul 14 2021, 5:18 PM
prha requested review of D8877: asset catalog perf: use wipe_timestamp for asset_key filtering.
Jul 14 2021, 12:42 AM

Jul 13 2021

prha accepted D8869: mypy DagsterInstance.

redfordnod

Jul 13 2021, 10:10 PM
prha added inline comments to D8845: have AzureComputeLogManager implement CapturedLogManager interface.
Jul 13 2021, 9:10 PM
prha closed D8864: asset catalog perf: make use of tags column if migrated.
Jul 13 2021, 7:31 PM
prha committed R1:f6c6372344ce: asset catalog perf: make use of tags column if migrated (authored by prha).
asset catalog perf: make use of tags column if migrated
Jul 13 2021, 7:31 PM
prha requested review of D8864: asset catalog perf: make use of tags column if migrated.
Jul 13 2021, 7:03 PM
prha added inline comments to D8810: [dag-star] graphql websocket endpoint.
Jul 13 2021, 6:50 PM
prha accepted D8846: [dag-star] download debug file.

flareon

Jul 13 2021, 6:41 PM
prha closed D8833: make sure pipeline_failure_sensor is under test.
Jul 13 2021, 6:21 PM
prha committed R1:d9f5cafa1f0c: make sure pipeline_failure_sensor is under test (authored by prha).
make sure pipeline_failure_sensor is under test
Jul 13 2021, 6:21 PM
prha closed D8853: ensure pipeline def args get threaded through hook decorator.
Jul 13 2021, 5:09 PM
prha committed R1:eb2366654d3b: ensure pipeline def args get threaded through hook decorator (authored by prha).
ensure pipeline def args get threaded through hook decorator
Jul 13 2021, 5:09 PM
prha accepted D8808: [dag-star] graphql endpoint.
Jul 13 2021, 4:03 PM
prha requested review of D8853: ensure pipeline def args get threaded through hook decorator.
Jul 13 2021, 3:57 PM

Jul 12 2021

prha requested review of D8844: have GcsComputeLogManager implement CapturedLogManager interface.
Jul 12 2021, 10:43 PM
prha requested review of D8843: have S3ComputeLogManager implement CapturedLogManager interface.
Jul 12 2021, 10:42 PM
prha requested review of D8840: convert local compute log manager.
Jul 12 2021, 10:35 PM
prha closed D8839: Revert "pin dbt for test", try removing default dbt profile dir.
Jul 12 2021, 10:34 PM
prha added a reverting change for R1:fdbcecb76c5d: pin dbt for test: R1:b14acdec328a: Revert "pin dbt for test", try removing default dbt profile dir.
Jul 12 2021, 10:34 PM
prha added a reverting change for D8831: pin dbt for test: R1:b14acdec328a: Revert "pin dbt for test", try removing default dbt profile dir.
Jul 12 2021, 10:34 PM