Page MenuHomePhabricator

prha (Phil Rha)
User

Projects

User does not belong to any projects.

User Details

User Since
Mon, Aug 5, 9:56 PM (2 w, 3 d)

Recent Activity

Yesterday

prha accepted D869: Performance improvements based on fan-in-out example DAG.

small nit, but overall this looks great!

Thu, Aug 22, 8:20 PM
prha committed R1:22bee0fd8681: 0.5.7 (authored by prha).
0.5.7
Thu, Aug 22, 6:38 PM
prha committed R1:81ef8f220fbd: 0.5.7.pre0 (authored by prha).
0.5.7.pre0
Thu, Aug 22, 5:39 PM
prha added inline comments to D871: Fixes Dagit on Windows.
Thu, Aug 22, 5:20 PM
prha accepted D871: Fixes Dagit on Windows.

LGTM

Thu, Aug 22, 5:20 PM

Wed, Aug 21

prha added inline comments to D859: Break log storage out from run storage.
Wed, Aug 21, 8:24 PM

Mon, Aug 19

prha committed R1:97affd2c7b5f: RFC: push config obj instantiation into `reconstitute_pipeline_context` (authored by prha).
RFC: push config obj instantiation into `reconstitute_pipeline_context`
Mon, Aug 19, 6:33 PM
prha closed D831: RFC: push config obj instantiation into `reconstitute_pipeline_context`.
Mon, Aug 19, 6:33 PM
prha added inline comments to D831: RFC: push config obj instantiation into `reconstitute_pipeline_context`.
Mon, Aug 19, 6:32 PM

Fri, Aug 16

prha accepted D836: [dagster-graphql] use obj for required resource.
Fri, Aug 16, 8:38 PM
prha added a comment to D831: RFC: push config obj instantiation into `reconstitute_pipeline_context`.

Fri, Aug 16, 3:49 PM
prha committed R1:466c4aaab81e: fix airline demo snippet (authored by prha).
fix airline demo snippet
Fri, Aug 16, 5:10 AM
prha closed D834: fix airline demo snippet.
Fri, Aug 16, 5:10 AM
prha created D834: fix airline demo snippet.
Fri, Aug 16, 12:33 AM
prha committed R1:b60d6f85d125: adjust the dagstermill code snippets for the airline demo docs (authored by prha).
adjust the dagstermill code snippets for the airline demo docs
Fri, Aug 16, 12:05 AM
prha closed D823: adjust the dagstermill code snippets for the airline demo docs.
Fri, Aug 16, 12:05 AM

Thu, Aug 15

prha added a reviewer for D831: RFC: push config obj instantiation into `reconstitute_pipeline_context`: Restricted Project.
Thu, Aug 15, 11:52 PM
prha removed a reviewer for D831: RFC: push config obj instantiation into `reconstitute_pipeline_context`: Restricted Project.
Thu, Aug 15, 11:44 PM
prha updated the diff for D831: RFC: push config obj instantiation into `reconstitute_pipeline_context`.

fix python 2.7 syntax error

Thu, Aug 15, 11:43 PM
prha planned changes to D831: RFC: push config obj instantiation into `reconstitute_pipeline_context`.
Thu, Aug 15, 11:11 PM
prha added a reviewer for D831: RFC: push config obj instantiation into `reconstitute_pipeline_context`: Restricted Project.

I'd like someone to sanity check my use of different library imports (six / seven / json).

Thu, Aug 15, 11:05 PM
prha created D831: RFC: push config obj instantiation into `reconstitute_pipeline_context`.
Thu, Aug 15, 11:00 PM
prha accepted D825: Fix state update error in ConfigEditorModePicker.

LGTM

Thu, Aug 15, 8:23 PM
prha committed R1:d291ae0d037a: switch airflow tests to run on medium instance (authored by prha).
switch airflow tests to run on medium instance
Thu, Aug 15, 8:22 PM
prha closed D827: switch airflow tests to run on medium instance.
Thu, Aug 15, 8:22 PM
prha added a reviewer for D827: switch airflow tests to run on medium instance: Restricted Project.
Thu, Aug 15, 7:27 PM
prha created D827: switch airflow tests to run on medium instance.
Thu, Aug 15, 7:27 PM
prha committed R1:d79b27377be1: Add custom behavior to the CellTruncationProvider (authored by prha).
Add custom behavior to the CellTruncationProvider
Thu, Aug 15, 7:10 PM
prha closed D819: Add custom behavior to the CellTruncationProvider.
Thu, Aug 15, 7:10 PM
prha added a comment to D823: adjust the dagstermill code snippets for the airline demo docs.

this seems brittle... is there a better way?

Thu, Aug 15, 5:45 PM
prha added a reviewer for D823: adjust the dagstermill code snippets for the airline demo docs: natekupp.
Thu, Aug 15, 5:44 PM
prha created D823: adjust the dagstermill code snippets for the airline demo docs.
Thu, Aug 15, 5:44 PM
prha committed R1:7318e78d033a: fix required resource boolean (authored by prha).
fix required resource boolean
Thu, Aug 15, 5:36 PM
prha closed D822: fix required resource boolean.
Thu, Aug 15, 5:36 PM
prha added a reviewer for D822: fix required resource boolean: Restricted Project.
Thu, Aug 15, 5:05 PM
prha created D822: fix required resource boolean.
Thu, Aug 15, 5:04 PM
prha added a comment to D819: Add custom behavior to the CellTruncationProvider.

ended up just wrapping the content with a wrapper div... I don't think there's another way to do it

Thu, Aug 15, 4:32 PM
prha updated the diff for D819: Add custom behavior to the CellTruncationProvider.
  • Use refs instead of ReactDOM.findDOMNode
Thu, Aug 15, 4:30 PM
prha added inline comments to D819: Add custom behavior to the CellTruncationProvider.
Thu, Aug 15, 4:01 PM

Wed, Aug 14

prha closed D809: Display required_resources in dagit.
Wed, Aug 14, 11:53 PM
prha committed R1:f250ef1fda29: Display required_resources in dagit (authored by prha).
Display required_resources in dagit
Wed, Aug 14, 11:53 PM
prha committed R1:13b4b960e84c: fix misc JS console warnings (authored by prha).
fix misc JS console warnings
Wed, Aug 14, 10:41 PM
prha closed D820: fix misc JS console warnings.
Wed, Aug 14, 10:41 PM
prha updated the diff for D820: fix misc JS console warnings.
  • update snapshot
Wed, Aug 14, 10:32 PM
prha added a comment to D809: Display required_resources in dagit.

What commands are you using to run this?

Wed, Aug 14, 10:26 PM
prha added reviewers for D820: fix misc JS console warnings: Restricted Project, bengotow.
Wed, Aug 14, 10:13 PM
prha created D820: fix misc JS console warnings.
Wed, Aug 14, 10:12 PM
prha added reviewers for D819: Add custom behavior to the CellTruncationProvider: Restricted Project, bengotow.
Wed, Aug 14, 10:09 PM
prha updated the summary of D819: Add custom behavior to the CellTruncationProvider.
Wed, Aug 14, 10:08 PM
prha created D819: Add custom behavior to the CellTruncationProvider.
Wed, Aug 14, 10:03 PM
prha updated the diff for D809: Display required_resources in dagit.

create required resource object type

Wed, Aug 14, 4:33 PM
prha committed R1:ebaa4272c8ef: fix column resizing in run view (authored by prha).
fix column resizing in run view
Wed, Aug 14, 12:17 AM
prha closed D792: fix column resizing in run view.
Wed, Aug 14, 12:17 AM
prha added a comment to D792: fix column resizing in run view.

Yeah, kept digging into why the mouseup event wasn't firing in Chrome/Safari. Turns out, they swallow the mouseup event for elements with the draggable attribute that has initiated a drag event.

Wed, Aug 14, 12:12 AM
prha retitled D792: fix column resizing in run view from handle variety of browser drag events for column resizing to fix column resizing in run view.
Wed, Aug 14, 12:08 AM
prha updated the diff for D792: fix column resizing in run view.

updated styled.div attributes to not collide with HTML5 drag attrs

Wed, Aug 14, 12:04 AM

Tue, Aug 13

prha updated the summary of D809: Display required_resources in dagit.
Tue, Aug 13, 6:44 PM
prha updated the summary of D809: Display required_resources in dagit.
Tue, Aug 13, 6:42 PM
prha updated the summary of D809: Display required_resources in dagit.
Tue, Aug 13, 6:41 PM
prha created D809: Display required_resources in dagit.
Tue, Aug 13, 6:39 PM

Mon, Aug 12

prha committed R1:6c78175afd31: markdown support in event metadata (authored by prha).
markdown support in event metadata
Mon, Aug 12, 9:55 PM
prha closed D800: markdown support in event metadata.
Mon, Aug 12, 9:55 PM
prha retitled D800: markdown support in event metadata from python/graphql support for stashing markdown to markdown support in event metadata.
Mon, Aug 12, 9:35 PM
prha created D800: markdown support in event metadata.
Mon, Aug 12, 9:33 PM
prha updated the summary of D792: fix column resizing in run view.
Mon, Aug 12, 4:19 PM

Fri, Aug 9

prha added a reviewer for D792: fix column resizing in run view: Restricted Project.
Fri, Aug 9, 10:26 PM
prha created D792: fix column resizing in run view.
Fri, Aug 9, 10:21 PM

Thu, Aug 8

prha committed R1:54586608bcb2: change `file_handle_to_s3` solid to use S3.Client.upload_fileobj (authored by prha).
change `file_handle_to_s3` solid to use S3.Client.upload_fileobj
Thu, Aug 8, 8:51 PM
prha closed D784: change `file_handle_to_s3` solid to use S3.Client.upload_fileobj.
Thu, Aug 8, 8:51 PM
prha added a reviewer for D784: change `file_handle_to_s3` solid to use S3.Client.upload_fileobj: Restricted Project.
Thu, Aug 8, 6:50 PM
prha updated the summary of D784: change `file_handle_to_s3` solid to use S3.Client.upload_fileobj.
Thu, Aug 8, 6:50 PM
prha created D784: change `file_handle_to_s3` solid to use S3.Client.upload_fileobj.
Thu, Aug 8, 6:49 PM

Wed, Aug 7

prha committed R1:3a0176514e12: Changes step success to mean successful execution (e.g. excluding skipped steps) (authored by prha).
Changes step success to mean successful execution (e.g. excluding skipped steps)
Wed, Aug 7, 9:21 PM
prha closed D775: Changes step success to mean successful execution (e.g. excluding skipped steps).
Wed, Aug 7, 9:21 PM
prha updated the diff for D775: Changes step success to mean successful execution (e.g. excluding skipped steps).

lint sanitation

Wed, Aug 7, 9:10 PM
prha updated the diff for D775: Changes step success to mean successful execution (e.g. excluding skipped steps).

removed step assertions (checking not failed means nothing for output)

Wed, Aug 7, 8:58 PM
prha added a reviewer for D775: Changes step success to mean successful execution (e.g. excluding skipped steps): Restricted Project.
Wed, Aug 7, 8:48 PM
prha created D775: Changes step success to mean successful execution (e.g. excluding skipped steps).
Wed, Aug 7, 8:47 PM