Page MenuHomePhabricator

prha (Phil Rha)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2019, 9:56 PM (47 w, 3 d)
Roles
Administrator

Recent Activity

Today

prha updated the diff for D3670: Remove ability to load modules resolved by the working directory.

update changes, docs

Fri, Jul 3, 2:29 AM
prha updated the diff for D3670: Remove ability to load modules resolved by the working directory.
  • switch tests to pass in overriding remove_path_fn instead of using mocks
Fri, Jul 3, 2:00 AM

Yesterday

prha added inline comments to D3670: Remove ability to load modules resolved by the working directory.
Thu, Jul 2, 11:53 PM
prha updated the diff for D3670: Remove ability to load modules resolved by the working directory.
  • rename fn_name
Thu, Jul 2, 11:37 PM
prha added inline comments to D3670: Remove ability to load modules resolved by the working directory.
Thu, Jul 2, 11:19 PM
prha added inline comments to D3670: Remove ability to load modules resolved by the working directory.
Thu, Jul 2, 11:11 PM
prha updated the diff for D3670: Remove ability to load modules resolved by the working directory.

black

Thu, Jul 2, 11:01 PM
prha updated the diff for D3670: Remove ability to load modules resolved by the working directory.
  • add python package load-from arg
Thu, Jul 2, 10:56 PM
prha added a comment to D3670: Remove ability to load modules resolved by the working directory.

On reflection, I think the only reason that person in #general hit that case (CWD-dependent imports) was because we were manually adding the working directory to the path in python_modules/dagster/dagster/cli/__init__.py.

Thu, Jul 2, 8:36 PM
prha added inline comments to D3670: Remove ability to load modules resolved by the working directory.
Thu, Jul 2, 6:03 PM
prha added inline comments to D3670: Remove ability to load modules resolved by the working directory.
Thu, Jul 2, 5:40 PM
prha updated the diff for D3670: Remove ability to load modules resolved by the working directory.

clean up, simplify path manipulation, add more comments

Thu, Jul 2, 5:14 PM
prha added inline comments to D3670: Remove ability to load modules resolved by the working directory.
Thu, Jul 2, 3:59 PM
prha updated the diff for D3670: Remove ability to load modules resolved by the working directory.

check against ImportError instead, to support py27

Thu, Jul 2, 4:54 AM
prha updated the diff for D3670: Remove ability to load modules resolved by the working directory.

add mock to stub out sys.path replacements

Thu, Jul 2, 4:35 AM
prha retitled D3670: Remove ability to load modules resolved by the working directory from RFC: add working dir to module code pointer to Remove ability to load modules resolved by the working directory.
Thu, Jul 2, 1:56 AM
prha updated the diff for D3670: Remove ability to load modules resolved by the working directory.

remove ability to load modules resolved by local directory

Thu, Jul 2, 1:53 AM
prha requested review of D3732: remove loading of local modules.
Thu, Jul 2, 12:16 AM

Wed, Jul 1

prha planned changes to D3670: Remove ability to load modules resolved by the working directory.
Wed, Jul 1, 11:21 PM
prha updated the diff for D3670: Remove ability to load modules resolved by the working directory.
  • add test, address schema query
Wed, Jul 1, 11:13 PM
prha updated the diff for D3670: Remove ability to load modules resolved by the working directory.
  • resolve introspection query
Wed, Jul 1, 8:11 PM
prha updated the diff for D3670: Remove ability to load modules resolved by the working directory.
  • comments, changes
Wed, Jul 1, 7:35 PM

Tue, Jun 30

prha added a comment to D3706: [dagit] ENVIRONMENT -> REPOSITORY.

makes sense to me... will let @schrockn and @bengotow also weigh in. should we also rename the component RepositoryPicker, etc?

Tue, Jun 30, 6:00 PM
prha accepted D3705: Improve behavior of the Enter key in the Dagit pipeline sidebar #2572.

alakazam

Tue, Jun 30, 5:02 PM
prha accepted D3671: Pipeline-scoped runs tab, cleaner cursor-paginated query utils.

This looks great. We should fix the cursor typo, but o.w. lgtm

Tue, Jun 30, 4:47 PM
prha committed R1:3485d721a8a7: add literalincludes, add readme.md to direct traffic to docs site (authored by prha).
add literalincludes, add readme.md to direct traffic to docs site
Tue, Jun 30, 4:27 PM
prha closed D3701: add literalincludes, add readme.md to direct traffic to docs site.
Tue, Jun 30, 4:27 PM
prha requested review of D3701: add literalincludes, add readme.md to direct traffic to docs site.
Tue, Jun 30, 12:53 AM

Mon, Jun 29

prha accepted D3694: defensive schedule origin id test.
Mon, Jun 29, 9:57 PM
prha updated the diff for D3670: Remove ability to load modules resolved by the working directory.
  • split out directory-aware module code pointer
Mon, Jun 29, 7:46 PM
prha updated the diff for D3670: Remove ability to load modules resolved by the working directory.
  • remove default working directory, resolve working_directory relative to workspace.yaml
Mon, Jun 29, 6:07 PM
prha committed R1:fb351600fb81: Convert graphql endpoints wrapping user-code api calls in `orError` checks (authored by prha).
Convert graphql endpoints wrapping user-code api calls in `orError` checks
Mon, Jun 29, 5:47 PM
prha closed D3645: Convert graphql endpoints wrapping user-code api calls in `orError` checks.
Mon, Jun 29, 5:47 PM
prha added a comment to D3670: Remove ability to load modules resolved by the working directory.

Yeah, I think we need to somehow force a schedule reconcile upon version update.

Mon, Jun 29, 5:15 PM
prha added a comment to D3670: Remove ability to load modules resolved by the working directory.

Also, yes, the defaults are the part that I'm most unsure about...

Mon, Jun 29, 5:06 PM
prha added a comment to D3670: Remove ability to load modules resolved by the working directory.

I'm not sure about changing the file-based code pointer... What's the error case we're handling there? I guess the name working_directory could mean that it should allow relative paths there...

Mon, Jun 29, 5:05 PM
prha updated the diff for D3670: Remove ability to load modules resolved by the working directory.
  • add working directory to origin repo args
Mon, Jun 29, 4:55 PM

Fri, Jun 26

prha added a comment to D3670: Remove ability to load modules resolved by the working directory.

I made sure we had a test for loading relative modules, but found it hard to test some of the other flows involving PYTHONPATH...

Fri, Jun 26, 11:36 PM
prha requested review of D3670: Remove ability to load modules resolved by the working directory.
Fri, Jun 26, 11:28 PM
prha accepted D3660: Play nicely with test collectors.
Fri, Jun 26, 7:41 PM
prha added inline comments to D3659: [docs] split asset materializations from expectations.
Fri, Jun 26, 7:40 PM
prha accepted D3659: [docs] split asset materializations from expectations.
Fri, Jun 26, 7:39 PM

Thu, Jun 25

prha committed R1:5c7ba95fa8fd: add overview section for asset materializations / expectations (authored by prha).
add overview section for asset materializations / expectations
Thu, Jun 25, 11:37 PM
prha closed D3633: add overview section for asset materializations / expectations.
Thu, Jun 25, 11:37 PM
prha accepted D3654: Extract reconcile button to component.

bulbasaur

Thu, Jun 25, 11:22 PM
prha added inline comments to D3633: add overview section for asset materializations / expectations.
Thu, Jun 25, 10:02 PM
prha requested review of D3645: Convert graphql endpoints wrapping user-code api calls in `orError` checks.
Thu, Jun 25, 9:57 PM
prha accepted D3631: add tags to preset.

nice

Thu, Jun 25, 9:54 PM
prha added a reviewer for D3633: add overview section for asset materializations / expectations: schrockn.
Thu, Jun 25, 5:37 PM
prha accepted D3640: Improve dagstermill test coverage.
Thu, Jun 25, 4:26 PM

Wed, Jun 24

prha requested review of D3633: add overview section for asset materializations / expectations.
Wed, Jun 24, 10:41 PM
prha added a comment to D3631: add tags to preset.

Can also approve this if you want this to be separate diffs....

Wed, Jun 24, 10:22 PM
prha requested changes to D3631: add tags to preset.

I think for completeness, you probably want to be able to query this off of the preset in graphql in the ConfigEditorConfigPicker, similar to the partition tags (except no need to make the call over the API). This should pre-fill the tag section in the playground.

Wed, Jun 24, 10:21 PM

Tue, Jun 23

prha committed R1:8e3a00d67734: elevate asset methods onto instance (authored by prha).
elevate asset methods onto instance
Tue, Jun 23, 8:25 PM
prha closed D3608: elevate asset methods onto instance.
Tue, Jun 23, 8:25 PM
prha updated the diff for D3608: elevate asset methods onto instance.

comments

Tue, Jun 23, 8:05 PM
prha added inline comments to D3608: elevate asset methods onto instance.
Tue, Jun 23, 8:04 PM
prha committed R1:558d363f3d98: extract error from api return values (authored by prha).
extract error from api return values
Tue, Jun 23, 7:59 PM
prha closed D3580: extract error from api return values.
Tue, Jun 23, 7:59 PM
prha updated the diff for D3580: extract error from api return values.

fix tests

Tue, Jun 23, 6:46 PM
prha updated the diff for D3580: extract error from api return values.

trailing comma

Tue, Jun 23, 6:33 PM
prha added inline comments to D3580: extract error from api return values.
Tue, Jun 23, 6:32 PM
prha updated the summary of D3580: extract error from api return values.
Tue, Jun 23, 6:28 PM
prha updated the diff for D3580: extract error from api return values.

restored wrapping *ErrorData namedtuples

Tue, Jun 23, 6:28 PM
prha requested review of D3608: elevate asset methods onto instance.
Tue, Jun 23, 6:15 PM
prha committed R1:7a73d46e5e7e: add assets/materialization example (authored by prha).
add assets/materialization example
Tue, Jun 23, 3:01 PM
prha closed D3599: add assets/materialization example.
Tue, Jun 23, 3:01 PM
prha updated the diff for D3599: add assets/materialization example.

update

Tue, Jun 23, 3:39 AM
prha added inline comments to D3599: add assets/materialization example.
Tue, Jun 23, 3:33 AM
prha requested review of D3599: add assets/materialization example.
Tue, Jun 23, 1:41 AM

Mon, Jun 22

prha accepted D3592: windows fixes.

What tests were failing? Just trying to get a sense of when this would pop up...

Mon, Jun 22, 7:39 PM

Sat, Jun 20

prha requested review of D3580: extract error from api return values.
Sat, Jun 20, 1:31 AM

Fri, Jun 19

prha committed R1:9e275ee2274b: add changes for 0.8.4 (authored by prha).
add changes for 0.8.4
Fri, Jun 19, 11:42 PM
prha closed D3578: add changes for 0.8.4.
Fri, Jun 19, 11:42 PM
prha committed R1:773411c7f81d: fix longitudinal partition selector (authored by prha).
fix longitudinal partition selector
Fri, Jun 19, 11:15 PM
prha closed D3573: fix longitudinal partition selector.
Fri, Jun 19, 11:15 PM
prha accepted D3469: Rebuild the launch execution button for easier maintenance.
Fri, Jun 19, 11:14 PM
prha updated the diff for D3578: add changes for 0.8.4.

update

Fri, Jun 19, 11:09 PM
prha added a reviewer for D3578: add changes for 0.8.4: yuhan.
Fri, Jun 19, 11:07 PM
prha added a comment to D3578: add changes for 0.8.4.

feel free to comment with your own changes and will add them in...

Fri, Jun 19, 11:07 PM
prha requested review of D3578: add changes for 0.8.4.
Fri, Jun 19, 11:07 PM
prha committed R1:784704b43935: Add location reload button when supported, keyboard nav in sidebar (authored by bengotow).
Add location reload button when supported, keyboard nav in sidebar
Fri, Jun 19, 10:45 PM
prha closed D3569: Add location reload button when supported, keyboard nav in sidebar.
Fri, Jun 19, 10:45 PM
prha commandeered D3569: Add location reload button when supported, keyboard nav in sidebar.
Fri, Jun 19, 10:43 PM
prha accepted D3569: Add location reload button when supported, keyboard nav in sidebar.
Fri, Jun 19, 10:43 PM
prha committed R1:fc966d6b3a00: resolve partition set partition names over api call (authored by prha).
resolve partition set partition names over api call
Fri, Jun 19, 10:31 PM
prha closed D3570: resolve partition set partition names over api call.
Fri, Jun 19, 10:31 PM
prha committed R1:76e5a30f3ee8: update schedule page to show only last tick (authored by prha).
update schedule page to show only last tick
Fri, Jun 19, 10:30 PM
prha closed D3546: update schedule page to show only last tick.
Fri, Jun 19, 10:30 PM
prha requested review of D3573: fix longitudinal partition selector.
Fri, Jun 19, 8:50 PM
prha committed R1:e301e271b5d4: fix run selection for longitudinal graphs (authored by prha).
fix run selection for longitudinal graphs
Fri, Jun 19, 8:39 PM
prha closed D3571: fix run selection for longitudinal graphs.
Fri, Jun 19, 8:39 PM
prha updated the diff for D3570: resolve partition set partition names over api call.
  • split out error class
Fri, Jun 19, 8:34 PM
prha requested review of D3571: fix run selection for longitudinal graphs.
Fri, Jun 19, 7:06 PM
prha added a comment to D3570: resolve partition set partition names over api call.

I know its a pain but I do think its much clearer/safer if we return different types for error cases rather than having all the properties be optional

Fri, Jun 19, 6:57 PM
prha requested review of D3570: resolve partition set partition names over api call.
Fri, Jun 19, 6:18 PM
prha committed R1:0333b1b16125: add padding to the end of the run logs (authored by prha).
add padding to the end of the run logs
Fri, Jun 19, 4:33 PM
prha closed D3551: add padding to the end of the run logs.
Fri, Jun 19, 4:33 PM
prha retitled D3551: add padding to the end of the run logs from RFC: add padding to the end of the run logs to add padding to the end of the run logs.
Fri, Jun 19, 4:32 PM
prha added a comment to D3546: update schedule page to show only last tick.

Okay. I *think* this is causing some confusion because it's easy to confuse attempts with runs and execution time with partition date. I think something that looks more like a streaming logfile that people need to click into to debug would be more useful.

Fri, Jun 19, 3:51 PM