User Details
User Details
- User Since
- Aug 5 2019, 9:56 PM (76 w, 1 d)
- Roles
- Administrator
Yesterday
Yesterday
prha requested review of D6041: improve sensor CLI error messages.
Fri, Jan 15
Fri, Jan 15
prha updated the diff for D5941: RFC: Make default sharded sqlite implementation asset-aware.
tests
prha updated the diff for D5941: RFC: Make default sharded sqlite implementation asset-aware.
fix bad indentation
prha planned changes to D5941: RFC: Make default sharded sqlite implementation asset-aware.
prha updated the diff for D5941: RFC: Make default sharded sqlite implementation asset-aware.
- make two explicit connection calls in sql event log storage
prha committed R1:368b05ce4987: pin chardet, to resolve dep conflict with aiohttp<=3.7.3 (authored by prha).
pin chardet, to resolve dep conflict with aiohttp<=3.7.3
prha requested review of D6022: pin chardet, to resolve dep conflict with aiohttp<=3.7.3.
prha published D6021: Changelog nits for review.
Thu, Jan 14
Thu, Jan 14
prha published D6019: Adds changelog notes and migration guide for 0.10.0. for review.
prha committed R1:074f80071584: handle latest version of nbformat, which adds random string ids (authored by prha).
handle latest version of nbformat, which adds random string ids
prha requested review of D5997: handle latest version of nbformat, which adds random string ids.
okay, looks good to me!
prha requested changes to D5805: Migrate db.String to db.Text to support MySQL.
This looks pretty solid... nice work.
prha committed R1:76f4d7655827: make sure integrity error is caught within a connection contextmanager (authored by prha).
make sure integrity error is caught within a connection contextmanager
prha updated the diff for D5991: make sure integrity error is caught within a connection contextmanager.
lint
fix tick history panning, tooltip width
prha added a comment to D5985: fix tick history panning, tooltip width.
Not without custom tooltips, which I'm looking into but is a lot for right now.
prha accepted D5982: Don't always run create_all during storage creation, add stamps to postgres storage.
prha added inline comments to D5982: Don't always run create_all during storage creation, add stamps to postgres storage.
Wed, Jan 13
Wed, Jan 13
update screenshots for schedules/sensors
prha requested review of D5985: fix tick history panning, tooltip width.
prha requested review of D5979: update screenshots for schedules/sensors.
prha added a comment to D5721: DynamicOutput DSL map approach.
Yeah, this seems fine if it's for internal use.
prha added inline comments to D5721: DynamicOutput DSL map approach.
prha added inline comments to D5805: Migrate db.String to db.Text to support MySQL.
prha added a comment to D5951: [dagit] Add "Scheduled" tab to Runs page.
Oh, interesting. Do you think we need to display something for past ticks that haven't been resolved?
prha added a comment to D5951: [dagit] Add "Scheduled" tab to Runs page.
I prefer 'Upcoming' to 'Scheduled', just because they might not be scheduled, and upcoming is just ambiguous enough?
prha added inline comments to D5926: Raise a migration required exception when you load a pre-0.10.0 schedule storage.
prha requested changes to D5926: Raise a migration required exception when you load a pre-0.10.0 schedule storage.
prha requested review of D5946: set reasonable blank state for upcoming ticks.
prha added reviewers for D5941: RFC: Make default sharded sqlite implementation asset-aware: schrockn, alangenfeld, max, sandyryza.
prha requested review of D5941: RFC: Make default sharded sqlite implementation asset-aware.
Tue, Jan 12
Tue, Jan 12
prha committed R1:7cc6caf51caa: create run partition data migration, tie to `dagster instance migrate` (authored by prha).
create run partition data migration, tie to `dagster instance migrate`
prha updated the diff for D5916: create run partition data migration, tie to `dagster instance migrate`.
rebase
prha retitled D5916: create run partition data migration, tie to `dagster instance migrate` from RFC: create run partition data migration, tie to `dagster instance migrate` to create run partition data migration, tie to `dagster instance migrate`.
prha added a comment to D5916: create run partition data migration, tie to `dagster instance migrate`.
What's your take on how long we'd need to maintain this migration behavior? I've self-justified the complexity by thinking that we'd eventually consider it safe to remove this migration behavior.
prha updated the diff for D5916: create run partition data migration, tie to `dagster instance migrate`.
- rename index methods, add migration test
fix non-unique ids for partition status
prha requested review of D5933: fix non-unique ids for partition status.
Callout looks more prominent than I would have thought, but sure.
prha added inline comments to D5780: eliminate Persistable.
oh, this is a good idea!
Mon, Jan 11
Mon, Jan 11
prha committed R1:b7a353f327f0: Unify sensor timeline / job history graphs, tick history improvements (authored by prha).
Unify sensor timeline / job history graphs, tick history improvements
prha added inline comments to D5916: create run partition data migration, tie to `dagster instance migrate`.
prha retitled D5916: create run partition data migration, tie to `dagster instance migrate` from create run partition data migration to RFC: create run partition data migration, tie to `dagster instance migrate`.
prha requested review of D5916: create run partition data migration, tie to `dagster instance migrate`.
fix multi run id pipeline run filter queries
prha updated the summary of D5914: Unify sensor timeline / job history graphs, tick history improvements.
prha requested review of D5914: Unify sensor timeline / job history graphs, tick history improvements.
prha requested review of D5913: fix multi run id pipeline run filter queries.
Fri, Jan 8
Fri, Jan 8
Add initial overview docs for sensors
prha retitled D5812: Add initial overview docs for sensors from WIP: Add initial overview docs for sensors to Add initial overview docs for sensors.
prha added a comment to D5880: [dagit] Minor changes to "Next tick" timestamp.
yeah, mostly changed the format because it looked to wordy/repetitive, but switching up the timezone display helps a lot
prha added inline comments to D5819: Remove default partition selector from PartitionSetDefinition.create_schedule_definition.
prha accepted D5853: Update scheduler part of the tutorial to longer reference cron and the 'dagster schedule up' command..
I think this is good. I wonder, though, if we should talk about that the schedule decorators are partitioned
Thu, Jan 7
Thu, Jan 7
unify schedules / sensors in left nav list
prha updated the summary of D5861: unify schedules / sensors in left nav list.
prha updated the summary of D5861: unify schedules / sensors in left nav list.
prha committed R1:1965f7820fe8: RFC: Add migration to pull partition columns to the run table (authored by prha).
RFC: Add migration to pull partition columns to the run table
prha requested review of D5861: unify schedules / sensors in left nav list.
prha updated the diff for D5840: RFC: Add migration to pull partition columns to the run table.
add downgrade check
prha committed R1:23a4caf1a48e: add lazy migration for the secondary indexed asset keys (authored by prha).
add lazy migration for the secondary indexed asset keys
add combined schedule ticks
prha retitled D5788: add combined schedule ticks from add combined schedules graph to add combined schedule ticks.
prha updated the summary of D5788: add combined schedule ticks.
prha updated the diff for D5788: add combined schedule ticks.
update, replace graph with table
prha updated the diff for D5788: add combined schedule ticks.
- change graph to flat list