Page MenuHomePhabricator

prha (Phil Rha)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2019, 9:56 PM (76 w, 1 d)
Roles
Administrator

Recent Activity

Yesterday

prha accepted D6045: Run queue troubleshooting doc.
Tue, Jan 19, 11:45 PM
prha requested review of D6041: improve sensor CLI error messages.
Tue, Jan 19, 8:33 PM
prha accepted D6038: Add sensor_cli to api docs.
Tue, Jan 19, 4:04 PM

Fri, Jan 15

prha accepted D6031: [dagit] Upgrade eslint packages.

whynot

Fri, Jan 15, 8:13 PM
prha updated the diff for D5941: RFC: Make default sharded sqlite implementation asset-aware.

tests

Fri, Jan 15, 7:12 PM
prha updated the diff for D5941: RFC: Make default sharded sqlite implementation asset-aware.

fix bad indentation

Fri, Jan 15, 6:49 PM
prha planned changes to D5941: RFC: Make default sharded sqlite implementation asset-aware.
Fri, Jan 15, 6:40 PM
prha updated the diff for D5941: RFC: Make default sharded sqlite implementation asset-aware.
  • make two explicit connection calls in sql event log storage
Fri, Jan 15, 6:25 PM
prha committed R1:3b92ec5a557d: [Docs] 0.10.0 (authored by prha).
[Docs] 0.10.0
Fri, Jan 15, 3:10 AM
prha committed R1:dad381d3a6f6: 0.10.0 (authored by prha).
0.10.0
Fri, Jan 15, 1:14 AM
prha committed R1:a79b78a31e22: 0.10.0.pre0 (authored by prha).
0.10.0.pre0
Fri, Jan 15, 12:47 AM
prha closed D6022: pin chardet, to resolve dep conflict with aiohttp<=3.7.3.
Fri, Jan 15, 12:39 AM
prha committed R1:368b05ce4987: pin chardet, to resolve dep conflict with aiohttp<=3.7.3 (authored by prha).
pin chardet, to resolve dep conflict with aiohttp<=3.7.3
Fri, Jan 15, 12:39 AM
prha requested review of D6022: pin chardet, to resolve dep conflict with aiohttp<=3.7.3.
Fri, Jan 15, 12:35 AM
prha accepted D6021: Changelog nits.
Fri, Jan 15, 12:20 AM
prha published D6021: Changelog nits for review.
Fri, Jan 15, 12:20 AM

Thu, Jan 14

prha accepted D6019: Adds changelog notes and migration guide for 0.10.0..
Thu, Jan 14, 11:32 PM
prha published D6019: Adds changelog notes and migration guide for 0.10.0. for review.
Thu, Jan 14, 11:32 PM
prha accepted D6004: Tweak daemon docs.
Thu, Jan 14, 7:53 PM
prha closed D5997: handle latest version of nbformat, which adds random string ids.
Thu, Jan 14, 6:29 PM
prha committed R1:074f80071584: handle latest version of nbformat, which adds random string ids (authored by prha).
handle latest version of nbformat, which adds random string ids
Thu, Jan 14, 6:29 PM
prha requested review of D5997: handle latest version of nbformat, which adds random string ids.
Thu, Jan 14, 6:21 PM
prha accepted D5805: Migrate db.String to db.Text to support MySQL.

okay, looks good to me!

Thu, Jan 14, 6:06 PM
prha requested changes to D5805: Migrate db.String to db.Text to support MySQL.

This looks pretty solid... nice work.

Thu, Jan 14, 5:22 PM
prha closed D5991: make sure integrity error is caught within a connection contextmanager.
Thu, Jan 14, 4:43 PM
prha committed R1:76f4d7655827: make sure integrity error is caught within a connection contextmanager (authored by prha).
make sure integrity error is caught within a connection contextmanager
Thu, Jan 14, 4:43 PM
prha updated the diff for D5991: make sure integrity error is caught within a connection contextmanager.

lint

Thu, Jan 14, 4:23 PM
prha closed D5985: fix tick history panning, tooltip width.
Thu, Jan 14, 4:05 PM
prha committed R1:d87728fb178e: fix tick history panning, tooltip width (authored by prha).
fix tick history panning, tooltip width
Thu, Jan 14, 4:05 PM
prha added a comment to D5985: fix tick history panning, tooltip width.

Not without custom tooltips, which I'm looking into but is a lot for right now.

Thu, Jan 14, 4:04 PM
prha accepted D5982: Don't always run create_all during storage creation, add stamps to postgres storage.

push_n_pray

Thu, Jan 14, 4:53 AM
prha added inline comments to D5982: Don't always run create_all during storage creation, add stamps to postgres storage.
Thu, Jan 14, 12:19 AM

Wed, Jan 13

prha closed D5979: update screenshots for schedules/sensors.
Wed, Jan 13, 11:21 PM
prha committed R1:7304e801d6b6: update screenshots for schedules/sensors (authored by prha).
update screenshots for schedules/sensors
Wed, Jan 13, 11:21 PM
prha requested review of D5985: fix tick history panning, tooltip width.
Wed, Jan 13, 11:18 PM
prha requested review of D5979: update screenshots for schedules/sensors.
Wed, Jan 13, 10:28 PM
prha added a comment to D5721: DynamicOutput DSL map approach.

Yeah, this seems fine if it's for internal use.

Wed, Jan 13, 8:16 PM
prha added inline comments to D5721: DynamicOutput DSL map approach.
Wed, Jan 13, 8:15 PM
prha added inline comments to D5805: Migrate db.String to db.Text to support MySQL.
Wed, Jan 13, 4:58 PM
prha added a comment to D5951: [dagit] Add "Scheduled" tab to Runs page.

Oh, interesting. Do you think we need to display something for past ticks that haven't been resolved?

Wed, Jan 13, 4:51 PM
prha abandoned D5946: set reasonable blank state for upcoming ticks.
Wed, Jan 13, 4:46 PM
prha accepted D5952: [dagit] Use tabular-nums spacing on TimestampDisplay.
Wed, Jan 13, 4:46 PM
prha added a comment to D5951: [dagit] Add "Scheduled" tab to Runs page.

I prefer 'Upcoming' to 'Scheduled', just because they might not be scheduled, and upcoming is just ambiguous enough?

Wed, Jan 13, 4:46 PM
prha added inline comments to D5926: Raise a migration required exception when you load a pre-0.10.0 schedule storage.
Wed, Jan 13, 4:29 AM
prha requested changes to D5926: Raise a migration required exception when you load a pre-0.10.0 schedule storage.
Wed, Jan 13, 3:28 AM
prha requested review of D5946: set reasonable blank state for upcoming ticks.
Wed, Jan 13, 1:43 AM
prha accepted D5940: copy pass on sensors docs.
Wed, Jan 13, 12:44 AM
prha added reviewers for D5941: RFC: Make default sharded sqlite implementation asset-aware: schrockn, alangenfeld, max, sandyryza.
Wed, Jan 13, 12:38 AM
prha requested review of D5941: RFC: Make default sharded sqlite implementation asset-aware.
Wed, Jan 13, 12:34 AM

Tue, Jan 12

prha closed D5916: create run partition data migration, tie to `dagster instance migrate`.
Tue, Jan 12, 11:40 PM
prha committed R1:7cc6caf51caa: create run partition data migration, tie to `dagster instance migrate` (authored by prha).
create run partition data migration, tie to `dagster instance migrate`
Tue, Jan 12, 11:39 PM
prha updated the diff for D5916: create run partition data migration, tie to `dagster instance migrate`.

rebase

Tue, Jan 12, 11:14 PM
prha retitled D5916: create run partition data migration, tie to `dagster instance migrate` from RFC: create run partition data migration, tie to `dagster instance migrate` to create run partition data migration, tie to `dagster instance migrate`.
Tue, Jan 12, 10:29 PM
prha added a comment to D5916: create run partition data migration, tie to `dagster instance migrate`.

What's your take on how long we'd need to maintain this migration behavior? I've self-justified the complexity by thinking that we'd eventually consider it safe to remove this migration behavior.

Tue, Jan 12, 10:06 PM
prha updated the diff for D5916: create run partition data migration, tie to `dagster instance migrate`.
  • rename index methods, add migration test
Tue, Jan 12, 9:11 PM
prha closed D5933: fix non-unique ids for partition status.
Tue, Jan 12, 8:28 PM
prha committed R1:9c4843f7da1c: fix non-unique ids for partition status (authored by prha).
fix non-unique ids for partition status
Tue, Jan 12, 8:28 PM
prha requested review of D5933: fix non-unique ids for partition status.
Tue, Jan 12, 8:14 PM
prha accepted D5930: [dagit] Update "Timing" column for Queued runs.
Tue, Jan 12, 7:18 PM
prha accepted D5923: migration for wiping the scheduler when transitioning from 0.9.x to 0.10.0.
Tue, Jan 12, 7:06 PM
prha accepted D5915: [dagit] Link to run config from Queued tab.

Callout looks more prominent than I would have thought, but sure.

Tue, Jan 12, 6:16 PM
prha added inline comments to D5780: eliminate Persistable.
Tue, Jan 12, 6:06 PM
prha accepted D5919: Add "scheduler" column to schedule storage.

oh, this is a good idea!

Tue, Jan 12, 12:12 AM

Mon, Jan 11

prha closed D5914: Unify sensor timeline / job history graphs, tick history improvements.
Mon, Jan 11, 11:51 PM
prha committed R1:b7a353f327f0: Unify sensor timeline / job history graphs, tick history improvements (authored by prha).
Unify sensor timeline / job history graphs, tick history improvements
Mon, Jan 11, 11:51 PM
prha accepted D5917: [easy] fix toy schedule referencing a pipeline that doesn't exist.
Mon, Jan 11, 10:55 PM
prha added inline comments to D5916: create run partition data migration, tie to `dagster instance migrate`.
Mon, Jan 11, 10:54 PM
prha retitled D5916: create run partition data migration, tie to `dagster instance migrate` from create run partition data migration to RFC: create run partition data migration, tie to `dagster instance migrate`.
Mon, Jan 11, 10:02 PM
prha requested review of D5916: create run partition data migration, tie to `dagster instance migrate`.
Mon, Jan 11, 9:56 PM
prha accepted D5908: Finish breaking change to date_partition_range to handle timezones correctly.
Mon, Jan 11, 8:27 PM
prha accepted D5909: [dagit] Use tabular-nums for in-progress solid execution timing.
Mon, Jan 11, 8:27 PM
prha closed D5913: fix multi run id pipeline run filter queries.
Mon, Jan 11, 8:13 PM
prha committed R1:2b6ce4a1c229: fix multi run id pipeline run filter queries (authored by prha).
fix multi run id pipeline run filter queries
Mon, Jan 11, 8:13 PM
prha updated the summary of D5914: Unify sensor timeline / job history graphs, tick history improvements.
Mon, Jan 11, 8:01 PM
prha requested review of D5914: Unify sensor timeline / job history graphs, tick history improvements.
Mon, Jan 11, 7:53 PM
prha requested review of D5913: fix multi run id pipeline run filter queries.
Mon, Jan 11, 7:52 PM

Fri, Jan 8

prha closed D5812: Add initial overview docs for sensors.
Fri, Jan 8, 9:50 PM
prha committed R1:8b1b5307921b: Add initial overview docs for sensors (authored by prha).
Add initial overview docs for sensors
Fri, Jan 8, 9:50 PM
prha retitled D5812: Add initial overview docs for sensors from WIP: Add initial overview docs for sensors to Add initial overview docs for sensors.
Fri, Jan 8, 9:48 PM
prha added a comment to D5880: [dagit] Minor changes to "Next tick" timestamp.

yeah, mostly changed the format because it looked to wordy/repetitive, but switching up the timezone display helps a lot

Fri, Jan 8, 5:10 PM
prha accepted D5880: [dagit] Minor changes to "Next tick" timestamp.
Fri, Jan 8, 5:09 PM
prha added inline comments to D5819: Remove default partition selector from PartitionSetDefinition.create_schedule_definition.
Fri, Jan 8, 4:49 PM
prha accepted D5853: Update scheduler part of the tutorial to longer reference cron and the 'dagster schedule up' command..

I think this is good. I wonder, though, if we should talk about that the schedule decorators are partitioned

Fri, Jan 8, 12:02 AM

Thu, Jan 7

prha closed D5861: unify schedules / sensors in left nav list.
Thu, Jan 7, 9:02 PM
prha committed R1:fcfd69386fec: unify schedules / sensors in left nav list (authored by prha).
unify schedules / sensors in left nav list
Thu, Jan 7, 9:02 PM
prha updated the summary of D5861: unify schedules / sensors in left nav list.
Thu, Jan 7, 8:49 PM
prha updated the summary of D5861: unify schedules / sensors in left nav list.
Thu, Jan 7, 8:48 PM
prha accepted D5859: Some Jest cleanup.
Thu, Jan 7, 8:47 PM
prha closed D5840: RFC: Add migration to pull partition columns to the run table.
Thu, Jan 7, 8:41 PM
prha committed R1:1965f7820fe8: RFC: Add migration to pull partition columns to the run table (authored by prha).
RFC: Add migration to pull partition columns to the run table
Thu, Jan 7, 8:41 PM
prha requested review of D5861: unify schedules / sensors in left nav list.
Thu, Jan 7, 8:30 PM
prha updated the diff for D5840: RFC: Add migration to pull partition columns to the run table.

add downgrade check

Thu, Jan 7, 6:38 PM
prha closed D5823: add lazy migration for the secondary indexed asset keys.
Thu, Jan 7, 6:14 PM
prha committed R1:23a4caf1a48e: add lazy migration for the secondary indexed asset keys (authored by prha).
add lazy migration for the secondary indexed asset keys
Thu, Jan 7, 6:14 PM
prha closed D5788: add combined schedule ticks.
Thu, Jan 7, 4:41 AM
prha committed R1:9b85558f3293: add combined schedule ticks (authored by prha).
add combined schedule ticks
Thu, Jan 7, 4:41 AM
prha retitled D5788: add combined schedule ticks from add combined schedules graph to add combined schedule ticks.
Thu, Jan 7, 4:38 AM
prha updated the summary of D5788: add combined schedule ticks.
Thu, Jan 7, 12:53 AM
prha updated the diff for D5788: add combined schedule ticks.

update, replace graph with table

Thu, Jan 7, 12:49 AM
prha updated the diff for D5788: add combined schedule ticks.
  • change graph to flat list
Thu, Jan 7, 12:41 AM