Page MenuHomePhabricator

prha (Phil Rha)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2019, 9:56 PM (28 w, 4 d)

Recent Activity

Today

prha requested changes to D2098: [BUGFIX] - Thread in solid_subset into PartitionSetDefinitions.

It's not obvious from the test that this would still yield what you actually want.

Sat, Feb 22, 12:01 AM

Yesterday

prha created D2103: support env_vars in dagster-snowflake.
Fri, Feb 21, 11:48 PM
prha accepted D2099: detect cycles at instantiation time.
Fri, Feb 21, 10:08 PM
prha committed R1:74be7874b71b: change scoped pipeline context to event generator (authored by prha).
change scoped pipeline context to event generator
Fri, Feb 21, 9:39 PM
prha closed D2073: change scoped pipeline context to event generator.
Fri, Feb 21, 9:39 PM
prha requested changes to D2098: [BUGFIX] - Thread in solid_subset into PartitionSetDefinitions.
Fri, Feb 21, 9:34 PM
prha committed R1:7258f56ce7bb: make sure interactive context have defined resources for example notebooks (authored by prha).
make sure interactive context have defined resources for example notebooks
Fri, Feb 21, 9:12 PM
prha closed D2096: make sure interactive context have defined resources for example notebooks.
Fri, Feb 21, 9:11 PM
prha updated the diff for D2073: change scoped pipeline context to event generator.
  • add exception-handling tests, add comments, extract resource init
Fri, Feb 21, 9:08 PM
prha updated the diff for D2096: make sure interactive context have defined resources for example notebooks.

rebase

Fri, Feb 21, 6:57 PM
prha created D2096: make sure interactive context have defined resources for example notebooks.
Fri, Feb 21, 6:41 PM

Thu, Feb 20

prha updated the diff for D2073: change scoped pipeline context to event generator.
  • add check casts to get_object calls
Thu, Feb 20, 10:54 PM
prha updated the diff for D2073: change scoped pipeline context to event generator.
  • tests and refactor
Thu, Feb 20, 10:46 PM
prha planned changes to D2073: change scoped pipeline context to event generator.
Thu, Feb 20, 8:31 PM
prha updated the diff for D2073: change scoped pipeline context to event generator.

add tests, make sure resource stack tears down on failures

Thu, Feb 20, 2:00 AM
prha added a comment to D2073: change scoped pipeline context to event generator.

couple things.... still trying to figure out the exception handling. I think we weren't tearing down resources properly before, so figuring out what tests we need to write, change, etc.

Thu, Feb 20, 12:12 AM
prha updated the diff for D2073: change scoped pipeline context to event generator.
  • pipeline initialization events, but with generators INSTEAD of context managers
Thu, Feb 20, 12:06 AM

Wed, Feb 19

prha updated the diff for D2073: change scoped pipeline context to event generator.

fix scoped_pipeline_context reference

Wed, Feb 19, 6:49 PM
prha updated the diff for D2073: change scoped pipeline context to event generator.

add try/finally, remove double defaults

Wed, Feb 19, 6:18 PM
prha added a comment to D2073: change scoped pipeline context to event generator.

I initially had it so that the resource/builder/context were yielded along with the event stream, but switched it (per @alangenfeld's suggestion) because it makes it way more explicit in the caller what is going on. I do like this better and we're not mixing types so much. It was getting confusing where we're stacking things at different levels and the type I'm trying to extract is different at each level.

Wed, Feb 19, 6:10 PM
prha committed R1:092691b676ec: fix reload supported flag on dagit reloader (authored by prha).
fix reload supported flag on dagit reloader
Wed, Feb 19, 5:58 PM
prha closed D2075: fix reload supported flag on dagit reloader.
Wed, Feb 19, 5:58 PM
prha accepted D2067: ActiveExecution cleanup.
Wed, Feb 19, 12:45 AM
prha updated the diff for D2075: fix reload supported flag on dagit reloader.

rebase

Wed, Feb 19, 12:32 AM
prha created D2075: fix reload supported flag on dagit reloader.
Wed, Feb 19, 12:11 AM

Tue, Feb 18

prha accepted D2074: Disable dask and gcp tests..
Tue, Feb 18, 11:36 PM
prha accepted D2072: [dagit] improve event log tags.
Tue, Feb 18, 11:05 PM
prha created D2073: change scoped pipeline context to event generator.
Tue, Feb 18, 11:00 PM

Mon, Feb 17

prha accepted D2059: [dagit] fix errored step exec time.
Mon, Feb 17, 5:25 PM

Sat, Feb 15

prha committed R1:d50ec1f2afaa: switch to pass connection instead of engine to check_alembic_revision (authored by prha).
switch to pass connection instead of engine to check_alembic_revision
Sat, Feb 15, 1:20 AM
prha closed D2057: switch to pass connection instead of engine to check_alembic_revision.
Sat, Feb 15, 1:20 AM
prha created D2057: switch to pass connection instead of engine to check_alembic_revision.
Sat, Feb 15, 1:07 AM

Fri, Feb 14

prha accepted D2051: Set language for literal includes.
Fri, Feb 14, 10:39 PM

Thu, Feb 13

prha accepted D2042: fix missing args in pipeline run roundtrip.
Thu, Feb 13, 9:01 PM
prha accepted D2039: use source import from dagster.seven.
Thu, Feb 13, 6:37 PM
prha accepted D2010: Partition Docs.
Thu, Feb 13, 12:04 AM

Wed, Feb 12

prha committed R1:613ac12b4c1b: add scheduler storage sqlite to manifest (authored by prha).
add scheduler storage sqlite to manifest
Wed, Feb 12, 11:59 PM
prha closed D2035: add scheduler storage sqlite to manifest.
Wed, Feb 12, 11:59 PM
prha committed R1:14e5480b11c8: make scheduler warning stack easier to parse (authored by prha).
make scheduler warning stack easier to parse
Wed, Feb 12, 11:53 PM
prha closed D2033: make scheduler warning stack easier to parse.
Wed, Feb 12, 11:53 PM
prha created D2035: add scheduler storage sqlite to manifest.
Wed, Feb 12, 11:53 PM
prha added inline comments to D2010: Partition Docs.
Wed, Feb 12, 11:38 PM
prha created D2033: make scheduler warning stack easier to parse.
Wed, Feb 12, 11:21 PM
prha committed R1:a4e3bc3e14f7: make all run buttons launch enabled (authored by prha).
make all run buttons launch enabled
Wed, Feb 12, 11:07 PM
prha closed D2027: make all run buttons launch enabled.
Wed, Feb 12, 11:07 PM
prha added inline comments to D2024: [dagit] handle errors in DirectGraphQLSubscription.
Wed, Feb 12, 10:54 PM
prha added a reviewer for D2027: make all run buttons launch enabled: bengotow.
Wed, Feb 12, 10:52 PM
prha updated the diff for D2027: make all run buttons launch enabled.

add syncing hack using useState

Wed, Feb 12, 10:51 PM
prha created D2027: make all run buttons launch enabled.
Wed, Feb 12, 10:26 PM
prha added inline comments to D2024: [dagit] handle errors in DirectGraphQLSubscription.
Wed, Feb 12, 9:58 PM
prha committed R1:115564b8a41d: resolve tags type error (authored by prha).
resolve tags type error
Wed, Feb 12, 7:03 PM
prha closed D2017: resolve tags type error.
Wed, Feb 12, 7:03 PM
prha created D2017: resolve tags type error.
Wed, Feb 12, 6:47 PM
prha committed R1:cef09d56f9f4: add prha changes 0.7.0, migrations (authored by prha).
add prha changes 0.7.0, migrations
Wed, Feb 12, 6:31 PM
prha closed D2014: add prha changes 0.7.0, migrations.
Wed, Feb 12, 6:31 PM
prha created D2014: add prha changes 0.7.0, migrations.
Wed, Feb 12, 5:32 PM
prha accepted D2004: 0.7.0 Migration Guide.

My vote is to move to 0.7.0_MIGRATION.md, but we should get this in so others can add to it.

Wed, Feb 12, 1:10 AM

Tue, Feb 11

prha accepted D2005: [dagit] dont fetch envYaml on load in runs page.

zoomzoomzoom

Tue, Feb 11, 10:46 PM
prha created Image Macro "zoomzoomzoom".
Tue, Feb 11, 10:45 PM
prha added inline comments to D1964: Dagster Pandas Guide Docs.
Tue, Feb 11, 10:26 PM
prha added a comment to D1964: Dagster Pandas Guide Docs.

Could just be me, but it feels jarring to switch so often between passive voice, 1st person and 2nd person.

Tue, Feb 11, 10:00 PM
prha accepted D1768: [core] add context to type_checks.

yeah, this makes sense to me.

Tue, Feb 11, 9:07 PM
prha accepted D2002: [changelog] add my 0.7.0 entries.

some spelling / grammar nits, but okay!

Tue, Feb 11, 7:54 PM
prha added a comment to D1997: Rework Gaant for performant rendering on large DAGs, add sidebar, polish.

Some polish feedback:

Tue, Feb 11, 7:35 PM
prha committed R1:2d7acf53cb41: add changes (authored by prha).
add changes
Tue, Feb 11, 6:42 PM
prha committed R1:a69fccfdced2: cascade run deletions in postgres (authored by prha).
cascade run deletions in postgres
Tue, Feb 11, 6:38 PM
prha closed D1992: cascade run deletions in postgres.
Tue, Feb 11, 6:38 PM
prha updated the diff for D1992: cascade run deletions in postgres.
  • add in memory, sqlite storage impl
Tue, Feb 11, 6:25 PM
prha planned changes to D1992: cascade run deletions in postgres.

Need to fix the other RunStorage implementations...

Tue, Feb 11, 12:53 AM
prha updated the diff for D1992: cascade run deletions in postgres.

resolve conflicting tag issues

Tue, Feb 11, 12:42 AM
prha updated the diff for D1992: cascade run deletions in postgres.

assert empty run tags

Tue, Feb 11, 12:27 AM
prha committed R1:f2642a909154: Add support for adding tags in the execution playground tag editor (authored by prha).
Add support for adding tags in the execution playground tag editor
Tue, Feb 11, 12:20 AM
prha closed D1962: Add support for adding tags in the execution playground tag editor.
Tue, Feb 11, 12:20 AM

Mon, Feb 10

prha committed R1:ada7278bb184: defer session filtering while pipeline names are loading (authored by prha).
defer session filtering while pipeline names are loading
Mon, Feb 10, 10:29 PM
prha closed D1958: defer session filtering while pipeline names are loading.
Mon, Feb 10, 10:29 PM
prha updated the summary of D1992: cascade run deletions in postgres.
Mon, Feb 10, 10:20 PM
prha added inline comments to D1958: defer session filtering while pipeline names are loading.
Mon, Feb 10, 10:13 PM
prha updated the diff for D1992: cascade run deletions in postgres.

update to sync event_storage, run_storage migration scripts

Mon, Feb 10, 10:10 PM
prha accepted D1986: Remove backwards-compatible run_config from execution context (#1874).
Mon, Feb 10, 9:33 PM
prha created D1992: cascade run deletions in postgres.
Mon, Feb 10, 9:32 PM
prha accepted D1990: 2 step re-execution test.
Mon, Feb 10, 9:21 PM
prha added a comment to D1990: 2 step re-execution test.

yaytests

Mon, Feb 10, 9:20 PM
prha added a comment to D1986: Remove backwards-compatible run_config from execution context (#1874).

My vote is to keep create_execution_plan taking in RunConfig.

Mon, Feb 10, 5:01 PM

Sat, Feb 8

prha committed R1:c7c385787e9e: Strip out solid-specific error message in dagster resource error (authored by prha).
Strip out solid-specific error message in dagster resource error
Sat, Feb 8, 12:01 AM
prha closed D1984: Strip out solid-specific error message in dagster resource error.
Sat, Feb 8, 12:01 AM

Fri, Feb 7

prha committed R1:b5d75b034eca: add docstrings for ComputeLogManager (authored by prha).
add docstrings for ComputeLogManager
Fri, Feb 7, 11:45 PM
prha closed D1963: add docstrings for ComputeLogManager.
Fri, Feb 7, 11:45 PM
prha created D1984: Strip out solid-specific error message in dagster resource error.
Fri, Feb 7, 11:42 PM
prha updated the diff for D1963: add docstrings for ComputeLogManager.

add method docs

Fri, Feb 7, 11:08 PM
prha committed R1:ce4d86a96901: update system storage resource docs (authored by prha).
update system storage resource docs
Fri, Feb 7, 11:06 PM
prha closed D1980: update system storage resource docs.
Fri, Feb 7, 11:06 PM
prha committed R1:70fbd1801bf0: skip loading resources when not available on the wider pipeline context (authored by prha).
skip loading resources when not available on the wider pipeline context
Fri, Feb 7, 11:06 PM
prha closed D1979: skip loading resources when not available on the wider pipeline context.
Fri, Feb 7, 11:06 PM
prha updated the diff for D1979: skip loading resources when not available on the wider pipeline context.

update with resource keys available invariant check

Fri, Feb 7, 10:41 PM
prha updated the diff for D1979: skip loading resources when not available on the wider pipeline context.

update snapshots

Fri, Feb 7, 9:49 PM
prha retitled D1980: update system storage resource docs from update s3 resource docs to update system storage resource docs.
Fri, Feb 7, 9:46 PM
prha updated the diff for D1980: update system storage resource docs.

update with gcs update

Fri, Feb 7, 9:42 PM
prha created D1980: update system storage resource docs.
Fri, Feb 7, 9:40 PM
prha created D1979: skip loading resources when not available on the wider pipeline context.
Fri, Feb 7, 9:27 PM
prha accepted D1974: Kill new as_dagster_type invokes.

This feels fine to me.... are we moving away from the define_python_dagster_type calls that are featured in D1906?

Fri, Feb 7, 5:48 PM