Page MenuHomePhabricator

prha (Phil Rha)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2019, 9:56 PM (18 w, 4 d)

Recent Activity

Today

prha updated the diff for D1657: Add web worker to calculate dagre layout for large graphs.

rebased, added jest mocks

Sat, Dec 14, 2:03 AM
prha committed R1:33f93e1e71cb: extract graph container from PipelineExplorer (2 of 4) (authored by prha).
extract graph container from PipelineExplorer (2 of 4)
Sat, Dec 14, 12:57 AM
prha closed D1652: extract graph container from PipelineExplorer (2 of 4).
Sat, Dec 14, 12:57 AM
prha updated the diff for D1652: extract graph container from PipelineExplorer (2 of 4).

rebase

Sat, Dec 14, 12:25 AM

Yesterday

prha committed R1:c6e27d3ba704: Extract layout-only methods into a standalone file that can be called from a… (authored by prha).
Extract layout-only methods into a standalone file that can be called from a…
Fri, Dec 13, 11:57 PM
prha closed D1651: Extract layout-only methods into a standalone file that can be called from a web-worker (1 of 4).
Fri, Dec 13, 11:57 PM
prha planned changes to D1657: Add web worker to calculate dagre layout for large graphs.

Need to mock out jest config to support web workers

Fri, Dec 13, 11:51 PM
prha updated the diff for D1651: Extract layout-only methods into a standalone file that can be called from a web-worker (1 of 4).

rebase

Fri, Dec 13, 11:41 PM
prha added a comment to D1651: Extract layout-only methods into a standalone file that can be called from a web-worker (1 of 4).

Yeah, I would do this if it were really clean, but a lot of the types are reused all over the place

Fri, Dec 13, 11:30 PM
prha committed R1:f92e17047499: Extract dom utils from Utils (authored by prha).
Extract dom utils from Utils
Fri, Dec 13, 11:25 PM
prha closed D1654: Extract dom utils from Utils.
Fri, Dec 13, 11:25 PM
prha updated the diff for D1657: Add web worker to calculate dagre layout for large graphs.

add back memoization for the async dagre layout call

Fri, Dec 13, 11:15 PM
prha updated the summary of D1657: Add web worker to calculate dagre layout for large graphs.
Fri, Dec 13, 9:40 PM
prha created D1657: Add web worker to calculate dagre layout for large graphs.
Fri, Dec 13, 9:39 PM
prha created D1654: Extract dom utils from Utils.
Fri, Dec 13, 6:45 PM
prha created D1652: extract graph container from PipelineExplorer (2 of 4).
Fri, Dec 13, 6:42 PM
prha created D1651: Extract layout-only methods into a standalone file that can be called from a web-worker (1 of 4).
Fri, Dec 13, 6:39 PM

Wed, Dec 11

prha accepted D1636: Rename Scheduler graphql schema file.

makeitso

Wed, Dec 11, 11:13 PM
prha committed R1:3d99bf535417: fix pipeline definition doc to reference solid (authored by prha).
fix pipeline definition doc to reference solid
Wed, Dec 11, 10:13 PM
prha closed D1634: fix pipeline definition doc to reference solid.
Wed, Dec 11, 10:13 PM
prha created D1634: fix pipeline definition doc to reference solid.
Wed, Dec 11, 7:36 PM
prha committed R1:8c756197188e: Refactor solid selector to defer query until selector is opened (authored by prha).
Refactor solid selector to defer query until selector is opened
Wed, Dec 11, 12:33 AM
prha closed D1627: Refactor solid selector to defer query until selector is opened.
Wed, Dec 11, 12:33 AM
prha committed R1:d380ffc62678: fix console warnings about accessibility (authored by prha).
fix console warnings about accessibility
Wed, Dec 11, 12:32 AM
prha closed D1630: fix console warnings about accessibility.
Wed, Dec 11, 12:32 AM
prha added inline comments to D1617: Remove execution_params from ScheduleDefinition.
Wed, Dec 11, 12:31 AM
prha requested changes to D1612: Create resource for partitions.

returning to your queue

Wed, Dec 11, 12:24 AM
prha updated the diff for D1627: Refactor solid selector to defer query until selector is opened.

use default cache policy

Wed, Dec 11, 12:21 AM
prha updated the diff for D1630: fix console warnings about accessibility.

update snapshots

Wed, Dec 11, 12:19 AM
prha added inline comments to D1612: Create resource for partitions.
Wed, Dec 11, 12:18 AM

Tue, Dec 10

prha created D1630: fix console warnings about accessibility.
Tue, Dec 10, 11:36 PM
prha added inline comments to D1617: Remove execution_params from ScheduleDefinition.
Tue, Dec 10, 9:18 PM
prha updated the summary of D1627: Refactor solid selector to defer query until selector is opened.
Tue, Dec 10, 9:12 PM
prha created D1627: Refactor solid selector to defer query until selector is opened.
Tue, Dec 10, 9:00 PM
prha committed R1:90cec00bdc54: add backfill cli script (authored by prha).
add backfill cli script
Tue, Dec 10, 5:36 PM
prha closed D1566: add backfill cli script.
Tue, Dec 10, 5:36 PM
prha updated the diff for D1566: add backfill cli script.

update

Tue, Dec 10, 5:24 PM
prha committed R1:2090c33b9410: limit compute log filename length (authored by prha).
limit compute log filename length
Tue, Dec 10, 5:05 PM
prha closed D1610: limit compute log filename length.
Tue, Dec 10, 5:05 PM
prha added a comment to D1610: limit compute log filename length.

Yeah, it's not clear to me exactly how to extract any meaningful partial signal from the step_key.

Tue, Dec 10, 5:01 PM
prha accepted D1615: Update datetime partition example to use Partition API.
Tue, Dec 10, 12:53 AM
prha accepted D1613: Add tag for partition set name.
Tue, Dec 10, 12:48 AM
prha updated the diff for D1566: add backfill cli script.

support CLI-based partition tagging, handle ambiguous partition_set arguments

Tue, Dec 10, 12:02 AM

Mon, Dec 9

prha created D1610: limit compute log filename length.
Mon, Dec 9, 9:43 PM
prha abandoned D1431: Add UI for partitions in Dagit.
Mon, Dec 9, 5:12 PM
prha abandoned D1442: add scheduled partition execution.
Mon, Dec 9, 5:11 PM

Sat, Dec 7

prha planned changes to D1566: add backfill cli script.

will look into the tags issue

Sat, Dec 7, 12:55 AM
prha updated the diff for D1566: add backfill cli script.

update

Sat, Dec 7, 12:26 AM
prha updated the diff for D1566: add backfill cli script.

rebase

Sat, Dec 7, 12:08 AM

Fri, Dec 6

prha updated the diff for D1566: add backfill cli script.

update

Fri, Dec 6, 11:44 PM
prha committed R1:d139d6453e4f: generate empty stats object (authored by prha).
generate empty stats object
Fri, Dec 6, 11:15 PM
prha closed D1567: generate empty stats object.
Fri, Dec 6, 11:15 PM
prha updated the diff for D1566: add backfill cli script.

update

Fri, Dec 6, 11:01 PM
prha accepted D1430: Introduce Partition API.

Looks good! Once build issues are resolved (and one typo), let's land!

Fri, Dec 6, 10:57 PM
prha created D1567: generate empty stats object.
Fri, Dec 6, 10:39 PM
prha created D1566: add backfill cli script.
Fri, Dec 6, 10:28 PM
prha added inline comments to D1430: Introduce Partition API.
Fri, Dec 6, 1:12 AM
prha requested changes to D1430: Introduce Partition API.

some style nits, but also we should write some tests.

Fri, Dec 6, 12:07 AM

Wed, Dec 4

prha committed R1:6470ef6f7448: fix graphql playground errors (authored by prha).
fix graphql playground errors
Wed, Dec 4, 7:24 PM
prha closed D1535: fix graphql playground errors.
Wed, Dec 4, 7:24 PM
prha added a reviewer for D1535: fix graphql playground errors: alangenfeld.
Wed, Dec 4, 6:46 PM
prha updated the diff for D1535: fix graphql playground errors.

update schema

Wed, Dec 4, 5:46 PM
prha created D1535: fix graphql playground errors.
Wed, Dec 4, 4:45 PM
prha committed R1:af5fd29a27e8: link schedule page (authored by prha).
link schedule page
Wed, Dec 4, 12:38 AM
prha closed D1527: link schedule page.
Wed, Dec 4, 12:38 AM

Tue, Dec 3

prha updated the diff for D1527: link schedule page.

sashank

Tue, Dec 3, 11:08 PM
prha updated the diff for D1527: link schedule page.

regenerate types

Tue, Dec 3, 3:00 AM
prha updated the summary of D1527: link schedule page.
Tue, Dec 3, 1:35 AM
prha updated the diff for D1527: link schedule page.

updated to display attempts rather than runs

Tue, Dec 3, 1:33 AM
prha added inline comments to D1430: Introduce Partition API.
Tue, Dec 3, 12:59 AM
prha added inline comments to D1527: link schedule page.
Tue, Dec 3, 12:29 AM

Mon, Dec 2

prha updated the diff for D1527: link schedule page.

snapshot update

Mon, Dec 2, 11:46 PM
prha added inline comments to D1430: Introduce Partition API.
Mon, Dec 2, 11:19 PM
prha updated the summary of D1527: link schedule page.
Mon, Dec 2, 10:53 PM
prha created D1527: link schedule page.
Mon, Dec 2, 10:48 PM
prha accepted D1501: Eliminate selector argument from PipelineDefinition.

This looks good to me...

Mon, Dec 2, 5:13 PM
prha accepted D1515: Add a loading spinner to the runs filter input (#1922).

lg!

Mon, Dec 2, 4:37 PM

Wed, Nov 27

prha committed R1:dbb6fea8fbec: disable retry button for in_memory storage (authored by prha).
disable retry button for in_memory storage
Wed, Nov 27, 5:18 PM
prha closed D1497: disable retry button for in_memory storage.
Wed, Nov 27, 5:18 PM
prha updated the diff for D1497: disable retry button for in_memory storage.

description change

Wed, Nov 27, 5:17 PM
prha updated the summary of D1497: disable retry button for in_memory storage.
Wed, Nov 27, 2:23 AM
prha updated the summary of D1497: disable retry button for in_memory storage.
Wed, Nov 27, 2:22 AM
prha updated the summary of D1497: disable retry button for in_memory storage.
Wed, Nov 27, 2:21 AM
prha created D1497: disable retry button for in_memory storage.
Wed, Nov 27, 2:19 AM
prha updated the diff for D1430: Introduce Partition API.

update to comments, using namedtuple, adding default partition selector

Wed, Nov 27, 1:29 AM
prha added inline comments to D1430: Introduce Partition API.
Wed, Nov 27, 12:26 AM

Tue, Nov 26

prha updated the diff for D1430: Introduce Partition API.
  • move partition definitions to standalone repository yaml section
  • mapped config
Tue, Nov 26, 11:09 PM

Mon, Nov 25

prha resigned from D1471: Refactor SQL-based event log storages to use SQLAlchemy.
Mon, Nov 25, 11:03 PM
prha committed R1:05761fda5ec4: create schedule page, show schedule attempts (authored by prha).
create schedule page, show schedule attempts
Mon, Nov 25, 5:29 PM
prha closed D1479: create schedule page, show schedule attempts.
Mon, Nov 25, 5:29 PM
prha added a comment to D1479: create schedule page, show schedule attempts.

Mostly because I'm anticipating landing some partition UI that we don't want to expose quite yet...

Mon, Nov 25, 5:23 PM
prha created D1479: create schedule page, show schedule attempts.
Mon, Nov 25, 6:19 AM

Sun, Nov 24

prha added a comment to D1430: Introduce Partition API.

Thanks for this feedback. It might be helpful to describe how I've been thinking about some of the specific decisions.

Sun, Nov 24, 9:14 PM

Sat, Nov 23

prha updated the diff for D1430: Introduce Partition API.

black

Sat, Nov 23, 1:15 AM
prha retitled D1430: Introduce Partition API from Introduce Schedule Partition API to Introduce Partition API.
Sat, Nov 23, 1:14 AM
prha updated the diff for D1430: Introduce Partition API.
  • defines partition core api
  • extracts partition definion from schedule and puts on pipeline definition
  • added partition selector to schedule definition
Sat, Nov 23, 1:04 AM

Fri, Nov 22

prha added a comment to D1468: [dagster-graphql] make --remote use post.

makeitso

Fri, Nov 22, 11:26 PM
prha accepted D1468: [dagster-graphql] make --remote use post.
Fri, Nov 22, 11:19 PM

Thu, Nov 21

prha added a comment to D1296: [RunLauncher] basic interface.

launchsuccess

Thu, Nov 21, 12:54 AM
prha created Image Macro "launchsuccess".
Thu, Nov 21, 12:54 AM