User Details
User Details
- User Since
- Aug 5 2019, 9:56 PM (121 w, 2 d)
- Roles
- Administrator
Aug 9 2021
Aug 9 2021
This is so that the cloud index can add cloud-specific routes?
Aug 3 2021
Aug 3 2021
Jul 31 2021
Jul 31 2021
Jul 30 2021
Jul 30 2021
fix run stats for backfill progress
prha updated the diff for D9169: skip failing windows test for grpc/ipc failures on empty dir.
update
prha published D9169: skip failing windows test for grpc/ipc failures on empty dir for review.
prha added a comment to D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.
This makes sense to me... thanks for cleaning this up.
prha planned changes to D8321: Add CLI command to reset migration state.
show schedules/sensors that are not in storage
Jul 29 2021
Jul 29 2021
prha requested review of D9155: show schedules/sensors that are not in storage.
fix tooltip content for sensor timeline
prha updated the diff for D9153: fix tooltip content for sensor timeline.
noticed that the future tick colors were also off
prha requested review of D9152: fix run stats for backfill progress.
prha committed R1:9652d966c5c2: enable backfills to recover from failed partitioned solid selection runs (authored by prha).
enable backfills to recover from failed partitioned solid selection runs
prha added inline comments to D9070: [caprisun] RepositoryDefinition.asset_definition_graph.
just to confirm then... was this not broken on prod?
prha added inline comments to D9116: [Easy] Adding serialization decorators & convenience methods.
prha requested review of D9138: enable backfills to recover from failed partitioned solid selection runs.
prha committed R1:bfb90e8b0b44: Revert "Load execution plan from the snapshot on the run when resume retrying" (authored by prha).
Revert "Load execution plan from the snapshot on the run when resume retrying"
Jul 28 2021
Jul 28 2021
prha added a comment to D9124: [dagit] Repair layout worker, large DAG loading.
Yeah, I think the important piece is not being reliant on webpack, so that we can actually do the imports asynchronously from the webworker.
prha added a comment to D9124: [dagit] Repair layout worker, large DAG loading.
Is there a way to test that the layout worker doesn't have imports (direct or transitive) that will break it?
Jul 27 2021
Jul 27 2021
Jul 23 2021
Jul 23 2021
handle wiped assets for asset index migration
prha requested review of D9043: handle wiped assets for asset index migration.
prha committed R1:d83aae80f45b: tailwind config for highlighting back links in source snippets (authored by prha).
tailwind config for highlighting back links in source snippets
prha requested review of D9035: tailwind config for highlighting back links in source snippets.
Jul 22 2021
Jul 22 2021
prha added inline comments to D8969: [caprisun] @asset and build_assets_job.
Jul 20 2021
Jul 20 2021
prha committed R1:a26ded525684: fix postgres backcompat test flakiness (stable set comparison) (authored by prha).
fix postgres backcompat test flakiness (stable set comparison)
prha requested review of D8967: fix postgres backcompat test flakiness (stable set comparison).
Jul 19 2021
Jul 19 2021
Jul 16 2021
Jul 16 2021
Jul 15 2021
Jul 15 2021
prha updated the diff for D8840: convert local compute log manager.
more mypy, renaming for clarity
prha added inline comments to D8840: convert local compute log manager.
prha updated the diff for D8845: have AzureComputeLogManager implement CapturedLogManager interface.
rebase
prha updated the diff for D8844: have GcsComputeLogManager implement CapturedLogManager interface.
rebase
prha updated the diff for D8843: have S3ComputeLogManager implement CapturedLogManager interface.
rebase
prha updated the diff for D8842: Make implement NoopComputeLogManager implement CapturedLogManager interface.
rebase
prha added inline comments to D8840: convert local compute log manager.
prha abandoned D7945: RFC: add new api hooks for compute log manager to capture logs outside of a pipeline context, support process-based capture.
In favor of D8385
prha abandoned D8905: testtt.
prha updated the diff for D8385: add captured log manager interface.
added comments, renamed some methods, dropped is_enabled
prha requested review of D8905: testtt.
disable flaky test_partial_backfill in windows
Jul 14 2021
Jul 14 2021
prha added a comment to D8900: RunStatusSensorDefinition and @run_status_sensor.
It gets a little hairy if we allow arbitrary dagster event types, because the current implementation (with the RunShardedEventsCursor) implicitly assumes a 1-to-1 event to run mapping.
prha requested review of D8902: disable flaky test_partial_backfill in windows.
prha added a comment to D8900: RunStatusSensorDefinition and @run_status_sensor.
The run status => event mapping feels a little weird to me, but maybe results in the desired behavior.
prha committed R1:eed3e11bbb6c: asset catalog perf: use wipe_timestamp for asset_key filtering (authored by prha).
asset catalog perf: use wipe_timestamp for asset_key filtering
prha requested review of D8877: asset catalog perf: use wipe_timestamp for asset_key filtering.
Jul 13 2021
Jul 13 2021
prha added inline comments to D8845: have AzureComputeLogManager implement CapturedLogManager interface.
prha committed R1:f6c6372344ce: asset catalog perf: make use of tags column if migrated (authored by prha).
asset catalog perf: make use of tags column if migrated
prha requested review of D8864: asset catalog perf: make use of tags column if migrated.
prha added inline comments to D8810: [dag-star] graphql websocket endpoint.
make sure pipeline_failure_sensor is under test
prha committed R1:eb2366654d3b: ensure pipeline def args get threaded through hook decorator (authored by prha).
ensure pipeline def args get threaded through hook decorator
prha requested review of D8853: ensure pipeline def args get threaded through hook decorator.
Jul 12 2021
Jul 12 2021
prha requested review of D8844: have GcsComputeLogManager implement CapturedLogManager interface.
prha requested review of D8843: have S3ComputeLogManager implement CapturedLogManager interface.
prha requested review of D8840: convert local compute log manager.
prha added a reverting change for R1:fdbcecb76c5d: pin dbt for test: R1:b14acdec328a: Revert "pin dbt for test", try removing default dbt profile dir.
prha added a reverting change for D8831: pin dbt for test: R1:b14acdec328a: Revert "pin dbt for test", try removing default dbt profile dir.