Page MenuHomeElementl

owen (Owen Kephart)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 19 2021, 6:42 PM (16 w, 3 d)

Recent Activity

Thu, May 13

owen accepted D7907: 0.11.9 changelog.
Thu, May 13, 8:57 PM

Wed, May 12

owen closed D7879: pin jinja2 to fix tests.
Wed, May 12, 2:44 AM
owen committed R1:c3772c16c815: pin jinja2 to fix tests (authored by owen).
pin jinja2 to fix tests
Wed, May 12, 2:44 AM
owen updated the diff for D7879: pin jinja2 to fix tests.

up

Wed, May 12, 2:16 AM
owen updated the diff for D7879: pin jinja2 to fix tests.

up

Wed, May 12, 2:14 AM
owen requested review of D7879: pin jinja2 to fix tests.
Wed, May 12, 2:03 AM

Mon, May 10

owen accepted D7847: [dagster-graphql][client] Fixing `reload_repository_location` and `submit_pipeline_execution`.

nice!

Mon, May 10, 10:51 PM

Tue, May 4

owen closed D7697: Add an example of how to configure an fs_io_manager w/ a different base_path.
Tue, May 4, 5:29 PM
owen committed R1:a693f57e337b: Add an example of how to configure an fs_io_manager w/ a different base_path (authored by owen).
Add an example of how to configure an fs_io_manager w/ a different base_path
Tue, May 4, 5:29 PM
owen closed D7693: only suggest config for missing entries.
Tue, May 4, 5:09 PM
owen committed R1:8fe101c6ee5d: only suggest config for missing entries (authored by owen).
only suggest config for missing entries
Tue, May 4, 5:09 PM
owen updated the diff for D7697: Add an example of how to configure an fs_io_manager w/ a different base_path.

up

Tue, May 4, 5:01 PM

Mon, May 3

owen updated the diff for D7697: Add an example of how to configure an fs_io_manager w/ a different base_path.

up

Mon, May 3, 8:41 PM
owen requested review of D7697: Add an example of how to configure an fs_io_manager w/ a different base_path.
Mon, May 3, 5:41 PM
owen requested review of D7693: only suggest config for missing entries.
Mon, May 3, 5:14 PM

Thu, Apr 29

owen closed D7671: Fix bug with enum values and config snapshots.
Thu, Apr 29, 11:43 PM
owen committed R1:00ceb42bcfe0: Fix bug with enum values and config snapshots (authored by owen).
Fix bug with enum values and config snapshots
Thu, Apr 29, 11:43 PM
owen updated the diff for D7671: Fix bug with enum values and config snapshots.

up

Thu, Apr 29, 11:11 PM
owen requested review of D7671: Fix bug with enum values and config snapshots.
Thu, Apr 29, 10:10 PM

Tue, Apr 27

owen accepted D7631: remove unit test on connecting solids tutorial page.

This stuck out to me a bit when I was reviewing the other diff this morning. lgtm

Tue, Apr 27, 10:37 PM
owen accepted D7516: download csv in tutorial.

Looks great! Had two minor comments but otherwise good to land from my perspective

Tue, Apr 27, 5:06 PM

Tue, Apr 20

owen closed D7533: updated error message for the case that the user passes in Optional to the config system.
Tue, Apr 20, 11:21 PM
owen committed R1:ae921eb6dd66: updated error message for the case that the user passes in Optional to the… (authored by owen).
updated error message for the case that the user passes in Optional to the…
Tue, Apr 20, 11:21 PM
owen updated the diff for D7533: updated error message for the case that the user passes in Optional to the config system.

up

Tue, Apr 20, 10:50 PM
owen added a reviewer for D7533: updated error message for the case that the user passes in Optional to the config system: yuhan.
Tue, Apr 20, 9:39 PM
owen updated the diff for D7533: updated error message for the case that the user passes in Optional to the config system.

added another config typing error change

Tue, Apr 20, 9:38 PM
owen requested review of D7533: updated error message for the case that the user passes in Optional to the config system.
Tue, Apr 20, 9:37 PM
owen closed D7530: better error message when attempting to reexecute w/ in-mem io manager.
Tue, Apr 20, 7:19 PM
owen committed R1:f1b1fd7c0dea: better error message when attempting to reexecute w/ in-mem io manager (authored by owen).
better error message when attempting to reexecute w/ in-mem io manager
Tue, Apr 20, 7:19 PM
owen requested review of D7530: better error message when attempting to reexecute w/ in-mem io manager.
Tue, Apr 20, 6:06 PM
owen closed D7501: Correctly classify errors importing user code.
Tue, Apr 20, 5:02 PM
owen committed R1:892c3e66d200: Correctly classify errors importing user code (authored by owen).
Correctly classify errors importing user code
Tue, Apr 20, 5:02 PM
owen added a comment to D7516: download csv in tutorial.

Overall, I think this is a really strong change. Beyond making the retry story make more sense, sourcing from a URL also makes the configurability make more sense ("hey! now I can just point my pipeline at any cereal csv on the internet!"). It also means that this feels like a full pipeline lifecycle. In the original tutorial, I felt like there was something missing at the front of the pipeline (how do you get this csv onto your computer in the first place), but this feels a lot more complete.

Tue, Apr 20, 5:00 PM

Mon, Apr 19

owen updated the diff for D7501: Correctly classify errors importing user code.

up

Mon, Apr 19, 11:20 PM
owen updated the diff for D7501: Correctly classify errors importing user code.

up

Mon, Apr 19, 11:19 PM
owen added a comment to D7501: Correctly classify errors importing user code.

definitely support the overall goal, just need to adjust the approach

this behavior should probably be put under test too

Mon, Apr 19, 10:42 PM
owen updated the diff for D7501: Correctly classify errors importing user code.

up

Mon, Apr 19, 10:19 PM
owen requested review of D7501: Correctly classify errors importing user code.
Mon, Apr 19, 6:06 PM
owen added a comment to D7492: allow partial InputDefinition list.

Overall, I think this is a positive change. I've personally run into this edge before, and it is frustrating to have to put such a long definition in for an input that has no special properties, simply because a different parameter does.

Mon, Apr 19, 4:15 PM

Fri, Apr 16

owen closed D7419: Improved error message when missing config.
Fri, Apr 16, 10:49 PM
owen committed R1:e329f941c271: Improved error message when missing config (authored by owen).
Improved error message when missing config
Fri, Apr 16, 10:49 PM
owen updated the diff for D7419: Improved error message when missing config.
  • restored correct version of file
Fri, Apr 16, 10:23 PM
owen added a comment to D7419: Improved error message when missing config.

i think this is a clear step forward even if its json sample in yaml land dagit

also - looks like we are not including commas between fields for the "expected" section when there is extra config? not sure if thats an easy diff to throw out while you're in this zone

resolve inlines before landing

Fri, Apr 16, 10:16 PM
owen updated the diff for D7419: Improved error message when missing config.

up

Fri, Apr 16, 10:04 PM
owen published D7419: Improved error message when missing config for review.
Fri, Apr 16, 4:56 PM

Apr 13 2021

owen accepted D7406: [dagstermill] support Failure and RetryRequested.
Apr 13 2021, 11:00 PM

Apr 6 2021

owen closed D7329: add slack hooks to api docs.
Apr 6 2021, 10:37 PM
owen committed R1:13990f2b1bae: add slack hooks to api docs (authored by owen).
add slack hooks to api docs
Apr 6 2021, 10:37 PM
owen requested review of D7329: add slack hooks to api docs.
Apr 6 2021, 10:17 PM

Mar 31 2021

owen accepted D7241: [config] fix Permissive dict scrambling.
Mar 31 2021, 4:45 PM

Mar 30 2021

owen accepted D7211: [graphql] manual coerce >32bit int metadata.
Mar 30 2021, 6:24 PM
owen added inline comments to D7211: [graphql] manual coerce >32bit int metadata.
Mar 30 2021, 4:15 PM
owen added a comment to D7211: [graphql] manual coerce >32bit int metadata.

out of curiosity, where are these >32 bit entries coming from and why does it cause an error in dagit? ideally it would be nice not to silently null out people's metadata. obviously the code here looks correct, just trying to get more context.

Mar 30 2021, 4:08 PM

Mar 22 2021

owen accepted D7088: Derive StepOutput get_asset_key functions from the outputdefinition rather than storing them as fields on StepOutput.
Mar 22 2021, 3:45 PM
owen added a comment to D7088: Derive StepOutput get_asset_key functions from the outputdefinition rather than storing them as fields on StepOutput.

love it!

Mar 22 2021, 3:45 PM

Mar 18 2021

owen closed D6991: Updated asset docs.
Mar 18 2021, 2:54 AM
owen committed R1:0bfbf67c4673: Updated asset docs (authored by owen).
Updated asset docs
Mar 18 2021, 2:54 AM
owen updated the diff for D6991: Updated asset docs.
  • updated snapshots
Mar 18 2021, 2:19 AM
owen updated the diff for D6991: Updated asset docs.

rebased

Mar 18 2021, 1:59 AM
owen retitled D6991: Updated asset docs from initial commit of new asset docs to Updated asset docs.
Mar 18 2021, 1:52 AM
owen updated the diff for D6991: Updated asset docs.
  • fixed dead links
Mar 18 2021, 1:19 AM
owen updated the diff for D6991: Updated asset docs.
  • minor edits
Mar 18 2021, 12:53 AM
owen closed D6910: dagit asset lineage interface.
Mar 18 2021, 12:24 AM
owen committed R1:fc39a9406d18: dagit asset lineage interface (authored by owen).
dagit asset lineage interface
Mar 18 2021, 12:24 AM
owen updated the diff for D6910: dagit asset lineage interface.
  • updated graphql test
  • fixed prettier
  • updated snapshots
  • rebased
Mar 18 2021, 12:08 AM

Mar 17 2021

owen updated the diff for D6991: Updated asset docs.
  • added screenshot/text for asset lineage
  • removed separate asset catalog page
Mar 17 2021, 11:39 PM
owen updated the diff for D6991: Updated asset docs.
  • restructured asset docs and added content
Mar 17 2021, 10:30 PM
owen requested review of D6991: Updated asset docs.
Mar 17 2021, 12:51 AM

Mar 16 2021

owen added a comment to D6910: dagit asset lineage interface.

The list view now shows the asset lineage info for every materialization event. For one of the pipeline runs, I didn't include partitions, so you can see what that looks like as well.

Mar 16 2021, 5:57 PM
owen updated the diff for D6910: dagit asset lineage interface.
  • updated snapshots
Mar 16 2021, 5:52 PM
owen updated the diff for D6910: dagit asset lineage interface.
  • updated snapshots
  • added lineage info to list view
  • changed heading on partitioned asset pages
Mar 16 2021, 5:49 PM

Mar 15 2021

owen updated the diff for D6910: dagit asset lineage interface.
  • updated graphql test
  • fixed prettier
  • updated snapshots
Mar 15 2021, 11:03 PM
owen added a comment to D6910: dagit asset lineage interface.

This mostly looks great. A couple thoughts:

  • For partitioned assets, users care about the parents of the entire asset, not just the latest partition. Are we able to aggregate that up? It could be in a separate diff if that makes more sense.
  • When users click into historical materializations, can we show this information as well?
Mar 15 2021, 10:57 PM
owen added a comment to D6910: dagit asset lineage interface.

I added an asset with two parents to the lineage pipeline so that you can see what that looks like.

Mar 15 2021, 10:45 PM
owen added inline comments to D6910: dagit asset lineage interface.
Mar 15 2021, 10:44 PM
owen updated the diff for D6910: dagit asset lineage interface.
  • cleaned up js and graphene logic
Mar 15 2021, 10:43 PM
owen closed D6939: Updated Solid Events page in the docs.
Mar 15 2021, 8:34 PM
owen committed R1:452a851611f2: Updated Solid Events page in the docs (authored by owen).
Updated Solid Events page in the docs
Mar 15 2021, 8:34 PM
owen updated the diff for D6939: Updated Solid Events page in the docs.
  • yarn snapshot
Mar 15 2021, 7:03 PM
owen updated the diff for D6939: Updated Solid Events page in the docs.
  • yarn snapshot
Mar 15 2021, 6:36 PM
owen updated the diff for D6939: Updated Solid Events page in the docs.

testing

Mar 15 2021, 6:05 PM
owen added a comment to D6910: dagit asset lineage interface.

If you apply this diff and and do make dev_webapp in dagster/js_modules/dagit, and then dagit -p 3333 -w workspace.yaml, you can run the asset_lineage pipeline, which shows off the relevant behavior.

Mar 15 2021, 5:46 PM

Mar 12 2021

owen requested review of D6910: dagit asset lineage interface.
Mar 12 2021, 5:53 PM

Mar 10 2021

owen closed D6873: fixed error loading asset lineage example.
Mar 10 2021, 8:10 PM
owen committed R1:8d34e01886ba: fixed error loading asset lineage example (authored by owen).
fixed error loading asset lineage example
Mar 10 2021, 8:10 PM
owen requested review of D6873: fixed error loading asset lineage example.
Mar 10 2021, 5:48 PM
owen closed D6522: Python API for specifying Asset/Output dependencies.
Mar 10 2021, 12:21 AM
owen committed R1:4a4e49d19f52: Python API for specifying Asset/Output dependencies (authored by owen).
Python API for specifying Asset/Output dependencies
Mar 10 2021, 12:21 AM

Mar 9 2021

owen requested review of D6522: Python API for specifying Asset/Output dependencies.
Mar 9 2021, 10:00 PM

Feb 4 2021

owen committed R1:adc194b4d961: merging in docs change (authored by owen).
merging in docs change
Feb 4 2021, 10:43 PM
owen committed R1:9b3c266f27d5: [Docs] 0.10.3 (authored by owen).
[Docs] 0.10.3
Feb 4 2021, 10:43 PM
owen committed R1:349190babc95: 0.10.3 (authored by owen).
0.10.3
Feb 4 2021, 10:04 PM
owen committed R1:9c7fe59a6520: 0.10.3.pre0 (authored by owen).
0.10.3.pre0
Feb 4 2021, 9:47 PM
owen closed D6310: Updated CHANGES for 0.10.3.
Feb 4 2021, 9:38 PM
owen committed R1:1bd0e84630e6: Updated CHANGES for 0.10.3 (authored by owen).
Updated CHANGES for 0.10.3
Feb 4 2021, 9:38 PM
owen requested review of D6310: Updated CHANGES for 0.10.3.
Feb 4 2021, 9:27 PM

Jan 26 2021

owen updated the diff for D6140: Initial commit of adding hooks to some of the integration libraries.

fixed more docstrings

Jan 26 2021, 11:46 PM
owen added a comment to D6140: Initial commit of adding hooks to some of the integration libraries.

I wanted to do my due diligence and see how these integrations would actually look in the real world, so if you're curious:

Jan 26 2021, 11:25 PM
owen updated the diff for D6140: Initial commit of adding hooks to some of the integration libraries.
  • refactored hooks and integrated them with the APIs a bit better
  • updated docs and added docstrings
Jan 26 2021, 11:22 PM
owen added inline comments to D6140: Initial commit of adding hooks to some of the integration libraries.
Jan 26 2021, 4:48 PM