- User Since
- Apr 23 2019, 10:22 PM (107 w, 2 d)
- Administrator, Disabled
Mar 16 2021
Mar 4 2021
Feb 24 2021
Feb 16 2021
Feb 15 2021
I think this is fine for now - doesn't need to be in this diff, but should we deprecate these enabled flags and change the helm schema to be like
Feb 11 2021
cool, looks good to me. see one comment on testing; also, are there any other places we should expose the ability to add labels while you're at it?
Feb 8 2021
Feb 4 2021
should flower and the celery workers have different envs? or should this be shared?
Feb 3 2021
Feb 2 2021
see one comment, otherwise LGTM!
Feb 1 2021
Jan 29 2021
hmm but I think we're stuck on an older airflow before this fix went out; see: https://github.com/dagster-io/dagster/blob/master/python_modules/libraries/dagster-airflow/setup.py#L47
hmm did you try this on a clean venv? last I tried it didn't work properly
Jan 20 2021
Jan 19 2021
thanks for fixing - is there a scaffolding template for these that needs to get updated too?
Jan 17 2021
Jan 16 2021
Jan 15 2021
Jan 14 2021
should we just remove this file entirely? since quip is only accessible to employees?
Jan 13 2021
hmm shouldn't this:
if the body of one solid creates a particular table in a database and the body of another solid consumes that table
be modeled w/ IOManagers instead of Nothings?
This looks really good to me now! Thanks for getting this done!!
Jan 12 2021
Jan 11 2021
yeah buildkite has an assert on their side that fails loudly if both are set, so I figured it'd be best to just fall through to their error message rather than insert our own
ambitious, I like it