User Details
- User Since
- Apr 23 2019, 10:22 PM (73 w, 5 d)
- Roles
- Administrator
Sat, Sep 19
I don't know how best to test this, but see https://boto3.amazonaws.com/v1/documentation/api/latest/guide/retries.html
Thu, Sep 17
Wed, Sep 16
up
up
Tue, Sep 15
Mon, Sep 14
Fri, Sep 11
Thu, Sep 10
Thu, Aug 27
Tue, Aug 25
Aug 21 2020
after a long stint of meticulously switching double quotes to single wherever I found them, given the abstentions, I'm happy to be the one to go ahead and greenlight this. Getting tooling support is super attractive
Aug 20 2020
sounds good. will also need to remove from buildkite pipeline.py if we still test 27 there
Aug 19 2020
cool, this lgtm - will let others chime in before the final sign-off
Aug 17 2020
Aug 12 2020
yes, we should make this a literalinclude instead of a code-block - mind taking that on this diff? it'll ensure we don't end up in this state again
Aug 11 2020
cool this looks good to me. assume you're on top of this, but you'll have to also update the published integration image to "rebase" on this updated image - I think this is documented in the readme? lmk if you need a hand
Aug 10 2020
see one comment, otherwise LGTM! thanks for setting this up
Aug 7 2020
Aug 6 2020
see one comment otherwise lgtm, thanks for figuring this out!
LGTM - @johann do you want to take a look before Cat lands this?
dagster-image build-all --name k8s-dagit dagster-image build-all --name k8s-example dagster-image build-all --name k8s-celery-worker dagster-image push-dockerhub --name k8s-dagit dagster-image push-dockerhub --name k8s-example dagster-image push-dockerhub --name k8s-celery-worker
Looks great, thanks for doing this. after you build and push the dagit image to docker hub, can you also update the helm chart to use the dagit image?
Aug 5 2020
buildkite is so flaky
This is great. Left a few comments on some small nits throughout, otherwise this looks good to land.
Aug 4 2020
I think we can just do D4091 instead
LGTM, rebase should deal w/ the GCP build failurees
LGTM pending time.sleep change
Aug 3 2020
Jul 30 2020
Jul 29 2020
Jul 28 2020
it'd be nice to test this somehow.....maybe file a bug that we should get test coverage on these?
Jul 27 2020
add tests and refactor DagsterDockerOperator
looks reasonable - is there a way to confirm that this will do the right thing despite the lack of --no-cache? would be good to ensure that a code change does properly get propagated to the built image vs. just re-using the last cached version