Page MenuHomePhabricator
People nate

nate (Nate Kupp)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Apr 23 2019, 10:22 PM (62 w, 2 d)
Roles
Administrator

Recent Activity
View All

Today

nate accepted D3754: Fix install order in root Makefile.
Fri, Jul 3, 2:27 PM

Yesterday

nate accepted D3741: Fix scheduling section of tutorial.

see one comment, otherwise lgtm

Thu, Jul 2, 7:58 PM
nate accepted D3742: slight fixes to docs.
Thu, Jul 2, 5:39 PM
nate committed R1:c6d562cdbb99: Add literalinclude to configmapping (authored by nate).
Add literalinclude to configmapping
Thu, Jul 2, 4:51 PM
nate closed D3738: Add literalinclude to configmapping.
Thu, Jul 2, 4:51 PM
nate accepted D3740: create_example fix.
Thu, Jul 2, 4:51 PM
nate accepted D3739: [docs] fix examples sidebar.
Thu, Jul 2, 4:50 PM
nate accepted D3734: [docs] example page aesthetic improvements.

Great thanks for doing this!

Thu, Jul 2, 4:50 PM
nate requested review of D3738: Add literalinclude to configmapping.
Thu, Jul 2, 4:23 PM
nate committed R1:34b25703079e: Add an example for deploying Dagster on Kubernetes (authored by nate).
Add an example for deploying Dagster on Kubernetes
Thu, Jul 2, 4:16 PM
nate closed D3700: Add an example for deploying Dagster on Kubernetes.
Thu, Jul 2, 4:16 PM
nate updated the diff for D3700: Add an example for deploying Dagster on Kubernetes.

rebase

Thu, Jul 2, 3:43 PM
nate added inline comments to D3736: (kubernetes-testability-3) Mock out wait_job_for_success. Found bug with first test.
Thu, Jul 2, 3:28 PM
nate added a comment to D3733: parallelize dagster_tests/.

hmm, can you just move all of the other dagster tests under dagster_tests/general_tests? then you shouldn't need the ignores, right?

Thu, Jul 2, 3:26 PM

Wed, Jul 1

nate accepted D3729: drop intro_tutorial from tests #2623.

very nice!!!

Wed, Jul 1, 11:34 PM
nate accepted D3669: [celery docker] add a test.

cool, seems pretty reasonable to me

Wed, Jul 1, 11:17 PM
nate updated the diff for D3700: Add an example for deploying Dagster on Kubernetes.

up

Wed, Jul 1, 10:59 PM
nate updated the diff for D3700: Add an example for deploying Dagster on Kubernetes.

up

Wed, Jul 1, 10:56 PM
nate added a comment to D3700: Add an example for deploying Dagster on Kubernetes.

Cool, updated

Wed, Jul 1, 10:56 PM
nate added inline comments to D3700: Add an example for deploying Dagster on Kubernetes.
Wed, Jul 1, 10:38 PM
nate accepted D3723: Actually use docker images during test image build. Use pex for aws cli tool..
Wed, Jul 1, 10:18 PM
nate updated the summary of D3700: Add an example for deploying Dagster on Kubernetes.
Wed, Jul 1, 7:49 PM
nate updated the diff for D3700: Add an example for deploying Dagster on Kubernetes.

up

Wed, Jul 1, 7:47 PM
nate accepted D3672: [docs] Nothing example.
Wed, Jul 1, 6:56 PM
nate accepted D3717: (build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds.
Wed, Jul 1, 3:54 PM
nate added inline comments to D3717: (build-image-improvement-2) Add slimmer bootstrap test builder image for faster cold builds.
Wed, Jul 1, 2:45 PM
nate accepted D3716: (build-image-improvement-1) Move docker to integration.
Wed, Jul 1, 2:19 PM
nate requested review of D3700: Add an example for deploying Dagster on Kubernetes.
Wed, Jul 1, 4:04 AM

Tue, Jun 30

nate added a comment to D3698: [docs] Move examples doc under docs folder.

with this change, should we also ensure that each example has a README.md that points to the docs site? we can add a test to buildkitet which will fail when that README isn't present, similar to .buildkite/scripts/check_library_docs.py

Tue, Jun 30, 8:16 PM
nate updated subscribers of D3680: (celery-k8s-refactor-3.1) Move CeleryK8sRunLauncher to dagster_celery_k8s.

re: moving test fixtures to a common place, I agree - @sashank and I started some of this with the creation of the top-level dagster-test module, we can move test machinery there. I just chatted with @aj.nadel who is thinking about similar things for testing dagster-graphql + dagster-postgres and needs to use some fixtures from dagster-postgres

Tue, Jun 30, 8:12 PM
nate committed R1:052594ce97f7: Add check to ensure DAGSTER_HOME is a valid directory (authored by nate).
Add check to ensure DAGSTER_HOME is a valid directory
Tue, Jun 30, 12:25 AM
nate closed D3697: Add check to ensure DAGSTER_HOME is a valid directory.
Tue, Jun 30, 12:25 AM

Mon, Jun 29

nate accepted D3696: [doc] Update Types overview.

LGTM, two minor comments

Mon, Jun 29, 8:46 PM
nate requested review of D3697: Add check to ensure DAGSTER_HOME is a valid directory.
Mon, Jun 29, 8:29 PM

Sun, Jun 28

nate accepted D3682: 085 docs.
Sun, Jun 28, 1:53 AM

Fri, Jun 26

nate added inline comments to D3658: [docs] streamline Deploy.
Fri, Jun 26, 11:02 PM
nate accepted D3658: [docs] streamline Deploy.

I copied these two YAML files into docs_snippets and put them under test, so we can remove these now

Fri, Jun 26, 11:01 PM
nate accepted D3666: [docs] remove principles.
Fri, Jun 26, 10:38 PM
nate accepted D3637: examples/legacy_examples/airline_demo -> examples/airline_demo.
Fri, Jun 26, 10:25 PM

Thu, Jun 25

nate accepted D3651: [docs] Scheduling section.
Thu, Jun 25, 10:02 PM
nate committed R1:354fd895fdb5: [docs] Add instances overview page (authored by nate).
[docs] Add instances overview page
Thu, Jun 25, 4:27 PM
nate closed D3617: [docs] Add instances overview page.
Thu, Jun 25, 4:27 PM
nate updated the diff for D3617: [docs] Add instances overview page.

up

Thu, Jun 25, 4:10 PM
nate updated the diff for D3617: [docs] Add instances overview page.

fix bug in Dagit

Thu, Jun 25, 4:03 PM
nate updated the diff for D3617: [docs] Add instances overview page.

up

Thu, Jun 25, 12:11 AM

Tue, Jun 23

nate accepted D3612: [docs] github link with version.
Tue, Jun 23, 11:05 PM
nate requested review of D3617: [docs] Add instances overview page.
Tue, Jun 23, 11:03 PM
nate committed R1:a61879bc8214: More py35 cleanup (authored by nate).
More py35 cleanup
Tue, Jun 23, 5:00 PM
nate closed D3602: More py35 cleanup.
Tue, Jun 23, 5:00 PM
nate accepted D3604: Fix lint errors.
Tue, Jun 23, 3:29 PM
nate requested review of D3602: More py35 cleanup.
Tue, Jun 23, 3:16 PM

Sat, Jun 20

nate accepted D3550: Image option for postgresql in helm.
Sat, Jun 20, 4:06 PM
nate accepted D3579: [docs seo] ref canonical.
Sat, Jun 20, 4:02 PM
nate accepted D3584: [docs example] fix new pages literalinclude.
Sat, Jun 20, 1:11 AM

Fri, Jun 19

nate accepted D3572: [docs examples] move old examples to examples/legacy_examples.
Fri, Jun 19, 11:18 PM
nate accepted D3573: fix longitudinal partition selector.
Fri, Jun 19, 11:15 PM
nate added inline comments to D3550: Image option for postgresql in helm.
Fri, Jun 19, 7:54 PM
nate accepted D3561: [docs examples] move intro_tutorial to docs_snippets/docs_snippets/.

thank you for doing this!!! can you file an issue or otherwise track that TODO so that we don't forget?

Fri, Jun 19, 6:07 PM

Thu, Jun 18

nate accepted D3554: [examples] Update airflow_ingest examples.
Thu, Jun 18, 10:14 PM
nate changed the Can Create Badges policy for application Badges from Administrators to Restricted Project (Project).
Thu, Jun 18, 9:44 PM
nate accepted D3553: add pipeline descriptions for toy pipelines.
Thu, Jun 18, 8:49 PM
nate committed R1:dd59ca809d97: First new example with tests (authored by nate).
First new example with tests
Thu, Jun 18, 8:12 PM
nate closed D3512: First new example with tests.
Thu, Jun 18, 8:12 PM
nate updated the diff for D3512: First new example with tests.

rerun buildkite - flaky test

Thu, Jun 18, 7:27 PM
nate updated the diff for D3512: First new example with tests.

up

Thu, Jun 18, 7:11 PM
nate updated the diff for D3512: First new example with tests.

up

Thu, Jun 18, 6:59 PM
nate updated the diff for D3512: First new example with tests.

up

Thu, Jun 18, 6:40 PM
nate updated the summary of D3512: First new example with tests.
Thu, Jun 18, 6:28 PM
nate updated the diff for D3512: First new example with tests.

up

Thu, Jun 18, 6:27 PM
nate updated the diff for D3512: First new example with tests.

up

Thu, Jun 18, 6:26 PM
nate updated the diff for D3512: First new example with tests.

up

Thu, Jun 18, 6:26 PM
nate committed R1:04f5f6e103c3: Create docs_snippets folder in examples (authored by nate).
Create docs_snippets folder in examples
Thu, Jun 18, 6:09 PM
nate closed D3545: Create docs_snippets folder in examples.
Thu, Jun 18, 6:09 PM
nate accepted D3501: isOptional -> isRequired graphql/dagit.
Thu, Jun 18, 6:06 PM
nate updated the diff for D3545: Create docs_snippets folder in examples.

up

Thu, Jun 18, 5:54 PM
nate updated the diff for D3545: Create docs_snippets folder in examples.

disable coverage

Thu, Jun 18, 5:47 PM
nate accepted D3548: docs 0.8.3.
Thu, Jun 18, 3:51 AM
nate accepted D3547: [docs] tutorial code link style.
Thu, Jun 18, 1:22 AM
nate updated the diff for D3545: Create docs_snippets folder in examples.

up

Thu, Jun 18, 12:01 AM

Wed, Jun 17

nate updated the diff for D3545: Create docs_snippets folder in examples.

up

Wed, Jun 17, 11:52 PM
nate updated the diff for D3545: Create docs_snippets folder in examples.

up

Wed, Jun 17, 11:47 PM
nate updated the diff for D3545: Create docs_snippets folder in examples.

up

Wed, Jun 17, 11:29 PM
nate accepted D3532: Add liveliness check to celery worker.
Wed, Jun 17, 10:57 PM
nate requested review of D3545: Create docs_snippets folder in examples.
Wed, Jun 17, 10:47 PM
nate added inline comments to D3532: Add liveliness check to celery worker.
Wed, Jun 17, 10:41 PM
nate accepted D3535: add liveness and startup probe to flower.
Wed, Jun 17, 10:39 PM
nate committed R1:92494b22efc5: 0.8.3 (authored by nate).
0.8.3
Wed, Jun 17, 5:45 PM
nate committed R1:5686f5d598b9: 0.8.3.pre0 (authored by nate).
0.8.3.pre0
Wed, Jun 17, 5:35 PM
nate committed R1:f2b7e61334b9: Disable events demo tests (authored by nate).
Disable events demo tests
Wed, Jun 17, 5:32 PM
nate closed D3542: Disable events demo tests.
Wed, Jun 17, 5:32 PM
nate requested review of D3542: Disable events demo tests.
Wed, Jun 17, 5:27 PM
nate accepted D3523: [docs][overview] Add solids and pipelines section to overview.
Wed, Jun 17, 4:06 PM
nate accepted D3522: Add docs examples module and add to buildkite.
Wed, Jun 17, 4:06 PM
nate accepted D3537: 083 changelog.

thanks! see couple comments

Wed, Jun 17, 4:05 PM
nate added a comment to D3537: 083 changelog.

maybe also "Several Dagit bugfixes"?

Wed, Jun 17, 4:05 PM
nate committed R1:59709490609d: scheduler K8sRunLauncher workaround (authored by alangenfeld).
scheduler K8sRunLauncher workaround
Wed, Jun 17, 2:44 PM
nate closed D3517: scheduler K8sRunLauncher workaround.
Wed, Jun 17, 2:43 PM
nate accepted D3533: Print stderr/stdout for helm install and kind create cluster.
Wed, Jun 17, 2:43 PM
nate accepted D3531: add startup probe and liveness probe to dagit.
Wed, Jun 17, 2:56 AM
nate accepted D3531: add startup probe and liveness probe to dagit.
Wed, Jun 17, 2:08 AM