- User Since
- Apr 23 2019, 10:22 PM (62 w, 2 d)
see one comment, otherwise lgtm
Great thanks for doing this!
hmm, can you just move all of the other dagster tests under dagster_tests/general_tests? then you shouldn't need the ignores, right?
Wed, Jul 1
cool, seems pretty reasonable to me
Tue, Jun 30
with this change, should we also ensure that each example has a README.md that points to the docs site? we can add a test to buildkitet which will fail when that README isn't present, similar to .buildkite/scripts/check_library_docs.py
re: moving test fixtures to a common place, I agree - @sashank and I started some of this with the creation of the top-level dagster-test module, we can move test machinery there. I just chatted with @aj.nadel who is thinking about similar things for testing dagster-graphql + dagster-postgres and needs to use some fixtures from dagster-postgres
Mon, Jun 29
Sun, Jun 28
Fri, Jun 26
I copied these two YAML files into docs_snippets and put them under test, so we can remove these now
Thu, Jun 25
fix bug in Dagit
Tue, Jun 23
Sat, Jun 20
Fri, Jun 19
thank you for doing this!!! can you file an issue or otherwise track that TODO so that we don't forget?
Thu, Jun 18
rerun buildkite - flaky test
Wed, Jun 17
maybe also "Several Dagit bugfixes"?