Page MenuHomePhabricator

nate (Nate Kupp)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Apr 23 2019, 10:22 PM (96 w, 6 d)
Roles
Administrator

Recent Activity

Wed, Feb 24

nate accepted D6658: Add Slack badge to README.
Wed, Feb 24, 11:33 PM
nate accepted D6652: Fix mislabeled image python versions.
Wed, Feb 24, 3:42 AM

Tue, Feb 16

nate accepted D6511: [import-cleanup] lazy import migration.utils.
Tue, Feb 16, 9:03 PM

Mon, Feb 15

nate accepted D6476: Add parameter in Helm chart to set whether redis is created within k8s.

I think this is fine for now - doesn't need to be in this diff, but should we deprecate these enabled flags and change the helm schema to be like

Mon, Feb 15, 10:53 PM
nate accepted D6498: Pin astroid.
Mon, Feb 15, 10:28 PM
nate published D6498: Pin astroid for review.
Mon, Feb 15, 10:28 PM

Thu, Feb 11

nate accepted D6279: GH issue 3609 (Expose labels field in celery config).

cool, looks good to me. see one comment on testing; also, are there any other places we should expose the ability to add labels while you're at it?

Thu, Feb 11, 6:05 AM

Mon, Feb 8

nate accepted D6348: Remove examples/deploy_k8s link.
Mon, Feb 8, 5:38 PM

Thu, Feb 4

nate accepted D6280: GH issue 3051 (Flower configuration - expose env vars).

should flower and the celery workers have different envs? or should this be shared?

Thu, Feb 4, 11:32 PM

Wed, Feb 3

nate accepted D6290: document type of slack_resource object.
Wed, Feb 3, 10:38 PM
nate accepted D6278: [GH 3611] `YOUR_ENV_VAR` is leaking from helm defaults into user clusters.
Wed, Feb 3, 2:18 PM

Tue, Feb 2

nate accepted D6222: clarify the type of the object that's returned by s3_resource.
Tue, Feb 2, 7:42 PM
nate added a comment to D6246: decouple api docs dependencies from `make dev_install`.

see one comment, otherwise LGTM!

Tue, Feb 2, 2:30 AM
nate accepted D6246: decouple api docs dependencies from `make dev_install`.
Tue, Feb 2, 2:30 AM
nate accepted D6207: add dagster-azure back to dev_install.
Tue, Feb 2, 12:06 AM

Mon, Feb 1

nate accepted D6245: Pin pytz for compat with Snowflake connector.
Mon, Feb 1, 11:59 PM
nate published D6245: Pin pytz for compat with Snowflake connector for review.
Mon, Feb 1, 11:59 PM

Jan 29 2021

nate abandoned D5767: (buildkite 10/n) Add Windows tests.
Jan 29 2021, 5:19 AM
nate requested changes to D6206: add dagster-airflow back to dev_install.
Jan 29 2021, 5:19 AM
nate accepted D6206: add dagster-airflow back to dev_install.

hmm but I think we're stuck on an older airflow before this fix went out; see: https://github.com/dagster-io/dagster/blob/master/python_modules/libraries/dagster-airflow/setup.py#L47

Jan 29 2021, 5:18 AM
nate added a comment to D6207: add dagster-azure back to dev_install.

hmm did you try this on a clean venv? last I tried it didn't work properly

Jan 29 2021, 5:04 AM

Jan 20 2021

nate accepted D6051: fix docs rendering.
Jan 20 2021, 12:30 AM
nate published D6051: fix docs rendering for review.
Jan 20 2021, 12:30 AM

Jan 19 2021

nate accepted D6050: Add retries to buildkite ecr plugin.
Jan 19 2021, 10:59 PM
nate closed D6035: Remove dev-requirements.txt files.
Jan 19 2021, 8:45 PM
nate committed R1:974b3a480a14: Remove dev-requirements.txt files (authored by nate).
Remove dev-requirements.txt files
Jan 19 2021, 8:44 PM
nate updated the diff for D6035: Remove dev-requirements.txt files.

up

Jan 19 2021, 8:17 PM
nate updated the diff for D6035: Remove dev-requirements.txt files.

up

Jan 19 2021, 8:06 PM
nate added inline comments to D6035: Remove dev-requirements.txt files.
Jan 19 2021, 8:05 PM
nate accepted D6042: Remove py27 from tox envlist.
Jan 19 2021, 8:00 PM
nate accepted D6044: Fix tox envlists py35..37 -> py36..38.

thanks for fixing - is there a scaffolding template for these that needs to get updated too?

Jan 19 2021, 7:59 PM

Jan 17 2021

nate accepted D6037: update k8s docs.
Jan 17 2021, 7:30 AM

Jan 16 2021

nate added reviewers for D6035: Remove dev-requirements.txt files: rexledesma, alangenfeld, dgibson.
Jan 16 2021, 12:29 AM
nate requested review of D6035: Remove dev-requirements.txt files.
Jan 16 2021, 12:12 AM

Jan 15 2021

nate accepted D6034: [dagit] Whoops, delete some test code.
Jan 15 2021, 7:26 PM
nate accepted D6028: Add retries to check in dagster=postgres init that checks table names.
Jan 15 2021, 4:56 PM
nate abandoned D6024: dagstermoji.
Jan 15 2021, 3:44 AM
nate updated the summary of D6024: dagstermoji.
Jan 15 2021, 3:43 AM
nate requested review of D6024: dagstermoji.
Jan 15 2021, 3:39 AM

Jan 14 2021

nate accepted D6014: Add examples when migrating Helm values to 0.10.0.
Jan 14 2021, 9:37 PM
nate closed D6000: Buildkite - remove pipeline.py.
Jan 14 2021, 8:43 PM
nate committed R1:8cca847f96d0: Buildkite - remove pipeline.py (authored by nate).
Buildkite - remove pipeline.py
Jan 14 2021, 8:43 PM
nate accepted D6006: update link in RELEASING.md.
Jan 14 2021, 8:40 PM
nate added a comment to D6006: update link in RELEASING.md.

should we just remove this file entirely? since quip is only accessible to employees?

Jan 14 2021, 8:39 PM
nate requested review of D6000: Buildkite - remove pipeline.py.
Jan 14 2021, 7:34 PM
nate closed D5964: Buildkite emoji.
Jan 14 2021, 12:26 AM
nate committed R1:87dffba1f374: Buildkite emoji (authored by nate).
Buildkite emoji
Jan 14 2021, 12:26 AM
nate retitled D5964: Buildkite emoji from Buildkite build cleanup to Buildkite emoji.
Jan 14 2021, 12:25 AM
nate updated the diff for D5964: Buildkite emoji.

up

Jan 14 2021, 12:15 AM

Jan 13 2021

nate updated the diff for D5964: Buildkite emoji.

up

Jan 13 2021, 11:53 PM
nate updated the diff for D5964: Buildkite emoji.

up

Jan 13 2021, 11:49 PM
nate accepted D5977: update nothing docs now that we have IO managers.

hmm shouldn't this:

if the body of one solid creates a particular table in a database and the body of another solid consumes that table

be modeled w/ IOManagers instead of Nothings?

Jan 13 2021, 11:23 PM
nate accepted D5974: Update images in helm chart.
Jan 13 2021, 11:03 PM
nate updated the diff for D5964: Buildkite emoji.

up

Jan 13 2021, 8:28 PM
nate requested review of D5964: Buildkite emoji.
Jan 13 2021, 8:24 PM
nate closed D5958: Fix build failure from six cleanup.
Jan 13 2021, 6:58 PM
nate committed R1:990e59065144: Fix build failure from six cleanup (authored by nate).
Fix build failure from six cleanup
Jan 13 2021, 6:58 PM
nate updated the diff for D5958: Fix build failure from six cleanup.

up

Jan 13 2021, 6:43 PM
nate published D5958: Fix build failure from six cleanup for review.
Jan 13 2021, 6:37 PM
nate closed D5944: Remove usage of six.
Jan 13 2021, 5:32 PM
nate committed R1:4bcaa2828860: Remove usage of six (authored by nate).
Remove usage of six
Jan 13 2021, 5:32 PM
nate updated the summary of D5944: Remove usage of six.
Jan 13 2021, 4:52 AM
nate updated the diff for D5944: Remove usage of six.

up

Jan 13 2021, 4:50 AM
nate updated the diff for D5944: Remove usage of six.

up

Jan 13 2021, 2:08 AM
nate requested review of D5944: Remove usage of six.
Jan 13 2021, 1:58 AM
nate accepted D5537: k8s deployment docs.

This looks really good to me now! Thanks for getting this done!!

Jan 13 2021, 12:20 AM

Jan 12 2021

nate closed D5929: py2 cleanup: remove misc uses of future.
Jan 12 2021, 9:23 PM
nate committed R1:9f8cd25da00e: py2 cleanup: remove misc uses of future (authored by nate).
py2 cleanup: remove misc uses of future
Jan 12 2021, 9:23 PM
nate updated the diff for D5805: Migrate db.String to db.Text to support MySQL.

up

Jan 12 2021, 8:55 PM
nate updated the diff for D5805: Migrate db.String to db.Text to support MySQL.

up

Jan 12 2021, 8:14 PM
nate updated the test plan for D5805: Migrate db.String to db.Text to support MySQL.
Jan 12 2021, 8:14 PM
nate updated the diff for D5805: Migrate db.String to db.Text to support MySQL.

up

Jan 12 2021, 7:53 PM
nate accepted D5932: Revert "Remove retries from integration test suite".
Jan 12 2021, 7:34 PM
nate closed D5928: Remove py2 test skip markers that are now unused.
Jan 12 2021, 7:26 PM
nate committed R1:bfcd0482cf7d: Remove py2 test skip markers that are now unused (authored by nate).
Remove py2 test skip markers that are now unused
Jan 12 2021, 7:26 PM
nate updated the summary of D5929: py2 cleanup: remove misc uses of future.
Jan 12 2021, 7:25 PM
nate added reviewers for D5929: py2 cleanup: remove misc uses of future: alangenfeld, max.
Jan 12 2021, 7:25 PM
nate closed D5927: Remove misc py2 compat stuff.
Jan 12 2021, 7:24 PM
nate committed R1:cd894fbbf5f7: Remove misc py2 compat stuff (authored by nate).
Remove misc py2 compat stuff
Jan 12 2021, 7:24 PM
nate requested review of D5929: py2 cleanup: remove misc uses of future.
Jan 12 2021, 6:49 PM
nate added reviewers for D5928: Remove py2 test skip markers that are now unused: max, alangenfeld.
Jan 12 2021, 6:28 PM
nate added reviewers for D5927: Remove misc py2 compat stuff: max, alangenfeld.
Jan 12 2021, 6:28 PM
nate requested review of D5928: Remove py2 test skip markers that are now unused.
Jan 12 2021, 6:00 PM
nate requested review of D5927: Remove misc py2 compat stuff.
Jan 12 2021, 5:52 PM
nate added inline comments to D5537: k8s deployment docs.
Jan 12 2021, 3:35 AM

Jan 11 2021

nate closed D5906: Trigger internal repo only for commits from team.
Jan 11 2021, 5:22 PM
nate committed R1:fec87e53513f: Trigger internal repo only for commits from team (authored by nate).
Trigger internal repo only for commits from team
Jan 11 2021, 5:22 PM
nate added a comment to D5906: Trigger internal repo only for commits from team.

yeah buildkite has an assert on their side that fails loudly if both are set, so I figured it'd be best to just fall through to their error message rather than insert our own

Jan 11 2021, 5:21 PM
nate published D5906: Trigger internal repo only for commits from team for review.
Jan 11 2021, 5:08 PM
nate accepted D5904: Remove retries from integration test suite.

ambitious, I like it

Jan 11 2021, 4:49 PM

Jan 10 2021

nate updated the diff for D5767: (buildkite 10/n) Add Windows tests.

up

Jan 10 2021, 5:56 AM
nate added a reviewer for D5767: (buildkite 10/n) Add Windows tests: rexledesma.
Jan 10 2021, 5:55 AM
nate updated the summary of D5767: (buildkite 10/n) Add Windows tests.
Jan 10 2021, 5:54 AM
nate updated the diff for D5767: (buildkite 10/n) Add Windows tests.

up

Jan 10 2021, 5:09 AM
nate updated the diff for D5767: (buildkite 10/n) Add Windows tests.

up

Jan 10 2021, 4:32 AM
nate updated the diff for D5767: (buildkite 10/n) Add Windows tests.

up

Jan 10 2021, 4:20 AM
nate updated the diff for D5767: (buildkite 10/n) Add Windows tests.

up

Jan 10 2021, 3:34 AM

Jan 9 2021

nate updated the diff for D5767: (buildkite 10/n) Add Windows tests.

up

Jan 9 2021, 11:52 PM
nate updated the diff for D5767: (buildkite 10/n) Add Windows tests.

up

Jan 9 2021, 11:10 PM
nate updated the diff for D5767: (buildkite 10/n) Add Windows tests.

up

Jan 9 2021, 11:05 PM