gonna abandon this for now, can come back to it if needed

hmmm this doesn't seem to have triggered the integration test suite, if I'm not mistaken - @max ?

make_people() has gotten so much mileage ;)

Abandoning given incoming changes to this part of the system. We can revisit in the future if needed cc @sandyryza @yuhan

looks reasonable enough to me, but will let ben/prha do the signoff :)

cool sgtm!

rather than adding the buildkite env var here, should we also add support for blocking telemetry based on a DAGSTER_TELEMETRY_ENABLED=false env var? seems like something our users might want also

see one comment, otherwise lgtm

See one nit above, otherwise LGTM.

ah, also I think we need to move the test image builds to this pipeline, from pipeline.py - see test_image_depends_fn

Great! Adding @catherinewu also.

@alangenfeld damn - worth reverting while we revise to hold onto connections? or just fix forward?

Cool, thanks for this - shouldn't cause any other issues AFAIK

ah, great! once landed could you update the documentation also?

hmm I haven't worked on this part of the system much, but the proposal sounds reasonable; would love to hear from @max and @prha when he's back

any thoughts on how to test this? Would love to get some test coverage before merging

yeah, let me do those separately, I'm less confident in being able to write good test for those—but will put up a follow-up diff

up

rebase

up

up

up

one nit, otherwise lgtm

I think we should still do this regardless, but can you also take a look at using PG for queuing and dropping RabbitMQ entirely?

up

up

up

left a few comments, otherwise lgtm - will let @catherinewu have the honors of final sign-off

rebase

up

I don't know how best to test this, but see https://boto3.amazonaws.com/v1/documentation/api/latest/guide/retries.html

up

up

up

up

up

up

nice! this is sweet

after a long stint of meticulously switching double quotes to single wherever I found them, given the abstentions, I'm happy to be the one to go ahead and greenlight this. Getting tooling support is super attractive