Page MenuHomePhabricator

max (Max Gasner)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2019, 5:20 PM (17 w, 6 h)

Recent Activity

Wed, Aug 21

max updated the diff for D859: Break log storage out from run storage.

Black

Wed, Aug 21, 9:59 PM
max updated the diff for D859: Break log storage out from run storage.

Reorganize

Wed, Aug 21, 9:56 PM
max updated the diff for D862: Add naive filesystem log watchers.

Rebase

Wed, Aug 21, 9:33 PM
max updated the diff for D859: Break log storage out from run storage.

Black

Wed, Aug 21, 9:27 PM
max updated the diff for D862: Add naive filesystem log watchers.

Rebase

Wed, Aug 21, 9:25 PM
max updated the diff for D859: Break log storage out from run storage.

EventLogStorage

Wed, Aug 21, 9:15 PM
max abandoned D789: Naive watcher for filesystem log storage.
Wed, Aug 21, 9:12 PM
max created D862: Add naive filesystem log watchers.
Wed, Aug 21, 9:10 PM
max added inline comments to D859: Break log storage out from run storage.
Wed, Aug 21, 9:02 PM
max created D859: Break log storage out from run storage.
Wed, Aug 21, 8:19 PM
max updated the diff for D853: Use __slots__ for PipelineRun.

Rebase

Wed, Aug 21, 4:18 PM
max updated subscribers of D853: Use __slots__ for PipelineRun.

Yeah, at @schrockn's request

Wed, Aug 21, 4:17 PM
max updated the diff for D850: Refactor PipelineRun.

Wtf

Wed, Aug 21, 4:07 PM
max updated the diff for D850: Refactor PipelineRun.

Rebase

Wed, Aug 21, 3:19 PM
max created D853: Use __slots__ for PipelineRun.
Wed, Aug 21, 3:14 PM
max created D852: Bring pyproject.toml black settings in line with CLI.
Wed, Aug 21, 3:09 PM
max updated the diff for D850: Refactor PipelineRun.

Rebase

Wed, Aug 21, 12:13 AM
max updated the diff for D841: Consolidate double implementation of run storage.

Rebase

Wed, Aug 21, 12:11 AM
max added inline comments to D841: Consolidate double implementation of run storage.
Wed, Aug 21, 12:09 AM
max added a comment to D841: Consolidate double implementation of run storage.

I think that https://dagster.phacility.com/D850 should address @schrockn's questions

Wed, Aug 21, 12:07 AM

Tue, Aug 20

max updated the diff for D850: Refactor PipelineRun.

Black

Tue, Aug 20, 11:48 PM
max updated the summary of D850: Refactor PipelineRun.
Tue, Aug 20, 11:15 PM
max created D850: Refactor PipelineRun.
Tue, Aug 20, 11:14 PM
max updated the summary of D841: Consolidate double implementation of run storage.
Tue, Aug 20, 5:26 PM
max updated the diff for D841: Consolidate double implementation of run storage.

Lint

Tue, Aug 20, 5:25 PM

Mon, Aug 19

max updated the diff for D841: Consolidate double implementation of run storage.

Black

Mon, Aug 19, 10:51 PM
max updated the summary of D841: Consolidate double implementation of run storage.
Mon, Aug 19, 10:51 PM
max added a reviewer for D841: Consolidate double implementation of run storage: schrockn.
Mon, Aug 19, 10:51 PM
max updated the diff for D841: Consolidate double implementation of run storage.

Black

Mon, Aug 19, 10:51 PM
max updated the diff for D841: Consolidate double implementation of run storage.

Black

Mon, Aug 19, 10:45 PM
max updated the diff for D841: Consolidate double implementation of run storage.

Nits

Mon, Aug 19, 10:40 PM
max updated the diff for D841: Consolidate double implementation of run storage.

Nits

Mon, Aug 19, 10:18 PM
max updated the diff for D841: Consolidate double implementation of run storage.

Six

Mon, Aug 19, 9:54 PM
max updated the diff for D841: Consolidate double implementation of run storage.

Nits

Mon, Aug 19, 9:51 PM
max updated the diff for D841: Consolidate double implementation of run storage.

Nits

Mon, Aug 19, 9:45 PM
max updated the diff for D841: Consolidate double implementation of run storage.

Nits

Mon, Aug 19, 9:43 PM
max updated the diff for D841: Consolidate double implementation of run storage.

Nits

Mon, Aug 19, 9:39 PM
max updated the summary of D841: Consolidate double implementation of run storage.
Mon, Aug 19, 9:38 PM
max created D841: Consolidate double implementation of run storage.
Mon, Aug 19, 9:33 PM

Fri, Aug 16

max updated the diff for D789: Naive watcher for filesystem log storage.

Fixup

Fri, Aug 16, 11:14 PM
max updated the diff for D789: Naive watcher for filesystem log storage.

Nits

Fri, Aug 16, 11:05 PM
max updated the diff for D789: Naive watcher for filesystem log storage.

Nits

Fri, Aug 16, 10:45 PM
max updated the diff for D789: Naive watcher for filesystem log storage.

nk

Fri, Aug 16, 10:36 PM
max accepted D824: [dagster] EventSink.
Fri, Aug 16, 10:17 PM
max accepted D831: RFC: push config obj instantiation into `reconstitute_pipeline_context`.
Fri, Aug 16, 10:13 PM
max added reviewers for D789: Naive watcher for filesystem log storage: alangenfeld, Restricted Project.
Fri, Aug 16, 10:08 PM
max retitled D789: Naive watcher for filesystem log storage from Wip to Naive watcher for filesystem log storage.
Fri, Aug 16, 10:08 PM
max updated the diff for D789: Naive watcher for filesystem log storage.

Nits

Fri, Aug 16, 10:07 PM
max added a comment to D833: Update Flask dependency.

Do we know what is actually breaking?

Fri, Aug 16, 9:57 PM
max updated the diff for D789: Naive watcher for filesystem log storage.

POC

Fri, Aug 16, 9:56 PM

Thu, Aug 15

max created D828: Update releasing docs.
Thu, Aug 15, 8:42 PM
max updated the diff for D815: Promote some step events to INFO.

Assert

Thu, Aug 15, 5:08 PM
max added a comment to D815: Promote some step events to INFO.

Thu, Aug 15, 5:00 PM
max updated the diff for D815: Promote some step events to INFO.

Rewind

Thu, Aug 15, 4:54 PM

Wed, Aug 14

max added inline comments to D815: Promote some step events to INFO.
Wed, Aug 14, 8:44 PM
max updated the diff for D815: Promote some step events to INFO.

Nits

Wed, Aug 14, 8:43 PM
max added a comment to D815: Promote some step events to INFO.
13:08 $ dagster pipeline execute hello_world_pipeline
2019-08-14 13:08:29 - dagster - INFO - 
        orig_message = "Started execution of step \"hello_world.compute\"."
      log_message_id = "76a5859e-f570-4149-8abb-5827edb5dc88"
       log_timestamp = "2019-08-14T20:08:29.680115"
              run_id = "0d373766-6ca8-4f54-a558-8dc503cb285e"
            pipeline = "hello_world_pipeline"
execution_epoch_time = 1565813309.6636858
            step_key = "hello_world.compute"
               solid = "hello_world"
    solid_definition = "hello_world"
       dagster_event = {"event_specific_data": null, "event_type_value": "STEP_START", "logging_tags": {"execution_epoch_time": 1565813309.6636858, "pipeline": "hello_world_pipeline", "solid": "hello_world", "solid_definition": "hello_world", "step_key": "hello_world.compute"}, "message": "Started execution of step \"hello_world.compute\".", "pipeline_name": "hello_world_pipeline", "solid_handle": ["hello_world", "hello_world", null], "step_key": "hello_world.compute", "step_kind_value": "COMPUTE"}
       pipeline_name = "hello_world_pipeline"
2019-08-14 13:08:29 - dagster - INFO - 
        orig_message = "Yielded output \"result\" of type \"Any\". (Type check passed)."
      log_message_id = "c2e86805-48d0-4ff9-a319-259e028bc697"
       log_timestamp = "2019-08-14T20:08:29.685378"
              run_id = "0d373766-6ca8-4f54-a558-8dc503cb285e"
            pipeline = "hello_world_pipeline"
execution_epoch_time = 1565813309.6636858
            step_key = "hello_world.compute"
               solid = "hello_world"
    solid_definition = "hello_world"
       dagster_event = {"event_specific_data": [["hello_world.compute", "result"], null, [true, "result", null, []]], "event_type_value": "STEP_OUTPUT", "logging_tags": {"execution_epoch_time": 1565813309.6636858, "pipeline": "hello_world_pipeline", "solid": "hello_world", "solid_definition": "hello_world", "step_key": "hello_world.compute"}, "message": "Yielded output \"result\" of type \"Any\". (Type check passed).", "pipeline_name": "hello_world_pipeline", "solid_handle": ["hello_world", "hello_world", null], "step_key": "hello_world.compute", "step_kind_value": "COMPUTE"}
       pipeline_name = "hello_world_pipeline"
2019-08-14 13:08:29 - dagster - INFO - 
        orig_message = "Finished execution of step \"hello_world.compute\" in 0.92ms."
      log_message_id = "33ddba7c-b6c7-421f-a906-4a0f9f942169"
       log_timestamp = "2019-08-14T20:08:29.685813"
              run_id = "0d373766-6ca8-4f54-a558-8dc503cb285e"
            pipeline = "hello_world_pipeline"
execution_epoch_time = 1565813309.6636858
            step_key = "hello_world.compute"
               solid = "hello_world"
    solid_definition = "hello_world"
       dagster_event = {"event_specific_data": [0.9248830028809607], "event_type_value": "STEP_SUCCESS", "logging_tags": {"execution_epoch_time": 1565813309.6636858, "pipeline": "hello_world_pipeline", "solid": "hello_world", "solid_definition": "hello_world", "step_key": "hello_world.compute"}, "message": "Finished execution of step \"hello_world.compute\" in 0.92ms.", "pipeline_name": "hello_world_pipeline", "solid_handle": ["hello_world", "hello_world", null], "step_key": "hello_world.compute", "step_kind_value": "COMPUTE"}
       pipeline_name = "hello_world_pipeline"
Wed, Aug 14, 8:09 PM
max updated the diff for D815: Promote some step events to INFO.

Fix tests

Wed, Aug 14, 6:06 PM
max retitled D815: Promote some step events to INFO from Drop the default console logger log level to DEBUG to Promote some step events to INFO.
Wed, Aug 14, 6:05 PM
max updated the diff for D815: Promote some step events to INFO.

Rework

Wed, Aug 14, 6:05 PM
max updated the diff for D817: Terminate watchdog when the child process exits.

Add basic test for cli wrapper

Wed, Aug 14, 5:59 PM
max updated the diff for D817: Terminate watchdog when the child process exits.

Rebase

Wed, Aug 14, 5:51 PM
max created D817: Terminate watchdog when the child process exits.
Wed, Aug 14, 5:39 PM
max updated the diff for D816: Handle SIGTERM like SIGINT.

Black

Wed, Aug 14, 5:24 PM
max added a comment to D815: Promote some step events to INFO.

Alternatively, we could have a CLI-specific logger that did some cute display stuff (could print out something like . . . . or take verbose options)

Wed, Aug 14, 4:35 PM
max created D816: Handle SIGTERM like SIGINT.
Wed, Aug 14, 4:18 PM
max updated the diff for D814: Keep the abspath to repository.yaml around in ExecutionTargetHandle.

Basic test for output notebook reexecution

Wed, Aug 14, 3:38 PM
max added a comment to D815: Promote some step events to INFO.

Just going to note that they are very, very noisy

Wed, Aug 14, 3:31 PM
max created D815: Promote some step events to INFO.
Wed, Aug 14, 3:20 PM
max created D814: Keep the abspath to repository.yaml around in ExecutionTargetHandle.
Wed, Aug 14, 3:06 PM

Tue, Aug 13

max updated the diff for D802: Update docs and changelog for 0.5.6.

Rebase

Tue, Aug 13, 11:17 PM
max abandoned D583: Add expectations pipeline with histograms.
Tue, Aug 13, 11:14 PM
max updated the diff for D808: Actually preserve the original config dict.

Nits

Tue, Aug 13, 11:10 PM
max accepted D812: [log sink] multiprocess executor.
Tue, Aug 13, 11:08 PM
max accepted D811: [log sink] RunConfig log_sink.

can't wait for this to go

Tue, Aug 13, 11:06 PM
max added inline comments to D808: Actually preserve the original config dict.
Tue, Aug 13, 11:05 PM
max accepted D810: [log sink] move dagstermill xproc log to dagster.
Tue, Aug 13, 11:05 PM
max updated the diff for D808: Actually preserve the original config dict.

Nits

Tue, Aug 13, 11:02 PM
max updated the diff for D789: Naive watcher for filesystem log storage.

Cp

Tue, Aug 13, 10:50 PM
max created D808: Actually preserve the original config dict.
Tue, Aug 13, 6:29 PM
max updated the diff for D802: Update docs and changelog for 0.5.6.

Add MarkdownMetadataEntryData

Tue, Aug 13, 3:11 PM
max added inline comments to D801: Initial k8s operator and split out of shared functionality.
Tue, Aug 13, 3:08 PM

Mon, Aug 12

max created D802: Update docs and changelog for 0.5.6.
Mon, Aug 12, 10:05 PM
max accepted D795: Initial dagster-dbt prototype.
Mon, Aug 12, 9:29 PM
max updated the diff for D799: Don't run docker-compose fixture on buildkite.

Lint

Mon, Aug 12, 8:58 PM
max created D799: Don't run docker-compose fixture on buildkite.
Mon, Aug 12, 8:50 PM
max added a comment to D792: fix column resizing in run view.

oohh 👀

Mon, Aug 12, 6:59 PM
max added inline comments to D759: Create script to generate library.
Mon, Aug 12, 6:52 PM
max updated the diff for D782: Use isort to sort imports.

Black

Mon, Aug 12, 6:34 PM
max updated the diff for D782: Use isort to sort imports.

Fix failing test

Mon, Aug 12, 6:20 PM
max updated the diff for D782: Use isort to sort imports.

Fix test

Mon, Aug 12, 3:42 PM
max updated the diff for D782: Use isort to sort imports.

Rebase

Mon, Aug 12, 3:18 PM

Fri, Aug 9

max created D789: Naive watcher for filesystem log storage.
Fri, Aug 9, 6:39 PM
max updated the diff for D774: Refactor PipelineRunStorage.

Black

Fri, Aug 9, 6:06 PM
max updated the diff for D774: Refactor PipelineRunStorage.

Rebase

Fri, Aug 9, 6:04 PM
max updated the diff for D774: Refactor PipelineRunStorage.

black

Fri, Aug 9, 5:37 PM
max updated the diff for D774: Refactor PipelineRunStorage.

Omit id for now

Fri, Aug 9, 5:35 PM
max updated the diff for D774: Refactor PipelineRunStorage.

fix dflt

Fri, Aug 9, 5:07 PM
max added inline comments to D774: Refactor PipelineRunStorage.
Fri, Aug 9, 5:02 PM

Thu, Aug 8

max updated the diff for D774: Refactor PipelineRunStorage.

Black

Thu, Aug 8, 9:31 PM