Up

this is fine, if we want to get rid of placeholders like this generally, but it's still something we are going to need to handle

hmm, consider also Path

i'm going to hold off on the abc, after some consideration, and give it some more consideration. it would be nice to get rid of the Union[] stuff in the docs, but if people click into the abc they won't see what methods are available on the results, since composite solid results and solid results implement different methods. in some ways composite solids are more like pipelines than they are like solids.

It's tricky, because this *is* slightly different from all of the examples.

Blk

Blk

not sure about this bucket api, please see comments. why not set_object(key, obj) and get_object(key)? maybe there's a missing upload_file api -- rn there's this odd asymmetry where we have set_object: str -> None and get_object: str -> blob (rather than set_object taking a blob and get_object giving one back)

I believe this is the right course of action until we get this under some form of test, will resign to @natekupp

Ununiqueify

Up

why limit it to local instances though?

ok. a short step from here to putting this in config!

Rebase

Yikes! Should be custom_types_figure_one.png, which is already checked in

I think that, to be safe, we should pin to 'google-cloud-bigquery>=1.19.*,<=1.21.0', 'google-cloud-storage<1.23.0', 'google-resumable-media >= 0.3.1, != 0.4.0, < 0.5dev' and then release or run a post-release as soon as https://github.com/googleapis/google-cloud-python/issues/9786 is resolved

cc @sashank

Up

I don't like the features system but I still think we need a way to feature-flag front-end functionality. Maybe it's about starting dagit with explicit flags?

Per our conversation re: providing examples that users will mirror, let's abandon this in favor of https://dagster.phacility.com/D1408

Webster

Nits

Up

py27

Nit

Nits

Up

Up

Up

Nits

Nits

I also dislike the bitshift because I don't know which direction is which

requesting changes on this to fix the implementation of the local bucket to work with s3 keys like foo/bar/baz

One more little thing, added check_dagster_type helper for testing custom types

Nits

Up

Up

Simplify further

this seems right

Do we need the enum-compat requirement at all? And can we drop the future pin?

Rebase

i'd like to make sure this will work on windows

Up

Up

Up

Up

Up

Up

Black

Up

Nits

reexecution config changes? scheduler errors in dagit? D1372?

Isort

Blk

Nits

so fresh and clean

py27

py27

Hooray

Up

Up

Nits

Black

Black

Less fragile solution to follow on D1382