Page MenuHomePhabricator

max (Max Gasner)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2019, 5:20 PM (42 w, 5 d)

Recent Activity

Yesterday

max added a comment to D2064: Rework sidebar styles.

Before:

Tue, Feb 18, 8:54 PM
max updated the diff for D2064: Rework sidebar styles.

Rebase & nits

Tue, Feb 18, 8:52 PM
max committed R1:c3ebf8cbe773: Fix dead docs links (authored by max).
Fix dead docs links
Tue, Feb 18, 8:50 PM
max closed D2065: Fix dead docs links.
Tue, Feb 18, 8:50 PM
max added inline comments to D2065: Fix dead docs links.
Tue, Feb 18, 8:48 PM
max committed R1:8fea586faace: Improve info hierarchy (authored by max).
Improve info hierarchy
Tue, Feb 18, 1:45 AM
max closed D2063: Improve info hierarchy.
Tue, Feb 18, 1:45 AM
max created D2065: Fix dead docs links.
Tue, Feb 18, 1:45 AM
max created D2064: Rework sidebar styles.
Tue, Feb 18, 12:51 AM
max created D2063: Improve info hierarchy.
Tue, Feb 18, 12:49 AM

Mon, Feb 17

max added a comment to D2060: make dagster pandas input/output schema more flexible.

i would have biased towards going in the other direction and strongly typing the whole pandas API rather than reducing the surface we cover. one benefit of strongly-typed config is catching errors early. even if we do go the other direction, i don't like the introduction of a new parameter name that doesn't align with the underlying API -- why serialization_options and not kwargs? (i admit that taking this position to its extreme would replace path with filepath_or_buffer, which, maybe, is the wrong thing to do)

Mon, Feb 17, 11:19 PM
max updated the diff for D2062: Move tutorial into main dagster package.

Blk

Mon, Feb 17, 11:09 PM
max updated the diff for D2062: Move tutorial into main dagster package.

Up

Mon, Feb 17, 11:08 PM
max added a comment to D2062: Move tutorial into main dagster package.

I'm not sure what you mean by prior art.

Mon, Feb 17, 11:07 PM
max updated the diff for D2062: Move tutorial into main dagster package.

Nits

Mon, Feb 17, 10:47 PM
max updated the diff for D2062: Move tutorial into main dagster package.

Up

Mon, Feb 17, 10:13 PM
max retitled D2062: Move tutorial into main dagster package from Cp - move tutorial to Move tutorial into main dagster package.
Mon, Feb 17, 9:55 PM
max created D2062: Move tutorial into main dagster package.
Mon, Feb 17, 9:52 PM
max closed D2056: Actually display the type check description in Dagit..
Mon, Feb 17, 6:28 PM
max committed R1:c900c513a5b4: Actually display the type check description in Dagit. (authored by max).
Actually display the type check description in Dagit.
Mon, Feb 17, 6:28 PM
max committed R1:5d137a6e074d: Look up port only when -p is not explicitly set (authored by max).
Look up port only when -p is not explicitly set
Mon, Feb 17, 6:28 PM
max closed D2055: Look up port only when -p is not explicitly set.
Mon, Feb 17, 6:28 PM

Sat, Feb 15

max accepted D2057: switch to pass connection instead of engine to check_alembic_revision.
Sat, Feb 15, 1:08 AM
max created D2056: Actually display the type check description in Dagit..
Sat, Feb 15, 12:35 AM
max added a comment to D2053: [Helm] Retrieve PG password from environment vs. hard-coding it.

if i were concerned about this, i would also probably be using a username and db name that i didn't want anywhere -- we consider perhaps reading those in in the same way

Sat, Feb 15, 12:02 AM

Fri, Feb 14

max created D2055: Look up port only when -p is not explicitly set.
Fri, Feb 14, 11:57 PM
max committed R1:3b618c927b1e: Set language for literal includes (authored by max).
Set language for literal includes
Fri, Feb 14, 10:50 PM
max closed D2051: Set language for literal includes.
Fri, Feb 14, 10:50 PM
max added a comment to D2052: Fix bug in config post-processing.

Can we add a test also!

Fri, Feb 14, 10:47 PM
max created D2051: Set language for literal includes.
Fri, Feb 14, 10:37 PM
max accepted D2050: improve error when using DagsterType in config.
Fri, Feb 14, 10:30 PM
max closed D2045: Fix line number spacing.
Fri, Feb 14, 10:28 PM
max committed R1:d5c5d4eef44c: Fix line number spacing (authored by max).
Fix line number spacing
Fri, Feb 14, 10:28 PM
max committed R1:cdcd4e34b866: Fix code font families (authored by max).
Fix code font families
Fri, Feb 14, 10:28 PM
max closed D2046: Fix code font families.
Fri, Feb 14, 10:28 PM
max added inline comments to D2050: improve error when using DagsterType in config.
Fri, Feb 14, 10:10 PM
max updated the diff for D2045: Fix line number spacing.

Rebase

Fri, Feb 14, 10:10 PM
max updated the diff for D2046: Fix code font families.

Rebase

Fri, Feb 14, 10:10 PM
max committed R1:f1a96e48b30d: Fixes for Gatsby deploy (authored by max).
Fixes for Gatsby deploy
Fri, Feb 14, 10:09 PM
max closed D2044: Fixes for Gatsby deploy.
Fri, Feb 14, 10:09 PM
max updated the diff for D2044: Fixes for Gatsby deploy.

Rebase

Fri, Feb 14, 10:00 PM
max updated the diff for D2044: Fixes for Gatsby deploy.

Rebase

Fri, Feb 14, 9:46 PM
max committed R1:d7039f3ef958: Reorganize info hierarchy (authored by max).
Reorganize info hierarchy
Fri, Feb 14, 9:30 PM
max closed D2043: Reorganize info hierarchy.
Fri, Feb 14, 9:30 PM
max updated the diff for D2045: Fix line number spacing.

Rebase

Fri, Feb 14, 9:07 PM
max updated the diff for D2044: Fixes for Gatsby deploy.

Rebase

Fri, Feb 14, 9:07 PM
max updated the diff for D2043: Reorganize info hierarchy.

Rebase

Fri, Feb 14, 8:58 PM
max updated the diff for D2043: Reorganize info hierarchy.

Nits

Fri, Feb 14, 8:57 PM
max created D2046: Fix code font families.
Fri, Feb 14, 12:03 AM

Thu, Feb 13

max created D2045: Fix line number spacing.
Thu, Feb 13, 11:55 PM
max retitled D2043: Reorganize info hierarchy from Cp to Reorganize info hierarchy.
Thu, Feb 13, 11:26 PM
max updated the diff for D2044: Fixes for Gatsby deploy.

Hardcode

Thu, Feb 13, 11:26 PM
max created D2044: Fixes for Gatsby deploy.
Thu, Feb 13, 10:26 PM
max created D2043: Reorganize info hierarchy.
Thu, Feb 13, 10:17 PM
max closed D2040: Docs nits.
Thu, Feb 13, 7:08 PM
max committed R1:e0c18594d192: Docs nits (authored by max).
Docs nits
Thu, Feb 13, 7:08 PM
max created D2040: Docs nits.
Thu, Feb 13, 6:56 PM
max committed R1:5738b7baa572: Update changelog (authored by max).
Update changelog
Thu, Feb 13, 12:12 AM
max closed D2036: Update changelog.
Thu, Feb 13, 12:12 AM
max created D2036: Update changelog.
Thu, Feb 13, 12:05 AM

Wed, Feb 12

max added inline comments to D1967: Dagster Type Guide.
Wed, Feb 12, 7:19 PM
max committed R1:abb12ac2a0d7: Rework Airflow docs (authored by max).
Rework Airflow docs
Wed, Feb 12, 6:59 PM
max closed D2015: Rework Airflow docs.
Wed, Feb 12, 6:59 PM
max updated the diff for D2015: Rework Airflow docs.

Rebase

Wed, Feb 12, 6:40 PM
max committed R1:2c08c91347bc: Basic docs for dagster-k8s (authored by max).
Basic docs for dagster-k8s
Wed, Feb 12, 6:38 PM
max closed D2012: Basic docs for dagster-k8s.
Wed, Feb 12, 6:38 PM
max updated the diff for D2012: Basic docs for dagster-k8s.

Rebase

Wed, Feb 12, 6:24 PM
max committed R1:18463b454c8b: Document the Celery executor (authored by max).
Document the Celery executor
Wed, Feb 12, 6:23 PM
max closed D2006: Document the Celery executor.
Wed, Feb 12, 6:23 PM
max removed a reviewer for D2006: Document the Celery executor: schrockn.
Wed, Feb 12, 6:16 PM
max updated the diff for D2006: Document the Celery executor.

Rebase

Wed, Feb 12, 6:07 PM
max created D2015: Rework Airflow docs.
Wed, Feb 12, 5:54 PM
max added inline comments to D2012: Basic docs for dagster-k8s.
Wed, Feb 12, 5:22 PM
max added a reviewer for D2006: Document the Celery executor: sashank.
Wed, Feb 12, 5:01 PM
max added a comment to D1996: Per live discussions, remove usable types from libraries.

I think I'm on the same page as Alex

Wed, Feb 12, 5:00 PM
max added reviewers for D2012: Basic docs for dagster-k8s: schrockn, alangenfeld, prha, sashank, nate.
Wed, Feb 12, 4:22 PM
max updated the diff for D2012: Basic docs for dagster-k8s.

Fix

Wed, Feb 12, 6:37 AM
max created D2012: Basic docs for dagster-k8s.
Wed, Feb 12, 6:16 AM
max updated the diff for D2006: Document the Celery executor.

AGH

Wed, Feb 12, 6:14 AM
max updated the diff for D2006: Document the Celery executor.

Updating

Wed, Feb 12, 6:12 AM
max updated the diff for D2006: Document the Celery executor.

Up

Wed, Feb 12, 12:44 AM
max added inline comments to D2006: Document the Celery executor.
Wed, Feb 12, 12:44 AM
max updated the diff for D2006: Document the Celery executor.

Up

Wed, Feb 12, 12:41 AM
max updated the diff for D2006: Document the Celery executor.

Up

Wed, Feb 12, 12:03 AM

Tue, Feb 11

max updated the diff for D2006: Document the Celery executor.

Respond to comments

Tue, Feb 11, 11:52 PM
max added a reviewer for D2006: Document the Celery executor: sashank.
Tue, Feb 11, 11:52 PM
max accepted D2008: Move concepts and demos under learn.
Tue, Feb 11, 11:38 PM
max created D2006: Document the Celery executor.
Tue, Feb 11, 9:29 PM
max added a comment to D1768: [core] add context to type_checks.

I think we should hard break this now so that the changes are bundled with the other custom type changes

Tue, Feb 11, 9:24 PM
max added inline comments to D2004: 0.7.0 Migration Guide.
Tue, Feb 11, 9:22 PM
max committed R1:d898c797de50: Fix docstring handling in decorators (authored by max).
Fix docstring handling in decorators
Tue, Feb 11, 8:37 PM
max closed D2001: Fix docstring handling in decorators.
Tue, Feb 11, 8:37 PM
max updated the diff for D2001: Fix docstring handling in decorators.

Blk

Tue, Feb 11, 7:57 PM
max created D2001: Fix docstring handling in decorators.
Tue, Feb 11, 7:46 PM
max committed R1:548c55ee07da: Improve documentation for dagster-celery (authored by max).
Improve documentation for dagster-celery
Tue, Feb 11, 6:09 PM
max closed D1994: Improve documentation for dagster-celery.
Tue, Feb 11, 6:09 PM
max updated the diff for D1994: Improve documentation for dagster-celery.

Fix assert

Tue, Feb 11, 3:25 AM
max updated the diff for D1994: Improve documentation for dagster-celery.

Blk

Tue, Feb 11, 3:02 AM
max updated the diff for D1994: Improve documentation for dagster-celery.

Up

Tue, Feb 11, 3:02 AM
max updated the diff for D1994: Improve documentation for dagster-celery.

Up

Tue, Feb 11, 3:00 AM