this may all be a wash

anotate

add test

try checking in lockfile

pipfile

??

unrelated flaky test failure

up

rebase

rebase

This seems mostly good but there is now nothing in the traceback to indicate that the error occurred over GRPC? Which seems like it's setting us up to be unable to debug.

Can we rename this diff? It's a little misleading -- I thought that this was going to touch the core in-process execute_pipeline API

ah this is so great, now we can work on 3.9 and 3.10

rebase

Closing in favor of D4062

Rebase

i believe so

Plan is to squash this and D4047 and merge simultaneously as this removes the test failing only on py38/buildkite.

dagstermill lint failure

import hell fixup

rebase

rebase

rm params

respond to feedback

lgtm, i am going to resign in favor of @alangenfeld

transient test failure

requesting changes for the os-specific path construction, but i like this. i'd like to see tests and fleshed out docstrings with examples

up

windows fix

respond to feedback

rebase

are the docker requirements missing from dev-requirements.txt?

let's explore the alternative impl based on wrapping the object rather than copying the method

• the ipc_interrupt scheme is not possible here because the interrupt signal is swallowed by the grpc server machinery (so we can't generate a soft termination STEP_FAILURE event)
• we need to spin up a multi-worker ephemeral server because we need another worker to listen to cancellation requests
• we use multiprocessing/_kill_on_event instead of the ipc scheme b/c, since the interrupts don't work correctly, there is no win from the ipc scheme

see note on failure case

py2

Split up context managers per comments

requesting changes to resolve the setup.py/conditional import issue

i feel good about this but i know there was some back and forth on whether to set this at the instance level so will defer to others with stronger opinions

awesome

provided we can keep discipline around the weeklies, i am ok with this, but there is still all kinds of support for the nightly channel in our setup.py files, etc...

test pass on nt -- see github pr

undebug

fix id parsing

lint

rebase

up