Page MenuHomeElementl

max (Max Gasner)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2019, 5:20 PM (129 w, 3 d)
Roles
Administrator

Recent Activity

Aug 27 2021

max committed R1:d1f96bbe9b59: Automation: versioned docs for 0.12.8 (authored by max).
Automation: versioned docs for 0.12.8
Aug 27 2021, 3:07 PM

Aug 26 2021

max committed R1:cc8ea31e078d: Attribute bugfix (authored by max).
Attribute bugfix
Aug 26 2021, 9:34 PM

Jul 22 2021

max closed D8145: Quieten experimental warnings on example pipeline.
Jul 22 2021, 10:14 PM
max committed R1:dab102788657: Quieten experimental warnings on example pipeline (authored by max).
Quieten experimental warnings on example pipeline
Jul 22 2021, 10:13 PM
max requested review of D8145: Quieten experimental warnings on example pipeline.
Jul 22 2021, 9:03 PM
max abandoned D4743: Replace timezone-unsafe use of now() and utcnow().
Jul 22 2021, 7:15 PM

Jul 21 2021

max resigned from D8844: have GcsComputeLogManager implement CapturedLogManager interface.
Jul 21 2021, 11:44 PM
max resigned from D8845: have AzureComputeLogManager implement CapturedLogManager interface.
Jul 21 2021, 11:44 PM
max added a comment to D8385: add captured log manager interface.

e.g. describing the lifecycle

Jul 21 2021, 11:42 PM
max added a comment to D8385: add captured log manager interface.

i think docstrings on the base class would make this easier to navigate

Jul 21 2021, 11:41 PM
max added inline comments to D8810: [dag-star] graphql websocket endpoint.
Jul 21 2021, 11:30 PM
max added a comment to D8981: add `from_failure` bool arg to rexecute pipeline apis.

i think the enum solution is the cleanest here; it certainly adds API surface but if we retain backcompatibility with the old list of strings, that feels fine -- it adds API surface in lockstep with new functionality

Jul 21 2021, 11:23 PM
max accepted D8953: Add a base IRepositoryData class that can be used to implement repositories with different caching rules.

i like alex's renaming suggestion

Jul 21 2021, 5:20 PM

Jul 19 2021

max accepted D8940: Move serdes deserialization out of DagsterGrpcClient.
Jul 19 2021, 9:59 PM
max closed D8948: Add utility to deserialize json to specific namedtuple class.
Jul 19 2021, 6:58 PM
max committed R1:f61a89a455c2: Add utility to deserialize json to specific namedtuple class (authored by max).
Add utility to deserialize json to specific namedtuple class
Jul 19 2021, 6:58 PM
max requested review of D8948: Add utility to deserialize json to specific namedtuple class.
Jul 19 2021, 5:47 PM

Jul 9 2021

max accepted D8805: [dagit] Avoid CORS in development.
Jul 9 2021, 8:55 PM
max resigned from D8684: style: adopt pre-commit for Python black formatting.
Jul 9 2021, 8:54 PM

Jul 8 2021

max closed D8752: Clean up marshalling of multiple inputs.
Jul 8 2021, 7:08 PM
max committed R1:07510f68022e: Clean up marshalling of multiple inputs (authored by max).
Clean up marshalling of multiple inputs
Jul 8 2021, 7:08 PM
max added inline comments to D8752: Clean up marshalling of multiple inputs.
Jul 8 2021, 5:53 PM
max added a reviewer for D8752: Clean up marshalling of multiple inputs: alangenfeld.
Jul 8 2021, 4:46 PM

Jul 7 2021

max requested review of D8752: Clean up marshalling of multiple inputs.
Jul 7 2021, 11:18 PM
max added a comment to D8684: style: adopt pre-commit for Python black formatting.

I don't personally love pre-commit hooks but if we do this we should think about also adding mypy, isort

Jul 7 2021, 10:43 PM

Jul 4 2021

max accepted D8702: mypy fixes to make master green.
Jul 4 2021, 8:00 PM

Jul 3 2021

max closed D8696: Typehints for MayHaveInstanceWeakref.
Jul 3 2021, 12:35 AM
max committed R1:a566b62cf58a: Typehints for MayHaveInstanceWeakref (authored by max).
Typehints for MayHaveInstanceWeakref
Jul 3 2021, 12:35 AM
max updated the diff for D8696: Typehints for MayHaveInstanceWeakref.

up

Jul 3 2021, 12:28 AM
max requested review of D8696: Typehints for MayHaveInstanceWeakref.

irrelevant stochastic test failure in dagster pandas

Jul 3 2021, 12:06 AM

Jul 2 2021

max closed D8681: Fix circular import.
Jul 2 2021, 7:33 PM
max committed R1:6c351f358831: Fix circular import (authored by max).
Fix circular import
Jul 2 2021, 7:33 PM
max added a comment to D8681: Fix circular import.

i think this is marginal -- it is really expected to be imported after the package so there's a case for making it absolute. i am just following the existing pattern later in this file though

Jul 2 2021, 6:56 PM

Jun 28 2021

max closed D8523: Add type annotations.
Jun 28 2021, 11:38 PM
max committed R1:08e7e2c7e1a5: Add type annotations (authored by max).
Add type annotations
Jun 28 2021, 11:38 PM

Jun 24 2021

max requested review of D8523: Add type annotations.

Unrelated test setup failure due to ongoing release.

Jun 24 2021, 11:49 PM

Jun 4 2021

max resigned from D8231: [RFC] remove PIPELINE_INIT_FAILURE event.

i agree with alex and think this is just great

Jun 4 2021, 8:03 PM
max added inline comments to D8231: [RFC] remove PIPELINE_INIT_FAILURE event.
Jun 4 2021, 8:02 PM

Jun 3 2021

max added a comment to D8209: [RFC] send python logging messages to the DagsterLogManager.

does this work with a log line emitted by a solid that isn't defined inline (but loaded from a file/module); does this work with log lines emitted by libraries called by solids?

Jun 3 2021, 6:09 PM
max accepted D8220: [dagster-graphql] PipelineRun.events.
Jun 3 2021, 6:07 PM

Jun 2 2021

max added a comment to D8185: Speed up test runs by using all CPU cores.

This definitely looks cleaner than the last time I tried it. I'd want to see ~100 test runs succeed before approving this. The failure above might be due to a conflict with the GRPC generation test, test_compiled_protobuf, which could definitely be isolated but is definitely not isolated at present. As you've discovered, the big wins in test time will come from more intelligent use of fixtures and from writing more true unit tests, not from multiprocessing.

Jun 2 2021, 7:49 PM
max added a comment to D8174: Attempt an unpin of sqlalchemy in dagster-airflow.

what about sid's comment on https://github.com/dagster-io/dagster/issues/3858?

Jun 2 2021, 7:25 PM

May 27 2021

max added inline comments to D8122: Make run storage metadata class configurable, plus the ability to insert/filter tables using additional attributes.
May 27 2021, 12:24 AM

May 26 2021

max added inline comments to D7945: RFC: add new api hooks for compute log manager to capture logs outside of a pipeline context, support process-based capture.
May 26 2021, 11:52 PM
max added inline comments to D7945: RFC: add new api hooks for compute log manager to capture logs outside of a pipeline context, support process-based capture.
May 26 2021, 11:50 PM
max added a comment to D7680: [RFC] DagsterAuthManager for run attribution.

I think I agree that another layer of indirection would be nice here, with e.g. get_additional_tags_for_run(pipeline_run) on the custom instance, and then the implementation of that calling the auth manager. i also think it makes sense to call this auth manager something like FlaskAuthManager

May 26 2021, 11:18 PM
max resigned from D7384: RFC: remove the airline demo.
May 26 2021, 11:07 PM
max accepted D7160: add compute log manager api to more directly expose file-like object.

thank you, this is great

May 26 2021, 11:06 PM
max closed D7970: papermill 2.0 compatibility.
May 26 2021, 5:54 PM
max committed R1:6db81c1183df: papermill 2.0 compatibility (authored by max).
papermill 2.0 compatibility
May 26 2021, 5:54 PM
max updated the diff for D7970: papermill 2.0 compatibility.

rebase

May 26 2021, 4:56 PM
max closed D6865: Housekeeping and code coverage.
May 26 2021, 4:55 PM
max committed R1:8d5dc63795f2: Housekeeping and code coverage (authored by max).
Housekeeping and code coverage
May 26 2021, 4:55 PM
max closed D8047: Upgrade mypy.
May 26 2021, 4:55 PM
max closed D8086: Use compat layer for typing introspection.
May 26 2021, 4:55 PM
max committed R1:ba312cad7c04: Upgrade mypy (authored by max).
Upgrade mypy
May 26 2021, 4:55 PM
max committed R1:e2b7333ac668: Use compat layer for typing introspection (authored by max).
Use compat layer for typing introspection
May 26 2021, 4:55 PM
max updated the diff for D7970: papermill 2.0 compatibility.

up

May 26 2021, 4:54 PM
max added inline comments to D8086: Use compat layer for typing introspection.
May 26 2021, 4:54 PM

May 25 2021

max requested review of D6865: Housekeeping and code coverage.
May 25 2021, 11:53 PM
max closed D8093: Repin alembic.
May 25 2021, 11:53 PM
max committed R1:61bc96e42037: Repin alembic (authored by max).
Repin alembic
May 25 2021, 11:53 PM
max updated the diff for D8093: Repin alembic.

add comment

May 25 2021, 11:52 PM
max updated the diff for D8086: Use compat layer for typing introspection.

rebase

May 25 2021, 11:29 PM
max requested review of D8093: Repin alembic.
May 25 2021, 11:28 PM
max updated the diff for D8047: Upgrade mypy.

blk

May 25 2021, 11:27 PM
max updated the diff for D7970: papermill 2.0 compatibility.

up

May 25 2021, 11:27 PM
max requested review of D8086: Use compat layer for typing introspection.
May 25 2021, 11:26 PM
max updated the diff for D7970: papermill 2.0 compatibility.

rebase

May 25 2021, 11:14 PM
max updated the diff for D8047: Upgrade mypy.

blk

May 25 2021, 11:14 PM
max updated the diff for D7970: papermill 2.0 compatibility.

rebase on D8104

May 25 2021, 11:05 PM
max updated the diff for D8047: Upgrade mypy.

rebase on D8104

May 25 2021, 11:03 PM
max accepted D8104: fix bad commit for capture logs.

merge when tests pass

May 25 2021, 10:48 PM
max published D8104: fix bad commit for capture logs for review.
May 25 2021, 10:48 PM
max updated the diff for D7970: papermill 2.0 compatibility.

rebase

May 25 2021, 10:13 PM
max updated the diff for D8047: Upgrade mypy.

rebase

May 25 2021, 10:10 PM
max requested review of D8047: Upgrade mypy.
May 25 2021, 9:05 PM
max accepted D8092: Loosen type annotations around hook decorators.
May 25 2021, 7:31 PM
max added a comment to D8092: Loosen type annotations around hook decorators.

+1 when tests pass

May 25 2021, 7:31 PM
max published D8092: Loosen type annotations around hook decorators for review.
May 25 2021, 7:31 PM
max closed D8017: Add seven.compat.
May 25 2021, 2:12 AM
max committed R1:fa478b44a588: Add seven.compat (authored by max).
Add seven.compat
May 25 2021, 2:12 AM
max updated the diff for D7970: papermill 2.0 compatibility.

rebase

May 25 2021, 1:58 AM

May 24 2021

max closed D8044: Simplify built-in type system.
May 24 2021, 12:37 AM
max committed R1:ba68fb3102a5: Simplify built-in type system (authored by max).
Simplify built-in type system
May 24 2021, 12:37 AM
max closed D8046: Pin alembic.
May 24 2021, 12:37 AM
max committed R1:a4d4f73161ff: Pin alembic (authored by max).
Pin alembic
May 24 2021, 12:37 AM
max requested review of D8044: Simplify built-in type system.
May 24 2021, 12:33 AM

May 21 2021

max updated the diff for D7970: papermill 2.0 compatibility.

up

May 21 2021, 2:05 AM
max updated the diff for D7970: papermill 2.0 compatibility.

up

May 21 2021, 2:04 AM
max updated the diff for D7970: papermill 2.0 compatibility.

up

May 21 2021, 2:00 AM
max updated the diff for D7970: papermill 2.0 compatibility.

up

May 21 2021, 1:59 AM
max updated the diff for D7970: papermill 2.0 compatibility.

omg

May 21 2021, 1:57 AM

May 20 2021

max updated the diff for D7970: papermill 2.0 compatibility.

escape

May 20 2021, 11:44 PM
max updated the diff for D7970: papermill 2.0 compatibility.

escape

May 20 2021, 11:43 PM
max updated the diff for D7970: papermill 2.0 compatibility.

up

May 20 2021, 11:41 PM
max updated the diff for D7970: papermill 2.0 compatibility.

escape

May 20 2021, 11:38 PM
max updated the diff for D7970: papermill 2.0 compatibility.

omg

May 20 2021, 8:59 PM
max closed D8021: Resolve circular import issue.
May 20 2021, 8:58 PM
max committed R1:6e77fd881a4d: Resolve circular import issue (authored by max).
Resolve circular import issue
May 20 2021, 8:58 PM