Page MenuHomeElementl

max (Max Gasner)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2019, 5:20 PM (103 w, 5 d)
Roles
Administrator

Recent Activity

Yesterday

max requested review of D7506: Use "dev" as version string for master.
Tue, Apr 20, 9:33 PM
max accepted D7474: clarify API doc for InputDefinition and OutputDefinition dagster_type args.
Tue, Apr 20, 6:49 PM
max accepted D7513: make storage deprecation warning clearer.
Tue, Apr 20, 6:47 PM
max added a comment to D7516: download csv in tutorial.

pandas is just a very heavy dep for a tutorial -- it's obviously more idiomatic for most data users (though possibly not "data eng") and installation has gotten better for most users, but if wheels aren't present (e.g. on python 3.10) it's still a "how do i install gfortran" situation

Tue, Apr 20, 6:47 PM
max closed D7508: Ignore the .env file.
Tue, Apr 20, 6:14 PM
max committed R1:170ed02e07ea: Ignore the .env file (authored by max).
Ignore the .env file
Tue, Apr 20, 6:14 PM

Mon, Apr 19

max accepted D7499: in check functions, remove raise_with_traceback and convert to f-strings.

it might be helpful to have a comment on why AbstractSet is required at the top of the file

Mon, Apr 19, 8:27 PM
max requested review of D7508: Ignore the .env file.
Mon, Apr 19, 8:17 PM
max committed R1:ef5505cbc03e: 0.11.5 docs build (authored by max).
0.11.5 docs build
Mon, Apr 19, 7:36 PM

Fri, Apr 16

max closed D7436: Add --short flag to dagster-release version (for automation).
Fri, Apr 16, 7:28 PM
max committed R1:e26d34662914: Add --short flag to dagster-release version (for automation) (authored by max).
Add --short flag to dagster-release version (for automation)
Fri, Apr 16, 7:27 PM

Thu, Apr 15

max closed D7472: Changelog for 0.11.5.
Thu, Apr 15, 10:25 PM
max committed R1:7ca5ca595db9: Changelog for 0.11.5 (authored by max).
Changelog for 0.11.5
Thu, Apr 15, 10:25 PM
max requested review of D7472: Changelog for 0.11.5.
Thu, Apr 15, 10:00 PM
max requested review of D7436: Add --short flag to dagster-release version (for automation).
Thu, Apr 15, 4:19 PM

Thu, Apr 8

max added inline comments to D7261: change DagsterInstance.get behavior.
Thu, Apr 8, 10:32 PM
max closed D7331: Use Jinja templating.
Thu, Apr 8, 7:24 PM
max committed R1:7e235f3b856d: Use Jinja templating (authored by max).
Use Jinja templating
Thu, Apr 8, 7:24 PM
max requested review of D7331: Use Jinja templating.
Thu, Apr 8, 6:52 PM

Wed, Apr 7

max accepted D7284: [dagit] RFC: Simplify GraphQL Playground usage.
Wed, Apr 7, 11:06 PM
max accepted D7261: change DagsterInstance.get behavior.

this is great, we should probably write up a changelog entry

Wed, Apr 7, 4:18 PM

Tue, Apr 6

max accepted D7264: update scrapbook dep.
Tue, Apr 6, 10:29 PM
max added inline comments to D7261: change DagsterInstance.get behavior.
Tue, Apr 6, 10:26 PM

Mon, Apr 5

max accepted D7280: improve dynamic map & collect api docs.
Mon, Apr 5, 10:54 PM

Wed, Mar 31

max accepted D7230: dont require matplotlib in dagster-pandas.

Seems legit

Wed, Mar 31, 5:41 PM

Tue, Mar 30

max closed D7221: Hygiene for Dagit routes.
Tue, Mar 30, 9:06 PM
max committed R1:6333cc004a2c: Hygiene for Dagit routes (authored by max).
Hygiene for Dagit routes
Tue, Mar 30, 9:06 PM
max requested review of D7221: Hygiene for Dagit routes.
Tue, Mar 30, 8:55 PM
max closed D7216: Once more with feeling.
Tue, Mar 30, 4:32 PM
max committed R1:afb5ed101fdc: Once more with feeling (authored by max).
Once more with feeling
Tue, Mar 30, 4:32 PM
max closed D7215: f-string fix.
Tue, Mar 30, 4:13 PM
max committed R1:37c636ec80fd: f-string fix (authored by max).
f-string fix
Tue, Mar 30, 4:13 PM
max closed D7200: fix format strings.
Tue, Mar 30, 3:33 PM
max committed R1:0714bdabf728: fix format strings (authored by max).
fix format strings
Tue, Mar 30, 3:33 PM

Mon, Mar 29

max closed D7178: Use f-strings.
Mon, Mar 29, 8:11 PM
max committed R1:9db8132c1ac1: Use f-strings (authored by max).
Use f-strings
Mon, Mar 29, 8:11 PM
max updated the diff for D7178: Use f-strings.

rebase

Mon, Mar 29, 8:09 PM
max updated the diff for D7178: Use f-strings.

up

Mon, Mar 29, 7:30 PM
max requested review of D7178: Use f-strings.
Mon, Mar 29, 7:13 PM
max closed D7162: Add check calls for configurable class.
Mon, Mar 29, 5:05 PM
max committed R1:40a591398a1a: Add check calls for configurable class (authored by max).
Add check calls for configurable class
Mon, Mar 29, 5:05 PM
max accepted D7166: catch invalid pipeline_name on sensors and schedules.
Mon, Mar 29, 4:05 PM
max requested review of D7162: Add check calls for configurable class.
Mon, Mar 29, 3:40 PM

Mon, Mar 22

max added a comment to D7092: Add a lock around alembic stamping.

hmm, what if instead of this we checked whether we were on the main thread and if not, did not stamp?

Mon, Mar 22, 5:40 PM

Mar 18 2021

max closed D7061: Fix broken link.
Mar 18 2021, 9:55 PM
max committed R1:f4e677872317: Fix broken link (authored by max).
Fix broken link
Mar 18 2021, 9:55 PM
max published D7061: Fix broken link for review.
Mar 18 2021, 9:53 PM
max closed D7044: Fixes to API docs.
Mar 18 2021, 8:24 PM
max committed R1:c1828561d0ea: Fixes to API docs (authored by max).
Fixes to API docs
Mar 18 2021, 8:24 PM
max updated the diff for D7044: Fixes to API docs.

up

Mar 18 2021, 8:24 PM
max closed D7041: Install missing packages in dev install.
Mar 18 2021, 8:21 PM
max committed R1:bbe494c19549: Install missing packages in dev install (authored by max).
Install missing packages in dev install
Mar 18 2021, 8:21 PM
max commandeered D7044: Fixes to API docs.
Mar 18 2021, 8:21 PM
max requested review of D7041: Install missing packages in dev install.
Mar 18 2021, 7:38 PM

Mar 11 2021

max accepted D6890: [easy] Pass schema into instantiate_app_with_views instead of creating it inside the method.
Mar 11 2021, 5:03 PM
max accepted D6862: [dagster-postgres] Cleanup Event Log.

lgtm but i would like @prha to glance at the signal handling behavior in await_pg_notifications

Mar 11 2021, 5:02 PM
max accepted D6894: [easy] Include docker image in docker run launcher run tags.
Mar 11 2021, 5:00 PM

Mar 10 2021

max added inline comments to D6862: [dagster-postgres] Cleanup Event Log.
Mar 10 2021, 4:10 PM
max accepted D6863: [dagster-postgres] Fixing cursor issues (GH issue #3744).
Mar 10 2021, 4:00 PM
max accepted D6852: Let DagsterInstance subclasses define schemas and place keys at the top-level of dagster.yaml.

this seems ok to me, if we're optimizing for the convenience of the person writing yaml

Mar 10 2021, 12:06 AM

Mar 5 2021

max closed D6768: Allow config for custom instance classes.
Mar 5 2021, 3:59 AM
max committed R1:0bcadea1f357: Allow config for custom instance classes (authored by max).
Allow config for custom instance classes
Mar 5 2021, 3:59 AM
max closed D6764: Factor instance weakref machinery into a mixin.
Mar 5 2021, 3:59 AM
max committed R1:de75f1d0fff5: Factor instance weakref machinery into a mixin (authored by max).
Factor instance weakref machinery into a mixin
Mar 5 2021, 3:59 AM

Mar 4 2021

max updated the diff for D6768: Allow config for custom instance classes.

blk

Mar 4 2021, 9:05 PM
max closed D6793: Use ECR alias.
Mar 4 2021, 8:55 PM
max committed R1:f0b84893772f: Use ECR alias (authored by max).
Use ECR alias
Mar 4 2021, 8:55 PM
max updated the diff for D6768: Allow config for custom instance classes.

add test and docs

Mar 4 2021, 8:39 PM
max requested review of D6793: Use ECR alias.
Mar 4 2021, 7:40 PM
max updated the diff for D6768: Allow config for custom instance classes.

rebase

Mar 4 2021, 7:31 PM
max updated the diff for D6764: Factor instance weakref machinery into a mixin.

blk

Mar 4 2021, 6:58 PM
max updated the diff for D6764: Factor instance weakref machinery into a mixin.

add deprecation warning

Mar 4 2021, 6:00 PM
max updated the diff for D6764: Factor instance weakref machinery into a mixin.

rebase and backcompat

Mar 4 2021, 5:33 PM

Mar 3 2021

max closed D6707: Fully qualify all image names.
Mar 3 2021, 11:29 PM
max committed R1:75746e0d8af8: Fully qualify all image names (authored by max).
Fully qualify all image names
Mar 3 2021, 11:29 PM
max updated the diff for D6707: Fully qualify all image names.

up

Mar 3 2021, 11:11 PM
max updated the diff for D6707: Fully qualify all image names.

global

Mar 3 2021, 10:41 PM
max updated the diff for D6707: Fully qualify all image names.

?!

Mar 3 2021, 10:05 PM
max updated the diff for D6707: Fully qualify all image names.

whaa

Mar 3 2021, 9:53 PM
max updated the diff for D6707: Fully qualify all image names.

pullPolicy

Mar 3 2021, 9:39 PM
max requested review of D6768: Allow config for custom instance classes.
Mar 3 2021, 9:28 PM
max updated the diff for D6707: Fully qualify all image names.

blk

Mar 3 2021, 8:58 PM
max requested review of D6764: Factor instance weakref machinery into a mixin.
Mar 3 2021, 8:54 PM
max updated the diff for D6707: Fully qualify all image names.

pylint

Mar 3 2021, 8:50 PM
max closed D6706: Add support for pushing built images to ECR.
Mar 3 2021, 8:49 PM
max committed R1:989e61d45f00: Add support for pushing built images to ECR (authored by max).
Add support for pushing built images to ECR
Mar 3 2021, 8:49 PM
max added a comment to D5126: RFC use custom yaml loader.

if we do this, we need to clearly document it

Mar 3 2021, 8:44 PM
max accepted D6763: fix alembic directory references in postgres setup.py.
Mar 3 2021, 8:44 PM
max updated the diff for D6707: Fully qualify all image names.

up

Mar 3 2021, 8:32 PM
max updated the diff for D6707: Fully qualify all image names.

up

Mar 3 2021, 8:31 PM
max added inline comments to D6707: Fully qualify all image names.
Mar 3 2021, 8:31 PM
max updated the diff for D6706: Add support for pushing built images to ECR.

up

Mar 3 2021, 8:23 PM
max added inline comments to D6706: Add support for pushing built images to ECR.
Mar 3 2021, 8:23 PM
max closed D6643: Add BoolSource.
Mar 3 2021, 8:15 PM
max committed R1:b15861d39919: Add BoolSource (authored by max).
Add BoolSource
Mar 3 2021, 8:15 PM
max closed D6686: Minor fixup for k8s docs.
Mar 3 2021, 8:14 PM
max committed R1:6102a34011e4: Minor fixup for k8s docs (authored by max).
Minor fixup for k8s docs
Mar 3 2021, 8:14 PM

Mar 2 2021

max accepted D6712: Make DagsterDaemon extend AbstractContextManager.
Mar 2 2021, 11:15 PM

Mar 1 2021

max requested review of D6707: Fully qualify all image names.
Mar 1 2021, 6:49 PM

Feb 26 2021

max requested review of D6686: Minor fixup for k8s docs.

irrelevant test failures

Feb 26 2021, 8:05 PM