Page MenuHomePhabricator

max (Max Gasner)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2019, 5:20 PM (67 w, 5 d)

Recent Activity

Thu, Aug 6

max added a comment to D4122: Even softer termination scheme.

this may all be a wash

Thu, Aug 6, 9:04 PM
max committed R1:a8fcc39d90aa: update protobuf to 3.12.4 (authored by alangenfeld).
update protobuf to 3.12.4
Thu, Aug 6, 8:57 PM
max closed D4065: update protobuf to 3.12.4.
Thu, Aug 6, 8:57 PM
max updated the diff for D4122: Even softer termination scheme.

anotate

Thu, Aug 6, 8:50 PM
max committed R1:2ba1862e8e81: Cleaner handling of crashes in execution subprocesses (authored by max).
Cleaner handling of crashes in execution subprocesses
Thu, Aug 6, 8:03 PM
max closed D4104: Cleaner handling of crashes in execution subprocesses.
Thu, Aug 6, 8:03 PM
max committed R1:750437d7c4ae: Add custom linter to guard against backwards-incompatible daemon keyword in… (authored by max).
Add custom linter to guard against backwards-incompatible daemon keyword in…
Thu, Aug 6, 7:55 PM
max closed D4100: Add custom linter to guard against backwards-incompatible daemon keyword in threading.Thread.
Thu, Aug 6, 7:55 PM
max accepted D4087: nicer error on failure to load repository in external process.
Thu, Aug 6, 7:54 PM
max accepted D4036: migration guide.
Thu, Aug 6, 7:54 PM
max updated the diff for D4100: Add custom linter to guard against backwards-incompatible daemon keyword in threading.Thread.

add test

Thu, Aug 6, 7:20 PM
max updated the diff for D4065: update protobuf to 3.12.4.

try checking in lockfile

Thu, Aug 6, 6:47 PM
max updated the diff for D4065: update protobuf to 3.12.4.

pipfile

Thu, Aug 6, 6:33 PM
max updated the diff for D4065: update protobuf to 3.12.4.

??

Thu, Aug 6, 6:09 PM
max added inline comments to D4103: implement configured logger, executor.
Thu, Aug 6, 5:08 PM
max requested review of D4104: Cleaner handling of crashes in execution subprocesses.
Thu, Aug 6, 4:12 PM
max requested review of D4122: Even softer termination scheme.

unrelated flaky test failure

Thu, Aug 6, 3:44 PM
max updated the diff for D4065: update protobuf to 3.12.4.

up

Thu, Aug 6, 3:35 PM
max committed R1:e8de52f6ab86: Heartbeat for GRPC server (authored by max).
Heartbeat for GRPC server
Thu, Aug 6, 3:05 PM
max closed D4099: Heartbeat for GRPC server.
Thu, Aug 6, 3:05 PM
max accepted D4112: Remove optional DagsterInstance param from execute CLI path.
Thu, Aug 6, 2:56 PM
max accepted D4114: Add retries for flakey integration tests.
Thu, Aug 6, 2:54 PM
max accepted D4115: Remove notebook_solid wrapper.
Thu, Aug 6, 2:54 PM
max updated the diff for D4065: update protobuf to 3.12.4.

rebase

Thu, Aug 6, 1:59 PM
max updated the diff for D4099: Heartbeat for GRPC server.

rebase

Thu, Aug 6, 11:11 AM

Wed, Aug 5

max requested review of D4099: Heartbeat for GRPC server.
Wed, Aug 5, 10:34 PM
max commandeered D4065: update protobuf to 3.12.4.
Wed, Aug 5, 7:16 PM
max requested review of D4100: Add custom linter to guard against backwards-incompatible daemon keyword in threading.Thread.
Wed, Aug 5, 1:24 PM
max added a comment to D4087: nicer error on failure to load repository in external process.

This seems mostly good but there is now nothing in the traceback to indicate that the error occurred over GRPC? Which seems like it's setting us up to be unable to debug.

Wed, Aug 5, 1:08 PM
max added a comment to D4078: Move execute_pipeline to not run any user code.

Can we rename this diff? It's a little misleading -- I thought that this was going to touch the core in-process execute_pipeline API

Wed, Aug 5, 1:05 PM

Tue, Aug 4

max accepted D4096: Don't kill the grpc server process when the parent process ends.
Tue, Aug 4, 10:59 PM
max accepted D4091: Full support for Python 3.8.

ah this is so great, now we can work on 3.9 and 3.10

Tue, Aug 4, 10:51 PM

Mon, Aug 3

max committed R1:9da69f597f88: Add DefaultRunLauncher and shed EphemeralGrpcRunLauncher (authored by max).
Add DefaultRunLauncher and shed EphemeralGrpcRunLauncher
Mon, Aug 3, 4:38 PM
max closed D4062: Add DefaultRunLauncher and shed EphemeralGrpcRunLauncher.
Mon, Aug 3, 4:38 PM
max updated the diff for D4062: Add DefaultRunLauncher and shed EphemeralGrpcRunLauncher.

rebase

Mon, Aug 3, 4:21 PM
max accepted D4066: tqdm pin to fix lint.
Mon, Aug 3, 4:18 PM
max closed D4047: Add DefaultRunLauncher.

Closing in favor of D4062

Mon, Aug 3, 4:01 PM
max retitled D4062: Add DefaultRunLauncher and shed EphemeralGrpcRunLauncher from Swap DefaultRunLauncher and shed EphemeralGrpcRunLauncher to Add DefaultRunLauncher and shed EphemeralGrpcRunLauncher.
Mon, Aug 3, 4:01 PM
max updated the diff for D4062: Add DefaultRunLauncher and shed EphemeralGrpcRunLauncher.

Rebase

Mon, Aug 3, 4:00 PM
max added a comment to D4062: Add DefaultRunLauncher and shed EphemeralGrpcRunLauncher.

i believe so

Mon, Aug 3, 3:57 PM
max added a comment to D4062: Add DefaultRunLauncher and shed EphemeralGrpcRunLauncher.

Plan is to squash this and D4047 and merge simultaneously as this removes the test failing only on py38/buildkite.

Mon, Aug 3, 3:32 PM
max requested review of D4062: Add DefaultRunLauncher and shed EphemeralGrpcRunLauncher.

dagstermill lint failure

Mon, Aug 3, 3:31 PM

Sun, Aug 2

max updated the diff for D4047: Add DefaultRunLauncher.

import hell fixup

Sun, Aug 2, 1:46 PM
max updated the diff for D4047: Add DefaultRunLauncher.

rebase

Sun, Aug 2, 12:56 PM

Fri, Jul 31

max updated the diff for D4047: Add DefaultRunLauncher.

rebase

Fri, Jul 31, 6:44 PM
max updated the diff for D4047: Add DefaultRunLauncher.

rm params

Fri, Jul 31, 6:29 PM
max added inline comments to D4047: Add DefaultRunLauncher.
Fri, Jul 31, 6:26 PM
max updated the diff for D4047: Add DefaultRunLauncher.

respond to feedback

Fri, Jul 31, 4:08 PM
max added inline comments to D4047: Add DefaultRunLauncher.
Fri, Jul 31, 4:06 PM
max added inline comments to D4047: Add DefaultRunLauncher.
Fri, Jul 31, 4:05 PM
max resigned from D4031: Remove places in scheduler execution where we call user code.

lgtm, i am going to resign in favor of @alangenfeld

Fri, Jul 31, 3:33 PM
max requested review of D4047: Add DefaultRunLauncher.

transient test failure

Fri, Jul 31, 3:28 PM

Thu, Jul 30

max requested changes to D3981: [2] run-scoped file manager resources.
Thu, Jul 30, 4:01 PM
max added a comment to D3981: [2] run-scoped file manager resources.

requesting changes for the os-specific path construction, but i like this. i'd like to see tests and fleshed out docstrings with examples

Thu, Jul 30, 4:01 PM
max added a reviewer for D3981: [2] run-scoped file manager resources: sandyryza.
Thu, Jul 30, 3:58 PM

Wed, Jul 29

max committed R1:349e82dd8c3e: Persistent GRPC run launcher (authored by max).
Persistent GRPC run launcher
Wed, Jul 29, 8:41 PM
max closed D4003: Persistent GRPC run launcher.
Wed, Jul 29, 8:41 PM
max updated the diff for D4003: Persistent GRPC run launcher.

up

Wed, Jul 29, 7:02 PM
max updated the diff for D4003: Persistent GRPC run launcher.

windows fix

Wed, Jul 29, 6:54 PM
max updated the diff for D4003: Persistent GRPC run launcher.

respond to feedback

Wed, Jul 29, 6:32 PM
max added inline comments to D4003: Persistent GRPC run launcher.
Wed, Jul 29, 6:31 PM
max requested review of D4003: Persistent GRPC run launcher.
Wed, Jul 29, 3:36 PM

Sat, Jul 25

max committed R1:b37724660d26: Support soft run termination over GRPC (authored by max).
Support soft run termination over GRPC
Sat, Jul 25, 6:13 PM
max closed D3954: Support soft run termination over GRPC.
Sat, Jul 25, 6:13 PM
max added inline comments to D3954: Support soft run termination over GRPC.
Sat, Jul 25, 6:13 PM

Fri, Jul 24

max updated the diff for D3954: Support soft run termination over GRPC.

rebase

Fri, Jul 24, 4:22 PM
max added inline comments to D3954: Support soft run termination over GRPC.
Fri, Jul 24, 3:45 PM
max added a comment to D3984: Test grpc ping inside container.

are the docker requirements missing from dev-requirements.txt?

Fri, Jul 24, 3:43 PM
max requested changes to D3985: Adding type info to materializations as metadata.

let's explore the alternative impl based on wrapping the object rather than copying the method

Fri, Jul 24, 2:59 PM

Thu, Jul 23

max added a comment to D3954: Support soft run termination over GRPC.
  • the ipc_interrupt scheme is not possible here because the interrupt signal is swallowed by the grpc server machinery (so we can't generate a soft termination STEP_FAILURE event)
  • we need to spin up a multi-worker ephemeral server because we need another worker to listen to cancellation requests
  • we use multiprocessing/_kill_on_event instead of the ipc scheme b/c, since the interrupts don't work correctly, there is no win from the ipc scheme
Thu, Jul 23, 12:45 PM

Wed, Jul 22

max requested review of D3954: Support soft run termination over GRPC.
Wed, Jul 22, 5:05 PM
max added inline comments to D3960: Spin up a persistent grpc server on pyenv repository location creation, instead of creating an ephemeral one on each API call.
Wed, Jul 22, 4:56 PM
max added inline comments to D3937: update CHANGES.md on storages.
Wed, Jul 22, 3:50 PM
max accepted D3893: add linter for try/finally.

see note on failure case

Wed, Jul 22, 3:47 PM

Tue, Jul 21

max committed R1:8a1f68ffd942: Support soft server termination over GRPC (authored by max).
Support soft server termination over GRPC
Tue, Jul 21, 9:31 PM
max closed D3946: Support soft server termination over GRPC.
Tue, Jul 21, 9:31 PM
max updated the diff for D3946: Support soft server termination over GRPC.

py2

Tue, Jul 21, 6:07 PM
max added inline comments to D3946: Support soft server termination over GRPC.
Tue, Jul 21, 4:37 PM
max updated the diff for D3946: Support soft server termination over GRPC.

Split up context managers per comments

Tue, Jul 21, 4:07 PM
max requested changes to D3893: add linter for try/finally.

requesting changes to resolve the setup.py/conditional import issue

Tue, Jul 21, 3:32 PM
max accepted D3893: add linter for try/finally.
Tue, Jul 21, 3:31 PM
max accepted D3949: Split _grpc methods into ephemeral and non-ephemeral versions.
Tue, Jul 21, 12:01 PM
max accepted D3951: Add repository location for grpc server managed outside of dagster.
Tue, Jul 21, 12:01 PM
max accepted D3933: fix fan-in skips for fully skipped solids.
Tue, Jul 21, 11:56 AM

Mon, Jul 20

max requested review of D3946: Support soft server termination over GRPC.
Mon, Jul 20, 6:05 PM
max accepted D3936: Add a flag to workspace.yaml that lets users opt into the ephemeral grpc server.
Mon, Jul 20, 5:42 PM
max added a comment to D3936: Add a flag to workspace.yaml that lets users opt into the ephemeral grpc server.

i feel good about this but i know there was some back and forth on whether to set this at the instance level so will defer to others with stronger opinions

Mon, Jul 20, 3:22 PM
max added inline comments to D3893: add linter for try/finally.
Mon, Jul 20, 3:20 PM
max accepted D3944: add graphql test environment for ephemeral grpc-based repository location.

awesome

Mon, Jul 20, 3:14 PM

Thu, Jul 16

max added a comment to D3910: Remove nightly and deploy pipelines.

provided we can keep discipline around the weeklies, i am ok with this, but there is still all kinds of support for the nightly channel in our setup.py files, etc...

Thu, Jul 16, 2:38 AM
max committed R1:bfcb58c08654: Fix confusing unmatched quote (authored by max).
Fix confusing unmatched quote
Thu, Jul 16, 2:37 AM
max closed D3899: Fix confusing unmatched quote.
Thu, Jul 16, 2:37 AM

Wed, Jul 15

max requested review of D3899: Fix confusing unmatched quote.
Wed, Jul 15, 5:21 PM

Tue, Jul 14

max updated the diff for D3881: Unit tests of IPC interrupt machinery & interaction with compute logs.

test pass on nt -- see github pr

Tue, Jul 14, 6:19 PM
max accepted D3885: moving all top-level tests to general.
Tue, Jul 14, 6:13 PM
max updated the diff for D3881: Unit tests of IPC interrupt machinery & interaction with compute logs.

undebug

Tue, Jul 14, 6:08 PM
max updated the diff for D3881: Unit tests of IPC interrupt machinery & interaction with compute logs.

fix id parsing

Tue, Jul 14, 6:07 PM
max updated the diff for D3881: Unit tests of IPC interrupt machinery & interaction with compute logs.

lint

Tue, Jul 14, 5:58 PM
max updated the diff for D3881: Unit tests of IPC interrupt machinery & interaction with compute logs.

rebase

Tue, Jul 14, 5:57 PM
max updated the diff for D3881: Unit tests of IPC interrupt machinery & interaction with compute logs.

up

Tue, Jul 14, 5:55 PM