Page MenuHomePhabricator

max (Max Gasner)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2019, 5:20 PM (29 w, 2 d)

Recent Activity

Yesterday

max updated the diff for D1443: Resolves https://github.com/dagster-io/dagster/issues/1913.

Up

Sat, Nov 16, 7:03 PM
max accepted D1441: Kill is_secret.

this is fine, if we want to get rid of placeholders like this generally, but it's still something we are going to need to handle

Sat, Nov 16, 7:01 PM
max accepted D1440: Rename inner_type to tuple_types.
Sat, Nov 16, 7:00 PM
max added a comment to D1441: Kill is_secret.

hmm, consider also Path

Sat, Nov 16, 6:55 PM
max created D1443: Resolves https://github.com/dagster-io/dagster/issues/1913.
Sat, Nov 16, 5:20 AM

Fri, Nov 15

max accepted D1438: fix py27 test.
Fri, Nov 15, 9:50 PM
max added a comment to D1432: Introduce CompositeSolidExecutionResult.

i'm going to hold off on the abc, after some consideration, and give it some more consideration. it would be nice to get rid of the Union[] stuff in the docs, but if people click into the abc they won't see what methods are available on the results, since composite solid results and solid results implement different methods. in some ways composite solids are more like pipelines than they are like solids.

Fri, Nov 15, 6:57 PM
max added a comment to D1425: Kitchen sink tutorial pipeline.

It's tricky, because this *is* slightly different from all of the examples.

Fri, Nov 15, 12:54 AM
max updated the diff for D1419: Docs improvements.

Blk

Fri, Nov 15, 12:53 AM
max updated the diff for D1432: Introduce CompositeSolidExecutionResult.

Blk

Fri, Nov 15, 12:50 AM
max created D1432: Introduce CompositeSolidExecutionResult.
Fri, Nov 15, 12:41 AM

Thu, Nov 14

max created D1425: Kitchen sink tutorial pipeline.
Thu, Nov 14, 1:40 AM
max accepted D1416: [instance] support overrides.
Thu, Nov 14, 12:14 AM
max accepted D1396: Consolidate bay bike csv files into one csv file and upload to bucket resource.

not sure about this bucket api, please see comments. why not set_object(key, obj) and get_object(key)? maybe there's a missing upload_file api -- rn there's this odd asymmetry where we have set_object: str -> None and get_object: str -> blob (rather than set_object taking a blob and get_object giving one back)

Thu, Nov 14, 12:07 AM

Wed, Nov 13

max resigned from D1421: remove k8 operator.

I believe this is the right course of action until we get this under some form of test, will resign to @natekupp

Wed, Nov 13, 11:57 PM
max updated the diff for D1420: Fixes a nasty nondeterministic bug in preset construction from source files.

Ununiqueify

Wed, Nov 13, 10:07 PM
max updated the diff for D1420: Fixes a nasty nondeterministic bug in preset construction from source files.

Up

Wed, Nov 13, 9:47 PM
max created D1420: Fixes a nasty nondeterministic bug in preset construction from source files.
Wed, Nov 13, 9:47 PM
max created D1419: Docs improvements.
Wed, Nov 13, 9:38 PM
max added a comment to D1416: [instance] support overrides.

why limit it to local instances though?

Wed, Nov 13, 8:49 PM
max added a comment to D1416: [instance] support overrides.

ok. a short step from here to putting this in config!

Wed, Nov 13, 8:48 PM
max updated the diff for D1413: Provide example of type tests.

Rebase

Wed, Nov 13, 7:41 PM
max accepted D1415: Change image for displaying metadata type informaiton.
Wed, Nov 13, 7:13 PM
max requested changes to D1415: Change image for displaying metadata type informaiton.

Yikes! Should be custom_types_figure_one.png, which is already checked in

Wed, Nov 13, 7:09 PM
max added a comment to D1414: pin google-cloud-storage until they fix deps.

I think that, to be safe, we should pin to 'google-cloud-bigquery>=1.19.*,<=1.21.0', 'google-cloud-storage<1.23.0', 'google-resumable-media >= 0.3.1, != 0.4.0, < 0.5dev' and then release or run a post-release as soon as https://github.com/googleapis/google-cloud-python/issues/9786 is resolved

Wed, Nov 13, 6:26 PM
max accepted D1412: [instance] remove features system.

cc @sashank

Wed, Nov 13, 6:22 PM
max updated the diff for D1405: Improve airflow docs.

Up

Wed, Nov 13, 6:09 PM
max added a comment to D1412: [instance] remove features system.

I don't like the features system but I still think we need a way to feature-flag front-end functionality. Maybe it's about starting dagit with explicit flags?

Wed, Nov 13, 6:00 PM
max resigned from D1406: Make tutorial pytest files behave as if they are outside a package.
Wed, Nov 13, 5:59 PM
max added a comment to D1406: Make tutorial pytest files behave as if they are outside a package.

Per our conversation re: providing examples that users will mirror, let's abandon this in favor of https://dagster.phacility.com/D1408

Wed, Nov 13, 5:59 PM
max updated the diff for D1405: Improve airflow docs.

Webster

Wed, Nov 13, 5:55 PM
max updated the diff for D1405: Improve airflow docs.

Nits

Wed, Nov 13, 5:54 PM
max added inline comments to D1405: Improve airflow docs.
Wed, Nov 13, 5:51 PM
max updated the diff for D1413: Provide example of type tests.

Up

Wed, Nov 13, 5:43 PM
max created D1413: Provide example of type tests.
Wed, Nov 13, 5:35 PM
max updated the diff for D1392: RFC: Rationalize type check system.

py27

Wed, Nov 13, 12:45 AM
max added a reviewer for D1405: Improve airflow docs: schrockn.
Wed, Nov 13, 12:26 AM
max accepted D1409: Minor typo fixes to the tutorial.
Wed, Nov 13, 12:25 AM
max updated the diff for D1405: Improve airflow docs.

Nit

Wed, Nov 13, 12:24 AM
max accepted D1408: Merge test and code files in tutorial.
Wed, Nov 13, 12:24 AM
max updated the diff for D1405: Improve airflow docs.

Nits

Wed, Nov 13, 12:21 AM
max updated the diff for D1405: Improve airflow docs.

Up

Wed, Nov 13, 12:19 AM

Tue, Nov 12

max updated the diff for D1405: Improve airflow docs.

Up

Tue, Nov 12, 11:41 PM
max updated the diff for D1405: Improve airflow docs.

Up

Tue, Nov 12, 10:35 PM
max created D1405: Improve airflow docs.
Tue, Nov 12, 10:34 PM
max accepted D1403: publish fixes attempt 2.
Tue, Nov 12, 7:56 PM
max updated the diff for D1392: RFC: Rationalize type check system.

Nits

Tue, Nov 12, 7:38 PM
max accepted D1402: publish fixes.
Tue, Nov 12, 7:34 PM
max updated the diff for D1392: RFC: Rationalize type check system.

Nits

Tue, Nov 12, 7:11 PM
max added a comment to D1370: RFC: chain function for building strings of solids.

I also dislike the bitshift because I don't know which direction is which

Tue, Nov 12, 7:09 PM
max accepted D1355: Support run retry.
Tue, Nov 12, 7:09 PM
max requested changes to D1396: Consolidate bay bike csv files into one csv file and upload to bucket resource.

requesting changes on this to fix the implementation of the local bucket to work with s3 keys like foo/bar/baz

Tue, Nov 12, 7:03 PM
max accepted D1385: 0.6.4 release notes.
Tue, Nov 12, 6:57 PM
max added a comment to D1385: 0.6.4 release notes.

One more little thing, added check_dagster_type helper for testing custom types

Tue, Nov 12, 6:57 PM
max accepted D1400: [publish] fix audit and add to release checklist.
Tue, Nov 12, 6:55 PM
max updated the diff for D1401: Add audit check for versions.

Nits

Tue, Nov 12, 6:55 PM
max added inline comments to D1401: Add audit check for versions.
Tue, Nov 12, 6:53 PM
max added inline comments to D1401: Add audit check for versions.
Tue, Nov 12, 6:53 PM
max updated the diff for D1392: RFC: Rationalize type check system.

Up

Tue, Nov 12, 6:52 PM
max created D1401: Add audit check for versions.
Tue, Nov 12, 6:31 PM
max updated the diff for D1392: RFC: Rationalize type check system.

Up

Tue, Nov 12, 5:55 PM
max abandoned D1399: Prune Docker containers in Buildkite.
Tue, Nov 12, 5:42 PM

Mon, Nov 11

max created D1399: Prune Docker containers in Buildkite.
Mon, Nov 11, 11:25 PM
max updated the diff for D1392: RFC: Rationalize type check system.

Simplify further

Mon, Nov 11, 10:27 PM
max accepted D1397: [dagster-airflow] Minimize core dependencies.

this seems right

Mon, Nov 11, 9:45 PM
max added a comment to D1397: [dagster-airflow] Minimize core dependencies.

Do we need the enum-compat requirement at all? And can we drop the future pin?

Mon, Nov 11, 9:21 PM
max updated the diff for D1392: RFC: Rationalize type check system.

Rebase

Mon, Nov 11, 8:56 PM
max requested changes to D1396: Consolidate bay bike csv files into one csv file and upload to bucket resource.

i'd like to make sure this will work on windows

Mon, Nov 11, 8:54 PM
max updated the diff for D1389: Add check_dagster_type utility to enable unit-testing of custom types.

Up

Mon, Nov 11, 6:53 PM
max updated the diff for D1389: Add check_dagster_type utility to enable unit-testing of custom types.

Up

Mon, Nov 11, 6:44 PM
max updated the diff for D1389: Add check_dagster_type utility to enable unit-testing of custom types.

Up

Mon, Nov 11, 6:37 PM
max updated the diff for D1389: Add check_dagster_type utility to enable unit-testing of custom types.

Up

Mon, Nov 11, 6:33 PM
max updated the diff for D1392: RFC: Rationalize type check system.

Up

Mon, Nov 11, 6:26 PM
max updated the diff for D1392: RFC: Rationalize type check system.

Up

Mon, Nov 11, 6:13 PM

Fri, Nov 8

max updated the summary of D1392: RFC: Rationalize type check system.
Fri, Nov 8, 6:05 PM
max created D1392: RFC: Rationalize type check system.
Fri, Nov 8, 5:58 PM

Thu, Nov 7

max added inline comments to D1355: Support run retry.
Thu, Nov 7, 11:23 PM
max created D1389: Add check_dagster_type utility to enable unit-testing of custom types.
Thu, Nov 7, 11:21 PM
max updated the diff for D1383: Guard against inscrutable error messages when passing badly-behaved values in place of types.

Black

Thu, Nov 7, 11:12 PM
max updated the diff for D1388: Add basic test docs.

Up

Thu, Nov 7, 11:11 PM
max updated the diff for D1383: Guard against inscrutable error messages when passing badly-behaved values in place of types.

Nits

Thu, Nov 7, 11:05 PM
max added a comment to D1385: 0.6.4 release notes.

reexecution config changes? scheduler errors in dagit? D1372?

Thu, Nov 7, 10:55 PM
max updated the diff for D1388: Add basic test docs.

Isort

Thu, Nov 7, 10:50 PM
max added inline comments to D1383: Guard against inscrutable error messages when passing badly-behaved values in place of types.
Thu, Nov 7, 10:49 PM
max updated the diff for D1388: Add basic test docs.

Blk

Thu, Nov 7, 10:47 PM
max updated the diff for D1383: Guard against inscrutable error messages when passing badly-behaved values in place of types.

Nits

Thu, Nov 7, 10:47 PM
max added inline comments to D1383: Guard against inscrutable error messages when passing badly-behaved values in place of types.
Thu, Nov 7, 10:38 PM
max created D1388: Add basic test docs.
Thu, Nov 7, 10:36 PM
max accepted D1371: fix terminate in multiprocess engine.

so fresh and clean

Thu, Nov 7, 9:51 PM
max updated the diff for D1383: Guard against inscrutable error messages when passing badly-behaved values in place of types.

py27

Thu, Nov 7, 9:47 PM
max updated the diff for D1383: Guard against inscrutable error messages when passing badly-behaved values in place of types.

py27

Thu, Nov 7, 9:41 PM
max accepted D1379: remove unused examples/requirements.txt file.

Hooray

Thu, Nov 7, 7:46 PM
max updated the diff for D1383: Guard against inscrutable error messages when passing badly-behaved values in place of types.

Up

Thu, Nov 7, 7:45 PM
max updated the diff for D1383: Guard against inscrutable error messages when passing badly-behaved values in place of types.

Up

Thu, Nov 7, 7:43 PM
max updated the diff for D1382: Reorganize type mapping.

Nits

Thu, Nov 7, 7:43 PM
max updated the diff for D1383: Guard against inscrutable error messages when passing badly-behaved values in place of types.

Black

Thu, Nov 7, 7:37 PM
max updated the diff for D1382: Reorganize type mapping.

Black

Thu, Nov 7, 7:36 PM
max created D1383: Guard against inscrutable error messages when passing badly-behaved values in place of types.
Thu, Nov 7, 7:29 PM
max abandoned D1365: Guard against inscrutable error messages when passing badly-behaved values in place of types.

Less fragile solution to follow on D1382

Thu, Nov 7, 7:02 PM
max created D1382: Reorganize type mapping.
Thu, Nov 7, 7:01 PM