Page MenuHomePhabricator

max (Max Gasner)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2019, 5:20 PM (77 w, 6 d)
Roles
Administrator

Recent Activity

Yesterday

max abandoned D4857: Actually fall back to repo root in automation machinery.
Wed, Oct 21, 9:51 PM
max updated the diff for D4857: Actually fall back to repo root in automation machinery.

try to fix?

Wed, Oct 21, 9:49 PM
max added a comment to D4857: Actually fall back to repo root in automation machinery.

oh yeah this is totally out of sync sorry

Wed, Oct 21, 9:48 PM
max accepted D4764: add summary table for asset keys.
Wed, Oct 21, 9:47 PM
max requested review of D4857: Actually fall back to repo root in automation machinery.

transient failure in unrelated scheduler tests

Wed, Oct 21, 7:12 PM
max added inline comments to D4764: add summary table for asset keys.
Wed, Oct 21, 6:49 PM
max added inline comments to D4764: add summary table for asset keys.
Wed, Oct 21, 3:53 PM
max requested changes to D4797: Support slackclient 2.x when the python version is 3.x.

i agree this should be python3 only, and we shouldn't attempt to support the old api. @schrockn dwall has effectively had to write his own dagster-slack library because of this.

Wed, Oct 21, 3:50 PM
max accepted D4846: Move bad names from warnings to hard errors.

i'm into this, see comment about warning

Wed, Oct 21, 3:48 PM
max added inline comments to D4846: Move bad names from warnings to hard errors.
Wed, Oct 21, 3:47 PM

Tue, Oct 20

max closed D4833: Lint.
Tue, Oct 20, 6:36 PM
max committed R1:db6fc6467d3e: Lint (authored by max).
Lint
Tue, Oct 20, 6:35 PM
max requested review of D4833: Lint.
Tue, Oct 20, 6:28 PM
max closed D4822: serialization safety.
Tue, Oct 20, 3:25 PM
max committed R1:77f3ec8fba9e: serialization safety (authored by max).
serialization safety
Tue, Oct 20, 3:25 PM
max updated the diff for D4822: serialization safety.

fix type hints

Tue, Oct 20, 2:59 PM

Mon, Oct 19

max requested review of D4822: serialization safety.
Mon, Oct 19, 11:13 PM
max added inline comments to D4764: add summary table for asset keys.
Mon, Oct 19, 11:07 PM
max accepted D4763: remove selector from tutorial.

can you open an issue to intro selector in docs

Mon, Oct 19, 10:52 PM
max closed D4816: Stream dbt logs and re-log messages.
Mon, Oct 19, 10:43 PM
max committed R1:4826cabaf027: Stream dbt logs and re-log messages (authored by max).
Stream dbt logs and re-log messages
Mon, Oct 19, 10:43 PM
max requested review of D4816: Stream dbt logs and re-log messages.
Mon, Oct 19, 8:42 PM

Wed, Oct 14

max accepted D4772: steps towards getting ECSRunLauncher working.

you only live twice

Wed, Oct 14, 5:02 PM

Tue, Oct 13

max accepted D4610: Creates data classes for dbt run results..

let's merge this and proceed

Tue, Oct 13, 8:19 PM

Fri, Oct 9

max added a comment to D4736: [RFC] DagsterInstance.optimize_for_dagit.

I think we need a test that spins up like, several dozen instances pointed at a single psql

Fri, Oct 9, 7:28 PM
max accepted D4724: Adds checks for float and int elements..
Fri, Oct 9, 7:26 PM
max accepted D4733: test_addresses_for_version wasn't running.
Fri, Oct 9, 7:21 PM
max accepted D4740: disable flaky launcher tests on windows.
Fri, Oct 9, 3:31 PM

Thu, Oct 8

max closed D4699: Reorganize ge_example.
Thu, Oct 8, 2:12 PM
max committed R1:935a5ea83fe6: Reorganize ge_example (authored by max).
Reorganize ge_example
Thu, Oct 8, 2:11 PM
max updated the diff for D4699: Reorganize ge_example.

fix workspace

Thu, Oct 8, 12:59 PM

Wed, Oct 7

max requested review of D4708: Improve the error message when loading an empty workspace.yaml.
Wed, Oct 7, 9:08 PM
max added reviewers for D4699: Reorganize ge_example: nate, cdecarolis.
Wed, Oct 7, 8:25 PM
max closed D4701: Fix highlighting and use markers for literal includes.
Wed, Oct 7, 6:35 PM
max committed R1:59de85dfce42: Fix highlighting and use markers for literal includes (authored by max).
Fix highlighting and use markers for literal includes
Wed, Oct 7, 6:35 PM
max closed D4703: Fix GE tests.
Wed, Oct 7, 6:04 PM
max committed R1:1c4084872b51: Fix GE tests (authored by max).
Fix GE tests
Wed, Oct 7, 6:04 PM
max added reviewers for D4703: Fix GE tests: alangenfeld, sashank, nate, yuhan, sandyryza, dgibson.
Wed, Oct 7, 5:58 PM
max requested review of D4703: Fix GE tests.
Wed, Oct 7, 5:57 PM
max requested review of D4699: Reorganize ge_example.
Wed, Oct 7, 4:52 PM
max added inline comments to D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.
Wed, Oct 7, 4:35 PM
max requested review of D4701: Fix highlighting and use markers for literal includes.
Wed, Oct 7, 3:49 PM
max added inline comments to D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.
Wed, Oct 7, 3:47 PM
max added a comment to D4665: Show a screenshot of the error as it displays in dagit for Complex Type Checks.

Are we trying to do this for every error message?

Wed, Oct 7, 3:44 PM
max requested changes to D4645: Add Code Snippet for Metadata and custom Type Checks.

This is ok as a standalone change, req'ing changes for discussion. Do we want to provide config for *all* of the examples on this page? If not, why not? Seems inconsistent.

Wed, Oct 7, 2:49 PM
max requested changes to D4643: Modify Making Your Pipelines Testable in Docs.
Wed, Oct 7, 2:41 PM
max requested changes to D4641: Replace custom_types_figure_one image to highlight SimpleDataFrame.
Wed, Oct 7, 2:40 PM
max added a comment to D4641: Replace custom_types_figure_one image to highlight SimpleDataFrame.

this is fine as a standalone change, i am requesting changes just so we can discuss some of the broader issues. if we are going to use this green circle highlight idiom, we should use it elsewhere in the tutorial as well - it doesn't really make sense for this to be the only screenshot with salient elements highlighted. i also think we need a plan for how we're going to recreate these screenshots when the UI changes. the previous screenshots were generated automatically using a script: https://github.com/dagster-io/dagster/blob/master/docs/generate_screenshots.test.js -- if we aren't going to update this script to generate the highlights as well, i think we should consider writing instructions for whatever manual work is required to highlight the screenshots.

Wed, Oct 7, 2:40 PM
max requested changes to D4610: Creates data classes for dbt run results..
Wed, Oct 7, 2:35 PM

Fri, Oct 2

max committed R1:cd842386785b: [Docs] 0.9.13 (authored by max).
[Docs] 0.9.13
Fri, Oct 2, 8:41 PM
max committed R1:5361daa047cf: 0.9.13 (authored by max).
0.9.13
Fri, Oct 2, 8:12 PM
max committed R1:60f78cf336cd: 0.9.13.pre0 (authored by max).
0.9.13.pre0
Fri, Oct 2, 8:04 PM
max closed D4654: Changes for 0.9.13.
Fri, Oct 2, 7:57 PM
max committed R1:6db79178c5af: Changes for 0.9.13 (authored by max).
Changes for 0.9.13
Fri, Oct 2, 7:57 PM
max accepted D4648: Changed the title of Tutorials to Before We Start.
Fri, Oct 2, 7:24 PM
max requested changes to D4645: Add Code Snippet for Metadata and custom Type Checks.
Fri, Oct 2, 6:01 PM
max accepted D4642: Remind the user of add config to launch execution and update ERROR message for running custom_types_2.py.
Fri, Oct 2, 6:00 PM
max accepted D4644: Replace the previous img which displays unwanted keyboard shortcuts.
Fri, Oct 2, 5:58 PM
max requested changes to D4643: Modify Making Your Pipelines Testable in Docs.
Fri, Oct 2, 5:58 PM
max requested changes to D4610: Creates data classes for dbt run results..

must fix the TODOs

Fri, Oct 2, 5:51 PM
max requested changes to D4641: Replace custom_types_figure_one image to highlight SimpleDataFrame.
Fri, Oct 2, 5:43 PM
max requested changes to D4607: Fix Docs Small Bugs in Dagster Types Chapter.
Fri, Oct 2, 5:43 PM
max requested changes to D4619: Modify Making Your Pipelines Testable in Docs.

seems like this includes a bunch of changes from D4607, you may need to rebase for a clean diff

Fri, Oct 2, 12:47 PM
max requested changes to D4607: Fix Docs Small Bugs in Dagster Types Chapter.

not sure why we're changing the names of these images

Fri, Oct 2, 12:47 PM
max closed D4571: Fix serdes for CustomPointer.
Fri, Oct 2, 12:43 PM
max committed R1:8bed4e384635: Fix serdes for CustomPointer (authored by max).
Fix serdes for CustomPointer
Fri, Oct 2, 12:43 PM

Thu, Oct 1

max updated the diff for D4571: Fix serdes for CustomPointer.

Rebase

Thu, Oct 1, 5:05 PM
max added inline comments to D4571: Fix serdes for CustomPointer.
Thu, Oct 1, 5:04 PM
max updated the diff for D4571: Fix serdes for CustomPointer.

respond to feedback

Thu, Oct 1, 5:04 PM

Mon, Sep 28

max requested review of D4571: Fix serdes for CustomPointer.
Mon, Sep 28, 5:07 PM

Sep 21 2020

max accepted D4336: Add dbt cli module.
Sep 21 2020, 4:12 PM

Sep 17 2020

max requested changes to D4336: Add dbt cli module.

This is great, I mostly only have nits and suggestions for future rationalization/consolidation. It seems like we are all in agreement about a solid factory-based approach going forward. I'd like to see the documentation for config options be a little more pedantic here, and I think we should mark the new APIs as @experimental. The only thing that really needs to change before this lands is that we can't claim support for 2.7 while we have py3 typing syntax in the codebase and are not testing on py2. i'm requesting changes for this only. i do think the return values from these solids are a little bit particular, but i don't think that matters if the APIs are marked as experimental.

Sep 17 2020, 8:30 PM

Sep 3 2020

max accepted D4333: [dagstermill] open notebooks with 'rb'.
Sep 3 2020, 8:18 PM
max added a comment to D4333: [dagstermill] open notebooks with 'rb'.

Would be nice to have a test case with s3 storage

Sep 3 2020, 8:18 PM

Aug 27 2020

max committed R1:bb4d9447fa54: Add custom reconstructable (authored by max).
Add custom reconstructable
Aug 27 2020, 9:38 PM
max closed D4293: Add custom reconstructable.
Aug 27 2020, 9:38 PM
max updated the diff for D4293: Add custom reconstructable.

fix import

Aug 27 2020, 8:55 PM
max updated the diff for D4293: Add custom reconstructable.

rename to build_reconstructable_pipeline

Aug 27 2020, 8:40 PM
max requested review of D4293: Add custom reconstructable.
Aug 27 2020, 8:26 PM

Aug 20 2020

max accepted D4245: grpc pylint workaround.
Aug 20 2020, 8:58 PM
max accepted D4203: ge tutorial.
Aug 20 2020, 8:54 PM
alangenfeld empowered max as an administrator.
Aug 20 2020, 7:19 PM
max requested changes to D4203: ge tutorial.
Aug 20 2020, 6:55 PM
max added inline comments to D4203: ge tutorial.
Aug 20 2020, 6:55 PM
max added a comment to D4184: Use run tags table to store grpc client information to support termination.

conceivably we should also hide the existing "system" tags (dagster/...) in the follow-on.

Aug 20 2020, 6:46 PM
max accepted D4018: putting finishing touches on GE.
Aug 20 2020, 6:44 PM
max accepted D4204: error message fix.
Aug 20 2020, 6:42 PM

Aug 19 2020

max added inline comments to D4199: RFC: @dagster_type decorator.
Aug 19 2020, 9:06 PM

Aug 17 2020

max committed R1:c44cd0d79bf0: Improve error msg (authored by max).
Improve error msg
Aug 17 2020, 8:25 PM
max closed D4201: Improve error msg.
Aug 17 2020, 8:25 PM
max added a comment to D3981: [2] run-scoped file manager resources.

are the test failures real? also, docs for GCS and ADLS2?

Aug 17 2020, 2:24 PM
max added a comment to D3981: [2] run-scoped file manager resources.

this looks great, i think i agree with sandy that this is preferable to non-run-scoped.

Aug 17 2020, 2:24 PM
max accepted D4181: adding union to base.
Aug 17 2020, 2:11 PM
max requested review of D4199: RFC: @dagster_type decorator.
Aug 17 2020, 2:00 PM
max requested review of D4201: Improve error msg.
Aug 17 2020, 1:49 PM
max added a comment to D4171: first run of hooks on expectations.

do hooks have a concept of should_execute, like schedules? seems like having an explicit filter would be helpful once we're talking about events that may be fired n times

Aug 17 2020, 1:30 PM
max added a comment to D4184: Use run tags table to store grpc client information to support termination.

I agree with Alex -- esp as more state management stuff is coming down the chute that *def* doesn't belong in tags

Aug 17 2020, 1:29 PM
max resigned from D4163: Turn on auto-formatting for string literals in black.

I found some nice pictures of bikesheds online that we should probably consider.

Aug 17 2020, 1:25 PM
max requested changes to D4181: adding union to base.

requesting changes for docstring

Aug 17 2020, 1:24 PM

Aug 14 2020

max added a comment to D4018: putting finishing touches on GE.

woww

Aug 14 2020, 6:03 PM