e.g. describing the lifecycle

i think docstrings on the base class would make this easier to navigate

i think the enum solution is the cleanest here; it certainly adds API surface but if we retain backcompatibility with the old list of strings, that feels fine -- it adds API surface in lockstep with new functionality

i like alex's renaming suggestion

I don't personally love pre-commit hooks but if we do this we should think about also adding mypy, isort

up

irrelevant stochastic test failure in dagster pandas

i think this is marginal -- it is really expected to be imported after the package so there's a case for making it absolute. i am just following the existing pattern later in this file though

Unrelated test setup failure due to ongoing release.

i agree with alex and think this is just great

does this work with a log line emitted by a solid that isn't defined inline (but loaded from a file/module); does this work with log lines emitted by libraries called by solids?

This definitely looks cleaner than the last time I tried it. I'd want to see ~100 test runs succeed before approving this. The failure above might be due to a conflict with the GRPC generation test, test_compiled_protobuf, which could definitely be isolated but is definitely not isolated at present. As you've discovered, the big wins in test time will come from more intelligent use of fixtures and from writing more true unit tests, not from multiprocessing.

what about sid's comment on https://github.com/dagster-io/dagster/issues/3858?

I think I agree that another layer of indirection would be nice here, with e.g. get_additional_tags_for_run(pipeline_run) on the custom instance, and then the implementation of that calling the auth manager. i also think it makes sense to call this auth manager something like FlaskAuthManager

thank you, this is great

rebase

up

add comment

rebase

blk

up

rebase

blk

rebase on D8104

rebase on D8104

merge when tests pass

rebase

rebase

+1 when tests pass

rebase

up

up

up

up

omg

escape

escape

up

escape

omg

up

up