Page MenuHomePhabricator

max (Max Gasner)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2019, 5:20 PM (57 w, 2 d)

Recent Activity

Fri, May 29

max requested changes to D3122: (dagit-out-of-process-2) Add method to get external pipeline w/ API.

Can we also test the error handling path?

Fri, May 29, 11:56 PM
max accepted D3160: Fix scheduler path.
Fri, May 29, 4:27 PM
max accepted D3110: [0.7.15] Isolate updating scheduler state from updating cron tab.

let's look at coverage through the dagster-cron tests and then merge this if those are ok. this is not ideal but i see there are reasons for trying to ship it.

Fri, May 29, 12:27 AM
max added a comment to D3110: [0.7.15] Isolate updating scheduler state from updating cron tab.

what I would like to see here is 100% branch coverage on the code in scheduler.py

Fri, May 29, 12:20 AM

Thu, May 28

max committed R1:8fff8be7901f: 6/ Make dagster api execute_run take repository target arguments (authored by max).
6/ Make dagster api execute_run take repository target arguments
Thu, May 28, 7:30 PM
max closed D3069: 6/ Make dagster api execute_run take repository target arguments.
Thu, May 28, 7:30 PM
max requested review of D3069: 6/ Make dagster api execute_run take repository target arguments.
Thu, May 28, 6:29 PM
max committed R1:1b24de2a86db: Reenable test (authored by max).
Reenable test
Thu, May 28, 5:16 PM
max closed D3134: Reenable test.
Thu, May 28, 5:16 PM
max committed R1:e5c809203208: Reorganize decorators (authored by max).
Reorganize decorators
Thu, May 28, 2:16 AM
max closed D3137: Reorganize decorators.
Thu, May 28, 2:16 AM
max requested review of D3137: Reorganize decorators.
Thu, May 28, 12:24 AM
max accepted D3113: selector 2/ allow solid_subset to take DSL syntax in python api execute_pipeline and execute_pipeline_iterator.
Thu, May 28, 12:00 AM

Wed, May 27

max accepted D3112: selector 1/ subselection query to solid_subset.
Wed, May 27, 11:59 PM
max requested review of D3134: Reenable test.
Wed, May 27, 11:19 PM
max added a comment to D3123: [WIP] (dagit-out-of-process-3) Implement get_external_pipeline for OutOfProcessDagsterEnvironment.

I think the sync APIs really would be better served by using check_output

Wed, May 27, 6:15 PM
max added a comment to D3116: [graphql-environment-2] add graphql endpoints for Environment.

We should memorialize our discussion from this morning & future plans in a comment in code somewhere I think

Wed, May 27, 6:14 PM
max accepted D3115: Remove duplicated code in buildkite pipeline.py.
Wed, May 27, 5:59 PM
max requested changes to D3113: selector 2/ allow solid_subset to take DSL syntax in python api execute_pipeline and execute_pipeline_iterator.

this is great, i'd like to see a more exhaustive set of test cases (incl. multiple clauses, multiple overlapping clauses, and in the presence of composites)

Wed, May 27, 5:53 PM
max requested changes to D3112: selector 1/ subselection query to solid_subset.

requesting changes for dedupe and the docstring which is a little out of sync with the actual signature

Wed, May 27, 5:50 PM
max requested changes to D3122: (dagit-out-of-process-2) Add method to get external pipeline w/ API.

requesting changes to surface the subprocess error info

Wed, May 27, 4:50 PM
max added inline comments to D3122: (dagit-out-of-process-2) Add method to get external pipeline w/ API.
Wed, May 27, 4:49 PM
max added inline comments to D3115: Remove duplicated code in buildkite pipeline.py.
Wed, May 27, 4:46 PM
max requested changes to D3115: Remove duplicated code in buildkite pipeline.py.

requesting changes for clarifying comments in the docstring, this is great

Wed, May 27, 4:45 PM
max requested changes to D3110: [0.7.15] Isolate updating scheduler state from updating cron tab.
Wed, May 27, 4:28 PM
max added inline comments to D3110: [0.7.15] Isolate updating scheduler state from updating cron tab.
Wed, May 27, 4:28 PM

Tue, May 26

max committed R1:f11074c1d4b8: 2/ Add description field to RepositoryDefinition (authored by max).
2/ Add description field to RepositoryDefinition
Tue, May 26, 7:14 PM
max closed D3059: 2/ Add description field to RepositoryDefinition.
Tue, May 26, 7:14 PM
max added a comment to D3066: 3/ Introduce @repository decorator.

i'm not sure i understand what you have in mind here - are you looking for lazy evaluation of objects other than pipeline definitions?

Tue, May 26, 7:12 PM
max added inline comments to D3074: (graphql-context-test-suite-2) Add graphql_context_test_suite.
Tue, May 26, 6:19 PM

Fri, May 22

max accepted D3060: [dagit] shift-click to multi select steps #2470.

ah, hooray this is so good

Fri, May 22, 11:58 PM
max accepted D3065: run grouping - persist step selection query in tags.

ok for now

Fri, May 22, 11:58 PM
max requested review of D3066: 3/ Introduce @repository decorator.
Fri, May 22, 11:20 PM
max requested review of D3059: 2/ Add description field to RepositoryDefinition.
Fri, May 22, 11:20 PM
max accepted D3051: (dagster-cli-api-run-launcher-6) Make cli api run launcher configurable class.
Fri, May 22, 7:00 PM
max accepted D3045: (dagster-cli-api-run-launcher-7) Add APIs to RunLauncher for termination support.
Fri, May 22, 5:47 PM
max accepted D3046: [dagit] make log filter follow the step selection DSL #2472.
Fri, May 22, 5:41 PM
max added a comment to D3046: [dagit] make log filter follow the step selection DSL #2472.

this looks great to me, seems like a straightforward improvement. i have a slight preference for the approach you've rejected of allowing multi-selection & reflecting it in the filter query

Fri, May 22, 5:41 PM
max accepted D3038: (dagster-cli-api-run-launcher-5) Make subset execution work over cli api.
Fri, May 22, 5:38 PM
max accepted D3012: (dagster-cli-api-run-launcher-4) Add engine events to the cli codepath.

lgtm

Fri, May 22, 5:37 PM
max committed R1:ca194f36d445: 1/ Add helpers to get cli args from reconstructables (authored by max).
1/ Add helpers to get cli args from reconstructables
Fri, May 22, 5:34 PM
max closed D3031: 1/ Add helpers to get cli args from reconstructables.
Fri, May 22, 5:34 PM
max committed R1:350940be0f11: Clarify behavior when a schedule with a given name is not found in a repository (authored by max).
Clarify behavior when a schedule with a given name is not found in a repository
Fri, May 22, 5:34 PM
max closed D3030: Clarify behavior when a schedule with a given name is not found in a repository.
Fri, May 22, 5:34 PM

Thu, May 21

max requested review of D3031: 1/ Add helpers to get cli args from reconstructables.
Thu, May 21, 7:42 PM
max accepted D3020: Add Airflow issue comment.

this is fine, the issue is a dupe

Thu, May 21, 7:33 PM
max requested review of D3030: Clarify behavior when a schedule with a given name is not found in a repository.
Thu, May 21, 7:28 PM
max accepted D3023: Delete container-based loading for now.
Thu, May 21, 5:12 PM

Wed, May 20

max accepted D3015: [0.7.14] dagit enable multi-step re-execution via step subset selector.

this is so delightful

Wed, May 20, 10:36 PM
max resigned from D2923: Delete all non *orError accessors.

this lgtm, i will let @bengotow have the final word

Wed, May 20, 10:35 PM
max accepted D3008: (dagster-cli-api-run-launcher-1) Move RunLauncher to base.py.
Wed, May 20, 8:57 PM
max accepted D2984: [0.7.14] Add tooltip for disabled re-executions.
Wed, May 20, 8:57 PM
max accepted D2947: RFC - a way to run multiproc engine without sqlite event log.

hooray

Wed, May 20, 8:56 PM

Mon, May 18

max added a comment to D2879: RFC: Composite solid subselection.

Just for the avoidance of doubt, I agree with Alex and I think this is clearer and more consistent than the alternative

Mon, May 18, 11:03 PM
max accepted D2981: dagit run viewer - step text label unselectable #2471.
Mon, May 18, 11:01 PM
max added a comment to D2981: dagit run viewer - step text label unselectable #2471.

ah, hooray!!

Mon, May 18, 11:01 PM
max added a comment to D2959: [dagit] enable multi-step re-execution via step subset selector #2453.

I think this is a huge step forwards but will defer to @schrockn for ultimate sign off

Mon, May 18, 11:01 PM
max committed R1:30ca1be7907f: Add tooltip for disabled re-executions (authored by max).
Add tooltip for disabled re-executions
Mon, May 18, 10:52 PM
max closed D2969: Add tooltip for disabled re-executions.
Mon, May 18, 10:52 PM
max committed R1:701114c493d6: GraphQL query for run groupings (authored by max).
GraphQL query for run groupings
Mon, May 18, 10:52 PM
max closed D2470: GraphQL query for run groupings.
Mon, May 18, 10:52 PM
max committed R1:b62fa44a31ae: Add query to get runs grouped by root run id (authored by max).
Add query to get runs grouped by root run id
Mon, May 18, 10:51 PM
max closed D2444: Add query to get runs grouped by root run id.
Mon, May 18, 10:51 PM
max updated the diff for D2969: Add tooltip for disabled re-executions.

Add tooltip for Open in Playground

Mon, May 18, 10:09 PM
max added a comment to D2969: Add tooltip for disabled re-executions.

yes brilliant

Mon, May 18, 9:22 PM
max requested review of D2969: Add tooltip for disabled re-executions.
Mon, May 18, 4:44 PM
max updated the diff for D2470: GraphQL query for run groupings.

Rebase

Mon, May 18, 4:27 AM
max updated the diff for D2444: Add query to get runs grouped by root run id.

Improve tests

Mon, May 18, 4:17 AM

Sat, May 16

max committed R1:116800d1226c: Add bash_solid (authored by max).
Add bash_solid
Sat, May 16, 10:40 PM
max closed D2964: Add bash_solid.
Sat, May 16, 10:40 PM
max requested review of D2964: Add bash_solid.
Sat, May 16, 12:28 AM

Fri, May 15

max accepted D2918: Remove _object methods from IntermediateStore.
Fri, May 15, 4:27 PM
max added a comment to D2959: [dagit] enable multi-step re-execution via step subset selector #2453.

I *really* like the second interaction; maybe we can talk about the first on this morning's call. It does feel a little hard to clear the subset selection.

Fri, May 15, 4:26 PM
max added inline comments to D2444: Add query to get runs grouped by root run id.
Fri, May 15, 4:23 PM
max added a comment to D2444: Add query to get runs grouped by root run id.

@yuhan I think this observes those semantics, will add a test to demonstrate

Fri, May 15, 4:22 PM

Thu, May 14

max committed R1:67b9a728097f: Use external classes in compute_step_keys_to_execute (authored by max).
Use external classes in compute_step_keys_to_execute
Thu, May 14, 10:58 PM
max closed D2945: Use external classes in compute_step_keys_to_execute.
Thu, May 14, 10:58 PM
max updated the diff for D2945: Use external classes in compute_step_keys_to_execute.

add comment and reference to issue

Thu, May 14, 10:25 PM
max accepted D2950: Restructure dagster-graphql tests to control context lifecycle.
Thu, May 14, 10:18 PM
max added a comment to D2950: Restructure dagster-graphql tests to control context lifecycle.

sweet, this is much better

Thu, May 14, 10:18 PM
max requested review of D2945: Use external classes in compute_step_keys_to_execute.
Thu, May 14, 9:02 PM
max added a comment to D2444: Add query to get runs grouped by root run id.

I just expanded the discussion of alternatives in the comments, but I'll expand on it here.

Thu, May 14, 6:57 PM
max added inline comments to D2923: Delete all non *orError accessors.
Thu, May 14, 6:44 PM
max updated the diff for D2470: GraphQL query for run groupings.

generate schema

Thu, May 14, 6:38 PM
max updated the diff for D2470: GraphQL query for run groupings.

feedback

Thu, May 14, 2:53 AM
max updated the diff for D2879: RFC: Composite solid subselection.

Add comments

Thu, May 14, 2:43 AM
max added inline comments to D2879: RFC: Composite solid subselection.
Thu, May 14, 1:34 AM
max updated the diff for D2879: RFC: Composite solid subselection.

nits

Thu, May 14, 1:34 AM
max updated the diff for D2470: GraphQL query for run groupings.

schema

Thu, May 14, 1:26 AM
max planned changes to D2470: GraphQL query for run groupings.
Thu, May 14, 1:19 AM
max updated the diff for D2470: GraphQL query for run groupings.

fixup

Thu, May 14, 1:19 AM
max added inline comments to D2444: Add query to get runs grouped by root run id.
Thu, May 14, 12:58 AM
max requested review of D2444: Add query to get runs grouped by root run id.

Reopening this for comment, now with pseudosql in the comments as well as more color on why I still think this is the right way to do it.

Thu, May 14, 12:48 AM
max added a reviewer for D2444: Add query to get runs grouped by root run id: alangenfeld.
Thu, May 14, 12:48 AM
max planned changes to D2444: Add query to get runs grouped by root run id.
Thu, May 14, 12:44 AM
max updated the diff for D2444: Add query to get runs grouped by root run id.

Rebase

Thu, May 14, 12:44 AM

Wed, May 13

max commandeered D2444: Add query to get runs grouped by root run id.
Wed, May 13, 8:00 PM
max accepted D2887: improve reconstructable().

still think it would be nice if @pipeline gave you this for free

Wed, May 13, 7:15 PM
max commandeered D2470: GraphQL query for run groupings.
Wed, May 13, 6:59 PM
max added inline comments to D2879: RFC: Composite solid subselection.
Wed, May 13, 6:48 PM