User Details
- User Since
- Apr 25 2019, 5:20 PM (214 w, 6 d)
- Roles
- Administrator, Disabled
Aug 27 2021
Aug 26 2021
Jul 22 2021
Jul 21 2021
e.g. describing the lifecycle
i think docstrings on the base class would make this easier to navigate
i think the enum solution is the cleanest here; it certainly adds API surface but if we retain backcompatibility with the old list of strings, that feels fine -- it adds API surface in lockstep with new functionality
i like alex's renaming suggestion
Jul 19 2021
Jul 9 2021
Jul 8 2021
Jul 7 2021
I don't personally love pre-commit hooks but if we do this we should think about also adding mypy, isort
Jul 4 2021
Jul 3 2021
irrelevant stochastic test failure in dagster pandas
Jul 2 2021
i think this is marginal -- it is really expected to be imported after the package so there's a case for making it absolute. i am just following the existing pattern later in this file though
Jun 28 2021
Jun 24 2021
Unrelated test setup failure due to ongoing release.
Jun 4 2021
i agree with alex and think this is just great
Jun 3 2021
does this work with a log line emitted by a solid that isn't defined inline (but loaded from a file/module); does this work with log lines emitted by libraries called by solids?
Jun 2 2021
This definitely looks cleaner than the last time I tried it. I'd want to see ~100 test runs succeed before approving this. The failure above might be due to a conflict with the GRPC generation test, test_compiled_protobuf, which could definitely be isolated but is definitely not isolated at present. As you've discovered, the big wins in test time will come from more intelligent use of fixtures and from writing more true unit tests, not from multiprocessing.
what about sid's comment on https://github.com/dagster-io/dagster/issues/3858?
May 27 2021
May 26 2021
I think I agree that another layer of indirection would be nice here, with e.g. get_additional_tags_for_run(pipeline_run) on the custom instance, and then the implementation of that calling the auth manager. i also think it makes sense to call this auth manager something like FlaskAuthManager
thank you, this is great
May 25 2021
rebase
+1 when tests pass