- User Since
- Apr 25 2019, 5:20 PM (77 w, 6 d)
try to fix?
oh yeah this is totally out of sync sorry
transient failure in unrelated scheduler tests
i agree this should be python3 only, and we shouldn't attempt to support the old api. @schrockn dwall has effectively had to write his own dagster-slack library because of this.
i'm into this, see comment about warning
Tue, Oct 20
Mon, Oct 19
can you open an issue to intro selector in docs
Wed, Oct 14
you only live twice
Tue, Oct 13
let's merge this and proceed
Fri, Oct 9
I think we need a test that spins up like, several dozen instances pointed at a single psql
Thu, Oct 8
Wed, Oct 7
Are we trying to do this for every error message?
This is ok as a standalone change, req'ing changes for discussion. Do we want to provide config for *all* of the examples on this page? If not, why not? Seems inconsistent.
this is fine as a standalone change, i am requesting changes just so we can discuss some of the broader issues. if we are going to use this green circle highlight idiom, we should use it elsewhere in the tutorial as well - it doesn't really make sense for this to be the only screenshot with salient elements highlighted. i also think we need a plan for how we're going to recreate these screenshots when the UI changes. the previous screenshots were generated automatically using a script: https://github.com/dagster-io/dagster/blob/master/docs/generate_screenshots.test.js -- if we aren't going to update this script to generate the highlights as well, i think we should consider writing instructions for whatever manual work is required to highlight the screenshots.
Fri, Oct 2
must fix the TODOs
seems like this includes a bunch of changes from D4607, you may need to rebase for a clean diff
not sure why we're changing the names of these images
Thu, Oct 1
Mon, Sep 28
Sep 21 2020
Sep 17 2020
This is great, I mostly only have nits and suggestions for future rationalization/consolidation. It seems like we are all in agreement about a solid factory-based approach going forward. I'd like to see the documentation for config options be a little more pedantic here, and I think we should mark the new APIs as @experimental. The only thing that really needs to change before this lands is that we can't claim support for 2.7 while we have py3 typing syntax in the codebase and are not testing on py2. i'm requesting changes for this only. i do think the return values from these solids are a little bit particular, but i don't think that matters if the APIs are marked as experimental.
Sep 3 2020
Would be nice to have a test case with s3 storage
Aug 27 2020
rename to build_reconstructable_pipeline
Aug 20 2020
conceivably we should also hide the existing "system" tags (dagster/...) in the follow-on.
Aug 19 2020
Aug 17 2020
are the test failures real? also, docs for GCS and ADLS2?
this looks great, i think i agree with sandy that this is preferable to non-run-scoped.
do hooks have a concept of should_execute, like schedules? seems like having an explicit filter would be helpful once we're talking about events that may be fired n times
I agree with Alex -- esp as more state management stuff is coming down the chute that *def* doesn't belong in tags
I found some nice pictures of bikesheds online that we should probably consider.
requesting changes for docstring