Page MenuHomePhabricator

leoeer (Leor Fishman)
Disabled

Projects

User does not belong to any projects.

User Details

User Since
Jun 1 2020, 7:56 PM (20 w, 2 d)
Roles
Disabled

Recent Activity

Aug 24 2020

leoeer added inline comments to D4178: made it unnecessary to require run config for storages when the storage has no config schema..
Aug 24 2020, 5:27 PM

Aug 21 2020

leoeer added inline comments to D4178: made it unnecessary to require run config for storages when the storage has no config schema..
Aug 21 2020, 7:39 PM

Aug 20 2020

leoeer updated the diff for D4203: ge tutorial.

flaky

Aug 20 2020, 7:40 PM
leoeer updated the diff for D4203: ge tutorial.

Max's docs changes

Aug 20 2020, 7:09 PM
leoeer updated the diff for D4018: putting finishing touches on GE.

max's comments

Aug 20 2020, 6:50 PM
leoeer added inline comments to D4178: made it unnecessary to require run config for storages when the storage has no config schema..
Aug 20 2020, 4:41 PM

Aug 19 2020

leoeer requested review of D4228: remove explicit union API.
Aug 19 2020, 9:29 PM
leoeer added inline comments to D4199: RFC: @dagster_type decorator.
Aug 19 2020, 9:15 PM
leoeer requested review of D4227: fix for github issue #2827.
Aug 19 2020, 7:55 PM
leoeer updated the diff for D4018: putting finishing touches on GE.

anthony's change

Aug 19 2020, 2:42 PM

Aug 18 2020

leoeer added a comment to D4188: RFC: Composable Types with Materializers as first example.

Commenting to register strong agreement with the abstraction choice here of having type factories and then basic/default loader+materializers, type checkers, TSPs. etc -- my one concern is that this abstraction has some weird mixes of functional/OOP design (not sure we want ComposableMaterializer to exist if create_composable_type_materializer does)

Aug 18 2020, 11:48 PM
leoeer added a comment to D4178: made it unnecessary to require run config for storages when the storage has no config schema..

this behavior seems not quite right -- shouldn't we be checking if any configless intermediate/system storage exists, not just checking the first?

Aug 18 2020, 11:39 PM
leoeer added inline comments to D4199: RFC: @dagster_type decorator.
Aug 18 2020, 12:38 AM

Aug 17 2020

leoeer updated the diff for D4203: ge tutorial.

sandy fixes

Aug 17 2020, 10:19 PM
leoeer updated the diff for D4203: ge tutorial.

sandy fixes

Aug 17 2020, 9:59 PM
leoeer requested review of D4203: ge tutorial.
Aug 17 2020, 5:50 PM
leoeer requested review of D4204: error message fix.
Aug 17 2020, 3:52 PM
leoeer updated the diff for D4181: adding union to base.

flaky

Aug 17 2020, 2:46 PM
leoeer updated the diff for D4181: adding union to base.

correct code blocks

Aug 17 2020, 2:40 PM
leoeer updated the diff for D4181: adding union to base.

docs with examples

Aug 17 2020, 2:37 PM
leoeer updated the diff for D4181: adding union to base.

docstring update

Aug 17 2020, 1:41 PM

Aug 14 2020

leoeer added a comment to D4171: first run of hooks on expectations.

per pipeline should be supported as well as per solid is, but tbh the use case for expectation results as I see it is way more likely to be limited to a few solids.

Aug 14 2020, 9:44 PM
leoeer added inline comments to D4014: solid-hook-3 hooks can decorate pipeline defs.
Aug 14 2020, 7:35 PM
leoeer updated the diff for D4018: putting finishing touches on GE.

flaky

Aug 14 2020, 6:27 PM
leoeer updated the diff for D4018: putting finishing touches on GE.

ge no longer necessarily fills filesystem

Aug 14 2020, 6:09 PM
leoeer requested review of D4181: adding union to base.
Aug 14 2020, 3:58 PM
leoeer published D4171: first run of hooks on expectations for review.

this is my first try at adding hooks on expectation results, and is likely useful for GE tooling

Aug 14 2020, 3:39 PM

Aug 13 2020

leoeer added inline comments to D4129: implement configured intermediate_storage, system_storage.
Aug 13 2020, 8:45 PM
leoeer added a reviewer for D4148: type union: alangenfeld.
Aug 13 2020, 5:36 PM
leoeer added inline comments to D4148: type union.
Aug 13 2020, 4:43 PM
leoeer added a comment to D4018: putting finishing touches on GE.

sample GE markdown rendered in dagit

Aug 13 2020, 12:17 AM
leoeer updated the diff for D4018: putting finishing touches on GE.

removing done todo

Aug 13 2020, 12:15 AM
leoeer published D4018: putting finishing touches on GE for review.
Aug 13 2020, 12:12 AM

Aug 12 2020

leoeer requested review of D4148: type union.
Aug 12 2020, 6:53 PM

Jul 30 2020

leoeer accepted D4051: changelog.

lgtm

Jul 30 2020, 10:15 PM
leoeer published D4051: changelog for review.
Jul 30 2020, 10:15 PM
leoeer updated the diff for D4038: displaying asset types in the asset menu.

rebase

Jul 30 2020, 3:16 PM
leoeer updated the diff for D4038: displaying asset types in the asset menu.

phil's changes

Jul 30 2020, 3:03 PM

Jul 29 2020

leoeer added a reviewer for D4038: displaying asset types in the asset menu: max.
Jul 29 2020, 9:58 PM
leoeer added a comment to D4038: displaying asset types in the asset menu.

image in dagit

Jul 29 2020, 9:56 PM
leoeer published D4038: displaying asset types in the asset menu for review.

the build failure is due to a legacy example having issues

Jul 29 2020, 9:37 PM

Jul 28 2020

leoeer updated the diff for D4023: modifying metadata with prefix.

black

Jul 28 2020, 10:41 PM
leoeer updated the diff for D4023: modifying metadata with prefix.

nits and renames

Jul 28 2020, 10:17 PM
leoeer updated the diff for D4023: modifying metadata with prefix.

format

Jul 28 2020, 9:48 PM
leoeer updated the diff for D4023: modifying metadata with prefix.

generic type info on pandas

Jul 28 2020, 9:40 PM
leoeer updated the diff for D4023: modifying metadata with prefix.

docs

Jul 28 2020, 9:22 PM
leoeer updated the diff for D4023: modifying metadata with prefix.

docs update

Jul 28 2020, 8:41 PM
leoeer updated the diff for D4023: modifying metadata with prefix.

phil's changes

Jul 28 2020, 8:09 PM
leoeer requested review of D4023: modifying metadata with prefix.
Jul 28 2020, 7:28 PM

Jul 27 2020

leoeer accepted D3953: gcs and azure file manager resources.

Accepting this change with resource/pipeline-based file managers soon to come after

Jul 27 2020, 8:52 PM

Jul 24 2020

leoeer added inline comments to D3985: Adding type info to materializations as metadata.
Jul 24 2020, 10:46 PM
leoeer added inline comments to D3985: Adding type info to materializations as metadata.
Jul 24 2020, 10:06 PM
leoeer added inline comments to D3985: Adding type info to materializations as metadata.
Jul 24 2020, 8:51 PM
leoeer added inline comments to D3985: Adding type info to materializations as metadata.
Jul 24 2020, 8:33 PM
leoeer updated the diff for D3985: Adding type info to materializations as metadata.

new functionality tests

Jul 24 2020, 6:23 PM
leoeer updated the diff for D3985: Adding type info to materializations as metadata.

cloning over mutation

Jul 24 2020, 4:26 PM
leoeer added inline comments to D3985: Adding type info to materializations as metadata.
Jul 24 2020, 3:38 PM
leoeer updated the diff for D3985: Adding type info to materializations as metadata.

lint fix

Jul 24 2020, 3:14 PM
leoeer updated the diff for D3985: Adding type info to materializations as metadata.

wrapper class

Jul 24 2020, 3:12 PM

Jul 23 2020

leoeer added a comment to D3953: gcs and azure file manager resources.

if i'm using e.g. gcs, do i need to provide the config in GCS_CONFIG_SCHEMA twice?

Jul 23 2020, 9:15 PM
leoeer requested changes to D3953: gcs and azure file manager resources.

Does this require duplicating config at the run level? would be better if it didn't.

Jul 23 2020, 7:57 PM
leoeer updated the diff for D3985: Adding type info to materializations as metadata.

better docs

Jul 23 2020, 7:10 PM
leoeer updated the diff for D3985: Adding type info to materializations as metadata.

no exceptions as control flow

Jul 23 2020, 6:35 PM
leoeer added inline comments to D3985: Adding type info to materializations as metadata.
Jul 23 2020, 5:57 PM
leoeer updated the diff for D3985: Adding type info to materializations as metadata.

broad exception

Jul 23 2020, 5:52 PM
leoeer added a reviewer for D3985: Adding type info to materializations as metadata: nate.
Jul 23 2020, 5:05 PM
leoeer requested review of D3985: Adding type info to materializations as metadata.
Jul 23 2020, 4:18 PM

Jul 22 2020

leoeer requested review of D3973: comma fix in buildkite.
Jul 22 2020, 6:28 PM
leoeer updated the diff for D3970: update dagster_pandas deprecation warning.

capitalize

Jul 22 2020, 4:40 PM
leoeer requested review of D3970: update dagster_pandas deprecation warning.
Jul 22 2020, 4:20 PM

Jul 20 2020

leoeer requested changes to D3812: [RFC] solid hook built on top of events.

somewhat in agreement with nick here, hooks make more sense as a mapping from solids or solid_names to functions (with associated types) at the pipeline or mode def level?

Jul 20 2020, 10:58 PM

Jul 17 2020

leoeer updated the diff for D3925: singularizing executor and intermediate defs.

slight docstring update

Jul 17 2020, 8:53 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

double warning

Jul 17 2020, 5:37 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

slight docstring fix

Jul 17 2020, 5:34 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

snap linting

Jul 17 2020, 5:17 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

bug fixes

Jul 17 2020, 4:52 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

snaps

Jul 17 2020, 4:41 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

black

Jul 17 2020, 4:33 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

snaps and plurals

Jul 17 2020, 4:29 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

singularization changes

Jul 17 2020, 4:20 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

bug fix

Jul 17 2020, 3:13 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

singular def

Jul 17 2020, 2:52 PM
leoeer requested changes to D3937: update CHANGES.md on storages.
Jul 17 2020, 12:54 AM

Jul 16 2020

leoeer added inline comments to D3925: singularizing executor and intermediate defs.
Jul 16 2020, 8:41 PM
leoeer added reviewers for D3925: singularizing executor and intermediate defs: max, schrockn.
Jul 16 2020, 7:39 PM
leoeer published D3925: singularizing executor and intermediate defs for review.

Singularization is ready, I think :)

Jul 16 2020, 7:38 PM
leoeer added a reviewer for D3920: updating remaining examples to intermediates: sandyryza.
Jul 16 2020, 3:20 PM
leoeer published D3920: updating remaining examples to intermediates for review.
Jul 16 2020, 3:20 PM

Jul 15 2020

leoeer added a comment to D3812: [RFC] solid hook built on top of events.

In terms of every hook def having the same requirements, why not handle that by having hookdefs default to None (as is currently done in code)

Jul 15 2020, 9:20 PM
leoeer requested review of D3903: docs updates for intermediates.
Jul 15 2020, 8:22 PM
leoeer retitled D3898: modifying airline demo to use intermediate storage from modifying examples to use intermediate storage to modifying airline demo to use intermediate storage.
Jul 15 2020, 7:38 PM
leoeer updated the summary of D3898: modifying airline demo to use intermediate storage.
Jul 15 2020, 6:39 PM
leoeer requested review of D3898: modifying airline demo to use intermediate storage.
Jul 15 2020, 6:34 PM
leoeer accepted D3891: make sure intermediates_manager config is recognized as persistent.

excellent, accepting assuming it builds

Jul 15 2020, 12:28 AM
leoeer requested changes to D3891: make sure intermediates_manager config is recognized as persistent.

The celery logic should be the same as the core logic for determining persistence, imo

Jul 15 2020, 12:15 AM

Jul 14 2020

leoeer requested review of D3885: moving all top-level tests to general.
Jul 14 2020, 5:43 PM
leoeer requested review of D3884: bug fix.
Jul 14 2020, 5:06 PM
leoeer updated the diff for D3663: reimplementing all prior validators.

datetime range support

Jul 14 2020, 2:32 PM
leoeer updated the diff for D3663: reimplementing all prior validators.

black

Jul 14 2020, 2:14 PM
leoeer updated the diff for D3663: reimplementing all prior validators.

todo out of docstring

Jul 14 2020, 2:00 PM