Page MenuHomePhabricator

leoeer (Leor Fishman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 1 2020, 7:56 PM (10 w, 20 h)

Recent Activity

Thu, Jul 30

leoeer accepted D4051: changelog.

lgtm

Thu, Jul 30, 10:15 PM
leoeer published D4051: changelog for review.
Thu, Jul 30, 10:15 PM
leoeer updated the diff for D4038: displaying asset types in the asset menu.

rebase

Thu, Jul 30, 3:16 PM
leoeer updated the diff for D4038: displaying asset types in the asset menu.

phil's changes

Thu, Jul 30, 3:03 PM

Wed, Jul 29

leoeer added a reviewer for D4038: displaying asset types in the asset menu: max.
Wed, Jul 29, 9:58 PM
leoeer added a comment to D4038: displaying asset types in the asset menu.

image in dagit

Wed, Jul 29, 9:56 PM
leoeer published D4038: displaying asset types in the asset menu for review.

the build failure is due to a legacy example having issues

Wed, Jul 29, 9:37 PM

Tue, Jul 28

leoeer updated the diff for D4023: modifying metadata with prefix.

black

Tue, Jul 28, 10:41 PM
leoeer updated the diff for D4023: modifying metadata with prefix.

nits and renames

Tue, Jul 28, 10:17 PM
leoeer updated the diff for D4023: modifying metadata with prefix.

format

Tue, Jul 28, 9:48 PM
leoeer updated the diff for D4023: modifying metadata with prefix.

generic type info on pandas

Tue, Jul 28, 9:40 PM
leoeer updated the diff for D4023: modifying metadata with prefix.

docs

Tue, Jul 28, 9:22 PM
leoeer updated the diff for D4023: modifying metadata with prefix.

docs update

Tue, Jul 28, 8:41 PM
leoeer updated the diff for D4023: modifying metadata with prefix.

phil's changes

Tue, Jul 28, 8:09 PM
leoeer requested review of D4023: modifying metadata with prefix.
Tue, Jul 28, 7:28 PM

Mon, Jul 27

leoeer accepted D3953: gcs and azure file manager resources.

Accepting this change with resource/pipeline-based file managers soon to come after

Mon, Jul 27, 8:52 PM

Fri, Jul 24

leoeer added inline comments to D3985: Adding type info to materializations as metadata.
Fri, Jul 24, 10:46 PM
leoeer added inline comments to D3985: Adding type info to materializations as metadata.
Fri, Jul 24, 10:06 PM
leoeer added inline comments to D3985: Adding type info to materializations as metadata.
Fri, Jul 24, 8:51 PM
leoeer added inline comments to D3985: Adding type info to materializations as metadata.
Fri, Jul 24, 8:33 PM
leoeer updated the diff for D3985: Adding type info to materializations as metadata.

new functionality tests

Fri, Jul 24, 6:23 PM
leoeer updated the diff for D3985: Adding type info to materializations as metadata.

cloning over mutation

Fri, Jul 24, 4:26 PM
leoeer added inline comments to D3985: Adding type info to materializations as metadata.
Fri, Jul 24, 3:38 PM
leoeer updated the diff for D3985: Adding type info to materializations as metadata.

lint fix

Fri, Jul 24, 3:14 PM
leoeer updated the diff for D3985: Adding type info to materializations as metadata.

wrapper class

Fri, Jul 24, 3:12 PM

Thu, Jul 23

leoeer added a comment to D3953: gcs and azure file manager resources.

if i'm using e.g. gcs, do i need to provide the config in GCS_CONFIG_SCHEMA twice?

Thu, Jul 23, 9:15 PM
leoeer requested changes to D3953: gcs and azure file manager resources.

Does this require duplicating config at the run level? would be better if it didn't.

Thu, Jul 23, 7:57 PM
leoeer updated the diff for D3985: Adding type info to materializations as metadata.

better docs

Thu, Jul 23, 7:10 PM
leoeer updated the diff for D3985: Adding type info to materializations as metadata.

no exceptions as control flow

Thu, Jul 23, 6:35 PM
leoeer added inline comments to D3985: Adding type info to materializations as metadata.
Thu, Jul 23, 5:57 PM
leoeer updated the diff for D3985: Adding type info to materializations as metadata.

broad exception

Thu, Jul 23, 5:52 PM
leoeer added a reviewer for D3985: Adding type info to materializations as metadata: nate.
Thu, Jul 23, 5:05 PM
leoeer requested review of D3985: Adding type info to materializations as metadata.
Thu, Jul 23, 4:18 PM

Wed, Jul 22

leoeer requested review of D3973: comma fix in buildkite.
Wed, Jul 22, 6:28 PM
leoeer updated the diff for D3970: update dagster_pandas deprecation warning.

capitalize

Wed, Jul 22, 4:40 PM
leoeer requested review of D3970: update dagster_pandas deprecation warning.
Wed, Jul 22, 4:20 PM

Mon, Jul 20

leoeer requested changes to D3812: [RFC] solid hook built on top of events.

somewhat in agreement with nick here, hooks make more sense as a mapping from solids or solid_names to functions (with associated types) at the pipeline or mode def level?

Mon, Jul 20, 10:58 PM

Fri, Jul 17

leoeer updated the diff for D3925: singularizing executor and intermediate defs.

slight docstring update

Fri, Jul 17, 8:53 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

double warning

Fri, Jul 17, 5:37 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

slight docstring fix

Fri, Jul 17, 5:34 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

snap linting

Fri, Jul 17, 5:17 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

bug fixes

Fri, Jul 17, 4:52 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

snaps

Fri, Jul 17, 4:41 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

black

Fri, Jul 17, 4:33 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

snaps and plurals

Fri, Jul 17, 4:29 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

singularization changes

Fri, Jul 17, 4:20 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

bug fix

Fri, Jul 17, 3:13 PM
leoeer updated the diff for D3925: singularizing executor and intermediate defs.

singular def

Fri, Jul 17, 2:52 PM
leoeer requested changes to D3937: update CHANGES.md on storages.
Fri, Jul 17, 12:54 AM

Thu, Jul 16

leoeer added inline comments to D3925: singularizing executor and intermediate defs.
Thu, Jul 16, 8:41 PM
leoeer added reviewers for D3925: singularizing executor and intermediate defs: max, schrockn.
Thu, Jul 16, 7:39 PM
leoeer published D3925: singularizing executor and intermediate defs for review.

Singularization is ready, I think :)

Thu, Jul 16, 7:38 PM
leoeer added a reviewer for D3920: updating remaining examples to intermediates: sandyryza.
Thu, Jul 16, 3:20 PM
leoeer published D3920: updating remaining examples to intermediates for review.
Thu, Jul 16, 3:20 PM

Wed, Jul 15

leoeer added a comment to D3812: [RFC] solid hook built on top of events.

In terms of every hook def having the same requirements, why not handle that by having hookdefs default to None (as is currently done in code)

Wed, Jul 15, 9:20 PM
leoeer requested review of D3903: docs updates for intermediates.
Wed, Jul 15, 8:22 PM
leoeer retitled D3898: modifying airline demo to use intermediate storage from modifying examples to use intermediate storage to modifying airline demo to use intermediate storage.
Wed, Jul 15, 7:38 PM
leoeer updated the summary of D3898: modifying airline demo to use intermediate storage.
Wed, Jul 15, 6:39 PM
leoeer requested review of D3898: modifying airline demo to use intermediate storage.
Wed, Jul 15, 6:34 PM
leoeer accepted D3891: make sure intermediates_manager config is recognized as persistent.

excellent, accepting assuming it builds

Wed, Jul 15, 12:28 AM
leoeer requested changes to D3891: make sure intermediates_manager config is recognized as persistent.

The celery logic should be the same as the core logic for determining persistence, imo

Wed, Jul 15, 12:15 AM

Tue, Jul 14

leoeer requested review of D3885: moving all top-level tests to general.
Tue, Jul 14, 5:43 PM
leoeer requested review of D3884: bug fix.
Tue, Jul 14, 5:06 PM
leoeer updated the diff for D3663: reimplementing all prior validators.

datetime range support

Tue, Jul 14, 2:32 PM
leoeer updated the diff for D3663: reimplementing all prior validators.

black

Tue, Jul 14, 2:14 PM
leoeer updated the diff for D3663: reimplementing all prior validators.

todo out of docstring

Tue, Jul 14, 2:00 PM
leoeer updated the diff for D3663: reimplementing all prior validators.

massive docs rewrite

Tue, Jul 14, 1:59 PM

Mon, Jul 13

leoeer updated the diff for D3663: reimplementing all prior validators.

update deprecation language

Mon, Jul 13, 10:47 PM
leoeer accepted D3865: clean up print.
Mon, Jul 13, 8:36 PM
leoeer updated the diff for D3791: first run of intermediate creation.

modifying docs and slight refactors

Mon, Jul 13, 5:33 PM
leoeer updated the diff for D3791: first run of intermediate creation.

gcs and azure refactored

Mon, Jul 13, 5:26 PM
leoeer updated the diff for D3791: first run of intermediate creation.

major refactor

Mon, Jul 13, 5:11 PM
leoeer updated the diff for D3791: first run of intermediate creation.

major refactor

Mon, Jul 13, 5:07 PM
leoeer updated the diff for D3791: first run of intermediate creation.

major refactor

Mon, Jul 13, 5:04 PM

Jul 10 2020

leoeer updated the diff for D3791: first run of intermediate creation.

fixing nits

Jul 10 2020, 8:02 PM
leoeer added inline comments to D3791: first run of intermediate creation.
Jul 10 2020, 5:45 PM
leoeer updated the diff for D3791: first run of intermediate creation.

rebase

Jul 10 2020, 5:05 PM
leoeer updated the diff for D3791: first run of intermediate creation.

snapshot updates

Jul 10 2020, 4:59 PM
leoeer updated the diff for D3791: first run of intermediate creation.

defaults and all

Jul 10 2020, 4:04 PM

Jul 9 2020

leoeer updated the diff for D3791: first run of intermediate creation.

flaky test

Jul 9 2020, 5:34 PM
leoeer updated the diff for D3791: first run of intermediate creation.

lint fix

Jul 9 2020, 5:09 PM
leoeer updated the diff for D3791: first run of intermediate creation.

rename plus util

Jul 9 2020, 5:00 PM
leoeer added a comment to D3791: first run of intermediate creation.

tests are passing @max (the previous fail looks like it was a k8s flake issue)

Jul 9 2020, 4:20 PM
leoeer updated the diff for D3791: first run of intermediate creation.

format nits

Jul 9 2020, 3:59 PM
leoeer updated the diff for D3791: first run of intermediate creation.

removing debug stmt

Jul 9 2020, 3:04 PM

Jul 8 2020

leoeer added inline comments to D3812: [RFC] solid hook built on top of events.
Jul 8 2020, 11:59 PM
leoeer updated the diff for D3791: first run of intermediate creation.

pgsnaps

Jul 8 2020, 11:34 PM
leoeer updated the diff for D3791: first run of intermediate creation.

postgres snaps

Jul 8 2020, 10:57 PM
leoeer updated the diff for D3791: first run of intermediate creation.

isort

Jul 8 2020, 10:53 PM
leoeer updated the diff for D3791: first run of intermediate creation.

fixing tests

Jul 8 2020, 10:46 PM
leoeer updated the diff for D3791: first run of intermediate creation.

slight bug fix in env configs

Jul 8 2020, 9:15 PM
leoeer updated the diff for D3791: first run of intermediate creation.

docstring fix

Jul 8 2020, 8:59 PM
leoeer updated the diff for D3791: first run of intermediate creation.

tests and bug fixes

Jul 8 2020, 8:57 PM
leoeer updated the diff for D3791: first run of intermediate creation.

max's changes

Jul 8 2020, 5:58 PM
leoeer added inline comments to D3791: first run of intermediate creation.
Jul 8 2020, 5:56 PM
leoeer updated the diff for D3791: first run of intermediate creation.

reformatting

Jul 8 2020, 4:32 PM
leoeer updated the diff for D3791: first run of intermediate creation.

fixing diff

Jul 8 2020, 3:41 PM
leoeer updated the diff for D3791: first run of intermediate creation.
  • removing config and todo
Jul 8 2020, 3:29 PM
leoeer updated the diff for D3791: first run of intermediate creation.

warnings and blessed dep handling

Jul 8 2020, 2:11 PM

Jul 7 2020

leoeer updated the diff for D3791: first run of intermediate creation.

removing unnecessary creation

Jul 7 2020, 9:55 PM