Page MenuHomeElementl

jordansanders (Jordan Sanders)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 12 2021, 3:38 PM (27 w, 3 d)

Recent Activity

Thu, Oct 14

jordansanders committed R1:79db28263a20: Automation: versioned docs for 0.12.15 (authored by elementl-devtools).
Automation: versioned docs for 0.12.15
Thu, Oct 14, 10:21 PM

Aug 2 2021

jordansanders accepted D9179: speed up test project builds.
Aug 2 2021, 2:36 PM

Jul 29 2021

jordansanders accepted D9145: Update readme for hackernews example.
Jul 29 2021, 5:36 PM

Jul 28 2021

jordansanders closed D9105: Return false if describe_tasks isn't consistent.
Jul 28 2021, 5:33 PM
jordansanders committed R1:cdc1f5a37487: Return false if describe_tasks isn't consistent (authored by jordansanders).
Return false if describe_tasks isn't consistent
Jul 28 2021, 5:33 PM
jordansanders requested changes to D9120: Make run storage test a bit less strict.
Jul 28 2021, 3:06 PM

Jul 27 2021

jordansanders published D9105: Return false if describe_tasks isn't consistent for review.
Jul 27 2021, 10:51 PM

Jul 23 2021

jordansanders requested changes to D9050: test: default docker compose fixtures to be module scoped.

I'd like to see it in action - I don't have a great sense of how this actually gets used and adding a test to describe that behavior would be great.

Jul 23 2021, 9:12 PM

Jul 22 2021

jordansanders accepted D9033: rm dagster dep from automation.
Jul 22 2021, 11:15 PM
jordansanders published D9033: rm dagster dep from automation for review.

Do we have a hypothesis for why this would cause issues this week but not last?

Jul 22 2021, 11:14 PM
jordansanders accepted D9021: changes for 0.12.3.
Jul 22 2021, 7:24 PM
jordansanders added a comment to D9021: changes for 0.12.3.

@jordansanders how strongly do you feel about stars vs. dashes? I don't mind changing this time, but fairly annoying if that needs to be another step in the release guide. (the stars are generated by the Quip markdown export).

Jul 22 2021, 7:20 PM
jordansanders requested changes to D9021: changes for 0.12.3.

Let's definitely remove the "Added information" line 😄

Jul 22 2021, 7:12 PM

Jul 21 2021

jordansanders closed D8995: More narrowly scope IAM policies.
Jul 21 2021, 10:28 PM
jordansanders committed R1:e9ab0a083178: More narrowly scope IAM policies (authored by jordansanders).
More narrowly scope IAM policies
Jul 21 2021, 10:28 PM
jordansanders closed D8978: Infer cluster from tags.
Jul 21 2021, 10:28 PM
jordansanders committed R1:00d73bb34601: Infer cluster from tags (authored by jordansanders).
Infer cluster from tags
Jul 21 2021, 10:28 PM
jordansanders updated the summary of D8995: More narrowly scope IAM policies.
Jul 21 2021, 9:52 PM
jordansanders added a comment to D8995: More narrowly scope IAM policies.

Do we support termination? Dagit makes that api call if so

Jul 21 2021, 9:32 PM
jordansanders updated the diff for D8995: More narrowly scope IAM policies.

rebase

Jul 21 2021, 9:31 PM
jordansanders updated the diff for D8978: Infer cluster from tags.

Return false if can_terminate can't look up any tasks

Jul 21 2021, 9:31 PM
jordansanders closed D8977: Give dagit permission to interact with ECS.
Jul 21 2021, 9:30 PM
jordansanders committed R1:538c27bcada0: Give dagit permission to interact with ECS (authored by jordansanders).
Give dagit permission to interact with ECS
Jul 21 2021, 9:30 PM
jordansanders added inline comments to D8978: Infer cluster from tags.
Jul 21 2021, 9:26 PM
jordansanders added inline comments to D8978: Infer cluster from tags.
Jul 21 2021, 9:25 PM
jordansanders updated the diff for D8995: More narrowly scope IAM policies.

Remove unnecessary dagit permissions (these were only included because https://dagster.phacility.com/D8978 hasn't landed yet)

Jul 21 2021, 9:23 PM
jordansanders updated the diff for D8995: More narrowly scope IAM policies.

Add StopTask permission to dagit and add a sleep to the solid so it's easier to manually test

Jul 21 2021, 9:22 PM
jordansanders requested review of D8995: More narrowly scope IAM policies.
Jul 21 2021, 8:03 PM

Jul 20 2021

jordansanders requested review of D8978: Infer cluster from tags.
Jul 20 2021, 10:17 PM
jordansanders requested review of D8977: Give dagit permission to interact with ECS.
Jul 20 2021, 10:13 PM

Jul 16 2021

jordansanders closed D8910: Don't inherit entryPoint from Task Definition.
Jul 16 2021, 1:43 PM
jordansanders committed R1:7c861510727d: Don't inherit entryPoint from Task Definition (authored by jordansanders).
Don't inherit entryPoint from Task Definition
Jul 16 2021, 1:43 PM
jordansanders accepted D8919: Pass in an instance ref to daemon run loop rather than using DagsterInstance.get().
Jul 16 2021, 1:35 PM
jordansanders added a comment to D8910: Don't inherit entryPoint from Task Definition.

users might still run into this issue when their image contains an ENTRYPOINT.

in docs?

Jul 16 2021, 1:29 PM

Jul 15 2021

jordansanders requested review of D8910: Don't inherit entryPoint from Task Definition.
Jul 15 2021, 9:02 PM

Jul 8 2021

jordansanders accepted D8763: ReadOnlyError => UnauthorizedError.
Jul 8 2021, 5:50 PM
jordansanders accepted D8750: Replace check_read_only with specific permissions checks.
Jul 8 2021, 2:50 PM
jordansanders accepted D8735: docs: add title and description metadata to Kubernetes deployment guides.
Jul 8 2021, 1:41 PM
jordansanders requested changes to D8750: Replace check_read_only with specific permissions checks.

This is a really good change - we should more explicitly test it and be a little bit more defensive w/r/t passing strings around.

Jul 8 2021, 1:41 PM

Jul 7 2021

jordansanders accepted D8742: Add 'check_heartbeats' flag to DagsterDaemonController.check_daemon_loop.
Jul 7 2021, 8:49 PM

Jul 6 2021

jordansanders closed D8690: Demonstrate using the fixtures in a test suite.
Jul 6 2021, 8:59 PM
jordansanders committed R1:6b1008cc091f: Demonstrate using the fixtures in a test suite (authored by jordansanders).
Demonstrate using the fixtures in a test suite
Jul 6 2021, 8:59 PM
jordansanders closed D8688: Introduce docker compose fixtures.
Jul 6 2021, 8:59 PM
jordansanders committed R1:6bc8d76689ae: Introduce docker compose fixtures (authored by jordansanders).
Introduce docker compose fixtures
Jul 6 2021, 8:59 PM
jordansanders updated the diff for D8690: Demonstrate using the fixtures in a test suite.

rebase

Jul 6 2021, 7:30 PM
jordansanders updated the diff for D8688: Introduce docker compose fixtures.

rebase

Jul 6 2021, 7:29 PM
jordansanders updated the diff for D8690: Demonstrate using the fixtures in a test suite.

Fixup diff description

Jul 6 2021, 7:13 PM
jordansanders added a comment to D8684: style: adopt pre-commit for Python black formatting.

Take it with a grain of salt, but it looks like we backed away from pre-commit hooks once before as well:

Jul 6 2021, 7:08 PM
jordansanders added a comment to D8684: style: adopt pre-commit for Python black formatting.

I don't personally love git-hooks and find them to often be more of a hinderance than a help: https://www.thoughtworks.com/en-us/insights/blog/pre-commit-don-t-git-hooked

Jul 6 2021, 6:57 PM
jordansanders added inline comments to D8688: Introduce docker compose fixtures.
Jul 6 2021, 2:56 PM
jordansanders requested review of D8690: Demonstrate using the fixtures in a test suite.
Jul 6 2021, 2:54 PM
jordansanders requested review of D8688: Introduce docker compose fixtures.
Jul 6 2021, 1:44 PM

Jul 2 2021

jordansanders closed D8694: Use tz_localize to get naive local timestamp.
Jul 2 2021, 9:31 PM
jordansanders committed R1:0d30bd2c7729: Use tz_localize to get naive local timestamp (authored by jordansanders).
Use tz_localize to get naive local timestamp
Jul 2 2021, 9:31 PM
jordansanders closed D8642: Configure task_definition and container_name.
Jul 2 2021, 9:18 PM
jordansanders closed D8641: Ignore dagster.ExperimentalWarning.
Jul 2 2021, 9:18 PM
jordansanders committed R1:ac931b1663b9: Configure task_definition and container_name (authored by jordansanders).
Configure task_definition and container_name
Jul 2 2021, 9:18 PM
jordansanders committed R1:2368e1d7da01: Ignore dagster.ExperimentalWarning (authored by jordansanders).
Ignore dagster.ExperimentalWarning
Jul 2 2021, 9:18 PM
jordansanders closed D8640: Split launcher tests into a module per function.
Jul 2 2021, 9:18 PM
jordansanders closed D8638: Extract task definition logic.
Jul 2 2021, 9:18 PM
jordansanders committed R1:08b6c70cd589: Split launcher tests into a module per function (authored by jordansanders).
Split launcher tests into a module per function
Jul 2 2021, 9:18 PM
jordansanders committed R1:754812ea0740: Extract task definition logic (authored by jordansanders).
Extract task definition logic
Jul 2 2021, 9:18 PM
jordansanders closed D8637: Customize instance fixture.
Jul 2 2021, 9:18 PM
jordansanders committed R1:5f1b5b7a7c81: Customize instance fixture (authored by jordansanders).
Customize instance fixture
Jul 2 2021, 9:18 PM
jordansanders closed D8639: Stub AWS before instance construction.
Jul 2 2021, 9:18 PM
jordansanders committed R1:95cbb3674d39: Stub AWS before instance construction (authored by jordansanders).
Stub AWS before instance construction
Jul 2 2021, 9:18 PM
jordansanders updated the diff for D8642: Configure task_definition and container_name.

rebase

Jul 2 2021, 8:19 PM
jordansanders updated the diff for D8641: Ignore dagster.ExperimentalWarning.

update

Jul 2 2021, 8:18 PM
jordansanders updated the diff for D8640: Split launcher tests into a module per function.

update

Jul 2 2021, 8:17 PM
jordansanders updated the diff for D8638: Extract task definition logic.

update

Jul 2 2021, 8:17 PM
jordansanders updated the diff for D8637: Customize instance fixture.

s/metadata/stub_ecs_metadata

Jul 2 2021, 8:17 PM

Jul 1 2021

jordansanders updated the diff for D8642: Configure task_definition and container_name.

Use the new instance_cm fixture instead of the build_instance fixture (which no longer exists)

Jul 1 2021, 6:30 PM
jordansanders updated the diff for D8641: Ignore dagster.ExperimentalWarning.

Rebase

Jul 1 2021, 6:29 PM
jordansanders updated the diff for D8640: Split launcher tests into a module per function.

Rebase

Jul 1 2021, 6:28 PM
jordansanders updated the diff for D8638: Extract task definition logic.

Rebase

Jul 1 2021, 6:27 PM
jordansanders updated the diff for D8637: Customize instance fixture.

Refactor to return a contextmanager

Jul 1 2021, 6:27 PM
jordansanders updated the diff for D8639: Stub AWS before instance construction.

Rearrange stack so this comes first

Jul 1 2021, 6:25 PM
jordansanders accepted D8594: 4/ remove versioned_content and versioned_images.
Jul 1 2021, 2:01 PM

Jun 30 2021

jordansanders requested review of D8642: Configure task_definition and container_name.
Jun 30 2021, 9:32 PM
jordansanders requested review of D8639: Stub AWS before instance construction.
Jun 30 2021, 9:30 PM
jordansanders requested review of D8637: Customize instance fixture.
Jun 30 2021, 9:25 PM
jordansanders requested review of D8641: Ignore dagster.ExperimentalWarning.
Jun 30 2021, 9:13 PM
jordansanders requested review of D8640: Split launcher tests into a module per function.
Jun 30 2021, 9:11 PM
jordansanders requested review of D8638: Extract task definition logic.
Jun 30 2021, 9:05 PM
jordansanders closed D8575: Test ECS reference deployment.
Jun 30 2021, 9:02 PM
jordansanders committed R1:00e19db4dfcf: Test ECS reference deployment (authored by jordansanders).
Test ECS reference deployment
Jun 30 2021, 9:02 PM
jordansanders added inline comments to D8575: Test ECS reference deployment.
Jun 30 2021, 9:01 PM
jordansanders closed D8490: Remove reference to output_manager decorator.
Jun 30 2021, 7:31 PM
jordansanders committed R1:c2a85bca973e: Remove reference to output_manager decorator (authored by jordansanders).
Remove reference to output_manager decorator
Jun 30 2021, 7:31 PM
jordansanders updated the diff for D8575: Test ECS reference deployment.

Add comments

Jun 30 2021, 7:27 PM
jordansanders added inline comments to D8575: Test ECS reference deployment.
Jun 30 2021, 6:04 PM
jordansanders closed D8573: Install compose-cli.
Jun 30 2021, 4:31 PM
jordansanders committed R1:a759b176e6ba: Install compose-cli (authored by jordansanders).
Install compose-cli
Jun 30 2021, 4:31 PM
jordansanders updated the diff for D8575: Test ECS reference deployment.

rebase

Jun 30 2021, 3:56 PM
jordansanders updated the diff for D8573: Install compose-cli.

rebase

Jun 30 2021, 3:55 PM
jordansanders closed D8577: Handle LegacyVersion.
Jun 30 2021, 3:55 PM
jordansanders committed R1:b02f7ecac361: Handle LegacyVersion (authored by jordansanders).
Handle LegacyVersion
Jun 30 2021, 3:55 PM
jordansanders added a comment to D8573: Install compose-cli.

test failure looks unrelated?

Jun 30 2021, 1:57 PM

Jun 29 2021

jordansanders added a reviewer for D8577: Handle LegacyVersion: dgibson.
Jun 29 2021, 8:53 PM
jordansanders accepted D8599: fix: pass creds via env vars if vercel.
Jun 29 2021, 7:29 PM