User Details
- User Since
- Apr 12 2021, 3:38 PM (95 w, 52 m)
- Roles
- Disabled
Oct 14 2021
Aug 2 2021
Jul 29 2021
Jul 28 2021
Jul 27 2021
Jul 23 2021
I'd like to see it in action - I don't have a great sense of how this actually gets used and adding a test to describe that behavior would be great.
Jul 22 2021
Do we have a hypothesis for why this would cause issues this week but not last?
Let's definitely remove the "Added information" line 😄
Jul 21 2021
Do we support termination? Dagit makes that api call if so
rebase
Return false if can_terminate can't look up any tasks
Remove unnecessary dagit permissions (these were only included because https://dagster.phacility.com/D8978 hasn't landed yet)
Add StopTask permission to dagit and add a sleep to the solid so it's easier to manually test
Jul 20 2021
Jul 16 2021
Jul 15 2021
Jul 8 2021
This is a really good change - we should more explicitly test it and be a little bit more defensive w/r/t passing strings around.
Jul 7 2021
Jul 6 2021
rebase
rebase
Fixup diff description
Take it with a grain of salt, but it looks like we backed away from pre-commit hooks once before as well:
I don't personally love git-hooks and find them to often be more of a hinderance than a help: https://www.thoughtworks.com/en-us/insights/blog/pre-commit-don-t-git-hooked
Jul 2 2021
rebase
update
update
s/metadata/stub_ecs_metadata
Jul 1 2021
Use the new instance_cm fixture instead of the build_instance fixture (which no longer exists)
Rebase
Rebase
Refactor to return a contextmanager
Rearrange stack so this comes first
Jun 30 2021
Add comments
rebase