Page MenuHomeElementl

jordansanders (Jordan Sanders)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 12 2021, 3:38 PM (4 w, 5 d)

Recent Activity

Thu, May 13

jordansanders added a reverting change for R1:25419d61ccbf: Automation: versioned docs for 0.11.9rc8: R1:34dffb314783: Revert "Automation: versioned docs for 0.11.9rc8".
Thu, May 13, 11:09 PM
jordansanders committed R1:34dffb314783: Revert "Automation: versioned docs for 0.11.9rc8" (authored by jordansanders).
Revert "Automation: versioned docs for 0.11.9rc8"
Thu, May 13, 11:09 PM
jordansanders added a reverting change for R1:32918732397c: Remove 0.11.9rc8 docs: R1:7a32876e89d3: Revert "Remove 0.11.9rc8 docs".
Thu, May 13, 11:09 PM
jordansanders added a reverting change for D7908: Remove 0.11.9rc8 docs: R1:7a32876e89d3: Revert "Remove 0.11.9rc8 docs".
Thu, May 13, 11:09 PM
jordansanders committed R1:7a32876e89d3: Revert "Remove 0.11.9rc8 docs" (authored by jordansanders).
Revert "Remove 0.11.9rc8 docs"
Thu, May 13, 11:09 PM
jordansanders closed D7908: Remove 0.11.9rc8 docs.
Thu, May 13, 10:38 PM
jordansanders committed R1:32918732397c: Remove 0.11.9rc8 docs (authored by jordansanders).
Remove 0.11.9rc8 docs
Thu, May 13, 10:38 PM
jordansanders requested review of D7908: Remove 0.11.9rc8 docs.
Thu, May 13, 10:31 PM
jordansanders closed D7907: 0.11.9 changelog.
Thu, May 13, 9:07 PM
jordansanders committed R1:7aad86b1c136: 0.11.9 changelog (authored by jordansanders).
0.11.9 changelog
Thu, May 13, 9:07 PM
jordansanders updated the diff for D7907: 0.11.9 changelog.

up

Thu, May 13, 9:07 PM
jordansanders updated the diff for D7907: 0.11.9 changelog.

s/*/- and turn make dev_install into inline code

Thu, May 13, 9:06 PM
jordansanders published D7907: 0.11.9 changelog for review.
Thu, May 13, 8:55 PM
jordansanders committed R1:25419d61ccbf: Automation: versioned docs for 0.11.9rc8 (authored by jordansanders).
Automation: versioned docs for 0.11.9rc8
Thu, May 13, 8:15 PM
jordansanders closed D7887: Pip install twice.
Thu, May 13, 5:13 PM
jordansanders committed R1:99ce9c8ba0bb: Pip install twice (authored by jordansanders).
Pip install twice
Thu, May 13, 5:13 PM
jordansanders accepted D7891: Allow dagster/priority tag on definitions.
Thu, May 13, 2:02 PM

Wed, May 12

jordansanders published D7887: Pip install twice for review.
Wed, May 12, 5:25 PM

Tue, May 11

jordansanders accepted D7868: Add Dagster alert events.
Tue, May 11, 8:14 PM

Tue, May 4

jordansanders accepted D7731: [easy] Add can_watch() to TestEventLogStorage.
Tue, May 4, 9:58 PM
jordansanders added inline comments to D7711: Add override for env_name for TestPosgresInstance.docker_compose_up.
Tue, May 4, 9:03 PM
jordansanders accepted D7711: Add override for env_name for TestPosgresInstance.docker_compose_up.
Tue, May 4, 8:56 PM

Mon, May 3

jordansanders added inline comments to D7665: Scaffold networking and load balancer for example ECS deployment.
Mon, May 3, 2:38 PM

Thu, Apr 29

jordansanders requested review of D7667: Add a dagit service.
Thu, Apr 29, 9:10 PM
jordansanders requested review of D7666: Add a Fargate cluster.
Thu, Apr 29, 9:09 PM
jordansanders requested review of D7665: Scaffold networking and load balancer for example ECS deployment.
Thu, Apr 29, 9:08 PM
jordansanders accepted D7658: shorter stabler URL for cereal.csv in intro tutorial.
Thu, Apr 29, 3:20 PM

Wed, Apr 28

jordansanders accepted D7644: Fix typo in monthly schedule decorator.
Wed, Apr 28, 9:46 PM
jordansanders closed D7641: Fix typo.
Wed, Apr 28, 9:21 PM
jordansanders committed R1:6e32738d0720: Fix typo (authored by jordansanders).
Fix typo
Wed, Apr 28, 9:21 PM
jordansanders requested review of D7641: Fix typo.
Wed, Apr 28, 8:30 PM
jordansanders accepted D7630: tone down testing concepts section.

A few typos that I trust you to fix without me re-reviewing plus an idea for the future.

Wed, Apr 28, 12:29 AM

Tue, Apr 27

jordansanders closed D7586: Remove get_test_helm_namespace.
Tue, Apr 27, 2:13 PM
jordansanders closed D7585: Extract configmap, aws_configmap, and secret.
Tue, Apr 27, 2:12 PM
jordansanders committed R1:883df03812d3: Remove get_test_helm_namespace (authored by jordansanders).
Remove get_test_helm_namespace
Tue, Apr 27, 2:12 PM
jordansanders committed R1:8d8e5b37c8db: Extract configmap, aws_configmap, and secret (authored by jordansanders).
Extract configmap, aws_configmap, and secret
Tue, Apr 27, 2:12 PM
jordansanders closed D7584: Remove _helm_namespace_helper.
Tue, Apr 27, 2:12 PM
jordansanders committed R1:4e5b1f9b9450: Remove _helm_namespace_helper (authored by jordansanders).
Remove _helm_namespace_helper
Tue, Apr 27, 2:12 PM
jordansanders closed D7583: Extract namespace fixture.
Tue, Apr 27, 2:12 PM
jordansanders closed D7582: Extract should_cleanup fixture.
Tue, Apr 27, 2:12 PM
jordansanders committed R1:4bbbd0e405ea: Extract namespace fixture (authored by jordansanders).
Extract namespace fixture
Tue, Apr 27, 2:12 PM
jordansanders committed R1:3137cbdfe174: Extract should_cleanup fixture (authored by jordansanders).
Extract should_cleanup fixture
Tue, Apr 27, 2:12 PM
jordansanders closed D7581: Get helm fixtures as a pytest plugin.
Tue, Apr 27, 2:12 PM
jordansanders committed R1:89a8759ab1c7: Get helm fixtures as a pytest plugin (authored by jordansanders).
Get helm fixtures as a pytest plugin
Tue, Apr 27, 2:12 PM
jordansanders closed D7580: Use pytestconfig fixture instead of request.
Tue, Apr 27, 2:12 PM
jordansanders committed R1:9da0b13ad220: Use pytestconfig fixture instead of request (authored by jordansanders).
Use pytestconfig fixture instead of request
Tue, Apr 27, 2:12 PM

Mon, Apr 26

jordansanders closed D7568: Allow user deployment startup probes to be disabled in helm charts.
Mon, Apr 26, 6:33 PM
jordansanders committed R1:1eb696e11566: Allow user deployment startup probes to be disabled in helm charts (authored by jordansanders).
Allow user deployment startup probes to be disabled in helm charts
Mon, Apr 26, 6:33 PM
jordansanders requested review of D7585: Extract configmap, aws_configmap, and secret.
Mon, Apr 26, 6:33 PM
jordansanders requested review of D7586: Remove get_test_helm_namespace.
Mon, Apr 26, 6:31 PM
jordansanders updated the diff for D7584: Remove _helm_namespace_helper.

Rebase

Mon, Apr 26, 4:44 PM
jordansanders updated the diff for D7583: Extract namespace fixture.

Rebase

Mon, Apr 26, 4:44 PM
jordansanders updated the diff for D7582: Extract should_cleanup fixture.

Rebase

Mon, Apr 26, 4:43 PM
jordansanders updated the diff for D7581: Get helm fixtures as a pytest plugin.

Rebase

Mon, Apr 26, 4:43 PM
jordansanders updated the diff for D7580: Use pytestconfig fixture instead of request.

Rebase

Mon, Apr 26, 4:42 PM
jordansanders requested review of D7584: Remove _helm_namespace_helper.
Mon, Apr 26, 4:38 PM
jordansanders closed D7588: Add directions for running integration tests locally.
Mon, Apr 26, 4:29 PM
jordansanders committed R1:9aa00edef749: Add directions for running integration tests locally (authored by jordansanders).
Add directions for running integration tests locally
Mon, Apr 26, 4:29 PM
jordansanders updated the diff for D7568: Allow user deployment startup probes to be disabled in helm charts.

s/comment out/disable

Mon, Apr 26, 4:28 PM
jordansanders updated the diff for D7583: Extract namespace fixture.

helm_namespace_for_user_deployments_subchart_disabled should continue to require the helm_namespace_for_user_deployments_subchart fixture

Mon, Apr 26, 4:10 PM

Fri, Apr 23

jordansanders requested review of D7581: Get helm fixtures as a pytest plugin.
Fri, Apr 23, 9:23 PM
jordansanders requested review of D7580: Use pytestconfig fixture instead of request.
Fri, Apr 23, 9:21 PM
jordansanders requested review of D7588: Add directions for running integration tests locally.
Fri, Apr 23, 9:20 PM
jordansanders updated the diff for D7583: Extract namespace fixture.

rebase

Fri, Apr 23, 9:06 PM
jordansanders updated the diff for D7582: Extract should_cleanup fixture.

rebase

Fri, Apr 23, 9:05 PM
jordansanders requested review of D7583: Extract namespace fixture.
Fri, Apr 23, 8:52 PM
jordansanders requested review of D7582: Extract should_cleanup fixture.
Fri, Apr 23, 8:50 PM
jordansanders closed D7561: Allow daemon startup probes to be disabled in helm charts.
Fri, Apr 23, 2:08 PM
jordansanders committed R1:01ad554aab4c: Allow daemon startup probes to be disabled in helm charts (authored by jordansanders).
Allow daemon startup probes to be disabled in helm charts
Fri, Apr 23, 2:08 PM
jordansanders closed D7560: Allow dagit startup probes to be disabled in helm charts.
Fri, Apr 23, 2:08 PM
jordansanders committed R1:756b3626351e: Allow dagit startup probes to be disabled in helm charts (authored by jordansanders).
Allow dagit startup probes to be disabled in helm charts
Fri, Apr 23, 2:07 PM
jordansanders closed D7545: Run make build from same directory as the README.
Fri, Apr 23, 2:06 PM
jordansanders committed R1:2bc6f7991b4c: Run make build from same directory as the README (authored by jordansanders).
Run make build from same directory as the README
Fri, Apr 23, 2:06 PM

Thu, Apr 22

jordansanders requested review of D7568: Allow user deployment startup probes to be disabled in helm charts.
Thu, Apr 22, 10:26 PM
jordansanders updated the diff for D7561: Allow daemon startup probes to be disabled in helm charts.

up

Thu, Apr 22, 8:35 PM
jordansanders updated the diff for D7560: Allow dagit startup probes to be disabled in helm charts.

up

Thu, Apr 22, 8:35 PM
jordansanders updated the diff for D7560: Allow dagit startup probes to be disabled in helm charts.

Schema apply

Thu, Apr 22, 8:33 PM
jordansanders updated the diff for D7560: Allow dagit startup probes to be disabled in helm charts.

Apply schema

Thu, Apr 22, 8:29 PM
jordansanders retitled D7560: Allow dagit startup probes to be disabled in helm charts from Enable/disable dagit startupProbe to Allow dagit startup probes to be disabled in helm charts.
Thu, Apr 22, 8:10 PM
jordansanders retitled D7561: Allow daemon startup probes to be disabled in helm charts from Enable/disable Dagster Daemon to Allow daemon startup probes to be disabled in helm charts.
Thu, Apr 22, 8:09 PM
jordansanders requested review of D7561: Allow daemon startup probes to be disabled in helm charts.
Thu, Apr 22, 8:04 PM
jordansanders requested review of D7560: Allow dagit startup probes to be disabled in helm charts.
Thu, Apr 22, 7:42 PM
jordansanders requested review of D7561: Allow daemon startup probes to be disabled in helm charts.
Thu, Apr 22, 7:42 PM

Wed, Apr 21

jordansanders requested review of D7545: Run make build from same directory as the README.
Wed, Apr 21, 8:07 PM
jordansanders closed D7543: Revert "Revert "Configure celery_k8s_job_executor job timeouts"".
Wed, Apr 21, 7:00 PM
jordansanders added a reverting change for D7542: Revert "Configure celery_k8s_job_executor job timeouts": R1:603f35863163: Revert "Revert "Configure celery_k8s_job_executor job timeouts"".
Wed, Apr 21, 7:00 PM
jordansanders added a reverting change for R1:bae69965a5a4: Revert "Configure celery_k8s_job_executor job timeouts": R1:603f35863163: Revert "Revert "Configure celery_k8s_job_executor job timeouts"".
Wed, Apr 21, 7:00 PM
jordansanders committed R1:603f35863163: Revert "Revert "Configure celery_k8s_job_executor job timeouts"" (authored by jordansanders).
Revert "Revert "Configure celery_k8s_job_executor job timeouts""
Wed, Apr 21, 7:00 PM
jordansanders requested review of D7543: Revert "Revert "Configure celery_k8s_job_executor job timeouts"".
Wed, Apr 21, 6:49 PM
jordansanders added a reverting change for D7542: Revert "Configure celery_k8s_job_executor job timeouts": D7543: Revert "Revert "Configure celery_k8s_job_executor job timeouts"".
Wed, Apr 21, 6:24 PM
jordansanders added a reverting change for R1:bae69965a5a4: Revert "Configure celery_k8s_job_executor job timeouts": D7543: Revert "Revert "Configure celery_k8s_job_executor job timeouts"".
Wed, Apr 21, 6:24 PM
jordansanders closed D7542: Revert "Configure celery_k8s_job_executor job timeouts".
Wed, Apr 21, 5:49 PM
jordansanders added a reverting change for D7532: Configure celery_k8s_job_executor job timeouts: R1:bae69965a5a4: Revert "Configure celery_k8s_job_executor job timeouts".
Wed, Apr 21, 5:49 PM
jordansanders added a reverting change for R1:d64bcf59ccf8: Configure celery_k8s_job_executor job timeouts: R1:bae69965a5a4: Revert "Configure celery_k8s_job_executor job timeouts".
Wed, Apr 21, 5:49 PM
jordansanders committed R1:bae69965a5a4: Revert "Configure celery_k8s_job_executor job timeouts" (authored by jordansanders).
Revert "Configure celery_k8s_job_executor job timeouts"
Wed, Apr 21, 5:49 PM
jordansanders added a comment to D7539: Revert "Better error handling when the daemon hits an error while trying to check a heartbeat".

Not on diffs unless you put Integration in the test plan, which I foolishly
did not

Wed, Apr 21, 5:48 PM
jordansanders added a reverting change for D7532: Configure celery_k8s_job_executor job timeouts: D7542: Revert "Configure celery_k8s_job_executor job timeouts".
Wed, Apr 21, 5:46 PM
jordansanders added a reverting change for R1:d64bcf59ccf8: Configure celery_k8s_job_executor job timeouts: D7542: Revert "Configure celery_k8s_job_executor job timeouts".
Wed, Apr 21, 5:46 PM
jordansanders accepted D7539: Revert "Better error handling when the daemon hits an error while trying to check a heartbeat".

Does buildkite not run the integration test in question for us?

Wed, Apr 21, 4:55 PM
jordansanders closed D7532: Configure celery_k8s_job_executor job timeouts.
Wed, Apr 21, 4:31 PM