Page MenuHomeElementl

johann (Johann Miller)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jun 15 2020, 1:38 PM (44 w, 2 h)
Roles
Administrator

Recent Activity

Today

johann accepted D7460: Recover from failed backfills, populate backfill errors.
Mon, Apr 19, 1:28 PM

Fri, Apr 16

johann added a comment to D7478: [Helm] Allow configuration of postgres connection string on storage classes.

It might be helpful to get more context from the user, are there cases where they couldn't just pull out the user/password/etc? Looks like it wouldn't be too hard postgresql://[user[:password]@][netloc][:port][/dbname][?param1=value1&...]

Fri, Apr 16, 7:35 PM

Tue, Apr 13

johann accepted D7398: Change today_at_midnight default timezone to UTC.
Tue, Apr 13, 2:23 PM

Fri, Apr 9

johann closed D7370: K8sRunLauncher make postgres optional.
Fri, Apr 9, 6:37 PM
johann committed R1:e2617ae70897: K8sRunLauncher make postgres optional (authored by johann).
K8sRunLauncher make postgres optional
Fri, Apr 9, 6:37 PM
johann updated the diff for D7370: K8sRunLauncher make postgres optional.

up

Fri, Apr 9, 5:56 PM
johann requested review of D7370: K8sRunLauncher make postgres optional.
Fri, Apr 9, 5:15 PM
johann updated the diff for D7364: Dump dagster debug exports in integration tests.

up

Fri, Apr 9, 2:01 AM
johann updated the diff for D7364: Dump dagster debug exports in integration tests.

use current test in filename

Fri, Apr 9, 1:59 AM
johann published D7364: Dump dagster debug exports in integration tests for review.

@alangenfeld looks like only runs from user deployments have pipeline_snapshot_ids? Does debug export work without grpc servers?

Fri, Apr 9, 1:54 AM

Tue, Apr 6

johann accepted D7319: Make more dagster grpc server parameters controllable via env var.
Tue, Apr 6, 8:08 PM
johann requested changes to D7319: Make more dagster grpc server parameters controllable via env var.

Just realized this is a click feature, should we use this instead? https://click.palletsprojects.com/en/7.x/options/#values-from-environment-variables

Tue, Apr 6, 4:11 PM
johann closed D7292: Add docker image run tag in k8s launchers.
Tue, Apr 6, 3:15 PM
johann committed R1:b55b46c2f384: Add docker image run tag in k8s launchers (authored by johann).
Add docker image run tag in k8s launchers
Tue, Apr 6, 3:15 PM
johann updated the diff for D7292: Add docker image run tag in k8s launchers.

feedback

Tue, Apr 6, 2:22 PM

Sat, Apr 3

johann requested review of D7292: Add docker image run tag in k8s launchers.
Sat, Apr 3, 1:05 AM

Fri, Apr 2

alangenfeld empowered johann as an administrator.
Fri, Apr 2, 6:29 PM
johann accepted D7257: Merge Helm repo index when packaging release.
Fri, Apr 2, 4:24 PM
johann accepted D7272: Update Helm for 0.11.3.
Fri, Apr 2, 3:07 PM

Thu, Apr 1

johann accepted D7263: clarify apidoc for mode arg of sensor decorator.
Thu, Apr 1, 9:23 PM
johann accepted D7253: [helm] Allow creation of workspace from dagit values.
Thu, Apr 1, 8:23 PM
johann added a comment to D7253: [helm] Allow creation of workspace from dagit values.

Good point about the subchart. I don't love putting it under dagit- makes sense to us, but I don't think they seem related for users. Breaking change, but what if the subchart was under an additional yaml key? So that additional values related to user deployments could be under the userDeployments key?

Thu, Apr 1, 7:38 PM
johann requested changes to D7253: [helm] Allow creation of workspace from dagit values.

I think the field would be more natural under userDeployments than dagit

Thu, Apr 1, 3:04 PM
johann accepted D7252: Reorganize helm user deployment template tests.
Thu, Apr 1, 2:58 PM
johann accepted D7254: Mark Helm values schema as generated.
Thu, Apr 1, 2:57 PM
johann accepted D7255: Update Chart.yaml for Artifacthub.
Thu, Apr 1, 2:56 PM

Wed, Mar 31

johann accepted D7245: [airflow] clean up dead code.
Wed, Mar 31, 6:19 PM

Thu, Mar 25

johann accepted D7147: Allow global service account for Dagster Helm chart.
Thu, Mar 25, 8:27 PM
johann accepted D7125: Roll user deployments if Helm values change.

Yay tests!

Thu, Mar 25, 8:25 PM
johann closed D7140: Clarify dagster/priority docs.
Thu, Mar 25, 2:25 PM
johann committed R1:01d839d91998: Clarify dagster/priority docs (authored by johann).
Clarify dagster/priority docs
Thu, Mar 25, 2:25 PM
johann updated the diff for D7140: Clarify dagster/priority docs.

up

Thu, Mar 25, 2:24 PM
johann requested review of D7140: Clarify dagster/priority docs.
Thu, Mar 25, 1:12 PM

Wed, Mar 24

johann accepted D7121: ephemeral instance required daemons.
Wed, Mar 24, 4:03 PM

Tue, Mar 23

johann accepted D7070: Update helm release cli to take chart path.
Tue, Mar 23, 5:53 PM

Mon, Mar 22

johann closed D7105: Update changelog 0.11.1.
Mon, Mar 22, 10:49 PM
johann committed R1:4511b56a7f30: Update changelog 0.11.1 (authored by johann).
Update changelog 0.11.1
Mon, Mar 22, 10:49 PM
johann committed R1:6f9570b4760a: 0.11.1 (authored by johann).
0.11.1
Mon, Mar 22, 10:27 PM
johann accepted D7104: [docs-infra] feedback "cancel" button.
Mon, Mar 22, 10:22 PM
johann committed R1:79da973815a6: 0.11.1.pre0 (authored by johann).
0.11.1.pre0
Mon, Mar 22, 10:10 PM
johann closed D7101: 0.11.1 Changelog.
Mon, Mar 22, 10:00 PM
johann committed R1:0668d87e629a: 0.11.1 Changelog (authored by johann).
0.11.1 Changelog
Mon, Mar 22, 10:00 PM
johann updated the diff for D7101: 0.11.1 Changelog.

up

Mon, Mar 22, 9:58 PM
johann requested review of D7101: 0.11.1 Changelog.
Mon, Mar 22, 9:36 PM
johann accepted D7083: skip flaky test in windows.

Any guess why it flakes on windows? Could be good to leave a note

Mon, Mar 22, 2:48 PM
johann accepted D7086: Remove external_pipeline_from_run.
Mon, Mar 22, 2:46 PM
johann abandoned D6765: RFC: cancel runs via daemon.
Mon, Mar 22, 2:43 PM
johann abandoned D6349: Select daemon types for controller.
Mon, Mar 22, 2:42 PM

Mar 13 2021

johann accepted D6930: [docs] Elaborate on configuration in the Dagster Deployment Overview.

1 fix, otherwise lgtm. Thank you!

Mar 13 2021, 4:15 AM
johann closed D6918: Dagster deployment overview docs.
Mar 13 2021, 1:36 AM
johann committed R1:ef9c9bfce198: Dagster deployment overview docs (authored by johann).
Dagster deployment overview docs
Mar 13 2021, 1:36 AM
johann updated the diff for D6918: Dagster deployment overview docs.

Feedback

Mar 13 2021, 1:35 AM
johann updated the diff for D6918: Dagster deployment overview docs.

rebase

Mar 13 2021, 12:45 AM

Mar 12 2021

johann added a comment to D6918: Dagster deployment overview docs.

Missing links for run config and executor pages

Mar 12 2021, 6:56 PM
johann updated the diff for D6918: Dagster deployment overview docs.

links

Mar 12 2021, 6:54 PM
johann published D6918: Dagster deployment overview docs for review.

Rendered, since tables are hard to read

Mar 12 2021, 5:41 PM
johann accepted D6854: remove dashes from run concurrency docs code snippet.
Mar 12 2021, 1:47 AM

Mar 11 2021

johann added a reviewer for D6881: Remove checksum annotations in Helm user code deployments: dgibson.
Mar 11 2021, 8:14 PM
johann added a comment to D6881: Remove checksum annotations in Helm user code deployments.

Does that hold true if we use Instance.get()? https://dagster.phacility.com/D6883

Mar 11 2021, 8:14 PM
johann requested changes to D6881: Remove checksum annotations in Helm user code deployments.

user code containers should not need to redeploy if the Dagit instance changes.

Mar 11 2021, 3:35 PM

Mar 10 2021

johann accepted D6869: [RFC][docs] Dagster Deployment nav.

This is ok with me, but we might benefit from another level of hierarchy under 'deployment'. It's a somewhat scattered collection of objects (coordinators/launchers/storages that are configured on the instance, executors in run config, and the daemon which is a service). However I do think all this stuff fits the bill of 'things you consider after you have written your first pipelines and are looking to host them somewhere'

Mar 10 2021, 5:46 PM

Mar 9 2021

johann accepted D6836: [dagit] Add warning Alert for unhealthy queue daemon.
Mar 9 2021, 10:02 PM
johann resigned from D6651: [RFC] Add Helm job to migrate Dagster instance.

Nice! Existing feedback looks good to me

Mar 9 2021, 9:57 PM
johann accepted D6709: [RFC] Implement Helm user code deployment tests.

I think this lgtm. Per offline discussion, might use something like kubeval rather than deserializing with the k8s client

Mar 9 2021, 8:46 PM
johann added a comment to D6836: [dagit] Add warning Alert for unhealthy queue daemon.

How about The Queued run coordinator daemon has errors? Not running is an error, we surface it as one on the status page

Mar 9 2021, 7:14 PM

Mar 8 2021

johann updated the test plan for D6813: Enable grpc health check probe by default.
Mar 8 2021, 1:45 PM

Mar 5 2021

johann added inline comments to D6813: Enable grpc health check probe by default.
Mar 5 2021, 8:03 PM
johann updated subscribers of D6813: Enable grpc health check probe by default.
Mar 5 2021, 8:02 PM
johann requested review of D6813: Enable grpc health check probe by default.
Mar 5 2021, 7:17 PM
johann added a comment to D6805: fix indentation in versions.yaml.

Whoops! Thank you for fixing

Mar 5 2021, 2:11 PM

Mar 4 2021

johann added inline comments to D6765: RFC: cancel runs via daemon.
Mar 4 2021, 5:28 PM

Mar 3 2021

johann accepted D6706: Add support for pushing built images to ECR.
Mar 3 2021, 8:45 PM
johann updated the summary of D6765: RFC: cancel runs via daemon.
Mar 3 2021, 8:12 PM
johann published D6765: RFC: cancel runs via daemon for review.
Mar 3 2021, 8:12 PM
johann accepted D6757: Fix sensor loop handle cleanup.
Mar 3 2021, 3:20 PM

Mar 2 2021

johann closed D6750: Increase event log watch test timeout (avoid flakes).
Mar 2 2021, 8:19 PM
johann committed R1:b60018f90b63: Increase event log watch test timeout (avoid flakes) (authored by johann).
Increase event log watch test timeout (avoid flakes)
Mar 2 2021, 8:19 PM
johann requested review of D6750: Increase event log watch test timeout (avoid flakes).
Mar 2 2021, 7:30 PM
johann closed D6730: Remove experimental from queued run daemon.
Mar 2 2021, 4:06 PM
johann committed R1:c009e4d3726c: Remove experimental from queued run daemon (authored by johann).
Remove experimental from queued run daemon
Mar 2 2021, 4:06 PM
johann updated the summary of D6730: Remove experimental from queued run daemon.
Mar 2 2021, 3:57 AM
johann requested review of D6730: Remove experimental from queued run daemon.
Mar 2 2021, 1:01 AM

Mar 1 2021

johann added inline comments to D6722: Share grpc server processes between daemon threads.
Mar 1 2021, 5:35 PM

Feb 27 2021

johann published D6717: [RFC] Instance health query for review.
Feb 27 2021, 1:29 AM

Feb 26 2021

johann accepted D6710: Add redis to buildkite-integration-base.
Feb 26 2021, 11:39 PM
johann closed D6692: Drop failing runs in the queue daemon.
Feb 26 2021, 10:30 PM
johann committed R1:d67839661337: Drop failing runs in the queue daemon (authored by johann).
Drop failing runs in the queue daemon
Feb 26 2021, 10:30 PM
johann accepted D6675: Let daemons be contextmanagers.
Feb 26 2021, 5:57 PM
johann updated the diff for D6692: Drop failing runs in the queue daemon.

feedback

Feb 26 2021, 5:52 PM
johann requested review of D6692: Drop failing runs in the queue daemon.
Feb 26 2021, 3:07 AM
johann closed D6652: Fix mislabeled image python versions.
Feb 26 2021, 12:17 AM
johann committed R1:978e7eab3705: Fix mislabeled image python versions (authored by johann).
Fix mislabeled image python versions
Feb 26 2021, 12:17 AM

Feb 24 2021

johann accepted D6654: Log heartbeats during the first daemon iteration (while keeping the first error heartbeat).
Feb 24 2021, 10:55 PM
johann requested review of D6652: Fix mislabeled image python versions.
Feb 24 2021, 1:04 AM

Feb 18 2021

johann closed D6573: Use correct command for liveness-check.
Feb 18 2021, 7:34 PM
johann committed R1:beed649715c9: Use correct command for liveness-check (authored by johann).
Use correct command for liveness-check
Feb 18 2021, 7:34 PM
johann added a comment to D6573: Use correct command for liveness-check.

There's an existing test that differentiates the all_daemons_healthy and all_daemons_live functions, but it doesn't actually invoke the cli. I guess it's time to bring the cli under test?

Feb 18 2021, 6:28 PM
johann requested review of D6573: Use correct command for liveness-check.
Feb 18 2021, 6:04 PM
johann accepted D6552: add sensor daemon interval docs, individual interval mismatch warnings.

Looks good!

Feb 18 2021, 2:02 PM

Feb 16 2021

johann closed D6478: [Easy] Missed run coordinator -> run worker switches.
Feb 16 2021, 11:39 PM