Page MenuHomeElementl

johann (Johann Miller)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jun 15 2020, 1:38 PM (69 w, 6 d)
Roles
Administrator

Recent Activity

Aug 6 2021

johann abandoned D9162: Move termination status checks from launcher to instance.
Aug 6 2021, 10:46 PM

Aug 3 2021

johann requested changes to D9178: add secrets/config maps from the executor config to the run launcher config, rather than replacing them.

Should dedup the the lists? Or at least test behavior with duplicates (I think that's already happening in the integration test?)

Aug 3 2021, 2:31 PM

Jul 30 2021

johann updated the summary of D9162: Move termination status checks from launcher to instance.
Jul 30 2021, 5:26 PM
johann published D9162: Move termination status checks from launcher to instance for review.
Jul 30 2021, 5:22 PM

Jul 28 2021

johann accepted D9078: delegate k8s executor config to run launcher if it isn't set, instead of assuming default.

lgtm

Jul 28 2021, 5:33 PM
johann accepted D9117: Make ttl and backoff limit customizable.
Jul 28 2021, 4:10 PM

Jul 27 2021

johann accepted D9080: fix(helm): use correct templating logic for compute log manager.
Jul 27 2021, 4:09 PM
johann accepted D9078: delegate k8s executor config to run launcher if it isn't set, instead of assuming default.
Jul 27 2021, 3:17 PM

Jul 21 2021

johann accepted D8995: More narrowly scope IAM policies.
Jul 21 2021, 9:38 PM
johann requested changes to D8995: More narrowly scope IAM policies.

Do we support termination? Dagit makes that api call if so

Jul 21 2021, 8:15 PM

Jul 15 2021

johann accepted D8910: Don't inherit entryPoint from Task Definition.

users might still run into this issue when their image contains an ENTRYPOINT.

Jul 15 2021, 10:59 PM

Jul 14 2021

johann accepted D8841: [docs] Dagster K8s deployment guide corrections - GH Issue #4234.

Good stuff

Jul 14 2021, 7:09 PM

Jul 8 2021

johann closed D8772: Add step tags to StepHandlerContext.
Jul 8 2021, 6:36 PM
johann committed R1:4d35fda5cf4c: Add step tags to StepHandlerContext (authored by johann).
Add step tags to StepHandlerContext
Jul 8 2021, 6:36 PM
johann closed D8751: Remove persisted StepHandlerContext.
Jul 8 2021, 6:29 PM
johann committed R1:842360ef3a56: Remove persisted StepHandlerContext (authored by johann).
Remove persisted StepHandlerContext
Jul 8 2021, 6:29 PM
johann closed D8744: k8s executor client config.
Jul 8 2021, 6:28 PM
johann committed R1:548c2383e26d: k8s executor client config (authored by johann).
k8s executor client config
Jul 8 2021, 6:28 PM
johann updated the diff for D8772: Add step tags to StepHandlerContext.

up

Jul 8 2021, 6:15 PM
johann updated the diff for D8744: k8s executor client config.

remove config defaults

Jul 8 2021, 6:04 PM
johann published D8772: Add step tags to StepHandlerContext for review.
Jul 8 2021, 5:55 PM
johann added a comment to D8744: k8s executor client config.

Would make sense to move to the DagsterKubernetesClient, that said we don't currently use it directly in either of the k8s launchers or the celery k8s executor. So I think it's a general refactor to move our classes away from using the k8s lib directly

Jul 8 2021, 5:05 PM
johann accepted D8759: [Content Gap] K8s Job/Pod ttl help.

Excellent. Could consider mentioning 3rd party solutions, e.g.

Jul 8 2021, 4:58 PM

Jul 7 2021

johann added reviewers for D8751: Remove persisted StepHandlerContext: rexledesma, jordansanders.
Jul 7 2021, 10:40 PM
johann published D8751: Remove persisted StepHandlerContext for review.
Jul 7 2021, 10:39 PM
johann published D8744: k8s executor client config for review.
Jul 7 2021, 10:39 PM
johann closed D8739: Bug: log k8s executor events.
Jul 7 2021, 10:19 PM
johann committed R1:3883cdfc7d67: Bug: log k8s executor events (authored by johann).
Bug: log k8s executor events
Jul 7 2021, 10:19 PM
johann requested review of D8739: Bug: log k8s executor events.

Changed approach to log from the step_delegating_executor rather than the step handlers, because the executor has the step contexts and can log correctly. this also means you don't have to remember to log the individual events.

Jul 7 2021, 9:25 PM
johann updated the diff for D8739: Bug: log k8s executor events.

change approach

Jul 7 2021, 9:23 PM
johann published D8739: Bug: log k8s executor events for review.
Jul 7 2021, 6:03 PM
johann accepted D8737: feat!: add schema in Helm for run coordinator.
Jul 7 2021, 5:26 PM
johann accepted D8738: feat!: rename queuedRunCoordinator to runCoordinator in Helm.
Jul 7 2021, 5:25 PM
johann accepted D8660: beef up deploy docker docs.
Jul 7 2021, 6:13 AM
johann accepted D8717: Let custom instance classes override the default configurable class data.

nice

Jul 7 2021, 6:03 AM
johann accepted D8656: docs for DAGSTER_CURRENT_IMAGE.

Wow I had forgotten this was necessary

Jul 7 2021, 5:44 AM

Jul 6 2021

johann accepted D8688: Introduce docker compose fixtures.
Jul 6 2021, 2:46 PM
johann added a comment to D8688: Introduce docker compose fixtures.

Awesome! Could move description from the diff to code comments

Jul 6 2021, 2:46 PM

Jul 2 2021

johann closed D8676: Dispose local compute log manager.
Jul 2 2021, 5:58 PM
johann committed R1:43cab32d8773: Dispose local compute log manager (authored by johann).
Dispose local compute log manager
Jul 2 2021, 5:58 PM
johann published D8676: Dispose local compute log manager for review.
Jul 2 2021, 4:15 PM

Jun 28 2021

johann resigned from D8527: dagit_base_url instance setting.
Jun 28 2021, 5:01 PM

Jun 25 2021

johann added a comment to D8527: dagit_base_url instance setting.

Read only dagit would be an example of a second dagit (with a new url) pointed at the same instance

Jun 25 2021, 9:33 PM

Jun 24 2021

johann committed R1:8d009a51c952: remove rc docs (authored by johann).
remove rc docs
Jun 24 2021, 11:17 PM
johann added a reverting change for D8519: Remove rc docs: R1:f969a3b24e66: Revert "Remove rc docs".
Jun 24 2021, 10:20 PM
johann committed R1:f969a3b24e66: Revert "Remove rc docs" (authored by johann).
Revert "Remove rc docs"
Jun 24 2021, 10:20 PM
johann added a reverting change for R1:5811daa28732: Remove rc docs: R1:f969a3b24e66: Revert "Remove rc docs".
Jun 24 2021, 10:20 PM
johann closed D8519: Remove rc docs.
Jun 24 2021, 9:41 PM
johann committed R1:5811daa28732: Remove rc docs (authored by johann).
Remove rc docs
Jun 24 2021, 9:41 PM
johann published D8519: Remove rc docs for review.
Jun 24 2021, 9:32 PM
johann closed D8517: 0.11.15 changelog.
Jun 24 2021, 9:21 PM
johann committed R1:9d66d75b2de0: 0.11.15 changelog (authored by johann).
0.11.15 changelog
Jun 24 2021, 9:21 PM
johann updated the diff for D8517: 0.11.15 changelog.

breaking changes section

Jun 24 2021, 9:09 PM
johann updated the diff for D8517: 0.11.15 changelog.

feedback

Jun 24 2021, 9:05 PM
johann published D8517: 0.11.15 changelog for review.
Jun 24 2021, 8:50 PM
johann accepted D8508: Allow grpc servers to be shut down over graphql.

If this happened enough on k8s via CD or something, k8s might go into crashloopbackoff. Looks like that's not tunable https://github.com/kubernetes/kubernetes/issues/57291. But users probably shouldn't hit it...
If they do, it's an exponential backoff capped at 5 min and clears after 10 min of successful running. Seems ok

Jun 24 2021, 5:48 PM

Jun 21 2021

johann accepted D8477: Add 'set_dagster_home' flag to instance_for_test.
Jun 21 2021, 6:42 PM

Jun 18 2021

johann added inline comments to D8439: [helm] Add k8s fields to pydantic schema.
Jun 18 2021, 7:12 PM
johann resigned from D8321: Add CLI command to reset migration state.
Jun 18 2021, 3:55 PM

Jun 16 2021

johann closed D8393: Add instance to compute log manager.
Jun 16 2021, 3:00 PM
johann committed R1:6dbacf29da37: Add instance to compute log manager (authored by johann).
Add instance to compute log manager
Jun 16 2021, 3:00 PM
johann requested review of D8393: Add instance to compute log manager.
Jun 16 2021, 1:52 PM

Jun 15 2021

johann accepted D8388: docs: clarify instructions when installing old Helm Chart versions.
Jun 15 2021, 9:02 PM
johann requested changes to D8353: Dockerfile for hacker news example.

Going to discuss offline

Jun 15 2021, 8:49 PM
johann accepted D8377: Speed up deploy-docker build.sh file.
Jun 15 2021, 5:50 PM

Jun 10 2021

johann accepted D8301: feat: set default image tags of Dagster provided images in Helm chart to current Chart version.

Awesome! I think this will deserve at least a callout in the #dagster-kubernetes channel, it's a decent quality-of-life improvement.

Jun 10 2021, 1:31 PM

Jun 9 2021

johann added a comment to D8292: Add a reference deployment for ECS.

I like this direction too.

Jun 9 2021, 2:03 PM

Jun 7 2021

johann closed D8252: k8s executor user defined config.
Jun 7 2021, 11:02 PM
johann committed R1:a03c580f158e: k8s executor user defined config (authored by johann).
k8s executor user defined config
Jun 7 2021, 11:02 PM
johann closed D8251: K8s executor use pipeline origin image.
Jun 7 2021, 11:02 PM
johann committed R1:21bca3bc763a: K8s executor use pipeline origin image (authored by johann).
K8s executor use pipeline origin image
Jun 7 2021, 11:02 PM
johann updated the diff for D8252: k8s executor user defined config.

up

Jun 7 2021, 9:42 PM
johann updated the diff for D8252: k8s executor user defined config.

up

Jun 7 2021, 8:24 PM

Jun 4 2021

johann retitled D8252: k8s executor user defined config from User defined k8s executor config to k8s executor user defined config.
Jun 4 2021, 10:58 PM
johann updated the diff for D8252: k8s executor user defined config.

test

Jun 4 2021, 10:57 PM
johann requested review of D8252: k8s executor user defined config.
Jun 4 2021, 8:45 PM
johann requested review of D8251: K8s executor use pipeline origin image.
Jun 4 2021, 8:36 PM
johann closed D8197: K8s executor docs.
Jun 4 2021, 5:37 PM
johann committed R1:0567e6699536: K8s executor docs (authored by johann).
K8s executor docs
Jun 4 2021, 5:37 PM
johann updated the diff for D8197: K8s executor docs.

up

Jun 4 2021, 4:23 PM
johann updated the test plan for D8197: K8s executor docs.
Jun 4 2021, 4:19 PM
johann updated the diff for D8197: K8s executor docs.

feedback

Jun 4 2021, 3:59 PM
johann added inline comments to D8197: K8s executor docs.
Jun 4 2021, 3:52 PM
johann added a comment to D8227: Don't call DagsterInstance.get() in create_daemon_of_type.

Should we consider raising an error when .get is called outside of a context manager? Something like https://stackoverflow.com/a/54514410/14656695

Jun 4 2021, 1:44 PM

Jun 3 2021

johann abandoned D8027: k8s executor terminate.
Jun 3 2021, 10:41 PM
johann closed D8218: Separate interval for check step health.
Jun 3 2021, 6:20 PM
johann committed R1:399bddf4f604: Separate interval for check step health (authored by johann).
Separate interval for check step health
Jun 3 2021, 6:20 PM
johann added inline comments to D8218: Separate interval for check step health.
Jun 3 2021, 4:56 PM
johann added inline comments to D8218: Separate interval for check step health.
Jun 3 2021, 4:54 PM
johann added inline comments to D8218: Separate interval for check step health.
Jun 3 2021, 4:47 PM
johann requested review of D8218: Separate interval for check step health.
Jun 3 2021, 3:50 PM

Jun 2 2021

johann updated the diff for D8197: K8s executor docs.

up

Jun 2 2021, 6:49 PM
johann closed D8196: K8s executor logging.
Jun 2 2021, 6:42 PM
johann committed R1:8e0913b2a2c1: K8s executor logging (authored by johann).
K8s executor logging
Jun 2 2021, 6:42 PM
johann added reviewers for D8197: K8s executor docs: jordansanders, dgibson, yuhan.
Jun 2 2021, 6:40 PM
johann added inline comments to D8197: K8s executor docs.
Jun 2 2021, 6:40 PM
johann updated the diff for D8197: K8s executor docs.

up

Jun 2 2021, 6:38 PM
johann updated the diff for D8197: K8s executor docs.

up

Jun 2 2021, 6:30 PM
johann updated the diff for D8197: K8s executor docs.

up

Jun 2 2021, 6:23 PM
johann updated the diff for D8197: K8s executor docs.

up

Jun 2 2021, 5:52 PM