Page MenuHomePhabricator

johann (Johann Miller)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 15 2020, 1:38 PM (31 w, 6 d)

Recent Activity

Fri, Jan 22

johann updated the diff for D6010: Run queuing enabled endpoint.

rebase

Fri, Jan 22, 5:13 PM
johann closed D6104: Fix typos on the troubleshooting pages.
Fri, Jan 22, 2:34 PM
johann committed R1:ac6f46105bca: Fix typos on the troubleshooting pages (authored by johann).
Fix typos on the troubleshooting pages
Fri, Jan 22, 2:34 PM
johann closed D6103: Fix queue troubleshooting docs typo.
Fri, Jan 22, 2:28 PM
johann committed R1:4f97dc33aef6: Fix queue troubleshooting docs typo (authored by johann).
Fix queue troubleshooting docs typo
Fri, Jan 22, 2:28 PM
johann updated the diff for D6010: Run queuing enabled endpoint.

up

Fri, Jan 22, 1:51 PM
johann added a comment to D6010: Run queuing enabled endpoint.

Is there a lighter weight way to do this test

Fri, Jan 22, 1:26 PM
johann updated the diff for D6010: Run queuing enabled endpoint.

add test

Fri, Jan 22, 1:26 PM

Wed, Jan 20

johann closed D6045: Run queue troubleshooting doc.
Wed, Jan 20, 8:19 PM
johann committed R1:63ace7e91454: Run queue troubleshooting doc (authored by johann).
Run queue troubleshooting doc
Wed, Jan 20, 8:19 PM
johann updated the diff for D6045: Run queue troubleshooting doc.

up

Wed, Jan 20, 8:18 PM
johann accepted D6057: Fix daemons not working in repo locations with more than one repo..
Wed, Jan 20, 5:17 PM

Tue, Jan 19

johann requested review of D6045: Run queue troubleshooting doc.
Tue, Jan 19, 10:12 PM
johann updated the test plan for D6010: Run queuing enabled endpoint.
Tue, Jan 19, 9:28 PM

Fri, Jan 15

johann accepted D6027: Fix deploy_docker example.
Fri, Jan 15, 4:00 PM

Thu, Jan 14

johann accepted D6015: Don't over-promise about daemon latency in the k8s docs.
Thu, Jan 14, 9:54 PM
johann added a comment to D6015: Don't over-promise about daemon latency in the k8s docs.
Thu, Jan 14, 9:54 PM
johann updated subscribers of D6010: Run queuing enabled endpoint.

@dish here's the endpoint for queuing, you could commandeer or I can land this after release

Thu, Jan 14, 9:20 PM
johann requested review of D6010: Run queuing enabled endpoint.
Thu, Jan 14, 9:14 PM
johann accepted D5994: pass on run coordinator/queueing copy.
Thu, Jan 14, 3:22 PM
johann accepted D5983: [easy] fix windows scheduler tests.
Thu, Jan 14, 1:51 AM

Wed, Jan 13

johann closed D5987: Fix run launcher link.
Wed, Jan 13, 11:52 PM
johann committed R1:82a77e6c387f: Fix run launcher link (authored by johann).
Fix run launcher link
Wed, Jan 13, 11:52 PM
johann closed D5876: Run queue docs.
Wed, Jan 13, 10:56 PM
johann committed R1:09da21d38ae2: Run queue docs (authored by johann).
Run queue docs
Wed, Jan 13, 10:56 PM
johann updated the diff for D5876: Run queue docs.

feedback

Wed, Jan 13, 10:33 PM
johann updated the diff for D5848: Surface multiple errors in daemon.

wait for first iteration to report heartbeat

Wed, Jan 13, 9:25 PM
johann published D5848: Surface multiple errors in daemon for review.

Publishing early, tests will fail due to missing gql changes

Wed, Jan 13, 9:16 PM
johann requested review of D5974: Update images in helm chart.
Wed, Jan 13, 8:34 PM
johann closed D5571: Refactor dagster k8s images.
Wed, Jan 13, 8:07 PM
johann committed R1:34701f462d81: Refactor dagster k8s images (authored by johann).
Refactor dagster k8s images
Wed, Jan 13, 8:07 PM
johann retitled D5876: Run queue docs from [Draft] Run concurrency docs to Run queue docs.
Wed, Jan 13, 7:18 PM
johann updated the diff for D5571: Refactor dagster k8s images.

update to py 3.8.7

Wed, Jan 13, 7:15 PM
johann updated the diff for D5571: Refactor dagster k8s images.

rebase

Wed, Jan 13, 7:12 PM
johann updated the diff for D5876: Run queue docs.

up

Wed, Jan 13, 6:56 PM
johann updated the diff for D5876: Run queue docs.

up

Wed, Jan 13, 6:35 PM
johann updated the diff for D5876: Run queue docs.

up

Wed, Jan 13, 6:08 PM
johann updated the diff for D5876: Run queue docs.

fix links

Wed, Jan 13, 5:47 PM
johann added inline comments to D5876: Run queue docs.
Wed, Jan 13, 5:16 PM
johann updated the diff for D5876: Run queue docs.

feedback

Wed, Jan 13, 5:15 PM
johann accepted D5943: daemon overview page.

lgtm

Wed, Jan 13, 1:59 AM

Mon, Jan 11

johann accepted D5911: [dagit] Repair counts for queued/in-progress run tabs.
Mon, Jan 11, 7:09 PM
johann added inline comments to D5911: [dagit] Repair counts for queued/in-progress run tabs.
Mon, Jan 11, 6:24 PM

Fri, Jan 8

johann added a comment to D5883: Remove experimental warning for queued run coordinator.

I believe doing it on the init is convention bc something breaks when it's on the class, it would be great if we could clarify the message though.

Fri, Jan 8, 9:01 PM
johann added a reviewer for D5876: Run queue docs: yuhan.
Fri, Jan 8, 4:05 PM
johann retitled D5876: Run queue docs from Run concurrency docs to [Draft] Run concurrency docs.
Fri, Jan 8, 4:04 PM
johann requested review of D5876: Run queue docs.
Fri, Jan 8, 3:51 PM
johann accepted D5793: Update dagsterDaemon documention in helm chart.
Fri, Jan 8, 2:14 PM

Thu, Jan 7

johann closed D5838: Reuse repo location handles in daemon.
Thu, Jan 7, 7:01 PM
johann committed R1:dbe25b476ced: Reuse repo location handles in daemon (authored by johann).
Reuse repo location handles in daemon
Thu, Jan 7, 7:01 PM
johann updated the diff for D5838: Reuse repo location handles in daemon.

feedback

Thu, Jan 7, 4:54 PM
johann updated the diff for D5838: Reuse repo location handles in daemon.

feedback

Thu, Jan 7, 1:58 PM

Wed, Jan 6

johann accepted D5845: Fix Buildkite integration tests.
Wed, Jan 6, 5:54 PM
johann closed D5835: Warn on multiple daemons.
Wed, Jan 6, 5:41 PM
johann committed R1:cd90ddd409b1: Warn on multiple daemons (authored by johann).
Warn on multiple daemons
Wed, Jan 6, 5:41 PM
johann retitled D5838: Reuse repo location handles in daemon from Memoize repo location handles in daemon to Reuse repo location handles in daemon.
Wed, Jan 6, 5:40 PM
johann updated the diff for D5838: Reuse repo location handles in daemon.

up

Wed, Jan 6, 5:38 PM
johann updated the diff for D5838: Reuse repo location handles in daemon.

add test

Wed, Jan 6, 5:37 PM
johann requested review of D5838: Reuse repo location handles in daemon.
Wed, Jan 6, 5:07 PM
johann updated the diff for D5835: Warn on multiple daemons.

add test

Wed, Jan 6, 4:21 PM
johann updated the diff for D5835: Warn on multiple daemons.

feedback

Wed, Jan 6, 4:06 PM
johann requested review of D5835: Warn on multiple daemons.
Wed, Jan 6, 3:45 PM
johann added inline comments to D5824: Revamp deploying locally and deploying in docker docs to reference dagster-daemon and new deploy_docker example.
Wed, Jan 6, 3:04 PM
johann added a comment to D5571: Refactor dagster k8s images.

Would this be good to get in for release?

Wed, Jan 6, 2:50 PM

Tue, Jan 5

johann closed D5815: Convert daemon run_iteration to generators.
Tue, Jan 5, 10:38 PM
johann committed R1:20ffe50488e8: Convert daemon run_iteration to generators (authored by johann).
Convert daemon run_iteration to generators
Tue, Jan 5, 10:38 PM
johann updated the diff for D5815: Convert daemon run_iteration to generators.

test

Tue, Jan 5, 10:17 PM
johann updated the diff for D5815: Convert daemon run_iteration to generators.

feedback

Tue, Jan 5, 9:52 PM
johann requested review of D5815: Convert daemon run_iteration to generators.
Tue, Jan 5, 4:45 PM

Mon, Jan 4

johann updated the diff for D5571: Refactor dagster k8s images.

rebase

Mon, Jan 4, 6:02 PM
johann added inline comments to D5756: docs for schedules for 0.10.0.
Mon, Jan 4, 3:33 PM

Sat, Dec 26

johann accepted D5759: Heartbeat separately after each daemon iteration.
Sat, Dec 26, 1:55 AM

Dec 22 2020

johann closed D5749: Drop heartbeats table instead of delete.
Dec 22 2020, 10:08 PM
johann committed R1:5f5fd19a4475: Drop heartbeats table instead of delete (authored by johann).
Drop heartbeats table instead of delete
Dec 22 2020, 10:08 PM
johann updated the diff for D5749: Drop heartbeats table instead of delete.

remove test

Dec 22 2020, 9:37 PM
johann added a reverting change for D5741: Expose daemon errors in heartbeat graphql: D5752: Revert "Expose daemon errors in heartbeat graphql".
Dec 22 2020, 9:24 PM
johann added a reverting change for R1:1978aa609d0e: Expose daemon errors in heartbeat graphql: D5752: Revert "Expose daemon errors in heartbeat graphql".
Dec 22 2020, 9:24 PM
johann updated the test plan for D5749: Drop heartbeats table instead of delete.
Dec 22 2020, 9:06 PM
johann added a comment to D5749: Drop heartbeats table instead of delete.

Agreed we should be consistent. I'm not sure if that's the intention of wipe, but it would seem useful.

Dec 22 2020, 8:56 PM
johann updated the diff for D5749: Drop heartbeats table instead of delete.

up

Dec 22 2020, 8:52 PM
johann published D5749: Drop heartbeats table instead of delete for review.
Dec 22 2020, 8:38 PM
johann closed D5741: Expose daemon errors in heartbeat graphql.
Dec 22 2020, 7:54 PM
johann committed R1:1978aa609d0e: Expose daemon errors in heartbeat graphql (authored by johann).
Expose daemon errors in heartbeat graphql
Dec 22 2020, 7:54 PM
johann closed D5740: [Easy] Fix datetime/float inconsistency in heartbeat graphql.
Dec 22 2020, 7:50 PM
johann committed R1:768f74150d26: [Easy] Fix datetime/float inconsistency in heartbeat graphql (authored by johann).
[Easy] Fix datetime/float inconsistency in heartbeat graphql
Dec 22 2020, 7:50 PM
johann requested review of D5741: Expose daemon errors in heartbeat graphql.
Dec 22 2020, 7:09 PM
johann abandoned D5734: remove str decode.
Dec 22 2020, 6:54 PM
johann requested review of D5740: [Easy] Fix datetime/float inconsistency in heartbeat graphql.
Dec 22 2020, 6:21 PM
johann closed D5626: [RFC] Errors in daemon heartbeats.
Dec 22 2020, 5:10 PM
johann committed R1:42aa8f151a4d: [RFC] Errors in daemon heartbeats (authored by johann).
[RFC] Errors in daemon heartbeats
Dec 22 2020, 5:10 PM
johann updated the diff for D5626: [RFC] Errors in daemon heartbeats.

rebase

Dec 22 2020, 5:09 PM
johann requested review of D5734: remove str decode.
Dec 22 2020, 4:07 PM
johann accepted D5732: Fix dagster_github after pyjwt upgrade to 2.0.
Dec 22 2020, 4:04 PM
johann updated the diff for D5626: [RFC] Errors in daemon heartbeats.

up

Dec 22 2020, 3:26 PM

Dec 21 2020

johann updated the diff for D5626: [RFC] Errors in daemon heartbeats.

up

Dec 21 2020, 11:29 PM
johann updated the diff for D5626: [RFC] Errors in daemon heartbeats.

serializable error

Dec 21 2020, 11:01 PM
johann closed D5706: Convert daemon timestamps to unix time.
Dec 21 2020, 6:20 PM
johann committed R1:216e1fc1cbbe: Convert daemon timestamps to unix time (authored by johann).
Convert daemon timestamps to unix time
Dec 21 2020, 6:20 PM
johann updated the diff for D5706: Convert daemon timestamps to unix time.

up

Dec 21 2020, 5:52 PM
johann updated the diff for D5706: Convert daemon timestamps to unix time.

up

Dec 21 2020, 5:38 PM