Page MenuHomePhabricator

johann (Johann Miller)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 15 2020, 1:38 PM (18 w, 2 d)

Recent Activity

Today

johann requested review of D4861: [run-queue 1] Add PipelineOrigin to PipelineRun.
Thu, Oct 22, 12:26 AM

Yesterday

johann added inline comments to D4791: [RFC] Dagster native run queuing cli.
Wed, Oct 21, 10:13 PM
johann updated the diff for D4776: Add grpc-health-probe.

fix pin and add test

Wed, Oct 21, 9:41 PM
johann added inline comments to D4776: Add grpc-health-probe.
Wed, Oct 21, 9:20 PM
johann added inline comments to D4776: Add grpc-health-probe.
Wed, Oct 21, 9:07 PM
johann abandoned D4367: Celery run queue.

Abandoning for https://dagster.phacility.com/D4791

Wed, Oct 21, 6:08 PM
johann added a comment to D4849: [docker] Improve caching in editable images.

Does it not matter that the other libraries depend on dagster core?

Wed, Oct 21, 6:07 PM
johann resigned from D4692: Fetch PySpark driver IP if not set in resource config..

@bob could you post the custom resource here just so we have one more place to find it if we need it again? After that I agree this can be abandoned for now

Wed, Oct 21, 6:02 PM
johann accepted D4826: [easy] Clean up instance file.
Wed, Oct 21, 5:59 PM
johann updated the test plan for D4776: Add grpc-health-probe.
Wed, Oct 21, 1:20 PM
johann added a comment to D4776: Add grpc-health-probe.

Should be ready for re-review

Wed, Oct 21, 4:02 AM
johann updated the summary of D4776: Add grpc-health-probe.
Wed, Oct 21, 1:58 AM
johann updated the diff for D4776: Add grpc-health-probe.

rebase and up dependency pin

Wed, Oct 21, 1:57 AM
johann updated the test plan for D4776: Add grpc-health-probe.
Wed, Oct 21, 1:35 AM
johann updated the diff for D4776: Add grpc-health-probe.

fix helm liveness check

Wed, Oct 21, 1:32 AM
johann updated the diff for D4776: Add grpc-health-probe.

add client to dagster cli

Wed, Oct 21, 1:14 AM

Tue, Oct 20

johann requested review of D4791: [RFC] Dagster native run queuing cli.
Tue, Oct 20, 11:25 PM

Fri, Oct 16

johann updated the diff for D4754: Refactor execute_step_with_structured_logs.

rebase

Fri, Oct 16, 4:31 PM
johann accepted D4802: [k8s] Allow users to set custom labels in Pod metadata.
Fri, Oct 16, 3:13 PM
johann published D4802: [k8s] Allow users to set custom labels in Pod metadata for review.

lgtm

Fri, Oct 16, 3:12 PM

Wed, Oct 14

johann added a comment to D4776: Add grpc-health-probe.

Is there anything we can do to make it easier for users to include/remember to include the binary in their user deployment images? It could just be bundled in dagster and invoked via a dagster cli but I don't think that's great, especially given that the binary is only available for linux. We could build our own client for it?

Wed, Oct 14, 7:59 PM
johann added inline comments to D4776: Add grpc-health-probe.
Wed, Oct 14, 7:14 PM
johann added inline comments to D4776: Add grpc-health-probe.
Wed, Oct 14, 7:10 PM
johann added inline comments to D4776: Add grpc-health-probe.
Wed, Oct 14, 6:01 PM
johann updated the summary of D4776: Add grpc-health-probe.
Wed, Oct 14, 6:00 PM
johann updated the summary of D4776: Add grpc-health-probe.
Wed, Oct 14, 5:35 PM
johann updated the diff for D4776: Add grpc-health-probe.

up

Wed, Oct 14, 5:32 PM
johann updated the diff for D4776: Add grpc-health-probe.

add to helm

Wed, Oct 14, 4:19 PM
johann requested review of D4776: Add grpc-health-probe.
Wed, Oct 14, 3:50 PM

Tue, Oct 13

johann requested review of D4754: Refactor execute_step_with_structured_logs.
Tue, Oct 13, 5:13 PM

Mon, Oct 12

johann updated subscribers of D4674: Add liveness probe to extra celery workers.
Mon, Oct 12, 9:01 PM
johann accepted D4751: suppressed experimental arg warning for builtin dagster type loaders..
Mon, Oct 12, 7:12 PM

Fri, Oct 9

johann added inline comments to D4718: [1/2] Configure celeryless deploy on helm.
Fri, Oct 9, 4:50 PM
johann added a reviewer for D4718: [1/2] Configure celeryless deploy on helm: sashank.
Fri, Oct 9, 4:44 PM
johann accepted D4744: Improve caching in k8s example dockerfile.
Fri, Oct 9, 4:41 PM

Thu, Oct 8

johann closed D4734: Helm pass userdeployment port.
Thu, Oct 8, 8:50 PM
johann committed R1:ce7c5da372fe: Helm pass userdeployment port (authored by johann).
Helm pass userdeployment port
Thu, Oct 8, 8:50 PM
johann updated the test plan for D4734: Helm pass userdeployment port.
Thu, Oct 8, 8:28 PM
johann closed D4707: Pass userdeployment port.
Thu, Oct 8, 4:59 PM
johann committed R1:09e73c782e61: Pass userdeployment port (authored by johann).
Pass userdeployment port
Thu, Oct 8, 4:58 PM
johann updated the diff for D4707: Pass userdeployment port.

rebase

Thu, Oct 8, 4:54 PM

Wed, Oct 7

johann requested review of D4707: Pass userdeployment port.
Wed, Oct 7, 8:42 PM

Tue, Oct 6

johann closed D4673: refactor k8s client wrapper.
Tue, Oct 6, 7:01 PM
johann committed R1:58daef85d2c8: refactor k8s client wrapper (authored by johann).
refactor k8s client wrapper
Tue, Oct 6, 7:01 PM
johann requested review of D4673: refactor k8s client wrapper.
Tue, Oct 6, 3:08 PM

Mon, Oct 5

johann closed D4670: filter list_namespaced_job k8s call.
Mon, Oct 5, 8:11 PM
johann committed R1:fbe6cdef5015: filter list_namespaced_job k8s call (authored by johann).
filter list_namespaced_job k8s call
Mon, Oct 5, 8:11 PM
johann updated the diff for D4670: filter list_namespaced_job k8s call.

edit invariant error

Mon, Oct 5, 7:38 PM
johann updated the summary of D4670: filter list_namespaced_job k8s call.
Mon, Oct 5, 7:10 PM
johann updated the diff for D4670: filter list_namespaced_job k8s call.

up

Mon, Oct 5, 7:09 PM
johann updated the diff for D4670: filter list_namespaced_job k8s call.

up

Mon, Oct 5, 6:45 PM
johann accepted D4669: [dagit-debug] allow multiple files.
Mon, Oct 5, 4:23 PM
johann closed D4633: add dagster-version desc.
Mon, Oct 5, 4:20 PM
johann committed R1:317e92ceb662: add dagster-version desc (authored by johann).
add dagster-version desc
Mon, Oct 5, 4:20 PM

Fri, Oct 2

johann added a comment to D4367: Celery run queue.

@catherinewu I think this has addressed most concerns.

Fri, Oct 2, 9:04 PM
johann updated the diff for D4367: Celery run queue.

up

Fri, Oct 2, 4:33 PM
johann requested review of D4633: add dagster-version desc.
Fri, Oct 2, 4:19 PM
johann added inline comments to D4629: Add dagster-version arg to docker release commands.
Fri, Oct 2, 3:38 PM
johann added inline comments to D4629: Add dagster-version arg to docker release commands.
Fri, Oct 2, 3:36 PM
johann updated the diff for D4367: Celery run queue.

up

Fri, Oct 2, 3:30 PM
johann updated the diff for D4367: Celery run queue.

fix helm_values.py

Fri, Oct 2, 3:07 PM

Thu, Oct 1

johann updated the diff for D4367: Celery run queue.

rebase

Thu, Oct 1, 7:45 PM
johann updated the diff for D4367: Celery run queue.

up

Thu, Oct 1, 4:37 PM
johann updated the diff for D4367: Celery run queue.

helm

Thu, Oct 1, 4:01 PM
johann added inline comments to D4601: K8s API Retries.
Thu, Oct 1, 2:14 PM

Wed, Sep 30

johann added inline comments to D4367: Celery run queue.
Wed, Sep 30, 6:42 PM
johann updated the diff for D4367: Celery run queue.

rebase

Wed, Sep 30, 5:06 PM
johann updated the diff for D4367: Celery run queue.

various renamings

Wed, Sep 30, 4:52 PM

Tue, Sep 29

johann accepted D4584: [easy] Fix celery deploy instructions.
Tue, Sep 29, 6:26 PM

Thu, Sep 24

johann updated the diff for D4367: Celery run queue.

rebase

Thu, Sep 24, 10:20 PM
johann abandoned D4507: BK: wait for celery to init.
Thu, Sep 24, 1:30 PM
johann updated the diff for D4367: Celery run queue.

up

Thu, Sep 24, 1:30 PM

Wed, Sep 23

johann updated the diff for D4367: Celery run queue.

up

Wed, Sep 23, 8:50 PM
johann updated the diff for D4367: Celery run queue.

up

Wed, Sep 23, 7:37 PM
johann updated the diff for D4367: Celery run queue.

nits

Wed, Sep 23, 5:57 PM
johann added inline comments to D4367: Celery run queue.
Wed, Sep 23, 5:26 PM
johann added inline comments to D4367: Celery run queue.
Wed, Sep 23, 5:24 PM
johann added a comment to D4507: BK: wait for celery to init.

Ah you're right Cat, this is redundant. Thanks for catching.

Wed, Sep 23, 2:29 PM
johann added inline comments to D4367: Celery run queue.
Wed, Sep 23, 12:31 AM

Tue, Sep 22

johann updated the diff for D4507: BK: wait for celery to init.

up

Tue, Sep 22, 8:59 PM
johann updated the summary of D4507: BK: wait for celery to init.
Tue, Sep 22, 8:56 PM
johann updated the summary of D4507: BK: wait for celery to init.
Tue, Sep 22, 8:56 PM
johann updated the diff for D4367: Celery run queue.

rebase

Tue, Sep 22, 8:45 PM
johann updated the diff for D4367: Celery run queue.

reduce flakiness

Tue, Sep 22, 8:33 PM
johann requested review of D4507: BK: wait for celery to init.
Tue, Sep 22, 7:59 PM

Sep 21 2020

johann updated the diff for D4367: Celery run queue.

typo

Sep 21 2020, 8:45 PM
johann added inline comments to D4367: Celery run queue.
Sep 21 2020, 8:43 PM
johann accepted D4492: Fixes RPC components for smoother `datalands` migration..

Lgtm, would just add a util function

Sep 21 2020, 8:31 PM
johann accepted D4470: [toys] add crashing to error_monster.
Sep 21 2020, 3:41 PM
johann updated the diff for D4367: Celery run queue.

rebase in black fix

Sep 21 2020, 2:56 PM
johann committed R1:267fae8d5cf8: fix black error (authored by johann).
fix black error
Sep 21 2020, 2:56 PM
johann closed D4490: fix black error.
Sep 21 2020, 2:56 PM
johann added a comment to D4367: Celery run queue.

@nate @catherinewu This is ready if you guys want to take a look at the Celery and Helm changes

Sep 21 2020, 2:13 PM
johann updated the diff for D4367: Celery run queue.

rebase and cleanup

Sep 21 2020, 2:10 PM

Sep 18 2020

johann updated the diff for D4367: Celery run queue.

up

Sep 18 2020, 7:20 PM
johann updated the diff for D4367: Celery run queue.

rename

Sep 18 2020, 6:49 PM
johann updated the diff for D4367: Celery run queue.

clean up

Sep 18 2020, 6:46 PM
johann updated the diff for D4367: Celery run queue.

separate instance

Sep 18 2020, 6:05 PM
johann updated the diff for D4367: Celery run queue.

up

Sep 18 2020, 6:02 PM
johann updated the diff for D4367: Celery run queue.

enable queue in bk

Sep 18 2020, 4:39 PM