- User Since
- Jun 15 2020, 1:38 PM (44 w, 2 h)
Fri, Apr 16
It might be helpful to get more context from the user, are there cases where they couldn't just pull out the user/password/etc? Looks like it wouldn't be too hard postgresql://[user[:password]@][netloc][:port][/dbname][?param1=value1&...]
Tue, Apr 13
Fri, Apr 9
use current test in filename
@alangenfeld looks like only runs from user deployments have pipeline_snapshot_ids? Does debug export work without grpc servers?
Tue, Apr 6
Just realized this is a click feature, should we use this instead? https://click.palletsprojects.com/en/7.x/options/#values-from-environment-variables
Sat, Apr 3
Fri, Apr 2
Thu, Apr 1
Good point about the subchart. I don't love putting it under dagit- makes sense to us, but I don't think they seem related for users. Breaking change, but what if the subchart was under an additional yaml key? So that additional values related to user deployments could be under the userDeployments key?
I think the field would be more natural under userDeployments than dagit
Wed, Mar 31
Thu, Mar 25
Wed, Mar 24
Tue, Mar 23
Mon, Mar 22
Any guess why it flakes on windows? Could be good to leave a note
Mar 13 2021
1 fix, otherwise lgtm. Thank you!
Mar 12 2021
Missing links for run config and executor pages
Rendered, since tables are hard to read
Mar 11 2021
Does that hold true if we use Instance.get()? https://dagster.phacility.com/D6883
user code containers should not need to redeploy if the Dagit instance changes.
Mar 10 2021
This is ok with me, but we might benefit from another level of hierarchy under 'deployment'. It's a somewhat scattered collection of objects (coordinators/launchers/storages that are configured on the instance, executors in run config, and the daemon which is a service). However I do think all this stuff fits the bill of 'things you consider after you have written your first pipelines and are looking to host them somewhere'
Mar 9 2021
Nice! Existing feedback looks good to me
I think this lgtm. Per offline discussion, might use something like kubeval rather than deserializing with the k8s client
How about The Queued run coordinator daemon has errors? Not running is an error, we surface it as one on the status page
Mar 8 2021
Mar 5 2021
Whoops! Thank you for fixing
Mar 4 2021
Mar 3 2021
Mar 2 2021
Mar 1 2021
Feb 27 2021
Feb 26 2021
Feb 24 2021
Feb 18 2021
There's an existing test that differentiates the all_daemons_healthy and all_daemons_live functions, but it doesn't actually invoke the cli. I guess it's time to bring the cli under test?