- User Since
- Sep 14 2020, 6:08 PM (18 w, 3 d)
Remove extra React.Suspense I forgot to remove
On https://reactjs.org/docs/code-splitting.html it is listed as the suggested approach for code splitting.
The only thing I want to be really careful of is that this doesn't lead to a breakdown in the ~1:1 relationship between components and fragments. Eg: SidebarSolidDefinition uses SIDEBAR_SOLID_DEFINITION_FRAGMENT and broadly speaking, other components should define their own fragments that are scoped to their data needs, not re-use that one. We have some places where we are re-using fragments (I am definitely guilty of the GanttChart family of components all sharing a single fragment), but by and large it's a lot easier to keep the graphql queries accurate after refactors, etc. if it's 1:1. It'd be a real bummer if a year from now half the app was sharing RUN_TABLE_RUN_FRAGMENT :-p. Shouldn't be a problem, but we might have to watch out if the team grows and these are nice easy imports!
Tue, Jan 19
Fri, Jan 15
Thu, Jan 14
Could the text wrap instead of being truncated?
Wed, Jan 13
Show pipeline name instead of repo, remove YYYY from timestamp format
Add (and tweak) SchedulerInfo
Yeah sorry, was cleaning some things up.
I'm about to change some things here to support the Runs page, and will include an empty state there.
Tue, Jan 12
Hide elapsed time if queued
Mon, Jan 11
(Discussed in standup -- the statuses key will override ...filter for queuedFilter and inProgressFilter, which should be correct.)
Fri, Jan 8
I think I like the Loading text better than the spinner
Remove print, something seems broken
Print diff_files for BK
Added some Python changes to include a generated ID for PartitionSet. Fairly dogscience, so please let me know if I did it all wrong or missed something.
Use a generated ID instead, to avoid name collisions across repositories.
Thu, Jan 7
Test, use CSS for uppercase headers