Page MenuHomePhabricator

dish (Isaac Hellendag)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 14 2020, 6:08 PM (6 w, 1 d)

Recent Activity

Yesterday

dish requested review of D4929: Enable import/no-duplicates eslint.
Tue, Oct 27, 10:01 PM
dish closed D4914: ApolloTestProvider.
Tue, Oct 27, 9:50 PM
dish committed R1:5122764d7659: ApolloTestProvider (authored by dish).
ApolloTestProvider
Tue, Oct 27, 9:50 PM
dish added a comment to D4914: ApolloTestProvider.

This looks good to me - I guess it replaces the MockedProvider we already have in place in App.test.tsx?

I think that our current implementation of the graphql mocking is a bit unusual but it was designed to replace defaultMocks with query results loaded from a folder of JSON files. (At the time, Apollo seemed to suggest maintaining "defaultMocks" by hand, and for our queries that'd be crazy.) The current setup allows you to run the actual GraphQL server and pull down real data to generate the folder of mocks, and then run the tests against those files. It's definitely not ideal because changes to the demo pipelines change the GraphQL mocks which change the snapshots, but it seemed like maintaining the mocks by hand was untenable.

Tue, Oct 27, 9:25 PM
dish requested review of D4914: ApolloTestProvider.
Tue, Oct 27, 3:09 PM

Mon, Oct 26

dish closed D4876: [dagit] Quick search component (experiment).
Mon, Oct 26, 7:00 PM
dish committed R1:0cbb8dece601: [dagit] Quick search component (experiment) (authored by dish).
[dagit] Quick search component (experiment)
Mon, Oct 26, 7:00 PM
dish retitled D4876: [dagit] Quick search component (experiment) from RFC [dagit] Quick search to [dagit] Quick search component (experiment).
Mon, Oct 26, 6:59 PM
dish accepted D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.
Mon, Oct 26, 6:29 PM
dish updated the diff for D4876: [dagit] Quick search component (experiment).

+bengotow, went with a dir for sample data because ts didn't like the .data.ts extension

Mon, Oct 26, 6:25 PM
dish closed D4871: [dagit] Replace Legend tables with Table.
Mon, Oct 26, 6:18 PM
dish committed R1:4396161679ee: [dagit] Replace Legend tables with Table (authored by dish).
[dagit] Replace Legend tables with Table
Mon, Oct 26, 6:18 PM
dish added inline comments to D4876: [dagit] Quick search component (experiment).
Mon, Oct 26, 6:10 PM
dish updated the diff for D4871: [dagit] Replace Legend tables with Table.

+bengotow

Mon, Oct 26, 6:05 PM
dish added inline comments to D4871: [dagit] Replace Legend tables with Table.
Mon, Oct 26, 5:55 PM
dish closed D4885: [dagit] Move fonts to src.
Mon, Oct 26, 5:49 PM
dish committed R1:2baa707c9b43: [dagit] Move fonts to src (authored by dish).
[dagit] Move fonts to src
Mon, Oct 26, 5:49 PM

Fri, Oct 23

dish requested review of D4885: [dagit] Move fonts to src.
Fri, Oct 23, 6:50 PM

Thu, Oct 22

dish requested review of D4876: [dagit] Quick search component (experiment).
Thu, Oct 22, 10:33 PM
dish requested review of D4871: [dagit] Replace Legend tables with Table.
Thu, Oct 22, 8:05 PM
dish closed D4864: [dagit] Tag truncation on Playground.
Thu, Oct 22, 3:36 PM
dish committed R1:4ff17fdc635f: [dagit] Tag truncation on Playground (authored by dish).
[dagit] Tag truncation on Playground
Thu, Oct 22, 3:36 PM
dish updated the diff for D4864: [dagit] Tag truncation on Playground.

Clean up border-radius on tag value

Thu, Oct 22, 3:08 PM
dish requested review of D4864: [dagit] Tag truncation on Playground.
Thu, Oct 22, 3:00 PM

Tue, Oct 20

dish closed D4821: [dagit] Create workspace routes.
Tue, Oct 20, 7:24 PM
dish committed R1:17c5334963d4: [dagit] Create workspace routes (authored by dish).
[dagit] Create workspace routes
Tue, Oct 20, 7:24 PM
dish retitled D4821: [dagit] Create workspace routes from RFC: [dagit] Start adding Workspace routes to [dagit] Create workspace routes.
Tue, Oct 20, 7:09 PM
dish updated the diff for D4821: [dagit] Create workspace routes.

Remove console.log

Tue, Oct 20, 7:08 PM
dish closed D4828: [dagit] Create instance routes.
Tue, Oct 20, 6:56 PM
dish committed R1:00202b96f1c4: [dagit] Create instance routes (authored by dish).
[dagit] Create instance routes
Tue, Oct 20, 6:56 PM
dish retitled D4828: [dagit] Create instance routes from RFC [dagit] Create instance routes to [dagit] Create instance routes.
Tue, Oct 20, 6:55 PM
dish added a comment to D4821: [dagit] Create workspace routes.

I'm a little bit worried that the whole concept of a repo location isn't necc. clear to users right now though, especially when they only have a single repository in each location

Tue, Oct 20, 6:52 PM
dish requested review of D4828: [dagit] Create instance routes.
Tue, Oct 20, 5:04 PM

Mon, Oct 19

dish added a comment to D4809: Clean up partitions UI and improve backfill usability.

Possibly crazy idea: can we use a yaml CodeMirror here? E.g.

Mon, Oct 19, 10:54 PM
dish requested review of D4821: [dagit] Create workspace routes.
Mon, Oct 19, 10:04 PM
dish requested changes to D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.

Direction looks great to me. Some nits inline, mostly stylistic/legibility things.

Mon, Oct 19, 7:54 PM

Fri, Oct 16

dish closed D4803: [dagit] Standardize font-family usage.
Fri, Oct 16, 7:04 PM
dish committed R1:f24d430fcbd0: [dagit] Standardize font-family usage (authored by dish).
[dagit] Standardize font-family usage
Fri, Oct 16, 7:04 PM
dish updated the diff for D4803: [dagit] Standardize font-family usage.

Accidental comment

Fri, Oct 16, 6:39 PM
dish closed D4765: [dagit] Allow copying filter state to URL on Run page.
Fri, Oct 16, 6:13 PM
dish committed R1:2fd4374e3889: [dagit] Allow copying filter state to URL on Run page (authored by dish).
[dagit] Allow copying filter state to URL on Run page
Fri, Oct 16, 6:13 PM
dish updated the diff for D4765: [dagit] Allow copying filter state to URL on Run page.

Remove rogue console.log

Fri, Oct 16, 6:01 PM
dish added a comment to D4803: [dagit] Standardize font-family usage.

Before:

Fri, Oct 16, 6:00 PM
dish requested review of D4803: [dagit] Standardize font-family usage.
Fri, Oct 16, 5:57 PM
dish added inline comments to D4765: [dagit] Allow copying filter state to URL on Run page.
Fri, Oct 16, 5:54 PM

Thu, Oct 15

dish committed R1:9b9c78e332f9: [Docs] 0.9.15 (authored by dish).
[Docs] 0.9.15
Thu, Oct 15, 10:55 PM
dish committed R1:ffc2566c127c: 0.9.15 (authored by dish).
0.9.15
Thu, Oct 15, 10:18 PM
dish committed R1:da8a0069f1c9: 0.9.15pre0 (authored by dish).
0.9.15pre0
Thu, Oct 15, 9:58 PM
dish closed D4795: Changes for 0.9.15.
Thu, Oct 15, 9:45 PM
dish committed R1:9ac36b9274f1: Changes for 0.9.15 (authored by dish).
Changes for 0.9.15
Thu, Oct 15, 9:45 PM
dish updated the diff for D4795: Changes for 0.9.15.

+alangenfeld

Thu, Oct 15, 9:40 PM
dish closed D4789: [dagit] Use parent snapshot ID to determine current-ness of snapshot.
Thu, Oct 15, 8:11 PM
dish committed R1:84a37997d508: [dagit] Use parent snapshot ID to determine current-ness of snapshot (authored by dish).
[dagit] Use parent snapshot ID to determine current-ness of snapshot
Thu, Oct 15, 8:11 PM
dish updated the diff for D4789: [dagit] Use parent snapshot ID to determine current-ness of snapshot.

Show 'Snapshot' if there is no current pipeline state

Thu, Oct 15, 7:52 PM
dish closed D4790: [dagit] Restore nav height fix for Safari.
Thu, Oct 15, 7:40 PM
dish committed R1:fd3a0fcd5479: [dagit] Restore nav height fix for Safari (authored by dish).
[dagit] Restore nav height fix for Safari
Thu, Oct 15, 7:40 PM
dish requested review of D4790: [dagit] Restore nav height fix for Safari.
Thu, Oct 15, 7:15 PM
dish requested review of D4789: [dagit] Use parent snapshot ID to determine current-ness of snapshot.
Thu, Oct 15, 5:30 PM

Wed, Oct 14

dish closed D4784: [dagit] Allow snapshots to re-run even if the snapshot ID is mismatched.
Wed, Oct 14, 9:51 PM
dish committed R1:703aa09985bf: [dagit] Allow snapshots to re-run even if the snapshot ID is mismatched (authored by dish).
[dagit] Allow snapshots to re-run even if the snapshot ID is mismatched
Wed, Oct 14, 9:51 PM
dish added inline comments to D4784: [dagit] Allow snapshots to re-run even if the snapshot ID is mismatched.
Wed, Oct 14, 9:50 PM
dish updated the diff for D4784: [dagit] Allow snapshots to re-run even if the snapshot ID is mismatched.

+alangenfeld

Wed, Oct 14, 9:44 PM
dish added inline comments to D4784: [dagit] Allow snapshots to re-run even if the snapshot ID is mismatched.
Wed, Oct 14, 9:44 PM
dish requested review of D4784: [dagit] Allow snapshots to re-run even if the snapshot ID is mismatched.
Wed, Oct 14, 9:26 PM
dish closed D4782: [dagit] Remove "historical" tag on Run table.
Wed, Oct 14, 8:54 PM
dish committed R1:67e4e6b1a7a2: [dagit] Remove "historical" tag on Run table (authored by dish).
[dagit] Remove "historical" tag on Run table
Wed, Oct 14, 8:54 PM
dish requested review of D4782: [dagit] Remove "historical" tag on Run table.
Wed, Oct 14, 8:21 PM
dish accepted D4762: [dagit] change Preparing to Not Executed.
Wed, Oct 14, 3:04 PM

Tue, Oct 13

dish accepted D4695: Incrementally fetch data for partition set UI.
Tue, Oct 13, 9:26 PM
dish added a comment to D4695: Incrementally fetch data for partition set UI.

Some minor comments -- the only one that strikes me as a maybe-bug is the pop followed by slice.

Tue, Oct 13, 9:26 PM
dish closed D4766: Delete unnecessary file, fix run row link.
Tue, Oct 13, 6:15 PM
dish committed R1:078f1b92bfc8: Delete unnecessary file, fix run row link (authored by dish).
Delete unnecessary file, fix run row link
Tue, Oct 13, 6:15 PM
dish requested review of D4766: Delete unnecessary file, fix run row link.
Tue, Oct 13, 6:08 PM
dish closed D4709: [dagit] Separate snapshot and current pipeline permalinks.
Tue, Oct 13, 5:54 PM
dish committed R1:f7dd62ecd9e2: [dagit] Separate snapshot and current pipeline permalinks (authored by dish).
[dagit] Separate snapshot and current pipeline permalinks
Tue, Oct 13, 5:54 PM
dish added inline comments to D4762: [dagit] change Preparing to Not Executed.
Tue, Oct 13, 5:52 PM
dish retitled D4709: [dagit] Separate snapshot and current pipeline permalinks from [dagit] RFC: Separate snapshot and current pipeline permalinks to [dagit] Separate snapshot and current pipeline permalinks.
Tue, Oct 13, 5:50 PM
dish updated the diff for D4709: [dagit] Separate snapshot and current pipeline permalinks.

+bengotow

Tue, Oct 13, 4:58 PM
dish requested review of D4765: [dagit] Allow copying filter state to URL on Run page.
Tue, Oct 13, 4:56 PM
dish added inline comments to D4709: [dagit] Separate snapshot and current pipeline permalinks.
Tue, Oct 13, 4:50 PM
dish closed D4748: [dagit] Warn on tab removal in Playground.
Tue, Oct 13, 4:48 PM
dish committed R1:760f7babdd63: [dagit] Warn on tab removal in Playground (authored by dish).
[dagit] Warn on tab removal in Playground
Tue, Oct 13, 4:48 PM
dish added a comment to D4748: [dagit] Warn on tab removal in Playground.

This looks great! Did not realize we had a useConfirmation hook, but that makes this super clean. (Though I assume it's stateless and doesn't only remind you on the removal of the first tab?)

Tue, Oct 13, 4:47 PM

Mon, Oct 12

dish updated the diff for D4709: [dagit] Separate snapshot and current pipeline permalinks.

Remove empty repo conditional, doesn't seem necessary

Mon, Oct 12, 7:43 PM
dish added a comment to D4709: [dagit] Separate snapshot and current pipeline permalinks.

Multiple levels of tabs might work, so that the main pipeline tabs would always be visible.

Mon, Oct 12, 7:38 PM
dish updated the diff for D4748: [dagit] Warn on tab removal in Playground.

useConfirmation, don't show X if only one tab

Mon, Oct 12, 3:55 PM
dish closed D4747: [dagit] State refactor for execution tabs.
Mon, Oct 12, 3:07 PM
dish committed R1:98cddb90c3d9: [dagit] State refactor for execution tabs (authored by dish).
[dagit] State refactor for execution tabs
Mon, Oct 12, 3:07 PM
dish updated the diff for D4748: [dagit] Warn on tab removal in Playground.

Rebase

Mon, Oct 12, 3:03 PM
dish updated the diff for D4747: [dagit] State refactor for execution tabs.

Make ExecutionTabs non-pure to simplify a bit

Mon, Oct 12, 2:52 PM
dish added inline comments to D4747: [dagit] State refactor for execution tabs.
Mon, Oct 12, 2:49 PM
dish added a comment to D4709: [dagit] Separate snapshot and current pipeline permalinks.

I feel not obvious/easy to get back to the playground/overview pages if you end up on a snapshot page, especially since we use the same tabs UI for both ["Definition, "Runs"] and ["Overview", "Definition", "Runs", "Partitions"].

Mon, Oct 12, 2:13 PM

Fri, Oct 9

dish added inline comments to D4748: [dagit] Warn on tab removal in Playground.
Fri, Oct 9, 10:10 PM
dish updated the diff for D4747: [dagit] State refactor for execution tabs.

Don't need the useState diff

Fri, Oct 9, 9:02 PM
dish requested review of D4748: [dagit] Warn on tab removal in Playground.
Fri, Oct 9, 8:53 PM
dish requested review of D4747: [dagit] State refactor for execution tabs.
Fri, Oct 9, 8:52 PM
dish updated the diff for D4709: [dagit] Separate snapshot and current pipeline permalinks.

Rebase

Fri, Oct 9, 3:58 PM

Thu, Oct 8

dish closed D4714: [dagit] Don't crash on solid selection that isn't in subset.
Thu, Oct 8, 1:45 PM
dish committed R1:afe56fff0d0f: [dagit] Don't crash on solid selection that isn't in subset (authored by dish).
[dagit] Don't crash on solid selection that isn't in subset
Thu, Oct 8, 1:44 PM

Wed, Oct 7

dish added a comment to D4712: [dagit] print operation times.

We could add a debug console somewhere that allows toggling this kind of thing, then ask folks to toggle it on while we're live debugging with them.

Wed, Oct 7, 11:05 PM