Page MenuHomeElementl

dish (Isaac Hellendag)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 14 2020, 6:08 PM (63 w, 2 d)

Recent Activity

Aug 9 2021

dish closed D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.
Aug 9 2021, 9:55 PM
dish committed R1:c7c169e4dcfc: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription (authored by dish).
[dagit] RFC: useSubscription instead of DirectGraphQLSubscription
Aug 9 2021, 9:55 PM
dish updated the diff for D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.

Extra fragment wrapper

Aug 9 2021, 7:51 PM
dish added inline comments to D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.
Aug 9 2021, 7:50 PM
dish updated the diff for D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.

Use message batching in LogsProvider to ensure smooth Gantt animation.

Aug 9 2021, 7:42 PM
dish closed D9211: [dagit] Extract ContentRoot to be an App child.
Aug 9 2021, 4:42 PM
dish committed R1:65af656835d5: [dagit] Extract ContentRoot to be an App child (authored by dish).
[dagit] Extract ContentRoot to be an App child
Aug 9 2021, 4:41 PM
dish added a comment to D9211: [dagit] Extract ContentRoot to be an App child.

This is so that the cloud index can add cloud-specific routes?

Aug 9 2021, 4:40 PM
dish requested review of D9211: [dagit] Extract ContentRoot to be an App child.
Aug 9 2021, 4:28 PM
dish closed D9210: [dagit] Enable limited frame-src.
Aug 9 2021, 3:39 PM
dish committed R1:421626462227: [dagit] Enable limited frame-src (authored by dish).
[dagit] Enable limited frame-src
Aug 9 2021, 3:39 PM
dish requested review of D9210: [dagit] Enable limited frame-src.
Aug 9 2021, 2:46 PM
dish accepted D9193: Tests for permissions query in graphql.
Aug 9 2021, 1:34 PM

Aug 4 2021

dish closed D9202: [dagit] Lazy-load partition set info for Schedules.
Aug 4 2021, 4:29 PM
dish committed R1:fc435395a8c6: [dagit] Lazy-load partition set info for Schedules (authored by dish).
[dagit] Lazy-load partition set info for Schedules
Aug 4 2021, 4:29 PM
dish updated the diff for D9202: [dagit] Lazy-load partition set info for Schedules.

Show coverage

Aug 4 2021, 3:53 PM
dish added a comment to D9202: [dagit] Lazy-load partition set info for Schedules.

Screen Shot 2021-08-04 at 10.45.58 AM.png (518×656 px, 44 KB)

Aug 4 2021, 3:49 PM
dish updated the diff for D9202: [dagit] Lazy-load partition set info for Schedules.

+alangenfeld

Aug 4 2021, 3:48 PM

Aug 3 2021

dish requested review of D9202: [dagit] Lazy-load partition set info for Schedules.
Aug 3 2021, 7:09 PM
dish closed D9196: [dagit] Perms followup.
Aug 3 2021, 4:37 PM
dish committed R1:4694cc873bd5: [dagit] Perms followup (authored by dish).
[dagit] Perms followup
Aug 3 2021, 4:37 PM
dish requested review of D9196: [dagit] Perms followup.
Aug 3 2021, 4:30 PM
dish closed D9185: [dagit] Add Permissions query.
Aug 3 2021, 3:10 PM
dish committed R1:55ed5ae70747: [dagit] Add Permissions query (authored by dgibson).
[dagit] Add Permissions query
Aug 3 2021, 3:10 PM
dish added a comment to D9185: [dagit] Add Permissions query.

Does this require any changes in the internal repo in order to avoid any breaking changes there?

Aug 3 2021, 3:04 PM
dish updated the diff for D9185: [dagit] Add Permissions query.

Compatibility, expose raw permission array.

Aug 3 2021, 2:43 PM

Aug 2 2021

dish requested review of D9185: [dagit] Add Permissions query.
Aug 2 2021, 9:46 PM
dish added inline comments to D9181: allow step failure events to have no serialized error.
Aug 2 2021, 5:11 PM
dish updated the diff for D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.

Fix ref error in useViewport

Aug 2 2021, 3:31 PM
dish closed D9170: [dagit] Stop overfetching schedule/sensor in JobMetadata.
Aug 2 2021, 2:04 PM
dish committed R1:e93b23ef47e9: [dagit] Stop overfetching schedule/sensor in JobMetadata (authored by dish).
[dagit] Stop overfetching schedule/sensor in JobMetadata
Aug 2 2021, 2:04 PM
dish added inline comments to D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.
Aug 2 2021, 2:03 PM

Jul 30 2021

dish requested review of D9170: [dagit] Stop overfetching schedule/sensor in JobMetadata.
Jul 30 2021, 10:14 PM
dish updated the diff for D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.

Commented line

Jul 30 2021, 7:42 PM
dish accepted D9152: fix run stats for backfill progress.
Jul 30 2021, 6:42 PM
dish requested review of D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.
Jul 30 2021, 6:06 PM

Jul 29 2021

dish accepted D9153: fix tooltip content for sensor timeline.
Jul 29 2021, 9:58 PM
dish published D9153: fix tooltip content for sensor timeline for review.
Jul 29 2021, 9:58 PM
dish closed D9144: [dagit] Repair repo specificity on Run details and re-execution.
Jul 29 2021, 8:11 PM
dish committed R1:582094301440: [dagit] Repair repo specificity on Run details and re-execution (authored by dish).
[dagit] Repair repo specificity on Run details and re-execution
Jul 29 2021, 8:10 PM
dish closed D9124: [dagit] Repair layout worker, large DAG loading.
Jul 29 2021, 8:03 PM
dish committed R1:02a26b61b970: [dagit] Repair layout worker, large DAG loading (authored by dish).
[dagit] Repair layout worker, large DAG loading
Jul 29 2021, 8:03 PM
dish updated the diff for D9144: [dagit] Repair repo specificity on Run details and re-execution.

+yuhan

Jul 29 2021, 7:57 PM
dish updated the diff for D9124: [dagit] Repair layout worker, large DAG loading.

Comment regarding React dependency

Jul 29 2021, 7:39 PM
dish added a comment to D9124: [dagit] Repair layout worker, large DAG loading.

just to confirm then... was this not broken on prod?

Jul 29 2021, 4:58 PM
dish requested review of D9144: [dagit] Repair repo specificity on Run details and re-execution.
Jul 29 2021, 2:53 PM
dish added a comment to D9124: [dagit] Repair layout worker, large DAG loading.

Is there a way to run a test to make sure that the worker compiles? Seems like an easy thing to break again with a random refactor.

Jul 29 2021, 2:46 PM

Jul 28 2021

dish updated the summary of D9124: [dagit] Repair layout worker, large DAG loading.
Jul 28 2021, 7:33 PM
dish added a comment to D9124: [dagit] Repair layout worker, large DAG loading.

Is there a way to test that the layout worker doesn't have imports (direct or transitive) that will break it?

Jul 28 2021, 7:25 PM
dish requested review of D9124: [dagit] Repair layout worker, large DAG loading.
Jul 28 2021, 5:39 PM
dish closed D9119: [dagit] TS 4.3.5.
Jul 28 2021, 5:31 PM
dish committed R1:58983f8a4436: [dagit] TS 4.3.5 (authored by dish).
[dagit] TS 4.3.5
Jul 28 2021, 5:31 PM
dish requested review of D9119: [dagit] TS 4.3.5.
Jul 28 2021, 2:54 PM
dish accepted D9099: [dagit] Fix divider covering the “Launch Execution” button #4370.
Jul 28 2021, 2:24 PM
dish accepted D9100: [dagit] Pad the bottom of the Gantt chart to avoid last row of steps behind search box #4389.
Jul 28 2021, 2:23 PM
dish accepted D9102: [dagit] Fix Gantt chart time indicators offset from step edges when scrollbars present #4408.
Jul 28 2021, 2:23 PM

Jul 27 2021

dish closed D9089: [dagit] Move WebSocket context.
Jul 27 2021, 8:41 PM
dish committed R1:4e309e16c0f3: [dagit] Move WebSocket context (authored by dish).
[dagit] Move WebSocket context
Jul 27 2021, 8:41 PM
dish closed D9087: [dagit] Refactor components with subscriptions.
Jul 27 2021, 8:41 PM
dish committed R1:b776ad8edc20: [dagit] Refactor components with subscriptions (authored by dish).
[dagit] Refactor components with subscriptions
Jul 27 2021, 8:41 PM
dish updated the diff for D9089: [dagit] Move WebSocket context.

Stringify to ensure we keep the same header object

Jul 27 2021, 7:55 PM
dish added inline comments to D9089: [dagit] Move WebSocket context.
Jul 27 2021, 7:49 PM
dish requested review of D9089: [dagit] Move WebSocket context.
Jul 27 2021, 7:31 PM
dish updated the diff for D9087: [dagit] Refactor components with subscriptions.

setNodes() when runId changes

Jul 27 2021, 7:02 PM
dish closed D9030: [dagit] Fix manifest.
Jul 27 2021, 6:33 PM
dish committed R1:3d1845e5a014: [dagit] Fix manifest (authored by dish).
[dagit] Fix manifest
Jul 27 2021, 6:33 PM
dish requested review of D9087: [dagit] Refactor components with subscriptions.
Jul 27 2021, 6:19 PM
dish closed D8956: [dagit] Show start/end information on latest run in Job details.
Jul 27 2021, 3:49 PM
dish committed R1:62568ae3388e: [dagit] Show start/end information on latest run in Job details (authored by dish).
[dagit] Show start/end information on latest run in Job details
Jul 27 2021, 3:49 PM
dish closed D9065: [dagit] Modify App initialization config.
Jul 27 2021, 3:30 PM
dish committed R1:7a03bb0ffe30: [dagit] Modify App initialization config (authored by dish).
[dagit] Modify App initialization config
Jul 27 2021, 3:30 PM
dish updated the diff for D8956: [dagit] Show start/end information on latest run in Job details.

Rebase

Jul 27 2021, 3:29 PM
dish updated the summary of D9065: [dagit] Modify App initialization config.
Jul 27 2021, 2:19 PM

Jul 26 2021

dish requested review of D9065: [dagit] Modify App initialization config.
Jul 26 2021, 9:30 PM
dish updated the diff for D8956: [dagit] Show start/end information on latest run in Job details.

Rebase

Jul 26 2021, 3:06 PM

Jul 22 2021

dish requested review of D9030: [dagit] Fix manifest.
Jul 22 2021, 8:19 PM
dish closed D9012: [dagit] Handle WS issue in CSP for Safari.
Jul 22 2021, 6:03 PM
dish committed R1:e839f19d97e6: [dagit] Handle WS issue in CSP for Safari (authored by dish).
[dagit] Handle WS issue in CSP for Safari
Jul 22 2021, 6:03 PM
dish updated the diff for D9012: [dagit] Handle WS issue in CSP for Safari.

Fix local commits

Jul 22 2021, 5:55 PM
dish published D9012: [dagit] Handle WS issue in CSP for Safari for review.
Jul 22 2021, 5:46 PM

Jul 21 2021

dish closed D8992: [dagit] Fix link to partition from schedule page.
Jul 21 2021, 11:43 PM
dish committed R1:651b7e83fa71: [dagit] Fix link to partition from schedule page (authored by dish).
[dagit] Fix link to partition from schedule page
Jul 21 2021, 11:43 PM
dish closed D8991: [dagit] Fix JobMetadataQuery for non-crag.
Jul 21 2021, 5:30 PM
dish committed R1:7cb5a19495aa: [dagit] Fix JobMetadataQuery for non-crag (authored by dish).
[dagit] Fix JobMetadataQuery for non-crag
Jul 21 2021, 5:30 PM
dish requested review of D8992: [dagit] Fix link to partition from schedule page.
Jul 21 2021, 5:20 PM
dish requested review of D8991: [dagit] Fix JobMetadataQuery for non-crag.
Jul 21 2021, 5:01 PM
dish accepted D8987: Don't show an error/failure result when a repo location transitions from error => loading.
Jul 21 2021, 4:47 PM

Jul 20 2021

dish updated the diff for D8956: [dagit] Show start/end information on latest run in Job details.

Remove TimeElapsed change

Jul 20 2021, 6:42 PM
dish updated the diff for D8956: [dagit] Show start/end information on latest run in Job details.

Use RunTime instead

Jul 20 2021, 6:41 PM
dish closed D8962: [dagit] Delete some dead JS.
Jul 20 2021, 5:42 PM
dish committed R1:de862c48925c: [dagit] Delete some dead JS (authored by dish).
[dagit] Delete some dead JS
Jul 20 2021, 5:42 PM
dish requested review of D8962: [dagit] Delete some dead JS.
Jul 20 2021, 5:34 PM
dish closed D8961: [dagit] Delete /flags.
Jul 20 2021, 5:15 PM
dish committed R1:dac4ebfbcba9: [dagit] Delete /flags (authored by dish).
[dagit] Delete /flags
Jul 20 2021, 5:15 PM
dish closed D8954: [dagit] Crag: solid -> op.
Jul 20 2021, 5:15 PM
dish committed R1:cb504067b287: [dagit] Crag: solid -> op (authored by dish).
[dagit] Crag: solid -> op
Jul 20 2021, 5:15 PM
dish requested review of D8961: [dagit] Delete /flags.
Jul 20 2021, 2:14 PM

Jul 19 2021

dish closed D8950: [dagit] Include credentials on GraphQL playground.
Jul 19 2021, 10:14 PM
dish committed R1:10d76954dee1: [dagit] Include credentials on GraphQL playground (authored by dish).
[dagit] Include credentials on GraphQL playground
Jul 19 2021, 10:14 PM
dish requested review of D8956: [dagit] Show start/end information on latest run in Job details.
Jul 19 2021, 9:29 PM