Page MenuHomeElementl

dish (Isaac Hellendag)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 14 2020, 6:08 PM (30 w, 6 d)

Recent Activity

Today

dish closed D7487: [dagit] Assets: Only show latest materialization in list.
Mon, Apr 19, 2:16 PM
dish committed R1:ed7ba1a71794: [dagit] Assets: Only show latest materialization in list (authored by dish).
[dagit] Assets: Only show latest materialization in list
Mon, Apr 19, 2:15 PM
dish updated the diff for D7487: [dagit] Assets: Only show latest materialization in list.

+bengotow

Mon, Apr 19, 2:01 PM

Fri, Apr 16

dish requested review of D7487: [dagit] Assets: Only show latest materialization in list.
Fri, Apr 16, 8:07 PM
dish closed D7423: [dagit] Split the bundle.
Fri, Apr 16, 2:10 PM
dish closed D7418: [dagit] Eject CRA.
Fri, Apr 16, 2:10 PM
dish committed R1:6038b7cab2e9: [dagit] Split the bundle (authored by dish).
[dagit] Split the bundle
Fri, Apr 16, 2:10 PM
dish committed R1:8bfebf989579: [dagit] Eject CRA (authored by dish).
[dagit] Eject CRA
Fri, Apr 16, 2:10 PM
dish accepted D7469: Make default scroll position in "Launch backfill" modal be right-most partition #3787.
Fri, Apr 16, 2:05 PM
dish accepted D7465: Handle long lists of parent assets #3952.
Fri, Apr 16, 2:04 PM
dish added a comment to D7467: Increase the number of typeahead autocompletions shown and scroll the list #4017.

When scrolling down with the keyboard, does the scrollable div keep the highlighted item visible? (If not: the typeahead dropdown code for global search and log filtering does do this, so we can either try to reuse that code here or copy it over temporarily.)

Fri, Apr 16, 2:03 PM
dish accepted D7467: Increase the number of typeahead autocompletions shown and scroll the list #4017.
Fri, Apr 16, 2:01 PM
dish accepted D7466: Remove “for-screenshots” titles - confirmed with Sashank that there is no script using this anymore #3800.
Fri, Apr 16, 2:01 PM

Thu, Apr 15

dish updated the diff for D7423: [dagit] Split the bundle.

+prha

Thu, Apr 15, 6:17 PM
dish accepted D7461: Show failure status with python stack trace for failed backfills.
Thu, Apr 15, 5:59 PM
dish closed D7433: [dagit] Fix left nav schedules/sensors filtering.
Thu, Apr 15, 12:09 AM
dish committed R1:51bb6d294e88: [dagit] Fix left nav schedules/sensors filtering (authored by dish).
[dagit] Fix left nav schedules/sensors filtering
Thu, Apr 15, 12:09 AM

Wed, Apr 14

dish requested review of D7423: [dagit] Split the bundle.
Wed, Apr 14, 9:34 PM
dish requested review of D7433: [dagit] Fix left nav schedules/sensors filtering.
Wed, Apr 14, 8:52 PM
dish accepted D7378: Improve the button layout of the partition view for smaller displays.
Wed, Apr 14, 5:18 PM
dish updated the diff for D7418: [dagit] Eject CRA.

Rebase, squash a rogue commit

Wed, Apr 14, 2:02 PM

Tue, Apr 13

dish requested review of D7418: [dagit] Eject CRA.
Tue, Apr 13, 10:07 PM
dish accepted D7379: Fix the partition “Run steps” sidebar which required immediate step list.
Tue, Apr 13, 10:01 PM

Mon, Apr 12

dish accepted D7390: fix main content margin for wide screens.

Thanks for the fix!

Mon, Apr 12, 4:33 PM
dish closed D7369: [dagit] Fix path prefix in dev.
Mon, Apr 12, 4:28 PM
dish committed R1:3dc86ce14f60: [dagit] Fix path prefix in dev (authored by dish).
[dagit] Fix path prefix in dev
Mon, Apr 12, 4:28 PM
dish requested changes to D7390: fix main content margin for wide screens.
Mon, Apr 12, 4:26 PM
dish added a comment to D7390: fix main content margin for wide screens.

Ah man, sorry about this. Unfortunately it requires a bit more.

Mon, Apr 12, 4:25 PM

Fri, Apr 9

dish added inline comments to D7365: fix partition run matrix to handle composite solids / dynamic solids.
Fri, Apr 9, 6:09 PM
dish added a comment to D7372: fix the app_path_prefix on the dev server by ignoring the uninterpolated value.

This doesn't fix the manifest path, unfortunately. https://dagster.phacility.com/D7369

Fri, Apr 9, 5:57 PM
dish requested review of D7369: [dagit] Fix path prefix in dev.
Fri, Apr 9, 4:52 PM
dish closed D7368: [dagit] Delete commented code in AssetView.
Fri, Apr 9, 4:09 PM
dish committed R1:d3bdc43a94c2: [dagit] Delete commented code in AssetView (authored by dish).
[dagit] Delete commented code in AssetView
Fri, Apr 9, 4:09 PM
dish published D7368: [dagit] Delete commented code in AssetView for review.
Fri, Apr 9, 3:53 PM
dish added inline comments to D7355: [dagit] Break apart Asset materialization query.
Fri, Apr 9, 3:51 PM
dish closed D7355: [dagit] Break apart Asset materialization query.
Fri, Apr 9, 3:50 PM
dish committed R1:4b2fa779c607: [dagit] Break apart Asset materialization query (authored by dish).
[dagit] Break apart Asset materialization query
Fri, Apr 9, 3:50 PM
dish accepted D7315: add bulk actions to asset view, for asset wipe.
Fri, Apr 9, 3:49 PM

Thu, Apr 8

dish closed D7358: [dagit] Remove extra slash on app.py string replace.
Thu, Apr 8, 8:56 PM
dish committed R1:1c2a45544aa1: [dagit] Remove extra slash on app.py string replace (authored by dish).
[dagit] Remove extra slash on app.py string replace
Thu, Apr 8, 8:56 PM
dish added a comment to D7358: [dagit] Remove extra slash on app.py string replace.

Some kind of "does the app render at all" smoke test would have been good here. Mostly I'm highly skeptical of smoke tests, but that's the super basic kind that I'm okay with.

Thu, Apr 8, 8:52 PM
dish published D7358: [dagit] Remove extra slash on app.py string replace for review.
Thu, Apr 8, 8:48 PM
dish requested review of D7355: [dagit] Break apart Asset materialization query.
Thu, Apr 8, 7:16 PM
dish accepted D7331: Use Jinja templating.
Thu, Apr 8, 7:11 PM
dish closed D7345: [dagit] Default nav closed.
Thu, Apr 8, 2:38 PM
dish committed R1:d21aad217b00: [dagit] Default nav closed (authored by dish).
[dagit] Default nav closed
Thu, Apr 8, 2:38 PM
dish closed D7284: [dagit] RFC: Simplify GraphQL Playground usage.
Thu, Apr 8, 1:19 AM
dish committed R1:6280ac14a9b3: [dagit] RFC: Simplify GraphQL Playground usage (authored by dish).
[dagit] RFC: Simplify GraphQL Playground usage
Thu, Apr 8, 1:19 AM
dish updated the diff for D7284: [dagit] RFC: Simplify GraphQL Playground usage.

I'm a dummy

Thu, Apr 8, 12:56 AM
dish updated the diff for D7284: [dagit] RFC: Simplify GraphQL Playground usage.

Nope undo

Thu, Apr 8, 12:53 AM
dish updated the diff for D7284: [dagit] RFC: Simplify GraphQL Playground usage.

Manifest

Thu, Apr 8, 12:27 AM

Wed, Apr 7

dish updated the diff for D7284: [dagit] RFC: Simplify GraphQL Playground usage.

Rebase

Wed, Apr 7, 11:52 PM
dish closed D7344: [dagit] Asset: swap "By Partition" and "By Timestamp" default.
Wed, Apr 7, 7:57 PM
dish committed R1:a74ca733d5d7: [dagit] Asset: swap "By Partition" and "By Timestamp" default (authored by dish).
[dagit] Asset: swap "By Partition" and "By Timestamp" default
Wed, Apr 7, 7:57 PM
dish requested review of D7345: [dagit] Default nav closed.
Wed, Apr 7, 7:46 PM
dish closed D7323: [dagit] RFC: Collapsible left nav.
Wed, Apr 7, 7:07 PM
dish committed R1:f66e25d12101: [dagit] RFC: Collapsible left nav (authored by dish).
[dagit] RFC: Collapsible left nav
Wed, Apr 7, 7:07 PM
dish added a comment to D7323: [dagit] RFC: Collapsible left nav.

Sanity checked this in Safari and Firefox as well.

Wed, Apr 7, 7:07 PM
dish requested review of D7344: [dagit] Asset: swap "By Partition" and "By Timestamp" default.
Wed, Apr 7, 7:06 PM
dish closed D7324: [dagit] Enable extended search for global search.
Wed, Apr 7, 7:00 PM
dish committed R1:978b4692ee50: [dagit] Enable extended search for global search (authored by dish).
[dagit] Enable extended search for global search
Wed, Apr 7, 7:00 PM
dish updated the summary of D7284: [dagit] RFC: Simplify GraphQL Playground usage.
Wed, Apr 7, 6:53 PM
dish updated the summary of D7284: [dagit] RFC: Simplify GraphQL Playground usage.
Wed, Apr 7, 6:52 PM
dish added a reviewer for D7284: [dagit] RFC: Simplify GraphQL Playground usage: max.
Wed, Apr 7, 6:51 PM
dish requested review of D7284: [dagit] RFC: Simplify GraphQL Playground usage.
Wed, Apr 7, 6:51 PM
dish updated the diff for D7284: [dagit] RFC: Simplify GraphQL Playground usage.

Check in graphql-playground-react assets instead of using CDN.

Wed, Apr 7, 6:50 PM
dish closed D7338: [dagit] Backfill dialog: separate names from statuses.
Wed, Apr 7, 3:07 PM
dish committed R1:3d66a167bc95: [dagit] Backfill dialog: separate names from statuses (authored by dish).
[dagit] Backfill dialog: separate names from statuses
Wed, Apr 7, 3:06 PM
dish requested review of D7338: [dagit] Backfill dialog: separate names from statuses.
Wed, Apr 7, 2:49 PM

Tue, Apr 6

dish requested review of D7324: [dagit] Enable extended search for global search.
Tue, Apr 6, 6:46 PM
dish requested review of D7323: [dagit] RFC: Collapsible left nav.
Tue, Apr 6, 6:22 PM
dish requested changes to D7315: add bulk actions to asset view, for asset wipe.

We'll need to come up with a solution on the spacing, and I'm very curious about "wipe" vs. "delete".

Tue, Apr 6, 2:12 PM

Mon, Apr 5

dish closed D7299: [dagit] Left nav experiment cleanup.
Mon, Apr 5, 7:03 PM
dish committed R1:e85efee33978: [dagit] Left nav experiment cleanup (authored by dish).
[dagit] Left nav experiment cleanup
Mon, Apr 5, 7:03 PM
dish added a comment to D7248: RFC: Change asset catalog to have combined selector/filter capability.

Are there examples of this pattern in other apps that are worth comparing to?

Mon, Apr 5, 4:36 PM
dish resigned from D4743: Replace timezone-unsafe use of now() and utcnow().

queue mgmt

Mon, Apr 5, 2:44 PM
dish accepted D7248: RFC: Change asset catalog to have combined selector/filter capability.

This looks like a pretty good solution to me.

Mon, Apr 5, 2:44 PM
dish requested review of D7299: [dagit] Left nav experiment cleanup.
Mon, Apr 5, 2:22 PM
dish requested review of D7284: [dagit] RFC: Simplify GraphQL Playground usage.
Mon, Apr 5, 1:37 PM

Fri, Apr 2

dish closed D7290: [dagit] Disallow imports from graphql-tag.
Fri, Apr 2, 10:22 PM
dish committed R1:ebdb6e371b96: [dagit] Disallow imports from graphql-tag (authored by dish).
[dagit] Disallow imports from graphql-tag
Fri, Apr 2, 10:22 PM
dish requested review of D7290: [dagit] Disallow imports from graphql-tag.
Fri, Apr 2, 10:04 PM
dish closed D7251: [dagit] Make sure repoAddress is used for Pipeline definition.
Fri, Apr 2, 7:27 PM
dish committed R1:8b8e92f9c261: [dagit] Make sure repoAddress is used for Pipeline definition (authored by dish).
[dagit] Make sure repoAddress is used for Pipeline definition
Fri, Apr 2, 7:27 PM
dish updated the diff for D7251: [dagit] Make sure repoAddress is used for Pipeline definition.

+dgibson

Fri, Apr 2, 7:18 PM
dish closed D7246: [dagit] Upgrade to React 17.
Fri, Apr 2, 2:42 PM
dish committed R1:98c4b50787c0: [dagit] Upgrade to React 17 (authored by dish).
[dagit] Upgrade to React 17
Fri, Apr 2, 2:42 PM
dish updated the diff for D7246: [dagit] Upgrade to React 17.

Rebase to sanity check BK

Fri, Apr 2, 2:26 PM

Thu, Apr 1

dish committed R1:174bdee2737e: 0.11.3 (authored by dish).
0.11.3
Thu, Apr 1, 9:51 PM
dish committed R1:86e113547010: 0.11.3.pre0 (authored by dish).
0.11.3.pre0
Thu, Apr 1, 9:35 PM
dish closed D7266: Changelog for 0.11.3.
Thu, Apr 1, 9:19 PM
dish committed R1:13fef80d5572: Changelog for 0.11.3 (authored by dish).
Changelog for 0.11.3
Thu, Apr 1, 9:19 PM
dish updated the diff for D7266: Changelog for 0.11.3.

Whitespace

Thu, Apr 1, 9:18 PM
dish published D7266: Changelog for 0.11.3 for review.
Thu, Apr 1, 9:13 PM

Wed, Mar 31

dish requested review of D7251: [dagit] Make sure repoAddress is used for Pipeline definition.
Wed, Mar 31, 10:33 PM
dish requested review of D7246: [dagit] Upgrade to React 17.
Wed, Mar 31, 7:08 PM
dish closed D7225: [dagit] Clean up some dead code and exports.
Wed, Mar 31, 3:25 PM
dish committed R1:f0715e796a94: [dagit] Clean up some dead code and exports (authored by dish).
[dagit] Clean up some dead code and exports
Wed, Mar 31, 3:25 PM
dish closed D7220: [dagit] Fix cache reading in Schedules/Sensors section.
Wed, Mar 31, 2:43 PM
dish committed R1:b8003f4f2dc9: [dagit] Fix cache reading in Schedules/Sensors section (authored by dish).
[dagit] Fix cache reading in Schedules/Sensors section
Wed, Mar 31, 2:43 PM