Page MenuHomePhabricator

dish (Isaac Hellendag)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 14 2020, 6:08 PM (18 w, 3 d)

Recent Activity

Today

dish updated the diff for D6074: [dagit] Granular lodash imports.

Rebase

Thu, Jan 21, 6:34 PM
dish closed D6072: [dagit] Lazy import CodeMirror.
Thu, Jan 21, 6:33 PM
dish committed R1:3ecccdfc557e: [dagit] Lazy import CodeMirror (authored by dish).
[dagit] Lazy import CodeMirror
Thu, Jan 21, 6:33 PM
dish updated the diff for D6072: [dagit] Lazy import CodeMirror.

Remove extra React.Suspense I forgot to remove

Thu, Jan 21, 5:33 PM
dish added a comment to D6072: [dagit] Lazy import CodeMirror.

On https://reactjs.org/docs/code-splitting.html it is listed as the suggested approach for code splitting.

Thu, Jan 21, 5:09 PM
dish requested review of D6078: [dagit] Clean up src I.
Thu, Jan 21, 12:13 AM
dish closed D6079: [dagit] Fix SidebarTabbedContainerSolidQuery.
Thu, Jan 21, 12:08 AM
dish committed R1:169d6e2cbf04: [dagit] Fix SidebarTabbedContainerSolidQuery (authored by dish).
[dagit] Fix SidebarTabbedContainerSolidQuery
Thu, Jan 21, 12:08 AM

Yesterday

dish requested review of D6079: [dagit] Fix SidebarTabbedContainerSolidQuery.
Wed, Jan 20, 11:57 PM
dish requested review of D6074: [dagit] Granular lodash imports.
Wed, Jan 20, 10:47 PM
dish requested review of D6072: [dagit] Lazy import CodeMirror.
Wed, Jan 20, 10:18 PM
dish closed D6049: [dagit] Eliminate static fragments property.
Wed, Jan 20, 3:15 PM
dish committed R1:5db981ff2144: [dagit] Eliminate static fragments property (authored by dish).
[dagit] Eliminate static fragments property
Wed, Jan 20, 3:15 PM
dish added a comment to D6049: [dagit] Eliminate static fragments property.

The only thing I want to be really careful of is that this doesn't lead to a breakdown in the ~1:1 relationship between components and fragments. Eg: SidebarSolidDefinition uses SIDEBAR_SOLID_DEFINITION_FRAGMENT and broadly speaking, other components should define their own fragments that are scoped to their data needs, not re-use that one. We have some places where we are re-using fragments (I am definitely guilty of the GanttChart family of components all sharing a single fragment), but by and large it's a lot easier to keep the graphql queries accurate after refactors, etc. if it's 1:1. It'd be a real bummer if a year from now half the app was sharing RUN_TABLE_RUN_FRAGMENT :-p. Shouldn't be a problem, but we might have to watch out if the team grows and these are nice easy imports!

Wed, Jan 20, 3:06 PM

Tue, Jan 19

dish requested review of D6049: [dagit] Eliminate static fragments property.
Tue, Jan 19, 10:38 PM

Fri, Jan 15

dish closed D6031: [dagit] Upgrade eslint packages.
Fri, Jan 15, 9:42 PM
dish committed R1:89b27c7e0d96: [dagit] Upgrade eslint packages (authored by dish).
[dagit] Upgrade eslint packages
Fri, Jan 15, 9:42 PM
dish closed D6034: [dagit] Whoops, delete some test code.
Fri, Jan 15, 7:32 PM
dish committed R1:1ff91c889c19: [dagit] Whoops, delete some test code (authored by dish).
[dagit] Whoops, delete some test code
Fri, Jan 15, 7:31 PM
dish requested review of D6034: [dagit] Whoops, delete some test code.
Fri, Jan 15, 7:13 PM
dish added inline comments to D5998: [dagit] Improve PythonError case in RunGroupPanel.
Fri, Jan 15, 7:04 PM
dish closed D5998: [dagit] Improve PythonError case in RunGroupPanel.
Fri, Jan 15, 6:02 PM
dish committed R1:1d530668e8cf: [dagit] Improve PythonError case in RunGroupPanel (authored by dish).
[dagit] Improve PythonError case in RunGroupPanel
Fri, Jan 15, 6:02 PM
dish requested review of D6031: [dagit] Upgrade eslint packages.
Fri, Jan 15, 5:11 PM

Thu, Jan 14

dish requested review of D5998: [dagit] Improve PythonError case in RunGroupPanel.
Thu, Jan 14, 6:23 PM
dish added a comment to D5985: fix tick history panning, tooltip width.

Could the text wrap instead of being truncated?

Thu, Jan 14, 2:37 PM

Wed, Jan 13

dish closed D5951: [dagit] Add "Scheduled" tab to Runs page.
Wed, Jan 13, 8:44 PM
dish committed R1:c15c791102c5: [dagit] Add "Scheduled" tab to Runs page (authored by dish).
[dagit] Add "Scheduled" tab to Runs page
Wed, Jan 13, 8:44 PM
dish added a comment to D5951: [dagit] Add "Scheduled" tab to Runs page.

Wed, Jan 13, 8:06 PM
dish updated the diff for D5951: [dagit] Add "Scheduled" tab to Runs page.

Show pipeline name instead of repo, remove YYYY from timestamp format

Wed, Jan 13, 8:06 PM
dish closed D5952: [dagit] Use tabular-nums spacing on TimestampDisplay.
Wed, Jan 13, 5:24 PM
dish committed R1:44ac12ed0195: [dagit] Use tabular-nums spacing on TimestampDisplay (authored by dish).
[dagit] Use tabular-nums spacing on TimestampDisplay
Wed, Jan 13, 5:24 PM
dish added a comment to D5951: [dagit] Add "Scheduled" tab to Runs page.

Wed, Jan 13, 5:22 PM
dish updated the diff for D5951: [dagit] Add "Scheduled" tab to Runs page.

Add (and tweak) SchedulerInfo

Wed, Jan 13, 5:21 PM
dish requested review of D5952: [dagit] Use tabular-nums spacing on TimestampDisplay.
Wed, Jan 13, 4:18 PM
dish added a comment to D5951: [dagit] Add "Scheduled" tab to Runs page.

Empty state:

Wed, Jan 13, 4:07 PM
dish added a comment to D5951: [dagit] Add "Scheduled" tab to Runs page.

Yeah sorry, was cleaning some things up.

Wed, Jan 13, 4:06 PM
dish updated the diff for D5951: [dagit] Add "Scheduled" tab to Runs page.

Consistent language

Wed, Jan 13, 4:06 PM
dish requested review of D5951: [dagit] Add "Scheduled" tab to Runs page.
Wed, Jan 13, 4:05 PM
dish closed D5935: [dagit] Reduce some extra renders in Schedules table.
Wed, Jan 13, 3:48 PM
dish committed R1:c9d84c8c1689: [dagit] Reduce some extra renders in Schedules table (authored by dish).
[dagit] Reduce some extra renders in Schedules table
Wed, Jan 13, 3:48 PM
dish added a comment to D5946: set reasonable blank state for upcoming ticks.

I'm about to change some things here to support the Runs page, and will include an empty state there.

Wed, Jan 13, 2:58 PM

Tue, Jan 12

dish accepted D5933: fix non-unique ids for partition status.
Tue, Jan 12, 8:27 PM
dish requested review of D5935: [dagit] Reduce some extra renders in Schedules table.
Tue, Jan 12, 8:18 PM
dish closed D5930: [dagit] Update "Timing" column for Queued runs.
Tue, Jan 12, 7:25 PM
dish committed R1:644af99eefdc: [dagit] Update "Timing" column for Queued runs (authored by dish).
[dagit] Update "Timing" column for Queued runs
Tue, Jan 12, 7:25 PM
dish added a comment to D5930: [dagit] Update "Timing" column for Queued runs.

Tue, Jan 12, 7:05 PM
dish updated the diff for D5930: [dagit] Update "Timing" column for Queued runs.

Hide elapsed time if queued

Tue, Jan 12, 7:02 PM
dish requested review of D5930: [dagit] Update "Timing" column for Queued runs.
Tue, Jan 12, 6:48 PM
dish closed D5915: [dagit] Link to run config from Queued tab.
Tue, Jan 12, 6:25 PM
dish committed R1:e30868ea2503: [dagit] Link to run config from Queued tab (authored by dish).
[dagit] Link to run config from Queued tab
Tue, Jan 12, 6:25 PM
dish closed D5888: [dagit] Don't disappear Daemon statuses when loading.
Tue, Jan 12, 4:31 PM
dish committed R1:c19a2edde96c: [dagit] Don't disappear Daemon statuses when loading (authored by dish).
[dagit] Don't disappear Daemon statuses when loading
Tue, Jan 12, 4:31 PM

Mon, Jan 11

dish accepted D5914: Unify sensor timeline / job history graphs, tick history improvements.
Mon, Jan 11, 11:43 PM
dish closed D5909: [dagit] Use tabular-nums for in-progress solid execution timing.
Mon, Jan 11, 8:56 PM
dish committed R1:55ca42084711: [dagit] Use tabular-nums for in-progress solid execution timing (authored by dish).
[dagit] Use tabular-nums for in-progress solid execution timing
Mon, Jan 11, 8:56 PM
dish requested review of D5915: [dagit] Link to run config from Queued tab.
Mon, Jan 11, 8:36 PM
dish closed D5911: [dagit] Repair counts for queued/in-progress run tabs.
Mon, Jan 11, 7:15 PM
dish committed R1:47ee835a8e48: [dagit] Repair counts for queued/in-progress run tabs (authored by dish).
[dagit] Repair counts for queued/in-progress run tabs
Mon, Jan 11, 7:15 PM
dish added a comment to D5911: [dagit] Repair counts for queued/in-progress run tabs.

(Discussed in standup -- the statuses key will override ...filter for queuedFilter and inProgressFilter, which should be correct.)

Mon, Jan 11, 6:58 PM
dish added inline comments to D5911: [dagit] Repair counts for queued/in-progress run tabs.
Mon, Jan 11, 6:30 PM
dish requested review of D5911: [dagit] Repair counts for queued/in-progress run tabs.
Mon, Jan 11, 6:18 PM
dish requested review of D5909: [dagit] Use tabular-nums for in-progress solid execution timing.
Mon, Jan 11, 5:31 PM
dish closed D5905: [dagit] Repair tooltip flickering in log list.
Mon, Jan 11, 4:55 PM
dish committed R1:80354a25b590: [dagit] Repair tooltip flickering in log list (authored by dish).
[dagit] Repair tooltip flickering in log list
Mon, Jan 11, 4:55 PM
dish requested review of D5905: [dagit] Repair tooltip flickering in log list.
Mon, Jan 11, 4:37 PM

Fri, Jan 8

dish closed D5839: [dagit] Add `id` to PartitionSet.
Fri, Jan 8, 11:32 PM
dish committed R1:1925f1043faf: [dagit] Add `id` to PartitionSet (authored by dish).
[dagit] Add `id` to PartitionSet
Fri, Jan 8, 11:32 PM
dish updated the diff for D5839: [dagit] Add `id` to PartitionSet.

black

Fri, Jan 8, 11:06 PM
dish updated the diff for D5888: [dagit] Don't disappear Daemon statuses when loading.

I think I like the Loading text better than the spinner

Fri, Jan 8, 11:04 PM
dish requested review of D5888: [dagit] Don't disappear Daemon statuses when loading.
Fri, Jan 8, 11:04 PM
dish updated the diff for D5839: [dagit] Add `id` to PartitionSet.

+nate

Fri, Jan 8, 10:59 PM
dish updated the diff for D5839: [dagit] Add `id` to PartitionSet.

Remove print, something seems broken

Fri, Jan 8, 10:44 PM
dish updated the diff for D5839: [dagit] Add `id` to PartitionSet.

Trying again

Fri, Jan 8, 10:42 PM
dish updated the diff for D5839: [dagit] Add `id` to PartitionSet.

Print diff_files for BK

Fri, Jan 8, 10:37 PM
dish updated the diff for D5839: [dagit] Add `id` to PartitionSet.

Update test

Fri, Jan 8, 10:19 PM
dish closed D5880: [dagit] Minor changes to "Next tick" timestamp.
Fri, Jan 8, 5:48 PM
dish committed R1:312a8b5dd45c: [dagit] Minor changes to "Next tick" timestamp (authored by dish).
[dagit] Minor changes to "Next tick" timestamp
Fri, Jan 8, 5:47 PM
dish requested review of D5880: [dagit] Minor changes to "Next tick" timestamp.
Fri, Jan 8, 5:01 PM
dish closed D5856: [dagit] Make sections of Instance config page linkable.
Fri, Jan 8, 4:02 PM
dish committed R1:11760a5296a8: [dagit] Make sections of Instance config page linkable (authored by dish).
[dagit] Make sections of Instance config page linkable
Fri, Jan 8, 4:02 PM
dish updated the diff for D5856: [dagit] Make sections of Instance config page linkable.

Rebase

Fri, Jan 8, 3:51 PM
dish closed D5868: formatElapsedTime proposal for <10s.
Fri, Jan 8, 3:47 PM
dish committed R1:4d0a6846772b: formatElapsedTime proposal for <10s (authored by dish).
formatElapsedTime proposal for <10s
Fri, Jan 8, 3:47 PM
dish closed D5866: [dagit] Prefer user timezone on Schedule ticks.
Fri, Jan 8, 3:47 PM
dish committed R1:eb0183c12ebf: [dagit] Prefer user timezone on Schedule ticks (authored by dish).
[dagit] Prefer user timezone on Schedule ticks
Fri, Jan 8, 3:47 PM
dish added a comment to D5839: [dagit] Add `id` to PartitionSet.

Added some Python changes to include a generated ID for PartitionSet. Fairly dogscience, so please let me know if I did it all wrong or missed something.

Fri, Jan 8, 3:44 PM
dish requested review of D5839: [dagit] Add `id` to PartitionSet.
Fri, Jan 8, 3:43 PM
dish updated the diff for D5839: [dagit] Add `id` to PartitionSet.

Use a generated ID instead, to avoid name collisions across repositories.

Fri, Jan 8, 3:43 PM
dish closed D5870: Upgrade TypeScript, react-scripts.
Fri, Jan 8, 3:38 PM
dish committed R1:76ef7f7cc80b: Upgrade TypeScript, react-scripts (authored by dish).
Upgrade TypeScript, react-scripts
Fri, Jan 8, 3:38 PM
dish added inline comments to D5839: [dagit] Add `id` to PartitionSet.
Fri, Jan 8, 3:19 PM
dish updated the diff for D5839: [dagit] Add `id` to PartitionSet.

Regenerate types

Fri, Jan 8, 3:00 PM

Thu, Jan 7

dish closed D5822: [dagit] Consolidate pieces into "Instance details".
Thu, Jan 7, 10:52 PM
dish committed R1:e739c881d90b: [dagit] Consolidate pieces into "Instance details" (authored by dish).
[dagit] Consolidate pieces into "Instance details"
Thu, Jan 7, 10:52 PM
dish requested review of D5870: Upgrade TypeScript, react-scripts.
Thu, Jan 7, 10:51 PM
dish requested review of D5868: formatElapsedTime proposal for <10s.
Thu, Jan 7, 9:50 PM
dish requested review of D5866: [dagit] Prefer user timezone on Schedule ticks.
Thu, Jan 7, 9:38 PM
dish updated the diff for D5822: [dagit] Consolidate pieces into "Instance details".

Test, use CSS for uppercase headers

Thu, Jan 7, 9:04 PM
dish closed D5859: Some Jest cleanup.
Thu, Jan 7, 8:54 PM