User Details
User Details
- User Since
- Sep 14 2020, 6:08 PM (141 w, 4 d)
- Roles
- Disabled
Aug 9 2021
Aug 9 2021
• dish committed R1:c7c169e4dcfc: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription (authored by • dish).
[dagit] RFC: useSubscription instead of DirectGraphQLSubscription
• dish updated the diff for D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.
Extra fragment wrapper
• dish added inline comments to D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.
• dish updated the diff for D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.
Use message batching in LogsProvider to ensure smooth Gantt animation.
• dish committed R1:65af656835d5: [dagit] Extract ContentRoot to be an App child (authored by • dish).
[dagit] Extract ContentRoot to be an App child
• dish added a comment to D9211: [dagit] Extract ContentRoot to be an App child.
This is so that the cloud index can add cloud-specific routes?
• dish requested review of D9211: [dagit] Extract ContentRoot to be an App child.
[dagit] Enable limited frame-src
• dish requested review of D9210: [dagit] Enable limited frame-src.
Aug 4 2021
Aug 4 2021
• dish committed R1:fc435395a8c6: [dagit] Lazy-load partition set info for Schedules (authored by • dish).
[dagit] Lazy-load partition set info for Schedules
• dish updated the diff for D9202: [dagit] Lazy-load partition set info for Schedules.
Show coverage
• dish added a comment to D9202: [dagit] Lazy-load partition set info for Schedules.
• dish updated the diff for D9202: [dagit] Lazy-load partition set info for Schedules.
+alangenfeld
Aug 3 2021
Aug 3 2021
• dish requested review of D9202: [dagit] Lazy-load partition set info for Schedules.
[dagit] Perms followup
• dish requested review of D9196: [dagit] Perms followup.
[dagit] Add Permissions query
• dish added a comment to D9185: [dagit] Add Permissions query.
Does this require any changes in the internal repo in order to avoid any breaking changes there?
• dish updated the diff for D9185: [dagit] Add Permissions query.
Compatibility, expose raw permission array.
Aug 2 2021
Aug 2 2021
• dish requested review of D9185: [dagit] Add Permissions query.
• dish added inline comments to D9181: allow step failure events to have no serialized error.
• dish updated the diff for D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.
Fix ref error in useViewport
• dish committed R1:e93b23ef47e9: [dagit] Stop overfetching schedule/sensor in JobMetadata (authored by • dish).
[dagit] Stop overfetching schedule/sensor in JobMetadata
• dish added inline comments to D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.
Jul 30 2021
Jul 30 2021
• dish requested review of D9170: [dagit] Stop overfetching schedule/sensor in JobMetadata.
• dish updated the diff for D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.
Commented line
• dish requested review of D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.
Jul 29 2021
Jul 29 2021
• dish published D9153: fix tooltip content for sensor timeline for review.
• dish committed R1:582094301440: [dagit] Repair repo specificity on Run details and re-execution (authored by • dish).
[dagit] Repair repo specificity on Run details and re-execution
• dish committed R1:02a26b61b970: [dagit] Repair layout worker, large DAG loading (authored by • dish).
[dagit] Repair layout worker, large DAG loading
• dish updated the diff for D9144: [dagit] Repair repo specificity on Run details and re-execution.
+yuhan
• dish updated the diff for D9124: [dagit] Repair layout worker, large DAG loading.
Comment regarding React dependency
• dish added a comment to D9124: [dagit] Repair layout worker, large DAG loading.
just to confirm then... was this not broken on prod?
• dish requested review of D9144: [dagit] Repair repo specificity on Run details and re-execution.
• dish added a comment to D9124: [dagit] Repair layout worker, large DAG loading.
Is there a way to run a test to make sure that the worker compiles? Seems like an easy thing to break again with a random refactor.
Jul 28 2021
Jul 28 2021
• dish updated the summary of D9124: [dagit] Repair layout worker, large DAG loading.
• dish added a comment to D9124: [dagit] Repair layout worker, large DAG loading.
Is there a way to test that the layout worker doesn't have imports (direct or transitive) that will break it?
• dish requested review of D9124: [dagit] Repair layout worker, large DAG loading.
[dagit] TS 4.3.5
• dish requested review of D9119: [dagit] TS 4.3.5.
Jul 27 2021
Jul 27 2021
[dagit] Move WebSocket context
• dish committed R1:b776ad8edc20: [dagit] Refactor components with subscriptions (authored by • dish).
[dagit] Refactor components with subscriptions
• dish updated the diff for D9089: [dagit] Move WebSocket context.
Stringify to ensure we keep the same header object
• dish added inline comments to D9089: [dagit] Move WebSocket context.
• dish requested review of D9089: [dagit] Move WebSocket context.
• dish updated the diff for D9087: [dagit] Refactor components with subscriptions.
setNodes() when runId changes
[dagit] Fix manifest
• dish requested review of D9087: [dagit] Refactor components with subscriptions.
• dish committed R1:62568ae3388e: [dagit] Show start/end information on latest run in Job details (authored by • dish).
[dagit] Show start/end information on latest run in Job details
[dagit] Modify App initialization config
• dish updated the diff for D8956: [dagit] Show start/end information on latest run in Job details.
Rebase
• dish updated the summary of D9065: [dagit] Modify App initialization config.
Jul 26 2021
Jul 26 2021
• dish requested review of D9065: [dagit] Modify App initialization config.
• dish updated the diff for D8956: [dagit] Show start/end information on latest run in Job details.
Rebase
Jul 22 2021
Jul 22 2021
• dish requested review of D9030: [dagit] Fix manifest.
[dagit] Handle WS issue in CSP for Safari
• dish updated the diff for D9012: [dagit] Handle WS issue in CSP for Safari.
Fix local commits
• dish published D9012: [dagit] Handle WS issue in CSP for Safari for review.
Jul 21 2021
Jul 21 2021
• dish committed R1:651b7e83fa71: [dagit] Fix link to partition from schedule page (authored by • dish).
[dagit] Fix link to partition from schedule page
[dagit] Fix JobMetadataQuery for non-crag
• dish requested review of D8992: [dagit] Fix link to partition from schedule page.
• dish requested review of D8991: [dagit] Fix JobMetadataQuery for non-crag.
Jul 20 2021
Jul 20 2021
• dish updated the diff for D8956: [dagit] Show start/end information on latest run in Job details.
Remove TimeElapsed change
• dish updated the diff for D8956: [dagit] Show start/end information on latest run in Job details.
Use RunTime instead
[dagit] Delete some dead JS
• dish requested review of D8962: [dagit] Delete some dead JS.
[dagit] Delete /flags
[dagit] Crag: solid -> op
• dish requested review of D8961: [dagit] Delete /flags.
Jul 19 2021
Jul 19 2021
• dish committed R1:10d76954dee1: [dagit] Include credentials on GraphQL playground (authored by • dish).
[dagit] Include credentials on GraphQL playground