User Details
User Details
- User Since
- Jul 6 2020, 12:49 PM (41 w, 2 h)
Today
Today
dgibson added reviewers for D7494: Refactor how we handle exceptions in daemons: prha, johann, alangenfeld.
dgibson updated the diff for D7494: Refactor how we handle exceptions in daemons.
up
Sat, Apr 17
Sat, Apr 17
dgibson requested review of D7495: Fix termination in docker deploy example.
dgibson updated the diff for D7494: Refactor how we handle exceptions in daemons.
up
dgibson requested review of D7494: Refactor how we handle exceptions in daemons.
dgibson committed R1:58be49bd59f5: Add a default gRPC timeout to better handle slow/hanging sensors in the daemon (authored by dgibson).
Add a default gRPC timeout to better handle slow/hanging sensors in the daemon
include stack trace in repo failure
Fri, Apr 16
Fri, Apr 16
dgibson committed R1:1beeea2e0446: Fix issue with error handling in ProcessGrpcServerRegistry (authored by dgibson).
Fix issue with error handling in ProcessGrpcServerRegistry
dgibson added a comment to D7477: Fix issue with error handling in ProcessGrpcServerRegistry.
I'd like to try to cherry pick this if reviewers have a sec (since the blamerev is going out in the release)
dgibson added a reviewer for D7477: Fix issue with error handling in ProcessGrpcServerRegistry: prha.
dgibson added a reviewer for D7477: Fix issue with error handling in ProcessGrpcServerRegistry: alangenfeld.
dgibson added reviewers for D7477: Fix issue with error handling in ProcessGrpcServerRegistry: sashank, johann, max.
dgibson requested review of D7477: Fix issue with error handling in ProcessGrpcServerRegistry.
Thu, Apr 15
Thu, Apr 15
dgibson committed R1:8a7068dcd634: Add some overridable methods to ProcessGrpcServerRegistry to make it extendable… (authored by dgibson).
Add some overridable methods to ProcessGrpcServerRegistry to make it extendable…
dgibson requested changes to D7395: Provide more detailed SkipReasons.
sorry for all the back and forth here, just looking to get the copy super clear since the early check is a common source of user confusion in #general
Wed, Apr 14
Wed, Apr 14
dgibson requested changes to D7395: Provide more detailed SkipReasons.
Tue, Apr 13
Tue, Apr 13
dgibson requested changes to D7395: Provide more detailed SkipReasons.
this generally makes a ton of sense to me, I just had some more time to think about the exact copy to use for maximum clarify, left some thoughts inline.
@prha may have thoughts here too.
dgibson committed R1:a214cf57df0b: Change today_at_midnight default timezone to UTC (authored by dgibson).
Change today_at_midnight default timezone to UTC
Mon, Apr 12
Mon, Apr 12
dgibson updated the diff for D7398: Change today_at_midnight default timezone to UTC.
up
dgibson published D7398: Change today_at_midnight default timezone to UTC for review.
Quick pass on deploying to airflow docs
dgibson updated the diff for D7387: Quick pass on deploying to airflow docs.
rebase
dgibson published D7388: pin jupyter-client for review.
dgibson published D7387: Quick pass on deploying to airflow docs for review.
Sat, Apr 10
Sat, Apr 10
Fri, Apr 9
Fri, Apr 9
dgibson committed R1:a57196c29d87: Move run worker host mode code to its own module (authored by dgibson).
Move run worker host mode code to its own module
dgibson committed R1:07369c5f5222: Incorporate run config into choosing the executor in host mode run worker flow (authored by dgibson).
Incorporate run config into choosing the executor in host mode run worker flow
dgibson committed R1:1980c16c9edd: Move user-code-dependent executor validation to execution plan generation… (authored by dgibson).
Move user-code-dependent executor validation to execution plan generation…
dgibson updated the diff for D7327: Move run worker host mode code to its own module.
up
dgibson updated the diff for D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker.
up
dgibson requested changes to D7366: Add MayHaveInstanceWeakref mixin to GrpcServerRegistry.
This might be better suited for the specific subclass you’re working with that’s already associated with an instance?
Thu, Apr 8
Thu, Apr 8
should some test have broken that this would fix?
dgibson updated the diff for D7327: Move run worker host mode code to its own module.
up
dgibson updated the diff for D7317: Incorporate run config into choosing the executor in host mode run worker flow.
upx
dgibson updated the diff for D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker.
up
Wed, Apr 7
Wed, Apr 7
dgibson updated the diff for D7327: Move run worker host mode code to its own module.
up
dgibson updated the diff for D7317: Incorporate run config into choosing the executor in host mode run worker flow.
up
dgibson updated the diff for D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker.
ExecutorProcessSetting => List[ExecutorRequirement]
Fix integration tests
dgibson requested review of D7346: Fix integration tests.
dgibson committed R1:51b0fd6953d3: Add property to storage tables to turn auto-create behavior on and off (authored by dgibson).
Add property to storage tables to turn auto-create behavior on and off
dgibson updated the diff for D7332: Add property to storage tables to turn auto-create behavior on and off.
rename param
dgibson added a comment to D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker.
@alex you have accepted the two follow-on diffs to this but the base of the stack remains :) ExecutorProcessSetting giving you pause?
dgibson updated the diff for D7332: Add property to storage tables to turn auto-create behavior on and off.
up
dgibson requested review of D7327: Move run worker host mode code to its own module.
flake test failure
dgibson updated the diff for D7332: Add property to storage tables to turn auto-create behavior on and off.
add test
dgibson added reviewers for D7332: Add property to storage tables to turn auto-create behavior on and off: max, johann, alangenfeld, prha.
dgibson requested review of D7332: Add property to storage tables to turn auto-create behavior on and off.
no need for a single metadata
Tue, Apr 6
Tue, Apr 6
dgibson planned changes to D7328: RFC: Allow storages to specify a custom sqlalchemy metadata class.
dgibson published D7328: RFC: Allow storages to specify a custom sqlalchemy metadata class for review.
dgibson updated the diff for D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker.
up
dgibson committed R1:09a4531c2be2: Make more dagster grpc server parameters controllable via env var (authored by dgibson).
Make more dagster grpc server parameters controllable via env var
dgibson updated the diff for D7319: Make more dagster grpc server parameters controllable via env var.
use env vars
dgibson requested review of D7319: Make more dagster grpc server parameters controllable via env var.
dgibson updated the diff for D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker.
up
dgibson accepted D6017: initial async solids support.
sorry for sitting on this forever.
dgibson committed R1:93032442ddd6: Fixes for errors when a daemon thread goes down (authored by dgibson).
Fixes for errors when a daemon thread goes down
dgibson committed R1:9a34a487e6c3: Don't rely on COMPOSE_PROJECT_IMAGE to set the pipeline code image in the… (authored by dgibson).
Don't rely on COMPOSE_PROJECT_IMAGE to set the pipeline code image in the…
raise exceptions from grpc methods
dgibson updated the diff for D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker.
up
dgibson updated the diff for D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker.
enum on the ExecutorDefinition
Mon, Apr 5
Mon, Apr 5
dgibson published D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker for review.
probably 80% of this diff is passing DagsterInstances around so that we can access it during plan creation to validate the executor, I could split that part out into a separate diff if that would make it easier to review
Sun, Apr 4
Sun, Apr 4
dgibson requested review of D7295: raise exceptions from grpc methods.
Sat, Apr 3
Sat, Apr 3
Fri, Apr 2
Fri, Apr 2