Page MenuHomeElementl

dgibson (Daniel Gibson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 6 2020, 12:49 PM (50 w, 1 d)

Recent Activity

Yesterday

dgibson accepted D8475: Include ENI infornmation in ECS task stubs.
Tue, Jun 22, 12:50 AM

Mon, Jun 21

dgibson closed D8477: Add 'set_dagster_home' flag to instance_for_test.
Mon, Jun 21, 6:51 PM
dgibson committed R1:f152cbb98624: Add 'set_dagster_home' flag to instance_for_test (authored by dgibson).
Add 'set_dagster_home' flag to instance_for_test
Mon, Jun 21, 6:51 PM
dgibson accepted D8456: fix: assert compute log manager json schema matches configurable class.
Mon, Jun 21, 5:31 PM
dgibson accepted D8474: Tag runs with ECS info.
Mon, Jun 21, 5:26 PM

Sat, Jun 19

dgibson closed D8455: Pin dagster-XXX libraries to the same version as dagster.
Sat, Jun 19, 2:17 AM
dgibson committed R1:5fcfd7bdce3b: Pin dagster-XXX libraries to the same version as dagster (authored by dgibson).
Pin dagster-XXX libraries to the same version as dagster
Sat, Jun 19, 2:17 AM

Fri, Jun 18

dgibson accepted D8473: Ensure AWS unit tests never run against real AWS.

no HBO max issues for us

Fri, Jun 18, 9:53 PM
dgibson published D8477: Add 'set_dagster_home' flag to instance_for_test for review.
Fri, Jun 18, 9:46 PM
dgibson added a reviewer for D8455: Pin dagster-XXX libraries to the same version as dagster: prha.
Fri, Jun 18, 9:32 PM
dgibson closed D8467: Bugfixes for dagits checking cookies on each request.
Fri, Jun 18, 7:15 PM
dgibson committed R1:29f8ccb20a59: Bugfixes for dagits checking cookies on each request (authored by dgibson).
Bugfixes for dagits checking cookies on each request
Fri, Jun 18, 7:15 PM
dgibson published D8467: Bugfixes for dagits checking cookies on each request for review.
Fri, Jun 18, 6:58 PM
dgibson accepted D8400: Stub ECS ListTasks.
Fri, Jun 18, 6:41 PM
dgibson published D8455: Pin dagster-XXX libraries to the same version as dagster for review.
Fri, Jun 18, 4:01 PM
dgibson closed D8446: Make WorkspaceRequestContext a base class.
Fri, Jun 18, 3:41 PM
dgibson committed R1:ac2731fa6f7b: Make WorkspaceRequestContext a base class (authored by dgibson).
Make WorkspaceRequestContext a base class
Fri, Jun 18, 3:41 PM
dgibson accepted D8448: remove 0.11.14 pre-release version from the docs version.
Fri, Jun 18, 3:04 AM

Thu, Jun 17

dgibson requested review of D8446: Make WorkspaceRequestContext a base class.
Thu, Jun 17, 10:47 PM
dgibson accepted D8417: Mixin ConfigurableClass with EcsRunLauncher.
Thu, Jun 17, 10:25 PM
dgibson accepted D8407: Remove unused ECS Client.
Thu, Jun 17, 10:25 PM
dgibson accepted D8405: Terminate ECS runs.
Thu, Jun 17, 10:25 PM
dgibson added a comment to D8404: Launch runs in ECS.

Ah, termination is in the next diff

Thu, Jun 17, 10:23 PM
dgibson accepted D8404: Launch runs in ECS.
Thu, Jun 17, 10:23 PM
dgibson accepted D8403: Stub ECS StopTask.
Thu, Jun 17, 10:15 PM
dgibson accepted D8402: Stub ECS ListTagsForResource for tasks only.
Thu, Jun 17, 10:14 PM
dgibson accepted D8401: Stub ECS TagResource for tasks only.
Thu, Jun 17, 10:13 PM
dgibson accepted D8399: Stub ECS DescribeTasks.
Thu, Jun 17, 10:13 PM
dgibson accepted D8398: Stub ECS RunTask.
Thu, Jun 17, 10:12 PM
dgibson accepted D8397: Stub ECS DescribeTaskDefinition.
Thu, Jun 17, 10:11 PM
dgibson accepted D8396: Stub ECS RegisterTaskDefinition.
Thu, Jun 17, 10:10 PM
dgibson accepted D8438: 0.11.14 changelog.
Thu, Jun 17, 7:44 PM

Wed, Jun 16

dgibson accepted D8393: Add instance to compute log manager.
Wed, Jun 16, 1:57 PM

Tue, Jun 15

dgibson closed D8377: Speed up deploy-docker build.sh file.
Tue, Jun 15, 7:56 PM
dgibson committed R1:a5415528e6ea: Speed up deploy-docker build.sh file (authored by dgibson).
Speed up deploy-docker build.sh file
Tue, Jun 15, 7:56 PM
dgibson requested review of D8377: Speed up deploy-docker build.sh file.

unrelated test failure

Tue, Jun 15, 4:49 PM
dgibson requested changes to D8211: feat: retrieve partition set names from external partition set in schedule based partitions.

overall this makes sense to me - tweak some names and remove some extra timezone fields and i think we're good

Tue, Jun 15, 4:09 AM

Sat, Jun 12

dgibson closed D8358: remove 0.11.14 RCs from docs.
Sat, Jun 12, 1:27 AM
dgibson committed R1:afe5e08c7c3c: remove 0.11.14 RCs from docs (authored by dgibson).
remove 0.11.14 RCs from docs
Sat, Jun 12, 1:26 AM

Fri, Jun 11

dgibson closed D8339: Be less strict in dagster image build CLI about the environment matching the passed in version.
Fri, Jun 11, 8:34 PM
dgibson committed R1:7c9a752e9a82: Be less strict in dagster image build CLI about the environment matching the… (authored by dgibson).
Be less strict in dagster image build CLI about the environment matching the…
Fri, Jun 11, 8:34 PM
dgibson updated the diff for D8339: Be less strict in dagster image build CLI about the environment matching the passed in version.

missed a spot

Fri, Jun 11, 5:03 PM
dgibson updated the diff for D8339: Be less strict in dagster image build CLI about the environment matching the passed in version.

up

Fri, Jun 11, 4:47 PM
dgibson added a comment to D8339: Be less strict in dagster image build CLI about the environment matching the passed in version.

My understanding is we're not skipping step 6, but it's not doing exactly what you think it is. "dagster-release release" doesn't increment the dagster version in the virtual environment (it doesn't modify it in place, it does a git push to the repository in a separate checkout). So it does incrementsthe dagster version if you do a fresh checkout of the release branch. If we re-generated the virtual environment, it would now be on the correct version, which is why the pipeline succeeds if you re-run it and rebuild the virtual environment.

Fri, Jun 11, 3:12 PM
dgibson added a comment to D8226: fix: create daemons without using reference to instance.

probably will require a quick internal change too right?

Fri, Jun 11, 2:37 PM
dgibson accepted D8226: fix: create daemons without using reference to instance.
Fri, Jun 11, 2:36 PM
dgibson added a comment to D8339: Be less strict in dagster image build CLI about the environment matching the passed in version.

er, my mistake, it's running using the build environment (which is on the release branch but doesn't have the newly written dagster version that the dagster-release release command created - the code is correct, the version is not. That's why it works when you re-run the pipeline)

Fri, Jun 11, 2:15 PM
dgibson added inline comments to D8339: Be less strict in dagster image build CLI about the environment matching the passed in version.
Fri, Jun 11, 2:01 PM
dgibson added inline comments to D8324: get_stored_events and get_stored_runs.
Fri, Jun 11, 1:32 PM
dgibson retitled D8339: Be less strict in dagster image build CLI about the environment matching the passed in version from Be less strict in dagster image build CLI about to Be less strict in dagster image build CLI about the environment matching the passed in version.
Fri, Jun 11, 4:14 AM
dgibson requested review of D8339: Be less strict in dagster image build CLI about the environment matching the passed in version.
Fri, Jun 11, 4:10 AM

Thu, Jun 10

dgibson closed D8336: CHANGES.md for 01113.
Thu, Jun 10, 10:19 PM
dgibson committed R1:ac4e0fe8bc38: CHANGES.md for 01113 (authored by dgibson).
CHANGES.md for 01113
Thu, Jun 10, 10:19 PM
dgibson updated the diff for D8336: CHANGES.md for 01113.

tweaks

Thu, Jun 10, 8:41 PM
dgibson requested review of D8336: CHANGES.md for 01113.
Thu, Jun 10, 8:23 PM
dgibson accepted D8330: [dagster-graphql-client] Make `use_https` required.

add @owen's suggestion and this looks good to me

Thu, Jun 10, 5:12 PM
dgibson added a comment to D8321: Add CLI command to reset migration state.

An option that lets you pass in a custom rev does seem like a good idea too (in the case before, we could have set them to the pre-0.10.0 rev that we expected them to be at)

Thu, Jun 10, 2:41 PM
dgibson added a comment to D8321: Add CLI command to reset migration state.

It seemed to work with the specific migration that prompted this (0.10.9 => 0.11.13)

Thu, Jun 10, 2:28 PM
dgibson closed D8304: remove automation.release module from OSS.
Thu, Jun 10, 1:57 PM
dgibson committed R1:6b062611362c: remove automation.release module from OSS (authored by dgibson).
remove automation.release module from OSS
Thu, Jun 10, 1:57 PM
dgibson added a comment to D8304: remove automation.release module from OSS.

landing this now so that there aren't two dagster-release CLIs during the release (one in automation and one in automation-internal) - will revert if the internal release plan today doesn't work out for some reasn

Thu, Jun 10, 1:56 PM

Wed, Jun 9

dgibson accepted D8320: [dagster-graphql-client] Allow HTTPS use.
Wed, Jun 9, 10:22 PM
dgibson accepted D8308: [dagit] Generate GraphQL types first in tox.
Wed, Jun 9, 10:20 PM
dgibson accepted D8144: Remove inclusive parameter when generating schedule partition ranges.

sweet, thank you for powering through that, the universe makes sense again :)

Wed, Jun 9, 10:19 PM
dgibson retitled D8304: remove automation.release module from OSS from remove automation module from OSS to remove automation.release module from OSS.
Wed, Jun 9, 4:26 PM
dgibson requested review of D8304: remove automation.release module from OSS.
Wed, Jun 9, 4:24 PM
dgibson accepted D8292: [RFC] Add a reference deployment for ECS.

yeah to johann's point - the docker-compose setup here is basically identical other than that the image comes from $REGISTRY_URL right? (and the RunLauncher will be an ECSRunLauncher eventually - although will that similarly be able to use the DockerRunLauncher with different Docker creds do you think?)

Wed, Jun 9, 2:08 PM

Tue, Jun 8

dgibson closed D8264: Do Postgres/MySQL table creation in a transaction.
Tue, Jun 8, 11:57 PM
dgibson committed R1:540fcbbf2894: Do Postgres/MySQL table creation in a transaction (authored by dgibson).
Do Postgres/MySQL table creation in a transaction
Tue, Jun 8, 11:57 PM
dgibson closed D8284: Simplify how we specify the list of available executors to execute_run_host_mode.
Tue, Jun 8, 11:56 PM
dgibson committed R1:59b5668839c6: Simplify how we specify the list of available executors to execute_run_host_mode (authored by dgibson).
Simplify how we specify the list of available executors to execute_run_host_mode
Tue, Jun 8, 11:56 PM
dgibson published D8284: Simplify how we specify the list of available executors to execute_run_host_mode for review.
Tue, Jun 8, 4:53 PM
dgibson accepted D8280: move last_empty_partition to test file.
Tue, Jun 8, 2:05 PM

Mon, Jun 7

dgibson closed D8274: Add test that runs graphql_client.get_run_status against a real graphql context.
Mon, Jun 7, 7:57 PM
dgibson committed R1:03e2b9b93038: Add test that runs graphql_client.get_run_status against a real graphql context (authored by dgibson).
Add test that runs graphql_client.get_run_status against a real graphql context
Mon, Jun 7, 7:57 PM
dgibson requested review of D8274: Add test that runs graphql_client.get_run_status against a real graphql context.
Mon, Jun 7, 7:21 PM
dgibson requested review of D8264: Do Postgres/MySQL table creation in a transaction.
Mon, Jun 7, 4:44 PM
dgibson closed D8268: Fixes for dagster-mysql local runs.
Mon, Jun 7, 4:39 PM
dgibson committed R1:af575b062831: Fixes for dagster-mysql local runs (authored by dgibson).
Fixes for dagster-mysql local runs
Mon, Jun 7, 4:39 PM
dgibson requested review of D8268: Fixes for dagster-mysql local runs.
Mon, Jun 7, 4:32 PM
dgibson accepted D8251: K8s executor use pipeline origin image.

want to grab the one in celery_k8s_job_executor too? I think it's similarly not needed

Mon, Jun 7, 3:20 PM
dgibson accepted D8252: k8s executor user defined config.
Mon, Jun 7, 3:17 PM
dgibson accepted D8263: [dagit] Restore schema.graphql to repo.
Mon, Jun 7, 2:54 PM

Fri, Jun 4

dgibson added a reviewer for D8225: Move solid error boundary closer to user code invocation to clean up stack traces: alangenfeld.
Fri, Jun 4, 7:25 PM
dgibson accepted D8208: [serdes] improve errors.
Fri, Jun 4, 7:24 PM
dgibson added inline comments to D8144: Remove inclusive parameter when generating schedule partition ranges.
Fri, Jun 4, 6:57 PM
dgibson accepted D8244: [dagit] Stop diffing schema.graphql during build.

Makes sense to me - there's an internal version coming too i assume

Fri, Jun 4, 3:17 PM
dgibson accepted D8197: K8s executor docs.
Fri, Jun 4, 3:15 PM
dgibson abandoned D8227: Don't call DagsterInstance.get() in create_daemon_of_type.

I like that idea

Fri, Jun 4, 1:45 PM

Thu, Jun 3

dgibson requested changes to D8226: fix: create daemons without using reference to instance.

thanks for doing this! One small thing and we're good I think (let's merge create() with the constructor)

Thu, Jun 3, 7:37 PM
dgibson requested review of D8227: Don't call DagsterInstance.get() in create_daemon_of_type.
Thu, Jun 3, 6:29 PM
dgibson accepted D8218: Separate interval for check step health.

seems reasonable to me then

Thu, Jun 3, 6:18 PM
dgibson added a comment to D8218: Separate interval for check step health.

leaving open for a bit for the question for jordan

Thu, Jun 3, 4:27 PM
dgibson accepted D8219: [dagit] Do not disable Launch buttons.
Thu, Jun 3, 4:20 PM

Wed, Jun 2

dgibson closed D8192: Make TestScheduleStorage less finicky about tick IDs.
Wed, Jun 2, 5:03 PM
dgibson committed R1:1464a0632f59: Make TestScheduleStorage less finicky about tick IDs (authored by dgibson).
Make TestScheduleStorage less finicky about tick IDs
Wed, Jun 2, 5:03 PM
dgibson accepted D8200: correctly apply error boundary when handle_output is a generator.
Wed, Jun 2, 4:57 PM
dgibson requested changes to D8144: Remove inclusive parameter when generating schedule partition ranges.

sorry for the delay, this one took me a while to wrap my brain around.

Wed, Jun 2, 3:58 PM
dgibson added a reviewer for D8192: Make TestScheduleStorage less finicky about tick IDs: jordansanders.
Wed, Jun 2, 3:23 PM
dgibson accepted D8196: K8s executor logging.
Wed, Jun 2, 3:22 PM