Page MenuHomePhabricator

dgibson (Daniel Gibson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 6 2020, 12:49 PM (28 w, 6 d)

Recent Activity

Yesterday

dgibson abandoned D6119: [12/n] Reconstruct ExecutionPlan from the ExecutionPlanSnapshot when it is available.
Sun, Jan 24, 11:29 PM
dgibson abandoned D6095: [10/n]Make StepOutput user-code-free.

squashed into https://dagster.phacility.com/D6133

Sun, Jan 24, 11:28 PM
dgibson abandoned D6094: [9/n] Make StepInputSource use snapshots.

squashed into https://dagster.phacility.com/D6133

Sun, Jan 24, 11:28 PM
dgibson abandoned D6093: [8/n] Make StepInput.dagster_type a snapshot instead (no user code).

squashed into https://dagster.phacility.com/D6133

Sun, Jan 24, 11:28 PM
dgibson abandoned D6086: [5/n] Wait to determine step compute_fn until you're actually in step execution.

squashed into https://dagster.phacility.com/D6133

Sun, Jan 24, 11:28 PM
dgibson abandoned D6083: [3/n] Include pipeline snapshot and execution plan snapshot on system execution context.
Sun, Jan 24, 11:27 PM
dgibson abandoned D6088: [6and7/n] remove solid from ExecutionStep.

squashed into https://dagster.phacility.com/D6133

Sun, Jan 24, 11:27 PM
dgibson retitled D6133: Reconstruct ExecutionPlan from the ExecutionPlanSnapshot in the run worker if one exists from (Squashed) Reconstruct ExecutionPlan from the ExecutionPlanSnapshot to Reconstruct ExecutionPlan from the ExecutionPlanSnapshot in the run worker if one exists.
Sun, Jan 24, 11:26 PM
dgibson updated the diff for D6133: Reconstruct ExecutionPlan from the ExecutionPlanSnapshot in the run worker if one exists.

up

Sun, Jan 24, 11:21 PM
dgibson updated the diff for D6133: Reconstruct ExecutionPlan from the ExecutionPlanSnapshot in the run worker if one exists.

up

Sun, Jan 24, 11:07 PM
dgibson updated the diff for D6133: Reconstruct ExecutionPlan from the ExecutionPlanSnapshot in the run worker if one exists.

up

Sun, Jan 24, 9:27 PM
dgibson updated the diff for D6133: Reconstruct ExecutionPlan from the ExecutionPlanSnapshot in the run worker if one exists.

up

Sun, Jan 24, 8:13 PM
dgibson updated the diff for D6133: Reconstruct ExecutionPlan from the ExecutionPlanSnapshot in the run worker if one exists.

up

Sun, Jan 24, 8:04 PM
dgibson updated the diff for D6133: Reconstruct ExecutionPlan from the ExecutionPlanSnapshot in the run worker if one exists.

up

Sun, Jan 24, 7:03 PM
dgibson requested review of D6133: Reconstruct ExecutionPlan from the ExecutionPlanSnapshot in the run worker if one exists.
Sun, Jan 24, 4:56 AM

Sat, Jan 23

dgibson added a comment to D6131: Replace dagster api grpc with 'python -m dagster.grpc' in docs?.

"As initialized upon program startup, the first item of this list, path[0], is the directory containing the script that was used to invoke the Python interpreter. If the script directory is not available (e.g. if the interpreter is invoked interactively or if the script is read from standard input), path[0] is the empty string, which directs Python to search modules in the current directory first."

Sat, Jan 23, 7:22 PM
dgibson added a comment to D6131: Replace dagster api grpc with 'python -m dagster.grpc' in docs?.

possibly relevant:

Sat, Jan 23, 7:21 PM
dgibson closed D6081: Remove pipeline_def from top-level SystemExecutionContext, only use in step execution contexts.
Sat, Jan 23, 7:20 PM
dgibson committed R1:ac7dec89ecca: Remove pipeline_def from top-level SystemExecutionContext, only use in step… (authored by dgibson).
Remove pipeline_def from top-level SystemExecutionContext, only use in step…
Sat, Jan 23, 7:20 PM
dgibson published D6131: Replace dagster api grpc with 'python -m dagster.grpc' in docs? for review.
Sat, Jan 23, 7:17 PM
dgibson updated the diff for D6119: [12/n] Reconstruct ExecutionPlan from the ExecutionPlanSnapshot when it is available.

up

Sat, Jan 23, 6:21 PM
dgibson added inline comments to D6081: Remove pipeline_def from top-level SystemExecutionContext, only use in step execution contexts.
Sat, Jan 23, 6:19 PM
dgibson updated the diff for D6081: Remove pipeline_def from top-level SystemExecutionContext, only use in step execution contexts.

up

Sat, Jan 23, 6:17 PM
dgibson requested review of D6119: [12/n] Reconstruct ExecutionPlan from the ExecutionPlanSnapshot when it is available.
Sat, Jan 23, 4:42 PM
dgibson requested review of D6129: Skip event log watch tests on local mac runs.
Sat, Jan 23, 4:11 PM

Fri, Jan 22

dgibson accepted D6113: Repin ipykernel.
Fri, Jan 22, 7:37 PM
dgibson added a reviewer for D6095: [10/n]Make StepOutput user-code-free: alangenfeld.
Fri, Jan 22, 3:38 PM
dgibson added a reviewer for D6094: [9/n] Make StepInputSource use snapshots: alangenfeld.
Fri, Jan 22, 3:38 PM
dgibson added a reviewer for D6093: [8/n] Make StepInput.dagster_type a snapshot instead (no user code): alangenfeld.
Fri, Jan 22, 3:38 PM
dgibson added a reviewer for D6088: [6and7/n] remove solid from ExecutionStep: alangenfeld.
Fri, Jan 22, 3:38 PM
dgibson retitled D6088: [6and7/n] remove solid from ExecutionStep from remove solid from ExecutionStep to [6and7/n] remove solid from ExecutionStep.
Fri, Jan 22, 3:38 PM
dgibson retitled D6086: [5/n] Wait to determine step compute_fn until you're actually in step execution from Wait to determine step compute_fn until you're actually in step execution to [5/n] Wait to determine step compute_fn until you're actually in step execution.
Fri, Jan 22, 3:37 PM
dgibson retitled D6084: [4/n] Remove mode_def from SystemExecutionContext, replace with mode_name from Remove mode_def from SystemExecutionContext, replace with mode_name to [4/n] Remove mode_def from SystemExecutionContext, replace with mode_name.
Fri, Jan 22, 3:37 PM
dgibson retitled D6083: [3/n] Include pipeline snapshot and execution plan snapshot on system execution context from Include pipeline snapshot and execution plan snapshot on system execution context to [3/n] Include pipeline snapshot and execution plan snapshot on system execution context.
Fri, Jan 22, 3:36 PM
dgibson requested review of D6095: [10/n]Make StepOutput user-code-free.
Fri, Jan 22, 6:41 AM
dgibson requested review of D6094: [9/n] Make StepInputSource use snapshots.
Fri, Jan 22, 6:37 AM
dgibson requested review of D6093: [8/n] Make StepInput.dagster_type a snapshot instead (no user code).
Fri, Jan 22, 4:38 AM
dgibson requested review of D6102: yield a SkipReason when a partitioned schedule can't find its partition.
Fri, Jan 22, 4:34 AM
dgibson updated the diff for D6088: [6and7/n] remove solid from ExecutionStep.

up

Fri, Jan 22, 4:17 AM
dgibson retitled D6088: [6and7/n] remove solid from ExecutionStep from remove solid from ExecutionStep to [7/n] remove solid from ExecutionStep.
Fri, Jan 22, 4:17 AM

Thu, Jan 21

dgibson requested review of D6088: [6and7/n] remove solid from ExecutionStep.
Thu, Jan 21, 10:28 PM
dgibson requested review of D6086: [5/n] Wait to determine step compute_fn until you're actually in step execution.
Thu, Jan 21, 6:04 PM
dgibson requested review of D6084: [4/n] Remove mode_def from SystemExecutionContext, replace with mode_name.
Thu, Jan 21, 5:57 PM
dgibson requested review of D6083: [3/n] Include pipeline snapshot and execution plan snapshot on system execution context.
Thu, Jan 21, 5:19 PM
dgibson requested review of D6081: Remove pipeline_def from top-level SystemExecutionContext, only use in step execution contexts.
Thu, Jan 21, 5:17 PM

Wed, Jan 20

dgibson closed D6057: Fix daemons not working in repo locations with more than one repo..
Wed, Jan 20, 5:35 PM
dgibson committed R1:0b046d20d7fb: Fix daemons not working in repo locations with more than one repo. (authored by dgibson).
Fix daemons not working in repo locations with more than one repo.
Wed, Jan 20, 5:34 PM
dgibson requested review of D6057: Fix daemons not working in repo locations with more than one repo..
Wed, Jan 20, 5:11 PM
dgibson requested changes to D6010: Run queuing enabled endpoint.

looks good, add test?

Wed, Jan 20, 4:56 PM
dgibson accepted D6041: improve sensor CLI error messages.
Wed, Jan 20, 4:52 PM
dgibson closed D6056: add error message when you start the daemon with no instance set..
Wed, Jan 20, 3:14 PM
dgibson committed R1:83d28e88fab7: add error message when you start the daemon with no instance set. (authored by dgibson).
add error message when you start the daemon with no instance set.
Wed, Jan 20, 3:14 PM
dgibson requested review of D6056: add error message when you start the daemon with no instance set..
Wed, Jan 20, 4:20 AM
dgibson closed D6040: Unpin alembic.
Wed, Jan 20, 1:34 AM
dgibson committed R1:0a595bedd599: Unpin alembic (authored by dgibson).
Unpin alembic
Wed, Jan 20, 1:33 AM
dgibson updated the diff for D6040: Unpin alembic.

up

Wed, Jan 20, 1:05 AM

Tue, Jan 19

dgibson updated the summary of D6040: Unpin alembic.
Tue, Jan 19, 9:32 PM
dgibson requested review of D6040: Unpin alembic.
Tue, Jan 19, 9:32 PM
dgibson closed D6038: Add sensor_cli to api docs.
Tue, Jan 19, 4:19 PM
dgibson committed R1:469c90c3576f: Add sensor_cli to api docs (authored by dgibson).
Add sensor_cli to api docs
Tue, Jan 19, 4:19 PM
dgibson requested review of D6038: Add sensor_cli to api docs.
Tue, Jan 19, 4:04 PM

Fri, Jan 15

dgibson closed D6028: Add retries to check in dagster=postgres init that checks table names.
Fri, Jan 15, 5:01 PM
dgibson committed R1:af02cdb364dc: Add retries to check in dagster=postgres init that checks table names (authored by dgibson).
Add retries to check in dagster=postgres init that checks table names
Fri, Jan 15, 5:01 PM
dgibson closed D6027: Fix deploy_docker example.
Fri, Jan 15, 4:47 PM
dgibson committed R1:9dc85f6481c9: Fix deploy_docker example (authored by dgibson).
Fix deploy_docker example
Fri, Jan 15, 4:47 PM
dgibson requested review of D6028: Add retries to check in dagster=postgres init that checks table names.
Fri, Jan 15, 4:10 PM
dgibson requested review of D6027: Fix deploy_docker example.
Fri, Jan 15, 3:59 PM
dgibson accepted D6022: pin chardet, to resolve dep conflict with aiohttp<=3.7.3.
Fri, Jan 15, 12:38 AM

Thu, Jan 14

dgibson closed D6015: Don't over-promise about daemon latency in the k8s docs.
Thu, Jan 14, 10:04 PM
dgibson committed R1:23b475873c91: Don't over-promise about daemon latency in the k8s docs (authored by dgibson).
Don't over-promise about daemon latency in the k8s docs
Thu, Jan 14, 10:04 PM
dgibson updated the diff for D6015: Don't over-promise about daemon latency in the k8s docs.

one more

Thu, Jan 14, 9:59 PM
dgibson updated the diff for D6015: Don't over-promise about daemon latency in the k8s docs.

regularly => periodically

Thu, Jan 14, 9:55 PM
dgibson published D6015: Don't over-promise about daemon latency in the k8s docs for review.
Thu, Jan 14, 9:54 PM
dgibson accepted D6012: Fix wording for scheduler in Helm values.
Thu, Jan 14, 9:22 PM
dgibson closed D6006: update link in RELEASING.md.
Thu, Jan 14, 9:01 PM
dgibson committed R1:9df1cec2abbe: update link in RELEASING.md (authored by dgibson).
update link in RELEASING.md
Thu, Jan 14, 9:01 PM
dgibson updated the diff for D6006: update link in RELEASING.md.

fair point

Thu, Jan 14, 8:40 PM
dgibson requested review of D6006: update link in RELEASING.md.
Thu, Jan 14, 8:21 PM
dgibson closed D6004: Tweak daemon docs.
Thu, Jan 14, 8:02 PM
dgibson committed R1:3952737e327a: Tweak daemon docs (authored by dgibson).
Tweak daemon docs
Thu, Jan 14, 8:02 PM
dgibson updated the diff for D6004: Tweak daemon docs.

up

Thu, Jan 14, 7:59 PM
dgibson updated the diff for D6004: Tweak daemon docs.

up

Thu, Jan 14, 7:55 PM
dgibson updated the diff for D6004: Tweak daemon docs.

typo

Thu, Jan 14, 7:48 PM
dgibson accepted D6003: [docs] dynamic graphs.
Thu, Jan 14, 7:46 PM
dgibson published D6004: Tweak daemon docs for review.
Thu, Jan 14, 7:45 PM
dgibson accepted D6003: [docs] dynamic graphs.
Thu, Jan 14, 7:28 PM
dgibson accepted D6001: Fix create date for migration script.
Thu, Jan 14, 6:46 PM
dgibson closed D5993: Make instance migration error clearer.
Thu, Jan 14, 4:42 PM
dgibson committed R1:b229d3dfffdb: Make instance migration error clearer (authored by dgibson).
Make instance migration error clearer
Thu, Jan 14, 4:42 PM
dgibson accepted D5996: only connect on init when needed.

good catch

Thu, Jan 14, 4:23 PM
dgibson accepted D5991: make sure integrity error is caught within a connection contextmanager.
Thu, Jan 14, 4:20 PM
dgibson published D5991: make sure integrity error is caught within a connection contextmanager for review.
Thu, Jan 14, 4:20 PM
dgibson updated the diff for D5993: Make instance migration error clearer.

up

Thu, Jan 14, 3:40 PM
dgibson closed D5994: pass on run coordinator/queueing copy.
Thu, Jan 14, 3:25 PM
dgibson committed R1:2c32217023ae: pass on run coordinator/queueing copy (authored by dgibson).
pass on run coordinator/queueing copy
Thu, Jan 14, 3:25 PM
dgibson closed D5982: Don't always run create_all during storage creation, add stamps to postgres storage.
Thu, Jan 14, 3:22 PM
dgibson committed R1:0b06d69e093c: Don't always run create_all during storage creation, add stamps to postgres… (authored by dgibson).
Don't always run create_all during storage creation, add stamps to postgres…
Thu, Jan 14, 3:22 PM
dgibson accepted D5995: Disable gRPC watch threads for 0.10.0.

accepting assuming that any tests that fail due to this are also disabled

Thu, Jan 14, 3:15 PM
dgibson published D5995: Disable gRPC watch threads for 0.10.0 for review.
Thu, Jan 14, 3:15 PM
dgibson updated the diff for D5993: Make instance migration error clearer.

up

Thu, Jan 14, 3:11 PM