Page MenuHomePhabricator

dgibson (Daniel Gibson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 6 2020, 12:49 PM (15 w, 1 d)

Recent Activity

Today

dgibson updated the diff for D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.

rebase

Tue, Oct 20, 4:52 PM
dgibson closed D4823: Ensure that origins don't change when we switch from cli api repos to grpc repos.
Tue, Oct 20, 4:07 PM
dgibson committed R1:6d3e9aaac0af: Ensure that origins don't change when we switch from cli api repos to grpc repos (authored by dgibson).
Ensure that origins don't change when we switch from cli api repos to grpc repos
Tue, Oct 20, 4:07 PM
dgibson added inline comments to D4823: Ensure that origins don't change when we switch from cli api repos to grpc repos.
Tue, Oct 20, 4:07 PM
dgibson added a comment to D4821: RFC: [dagit] Start adding Workspace routes.

Overall this makes sense to me!

Tue, Oct 20, 4:04 PM
dgibson requested review of D4827: Append "_location" to default repository location name.
Tue, Oct 20, 3:49 PM
dgibson added a reviewer for D4823: Ensure that origins don't change when we switch from cli api repos to grpc repos: sashank.
Tue, Oct 20, 2:49 PM
dgibson requested review of D4817: Remove executePlan dagster-graphql call.
Tue, Oct 20, 1:39 AM
dgibson requested review of D4824: Remove legacy repo format from loading path.
Tue, Oct 20, 1:36 AM
dgibson added a reviewer for D4813: Maintain backcompat in date_partition_range: prha.
Tue, Oct 20, 1:18 AM
dgibson updated the diff for D4742: Remove legacy repo format from examples/tests, replace the default with the new standard format except when specifically testing legacy stuff.

remove the breaking part, just update teh examples and tests for now

Tue, Oct 20, 1:14 AM
dgibson added a reviewer for D4805: Don't rebuild the docker image every time you run a kind test locally: alangenfeld.
Tue, Oct 20, 1:03 AM
dgibson abandoned D4799: test termination in BK.
Tue, Oct 20, 1:02 AM
dgibson requested review of D4823: Ensure that origins don't change when we switch from cli api repos to grpc repos.
Tue, Oct 20, 12:55 AM
dgibson updated the diff for D4814: rm DagsterKubernetesPodOperator and test infra around it.

up

Tue, Oct 20, 12:35 AM

Yesterday

dgibson updated the diff for D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.

up

Mon, Oct 19, 9:16 PM
dgibson requested review of D4814: rm DagsterKubernetesPodOperator and test infra around it.

test failures are transient/unrelated

Mon, Oct 19, 8:43 PM
dgibson requested review of D4813: Maintain backcompat in date_partition_range.
Mon, Oct 19, 7:59 PM
dgibson updated the diff for D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.

up

Mon, Oct 19, 7:46 PM
dgibson closed D4769: Use execute_step_with_structured_logs in DagsterDockerOperator.
Mon, Oct 19, 7:40 PM
dgibson committed R1:febffd667ebb: Use execute_step_with_structured_logs in DagsterDockerOperator (authored by dgibson).
Use execute_step_with_structured_logs in DagsterDockerOperator
Mon, Oct 19, 7:40 PM
dgibson planned changes to D4788: RFC: Add partitions to arbitrary cron-based schedules.
Mon, Oct 19, 1:21 PM

Sat, Oct 17

dgibson closed D4804: Fix helm namespace lifecycle in tests.
Sat, Oct 17, 12:14 AM
dgibson committed R1:82f9303658f5: Fix helm namespace lifecycle in tests (authored by dgibson).
Fix helm namespace lifecycle in tests
Sat, Oct 17, 12:14 AM

Fri, Oct 16

dgibson requested review of D4805: Don't rebuild the docker image every time you run a kind test locally.
Fri, Oct 16, 9:05 PM
dgibson requested review of D4804: Fix helm namespace lifecycle in tests.
Fri, Oct 16, 9:02 PM
dgibson closed D4801: [easy] Fix missing param change in date_partition_range call.
Fri, Oct 16, 4:07 PM
dgibson committed R1:69cb751f7166: [easy] Fix missing param change in date_partition_range call (authored by dgibson).
[easy] Fix missing param change in date_partition_range call
Fri, Oct 16, 4:06 PM
dgibson abandoned D4538: Write non-error execution logs to stdout instead of stderr, only surface stderr from child processes in host processes like the scheduler.

I'm going to hold off on this for now, will keep it in the back pocket though

Fri, Oct 16, 3:06 PM
dgibson published D4801: [easy] Fix missing param change in date_partition_range call for review.
Fri, Oct 16, 2:55 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:48 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:48 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:48 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:47 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:47 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:47 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:47 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:46 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:46 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:46 PM
dgibson closed D4725: Add execution_timezone field to schedules.
Fri, Oct 16, 2:31 PM
dgibson committed R1:fe88d204fa88: Add execution_timezone field to schedules (authored by dgibson).
Add execution_timezone field to schedules
Fri, Oct 16, 2:31 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:29 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:29 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:29 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:29 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:28 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:28 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:28 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:27 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:27 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:27 PM
dgibson closed D4723: Get cron schedule from ExternalSchedule rather than the Schedule DB.
Fri, Oct 16, 2:13 PM
dgibson closed D4671: Make scheduler timezone-aware.
Fri, Oct 16, 2:13 PM
dgibson committed R1:c52d2d09c3a3: Get cron schedule from ExternalSchedule rather than the Schedule DB (authored by dgibson).
Get cron schedule from ExternalSchedule rather than the Schedule DB
Fri, Oct 16, 2:13 PM
dgibson committed R1:fb652b6a321f: Make scheduler timezone-aware (authored by dgibson).
Make scheduler timezone-aware
Fri, Oct 16, 2:13 PM
dgibson updated the diff for D4799: test termination in BK.

trial2

Fri, Oct 16, 2:11 PM
dgibson updated the diff for D4799: test termination in BK.

trial2

Fri, Oct 16, 2:11 PM
dgibson updated the diff for D4799: test termination in BK.

trial2

Fri, Oct 16, 2:10 PM
dgibson updated the diff for D4799: test termination in BK.

trial2

Fri, Oct 16, 2:10 PM
dgibson updated the diff for D4799: test termination in BK.

trial2

Fri, Oct 16, 2:10 PM
dgibson updated the diff for D4799: test termination in BK.

trial2

Fri, Oct 16, 2:09 PM
dgibson updated the diff for D4799: test termination in BK.

trial2

Fri, Oct 16, 2:09 PM
dgibson updated the diff for D4799: test termination in BK.

trial2

Fri, Oct 16, 2:09 PM
dgibson updated the diff for D4799: test termination in BK.

trial2

Fri, Oct 16, 2:08 PM
dgibson updated the diff for D4799: test termination in BK.

trial2

Fri, Oct 16, 2:08 PM
dgibson updated the diff for D4725: Add execution_timezone field to schedules.

up

Fri, Oct 16, 2:07 PM
dgibson updated the diff for D4799: test termination in BK.

trial

Fri, Oct 16, 1:57 PM
dgibson updated the diff for D4799: test termination in BK.

trial

Fri, Oct 16, 1:57 PM
dgibson updated the diff for D4799: test termination in BK.

trial

Fri, Oct 16, 1:57 PM
dgibson updated the diff for D4799: test termination in BK.

trial

Fri, Oct 16, 1:56 PM
dgibson updated the diff for D4799: test termination in BK.

trial

Fri, Oct 16, 1:56 PM
dgibson updated the diff for D4799: test termination in BK.

trial

Fri, Oct 16, 1:56 PM
dgibson updated the diff for D4799: test termination in BK.

trial

Fri, Oct 16, 1:55 PM
dgibson updated the diff for D4799: test termination in BK.

trial

Fri, Oct 16, 1:55 PM
dgibson updated the diff for D4799: test termination in BK.

trial

Fri, Oct 16, 1:55 PM
dgibson updated the diff for D4799: test termination in BK.

trial

Fri, Oct 16, 1:55 PM
dgibson requested review of D4799: test termination in BK.
Fri, Oct 16, 1:54 PM
dgibson updated the diff for D4671: Make scheduler timezone-aware.

up

Fri, Oct 16, 1:52 PM
dgibson updated the diff for D4787: Require that start_date be on a month/day boundary for monthly/daily schedules.

up

Fri, Oct 16, 1:21 PM
dgibson updated the diff for D4725: Add execution_timezone field to schedules.

up

Fri, Oct 16, 1:20 PM
dgibson updated the diff for D4723: Get cron schedule from ExternalSchedule rather than the Schedule DB.

up

Fri, Oct 16, 1:17 PM
dgibson updated the diff for D4671: Make scheduler timezone-aware.

up

Fri, Oct 16, 1:17 PM
dgibson abandoned D4792: JUST BK FOR DAGSTER AIRFLOW DIFF.
Fri, Oct 16, 1:14 PM
dgibson updated the diff for D4769: Use execute_step_with_structured_logs in DagsterDockerOperator.

up

Fri, Oct 16, 1:14 PM
dgibson abandoned D4798: test for multiple trials with BK.
Fri, Oct 16, 1:14 PM
dgibson abandoned D4796: Fix dagster_celery_docker.

rolling this into https://dagster.phacility.com/D4769

Fri, Oct 16, 1:13 PM
dgibson requested review of D4798: test for multiple trials with BK.
Fri, Oct 16, 4:04 AM
dgibson updated the diff for D4769: Use execute_step_with_structured_logs in DagsterDockerOperator.

.

Fri, Oct 16, 3:34 AM
dgibson updated the diff for D4796: Fix dagster_celery_docker.

now it is passing, check for flakiness?

Fri, Oct 16, 2:55 AM
dgibson updated the diff for D4796: Fix dagster_celery_docker.

up

Fri, Oct 16, 2:38 AM
dgibson requested review of D4796: Fix dagster_celery_docker.

halp

Fri, Oct 16, 2:23 AM
dgibson requested review of D4769: Use execute_step_with_structured_logs in DagsterDockerOperator.
Fri, Oct 16, 12:26 AM

Thu, Oct 15

dgibson requested review of D4792: JUST BK FOR DAGSTER AIRFLOW DIFF.
Thu, Oct 15, 9:26 PM
dgibson requested review of D4787: Require that start_date be on a month/day boundary for monthly/daily schedules.
Thu, Oct 15, 7:32 PM
dgibson added a comment to D4788: RFC: Add partitions to arbitrary cron-based schedules.

yeah, that would be a good future change I think. A missing piece is that we would need to be able to efficiently figure out the next partition without loading them all I think? Since you could have an hourly schedule that spans hundreds of days, for example.

Thu, Oct 15, 7:08 PM
dgibson updated the diff for D4723: Get cron schedule from ExternalSchedule rather than the Schedule DB.

up

Thu, Oct 15, 7:04 PM
dgibson updated the diff for D4671: Make scheduler timezone-aware.

up

Thu, Oct 15, 7:03 PM
dgibson published D4788: RFC: Add partitions to arbitrary cron-based schedules for review.
Thu, Oct 15, 3:52 PM
dgibson closed D4752: Add postgres DB container to celery docker test, fix api call escaping.
Thu, Oct 15, 2:07 PM