Page MenuHomeElementl

dgibson (Daniel Gibson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 6 2020, 12:49 PM (41 w, 2 h)

Recent Activity

Today

dgibson accepted D7395: Provide more detailed SkipReasons.
Mon, Apr 19, 2:05 PM
dgibson added reviewers for D7494: Refactor how we handle exceptions in daemons: prha, johann, alangenfeld.
Mon, Apr 19, 1:38 PM
dgibson added reviewers for D7495: Fix termination in docker deploy example: alangenfeld, johann.
Mon, Apr 19, 1:37 PM
dgibson updated the diff for D7494: Refactor how we handle exceptions in daemons.

up

Mon, Apr 19, 3:48 AM
dgibson updated the diff for D7495: Fix termination in docker deploy example.

up

Mon, Apr 19, 2:59 AM
dgibson updated the diff for D7495: Fix termination in docker deploy example.

up

Mon, Apr 19, 2:58 AM

Sat, Apr 17

dgibson requested review of D7495: Fix termination in docker deploy example.
Sat, Apr 17, 3:52 PM
dgibson updated the diff for D7494: Refactor how we handle exceptions in daemons.

up

Sat, Apr 17, 2:42 AM
dgibson requested review of D7494: Refactor how we handle exceptions in daemons.
Sat, Apr 17, 2:40 AM
dgibson closed D7479: Add a default gRPC timeout to better handle slow/hanging sensors in the daemon.
Sat, Apr 17, 1:01 AM
dgibson committed R1:58be49bd59f5: Add a default gRPC timeout to better handle slow/hanging sensors in the daemon (authored by dgibson).
Add a default gRPC timeout to better handle slow/hanging sensors in the daemon
Sat, Apr 17, 1:01 AM
dgibson closed D7491: include stack trace in repo failure.
Sat, Apr 17, 12:59 AM
dgibson committed R1:23dbfe0051c0: include stack trace in repo failure (authored by dgibson).
include stack trace in repo failure
Sat, Apr 17, 12:59 AM

Fri, Apr 16

dgibson accepted D7482: Don't pass a dir to our TemporaryDirectory.
Fri, Apr 16, 5:36 PM
dgibson requested review of D7479: Add a default gRPC timeout to better handle slow/hanging sensors in the daemon.
Fri, Apr 16, 4:55 PM
dgibson closed D7477: Fix issue with error handling in ProcessGrpcServerRegistry.
Fri, Apr 16, 3:31 PM
dgibson committed R1:1beeea2e0446: Fix issue with error handling in ProcessGrpcServerRegistry (authored by dgibson).
Fix issue with error handling in ProcessGrpcServerRegistry
Fri, Apr 16, 3:31 PM
dgibson added a comment to D7477: Fix issue with error handling in ProcessGrpcServerRegistry.

I'd like to try to cherry pick this if reviewers have a sec (since the blamerev is going out in the release)

Fri, Apr 16, 3:18 PM
dgibson added a reviewer for D7477: Fix issue with error handling in ProcessGrpcServerRegistry: prha.
Fri, Apr 16, 3:07 PM
dgibson added a reviewer for D7477: Fix issue with error handling in ProcessGrpcServerRegistry: alangenfeld.
Fri, Apr 16, 3:06 PM
dgibson added reviewers for D7477: Fix issue with error handling in ProcessGrpcServerRegistry: sashank, johann, max.
Fri, Apr 16, 2:46 PM
dgibson requested review of D7477: Fix issue with error handling in ProcessGrpcServerRegistry.
Fri, Apr 16, 4:42 AM

Thu, Apr 15

dgibson accepted D7472: Changelog for 0.11.5.
Thu, Apr 15, 10:24 PM
dgibson closed D7458: Add some overridable methods to ProcessGrpcServerRegistry to make it extendable to support different origin types.
Thu, Apr 15, 9:58 PM
dgibson committed R1:8a7068dcd634: Add some overridable methods to ProcessGrpcServerRegistry to make it extendable… (authored by dgibson).
Add some overridable methods to ProcessGrpcServerRegistry to make it extendable…
Thu, Apr 15, 9:58 PM
dgibson requested review of D7458: Add some overridable methods to ProcessGrpcServerRegistry to make it extendable to support different origin types.
Thu, Apr 15, 4:48 PM
dgibson requested changes to D7395: Provide more detailed SkipReasons.

sorry for all the back and forth here, just looking to get the copy super clear since the early check is a common source of user confusion in #general

Thu, Apr 15, 3:14 PM
dgibson accepted D7452: Remove pyrsistent.
Thu, Apr 15, 2:32 PM
dgibson accepted D7448: Move upload_logs to dagit.
Thu, Apr 15, 1:23 PM

Wed, Apr 14

dgibson abandoned D7123: Don't throw when two simultaneous alembic stamps result in a unique key violation.
Wed, Apr 14, 9:55 PM
dgibson requested changes to D7395: Provide more detailed SkipReasons.
Wed, Apr 14, 6:41 PM

Tue, Apr 13

dgibson requested changes to D7395: Provide more detailed SkipReasons.

this generally makes a ton of sense to me, I just had some more time to think about the exact copy to use for maximum clarify, left some thoughts inline.
@prha may have thoughts here too.

Tue, Apr 13, 3:41 PM
dgibson accepted D7401: correctly update runs with utc timestamps.
Tue, Apr 13, 3:09 PM
dgibson closed D7398: Change today_at_midnight default timezone to UTC.
Tue, Apr 13, 2:46 PM
dgibson committed R1:a214cf57df0b: Change today_at_midnight default timezone to UTC (authored by dgibson).
Change today_at_midnight default timezone to UTC
Tue, Apr 13, 2:46 PM

Mon, Apr 12

dgibson updated the diff for D7398: Change today_at_midnight default timezone to UTC.

up

Mon, Apr 12, 10:56 PM
dgibson published D7398: Change today_at_midnight default timezone to UTC for review.
Mon, Apr 12, 10:31 PM
dgibson abandoned D6909: Set entrypoint to empty when launching runs or steps iwth a custom command.
Mon, Apr 12, 10:23 PM
dgibson closed D7387: Quick pass on deploying to airflow docs.
Mon, Apr 12, 9:46 PM
dgibson committed R1:54bcad0f3189: Quick pass on deploying to airflow docs (authored by dgibson).
Quick pass on deploying to airflow docs
Mon, Apr 12, 9:46 PM
dgibson updated the diff for D7387: Quick pass on deploying to airflow docs.

rebase

Mon, Apr 12, 4:04 PM
dgibson accepted D7388: pin jupyter-client.
Mon, Apr 12, 3:57 PM
dgibson published D7388: pin jupyter-client for review.
Mon, Apr 12, 3:57 PM
dgibson published D7387: Quick pass on deploying to airflow docs for review.
Mon, Apr 12, 3:45 PM

Sat, Apr 10

dgibson accepted D7385: Unpin pandas.
Sat, Apr 10, 6:14 PM

Fri, Apr 9

dgibson closed D7327: Move run worker host mode code to its own module.
Fri, Apr 9, 3:07 PM
dgibson committed R1:a57196c29d87: Move run worker host mode code to its own module (authored by dgibson).
Move run worker host mode code to its own module
Fri, Apr 9, 3:07 PM
dgibson closed D7317: Incorporate run config into choosing the executor in host mode run worker flow.
Fri, Apr 9, 3:07 PM
dgibson committed R1:07369c5f5222: Incorporate run config into choosing the executor in host mode run worker flow (authored by dgibson).
Incorporate run config into choosing the executor in host mode run worker flow
Fri, Apr 9, 3:07 PM
dgibson closed D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker.
Fri, Apr 9, 3:07 PM
dgibson committed R1:1980c16c9edd: Move user-code-dependent executor validation to execution plan generation… (authored by dgibson).
Move user-code-dependent executor validation to execution plan generation…
Fri, Apr 9, 3:07 PM
dgibson updated the diff for D7327: Move run worker host mode code to its own module.

up

Fri, Apr 9, 2:57 PM
dgibson updated the diff for D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker.

up

Fri, Apr 9, 2:56 PM
dgibson requested changes to D7366: Add MayHaveInstanceWeakref mixin to GrpcServerRegistry.

This might be better suited for the specific subclass you’re working with that’s already associated with an instance?

Fri, Apr 9, 11:43 AM

Thu, Apr 8

dgibson accepted D7358: [dagit] Remove extra slash on app.py string replace.

should some test have broken that this would fix?

Thu, Apr 8, 8:50 PM
dgibson updated the diff for D7327: Move run worker host mode code to its own module.

up

Thu, Apr 8, 12:41 AM
dgibson updated the diff for D7317: Incorporate run config into choosing the executor in host mode run worker flow.

upx

Thu, Apr 8, 12:41 AM
dgibson updated the diff for D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker.

up

Thu, Apr 8, 12:40 AM

Wed, Apr 7

dgibson updated the diff for D7327: Move run worker host mode code to its own module.

up

Wed, Apr 7, 10:21 PM
dgibson updated the diff for D7317: Incorporate run config into choosing the executor in host mode run worker flow.

up

Wed, Apr 7, 10:16 PM
dgibson updated the diff for D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker.

ExecutorProcessSetting => List[ExecutorRequirement]

Wed, Apr 7, 10:12 PM
dgibson closed D7346: Fix integration tests.
Wed, Apr 7, 9:04 PM
dgibson committed R1:e44620f99da7: Fix integration tests (authored by dgibson).
Fix integration tests
Wed, Apr 7, 9:04 PM
dgibson requested review of D7346: Fix integration tests.
Wed, Apr 7, 9:00 PM
dgibson closed D7332: Add property to storage tables to turn auto-create behavior on and off.
Wed, Apr 7, 7:34 PM
dgibson committed R1:51b0fd6953d3: Add property to storage tables to turn auto-create behavior on and off (authored by dgibson).
Add property to storage tables to turn auto-create behavior on and off
Wed, Apr 7, 7:34 PM
dgibson updated the diff for D7332: Add property to storage tables to turn auto-create behavior on and off.

rename param

Wed, Apr 7, 7:17 PM
dgibson added a comment to D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker.

@alex you have accepted the two follow-on diffs to this but the base of the stack remains :) ExecutorProcessSetting giving you pause?

Wed, Apr 7, 7:13 PM
dgibson updated the diff for D7332: Add property to storage tables to turn auto-create behavior on and off.

up

Wed, Apr 7, 3:07 PM
dgibson requested review of D7327: Move run worker host mode code to its own module.

flake test failure

Wed, Apr 7, 3:06 PM
dgibson updated the diff for D7332: Add property to storage tables to turn auto-create behavior on and off.

add test

Wed, Apr 7, 3:06 PM
dgibson added reviewers for D7332: Add property to storage tables to turn auto-create behavior on and off: max, johann, alangenfeld, prha.
Wed, Apr 7, 2:21 PM
dgibson requested review of D7332: Add property to storage tables to turn auto-create behavior on and off.
Wed, Apr 7, 1:35 AM
dgibson abandoned D7328: RFC: Allow storages to specify a custom sqlalchemy metadata class.

no need for a single metadata

Wed, Apr 7, 12:40 AM

Tue, Apr 6

dgibson planned changes to D7328: RFC: Allow storages to specify a custom sqlalchemy metadata class.
Tue, Apr 6, 11:20 PM
dgibson published D7328: RFC: Allow storages to specify a custom sqlalchemy metadata class for review.
Tue, Apr 6, 9:54 PM
dgibson updated the diff for D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker.

up

Tue, Apr 6, 8:47 PM
dgibson closed D7319: Make more dagster grpc server parameters controllable via env var.
Tue, Apr 6, 8:44 PM
dgibson committed R1:09a4531c2be2: Make more dagster grpc server parameters controllable via env var (authored by dgibson).
Make more dagster grpc server parameters controllable via env var
Tue, Apr 6, 8:44 PM
dgibson updated the diff for D7319: Make more dagster grpc server parameters controllable via env var.

use env vars

Tue, Apr 6, 8:06 PM
dgibson requested review of D7319: Make more dagster grpc server parameters controllable via env var.
Tue, Apr 6, 3:57 PM
dgibson requested review of D7317: Incorporate run config into choosing the executor in host mode run worker flow.
Tue, Apr 6, 2:21 PM
dgibson updated the diff for D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker.

up

Tue, Apr 6, 2:00 PM
dgibson accepted D6017: initial async solids support.

sorry for sitting on this forever.

Tue, Apr 6, 1:57 PM
dgibson closed D7285: Fixes for errors when a daemon thread goes down.
Tue, Apr 6, 1:50 PM
dgibson committed R1:93032442ddd6: Fixes for errors when a daemon thread goes down (authored by dgibson).
Fixes for errors when a daemon thread goes down
Tue, Apr 6, 1:50 PM
dgibson closed D7294: Don't rely on COMPOSE_PROJECT_IMAGE to set the pipeline code image in the docker example.
Tue, Apr 6, 1:42 PM
dgibson committed R1:9a34a487e6c3: Don't rely on COMPOSE_PROJECT_IMAGE to set the pipeline code image in the… (authored by dgibson).
Don't rely on COMPOSE_PROJECT_IMAGE to set the pipeline code image in the…
Tue, Apr 6, 1:42 PM
dgibson accepted D7292: Add docker image run tag in k8s launchers.

nice

Tue, Apr 6, 1:40 PM
dgibson closed D7295: raise exceptions from grpc methods.
Tue, Apr 6, 1:34 PM
dgibson committed R1:cc70da07a7f3: raise exceptions from grpc methods (authored by dgibson).
raise exceptions from grpc methods
Tue, Apr 6, 1:34 PM
dgibson updated the diff for D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker.

up

Tue, Apr 6, 2:03 AM
dgibson updated the diff for D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker.

enum on the ExecutorDefinition

Tue, Apr 6, 1:47 AM
dgibson accepted D7289: [dynamic] fix multiple collects on one step.
Tue, Apr 6, 12:47 AM

Mon, Apr 5

dgibson published D7300: Move user-code-dependent executor validation to execution plan generation, rather than the run worker for review.

probably 80% of this diff is passing DagsterInstances around so that we can access it during plan creation to validate the executor, I could split that part out into a separate diff if that would make it easier to review

Mon, Apr 5, 9:39 PM
dgibson added reviewers for D7295: raise exceptions from grpc methods: sashank, prha, alangenfeld.
Mon, Apr 5, 2:09 PM
dgibson added reviewers for D7294: Don't rely on COMPOSE_PROJECT_IMAGE to set the pipeline code image in the docker example: alangenfeld, prha, sashank, johann.
Mon, Apr 5, 2:08 PM

Sun, Apr 4

dgibson requested review of D7295: raise exceptions from grpc methods.
Sun, Apr 4, 4:53 AM

Sat, Apr 3

dgibson requested review of D7294: Don't rely on COMPOSE_PROJECT_IMAGE to set the pipeline code image in the docker example.
Sat, Apr 3, 9:43 PM

Fri, Apr 2

dgibson abandoned D6760: RFC: Move handle refresh time management code from individual daemons into RepositoryLocationHandleManager.
Fri, Apr 2, 9:56 PM