- User Since
- Jul 20 2020, 3:42 PM (18 w, 5 d)
Wed, Nov 25
build completed successfully, not sure why the hook didn't publish.
Tue, Nov 24
Mon, Nov 23
Fri, Nov 20
Fixed nits. Re-added VersionedAssetStore abstract class so that users are not forced to implement has_asset method
Thu, Nov 19
Rebased on top of Versioned Asset Store changes
Removed VersionedAssetStore abstract class, and instead added a has_asset method to the base assetstore class.
Rebased on top of AssetStoreContext changes
LGTM! I think these changes are gonna enable the versioning workstreams in a big way.
LGTM! Fwiw @sandyryza I think exposing the construct method makes sense, if at least for the testing case that we talked about before.
Wed, Nov 18
to your queue
Fixed set_asset call
Migrated to using asset store context
fixed messaging on filesystem_versioned_asset_store
Tue, Nov 17
Addressed comments. Moved version resolution logic off of the execution plan. passed mode as a param of environment config instead of mode_definition to execution plan. Got rid of outdated documentation. Assert -> check invariant.
Fri, Nov 13
Fixed lint issue
Use topological steps
Thu, Nov 12
Placed computed fxn to compute step output versions on execution plan using information already provided in step builder
Tue, Nov 10
Wed, Nov 4
Mon, Nov 2
Fri, Oct 30
Added additional failure mode tests. When non-str key provided, no type loader is set.
Oct 29 2020
Added test for when inner type without loader is used
Oct 22 2020
Thanks so much for fixing these up.
Oct 20 2020
Oct 13 2020
Oct 12 2020
docs make black
Added issue tracking
Looks good. Thanks for catching!
Oct 9 2020
Awesome stuff - just want to make sure I understand the breaking correctly here: A call such as Output("value", address="some_address") is no longer permitted?
Changed print_versions -> list_versions. Consolidated config option. Made list_versions logic more concise.
Oct 8 2020
Oct 7 2020
I'm not too familiar with ObjectStoreOperation's fxnality / how this ultimately ties back to the addressing stuff. Deferring to @yuhan here.
Got rid of some really questionable control flow.
I must have missed this one with my fix. Thanks so much for catching it! LGTM
Got rid of test_build_memoized_plan, was subsumed by other tests.
Fixed lint errors
Fixed issue with step execution that was preventing hydration. Changed pipeline to actually create result files. Renamed and moved files since they no longer directly test the CLI.
Oct 6 2020
Oct 5 2020
Fixed nits. Altered partial versioning test to fit with changes
Removed implementation-specific test. Added type checking to values in address dict
The only thing that worries me is how this might play with the part of the system that actually caches addresses for a given version. But as long as we're intentional going forward with preserving this behavior it should be fine. The fact that steps upstream of a step with a filled-in version really helps us here.