- User Since
- Jul 20 2020, 3:42 PM (42 w, 3 d)
Finish type annotations
respin to allow backcompat with dbt 0.18.x users
Wrap iterator in tighter error bound, fix some messages
works for me !
Wed, May 12
Add more tests for multi-output case, change arg names
Mon, May 10
Update examples, remove lambda_solid from API docs
Fix multi-output, add tests for retry, failure, add asset materialization recording, be more strict about when context is provided.
Fri, May 7
This is now ready for another round of review
Update on top of resource object changes
I_Contains_Generator -> IContainsGenerator
Change to use isinstance checks to determine generator-ness
Thu, May 6
Respun using a fxn/context manager to build out a solid execution context, and on top of optional-context changes
Wed, May 5
q mgmt for now
q mgmt for now
Add comments, simplify test
Docs and errors pass
revert most recent change and stack into invocation diff
Added a "context arg provided" attribute to solid definition. We will use this in invocation to determine whether or not a context arg is provided, rather than magically going based on requirements.
Tue, May 4
Ensure that we don't tear down a provided instance, only the one that we construct.
Might be better to wait for context-optional, bc we might want to change it again for that.
Thought of another issue: We only want to tear down an instance that we construct, not one that is passed in.
Move teardown to __del__ if not in context manager scope. This ensures that teardown will always occur before the end of the program.
Think I'm gonna add a follow up / breaking change diff s.t. we're a bit more strict about name validation, ie if context doesn't work, neither should context_ or _context.
Mon, May 3
Test battery, fix inference
Adding battery of tests
Respin after input arg validation refactor
Respin to have clearer functionality
Respinning to be more clear about functionality
Wait for refactor
There is still a possibility that we don't tear down properly here - if someone initializes a context manager but never tries to actually use anything from it, then we won't perform teardown. Trying to think of a place to inject teardown to ensure that it always occurs (if not in context manager, and not already torn down), I was thinking del?
Update to check whether any resource is a context manager, and if it is, ensure that resources are being accessed in context.
Fri, Apr 30
Respin with clearer functionality
Respin with separate fxns for validation and getting extra args
Deque for now
Thu, Apr 29
Wed, Apr 28
Respin with better context manager error support, wait to see how build_resources changes land
Use more descriptive disable expressions
Respin with DirectSolidExecutionContext
Tue, Apr 27
Fix kwargs logic, tests for asyncio and multiple outputs
Removing reviewers until this is ready for review again
Remove invokable stuff
Mon, Apr 26
Up and fix worse type sig