Page MenuHomePhabricator

catherinewu (Catherine)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Feb 24 2020, 6:17 PM (47 w, 3 d)
Roles
Administrator

Recent Activity

Today

catherinewu accepted D6087: [docs] Adjusted documentation to reflect that solids can also be tagged (issue 3291).

Macro pooh_eating_honey:

Thu, Jan 21, 7:41 PM
catherinewu added inline comments to D5651: [Github Community] Add a PR template.
Thu, Jan 21, 2:38 AM

Yesterday

catherinewu added inline comments to D6025: [Documentation] Refresh the Contributing guides.
Wed, Jan 20, 11:16 PM
catherinewu added inline comments to D6025: [Documentation] Refresh the Contributing guides.
Wed, Jan 20, 11:10 PM
catherinewu added inline comments to D6025: [Documentation] Refresh the Contributing guides.
Wed, Jan 20, 4:35 AM
catherinewu closed D6051: fix docs rendering.
Wed, Jan 20, 1:28 AM
catherinewu committed R1:e573617c2d19: fix docs rendering (authored by catherinewu).
fix docs rendering
Wed, Jan 20, 1:28 AM

Tue, Jan 19

catherinewu closed D6037: update k8s docs.
Tue, Jan 19, 9:52 PM
catherinewu committed R1:e72bd1004000: update k8s docs (authored by catherinewu).
update k8s docs
Tue, Jan 19, 9:51 PM
catherinewu accepted D6039: Default user deployment replica count to 1.

Macro pooh_eating_honey:

Tue, Jan 19, 5:34 PM

Sun, Jan 17

catherinewu requested review of D6037: update k8s docs.
Sun, Jan 17, 12:55 AM
catherinewu abandoned D3939: add test for celery k8s run launcher termination without run launcher.
Sun, Jan 17, 12:28 AM

Fri, Jan 15

catherinewu added inline comments to D5949: Add an example of how to trigger a pipeline by graphQL.
Fri, Jan 15, 2:34 AM

Thu, Jan 14

catherinewu closed D5986: Add mailing list subscription button (via Revue).
Thu, Jan 14, 9:49 PM
catherinewu committed R1:3d5076a71ca1: Add mailing list subscription button (via Revue) (authored by catherinewu).
Add mailing list subscription button (via Revue)
Thu, Jan 14, 9:49 PM
catherinewu added a reviewer for D5986: Add mailing list subscription button (via Revue): yuhan.
Thu, Jan 14, 9:26 PM
catherinewu updated the diff for D5986: Add mailing list subscription button (via Revue).

update license

Thu, Jan 14, 9:26 PM
catherinewu updated the diff for D5986: Add mailing list subscription button (via Revue).

rebase

Thu, Jan 14, 9:24 PM
catherinewu added a comment to D5986: Add mailing list subscription button (via Revue).

Thu, Jan 14, 2:30 AM
catherinewu updated the diff for D5986: Add mailing list subscription button (via Revue).

up

Thu, Jan 14, 1:26 AM
catherinewu abandoned D4778: default to k8s scheduler, update docs.
Thu, Jan 14, 12:22 AM
catherinewu requested review of D5986: Add mailing list subscription button (via Revue).
Thu, Jan 14, 12:09 AM

Wed, Jan 13

catherinewu closed D5537: k8s deployment docs.
Wed, Jan 13, 5:47 PM
catherinewu committed R1:f73c4d537837: k8s deployment docs (authored by catherinewu).
k8s deployment docs
Wed, Jan 13, 5:47 PM
catherinewu updated the diff for D5537: k8s deployment docs.

more deadlinks

Wed, Jan 13, 3:35 AM
catherinewu updated the diff for D5537: k8s deployment docs.

fix deadlinks

Wed, Jan 13, 2:49 AM

Tue, Jan 12

catherinewu updated the diff for D5537: k8s deployment docs.

up

Tue, Jan 12, 9:19 PM
catherinewu updated the diff for D5537: k8s deployment docs.

address comments

Tue, Jan 12, 9:16 PM
catherinewu updated the diff for D5537: k8s deployment docs.

up

Tue, Jan 12, 3:03 AM

Mon, Jan 11

catherinewu updated the diff for D5537: k8s deployment docs.

fix dead links

Mon, Jan 11, 11:14 PM
catherinewu added a comment to D5891: Update helm defaults for user code deployments, run launcher, and rabbitmq.

oh, we should run integration tests on this

Mon, Jan 11, 10:23 PM
catherinewu accepted D5891: Update helm defaults for user code deployments, run launcher, and rabbitmq.

LGTM!

Mon, Jan 11, 10:22 PM
catherinewu updated the diff for D5537: k8s deployment docs.

rebase

Mon, Jan 11, 7:34 PM
catherinewu updated the diff for D5537: k8s deployment docs.

bk

Mon, Jan 11, 6:30 PM
catherinewu retitled D5537: k8s deployment docs from [rfc] k8s deployment docs to k8s deployment docs.
Mon, Jan 11, 6:30 PM
catherinewu added inline comments to D5651: [Github Community] Add a PR template.
Mon, Jan 11, 5:50 PM

Sat, Jan 9

catherinewu updated the diff for D5537: k8s deployment docs.

address comments

Sat, Jan 9, 2:45 AM
catherinewu added inline comments to D5537: k8s deployment docs.
Sat, Jan 9, 2:45 AM
catherinewu added inline comments to D5651: [Github Community] Add a PR template.
Sat, Jan 9, 12:50 AM

Fri, Jan 8

catherinewu added a comment to D5651: [Github Community] Add a PR template.

How does this template compare to other open source projects like dbt, gatsby, react, kubernetes?

Fri, Jan 8, 11:52 PM

Wed, Jan 6

catherinewu accepted D5476: Adds values.yaml fields for user-deployment liveness and startup probe..
Wed, Jan 6, 10:55 PM
catherinewu added a comment to D5537: k8s deployment docs.

is it possible to link to a release version of the values.yaml file? otherwise, there will be potential for skew between latest published helm chart and the values.yaml on master

Wed, Jan 6, 7:24 PM
catherinewu requested review of D5833: k8s scheduler test that creates a k8s job from a k8s cron job.
Wed, Jan 6, 8:09 AM
catherinewu closed D5830: fix scheduler image in helm chart.
Wed, Jan 6, 4:15 AM
catherinewu committed R1:cec365242853: fix scheduler image in helm chart (authored by catherinewu).
fix scheduler image in helm chart
Wed, Jan 6, 4:15 AM

Tue, Jan 5

catherinewu closed D5813: Skip flaky tests.
Tue, Jan 5, 5:07 AM
catherinewu committed R1:198e13c03397: Skip flaky tests (authored by catherinewu).
Skip flaky tests
Tue, Jan 5, 5:07 AM
catherinewu updated the diff for D5813: Skip flaky tests.

pylint

Tue, Jan 5, 4:46 AM
catherinewu updated the diff for D5813: Skip flaky tests.

black

Tue, Jan 5, 4:36 AM
catherinewu updated the diff for D5813: Skip flaky tests.

black

Tue, Jan 5, 4:03 AM
catherinewu updated the diff for D5813: Skip flaky tests.

black

Tue, Jan 5, 4:01 AM
catherinewu updated the diff for D5813: Skip flaky tests.

black

Tue, Jan 5, 3:21 AM
catherinewu requested review of D5537: k8s deployment docs.
Tue, Jan 5, 3:16 AM
catherinewu added a comment to D5782: Helm: annotations everywhere.

ah cool got it, looks good!

Tue, Jan 5, 3:01 AM

Mon, Jan 4

catherinewu added inline comments to D5793: Update dagsterDaemon documention in helm chart.
Mon, Jan 4, 6:10 PM
catherinewu added inline comments to D5476: Adds values.yaml fields for user-deployment liveness and startup probe..
Mon, Jan 4, 6:08 PM
catherinewu accepted D5782: Helm: annotations everywhere.

Awesome! Small nit: we validate that userDeployments.service.annotations exists but assume that dagit.service.annotations and flower.service.annotations exist -- would prefer either assuming all or validating all?

Mon, Jan 4, 6:00 PM

Thu, Dec 24

catherinewu accepted D5765: Add default dagsterApiGrpcArgs for example user code deployment.

looks good, let's run the integration tests before merging

Thu, Dec 24, 3:58 AM

Wed, Dec 23

catherinewu accepted D5763: Clarify in schedule docblock that scheduled_execution_time is only available in DagsterDaemonScheduler.
Wed, Dec 23, 8:25 PM

Dec 17 2020

catherinewu updated the diff for D5654: remove the option to backfill from failure.

up

Dec 17 2020, 4:56 PM
catherinewu requested review of D5654: remove the option to backfill from failure.
Dec 17 2020, 4:54 PM

Dec 16 2020

catherinewu accepted D5642: Add DagsterDaemonScheduler to helm chart, minus the tests.

Macro pooh_eating_honey:

Dec 16 2020, 5:20 PM
catherinewu accepted D5594: Add integration test for using DagsterDaemonScheduler in helm chart, renmame run coordinator integration test to daemon integration test.

this looks good. I think it would be slightly better to add an env var that disables telemetry (ie DAGSTER_TELEMETRY_ENABLED) which can replace BUILDKITE in the Dockerfile and in the telemetry.py file so that we have more rigorous guarantees that tests won't send telemetry in the future. Also setting telemetry.enabled: false as the default in the Helm chart would be reasonable since we're very unlikely to get telemetry from k8s clusters anyways

Dec 16 2020, 5:17 PM
catherinewu added a comment to D5476: Adds values.yaml fields for user-deployment liveness and startup probe..

might need to kick off BK again? also i don't see the BK integration test suite?

Dec 16 2020, 2:51 AM
catherinewu accepted D5469: New mutation for force-mark-as-failed during termination.

Macro pooh_eating_honey:

Dec 16 2020, 2:20 AM
catherinewu added a comment to D5542: DynamicOutput execution support.

Overall, looks amazing -- so excited for this!

Dec 16 2020, 2:18 AM

Dec 15 2020

catherinewu added inline comments to D5594: Add integration test for using DagsterDaemonScheduler in helm chart, renmame run coordinator integration test to daemon integration test.
Dec 15 2020, 8:14 PM
catherinewu added inline comments to D5476: Adds values.yaml fields for user-deployment liveness and startup probe..
Dec 15 2020, 6:40 AM
catherinewu added a comment to D5476: Adds values.yaml fields for user-deployment liveness and startup probe..

Might be missing something, but I think adding integration on its own line under Test Plan should run the integration tests? you can also go to https://buildkite.com/dagster/dagster-integration-tests/builds/, click “New Build”, and enter the commit hash

Dec 15 2020, 6:33 AM

Dec 11 2020

catherinewu requested changes to D5030: Add workspace level telemetry metrics.

phab queue cleanup

Dec 11 2020, 11:10 PM
catherinewu accepted D5535: Get make dev_install working on python 3.9.

Macro pikachu:

Dec 11 2020, 11:10 PM
catherinewu accepted D5530: clean-up execution plan objects.

Macro pooh_eating_honey:

Dec 11 2020, 11:05 PM
catherinewu requested changes to D5469: New mutation for force-mark-as-failed during termination.
Dec 11 2020, 10:59 PM
catherinewu added inline comments to D5521: MappableOutput(Definition).
Dec 11 2020, 10:41 PM
catherinewu accepted D5521: MappableOutput(Definition).

looks gooood to me! I personally like "mappable"

Dec 11 2020, 10:27 PM
catherinewu committed R1:7d35265e3cc6: 0.9.22 release; update last_updated.yaml for docker images (authored by catherinewu).
0.9.22 release; update last_updated.yaml for docker images
Dec 11 2020, 6:37 AM
catherinewu committed R1:35d8765e8885: 0.9.22.post0 changes.md (authored by catherinewu).
0.9.22.post0 changes.md
Dec 11 2020, 6:36 AM
catherinewu committed R1:58128a6852cb: 0.9.22 changes.md (authored by catherinewu).
0.9.22 changes.md
Dec 11 2020, 6:35 AM
catherinewu committed R1:e4786bf5c67f: 0.9.21 changes.md (authored by bob).
0.9.21 changes.md
Dec 11 2020, 6:33 AM
catherinewu committed R1:211be13680f9: [Docs] 0.9.22 (authored by catherinewu).
[Docs] 0.9.22
Dec 11 2020, 6:26 AM
catherinewu committed R1:5a7f742f0c9b: 0.9.22 release; update last_updated.yaml for docker images (authored by catherinewu).
0.9.22 release; update last_updated.yaml for docker images
Dec 11 2020, 5:58 AM
catherinewu resigned from D5456: Improve error messages for celery-k8s launcher.
Dec 11 2020, 4:50 AM
catherinewu requested changes to D5476: Adds values.yaml fields for user-deployment liveness and startup probe..

Hey, I don't think we should make livenessProbe and startupProbe required -- some folks may want to use a different method of monitoring their deployments. Moreover, startupProbe is not available on all kubernetes versions (only available starting 1.16+) so this would break folks on older versions.

Dec 11 2020, 4:45 AM
catherinewu committed R1:72978e9de84d: 0.9.22.post0 (authored by catherinewu).
0.9.22.post0
Dec 11 2020, 4:26 AM
catherinewu committed R1:b567b7728ec0: 0.9.22.post0 release to fix dask (authored by catherinewu).
0.9.22.post0 release to fix dask
Dec 11 2020, 4:14 AM
catherinewu committed R1:398deba0f6cf: pin urllib3 (authored by catherinewu).
pin urllib3
Dec 11 2020, 4:09 AM
catherinewu committed R1:f8753f0965de: pin dask to 2.30.0 (authored by catherinewu).
pin dask to 2.30.0
Dec 11 2020, 4:09 AM
catherinewu closed D5546: pin urllib3.
Dec 11 2020, 4:07 AM
catherinewu committed R1:51c13f7c2a82: pin urllib3 (authored by catherinewu).
pin urllib3
Dec 11 2020, 4:07 AM
catherinewu requested review of D5546: pin urllib3.
Dec 11 2020, 4:04 AM
catherinewu closed D5549: pin dask to 2.30.0.
Dec 11 2020, 4:03 AM
catherinewu committed R1:658ca5916adb: pin dask to 2.30.0 (authored by catherinewu).
pin dask to 2.30.0
Dec 11 2020, 4:03 AM
catherinewu updated the diff for D5549: pin dask to 2.30.0.

black

Dec 11 2020, 3:33 AM
catherinewu updated the diff for D5549: pin dask to 2.30.0.

also need to pin distributed to <=2.30.1

Dec 11 2020, 3:28 AM
catherinewu published D5549: pin dask to 2.30.0 for review.
Dec 11 2020, 3:18 AM
catherinewu added a reverting change for R1:64a5e0224a98: 0.9.22pre0: R1:ead9563023df: Revert "0.9.22pre0".
Dec 11 2020, 3:00 AM
catherinewu committed R1:ead9563023df: Revert "0.9.22pre0" (authored by catherinewu).
Revert "0.9.22pre0"
Dec 11 2020, 3:00 AM
catherinewu committed R1:039f9d347ddd: 0.9.22 (authored by catherinewu).
0.9.22
Dec 11 2020, 2:26 AM
catherinewu committed R1:3b540bcae453: 0.9.22.pre1 (authored by catherinewu).
0.9.22.pre1
Dec 11 2020, 2:11 AM
catherinewu committed R1:6dd29501b5a7: 0.9.22.pre0 (authored by catherinewu).
0.9.22.pre0
Dec 11 2020, 2:00 AM