- User Since
- Feb 24 2020, 6:17 PM (47 w, 3 d)
Tue, Jan 19
Sun, Jan 17
Fri, Jan 15
Thu, Jan 14
Wed, Jan 13
Tue, Jan 12
Mon, Jan 11
oh, we should run integration tests on this
Sat, Jan 9
Fri, Jan 8
How does this template compare to other open source projects like dbt, gatsby, react, kubernetes?
Wed, Jan 6
is it possible to link to a release version of the values.yaml file? otherwise, there will be potential for skew between latest published helm chart and the values.yaml on master
Tue, Jan 5
ah cool got it, looks good!
Mon, Jan 4
Awesome! Small nit: we validate that userDeployments.service.annotations exists but assume that dagit.service.annotations and flower.service.annotations exist -- would prefer either assuming all or validating all?
Thu, Dec 24
looks good, let's run the integration tests before merging
Wed, Dec 23
Dec 17 2020
Dec 16 2020
this looks good. I think it would be slightly better to add an env var that disables telemetry (ie DAGSTER_TELEMETRY_ENABLED) which can replace BUILDKITE in the Dockerfile and in the telemetry.py file so that we have more rigorous guarantees that tests won't send telemetry in the future. Also setting telemetry.enabled: false as the default in the Helm chart would be reasonable since we're very unlikely to get telemetry from k8s clusters anyways
might need to kick off BK again? also i don't see the BK integration test suite?
Overall, looks amazing -- so excited for this!
Dec 15 2020
Might be missing something, but I think adding integration on its own line under Test Plan should run the integration tests? you can also go to https://buildkite.com/dagster/dagster-integration-tests/builds/, click “New Build”, and enter the commit hash
Dec 11 2020
phab queue cleanup
looks gooood to me! I personally like "mappable"
Hey, I don't think we should make livenessProbe and startupProbe required -- some folks may want to use a different method of monitoring their deployments. Moreover, startupProbe is not available on all kubernetes versions (only available starting 1.16+) so this would break folks on older versions.
also need to pin distributed to <=2.30.1