Page MenuHomePhabricator

catherinewu (Catherine)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Feb 24 2020, 6:17 PM (34 w, 2 d)
Roles
Administrator

Recent Activity

Yesterday

catherinewu added a comment to D4849: [docker] Improve caching in editable images.

i think building images to make dagster core changes is not the most optimal dev loop?

Wed, Oct 21, 10:10 PM
catherinewu requested changes to D4840: [2/2] Expose config for k8s run launcher in helm chart.
Wed, Oct 21, 2:58 PM

Tue, Oct 20

catherinewu added inline comments to D4718: [1/2] Configure celeryless deploy on helm.
Tue, Oct 20, 3:35 AM

Fri, Oct 16

catherinewu accepted D4804: Fix helm namespace lifecycle in tests.

Macro pooh_eating_honey:

Fri, Oct 16, 11:33 PM
catherinewu requested changes to D4718: [1/2] Configure celeryless deploy on helm.

sending back to your queue w/ a few things

  • I think that job_namespace, load_incluster_config, kubeconfig_file for the K8sRunLauncher should be configurable from the helm chart, similar to other system components
  • re "It's kinda weird to have the launcher rely on the pipeline run configmap on when it might not even be configured if the user decides to go with user deployments." -- when a user enables user deployments, the pipeline run confipmap can still be used by the K8sScheduler. I agree that the naming is a bit dated, but I would much prefer either using the env-pipeline-run configmap, renaming the env-pipeline-run configmap, or deprecating the env-pipeline-run configmap (probably in a separate diff?) instead of having two configmaps that are very similar.
  • wrt documentation, i generally prefer adding docs the same time a feature is released so that users can immediately have a place to learn more; its also a good time to reflect on the code before committing to see if anything could be improved, and guarantees that the documentation actually gets written instead of backlogged
Fri, Oct 16, 8:26 PM
catherinewu accepted D4674: Add liveness probe to extra celery workers.

awesome, looks good!

Fri, Oct 16, 8:06 PM
catherinewu added a reviewer for D4778: default to k8s scheduler, update docs: alangenfeld.
Fri, Oct 16, 6:44 PM

Thu, Oct 15

catherinewu added inline comments to D4718: [1/2] Configure celeryless deploy on helm.
Thu, Oct 15, 2:46 AM
catherinewu added a comment to D4718: [1/2] Configure celeryless deploy on helm.

looking good! few things (1) whats the reasoning behind adding "helm/dagster/templates/configmap-env-instance.yaml" instead of using "helm/dagster/templates/configmap-env-pipeline-run.yaml"? (2) in test_integration.py, could we assert that there are no celery worker pods and no step job pods? in a previous migration, there was a bad issue where the tests were no longer using the expected run launcher so would be nice to add a sanity check

Thu, Oct 15, 2:41 AM
catherinewu closed D4777: fix formatting for configsource.
Thu, Oct 15, 2:08 AM
catherinewu committed R1:d64e88bae4e0: fix formatting for configsource (authored by catherinewu).
fix formatting for configsource
Thu, Oct 15, 2:08 AM

Wed, Oct 14

catherinewu added inline comments to D4776: Add grpc-health-probe.
Wed, Oct 14, 6:49 PM
catherinewu added inline comments to D4718: [1/2] Configure celeryless deploy on helm.
Wed, Oct 14, 6:07 PM
catherinewu updated the diff for D4778: default to k8s scheduler, update docs.

up

Wed, Oct 14, 4:54 PM
catherinewu added reviewers for D4778: default to k8s scheduler, update docs: nate, johann.
Wed, Oct 14, 4:53 PM
catherinewu requested review of D4778: default to k8s scheduler, update docs.
Wed, Oct 14, 4:29 PM
catherinewu requested review of D4777: fix formatting for configsource.
Wed, Oct 14, 4:01 PM

Tue, Oct 13

catherinewu added a comment to D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.

@alangenfeld re: telemetry, @rexledesma added telemetry for launch_scheduled_execution and is creating a doc to share (1) how to add telemetry to other functions and (2) how to query the collected data via sql. Are you thinking of adding telemetry for workspace_from_load_target, including the type of load_target -- should be similar to log_repo_stats unless we want to intercept the load_target within the telemetry_wrapper

Tue, Oct 13, 5:28 PM

Mon, Oct 12

catherinewu added a comment to D4674: Add liveness probe to extra celery workers.

Since the extraWorkerQueues part of this test has caused flakiness in the past, can we make sure to run this through bk a few times (5?) times before merging? last time i tried to add extraWorkerQueues back, it passed the first three runs and then failed twice (https://dagster.phacility.com/D4535)

Mon, Oct 12, 9:59 PM
catherinewu requested changes to D4718: [1/2] Configure celeryless deploy on helm.

looks reasonable to me! can we add a test that involves spinning up a k8s-only deployment in kind and asserting that we can run a pipeline successfully?

Mon, Oct 12, 9:50 PM
catherinewu added inline comments to D4718: [1/2] Configure celeryless deploy on helm.
Mon, Oct 12, 9:48 PM

Tue, Oct 6

catherinewu accepted D4367: Celery run queue.

approving conditional on checking for engine events (ie "Sending run coordinator task to Celery" + "Run coordinator finished, Celery exiting") in tests and some error handling for if "wait_for_job_success" raises an exception

Tue, Oct 6, 4:59 PM
catherinewu added inline comments to D4367: Celery run queue.
Tue, Oct 6, 4:52 PM
catherinewu accepted D4624: Add telemetry to scheduled execution api.
Tue, Oct 6, 4:21 PM

Sat, Oct 3

catherinewu requested changes to D4624: Add telemetry to scheduled execution api.

add test?

Sat, Oct 3, 12:05 AM

Thu, Oct 1

catherinewu added inline comments to D4601: K8s API Retries.
Thu, Oct 1, 7:52 PM
catherinewu accepted D4601: K8s API Retries.
Thu, Oct 1, 7:49 PM
catherinewu updated the summary of D4595: refactor some k8s error handling.
Thu, Oct 1, 3:27 PM
catherinewu updated the summary of D4595: refactor some k8s error handling.
Thu, Oct 1, 3:27 PM
catherinewu updated the summary of D4595: refactor some k8s error handling.
Thu, Oct 1, 3:26 PM
catherinewu updated the diff for D4595: refactor some k8s error handling.

u

Thu, Oct 1, 6:33 AM
catherinewu updated the test plan for D4595: refactor some k8s error handling.
Thu, Oct 1, 6:33 AM
catherinewu updated the diff for D4595: refactor some k8s error handling.

remove extra files

Thu, Oct 1, 6:30 AM
catherinewu requested review of D4595: refactor some k8s error handling.
Thu, Oct 1, 5:25 AM

Wed, Sep 30

catherinewu added a comment to D4603: Interrupt / termination test for dagster_dask.

we might want to add an engine event saying that there was a user-initiated termination

Wed, Sep 30, 11:46 PM
catherinewu accepted D4603: Interrupt / termination test for dagster_dask.

Macro pooh_eating_honey:

Wed, Sep 30, 11:45 PM

Tue, Sep 29

catherinewu closed D4567: emit engine events for termination w/ cli api run launcher and grpc run launcher.
Tue, Sep 29, 7:17 PM
catherinewu committed R1:bac544ccd3af: emit engine events for termination w/ cli api run launcher and grpc run launcher (authored by catherinewu).
emit engine events for termination w/ cli api run launcher and grpc run launcher
Tue, Sep 29, 7:17 PM
catherinewu accepted D4573: [dagster-celery-k8s] use error field on engine event data.

Macro pooh_eating_honey:

Tue, Sep 29, 2:03 AM
catherinewu added a reviewer for D4567: emit engine events for termination w/ cli api run launcher and grpc run launcher: dgibson.
Tue, Sep 29, 1:46 AM
catherinewu updated the diff for D4567: emit engine events for termination w/ cli api run launcher and grpc run launcher.

update DefaultRunLauncher terminate() to only call either cli api run launcher's terminate() or grpc run launcher's terminate() but not both

Tue, Sep 29, 1:41 AM
catherinewu closed D4568: add termination event for k8s launchers.
Tue, Sep 29, 12:52 AM
catherinewu committed R1:cb6055fde3fc: add termination event for k8s launchers (authored by catherinewu).
add termination event for k8s launchers
Tue, Sep 29, 12:52 AM
catherinewu closed D4574: increase k8s polling wait time between attempts to 10s.
Tue, Sep 29, 12:41 AM
catherinewu committed R1:3593b6b0c6ab: increase k8s polling wait time between attempts to 10s (authored by catherinewu).
increase k8s polling wait time between attempts to 10s
Tue, Sep 29, 12:41 AM
catherinewu closed D4337: generate synthetic step fail event when k8s step job raises a DagsterK8sError.
Tue, Sep 29, 12:40 AM
catherinewu committed R1:afb27a40130c: generate synthetic step fail event when k8s step job raises a DagsterK8sError (authored by catherinewu).
generate synthetic step fail event when k8s step job raises a DagsterK8sError
Tue, Sep 29, 12:40 AM

Mon, Sep 28

catherinewu added inline comments to D4444: Only allow grpc run termination in user code.
Mon, Sep 28, 10:50 PM
catherinewu updated the diff for D4568: add termination event for k8s launchers.

bk flake

Mon, Sep 28, 9:30 PM
catherinewu added a reviewer for D4574: increase k8s polling wait time between attempts to 10s: alangenfeld.
Mon, Sep 28, 9:28 PM
catherinewu added inline comments to D4567: emit engine events for termination w/ cli api run launcher and grpc run launcher.
Mon, Sep 28, 8:58 PM
catherinewu requested review of D4574: increase k8s polling wait time between attempts to 10s.
Mon, Sep 28, 8:10 PM
catherinewu requested review of D4567: emit engine events for termination w/ cli api run launcher and grpc run launcher.
Mon, Sep 28, 7:13 PM
catherinewu updated the diff for D4568: add termination event for k8s launchers.

update test

Mon, Sep 28, 6:58 PM
catherinewu updated the diff for D4337: generate synthetic step fail event when k8s step job raises a DagsterK8sError.

use error=serializable_error_info_from_exc_info(sys.exc_info()),

Mon, Sep 28, 6:41 PM
catherinewu added inline comments to D4565: Add more info to pipeline run status checks.
Mon, Sep 28, 5:51 PM
catherinewu updated the diff for D4568: add termination event for k8s launchers.

up

Mon, Sep 28, 5:29 PM
catherinewu updated the diff for D4568: add termination event for k8s launchers.

add cls to engine event

Mon, Sep 28, 4:08 PM
catherinewu updated the test plan for D4337: generate synthetic step fail event when k8s step job raises a DagsterK8sError.
Mon, Sep 28, 3:59 PM
catherinewu added reviewers for D4568: add termination event for k8s launchers: alangenfeld, nate.
Mon, Sep 28, 3:58 PM
catherinewu updated the diff for D4568: add termination event for k8s launchers.

isort

Mon, Sep 28, 3:52 PM

Sun, Sep 27

catherinewu requested review of D4568: add termination event for k8s launchers.
Sun, Sep 27, 10:07 PM
catherinewu updated the diff for D4337: generate synthetic step fail event when k8s step job raises a DagsterK8sError.

up

Sun, Sep 27, 9:55 PM
catherinewu closed D4561: update bk unit image.
Sun, Sep 27, 9:48 PM
catherinewu committed R1:eddc34c051a5: update bk unit image (authored by catherinewu).
update bk unit image
Sun, Sep 27, 9:48 PM
catherinewu accepted D4565: Add more info to pipeline run status checks.
Sun, Sep 27, 9:26 PM
catherinewu updated the diff for D4337: generate synthetic step fail event when k8s step job raises a DagsterK8sError.

rebase

Sun, Sep 27, 9:11 PM
catherinewu updated the diff for D4561: update bk unit image.

rebase

Sun, Sep 27, 9:10 PM
catherinewu closed D4555: Update BK integration image.
Sun, Sep 27, 9:08 PM
catherinewu committed R1:a30f3644466b: Update BK integration image (authored by catherinewu).
Update BK integration image
Sun, Sep 27, 9:08 PM

Fri, Sep 25

catherinewu requested review of D4561: update bk unit image.
Fri, Sep 25, 11:33 PM
catherinewu updated the diff for D4337: generate synthetic step fail event when k8s step job raises a DagsterK8sError.

rebase

Fri, Sep 25, 11:29 PM
catherinewu accepted D4560: Add more info to exception when pipeline run is in the wrong state.

I think there might be a few other occurrences, like https://github.com/dagster-io/dagster/blob/master/python_modules/libraries/dagster-k8s/dagster_k8s/client.py#L200 and making it more explicit in https://github.com/dagster-io/dagster/blob/master/python_modules/libraries/dagster-celery-k8s/dagster_celery_k8s/executor.py#L310

Fri, Sep 25, 11:26 PM
catherinewu retitled D4555: Update BK integration image from update bk integration image to Update BK integration image.
Fri, Sep 25, 11:16 PM
catherinewu requested review of D4555: Update BK integration image.
Fri, Sep 25, 8:00 PM
catherinewu created Image Macro "sounds_good_cat".
Fri, Sep 25, 5:44 PM
catherinewu created Image Macro "animated_excited_guy".
Fri, Sep 25, 5:43 PM
catherinewu created Image Macro "pooh_eating_honey".
Fri, Sep 25, 5:43 PM

Thu, Sep 24

catherinewu accepted D4543: Fix build_js.sh for paths with spaces.
Thu, Sep 24, 11:55 PM
catherinewu added inline comments to D4367: Celery run queue.
Thu, Sep 24, 10:47 PM
catherinewu accepted D4523: [dagit] download debug file.

Thu, Sep 24, 8:47 PM
catherinewu committed R1:bd7aebdb1ebc: add ability to specify custom celery liveness probe (authored by catherinewu).
add ability to specify custom celery liveness probe
Thu, Sep 24, 6:33 PM
catherinewu closed D4527: add ability to specify custom celery liveness probe.
Thu, Sep 24, 6:33 PM
catherinewu added a comment to D4531: [easy] "rehydrate" => "load" in user-facing error messages.

nice catch

Thu, Sep 24, 6:31 PM
catherinewu updated the diff for D4527: add ability to specify custom celery liveness probe.

update comment

Thu, Sep 24, 6:13 PM
catherinewu updated the summary of D4527: add ability to specify custom celery liveness probe.
Thu, Sep 24, 6:01 PM
catherinewu requested review of D4527: add ability to specify custom celery liveness probe.
Thu, Sep 24, 5:34 PM
catherinewu committed R1:4237716ac4d0: return [] instead of None in celery executor (authored by catherinewu).
return [] instead of None in celery executor
Thu, Sep 24, 5:06 PM
catherinewu closed D4529: return [] instead of None in celery executor.
Thu, Sep 24, 5:06 PM
catherinewu updated the diff for D4528: see what errors happen when using extra celery workers in bk.

run bk again

Thu, Sep 24, 4:57 PM
catherinewu updated the test plan for D4529: return [] instead of None in celery executor.
Thu, Sep 24, 5:23 AM
catherinewu updated the test plan for D4529: return [] instead of None in celery executor.
Thu, Sep 24, 5:22 AM
catherinewu requested review of D4529: return [] instead of None in celery executor.
Thu, Sep 24, 5:09 AM
catherinewu requested review of D4528: see what errors happen when using extra celery workers in bk.
Thu, Sep 24, 4:53 AM

Wed, Sep 23

catherinewu accepted D4504: Add actionable instruction when surfacing dagster home error.

Wed, Sep 23, 9:04 PM
catherinewu added inline comments to D4504: Add actionable instruction when surfacing dagster home error.
Wed, Sep 23, 9:02 PM
catherinewu added inline comments to D4504: Add actionable instruction when surfacing dagster home error.
Wed, Sep 23, 8:55 PM
catherinewu accepted D4509: dagster debug export & dagit-debug.

sooooo awesome

Wed, Sep 23, 5:42 PM
catherinewu added inline comments to D4367: Celery run queue.
Wed, Sep 23, 7:37 AM
catherinewu added inline comments to D4514: Use dagster type display name for dagster event message.
Wed, Sep 23, 7:23 AM