Page MenuHomePhabricator

bob (Bob Chen)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 10 2020, 2:21 PM (7 w, 16 h)

Recent Activity

Yesterday

bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • Fix the pruned buildkite pipeline. 0
Thu, Oct 29, 9:12 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • Adds dependency injection for k8s client on dagster-k8s run launcher.
Thu, Oct 29, 8:03 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • Adds dependency injection for k8s client on dagster-k8s run launcher.
Thu, Oct 29, 8:02 PM
bob accepted D4710: Adds example dbt project..

This is super cool (and well tested)! integrating dbt -> jupyter plotting -> slack is a much more comprehensive showcase of dagster. thanks again for commandeering this

Thu, Oct 29, 7:42 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • Prunes buildkite steps to only include integration tests.
Thu, Oct 29, 6:27 PM
bob added a comment to Senior IAM Policy Wizard.

Macro hitmonchan:

Thu, Oct 29, 4:30 PM

Mon, Oct 26

bob accepted D4887: Emit materializations for dbt CLI solids.

lgtm. Since the outputted results from various dbt commands are not consistent, we should discuss how to design the interface for materializing them and implement in a future diff. This revision does its job, tho

Mon, Oct 26, 6:14 PM
bob requested changes to D4887: Emit materializations for dbt CLI solids.

This refactoring of generate_materializations is great, especially since it's now available for CLI solids. I left some revision requests, and feel free to ask me to clarify anything if needed.

Mon, Oct 26, 5:24 PM
bob closed D4872: Adds CSS styling for doc pages generated by sphinx-click..
Mon, Oct 26, 2:44 PM
bob committed R1:b9da214e9619: Adds CSS styling for doc pages generated by sphinx-click. (authored by bob).
Adds CSS styling for doc pages generated by sphinx-click.
Mon, Oct 26, 2:44 PM

Fri, Oct 23

bob requested review of D4872: Adds CSS styling for doc pages generated by sphinx-click..
Fri, Oct 23, 9:12 PM
bob requested review of D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
Fri, Oct 23, 9:08 PM

Thu, Oct 22

bob closed D4875: Fixes typo. (RpcDbt -> DbtRpc).
Thu, Oct 22, 10:09 PM
bob committed R1:4a3fbbf9aa6e: Fixes typo. (RpcDbt -> DbtRpc) (authored by bob).
Fixes typo. (RpcDbt -> DbtRpc)
Thu, Oct 22, 10:09 PM
bob closed D4858: Improves docstrings for config API..
Thu, Oct 22, 8:46 PM
bob committed R1:5218af84a0ab: Improves docstrings for config API. (authored by bob).
Improves docstrings for config API.
Thu, Oct 22, 8:46 PM
bob updated the diff for D4858: Improves docstrings for config API..
  • Improves wording and adds examples for Noneable.
Thu, Oct 22, 8:16 PM
bob updated the diff for D4858: Improves docstrings for config API..
  • Adds docstrings for ScalarUnion.
Thu, Oct 22, 6:18 PM
bob abandoned D4692: Fetch PySpark driver IP if not set in resource config..
Thu, Oct 22, 5:09 PM
bob updated the diff for D4692: Fetch PySpark driver IP if not set in resource config..
  • Adds custom PySparkResource example.
Thu, Oct 22, 5:09 PM
bob updated the diff for D4858: Improves docstrings for config API..
  • Adds docstrings for ScalarUnion.
Thu, Oct 22, 5:00 PM

Wed, Oct 21

bob requested review of D4858: Improves docstrings for config API..
Wed, Oct 21, 9:44 PM

Tue, Oct 20

bob abandoned D4832: Fixes code snippet for configuring multiprocess executor..
Tue, Oct 20, 8:07 PM
bob accepted D4833: Lint.
Tue, Oct 20, 6:28 PM
bob requested review of D4832: Fixes code snippet for configuring multiprocess executor..
Tue, Oct 20, 5:15 PM
bob accepted D4822: serialization safety.

Macro thumbsup:

Tue, Oct 20, 3:05 PM
bob added inline comments to D4822: serialization safety.
Tue, Oct 20, 2:49 PM

Mon, Oct 19

bob accepted D4816: Stream dbt logs and re-log messages.

Macro chefkiss:

Mon, Oct 19, 8:58 PM

Tue, Oct 13

bob closed D4610: Creates data classes for dbt run results..
Tue, Oct 13, 8:44 PM
bob committed R1:a15a5ea20d83: Creates data classes for dbt run results. (authored by bob).
Creates data classes for dbt run results.
Tue, Oct 13, 8:44 PM
bob updated the diff for D4610: Creates data classes for dbt run results..
  • Fix linting issues 0.
  • Fix lint issues 1.
  • Fix lint issues 2, and marks dbt optional fields.
  • Fix lint issues 3.
  • Fix lint issues 4.
  • Improves descriptions for AssetMaterializations.
  • Adds "command" property to CliRunResult.
  • Uses specific commit in GitHub link.
  • Fix lint issues 1.
  • Tags CLI solids with "kind:dbt".
  • Rename result classes.
  • Refactors classes into named tuples.
  • Removes unused imports.
  • Uncomments checks.
  • Rename CLI asset materializations.
  • Removes pre_exec from CLI execution.
  • Removes unused import signal.
Tue, Oct 13, 8:21 PM
bob updated the diff for D4610: Creates data classes for dbt run results..
  • Removes unused import signal.
Tue, Oct 13, 6:51 PM

Mon, Oct 12

bob closed D4746: Uses comment markers instead of line numbers..
Mon, Oct 12, 5:32 PM
bob committed R1:55204d43bd9d: Uses comment markers instead of line numbers. (authored by bob).
Uses comment markers instead of line numbers.
Mon, Oct 12, 5:32 PM

Fri, Oct 9

bob updated the diff for D4610: Creates data classes for dbt run results..
  • Removes pre_exec from CLI execution.
Fri, Oct 9, 9:52 PM
bob updated the diff for D4610: Creates data classes for dbt run results..
  • Fix linting issues 0.
  • Fix lint issues 1.
  • Fix lint issues 2, and marks dbt optional fields.
  • Fix lint issues 3.
  • Fix lint issues 4.
  • Improves descriptions for AssetMaterializations.
  • Adds "command" property to CliRunResult.
  • Uses specific commit in GitHub link.
  • Fix lint issues 1.
  • Tags CLI solids with "kind:dbt".
  • Rename result classes.
  • Refactors classes into named tuples.
  • Removes unused imports.
  • Uncomments checks.
  • Rename CLI asset materializations.
Fri, Oct 9, 9:48 PM
bob closed D4724: Adds checks for float and int elements..
Fri, Oct 9, 8:13 PM
bob committed R1:92593e22dbae: Adds checks for float and int elements. (authored by bob).
Adds checks for float and int elements.
Fri, Oct 9, 8:13 PM
bob requested review of D4746: Uses comment markers instead of line numbers..
Fri, Oct 9, 7:10 PM
bob updated the summary of D4610: Creates data classes for dbt run results..
Fri, Oct 9, 6:16 PM

Thu, Oct 8

bob updated the diff for D4610: Creates data classes for dbt run results..
  • Removes unused imports.
Thu, Oct 8, 10:44 PM
bob updated the diff for D4610: Creates data classes for dbt run results..

Rebased on master.

Thu, Oct 8, 10:40 PM
bob updated the diff for D4610: Creates data classes for dbt run results..
  • Removes unused imports.
Thu, Oct 8, 9:12 PM
bob updated the diff for D4610: Creates data classes for dbt run results..
  • Tags CLI solids with "kind:dbt".
  • Rename result classes.
  • Refactors classes into named tuples.
Thu, Oct 8, 9:09 PM
bob requested review of D4724: Adds checks for float and int elements..
Thu, Oct 8, 4:34 PM
bob accepted D4702: Fix API Docs search.
Thu, Oct 8, 3:35 PM

Tue, Oct 6

bob requested review of D4692: Fetch PySpark driver IP if not set in resource config..
Tue, Oct 6, 9:50 PM

Mon, Oct 5

bob updated the diff for D4610: Creates data classes for dbt run results..

Fixes lint issues 1.

Mon, Oct 5, 2:28 PM
bob updated the diff for D4610: Creates data classes for dbt run results..

Uses specific commit in GitHub link.

Mon, Oct 5, 1:50 PM
bob updated subscribers of D4610: Creates data classes for dbt run results..

Are we still trying to get dwall to use this library? It seems like some of these changes (like the RpcRunResult rename) will require a lot of changes in his codebase. This isn't a bad thing, but just wanted to call it out.

Mon, Oct 5, 1:34 PM

Fri, Oct 2

bob closed D4653: Fixes for autodocs on dagster-dbt..
Fri, Oct 2, 8:07 PM
bob committed R1:6bb219a588e2: Fixes for autodocs on dagster-dbt. (authored by bob).
Fixes for autodocs on dagster-dbt.
Fri, Oct 2, 8:07 PM
bob updated the diff for D4610: Creates data classes for dbt run results..
  • Improves descriptions for AssetMaterializations.
  • Adds "command" property to CliRunResult.
Fri, Oct 2, 7:57 PM
bob requested review of D4653: Fixes for autodocs on dagster-dbt..
Fri, Oct 2, 7:22 PM
bob accepted D4636: typo in dbt apidocs.

fyi I'm currently doing a diff to fix this typo among some other autodoc errors/warnings. Feel free to land this though.

Fri, Oct 2, 5:17 PM

Thu, Oct 1

bob requested review of D4610: Creates data classes for dbt run results..
Thu, Oct 1, 6:56 PM

Sep 29 2020

bob closed D4592: Adds scrolling and line wrapping to Examples index page..
Sep 29 2020, 8:34 PM
bob committed R1:edb84ce04bf2: Adds scrolling and line wrapping to Examples index page. (authored by bob).
Adds scrolling and line wrapping to Examples index page.
Sep 29 2020, 8:34 PM
bob requested review of D4592: Adds scrolling and line wrapping to Examples index page..
Sep 29 2020, 8:14 PM

Sep 28 2020

bob closed D4552: Updates API docs sidebar and index list..
Sep 28 2020, 3:51 PM
bob committed R1:4f86de5df5f3: Updates API docs sidebar and index list. (authored by bob).
Updates API docs sidebar and index list.
Sep 28 2020, 3:51 PM
bob closed D4553: Always bolds labels "Parameters", "Returns", etc. in API docs..
Sep 28 2020, 3:39 PM
bob committed R1:f2c9f01d47b0: Always bolds labels "Parameters", "Returns", etc. in API docs. (authored by bob).
Always bolds labels "Parameters", "Returns", etc. in API docs.
Sep 28 2020, 3:39 PM
bob updated the diff for D4552: Updates API docs sidebar and index list..
  • Updates list of examples.
  • Fix code snippet label for multi-loc example.
Sep 28 2020, 3:22 PM

Sep 25 2020

bob requested review of D4553: Always bolds labels "Parameters", "Returns", etc. in API docs..
Sep 25 2020, 7:43 PM
bob requested review of D4552: Updates API docs sidebar and index list..
Sep 25 2020, 7:22 PM
bob committed R1:987f73da80ff: Adds autodocs for dagster-dbt public API. (authored by bob).
Adds autodocs for dagster-dbt public API.
Sep 25 2020, 7:09 PM
bob closed D4540: Adds autodocs for dagster-dbt public API..
Sep 25 2020, 7:09 PM
bob updated the diff for D4540: Adds autodocs for dagster-dbt public API..

Adds dagster_dbt to API docs sidebar and libraries index page.

Sep 25 2020, 6:39 PM
bob updated the diff for D4540: Adds autodocs for dagster-dbt public API..
  • Adds more detailed docstrings to dbt RPC types and resources.
  • Rearrange order of dagster_dbt API docs.
Sep 25 2020, 6:30 PM

Sep 24 2020

bob requested review of D4540: Adds autodocs for dagster-dbt public API..
Sep 24 2020, 8:51 PM

Sep 22 2020

bob committed R1:19bed5df9351: Fixes RPC components for smoother `datalands` migration. (authored by bob).
Fixes RPC components for smoother `datalands` migration.
Sep 22 2020, 4:06 PM
bob closed D4492: Fixes RPC components for smoother `datalands` migration..
Sep 22 2020, 4:06 PM
bob accepted D4483: fix relative links in module docs.
Sep 22 2020, 4:00 PM
bob updated the diff for D4492: Fixes RPC components for smoother `datalands` migration..

Imports custom error type.

Sep 22 2020, 3:39 PM
bob updated the diff for D4492: Fixes RPC components for smoother `datalands` migration..
  • Refactors the conversion of generator to RPC poll result.
  • Adds docstring to unwrap_result and checks overriding of config_schema on run_sql solid factory.
Sep 22 2020, 3:36 PM

Sep 21 2020

bob requested review of D4492: Fixes RPC components for smoother `datalands` migration..
Sep 21 2020, 5:15 PM
bob committed R1:b4c572613c7b: Add dbt cli module (authored by bob).
Add dbt cli module
Sep 21 2020, 4:34 PM
bob closed D4336: Add dbt cli module.
Sep 21 2020, 4:34 PM
bob updated the diff for D4336: Add dbt cli module.
  • Adds typechecks on CLI bool params.
  • Changes flag set XOR to set union.
  • Adds asset materializations of shell output.
Sep 21 2020, 3:36 PM

Sep 18 2020

bob updated the diff for D4336: Add dbt cli module.
  • Extracts output from dbt compile without causing Python member errors.
  • Adds logger attribute to DbtRpcClient.
  • Revert "Extracts output from dbt compile without causing Python member errors." and "Adds logger attribute to DbtRpcClient.
  • Adds @experimental to CLI solids.
  • Improve descriptions on CLI flag configs.
  • Removes Python 2 classifier.
Sep 18 2020, 9:07 PM

Sep 17 2020

bob committed R1:35b888095b95: Log changes for the 0.9.9 release. (authored by bob).
Log changes for the 0.9.9 release.
Sep 17 2020, 10:26 PM
bob closed D4463: Log changes for the 0.9.9 release..
Sep 17 2020, 10:26 PM
bob committed R1:101293535761: [Docs] 0.9.9 (authored by bob).
[Docs] 0.9.9
Sep 17 2020, 9:58 PM
bob committed R1:e166a4227a94: 0.9.9 (authored by bob).
0.9.9
Sep 17 2020, 9:23 PM
bob committed R1:75ac4b78445a: 0.9.9.pre1 (authored by bob).
0.9.9.pre1
Sep 17 2020, 9:00 PM
bob committed R1:e243f7c1cbb5: 0.9.9.pre0 (authored by bob).
0.9.9.pre0
Sep 17 2020, 4:14 PM
bob committed R1:2624b0bddb79: Removes dedent from CLI config snippet. (authored by bob).
Removes dedent from CLI config snippet.
Sep 17 2020, 3:40 PM
bob closed D4453: Removes dedent from CLI config snippet..
Sep 17 2020, 3:40 PM
bob added a comment to D4336: Add dbt cli module.

Re: Excluded dbt CLI Commands
I agree that the excluded dbt CLI commands are less likely to be useful or to be executed in the context of Dagster.

Sep 17 2020, 3:37 PM
bob requested review of D4453: Removes dedent from CLI config snippet..
Sep 17 2020, 2:53 PM

Sep 16 2020

bob added a comment to D4336: Add dbt cli module.

@johann Thanks for the review. I looked into your bullet points and here's what I found.

Sep 16 2020, 8:33 PM
bob added a reviewer for D4336: Add dbt cli module: johann.
Sep 16 2020, 5:37 PM
bob updated the diff for D4336: Add dbt cli module.

Re-export dbt_cli_compile from package root.

Sep 16 2020, 5:31 PM
bob retitled D4336: Add dbt cli module from [WIP] add dbt cli module to Add dbt cli module.
Sep 16 2020, 4:06 PM
bob updated the diff for D4336: Add dbt cli module.

Re-export dbt_cli_compile from package root.

Sep 16 2020, 4:06 PM
bob retitled D4336: Add dbt cli module from [WIP] add dbt cli module to Add dbt cli module.
Sep 16 2020, 4:05 PM
bob updated the diff for D4336: Add dbt cli module.

Adds the compile CLI solid.

Sep 16 2020, 2:40 PM

Sep 14 2020

bob updated the diff for D4336: Add dbt cli module.

Re-adds Python 2.7 as classifier.

Sep 14 2020, 9:16 PM
bob committed R1:0715ad266016: Changes `python_module`to `python_package` in tutorial. (authored by bob).
Changes `python_module`to `python_package` in tutorial.
Sep 14 2020, 8:50 PM