Page MenuHomePhabricator

bob (Bob Chen)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 10 2020, 2:21 PM (18 w, 5 d)

Recent Activity

Thu, Jan 14

bob closed D6019: Adds changelog notes and migration guide for 0.10.0..
Thu, Jan 14, 11:33 PM
bob committed R1:271f4d798111: Adds changelog notes and migration guide for 0.10.0. (authored by bob).
Adds changelog notes and migration guide for 0.10.0.
Thu, Jan 14, 11:32 PM

Thu, Jan 7

bob requested review of D5864: Adds guards for default probes..
Thu, Jan 7, 9:10 PM
bob closed D5476: Adds values.yaml fields for user-deployment liveness and startup probe..
Thu, Jan 7, 5:24 PM
bob committed R1:0095b7ca04fe: Adds values.yaml fields for user-deployment liveness and startup probe. (authored by bob).
Adds values.yaml fields for user-deployment liveness and startup probe.
Thu, Jan 7, 5:24 PM
bob updated the diff for D5476: Adds values.yaml fields for user-deployment liveness and startup probe..

Fix rebase.

Thu, Jan 7, 5:04 PM

Tue, Jan 5

bob updated the diff for D5476: Adds values.yaml fields for user-deployment liveness and startup probe..

Sets default probe in template YAML instead of values.yaml.

Tue, Jan 5, 7:14 PM

Mon, Jan 4

bob updated the diff for D5476: Adds values.yaml fields for user-deployment liveness and startup probe..

Adds user-deployment replica count for daemon integration test.

Mon, Jan 4, 9:42 PM
bob updated the diff for D5476: Adds values.yaml fields for user-deployment liveness and startup probe..

Adds replicaCount field to user-deployment integration tests.

Mon, Jan 4, 8:14 PM
bob updated the diff for D5476: Adds values.yaml fields for user-deployment liveness and startup probe..

Show all probe config for user-deployments in values.yaml, and make probes optional in templates.

Mon, Jan 4, 7:55 PM
bob abandoned D5679: Cleans env markers for unsupported Python versions..

these changes are a subset of this commit

Mon, Jan 4, 7:03 PM
bob added inline comments to D5476: Adds values.yaml fields for user-deployment liveness and startup probe..
Mon, Jan 4, 6:54 PM
bob closed D5603: Adds helm tests for ingress..
Mon, Jan 4, 6:37 PM
bob committed R1:2296d0352d96: Adds helm tests for ingress. (authored by bob).
Adds helm tests for ingress.
Mon, Jan 4, 6:37 PM
bob updated the diff for D5603: Adds helm tests for ingress..

rebase again to fix dagster-github problem

Mon, Jan 4, 6:13 PM
bob updated the diff for D5679: Cleans env markers for unsupported Python versions..

rebase on master

Mon, Jan 4, 6:00 PM
bob updated the diff for D5476: Adds values.yaml fields for user-deployment liveness and startup probe..

rebase on master

Mon, Jan 4, 5:56 PM
bob updated the diff for D5603: Adds helm tests for ingress..

rebase on master

Mon, Jan 4, 5:51 PM

Dec 18 2020

bob closed D5587: Uses configurable HTTP GET for Dagit liveness probe..
Dec 18 2020, 8:39 PM
bob committed R1:8641f723276f: Uses configurable HTTP GET for Dagit liveness probe. (authored by bob).
Uses configurable HTTP GET for Dagit liveness probe.
Dec 18 2020, 8:39 PM
bob added reviewers for D5603: Adds helm tests for ingress.: rexledesma, nate.
Dec 18 2020, 7:51 PM
bob updated the diff for D5476: Adds values.yaml fields for user-deployment liveness and startup probe..

rebase on master

Dec 18 2020, 7:50 PM
bob updated the diff for D5679: Cleans env markers for unsupported Python versions..
  • Removes "future" dependency.
Dec 18 2020, 7:48 PM
bob updated the diff for D5587: Uses configurable HTTP GET for Dagit liveness probe..

rebase on master

Dec 18 2020, 7:43 PM

Dec 17 2020

bob requested review of D5679: Cleans env markers for unsupported Python versions..
Dec 17 2020, 10:34 PM

Dec 15 2020

bob updated the test plan for D5476: Adds values.yaml fields for user-deployment liveness and startup probe..
Dec 15 2020, 5:30 PM
bob updated the diff for D5476: Adds values.yaml fields for user-deployment liveness and startup probe..
  • Removes integration tests from BuildKite pipeline.
  • Fixes templating for startupProbe on user deployments.
Dec 15 2020, 5:30 PM
bob accepted D5590: Pass down image pull secrets to k8s launcher in helm.

Macro thumbsup:

Dec 15 2020, 5:06 PM

Dec 14 2020

bob updated the diff for D5603: Adds helm tests for ingress..

Revert "Tmp: Inject typo in ingress.yaml.", and remove integration tests from buildkite pipeline.

Dec 14 2020, 10:34 PM
bob updated the diff for D5603: Adds helm tests for ingress..

Tmp: Inject typo in ingress.yaml.

Dec 14 2020, 10:14 PM
bob requested review of D5603: Adds helm tests for ingress..
Dec 14 2020, 9:41 PM
bob requested changes to D5590: Pass down image pull secrets to k8s launcher in helm.

I tested this locally with helm install --dry-run, but not with an actual install. If the helm integration tests are green, then this should be good to go

Dec 14 2020, 9:29 PM
bob updated the diff for D5476: Adds values.yaml fields for user-deployment liveness and startup probe..
  • Marks probes as optional in user deployments.
  • Tmp: Enables integration tests in BuildKite.
Dec 14 2020, 8:24 PM
bob updated the summary of D5587: Uses configurable HTTP GET for Dagit liveness probe..
Dec 14 2020, 8:12 PM
bob updated the test plan for D5587: Uses configurable HTTP GET for Dagit liveness probe..
Dec 14 2020, 7:11 PM
bob updated the diff for D5587: Uses configurable HTTP GET for Dagit liveness probe..

Revert testing modifications.

Dec 14 2020, 7:11 PM
bob updated the diff for D5587: Uses configurable HTTP GET for Dagit liveness probe..

Use httpGet probe handle for dagit in helm integration tests.

Dec 14 2020, 6:12 PM
bob updated the diff for D5587: Uses configurable HTTP GET for Dagit liveness probe..
  • Revert "Show captured output for integration tests."
  • WIP: Show helm output.
Dec 14 2020, 5:38 PM
bob updated the diff for D5587: Uses configurable HTTP GET for Dagit liveness probe..

Show captured output for integration tests.

Dec 14 2020, 5:22 PM
bob updated the diff for D5476: Adds values.yaml fields for user-deployment liveness and startup probe..

rebase

Dec 14 2020, 4:36 PM
bob updated the diff for D5587: Uses configurable HTTP GET for Dagit liveness probe..

WIP: Attempt using httpGet probe.

Dec 14 2020, 3:40 PM
bob updated the diff for D5476: Adds values.yaml fields for user-deployment liveness and startup probe..

Make livenessProbe and startupProbe optional for userdeployments.

Dec 14 2020, 3:38 PM
bob requested review of D5587: Uses configurable HTTP GET for Dagit liveness probe..
Dec 14 2020, 3:36 PM

Dec 10 2020

bob committed R1:f12b025a700a: Fixes whitespacing in helm template ingress.yaml. (authored by bob).
Fixes whitespacing in helm template ingress.yaml.
Dec 10 2020, 9:45 PM
bob removed reviewers for D5476: Adds values.yaml fields for user-deployment liveness and startup probe.: catherinewu, alangenfeld, rexledesma.
Dec 10 2020, 8:53 PM
bob closed D5528: Revert "Uses configurable HTTP GET for Dagit liveness probe.".
Dec 10 2020, 7:55 PM
bob added a reverting change for D5487: Uses configurable HTTP GET for Dagit liveness probe.: R1:de3b62016df5: Revert "Uses configurable HTTP GET for Dagit liveness probe.".
Dec 10 2020, 7:55 PM
bob added a reverting change for R1:5248900bd15d: Uses configurable HTTP GET for Dagit liveness probe.: R1:de3b62016df5: Revert "Uses configurable HTTP GET for Dagit liveness probe.".
Dec 10 2020, 7:55 PM
bob committed R1:de3b62016df5: Revert "Uses configurable HTTP GET for Dagit liveness probe." (authored by bob).
Revert "Uses configurable HTTP GET for Dagit liveness probe."
Dec 10 2020, 7:55 PM
bob updated the diff for D5476: Adds values.yaml fields for user-deployment liveness and startup probe..

Sets livenessProbe and startupProbe as required on userDeployments.

Dec 10 2020, 7:49 PM
bob requested review of D5528: Revert "Uses configurable HTTP GET for Dagit liveness probe.".
Dec 10 2020, 7:49 PM
bob added a reverting change for D5487: Uses configurable HTTP GET for Dagit liveness probe.: D5528: Revert "Uses configurable HTTP GET for Dagit liveness probe.".
Dec 10 2020, 7:30 PM
bob added a reverting change for R1:5248900bd15d: Uses configurable HTTP GET for Dagit liveness probe.: D5528: Revert "Uses configurable HTTP GET for Dagit liveness probe.".
Dec 10 2020, 7:30 PM
bob closed D5487: Uses configurable HTTP GET for Dagit liveness probe..
Dec 10 2020, 6:52 PM
bob committed R1:5248900bd15d: Uses configurable HTTP GET for Dagit liveness probe. (authored by bob).
Uses configurable HTTP GET for Dagit liveness probe.
Dec 10 2020, 6:52 PM
bob closed D5484: Fixes whitespacing in helm template ingress.yaml..
Dec 10 2020, 6:51 PM
bob committed R1:dda96758be96: Fixes whitespacing in helm template ingress.yaml. (authored by bob).
Fixes whitespacing in helm template ingress.yaml.
Dec 10 2020, 6:51 PM
bob updated the diff for D5487: Uses configurable HTTP GET for Dagit liveness probe..

Applies schema for 'core.v1.Probe' to the k8s LivenessProbe and StartupProbe config objects.

Dec 10 2020, 6:36 PM
bob retitled D5484: Fixes whitespacing in helm template ingress.yaml. from WIP: Fixes whitespacing in helm template ingress.yaml. to Fixes whitespacing in helm template ingress.yaml..
Dec 10 2020, 6:01 PM
bob updated the diff for D5476: Adds values.yaml fields for user-deployment liveness and startup probe..

Adds value.schema for user deployments.

Dec 10 2020, 5:51 PM

Dec 8 2020

bob requested review of D5487: Uses configurable HTTP GET for Dagit liveness probe..
Dec 8 2020, 10:27 PM
bob retitled D5484: Fixes whitespacing in helm template ingress.yaml. from Fixes whitespacing in helm template ingress.yaml. to WIP: Fixes whitespacing in helm template ingress.yaml..
Dec 8 2020, 9:53 PM
bob accepted D5485: named outputs for dbt solids.

Okay for now, to get this demo rolling.

Dec 8 2020, 9:44 PM
bob requested review of D5484: Fixes whitespacing in helm template ingress.yaml..
Dec 8 2020, 9:13 PM
bob requested review of D5476: Adds values.yaml fields for user-deployment liveness and startup probe..
Dec 8 2020, 4:58 PM

Dec 4 2020

bob committed R1:69b035080476: [Docs] 0.9.21 (authored by bob).
[Docs] 0.9.21
Dec 4 2020, 2:54 AM

Dec 3 2020

bob committed R1:159b13112c5d: 0.9.21 (authored by bob).
0.9.21
Dec 3 2020, 10:47 PM
bob committed R1:eed18edf6008: 0.9.21.pre0 (authored by bob).
0.9.21.pre0
Dec 3 2020, 10:29 PM
bob committed R1:0234b19fc044: Changes for 0.9.21 release. (authored by bob).
Changes for 0.9.21 release.
Dec 3 2020, 10:19 PM
bob committed R1:dbc43105b2e6: [Docs] 0.9.20 (authored by bob).
[Docs] 0.9.20
Dec 3 2020, 10:13 PM
bob committed R1:f153f83096bb: 0.9.20 Changes (authored by Chris DeCarolis <cdguitar817@gmail.com>).
0.9.20 Changes
Dec 3 2020, 8:34 PM
bob committed R1:b7881ca4631d: Uses official container image for flower. (authored by bob).
Uses official container image for flower.
Dec 3 2020, 5:35 PM
bob closed D5394: Uses official container image for flower..
Dec 3 2020, 3:38 PM
bob committed R1:6cbecb885f03: Uses official container image for flower. (authored by bob).
Uses official container image for flower.
Dec 3 2020, 3:38 PM

Dec 2 2020

bob requested review of D5394: Uses official container image for flower..
Dec 2 2020, 10:13 PM

Nov 4 2020

bob closed D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
Nov 4 2020, 6:12 PM
bob committed R1:8a249eddc755: Uses run tags instead of external pipeline tags for user defined k8s config. (authored by bob).
Uses run tags instead of external pipeline tags for user defined k8s config.
Nov 4 2020, 6:12 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • Uses repository location origin for fake external pipeline.
Nov 4 2020, 5:36 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..

Cleaning and rebase.

Nov 4 2020, 5:04 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • Refactors out dagster_test.
Nov 4 2020, 4:29 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • Refactors out dagster_test.
Nov 4 2020, 4:06 PM

Nov 3 2020

bob updated the summary of D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
Nov 3 2020, 4:43 PM
bob accepted D4988: Add json schema for helm postgresql.

Macro thumbsup:

Nov 3 2020, 4:38 PM
bob added inline comments to D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
Nov 3 2020, 4:17 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • Moves temporary kubeconfig into a fixture.
Nov 3 2020, 4:17 PM

Nov 2 2020

bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • WIP: Adds library testenv dependencies for dagster-celery-k8s.
Nov 2 2020, 9:51 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • WIP: Adds library testenv dependencies for dagster-celery-k8s.
Nov 2 2020, 9:25 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • WIP: Adds library testenv dependencies for dagster-celery-k8s.
Nov 2 2020, 8:07 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • WIP: Adds library testenv dependencies for dagster-celery-k8s.
Nov 2 2020, 7:58 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • WIP: Adds dagster-aws as testenv dependency for dagster-celery-k8s.
Nov 2 2020, 7:40 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • WIP: Fixes unicode string issue with py2, and adds missing param for dagster-celery-k8s test.
Nov 2 2020, 7:03 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • WIP: Fixes unicode string issue with py2, and adds missing param for dagster-celery-k8s test.
Nov 2 2020, 6:11 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • WIP: Adds dagster-test as testenv dependency for dagster-celery-k8s.
Nov 2 2020, 5:38 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • WIP: Use tmp file for kubeconfig.
Nov 2 2020, 5:31 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • WIP: Bypass loading k8s config.
  • Undo pruning of buildlkite pipeline.
Nov 2 2020, 5:06 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • Prunes buildkite steps to only include integration tests.
  • Adds dependency injection for k8s client on dagster-k8s run launcher.
  • Fix the pruned buildkite pipeline. 0
  • Fixes pruned buildkite pipeline. 1
  • Adds test for user defined k8s config in run tags.
  • Adds test for celery-k8s run launcher.
  • Runs isort.
  • Restores buildkite pipeline.
  • Fixes lint problems.
  • Prunes buildkite pipeline.
Nov 2 2020, 3:14 PM

Oct 30 2020

bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • Fixes lint problems.
Oct 30 2020, 7:38 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • Adds test for user defined k8s config in run tags.
  • Adds test for celery-k8s run launcher.
  • Runs isort.
  • Restores buildkite pipeline.
Oct 30 2020, 7:36 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • Prunes buildkite steps to only include integration tests.
  • Adds dependency injection for k8s client on dagster-k8s run launcher.
  • Fix the pruned buildkite pipeline. 0
  • Fixes pruned buildkite pipeline. 1
Oct 30 2020, 3:19 PM

Oct 29 2020

bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • Fix the pruned buildkite pipeline. 0
Oct 29 2020, 9:12 PM