Page MenuHomePhabricator

bengotow (Ben Gotow)
User

Projects

User does not belong to any projects.

User Details

User Since
May 9 2019, 3:45 PM (30 w, 3 d)

Recent Activity

Fri, Dec 6

bengotow updated the diff for D1549: [dagit] Fix wrapping in sidebar, disable reflow of fan-out.

Removing weighting method

Fri, Dec 6, 6:19 PM
bengotow added inline comments to D1549: [dagit] Fix wrapping in sidebar, disable reflow of fan-out.
Fri, Dec 6, 6:16 PM
bengotow retitled D1549: [dagit] Fix wrapping in sidebar, disable reflow of fan-out from Weight DAG edges by solid name similarity, fix wrapping in sidebar to [dagit] Fix wrapping in sidebar, disable reflow of fan-out.
Fri, Dec 6, 7:00 AM
bengotow updated the diff for D1549: [dagit] Fix wrapping in sidebar, disable reflow of fan-out.

Disable weighting based on name similarity, update tests

Fri, Dec 6, 6:59 AM
bengotow planned changes to D1549: [dagit] Fix wrapping in sidebar, disable reflow of fan-out.

Yeah that's a good point—I'll omit the edge weighting for now so we can push in the rest of these fixes. Long term it'd be kind of nice if users could choose between a couple graph layout algorithms but I agree this approach may work only for their DAG.

Fri, Dec 6, 6:51 AM
bengotow created D1552: Replace solid filter highlighting with solid filter re-layout.
Fri, Dec 6, 1:13 AM
bengotow created D1550: Replace current two-step zoom with smooth zoom.
Fri, Dec 6, 1:11 AM
bengotow updated the diff for D1549: [dagit] Fix wrapping in sidebar, disable reflow of fan-out.
  • Also fix issue with "black fill" appearing on external connection lines when viewing a composite (for unknown reason)
  • Turn off "max per row" code intended to wrap long lines of solids into blocks, does not work well on new example
Fri, Dec 6, 12:11 AM

Thu, Dec 5

bengotow updated the summary of D1549: [dagit] Fix wrapping in sidebar, disable reflow of fan-out.
Thu, Dec 5, 11:39 PM
bengotow created D1549: [dagit] Fix wrapping in sidebar, disable reflow of fan-out.
Thu, Dec 5, 11:39 PM
bengotow added a comment to D1540: Break pipeline explorer and sidebar queries apart, fetch only current solid layer.

Remaining build failure is in dagster-airflow, not related to this diff. Going to merge this.

Thu, Dec 5, 11:03 PM
bengotow updated the diff for D1540: Break pipeline explorer and sidebar queries apart, fetch only current solid layer.

Fix additional TS issue not found locally

Thu, Dec 5, 10:31 PM
bengotow updated the diff for D1540: Break pipeline explorer and sidebar queries apart, fetch only current solid layer.

Update data provided to our tests to match new root queries

Thu, Dec 5, 10:00 PM
bengotow updated the diff for D1540: Break pipeline explorer and sidebar queries apart, fetch only current solid layer.

Update for linting

Thu, Dec 5, 7:33 PM
bengotow added a comment to D1540: Break pipeline explorer and sidebar queries apart, fetch only current solid layer.

Will fix lint!

Thu, Dec 5, 7:24 PM
bengotow planned changes to D1542: Considerably reduce volume of type data fetched by ConfigEditor.

Oh interesting! Will check this out this afternoon—I wonder if TypeScript didn't catch usage of some of this data somehow.

Thu, Dec 5, 7:21 PM
bengotow added inline comments to D1542: Considerably reduce volume of type data fetched by ConfigEditor.
Thu, Dec 5, 12:55 AM
bengotow created D1542: Considerably reduce volume of type data fetched by ConfigEditor.
Thu, Dec 5, 12:54 AM

Wed, Dec 4

bengotow created D1540: Break pipeline explorer and sidebar queries apart, fetch only current solid layer.
Wed, Dec 4, 10:38 PM
bengotow accepted D1539: [graphql] improve solidHandle fields.

LGTM!

Wed, Dec 4, 9:36 PM
bengotow created D1536: Make dagit typeaheads match on value substrings, not just prefixes.
Wed, Dec 4, 6:45 PM

Sat, Nov 30

bengotow updated subscribers of D1516: Disable Re-execute and Retry when pipeline is unavailabe in repo (#1759).

Hmm I think the changed-configuration scenario currently breaks the retrieval of the pipeline entirely and the UI doesn't load? @alangenfeld / @schrockn I might need some context on how we should address that one—based on https://github.com/dagster-io/dagster/issues/1910, I assume we need to change the way runs are retrieved so that the config can be UnknownConfig? Although it seems it should still be viewable, just not re-used for execution. But without upfront interpretation, we wouldn't realize that the config was invalid until we tried to start execution with it, and wouldn't be able to disable the button in the UI.

Sat, Nov 30, 3:31 PM

Fri, Nov 29

bengotow created D1518: Update snapshot tests.
Fri, Nov 29, 11:01 PM
bengotow added a comment to D1431: Add UI for partitions in Dagit.

Just a few drive-by comments on the JS!

Fri, Nov 29, 9:21 PM
bengotow abandoned D1225: Preserve folded YAML sections in the config editor.

Going to abandon this—I think we decided not to move forward with preserving folding.

Fri, Nov 29, 9:13 PM
bengotow updated the diff for D1516: Disable Re-execute and Retry when pipeline is unavailabe in repo (#1759).

Update snapshot tests

Fri, Nov 29, 8:29 PM
bengotow updated the summary of D1516: Disable Re-execute and Retry when pipeline is unavailabe in repo (#1759).
Fri, Nov 29, 8:27 PM
bengotow created D1516: Disable Re-execute and Retry when pipeline is unavailabe in repo (#1759).
Fri, Nov 29, 8:22 PM
bengotow updated the summary of D1515: Add a loading spinner to the runs filter input (#1922).
Fri, Nov 29, 8:00 PM
bengotow created D1515: Add a loading spinner to the runs filter input (#1922).
Fri, Nov 29, 7:59 PM
bengotow updated the summary of D1513: Add input and output labels to invocations panel in dagit (#1503).
Fri, Nov 29, 7:48 PM
bengotow created D1513: Add input and output labels to invocations panel in dagit (#1503).
Fri, Nov 29, 7:46 PM
bengotow added a comment to D1508: Fix invalid + unrecoverable subselection state in Dagit (#1924).

(Edit: I tried rolling the SolidSelector's query up into the parent so that these would all load at once, and only afterwards realized that these need to be separate because the SolidSelector loads the whole pipeline, not the pipeline scoped down to the solid subset which is used by the rest of the interface.) I think we'll need to save a broader refactor of this for a little later.

Fri, Nov 29, 6:38 PM
bengotow added a comment to D1508: Fix invalid + unrecoverable subselection state in Dagit (#1924).

Hey! I updated this to include a comment and removed the spinner that I added to the Mode picker.

Fri, Nov 29, 5:46 PM
bengotow updated the diff for D1508: Fix invalid + unrecoverable subselection state in Dagit (#1924).
  • add a comment, remove the spinners in favor of default no-data appearance
Fri, Nov 29, 5:44 PM
bengotow updated the diff for D1456: Fix typeahead suggest token values, autoselect first completion.

Rebase

Fri, Nov 29, 5:24 PM

Thu, Nov 28

bengotow created D1510: Show invocations of composite solids when they’re expanded (#1836).
Thu, Nov 28, 4:18 PM
bengotow created D1509: Show autocompletions in initial empty config state, mention Ctrl-Space (#1576).
Thu, Nov 28, 6:05 AM
bengotow created D1508: Fix invalid + unrecoverable subselection state in Dagit (#1924).
Thu, Nov 28, 5:35 AM
bengotow created D1507: Use local Google fonts so dagit is usable offline (#1926).
Thu, Nov 28, 4:52 AM

Tue, Nov 19

bengotow updated the test plan for D1456: Fix typeahead suggest token values, autoselect first completion.
Tue, Nov 19, 7:35 AM
bengotow updated the diff for D1456: Fix typeahead suggest token values, autoselect first completion.
  • Add a few tests - we should probably add Enzyme soon
Tue, Nov 19, 7:34 AM
bengotow updated the summary of D1456: Fix typeahead suggest token values, autoselect first completion.
Tue, Nov 19, 6:13 AM
bengotow created D1456: Fix typeahead suggest token values, autoselect first completion.
Tue, Nov 19, 6:13 AM

Oct 29 2019

bengotow updated the diff for D1323: Repository-level solids explorer + graphQL root.
  • Make ordering of solids in usedSolids query deterministic
Oct 29 2019, 9:04 PM
bengotow updated the diff for D1323: Repository-level solids explorer + graphQL root.
  • Address diff feedback
  • Add solid explorer snapshot test, fix other tests, rebase
Oct 29 2019, 8:27 PM
bengotow planned changes to D1323: Repository-level solids explorer + graphQL root.
Oct 29 2019, 7:18 PM
bengotow added a comment to D1302: [dagit stress] random dag gen.

Oh this is super excellent, excited to do some perf work on top of this!

Oct 29 2019, 6:14 PM

Oct 25 2019

bengotow accepted D1327: add cancel button to active run view.
Oct 25 2019, 6:17 PM

Oct 24 2019

bengotow updated the diff for D1323: Repository-level solids explorer + graphQL root.

Rebase and fix black

Oct 24 2019, 7:37 PM
bengotow added a comment to D1323: Repository-level solids explorer + graphQL root.

Hey! I think if the design feedback is minor it's ready for a full review - if we end up changing the UI we can hold off on that, but I'd love to get your eyes on the python side now. I pieced together the graphql resolver a bit and that stuff is probably not ideal.

Oct 24 2019, 7:26 PM
bengotow updated the summary of D1323: Repository-level solids explorer + graphQL root.
Oct 24 2019, 6:50 PM
bengotow updated the summary of D1323: Repository-level solids explorer + graphQL root.
Oct 24 2019, 6:49 PM
bengotow created D1323: Repository-level solids explorer + graphQL root.
Oct 24 2019, 6:47 PM

Oct 11 2019

bengotow accepted D1260: Add css ellipsis for run pipeline name.

This looks good to me! 👍

Oct 11 2019, 3:54 PM

Oct 9 2019

bengotow updated the summary of D1253: Revert "Revert "Consolidate split panel handling, save divider locations to local storage"".
Oct 9 2019, 6:24 PM
bengotow added a reverting change for D1248: Revert "Consolidate split panel handling, save divider locations to local storage": D1253: Revert "Revert "Consolidate split panel handling, save divider locations to local storage"".
Oct 9 2019, 6:22 PM
bengotow added a reverting change for R1:c77468e64ff2: Revert "Consolidate split panel handling, save divider locations to local…: D1253: Revert "Revert "Consolidate split panel handling, save divider locations to local storage"".
Oct 9 2019, 6:22 PM
bengotow created D1253: Revert "Revert "Consolidate split panel handling, save divider locations to local storage"".
Oct 9 2019, 6:22 PM

Oct 8 2019

bengotow added inline comments to D1225: Preserve folded YAML sections in the config editor.
Oct 8 2019, 8:24 PM
bengotow added a comment to D1225: Preserve folded YAML sections in the config editor.

Hey folks! re: complexity I sort of agree - I could move this to a separate file / plugin type of thing, but it's definitely less straightforward than I'd hoped. We could switch to just storing line numbers that are folded instead of YAML paths, but I think being able to move between tabs and have your folding preserved is kind of nice, and with just indexes we might apply the folding incorrectly and not know. (eg: "fold line 12" might result in something being incorrectly folded if the YAML had changed.)

Oct 8 2019, 8:23 PM

Oct 4 2019

bengotow created D1225: Preserve folded YAML sections in the config editor.
Oct 4 2019, 10:55 PM
bengotow created D1216: Consolidate split panel handling, save divider locations to local storage.
Oct 4 2019, 6:48 PM

Oct 3 2019

bengotow updated the diff for D1189: Add Cancel and Delete menu items to the runs history view.
  • Fix out of sync Cancel.ts
Oct 3 2019, 7:26 PM
bengotow created D1189: Add Cancel and Delete menu items to the runs history view.
Oct 3 2019, 7:13 PM
bengotow updated the diff for D1150: Expose run filtering via GraphQL and implement pagination in Dagit.

Rebase

Oct 3 2019, 6:00 PM
bengotow updated the summary of D1150: Expose run filtering via GraphQL and implement pagination in Dagit.
Oct 3 2019, 5:51 PM
bengotow updated the diff for D1150: Expose run filtering via GraphQL and implement pagination in Dagit.
  • Add cursor stack for back-pagination, rename selector to PipelineRunsFilter
Oct 3 2019, 5:50 PM
bengotow added inline comments to D1150: Expose run filtering via GraphQL and implement pagination in Dagit.
Oct 3 2019, 5:42 PM
bengotow accepted D1170: Fix link to scheduled runs in dagit.

Looks great!

Oct 3 2019, 4:45 PM
bengotow accepted D1172: bypass apollo for compute log subscriptions.
Oct 3 2019, 4:38 PM

Oct 2 2019

bengotow updated the summary of D1150: Expose run filtering via GraphQL and implement pagination in Dagit.
Oct 2 2019, 10:49 PM
bengotow retitled D1150: Expose run filtering via GraphQL and implement pagination in Dagit from Expose run filtering via GraphQL and implement pagination in Dagit [wip] to Expose run filtering via GraphQL and implement pagination in Dagit.
Oct 2 2019, 10:48 PM
bengotow updated the diff for D1150: Expose run filtering via GraphQL and implement pagination in Dagit.
  • Client-side pagination and server-side search, addition of pipelineRunTags root query
Oct 2 2019, 10:40 PM
bengotow updated subscribers of D1150: Expose run filtering via GraphQL and implement pagination in Dagit.
Oct 2 2019, 4:28 AM

Oct 1 2019

bengotow accepted D1146: misc mode selector errors.

Looks good to me! I was seeing an exception on kwargs['mode'] so this should fix it 👍

Oct 1 2019, 11:30 PM
bengotow created D1150: Expose run filtering via GraphQL and implement pagination in Dagit.
Oct 1 2019, 11:26 PM
bengotow updated the diff for D1139: Fix misc GitHub issues related to Dagit UI.

Rebase

Oct 1 2019, 8:31 PM
bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.

Rebase

Oct 1 2019, 7:46 PM
bengotow created D1139: Fix misc GitHub issues related to Dagit UI.
Oct 1 2019, 7:34 PM
bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.
  • Add missing type
Oct 1 2019, 5:46 PM
bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.

Move the reloader interface to dagster-graphql, fix tests again

Oct 1 2019, 4:39 PM
bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.
  • Make the reloader optional in create_app as well
Oct 1 2019, 5:09 AM
bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.

Define a Reloader ABC in dagster core and move the implementation to Dagit, fix tests by making it optional

Oct 1 2019, 4:46 AM

Sep 30 2019

bengotow added inline comments to D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.
Sep 30 2019, 10:08 PM
bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.

Replaces the window.reload() at the beginning of the refresh, which only worked when the React app was running on a separate port in dev mode, with a "soft reload" and a toast to let you know when the reload is complete.

Sep 30 2019, 9:54 PM
bengotow updated the diff for D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.

Rebase on master to fix build(?)

Sep 30 2019, 9:30 PM
bengotow updated the diff for D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.

Abstract custom subscription into DirectGraphQLSubscription, implement retries

Sep 30 2019, 9:14 PM

Sep 27 2019

bengotow added a comment to D1075: Initial pass at Dagit “Reload” button based on single watch file.

Hey @alangenfeld this should be ready to go now. I did some research and it looks like watchmedo only allows you to watch directories, not single files, which is why the watch dir is a separate temp directory with one file in it. I was afraid that if we watched the same folder that it uses as a fallback for DAGSTER_HOME, it'd be possible for it to hit the "too many files to watch" scenario again? Let me know what you think

Sep 27 2019, 9:25 PM
bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.
  • Move reloading into a separate class given to the GraphQL layer
Sep 27 2019, 9:22 PM
bengotow added inline comments to D1075: Initial pass at Dagit “Reload” button based on single watch file.
Sep 27 2019, 9:17 PM
bengotow updated the diff for D1099: Fix GraphQL error when switching between pipelines with different modes.

Rename _open => _data

Sep 27 2019, 6:24 PM
bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.
  • Address diff feedback
Sep 27 2019, 6:23 PM
bengotow planned changes to D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.

Sounds good! I think handling reconnects is a good idea - will see if we can do that and pull the websocket impl out into a class for reuse.

Sep 27 2019, 6:19 PM
bengotow added a comment to D1099: Fix GraphQL error when switching between pipelines with different modes.

No - renaming modes will be a separate fix, working on that one now!
Will put a better name on _open

Sep 27 2019, 4:14 PM
bengotow updated the diff for D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.

Add file I forgot to commit

Sep 27 2019, 3:20 PM
bengotow created D1099: Fix GraphQL error when switching between pipelines with different modes.
Sep 27 2019, 3:19 PM
bengotow updated the summary of D1075: Initial pass at Dagit “Reload” button based on single watch file.
Sep 27 2019, 2:57 PM
bengotow updated the diff for D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.

Sync pipeline run status changes back to Apollo
Rename and move types a bit

Sep 27 2019, 2:49 PM
bengotow updated the summary of D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.
Sep 27 2019, 6:12 AM