Page MenuHomeElementl

bengotow (Ben Gotow)
User

Projects

User does not belong to any projects.

User Details

User Since
May 9 2019, 3:45 PM (127 w, 3 d)

Recent Activity

Aug 4 2021

bengotow accepted D9187: [crag] use non-Nothing inputs in crag toys.

Thanks for following up on this one! Does this mean that unlinked inputs would generally make sense to display in an accent color now? (re: https://github.com/dagster-io/dagster/issues/4407)

Aug 4 2021, 3:13 PM
bengotow added a comment to D9188: [caprisun] use @asset in the story recommender pipeline.

This LGTM! Excited to give this a spin

Aug 4 2021, 3:11 PM
bengotow accepted D9202: [dagit] Lazy-load partition set info for Schedules.

The JS changes here look great. I'd +1 showing the partition set name all the time with a link, and then just offering to "Show Coverage" or something like that to reveal "Missing", etc.

Aug 4 2021, 3:11 PM

Aug 2 2021

bengotow accepted D9161: [dagit] RFC: useSubscription instead of DirectGraphQLSubscription.
Aug 2 2021, 4:05 PM

Jul 29 2021

bengotow closed D9102: [dagit] Fix Gantt chart time indicators offset from step edges when scrollbars present #4408.
Jul 29 2021, 3:04 PM
bengotow committed R1:87a3e5a0f373: [dagit] Fix Gantt chart time indicators offset from step edges when scrollbars… (authored by bengotow).
[dagit] Fix Gantt chart time indicators offset from step edges when scrollbars…
Jul 29 2021, 3:04 PM
bengotow closed D9100: [dagit] Pad the bottom of the Gantt chart to avoid last row of steps behind search box #4389.
Jul 29 2021, 3:04 PM
bengotow committed R1:86210d56704b: [dagit] Pad the bottom of the Gantt chart to avoid last row of steps behind… (authored by bengotow).
[dagit] Pad the bottom of the Gantt chart to avoid last row of steps behind…
Jul 29 2021, 3:03 PM
bengotow closed D9099: [dagit] Fix divider covering the “Launch Execution” button #4370.
Jul 29 2021, 3:03 PM
bengotow committed R1:0c4c67051738: [dagit] Fix divider covering the “Launch Execution” button #4370 (authored by bengotow).
[dagit] Fix divider covering the “Launch Execution” button #4370
Jul 29 2021, 3:03 PM
bengotow added inline comments to D9070: [caprisun] RepositoryDefinition.asset_definition_graph.
Jul 29 2021, 3:01 PM

Jul 27 2021

bengotow requested review of D9102: [dagit] Fix Gantt chart time indicators offset from step edges when scrollbars present #4408.
Jul 27 2021, 9:51 PM
bengotow requested review of D9100: [dagit] Pad the bottom of the Gantt chart to avoid last row of steps behind search box #4389.
Jul 27 2021, 9:38 PM
bengotow requested review of D9099: [dagit] Fix divider covering the “Launch Execution” button #4370.
Jul 27 2021, 9:28 PM
bengotow accepted D9089: [dagit] Move WebSocket context.

This looks good to me! Added a couple inline comments but I think this is a nice improvement.

Jul 27 2021, 7:44 PM
bengotow accepted D9087: [dagit] Refactor components with subscriptions.

This looks good! I could have sworn there was more of a reason these were class components (shouldComponentUpdate or something like that...) but it doesn't seem like it. The new SFC implementations look equivalent to me sans that one setNodes([]) call 👍

Jul 27 2021, 6:53 PM
bengotow added a comment to D9070: [caprisun] RepositoryDefinition.asset_definition_graph.

This looks good to me! Just added an inline comment about the python syntax but feel free to ignore, you've thought about this 100x more and I'm just getting up to speed with the user stories around this!

Jul 27 2021, 6:46 PM
bengotow accepted D9030: [dagit] Fix manifest.

Oh wow haven't seen this before, good find

Jul 27 2021, 6:31 PM

Jul 16 2021

bengotow accepted D8922: [dagit] Upgrade chart.js.

This looks good to me! +1 for merging and kicking the tires on dev.

Jul 16 2021, 4:03 PM

Jul 8 2021

bengotow accepted D8764: [dagit] Crag: Don't show Partitions tab if none for Job.
Jul 8 2021, 5:48 PM
bengotow accepted D8765: [dagit] Crag: Fix Job browser titles.

Ahh good catch! I think I had too many tabs open to notice this one 🙈

Jul 8 2021, 5:43 PM

Jul 6 2021

bengotow accepted D8713: [dagit] Repair duplicate keys in App.test.
Jul 6 2021, 7:42 PM
bengotow closed D8614: Merge explorer into the Overview tab, remove Definition tab for all users.
Jul 6 2021, 2:05 PM
bengotow committed R1:b31aeee8234e: Merge explorer into the Overview tab, remove Definition tab for all users (authored by bengotow).
Merge explorer into the Overview tab, remove Definition tab for all users
Jul 6 2021, 2:04 PM
bengotow updated the diff for D8614: Merge explorer into the Overview tab, remove Definition tab for all users.
  • Fix tests
  • Revert snapshot change - only broken for me?
  • diff feedback
Jul 6 2021, 1:40 PM
bengotow accepted D8643: [dagit] Crag: Populate empty config if only one preset.

This looks great! Thanks for addressing the other stuff, I just added one comment about the presets.length == 1 && partitionSets case but I think this is good to go!

Jul 6 2021, 12:48 PM
bengotow accepted D8651: [dagit] Add "Download debug file" to Run page.

Code lgtm, but I agree we could play with the UI treatment a bit. Is the debug download feature just for folks to send to us, or can they inspect it themselves? If it's something we want people to find easily, we could potentially put two small icon buttons side by side in the top right area with the "tags" icon and the "download" icon and show the labels on hover? I think the tags icon is good enough people will guess what it does and we might end up with a whole toolbar of actions up there eventually...

Jul 6 2021, 12:37 PM

Jul 1 2021

bengotow accepted D8643: [dagit] Crag: Populate empty config if only one preset.

This looks good! It looks like runConfigYaml isn't used down in the ConfigEditorConfigPicker but otherwise this seems like a great change

Jul 1 2021, 3:05 PM
bengotow updated the diff for D8614: Merge explorer into the Overview tab, remove Definition tab for all users.

Rebase

Jul 1 2021, 12:24 AM
bengotow updated the summary of D8614: Merge explorer into the Overview tab, remove Definition tab for all users.
Jul 1 2021, 12:19 AM
bengotow requested review of D8614: Merge explorer into the Overview tab, remove Definition tab for all users.
Jul 1 2021, 12:08 AM

Jun 30 2021

bengotow accepted D8513: [dagit] Tidy up some JS.
Jun 30 2021, 4:19 AM
bengotow accepted D8567: [dagit] Settings page.

I think it'd be nice to go ahead and rip out /flags or have it redirect to this new page, seems like having both isn't super useful.

Jun 30 2021, 4:14 AM
bengotow accepted D8582: [dagit] Copy-to-clipboard fallback for unsupported contexts.

This looks good to me. I think from a user perspective it'd almost be better to fallback quietly to window.alert(stuffForClipboard) so they can select+copy out of there rather than hiding the buttons. I worry people will think the button was removed and file a ticket complaining about it. Didn't realize this was conditionally unavailable though! Super good to know 👍

Jun 30 2021, 4:10 AM
bengotow accepted D8601: [dagit] PipelineExecutionRoot refactor.

This looks great! Amazing how much better useQuery is than the old stuff...

Jun 30 2021, 4:08 AM

Jun 18 2021

bengotow accepted D8454: [dagit] Stop overfetching root query.
Jun 18 2021, 4:10 PM
bengotow accepted D8457: [dagit] Create AppCache via function.

LGTM!

Jun 18 2021, 3:48 PM

Jun 16 2021

bengotow closed D8394: [dagit] Switch to a new icon for jobs, limit overuse of pipeline icon.
Jun 16 2021, 6:17 PM
bengotow committed R1:92cf085f9227: [dagit] Switch to a new icon for jobs, limit overuse of pipeline icon (authored by bengotow).
[dagit] Switch to a new icon for jobs, limit overuse of pipeline icon
Jun 16 2021, 6:17 PM
bengotow updated the diff for D8394: [dagit] Switch to a new icon for jobs, limit overuse of pipeline icon.

Rebase

Jun 16 2021, 5:56 PM
bengotow accepted D8395: [dagit] Clean up feature flag code.

Ahh this looks great! Want to go ahead and merge this and i'll update the icons diff?

Jun 16 2021, 5:07 PM
bengotow requested review of D8394: [dagit] Switch to a new icon for jobs, limit overuse of pipeline icon.
Jun 16 2021, 3:21 PM
bengotow closed D8380: Move exploration of definitions to Graphs tab of Repository.
Jun 16 2021, 3:07 PM
bengotow committed R1:3ec5ccc8b885: Move exploration of definitions to Graphs tab of Repository (authored by bengotow).
Move exploration of definitions to Graphs tab of Repository
Jun 16 2021, 3:07 PM

Jun 15 2021

bengotow updated the diff for D8380: Move exploration of definitions to Graphs tab of Repository.
  • Fix title so composite solids look like graphs when in explorer is shown from /graphs/
  • Fix a few stray references to Pipelines in the workspcae repo explorer
  • Block access to the definition at the old paths, redirect to the overview (making overview the default)
  • Address diff feedback
Jun 15 2021, 10:04 PM
bengotow updated the diff for D8380: Move exploration of definitions to Graphs tab of Repository.

Rebase

Jun 15 2021, 9:48 PM
bengotow updated the diff for D8380: Move exploration of definitions to Graphs tab of Repository.
  • Address diff feedback
Jun 15 2021, 9:45 PM
bengotow planned changes to D8380: Move exploration of definitions to Graphs tab of Repository.
Jun 15 2021, 9:08 PM
bengotow accepted D8381: [dagit] Crag: Some nav tweaks.
Jun 15 2021, 8:35 PM
bengotow accepted D8384: [dagit] Crag: Job header.
Jun 15 2021, 8:32 PM
bengotow accepted D8379: [dagit] Upgrade Blueprint.
Jun 15 2021, 8:31 PM
bengotow updated the diff for D8380: Move exploration of definitions to Graphs tab of Repository.
  • Block access to the definition at the old paths, redirect to the overview (making overview the default)
Jun 15 2021, 5:02 PM
bengotow updated the diff for D8380: Move exploration of definitions to Graphs tab of Repository.
  • Fix title so composite solids look like graphs when in explorer is shown from /graphs/
  • Fix a few stray references to Pipelines in the workspcae repo explorer
Jun 15 2021, 4:48 PM
bengotow requested review of D8380: Move exploration of definitions to Graphs tab of Repository.
Jun 15 2021, 4:48 PM

Jun 14 2021

bengotow accepted D8363: [dagit] Crag: Flattened left nav jobs.

This looks great! I think the iconography + colors are nice and I'm a fan of not having the icons click through to the sensor / schedule pages. Ideally we'll just lift the valuable things off those pages onto the Job overview.

Jun 14 2021, 9:11 PM

Jun 10 2021

bengotow accepted D8316: [dagit] Crag: Add /jobs.

This looks good to me!

Jun 10 2021, 5:04 PM

Jun 4 2021

bengotow accepted D8247: [dagit] Fix mode-less pipeline paths.
Jun 4 2021, 6:18 PM

Jun 3 2021

bengotow closed D8212: Fix wrapping of SQL details displayed in the solid definition tab #4181.
Jun 3 2021, 10:02 PM
bengotow committed R1:9c9050a2c222: Fix wrapping of SQL details displayed in the solid definition tab #4181 (authored by bengotow).
Fix wrapping of SQL details displayed in the solid definition tab #4181
Jun 3 2021, 10:02 PM
bengotow accepted D8224: [dagit] Add a polling query for Run logs.

This looks great to me! Only other thing that occurs to me is that we also show streaming logs when you open a step's stderr | stdout panel from the bottom half of the run details view... I wonder if we need a similar fork over there?

Jun 3 2021, 6:59 PM
bengotow closed D8071: Present pipeline+mode as a tuple, lock pipeline mode in the playground.
Jun 3 2021, 6:56 PM
bengotow committed R1:6fa6f55179ea: Present pipeline+mode as a tuple, lock pipeline mode in the playground (authored by bengotow).
Present pipeline+mode as a tuple, lock pipeline mode in the playground
Jun 3 2021, 6:56 PM
bengotow accepted D8217: slow down RunGroupPanel refresh.
Jun 3 2021, 6:56 PM
bengotow updated the diff for D8071: Present pipeline+mode as a tuple, lock pipeline mode in the playground.
  • Test fixes
  • Merge branch 'master' of github.com:dagster-io/dagster into abg/pipelineandmode
Jun 3 2021, 2:31 PM
bengotow accepted D8205: [dagit] Clean up GraphQL mocks.
Jun 3 2021, 2:15 PM
bengotow requested review of D8212: Fix wrapping of SQL details displayed in the solid definition tab #4181.
Jun 3 2021, 2:11 PM
bengotow updated the diff for D8071: Present pipeline+mode as a tuple, lock pipeline mode in the playground.
  • Apply diff feedback
  • Use a React hook to upgrade old urls to include mode, wrap no-snapshot-id behavior in the same way
Jun 3 2021, 5:38 AM
bengotow planned changes to D8071: Present pipeline+mode as a tuple, lock pipeline mode in the playground.
Jun 3 2021, 4:45 AM

May 26 2021

bengotow added a comment to D8071: Present pipeline+mode as a tuple, lock pipeline mode in the playground.

Hey @alangenfeld! Let me double check that the URLs without the mode work as expected - we can definitely maintain backwards compatibility. The only other change in this diff that isn't feature-flagged is that places where both pipeline mode and snapshot are listed (I believe just the run details header) have changed from pipeline@snapshot:mode to pipeline:mode@snapshot. I think the old style was chosen because the snapshot reflects the pipeline and then mode applies configuration, but I think the entire thing should be clickable and pipeline:mode go to the pipeline overview page and @snapshot goes to the snapshot-in-time view of the pipeline. Depending on how long we want to leave this feature flagged it could make sense to make that conditional as well but it seemed minor.

May 26 2021, 2:50 AM

May 25 2021

bengotow abandoned D7980: Allow users to launch a backfill of the last pipeline partition set that generated an asset #3874.

Hey folks! I chatted with Sandy about this one and it sounds like we're all mostly in agreement that this doesn't reinforce a correct mental model of the system and we should probably omit this button and consider other ways to improve the linkage between assets and partition sets. Going to abandon this and follow up on the GH issue with the user!

May 25 2021, 9:21 PM

May 24 2021

bengotow requested review of D8071: Present pipeline+mode as a tuple, lock pipeline mode in the playground.
May 24 2021, 11:21 PM
bengotow accepted D8061: [dagit] Fix master (ts error).
May 24 2021, 8:36 PM
bengotow added a comment to D8061: [dagit] Fix master (ts error).

LGTM

May 24 2021, 8:36 PM
bengotow added a comment to D8048: [dagit] Track GanttChart mode in localStorage.

Patched this down and played with it a bit to make sure the useRefs are working properly, looks good to me!

May 24 2021, 8:01 PM
bengotow accepted D8048: [dagit] Track GanttChart mode in localStorage.
May 24 2021, 8:01 PM
bengotow accepted D8056: [dagit] Fix Asset view for empty asOf state.

Ahh good catch - this looks good to me

May 24 2021, 7:34 PM
bengotow accepted D8038: [dagit] Route config.
May 24 2021, 7:25 PM
bengotow accepted D8024: [dagit] Make better use of defaultMocks.

Looks good to me!

May 24 2021, 7:25 PM
bengotow accepted D7994: [dagit] Some Util cleanup.
May 24 2021, 7:25 PM
bengotow accepted D8011: [dagit] Strict TypeScript.

Wow this is more minimal than I would have expected actually!

May 24 2021, 7:24 PM

May 19 2021

bengotow requested review of D7980: Allow users to launch a backfill of the last pipeline partition set that generated an asset #3874.
May 19 2021, 4:06 AM

May 18 2021

bengotow accepted D7963: [dagit] Turn on eqeqeq lint rule.
May 18 2021, 4:19 PM
bengotow accepted D7889: [dagit] Extract AppCache to top level, consolidate TestProvider.

Looks good to me! Definitely like wrapping the containers into a TestProvider

May 18 2021, 2:49 PM

May 14 2021

bengotow accepted D7912: [dagit] Fix config nubs.
May 14 2021, 9:47 PM
bengotow accepted D7897: [dagit] Use Yarn v2.

Looks good to me and patches ok! Excited to give this a spin for a bit and see what else they've improved 🙌

May 14 2021, 9:47 PM
bengotow accepted D7881: [dagit] Delete src/main.
May 14 2021, 9:35 PM

May 10 2021

bengotow closed D7842: Fix regression in line height in asset history view #4156.
May 10 2021, 8:23 PM
bengotow committed R1:82ffbbd22b41: Fix regression in line height in asset history view #4156 (authored by bengotow).
Fix regression in line height in asset history view #4156
May 10 2021, 8:23 PM
bengotow accepted D7839: [dagit] Permissions.

This looks great! Exciting to see a permissions layer coming together. I think it'd be nice to try making a container component that applies the disabled + tooltip but it's pretty clean already with hook approach!

May 10 2021, 8:00 PM
bengotow requested review of D7842: Fix regression in line height in asset history view #4156.
May 10 2021, 7:58 PM
bengotow closed D7814: [dagit] Fix issue rendering Gantt for dynamic pipelines with a collect that has non-dynamic inputs.
May 10 2021, 4:06 PM
bengotow committed R1:4b94c856e248: [dagit] Fix issue rendering Gantt for dynamic pipelines with a collect that has… (authored by bengotow).
[dagit] Fix issue rendering Gantt for dynamic pipelines with a collect that has…
May 10 2021, 4:06 PM

May 7 2021

bengotow updated the summary of D7814: [dagit] Fix issue rendering Gantt for dynamic pipelines with a collect that has non-dynamic inputs.
May 7 2021, 9:06 PM
bengotow accepted D7810: [dagit] Add optional authorization header to HTTP requests.

Hmm I think this works for now because we're planning on using the authToken primarily to attribute runs, etc. to different users, but I think if we really wanted security we'd need to add auth to the websockets interface as well (or stop using it), right? I wonder if we should add a small comment in here explaining that there are still un-authorized GraphQL requests being made from the app in the few places we need websockets?

May 7 2021, 9:04 PM
bengotow accepted D7812: [dagit] Prepare to remove `main` file.
May 7 2021, 9:01 PM
bengotow accepted D7790: [dagit] Move everything out of __tests__.

Ahh yeah this will be much better! I'm not 100% sure when we started doing it the other way but I'm a fan of seeing them right next to the source in the file tree 👍

May 7 2021, 8:58 PM
bengotow updated the diff for D7814: [dagit] Fix issue rendering Gantt for dynamic pipelines with a collect that has non-dynamic inputs.

Add missing case triggered when run is half complete

May 7 2021, 8:57 PM
bengotow requested review of D7814: [dagit] Fix issue rendering Gantt for dynamic pipelines with a collect that has non-dynamic inputs.
May 7 2021, 8:43 PM
bengotow closed D7736: Add step contextual menus, url-persisted pagination to partition matrix.
May 7 2021, 8:34 PM
bengotow committed R1:74e2646ed7f4: Add step contextual menus, url-persisted pagination to partition matrix (authored by bengotow).
Add step contextual menus, url-persisted pagination to partition matrix
May 7 2021, 8:34 PM