Page MenuHomePhabricator

bengotow (Ben Gotow)
User

Projects

User does not belong to any projects.

User Details

User Since
May 9 2019, 3:45 PM (22 w, 4 d)

Recent Activity

Fri, Oct 11

bengotow accepted D1260: Add css ellipsis for run pipeline name.

This looks good to me! 👍

Fri, Oct 11, 3:54 PM

Wed, Oct 9

bengotow updated the summary of D1253: Revert "Revert "Consolidate split panel handling, save divider locations to local storage"".
Wed, Oct 9, 6:24 PM
bengotow added a reverting change for D1248: Revert "Consolidate split panel handling, save divider locations to local storage": D1253: Revert "Revert "Consolidate split panel handling, save divider locations to local storage"".
Wed, Oct 9, 6:22 PM
bengotow added a reverting change for R1:c77468e64ff2: Revert "Consolidate split panel handling, save divider locations to local…: D1253: Revert "Revert "Consolidate split panel handling, save divider locations to local storage"".
Wed, Oct 9, 6:22 PM
bengotow created D1253: Revert "Revert "Consolidate split panel handling, save divider locations to local storage"".
Wed, Oct 9, 6:22 PM

Tue, Oct 8

bengotow added inline comments to D1225: Preserve folded YAML sections in the config editor.
Tue, Oct 8, 8:24 PM
bengotow added a comment to D1225: Preserve folded YAML sections in the config editor.

Hey folks! re: complexity I sort of agree - I could move this to a separate file / plugin type of thing, but it's definitely less straightforward than I'd hoped. We could switch to just storing line numbers that are folded instead of YAML paths, but I think being able to move between tabs and have your folding preserved is kind of nice, and with just indexes we might apply the folding incorrectly and not know. (eg: "fold line 12" might result in something being incorrectly folded if the YAML had changed.)

Tue, Oct 8, 8:23 PM

Fri, Oct 4

bengotow created D1225: Preserve folded YAML sections in the config editor.
Fri, Oct 4, 10:55 PM
bengotow created D1216: Consolidate split panel handling, save divider locations to local storage.
Fri, Oct 4, 6:48 PM

Thu, Oct 3

bengotow updated the diff for D1189: Add Cancel and Delete menu items to the runs history view.
  • Fix out of sync Cancel.ts
Thu, Oct 3, 7:26 PM
bengotow created D1189: Add Cancel and Delete menu items to the runs history view.
Thu, Oct 3, 7:13 PM
bengotow updated the diff for D1150: Expose run filtering via GraphQL and implement pagination in Dagit.

Rebase

Thu, Oct 3, 6:00 PM
bengotow updated the summary of D1150: Expose run filtering via GraphQL and implement pagination in Dagit.
Thu, Oct 3, 5:51 PM
bengotow updated the diff for D1150: Expose run filtering via GraphQL and implement pagination in Dagit.
  • Add cursor stack for back-pagination, rename selector to PipelineRunsFilter
Thu, Oct 3, 5:50 PM
bengotow added inline comments to D1150: Expose run filtering via GraphQL and implement pagination in Dagit.
Thu, Oct 3, 5:42 PM
bengotow accepted D1170: Fix link to scheduled runs in dagit.

Looks great!

Thu, Oct 3, 4:45 PM
bengotow accepted D1172: bypass apollo for compute log subscriptions.
Thu, Oct 3, 4:38 PM

Wed, Oct 2

bengotow updated the summary of D1150: Expose run filtering via GraphQL and implement pagination in Dagit.
Wed, Oct 2, 10:49 PM
bengotow retitled D1150: Expose run filtering via GraphQL and implement pagination in Dagit from Expose run filtering via GraphQL and implement pagination in Dagit [wip] to Expose run filtering via GraphQL and implement pagination in Dagit.
Wed, Oct 2, 10:48 PM
bengotow updated the diff for D1150: Expose run filtering via GraphQL and implement pagination in Dagit.
  • Client-side pagination and server-side search, addition of pipelineRunTags root query
Wed, Oct 2, 10:40 PM
bengotow updated subscribers of D1150: Expose run filtering via GraphQL and implement pagination in Dagit.
Wed, Oct 2, 4:28 AM

Tue, Oct 1

bengotow accepted D1146: misc mode selector errors.

Looks good to me! I was seeing an exception on kwargs['mode'] so this should fix it 👍

Tue, Oct 1, 11:30 PM
bengotow created D1150: Expose run filtering via GraphQL and implement pagination in Dagit.
Tue, Oct 1, 11:26 PM
bengotow updated the diff for D1139: Fix misc GitHub issues related to Dagit UI.

Rebase

Tue, Oct 1, 8:31 PM
bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.

Rebase

Tue, Oct 1, 7:46 PM
bengotow created D1139: Fix misc GitHub issues related to Dagit UI.
Tue, Oct 1, 7:34 PM
bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.
  • Add missing type
Tue, Oct 1, 5:46 PM
bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.

Move the reloader interface to dagster-graphql, fix tests again

Tue, Oct 1, 4:39 PM
bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.
  • Make the reloader optional in create_app as well
Tue, Oct 1, 5:09 AM
bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.

Define a Reloader ABC in dagster core and move the implementation to Dagit, fix tests by making it optional

Tue, Oct 1, 4:46 AM

Mon, Sep 30

bengotow added inline comments to D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.
Mon, Sep 30, 10:08 PM
bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.

Replaces the window.reload() at the beginning of the refresh, which only worked when the React app was running on a separate port in dev mode, with a "soft reload" and a toast to let you know when the reload is complete.

Mon, Sep 30, 9:54 PM
bengotow updated the diff for D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.

Rebase on master to fix build(?)

Mon, Sep 30, 9:30 PM
bengotow updated the diff for D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.

Abstract custom subscription into DirectGraphQLSubscription, implement retries

Mon, Sep 30, 9:14 PM

Fri, Sep 27

bengotow added a comment to D1075: Initial pass at Dagit “Reload” button based on single watch file.

Hey @alangenfeld this should be ready to go now. I did some research and it looks like watchmedo only allows you to watch directories, not single files, which is why the watch dir is a separate temp directory with one file in it. I was afraid that if we watched the same folder that it uses as a fallback for DAGSTER_HOME, it'd be possible for it to hit the "too many files to watch" scenario again? Let me know what you think

Fri, Sep 27, 9:25 PM
bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.
  • Move reloading into a separate class given to the GraphQL layer
Fri, Sep 27, 9:22 PM
bengotow added inline comments to D1075: Initial pass at Dagit “Reload” button based on single watch file.
Fri, Sep 27, 9:17 PM
bengotow updated the diff for D1099: Fix GraphQL error when switching between pipelines with different modes.

Rename _open => _data

Fri, Sep 27, 6:24 PM
bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.
  • Address diff feedback
Fri, Sep 27, 6:23 PM
bengotow planned changes to D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.

Sounds good! I think handling reconnects is a good idea - will see if we can do that and pull the websocket impl out into a class for reuse.

Fri, Sep 27, 6:19 PM
bengotow added a comment to D1099: Fix GraphQL error when switching between pipelines with different modes.

No - renaming modes will be a separate fix, working on that one now!
Will put a better name on _open

Fri, Sep 27, 4:14 PM
bengotow updated the diff for D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.

Add file I forgot to commit

Fri, Sep 27, 3:20 PM
bengotow created D1099: Fix GraphQL error when switching between pipelines with different modes.
Fri, Sep 27, 3:19 PM
bengotow updated the summary of D1075: Initial pass at Dagit “Reload” button based on single watch file.
Fri, Sep 27, 2:57 PM
bengotow updated the diff for D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.

Sync pipeline run status changes back to Apollo
Rename and move types a bit

Fri, Sep 27, 2:49 PM
bengotow updated the summary of D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.
Fri, Sep 27, 6:12 AM
bengotow added inline comments to D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.
Fri, Sep 27, 6:09 AM
bengotow updated the diff for D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.

Remove extra graphql types, use debounce because smaller updates are smoother than infrequent large ones.

Fri, Sep 27, 6:05 AM
bengotow updated the summary of D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.
Fri, Sep 27, 6:01 AM
bengotow retitled D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders from Move log stream out of Apollo, memoize row contents and fix 2x cascading renders to Move log stream out of Apollo, memoize row contents and fix cascading renders.
Fri, Sep 27, 6:01 AM
bengotow created D1096: Move log stream out of Apollo, memoize row contents and fix cascading renders.
Fri, Sep 27, 5:45 AM
bengotow accepted D1090: [dagit] lazy subscription client.

Ran this locally and it looks good to me 👍

Fri, Sep 27, 2:24 AM
bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.
  • Basic diff feedback
  • Remove the loading spinner
  • Add to changelog
Fri, Sep 27, 2:15 AM

Thu, Sep 26

bengotow planned changes to D1075: Initial pass at Dagit “Reload” button based on single watch file.

Hey folks! I pushed up a few small changes to address the inline comments.

Thu, Sep 26, 10:37 PM

Mon, Sep 23

bengotow updated the diff for D1075: Initial pass at Dagit “Reload” button based on single watch file.

Fix tests, black formatting, snapshots

Mon, Sep 23, 3:06 PM
bengotow added inline comments to D1075: Initial pass at Dagit “Reload” button based on single watch file.
Mon, Sep 23, 2:44 PM
bengotow updated the summary of D1075: Initial pass at Dagit “Reload” button based on single watch file.
Mon, Sep 23, 2:40 PM
bengotow created D1075: Initial pass at Dagit “Reload” button based on single watch file.
Mon, Sep 23, 2:36 PM

Wed, Sep 18

bengotow updated the diff for D980: Move log-dervied stats to Python, expose via graphql as `run.stats`.

Ugh apparently I have to rebase and not merge master

Wed, Sep 18, 7:26 PM
bengotow updated the diff for D980: Move log-dervied stats to Python, expose via graphql as `run.stats`.
  • Merge branch 'master' into bengotow/-run-stats
Wed, Sep 18, 7:23 PM
bengotow added inline comments to D1057: Add a floating context panel to the Dagit config editor.
Wed, Sep 18, 7:17 PM
bengotow updated the summary of D1057: Add a floating context panel to the Dagit config editor.
Wed, Sep 18, 7:15 PM
bengotow created D1057: Add a floating context panel to the Dagit config editor.
Wed, Sep 18, 7:13 PM
bengotow updated the diff for D1044: Add re-execute to the pipeline runs dropdown menus.
  • Remove cancel
Wed, Sep 18, 7:09 PM
bengotow updated the diff for D980: Move log-dervied stats to Python, expose via graphql as `run.stats`.
  • Avoid Date.now, add better explanation of sort logic
  • Show number of steps out of total
  • Run check in PipelineRunStats constructor
Wed, Sep 18, 7:04 PM

Tue, Sep 17

bengotow updated the diff for D1044: Add re-execute to the pipeline runs dropdown menus.

Update the text labels after discussion with team

Tue, Sep 17, 6:24 PM
bengotow created D1044: Add re-execute to the pipeline runs dropdown menus.
Tue, Sep 17, 2:29 PM

Mon, Sep 16

bengotow updated the diff for D1029: Replace runs search bar with a nice autocompleting tokenized field.

Rebuild snapshot tests

Mon, Sep 16, 4:52 PM
bengotow added a comment to D1029: Replace runs search bar with a nice autocompleting tokenized field.

Good catch—I switched this over to using onFocus and onBlur on the input to manage the open / close state rather than inheriting behavior from the popover and that seems to work much better!

Mon, Sep 16, 4:51 PM
bengotow updated the diff for D1029: Replace runs search bar with a nice autocompleting tokenized field.

Rebase and address feedback

Mon, Sep 16, 4:50 PM

Sep 13 2019

bengotow created D1029: Replace runs search bar with a nice autocompleting tokenized field.
Sep 13 2019, 4:15 PM
bengotow updated the diff for D985: Basic implementation of search through run history.

Rebasing

Sep 13 2019, 4:04 PM
bengotow updated the diff for D985: Basic implementation of search through run history.

Make runId searchable, support /runs?q=<term> so nobody is copy-pasting runIds

Sep 13 2019, 2:58 PM
bengotow added inline comments to D980: Move log-dervied stats to Python, expose via graphql as `run.stats`.
Sep 13 2019, 2:25 PM
bengotow added a comment to D985: Basic implementation of search through run history.

Sure! Don't see why not. While I'm at it I'll make it so this search field can be populated from the query string - If there's some other place people are copy-pasting runIds from, it'd be cool to switch to a dagit link.

Sep 13 2019, 3:51 AM
bengotow planned changes to D980: Move log-dervied stats to Python, expose via graphql as `run.stats`.

Hmm, I'll see if we can pull the total number of steps - being able to show a total count rather than accumulating them as we go would be nice. I think we may be pulling the execution plan into the UI already so it's probably not a big leap.

Sep 13 2019, 3:49 AM
bengotow abandoned D943: Mock more of the GraphQL queries, add snapshot test for new runs page.

Sounds good! I think this snapshot testing isn't working out very well because the mock data for Dagit is very hard to generate / very large compared to your typical react application, and is still changing often enough that we need to be able to re-generate it or it'll fall out of sync with the actual runtime values pretty quickly. I'm going to abandon this and I'll see if we can start writing more component-level / panel-level tests that might require less sophisticated / more piece-meal mock data.

Sep 13 2019, 3:46 AM

Sep 9 2019

bengotow created D985: Basic implementation of search through run history.
Sep 9 2019, 10:32 PM
bengotow updated the diff for D980: Move log-dervied stats to Python, expose via graphql as `run.stats`.
  • Fix sort of runs with no start time
Sep 9 2019, 10:11 PM
bengotow updated the summary of D980: Move log-dervied stats to Python, expose via graphql as `run.stats`.
Sep 9 2019, 4:45 PM
bengotow created D980: Move log-dervied stats to Python, expose via graphql as `run.stats`.
Sep 9 2019, 4:43 PM

Sep 5 2019

bengotow updated the diff for D945: Add autocompletion of bool true/false values in config editor.

Switch to True/False

Sep 5 2019, 6:11 PM
bengotow added inline comments to D945: Add autocompletion of bool true/false values in config editor.
Sep 5 2019, 6:06 PM
bengotow updated the summary of D945: Add autocompletion of bool true/false values in config editor.
Sep 5 2019, 4:58 PM
bengotow created D945: Add autocompletion of bool true/false values in config editor.
Sep 5 2019, 4:57 PM
bengotow created D944: Fix the example use of `logdir` to be `log-dir`.
Sep 5 2019, 3:26 PM
bengotow created D943: Mock more of the GraphQL queries, add snapshot test for new runs page.
Sep 5 2019, 3:24 PM
bengotow added inline comments to D855: Create Scheduler UI in Dagit.
Sep 5 2019, 2:52 PM

Sep 3 2019

bengotow added a comment to D920: Fix hook issues, stop serializing modal contents to JSON.

Sounds good! The reason this exists vs. doing each dialog inline is just because the dialog doesn't animate open / closed unless it's container is in the DOM when it's open AND closed (set via the <Dialog isOpen={}> in this case). So if you're not careful, you can end up with scenarios where every single row of a table contains an invisible not-yet-opened dialog DOM tree (or you just lose the animation, which would be better).

Sep 3 2019, 9:15 PM
bengotow added inline comments to D920: Fix hook issues, stop serializing modal contents to JSON.
Sep 3 2019, 6:30 PM
bengotow created D920: Fix hook issues, stop serializing modal contents to JSON.
Sep 3 2019, 6:26 PM
bengotow updated the diff for D905: Upgrade apollo, switch to hooks where it increases readability.
  • Turn on React hooks eslint rules
Sep 3 2019, 5:39 PM
bengotow added a comment to D905: Upgrade apollo, switch to hooks where it increases readability.

Ahh good call re: React hooks eslint rules. I turned them on and verified that they work by breaking hooks rules in a few places. Very slick. Will wait for this build to pass and get this merged!

Sep 3 2019, 5:38 PM
bengotow accepted D909: force run view under pipeline in url namespace.

Just a few inline comments—nothing blocking!

Sep 3 2019, 5:30 PM

Aug 29 2019

bengotow updated the diff for D905: Upgrade apollo, switch to hooks where it increases readability.

Rebase

Aug 29 2019, 12:15 AM
bengotow created D905: Upgrade apollo, switch to hooks where it increases readability.
Aug 29 2019, 12:09 AM

Aug 28 2019

bengotow accepted D904: Fix black.
Aug 28 2019, 11:11 PM
bengotow updated the diff for D858: Overhauled run history view.
  • Update autogenerated types
Aug 28 2019, 11:01 PM
bengotow updated the diff for D858: Overhauled run history view.
  • Update app snapshot tests to reflect new page URLs
Aug 28 2019, 10:59 PM
bengotow updated the diff for D858: Overhauled run history view.
  • Update snapshot tests
  • Remove complexity from CustomAlertProvider in favor of passing a ReactNode
  • Change paths to /explore/<pipeline> instead of <pipeline>/explore
  • Remove occurrences of if \([^\)]*\)$ in the TS (two line no-bracket ifs)
  • Consolidat time and stepKey formatting to the same utils
  • Tick up the elapsed time when runs are in-flight
  • Rebase
  • Switch <StorageProvider> to a hook to clean up the redirect
  • Move the hack to a separate page to keep things really nice and clean
  • Move the hack out of the main pipeline execution page
  • Revert changes to apollo version
  • Fix item missing in package cache
  • Rebase on master
Aug 28 2019, 10:55 PM