- User Since
- May 9 2019, 3:45 PM (30 w, 3 d)
Fri, Dec 6
Removing weighting method
Disable weighting based on name similarity, update tests
Yeah that's a good point—I'll omit the edge weighting for now so we can push in the rest of these fixes. Long term it'd be kind of nice if users could choose between a couple graph layout algorithms but I agree this approach may work only for their DAG.
- Also fix issue with "black fill" appearing on external connection lines when viewing a composite (for unknown reason)
- Turn off "max per row" code intended to wrap long lines of solids into blocks, does not work well on new example
Thu, Dec 5
Remaining build failure is in dagster-airflow, not related to this diff. Going to merge this.
Fix additional TS issue not found locally
Update data provided to our tests to match new root queries
Update for linting
Will fix lint!
Oh interesting! Will check this out this afternoon—I wonder if TypeScript didn't catch usage of some of this data somehow.
Wed, Dec 4
Sat, Nov 30
Hmm I think the changed-configuration scenario currently breaks the retrieval of the pipeline entirely and the UI doesn't load? @alangenfeld / @schrockn I might need some context on how we should address that one—based on https://github.com/dagster-io/dagster/issues/1910, I assume we need to change the way runs are retrieved so that the config can be UnknownConfig? Although it seems it should still be viewable, just not re-used for execution. But without upfront interpretation, we wouldn't realize that the config was invalid until we tried to start execution with it, and wouldn't be able to disable the button in the UI.
Fri, Nov 29
Just a few drive-by comments on the JS!
Going to abandon this—I think we decided not to move forward with preserving folding.
Update snapshot tests
(Edit: I tried rolling the SolidSelector's query up into the parent so that these would all load at once, and only afterwards realized that these need to be separate because the SolidSelector loads the whole pipeline, not the pipeline scoped down to the solid subset which is used by the rest of the interface.) I think we'll need to save a broader refactor of this for a little later.
Hey! I updated this to include a comment and removed the spinner that I added to the Mode picker.
- add a comment, remove the spinners in favor of default no-data appearance
Thu, Nov 28
Tue, Nov 19
- Add a few tests - we should probably add Enzyme soon
Oct 29 2019
- Make ordering of solids in usedSolids query deterministic
- Address diff feedback
- Add solid explorer snapshot test, fix other tests, rebase
Oh this is super excellent, excited to do some perf work on top of this!
Oct 25 2019
Oct 24 2019
Rebase and fix black
Hey! I think if the design feedback is minor it's ready for a full review - if we end up changing the UI we can hold off on that, but I'd love to get your eyes on the python side now. I pieced together the graphql resolver a bit and that stuff is probably not ideal.
Oct 11 2019
This looks good to me! 👍
Oct 9 2019
Oct 8 2019
Hey folks! re: complexity I sort of agree - I could move this to a separate file / plugin type of thing, but it's definitely less straightforward than I'd hoped. We could switch to just storing line numbers that are folded instead of YAML paths, but I think being able to move between tabs and have your folding preserved is kind of nice, and with just indexes we might apply the folding incorrectly and not know. (eg: "fold line 12" might result in something being incorrectly folded if the YAML had changed.)
Oct 4 2019
Oct 3 2019
- Fix out of sync Cancel.ts
- Add cursor stack for back-pagination, rename selector to PipelineRunsFilter
Oct 2 2019
- Client-side pagination and server-side search, addition of pipelineRunTags root query
Oct 1 2019
Looks good to me! I was seeing an exception on kwargs['mode'] so this should fix it 👍
- Add missing type
Move the reloader interface to dagster-graphql, fix tests again
- Make the reloader optional in create_app as well
Define a Reloader ABC in dagster core and move the implementation to Dagit, fix tests by making it optional
Sep 30 2019
Replaces the window.reload() at the beginning of the refresh, which only worked when the React app was running on a separate port in dev mode, with a "soft reload" and a toast to let you know when the reload is complete.
Rebase on master to fix build(?)
Abstract custom subscription into DirectGraphQLSubscription, implement retries
Sep 27 2019
Hey @alangenfeld this should be ready to go now. I did some research and it looks like watchmedo only allows you to watch directories, not single files, which is why the watch dir is a separate temp directory with one file in it. I was afraid that if we watched the same folder that it uses as a fallback for DAGSTER_HOME, it'd be possible for it to hit the "too many files to watch" scenario again? Let me know what you think
- Move reloading into a separate class given to the GraphQL layer
Rename _open => _data
- Address diff feedback
Sounds good! I think handling reconnects is a good idea - will see if we can do that and pull the websocket impl out into a class for reuse.
No - renaming modes will be a separate fix, working on that one now!
Will put a better name on _open
Add file I forgot to commit
Sync pipeline run status changes back to Apollo
Rename and move types a bit