Cleanup & Update tests

Ahh @alangenfeld that's a good question—for the serial execution engine displaying the dependency graph isn't quite what we want. Could we make the execution plan to include the order it plans to execute steps? Right now the plan doesn't encode enough information for us to know what the true parallelism / timing will look like (at least I don't think?) We could detect the serial execution engine and show them in a waterfall, but we might get the order wrong I think?

• Use fewer large nested functions in Gaant layout code

Comment Gaant layout algo

Hmm that's a good point re: partially invalid queries — it seems every portion of the query should be required to match at least one solid. Until we can display errors in context in the field, we should probably err on the side of it being valid though.

• Allow space as a delimiter in query syntax
• Only allow user to submit dialog when the query is valid
• Blur the active field when firing a shortcut so the query is committed

Re: Is there somewhere on the screen where we can put the "Alt" hint for discovering shortcuts? Pretty hard to figure out. - let's try to put it on the new home page near the bottom, I think that screen will have an empty corner or two.

• Prevent shortcuts from re-rendering children on on/off
• Merge branch 'master' of github.com:dagster-io/dagster into sfbg/layout-overhaul

Hey hey! Rebasing this now. I initially tried for Alt-Enter, but if a dialog appears letting you know that the run could not be started / config had errors, Alt-Enter also closes the dialog so it usually just flickers. I think we could bind the event to the keyup phase of the Alt-Enter shortcut, will look and see.

• Bind Alt-G to the Start button
• Fix broken Alt-S binding in Explore tab

• Prevent shortcuts from re-rendering children on on/off

• Prevent shortcuts from sticking if you tab away from the window

Ok sounds good to me then 😉

• Fix spelling
• Switch shortcuts to Opt-S and Opt-P so they work when you’re in the text editor
• Allow you to navigate via keyboard Alt-1, Alt-2, Alt-3 through left hand tabs
• Schedule / Scheduler => Schedules

This looks good to me, just added some comments and suggestions inline. Nothing super big!

The client side of this LGTM! Will resign and let someone take a look at the python, which looks quite a bit above my pay grade 😅

New config picker needs to pass pipeline name to new sessions

Rebase

• Cleanup of diff

• Remove immer
• Update specs

• Revert previous check for metadata presence
• Update RunMetadataProvider to be less dependent on event ordering

Hey @max! Ok - so I think that this is happening because we are receiving events out of order somehow, or otherwise missing the ExecutionStepStartEvent for a given step. It looks like if we receive a ExecutionStepFailureEvent with no preceding ExecutionStepStartEvent event, the execution plan step metadata (the object containing the materializations) gets initialized like this:

Ahh good catch! 👍

The JS side of this looks great to me—the only thing is that the introduction of state in the ConfigEditorConfigPicker might introduce some /slightly/ weird behavior because the state isn't saved per-tab. I think that if you switch tabs, the partition picker may remain present (or it may disappear and upon returning to a previous tab still be gone. I'm not sure which direction it will fail in offhand.)

Only enable in non-minified mode

Sounds good! I agree re: zoomed out view - you get an extra word or two but even that typically gets clipped rendering it largely useless.

Hey @prha — I did a search for styled. and went through the whole project to check that we have the ; in place now. I think this should be exhaustive!

This looks great. My only comment is that it's a bit strange that the component for the right hand side of the page is called SolidSidebar since it's the larger portion of the screen. I know it sort of inherited that naming because it re-uses the SidebarSolidDefinition component, but maybe we could call it SolidDetailContainer or something like that...

Good call—I think this naming is much more clear.

I'd defer to @alangenfeld but this looks great! Approved but with a couple inline comments - would definitely be good to double check and make sure the caching is working the way we intend.

Rebase

Fix tests

• Add "(Upcoming)"

Pushing up fixes now, thanks for the review @alangenfeld!

• Address PR feedback

This looks good 👍 I'm not sure how you're planning on structuring the webworker sources on the filesystem, but it might make sense to have a graph-worker folder (or something similar) for this dagre layout code so we can make it super clear that it's targeting a different JS context.

This looks great to me. I actually think we may want to double-down on this PipelineGraphContainer and move a bit more of the state down into it in a subsequent diff. I've been looking in to how we would "stack" viewports rather than replacing the viewport as you drill down into composites, and it's becoming clear that we need the state of each layer to be owned in a container rather than at the top. At any rate, seems like it'd build on this nicely.

Looks good to me! I feel like every project grows until there's a DOMUtils / Utils / DebugUtils, etc, but this seems like the correct approach here 😂

This looks good to me! I'm surprised this failed to build but you probably just need to run make generate-types.

• Perform substring matching in solid queries, still autocomplete to full names
• Move the filter bar to the bottom
• Automatically center the selected solid at all times

• Put the solid jump bar back
• Perform substring matching in solid queries, still autocomplete to full names

• Turn off this new feature in composites, since we are unable to save state at each layer and it was causing you to pop "up" to an empty view.
• Mark the root nodes as the DAG's "focus" and highlight them in blue for better visualization

LGTM!

Update changelog

Add new bar, put highlighting back, polish

Oh man this looks great to me. Really glad we were able to get innerTypes out of here and the new interfaces for the ConfigTypeSchema component look great. Ship it!

Removing weighting method

Disable weighting based on name similarity, update tests

Yeah that's a good point—I'll omit the edge weighting for now so we can push in the rest of these fixes. Long term it'd be kind of nice if users could choose between a couple graph layout algorithms but I agree this approach may work only for their DAG.

• Also fix issue with "black fill" appearing on external connection lines when viewing a composite (for unknown reason)
• Turn off "max per row" code intended to wrap long lines of solids into blocks, does not work well on new example

Remaining build failure is in dagster-airflow, not related to this diff. Going to merge this.

Fix additional TS issue not found locally

Update data provided to our tests to match new root queries

Update for linting

Will fix lint!

Oh interesting! Will check this out this afternoon—I wonder if TypeScript didn't catch usage of some of this data somehow.