Page MenuHomePhabricator

bengotow (Ben Gotow)
User

Projects

User does not belong to any projects.

User Details

User Since
May 9 2019, 3:45 PM (61 w, 2 d)

Recent Activity

Thu, Jul 9

bengotow accepted D3811: toggle partitions on shift-click.

Wow this is slick and the code looks good to me. I don't know if folks will guess that this interaction exists, so we may need to put a tooltip / meta text somewhere on the page so folks know to use it. (I feel like we need one of those "Loading..." banners with a Top Hat Dagster telling you tricks)

Thu, Jul 9, 5:19 AM

Tue, Jul 7

bengotow requested review of D3794: Fix a Gaant chart layout issue with unstarted steps appearing at x=0.
Tue, Jul 7, 7:22 PM
bengotow closed D3760: Allow Dagit to be mounted at a path via new `—path` CLI param.
Tue, Jul 7, 6:51 PM
bengotow committed R1:3f990af3391c: Allow Dagit to be mounted at a path via new `—path` CLI param (authored by bengotow).
Allow Dagit to be mounted at a path via new `—path` CLI param
Tue, Jul 7, 6:51 PM
bengotow updated the diff for D3760: Allow Dagit to be mounted at a path via new `—path` CLI param.

Add tests for Dagit path prefix feature

Tue, Jul 7, 4:05 PM
bengotow planned changes to D3760: Allow Dagit to be mounted at a path via new `—path` CLI param.
Tue, Jul 7, 3:34 PM
bengotow committed R1:b49c59764d1d: Rename EnvironmentPicker to RepositoryPicker (authored by bengotow).
Rename EnvironmentPicker to RepositoryPicker
Tue, Jul 7, 3:33 PM
bengotow closed D3707: Rename EnvironmentPicker to RepositoryPicker.
Tue, Jul 7, 3:33 PM
bengotow updated the diff for D3760: Allow Dagit to be mounted at a path via new `—path` CLI param.

Need to tie VSCode to Black

Tue, Jul 7, 2:10 PM
bengotow requested review of D3707: Rename EnvironmentPicker to RepositoryPicker.
Tue, Jul 7, 12:53 AM
bengotow accepted D3778: fix run pagination.

Oh wow sorry I didn't catch this when I put this together, I guess this instanceof Array check guarded against a typescript error here... looks great to me 👍

Tue, Jul 7, 12:39 AM
bengotow updated the diff for D3760: Allow Dagit to be mounted at a path via new `—path` CLI param.

Apply diff feedback

Tue, Jul 7, 12:33 AM
bengotow planned changes to D3760: Allow Dagit to be mounted at a path via new `—path` CLI param.
Tue, Jul 7, 12:29 AM

Mon, Jul 6

bengotow requested review of D3760: Allow Dagit to be mounted at a path via new `—path` CLI param.
Mon, Jul 6, 8:58 PM

Thu, Jul 2

bengotow accepted D3745: [dagit] show repository on scoped schedule view.

Looks great!

Thu, Jul 2, 7:13 PM

Tue, Jun 30

bengotow committed R1:96541d816ddd: Wrap ts, tsx files at 100 characters for better readability (authored by bengotow).
Wrap ts, tsx files at 100 characters for better readability
Tue, Jun 30, 8:48 PM
bengotow closed D3704: Wrap ts, tsx files at 100 characters for better readability.
Tue, Jun 30, 8:48 PM
bengotow added a comment to D3704: Wrap ts, tsx files at 100 characters for better readability.

lolo omg that gif

Tue, Jun 30, 8:43 PM
bengotow committed R1:1023d6949ac2: Pipeline-scoped runs tab, cleaner cursor-paginated query utils (authored by bengotow).
Pipeline-scoped runs tab, cleaner cursor-paginated query utils
Tue, Jun 30, 8:42 PM
bengotow closed D3671: Pipeline-scoped runs tab, cleaner cursor-paginated query utils.
Tue, Jun 30, 8:42 PM
bengotow added inline comments to D3671: Pipeline-scoped runs tab, cleaner cursor-paginated query utils.
Tue, Jun 30, 8:38 PM
bengotow updated the diff for D3671: Pipeline-scoped runs tab, cleaner cursor-paginated query utils.

Lock the current pipeline tag into the filter bar on the pipeline runs page

Tue, Jun 30, 8:36 PM
bengotow committed R1:3c91af4d7e2a: Improve behavior of the Enter key in the Dagit pipeline sidebar #2572 (authored by bengotow).
Improve behavior of the Enter key in the Dagit pipeline sidebar #2572
Tue, Jun 30, 6:43 PM
bengotow closed D3705: Improve behavior of the Enter key in the Dagit pipeline sidebar #2572.
Tue, Jun 30, 6:43 PM
bengotow updated the diff for D3671: Pipeline-scoped runs tab, cleaner cursor-paginated query utils.

Fix typo, add comments detailing new React hooks

Tue, Jun 30, 6:42 PM
bengotow requested review of D3704: Wrap ts, tsx files at 100 characters for better readability.
Tue, Jun 30, 6:34 PM
bengotow added a comment to D3706: [dagit] ENVIRONMENT -> REPOSITORY.

We probably should rename EnvironmentPicker but I can do it later today if that's easier, will require rebuilding the snapshots etc.

Tue, Jun 30, 6:06 PM
bengotow accepted D3706: [dagit] ENVIRONMENT -> REPOSITORY.
Tue, Jun 30, 6:06 PM
bengotow requested review of D3705: Improve behavior of the Enter key in the Dagit pipeline sidebar #2572.
Tue, Jun 30, 4:02 PM

Fri, Jun 26

bengotow requested review of D3671: Pipeline-scoped runs tab, cleaner cursor-paginated query utils.
Fri, Jun 26, 11:57 PM

Tue, Jun 23

bengotow committed R1:33840c747350: Rebuild the launch execution button for easier maintenance (authored by bengotow).
Rebuild the launch execution button for easier maintenance
Tue, Jun 23, 3:29 AM
bengotow closed D3469: Rebuild the launch execution button for easier maintenance.
Tue, Jun 23, 3:28 AM
bengotow updated the diff for D3469: Rebuild the launch execution button for easier maintenance.

Rebase

Tue, Jun 23, 12:58 AM

Fri, Jun 19

bengotow accepted D3568: Show full error and stack trace on launch errors.

Looks great let's ship it!

Fri, Jun 19, 8:12 PM
bengotow requested review of D3569: Add location reload button when supported, keyboard nav in sidebar.
Fri, Jun 19, 7:16 PM
bengotow updated the diff for D3469: Rebuild the launch execution button for easier maintenance.

Rename PipelineExecutionButtonGroup > LaunchRootExecutionButton

Fri, Jun 19, 3:57 PM
bengotow added inline comments to D3469: Rebuild the launch execution button for easier maintenance.
Fri, Jun 19, 3:54 PM
bengotow accepted D3551: add padding to the end of the run logs.
Fri, Jun 19, 3:48 PM
bengotow added a comment to D3519: Reload support for new architecture.

This looks good to me, I will add on the front-end UI today!

Fri, Jun 19, 3:48 PM

Wed, Jun 17

bengotow committed R1:457e12748f2c: Fix wild recursion in execution plan for fan-in-out, avoid offset lines unless… (authored by bengotow).
Fix wild recursion in execution plan for fan-in-out, avoid offset lines unless…
Wed, Jun 17, 4:45 PM
bengotow closed D3534: Fix wild recursion in execution plan for fan-in-out, avoid offset lines unless necessary.
Wed, Jun 17, 4:45 PM
bengotow requested review of D3534: Fix wild recursion in execution plan for fan-in-out, avoid offset lines unless necessary.
Wed, Jun 17, 6:40 AM

Tue, Jun 16

bengotow planned changes to D3469: Rebuild the launch execution button for easier maintenance.
Tue, Jun 16, 6:33 PM

Jun 12 2020

bengotow requested review of D3469: Rebuild the launch execution button for easier maintenance.
Jun 12 2020, 5:36 AM

Jun 11 2020

bengotow committed R1:159ce3cb9908: Switch more places to use `pipelineName`, improve loading of RunGroup (authored by bengotow).
Switch more places to use `pipelineName`, improve loading of RunGroup
Jun 11 2020, 10:49 PM
bengotow closed D3464: Switch more places to use `pipelineName`, improve loading of RunGroup.
Jun 11 2020, 10:49 PM
bengotow updated the diff for D3464: Switch more places to use `pipelineName`, improve loading of RunGroup.
  • Fix missing arg forwarding
Jun 11 2020, 10:34 PM
bengotow updated the diff for D3464: Switch more places to use `pipelineName`, improve loading of RunGroup.
  • Make “starting” state work in re-execute button [temporary fix]
Jun 11 2020, 10:02 PM
bengotow committed R1:462b57c615aa: Move schedules tab to repository scope (authored by bengotow).
Move schedules tab to repository scope
Jun 11 2020, 9:54 PM
bengotow closed D3460: Move schedules tab to repository scope.
Jun 11 2020, 9:54 PM
bengotow requested review of D3460: Move schedules tab to repository scope.
Jun 11 2020, 9:43 PM
bengotow requested review of D3464: Switch more places to use `pipelineName`, improve loading of RunGroup.
Jun 11 2020, 9:26 PM
bengotow accepted D3462: do not load snapshot to fetch name.
Jun 11 2020, 9:00 PM
bengotow accepted D3459: set default solid selection for query selector.

Looks good to me! I think originally we defaulted to "" instead of "*" because on large pipelines we wanted to make you type * explicitly and not try to render that subset immediately. I'm not sure that that is still necessary / an issue.

Jun 11 2020, 8:19 PM

Jun 10 2020

bengotow committed R1:6ca4c541d8fc: Fix log tailing behavior, broken by initial load of empty state instead of list… (authored by bengotow).
Fix log tailing behavior, broken by initial load of empty state instead of list…
Jun 10 2020, 3:07 PM
bengotow closed D3374: Fix log tailing behavior, broken by initial load of empty state instead of list #2487.
Jun 10 2020, 3:07 PM
bengotow committed R1:295decd98f01: Dagit should take you to the default page for a repo after selection #2554 (authored by bengotow).
Dagit should take you to the default page for a repo after selection #2554
Jun 10 2020, 3:07 PM
bengotow closed D3369: Dagit should take you to the default page for a repo after selection #2554.
Jun 10 2020, 3:07 PM
bengotow committed R1:6beb34829cd2: Overhaul GraphQL query hierarchy in playground for perf and loading states (authored by bengotow).
Overhaul GraphQL query hierarchy in playground for perf and loading states
Jun 10 2020, 3:06 PM
bengotow closed D3393: Overhaul GraphQL query hierarchy in playground for perf and loading states.
Jun 10 2020, 3:06 PM
bengotow requested review of D3393: Overhaul GraphQL query hierarchy in playground for perf and loading states.
Jun 10 2020, 4:42 AM

Jun 9 2020

bengotow requested review of D3374: Fix log tailing behavior, broken by initial load of empty state instead of list #2487.
Jun 9 2020, 7:10 PM
bengotow requested review of D3369: Dagit should take you to the default page for a repo after selection #2554.
Jun 9 2020, 6:42 PM

Jun 5 2020

bengotow accepted D3266: add another site to pass repository information to execution params.
Jun 5 2020, 5:28 AM
bengotow added inline comments to D3266: add another site to pass repository information to execution params.
Jun 5 2020, 5:28 AM
bengotow committed R1:ee05ea9fcbbb: Dagit should truncate long pipeline/solid names #2421 (authored by bengotow).
Dagit should truncate long pipeline/solid names #2421
Jun 5 2020, 3:23 AM
bengotow closed D3229: Dagit should truncate long pipeline/solid names #2421.
Jun 5 2020, 3:22 AM

Jun 4 2020

bengotow updated the diff for D3229: Dagit should truncate long pipeline/solid names #2421.
  • Rebase and update tests
Jun 4 2020, 5:21 PM
bengotow accepted D3272: Fix use-less escape eslint error.

Whoops good catch.

Jun 4 2020, 5:01 PM
bengotow added a comment to D3229: Dagit should truncate long pipeline/solid names #2421.

Will rebuild snapshots and land this, thanks for the review folks 👍

Jun 4 2020, 4:14 PM

Jun 3 2020

bengotow committed R1:095235a3015c: Run groupings in the pipeline run UI, improved Runs table (authored by bengotow).
Run groupings in the pipeline run UI, improved Runs table
Jun 3 2020, 6:12 PM
bengotow closed D3174: Run groupings in the pipeline run UI, improved Runs table.
Jun 3 2020, 6:12 PM
bengotow accepted D3235: remove start execution button.

This looks great to me! Just want to make sure we don't need the run launcher existence check anymore.

Jun 3 2020, 5:15 PM
bengotow updated the summary of D3229: Dagit should truncate long pipeline/solid names #2421.
Jun 3 2020, 3:51 PM
bengotow updated the diff for D3229: Dagit should truncate long pipeline/solid names #2421.
  • Also apply tooltip to solid column in the logs viewer
Jun 3 2020, 3:51 PM
bengotow committed R1:af6ee067b8e2: Consolidate use of custom alert provider, fix overflow in long errors #2359 (authored by bengotow).
Consolidate use of custom alert provider, fix overflow in long errors #2359
Jun 3 2020, 3:11 PM
bengotow closed D3228: Consolidate use of custom alert provider, fix overflow in long errors #2359.
Jun 3 2020, 3:11 PM
bengotow updated the summary of D3174: Run groupings in the pipeline run UI, improved Runs table.
Jun 3 2020, 2:46 PM
bengotow updated the diff for D3174: Run groupings in the pipeline run UI, improved Runs table.

Remove the solid subset display from the runs list for now, will revisit in follow-up diff that unifies the presentation across the runs list and run group display.

Jun 3 2020, 2:45 PM
bengotow committed R1:7005e4de832d: Fix yaml syntax highlighting of unquoted strings #2409 (authored by bengotow).
Fix yaml syntax highlighting of unquoted strings #2409
Jun 3 2020, 2:40 PM
bengotow closed D3232: Fix yaml syntax highlighting of unquoted strings #2409.
Jun 3 2020, 2:40 PM

Jun 2 2020

bengotow accepted D3224: remove dagit reloading.

Looks good - just as a sanity check, the idea is that making the graphQL queries again will always return the latest data from the python files on disk, so to reload dagit you'd just refresh the page in your browser the old-school way?

Jun 2 2020, 9:48 PM
bengotow requested review of D3228: Consolidate use of custom alert provider, fix overflow in long errors #2359.
Jun 2 2020, 9:21 PM
bengotow committed R1:cf67844dd6de: Redirect user to safety if they navigate to an invalid explorer path #2226 (authored by bengotow).
Redirect user to safety if they navigate to an invalid explorer path #2226
Jun 2 2020, 9:14 PM
bengotow closed D3220: Redirect user to safety if they navigate to an invalid explorer path #2226.
Jun 2 2020, 9:14 PM
bengotow added a comment to D3220: Redirect user to safety if they navigate to an invalid explorer path #2226.

Hmm will circle back on testing this - I think that we could create a snapshot test that renders an invalid URL and then checks that the post-redirected content is displayed, but something like that is so high level it's likely it'd break and someone would just "update the snapshots" to reflect the broken output. Really needs to be a hand written test I think and we need some more fixtures for those.

Jun 2 2020, 9:12 PM
bengotow updated the summary of D3229: Dagit should truncate long pipeline/solid names #2421.
Jun 2 2020, 9:07 PM
bengotow updated the diff for D3229: Dagit should truncate long pipeline/solid names #2421.
  • Allow custom (zero-delay) tooltips via a global handler for data-tooltip, with support for custom styling (eg: pipeline sidebar) via data-tooltip-style={}
Jun 2 2020, 9:04 PM
bengotow requested review of D3232: Fix yaml syntax highlighting of unquoted strings #2409.
Jun 2 2020, 8:08 PM
bengotow requested review of D3229: Dagit should truncate long pipeline/solid names #2421.
Jun 2 2020, 7:01 PM
bengotow requested review of D3220: Redirect user to safety if they navigate to an invalid explorer path #2226.
Jun 2 2020, 3:55 PM

May 29 2020

bengotow requested review of D3174: Run groupings in the pipeline run UI, improved Runs table.
May 29 2020, 9:17 PM
bengotow accepted D3170: persist solid selection throught dagit in tags.

Looks good!

May 29 2020, 8:48 PM

May 27 2020

bengotow accepted D3118: [graphql-environment-4] use pipeline selector for pipelineOrError.

Looks good to me!

May 27 2020, 4:40 PM
bengotow accepted D3117: [graphql-environment-3] replace pipeline name context with environment context provider.

This looks good to me! Nothing blocking just a few minor nits.

May 27 2020, 4:17 PM
bengotow accepted D3104: [graphql-environment-1] rename PipelineSelector to PipelineExplorerPath.

This looks good to me! I think PipelineExplorerPath is a good name and I like that it specifically references that it appears in the URL path 👍

May 27 2020, 4:04 PM

May 20 2020

bengotow accepted D2997: Create pipeline overview landing page.

This looks awesome and the JS is super clean. Glad you were able to export the RunActionsMenu, etc to share them. let's merge! 👍

May 20 2020, 9:02 PM
bengotow committed R1:691248836c4f: Formalize dagit "pipeline scope" with "Overview", "Definition", "Playground"… (authored by bengotow).
Formalize dagit "pipeline scope" with "Overview", "Definition", "Playground"…
May 20 2020, 8:57 PM
bengotow closed D2994: Formalize dagit "pipeline scope" with "Overview", "Definition", "Playground" tabs.
May 20 2020, 8:57 PM
bengotow updated the diff for D2994: Formalize dagit "pipeline scope" with "Overview", "Definition", "Playground" tabs.

Rebase

May 20 2020, 8:57 PM