Page MenuHomePhabricator

bengotow (Ben Gotow)
User

Projects

User does not belong to any projects.

User Details

User Since
May 9 2019, 3:45 PM (71 w, 3 d)

Recent Activity

Fri, Sep 18

bengotow added a reviewer for D3882: Make re-execute a two-part button so it’s one-click by default #2687: yuhan.
Fri, Sep 18, 2:54 PM
bengotow updated the diff for D3882: Make re-execute a two-part button so it’s one-click by default #2687.

Rebase, remove .py file merged in the wrong direction

Fri, Sep 18, 2:54 PM
bengotow updated the diff for D3882: Make re-execute a two-part button so it’s one-click by default #2687.

Rebase, CI is angry

Fri, Sep 18, 4:03 AM
bengotow updated the summary of D3882: Make re-execute a two-part button so it’s one-click by default #2687.
Fri, Sep 18, 2:55 AM
bengotow updated the summary of D3882: Make re-execute a two-part button so it’s one-click by default #2687.
Fri, Sep 18, 2:51 AM
bengotow updated the diff for D3882: Make re-execute a two-part button so it’s one-click by default #2687.

Updates based on feedback

Fri, Sep 18, 2:38 AM

Thu, Aug 27

bengotow committed R1:7ad77f640bc6: Add timezone picker to Dagit, make all timestamps timezone-aware (authored by bengotow).
Add timezone picker to Dagit, make all timestamps timezone-aware
Thu, Aug 27, 9:12 PM
bengotow closed D4276: Add timezone picker to Dagit, make all timestamps timezone-aware.
Thu, Aug 27, 9:12 PM
bengotow updated the diff for D4276: Add timezone picker to Dagit, make all timestamps timezone-aware.
  • Add a note re: scheduler cron strings not using timezone
Thu, Aug 27, 9:11 PM
bengotow updated the diff for D4276: Add timezone picker to Dagit, make all timestamps timezone-aware.
  • Remove notes file
Thu, Aug 27, 8:50 PM
bengotow updated the diff for D4276: Add timezone picker to Dagit, make all timestamps timezone-aware.
  • Fix “13:41pm” issue and RunTime using tz=Automatic
Thu, Aug 27, 8:45 PM

Tue, Aug 25

bengotow added a reviewer for D4276: Add timezone picker to Dagit, make all timestamps timezone-aware: sashank.
Tue, Aug 25, 3:03 AM
bengotow requested review of D4276: Add timezone picker to Dagit, make all timestamps timezone-aware.
Tue, Aug 25, 1:44 AM
bengotow committed R1:0a21f70a9bac: Fix minor box colorization issues on the new partition matrix (authored by bengotow).
Fix minor box colorization issues on the new partition matrix
Tue, Aug 25, 1:15 AM
bengotow closed D4273: Fix minor box colorization issues on the new partition matrix.
Tue, Aug 25, 1:15 AM

Mon, Aug 24

bengotow requested review of D4273: Fix minor box colorization issues on the new partition matrix.
Mon, Aug 24, 8:51 PM

Aug 21 2020

bengotow accepted D4249: Rewrite the backfill selector to match the run selector.

This looks great - definitely good to re-use the same elements in both places. Ship it!

Aug 21 2020, 3:03 PM

Aug 18 2020

bengotow committed R1:f4a67156b2ce: Patition run matrix for schedule+solid execution history (authored by bengotow).
Patition run matrix for schedule+solid execution history
Aug 18 2020, 9:34 PM
bengotow closed D4090: Patition run matrix for schedule+solid execution history.
Aug 18 2020, 9:34 PM
bengotow updated the diff for D4090: Patition run matrix for schedule+solid execution history.
  • Add a small shift click note
Aug 18 2020, 9:33 PM
bengotow updated the diff for D4090: Patition run matrix for schedule+solid execution history.
  • Time slice bar, colorization of age of runs
  • Default to 30 partitions, add 120 partition option
  • Move the partition run matrix to the top
Aug 18 2020, 7:18 PM
bengotow planned changes to D4090: Patition run matrix for schedule+solid execution history.
Aug 18 2020, 7:16 PM

Aug 17 2020

bengotow added reviewers for D4090: Patition run matrix for schedule+solid execution history: prha, schrockn, alangenfeld.
Aug 17 2020, 4:00 PM
bengotow accepted D4198: [partition-backfill-6] ui for partitions backfill.

Ahh this looks awesome! Really love this top level partition tab within the pipeline scope. From a UI perspective, I feel like "Launch Patition Backfill" should be a big button that takes you to the three panels (on a separate page or within a big modal?) but I like the idea of enabling selection directly on top of the matrix UI since it'll be familiar to the user already.

Aug 17 2020, 3:34 PM

Aug 11 2020

bengotow requested review of D4090: Patition run matrix for schedule+solid execution history.
Aug 11 2020, 6:48 PM

Aug 4 2020

bengotow accepted D4080: (instance-scheduler-1) Update sidebar navigation for schedules.

I really like this. With schedules getting so many cool features I think they deserve more top level representation.

Aug 4 2020, 9:30 PM
bengotow accepted D3978: RFC: add origin information into the repository picker.

This looks great to me 👍 I feel like the metadata approach gives this a lot of flexibility and the code looks clean. I think we can tweak the visual appearance a bit but the ideal styling sort of depends on how many options end up appearing in that menu in the common case, so it might be best to wait and see how this gets used!

Aug 4 2020, 6:34 PM

Jul 23 2020

bengotow added inline comments to D3978: RFC: add origin information into the repository picker.
Jul 23 2020, 2:59 PM

Jul 20 2020

bengotow committed R1:77a084ff9f8a: Enable multi-selection (+cancel +deletion) of runs in the runs list #2661 (authored by bengotow).
Enable multi-selection (+cancel +deletion) of runs in the runs list #2661
Jul 20 2020, 4:32 PM
bengotow closed D3889: Enable multi-selection (+cancel +deletion) of runs in the runs list #2661.
Jul 20 2020, 4:32 PM
bengotow updated the diff for D3889: Enable multi-selection (+cancel +deletion) of runs in the runs list #2661.

Rebase

Jul 20 2020, 4:32 PM

Jul 16 2020

bengotow committed R1:a7e8c5b81a93: Maintain repo selection in new tabs, make playground sessions repo-specific (authored by bengotow).
Maintain repo selection in new tabs, make playground sessions repo-specific
Jul 16 2020, 5:30 PM
bengotow closed D3928: Maintain repo selection in new tabs, make playground sessions repo-specific.
Jul 16 2020, 5:30 PM
bengotow updated the diff for D3928: Maintain repo selection in new tabs, make playground sessions repo-specific.

Update changelog

Jul 16 2020, 5:29 PM
bengotow requested review of D3928: Maintain repo selection in new tabs, make playground sessions repo-specific.
Jul 16 2020, 5:12 PM
bengotow updated the diff for D3889: Enable multi-selection (+cancel +deletion) of runs in the runs list #2661.

Address diff feedback

Jul 16 2020, 3:54 PM
bengotow planned changes to D3889: Enable multi-selection (+cancel +deletion) of runs in the runs list #2661.

Thanks for the review @prha will get this fixed today!

Jul 16 2020, 2:43 PM
bengotow committed R1:9a30aa0ab71d: Make config editor help a split pane to avoid overlapping text #2681 (authored by bengotow).
Make config editor help a split pane to avoid overlapping text #2681
Jul 16 2020, 2:36 PM
bengotow closed D3886: Make config editor help a split pane to avoid overlapping text #2681.
Jul 16 2020, 2:36 PM

Jul 14 2020

bengotow requested review of D3889: Enable multi-selection (+cancel +deletion) of runs in the runs list #2661.
Jul 14 2020, 8:22 PM
bengotow requested review of D3886: Make config editor help a split pane to avoid overlapping text #2681.
Jul 14 2020, 4:58 PM
bengotow requested review of D3882: Make re-execute a two-part button so it’s one-click by default #2687.
Jul 14 2020, 3:54 PM

Jul 9 2020

bengotow accepted D3811: toggle partitions on shift-click.

Wow this is slick and the code looks good to me. I don't know if folks will guess that this interaction exists, so we may need to put a tooltip / meta text somewhere on the page so folks know to use it. (I feel like we need one of those "Loading..." banners with a Top Hat Dagster telling you tricks)

Jul 9 2020, 5:19 AM

Jul 7 2020

bengotow requested review of D3794: Fix a Gaant chart layout issue with unstarted steps appearing at x=0.
Jul 7 2020, 7:22 PM
bengotow closed D3760: Allow Dagit to be mounted at a path via new `—path` CLI param.
Jul 7 2020, 6:51 PM
bengotow committed R1:3f990af3391c: Allow Dagit to be mounted at a path via new `—path` CLI param (authored by bengotow).
Allow Dagit to be mounted at a path via new `—path` CLI param
Jul 7 2020, 6:51 PM
bengotow updated the diff for D3760: Allow Dagit to be mounted at a path via new `—path` CLI param.

Add tests for Dagit path prefix feature

Jul 7 2020, 4:05 PM
bengotow planned changes to D3760: Allow Dagit to be mounted at a path via new `—path` CLI param.
Jul 7 2020, 3:34 PM
bengotow committed R1:b49c59764d1d: Rename EnvironmentPicker to RepositoryPicker (authored by bengotow).
Rename EnvironmentPicker to RepositoryPicker
Jul 7 2020, 3:33 PM
bengotow closed D3707: Rename EnvironmentPicker to RepositoryPicker.
Jul 7 2020, 3:33 PM
bengotow updated the diff for D3760: Allow Dagit to be mounted at a path via new `—path` CLI param.

Need to tie VSCode to Black

Jul 7 2020, 2:10 PM
bengotow requested review of D3707: Rename EnvironmentPicker to RepositoryPicker.
Jul 7 2020, 12:53 AM
bengotow accepted D3778: fix run pagination.

Oh wow sorry I didn't catch this when I put this together, I guess this instanceof Array check guarded against a typescript error here... looks great to me 👍

Jul 7 2020, 12:39 AM
bengotow updated the diff for D3760: Allow Dagit to be mounted at a path via new `—path` CLI param.

Apply diff feedback

Jul 7 2020, 12:33 AM
bengotow planned changes to D3760: Allow Dagit to be mounted at a path via new `—path` CLI param.
Jul 7 2020, 12:29 AM

Jul 6 2020

bengotow requested review of D3760: Allow Dagit to be mounted at a path via new `—path` CLI param.
Jul 6 2020, 8:58 PM

Jul 2 2020

bengotow accepted D3745: [dagit] show repository on scoped schedule view.

Looks great!

Jul 2 2020, 7:13 PM

Jun 30 2020

bengotow committed R1:96541d816ddd: Wrap ts, tsx files at 100 characters for better readability (authored by bengotow).
Wrap ts, tsx files at 100 characters for better readability
Jun 30 2020, 8:48 PM
bengotow closed D3704: Wrap ts, tsx files at 100 characters for better readability.
Jun 30 2020, 8:48 PM
bengotow added a comment to D3704: Wrap ts, tsx files at 100 characters for better readability.

lolo omg that gif

Jun 30 2020, 8:43 PM
bengotow committed R1:1023d6949ac2: Pipeline-scoped runs tab, cleaner cursor-paginated query utils (authored by bengotow).
Pipeline-scoped runs tab, cleaner cursor-paginated query utils
Jun 30 2020, 8:42 PM
bengotow closed D3671: Pipeline-scoped runs tab, cleaner cursor-paginated query utils.
Jun 30 2020, 8:42 PM
bengotow added inline comments to D3671: Pipeline-scoped runs tab, cleaner cursor-paginated query utils.
Jun 30 2020, 8:38 PM
bengotow updated the diff for D3671: Pipeline-scoped runs tab, cleaner cursor-paginated query utils.

Lock the current pipeline tag into the filter bar on the pipeline runs page

Jun 30 2020, 8:36 PM
bengotow committed R1:3c91af4d7e2a: Improve behavior of the Enter key in the Dagit pipeline sidebar #2572 (authored by bengotow).
Improve behavior of the Enter key in the Dagit pipeline sidebar #2572
Jun 30 2020, 6:43 PM
bengotow closed D3705: Improve behavior of the Enter key in the Dagit pipeline sidebar #2572.
Jun 30 2020, 6:43 PM
bengotow updated the diff for D3671: Pipeline-scoped runs tab, cleaner cursor-paginated query utils.

Fix typo, add comments detailing new React hooks

Jun 30 2020, 6:42 PM
bengotow requested review of D3704: Wrap ts, tsx files at 100 characters for better readability.
Jun 30 2020, 6:34 PM
bengotow added a comment to D3706: [dagit] ENVIRONMENT -> REPOSITORY.

We probably should rename EnvironmentPicker but I can do it later today if that's easier, will require rebuilding the snapshots etc.

Jun 30 2020, 6:06 PM
bengotow accepted D3706: [dagit] ENVIRONMENT -> REPOSITORY.
Jun 30 2020, 6:06 PM
bengotow requested review of D3705: Improve behavior of the Enter key in the Dagit pipeline sidebar #2572.
Jun 30 2020, 4:02 PM

Jun 26 2020

bengotow requested review of D3671: Pipeline-scoped runs tab, cleaner cursor-paginated query utils.
Jun 26 2020, 11:57 PM

Jun 23 2020

bengotow committed R1:33840c747350: Rebuild the launch execution button for easier maintenance (authored by bengotow).
Rebuild the launch execution button for easier maintenance
Jun 23 2020, 3:29 AM
bengotow closed D3469: Rebuild the launch execution button for easier maintenance.
Jun 23 2020, 3:28 AM
bengotow updated the diff for D3469: Rebuild the launch execution button for easier maintenance.

Rebase

Jun 23 2020, 12:58 AM

Jun 19 2020

bengotow accepted D3568: Show full error and stack trace on launch errors.

Looks great let's ship it!

Jun 19 2020, 8:12 PM
bengotow requested review of D3569: Add location reload button when supported, keyboard nav in sidebar.
Jun 19 2020, 7:16 PM
bengotow updated the diff for D3469: Rebuild the launch execution button for easier maintenance.

Rename PipelineExecutionButtonGroup > LaunchRootExecutionButton

Jun 19 2020, 3:57 PM
bengotow added inline comments to D3469: Rebuild the launch execution button for easier maintenance.
Jun 19 2020, 3:54 PM
bengotow accepted D3551: add padding to the end of the run logs.
Jun 19 2020, 3:48 PM
bengotow added a comment to D3519: Reload support for new architecture.

This looks good to me, I will add on the front-end UI today!

Jun 19 2020, 3:48 PM

Jun 17 2020

bengotow committed R1:457e12748f2c: Fix wild recursion in execution plan for fan-in-out, avoid offset lines unless… (authored by bengotow).
Fix wild recursion in execution plan for fan-in-out, avoid offset lines unless…
Jun 17 2020, 4:45 PM
bengotow closed D3534: Fix wild recursion in execution plan for fan-in-out, avoid offset lines unless necessary.
Jun 17 2020, 4:45 PM
bengotow requested review of D3534: Fix wild recursion in execution plan for fan-in-out, avoid offset lines unless necessary.
Jun 17 2020, 6:40 AM

Jun 16 2020

bengotow planned changes to D3469: Rebuild the launch execution button for easier maintenance.
Jun 16 2020, 6:33 PM

Jun 12 2020

bengotow requested review of D3469: Rebuild the launch execution button for easier maintenance.
Jun 12 2020, 5:36 AM

Jun 11 2020

bengotow committed R1:159ce3cb9908: Switch more places to use `pipelineName`, improve loading of RunGroup (authored by bengotow).
Switch more places to use `pipelineName`, improve loading of RunGroup
Jun 11 2020, 10:49 PM
bengotow closed D3464: Switch more places to use `pipelineName`, improve loading of RunGroup.
Jun 11 2020, 10:49 PM
bengotow updated the diff for D3464: Switch more places to use `pipelineName`, improve loading of RunGroup.
  • Fix missing arg forwarding
Jun 11 2020, 10:34 PM
bengotow updated the diff for D3464: Switch more places to use `pipelineName`, improve loading of RunGroup.
  • Make “starting” state work in re-execute button [temporary fix]
Jun 11 2020, 10:02 PM
bengotow committed R1:462b57c615aa: Move schedules tab to repository scope (authored by bengotow).
Move schedules tab to repository scope
Jun 11 2020, 9:54 PM
bengotow closed D3460: Move schedules tab to repository scope.
Jun 11 2020, 9:54 PM
bengotow requested review of D3460: Move schedules tab to repository scope.
Jun 11 2020, 9:43 PM
bengotow requested review of D3464: Switch more places to use `pipelineName`, improve loading of RunGroup.
Jun 11 2020, 9:26 PM
bengotow accepted D3462: do not load snapshot to fetch name.
Jun 11 2020, 9:00 PM
bengotow accepted D3459: set default solid selection for query selector.

Looks good to me! I think originally we defaulted to "" instead of "*" because on large pipelines we wanted to make you type * explicitly and not try to render that subset immediately. I'm not sure that that is still necessary / an issue.

Jun 11 2020, 8:19 PM

Jun 10 2020

bengotow committed R1:6ca4c541d8fc: Fix log tailing behavior, broken by initial load of empty state instead of list… (authored by bengotow).
Fix log tailing behavior, broken by initial load of empty state instead of list…
Jun 10 2020, 3:07 PM
bengotow closed D3374: Fix log tailing behavior, broken by initial load of empty state instead of list #2487.
Jun 10 2020, 3:07 PM
bengotow committed R1:295decd98f01: Dagit should take you to the default page for a repo after selection #2554 (authored by bengotow).
Dagit should take you to the default page for a repo after selection #2554
Jun 10 2020, 3:07 PM
bengotow closed D3369: Dagit should take you to the default page for a repo after selection #2554.
Jun 10 2020, 3:07 PM