Page MenuHomeElementl

bengotow (Ben Gotow)
User

Projects

User does not belong to any projects.

User Details

User Since
May 9 2019, 3:45 PM (105 w, 11 h)

Recent Activity

Mon, May 10

bengotow closed D7842: Fix regression in line height in asset history view #4156.
Mon, May 10, 8:23 PM
bengotow committed R1:82ffbbd22b41: Fix regression in line height in asset history view #4156 (authored by bengotow).
Fix regression in line height in asset history view #4156
Mon, May 10, 8:23 PM
bengotow accepted D7839: [dagit] Permissions.

This looks great! Exciting to see a permissions layer coming together. I think it'd be nice to try making a container component that applies the disabled + tooltip but it's pretty clean already with hook approach!

Mon, May 10, 8:00 PM
bengotow requested review of D7842: Fix regression in line height in asset history view #4156.
Mon, May 10, 7:58 PM
bengotow closed D7814: [dagit] Fix issue rendering Gantt for dynamic pipelines with a collect that has non-dynamic inputs.
Mon, May 10, 4:06 PM
bengotow committed R1:4b94c856e248: [dagit] Fix issue rendering Gantt for dynamic pipelines with a collect that has… (authored by bengotow).
[dagit] Fix issue rendering Gantt for dynamic pipelines with a collect that has…
Mon, May 10, 4:06 PM

Fri, May 7

bengotow updated the summary of D7814: [dagit] Fix issue rendering Gantt for dynamic pipelines with a collect that has non-dynamic inputs.
Fri, May 7, 9:06 PM
bengotow accepted D7810: [dagit] Add optional authorization header to HTTP requests.

Hmm I think this works for now because we're planning on using the authToken primarily to attribute runs, etc. to different users, but I think if we really wanted security we'd need to add auth to the websockets interface as well (or stop using it), right? I wonder if we should add a small comment in here explaining that there are still un-authorized GraphQL requests being made from the app in the few places we need websockets?

Fri, May 7, 9:04 PM
bengotow accepted D7812: [dagit] Prepare to remove `main` file.
Fri, May 7, 9:01 PM
bengotow accepted D7790: [dagit] Move everything out of __tests__.

Ahh yeah this will be much better! I'm not 100% sure when we started doing it the other way but I'm a fan of seeing them right next to the source in the file tree 👍

Fri, May 7, 8:58 PM
bengotow updated the diff for D7814: [dagit] Fix issue rendering Gantt for dynamic pipelines with a collect that has non-dynamic inputs.

Add missing case triggered when run is half complete

Fri, May 7, 8:57 PM
bengotow requested review of D7814: [dagit] Fix issue rendering Gantt for dynamic pipelines with a collect that has non-dynamic inputs.
Fri, May 7, 8:43 PM
bengotow closed D7736: Add step contextual menus, url-persisted pagination to partition matrix.
Fri, May 7, 8:34 PM
bengotow committed R1:74e2646ed7f4: Add step contextual menus, url-persisted pagination to partition matrix (authored by bengotow).
Add step contextual menus, url-persisted pagination to partition matrix
Fri, May 7, 8:34 PM

Wed, May 5

bengotow requested review of D7736: Add step contextual menus, url-persisted pagination to partition matrix.
Wed, May 5, 3:05 AM

Mon, May 3

bengotow accepted D7672: [dagit] Remove react-scripts from @dagit/core.
Mon, May 3, 12:39 PM
bengotow accepted D7685: [dagit] Make RunsSearchSpaceQuery lazy.

Oh nice! This seems like a nice solution 👍

Mon, May 3, 12:38 PM

Thu, Apr 29

bengotow closed D7632: Default to re-executing step selection of current run if one is present.
Thu, Apr 29, 9:18 PM
bengotow committed R1:1dfeef17e03a: Default to re-executing step selection of current run if one is present (authored by bengotow).
Default to re-executing step selection of current run if one is present
Thu, Apr 29, 9:18 PM
bengotow added a comment to D7632: Default to re-executing step selection of current run if one is present.

I think "All Steps in Root Run" sounds pretty good! It's super explicit which I think is preferable at this point... Root Run <Solid Selection> would work too but I'm a bit worried about a solid query making it too long. Will go with this for now and we can iterate if we come up with anything better!

Thu, Apr 29, 9:18 PM
bengotow closed D7626: Storybook for PipelineGraph, stories for various DAG viz features.
Thu, Apr 29, 9:12 PM
bengotow committed R1:fd5c11c62d6c: Storybook for PipelineGraph, stories for various DAG viz features (authored by bengotow).
Storybook for PipelineGraph, stories for various DAG viz features
Thu, Apr 29, 9:12 PM
bengotow closed D7609: Add storybooks for Gannt chart UI, show hh:mm:ss when clicking Gannt steps #4042.
Thu, Apr 29, 9:11 PM
bengotow committed R1:c7327cec3ec6: Add storybooks for Gannt chart UI, show hh:mm:ss when clicking Gannt steps #4042 (authored by bengotow).
Add storybooks for Gannt chart UI, show hh:mm:ss when clicking Gannt steps #4042
Thu, Apr 29, 9:11 PM

Wed, Apr 28

bengotow accepted D7628: [dagit] Display partition name tooltip if too long in matrix table.

Looks good to me!

Wed, Apr 28, 2:49 PM
bengotow requested review of D7632: Default to re-executing step selection of current run if one is present.
Wed, Apr 28, 6:51 AM

Tue, Apr 27

bengotow requested review of D7626: Storybook for PipelineGraph, stories for various DAG viz features.
Tue, Apr 27, 6:41 PM

Mon, Apr 26

bengotow accepted D7611: [dagit] Prevent overscroll on hscroll containers.

Oh nice! This is great - I had no idea there was a CSS property for this, good find. 🙌

Mon, Apr 26, 11:05 PM
bengotow closed D7467: Increase the number of typeahead autocompletions shown and scroll the list #4017.
Mon, Apr 26, 11:04 PM
bengotow committed R1:0c833109fb13: Increase the number of typeahead autocompletions shown and scroll the list #4017 (authored by bengotow).
Increase the number of typeahead autocompletions shown and scroll the list #4017
Mon, Apr 26, 11:04 PM
bengotow requested review of D7609: Add storybooks for Gannt chart UI, show hh:mm:ss when clicking Gannt steps #4042.
Mon, Apr 26, 9:53 PM
bengotow updated the diff for D7467: Increase the number of typeahead autocompletions shown and scroll the list #4017.
  • Keep the active item visible as you use the keyboard to navigate
Mon, Apr 26, 9:51 PM
bengotow accepted D7608: [dagit] Prevent solid selection from overlapping RunRoot header.
Mon, Apr 26, 9:51 PM
bengotow accepted D7597: [dagit] Polling query on assets page.

Looks good to me!

Mon, Apr 26, 9:49 PM
bengotow accepted D7572: [dagit] Link to pipeline from Run table.
Mon, Apr 26, 9:48 PM
bengotow accepted D7557: [dagit] Add close button to repo filter flyout.
Mon, Apr 26, 9:48 PM
bengotow updated the diff for D7467: Increase the number of typeahead autocompletions shown and scroll the list #4017.

Rebase and fix tests

Mon, Apr 26, 7:47 PM
bengotow closed D7498: Storybook for PartitionRunMatrix.
Mon, Apr 26, 7:43 PM
bengotow committed R1:309e35f0eca9: Storybook for PartitionRunMatrix (authored by bengotow).
Storybook for PartitionRunMatrix
Mon, Apr 26, 7:43 PM

Mon, Apr 19

bengotow accepted D7505: [dagit] Delete some dead code.
Mon, Apr 19, 7:43 PM
bengotow updated the diff for D7467: Increase the number of typeahead autocompletions shown and scroll the list #4017.

Rebase

Mon, Apr 19, 7:35 PM
bengotow updated the diff for D7467: Increase the number of typeahead autocompletions shown and scroll the list #4017.
  • Keep the active item visible as you use the keyboard to navigate
Mon, Apr 19, 7:34 PM
bengotow planned changes to D7467: Increase the number of typeahead autocompletions shown and scroll the list #4017.

Ahh good catch it lets you move the selection out of view. Will fix this!

Mon, Apr 19, 7:25 PM
bengotow accepted D7493: change run view to show compute log panel with log type toggle.

This looks like a huge improvement - the JS looks good but I'll defer to Nick and Sandy on the functional aspects!

Mon, Apr 19, 7:08 PM
bengotow updated the diff for D7498: Storybook for PartitionRunMatrix.

Upate with better stories

Mon, Apr 19, 5:16 PM
bengotow requested review of D7498: Storybook for PartitionRunMatrix.
Mon, Apr 19, 4:20 PM
bengotow closed D7465: Handle long lists of parent assets #3952.
Mon, Apr 19, 4:08 PM
bengotow committed R1:8bbce35a779c: Handle long lists of parent assets #3952 (authored by bengotow).
Handle long lists of parent assets #3952
Mon, Apr 19, 4:08 PM
bengotow updated the diff for D7465: Handle long lists of parent assets #3952.
  • Eliminate needless “Group” in AssetLineageElements
  • Fix storybook config and update storybook deps
  • Add storybook for AssetLineageElements
Mon, Apr 19, 3:41 PM

Fri, Apr 16

bengotow accepted D7487: [dagit] Assets: Only show latest materialization in list.

This seems like a good workflow improvement! Certainly makes the list easier to scan through and emphasizes that the graphs, etc. also only show the most recent run for the partition.

Fri, Apr 16, 8:46 PM
bengotow closed D7466: Remove “for-screenshots” titles - confirmed with Sashank that there is no script using this anymore #3800.
Fri, Apr 16, 3:16 PM
bengotow committed R1:0e06f31c1dec: Remove “for-screenshots” titles - confirmed with Sashank that there is no… (authored by bengotow).
Remove “for-screenshots” titles - confirmed with Sashank that there is no…
Fri, Apr 16, 3:16 PM
bengotow closed D7469: Make default scroll position in "Launch backfill" modal be right-most partition #3787.
Fri, Apr 16, 3:15 PM
bengotow committed R1:3e39b932315c: Make default scroll position in "Launch backfill" modal be right-most partition… (authored by bengotow).
Make default scroll position in "Launch backfill" modal be right-most partition…
Fri, Apr 16, 3:15 PM

Thu, Apr 15

bengotow requested review of D7469: Make default scroll position in "Launch backfill" modal be right-most partition #3787.
Thu, Apr 15, 8:42 PM
bengotow requested review of D7467: Increase the number of typeahead autocompletions shown and scroll the list #4017.
Thu, Apr 15, 8:36 PM
bengotow requested review of D7466: Remove “for-screenshots” titles - confirmed with Sashank that there is no script using this anymore #3800.
Thu, Apr 15, 8:36 PM
bengotow requested review of D7465: Handle long lists of parent assets #3952.
Thu, Apr 15, 8:30 PM

Wed, Apr 14

bengotow closed D7378: Improve the button layout of the partition view for smaller displays.
Wed, Apr 14, 6:17 PM
bengotow committed R1:c2ebfd254f9b: Improve the button layout of the partition view for smaller displays (authored by bengotow).
Improve the button layout of the partition view for smaller displays
Wed, Apr 14, 6:17 PM

Apr 14 2021

bengotow closed D7379: Fix the partition “Run steps” sidebar which required immediate step list.
Apr 14 2021, 3:02 AM
bengotow committed R1:6bc26b311f27: Fix the partition “Run steps” sidebar which required immediate step list (authored by bengotow).
Fix the partition “Run steps” sidebar which required immediate step list
Apr 14 2021, 3:02 AM

Apr 13 2021

bengotow closed D7377: Switch partition run matrix to simpler “square color = status in last run”.
Apr 13 2021, 7:03 PM
bengotow committed R1:8f63cb3760eb: Switch partition run matrix to simpler “square color = status in last run” (authored by bengotow).
Switch partition run matrix to simpler “square color = status in last run”
Apr 13 2021, 7:02 PM

Apr 9 2021

bengotow requested review of D7379: Fix the partition “Run steps” sidebar which required immediate step list.
Apr 9 2021, 10:03 PM
bengotow requested review of D7378: Improve the button layout of the partition view for smaller displays.
Apr 9 2021, 9:12 PM
bengotow requested review of D7377: Switch partition run matrix to simpler “square color = status in last run”.
Apr 9 2021, 8:17 PM

Apr 8 2021

bengotow accepted D7345: [dagit] Default nav closed.
Apr 8 2021, 2:29 PM

Apr 7 2021

bengotow accepted D7324: [dagit] Enable extended search for global search.

Seems safe to me since we don't have any objects in the system that have spaces in the names. I looked at the other "extended" operators and it doesn't seem like they'll conflict either (was a bit worried about dashes but it seems like those are safe.) LGTM!

Apr 7 2021, 3:43 PM
bengotow accepted D7323: [dagit] RFC: Collapsible left nav.

Patched this down and played around with it, looks great! It ended up not being as much code as I'd imagined too. I vote we ship it soon and see if folks have feedback on master.

Apr 7 2021, 3:41 PM
bengotow accepted D7284: [dagit] RFC: Simplify GraphQL Playground usage.

You know, I think I remember when we started doing this a long while back, and it was so that the Dagit graphql playground would work totally offline. (https://github.com/dagster-io/dagster/commit/7376c95cecc2a02f74dc213b533be187ea45b221) I don't know that it turned out to be as important as we thought it might, so I'm a fan of this change.

Apr 7 2021, 3:17 PM

Apr 1 2021

bengotow accepted D7246: [dagit] Upgrade to React 17.

Whoa nice! I guess we were mostly on function components already so a lot of the class component deprecations didn't matter - that's awesome!

Apr 1 2021, 3:42 AM

Mar 31 2021

bengotow accepted D7225: [dagit] Clean up some dead code and exports.

LGTM!

Mar 31 2021, 2:45 PM

Mar 30 2021

bengotow closed D7224: More @core peer-deps, new top nav exported from core.
Mar 30 2021, 11:41 PM
bengotow committed R1:8f57e09e1f8d: More @core peer-deps, new top nav exported from core (authored by bengotow).
More @core peer-deps, new top nav exported from core
Mar 30 2021, 11:41 PM
bengotow requested review of D7224: More @core peer-deps, new top nav exported from core.
Mar 30 2021, 10:45 PM
bengotow accepted D7221: Hygiene for Dagit routes.
Mar 30 2021, 8:55 PM

Mar 29 2021

bengotow accepted D7197: [dagit] Extract app configuration.

This looks great to me and I think this is a good pattern to set for these sort of global config values going forward. I'm actually surprised we didn't have more hardcoded stuff, 3 variables is not bad!

Mar 29 2021, 11:08 PM
bengotow accepted D7191: add babel plugin to resolve typescript error.

Didn't realize babel would have to handle this - It seems like babel/preset-typescript passing this to typescript for conversion to javascript would do the trick... but I have never quite understood the babel toolchain, if this does the trick I'm good with it!

Mar 29 2021, 8:49 PM
bengotow accepted D7159: [dagit] Split app into packages.

This looks great, I pulled it down and ran all the scripts etc - all worked smoothly! 🙌

Mar 29 2021, 3:12 PM

Mar 19 2021

bengotow accepted D7056: Restrict styled-components and react-router imports.

Chatted about this offline, this looks good and I like using eslint rules to enforce these, but I think the styled-components/macro version is much nicer and it'd be nice to standardize in the other direction if possible!

Mar 19 2021, 2:31 PM
bengotow accepted D7028: [dagit] Fix table row borders in Safari.
Mar 19 2021, 2:25 PM

Mar 17 2021

bengotow closed D6951: Collect support in annotations on the DAG and solid sidebar.
Mar 17 2021, 10:05 PM
bengotow committed R1:cd5eaabf7fd2: Collect support in annotations on the DAG and solid sidebar (authored by bengotow).
Collect support in annotations on the DAG and solid sidebar
Mar 17 2021, 10:05 PM
bengotow added a comment to D6951: Collect support in annotations on the DAG and solid sidebar.

Per discussion with @alangenfeld, this now looks a bit nicer and has a color coding to help users understand that the iconography and the layering are related.

Mar 17 2021, 10:05 PM
bengotow updated the diff for D6951: Collect support in annotations on the DAG and solid sidebar.

Rebase and update styling

Mar 17 2021, 9:35 PM
bengotow accepted D6973: [dagit] Use RepoNavItem.

I'm a fan! I pulled it down and poked at it a bit and it seems like a pretty clear improvement over the previous repo switcher and this code looks clean. Really like having a "filter" vs a "selection" concept here.

Mar 17 2021, 4:59 PM
bengotow accepted D6983: [dagit] Remove custom fonts.
Mar 17 2021, 4:48 PM

Mar 16 2021

bengotow requested review of D6951: Collect support in annotations on the DAG and solid sidebar.
Mar 16 2021, 4:43 AM

Mar 15 2021

bengotow closed D6825: Misc small tweaks to the asset root page.
Mar 15 2021, 7:55 PM
bengotow committed R1:95e1c4a8086c: Misc small tweaks to the asset root page (authored by bengotow).
Misc small tweaks to the asset root page
Mar 15 2021, 7:55 PM
bengotow added a comment to D6825: Misc small tweaks to the asset root page.

Talked with sandy + dish and revised the presentation to look like this:

image.png (301×631 px, 37 KB)

Mar 15 2021, 4:11 PM
bengotow updated the diff for D6825: Misc small tweaks to the asset root page.

Update presentation of "latest materialization from"

Mar 15 2021, 4:10 PM
bengotow accepted D6868: asset tags visible in catalog table view.

This looks great! I think asset tags are better than expecting everyone to collect their assets into folders with the path style names. I'm a little wary of pipeline being encoded on assets via a tag because it'd be nice to have a more formal structure with the full [pipeline+mode] links we render elsewhere, but that's out of scope of this :-)

Mar 15 2021, 3:24 AM
bengotow accepted D6893: [dagit] Make repo switcher more flexible.

This looks great! Just left a couple nits inline. If we get really tired of the Promise.all(client.query...) it'd be fun to explore a useQuery hook that took an array of VariableType and ran N queries and flattened them, but not sure if the response __typename checking would make it hard to generalize...

Mar 15 2021, 3:17 AM
bengotow accepted D6903: [dagit] RFC: Multi-repo switcher.

This looks great! I like this multi-select concept because it makes it really clear that the repo selection is a piece of view state specific to the sidebar and not a page-wide setting. It seems more valid to view a pipeline run of repo X with repo Y in the sidebar if it's "1 of 6" and the choice is behind a "Filter" button. Code looks good!

Mar 15 2021, 2:59 AM

Mar 11 2021

bengotow planned changes to D6825: Misc small tweaks to the asset root page.

Thanks folks! I'll tinker with this a bit more, I agree that sentence is a bit of a mouthful, the icons could help a lot.

Mar 11 2021, 10:28 PM
bengotow closed D6824: Add snapshotId support to PiplineAndMode, display mode in more places.
Mar 11 2021, 10:23 PM
bengotow committed R1:7125bfede992: Add snapshotId support to PiplineAndMode, display mode in more places (authored by bengotow).
Add snapshotId support to PiplineAndMode, display mode in more places
Mar 11 2021, 10:23 PM
bengotow closed D6823: Eagerly set mode when changing partition sets #3711.
Mar 11 2021, 10:22 PM