Page MenuHomePhabricator

bengotow (Ben Gotow)
User

Projects

User does not belong to any projects.

User Details

User Since
May 9 2019, 3:45 PM (47 w, 5 d)

Recent Activity

Today

bengotow updated the diff for D2364: Use our tokenized text field for log filtering so type: and step: features are easy to find.

Update snapshots

Wed, Apr 8, 3:53 AM
bengotow added a comment to D2364: Use our tokenized text field for log filtering so type: and step: features are easy to find.

Sounds good! Yep, I think you now have to press enter after typing freeform text to apply it + search, though that may be best for realistic scenarios with lots of logs

Wed, Apr 8, 3:51 AM
bengotow updated the diff for D2364: Use our tokenized text field for log filtering so type: and step: features are easy to find.
  • Properly support filtering by type and step
  • Rebase
Wed, Apr 8, 12:48 AM

Yesterday

bengotow added a comment to D2405: #2346-1 [RFC] multi-step (arbitrary subset) re-execution through dagit Run.

This looks great! Just added a few comments on the JS side of things—very cool to see multiple selection in the gaant view! I think that some of the changes to the "structured contents of the search bar" overlap with work I did but it might be easier for you to land this first, will check and see.

Tue, Apr 7, 4:49 PM
bengotow added a comment to D2460: #2346-2 [RFC] pass tags and stepkeys to playground.

Just a few drive-by comments, this looks good to me otherwise!

Tue, Apr 7, 4:28 PM

Thu, Apr 2

bengotow committed R1:286bb8d6b0e6: Replace the playground's execution plan preview with a more useful config map (authored by bengotow).
Replace the playground's execution plan preview with a more useful config map
Thu, Apr 2, 11:25 PM
bengotow closed D2368: Replace the playground's execution plan preview with a more useful config map.
Thu, Apr 2, 11:25 PM
bengotow updated the diff for D2368: Replace the playground's execution plan preview with a more useful config map.

Fix scroll bars

Thu, Apr 2, 11:24 PM
bengotow added a comment to D2368: Replace the playground's execution plan preview with a more useful config map.

Ooh good comment @alangenfeld, didn't see those scrollbars on my machine, will fix before landing this!

Thu, Apr 2, 11:20 PM
bengotow updated the diff for D2368: Replace the playground's execution plan preview with a more useful config map.

Fix generated types

Thu, Apr 2, 10:51 PM
bengotow updated the diff for D2368: Replace the playground's execution plan preview with a more useful config map.
  • Improved box colors
  • Improved jump-to-line that does not remove contextual help and reliably puts the line at the top of the editor
  • Option to show only incorrectly configured boxes
Thu, Apr 2, 9:26 PM

Mon, Mar 30

bengotow accepted D2372: Scope eslint to dagit in arclint.

LGTM!

Mon, Mar 30, 8:54 PM
bengotow updated the summary of D2368: Replace the playground's execution plan preview with a more useful config map.
Mon, Mar 30, 4:45 PM
bengotow created D2368: Replace the playground's execution plan preview with a more useful config map.
Mon, Mar 30, 4:45 PM
bengotow created D2364: Use our tokenized text field for log filtering so type: and step: features are easy to find.
Mon, Mar 30, 1:19 AM

Thu, Mar 19

bengotow committed R1:ede19cbcecda: Fix marker aliasing in the Gaant chart caused by non-unique marker keys (authored by bengotow).
Fix marker aliasing in the Gaant chart caused by non-unique marker keys
Thu, Mar 19, 9:32 PM
bengotow closed D2290: Fix marker aliasing in the Gaant chart caused by non-unique marker keys.
Thu, Mar 19, 9:31 PM
bengotow created D2290: Fix marker aliasing in the Gaant chart caused by non-unique marker keys.
Thu, Mar 19, 9:19 PM
bengotow committed R1:30bc3b3aebc4: Support for markers in the Gaant timeline visualization (authored by bengotow).
Support for markers in the Gaant timeline visualization
Thu, Mar 19, 3:55 AM
bengotow closed D2210: Support for markers in the Gaant timeline visualization.
Thu, Mar 19, 3:55 AM
bengotow updated the diff for D2210: Support for markers in the Gaant timeline visualization.
  • Add a hover highlight to the log rows, weaken debounce so it doesn't seem slow
  • Order the markers for display so that later markers are stacked on top in the DOM and hoverable
  • Improve the fog of war color so it has the same slight bluish tint as our other grays
Thu, Mar 19, 3:42 AM

Wed, Mar 18

bengotow added a comment to D2210: Support for markers in the Gaant timeline visualization.

Hey @alangenfeld , @prha , this should be ready for review again! Per our conversation yesterday there have been a handful of changes:

Wed, Mar 18, 7:05 PM
bengotow updated the summary of D2210: Support for markers in the Gaant timeline visualization.
Wed, Mar 18, 7:00 PM
bengotow updated the diff for D2210: Support for markers in the Gaant timeline visualization.
  • Add preparing step state, make logs and UI use new consistent skipped color
  • Debounce the hovering of logs
  • Split apart retried steps, clean up rendering a bit
Wed, Mar 18, 6:55 PM

Tue, Mar 17

bengotow updated the diff for D2210: Support for markers in the Gaant timeline visualization.
  • Better informational color
  • Indicate retries by colorizing the box gray=>green or gray=>red
  • Handle markers appearing multiple times due to retries
  • Highlight the current time as you hover over logs so it's easier to tie logs to the viz.
Tue, Mar 17, 4:57 PM

Thu, Mar 12

bengotow accepted D2207: (3/n schedule-attempts) More detailed tick view in dagit.

Looks good to me! I think we could definitely iterate on the design a bit and make it more of a vertical timeline (ala old execution plan), but the React parts look solid and we can play with that later. Also if you're in need of a very cheap way to fix those uppercase SUCCESS, etc. labels, you can do <span style={{textTransform: 'capitalize'}}>{text.toLowercase()}</span> and I wouldn't judge (or treat them as an enum and map from value => display value in a dict)

Thu, Mar 12, 2:37 PM

Tue, Mar 10

bengotow accepted D2219: #2128 add keyboard shortcut for preset button in the playground.

Hey! Just wanted to chime in — I think that the final approach here (using the DOM APIs to "click" the select when the shortcut is activated) is probably the best. I ran into this with the PipelineJumpBar as well. Ideally, the select Component would expose public methods (class components can have instance methods that you can call to imperatively, eg myCustomComponentRef.zoomToCenter()) OR allow for controlled usage. Blueprint's Select component is more or less a black box, and activating it via the DOM is the least-likely-to-break hack, since it should fundamentally always respond to a click event.

Tue, Mar 10, 7:19 PM

Mar 6 2020

bengotow updated the summary of D2210: Support for markers in the Gaant timeline visualization.
Mar 6 2020, 4:28 PM
bengotow updated the summary of D2210: Support for markers in the Gaant timeline visualization.
Mar 6 2020, 4:28 PM
bengotow created D2210: Support for markers in the Gaant timeline visualization.
Mar 6 2020, 4:27 PM

Mar 4 2020

bengotow added inline comments to D2143: Generate screenshots for intro tutorial.
Mar 4 2020, 4:45 PM

Feb 28 2020

bengotow added inline comments to D2164: [dagit] add markers.
Feb 28 2020, 7:03 PM

Feb 26 2020

bengotow committed R1:c9b7295ab8ee: Major performance boost in Gaant layout algorithm for fan_in_fan_out (authored by bengotow).
Major performance boost in Gaant layout algorithm for fan_in_fan_out
Feb 26 2020, 11:36 PM
bengotow closed D2149: Major performance boost in Gaant layout algorithm for fan_in_fan_out.
Feb 26 2020, 11:36 PM
bengotow updated the diff for D2149: Major performance boost in Gaant layout algorithm for fan_in_fan_out.

Add comment

Feb 26 2020, 11:35 PM
bengotow added inline comments to D2149: Major performance boost in Gaant layout algorithm for fan_in_fan_out.
Feb 26 2020, 11:30 PM
bengotow created D2149: Major performance boost in Gaant layout algorithm for fan_in_fan_out.
Feb 26 2020, 10:44 PM
bengotow committed R1:587ca94ad8ac: Fix dagit fonts and favicon by serving all static files in webapp/build (authored by bengotow).
Fix dagit fonts and favicon by serving all static files in webapp/build
Feb 26 2020, 7:20 PM
bengotow closed D2142: Fix dagit fonts and favicon by serving all static files in webapp/build.
Feb 26 2020, 7:20 PM
bengotow updated the diff for D2142: Fix dagit fonts and favicon by serving all static files in webapp/build.

Terrible at python today

Feb 26 2020, 6:26 PM
bengotow closed D2117: Move playground back into pipeline scope, clean up route props.
Feb 26 2020, 6:18 PM
bengotow committed R1:00f7d1d981d7: Move playground back into pipeline scope, clean up route props (authored by bengotow).
Move playground back into pipeline scope, clean up route props
Feb 26 2020, 6:18 PM
bengotow updated the diff for D2142: Fix dagit fonts and favicon by serving all static files in webapp/build.

Try from dagster venv

Feb 26 2020, 6:16 PM
bengotow updated the diff for D2142: Fix dagit fonts and favicon by serving all static files in webapp/build.

Update dagit router smoke test

Feb 26 2020, 6:11 PM
bengotow updated the diff for D2117: Move playground back into pipeline scope, clean up route props.
  • To be on the safe side, change local storage keys so we don’t need a migration
  • Update tests to a valid playground path
  • Fix “/setup” handling
Feb 26 2020, 6:04 PM
bengotow created D2142: Fix dagit fonts and favicon by serving all static files in webapp/build.
Feb 26 2020, 5:46 PM
bengotow committed R1:0bb999a0fe11: Fix rendering of straight lines—only align to box top / left if they’re on… (authored by bengotow).
Fix rendering of straight lines—only align to box top / left if they’re on…
Feb 26 2020, 4:37 PM
bengotow closed D2118: Fix rendering of straight lines—only align to box top / left if they’re on separate rows.
Feb 26 2020, 4:37 PM
bengotow committed R1:9b4a99bcfa5a: Selecting a node in the gaant view scrolls to the center of the diagram (authored by bengotow).
Selecting a node in the gaant view scrolls to the center of the diagram
Feb 26 2020, 4:37 PM
bengotow closed D2119: Selecting a node in the gaant view scrolls to the center of the diagram.
Feb 26 2020, 4:37 PM
bengotow committed R1:5440a6bd2fec: Don’t intercept+override copy event in codemirror and in text fields #2138 (authored by bengotow).
Don’t intercept+override copy event in codemirror and in text fields #2138
Feb 26 2020, 4:36 PM
bengotow closed D2120: Don’t intercept+override copy event in codemirror and in text fields #2138.
Feb 26 2020, 4:36 PM

Feb 25 2020

bengotow accepted D2130: Revert keyboard shortcuts bug.

LGTM! Thanks for fixing 🙌

Feb 25 2020, 10:08 PM
bengotow updated the diff for D2117: Move playground back into pipeline scope, clean up route props.
  • Pull pipeline out of session, fix issue with initial empty states
Feb 25 2020, 4:51 PM
bengotow added a comment to D2117: Move playground back into pipeline scope, clean up route props.

Hmm will try reverting my local storage and see if I can repro, that's an odd one.

Feb 25 2020, 4:32 PM
bengotow created D2120: Don’t intercept+override copy event in codemirror and in text fields #2138.
Feb 25 2020, 6:05 AM
bengotow created D2119: Selecting a node in the gaant view scrolls to the center of the diagram.
Feb 25 2020, 5:58 AM
bengotow created D2118: Fix rendering of straight lines—only align to box top / left if they’re on separate rows.
Feb 25 2020, 5:48 AM
bengotow created D2117: Move playground back into pipeline scope, clean up route props.
Feb 25 2020, 5:46 AM

Feb 12 2020

bengotow committed R1:738c5cf04cd6: Ensure zoom-to-fit scale is always >0 [2152] (authored by bengotow).
Ensure zoom-to-fit scale is always >0 [2152]
Feb 12 2020, 11:11 PM
bengotow closed D2030: Ensure zoom-to-fit scale is always >0 [2152].
Feb 12 2020, 11:11 PM
bengotow committed R1:7fb6f9310aba: Prevent default Gaant options from being mutated when merged with provided… (authored by bengotow).
Prevent default Gaant options from being mutated when merged with provided…
Feb 12 2020, 11:08 PM
bengotow closed D2028: Prevent default Gaant options from being mutated when merged with provided options [2148].
Feb 12 2020, 11:08 PM
bengotow created D2030: Ensure zoom-to-fit scale is always >0 [2152].
Feb 12 2020, 11:00 PM
bengotow added inline comments to D2028: Prevent default Gaant options from being mutated when merged with provided options [2148].
Feb 12 2020, 11:00 PM
bengotow added inline comments to D2028: Prevent default Gaant options from being mutated when merged with provided options [2148].
Feb 12 2020, 10:59 PM
bengotow accepted D2024: [dagit] handle errors in DirectGraphQLSubscription.

Accepted with one minor nit!

Feb 12 2020, 10:45 PM
bengotow created D2028: Prevent default Gaant options from being mutated when merged with provided options [2148].
Feb 12 2020, 10:38 PM
bengotow closed D1997: Rework Gaant for performant rendering on large DAGs, add sidebar, polish.
Feb 12 2020, 7:01 AM
bengotow committed R1:f19503514597: Rework Gaant for performant rendering on large DAGs, add sidebar, polish (authored by bengotow).
Rework Gaant for performant rendering on large DAGs, add sidebar, polish
Feb 12 2020, 7:00 AM
bengotow updated the diff for D1997: Rework Gaant for performant rendering on large DAGs, add sidebar, polish.
  • Merge branch 'master' of github.com:dagster-io/dagster into sfbg/gaant-v2
  • Toggle query when double clicking
  • Slowest path should only consider finished nodes
Feb 12 2020, 6:47 AM
bengotow added a comment to D1997: Rework Gaant for performant rendering on large DAGs, add sidebar, polish.

So I think a reasonable resolution to "undo" the selection of *foo*: If you double click again it toggles back to "*"

Feb 12 2020, 3:28 AM
bengotow added a comment to D1997: Rework Gaant for performant rendering on large DAGs, add sidebar, polish.

Test failures appear spurious?

Feb 12 2020, 12:55 AM
bengotow updated the diff for D1997: Rework Gaant for performant rendering on large DAGs, add sidebar, polish.
  • Add comments, address diff feedback
  • Conditionally add preset queries, don’t add any that are “”
  • Fix inifinite traversal - algo is visiting nodes repeatedly
  • Clearing a preset should reset filter to “*”
  • Add basic double-click-to-query behavior
  • Pass the current time through layout adjustment, tick continuously for smooth effect
Feb 12 2020, 12:27 AM

Feb 11 2020

bengotow planned changes to D1997: Rework Gaant for performant rendering on large DAGs, add sidebar, polish.
Feb 11 2020, 7:57 PM
bengotow updated the diff for D1997: Rework Gaant for performant rendering on large DAGs, add sidebar, polish.

Update types

Feb 11 2020, 4:07 PM
bengotow updated the summary of D1997: Rework Gaant for performant rendering on large DAGs, add sidebar, polish.
Feb 11 2020, 3:48 PM
bengotow updated the summary of D1997: Rework Gaant for performant rendering on large DAGs, add sidebar, polish.
Feb 11 2020, 3:39 PM
bengotow created D1997: Rework Gaant for performant rendering on large DAGs, add sidebar, polish.
Feb 11 2020, 3:32 PM

Feb 2 2020

bengotow updated the diff for D1935: Misc fixes and improvements to Dagit with large test pipeline.
  • Fix button label on the subset selector
  • Don’t assume step state transition logs will arrive in the right order
  • Put the “Re-execute” / “Cancel” / “Resume” buttons back in the old UI
  • Add a lint error when we hit the error display limit in the config editor
Feb 2 2020, 11:51 PM
bengotow added a comment to D1935: Misc fixes and improvements to Dagit with large test pipeline.

Added a message showing that errors are truncated!

Feb 2 2020, 11:47 PM
bengotow added inline comments to D1935: Misc fixes and improvements to Dagit with large test pipeline.
Feb 2 2020, 2:27 AM
bengotow accepted D1938: [graphql] expose ExecutionSelection on PipelineRun.

Looks good! This should allow us to fix the UI. Is the mode part of the execution selection or is that a parallel setting? Had expected to see that in here but maybe it's just because we've been showing them together in the UI.

Feb 2 2020, 2:16 AM

Jan 31 2020

bengotow created D1935: Misc fixes and improvements to Dagit with large test pipeline.
Jan 31 2020, 12:08 AM

Jan 29 2020

bengotow updated the diff for D1860: Basic composite expansion in the Dagit explore tab.
  • Merge branch 'master' of github.com:dagster-io/dagster into sfbg/expanded-composites-less-fun
Jan 29 2020, 10:57 PM
bengotow updated the diff for D1855: Gaant-style execution plan visualization behind feature flag.
  • Merge branch 'master' of github.com:dagster-io/dagster into sfbg/gaant
Jan 29 2020, 8:28 PM
bengotow updated the diff for D1860: Basic composite expansion in the Dagit explore tab.

Rebase

Jan 29 2020, 8:26 PM
bengotow updated the diff for D1855: Gaant-style execution plan visualization behind feature flag.
  • Rework CSS on config editor help
  • Fix min heights / behavior of the gaant UI when shrunk to 0 size
  • Add split panel controls for focusing first or second panels fast
  • Throw a few gradients in for good measure
  • Much more realistic timed-waterfall
Jan 29 2020, 8:25 PM
bengotow accepted D1876: clear cross repo sessions from local storage.

Looks good! Just a few minor suggestions 👍

Jan 29 2020, 8:12 PM

Jan 28 2020

bengotow updated the diff for D1860: Basic composite expansion in the Dagit explore tab.
  • Rename to “explode” composites and only show when it’d do something
  • Update tests
Jan 28 2020, 6:02 PM
bengotow planned changes to D1860: Basic composite expansion in the Dagit explore tab.

Will update this to address the feedback! Re: full reload, I think that the flashing loading indicator is annoying but also not realistic. For large pipelines this will probably take many seconds to switch over because it has to load every solid handle. I don't think we can do much of a transition because the graph shape changes, and navigating / continuing to play with the DAG while it loads isn't productive because it'll blow away your state when it replaces the graph. I think we should probably revisit better loading state when we make it expand the composites in-place via fancier edits to the rendering algo, since that'd allow for more of a transition!

Jan 28 2020, 5:18 PM

Jan 21 2020

bengotow updated the diff for D1860: Basic composite expansion in the Dagit explore tab.

Cleanup & Update tests

Jan 21 2020, 10:10 PM
bengotow added inline comments to D1860: Basic composite expansion in the Dagit explore tab.
Jan 21 2020, 10:04 PM
bengotow updated the summary of D1860: Basic composite expansion in the Dagit explore tab.
Jan 21 2020, 10:00 PM
bengotow created D1860: Basic composite expansion in the Dagit explore tab.
Jan 21 2020, 9:57 PM

Jan 17 2020

bengotow added a comment to D1855: Gaant-style execution plan visualization behind feature flag.

Ahh @alangenfeld that's a good question—for the serial execution engine displaying the dependency graph isn't quite what we want. Could we make the execution plan to include the order it plans to execute steps? Right now the plan doesn't encode enough information for us to know what the true parallelism / timing will look like (at least I don't think?) We could detect the serial execution engine and show them in a waterfall, but we might get the order wrong I think?

Jan 17 2020, 7:46 PM
bengotow updated the diff for D1855: Gaant-style execution plan visualization behind feature flag.
  • Use fewer large nested functions in Gaant layout code
Jan 17 2020, 7:42 PM
bengotow added inline comments to D1855: Gaant-style execution plan visualization behind feature flag.
Jan 17 2020, 6:31 PM
bengotow updated the diff for D1855: Gaant-style execution plan visualization behind feature flag.

Comment Gaant layout algo

Jan 17 2020, 6:28 PM
bengotow updated the summary of D1855: Gaant-style execution plan visualization behind feature flag.
Jan 17 2020, 6:11 PM