Page MenuHomePhabricator

alangenfeld (Alex Langenfeld)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Mar 20 2019, 8:25 PM (61 w, 4 d)
Roles
Administrator

Recent Activity

Yesterday

alangenfeld requested review of D3085: [dagit] launched run termination.
Sun, May 24, 8:39 PM
alangenfeld added inline comments to D3074: (graphql-context-test-suite-2) Add graphql_context_test_suite.
Sun, May 24, 5:32 PM
alangenfeld committed R1:c1dd529b0597: fix sqlite temporary file vs TemporaryDirectory cleanup race (authored by alangenfeld).
fix sqlite temporary file vs TemporaryDirectory cleanup race
Sun, May 24, 5:26 PM
alangenfeld closed D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race.
Sun, May 24, 5:26 PM
alangenfeld updated the summary of D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race.
Sun, May 24, 4:34 PM
alangenfeld added a reviewer for D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race: schrockn.
Sun, May 24, 4:33 PM
alangenfeld updated the test plan for D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race.
Sun, May 24, 4:33 PM
alangenfeld updated the diff for D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race.

up

Sun, May 24, 4:30 PM
alangenfeld updated the summary of D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race.
Sun, May 24, 4:30 PM
alangenfeld added inline comments to D3066: 3/ Introduce @repository decorator.
Sun, May 24, 4:29 PM
alangenfeld updated the summary of D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race.
Sun, May 24, 4:21 PM
alangenfeld updated the diff for D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race.

up

Sun, May 24, 4:14 PM
alangenfeld updated the diff for D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race.

think i got it

Sun, May 24, 4:14 PM
alangenfeld accepted D3059: 2/ Add description field to RepositoryDefinition.

thumbsup

Sun, May 24, 3:52 PM

Fri, May 22

alangenfeld updated the diff for D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race.

up

Fri, May 22, 7:46 PM
alangenfeld retitled D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race from Use wait() instead of communicate() to terminate processes to fix sqlite temporary file vs TemporaryDirectory cleanup race.
Fri, May 22, 7:43 PM
alangenfeld updated the diff for D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race.

up

Fri, May 22, 7:41 PM
alangenfeld updated the diff for D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race.

up

Fri, May 22, 7:12 PM
alangenfeld updated the diff for D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race.

try

Fri, May 22, 7:02 PM
alangenfeld removed a reviewer for D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race: schrockn.
Fri, May 22, 6:25 PM
alangenfeld accepted D3053: Fix expectations misspelling.

slamdunk

Fri, May 22, 5:38 PM
alangenfeld requested changes to D2925: Lakehouse renovation.

ya i think those last few naming bits are the only issues i can see

Fri, May 22, 5:38 PM
alangenfeld commandeered D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race.

ill dig in on this

Fri, May 22, 4:19 PM
alangenfeld requested changes to D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race.

I didnt read close enough - communicate does wait for close. As seen by test failures - the mystery continues.

Fri, May 22, 4:17 PM
alangenfeld accepted D3058: fix sqlite temporary file vs TemporaryDirectory cleanup race.
Fri, May 22, 3:45 PM

Thu, May 21

alangenfeld accepted D3043: Show inconsistent scheduler state errors in dagit.
Thu, May 21, 11:25 PM
alangenfeld accepted D3040: Dauphin spelling.

p sure this was me: i in fact can not spell

Thu, May 21, 10:22 PM
alangenfeld accepted D3034: Add CliApiRunLauncher [redux].
Thu, May 21, 9:19 PM
alangenfeld accepted D3025: Add top level scheduler logging.

ah ok cool thanks

Thu, May 21, 9:14 PM
alangenfeld added a comment to D3025: Add top level scheduler logging.

where is that in the diff i dont see any ref to dev null

Thu, May 21, 8:48 PM
alangenfeld added a comment to D3025: Add top level scheduler logging.

how does this fix the catalina thing?

Thu, May 21, 7:47 PM
alangenfeld accepted D3031: 1/ Add helpers to get cli args from reconstructables.

cool beans

Thu, May 21, 7:47 PM
alangenfeld accepted D3026: (run-launcher-handle-aware-1) Move ReconstructableRepository.from_yaml to CodePointer.from_yaml.

whynot

Thu, May 21, 7:02 PM
alangenfeld accepted D3017: Fix spelling errors in serdes.

spellcheck

Thu, May 21, 6:59 PM
alangenfeld added inline comments to D3019: (run-launcher-handle-aware-2) Add InProcessOrigin (pointer and yaml path). Add to EnvironmentHandle and make it accessible to ExternalRepository.
Thu, May 21, 6:58 PM
alangenfeld accepted D3011: (dagster-cli-api-run-launcher-3) Add CliApiRunLauncher.

limecat

Thu, May 21, 6:57 PM
alangenfeld accepted D3019: (run-launcher-handle-aware-2) Add InProcessOrigin (pointer and yaml path). Add to EnvironmentHandle and make it accessible to ExternalRepository.

but its not that much code were shuffling around so ill let you make the call

Thu, May 21, 6:38 PM
alangenfeld added inline comments to D3019: (run-launcher-handle-aware-2) Add InProcessOrigin (pointer and yaml path). Add to EnvironmentHandle and make it accessible to ExternalRepository.
Thu, May 21, 6:35 PM
alangenfeld accepted D3022: Consolidate ReconstructablePipeline and ReconstructablePipelineFromRepo, eliminate InterProcessExecutablePipeline.

less is more

Thu, May 21, 2:52 PM

Wed, May 20

alangenfeld accepted D2965: Add repo stats to telemetry.

looksgood

Wed, May 20, 10:51 PM
alangenfeld requested changes to D3011: (dagster-cli-api-run-launcher-3) Add CliApiRunLauncher.

looks reasonable so far - think its worth updating this diff til it functions as a proper run launcher

Wed, May 20, 10:43 PM
alangenfeld accepted D2923: Delete all non *orError accessors.

In all of these dagit cases, we're fetching the pipeline in a sub-component where the container component has already fetched the pipeline.
We may hit an error case in which dagit gets into a bad state in between requests, or we hit a framework bug while resolving some downstream piece of data, but these should be extremely rare.

Wed, May 20, 10:41 PM
alangenfeld added inline comments to D3011: (dagster-cli-api-run-launcher-3) Add CliApiRunLauncher.
Wed, May 20, 10:40 PM
alangenfeld accepted D3009: (dagster-cli-api-run-launcher-2) Add cli api for execute_run.

seaking

Wed, May 20, 10:35 PM
alangenfeld closed D2947: RFC - a way to run multiproc engine without sqlite event log.
Wed, May 20, 10:22 PM
alangenfeld committed R1:d353863659e4: RFC - a way to run multiproc engine without sqlite event log (authored by alangenfeld).
RFC - a way to run multiproc engine without sqlite event log
Wed, May 20, 10:22 PM
alangenfeld committed R1:1aeeaf3e296d: (multi-2) selector and handle (authored by alangenfeld).
(multi-2) selector and handle
Wed, May 20, 9:56 PM
alangenfeld closed D3006: (multi-2) selector and handle.
Wed, May 20, 9:56 PM
alangenfeld accepted D3004: Fix ipc windows errors.

There is a deeper issue with the compute_log_manager that I decided to punt on debugging.

Wed, May 20, 8:16 PM
alangenfeld committed R1:2fe8234ee0f9: Fix AWS CLI (authored by nate).
Fix AWS CLI
Wed, May 20, 8:11 PM
alangenfeld updated the diff for D3006: (multi-2) selector and handle.

up

Wed, May 20, 7:26 PM
alangenfeld added inline comments to D3006: (multi-2) selector and handle.
Wed, May 20, 7:25 PM
alangenfeld requested review of D3006: (multi-2) selector and handle.
Wed, May 20, 7:22 PM
alangenfeld updated the summary of D2947: RFC - a way to run multiproc engine without sqlite event log.
Wed, May 20, 3:34 PM
alangenfeld updated the summary of D2947: RFC - a way to run multiproc engine without sqlite event log.
Wed, May 20, 3:33 PM
alangenfeld updated the diff for D2947: RFC - a way to run multiproc engine without sqlite event log.

dont add new class

Wed, May 20, 3:29 PM
alangenfeld accepted D2992: Extract create_db_conn_string.

whynot

Wed, May 20, 3:26 PM
alangenfeld committed R1:643f1e791de3: lay ExecutionSelector to rest (authored by alangenfeld).
lay ExecutionSelector to rest
Wed, May 20, 3:26 PM
alangenfeld closed D2995: lay ExecutionSelector to rest.
Wed, May 20, 3:26 PM
alangenfeld added inline comments to D2965: Add repo stats to telemetry.
Wed, May 20, 3:00 PM
alangenfeld added inline comments to D2965: Add repo stats to telemetry.
Wed, May 20, 3:00 PM
alangenfeld added inline comments to D2947: RFC - a way to run multiproc engine without sqlite event log.
Wed, May 20, 2:53 PM

Tue, May 19

alangenfeld added a reviewer for D2995: lay ExecutionSelector to rest: schrockn.
Tue, May 19, 10:40 PM
alangenfeld requested review of D2995: lay ExecutionSelector to rest.
Tue, May 19, 10:38 PM
alangenfeld added a comment to D2879: RFC: Composite solid subselection.

met to discuss this - @schrockn was able to help outline how using the dotted notation for all composite config (subselected or not) instead of the hierarchal structure or a hybrid would make sense. The example of vscode settings helps us believe this as likely a better end user experience.

Tue, May 19, 6:26 PM
alangenfeld committed R1:f10d371db3ff: (multi-1) multi-env multi-repo DagsterGraphQLContext (authored by alangenfeld).
(multi-1) multi-env multi-repo DagsterGraphQLContext
Tue, May 19, 4:57 PM
alangenfeld closed D2988: (multi-1) multi-env multi-repo DagsterGraphQLContext.
Tue, May 19, 4:57 PM
alangenfeld updated the diff for D2988: (multi-1) multi-env multi-repo DagsterGraphQLContext.

fix dagoit

Tue, May 19, 3:07 PM
alangenfeld updated the diff for D2988: (multi-1) multi-env multi-repo DagsterGraphQLContext.

up

Tue, May 19, 4:04 AM
alangenfeld updated the diff for D2988: (multi-1) multi-env multi-repo DagsterGraphQLContext.

up

Tue, May 19, 3:21 AM
alangenfeld added inline comments to D2980: (execute-pipeline-out-of-process-2) Allow passing of instance-ref to cli.
Tue, May 19, 3:13 AM
alangenfeld added inline comments to D2980: (execute-pipeline-out-of-process-2) Allow passing of instance-ref to cli.
Tue, May 19, 3:13 AM
alangenfeld added inline comments to D2988: (multi-1) multi-env multi-repo DagsterGraphQLContext.
Tue, May 19, 3:10 AM
alangenfeld added inline comments to D2980: (execute-pipeline-out-of-process-2) Allow passing of instance-ref to cli.
Tue, May 19, 3:07 AM
alangenfeld accepted D2987: (execute-pipeline-out-of-process-4) Move CodePointer classes in dagster.core.codepointer.

codepointer is a little awkward - cant think of anything better though. Maybe code_pointer?

Tue, May 19, 3:05 AM
alangenfeld updated the summary of D2988: (multi-1) multi-env multi-repo DagsterGraphQLContext.
Tue, May 19, 3:01 AM
alangenfeld retitled D2988: (multi-1) multi-env multi-repo DagsterGraphQLContext from [WIP] multi repo to (multi-1) multi-env multi-repo DagsterGraphQLContext.
Tue, May 19, 3:00 AM
alangenfeld requested review of D2988: (multi-1) multi-env multi-repo DagsterGraphQLContext.
Tue, May 19, 3:00 AM
alangenfeld committed R1:196cfeecb664: [0.8.0] delete schedules & partitions handles (authored by alangenfeld).
[0.8.0] delete schedules & partitions handles
Tue, May 19, 2:49 AM
alangenfeld closed D2709: [0.8.0] delete schedules & partitions handles.
Tue, May 19, 2:49 AM
alangenfeld added a comment to D2986: Kill backwards compat schedules and partitions loading path.

https://dagster.phacility.com/D2709

Tue, May 19, 2:47 AM
alangenfeld accepted D2985: More spelling fixes.

spellcheck

Tue, May 19, 2:34 AM
alangenfeld created Image Macro "spellcheck".
Tue, May 19, 2:33 AM
alangenfeld added a comment to D2965: Add repo stats to telemetry.

I definitely think this is better than trying to re-derive the pipeline from the function args

Tue, May 19, 2:06 AM
alangenfeld accepted D2983: Update serdes.ipc tests to use safe_tempfile.

pikachu

Tue, May 19, 1:48 AM

Mon, May 18

alangenfeld accepted D2979: Fix invalid config schedule execution.

facepalm

Mon, May 18, 10:19 PM
alangenfeld updated the diff for D2709: [0.8.0] delete schedules & partitions handles.

up

Mon, May 18, 8:47 PM

Fri, May 15

alangenfeld added a comment to D2879: RFC: Composite solid subselection.

Did you guys see the picture i drew in an earlier comment? I have a hard time reconciling a mental model that makes sense for subsetting in to a composite where maintaining the original config structure makes sense. I agree that this is a gnarly user experience - but I think its because subsetting in to a composite is fundamentally complex and that complexity is accurately exposed to the user. I think maintaining the config structure will mask the complexity causing greater confusion.

Fri, May 15, 7:59 PM
alangenfeld added a comment to D2879: RFC: Composite solid subselection.

woah nice work on the comments - thats really nice. I would like @prha / @schrockn to also take a pass, mostly for opinion on the design choices highlighted in summary.

Fri, May 15, 5:12 PM
alangenfeld accepted D2952: Add scheduled large pipeline to test project.

should be fine but would be nice to have the motivation written down in the diff summary

Fri, May 15, 1:57 AM
alangenfeld requested changes to D2956: Get absolute path to repository for schedule.

can we do this at ReconstructableRepo creation instead? Lets take the time to figure out how to have a test in place for this

Fri, May 15, 1:55 AM
alangenfeld accepted D2953: Improve scheduler debug and reconciliation.
Fri, May 15, 1:53 AM

Thu, May 14

alangenfeld committed R1:8536c1e2c92e: 0.7.13 (authored by alangenfeld).
0.7.13
Thu, May 14, 11:09 PM
alangenfeld committed R1:435c3f94da15: 0.7.13.pre0 (authored by alangenfeld).
0.7.13.pre0
Thu, May 14, 10:41 PM
alangenfeld accepted D2949: (helm) Fix imagePullPolicy reference.
Thu, May 14, 10:27 PM
alangenfeld accepted D2951: [0.7.13] add version mismatch warning.

illallowit

Thu, May 14, 10:16 PM
alangenfeld accepted D2946: [0.7.13] Improve scheduler debug and reconciliation.

redfordnod

Thu, May 14, 10:01 PM
alangenfeld committed R1:828410232eeb: Use mode and solid subset from partition set in backfill (authored by sashank).
Use mode and solid subset from partition set in backfill
Thu, May 14, 9:53 PM
alangenfeld requested review of D2947: RFC - a way to run multiproc engine without sqlite event log.
Thu, May 14, 9:28 PM
alangenfeld accepted D2944: [0.7.13] Supports loading Airflow dags without depending on initialized Airflow db.

rubberstamp

Thu, May 14, 8:40 PM