Page MenuHomePhabricator

alangenfeld (Alex Langenfeld)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Mar 20 2019, 8:25 PM (43 w, 2 d)
Roles
Administrator

Recent Activity

Today

alangenfeld updated the diff for D1856: [codemod] yaml.load -> yaml.safe_load.

canary

Sat, Jan 18, 2:32 AM
alangenfeld committed R1:30f95699bb68: [k8s] dont hardcode service account name (authored by alangenfeld).
[k8s] dont hardcode service account name
Sat, Jan 18, 2:22 AM
alangenfeld closed D1858: [k8s] dont hardcode service account name.
Sat, Jan 18, 2:22 AM
alangenfeld updated the diff for D1858: [k8s] dont hardcode service account name.

set service account name

Sat, Jan 18, 2:09 AM
alangenfeld added a comment to D1857: BUGFIX: Ensure SubprocessExecutionManager isn't leaking POSIX semaphores.

I would just look through the other tests in dagster_graphql - python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_run_cancellation.py is probably a relevant example

Sat, Jan 18, 1:31 AM
alangenfeld updated the diff for D1858: [k8s] dont hardcode service account name.

god damn yaml templates

Sat, Jan 18, 12:30 AM
alangenfeld updated the diff for D1858: [k8s] dont hardcode service account name.

rebase

Sat, Jan 18, 12:20 AM
alangenfeld added inline comments to D1857: BUGFIX: Ensure SubprocessExecutionManager isn't leaking POSIX semaphores.
Sat, Jan 18, 12:19 AM

Yesterday

alangenfeld added inline comments to D1849: Improve local test story.
Fri, Jan 17, 11:45 PM
alangenfeld created D1858: [k8s] dont hardcode service account name.
Fri, Jan 17, 11:14 PM
alangenfeld created D1856: [codemod] yaml.load -> yaml.safe_load.
Fri, Jan 17, 8:17 PM
alangenfeld added a comment to D1855: Gaant-style execution plan visualization behind feature flag.

just spitballing ideas one thing we could do is keep the box pinned but to the left but change where the shading starts? What i want visually communicated when these things are waiting on eachother for not-data reasons is:

Fri, Jan 17, 8:04 PM
alangenfeld added a comment to D1855: Gaant-style execution plan visualization behind feature flag.

from use - if you execute the sleepy toy pipeline with the default config which uses inprocess engine - the four parallel steps happen sequentially which is not communicated in the waterfall timed view at all since we pin no the left alignment. Is this something worth addressing now or in a subsequent diff?

Fri, Jan 17, 7:35 PM
alangenfeld added inline comments to D1855: Gaant-style execution plan visualization behind feature flag.
Fri, Jan 17, 6:27 PM

Thu, Jan 16

alangenfeld accepted D1832: RFC: Update TypeStoragePluginRegistry to take list of tuples instead of dict.

this seems fine, double check if you need to add the check stuff

Thu, Jan 16, 10:53 PM
alangenfeld committed R1:64eb38facc20: remove deprecated ReexecutionConfig (authored by alangenfeld).
remove deprecated ReexecutionConfig
Thu, Jan 16, 10:02 PM
alangenfeld closed D1852: remove deprecated ReexecutionConfig.
Thu, Jan 16, 10:02 PM
alangenfeld closed D1847: [dagit] handle engine event errors.
Thu, Jan 16, 9:56 PM
alangenfeld committed R1:826f50a6639e: [dagit] handle engine event errors (authored by alangenfeld).
[dagit] handle engine event errors
Thu, Jan 16, 9:56 PM
alangenfeld committed R1:53f858f49b85: [celery] emit engine event on failed broker connection (authored by alangenfeld).
[celery] emit engine event on failed broker connection
Thu, Jan 16, 9:56 PM
alangenfeld closed D1846: [celery] emit engine event on failed broker connection.
Thu, Jan 16, 9:56 PM
alangenfeld updated the diff for D1853: handle differing arg and input def ordering.

special case singurlar input_def

Thu, Jan 16, 9:47 PM
alangenfeld planned changes to D1853: handle differing arg and input def ordering.
Thu, Jan 16, 6:50 PM
alangenfeld added a reviewer for D1765: Fix issue with pyspark_solid decorator not handling inputs: max.
Thu, Jan 16, 6:46 PM
alangenfeld updated the diff for D1765: Fix issue with pyspark_solid decorator not handling inputs.

rebaesw

Thu, Jan 16, 6:46 PM
alangenfeld commandeered D1765: Fix issue with pyspark_solid decorator not handling inputs.
Thu, Jan 16, 6:45 PM
alangenfeld created D1853: handle differing arg and input def ordering.
Thu, Jan 16, 6:33 PM
alangenfeld updated the diff for D1852: remove deprecated ReexecutionConfig.

rm print()

Thu, Jan 16, 5:49 PM
alangenfeld updated the diff for D1852: remove deprecated ReexecutionConfig.

update serdes and seven to better handle py2

Thu, Jan 16, 5:38 PM
alangenfeld accepted D1849: Improve local test story.

nice - just make sure to cleanup unused stuff

Thu, Jan 16, 5:08 PM
alangenfeld created D1852: remove deprecated ReexecutionConfig.
Thu, Jan 16, 4:29 PM
alangenfeld updated the diff for D1847: [dagit] handle engine event errors.

rebase + comment

Thu, Jan 16, 4:17 PM

Wed, Jan 15

alangenfeld added inline comments to D1844: RFC: Eliminate ConfigMappingContext.
Wed, Jan 15, 10:19 PM
alangenfeld added a comment to D1844: RFC: Eliminate ConfigMappingContext.

it seems like something bad is happening in changed.md thats causing the autoformatter to go nuts

Wed, Jan 15, 10:10 PM
alangenfeld added inline comments to D1846: [celery] emit engine event on failed broker connection.
Wed, Jan 15, 10:05 PM
alangenfeld created D1847: [dagit] handle engine event errors.
Wed, Jan 15, 10:01 PM
alangenfeld added a comment to D1846: [celery] emit engine event on failed broker connection.

Wed, Jan 15, 10:01 PM
alangenfeld created D1846: [celery] emit engine event on failed broker connection.
Wed, Jan 15, 9:59 PM
alangenfeld committed R1:e9e17639631b: [core] rework engine requirments checks (authored by alangenfeld).
[core] rework engine requirments checks
Wed, Jan 15, 4:05 PM
alangenfeld closed D1842: [core] rework engine requirments checks.
Wed, Jan 15, 4:05 PM

Tue, Jan 14

alangenfeld updated the summary of D1842: [core] rework engine requirments checks.
Tue, Jan 14, 9:55 PM
alangenfeld created D1842: [core] rework engine requirments checks.
Tue, Jan 14, 9:53 PM
alangenfeld accepted D1841: Rerun snapshots.
Tue, Jan 14, 9:53 PM
alangenfeld accepted D1828: More clear name properties for config types and graphql scalar union support.

Macro limecat:  PROCEED

Tue, Jan 14, 9:19 PM
alangenfeld accepted D1840: Check for duplicative runtime type names.

okay

Tue, Jan 14, 8:39 PM
alangenfeld committed R1:381c24186d85: [dagster-celery] cleanup default application (authored by alangenfeld).
[dagster-celery] cleanup default application
Tue, Jan 14, 8:35 PM
alangenfeld closed D1839: [dagster-celery] cleanup default application.
Tue, Jan 14, 8:35 PM
alangenfeld committed R1:e28245d47ba1: improve engine check error copy (authored by alangenfeld).
improve engine check error copy
Tue, Jan 14, 7:48 PM
alangenfeld closed D1838: improve engine check error copy.
Tue, Jan 14, 7:48 PM
alangenfeld updated the diff for D1839: [dagster-celery] cleanup default application.

lint

Tue, Jan 14, 7:47 PM
alangenfeld created D1839: [dagster-celery] cleanup default application.
Tue, Jan 14, 6:35 PM
alangenfeld created D1838: improve engine check error copy.
Tue, Jan 14, 6:34 PM

Mon, Jan 13

alangenfeld committed R1:7ccd4121f667: [ConfigClass] remove kwargs on from_config_value (authored by alangenfeld).
[ConfigClass] remove kwargs on from_config_value
Mon, Jan 13, 9:05 PM
alangenfeld closed D1831: [ConfigClass] remove kwargs on from_config_value.
Mon, Jan 13, 9:05 PM
alangenfeld committed R1:9080a545f9c7: [dagster-postgres] update config to Selector (authored by alangenfeld).
[dagster-postgres] update config to Selector
Mon, Jan 13, 9:04 PM
alangenfeld closed D1830: [dagster-postgres] update config to Selector.
Mon, Jan 13, 9:04 PM
alangenfeld updated the diff for D1831: [ConfigClass] remove kwargs on from_config_value.

rebase

Mon, Jan 13, 7:29 PM
alangenfeld updated the diff for D1830: [dagster-postgres] update config to Selector.

black

Mon, Jan 13, 7:29 PM
alangenfeld updated the diff for D1830: [dagster-postgres] update config to Selector.

use correct fixture

Mon, Jan 13, 7:24 PM
alangenfeld updated the diff for D1830: [dagster-postgres] update config to Selector.

use conn_string to get DB fixture

Mon, Jan 13, 7:18 PM
alangenfeld resigned from D1829: Fix runtime type comparison.

defer to @schrockn since I think i missed the last part of the convo on determining the best approach

Mon, Jan 13, 7:01 PM
alangenfeld updated the diff for D1830: [dagster-postgres] update config to Selector.

rm debug

Mon, Jan 13, 6:58 PM
alangenfeld updated the diff for D1830: [dagster-postgres] update config to Selector.

py2

Mon, Jan 13, 6:53 PM
alangenfeld created D1831: [ConfigClass] remove kwargs on from_config_value.
Mon, Jan 13, 6:50 PM
alangenfeld created D1830: [dagster-postgres] update config to Selector.
Mon, Jan 13, 6:35 PM
alangenfeld accepted D1827: (new-types-package-org-7) Minor cleanup on ConfigType.

nice

Mon, Jan 13, 4:28 PM
alangenfeld accepted D1826: (new-types-package-org-6) Eliminate ConfigTypeAttributes.

thumbsup

Mon, Jan 13, 4:26 PM
alangenfeld accepted D1825: (new-types-package-org-5) Eliminate is_system_config.

cleanup

Mon, Jan 13, 4:26 PM
alangenfeld accepted D1824: (new-types-package-org-4) Make name more clear. Eliminate named dicts and selectors.
Mon, Jan 13, 4:26 PM
alangenfeld accepted D1823: (new-types-package-org-3) Move dagster.core.types.runtime to dagster.core.types.

whynot

Mon, Jan 13, 4:22 PM
alangenfeld accepted D1822: (new-types-package-org-2) Make builtin mapping stuff a top-level submodule.

shims maybe? builtins on its own just doesn't mean much

Mon, Jan 13, 4:21 PM
alangenfeld accepted D1821: (new-types-package-org-1) dagster.core.types.config --> dagster.config.

movingshitaround

Mon, Jan 13, 4:16 PM
alangenfeld resigned from D1798: Replace playground subset selector with one that leverages solid query syntax.

let @prha take this one

Mon, Jan 13, 4:15 PM

Fri, Jan 10

alangenfeld committed R1:26ee1fce41c6: [k8s] misc fixes (authored by alangenfeld).
[k8s] misc fixes
Fri, Jan 10, 1:57 AM
alangenfeld closed D1813: [k8s] misc fixes.
Fri, Jan 10, 1:57 AM
alangenfeld updated the diff for D1813: [k8s] misc fixes.

rebase

Fri, Jan 10, 1:39 AM

Thu, Jan 9

alangenfeld accepted D1815: Revert "issue-2042 :: Convert calls to yaml.load (#2051)".

sadface

Thu, Jan 9, 11:46 PM
alangenfeld updated the diff for D1813: [k8s] misc fixes.

up

Thu, Jan 9, 11:43 PM
alangenfeld accepted D1805: (dict-where-type-is-used-6) Rename config list to array in graphql and dagit.

test plan
BK

Thu, Jan 9, 11:25 PM
alangenfeld updated the diff for D1813: [k8s] misc fixes.

fix

Thu, Jan 9, 11:02 PM
alangenfeld accepted D1812: (dict-where-type-is-used-10) Eliminate wrapping subpackage.

burn-it-down

Thu, Jan 9, 11:00 PM
alangenfeld accepted D1796: (dict-where-type-is-used-1) Allow usage of raw dict where config_type is expected; improve and simplify error handling.
Thu, Jan 9, 10:59 PM
alangenfeld added a comment to D1810: (dict-where-type-is-used-9) Optional --> Noneable.

is Nullable going to newish python only users up since there is no notion of null ? I think Noneable is worth discussing. Going to leave this one open for more debate

Thu, Jan 9, 10:56 PM
alangenfeld accepted D1807: (dict-where-type-is-used-8) Shape --> Dict.

im down - I'll go ahead and accept but probably worth double checking with @max if you want more thoughts

Thu, Jan 9, 10:55 PM
alangenfeld accepted D1795: load dagit settings for queueing execution manager from dagster.yaml.

Update [1] then good to go I think

Thu, Jan 9, 10:50 PM
alangenfeld accepted D1804: (dict-where-type-is-used-5) Rename Config List to Array.
Thu, Jan 9, 10:47 PM
alangenfeld accepted D1806: (dict-where-type-is-used-7) Remove superfluous build_config_dict function.
Thu, Jan 9, 10:44 PM
alangenfeld accepted D1814: Fix isort.

gogogo

Thu, Jan 9, 10:44 PM
alangenfeld accepted D1803: (dict-where-type-is-used-4) Eliminate wrapping tuple.

redparty

Thu, Jan 9, 10:32 PM
alangenfeld accepted D1802: (dict-where-type-is-used-3) Eliminate wrapping set.

byebye

Thu, Jan 9, 10:31 PM
alangenfeld accepted D1801: (dict-where-type-is-used-2) Allow list in config.

goforit

Thu, Jan 9, 10:29 PM
alangenfeld added inline comments to D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.
Thu, Jan 9, 10:23 PM
alangenfeld requested changes to D1796: (dict-where-type-is-used-1) Allow usage of raw dict where config_type is expected; improve and simplify error handling.

for the error messages I agree that we can tolerate losing the bit of context since the stack trace should point you in the right direction - but I think we can do better than whats in the diff as it stands

Thu, Jan 9, 10:21 PM
alangenfeld accepted D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.

prettygood

Thu, Jan 9, 10:09 PM
alangenfeld created Image Macro "prettygood".
Thu, Jan 9, 10:09 PM
alangenfeld committed R1:679099bd6759: delete symlinks (authored by alangenfeld).
delete symlinks
Thu, Jan 9, 10:05 PM
alangenfeld closed D1808: delete symlinks.
Thu, Jan 9, 10:05 PM
alangenfeld created D1813: [k8s] misc fixes.
Thu, Jan 9, 9:57 PM
alangenfeld added a comment to D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.

What do you think about having two contexts: ScheduleExecutionContext to pass to the schedule methods, and PartitionSelectionContext for the partition selector?
Ideally, we could just pass the DagsterGraphQLContext around

Thu, Jan 9, 9:27 PM
alangenfeld accepted D1811: Push integration images to DockerHub.

push_n_pray

Thu, Jan 9, 9:00 PM