Page MenuHomePhabricator

alangenfeld (Alex Langenfeld)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Mar 20 2019, 8:25 PM (47 w, 6 d)
Roles
Administrator

Recent Activity

Today

alangenfeld updated the diff for D2072: [dagit] improve event log tags.

rebase

Wed, Feb 19, 12:02 AM

Yesterday

alangenfeld updated the test plan for D2072: [dagit] improve event log tags.
Tue, Feb 18, 10:30 PM
alangenfeld updated the test plan for D2072: [dagit] improve event log tags.
Tue, Feb 18, 10:29 PM
alangenfeld created D2072: [dagit] improve event log tags.
Tue, Feb 18, 10:28 PM
alangenfeld added inline comments to D2070: [dagit] surface Failure metadata.
Tue, Feb 18, 10:09 PM
alangenfeld updated the test plan for D2070: [dagit] surface Failure metadata.
Tue, Feb 18, 10:08 PM
alangenfeld retitled D2070: [dagit] surface Failure metadata from surface Failure metadata to [dagit] surface Failure metadata.
Tue, Feb 18, 10:08 PM
alangenfeld created D2070: [dagit] surface Failure metadata.
Tue, Feb 18, 10:07 PM
alangenfeld updated the diff for D2067: ActiveExecution cleanup.

rebase

Tue, Feb 18, 9:02 PM
alangenfeld requested changes to D2061: [dagster-k8s] Remove hardcoded dagster home.

based on in person talk it sounds like you were going to toy around with this a bit

Tue, Feb 18, 7:35 PM
alangenfeld created D2068: retry prototype V0.
Tue, Feb 18, 7:24 PM
alangenfeld created D2067: ActiveExecution cleanup.
Tue, Feb 18, 6:49 PM
alangenfeld added inline comments to D2061: [dagster-k8s] Remove hardcoded dagster home.
Tue, Feb 18, 4:22 PM

Mon, Feb 17

alangenfeld committed R1:19cd04f95340: [dagit] fix errored step exec time (authored by alangenfeld).
[dagit] fix errored step exec time
Mon, Feb 17, 8:49 PM
alangenfeld closed D2059: [dagit] fix errored step exec time.
Mon, Feb 17, 8:49 PM
alangenfeld updated the summary of D2059: [dagit] fix errored step exec time.
Mon, Feb 17, 5:23 PM
alangenfeld created D2059: [dagit] fix errored step exec time.
Mon, Feb 17, 5:22 PM
alangenfeld committed R1:e9298abc1a13: improve error when using DagsterType in config (authored by alangenfeld).
improve error when using DagsterType in config
Mon, Feb 17, 4:39 PM
alangenfeld closed D2050: improve error when using DagsterType in config.
Mon, Feb 17, 4:39 PM
alangenfeld accepted D2053: [Helm] Retrieve PG password from environment vs. hard-coding it.

we can add the others in a follow if we decide to

Mon, Feb 17, 4:38 PM

Fri, Feb 14

alangenfeld accepted D2052: Fix bug in config post-processing.

nice good catch

Fri, Feb 14, 10:48 PM
alangenfeld updated the diff for D2050: improve error when using DagsterType in config.

more better

Fri, Feb 14, 10:28 PM
alangenfeld planned changes to D2050: improve error when using DagsterType in config.

good call

Fri, Feb 14, 10:13 PM
alangenfeld updated the diff for D2050: improve error when using DagsterType in config.

pylint 2

Fri, Feb 14, 10:09 PM
alangenfeld updated the diff for D2050: improve error when using DagsterType in config.

pylint

Fri, Feb 14, 9:51 PM
alangenfeld created D2050: improve error when using DagsterType in config.
Fri, Feb 14, 9:25 PM
alangenfeld accepted D2049: Update the Java JDK version and Helm in integration image builds.

squirtle

Fri, Feb 14, 5:24 PM
alangenfeld accepted D2045: Fix line number spacing.

whynot

Fri, Feb 14, 4:21 PM
alangenfeld committed R1:0cd01baa7b21: tutorial link (authored by alangenfeld).
tutorial link
Fri, Feb 14, 2:51 AM
alangenfeld committed R1:9e80d97fe7ab: fix k8s bk setup (authored by alangenfeld).
fix k8s bk setup
Fri, Feb 14, 1:14 AM
alangenfeld closed D2048: fix k8s bk setup.
Fri, Feb 14, 1:14 AM
alangenfeld abandoned D2047: integration image update.
Fri, Feb 14, 1:07 AM
alangenfeld added reviewers for D2048: fix k8s bk setup: max, nate.
Fri, Feb 14, 1:04 AM
alangenfeld created D2048: fix k8s bk setup.
Fri, Feb 14, 1:00 AM
alangenfeld created D2047: integration image update.
Fri, Feb 14, 12:56 AM

Thu, Feb 13

alangenfeld committed R1:89a9198133b8: fix missing args in pipeline run roundtrip (authored by alangenfeld).
fix missing args in pipeline run roundtrip
Thu, Feb 13, 9:25 PM
alangenfeld closed D2042: fix missing args in pipeline run roundtrip.
Thu, Feb 13, 9:25 PM
alangenfeld updated the diff for D2042: fix missing args in pipeline run roundtrip.

dont delete to_selector

Thu, Feb 13, 8:58 PM
alangenfeld updated the diff for D2042: fix missing args in pipeline run roundtrip.

future proofing

Thu, Feb 13, 8:37 PM
alangenfeld created D2042: fix missing args in pipeline run roundtrip.
Thu, Feb 13, 8:26 PM
alangenfeld closed D2039: use source import from dagster.seven.
Thu, Feb 13, 7:33 PM
alangenfeld committed R1:dc07b40ed02a: use source import from dagster.seven (authored by alangenfeld).
use source import from dagster.seven
Thu, Feb 13, 7:33 PM
alangenfeld committed R1:6117fcb8ebc7: [docs] add slack link to community section (authored by alangenfeld).
[docs] add slack link to community section
Thu, Feb 13, 7:33 PM
alangenfeld closed D2041: [docs] add slack link to community section.
Thu, Feb 13, 7:33 PM
alangenfeld created D2041: [docs] add slack link to community section.
Thu, Feb 13, 7:13 PM
alangenfeld accepted D2040: Docs nits.
Thu, Feb 13, 7:05 PM
alangenfeld updated the diff for D2039: use source import from dagster.seven.

...rebase

Thu, Feb 13, 6:58 PM
alangenfeld added inline comments to D2039: use source import from dagster.seven.
Thu, Feb 13, 6:36 PM
alangenfeld created D2039: use source import from dagster.seven.
Thu, Feb 13, 6:28 PM
alangenfeld committed R1:0fc1a8b02b57: 0.7.0 (authored by alangenfeld).
0.7.0
Thu, Feb 13, 12:18 AM
alangenfeld committed R1:c985e9497180: 0.7.0rc1 (authored by alangenfeld).
0.7.0rc1
Thu, Feb 13, 12:18 AM
alangenfeld accepted D2036: Update changelog.

rubberstamp

Thu, Feb 13, 12:06 AM

Wed, Feb 12

alangenfeld accepted D2035: add scheduler storage sqlite to manifest.
Wed, Feb 12, 11:58 PM
alangenfeld accepted D2034: Add scheduler migration guide.

fearow

Wed, Feb 12, 11:47 PM
alangenfeld closed D2031: solid metadata -> tags.
Wed, Feb 12, 11:29 PM
alangenfeld committed R1:4d4bbe89eff6: solid metadata -> tags (authored by alangenfeld).
solid metadata -> tags
Wed, Feb 12, 11:29 PM
alangenfeld updated the summary of D2031: solid metadata -> tags.
Wed, Feb 12, 11:29 PM
alangenfeld created D2031: solid metadata -> tags.
Wed, Feb 12, 11:16 PM
alangenfeld committed R1:471e73396392: [dagit] handle errors in DirectGraphQLSubscription (authored by alangenfeld).
[dagit] handle errors in DirectGraphQLSubscription
Wed, Feb 12, 11:12 PM
alangenfeld closed D2024: [dagit] handle errors in DirectGraphQLSubscription.
Wed, Feb 12, 11:12 PM
alangenfeld accepted D2030: Ensure zoom-to-fit scale is always >0 [2152].

Macro khan:  MAAAAATH

Wed, Feb 12, 11:09 PM
alangenfeld updated the diff for D2024: [dagit] handle errors in DirectGraphQLSubscription.

fixes

Wed, Feb 12, 10:58 PM
alangenfeld accepted D2027: make all run buttons launch enabled.

push_n_pray

Wed, Feb 12, 10:57 PM
alangenfeld added inline comments to D2027: make all run buttons launch enabled.
Wed, Feb 12, 10:54 PM
alangenfeld updated the diff for D2024: [dagit] handle errors in DirectGraphQLSubscription.

handle the empty case better

Wed, Feb 12, 10:50 PM
alangenfeld accepted D2025: Updates for 0.7.0 changelog.
Wed, Feb 12, 10:12 PM
alangenfeld accepted D2022: 0.7.0 Changelog reorg + schrockn additions.
Wed, Feb 12, 10:12 PM
alangenfeld accepted D2021: Update migration guide for RunConfig.
Wed, Feb 12, 10:09 PM
alangenfeld accepted D2023: fixed mismatched lines.

winclap

Wed, Feb 12, 9:54 PM
alangenfeld updated the diff for D2024: [dagit] handle errors in DirectGraphQLSubscription.

issue # + rm debug

Wed, Feb 12, 9:51 PM
alangenfeld created D2024: [dagit] handle errors in DirectGraphQLSubscription.
Wed, Feb 12, 9:47 PM
alangenfeld committed R1:e0c6aee8aec9: [k8s] remove (mis)hardcoded job-env config map (authored by alangenfeld).
[k8s] remove (mis)hardcoded job-env config map
Wed, Feb 12, 9:27 PM
alangenfeld closed D2019: [k8s] remove (mis)hardcoded job-env config map.
Wed, Feb 12, 9:27 PM
alangenfeld accepted D2020: Helm values.yaml rename job_image -> job_runner.

check k8s.rst as well but p sure thats fine

Wed, Feb 12, 8:45 PM
alangenfeld added a comment to D2020: Helm values.yaml rename job_image -> job_runner.

hit the README too https://dagster.phacility.com/source/dagster/browse/master/python_modules/libraries/dagster-k8s/README.md$32-33

Wed, Feb 12, 8:44 PM
alangenfeld updated the diff for D2019: [k8s] remove (mis)hardcoded job-env config map.

[]

Wed, Feb 12, 8:43 PM
alangenfeld updated the diff for D2019: [k8s] remove (mis)hardcoded job-env config map.

fix test?

Wed, Feb 12, 8:07 PM
alangenfeld created D2019: [k8s] remove (mis)hardcoded job-env config map.
Wed, Feb 12, 8:07 PM
alangenfeld accepted D2018: Use local artifacts storage for Scheduler.

config: {} is strange yaml - should just be config: but hopefully you can just omit the key all together

Wed, Feb 12, 7:15 PM
alangenfeld added inline comments to D1999: [Helm 2/N] More Helm fixes.
Wed, Feb 12, 7:11 PM
alangenfeld added inline comments to D1999: [Helm 2/N] More Helm fixes.
Wed, Feb 12, 7:04 PM
alangenfeld added a comment to D2018: Use local artifacts storage for Scheduler.

otherwise code looks good

Wed, Feb 12, 6:59 PM
alangenfeld requested changes to D2018: Use local artifacts storage for Scheduler.

k8s is gonna break - also make sure no docs or comments refer to it if we're dropping it

Wed, Feb 12, 6:59 PM
alangenfeld accepted D2017: resolve tags type error.

nice

Wed, Feb 12, 6:50 PM
alangenfeld accepted D2015: Rework Airflow docs.
Wed, Feb 12, 6:32 PM
alangenfeld accepted D2016: Add type check to migration guide.

thumbsup

Wed, Feb 12, 6:31 PM
alangenfeld added a comment to D2009: Per live discussions, remove usable types from libraries (Verbose bay bikes version).

in the spirit of having one diff that demonstrates "heres why mapping can be useful" I think thats probably a good exercise but be judicious with your time

Wed, Feb 12, 6:31 PM
alangenfeld accepted D2012: Basic docs for dagster-k8s.

cool

Wed, Feb 12, 5:11 PM
alangenfeld accepted D2011: Fix Celery configuration issue.
Wed, Feb 12, 3:57 PM
alangenfeld added a comment to D2009: Per live discussions, remove usable types from libraries (Verbose bay bikes version).

ya no rush - just accepted based on my comment on D1996 for reference

Wed, Feb 12, 1:58 AM
alangenfeld accepted D2003: Fix up config docblocks and extract config out of core types documentation.

make sure to check the docs build for warnings - i recently re-did all the indenting on these to fix warnings there

Wed, Feb 12, 1:57 AM
alangenfeld accepted D2009: Per live discussions, remove usable types from libraries (Verbose bay bikes version).
Wed, Feb 12, 1:55 AM
alangenfeld added a comment to D1996: Per live discussions, remove usable types from libraries.

You then see multiple different ways to use and propagate custom type

Wed, Feb 12, 1:55 AM
alangenfeld added a comment to D1997: Rework Gaant for performant rendering on large DAGs, add sidebar, polish.

Test failures appear spurious?

Wed, Feb 12, 1:31 AM
alangenfeld accepted D2006: Document the Celery executor.
Wed, Feb 12, 1:20 AM
alangenfeld accepted D1967: Dagster Type Guide.

this is within striking distance - accepting so you can proceed at your discretion

Wed, Feb 12, 1:13 AM
alangenfeld committed R1:eb90b7652d26: [core] add context to type_checks (authored by alangenfeld).
[core] add context to type_checks
Wed, Feb 12, 12:47 AM
alangenfeld closed D1768: [core] add context to type_checks.
Wed, Feb 12, 12:47 AM

Tue, Feb 11

alangenfeld updated the diff for D1768: [core] add context to type_checks.

more tutorial fixes

Tue, Feb 11, 11:00 PM
alangenfeld committed R1:9baf9c06b28e: [dagit] dont fetch envYaml on load in runs page (authored by alangenfeld).
[dagit] dont fetch envYaml on load in runs page
Tue, Feb 11, 10:51 PM