Page MenuHomePhabricator

aj.nadel (AJ Nadel)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 13 2020, 1:31 AM (8 w, 4 d)

Recent Activity

Yesterday

aj.nadel added inline comments to D4157: better configured error messages & docs.
Tue, Aug 11, 7:59 PM
aj.nadel added a reviewer for D4157: better configured error messages & docs: sandyryza.
Tue, Aug 11, 7:57 PM
aj.nadel requested review of D4157: better configured error messages & docs.
Tue, Aug 11, 6:45 PM
aj.nadel requested review of D4154: WIP implement composite solids.
Tue, Aug 11, 12:20 AM

Mon, Aug 10

aj.nadel updated the diff for D4129: implement configured intermediate_storage, system_storage.

black

Mon, Aug 10, 11:02 PM
aj.nadel updated the diff for D4129: implement configured intermediate_storage, system_storage.

up

Mon, Aug 10, 10:33 PM
aj.nadel requested review of D4129: implement configured intermediate_storage, system_storage.
Mon, Aug 10, 6:23 PM

Thu, Aug 6

aj.nadel committed R1:e6745d95c531: fix {mem,fs}_intermediate_storage docs and export (authored by aj.nadel).
fix {mem,fs}_intermediate_storage docs and export
Thu, Aug 6, 9:05 PM
aj.nadel closed D4072: fix {mem,fs}_intermediate_storage docs and export.
Thu, Aug 6, 9:05 PM
aj.nadel committed R1:0a7d8f888070: implement configured logger, executor (authored by aj.nadel).
implement configured logger, executor
Thu, Aug 6, 8:40 PM
aj.nadel closed D4103: implement configured logger, executor.
Thu, Aug 6, 8:40 PM
aj.nadel updated the diff for D4103: implement configured logger, executor.

rebase

Thu, Aug 6, 8:40 PM
aj.nadel updated the diff for D4072: fix {mem,fs}_intermediate_storage docs and export.

rebase

Thu, Aug 6, 8:17 PM
aj.nadel updated the diff for D4103: implement configured logger, executor.

add check

Thu, Aug 6, 8:09 PM
aj.nadel committed R1:f0be851d5e64: implement configurable (pure) solids (authored by aj.nadel).
implement configurable (pure) solids
Thu, Aug 6, 7:59 PM
aj.nadel closed D4024: implement configurable (pure) solids.
Thu, Aug 6, 7:59 PM
aj.nadel closed D4022: refactor configured implementation + more docs.
Thu, Aug 6, 7:55 PM
aj.nadel committed R1:2728e0dbdc68: refactor configured implementation + more docs (authored by aj.nadel).
refactor configured implementation + more docs
Thu, Aug 6, 7:55 PM
aj.nadel updated the diff for D4103: implement configured logger, executor.

rebase

Thu, Aug 6, 7:50 PM
aj.nadel updated the diff for D4024: implement configurable (pure) solids.

rebase

Thu, Aug 6, 7:10 PM
aj.nadel updated the diff for D4022: refactor configured implementation + more docs.

rebase

Thu, Aug 6, 7:10 PM
aj.nadel updated the diff for D4103: implement configured logger, executor.

remove non-ascii character :(x

Thu, Aug 6, 6:49 PM
aj.nadel added inline comments to D4103: implement configured logger, executor.
Thu, Aug 6, 6:31 PM
aj.nadel added inline comments to D4103: implement configured logger, executor.
Thu, Aug 6, 6:27 PM
aj.nadel updated the diff for D4103: implement configured logger, executor.

address comments by @sandyryza and @max

Thu, Aug 6, 6:26 PM
aj.nadel updated the diff for D4103: implement configured logger, executor.

up

Thu, Aug 6, 12:41 AM

Wed, Aug 5

aj.nadel requested review of D4103: implement configured logger, executor.
Wed, Aug 5, 8:23 PM

Tue, Aug 4

aj.nadel added inline comments to D4022: refactor configured implementation + more docs.
Tue, Aug 4, 10:17 PM
aj.nadel updated the diff for D4024: implement configurable (pure) solids.

property naming

Tue, Aug 4, 5:58 PM
aj.nadel updated the diff for D4022: refactor configured implementation + more docs.

fix property naming; add docstring

Tue, Aug 4, 5:37 PM

Mon, Aug 3

aj.nadel updated the diff for D4072: fix {mem,fs}_intermediate_storage docs and export.

walk back required_resource_keys changes

Mon, Aug 3, 11:40 PM
aj.nadel added inline comments to D4072: fix {mem,fs}_intermediate_storage docs and export.
Mon, Aug 3, 11:34 PM
aj.nadel updated the diff for D4024: implement configurable (pure) solids.

typo

Mon, Aug 3, 10:46 PM
aj.nadel updated the diff for D3981: [2] run-scoped file manager resources.

add tests and generate docs from them

Mon, Aug 3, 10:39 PM
aj.nadel updated the diff for D4024: implement configurable (pure) solids.

up

Mon, Aug 3, 10:14 PM
aj.nadel updated the diff for D4022: refactor configured implementation + more docs.

typos / name changes also

Mon, Aug 3, 9:51 PM
aj.nadel updated the diff for D4022: refactor configured implementation + more docs.

configured_config_mapping_fn --> _configured_config_mapping_fn

Mon, Aug 3, 9:47 PM
aj.nadel updated the diff for D4072: fix {mem,fs}_intermediate_storage docs and export.

typo

Mon, Aug 3, 9:29 PM
aj.nadel requested review of D4072: fix {mem,fs}_intermediate_storage docs and export.
Mon, Aug 3, 9:17 PM
aj.nadel added inline comments to D4022: refactor configured implementation + more docs.
Mon, Aug 3, 6:16 PM
aj.nadel updated the diff for D4024: implement configurable (pure) solids.

up

Mon, Aug 3, 5:36 PM

Fri, Jul 31

aj.nadel added a comment to D3981: [2] run-scoped file manager resources.

Unfinished but putting up a couple example docstrings for feedback

Fri, Jul 31, 11:18 PM
aj.nadel updated the diff for D3981: [2] run-scoped file manager resources.

up

Fri, Jul 31, 11:12 PM
aj.nadel updated the diff for D4024: implement configurable (pure) solids.

rebase

Fri, Jul 31, 10:30 PM
aj.nadel retitled D4022: refactor configured implementation + more docs from wip experimenting with transform_config to refactor configured implementation + more docs.
Fri, Jul 31, 10:26 PM

Thu, Jul 30

aj.nadel updated the diff for D4024: implement configurable (pure) solids.

up

Thu, Jul 30, 6:28 PM
aj.nadel updated the diff for D4022: refactor configured implementation + more docs.

typo

Thu, Jul 30, 6:26 PM
aj.nadel updated the diff for D4022: refactor configured implementation + more docs.

hoist non-resource-specific functionality to IConfigMappable

Thu, Jul 30, 6:14 PM
aj.nadel updated the diff for D4022: refactor configured implementation + more docs.

refactor to apply_config_mapping

Thu, Jul 30, 1:13 AM

Wed, Jul 29

aj.nadel added a reviewer for D4024: implement configurable (pure) solids: sashank.
Wed, Jul 29, 12:25 AM

Tue, Jul 28

aj.nadel requested review of D4024: implement configurable (pure) solids.
Tue, Jul 28, 11:02 PM
aj.nadel updated the diff for D4022: refactor configured implementation + more docs.

git is difficult

Tue, Jul 28, 8:46 PM
aj.nadel updated the diff for D4022: refactor configured implementation + more docs.

upupupu

Tue, Jul 28, 8:40 PM
aj.nadel updated the diff for D4022: refactor configured implementation + more docs.

lint

Tue, Jul 28, 8:35 PM
aj.nadel updated the diff for D4022: refactor configured implementation + more docs.

implement configurable (pure) solids

Tue, Jul 28, 8:16 PM
aj.nadel requested review of D4022: refactor configured implementation + more docs.
Tue, Jul 28, 7:32 PM

Mon, Jul 27

aj.nadel committed R1:eed7953ef0cb: gcs and azure file manager resources (authored by aj.nadel).
gcs and azure file manager resources
Mon, Jul 27, 10:46 PM
aj.nadel closed D3953: gcs and azure file manager resources.
Mon, Jul 27, 10:46 PM
aj.nadel requested review of D3981: [2] run-scoped file manager resources.
Mon, Jul 27, 7:06 PM
aj.nadel updated the summary of D3953: gcs and azure file manager resources.
Mon, Jul 27, 6:50 PM
aj.nadel updated the diff for D3953: gcs and azure file manager resources.

rebase

Mon, Jul 27, 6:49 PM
aj.nadel abandoned D3966: be explicit that resources can't be configured twice.
Mon, Jul 27, 6:39 PM

Sat, Jul 25

aj.nadel added inline comments to D3984: Test grpc ping inside container.
Sat, Jul 25, 2:43 AM
aj.nadel updated the diff for D3953: gcs and azure file manager resources.

add tests

Sat, Jul 25, 1:10 AM

Fri, Jul 24

aj.nadel abandoned D3967: add xfail tests for resource config preprocessing issue.

Fixed in D3998

Fri, Jul 24, 2:20 AM
aj.nadel planned changes to D3966: be explicit that resources can't be configured twice.
Fri, Jul 24, 12:17 AM
aj.nadel added a comment to D3998: first pass fix resource config preprocessing issue.

I didn't land the original tests -- should be ok with this!

Fri, Jul 24, 12:14 AM
aj.nadel added inline comments to D3995: changelog 0.8.9.
Fri, Jul 24, 12:13 AM
aj.nadel committed R1:951d6b080e9f: first pass fix resource config preprocessing issue (authored by aj.nadel).
first pass fix resource config preprocessing issue
Fri, Jul 24, 12:09 AM
aj.nadel closed D3998: first pass fix resource config preprocessing issue.
Fri, Jul 24, 12:09 AM

Wed, Jul 22

aj.nadel retitled D3966: be explicit that resources can't be configured twice from don't allow resources to be configured twice to be explicit that resources can't be configured twice.
Wed, Jul 22, 6:42 PM
aj.nadel updated the summary of D3966: be explicit that resources can't be configured twice.
Wed, Jul 22, 6:42 PM
aj.nadel requested review of D3966: be explicit that resources can't be configured twice.
Wed, Jul 22, 6:33 PM
aj.nadel requested review of D3967: add xfail tests for resource config preprocessing issue.
Wed, Jul 22, 6:19 PM

Tue, Jul 21

aj.nadel requested review of D3953: gcs and azure file manager resources.
Tue, Jul 21, 10:09 PM
aj.nadel committed R1:fb418b4e09f2: make graphql + postgres and dagster-postgres tests recover gracefully from… (authored by aj.nadel).
make graphql + postgres and dagster-postgres tests recover gracefully from…
Tue, Jul 21, 12:48 AM
aj.nadel closed D3824: make graphql + postgres and dagster-postgres tests recover gracefully from local docker issues.
Tue, Jul 21, 12:47 AM

Mon, Jul 20

aj.nadel updated the diff for D3824: make graphql + postgres and dagster-postgres tests recover gracefully from local docker issues.

rebase

Mon, Jul 20, 11:09 PM

Fri, Jul 17

aj.nadel updated the diff for D3824: make graphql + postgres and dagster-postgres tests recover gracefully from local docker issues.

rebase

Fri, Jul 17, 9:45 PM
aj.nadel committed R1:f5b504c4cdbc: make sure intermediates_manager config is recognized as persistent (authored by aj.nadel).
make sure intermediates_manager config is recognized as persistent
Fri, Jul 17, 9:34 PM
aj.nadel closed D3891: make sure intermediates_manager config is recognized as persistent.
Fri, Jul 17, 9:34 PM

Thu, Jul 16

aj.nadel added inline comments to D3914: Add fixture to build dagster core image.
Thu, Jul 16, 8:09 PM
aj.nadel updated the diff for D3849: prune InitSystemStorageContext.

ugh lint

Thu, Jul 16, 7:06 PM
aj.nadel updated the diff for D3849: prune InitSystemStorageContext.

up

Thu, Jul 16, 7:04 PM
aj.nadel requested review of D3849: prune InitSystemStorageContext.
Thu, Jul 16, 2:49 AM
aj.nadel updated the diff for D3824: make graphql + postgres and dagster-postgres tests recover gracefully from local docker issues.

revert back after convo with sashank

Thu, Jul 16, 2:19 AM

Wed, Jul 15

aj.nadel updated the diff for D3891: make sure intermediates_manager config is recognized as persistent.

use execution_plan.artifacts_persisted in celery lib check

Wed, Jul 15, 12:24 AM
aj.nadel requested review of D3891: make sure intermediates_manager config is recognized as persistent.
Wed, Jul 15, 12:07 AM

Tue, Jul 14

aj.nadel updated the diff for D3824: make graphql + postgres and dagster-postgres tests recover gracefully from local docker issues.

networking retry

Tue, Jul 14, 6:28 PM
aj.nadel updated the diff for D3824: make graphql + postgres and dagster-postgres tests recover gracefully from local docker issues.

tox passthru

Tue, Jul 14, 12:44 AM
aj.nadel updated the diff for D3824: make graphql + postgres and dagster-postgres tests recover gracefully from local docker issues.

bk still broke

Tue, Jul 14, 12:38 AM
aj.nadel updated the diff for D3824: make graphql + postgres and dagster-postgres tests recover gracefully from local docker issues.

oops up?

Tue, Jul 14, 12:25 AM
aj.nadel updated the diff for D3824: make graphql + postgres and dagster-postgres tests recover gracefully from local docker issues.

up?

Tue, Jul 14, 12:23 AM
aj.nadel updated the diff for D3824: make graphql + postgres and dagster-postgres tests recover gracefully from local docker issues.

up

Tue, Jul 14, 12:09 AM

Mon, Jul 13

aj.nadel updated the diff for D3824: make graphql + postgres and dagster-postgres tests recover gracefully from local docker issues.

try to avoid port conflict in the first place

Mon, Jul 13, 10:55 PM
aj.nadel updated the diff for D3824: make graphql + postgres and dagster-postgres tests recover gracefully from local docker issues.

rebase

Mon, Jul 13, 9:55 PM
aj.nadel updated the diff for D3824: make graphql + postgres and dagster-postgres tests recover gracefully from local docker issues.

address max comments

Mon, Jul 13, 9:53 PM

Jul 10 2020

aj.nadel retitled D3824: make graphql + postgres and dagster-postgres tests recover gracefully from local docker issues from simplify postgres/graphql tests to catch docker errors as warns to make graphql + postgres and dagster-postgres tests recover gracefully from local docker issues.
Jul 10 2020, 8:55 PM
aj.nadel updated the summary of D3824: make graphql + postgres and dagster-postgres tests recover gracefully from local docker issues.
Jul 10 2020, 8:54 PM
aj.nadel committed R1:8c389934c906: add missing tox envs to azure pipeline yml (authored by aj.nadel).
add missing tox envs to azure pipeline yml
Jul 10 2020, 8:49 PM