Page MenuHomeElementl
Feed All Stories

Fri, Apr 16

yuhan accepted D7462: Limit the scope of hook context.
Fri, Apr 16, 4:44 PM
Chris DeCarolis <cdguitar817@gmail.com> closed D7459: Use cleaner NamedTuple syntax for InputContext and OutputContext.
Fri, Apr 16, 4:42 PM
Chris DeCarolis <cdguitar817@gmail.com> committed R1:1bbb154d1872: Use cleaner NamedTuple syntax for InputContext and OutputContext (authored by Chris DeCarolis <cdguitar817@gmail.com>).
Use cleaner NamedTuple syntax for InputContext and OutputContext
Fri, Apr 16, 4:42 PM
rexledesma added a comment to D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].

bateman

Fri, Apr 16, 4:41 PM
rexledesma accepted D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].
Fri, Apr 16, 4:41 PM
alangenfeld added a comment to D7446: default config schema to Any.

should any docs or tutorials get updated in this diff as well?

Fri, Apr 16, 4:28 PM
alangenfeld accepted D7459: Use cleaner NamedTuple syntax for InputContext and OutputContext.

sweet thanks much

Fri, Apr 16, 4:26 PM
Chris DeCarolis <cdguitar817@gmail.com> closed D7464: [Depends on D7374] solid definition mypy.
Fri, Apr 16, 4:07 PM
Chris DeCarolis <cdguitar817@gmail.com> committed R1:f4d3762c7fae: [Depends on D7374] solid definition mypy (authored by Chris DeCarolis <cdguitar817@gmail.com>).
[Depends on D7374] solid definition mypy
Fri, Apr 16, 4:07 PM
Chris DeCarolis <cdguitar817@gmail.com> closed D7374: execution context naming revamp, remove resources and intermediate storage from run worker.
Fri, Apr 16, 3:55 PM
Chris DeCarolis <cdguitar817@gmail.com> committed R1:368326448843: execution context naming revamp, remove resources and intermediate storage from… (authored by Chris DeCarolis <cdguitar817@gmail.com>).
execution context naming revamp, remove resources and intermediate storage from…
Fri, Apr 16, 3:55 PM
dgibson closed D7477: Fix issue with error handling in ProcessGrpcServerRegistry.
Fri, Apr 16, 3:31 PM
dgibson committed R1:1beeea2e0446: Fix issue with error handling in ProcessGrpcServerRegistry (authored by dgibson).
Fix issue with error handling in ProcessGrpcServerRegistry
Fri, Apr 16, 3:31 PM
prha accepted D7477: Fix issue with error handling in ProcessGrpcServerRegistry.
Fri, Apr 16, 3:30 PM
Harbormaster failed remote builds in B28988: Diff 35575 for D7395: Provide more detailed SkipReasons!
Fri, Apr 16, 3:25 PM
dgibson added a comment to D7477: Fix issue with error handling in ProcessGrpcServerRegistry.

I'd like to try to cherry pick this if reviewers have a sec (since the blamerev is going out in the release)

Fri, Apr 16, 3:18 PM
bengotow closed D7466: Remove “for-screenshots” titles - confirmed with Sashank that there is no script using this anymore #3800.
Fri, Apr 16, 3:16 PM
bengotow committed R1:0e06f31c1dec: Remove “for-screenshots” titles - confirmed with Sashank that there is no… (authored by bengotow).
Remove “for-screenshots” titles - confirmed with Sashank that there is no…
Fri, Apr 16, 3:16 PM
bengotow closed D7469: Make default scroll position in "Launch backfill" modal be right-most partition #3787.
Fri, Apr 16, 3:15 PM
bengotow committed R1:3e39b932315c: Make default scroll position in "Launch backfill" modal be right-most partition… (authored by bengotow).
Make default scroll position in "Launch backfill" modal be right-most partition…
Fri, Apr 16, 3:15 PM
jordansanders added inline comments to D7395: Provide more detailed SkipReasons.
Fri, Apr 16, 3:10 PM
jordansanders updated the diff for D7395: Provide more detailed SkipReasons.

Explicitly check against the earliest possible partition.

Fri, Apr 16, 3:07 PM
dgibson added a reviewer for D7477: Fix issue with error handling in ProcessGrpcServerRegistry: prha.
Fri, Apr 16, 3:07 PM
dgibson added a reviewer for D7477: Fix issue with error handling in ProcessGrpcServerRegistry: alangenfeld.
Fri, Apr 16, 3:06 PM
sidkmenon added inline comments to D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].
Fri, Apr 16, 3:03 PM
sidkmenon updated the diff for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].

Adding to bk python scripts

Fri, Apr 16, 3:00 PM
cdecarolis updated the diff for D7462: Limit the scope of hook context.

Address comments

Fri, Apr 16, 2:58 PM
dgibson added reviewers for D7477: Fix issue with error handling in ProcessGrpcServerRegistry: sashank, johann, max.
Fri, Apr 16, 2:46 PM
cdecarolis updated the diff for D7459: Use cleaner NamedTuple syntax for InputContext and OutputContext.

Use typed namedtuple syntax to preserve constructor arguments

Fri, Apr 16, 2:32 PM
dish closed D7423: [dagit] Split the bundle.
Fri, Apr 16, 2:10 PM
dish closed D7418: [dagit] Eject CRA.
Fri, Apr 16, 2:10 PM
dish committed R1:6038b7cab2e9: [dagit] Split the bundle (authored by dish).
[dagit] Split the bundle
Fri, Apr 16, 2:10 PM
dish committed R1:8bfebf989579: [dagit] Eject CRA (authored by dish).
[dagit] Eject CRA
Fri, Apr 16, 2:10 PM
alangenfeld closed D7468: [mypy] pipeline & graph definitions.
Fri, Apr 16, 2:09 PM
alangenfeld committed R1:dc61de9defb4: [mypy] pipeline & graph definitions (authored by alangenfeld).
[mypy] pipeline & graph definitions
Fri, Apr 16, 2:09 PM
dish accepted D7469: Make default scroll position in "Launch backfill" modal be right-most partition #3787.
Fri, Apr 16, 2:05 PM
dish accepted D7465: Handle long lists of parent assets #3952.
Fri, Apr 16, 2:04 PM
dish added a comment to D7467: Increase the number of typeahead autocompletions shown and scroll the list #4017.

When scrolling down with the keyboard, does the scrollable div keep the highlighted item visible? (If not: the typeahead dropdown code for global search and log filtering does do this, so we can either try to reuse that code here or copy it over temporarily.)

Fri, Apr 16, 2:03 PM
dish accepted D7467: Increase the number of typeahead autocompletions shown and scroll the list #4017.
Fri, Apr 16, 2:01 PM
dish accepted D7466: Remove “for-screenshots” titles - confirmed with Sashank that there is no script using this anymore #3800.
Fri, Apr 16, 2:01 PM
sandyryza requested review of D7446: default config schema to Any.
Fri, Apr 16, 5:57 AM
dgibson requested review of D7477: Fix issue with error handling in ProcessGrpcServerRegistry.
Fri, Apr 16, 4:42 AM
cdecarolis added a comment to D7459: Use cleaner NamedTuple syntax for InputContext and OutputContext.

oh wait - whats the testing story for IO managers? Do we expect users to create these by hand in test scenarios ? We might need to the typing.NamedTuple with __new__ version

Fri, Apr 16, 12:47 AM
sidkmenon updated the diff for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].

Adding marker to pytest.ini

Fri, Apr 16, 12:45 AM
sandyryza accepted D7468: [mypy] pipeline & graph definitions.
Fri, Apr 16, 12:37 AM
sidkmenon updated the diff for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].

Addressing comments, including seperating tests into their own tox suite

Fri, Apr 16, 12:30 AM

Thu, Apr 15

max closed D7472: Changelog for 0.11.5.
Thu, Apr 15, 10:25 PM
max committed R1:7ca5ca595db9: Changelog for 0.11.5 (authored by max).
Changelog for 0.11.5
Thu, Apr 15, 10:25 PM
dgibson accepted D7472: Changelog for 0.11.5.
Thu, Apr 15, 10:24 PM
cdecarolis abandoned D7150: Don't initialize resources in run process.
Thu, Apr 15, 10:23 PM
sandyryza requested review of D7474: clarify API doc for InputDefinition and OutputDefinition dagster_type args.
Thu, Apr 15, 10:16 PM
Harbormaster failed remote builds in B28965: Diff 35546 for D7261: change DagsterInstance.get behavior!
Thu, Apr 15, 10:01 PM
max requested review of D7472: Changelog for 0.11.5.
Thu, Apr 15, 10:00 PM
dgibson closed D7458: Add some overridable methods to ProcessGrpcServerRegistry to make it extendable to support different origin types.
Thu, Apr 15, 9:58 PM
dgibson committed R1:8a7068dcd634: Add some overridable methods to ProcessGrpcServerRegistry to make it extendable… (authored by dgibson).
Add some overridable methods to ProcessGrpcServerRegistry to make it extendable…
Thu, Apr 15, 9:58 PM
Harbormaster failed remote builds in B28962: Diff 35543 for D7459: Use cleaner NamedTuple syntax for InputContext and OutputContext!
Thu, Apr 15, 9:58 PM
sashank accepted D7458: Add some overridable methods to ProcessGrpcServerRegistry to make it extendable to support different origin types.
Thu, Apr 15, 9:57 PM
alangenfeld added inline comments to D7261: change DagsterInstance.get behavior.
Thu, Apr 15, 9:45 PM
alangenfeld updated the diff for D7261: change DagsterInstance.get behavior.

copy refresh - support dagster pipeline execute

Thu, Apr 15, 9:42 PM
cdecarolis updated the diff for D7464: [Depends on D7374] solid definition mypy.

Union -> NodeDefinition, Generator -> Iterator

Thu, Apr 15, 9:41 PM
alangenfeld added a comment to D7459: Use cleaner NamedTuple syntax for InputContext and OutputContext.

oh wait - whats the testing story for IO managers? Do we expect users to create these by hand in test scenarios ? We might need to the typing.NamedTuple with __new__ version

Thu, Apr 15, 9:40 PM
yuhan added a comment to D7462: Limit the scope of hook context.

as we are updating the logging_tags, can we test it in terminal and dagit to see if the hook events still behave the same

Thu, Apr 15, 9:40 PM
cdecarolis updated the diff for D7459: Use cleaner NamedTuple syntax for InputContext and OutputContext.

Moved input and output context out of system.py

Thu, Apr 15, 9:37 PM
alangenfeld requested review of D7468: [mypy] pipeline & graph definitions.
Thu, Apr 15, 9:29 PM
Harbormaster failed remote builds in B28955: Diff 35535 for D7463: [mypy] Events mypy and namedtuple conversion!
Thu, Apr 15, 9:19 PM
alangenfeld requested changes to D7463: [mypy] Events mypy and namedtuple conversion.

switch the NamedTuples to still have __new__ but be typed

Thu, Apr 15, 9:02 PM
cdecarolis updated the diff for D7463: [mypy] Events mypy and namedtuple conversion.

Up

Thu, Apr 15, 8:58 PM
alangenfeld accepted D7464: [Depends on D7374] solid definition mypy.
Thu, Apr 15, 8:48 PM
cdecarolis requested review of D7463: [mypy] Events mypy and namedtuple conversion.
Thu, Apr 15, 8:46 PM
alangenfeld resigned from D7462: Limit the scope of hook context.

want @yuhan to sign off on this one

Thu, Apr 15, 8:46 PM
bengotow requested review of D7469: Make default scroll position in "Launch backfill" modal be right-most partition #3787.
Thu, Apr 15, 8:42 PM
alangenfeld requested changes to D7459: Use cleaner NamedTuple syntax for InputContext and OutputContext.

being annoying but i think its worth

Thu, Apr 15, 8:40 PM
bengotow requested review of D7467: Increase the number of typeahead autocompletions shown and scroll the list #4017.
Thu, Apr 15, 8:36 PM
bengotow requested review of D7466: Remove “for-screenshots” titles - confirmed with Sashank that there is no script using this anymore #3800.
Thu, Apr 15, 8:36 PM
bengotow requested review of D7465: Handle long lists of parent assets #3952.
Thu, Apr 15, 8:30 PM
cdecarolis requested review of D7464: [Depends on D7374] solid definition mypy.
Thu, Apr 15, 8:17 PM
cdecarolis requested review of D7462: Limit the scope of hook context.
Thu, Apr 15, 8:15 PM
cdecarolis requested review of D7459: Use cleaner NamedTuple syntax for InputContext and OutputContext.
Thu, Apr 15, 8:09 PM
sandyryza closed D7386: update solid concepts page to use less boilerplate.
Thu, Apr 15, 7:46 PM
sandyryza committed R1:48acdd5abe27: update solid concepts page to use less boilerplate (authored by sandyryza).
update solid concepts page to use less boilerplate
Thu, Apr 15, 7:46 PM
yuhan accepted D7386: update solid concepts page to use less boilerplate.
Thu, Apr 15, 7:18 PM
dish updated the diff for D7423: [dagit] Split the bundle.

+prha

Thu, Apr 15, 6:17 PM
alangenfeld resigned from D7438: Revamp the configuration concept section.
Thu, Apr 15, 6:08 PM
alangenfeld accepted D7436: Add --short flag to dagster-release version (for automation).

whynot

Thu, Apr 15, 6:00 PM
dish accepted D7461: Show failure status with python stack trace for failed backfills.
Thu, Apr 15, 5:59 PM
alangenfeld added a comment to D7374: execution context naming revamp, remove resources and intermediate storage from run worker.

land late tonight / early tomorrow for max soak between now and next release

Thu, Apr 15, 5:54 PM
alangenfeld accepted D7374: execution context naming revamp, remove resources and intermediate storage from run worker.

😗 👌

Thu, Apr 15, 5:53 PM
prha requested review of D7461: Show failure status with python stack trace for failed backfills.
Thu, Apr 15, 5:26 PM
prha requested review of D7460: Recover from failed backfills, populate backfill errors.
Thu, Apr 15, 5:21 PM
sandyryza updated the diff for D7438: Revamp the configuration concept section.

address nick feedback

Thu, Apr 15, 5:19 PM
sandyryza closed D7407: advanced tutorial changes.
Thu, Apr 15, 5:00 PM
sandyryza committed R1:f829072011c0: advanced tutorial changes (authored by sandyryza).
advanced tutorial changes
Thu, Apr 15, 5:00 PM
sandyryza added inline comments to D7407: advanced tutorial changes.
Thu, Apr 15, 4:59 PM
dgibson requested review of D7458: Add some overridable methods to ProcessGrpcServerRegistry to make it extendable to support different origin types.
Thu, Apr 15, 4:48 PM
schrockn requested changes to D7438: Revamp the configuration concept section.

minor changes but bouncing back to your queue

Thu, Apr 15, 4:24 PM
max requested review of D7436: Add --short flag to dagster-release version (for automation).
Thu, Apr 15, 4:19 PM
sandyryza added inline comments to D7416: only run example tests on py3.8.
Thu, Apr 15, 4:19 PM
schrockn accepted D7407: advanced tutorial changes.

👍🏻

Thu, Apr 15, 4:17 PM
schrockn resigned from D7374: execution context naming revamp, remove resources and intermediate storage from run worker.

Super excited for this change. Big step forward. Thanks @cdecarolis for working through this. Will let others approve.

Thu, Apr 15, 4:16 PM
sandyryza updated the summary of D7407: advanced tutorial changes.
Thu, Apr 15, 4:13 PM