Feed All Stories
Today
Today
nate requested review of D3144: Move remaining tests to new buildkite ModuleBuildSpec.
prha committed R1:2e6c85f6e6f9: [graphql-environment-8] convert PipelineSelector to use repositoryLocationName… (authored by prha).
[graphql-environment-8] convert PipelineSelector to use repositoryLocationName…
schrockn requested review of D3141: (hijack-cli-api-all-things-5) Move test_execute_schedule.py to test infra.
prha updated the diff for D3138: [graphql-environment-8] convert PipelineSelector to use repositoryLocationName instead of environmentName.
rebase
prha committed R1:2624e8479c87: [graphql-environment-7] convert misc pipeline selector queries off of legacy… (authored by prha).
[graphql-environment-7] convert misc pipeline selector queries off of legacy…
prha committed R1:cc67d004d7cc: [graphql-environment-6] Rename EnvironmentSchema, environmentConfig =>… (authored by prha).
[graphql-environment-6] Rename EnvironmentSchema, environmentConfig =>…
catherinewu requested review of D3145: Fan In Pipeline doc example.
prha committed R1:1dfff874cc1a: [graphql-environment-5] Rename EnvironmentSchema => RunConfigSchema (dagster… (authored by prha).
[graphql-environment-5] Rename EnvironmentSchema => RunConfigSchema (dagster…
prha committed R1:13597313733e: [graphql-environment-4] use pipeline selector for pipelineOrError (authored by prha).
[graphql-environment-4] use pipeline selector for pipelineOrError
prha committed R1:0394d9114710: [graphql-environment-3] replace pipeline name context with environment context… (authored by prha).
[graphql-environment-3] replace pipeline name context with environment context…
prha committed R1:67b7db1bed94: [graphql-environment-2] add graphql endpoints for Environment (authored by prha).
[graphql-environment-2] add graphql endpoints for Environment
prha committed R1:12f65342cdfe: [graphql-environment-1] rename PipelineSelector to PipelineExplorerPath (authored by prha).
[graphql-environment-1] rename PipelineSelector to PipelineExplorerPath
catherinewu requested review of D3142: Docs example for pipeline tags.
prha updated the diff for D3138: [graphql-environment-8] convert PipelineSelector to use repositoryLocationName instead of environmentName.
rebase
schrockn added a comment to D3132: [graphql] return HistoricalPipeline from PipelineRun.
*long-term
schrockn requested changes to D3132: [graphql] return HistoricalPipeline from PipelineRun.
My req changes is solely because I'm curious about what your vision for the future of PipelineReference is? Does it exist in the long-temr/
catherinewu requested review of D3140: Airflow ingest doc example.
alangenfeld requested review of D3132: [graphql] return HistoricalPipeline from PipelineRun.
schrockn updated the diff for D3136: (hijack-cli-api-all-things-4) Move compute logs to test suite.
up
alangenfeld requested review of D3139: rm dead backcompat code.
schrockn updated the diff for D3135: (hijack-cli-api-all-things-3) Move the RetryExecution test suite to use a test matrix.
rebase
nate added inline comments to D3106: PySpark EMR example.
Reorganize decorators
schrockn accepted D3138: [graphql-environment-8] convert PipelineSelector to use repositoryLocationName instead of environmentName.
👍🏻
schrockn accepted D3127: [graphql-environment-7] convert misc pipeline selector queries off of legacy selector.
cool
max requested review of D3137: Reorganize decorators.
prha added a comment to D3127: [graphql-environment-7] convert misc pipeline selector queries off of legacy selector.
No, but I was getting kind of difficult merges, so it actually got rebased into https://dagster.phacility.com/D3118
schrockn requested changes to D3127: [graphql-environment-7] convert misc pipeline selector queries off of legacy selector.
did you miss a commit in your rebase? i don't see get_legacy_pipeline_selector added in utils.py (there are no changes to utils)
alangenfeld committed R1:35d8c39d4297: DagsterEnvironment -> RepositoryLocation (authored by alangenfeld).
DagsterEnvironment -> RepositoryLocation
yuhan committed R1:72095f5b882f: selector 2/ allow solid_subset to take DSL syntax in python api… (authored by yuhan).
selector 2/ allow solid_subset to take DSL syntax in python api…
yuhan retitled D3113: selector 2/ allow solid_subset to take DSL syntax in python api execute_pipeline and execute_pipeline_iterator from selector 2/ add solid_subset_query to python api execute_pipeline and execute_pipeline_iterator to selector 2/ allow solid_subset to take DSL syntax in python api execute_pipeline and execute_pipeline_iterator.
yuhan committed R1:08e1ef534471: selector 1/ subselection query to solid_subset (authored by yuhan).
selector 1/ subselection query to solid_subset
Yesterday
Yesterday
prha updated the diff for D3127: [graphql-environment-7] convert misc pipeline selector queries off of legacy selector.
fix tests, update, rebase
Harbormaster failed remote builds in B12178: Diff 14958 for D3127: [graphql-environment-7] convert misc pipeline selector queries off of legacy selector!
schrockn requested review of D3136: (hijack-cli-api-all-things-4) Move compute logs to test suite.
Harbormaster failed remote builds in B12177: Diff 14957 for D3127: [graphql-environment-7] convert misc pipeline selector queries off of legacy selector!
prha updated the diff for D3127: [graphql-environment-7] convert misc pipeline selector queries off of legacy selector.
fix rebase
prha updated the diff for D3127: [graphql-environment-7] convert misc pipeline selector queries off of legacy selector.
rebase
prha updated the diff for D3120: [graphql-environment-6] Rename EnvironmentSchema, environmentConfig => RunConfigSchema, runConfig (graphql/js).
rebase
prha updated the diff for D3119: [graphql-environment-5] Rename EnvironmentSchema => RunConfigSchema (dagster core only).
rebase
prha updated the diff for D3118: [graphql-environment-4] use pipeline selector for pipelineOrError.
rebase
prha updated the diff for D3117: [graphql-environment-3] replace pipeline name context with environment context provider.
rebase
max requested review of D3134: Reenable test.
Lakehouse renovation
sandyryza added inline comments to D2925: Lakehouse renovation.
alangenfeld updated the diff for D3129: DagsterEnvironment -> RepositoryLocation.
up
sashank planned changes to D3122: (dagit-out-of-process-2) Add method to get external pipeline w/ API.
schrockn committed R1:b3700d09ce52: (hijack-cli-api-all-things-2) Rename sync_get_all_logs_for_run to… (authored by schrockn).
(hijack-cli-api-all-things-2) Rename sync_get_all_logs_for_run to…
schrockn committed R1:c716b1dd1076: Move test_execute_pipeline to use entire test executing test matrix (authored by schrockn).
Move test_execute_pipeline to use entire test executing test matrix
alangenfeld accepted D3133: (hijack-cli-api-all-things-2) Rename sync_get_all_logs_for_run to get_all_logs_finished_for_run_via_subscription.
names
alangenfeld added inline comments to D3122: (dagit-out-of-process-2) Add method to get external pipeline w/ API.
alangenfeld added a comment to D3064: Allow PresetDefinitions to wrap ModeDefinitions.
hmm definitely not crazy - will need to think on this one a bit
yuhan updated the diff for D3113: selector 2/ allow solid_subset to take DSL syntax in python api execute_pipeline and execute_pipeline_iterator.
- instead of making it an extra arg, we use the existing solid_subset: execute_pipeline(pipeline, solid_subset=['*some_solid', 'other_solid_a', 'other_solid_b+'])
- more tests to cover multiple clauses (disjoint, overlapping) and invalid queries
pipeline snapshot lineage
yuhan updated the summary of D3112: selector 1/ subselection query to solid_subset.
alangenfeld updated the diff for D3129: DagsterEnvironment -> RepositoryLocation.
up
yuhan updated the diff for D3112: selector 1/ subselection query to solid_subset.
- get_solid_subset_from_query(pipeline_def, query) where query is str => parse_solid_subset(pipeline_def, solid_subset) where solid_subset is List[str]
- dedup
- more tests to cover multiple clauses, invalid syntax, and duplication
alangenfeld added inline comments to D3129: DagsterEnvironment -> RepositoryLocation.
alangenfeld accepted D2925: Lakehouse renovation.
fine place to start - some edges to polish as we use it a bit and understand the ergonomics better
schrockn updated the diff for D3131: Move test_execute_pipeline to use entire test executing test matrix.
up
alangenfeld updated the diff for D3125: pipeline snapshot lineage.
how bout just PipelineSnapshotLineage?
schrockn updated the diff for D3131: Move test_execute_pipeline to use entire test executing test matrix.
up
schrockn requested changes to D3127: [graphql-environment-7] convert misc pipeline selector queries off of legacy selector.
Seems like this name should indicate that it is a legacy/single-env-single-repo codepath
schrockn requested changes to D3129: DagsterEnvironment -> RepositoryLocation.
Just req'ing changes so we can get the docs in there that @prha mentioned because I think that's a good call.
Move pylint to package tox files
schrockn added a comment to D3129: DagsterEnvironment -> RepositoryLocation.
Broadly speaking i think the code i more clear if we say "repository_location" rather than "location" in most places