Gah you're right
I kind of like the codemirror idea... and having yaml removes the requirement to learn another DSL.
Overall this makes sense to me!
Code looks okay, but hitting lots of merge conflicts... Req'ing for rebase.
awesome! looking forward to seeing this pushed
update doc, messages
remove test for removed migration
cool. this is looking good. i think the biggest issue with this as written is that you current require path in the asset_metadata for the default asset store. I think it should be the opposite and the default asset storage should take care of it for you.
Superseded by https://dagster.phacility.com/D4806
remove the breaking part, just update teh examples and tests for now
Created another config_more_details.py to hold the optional config. The config.py contains the least verbose example.
Update: Start with the least verbose config example
Possibly crazy idea: can we use a yaml CodeMirror here? E.g.
can you open an issue to intro selector in docs
rebase, add more logging to migration script
use pipeline env configmap
This looks great! Good catch 👍
As per discussion in the platform lane chat.
test failures are transient/unrelated
Direction looks great to me. Some nits inline, mostly stylistic/legibility things.
This is great! Some minor feedback. Big improvement
this is good but it needs tests