Page MenuHomePhabricator
Feed All Stories

Today

sandyryza accepted D4830: Yet another line number fix 😔.

Gah you're right

Tue, Oct 20, 5:00 PM
cdecarolis added inline comments to D4830: Yet another line number fix 😔.
Tue, Oct 20, 4:58 PM
GitHub <noreply@github.com> committed R1:3ad09f8cee97: Add limit to "dagster run list" (#3117) (authored by Haydar Ali Ismail <2961388+haydarai@users.noreply.github.com>).
Add limit to "dagster run list" (#3117)
Tue, Oct 20, 4:55 PM
dgibson updated the diff for D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.

rebase

Tue, Oct 20, 4:52 PM
GitHub <noreply@github.com> committed R1:a03bd01310be: Use env variables for CLI command options (#3077) (authored by Xinbin Huang <bin.huangxb@gmail.com>).
Use env variables for CLI command options (#3077)
Tue, Oct 20, 4:51 PM
alangenfeld committed R1:e20aa4735326: multiprocessing executor doc block fix (authored by alangenfeld).
multiprocessing executor doc block fix
Tue, Oct 20, 4:41 PM
alangenfeld accepted D4817: Remove executePlan dagster-graphql call.

yeahfuckyeah

Tue, Oct 20, 4:39 PM
sandyryza added inline comments to D4830: Yet another line number fix 😔.
Tue, Oct 20, 4:36 PM
alangenfeld added a comment to D4817: Remove executePlan dagster-graphql call.

sobeautiful

Tue, Oct 20, 4:35 PM
alangenfeld created Image Macro "sobeautiful".
Tue, Oct 20, 4:35 PM
prha added inline comments to D4813: Maintain backcompat in date_partition_range.
Tue, Oct 20, 4:22 PM
cdecarolis requested review of D4830: Yet another line number fix 😔.
Tue, Oct 20, 4:20 PM
prha added a comment to D4809: Clean up partitions UI and improve backfill usability.

I kind of like the codemirror idea... and having yaml removes the requirement to learn another DSL.

Tue, Oct 20, 4:19 PM
prha accepted D4827: Append "_location" to default repository location name.
Tue, Oct 20, 4:10 PM
dgibson closed D4823: Ensure that origins don't change when we switch from cli api repos to grpc repos.
Tue, Oct 20, 4:07 PM
dgibson committed R1:6d3e9aaac0af: Ensure that origins don't change when we switch from cli api repos to grpc repos (authored by dgibson).
Ensure that origins don't change when we switch from cli api repos to grpc repos
Tue, Oct 20, 4:07 PM
dgibson added inline comments to D4823: Ensure that origins don't change when we switch from cli api repos to grpc repos.
Tue, Oct 20, 4:07 PM
prha accepted D4823: Ensure that origins don't change when we switch from cli api repos to grpc repos.
Tue, Oct 20, 4:05 PM
dgibson added a comment to D4821: RFC: [dagit] Start adding Workspace routes.

Overall this makes sense to me!

Tue, Oct 20, 4:04 PM
prha added inline comments to D4813: Maintain backcompat in date_partition_range.
Tue, Oct 20, 3:53 PM
dgibson requested review of D4827: Append "_location" to default repository location name.
Tue, Oct 20, 3:49 PM
prha requested changes to D4691: Basic display of asset partition coverage / value by partition.

Code looks okay, but hitting lots of merge conflicts... Req'ing for rebase.

Tue, Oct 20, 3:42 PM
max closed D4822: serialization safety.
Tue, Oct 20, 3:25 PM
max committed R1:77f3ec8fba9e: serialization safety (authored by max).
serialization safety
Tue, Oct 20, 3:25 PM
schrockn accepted D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.

awesome! looking forward to seeing this pushed

Tue, Oct 20, 3:24 PM
bob accepted D4822: serialization safety.

Macro thumbsup:

Tue, Oct 20, 3:05 PM
max updated the diff for D4822: serialization safety.

fix type hints

Tue, Oct 20, 2:59 PM
bob added inline comments to D4822: serialization safety.
Tue, Oct 20, 2:49 PM
dgibson added a reviewer for D4823: Ensure that origins don't change when we switch from cli api repos to grpc repos: sashank.
Tue, Oct 20, 2:49 PM
prha closed D4812: remove backfill check for step selection.
Tue, Oct 20, 2:44 PM
prha committed R1:7806dc0e8232: remove backfill check for step selection (authored by prha).
remove backfill check for step selection
Tue, Oct 20, 2:44 PM
prha updated the diff for D4764: add summary table for asset keys.

update doc, messages

Tue, Oct 20, 2:43 PM
prha added inline comments to D4764: add summary table for asset keys.
Tue, Oct 20, 2:43 PM
prha updated the diff for D4764: add summary table for asset keys.

remove test for removed migration

Tue, Oct 20, 2:31 PM
sashank requested review of D4826: [easy] Clean up instance file.
Tue, Oct 20, 10:04 AM
catherinewu added inline comments to D4718: Configure celeryless deploy on helm.
Tue, Oct 20, 3:35 AM
schrockn requested changes to D4820: address-store-0 AssetAddress + AssetStore.

cool. this is looking good. i think the biggest issue with this as written is that you current require path in the asset_metadata for the default asset store. I think it should be the opposite and the default asset storage should take care of it for you.

Tue, Oct 20, 3:02 AM
schrockn requested review of D4825: (dask-dataframe-1) Extract create_dask_dataframe and make it create the default type.
Tue, Oct 20, 2:59 AM
dgibson requested review of D4817: Remove executePlan dagster-graphql call.
Tue, Oct 20, 1:39 AM
dgibson requested review of D4824: Remove legacy repo format from loading path.
Tue, Oct 20, 1:36 AM
dgibson added a reviewer for D4813: Maintain backcompat in date_partition_range: prha.
Tue, Oct 20, 1:18 AM
sandyryza abandoned D4745: Don't load pyspark when importing dagster_aws.emr.

Superseded by https://dagster.phacility.com/D4806

Tue, Oct 20, 1:14 AM
dgibson updated the diff for D4742: Remove legacy repo format from examples/tests, replace the default with the new standard format except when specifically testing legacy stuff.

remove the breaking part, just update teh examples and tests for now

Tue, Oct 20, 1:14 AM
sandyryza requested review of D4806: create dagster-aws-pyspark library with emr_pyspark_step_launcher.
Tue, Oct 20, 1:09 AM
dgibson added a reviewer for D4805: Don't rebuild the docker image every time you run a kind test locally: alangenfeld.
Tue, Oct 20, 1:03 AM
dgibson abandoned D4799: test termination in BK.
Tue, Oct 20, 1:02 AM
dgibson requested review of D4823: Ensure that origins don't change when we switch from cli api repos to grpc repos.
Tue, Oct 20, 12:55 AM
yichendai updated the summary of D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
Tue, Oct 20, 12:54 AM
yichendai updated the summary of D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
Tue, Oct 20, 12:53 AM
yichendai updated the summary of D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
Tue, Oct 20, 12:52 AM
yuhan requested review of D4820: address-store-0 AssetAddress + AssetStore.
Tue, Oct 20, 12:50 AM
yichendai added a comment to D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.

Created another config_more_details.py to hold the optional config. The config.py contains the least verbose example.

Tue, Oct 20, 12:49 AM
yichendai updated the diff for D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.

Update: Start with the least verbose config example

Tue, Oct 20, 12:46 AM
Harbormaster failed remote builds in B19821: Diff 24048 for D4579: address-store-1 AddressStore / AssetAddress + AssetStore!
Tue, Oct 20, 12:39 AM
dgibson updated the diff for D4814: rm DagsterKubernetesPodOperator and test infra around it.

up

Tue, Oct 20, 12:35 AM
yuhan planned changes to D4579: address-store-1 AddressStore / AssetAddress + AssetStore.
Tue, Oct 20, 12:19 AM
yuhan updated the diff for D4579: address-store-1 AddressStore / AssetAddress + AssetStore.

rebase /0

Tue, Oct 20, 12:17 AM

Yesterday

sandyryza closed D4763: remove selector from tutorial.
Mon, Oct 19, 11:55 PM
sandyryza committed R1:fcc2fdb20a2c: remove selector from tutorial (authored by sandyryza).
remove selector from tutorial
Mon, Oct 19, 11:55 PM
yuhan updated the summary of D4579: address-store-1 AddressStore / AssetAddress + AssetStore.
Mon, Oct 19, 11:48 PM
rexledesma closed D4674: Add liveness probe to extra celery workers.
Mon, Oct 19, 11:48 PM
rexledesma committed R1:b522ecc3a69f: Add liveness probe to extra celery workers (authored by rexledesma).
Add liveness probe to extra celery workers
Mon, Oct 19, 11:47 PM
max requested review of D4822: serialization safety.
Mon, Oct 19, 11:13 PM
max added inline comments to D4764: add summary table for asset keys.
Mon, Oct 19, 11:07 PM
dish added a comment to D4809: Clean up partitions UI and improve backfill usability.

Possibly crazy idea: can we use a yaml CodeMirror here? E.g.

Mon, Oct 19, 10:54 PM
max accepted D4763: remove selector from tutorial.

can you open an issue to intro selector in docs

Mon, Oct 19, 10:52 PM
max closed D4816: Stream dbt logs and re-log messages.
Mon, Oct 19, 10:43 PM
max committed R1:4826cabaf027: Stream dbt logs and re-log messages (authored by max).
Stream dbt logs and re-log messages
Mon, Oct 19, 10:43 PM
Harbormaster failed remote builds in B19813: Diff 24037 for D4764: add summary table for asset keys!
Mon, Oct 19, 10:41 PM
Harbormaster failed remote builds in B19812: Diff 24036 for D4764: add summary table for asset keys!
Mon, Oct 19, 10:20 PM
prha updated the diff for D4764: add summary table for asset keys.

black

Mon, Oct 19, 10:20 PM
prha added inline comments to D4764: add summary table for asset keys.
Mon, Oct 19, 10:15 PM
prha updated the diff for D4764: add summary table for asset keys.

rebase, add more logging to migration script

Mon, Oct 19, 10:15 PM
dish requested review of D4821: RFC: [dagit] Start adding Workspace routes.
Mon, Oct 19, 10:04 PM
prha updated the diff for D4800: RFC: Add table to track migration of secondary indexes on the event_log table.
comments
Mon, Oct 19, 9:55 PM
rexledesma updated the diff for D4718: Configure celeryless deploy on helm.

use pipeline env configmap

Mon, Oct 19, 9:50 PM
Harbormaster failed remote builds in B19804: Diff 24028 for D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API!
Mon, Oct 19, 9:34 PM
rexledesma updated the diff for D4718: Configure celeryless deploy on helm.

add docs

Mon, Oct 19, 9:29 PM
rexledesma updated the summary of D4718: Configure celeryless deploy on helm.
Mon, Oct 19, 9:19 PM
dgibson updated the diff for D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.

up

Mon, Oct 19, 9:16 PM
bengotow accepted D4807: (config-scaffold 1/n) Fix config errors visualization in Dagit.

This looks great! Good catch 👍

Mon, Oct 19, 9:10 PM
bob accepted D4816: Stream dbt logs and re-log messages.

Macro chefkiss:

Mon, Oct 19, 8:58 PM
alangenfeld added a comment to D4814: rm DagsterKubernetesPodOperator and test infra around it.

As per discussion in the platform lane chat.

Mon, Oct 19, 8:50 PM
dgibson requested review of D4814: rm DagsterKubernetesPodOperator and test infra around it.

test failures are transient/unrelated

Mon, Oct 19, 8:43 PM
max requested review of D4816: Stream dbt logs and re-log messages.
Mon, Oct 19, 8:42 PM
rexledesma requested review of D4815: Configure syntax for python diffs in gitattributes.
Mon, Oct 19, 8:39 PM
bengotow accepted D4812: remove backfill check for step selection.

Looks great!

Mon, Oct 19, 8:38 PM
Harbormaster failed remote builds in B19791: Diff 24014 for D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API!
Mon, Oct 19, 8:03 PM
dgibson requested review of D4813: Maintain backcompat in date_partition_range.
Mon, Oct 19, 7:59 PM
dish requested changes to D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.

Direction looks great to me. Some nits inline, mostly stylistic/legibility things.

Mon, Oct 19, 7:54 PM
dgibson updated the diff for D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.

up

Mon, Oct 19, 7:46 PM
dgibson closed D4769: Use execute_step_with_structured_logs in DagsterDockerOperator.
Mon, Oct 19, 7:40 PM
dgibson committed R1:febffd667ebb: Use execute_step_with_structured_logs in DagsterDockerOperator (authored by dgibson).
Use execute_step_with_structured_logs in DagsterDockerOperator
Mon, Oct 19, 7:40 PM
alangenfeld added inline comments to D4800: RFC: Add table to track migration of secondary indexes on the event_log table.
Mon, Oct 19, 7:39 PM
Harbormaster failed remote builds in B19785: Diff 24006 for D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids!
Mon, Oct 19, 7:30 PM
schrockn requested changes to D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.

This is great! Some minor feedback. Big improvement

Mon, Oct 19, 7:26 PM
sashank updated the diff for D4807: (config-scaffold 1/n) Fix config errors visualization in Dagit.

up

Mon, Oct 19, 7:25 PM
schrockn requested changes to D4781: RFC: allow optional configuration of parent pipeline solids for subsetted pipeline.

this is good but it needs tests

Mon, Oct 19, 7:20 PM
prha added inline comments to D4800: RFC: Add table to track migration of secondary indexes on the event_log table.
Mon, Oct 19, 7:15 PM
schrockn added a comment to D4811: RFC: decorator-based mode definition.

Using SolidDefinition is desirable for framework authors. This is a layered system

Mon, Oct 19, 7:14 PM