Page MenuHomeElementl
Feed All Stories

Today

jordansanders added inline comments to D7395: Provide more detailed SkipReasons.
Mon, Apr 19, 2:39 PM
dish closed D7487: [dagit] Assets: Only show latest materialization in list.
Mon, Apr 19, 2:16 PM
dish committed R1:ed7ba1a71794: [dagit] Assets: Only show latest materialization in list (authored by dish).
[dagit] Assets: Only show latest materialization in list
Mon, Apr 19, 2:15 PM
dgibson accepted D7395: Provide more detailed SkipReasons.
Mon, Apr 19, 2:05 PM
Chris DeCarolis <cdguitar817@gmail.com> closed D7462: Limit the scope of hook context.
Mon, Apr 19, 2:03 PM
Chris DeCarolis <cdguitar817@gmail.com> committed R1:4391029623b9: Limit the scope of hook context (authored by Chris DeCarolis <cdguitar817@gmail.com>).
Limit the scope of hook context
Mon, Apr 19, 2:03 PM
dish updated the diff for D7487: [dagit] Assets: Only show latest materialization in list.

+bengotow

Mon, Apr 19, 2:01 PM
dgibson added reviewers for D7494: Refactor how we handle exceptions in daemons: prha, johann, alangenfeld.
Mon, Apr 19, 1:38 PM
dgibson added reviewers for D7495: Fix termination in docker deploy example: alangenfeld, johann.
Mon, Apr 19, 1:37 PM
johann accepted D7460: Recover from failed backfills, populate backfill errors.
Mon, Apr 19, 1:28 PM
dgibson updated the diff for D7494: Refactor how we handle exceptions in daemons.

up

Mon, Apr 19, 3:48 AM
Harbormaster failed remote builds in B29044: Diff 35645 for D7495: Fix termination in docker deploy example!
Mon, Apr 19, 3:20 AM
dgibson updated the diff for D7495: Fix termination in docker deploy example.

up

Mon, Apr 19, 2:59 AM
dgibson updated the diff for D7495: Fix termination in docker deploy example.

up

Mon, Apr 19, 2:58 AM

Sat, Apr 17

dgibson requested review of D7495: Fix termination in docker deploy example.
Sat, Apr 17, 3:52 PM
dgibson updated the diff for D7494: Refactor how we handle exceptions in daemons.

up

Sat, Apr 17, 2:42 AM
dgibson requested review of D7494: Refactor how we handle exceptions in daemons.
Sat, Apr 17, 2:40 AM
dgibson closed D7479: Add a default gRPC timeout to better handle slow/hanging sensors in the daemon.
Sat, Apr 17, 1:01 AM
dgibson committed R1:58be49bd59f5: Add a default gRPC timeout to better handle slow/hanging sensors in the daemon (authored by dgibson).
Add a default gRPC timeout to better handle slow/hanging sensors in the daemon
Sat, Apr 17, 1:01 AM
dgibson closed D7491: include stack trace in repo failure.
Sat, Apr 17, 12:59 AM
dgibson committed R1:23dbfe0051c0: include stack trace in repo failure (authored by dgibson).
include stack trace in repo failure
Sat, Apr 17, 12:59 AM
Harbormaster failed remote builds in B29034: Diff 35633 for D7476: WIP convert hook_fn to a dummy pipeline and a sensor!
Sat, Apr 17, 12:17 AM
Harbormaster failed remote builds in B29033: Diff 35632 for D7476: WIP convert hook_fn to a dummy pipeline and a sensor!
Sat, Apr 17, 12:15 AM
Harbormaster failed remote builds in B29032: Diff 35631 for D7476: WIP convert hook_fn to a dummy pipeline and a sensor!
Sat, Apr 17, 12:14 AM

Fri, Apr 16

prha requested review of D7493: change run view to show compute log panel with log type toggle.
Fri, Apr 16, 11:23 PM
yuhan published D7476: WIP convert hook_fn to a dummy pipeline and a sensor for review.
Fri, Apr 16, 11:11 PM
owen closed D7419: Improved error message when missing config.
Fri, Apr 16, 10:49 PM
owen committed R1:e329f941c271: Improved error message when missing config (authored by owen).
Improved error message when missing config
Fri, Apr 16, 10:49 PM
alangenfeld accepted D7491: include stack trace in repo failure.

olmec

Fri, Apr 16, 10:29 PM
alangenfeld published D7491: include stack trace in repo failure for review.
Fri, Apr 16, 10:28 PM
owen updated the diff for D7419: Improved error message when missing config.
  • restored correct version of file
Fri, Apr 16, 10:23 PM
alangenfeld added inline comments to D7295: raise exceptions from grpc methods.
Fri, Apr 16, 10:23 PM
owen added a comment to D7419: Improved error message when missing config.

i think this is a clear step forward even if its json sample in yaml land dagit

also - looks like we are not including commas between fields for the "expected" section when there is extra config? not sure if thats an easy diff to throw out while you're in this zone

resolve inlines before landing

Fri, Apr 16, 10:16 PM
owen updated the diff for D7419: Improved error message when missing config.

up

Fri, Apr 16, 10:04 PM
alangenfeld added inline comments to D7295: raise exceptions from grpc methods.
Fri, Apr 16, 9:47 PM
prha closed D7486: change test to customize timeout to minimize test flakes.
Fri, Apr 16, 9:41 PM
prha committed R1:b1b34612d917: change test to customize timeout to minimize test flakes (authored by prha).
change test to customize timeout to minimize test flakes
Fri, Apr 16, 9:41 PM
alangenfeld requested review of D7489: refactor solid input validation.
Fri, Apr 16, 9:35 PM
sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/3].

rebasing

Fri, Apr 16, 9:19 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3].

Trying installation of dagster-graphql to fix build

Fri, Apr 16, 9:10 PM
bengotow accepted D7487: [dagit] Assets: Only show latest materialization in list.

This seems like a good workflow improvement! Certainly makes the list easier to scan through and emphasizes that the graphs, etc. also only show the most recent run for the partition.

Fri, Apr 16, 8:46 PM
alangenfeld accepted D7486: change test to customize timeout to minimize test flakes.
Fri, Apr 16, 8:35 PM
sidkmenon abandoned D7343: [Draft] [RFC] [dagster-graphql] Initial Python Client implementation.
Fri, Apr 16, 8:33 PM
prha added reviewers for D7486: change test to customize timeout to minimize test flakes: max, alangenfeld.
Fri, Apr 16, 8:31 PM
sidkmenon updated the test plan for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/3].
Fri, Apr 16, 8:30 PM
sidkmenon added reviewers for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3]: alangenfeld, catherinewu.
Fri, Apr 16, 8:30 PM
sidkmenon added a reviewer for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/3]: catherinewu.
Fri, Apr 16, 8:29 PM
sidkmenon added a reviewer for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/3]: alangenfeld.
Fri, Apr 16, 8:29 PM
Harbormaster failed remote builds in B29015: Diff 35611 for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/3]!
Fri, Apr 16, 8:28 PM
jordansanders closed D7482: Don't pass a dir to our TemporaryDirectory.
Fri, Apr 16, 8:24 PM
jordansanders committed R1:c232f190a947: Don't pass a dir to our TemporaryDirectory (authored by jordansanders).
Don't pass a dir to our TemporaryDirectory
Fri, Apr 16, 8:24 PM
Harbormaster failed remote builds in B29014: Diff 35610 for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3]!
Fri, Apr 16, 8:24 PM
prha requested review of D7486: change test to customize timeout to minimize test flakes.
Fri, Apr 16, 8:23 PM
Harbormaster failed remote builds in B29010: Diff 35606 for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/3]!
Fri, Apr 16, 8:15 PM
yuhan accepted D7444: fix non-required fields in IOManager output_config_schemas.
Fri, Apr 16, 8:13 PM
yuhan added a comment to D7446: default config schema to Any.

i think we should update all the config_schema arg docstrings to mention this default behavior, e.g. in @solid, SolidDefinition, @resource, and a lot more - esp composite and io manager will behave differently.

Fri, Apr 16, 8:12 PM
sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/3].

Rebasing

Fri, Apr 16, 8:11 PM
dish requested review of D7487: [dagit] Assets: Only show latest materialization in list.
Fri, Apr 16, 8:07 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3].

Adding dagster-graphql to tox.ini and setup.py in automation

Fri, Apr 16, 8:03 PM
Harbormaster failed remote builds in B29009: Diff 35605 for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3]!
Fri, Apr 16, 8:00 PM
Harbormaster failed remote builds in B29008: Diff 35604 for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3]!
Fri, Apr 16, 8:00 PM
sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/3].

Moving submit_pipeline_execution tests to the GraphQL python client's test suite

Fri, Apr 16, 7:54 PM
rexledesma added a comment to D7478: [Helm] Allow configuration of postgres connection string on storage classes.

@johann yeah I might have went about this a goofy way - it's probably more simpler to just expose a new field postgres_db.db_params in the storage config, and then just append the urlencoded values to the generated postgresql connection string

Fri, Apr 16, 7:45 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3].

Fixing are_queries_compatible

Fri, Apr 16, 7:43 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3].

Added regex check to remove redundant spacing from query strings as well

Fri, Apr 16, 7:41 PM
Harbormaster failed remote builds in B29007: Diff 35602 for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3]!
Fri, Apr 16, 7:39 PM
yuhan requested review of D7484: RFC make_config_resource 1/.
Fri, Apr 16, 7:37 PM
johann added a comment to D7478: [Helm] Allow configuration of postgres connection string on storage classes.

It might be helpful to get more context from the user, are there cases where they couldn't just pull out the user/password/etc? Looks like it wouldn't be too hard postgresql://[user[:password]@][netloc][:port][/dbname][?param1=value1&...]

Fri, Apr 16, 7:35 PM
max closed D7436: Add --short flag to dagster-release version (for automation).
Fri, Apr 16, 7:28 PM
max committed R1:e26d34662914: Add --short flag to dagster-release version (for automation) (authored by max).
Add --short flag to dagster-release version (for automation)
Fri, Apr 16, 7:27 PM
rexledesma planned changes to D7478: [Helm] Allow configuration of postgres connection string on storage classes.

More complicated than expected - will have to update the k8s run launchers to take in postgres_connection_string_secret rather than postgres_password_secret

Fri, Apr 16, 7:24 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3].

Adding checks for redundant dagster-graphql-client query snapshot calls and refactoring

Fri, Apr 16, 7:18 PM
prha closed D7483: fix compute log subscriptions.
Fri, Apr 16, 7:18 PM
prha committed R1:22a848c07564: fix compute log subscriptions (authored by prha).
fix compute log subscriptions
Fri, Apr 16, 7:18 PM
cdecarolis abandoned D6911: Execute API.

q mgmt

Fri, Apr 16, 6:56 PM
cdecarolis abandoned D6797: Submit API.

q mgmt

Fri, Apr 16, 6:53 PM
cdecarolis abandoned D6727: Reconstructable from file pointing to workspace yaml.

q mgmt

Fri, Apr 16, 6:53 PM
Harbormaster failed remote builds in B29000: Diff 35593 for D7478: [Helm] Allow configuration of postgres connection string on storage classes!
Fri, Apr 16, 6:37 PM
Harbormaster failed remote builds in B29002: Diff 35596 for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/3]!
Fri, Apr 16, 6:23 PM
Harbormaster failed remote builds in B29001: Diff 35594 for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3]!
Fri, Apr 16, 6:18 PM
alangenfeld accepted D7419: Improved error message when missing config.

i think this is a clear step forward even if its json sample in yaml land dagit

Fri, Apr 16, 6:10 PM
alangenfeld accepted D7483: fix compute log subscriptions.

golem

Fri, Apr 16, 6:05 PM
sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/3].

Rebasing

Fri, Apr 16, 6:05 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/3].

Responding to comments - refactoring cli to dagster-graphql-client cli

Fri, Apr 16, 5:59 PM
Harbormaster failed remote builds in B28998: Diff 35591 for D7478: [Helm] Allow configuration of postgres connection string on storage classes!
Fri, Apr 16, 5:56 PM
rexledesma updated the diff for D7478: [Helm] Allow configuration of postgres connection string on storage classes.

clarify localhost

Fri, Apr 16, 5:52 PM
sandyryza added a comment to D7419: Improved error message when missing config.

This will be a huge approachability and general usability win.

Fri, Apr 16, 5:52 PM
prha requested review of D7483: fix compute log subscriptions.
Fri, Apr 16, 5:51 PM
sandyryza added inline comments to D7261: [RFC] change DagsterInstance.get behavior.
Fri, Apr 16, 5:46 PM
dgibson accepted D7482: Don't pass a dir to our TemporaryDirectory.
Fri, Apr 16, 5:36 PM
jordansanders requested review of D7482: Don't pass a dir to our TemporaryDirectory.
Fri, Apr 16, 5:27 PM
Harbormaster failed remote builds in B28996: Diff 35589 for D7478: [Helm] Allow configuration of postgres connection string on storage classes!
Fri, Apr 16, 5:18 PM
rexledesma updated the diff for D7478: [Helm] Allow configuration of postgres connection string on storage classes.

fix fixture import

Fri, Apr 16, 5:13 PM
yuhan added inline comments to D7462: Limit the scope of hook context.
Fri, Apr 16, 5:03 PM
prha accepted D7479: Add a default gRPC timeout to better handle slow/hanging sensors in the daemon.
Fri, Apr 16, 5:00 PM
prha added a comment to D7479: Add a default gRPC timeout to better handle slow/hanging sensors in the daemon.

I think this is good. We might eventually want to fork a process for each evaluation, and then change the timeout based on the min interval? But better to make this change and then think through the ramifications of the other stuff.

Fri, Apr 16, 5:00 PM
rexledesma published D7478: [Helm] Allow configuration of postgres connection string on storage classes for review.
Fri, Apr 16, 4:59 PM
owen published D7419: Improved error message when missing config for review.
Fri, Apr 16, 4:56 PM
cdecarolis added inline comments to D7462: Limit the scope of hook context.
Fri, Apr 16, 4:56 PM
dgibson requested review of D7479: Add a default gRPC timeout to better handle slow/hanging sensors in the daemon.
Fri, Apr 16, 4:55 PM