Page MenuHomePhabricator
Feed All Stories

Yesterday

sashank committed R1:f6f7aecfd63a: Set environment variables on ScheduleDefinition (authored by sashank).
Set environment variables on ScheduleDefinition
Thu, Aug 22, 11:36 PM
Sashank Thupukari <s@thupukari.com> closed D877: Set environment variables on ScheduleDefinition.
Thu, Aug 22, 11:36 PM
sashank updated the diff for D877: Set environment variables on ScheduleDefinition.

Rebase

Thu, Aug 22, 11:26 PM
sashank committed R1:69ea4d6073d8: Add repo yaml directory to python path in dagster-graphql cli (authored by sashank).
Add repo yaml directory to python path in dagster-graphql cli
Thu, Aug 22, 11:25 PM
Sashank Thupukari <s@thupukari.com> closed D873: Add repo yaml directory to python path in dagster-graphql cli.
Thu, Aug 22, 11:25 PM
sashank updated the diff for D873: Add repo yaml directory to python path in dagster-graphql cli.

Move add to path before loading module

Thu, Aug 22, 11:13 PM
natekupp accepted D873: Add repo yaml directory to python path in dagster-graphql cli.
Thu, Aug 22, 10:55 PM
sashank updated the diff for D873: Add repo yaml directory to python path in dagster-graphql cli.

Only add if not already in sys.path

Thu, Aug 22, 10:50 PM
sashank updated the diff for D873: Add repo yaml directory to python path in dagster-graphql cli.

Move to LoaderEntrypoint

Thu, Aug 22, 10:44 PM
sashank updated the diff for D877: Set environment variables on ScheduleDefinition.

Rebase

Thu, Aug 22, 10:07 PM
sashank updated the diff for D873: Add repo yaml directory to python path in dagster-graphql cli.

Move to ExecutionTargetHandle

Thu, Aug 22, 10:07 PM
alangenfeld accepted D877: Set environment variables on ScheduleDefinition.

thumbsup

Thu, Aug 22, 9:57 PM
bengotow committed R1:0180115e15bc: Performance improvements based on fan-in-out example DAG (authored by bengotow).
Performance improvements based on fan-in-out example DAG
Thu, Aug 22, 9:51 PM
Ben Gotow <ben@foundry376.com> closed D869: Performance improvements based on fan-in-out example DAG.
Thu, Aug 22, 9:51 PM
bengotow updated the diff for D869: Performance improvements based on fan-in-out example DAG.
  • Add prop name to shouldComponentUpdate
Thu, Aug 22, 9:51 PM
bengotow added inline comments to D869: Performance improvements based on fan-in-out example DAG.
Thu, Aug 22, 9:48 PM
sashank created D877: Set environment variables on ScheduleDefinition.
Thu, Aug 22, 9:46 PM
schrockn accepted D844: Initial pass at custom modification of the Dagre layout for wide pipelines.

accepting because of fun tests in other diff

Thu, Aug 22, 9:44 PM
bengotow added a comment to D875: Add test coverage of the pipeline to svg process using svg snapshots.

Yeah we definitely need to hide some of these files!

Thu, Aug 22, 9:30 PM
natekupp created D876: Fix Slack link.
Thu, Aug 22, 9:26 PM
schrockn added a comment to D875: Add test coverage of the pipeline to svg process using svg snapshots.
  1. We should definitely configure phab to hide those huge data files
  2. This is really cool! Can you post a screenshot of the visual diff? Really curious what that looks like.
Thu, Aug 22, 9:04 PM
bengotow updated the diff for D875: Add test coverage of the pipeline to svg process using svg snapshots.
  • Add a test for a composite, add package cache so the tests pass
Thu, Aug 22, 9:02 PM
bengotow updated the diff for D875: Add test coverage of the pipeline to svg process using svg snapshots.
  • Add a test for a composite, add package cache so the tests pass
Thu, Aug 22, 9:01 PM
schrockn added a comment to D874: RFC: Remove lambda_solid from tutorial.

Yeah agree that it's not a slam dunk

Thu, Aug 22, 9:01 PM
Harbormaster failed remote builds in B3154: Diff 3950 for D875: Add test coverage of the pipeline to svg process using svg snapshots!
Thu, Aug 22, 8:49 PM
alangenfeld committed R1:a08b07d94c42: fix bad rebase (authored by alangenfeld).
fix bad rebase
Thu, Aug 22, 8:43 PM
bengotow created D875: Add test coverage of the pipeline to svg process using svg snapshots.
Thu, Aug 22, 8:43 PM
sashank updated the diff for D873: Add repo yaml directory to python path in dagster-graphql cli.

Rebase

Thu, Aug 22, 8:25 PM
prha accepted D869: Performance improvements based on fan-in-out example DAG.

small nit, but overall this looks great!

Thu, Aug 22, 8:20 PM
alangenfeld committed R1:bb5ae923c591: [storage] handle missing event log files (authored by alangenfeld).
[storage] handle missing event log files
Thu, Aug 22, 8:19 PM
alangenfeld closed D870: [storage] handle missing event log files.
Thu, Aug 22, 8:19 PM
alangenfeld updated the diff for D870: [storage] handle missing event log files.

verify_event_log_exists

Thu, Aug 22, 8:04 PM
alangenfeld added a comment to D874: RFC: Remove lambda_solid from tutorial.

hmmmm

Thu, Aug 22, 7:53 PM
bengotow added a comment to D844: Initial pass at custom modification of the Dagre layout for wide pipelines.

Hmm, this is /sorta/ incorporated into the snapshot tests, but I think we could definitely create some tests around dagre and this overall layout logic. Actually, we may be able to render out SVGs of given DAGs and then compare the SVGs, which would allow you to see WHAT changed when the code is modified / broken (I think otherwise this is just going to be comparing 200kb of JSON full of numbers and they'll just get updated blindly.) Will see if I can set this up today.

Thu, Aug 22, 6:54 PM
schrockn created D874: RFC: Remove lambda_solid from tutorial.
Thu, Aug 22, 6:53 PM
sashank updated the test plan for D873: Add repo yaml directory to python path in dagster-graphql cli.
Thu, Aug 22, 6:49 PM
sashank created D873: Add repo yaml directory to python path in dagster-graphql cli.
Thu, Aug 22, 6:48 PM
sashank committed R1:dc2c6e1bcbb0: Fix FilesystemRunStorage instantiations (authored by sashank).
Fix FilesystemRunStorage instantiations
Thu, Aug 22, 6:41 PM
Sashank Thupukari <s@thupukari.com> closed D872: Fix FilesystemRunStorage instantiations.
Thu, Aug 22, 6:41 PM
prha committed R1:22bee0fd8681: 0.5.7 (authored by prha).
0.5.7
Thu, Aug 22, 6:38 PM
sashank updated the diff for D872: Fix FilesystemRunStorage instantiations.

Move changes to branch

Thu, Aug 22, 6:28 PM
Harbormaster failed remote builds in B3147: Diff 3941 for D872: Fix FilesystemRunStorage instantiations!
Thu, Aug 22, 6:20 PM
sashank updated the diff for D872: Fix FilesystemRunStorage instantiations.

Fix test

Thu, Aug 22, 6:19 PM
schrockn accepted D872: Fix FilesystemRunStorage instantiations.
Thu, Aug 22, 6:15 PM
sashank updated the diff for D872: Fix FilesystemRunStorage instantiations.

Add test

Thu, Aug 22, 6:13 PM
sashank created D872: Fix FilesystemRunStorage instantiations.
Thu, Aug 22, 6:07 PM
schrockn accepted D870: [storage] handle missing event log files.

Actually I'm quite wrong given that the EventLogStorage class in question has context about the underlying store.

Thu, Aug 22, 5:44 PM
schrockn requested changes to D870: [storage] handle missing event log files.
Thu, Aug 22, 5:43 PM
prha committed R1:81ef8f220fbd: 0.5.7.pre0 (authored by prha).
0.5.7.pre0
Thu, Aug 22, 5:39 PM
natekupp committed R1:8c0bb011e943: Fixes Dagit on Windows (authored by natekupp).
Fixes Dagit on Windows
Thu, Aug 22, 5:33 PM
Nate Kupp <nate@elementl.com> closed D871: Fixes Dagit on Windows.
Thu, Aug 22, 5:33 PM
natekupp updated the diff for D871: Fixes Dagit on Windows.

up

Thu, Aug 22, 5:23 PM
prha added inline comments to D871: Fixes Dagit on Windows.
Thu, Aug 22, 5:20 PM
prha accepted D871: Fixes Dagit on Windows.

LGTM

Thu, Aug 22, 5:20 PM
natekupp created D871: Fixes Dagit on Windows.
Thu, Aug 22, 5:14 PM
natekupp committed R1:d0a7e0e0f805: RFC: Add support for specifying Dask resources (authored by natekupp).
RFC: Add support for specifying Dask resources
Thu, Aug 22, 4:55 PM
Nate Kupp <nate@elementl.com> closed D851: RFC: Add support for specifying Dask resources.
Thu, Aug 22, 4:55 PM
sashank planned changes to D855: [WIP] Create scaffolding for dagit scheduler UI.
Thu, Aug 22, 4:49 PM
alangenfeld accepted D851: RFC: Add support for specifying Dask resources.

shipit

Thu, Aug 22, 4:40 PM
sashank committed R1:0585f4650172: Set dagster home in dagit service (authored by sashank).
Set dagster home in dagit service
Thu, Aug 22, 4:39 PM
Sashank Thupukari <s@thupukari.com> closed D865: Set dagster home in dagit service.
Thu, Aug 22, 4:39 PM
natekupp updated the diff for D851: RFC: Add support for specifying Dask resources.

up

Thu, Aug 22, 4:33 PM
alangenfeld committed R1:cae2fa5a4db7: [RFC] simpler user defined types section (authored by alangenfeld).
[RFC] simpler user defined types section
Thu, Aug 22, 4:25 PM
alangenfeld closed D861: [RFC] simpler user defined types section.
Thu, Aug 22, 4:25 PM
natekupp committed R1:76671dc95332: Add a more prominent Slack button to the readme (authored by natekupp).
Add a more prominent Slack button to the readme
Thu, Aug 22, 4:20 PM
Nate Kupp <nate@elementl.com> closed D868: Add a more prominent Slack button to the readme.
Thu, Aug 22, 4:20 PM
alangenfeld created D870: [storage] handle missing event log files.
Thu, Aug 22, 3:25 PM
alangenfeld accepted D868: Add a more prominent Slack button to the readme.

illallowit

Thu, Aug 22, 2:40 PM
bengotow added a comment to D858: Overhauled run history view.

Thanks for the comments—will get these addressed tomorrow,

Thu, Aug 22, 6:52 AM
bengotow updated the diff for D869: Performance improvements based on fan-in-out example DAG.
  • Fix up comments
Thu, Aug 22, 6:40 AM
bengotow updated the summary of D869: Performance improvements based on fan-in-out example DAG.
Thu, Aug 22, 6:32 AM
bengotow updated the summary of D869: Performance improvements based on fan-in-out example DAG.
Thu, Aug 22, 6:29 AM
bengotow created D869: Performance improvements based on fan-in-out example DAG.
Thu, Aug 22, 6:22 AM
natekupp updated the summary of D868: Add a more prominent Slack button to the readme.
Thu, Aug 22, 5:17 AM
natekupp added a comment to D868: Add a more prominent Slack button to the readme.
Thu, Aug 22, 5:16 AM
natekupp created D868: Add a more prominent Slack button to the readme.
Thu, Aug 22, 5:15 AM
natekupp committed R1:071352432e8b: [4/N] dagster-aws CLI: nuke (authored by natekupp).
[4/N] dagster-aws CLI: nuke
Thu, Aug 22, 4:34 AM
Nate Kupp <nate@elementl.com> closed D867: [4/N] dagster-aws CLI: nuke.
Thu, Aug 22, 4:33 AM
sashank accepted D867: [4/N] dagster-aws CLI: nuke.
Thu, Aug 22, 4:23 AM
natekupp updated the diff for D867: [4/N] dagster-aws CLI: nuke.

up

Thu, Aug 22, 4:19 AM
schrockn requested changes to D851: RFC: Add support for specifying Dask resources.
Thu, Aug 22, 3:13 AM
schrockn added a comment to D851: RFC: Add support for specifying Dask resources.

agree on deciding on some sort of namespacing scheme here. i bias towards {'dask': {'resource_requirements': {...}}} option because it is inline with our current config system. but it does say something the software people like (e.g. vscode and k8s) using the in-key namespacing scheme

Thu, Aug 22, 3:13 AM

Wed, Aug 21

natekupp created D867: [4/N] dagster-aws CLI: nuke.
Wed, Aug 21, 11:35 PM
natekupp committed R1:6b6a71b26e2d: [3/N] dagster-aws CLI fix for make dev_install (authored by natekupp).
[3/N] dagster-aws CLI fix for make dev_install
Wed, Aug 21, 11:35 PM
Nate Kupp <nate@elementl.com> closed D866: [3/N] dagster-aws CLI fix for make dev_install.
Wed, Aug 21, 11:34 PM
sashank accepted D866: [3/N] dagster-aws CLI fix for make dev_install.
Wed, Aug 21, 11:34 PM
natekupp created D866: [3/N] dagster-aws CLI fix for make dev_install.
Wed, Aug 21, 11:13 PM
schrockn accepted D861: [RFC] simpler user defined types section.

Sauce

Wed, Aug 21, 11:01 PM
sashank added inline comments to D858: Overhauled run history view.
Wed, Aug 21, 10:50 PM
natekupp committed R1:9043b8a62ecf: [2/N] dagster-aws CLI fixes: use existing keypair if possible (authored by natekupp).
[2/N] dagster-aws CLI fixes: use existing keypair if possible
Wed, Aug 21, 10:45 PM
Nate Kupp <nate@elementl.com> closed D864: [2/N] dagster-aws CLI fixes: use existing keypair if possible.
Wed, Aug 21, 10:45 PM
sashank accepted D864: [2/N] dagster-aws CLI fixes: use existing keypair if possible.
Wed, Aug 21, 10:44 PM
alangenfeld commandeered D862: Add naive filesystem log watchers.
Wed, Aug 21, 10:43 PM
natekupp accepted D865: Set dagster home in dagit service.
Wed, Aug 21, 10:35 PM
sashank updated the diff for D865: Set dagster home in dagit service.

Remove $

Wed, Aug 21, 10:30 PM
natekupp requested changes to D865: Set dagster home in dagit service.

one change, see comment

Wed, Aug 21, 10:30 PM
sashank updated the diff for D865: Set dagster home in dagit service.

Rebase

Wed, Aug 21, 10:29 PM
sashank created D865: Set dagster home in dagit service.
Wed, Aug 21, 10:28 PM
natekupp created D864: [2/N] dagster-aws CLI fixes: use existing keypair if possible.
Wed, Aug 21, 10:28 PM
natekupp committed R1:cbae0b92a9cf: [1/N] dagster-aws CLI fixes (authored by natekupp).
[1/N] dagster-aws CLI fixes
Wed, Aug 21, 10:27 PM