Rebase

Move add to path before loading module

Only add if not already in sys.path

Move to LoaderEntrypoint

Rebase

Move to ExecutionTargetHandle

• Add prop name to shouldComponentUpdate

accepting because of fun tests in other diff

Yeah we definitely need to hide some of these files!

1. We should definitely configure phab to hide those huge data files
2. This is really cool! Can you post a screenshot of the visual diff? Really curious what that looks like.

• Add a test for a composite, add package cache so the tests pass

• Add a test for a composite, add package cache so the tests pass

Yeah agree that it's not a slam dunk

Rebase

small nit, but overall this looks great!

verify_event_log_exists

hmmmm

Hmm, this is /sorta/ incorporated into the snapshot tests, but I think we could definitely create some tests around dagre and this overall layout logic. Actually, we may be able to render out SVGs of given DAGs and then compare the SVGs, which would allow you to see WHAT changed when the code is modified / broken (I think otherwise this is just going to be comparing 200kb of JSON full of numbers and they'll just get updated blindly.) Will see if I can set this up today.

Move changes to branch

Fix test

Add test

Actually I'm quite wrong given that the EventLogStorage class in question has context about the underlying store.

up

LGTM

up

Thanks for the comments—will get these addressed tomorrow,

• Fix up comments

up

agree on deciding on some sort of namespacing scheme here. i bias towards {'dask': {'resource_requirements': {...}}} option because it is inline with our current config system. but it does say something the software people like (e.g. vscode and k8s) using the in-key namespacing scheme

Sauce

Remove $

one change, see comment

Rebase