Gah you're right
Feed All Stories
Today
Today
cdecarolis added inline comments to D4830: Yet another line number fix 😔.
GitHub <noreply@github.com> committed R1:3ad09f8cee97: Add limit to "dagster run list" (#3117) (authored by Haydar Ali Ismail <2961388+haydarai@users.noreply.github.com>).
Add limit to "dagster run list" (#3117)
dgibson updated the diff for D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.
rebase
GitHub <noreply@github.com> committed R1:a03bd01310be: Use env variables for CLI command options (#3077) (authored by Xinbin Huang <bin.huangxb@gmail.com>).
Use env variables for CLI command options (#3077)
alangenfeld committed R1:e20aa4735326: multiprocessing executor doc block fix (authored by alangenfeld).
multiprocessing executor doc block fix
sandyryza added inline comments to D4830: Yet another line number fix 😔.
prha added inline comments to D4813: Maintain backcompat in date_partition_range.
cdecarolis requested review of D4830: Yet another line number fix 😔.
prha added a comment to D4809: Clean up partitions UI and improve backfill usability.
I kind of like the codemirror idea... and having yaml removes the requirement to learn another DSL.
dgibson committed R1:6d3e9aaac0af: Ensure that origins don't change when we switch from cli api repos to grpc repos (authored by dgibson).
Ensure that origins don't change when we switch from cli api repos to grpc repos
dgibson added inline comments to D4823: Ensure that origins don't change when we switch from cli api repos to grpc repos.
dgibson added a comment to D4821: RFC: [dagit] Start adding Workspace routes.
Overall this makes sense to me!
prha added inline comments to D4813: Maintain backcompat in date_partition_range.
dgibson requested review of D4827: Append "_location" to default repository location name.
prha requested changes to D4691: Basic display of asset partition coverage / value by partition.
Code looks okay, but hitting lots of merge conflicts... Req'ing for rebase.
serialization safety
awesome! looking forward to seeing this pushed
bob added inline comments to D4822: serialization safety.
remove backfill check for step selection
prha updated the diff for D4764: add summary table for asset keys.
update doc, messages
prha added inline comments to D4764: add summary table for asset keys.
prha updated the diff for D4764: add summary table for asset keys.
remove test for removed migration
sashank requested review of D4826: [easy] Clean up instance file.
catherinewu added inline comments to D4718: Configure celeryless deploy on helm.
schrockn requested changes to D4820: address-store-0 AssetAddress + AssetStore.
cool. this is looking good. i think the biggest issue with this as written is that you current require path in the asset_metadata for the default asset store. I think it should be the opposite and the default asset storage should take care of it for you.
dgibson requested review of D4817: Remove executePlan dagster-graphql call.
dgibson requested review of D4824: Remove legacy repo format from loading path.
Superseded by https://dagster.phacility.com/D4806
dgibson updated the diff for D4742: Remove legacy repo format from examples/tests, replace the default with the new standard format except when specifically testing legacy stuff.
remove the breaking part, just update teh examples and tests for now
sandyryza requested review of D4806: create dagster-aws-pyspark library with emr_pyspark_step_launcher.
dgibson added a reviewer for D4805: Don't rebuild the docker image every time you run a kind test locally: alangenfeld.
yichendai updated the summary of D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
yichendai updated the summary of D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
yichendai updated the summary of D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
yuhan requested review of D4820: address-store-0 AssetAddress + AssetStore.
yichendai added a comment to D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
Created another config_more_details.py to hold the optional config. The config.py contains the least verbose example.
yichendai updated the diff for D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
Update: Start with the least verbose config example
Harbormaster failed remote builds in B19821: Diff 24048 for D4579: address-store-1 AddressStore / AssetAddress + AssetStore!
dgibson updated the diff for D4814: rm DagsterKubernetesPodOperator and test infra around it.
up
yuhan planned changes to D4579: address-store-1 AddressStore / AssetAddress + AssetStore.
yuhan updated the diff for D4579: address-store-1 AddressStore / AssetAddress + AssetStore.
rebase /0
Yesterday
Yesterday
remove selector from tutorial
yuhan updated the summary of D4579: address-store-1 AddressStore / AssetAddress + AssetStore.
rexledesma committed R1:b522ecc3a69f: Add liveness probe to extra celery workers (authored by rexledesma).
Add liveness probe to extra celery workers
max requested review of D4822: serialization safety.
max added inline comments to D4764: add summary table for asset keys.
dish added a comment to D4809: Clean up partitions UI and improve backfill usability.
Possibly crazy idea: can we use a yaml CodeMirror here? E.g.
max accepted D4763: remove selector from tutorial.
can you open an issue to intro selector in docs
Stream dbt logs and re-log messages
Harbormaster failed remote builds in B19813: Diff 24037 for D4764: add summary table for asset keys!
Harbormaster failed remote builds in B19812: Diff 24036 for D4764: add summary table for asset keys!
prha added inline comments to D4764: add summary table for asset keys.
prha updated the diff for D4764: add summary table for asset keys.
rebase, add more logging to migration script
dish requested review of D4821: RFC: [dagit] Start adding Workspace routes.
prha updated the diff for D4800: RFC: Add table to track migration of secondary indexes on the event_log table.
comments
rexledesma updated the diff for D4718: Configure celeryless deploy on helm.
use pipeline env configmap
rexledesma updated the diff for D4718: Configure celeryless deploy on helm.
add docs
rexledesma updated the summary of D4718: Configure celeryless deploy on helm.
dgibson updated the diff for D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.
up
This looks great! Good catch 👍
alangenfeld added a comment to D4814: rm DagsterKubernetesPodOperator and test infra around it.
As per discussion in the platform lane chat.
dgibson requested review of D4814: rm DagsterKubernetesPodOperator and test infra around it.
test failures are transient/unrelated
max requested review of D4816: Stream dbt logs and re-log messages.
rexledesma requested review of D4815: Configure syntax for python diffs in gitattributes.
dgibson requested review of D4813: Maintain backcompat in date_partition_range.
dish requested changes to D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.
Direction looks great to me. Some nits inline, mostly stylistic/legibility things.
dgibson updated the diff for D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.
up
dgibson committed R1:febffd667ebb: Use execute_step_with_structured_logs in DagsterDockerOperator (authored by dgibson).
Use execute_step_with_structured_logs in DagsterDockerOperator
alangenfeld added inline comments to D4800: RFC: Add table to track migration of secondary indexes on the event_log table.
Harbormaster failed remote builds in B19785: Diff 24006 for D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids!
schrockn requested changes to D4719: Revised the Parametrizing Solid with Config in Docs Basics of Solids.
This is great! Some minor feedback. Big improvement
sashank updated the diff for D4807: (config-scaffold 1/n) Fix config errors visualization in Dagit.
up
schrockn requested changes to D4781: RFC: allow optional configuration of parent pipeline solids for subsetted pipeline.
this is good but it needs tests
prha added inline comments to D4800: RFC: Add table to track migration of secondary indexes on the event_log table.
schrockn added a comment to D4811: RFC: decorator-based mode definition.
Using SolidDefinition is desirable for framework authors. This is a layered system