Page MenuHomeElementl
Feed Advanced Search

Mar 18 2021

sashank accepted D7019: [docs] Instance Config YAML refactor.
Mar 18 2021, 4:48 PM
sashank accepted D7020: [docs] content - clean up de-prioritized content: run launcher & executor.
Mar 18 2021, 4:48 PM
sashank closed D7035: [docs-infra] Switch css compilation back to purge.
Mar 18 2021, 4:37 PM
sashank committed R1:20dfe28fb6a5: [docs-infra] Switch css compilation back to purge (authored by sashank).
[docs-infra] Switch css compilation back to purge
Mar 18 2021, 4:37 PM
sashank published D7035: [docs-infra] Switch css compilation back to purge for review.
Mar 18 2021, 4:17 PM
sashank closed D7026: [docs] Search.
Mar 18 2021, 4:03 PM
sashank committed R1:8ae042321b0e: [docs] Search (authored by sashank).
[docs] Search
Mar 18 2021, 4:03 PM
sashank requested review of D7026: [docs] Search.
Mar 18 2021, 8:29 AM
sashank accepted D7014: [docs] dagit screenshots.
Mar 18 2021, 4:57 AM
sashank closed D7016: [docs] Add Tailwind JIT compilation + Sidebar for API docs + Style API docs.
Mar 18 2021, 4:57 AM
sashank committed R1:f53b563df546: [docs] Add Tailwind JIT compilation + Sidebar for API docs + Style API docs (authored by sashank).
[docs] Add Tailwind JIT compilation + Sidebar for API docs + Style API docs
Mar 18 2021, 4:57 AM
sashank closed D7015: [docs] GraphQL APi docs.
Mar 18 2021, 1:51 AM
sashank committed R1:6c633d9e2d4f: [docs] GraphQL APi docs (authored by sashank).
[docs] GraphQL APi docs
Mar 18 2021, 1:51 AM
sashank added a comment to D7015: [docs] GraphQL APi docs.

yeah these should eventually go under test

Mar 18 2021, 1:50 AM
sashank closed D6433: Fix workspace property on WorkspaceProcessContext.
Mar 18 2021, 1:50 AM
sashank committed R1:3f42c5647db5: Fix workspace property on WorkspaceProcessContext (authored by sashank).
Fix workspace property on WorkspaceProcessContext
Mar 18 2021, 1:50 AM
sashank updated the diff for D7016: [docs] Add Tailwind JIT compilation + Sidebar for API docs + Style API docs.

up

Mar 18 2021, 1:49 AM
sashank closed D6919: [docs] Center images by default.
Mar 18 2021, 1:47 AM
sashank committed R1:57af7daddd49: [docs] Center images by default (authored by sashank).
[docs] Center images by default
Mar 18 2021, 1:47 AM
sashank updated the diff for D6433: Fix workspace property on WorkspaceProcessContext.

up

Mar 18 2021, 1:19 AM
sashank abandoned D4923: (dagit-watch 1/n) Introduce watchdog to watch and reload handles.
Mar 18 2021, 1:18 AM
sashank abandoned D6361: Test flakiness of gc tests.
Mar 18 2021, 1:17 AM
sashank abandoned D5304: Fix undo functionatlity in Dagit playground.
Mar 18 2021, 1:17 AM
sashank updated the diff for D6919: [docs] Center images by default.

up

Mar 18 2021, 1:17 AM
sashank added a comment to D6919: [docs] Center images by default.

Failing test is not related

Mar 18 2021, 1:17 AM
sashank requested review of D6919: [docs] Center images by default.
Mar 18 2021, 1:16 AM
sashank abandoned D2293: [RFC] Datadog logger for events.
Mar 18 2021, 1:16 AM
sashank abandoned D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.
Mar 18 2021, 1:15 AM
sashank updated the diff for D7015: [docs] GraphQL APi docs.

up

Mar 18 2021, 1:13 AM
sashank updated the diff for D7015: [docs] GraphQL APi docs.

up

Mar 18 2021, 1:12 AM
sashank requested review of D7015: [docs] GraphQL APi docs.
Mar 18 2021, 1:10 AM
sashank added a comment to D7014: [docs] dagit screenshots.

would be worth showing the backfill uis here too

Mar 18 2021, 1:09 AM
sashank updated the diff for D7016: [docs] Add Tailwind JIT compilation + Sidebar for API docs + Style API docs.

up

Mar 18 2021, 1:06 AM
sashank published D7016: [docs] Add Tailwind JIT compilation + Sidebar for API docs + Style API docs for review.
Mar 18 2021, 1:04 AM

Mar 17 2021

sashank accepted D7008: sensor overview docs.
Mar 17 2021, 10:32 PM
sashank added inline comments to D6991: Updated asset docs.
Mar 17 2021, 9:55 PM
sashank closed D7005: [docs] Clean up several sphinx errors.
Mar 17 2021, 9:53 PM
sashank committed R1:e376490b1125: [docs] Clean up several sphinx errors (authored by sashank).
[docs] Clean up several sphinx errors
Mar 17 2021, 9:52 PM
sashank requested review of D7005: [docs] Clean up several sphinx errors.
Mar 17 2021, 7:17 PM
sashank closed D6961: [RFC] Remove typehints from docstring + update Sphinx typehints settings.
Mar 17 2021, 5:20 PM
sashank committed R1:f99ce3dc3e8d: [RFC] Remove typehints from docstring + update Sphinx typehints settings (authored by sashank).
[RFC] Remove typehints from docstring + update Sphinx typehints settings
Mar 17 2021, 5:20 PM
sashank updated the diff for D6961: [RFC] Remove typehints from docstring + update Sphinx typehints settings.

up

Mar 17 2021, 5:00 PM

Mar 16 2021

sashank updated the diff for D6961: [RFC] Remove typehints from docstring + update Sphinx typehints settings.

up

Mar 16 2021, 7:27 PM
sashank updated the diff for D6961: [RFC] Remove typehints from docstring + update Sphinx typehints settings.

up

Mar 16 2021, 6:52 PM
sashank updated the test plan for D6961: [RFC] Remove typehints from docstring + update Sphinx typehints settings.
Mar 16 2021, 6:36 PM
sashank published D6961: [RFC] Remove typehints from docstring + update Sphinx typehints settings for review.
Mar 16 2021, 6:35 PM
sashank accepted D6944: update description for Setup for the Tutorial page.
Mar 16 2021, 4:54 PM
sashank accepted D6962: Schedule docs.

+1 for the literal include code snippets. sorry for the extra work here. the previous schedule code snippets weren't under test so we converted all untested literal include code snippets into inline snippets to make it explicit. happy to do that for you if needed.

Mar 16 2021, 3:57 AM
sashank closed D6957: [docs-infra] Only add documentation label to docs issues.
Mar 16 2021, 1:36 AM
sashank committed R1:af13bbf7a6c7: [docs-infra] Only add documentation label to docs issues (authored by sashank).
[docs-infra] Only add documentation label to docs issues
Mar 16 2021, 1:36 AM
sashank requested review of D6957: [docs-infra] Only add documentation label to docs issues.
Mar 16 2021, 12:17 AM

Mar 15 2021

sashank closed D6955: [docs] Add dry-run flag to bot.
Mar 15 2021, 11:34 PM
sashank committed R1:999fa923e19b: [docs] Add dry-run flag to bot (authored by sashank).
[docs] Add dry-run flag to bot
Mar 15 2021, 11:34 PM
sashank published D6955: [docs] Add dry-run flag to bot for review.
Mar 15 2021, 10:55 PM
sashank closed D6950: [docs-infra] Update Github client ID.
Mar 15 2021, 9:25 PM
sashank committed R1:1722d8aca920: [docs-infra] Update Github client ID (authored by sashank).
[docs-infra] Update Github client ID
Mar 15 2021, 9:25 PM
sashank published D6950: [docs-infra] Update Github client ID for review.
Mar 15 2021, 9:24 PM
sashank closed D6949: [docs-infra] Encrypt private key to avoid lambda filesize limits.
Mar 15 2021, 9:20 PM
sashank committed R1:ba44554c2e8b: [docs-infra] Encrypt private key to avoid lambda filesize limits (authored by sashank).
[docs-infra] Encrypt private key to avoid lambda filesize limits
Mar 15 2021, 9:20 PM
sashank accepted D6945: Warn when using legacy schedulers.
Mar 15 2021, 9:16 PM
sashank updated the diff for D6943: Unpin sqlalchemy: Update select label to not be `count`.

Pin sqlalchemy in dagster-airflow

Mar 15 2021, 7:55 PM
sashank added a comment to D6943: Unpin sqlalchemy: Update select label to not be `count`.

It looks like flask_admin in airflow has a broken import caused by sqlalchemy==1.4.0 as well, but the problem here is that db.engine.Result is only available in 1.4.0, and ResultProxy isn't. So if we pin to <1.4.0 in only dagster-airflow, then dagster-postgres won't work

Mar 15 2021, 7:35 PM
sashank added a comment to D6943: Unpin sqlalchemy: Update select label to not be `count`.

@sidkmenon could I get another look at the ResultProxy change?

Mar 15 2021, 7:11 PM
sashank requested review of D6943: Unpin sqlalchemy: Update select label to not be `count`.
Mar 15 2021, 7:10 PM
sashank added a reviewer for D6943: Unpin sqlalchemy: Update select label to not be `count`: sidkmenon.
Mar 15 2021, 7:10 PM
sashank updated the diff for D6943: Unpin sqlalchemy: Update select label to not be `count`.

up

Mar 15 2021, 7:10 PM
sashank updated the diff for D6943: Unpin sqlalchemy: Update select label to not be `count`.

unpin

Mar 15 2021, 7:01 PM
sashank retitled D6943: Unpin sqlalchemy: Update select label to not be `count` from Unpin sqlalchemy: Update select label to not be to Unpin sqlalchemy: Update select label to not be `count`.
Mar 15 2021, 7:00 PM
sashank closed D6942: [docs] Fix broken deploymnent section links.
Mar 15 2021, 6:49 PM
sashank committed R1:8fad90639503: [docs] Fix broken deploymnent section links (authored by sashank).
[docs] Fix broken deploymnent section links
Mar 15 2021, 6:49 PM
sashank published D6942: [docs] Fix broken deploymnent section links for review.
Mar 15 2021, 6:42 PM
sashank requested changes to D6909: Set entrypoint to empty when launching runs or steps iwth a custom command.

Let me know if my suggestion doesn't makes or doesn't result in the desired behavior you're trying to achieve here. Not 100% familiar with the docker run launcher.

Mar 15 2021, 6:36 PM
sashank added inline comments to D6909: Set entrypoint to empty when launching runs or steps iwth a custom command.
Mar 15 2021, 6:32 PM
sashank added a comment to D6909: Set entrypoint to empty when launching runs or steps iwth a custom command.

In some cases, users want their entrypoint to _not_ be dagster, because they could be using something like conda. This is because dagster isn't an available command in their virtual environment. Here's an example of where a similar problem came up in dagster-k8s: https://github.com/dagster-io/dagster/issues/3081.

Mar 15 2021, 6:23 PM
sashank closed D6930: [docs] Elaborate on configuration in the Dagster Deployment Overview.
Mar 15 2021, 6:14 PM
sashank committed R1:3ef321e14eea: [docs] Elaborate on configuration in the Dagster Deployment Overview (authored by sashank).
[docs] Elaborate on configuration in the Dagster Deployment Overview
Mar 15 2021, 6:14 PM
sashank published D6939: Updated Solid Events page in the docs for review.

Thank you! This is great!

Mar 15 2021, 6:04 PM
sashank accepted D6939: Updated Solid Events page in the docs.
Mar 15 2021, 6:04 PM

Mar 14 2021

sashank accepted D6924: [docs-infra] build test.

Woo! Thanks for fixing this

Mar 14 2021, 4:54 AM

Mar 13 2021

sashank added inline comments to D6927: Fix sensors docs to use context.get_instance().
Mar 13 2021, 2:40 AM
sashank added inline comments to D6927: Fix sensors docs to use context.get_instance().
Mar 13 2021, 2:39 AM
sashank published D6930: [docs] Elaborate on configuration in the Dagster Deployment Overview for review.
Mar 13 2021, 2:25 AM
sashank accepted D6918: Dagster deployment overview docs.
Mar 13 2021, 12:51 AM
sashank closed D6925: [docs] Sensors content.
Mar 13 2021, 12:24 AM
sashank committed R1:ef9e33710d68: [docs] Sensors content (authored by sashank).
[docs] Sensors content
Mar 13 2021, 12:24 AM
sashank closed D6923: [docs] Update docs bot command and add new generic issue command.
Mar 13 2021, 12:19 AM
sashank committed R1:c6c62b3299c2: [docs] Update docs bot command and add new generic issue command (authored by sashank).
[docs] Update docs bot command and add new generic issue command
Mar 13 2021, 12:19 AM
sashank accepted D6927: Fix sensors docs to use context.get_instance().

Thanks for the fix and tests!

Mar 13 2021, 12:16 AM

Mar 12 2021

sashank added inline comments to D6923: [docs] Update docs bot command and add new generic issue command.
Mar 12 2021, 8:03 PM
sashank published D6923: [docs] Update docs bot command and add new generic issue command for review.
Mar 12 2021, 7:54 PM
sashank accepted D6907: [docs-infra] enable broken link tests on bk.

Amazing work

Mar 12 2021, 8:26 AM
sashank accepted D6913: [docs] api docs index page.

Yay

Mar 12 2021, 7:31 AM
sashank accepted D6896: [easy] Add username to pg isready check.
Mar 12 2021, 6:54 AM
sashank committed R1:752c0bdc33bd: [docs] Fix typescript error in docs issue bot (authored by sashank).
[docs] Fix typescript error in docs issue bot
Mar 12 2021, 6:52 AM
sashank closed D6906: [docs] Add backend for docs issue bot.
Mar 12 2021, 6:47 AM
sashank committed R1:1f559f321651: [docs] Add backend for docs issue bot (authored by sashank).
[docs] Add backend for docs issue bot
Mar 12 2021, 6:47 AM
sashank added a comment to D6906: [docs] Add backend for docs issue bot.

so sick, can you put a quick readme of how to get this up and running locally?

Mar 12 2021, 12:23 AM
sashank added inline comments to D6906: [docs] Add backend for docs issue bot.
Mar 12 2021, 12:19 AM
sashank accepted D6905: [docs-infra] skip calling window.gtag when GA isn't included.
Mar 12 2021, 12:18 AM
sashank updated the diff for D6906: [docs] Add backend for docs issue bot.

feedback

Mar 12 2021, 12:18 AM