Page MenuHomePhabricator
Feed Advanced Search

Dec 7 2020

sashank abandoned D4949: Allow users to override k8s job container command.
Dec 7 2020, 6:12 PM
sashank published D5458: Mark complex cycle grpc server watch tests as skipped for review.
Dec 7 2020, 6:11 PM
sashank published D5456: Improve error messages for celery-k8s launcher for review.
Dec 7 2020, 6:04 PM
sashank requested review of D5454: Supprort cursor limit args on Pipeline.runs.
Dec 7 2020, 5:22 PM
sashank planned changes to D5304: Fix undo functionatlity in Dagit playground.

Sounds good, will fork the package instead

Dec 7 2020, 3:56 PM
sashank accepted D5410: [dagit] Avoid flashing progress bar in Loading.

Makes sense 👍

Dec 7 2020, 3:55 PM
sashank accepted D5411: [dagit] Repair breadcrumb links in TopNav.
Dec 7 2020, 3:53 PM
sashank added inline comments to D5440: [dagit] Clean up tables.
Dec 7 2020, 3:52 PM
sashank accepted D5440: [dagit] Clean up tables.
Dec 7 2020, 3:47 PM

Dec 4 2020

sashank accepted D5426: [easy] Add deploy_docker example scaffolding.
Dec 4 2020, 6:56 PM

Dec 3 2020

sashank planned changes to D4949: Allow users to override k8s job container command.
Dec 3 2020, 5:32 PM
sashank updated the diff for D4949: Allow users to override k8s job container command.

up

Dec 3 2020, 4:30 PM

Dec 2 2020

sashank accepted D5401: [dagit] Don't show shortcut hints on screen capture command.

YES! This is actually huge

Dec 2 2020, 11:34 PM
sashank accepted D5396: Upgrade storybook.
Dec 2 2020, 11:34 PM
sashank empowered yichendai as an administrator.
Dec 2 2020, 11:32 PM
sashank accepted D5388: [dagit] Fix phantom overlay in playground.
Dec 2 2020, 8:04 PM
sashank accepted D5359: [dagit] Fix clicks on loading overlay.
Dec 2 2020, 7:41 AM
sashank accepted D5362: Fix scaffold print output folder names.
Dec 2 2020, 7:40 AM

Dec 1 2020

sashank abandoned D4354: Git blame ignore revs.
Dec 1 2020, 5:48 PM
sashank abandoned D4545: Add full test suite.
Dec 1 2020, 5:48 PM
sashank abandoned D3981: [2] run-scoped file manager resources.
Dec 1 2020, 5:47 PM
sashank resigned from D4161: set up eslint for docs.

I think we can abandon this and revisit when we have the new site

Dec 1 2020, 5:46 PM
sashank accepted D5343: [dagit] Replace ButtonLink uses.

Nice! Thanks for this :)

Dec 1 2020, 5:17 PM
sashank closed D5331: [dagit] Increase Dialog size for repository location errors.
Dec 1 2020, 5:09 PM
sashank committed R1:abc6463634f8: [dagit] Increase Dialog size for repository location errors (authored by sashank).
[dagit] Increase Dialog size for repository location errors
Dec 1 2020, 5:09 PM
sashank accepted D5345: Add missing type parameter annotations to useMutation/useQuery.
Dec 1 2020, 5:08 PM
sashank planned changes to D4949: Allow users to override k8s job container command.
Dec 1 2020, 4:40 AM
sashank published D5331: [dagit] Increase Dialog size for repository location errors for review.
Dec 1 2020, 12:47 AM

Nov 30 2020

sashank closed D5306: [dagit] Remove refetch from WorkspaceContext.
Nov 30 2020, 6:51 PM
sashank committed R1:7f9892212f91: [dagit] Remove refetch from WorkspaceContext (authored by sashank).
[dagit] Remove refetch from WorkspaceContext
Nov 30 2020, 6:51 PM
sashank updated the diff for D4949: Allow users to override k8s job container command.

up

Nov 30 2020, 6:10 PM
sashank updated the test plan for D4949: Allow users to override k8s job container command.
Nov 30 2020, 6:10 PM
sashank updated the diff for D4949: Allow users to override k8s job container command.

reset last updated

Nov 30 2020, 5:42 PM
sashank updated the diff for D4949: Allow users to override k8s job container command.

up

Nov 30 2020, 5:22 PM
sashank updated the diff for D4949: Allow users to override k8s job container command.

up

Nov 30 2020, 5:01 PM
sashank updated the diff for D4949: Allow users to override k8s job container command.

up

Nov 30 2020, 4:57 PM
sashank updated the diff for D4949: Allow users to override k8s job container command.

up

Nov 30 2020, 4:57 PM
sashank updated the diff for D4949: Allow users to override k8s job container command.

up

Nov 30 2020, 4:46 PM

Nov 25 2020

sashank requested review of D5306: [dagit] Remove refetch from WorkspaceContext.
Nov 25 2020, 11:18 PM
sashank closed D5299: Fix apollo cache reset race condition.
Nov 25 2020, 10:59 PM
sashank committed R1:1d91ee8bccdb: Fix apollo cache reset race condition (authored by sashank).
Fix apollo cache reset race condition
Nov 25 2020, 10:59 PM
sashank updated the diff for D5299: Fix apollo cache reset race condition.

Add comment

Nov 25 2020, 10:59 PM
sashank added inline comments to D5299: Fix apollo cache reset race condition.
Nov 25 2020, 10:57 PM
sashank added a comment to D5304: Fix undo functionatlity in Dagit playground.

Double check that switching tabs in the editor doesn't create a continuous undo history

Nov 25 2020, 10:00 PM
sashank updated the diff for D5304: Fix undo functionatlity in Dagit playground.

up

Nov 25 2020, 9:46 PM
sashank published D5304: Fix undo functionatlity in Dagit playground for review.
Nov 25 2020, 9:35 PM
sashank accepted D5302: del stale todo.
Nov 25 2020, 9:31 PM
sashank closed D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.
Nov 25 2020, 9:09 PM
sashank committed R1:1d3359632e5f: (config-scaffold 2/n) Add scaffold config button to Dagit playground (authored by sashank).
(config-scaffold 2/n) Add scaffold config button to Dagit playground
Nov 25 2020, 9:09 PM
sashank updated the diff for D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.

up

Nov 25 2020, 9:01 PM
sashank updated the diff for D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.

up

Nov 25 2020, 8:46 PM
sashank updated the diff for D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.

up

Nov 25 2020, 8:34 PM
sashank added inline comments to D5299: Fix apollo cache reset race condition.
Nov 25 2020, 7:21 PM
sashank requested review of D5299: Fix apollo cache reset race condition.
Nov 25 2020, 6:28 PM
sashank updated the diff for D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.

up

Nov 25 2020, 6:25 PM
sashank closed D5189: (dagit-reload-4) Dagit location reloading UI.
Nov 25 2020, 3:51 PM
sashank committed R1:1b945e6c989b: (dagit-reload-4) Dagit location reloading UI (authored by sashank).
(dagit-reload-4) Dagit location reloading UI
Nov 25 2020, 3:51 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Nov 25 2020, 12:00 AM

Nov 24 2020

sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Nov 24 2020, 11:39 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Nov 24 2020, 10:20 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Nov 24 2020, 9:43 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Nov 24 2020, 9:39 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Nov 24 2020, 8:10 PM
sashank closed D5266: Deflake grpc server watch tests.
Nov 24 2020, 8:08 PM
sashank committed R1:b2f5185010ed: Deflake grpc server watch tests (authored by sashank).
Deflake grpc server watch tests
Nov 24 2020, 8:08 PM
sashank updated the diff for D5266: Deflake grpc server watch tests.

up

Nov 24 2020, 7:51 PM
sashank updated the diff for D5266: Deflake grpc server watch tests.

up

Nov 24 2020, 7:23 PM
sashank updated the diff for D5266: Deflake grpc server watch tests.

up

Nov 24 2020, 7:19 PM
sashank updated the diff for D5266: Deflake grpc server watch tests.

up

Nov 24 2020, 6:40 PM
sashank updated the diff for D5266: Deflake grpc server watch tests.

up

Nov 24 2020, 6:38 PM
sashank added a reviewer for D5266: Deflake grpc server watch tests: alangenfeld.
Nov 24 2020, 6:38 PM
sashank requested review of D5266: Deflake grpc server watch tests.
Nov 24 2020, 6:33 PM

Nov 23 2020

sashank accepted D5250: Add FutureTicks connection to ScheduleDefinition.
Nov 23 2020, 11:36 PM
sashank added a comment to D5250: Add FutureTicks connection to ScheduleDefinition.

This is very cool! Excited to see how this shows up in the UI

Nov 23 2020, 11:35 PM
sashank accepted D5248: Pull out logic for determining next ticks from scheduler to ExternalSchedule.
Nov 23 2020, 11:28 PM
sashank accepted D5255: [dagit] Repair endless scrolling Gaant.

With this change, the Gaant will no longer be affected by filtering the logs. Is this the correct behavior?

Nov 23 2020, 11:23 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Nov 23 2020, 5:48 PM
sashank accepted D5227: Try to resolve graphql schema loading race conditions in Jest.
Nov 23 2020, 5:42 PM
sashank closed D5231: Remove PageInfo gqp types.
Nov 23 2020, 5:41 PM
sashank committed R1:7981c266acfd: Remove PageInfo gqp types (authored by sashank).
Remove PageInfo gqp types
Nov 23 2020, 5:41 PM

Nov 21 2020

sashank added a comment to D5227: Try to resolve graphql schema loading race conditions in Jest.

How is it any different to move the function call outside of the function?

Nov 21 2020, 5:00 PM

Nov 20 2020

sashank published D5231: Remove PageInfo gqp types for review.
Nov 20 2020, 11:16 PM
sashank closed D5230: Mark complex cycle grpc test as skipped due to flakiness.
Nov 20 2020, 11:03 PM
sashank committed R1:cd1fc735b376: Mark complex cycle grpc test as skipped due to flakiness (authored by sashank).
Mark complex cycle grpc test as skipped due to flakiness
Nov 20 2020, 11:03 PM
sashank published D5230: Mark complex cycle grpc test as skipped due to flakiness for review.
Nov 20 2020, 10:24 PM
sashank retitled D5189: (dagit-reload-4) Dagit location reloading UI from [WIP] (dagit-reload-4) Dagit location reloading UI to (dagit-reload-4) Dagit location reloading UI.
Nov 20 2020, 7:04 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Nov 20 2020, 7:02 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Nov 20 2020, 6:22 PM
sashank updated the summary of D5189: (dagit-reload-4) Dagit location reloading UI.
Nov 20 2020, 6:21 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Nov 20 2020, 6:20 PM
sashank retitled D5189: (dagit-reload-4) Dagit location reloading UI from [WIP] (dagit-reload-4) Dagit location reloading UI to (dagit-reload-4) Dagit location reloading UI.
Nov 20 2020, 6:20 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Nov 20 2020, 6:19 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Nov 20 2020, 5:57 PM
sashank added a comment to D5214: add general_tests to windows tests.

It looks like there's also daemon_tests and utils_tests that we want to run

Nov 20 2020, 5:47 PM
sashank accepted D5214: add general_tests to windows tests.

Nice catch 👍

Nov 20 2020, 5:46 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

up

Nov 20 2020, 5:45 PM
sashank updated the diff for D5189: (dagit-reload-4) Dagit location reloading UI.

network only query

Nov 20 2020, 4:57 PM
sashank closed D5107: (dagit-reload-3) Add subscriber to GraphQL context.
Nov 20 2020, 3:59 PM
sashank committed R1:0a60a53ee4f5: (dagit-reload-3) Add subscriber to GraphQL context (authored by sashank).
(dagit-reload-3) Add subscriber to GraphQL context
Nov 20 2020, 3:59 PM
sashank updated the diff for D5107: (dagit-reload-3) Add subscriber to GraphQL context.

Update error message. Will addresss rename later in the stack

Nov 20 2020, 3:41 PM