Remove add subscriber from event handler
Nov 20 2020
Move down re-attaching event subscriber
revert flake test
Nov 19 2020
We would also need to surface this configuration in the helm chart
that's a really good idea, I'll try that. you should share that trick with the team :)
@prha updated to use count
- use count instead of iteration
- fix test case and set default to 1
requesting review again @alangenfeld
add step keys filter, update test to have one other retry step
Nov 18 2020
@dgibson thanks for the great suggestions, updated the diff accordingly.
- updated grpc server watch thread comment
- use wait instead of time.sleep
- remove UpdateServerId call
Nov 16 2020
Ended up not being necessary
Nov 13 2020
This looks great! Awesome to see that reconcile UI go away :)
Will defer to @yuhan here
That old background was quite ugly
clean up toys + remove inner function
Nov 12 2020
why separate instead of Ping including it?
Nov 11 2020
Nov 10 2020
Sorry about the wrong suggestion above, we should link to examples/fan_in_pipeline, not docs_snippets or dagster_test
Nov 6 2020
Nov 5 2020
Nov 3 2020
+1 on not linking to code in dagster-test. We should instead link to code in docs_snippets.
Nov 2 2020
Haha this is great. I'm glad we had good timing to realize this.
Oct 30 2020
This is great!