Page MenuHomeElementl
Feed Advanced Search

Nov 20 2020

sashank updated the diff for D5107: (dagit-reload-3) Add subscriber to GraphQL context.

Remove add subscriber from event handler

Nov 20 2020, 3:38 PM
sashank updated the diff for D5107: (dagit-reload-3) Add subscriber to GraphQL context.

Move down re-attaching event subscriber

Nov 20 2020, 3:33 PM
sashank closed D5212: Fix server id test flakiness.
Nov 20 2020, 12:05 AM
sashank committed R1:8b8740d472af: Fix server id test flakiness (authored by sashank).
Fix server id test flakiness
Nov 20 2020, 12:05 AM
sashank updated the diff for D5212: Fix server id test flakiness.

revert flake test

Nov 20 2020, 12:04 AM

Nov 19 2020

sashank added a comment to D4949: Allow users to override k8s job container command.

We would also need to surface this configuration in the helm chart

Nov 19 2020, 11:49 PM
sashank updated the diff for D5212: Fix server id test flakiness.

flake test

Nov 19 2020, 11:44 PM
sashank added a comment to D5212: Fix server id test flakiness.

that's a really good idea, I'll try that. you should share that trick with the team :)

Nov 19 2020, 11:38 PM
sashank published D5212: Fix server id test flakiness for review.
Nov 19 2020, 11:33 PM
sashank closed D5198: fix step restart atempts stats calculation.
Nov 19 2020, 9:48 PM
sashank committed R1:c58339e964e7: fix step restart atempts stats calculation (authored by alangenfeld).
fix step restart atempts stats calculation
Nov 19 2020, 9:48 PM
sashank updated the diff for D5198: fix step restart atempts stats calculation.

add comment

Nov 19 2020, 9:46 PM
sashank accepted D4785: Allow PipelineRunFilters on multiple statuses.

Nice!

Nov 19 2020, 9:31 PM
sashank requested review of D5198: fix step restart atempts stats calculation.

@prha updated to use count

Nov 19 2020, 7:57 PM
sashank updated the diff for D5198: fix step restart atempts stats calculation.
  • use count instead of iteration
Nov 19 2020, 7:55 PM
sashank added inline comments to D5198: fix step restart atempts stats calculation.
Nov 19 2020, 7:50 PM
sashank updated the diff for D5198: fix step restart atempts stats calculation.
  • fix test case and set default to 1
Nov 19 2020, 7:41 PM
sashank added inline comments to D5198: fix step restart atempts stats calculation.
Nov 19 2020, 7:25 PM
sashank added inline comments to D5198: fix step restart atempts stats calculation.
Nov 19 2020, 7:24 PM
sashank requested review of D5198: fix step restart atempts stats calculation.

requesting review again @alangenfeld

Nov 19 2020, 7:22 PM
sashank updated the diff for D5198: fix step restart atempts stats calculation.

up

Nov 19 2020, 7:22 PM
sashank updated the diff for D5198: fix step restart atempts stats calculation.

add step keys filter, update test to have one other retry step

Nov 19 2020, 7:20 PM
sashank planned changes to D5189: (dagit-reload-4) Dagit location reloading UI.
Nov 19 2020, 6:54 PM
sashank updated the diff for D4949: Allow users to override k8s job container command.

up

Nov 19 2020, 6:49 PM
sashank commandeered D5198: fix step restart atempts stats calculation.
Nov 19 2020, 5:36 PM
sashank retitled D5189: (dagit-reload-4) Dagit location reloading UI from [WIP] (dagit-reload-3) Dagit location reloading UI to [WIP] (dagit-reload-4) Dagit location reloading UI.
Nov 19 2020, 5:32 PM
sashank updated the summary of D5189: (dagit-reload-4) Dagit location reloading UI.
Nov 19 2020, 5:21 PM
sashank requested review of D5189: (dagit-reload-4) Dagit location reloading UI.
Nov 19 2020, 5:19 PM
sashank updated the diff for D4949: Allow users to override k8s job container command.

up

Nov 19 2020, 5:13 PM
sashank added a reviewer for D4949: Allow users to override k8s job container command: rexledesma.
Nov 19 2020, 4:56 PM
sashank added a reviewer for D4949: Allow users to override k8s job container command: johann.
Nov 19 2020, 4:56 PM
sashank published D4949: Allow users to override k8s job container command for review.
Nov 19 2020, 4:56 PM
sashank closed D5106: (dagit-reload-2/n) gRPC server watch thread.
Nov 19 2020, 4:41 PM
sashank committed R1:fd6338d76f68: (dagit-reload-2/n) gRPC server watch thread (authored by sashank).
(dagit-reload-2/n) gRPC server watch thread
Nov 19 2020, 4:41 PM
sashank updated the diff for D5106: (dagit-reload-2/n) gRPC server watch thread.

feedback

Nov 19 2020, 7:18 AM
sashank added inline comments to D5106: (dagit-reload-2/n) gRPC server watch thread.
Nov 19 2020, 7:17 AM

Nov 18 2020

sashank accepted D5194: ButtonLink.

Beautiful, thanks for this :)

Nov 18 2020, 10:39 PM
sashank requested review of D5107: (dagit-reload-3) Add subscriber to GraphQL context.
Nov 18 2020, 9:51 PM
sashank added a comment to D5107: (dagit-reload-3) Add subscriber to GraphQL context.

@dgibson thanks for the great suggestions, updated the diff accordingly.

Nov 18 2020, 9:51 PM
sashank planned changes to D5107: (dagit-reload-3) Add subscriber to GraphQL context.
Nov 18 2020, 9:47 PM
sashank updated the diff for D5107: (dagit-reload-3) Add subscriber to GraphQL context.

up

Nov 18 2020, 9:47 PM
sashank updated the diff for D5107: (dagit-reload-3) Add subscriber to GraphQL context.

up

Nov 18 2020, 9:46 PM
sashank updated the diff for D5107: (dagit-reload-3) Add subscriber to GraphQL context.

up

Nov 18 2020, 9:45 PM
sashank added inline comments to D5107: (dagit-reload-3) Add subscriber to GraphQL context.
Nov 18 2020, 9:36 PM
sashank added inline comments to D5106: (dagit-reload-2/n) gRPC server watch thread.
Nov 18 2020, 9:26 PM
sashank updated the diff for D5106: (dagit-reload-2/n) gRPC server watch thread.
  • updated grpc server watch thread comment
  • use wait instead of time.sleep
  • remove UpdateServerId call
Nov 18 2020, 9:23 PM
sashank planned changes to D5106: (dagit-reload-2/n) gRPC server watch thread.
Nov 18 2020, 2:14 PM
sashank added inline comments to D5106: (dagit-reload-2/n) gRPC server watch thread.
Nov 18 2020, 2:13 PM

Nov 16 2020

sashank abandoned D4850: (1/n k8s-pod-deletion) Add event specific data to STEP_RESTARTED events.

Ended up not being necessary

Nov 16 2020, 11:01 PM
sashank added reviewers for D5107: (dagit-reload-3) Add subscriber to GraphQL context: alangenfeld, dgibson.
Nov 16 2020, 6:03 PM
sashank added reviewers for D5106: (dagit-reload-2/n) gRPC server watch thread: alangenfeld, dgibson.
Nov 16 2020, 6:03 PM
sashank accepted D5156: [docs] fix DagsterInstance refs.
Nov 16 2020, 6:00 PM
sashank requested review of D5107: (dagit-reload-3) Add subscriber to GraphQL context.
Nov 16 2020, 12:46 PM
sashank requested review of D5106: (dagit-reload-2/n) gRPC server watch thread.
Nov 16 2020, 12:10 PM
sashank abandoned D5032: (dagster-reload 1/n) Add server ID stream endpoint to gRPC server + watch for server disconnects.
Nov 16 2020, 8:23 AM
sashank accepted D5153: [easy] Initialize self.client early in ManagedGrpcServerRepositoryLocationHandle so that __del__ won't raise an error if you interrupt a test.
Nov 16 2020, 8:23 AM

Nov 13 2020

sashank accepted D5139: Merge scheduler page and schedules page.
Nov 13 2020, 11:29 PM
sashank added a comment to D5139: Merge scheduler page and schedules page.

This looks great! Awesome to see that reconcile UI go away :)

Nov 13 2020, 11:29 PM
sashank resigned from D4960: [Docs] Corrected the path to fan_in_fan_out.py.

Will defer to @yuhan here

Nov 13 2020, 8:29 PM
sashank closed D5105: (dagit-reload-1/n) Add GetServerId gRPC service method.
Nov 13 2020, 6:33 PM
sashank committed R1:99e5ab3ea580: (dagit-reload-1/n) Add GetServerId gRPC service method (authored by sashank).
(dagit-reload-1/n) Add GetServerId gRPC service method
Nov 13 2020, 6:33 PM
sashank updated the diff for D5105: (dagit-reload-1/n) Add GetServerId gRPC service method.

rebase

Nov 13 2020, 6:11 PM
sashank accepted D5136: [dagit] Upgrade CodeMirror, fix error rendering.

That old background was quite ugly

Nov 13 2020, 6:00 PM
sashank removed reviewers for D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground: schrockn, bengotow, dish, alangenfeld.
Nov 13 2020, 5:59 PM
sashank updated the diff for D5105: (dagit-reload-1/n) Add GetServerId gRPC service method.

clean up toys + remove inner function

Nov 13 2020, 5:56 PM
sashank closed D4855: (5/n k8s-pod-deletion) Prevent step re-executions due to pod deletions.
Nov 13 2020, 5:51 PM
sashank committed R1:3fc913c43b03: (5/n k8s-pod-deletion) Prevent step re-executions due to pod deletions (authored by sashank).
(5/n k8s-pod-deletion) Prevent step re-executions due to pod deletions
Nov 13 2020, 5:51 PM

Nov 12 2020

sashank accepted D5113: Upgrade react-scripts, TypeScript, eslint, styled-components.
Nov 12 2020, 8:57 PM
sashank added a comment to D5105: (dagit-reload-1/n) Add GetServerId gRPC service method.

why separate instead of Ping including it?

Nov 12 2020, 8:11 PM
sashank updated the diff for D4855: (5/n k8s-pod-deletion) Prevent step re-executions due to pod deletions.

Add default

Nov 12 2020, 8:05 PM
sashank updated the diff for D4855: (5/n k8s-pod-deletion) Prevent step re-executions due to pod deletions.

clean

Nov 12 2020, 4:41 PM
sashank updated the diff for D4855: (5/n k8s-pod-deletion) Prevent step re-executions due to pod deletions.

add tests

Nov 12 2020, 4:39 PM
sashank updated the summary of D5105: (dagit-reload-1/n) Add GetServerId gRPC service method.
Nov 12 2020, 4:18 PM
sashank added reviewers for D5105: (dagit-reload-1/n) Add GetServerId gRPC service method: alangenfeld, dgibson, prha, max.
Nov 12 2020, 4:10 PM

Nov 11 2020

sashank abandoned D4731: Add test to make sure search is live.
Nov 11 2020, 11:45 PM
sashank accepted D5100: Only show the systam timezone warning when using the SystemCronScheduler.
Nov 11 2020, 11:45 PM
sashank accepted D5095: reword wipe CLI command so it doesn't mention cron jobs specifically.

Nice catch

Nov 11 2020, 11:43 PM
sashank accepted D5097: Add executionTimezone to ScheduleDefinition in GraphQL.

Macro chefkiss:

Nov 11 2020, 11:42 PM
sashank accepted D5110: [dagit] Eliminate a couple of React warnings.
Nov 11 2020, 11:42 PM
sashank requested review of D5105: (dagit-reload-1/n) Add GetServerId gRPC service method.
Nov 11 2020, 9:35 PM

Nov 10 2020

sashank added a comment to D4960: [Docs] Corrected the path to fan_in_fan_out.py.

Sorry about the wrong suggestion above, we should link to examples/fan_in_pipeline, not docs_snippets or dagster_test

Nov 10 2020, 11:03 PM

Nov 6 2020

sashank accepted D5054: Remove helm cruft.
Nov 6 2020, 11:12 PM
sashank added inline comments to D5032: (dagster-reload 1/n) Add server ID stream endpoint to gRPC server + watch for server disconnects.
Nov 6 2020, 6:35 PM
sashank added inline comments to D5032: (dagster-reload 1/n) Add server ID stream endpoint to gRPC server + watch for server disconnects.
Nov 6 2020, 3:45 PM

Nov 5 2020

sashank accepted D5042: [Release] Add release notes for 0.9.18.
Nov 5 2020, 10:14 PM
sashank published D5042: [Release] Add release notes for 0.9.18 for review.
Nov 5 2020, 10:14 PM
sashank updated the diff for D5032: (dagster-reload 1/n) Add server ID stream endpoint to gRPC server + watch for server disconnects.

up

Nov 5 2020, 3:57 PM
sashank requested review of D5032: (dagster-reload 1/n) Add server ID stream endpoint to gRPC server + watch for server disconnects.
Nov 5 2020, 3:57 PM

Nov 3 2020

sashank requested changes to D4960: [Docs] Corrected the path to fan_in_fan_out.py.
Nov 3 2020, 8:50 PM
sashank added a comment to D4960: [Docs] Corrected the path to fan_in_fan_out.py.

+1 on not linking to code in dagster-test. We should instead link to code in docs_snippets.

Nov 3 2020, 8:50 PM
sashank abandoned D4849: [docker] Improve caching in editable images.
Nov 3 2020, 8:48 PM

Nov 2 2020

sashank added inline comments to D4989: Add json schema for helm rabbitmq.
Nov 2 2020, 10:11 PM
sashank accepted D4989: Add json schema for helm rabbitmq.
Nov 2 2020, 10:10 PM
sashank accepted D4986: Correctly test fall DST transition.

Haha this is great. I'm glad we had good timing to realize this.

Nov 2 2020, 4:35 PM

Oct 30 2020

sashank added inline comments to D4973: Fix test_sync_list_container_grpc running locally outside of BK.
Oct 30 2020, 10:13 PM
sashank accepted D4973: Fix test_sync_list_container_grpc running locally outside of BK.

This is great!

Oct 30 2020, 10:04 PM

Oct 29 2020

sashank updated subscribers of Tamer of YAMLs.
Oct 29 2020, 4:27 PM

Oct 27 2020

sashank closed D4928: Update SqlRunStorage runs query to use inner join.
Oct 27 2020, 11:23 PM
sashank committed R1:a723d86a0b3f: Update SqlRunStorage runs query to use inner join (authored by sashank).
Update SqlRunStorage runs query to use inner join
Oct 27 2020, 11:23 PM
sashank resigned from D4728: [docs] execution overview.

I'll let @max do the pass over the content – everything looks good except running make buildnext and changing the literal include from dagster.core.instance to dagster

Oct 27 2020, 11:02 PM