Remove add subscriber from event handler

Move down re-attaching event subscriber

revert flake test

We would also need to surface this configuration in the helm chart

flake test

that's a really good idea, I'll try that. you should share that trick with the team :)

add comment

Nice!

@prha updated to use count

• use count instead of iteration

• fix test case and set default to 1

requesting review again @alangenfeld

up

add step keys filter, update test to have one other retry step

up

up

feedback

Beautiful, thanks for this :)

@dgibson thanks for the great suggestions, updated the diff accordingly.

up

up

up

• updated grpc server watch thread comment
• use wait instead of time.sleep
• remove UpdateServerId call

Ended up not being necessary

This looks great! Awesome to see that reconcile UI go away :)

Will defer to @yuhan here

rebase

That old background was quite ugly

clean up toys + remove inner function

why separate instead of Ping including it?

Add default

clean

add tests

Nice catch

Sorry about the wrong suggestion above, we should link to examples/fan_in_pipeline, not docs_snippets or dagster_test

up

+1 on not linking to code in dagster-test. We should instead link to code in docs_snippets.

Haha this is great. I'm glad we had good timing to realize this.

This is great!

I'll let @max do the pass over the content – everything looks good except running make buildnext and changing the literal include from dagster.core.instance to dagster