Page MenuHomePhabricator
Feed Advanced Search

Today

sashank requested review of D4860: Add documentation test for all top level dagster exports.
Thu, Oct 22, 1:58 AM
sashank added a comment to D4862: Enforce strict rules for yamllint.

Is there an auto formatter or format command associated with this? It would be good to add a command to the Makefile if there is.

Thu, Oct 22, 1:25 AM

Yesterday

sashank added inline comments to D4855: (5/n k8s-pod-deletion) Prevent step re-executions due to pod deletions.
Wed, Oct 21, 10:35 PM
sashank added a comment to D4850: (1/n k8s-pod-deletion) Add event specific data to STEP_RESTARTED events.

Happy to abandon if not needed

Wed, Oct 21, 7:25 PM
sashank added inline comments to D4855: (5/n k8s-pod-deletion) Prevent step re-executions due to pod deletions.
Wed, Oct 21, 7:25 PM
sashank requested review of D4855: (5/n k8s-pod-deletion) Prevent step re-executions due to pod deletions.
Wed, Oct 21, 6:06 PM
sashank closed D4826: [easy] Clean up instance file.
Wed, Oct 21, 6:00 PM
sashank committed R1:971b96c65c91: [easy] Clean up instance file (authored by sashank).
[easy] Clean up instance file
Wed, Oct 21, 6:00 PM
sashank closed D4807: (config-scaffold 1/n) Fix config errors visualization in Dagit.
Wed, Oct 21, 4:50 PM
sashank committed R1:c41f454f78bf: (config-scaffold 1/n) Fix config errors visualization in Dagit (authored by sashank).
(config-scaffold 1/n) Fix config errors visualization in Dagit
Wed, Oct 21, 4:50 PM
sashank added inline comments to D4797: Support slackclient 2.x when the python version is 3.x.
Wed, Oct 21, 4:49 PM
sashank added a reviewer for D4849: [docker] Improve caching in editable images: nate.
Wed, Oct 21, 4:23 PM
sashank requested review of D4853: (3/n k8s-pod-deletion) Add step keys filter to get_run_step_stats.
Wed, Oct 21, 3:56 PM
sashank requested review of D4851: (2/n k8s-pod-deletion) Add attempt count to RunStepKeyStatsSnapshot.
Wed, Oct 21, 3:54 PM
sashank added reviewers for D4826: [easy] Clean up instance file: alangenfeld, johann.
Wed, Oct 21, 3:23 PM
sashank updated the summary of D4849: [docker] Improve caching in editable images.
Wed, Oct 21, 3:22 PM
sashank requested review of D4850: (1/n k8s-pod-deletion) Add event specific data to STEP_RESTARTED events.
Wed, Oct 21, 3:20 PM
sashank requested review of D4849: [docker] Improve caching in editable images.
Wed, Oct 21, 3:17 PM

Tue, Oct 20

sashank requested review of D4826: [easy] Clean up instance file.
Tue, Oct 20, 10:04 AM

Mon, Oct 19

sashank updated the diff for D4807: (config-scaffold 1/n) Fix config errors visualization in Dagit.

up

Mon, Oct 19, 7:25 PM
sashank added a reviewer for D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground: alangenfeld.
Mon, Oct 19, 5:53 PM
sashank updated the diff for D4807: (config-scaffold 1/n) Fix config errors visualization in Dagit.

clean

Mon, Oct 19, 4:29 AM

Sun, Oct 18

sashank updated the test plan for D4807: (config-scaffold 1/n) Fix config errors visualization in Dagit.
Sun, Oct 18, 5:00 PM
sashank requested changes to D4797: Support slackclient 2.x when the python version is 3.x.

Taking a closer look, the new slack client is a pretty substantial refactor so it's probably not worth doing a seven style import. I think we may just want to bite the bullet and push a major breaking change to this library. If we do so, however, users who are stuck on py2 won't be able to use slack solid hooks etc.

Sun, Oct 18, 4:57 PM
sashank added a comment to D4788: RFC: Add partitions to arbitrary cron-based schedules.

@prha should also take a look at this

Sun, Oct 18, 4:51 PM
sashank accepted D4787: Require that start_date be on a month/day boundary for monthly/daily schedules.

Nice catch - this is a great fix. We should note this in the change log, because it has the potential to break some people's schedules/repositories.

Sun, Oct 18, 4:49 PM
sashank requested review of D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.
Sun, Oct 18, 7:59 AM
sashank requested review of D4807: (config-scaffold 1/n) Fix config errors visualization in Dagit.
Sun, Oct 18, 5:17 AM

Fri, Oct 16

sashank added inline comments to D4803: [dagit] Standardize font-family usage.
Fri, Oct 16, 6:19 PM
sashank accepted D4803: [dagit] Standardize font-family usage.

Beautiful

Fri, Oct 16, 6:17 PM
sashank closed D4802: [k8s] Allow users to set custom labels in Pod metadata.
Fri, Oct 16, 4:30 PM
sashank committed R1:82cc272fbfe0: [k8s] Allow users to set custom labels in Pod metadata (authored by sashank).
[k8s] Allow users to set custom labels in Pod metadata
Fri, Oct 16, 4:30 PM
sashank updated the diff for D4802: [k8s] Allow users to set custom labels in Pod metadata.

up

Fri, Oct 16, 4:05 PM
sashank added a comment to D4797: Support slackclient 2.x when the python version is 3.x.

This is a breaking change, so we should think through this. We could consider doing a seven style import based on py2 vs py3

Fri, Oct 16, 4:02 PM
sashank updated the diff for D4802: [k8s] Allow users to set custom labels in Pod metadata.

up

Fri, Oct 16, 3:32 PM

Thu, Oct 15

sashank accepted D4765: [dagit] Allow copying filter state to URL on Run page.
Thu, Oct 15, 9:52 PM
sashank resigned from D4763: remove selector from tutorial.

deferring to @max

Thu, Oct 15, 9:46 PM
sashank accepted D4749: Reform docs frontpage.

I think this still needs some visual treatment but this is definitely better than before.

Thu, Oct 15, 9:46 PM
sashank added a comment to D4788: RFC: Add partitions to arbitrary cron-based schedules.

This is great. I think the big question here now is whether we should always use cron_partition_range and create_cron_partition_selector_fn instead of date_partition_range and create_default_partition_selector_fn for all the other schedule decorators.

Thu, Oct 15, 5:29 PM

Wed, Oct 14

sashank accepted D4695: Incrementally fetch data for partition set UI.
Wed, Oct 14, 9:51 PM
sashank accepted D4725: Add execution_timezone field to schedules.

chefkiss

Wed, Oct 14, 9:21 PM
sashank added inline comments to D4725: Add execution_timezone field to schedules.
Wed, Oct 14, 9:15 PM

Tue, Oct 13

sashank accepted D4750: Increase gRPC message size limit for ExternalRepository API call.
Tue, Oct 13, 5:47 PM
sashank closed D4759: Update community example.
Tue, Oct 13, 1:59 PM
sashank committed R1:a2141b1bf607: Update community example (authored by sashank).
Update community example
Tue, Oct 13, 1:59 PM
sashank closed D4753: Add community meeting examples.
Tue, Oct 13, 1:33 PM
sashank committed R1:48b15ae2de92: Add community meeting examples (authored by sashank).
Add community meeting examples
Tue, Oct 13, 1:33 PM

Mon, Oct 12

sashank resigned from D4538: Write non-error execution logs to stdout instead of stderr, only surface stderr from child processes in host processes like the scheduler.
Mon, Oct 12, 9:38 PM
sashank requested changes to D4695: Incrementally fetch data for partition set UI.

Back to your queue

Mon, Oct 12, 9:37 PM
sashank accepted D4671: Make scheduler timezone-aware.
Mon, Oct 12, 9:25 PM
sashank accepted D4755: Fixed non matching line numbers across all examples and tutorials. Fixed mismatched code snippets. Changed from line numbers to markers where possible..
Mon, Oct 12, 9:12 PM
sashank added a comment to D4755: Fixed non matching line numbers across all examples and tutorials. Fixed mismatched code snippets. Changed from line numbers to markers where possible..

Thank you so much for doing this! This is a huge deal and will help all of our users

Mon, Oct 12, 9:12 PM
sashank published D4755: Fixed non matching line numbers across all examples and tutorials. Fixed mismatched code snippets. Changed from line numbers to markers where possible. for review.
Mon, Oct 12, 9:11 PM
sashank added inline comments to D4725: Add execution_timezone field to schedules.
Mon, Oct 12, 8:54 PM
sashank requested review of D4753: Add community meeting examples.
Mon, Oct 12, 7:32 PM

Sun, Oct 11

sashank accepted D4750: Increase gRPC message size limit for ExternalRepository API call.
Sun, Oct 11, 11:34 AM
sashank added inline comments to D4709: [dagit] Separate snapshot and current pipeline permalinks.
Sun, Oct 11, 11:19 AM
sashank added a comment to D4709: [dagit] Separate snapshot and current pipeline permalinks.

I feel not obvious/easy to get back to the playground/overview pages if you end up on a snapshot page, especially since we use the same tabs UI for both ["Definition, "Runs"] and ["Overview", "Definition", "Runs", "Partitions"].

Sun, Oct 11, 11:12 AM

Fri, Oct 9

sashank accepted D4747: [dagit] State refactor for execution tabs.

redfordnod

Fri, Oct 9, 11:14 PM
sashank added a comment to D4748: [dagit] Warn on tab removal in Playground.

This prevents accidental deletion of tabs and loss of configuration work.

Fri, Oct 9, 10:07 PM
sashank resigned from D4746: Uses comment markers instead of line numbers..
Fri, Oct 9, 9:59 PM
sashank accepted D4716: Conditional execution docs example.
Fri, Oct 9, 5:34 PM
sashank closed D4744: Improve caching in k8s example dockerfile.
Fri, Oct 9, 5:32 PM
sashank committed R1:b07139b7ce39: Improve caching in k8s example dockerfile (authored by sashank).
Improve caching in k8s example dockerfile
Fri, Oct 9, 5:32 PM
sashank published D4744: Improve caching in k8s example dockerfile for review.
Fri, Oct 9, 4:37 PM
sashank closed D4735: Fix FileNotFoundError in docs release.
Fri, Oct 9, 3:07 PM
sashank committed R1:fc1443b2b433: Fix FileNotFoundError in docs release (authored by sashank).
Fix FileNotFoundError in docs release
Fri, Oct 9, 3:07 PM

Thu, Oct 8

sashank updated subscribers of D4735: Fix FileNotFoundError in docs release.

I think this fixes the error @max ran into last week, but I'm not sure. Either way, doesn't hurt to do a mkdir - p

Thu, Oct 8, 9:33 PM
sashank updated the test plan for D4735: Fix FileNotFoundError in docs release.
Thu, Oct 8, 9:33 PM
sashank requested review of D4735: Fix FileNotFoundError in docs release.
Thu, Oct 8, 9:29 PM
sashank accepted D4728: [docs] execution overview.
Thu, Oct 8, 8:29 PM
sashank planned changes to D4731: Add test to make sure search is live.

works locally but not in BK :/

Thu, Oct 8, 8:27 PM
sashank accepted D4732: 0.9.14 release notes.
Thu, Oct 8, 8:08 PM
sashank published D4732: 0.9.14 release notes for review.
Thu, Oct 8, 8:08 PM
sashank published D4731: Add test to make sure search is live for review.
Thu, Oct 8, 8:00 PM
sashank accepted D4726: [docs] mobile view #3054.
Thu, Oct 8, 7:50 PM
sashank closed D4702: Fix API Docs search.
Thu, Oct 8, 6:46 PM
sashank committed R1:d6fde9e5dcaf: Fix API Docs search (authored by sashank).
Fix API Docs search
Thu, Oct 8, 6:45 PM
sashank updated the diff for D4702: Fix API Docs search.

up

Thu, Oct 8, 6:45 PM
sashank added inline comments to D4708: Improve the error message when loading an empty workspace.yaml.
Thu, Oct 8, 4:24 PM
sashank accepted D4708: Improve the error message when loading an empty workspace.yaml.

I realized this is a user-facing error. This looks good, but I feel like we shouldn't be using check.**_param calls for things like this. The workspace_config argument is irrelevant to the user here. What do you think about doing an isinstance check (either in this function or before calling ensure_workspace_config) and throwing a DagsterInvariantViolationError or similar if we see that the config is not a dict.

Thu, Oct 8, 4:23 PM
sashank accepted D4712: [dagit] print operation times.

They probably doesn't add that much of a performance hit, but I wonder if we should conditionally include the logTimeLink and timeStartLink themselves based on the feature flag.

Thu, Oct 8, 4:18 PM
sashank closed D4720: Unpin slackclient in automation.
Thu, Oct 8, 3:56 PM
sashank committed R1:d70c0332663f: Unpin slackclient in automation (authored by sashank).
Unpin slackclient in automation
Thu, Oct 8, 3:56 PM
sashank added a reviewer for D4702: Fix API Docs search: yuhan.
Thu, Oct 8, 2:28 PM
sashank updated the diff for D4720: Unpin slackclient in automation.

up

Thu, Oct 8, 7:20 AM
sashank added inline comments to D4702: Fix API Docs search.
Thu, Oct 8, 2:29 AM
sashank added a comment to D4712: [dagit] print operation times.

We could add a debug console somewhere that allows toggling this kind of thing, then ask folks to toggle it on while we're live debugging with them.

Thu, Oct 8, 2:26 AM
sashank accepted D4714: [dagit] Don't crash on solid selection that isn't in subset.
Thu, Oct 8, 2:23 AM

Wed, Oct 7

sashank added a comment to D4708: Improve the error message when loading an empty workspace.yaml.

Is this an error that we expect a user to see?

Wed, Oct 7, 9:47 PM
sashank updated the diff for D4702: Fix API Docs search.

rebase

Wed, Oct 7, 9:45 PM
sashank requested review of D4702: Fix API Docs search.
Wed, Oct 7, 9:45 PM
sashank added a comment to D4677: Replaced outdated images in Parametrizing Solids wiht Config.

or is it something @max 's automated screenshot script can help?

Wed, Oct 7, 9:44 PM
sashank accepted D4699: Reorganize ge_example.
Wed, Oct 7, 9:43 PM
sashank added a comment to D4705: [dagit] Clarify snapshot ID in Runs table.

Interesting, so I would be re-executing the *config* with the *current* pipeline, not the config with the *historical* pipeline. Is that correct? Should I be able to execute the historical pipeline instead? (Is that allowed?)

Wed, Oct 7, 8:34 PM
sashank added a comment to D4705: [dagit] Clarify snapshot ID in Runs table.

In the case of a historical config, would that mean that you get a config that might not work for the current pipeline at all but that that wouldn't be clear until you tried to run it?

Wed, Oct 7, 7:59 PM
sashank added a comment to D4705: [dagit] Clarify snapshot ID in Runs table.

should "Open in Playground" and "Re-Execute" be available in the context menu for old runs whose snapshots are now historical?

Wed, Oct 7, 7:55 PM
sashank added inline comments to D4705: [dagit] Clarify snapshot ID in Runs table.
Wed, Oct 7, 7:47 PM
sashank added a comment to D4705: [dagit] Clarify snapshot ID in Runs table.

Unlink the pipeline name. This seems to be a point of confusion, where people want to click to the run itself, but instead click the pipeline name and end up on the pipeline instead.

Wed, Oct 7, 7:47 PM
sashank accepted D4693: Allow querying runs by snapshot ID.
Wed, Oct 7, 4:59 PM