Looks great - will let @sandyryza take a look and sign off since he originally wrote this
Sun, Aug 2
Fri, Jul 31
Thu, Jul 30
Wed, Jul 29
Wow so we weren't using this image at all this whole time.
This looks great. Nice work on the comprehensive tests . Same comments re: comments and naming for https://dagster.phacility.com/D4022 apply here. It looks like we can use the abstractproperty pattern we experimented with last time to clean a bunch of this up - let me know what you think.
Tue, Jul 28
This is a great change! Thanks for doing such a thorough job investigating what composite_solids do and ensuring consistent behavior – this feels way better now.
are the docker requirements missing from dev-requirements.txt?
Fri, Jul 24
@aj.nadel want to abandon this?
if i'm using e.g. gcs, do i need to provide the config in GCS_CONFIG_SCHEMA twice?
Thu, Jul 23
Does this require duplicating config at the run level? would be better if it didn't.
Would it make sense to update the static method on PresetDefinition to use these utility methods?
This all looks great to me but I'll let @sandyryza do the final approval.
Wed, Jul 22
Tue, Jul 21
This looks great! We may want to add two new utils in dagster.utils for the reasons mentioned in the inline comment.
Mon, Jul 20
clean up LoadableTargetOrigin
fix symbol name
TODO: Still have to support passing a single attribute
Thu, Jul 16
update tox ini
Love how organized these scripts are now, thank you for doing this.