Page MenuHomePhabricator
Feed Advanced Search

Yesterday

sashank requested review of D6065: [docs] Fix relative path of literalinclude in celery_k8s_job_executor docstring.
Wed, Jan 20, 7:08 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

up

Wed, Jan 20, 5:49 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

up

Wed, Jan 20, 5:37 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

up

Wed, Jan 20, 5:29 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

up

Wed, Jan 20, 5:22 PM

Fri, Jan 15

sashank accepted D6026: [docs] fix broken API reference links.
Fri, Jan 15, 3:17 PM
sashank added a comment to D6026: [docs] fix broken API reference links.

Can we re-release this for 0.10.0? We might be getting a bunch o eyes on IO managers this week with people upgrading and it would be bad if they can't see documentation for their IO manager of choice

Fri, Jan 15, 3:17 PM

Thu, Jan 14

sashank accepted D6009: [docs] dagit overview refresh using demo.elmentl.
Thu, Jan 14, 8:39 PM
sashank accepted D6005: redo yarn.lock for /docs.
Thu, Jan 14, 8:17 PM
sashank abandoned D5518: Conslidate location reloading into single thread.
Thu, Jan 14, 7:51 PM
sashank accepted D6000: Buildkite - remove pipeline.py.

:'(

Thu, Jan 14, 7:51 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

up

Thu, Jan 14, 7:05 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.
Thu, Jan 14, 6:51 PM
sashank accepted D5998: [dagit] Improve PythonError case in RunGroupPanel.
Thu, Jan 14, 6:50 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.
  • bring back postgres deployed test suite
Thu, Jan 14, 6:46 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.
  • rebase and turn on watch thread
Thu, Jan 14, 6:45 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

up

Thu, Jan 14, 6:40 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

up

Thu, Jan 14, 6:24 PM
sashank added a comment to D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

does the watch thread need to get turned back on?

Thu, Jan 14, 6:08 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.
  • Add comments
Thu, Jan 14, 6:08 PM
sashank added inline comments to D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.
Thu, Jan 14, 5:52 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.
  • fix lint
Thu, Jan 14, 5:51 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.
  • Add garbage collection tests
Thu, Jan 14, 5:51 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

up

Thu, Jan 14, 5:11 PM
sashank closed D5653: Add more detail to schedule logs command.
Thu, Jan 14, 4:41 PM
sashank committed R1:d777cb267fac: Add more detail to schedule logs command (authored by sashank).
Add more detail to schedule logs command
Thu, Jan 14, 4:41 PM
sashank updated the diff for D5653: Add more detail to schedule logs command.

up

Thu, Jan 14, 4:16 PM
sashank updated the diff for D5653: Add more detail to schedule logs command.

up

Thu, Jan 14, 4:13 PM
sashank closed D5995: Disable gRPC watch threads for 0.10.0.
Thu, Jan 14, 4:06 PM
sashank committed R1:7131e16629de: Disable gRPC watch threads for 0.10.0 (authored by sashank).
Disable gRPC watch threads for 0.10.0
Thu, Jan 14, 4:06 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.
  • Update subscription server
Thu, Jan 14, 4:05 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

rebase

Thu, Jan 14, 3:25 PM
sashank updated the diff for D5995: Disable gRPC watch threads for 0.10.0.

up

Thu, Jan 14, 3:18 PM
sashank closed D5956: Move not_graphql_context_test_suite to root tox file.
Thu, Jan 14, 2:42 PM
sashank committed R1:9bb8189a1483: Move not_graphql_context_test_suite to root tox file (authored by sashank).
Move not_graphql_context_test_suite to root tox file
Thu, Jan 14, 2:41 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

up

Thu, Jan 14, 2:41 PM
sashank retitled D5953: Split DagterGraphQLContext into ProcessContext and RequestContext from Split DagterGrqphQLContext into ProcessContext and RequestContext to Split DagterGraphQLContext into ProcessContext and RequestContext.
Thu, Jan 14, 1:32 PM
sashank updated the diff for D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.

add tests

Thu, Jan 14, 1:28 PM
sashank updated the summary of D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.
Thu, Jan 14, 12:35 AM
sashank abandoned D5790: [dagit] Create copy of DagsterGraphQLContext for each request.
Thu, Jan 14, 12:32 AM
sashank added a comment to D5790: [dagit] Create copy of DagsterGraphQLContext for each request.

Abandoning in favor of: https://dagster.phacility.com/D5953

Thu, Jan 14, 12:32 AM
sashank planned changes to D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.
Thu, Jan 14, 12:32 AM
sashank requested review of D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.
Thu, Jan 14, 12:29 AM

Wed, Jan 13

sashank updated the diff for D5956: Move not_graphql_context_test_suite to root tox file.

up

Wed, Jan 13, 9:25 PM
sashank updated the diff for D5956: Move not_graphql_context_test_suite to root tox file.

update name of "variants" mark

Wed, Jan 13, 9:24 PM
sashank accepted D5966: [docs[ fix API Docs sidebar nav.
Wed, Jan 13, 9:13 PM
sashank requested review of D5956: Move not_graphql_context_test_suite to root tox file.
Wed, Jan 13, 5:57 PM

Tue, Jan 12

sashank accepted D5921: Throw an error on startup if there are running schedules that don't match the scheduler on the instance.
Tue, Jan 12, 4:35 PM
sashank added a comment to D5921: Throw an error on startup if there are running schedules that don't match the scheduler on the instance.

This looks great!

Tue, Jan 12, 4:34 PM
sashank accepted D5888: [dagit] Don't disappear Daemon statuses when loading.

Looks great!

Tue, Jan 12, 4:20 PM

Thu, Jan 7

sashank removed a reviewer for D5790: [dagit] Create copy of DagsterGraphQLContext for each request: alangenfeld.
Thu, Jan 7, 7:24 PM
sashank updated the diff for D5790: [dagit] Create copy of DagsterGraphQLContext for each request.
  • Use correct context for GraphQL View
Thu, Jan 7, 7:12 PM
sashank added inline comments to D5857: Refresh workspaces overview.
Thu, Jan 7, 7:05 PM

Wed, Jan 6

sashank added a comment to D5790: [dagit] Create copy of DagsterGraphQLContext for each request.

could we also bring back the deployed_grpc test suites as part of this now that they should no longer be crashing? (or in a followup also fine)

Wed, Jan 6, 5:10 PM

Mon, Jan 4

sashank planned changes to D5790: [dagit] Create copy of DagsterGraphQLContext for each request.

Lots of failing tests to fix

Mon, Jan 4, 8:57 PM
sashank updated the diff for D5790: [dagit] Create copy of DagsterGraphQLContext for each request.

rebase

Mon, Jan 4, 8:53 PM
sashank updated the diff for D5790: [dagit] Create copy of DagsterGraphQLContext for each request.
  • Remove unused imports
Mon, Jan 4, 8:47 PM
sashank updated the diff for D5790: [dagit] Create copy of DagsterGraphQLContext for each request.
  • Add with process_context helper
Mon, Jan 4, 8:45 PM
sashank updated the diff for D5790: [dagit] Create copy of DagsterGraphQLContext for each request.

up

Mon, Jan 4, 8:36 PM
sashank updated the diff for D5790: [dagit] Create copy of DagsterGraphQLContext for each request.

up

Mon, Jan 4, 8:35 PM
sashank updated the diff for D5790: [dagit] Create copy of DagsterGraphQLContext for each request.

up

Mon, Jan 4, 8:32 PM
sashank updated the diff for D5790: [dagit] Create copy of DagsterGraphQLContext for each request.

Split context into ProcessContext and RequestContext

Mon, Jan 4, 8:01 PM
sashank added inline comments to D5790: [dagit] Create copy of DagsterGraphQLContext for each request.
Mon, Jan 4, 7:39 PM
sashank added inline comments to D5790: [dagit] Create copy of DagsterGraphQLContext for each request.
Mon, Jan 4, 7:29 PM
sashank added inline comments to D5790: [dagit] Create copy of DagsterGraphQLContext for each request.
Mon, Jan 4, 7:11 PM
sashank updated the diff for D5790: [dagit] Create copy of DagsterGraphQLContext for each request.

up

Mon, Jan 4, 6:50 PM
sashank updated the diff for D5790: [dagit] Create copy of DagsterGraphQLContext for each request.
  • Update location event subscription to use root context
Mon, Jan 4, 6:28 PM
sashank updated the diff for D5790: [dagit] Create copy of DagsterGraphQLContext for each request.
  • Only add location subscribers on root context
Mon, Jan 4, 6:26 PM
sashank requested review of D5790: [dagit] Create copy of DagsterGraphQLContext for each request.
Mon, Jan 4, 5:45 PM

Dec 18 2020

sashank added inline comments to D5653: Add more detail to schedule logs command.
Dec 18 2020, 4:38 PM
sashank requested review of D5653: Add more detail to schedule logs command.
Dec 18 2020, 3:53 PM
sashank added a comment to D5679: Cleans env markers for unsupported Python versions..

Looks great to me, I'll let Nate do the final sign off

Dec 18 2020, 3:05 PM

Dec 17 2020

sashank closed D5639: [dagit] Simplify repository reload logic.
Dec 17 2020, 3:50 AM
sashank committed R1:b37bf6272dcb: [dagit] Simplify repository reload logic (authored by sashank).
[dagit] Simplify repository reload logic
Dec 17 2020, 3:50 AM

Dec 16 2020

sashank requested review of D5639: [dagit] Simplify repository reload logic.
Dec 16 2020, 9:53 AM

Dec 14 2020

sashank requested review of D5597: [dagster-k8s] Have job image from executor config take precedence instead of erroring.
Dec 14 2020, 6:23 PM
sashank closed D5452: Move "dagster" command to "args" for k8s container object.
Dec 14 2020, 5:52 PM
sashank committed R1:edf52f5d8341: Move "dagster" command to "args" for k8s container object (authored by sashank).
Move "dagster" command to "args" for k8s container object
Dec 14 2020, 5:52 PM
sashank closed D5456: Improve error messages for celery-k8s launcher.
Dec 14 2020, 5:42 PM
sashank committed R1:84d5305ac23c: Improve error messages for celery-k8s launcher (authored by sashank).
Improve error messages for celery-k8s launcher
Dec 14 2020, 5:42 PM
sashank added inline comments to D5456: Improve error messages for celery-k8s launcher.
Dec 14 2020, 5:41 PM
sashank added a comment to D5518: Conslidate location reloading into single thread.

will try to implement alex's suggestion today

Dec 14 2020, 5:12 PM
sashank updated the diff for D5456: Improve error messages for celery-k8s launcher.

rebase past errors

Dec 14 2020, 5:11 PM
sashank added a comment to D5522: object managers docs overview.

I'd love to be able to read a live previewing.

Dec 14 2020, 5:10 PM

Dec 10 2020

sashank updated the diff for D5456: Improve error messages for celery-k8s launcher.

up

Dec 10 2020, 4:35 PM
sashank planned changes to D5518: Conslidate location reloading into single thread.
Dec 10 2020, 4:29 PM

Dec 9 2020

sashank closed D5516: Update apollo cache reset to happen on each reload.
Dec 9 2020, 11:25 PM
sashank committed R1:a607564c68a1: Update apollo cache reset to happen on each reload (authored by sashank).
Update apollo cache reset to happen on each reload
Dec 9 2020, 11:25 PM
sashank requested review of D5518: Conslidate location reloading into single thread.
Dec 9 2020, 10:21 PM
sashank published D5516: Update apollo cache reset to happen on each reload for review.
Dec 9 2020, 9:19 PM
sashank published D5507: Add .join() to grpc server handle cleanup for review.

Thanks for this, this looks great

Dec 9 2020, 5:44 PM

Dec 8 2020

sashank accepted D5465: [dagit] Slice runs for pipeline list.

Thanks for coming back to this!

Dec 8 2020, 3:48 PM

Dec 7 2020

sashank closed D5454: Supprort cursor limit args on Pipeline.runs.
Dec 7 2020, 10:07 PM
sashank committed R1:0c96bdee72b8: Supprort cursor limit args on Pipeline.runs (authored by sashank).
Supprort cursor limit args on Pipeline.runs
Dec 7 2020, 10:07 PM
sashank closed D5458: Mark complex cycle grpc server watch tests as skipped.
Dec 7 2020, 8:54 PM
sashank committed R1:eb5b84e89bc6: Mark complex cycle grpc server watch tests as skipped (authored by sashank).
Mark complex cycle grpc server watch tests as skipped
Dec 7 2020, 8:54 PM
sashank planned changes to D5456: Improve error messages for celery-k8s launcher.
Dec 7 2020, 8:53 PM
sashank updated the diff for D5456: Improve error messages for celery-k8s launcher.

up

Dec 7 2020, 6:23 PM
sashank planned changes to D5456: Improve error messages for celery-k8s launcher.

Integration failures

Dec 7 2020, 6:14 PM
sashank published D5452: Move "dagster" command to "args" for k8s container object for review.
Dec 7 2020, 6:12 PM