Page MenuHomePhabricator
Feed Advanced Search

Fri, Jan 17

sashank accepted D1858: [k8s] dont hardcode service account name.

ty!

Fri, Jan 17, 11:15 PM
sashank abandoned D1850: Pass inputs to commpute_fn based on input name.
Fri, Jan 17, 9:59 PM
sashank added a comment to D1850: Pass inputs to commpute_fn based on input name.

Abandoning for https://dagster.phacility.com/D1853

Fri, Jan 17, 9:58 PM
sashank added inline comments to D1853: handle differing arg and input def ordering.
Fri, Jan 17, 7:59 PM
sashank added a reviewer for D1855: Gaant-style execution plan visualization behind feature flag: sashank.
Fri, Jan 17, 7:36 PM
sashank updated the diff for D1844: RFC: Eliminate ConfigMappingContext.

Actually isort

Fri, Jan 17, 12:37 AM
sashank updated the diff for D1844: RFC: Eliminate ConfigMappingContext.

isort

Fri, Jan 17, 12:32 AM

Thu, Jan 16

sashank updated the diff for D1844: RFC: Eliminate ConfigMappingContext.

remove trailing space

Thu, Jan 16, 11:48 PM
sashank updated the diff for D1829: Fix runtime type comparison.

rebase

Thu, Jan 16, 11:08 PM
sashank added a comment to D1832: RFC: Update TypeStoragePluginRegistry to take list of tuples instead of dict.

I think it might be best to leave it for type documentation purposes, even though it's being checked right after again.

Thu, Jan 16, 11:03 PM
sashank updated the diff for D1854: Remove dagster_tests import.

Remove TODO

Thu, Jan 16, 10:08 PM
sashank created D1854: Remove dagster_tests import.
Thu, Jan 16, 10:06 PM
sashank updated the diff for D1851: Change tests using add to subtract.

Remove extra files

Thu, Jan 16, 7:11 PM
sashank updated the diff for D1851: Change tests using add to subtract.

up

Thu, Jan 16, 8:07 AM
sashank updated the diff for D1851: Change tests using add to subtract.

Remove cereal files

Thu, Jan 16, 4:09 AM
sashank updated the diff for D1851: Change tests using add to subtract.

up

Thu, Jan 16, 4:07 AM
sashank created D1851: Change tests using add to subtract.
Thu, Jan 16, 3:52 AM
sashank created D1850: Pass inputs to commpute_fn based on input name.
Thu, Jan 16, 3:37 AM

Wed, Jan 15

sashank updated the diff for D1844: RFC: Eliminate ConfigMappingContext.

Try CHANGES.md fix again

Wed, Jan 15, 11:58 PM
sashank updated the diff for D1844: RFC: Eliminate ConfigMappingContext.

Rebase on CHANGES.md fix

Wed, Jan 15, 11:56 PM
sashank added inline comments to D1844: RFC: Eliminate ConfigMappingContext.
Wed, Jan 15, 11:39 PM
sashank created D1848: Fix changelog formatting.
Wed, Jan 15, 11:36 PM
sashank abandoned D1570: Add retries to SqliteRunStorage add_run.

It seems like the wal changes removs the need for this.

Wed, Jan 15, 10:21 PM

Tue, Jan 14

sashank updated the diff for D1844: RFC: Eliminate ConfigMappingContext.

make black (always forget to do this after a codemod)

Tue, Jan 14, 11:00 PM
sashank updated the diff for D1836: Convert gcp_pipeline to use partitions.

Rebase

Tue, Jan 14, 10:57 PM
sashank updated the diff for D1835: Fix errors with GCP pipeline.

Remove _START constant

Tue, Jan 14, 10:55 PM
sashank added inline comments to D1835: Fix errors with GCP pipeline.
Tue, Jan 14, 10:55 PM
sashank updated the diff for D1844: RFC: Eliminate ConfigMappingContext.

Add breaking change to CHANGES.md

Tue, Jan 14, 10:50 PM
sashank added inline comments to D1844: RFC: Eliminate ConfigMappingContext.
Tue, Jan 14, 10:39 PM
sashank retitled D1844: RFC: Eliminate ConfigMappingContext from Eliminate ConfigMappingContext to RFC: Eliminate ConfigMappingContext.
Tue, Jan 14, 10:33 PM
sashank added reviewers for D1844: RFC: Eliminate ConfigMappingContext: schrockn, alangenfeld.
Tue, Jan 14, 10:33 PM
sashank updated the summary of D1844: RFC: Eliminate ConfigMappingContext.
Tue, Jan 14, 10:33 PM
sashank updated the summary of D1843: Eliminate execution_epoch_time.
Tue, Jan 14, 10:31 PM
sashank updated the summary of D1843: Eliminate execution_epoch_time.
Tue, Jan 14, 10:31 PM
sashank updated the summary of D1844: RFC: Eliminate ConfigMappingContext.
Tue, Jan 14, 10:27 PM
sashank created D1844: RFC: Eliminate ConfigMappingContext.
Tue, Jan 14, 10:26 PM
sashank updated the diff for D1843: Eliminate execution_epoch_time.

up

Tue, Jan 14, 10:05 PM
sashank created D1843: Eliminate execution_epoch_time.
Tue, Jan 14, 10:02 PM
sashank updated the diff for D1836: Convert gcp_pipeline to use partitions.

Up

Tue, Jan 14, 9:57 PM
sashank abandoned D1386: Print scheduler changes on dagit startup.

This seems like it would be too noisy. Abandoning for now.

Tue, Jan 14, 9:36 PM
sashank updated the diff for D1836: Convert gcp_pipeline to use partitions.

Rebase

Tue, Jan 14, 9:05 PM
sashank updated the diff for D1835: Fix errors with GCP pipeline.

Add dagster-gcp install to tox.ini

Tue, Jan 14, 8:57 PM
sashank updated the diff for D1835: Fix errors with GCP pipeline.

Add dagster-gcp to setup.py

Tue, Jan 14, 8:49 PM
sashank created D1836: Convert gcp_pipeline to use partitions.
Tue, Jan 14, 1:31 AM
sashank added a reviewer for D1835: Fix errors with GCP pipeline: nate.
Tue, Jan 14, 1:30 AM
sashank created D1835: Fix errors with GCP pipeline.
Tue, Jan 14, 12:58 AM

Mon, Jan 13

sashank updated the diff for D1829: Fix runtime type comparison.

rebase

Mon, Jan 13, 8:55 PM
sashank updated the diff for D1832: RFC: Update TypeStoragePluginRegistry to take list of tuples instead of dict.

Use a subclass check instead of an instance check

Mon, Jan 13, 8:54 PM
sashank added a reviewer for D1832: RFC: Update TypeStoragePluginRegistry to take list of tuples instead of dict: alangenfeld.
Mon, Jan 13, 7:47 PM
sashank updated the diff for D1829: Fix runtime type comparison.

Rebase on RFC D1832

Mon, Jan 13, 7:39 PM
sashank updated the summary of D1832: RFC: Update TypeStoragePluginRegistry to take list of tuples instead of dict.
Mon, Jan 13, 7:38 PM
sashank retitled D1832: RFC: Update TypeStoragePluginRegistry to take list of tuples instead of dict from Update TypeStoragePluginRegistry to take list of tuples instead of dict to RFC: Update TypeStoragePluginRegistry to take list of tuples instead of dict.
Mon, Jan 13, 7:37 PM
sashank created D1832: RFC: Update TypeStoragePluginRegistry to take list of tuples instead of dict.
Mon, Jan 13, 7:37 PM
sashank added inline comments to D1829: Fix runtime type comparison.
Mon, Jan 13, 7:16 PM
sashank updated the summary of D1829: Fix runtime type comparison.
Mon, Jan 13, 7:16 PM
sashank updated the diff for D1829: Fix runtime type comparison.
  • Update __eq__ on RuntimeType to recursively check class and inner_types
  • Remove __hash__ on RuntimeType
  • Add inner_types to Tuple, Dict, and Set
Mon, Jan 13, 7:15 PM
sashank created D1829: Fix runtime type comparison.
Mon, Jan 13, 6:12 PM

Fri, Jan 10

sashank accepted D1818: add changelog entry for schedule definition argument changes.
Fri, Jan 10, 11:05 PM

Thu, Jan 9

sashank updated the diff for D1799: De-duplicate filter logic in SqlRunStorage.

rebase

Thu, Jan 9, 10:45 PM
sashank added inline comments to D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.
Thu, Jan 9, 10:21 PM
sashank updated the diff for D1797: (2.5/n) Add get_runs_count method to RunStorage.

Rebase and make graphql

Thu, Jan 9, 9:35 PM
sashank updated the diff for D1788: (1/n run-storage) Allow multiple tags in PipelineRunsFilter.

rebase and make graphql

Thu, Jan 9, 8:33 PM
sashank added a comment to D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.

I think we would probably make a new context class - PartitionSelectionContext or something for this as opposed to re-use something ill fitting

Thu, Jan 9, 8:23 PM
sashank updated the diff for D1799: De-duplicate filter logic in SqlRunStorage.

up

Thu, Jan 9, 8:25 AM
sashank updated the diff for D1799: De-duplicate filter logic in SqlRunStorage.

Up

Thu, Jan 9, 12:22 AM
sashank updated the diff for D1792: [RFC] Eliminate get_runs_with... methods on RunStorage and DagsterInstance.

Also eliminate all_runs :)

Thu, Jan 9, 12:17 AM

Wed, Jan 8

sashank updated the diff for D1799: De-duplicate filter logic in SqlRunStorage.

Make sugggested change: query = self._add_filters_to_query(base_query, filters)

Wed, Jan 8, 11:49 PM
sashank added inline comments to D1799: De-duplicate filter logic in SqlRunStorage.
Wed, Jan 8, 11:48 PM
sashank updated the diff for D1799: De-duplicate filter logic in SqlRunStorage.

Rename _build_query to _add_cursor_limit_to_query (thanks @prha)

Wed, Jan 8, 11:46 PM
sashank added a comment to D1799: De-duplicate filter logic in SqlRunStorage.

Open to suggestions on how to simplify further by putting everything into _build_query, but I didn't see a clean way to do so

Wed, Jan 8, 11:21 PM
sashank created D1799: De-duplicate filter logic in SqlRunStorage.
Wed, Jan 8, 11:19 PM
sashank added inline comments to D1790: (2/n run-storage) Add get_runs method to RunStorage.
Wed, Jan 8, 10:05 PM
sashank updated the diff for D1792: [RFC] Eliminate get_runs_with... methods on RunStorage and DagsterInstance.

Rebase to fix postgres tests

Wed, Jan 8, 9:51 PM
sashank updated the diff for D1797: (2.5/n) Add get_runs_count method to RunStorage.

up

Wed, Jan 8, 9:47 PM
sashank updated the diff for D1797: (2.5/n) Add get_runs_count method to RunStorage.

Alias subquery

Wed, Jan 8, 9:34 PM
sashank added inline comments to D1790: (2/n run-storage) Add get_runs method to RunStorage.
Wed, Jan 8, 9:31 PM
sashank updated the summary of D1792: [RFC] Eliminate get_runs_with... methods on RunStorage and DagsterInstance.
Wed, Jan 8, 8:07 PM
sashank updated the diff for D1792: [RFC] Eliminate get_runs_with... methods on RunStorage and DagsterInstance.

Rebase

Wed, Jan 8, 8:05 PM
sashank updated the summary of D1797: (2.5/n) Add get_runs_count method to RunStorage.
Wed, Jan 8, 8:03 PM
sashank updated the diff for D1797: (2.5/n) Add get_runs_count method to RunStorage.

up

Wed, Jan 8, 8:01 PM
sashank updated the diff for D1788: (1/n run-storage) Allow multiple tags in PipelineRunsFilter.

re-run tests

Wed, Jan 8, 7:50 PM
sashank updated the diff for D1790: (2/n run-storage) Add get_runs method to RunStorage.

make black

Wed, Jan 8, 7:44 PM
sashank updated the diff for D1788: (1/n run-storage) Allow multiple tags in PipelineRunsFilter.

Fix lint

Wed, Jan 8, 7:41 PM
sashank updated the diff for D1792: [RFC] Eliminate get_runs_with... methods on RunStorage and DagsterInstance.

Up

Wed, Jan 8, 7:34 PM
sashank updated the diff for D1792: [RFC] Eliminate get_runs_with... methods on RunStorage and DagsterInstance.

Up

Wed, Jan 8, 7:32 PM
sashank updated the diff for D1792: [RFC] Eliminate get_runs_with... methods on RunStorage and DagsterInstance.

Up

Wed, Jan 8, 7:27 PM
sashank updated the diff for D1797: (2.5/n) Add get_runs_count method to RunStorage.

Update postgres tests

Wed, Jan 8, 7:25 PM
sashank updated the diff for D1790: (2/n run-storage) Add get_runs method to RunStorage.

Fix lint warnings

Wed, Jan 8, 7:23 PM
sashank updated the diff for D1797: (2.5/n) Add get_runs_count method to RunStorage.

Rebase

Wed, Jan 8, 7:19 PM
sashank updated the diff for D1790: (2/n run-storage) Add get_runs method to RunStorage.

Make filters optional

Wed, Jan 8, 7:18 PM
sashank updated the diff for D1792: [RFC] Eliminate get_runs_with... methods on RunStorage and DagsterInstance.

Another rebase

Wed, Jan 8, 7:11 PM
sashank updated the diff for D1797: (2.5/n) Add get_runs_count method to RunStorage.

Up

Wed, Jan 8, 7:04 PM
sashank retitled D1790: (2/n run-storage) Add get_runs method to RunStorage from (2/n run-storage) Add get_runs_with_filter method to RunStorage to (2/n run-storage) Add get_runs method to RunStorage.
Wed, Jan 8, 7:01 PM
sashank updated the diff for D1792: [RFC] Eliminate get_runs_with... methods on RunStorage and DagsterInstance.

Rebase

Wed, Jan 8, 7:00 PM
sashank created D1797: (2.5/n) Add get_runs_count method to RunStorage.
Wed, Jan 8, 6:52 PM
sashank planned changes to D1790: (2/n run-storage) Add get_runs method to RunStorage.
Wed, Jan 8, 6:50 PM
sashank updated the diff for D1790: (2/n run-storage) Add get_runs method to RunStorage.

Rename get_runs_with_filter to get_runs

Wed, Jan 8, 6:50 PM
sashank created D1792: [RFC] Eliminate get_runs_with... methods on RunStorage and DagsterInstance.
Wed, Jan 8, 12:44 AM

Tue, Jan 7

sashank planned changes to D1790: (2/n run-storage) Add get_runs method to RunStorage.
Tue, Jan 7, 10:47 PM
sashank updated the diff for D1790: (2/n run-storage) Add get_runs method to RunStorage.

Add tests

Tue, Jan 7, 10:43 PM