Page MenuHomePhabricator
Feed Advanced Search

Today

sashank requested review of D4081: (instance-scheduler-2) [easy] Reorganize schedule fragments.
Tue, Aug 4, 4:54 PM
sashank requested review of D4080: (instance-scheduler-1) Update sidebar navigation for schedules.
Tue, Aug 4, 4:53 PM

Yesterday

sashank accepted D4072: fix {mem,fs}_intermediate_storage docs and export.
Mon, Aug 3, 9:43 PM

Sun, Aug 2

sashank added a reviewer for D4022: refactor configured implementation + more docs: sandyryza.
Sun, Aug 2, 12:34 AM
sashank updated subscribers of D4022: refactor configured implementation + more docs.

Looks great - will let @sandyryza take a look and sign off since he originally wrote this

Sun, Aug 2, 12:34 AM
sashank added reviewers for D4024: implement configurable (pure) solids: sandyryza, max.
Sun, Aug 2, 12:30 AM
sashank updated subscribers of D4024: implement configurable (pure) solids.

This makes sense to me - adding @sandyryza and @max to get more eyes on this

Sun, Aug 2, 12:30 AM

Fri, Jul 31

sashank committed R1:50de7a6937a9: [Docs] 0.8.10 (authored by sashank).
[Docs] 0.8.10
Fri, Jul 31, 12:37 AM
sashank committed R1:dbcb8afef24c: 0.8.10 (authored by sashank).
0.8.10
Fri, Jul 31, 12:01 AM

Thu, Jul 30

sashank committed R1:9325b680bdb6: 0.8.10.pre2 (authored by sashank).
0.8.10.pre2
Thu, Jul 30, 11:49 PM
sashank accepted D4052: Fix for release CLI.

i trust you

Thu, Jul 30, 11:37 PM

Wed, Jul 29

sashank accepted D4028: Removing Dask image build until we're ready to properly support it for Dask cluster tests.

Wow so we weren't using this image at all this whole time.

Wed, Jul 29, 12:57 AM
sashank added a comment to D4024: implement configurable (pure) solids.

This looks great. Nice work on the comprehensive tests . Same comments re: comments and naming for https://dagster.phacility.com/D4022 apply here. It looks like we can use the abstractproperty pattern we experimented with last time to clean a bunch of this up - let me know what you think.

Wed, Jul 29, 12:51 AM
sashank added inline comments to D4024: implement configurable (pure) solids.
Wed, Jul 29, 12:46 AM

Tue, Jul 28

sashank added a reviewer for D4022: refactor configured implementation + more docs: sashank.
Tue, Jul 28, 11:25 PM
sashank added inline comments to D4022: refactor configured implementation + more docs.
Tue, Jul 28, 11:25 PM
sashank added a comment to D4022: refactor configured implementation + more docs.

This is a great change! Thanks for doing such a thorough job investigating what composite_solids do and ensuring consistent behavior – this feels way better now.

Tue, Jul 28, 11:20 PM
sashank accepted D4020: Allow CLI commands to target running grpc servers.
Tue, Jul 28, 9:30 PM
sashank updated the diff for D3987: Initialize docker grpc server with target.

rebase

Tue, Jul 28, 3:58 PM
sashank added a comment to D3984: Test grpc ping inside container.

are the docker requirements missing from dev-requirements.txt?

Tue, Jul 28, 3:57 PM
sashank updated the diff for D3984: Test grpc ping inside container.

feedback

Tue, Jul 28, 3:51 PM
sashank added inline comments to D3984: Test grpc ping inside container.
Tue, Jul 28, 3:49 PM

Fri, Jul 24

sashank added inline comments to D3984: Test grpc ping inside container.
Fri, Jul 24, 6:50 PM
sashank added a reviewer for D4001: (0.9.0-deprecation-2) Fully deprecate config: alangenfeld.
Fri, Jul 24, 3:41 PM
sashank requested review of D4002: (0.9.0-deprecation-3) Fully deprecate --env flag.
Fri, Jul 24, 5:19 AM
sashank requested review of D4001: (0.9.0-deprecation-2) Fully deprecate config.
Fri, Jul 24, 5:06 AM
sashank requested review of D4000: (0.9.0-deprecation-1) Fully deprecate environment_dict.
Fri, Jul 24, 4:41 AM
sashank added a comment to D3967: add xfail tests for resource config preprocessing issue.

@aj.nadel want to abandon this?

Fri, Jul 24, 12:23 AM
sashank added a comment to D3953: gcs and azure file manager resources.

if i'm using e.g. gcs, do i need to provide the config in GCS_CONFIG_SCHEMA twice?

Fri, Jul 24, 12:19 AM

Thu, Jul 23

sashank added a comment to D3953: gcs and azure file manager resources.

Does this require duplicating config at the run level? would be better if it didn't.

Thu, Jul 23, 9:03 PM
sashank requested review of D3987: Initialize docker grpc server with target.
Thu, Jul 23, 8:18 PM
sashank added a comment to D3990: added utility functions to load config from yaml files, strings, and package resources..

Would it make sense to update the static method on PresetDefinition to use these utility methods?

Thu, Jul 23, 6:24 PM
sashank added a comment to D3966: be explicit that resources can't be configured twice.

This all looks great to me but I'll let @sandyryza do the final approval.

Thu, Jul 23, 6:23 PM
sashank added a reviewer for D3966: be explicit that resources can't be configured twice: sandyryza.
Thu, Jul 23, 6:21 PM
sashank updated the diff for D3916: Spin up grpc server in container.

up

Thu, Jul 23, 3:18 PM
sashank requested review of D3984: Test grpc ping inside container.
Thu, Jul 23, 2:39 PM
sashank requested review of D3916: Spin up grpc server in container.
Thu, Jul 23, 2:11 PM

Wed, Jul 22

sashank accepted D3973: comma fix in buildkite.
Wed, Jul 22, 6:34 PM
sashank committed R1:0c4078e16a52: Add fixture to build dagster core image (authored by sashank).
Add fixture to build dagster core image
Wed, Jul 22, 1:56 PM
sashank closed D3914: Add fixture to build dagster core image.
Wed, Jul 22, 1:56 PM

Tue, Jul 21

sashank accepted D3962: [docs] break up pipeline apidoc section.
Tue, Jul 21, 10:03 PM
sashank accepted D3963: [docs] overview ampersand consistency.
Tue, Jul 21, 10:02 PM
sashank accepted D3959: Make ephemeral_grpc_server a class so that we can store it in the repository location.

This looks great! We may want to add two new utils in dagster.utils for the reasons mentioned in the inline comment.

Tue, Jul 21, 10:02 PM
sashank added inline comments to D3959: Make ephemeral_grpc_server a class so that we can store it in the repository location.
Tue, Jul 21, 9:55 PM
sashank added inline comments to D3959: Make ephemeral_grpc_server a class so that we can store it in the repository location.
Tue, Jul 21, 9:48 PM
sashank updated the diff for D3914: Add fixture to build dagster core image.

up

Tue, Jul 21, 2:44 PM
sashank updated the diff for D3914: Add fixture to build dagster core image.

feedback

Tue, Jul 21, 2:42 PM
sashank added inline comments to D3951: Add repository location for grpc server managed outside of dagster.
Tue, Jul 21, 2:08 PM
sashank added inline comments to D3951: Add repository location for grpc server managed outside of dagster.
Tue, Jul 21, 2:08 PM
sashank added inline comments to D3951: Add repository location for grpc server managed outside of dagster.
Tue, Jul 21, 2:06 PM
sashank added inline comments to D3951: Add repository location for grpc server managed outside of dagster.
Tue, Jul 21, 1:56 PM

Mon, Jul 20

sashank committed R1:32bff5e9e1f1: Update GRPC server to store target (authored by sashank).
Update GRPC server to store target
Mon, Jul 20, 10:11 PM
sashank closed D3941: Update GRPC server to store target.
Mon, Jul 20, 10:11 PM
sashank added inline comments to D3941: Update GRPC server to store target.
Mon, Jul 20, 10:03 PM
sashank updated the diff for D3941: Update GRPC server to store target.

clean up LoadableTargetOrigin

Mon, Jul 20, 9:57 PM
sashank updated the diff for D3941: Update GRPC server to store target.

address feedback

Mon, Jul 20, 9:25 PM
sashank updated the diff for D3941: Update GRPC server to store target.

fix symbol name

Mon, Jul 20, 7:43 PM
sashank added a comment to D3941: Update GRPC server to store target.

TODO: Still have to support passing a single attribute

Mon, Jul 20, 7:17 PM
sashank updated the diff for D3941: Update GRPC server to store target.

up

Mon, Jul 20, 7:17 PM
sashank added inline comments to D3941: Update GRPC server to store target.
Mon, Jul 20, 4:50 PM
sashank planned changes to D3941: Update GRPC server to store target.
Mon, Jul 20, 4:41 PM
sashank abandoned D3868: Introduce persistent GRPC client.
Mon, Jul 20, 4:41 PM
sashank requested review of D3941: Update GRPC server to store target.
Mon, Jul 20, 2:20 PM

Thu, Jul 16

sashank committed R1:c4fc3571ddb4: [docs] Remove learn (authored by sashank).
[docs] Remove learn
Thu, Jul 16, 8:20 PM
sashank closed D3932: [docs] Remove learn.
Thu, Jul 16, 8:20 PM
sashank updated the diff for D3932: [docs] Remove learn.

up

Thu, Jul 16, 8:13 PM
sashank added a comment to D3932: [docs] Remove learn.

Macro byebye:

Thu, Jul 16, 8:02 PM
sashank committed R1:94f7b9ae38e6: Full text search (authored by sashank).
Full text search
Thu, Jul 16, 8:01 PM
sashank closed D3931: Full text search.
Thu, Jul 16, 8:01 PM
sashank published D3932: [docs] Remove learn for review.
Thu, Jul 16, 8:00 PM
sashank updated the summary of D3931: Full text search.
Thu, Jul 16, 7:55 PM
sashank requested review of D3931: Full text search.
Thu, Jul 16, 7:52 PM
sashank abandoned D3917: run bk.
Thu, Jul 16, 6:08 PM
sashank updated the diff for D3914: Add fixture to build dagster core image.

update tox ini

Thu, Jul 16, 6:00 PM
sashank added inline comments to D3914: Add fixture to build dagster core image.
Thu, Jul 16, 5:42 PM
sashank requested review of D3914: Add fixture to build dagster core image.
Thu, Jul 16, 5:42 PM
sashank updated the diff for D3917: run bk.

up

Thu, Jul 16, 3:44 PM
sashank updated the diff for D3917: run bk.

up

Thu, Jul 16, 3:31 PM
sashank requested review of D3917: run bk.
Thu, Jul 16, 5:57 AM
sashank committed R1:850884401ecd: Use python-slim when building core image locally (authored by sashank).
Use python-slim when building core image locally
Thu, Jul 16, 3:58 AM
sashank closed D3913: Use python-slim when building core image locally.
Thu, Jul 16, 3:58 AM
sashank committed R1:28de3379e51e: Rename dagster-core-docker-buildkite folder (authored by sashank).
Rename dagster-core-docker-buildkite folder
Thu, Jul 16, 3:57 AM
sashank closed D3912: Rename dagster-core-docker-buildkite folder.
Thu, Jul 16, 3:57 AM
sashank requested review of D3913: Use python-slim when building core image locally.
Thu, Jul 16, 1:46 AM
sashank requested review of D3912: Rename dagster-core-docker-buildkite folder.
Thu, Jul 16, 1:40 AM
sashank accepted D3908: Move docs automation to one place.

Love how organized these scripts are now, thank you for doing this.

Thu, Jul 16, 1:01 AM

Wed, Jul 15

sashank planned changes to D3868: Introduce persistent GRPC client.
Wed, Jul 15, 11:54 PM
sashank added inline comments to D3868: Introduce persistent GRPC client.
Wed, Jul 15, 10:39 PM
sashank committed R1:a9dd5f030dc8: Fix unit image version (authored by sashank).
Fix unit image version
Wed, Jul 15, 7:59 PM
sashank closed D3902: Fix unit image version.
Wed, Jul 15, 7:59 PM
sashank published D3902: Fix unit image version for review.
Wed, Jul 15, 7:57 PM
sashank committed R1:927ac9919824: (test-project-2) Add core test project (authored by sashank).
(test-project-2) Add core test project
Wed, Jul 15, 7:30 PM
sashank closed D3857: (test-project-2) Add core test project.
Wed, Jul 15, 7:29 PM
sashank updated the summary of D3868: Introduce persistent GRPC client.
Wed, Jul 15, 5:52 PM
sashank added reviewers for D3868: Introduce persistent GRPC client: dgibson, alangenfeld, max.
Wed, Jul 15, 5:49 PM
sashank committed R1:77e04d479655: Update socket argument flag to dagster api grpc (authored by sashank).
Update socket argument flag to dagster api grpc
Wed, Jul 15, 3:49 PM
sashank closed D3896: Update socket argument flag to dagster api grpc.
Wed, Jul 15, 3:49 PM
sashank requested review of D3868: Introduce persistent GRPC client.
Wed, Jul 15, 3:10 PM
sashank updated the diff for D3857: (test-project-2) Add core test project.

up

Wed, Jul 15, 3:09 PM
sashank published D3896: Update socket argument flag to dagster api grpc for review.
Wed, Jul 15, 2:16 PM