Page MenuHomePhabricator
Feed Advanced Search

Yesterday

sashank added a comment to D1566: add backfill cli script.

This is awesome. The interactive part is really nice to use.

Sat, Dec 7, 12:50 AM
sashank created D1570: Add retries to SqliteRunStorage add_run.
Sat, Dec 7, 12:40 AM
sashank added inline comments to D1566: add backfill cli script.
Sat, Dec 7, 12:28 AM
sashank added inline comments to D1566: add backfill cli script.
Sat, Dec 7, 12:09 AM

Fri, Dec 6

sashank added a comment to D1430: Introduce Partition API.

finallydone

Fri, Dec 6, 11:30 PM
sashank updated the diff for D1430: Introduce Partition API.

rebase on origin/master

Fri, Dec 6, 11:28 PM
sashank updated the diff for D1430: Introduce Partition API.

Remove instance parameter from dash_stats_datetime_partition_config function

Fri, Dec 6, 11:11 PM
sashank updated the diff for D1430: Introduce Partition API.

Fix typo

Fri, Dec 6, 11:09 PM
sashank added inline comments to D1430: Introduce Partition API.
Fri, Dec 6, 11:09 PM
sashank updated the diff for D1430: Introduce Partition API.

make black

Fri, Dec 6, 11:08 PM
sashank updated the diff for D1430: Introduce Partition API.

Add tests

Fri, Dec 6, 10:28 PM
sashank planned changes to D1430: Introduce Partition API.
Fri, Dec 6, 1:57 AM
sashank updated the diff for D1430: Introduce Partition API.

fix tests

Fri, Dec 6, 1:57 AM
sashank updated the diff for D1430: Introduce Partition API.

Remove use of instance in envvironment_config_fn, tags_fn, and PartitionSelector

Fri, Dec 6, 1:28 AM
sashank planned changes to D1430: Introduce Partition API.
Fri, Dec 6, 1:28 AM
sashank planned changes to D1430: Introduce Partition API.
Fri, Dec 6, 1:10 AM
sashank updated the diff for D1430: Introduce Partition API.
  • Fix validation on ScheduleDefinition
  • Throw DagsterInvariantViolationError if selected_partition == None
Fri, Dec 6, 1:10 AM
sashank added inline comments to D1430: Introduce Partition API.
Fri, Dec 6, 1:02 AM
sashank added inline comments to D1430: Introduce Partition API.
Fri, Dec 6, 12:36 AM
sashank updated the diff for D1430: Introduce Partition API.

up

Fri, Dec 6, 12:11 AM
sashank planned changes to D1430: Introduce Partition API.
Fri, Dec 6, 12:11 AM

Thu, Dec 5

sashank planned changes to D1430: Introduce Partition API.
Thu, Dec 5, 11:16 PM
sashank updated the diff for D1430: Introduce Partition API.
  • Add environment_dict_fn_for_partition and tags_fn_for_partition to PartitionSet.
  • Add method to PartitionSet to create a ScheduleDefinition from a PartitionSet. This allowed us to move all the partition logic from start_scheduled_execution to environment_dict_fn_for_partition and tags_fn_for_partition.
  • Add tags_fn to ScheduleDefinition
  • Add deprecation warnings for environment_dict and tags arguments to ScheduleDefinition. We should remove them in 0.7.0 to simplify the API.
Thu, Dec 5, 11:16 PM

Tue, Dec 3

sashank accepted D1527: link schedule page.

Looks great! Just two minor suggestions

Tue, Dec 3, 9:04 PM
sashank requested changes to D1527: link schedule page.

From Slack: Would be nice for the 5th column in the top bar to show attempts instead of runs, so that the colors match up with the attempts list

Tue, Dec 3, 12:27 AM
sashank accepted D1527: link schedule page.

This is great!

Tue, Dec 3, 12:23 AM
sashank updated the diff for D1430: Introduce Partition API.

Update date_partition_range to store datetime objects

Tue, Dec 3, 12:18 AM
sashank updated the diff for D1430: Introduce Partition API.

Up

Tue, Dec 3, 12:12 AM
sashank added inline comments to D1430: Introduce Partition API.
Tue, Dec 3, 12:08 AM
sashank updated the diff for D1430: Introduce Partition API.
  • Remove partition_environment_dict_fn
  • Readd partition argument to environment_dict_fn
  • Update existing example
  • Add value to Partition
Tue, Dec 3, 12:00 AM

Mon, Dec 2

sashank commandeered D1430: Introduce Partition API.
Mon, Dec 2, 10:31 PM

Fri, Nov 15

sashank updated the diff for D1431: Add UI for partitions in Dagit.

update snapshots

Fri, Nov 15, 10:13 PM
sashank updated the diff for D1431: Add UI for partitions in Dagit.

refactor

Fri, Nov 15, 10:12 PM
sashank updated the diff for D1431: Add UI for partitions in Dagit.

Remove re-execute button

Fri, Nov 15, 10:06 PM
sashank updated the summary of D1431: Add UI for partitions in Dagit.
Fri, Nov 15, 10:06 PM
sashank updated the summary of D1431: Add UI for partitions in Dagit.
Fri, Nov 15, 10:05 PM
sashank updated the diff for D1431: Add UI for partitions in Dagit.

rebase

Fri, Nov 15, 10:04 PM
sashank updated the diff for D1430: Introduce Partition API.

rebase off origin/master

Fri, Nov 15, 10:03 PM
sashank updated the diff for D1431: Add UI for partitions in Dagit.

rebase

Fri, Nov 15, 9:50 PM
sashank updated the diff for D1430: Introduce Partition API.

make graphql

Fri, Nov 15, 9:48 PM
sashank updated the diff for D1430: Introduce Partition API.

up

Fri, Nov 15, 9:48 PM
sashank updated the diff for D1431: Add UI for partitions in Dagit.

rebase

Fri, Nov 15, 9:39 PM
sashank updated the diff for D1430: Introduce Partition API.

update test

Fri, Nov 15, 9:38 PM
sashank updated the diff for D1430: Introduce Partition API.

update tests

Fri, Nov 15, 9:28 PM
sashank updated the diff for D1430: Introduce Partition API.

update tests

Fri, Nov 15, 9:24 PM
sashank updated the diff for D1431: Add UI for partitions in Dagit.

rebase

Fri, Nov 15, 9:04 PM
sashank updated the diff for D1430: Introduce Partition API.

rebase

Fri, Nov 15, 9:03 PM
sashank added a reviewer for D1431: Add UI for partitions in Dagit: Restricted Project.
Fri, Nov 15, 9:01 PM
sashank updated the summary of D1431: Add UI for partitions in Dagit.
Fri, Nov 15, 9:01 PM
sashank updated the summary of D1431: Add UI for partitions in Dagit.
Fri, Nov 15, 9:00 PM
sashank updated the diff for D1430: Introduce Partition API.

typo

Fri, Nov 15, 8:51 PM
sashank updated the summary of D1430: Introduce Partition API.
Fri, Nov 15, 8:49 PM
sashank updated the summary of D1430: Introduce Partition API.
Fri, Nov 15, 8:49 PM
sashank updated the diff for D1430: Introduce Partition API.

add tests

Fri, Nov 15, 8:43 PM
sashank updated the test plan for D1430: Introduce Partition API.
Fri, Nov 15, 7:18 PM
sashank updated the summary of D1430: Introduce Partition API.
Fri, Nov 15, 7:18 PM
sashank updated the diff for D1430: Introduce Partition API.

Add croniter dependency

Fri, Nov 15, 12:57 AM
sashank updated the diff for D1430: Introduce Partition API.

up

Fri, Nov 15, 12:46 AM
sashank updated the diff for D1430: Introduce Partition API.

up

Fri, Nov 15, 12:46 AM
sashank added inline comments to D1428: Extract ScheduleRow component to its own file.
Fri, Nov 15, 12:41 AM
sashank updated the diff for D1428: Extract ScheduleRow component to its own file.

make graphql

Fri, Nov 15, 12:36 AM
sashank created D1431: Add UI for partitions in Dagit.
Fri, Nov 15, 12:35 AM
sashank created D1430: Introduce Partition API.
Fri, Nov 15, 12:34 AM
sashank abandoned D1331: [WIP] Unit of Work.
Fri, Nov 15, 12:33 AM
sashank abandoned D1410: Add longitudinal view of scheduled runs.
Fri, Nov 15, 12:33 AM

Thu, Nov 14

sashank updated the diff for D1428: Extract ScheduleRow component to its own file.

rebase

Thu, Nov 14, 11:31 PM
sashank updated the diff for D1428: Extract ScheduleRow component to its own file.

mgql

Thu, Nov 14, 10:53 PM
sashank added reviewers for D1428: Extract ScheduleRow component to its own file: prha, Restricted Project.
Thu, Nov 14, 10:42 PM
sashank created D1428: Extract ScheduleRow component to its own file.
Thu, Nov 14, 10:41 PM

Wed, Nov 13

sashank added a comment to D1412: [instance] remove features system.

I was going to use this again for some of the schedule partition work to hide sections within Dagit until 0.7.0. But since it makes it easier to implement the override ability, it makes sense to get rid of this.

Wed, Nov 13, 8:47 PM
sashank created D1410: Add longitudinal view of scheduled runs.
Wed, Nov 13, 12:33 AM

Tue, Nov 12

sashank planned changes to D1331: [WIP] Unit of Work.
Tue, Nov 12, 11:36 PM
sashank updated the diff for D1404: Support preview configuration for dynamic schedule configs.

Fix typo

Tue, Nov 12, 9:21 PM
sashank added inline comments to D1404: Support preview configuration for dynamic schedule configs.
Tue, Nov 12, 9:07 PM
sashank updated the diff for D1404: Support preview configuration for dynamic schedule configs.

up

Tue, Nov 12, 8:04 PM
sashank created D1404: Support preview configuration for dynamic schedule configs.
Tue, Nov 12, 8:03 PM

Mon, Nov 11

sashank updated the diff for D1331: [WIP] Unit of Work.

up

Mon, Nov 11, 11:09 PM
sashank updated the diff for D1395: Fix scheduler documentation.

Update text

Mon, Nov 11, 7:35 PM
sashank updated the diff for D1395: Fix scheduler documentation.

up

Mon, Nov 11, 7:27 PM
sashank updated the diff for D1395: Fix scheduler documentation.

Fix tests

Mon, Nov 11, 7:21 PM
sashank updated the diff for D1395: Fix scheduler documentation.

up

Mon, Nov 11, 7:20 PM
sashank updated the diff for D1395: Fix scheduler documentation.

Up

Mon, Nov 11, 6:38 PM
sashank updated the diff for D1311: Add example of datetime paritioned schedule.

rebase

Mon, Nov 11, 6:31 PM
sashank updated the diff for D1307: Add environment_dict_fn argument to ScheduleDefinition.

rebase

Mon, Nov 11, 6:17 PM

Fri, Nov 8

sashank created D1395: Fix scheduler documentation.
Fri, Nov 8, 10:50 PM
sashank abandoned D1393: Make previous_run_id an optional arg on ExecutionParams.

Agreed actually - this is unnecessary

Fri, Nov 8, 7:18 PM
sashank updated the diff for D1331: [WIP] Unit of Work.

up

Fri, Nov 8, 6:55 PM
sashank added a comment to D1393: Make previous_run_id an optional arg on ExecutionParams.

Now realizing there might have been a reason you decided to make the constructor not have a default value so that you have to be explicit about previous_run_id=None. If so, happy to abandon this.

Fri, Nov 8, 6:48 PM
sashank updated the diff for D1393: Make previous_run_id an optional arg on ExecutionParams.

up

Fri, Nov 8, 6:46 PM
sashank created D1393: Make previous_run_id an optional arg on ExecutionParams.
Fri, Nov 8, 6:45 PM

Nov 7 2019

sashank updated the diff for D1384: Use Apollo cache normalization for schedule stop/start.

Add optimisticResponse to mutations

Nov 7 2019, 11:36 PM
sashank planned changes to D1384: Use Apollo cache normalization for schedule stop/start.
Nov 7 2019, 11:32 PM
sashank added a comment to D1384: Use Apollo cache normalization for schedule stop/start.

Yup exactly. But the mutation is fast and it feels instantaneous already

Nov 7 2019, 11:31 PM
sashank added a comment to D1384: Use Apollo cache normalization for schedule stop/start.

@prha We used to do that manually, but now we let Apollo reconcile the response from the mutation with the store to update the UI.

Nov 7 2019, 10:56 PM
sashank updated the diff for D1386: Print scheduler changes on dagit startup.

Up

Nov 7 2019, 10:35 PM
sashank created D1386: Print scheduler changes on dagit startup.
Nov 7 2019, 10:31 PM
sashank updated the diff for D1384: Use Apollo cache normalization for schedule stop/start.

Update tests

Nov 7 2019, 10:12 PM
sashank updated the summary of D1384: Use Apollo cache normalization for schedule stop/start.
Nov 7 2019, 10:03 PM
sashank added a reviewer for D1384: Use Apollo cache normalization for schedule stop/start: Restricted Project.
Nov 7 2019, 10:03 PM
sashank updated the summary of D1384: Use Apollo cache normalization for schedule stop/start.
Nov 7 2019, 10:02 PM