Page MenuHomePhabricator
Feed Advanced Search

Fri, Jul 10

yuhan requested review of D3847: update "Data Science with Notebooks" #2690.
Fri, Jul 10, 11:23 PM
yuhan accepted D3836: [celery-k8s] fix solid subset execution.
Fri, Jul 10, 10:15 PM
yuhan added inline comments to D3828: use table in lakehouse example.
Fri, Jul 10, 5:30 PM
yuhan added a reviewer for D3812: [RFC] step hook at event level: alangenfeld.
Fri, Jul 10, 5:26 PM
yuhan added inline comments to D3836: [celery-k8s] fix solid subset execution.
Fri, Jul 10, 5:23 PM

Wed, Jul 8

yuhan requested review of D3812: [RFC] step hook at event level.
Wed, Jul 8, 11:51 PM

Tue, Jul 7

yuhan added a comment to D3758: (lakehouse-table-2) lakehouse table.

would like to understand 1) when do I use Table and 2) its value.

Tue, Jul 7, 3:43 AM

Mon, Jul 6

yuhan accepted D3770: 0.8.6 docs.
Mon, Jul 6, 8:22 PM
yuhan closed D3735: drop legacy_examples dependency outside examples/ #2653.
Mon, Jul 6, 7:28 PM
yuhan committed R1:e000c36fc6ec: drop legacy_examples dependency outside examples/ #2653 (authored by yuhan).
drop legacy_examples dependency outside examples/ #2653
Mon, Jul 6, 7:28 PM
yuhan added a comment to D3761: Automate building docs.

this is awesome!! thanks for doing it! it looks great but i will let sashank take the last pass.

Mon, Jul 6, 7:24 PM
yuhan updated the diff for D3735: drop legacy_examples dependency outside examples/ #2653.

rebase

Mon, Jul 6, 7:10 PM
yuhan added a comment to D3735: drop legacy_examples dependency outside examples/ #2653.

@schrockn I see dagster-test as a place to put all the code shared by many python modules so we don't need to replicate test snippets or use code in examples/.
integration tests wise, i dont have strong opinions on where to put, but slightly prefer to have it separate from dagster-test and just keep dagster-test a simple "shared examples used by tests"

Mon, Jul 6, 5:54 PM

Thu, Jul 2

yuhan updated the diff for D3735: drop legacy_examples dependency outside examples/ #2653.

delete unused file

Thu, Jul 2, 9:48 PM
yuhan requested review of D3735: drop legacy_examples dependency outside examples/ #2653.
Thu, Jul 2, 9:46 PM
yuhan committed R1:fb8d0a625b5f: drop intro_tutorial from tests #2623 (authored by yuhan).
drop intro_tutorial from tests #2623
Thu, Jul 2, 12:23 AM
yuhan closed D3729: drop intro_tutorial from tests #2623.
Thu, Jul 2, 12:23 AM

Wed, Jul 1

yuhan accepted D3730: Fix broken link test.
Wed, Jul 1, 11:48 PM
yuhan requested review of D3729: drop intro_tutorial from tests #2623.
Wed, Jul 1, 11:29 PM
yuhan added a comment to D3725: [docs] Remove landing page and /docs path.

once you land it, can you update this accordingly? https://github.com/dagster-io/dagster-docs/blob/master/netlify.toml

Wed, Jul 1, 9:33 PM
yuhan accepted D3698: [docs] Move examples doc under docs folder.

Looks good overall

Wed, Jul 1, 8:59 PM

Tue, Jun 30

yuhan added a comment to D3698: [docs] Move examples doc under docs folder.

I actually slightly prefer to keep the readmes with the example code in examples/, because it feels natural when someone opens dagster repo and browser examples on github, they could just read through github without going anywhere else, like this link https://github.com/dagster-io/dagster/tree/0.8.5/examples/basic_pyspark

Tue, Jun 30, 10:58 PM
yuhan committed R1:35b2dc8fe2a9: cleanup docker-compose in pre-exit (authored by yuhan).
cleanup docker-compose in pre-exit
Tue, Jun 30, 10:52 PM
yuhan closed D3710: cleanup docker-compose in pre-exit.
Tue, Jun 30, 10:52 PM
yuhan requested review of D3710: cleanup docker-compose in pre-exit.
Tue, Jun 30, 10:41 PM
yuhan closed D3637: examples/legacy_examples/airline_demo -> examples/airline_demo.
Tue, Jun 30, 9:36 PM
yuhan committed R1:b1abfd4f4a1a: examples/legacy_examples/airline_demo -> examples/airline_demo (authored by yuhan).
examples/legacy_examples/airline_demo -> examples/airline_demo
Tue, Jun 30, 9:36 PM
yuhan updated the diff for D3637: examples/legacy_examples/airline_demo -> examples/airline_demo.

rebase

Tue, Jun 30, 9:21 PM
yuhan updated the diff for D3637: examples/legacy_examples/airline_demo -> examples/airline_demo.

rebase master

Tue, Jun 30, 8:18 PM

Fri, Jun 26

yuhan updated the summary of D3637: examples/legacy_examples/airline_demo -> examples/airline_demo.
Fri, Jun 26, 4:14 AM
yuhan updated the diff for D3637: examples/legacy_examples/airline_demo -> examples/airline_demo.

.coveragerc

Fri, Jun 26, 3:58 AM
yuhan updated the diff for D3637: examples/legacy_examples/airline_demo -> examples/airline_demo.

up

Fri, Jun 26, 3:21 AM
yuhan updated the diff for D3637: examples/legacy_examples/airline_demo -> examples/airline_demo.

up

Fri, Jun 26, 3:09 AM
yuhan updated the diff for D3637: examples/legacy_examples/airline_demo -> examples/airline_demo.

cov

Fri, Jun 26, 2:33 AM
yuhan updated the diff for D3637: examples/legacy_examples/airline_demo -> examples/airline_demo.

up

Fri, Jun 26, 2:17 AM
yuhan abandoned D3650: test.
Fri, Jun 26, 2:10 AM
yuhan updated the diff for D3637: examples/legacy_examples/airline_demo -> examples/airline_demo.

ready

Fri, Jun 26, 2:08 AM
yuhan requested review of D3637: examples/legacy_examples/airline_demo -> examples/airline_demo.
Fri, Jun 26, 1:02 AM

Thu, Jun 25

yuhan committed R1:80afa526be32: mark places outside examples where examples/ are mentioned (authored by yuhan).
mark places outside examples where examples/ are mentioned
Thu, Jun 25, 9:56 PM
yuhan closed D3628: mark places outside examples where examples/ are mentioned.
Thu, Jun 25, 9:56 PM
yuhan updated the diff for D3628: mark places outside examples where examples/ are mentioned.

up

Thu, Jun 25, 9:54 PM
yuhan committed R1:3da9e49b0e07: [docs] move literalincludes from legacy_examples to docs_snippets 1/ (authored by yuhan).
[docs] move literalincludes from legacy_examples to docs_snippets 1/
Thu, Jun 25, 9:32 PM
yuhan closed D3621: [docs] move literalincludes from legacy_examples to docs_snippets 1/.
Thu, Jun 25, 9:32 PM
yuhan requested review of D3650: test.
Thu, Jun 25, 9:09 PM
yuhan updated the summary of D3621: [docs] move literalincludes from legacy_examples to docs_snippets 1/.
Thu, Jun 25, 6:42 PM

Wed, Jun 24

yuhan requested review of D3628: mark places outside examples where examples/ are mentioned.
Wed, Jun 24, 8:21 PM
yuhan accepted D3620: Executor docs.
Wed, Jun 24, 4:41 PM
yuhan added reviewers for D3621: [docs] move literalincludes from legacy_examples to docs_snippets 1/: sashank, nate, sandyryza.
Wed, Jun 24, 4:39 PM
yuhan requested review of D3621: [docs] move literalincludes from legacy_examples to docs_snippets 1/.
Wed, Jun 24, 6:25 AM
yuhan committed R1:e551ff4bbb2c: [docs] SEO: add meta tags for dynamic pages (authored by yuhan).
[docs] SEO: add meta tags for dynamic pages
Wed, Jun 24, 12:49 AM
yuhan closed D3615: [docs] SEO: add meta tags for dynamic pages.
Wed, Jun 24, 12:49 AM
yuhan added inline comments to D3617: [docs] Add instances overview page.
Wed, Jun 24, 12:34 AM
yuhan committed R1:3934b5a0f52e: [docs] overview - logging (authored by yuhan).
[docs] overview - logging
Wed, Jun 24, 12:32 AM
yuhan closed D3600: [docs] overview - logging.
Wed, Jun 24, 12:32 AM
yuhan committed R1:4b4d08f41f9d: [docs] github link with version (authored by yuhan).
[docs] github link with version
Wed, Jun 24, 12:31 AM
yuhan closed D3612: [docs] github link with version.
Wed, Jun 24, 12:31 AM
yuhan accepted D3619: remove aws cli doc.
Wed, Jun 24, 12:21 AM

Tue, Jun 23

yuhan added a comment to D3600: [docs] overview - logging.

https://github.com/dagster-io/dagster/issues/2642

Tue, Jun 23, 9:07 PM
yuhan requested review of D3615: [docs] SEO: add meta tags for dynamic pages.
Tue, Jun 23, 9:02 PM
yuhan requested review of D3612: [docs] github link with version.
Tue, Jun 23, 8:41 PM
yuhan added a comment to D3600: [docs] overview - logging.

@sandyryza how do you feel about having a long glossary page (e.g. https://databricks.com/glossary) but divided by section like modes, resources, logging, etc, and then link the section on the bottom of each overview page?

Tue, Jun 23, 5:46 PM
yuhan requested review of D3600: [docs] overview - logging.
Tue, Jun 23, 12:20 AM

Mon, Jun 22

yuhan accepted D3598: fix backfill cli help text.
Mon, Jun 22, 11:17 PM
yuhan committed R1:cf558f64e96a: [docs seo] ref canonical (authored by yuhan).
[docs seo] ref canonical
Mon, Jun 22, 7:13 PM
yuhan closed D3579: [docs seo] ref canonical.
Mon, Jun 22, 7:13 PM
yuhan committed R1:d5f58483e450: docs 0.8.4 (authored by yuhan).
docs 0.8.4
Mon, Jun 22, 7:13 PM
yuhan closed D3582: docs 0.8.4.
Mon, Jun 22, 7:13 PM
yuhan added a comment to D3567: [docs] Add code example for intro page.

re: example
I'm fine with pandas, because I wouldn't expect people to follow/copypaste/run the intro code -- even just a few func names with pass would be fine IMO.
But I think we could have a better example to demonstrate our values: easy to organize pipeline code (elegant programming model), UI, programmatic APIs.

Mon, Jun 22, 7:12 PM

Sat, Jun 20

yuhan committed R1:4ff2edc478f1: [docs example] fix new pages literalinclude (authored by yuhan).
[docs example] fix new pages literalinclude
Sat, Jun 20, 1:33 AM
yuhan closed D3584: [docs example] fix new pages literalinclude.
Sat, Jun 20, 1:33 AM
yuhan retitled D3584: [docs example] fix new pages literalinclude from [docs example] new pages literalinclude to [docs example] fix new pages literalinclude.
Sat, Jun 20, 1:09 AM
yuhan requested review of D3584: [docs example] fix new pages literalinclude.
Sat, Jun 20, 1:08 AM
yuhan committed R1:e59a93a5d5e7: [docs examples] move old examples to examples/legacy_examples (authored by yuhan).
[docs examples] move old examples to examples/legacy_examples
Sat, Jun 20, 12:48 AM
yuhan closed D3572: [docs examples] move old examples to examples/legacy_examples.
Sat, Jun 20, 12:48 AM
yuhan requested review of D3582: docs 0.8.4.
Sat, Jun 20, 12:46 AM
yuhan requested review of D3579: [docs seo] ref canonical.
Sat, Jun 20, 12:25 AM

Fri, Jun 19

yuhan updated the test plan for D3572: [docs examples] move old examples to examples/legacy_examples.
Fri, Jun 19, 10:50 PM
yuhan requested review of D3572: [docs examples] move old examples to examples/legacy_examples.
Fri, Jun 19, 10:45 PM
yuhan accepted D3565: [docs] Render examples in docs.
Fri, Jun 19, 6:20 PM
yuhan committed R1:776d37b62ca0: [docs examples] move intro_tutorial to docs_snippets/docs_snippets/ (authored by yuhan).
[docs examples] move intro_tutorial to docs_snippets/docs_snippets/
Fri, Jun 19, 6:13 PM
yuhan closed D3561: [docs examples] move intro_tutorial to docs_snippets/docs_snippets/.
Fri, Jun 19, 6:13 PM
yuhan requested review of D3561: [docs examples] move intro_tutorial to docs_snippets/docs_snippets/.
Fri, Jun 19, 5:52 PM

Thu, Jun 18

yuhan committed R1:c99192238907: isOptional -> isRequired graphql/dagit (authored by yuhan).
isOptional -> isRequired graphql/dagit
Thu, Jun 18, 6:15 PM
yuhan closed D3501: isOptional -> isRequired graphql/dagit.
Thu, Jun 18, 6:15 PM
yuhan updated the diff for D3501: isOptional -> isRequired graphql/dagit.

rebase master

Thu, Jun 18, 5:44 PM
yuhan committed R1:63f4dffcc044: docs 0.8.3 (authored by yuhan).
docs 0.8.3
Thu, Jun 18, 4:05 AM
yuhan closed D3548: docs 0.8.3.
Thu, Jun 18, 4:05 AM
yuhan requested review of D3548: docs 0.8.3.
Thu, Jun 18, 3:47 AM
yuhan committed R1:c5bbeeb00a62: [docs] tutorial code link style (authored by yuhan).
[docs] tutorial code link style
Thu, Jun 18, 2:47 AM
yuhan closed D3547: [docs] tutorial code link style.
Thu, Jun 18, 2:47 AM
yuhan requested review of D3547: [docs] tutorial code link style.
Thu, Jun 18, 1:06 AM

Wed, Jun 17

yuhan added inline comments to D3544: Run Launcher Verbiage.
Wed, Jun 17, 11:34 PM
yuhan added a comment to D2879: RFC: Composite solid subselection.

FYI
in D3221 i renamed PipelineDefinition.subset_for_execution(solid_subset) to PipelineDefinition.get_pipeline_subset_def(solids_to_execute), because previously both ExecutablePipeline and PipelineDefinition have a func called subset_for_execution so i did the renaming to avoid confusing.
it may be worth reading the summary sections in D3221 and D3225 to get the context of the subsetting refactor we did after this diff

Wed, Jun 17, 10:56 PM

Tue, Jun 16

yuhan committed R1:4fd5a46bb5d1: tutorial code cleanup and test coverage (authored by yuhan).
tutorial code cleanup and test coverage
Tue, Jun 16, 9:11 PM
yuhan closed D3521: tutorial code cleanup and test coverage.
Tue, Jun 16, 9:11 PM
yuhan committed R1:3adc1f9fbb15: reexecute tutorial update (authored by yuhan).
reexecute tutorial update
Tue, Jun 16, 8:50 PM
yuhan closed D3515: reexecute tutorial update.
Tue, Jun 16, 8:50 PM
yuhan updated the diff for D3515: reexecute tutorial update.

comments

Tue, Jun 16, 8:47 PM
yuhan requested review of D3521: tutorial code cleanup and test coverage.
Tue, Jun 16, 8:38 PM
yuhan updated the diff for D3515: reexecute tutorial update.

changelog

Tue, Jun 16, 8:33 PM