I really like this. With schedules getting so many cool features I think they deserve more top level representation.
Tue, Aug 4
This looks great to me 👍 I feel like the metadata approach gives this a lot of flexibility and the code looks clean. I think we can tweak the visual appearance a bit but the ideal styling sort of depends on how many options end up appearing in that menu in the common case, so it might be best to wait and see how this gets used!
Thu, Jul 23
Mon, Jul 20
Thu, Jul 16
Address diff feedback
Thanks for the review @prha will get this fixed today!
Tue, Jul 14
Jul 9 2020
Wow this is slick and the code looks good to me. I don't know if folks will guess that this interaction exists, so we may need to put a tooltip / meta text somewhere on the page so folks know to use it. (I feel like we need one of those "Loading..." banners with a Top Hat Dagster telling you tricks)
Jul 7 2020
Add tests for Dagit path prefix feature
Need to tie VSCode to Black
Oh wow sorry I didn't catch this when I put this together, I guess this instanceof Array check guarded against a typescript error here... looks great to me 👍
Apply diff feedback
Jul 6 2020
Jul 2 2020
Jun 30 2020
lolo omg that gif
Lock the current pipeline tag into the filter bar on the pipeline runs page
Fix typo, add comments detailing new React hooks
We probably should rename EnvironmentPicker but I can do it later today if that's easier, will require rebuilding the snapshots etc.
Jun 26 2020
Jun 23 2020
Jun 19 2020
Looks great let's ship it!
Rename PipelineExecutionButtonGroup > LaunchRootExecutionButton
This looks good to me, I will add on the front-end UI today!
Jun 17 2020
Jun 16 2020
Jun 12 2020
Jun 11 2020
- Fix missing arg forwarding
- Make “starting” state work in re-execute button [temporary fix]
Looks good to me! I think originally we defaulted to "" instead of "*" because on large pipelines we wanted to make you type * explicitly and not try to render that subset immediately. I'm not sure that that is still necessary / an issue.
Jun 10 2020
Jun 9 2020
Jun 5 2020
Jun 4 2020
- Rebase and update tests
Will rebuild snapshots and land this, thanks for the review folks 👍
Jun 3 2020
This looks great to me! Just want to make sure we don't need the run launcher existence check anymore.
- Also apply tooltip to solid column in the logs viewer
Remove the solid subset display from the runs list for now, will revisit in follow-up diff that unifies the presentation across the runs list and run group display.
Jun 2 2020
Looks good - just as a sanity check, the idea is that making the graphQL queries again will always return the latest data from the python files on disk, so to reload dagit you'd just refresh the page in your browser the old-school way?