Page MenuHomeElementl
Feed Advanced Search

Fri, Apr 16

bengotow accepted D7487: [dagit] Assets: Only show latest materialization in list.

This seems like a good workflow improvement! Certainly makes the list easier to scan through and emphasizes that the graphs, etc. also only show the most recent run for the partition.

Fri, Apr 16, 8:46 PM
bengotow closed D7466: Remove “for-screenshots” titles - confirmed with Sashank that there is no script using this anymore #3800.
Fri, Apr 16, 3:16 PM
bengotow committed R1:0e06f31c1dec: Remove “for-screenshots” titles - confirmed with Sashank that there is no… (authored by bengotow).
Remove “for-screenshots” titles - confirmed with Sashank that there is no…
Fri, Apr 16, 3:16 PM
bengotow closed D7469: Make default scroll position in "Launch backfill" modal be right-most partition #3787.
Fri, Apr 16, 3:15 PM
bengotow committed R1:3e39b932315c: Make default scroll position in "Launch backfill" modal be right-most partition… (authored by bengotow).
Make default scroll position in "Launch backfill" modal be right-most partition…
Fri, Apr 16, 3:15 PM

Thu, Apr 15

bengotow requested review of D7469: Make default scroll position in "Launch backfill" modal be right-most partition #3787.
Thu, Apr 15, 8:42 PM
bengotow requested review of D7467: Increase the number of typeahead autocompletions shown and scroll the list #4017.
Thu, Apr 15, 8:36 PM
bengotow requested review of D7466: Remove “for-screenshots” titles - confirmed with Sashank that there is no script using this anymore #3800.
Thu, Apr 15, 8:36 PM
bengotow requested review of D7465: Handle long lists of parent assets #3952.
Thu, Apr 15, 8:30 PM

Wed, Apr 14

bengotow closed D7378: Improve the button layout of the partition view for smaller displays.
Wed, Apr 14, 6:17 PM
bengotow committed R1:c2ebfd254f9b: Improve the button layout of the partition view for smaller displays (authored by bengotow).
Improve the button layout of the partition view for smaller displays
Wed, Apr 14, 6:17 PM
bengotow closed D7379: Fix the partition “Run steps” sidebar which required immediate step list.
Wed, Apr 14, 3:02 AM
bengotow committed R1:6bc26b311f27: Fix the partition “Run steps” sidebar which required immediate step list (authored by bengotow).
Fix the partition “Run steps” sidebar which required immediate step list
Wed, Apr 14, 3:02 AM

Tue, Apr 13

bengotow closed D7377: Switch partition run matrix to simpler “square color = status in last run”.
Tue, Apr 13, 7:03 PM
bengotow committed R1:8f63cb3760eb: Switch partition run matrix to simpler “square color = status in last run” (authored by bengotow).
Switch partition run matrix to simpler “square color = status in last run”
Tue, Apr 13, 7:02 PM

Fri, Apr 9

bengotow requested review of D7379: Fix the partition “Run steps” sidebar which required immediate step list.
Fri, Apr 9, 10:03 PM
bengotow requested review of D7378: Improve the button layout of the partition view for smaller displays.
Fri, Apr 9, 9:12 PM
bengotow requested review of D7377: Switch partition run matrix to simpler “square color = status in last run”.
Fri, Apr 9, 8:17 PM

Thu, Apr 8

bengotow accepted D7345: [dagit] Default nav closed.
Thu, Apr 8, 2:29 PM

Wed, Apr 7

bengotow accepted D7324: [dagit] Enable extended search for global search.

Seems safe to me since we don't have any objects in the system that have spaces in the names. I looked at the other "extended" operators and it doesn't seem like they'll conflict either (was a bit worried about dashes but it seems like those are safe.) LGTM!

Wed, Apr 7, 3:43 PM
bengotow accepted D7323: [dagit] RFC: Collapsible left nav.

Patched this down and played around with it, looks great! It ended up not being as much code as I'd imagined too. I vote we ship it soon and see if folks have feedback on master.

Wed, Apr 7, 3:41 PM
bengotow accepted D7284: [dagit] RFC: Simplify GraphQL Playground usage.

You know, I think I remember when we started doing this a long while back, and it was so that the Dagit graphql playground would work totally offline. (7376c95cecc2a02f74dc213b533be187ea45b221) I don't know that it turned out to be as important as we thought it might, so I'm a fan of this change.

Wed, Apr 7, 3:17 PM

Thu, Apr 1

bengotow accepted D7246: [dagit] Upgrade to React 17.

Whoa nice! I guess we were mostly on function components already so a lot of the class component deprecations didn't matter - that's awesome!

Thu, Apr 1, 3:42 AM

Wed, Mar 31

bengotow accepted D7225: [dagit] Clean up some dead code and exports.

LGTM!

Wed, Mar 31, 2:45 PM

Tue, Mar 30

bengotow closed D7224: More @core peer-deps, new top nav exported from core.
Tue, Mar 30, 11:41 PM
bengotow committed R1:8f57e09e1f8d: More @core peer-deps, new top nav exported from core (authored by bengotow).
More @core peer-deps, new top nav exported from core
Tue, Mar 30, 11:41 PM
bengotow requested review of D7224: More @core peer-deps, new top nav exported from core.
Tue, Mar 30, 10:45 PM
bengotow accepted D7221: Hygiene for Dagit routes.
Tue, Mar 30, 8:55 PM

Mon, Mar 29

bengotow accepted D7197: [dagit] Extract app configuration.

This looks great to me and I think this is a good pattern to set for these sort of global config values going forward. I'm actually surprised we didn't have more hardcoded stuff, 3 variables is not bad!

Mon, Mar 29, 11:08 PM
bengotow accepted D7191: add babel plugin to resolve typescript error.

Didn't realize babel would have to handle this - It seems like babel/preset-typescript passing this to typescript for conversion to javascript would do the trick... but I have never quite understood the babel toolchain, if this does the trick I'm good with it!

Mon, Mar 29, 8:49 PM
bengotow accepted D7159: [dagit] Split app into packages.

This looks great, I pulled it down and ran all the scripts etc - all worked smoothly! 🙌

Mon, Mar 29, 3:12 PM

Mar 19 2021

bengotow accepted D7056: Restrict styled-components and react-router imports.

Chatted about this offline, this looks good and I like using eslint rules to enforce these, but I think the styled-components/macro version is much nicer and it'd be nice to standardize in the other direction if possible!

Mar 19 2021, 2:31 PM
bengotow accepted D7028: [dagit] Fix table row borders in Safari.
Mar 19 2021, 2:25 PM

Mar 17 2021

bengotow closed D6951: Collect support in annotations on the DAG and solid sidebar.
Mar 17 2021, 10:05 PM
bengotow committed R1:cd5eaabf7fd2: Collect support in annotations on the DAG and solid sidebar (authored by bengotow).
Collect support in annotations on the DAG and solid sidebar
Mar 17 2021, 10:05 PM
bengotow added a comment to D6951: Collect support in annotations on the DAG and solid sidebar.

Per discussion with @alangenfeld, this now looks a bit nicer and has a color coding to help users understand that the iconography and the layering are related.

Mar 17 2021, 10:05 PM
bengotow updated the diff for D6951: Collect support in annotations on the DAG and solid sidebar.

Rebase and update styling

Mar 17 2021, 9:35 PM
bengotow accepted D6973: [dagit] Use RepoNavItem.

I'm a fan! I pulled it down and poked at it a bit and it seems like a pretty clear improvement over the previous repo switcher and this code looks clean. Really like having a "filter" vs a "selection" concept here.

Mar 17 2021, 4:59 PM
bengotow accepted D6983: [dagit] Remove custom fonts.
Mar 17 2021, 4:48 PM

Mar 16 2021

bengotow requested review of D6951: Collect support in annotations on the DAG and solid sidebar.
Mar 16 2021, 4:43 AM

Mar 15 2021

bengotow closed D6825: Misc small tweaks to the asset root page.
Mar 15 2021, 7:55 PM
bengotow committed R1:95e1c4a8086c: Misc small tweaks to the asset root page (authored by bengotow).
Misc small tweaks to the asset root page
Mar 15 2021, 7:55 PM
bengotow added a comment to D6825: Misc small tweaks to the asset root page.

Talked with sandy + dish and revised the presentation to look like this:

image.png (301×631 px, 37 KB)

Mar 15 2021, 4:11 PM
bengotow updated the diff for D6825: Misc small tweaks to the asset root page.

Update presentation of "latest materialization from"

Mar 15 2021, 4:10 PM
bengotow accepted D6868: asset tags visible in catalog table view.

This looks great! I think asset tags are better than expecting everyone to collect their assets into folders with the path style names. I'm a little wary of pipeline being encoded on assets via a tag because it'd be nice to have a more formal structure with the full [pipeline+mode] links we render elsewhere, but that's out of scope of this :-)

Mar 15 2021, 3:24 AM
bengotow accepted D6893: [dagit] Make repo switcher more flexible.

This looks great! Just left a couple nits inline. If we get really tired of the Promise.all(client.query...) it'd be fun to explore a useQuery hook that took an array of VariableType and ran N queries and flattened them, but not sure if the response __typename checking would make it hard to generalize...

Mar 15 2021, 3:17 AM
bengotow accepted D6903: [dagit] RFC: Multi-repo switcher.

This looks great! I like this multi-select concept because it makes it really clear that the repo selection is a piece of view state specific to the sidebar and not a page-wide setting. It seems more valid to view a pipeline run of repo X with repo Y in the sidebar if it's "1 of 6" and the choice is behind a "Filter" button. Code looks good!

Mar 15 2021, 2:59 AM

Mar 11 2021

bengotow planned changes to D6825: Misc small tweaks to the asset root page.

Thanks folks! I'll tinker with this a bit more, I agree that sentence is a bit of a mouthful, the icons could help a lot.

Mar 11 2021, 10:28 PM
bengotow closed D6824: Add snapshotId support to PiplineAndMode, display mode in more places.
Mar 11 2021, 10:23 PM
bengotow committed R1:7125bfede992: Add snapshotId support to PiplineAndMode, display mode in more places (authored by bengotow).
Add snapshotId support to PiplineAndMode, display mode in more places
Mar 11 2021, 10:23 PM
bengotow closed D6823: Eagerly set mode when changing partition sets #3711.
Mar 11 2021, 10:22 PM
bengotow committed R1:979d4a1b1737: Eagerly set mode when changing partition sets #3711 (authored by bengotow).
Eagerly set mode when changing partition sets #3711
Mar 11 2021, 10:22 PM

Mar 9 2021

bengotow accepted D6832: [dagit] Use warning icon on Status, fix tab highlighting.
Mar 9 2021, 4:12 PM

Mar 8 2021

bengotow updated the summary of D6825: Misc small tweaks to the asset root page.
Mar 8 2021, 6:10 PM
bengotow updated the diff for D6825: Misc small tweaks to the asset root page.

Feature flag the breadcrumb-style title to the new asset catalog design

Mar 8 2021, 6:10 PM
bengotow requested review of D6825: Misc small tweaks to the asset root page.
Mar 8 2021, 5:56 PM
bengotow requested review of D6824: Add snapshotId support to PiplineAndMode, display mode in more places.
Mar 8 2021, 5:12 PM
bengotow requested review of D6823: Eagerly set mode when changing partition sets #3711.
Mar 8 2021, 5:05 PM
bengotow accepted D6815: Upgrade and repair Storybook.
Mar 8 2021, 3:56 AM

Mar 4 2021

bengotow accepted D6792: [dagit] Separate pipeline and snapshot links in Run header.
Mar 4 2021, 8:19 PM
bengotow accepted D6791: [dagit] Allow Group wrapping.
Mar 4 2021, 8:18 PM
bengotow accepted D6744: [dagit] Move mode alongside pipeline name.

This seems like a nice presentation - I think we've been struggling for a while to find a consistent home for "mode" that doesn't make it look like a tag. I like having the <PipelineAndMode> component to wrap up the UI - I wonder if we could push the href generation down into that component in any way? I'm not sure how easy it'd be to retrieve repoAddress within the component...

Mar 4 2021, 8:17 PM
bengotow accepted D6724: [dagit] Localize elapsed time and logs timestamps.

Oh this is super cool - nice that we don't need moment for this sort of thing these days.

Mar 4 2021, 8:14 PM

Mar 1 2021

bengotow accepted D6704: [dagit] Add global search to current left nav.

This looks great to me! Also agree with getting rid of the search bars in each section 👍

Mar 1 2021, 4:16 PM
bengotow accepted D6711: [dagit] Some dependency upgrades.
Mar 1 2021, 4:14 PM

Feb 23 2021

bengotow closed D6490: Force scrollbar visibility on partition matrix to make behavior more clear #3638.
Feb 23 2021, 10:39 PM
bengotow committed R1:cdf946aaaf10: Force scrollbar visibility on partition matrix to make behavior more clear #3638 (authored by bengotow).
Force scrollbar visibility on partition matrix to make behavior more clear #3638
Feb 23 2021, 10:39 PM
bengotow closed D6491: In backfill modal, explain ”Re-execute From Failure”, remove “Re-execute From Last Run”.
Feb 23 2021, 10:38 PM
bengotow committed R1:e32c9ce982d0: In backfill modal, explain ”Re-execute From Failure”, remove “Re-execute From… (authored by bengotow).
In backfill modal, explain ”Re-execute From Failure”, remove “Re-execute From…
Feb 23 2021, 10:38 PM
bengotow accepted D6547: [dagit] Simplify logs filtering input.

This looks awesome! Thanks for writing tests too since I imagine this will get pulled into the other places we have a tokenizing text field.

Feb 23 2021, 4:08 PM

Feb 22 2021

bengotow accepted D6572: [dagit] Use Python event types in log filter view.

This looks good to me, I don't think the capitalized strings in the logs are too scary...

Feb 22 2021, 9:42 PM
bengotow accepted D6589: [dagit] Add repo location reload to object headers.

This looks great! Nice we already had useRepositoryLocationReload, I forgot it was a hook!

Feb 22 2021, 9:06 PM
bengotow accepted D6628: [dagit] Add more useful things to Pipelines list.

This looks great to me! It does seem it'd be nice to have the fuse implementation pulled out into a helper hook because it gets a little technical, but there may not be anywhere else that we could re-use it so it's probably not worth factoring apart into two pieces.

Feb 22 2021, 8:02 PM
bengotow accepted D6606: [dagit] Fix Asset search selection.

This looks good to me!

Feb 22 2021, 7:49 PM
bengotow accepted D6564: [dagit] Flip hideNonMatches default.
Feb 22 2021, 7:48 PM

Feb 15 2021

bengotow requested review of D6491: In backfill modal, explain ”Re-execute From Failure”, remove “Re-execute From Last Run”.
Feb 15 2021, 5:58 PM
bengotow requested review of D6490: Force scrollbar visibility on partition matrix to make behavior more clear #3638.
Feb 15 2021, 5:25 PM
bengotow accepted D6403: [dagit] RFC: Instance status dot in left nav.

I'll let other folks weigh in but the JS for this looks great. I think that you're right - the dot should either display detailed info when you hover over it (as opposed to Warnings found) or they should be in a consolidated spot on the instance tab (or maybe each tab of the instance UI gets it's own yellow dot so you can click into the right tab? Probably overkill...)

Feb 15 2021, 5:01 PM
bengotow accepted D6441: [dagit] Shortcut handlers for simple left nav.

This looks great! I like the new shortcut annotation styling too, matches the new sidebar a bit better 👍

Feb 15 2021, 5:01 PM
bengotow accepted D6447: [dagit] Some loading-state cleanup.
Feb 15 2021, 5:00 PM

Feb 11 2021

bengotow accepted D6413: [dagit] Adjust run status colors.

Oh this is great, I really like the slow pulsing of the queued runs. I feel like it /could/ be a little distracting if different runs on the page pulse out of sync, but I imagine there aren't many places where we'd run in to that. Let's ship it!

Feb 11 2021, 2:13 AM
bengotow accepted D6405: [dagit] Font smoothing and default color.

Oh wow this is super noticeable. I didn't think to try this, looks much nicer!

Feb 11 2021, 2:11 AM
bengotow accepted D6402: [dagit] Consistent blue color for nav, search.
Feb 11 2021, 2:10 AM
bengotow accepted D6386: [dagit] Tweak some spacing following header change.
Feb 11 2021, 2:10 AM

Feb 9 2021

bengotow accepted D6367: [dagit] Consistent top nav.

This looks great! I like this direction and the consistency of the header + subtitle approach a lot. Just have a couple drive-by comments below, but I think we should merge this ASAP.

Feb 9 2021, 6:08 PM

Feb 5 2021

bengotow accepted D6333: [dagit] Fix Gantt chart scale.
Feb 5 2021, 8:50 PM
bengotow added a comment to D6333: [dagit] Fix Gantt chart scale.

Yep I think this will do it 👍 I think this must have become a problem when we started emitting logs during the "queued" phase and putting a big gap between firstLogAt and startedPipelineAt.

Feb 5 2021, 8:50 PM
bengotow accepted D6324: [dagit] QueryCountdown to consolidate some repetitive code.

This looks like a great refactor to me! Big fan of making these consistent.

Feb 5 2021, 4:41 PM
bengotow accepted D6323: Repair LeftNavSimple.stories.
Feb 5 2021, 4:36 PM
bengotow accepted D6322: Repair pointer-events with Group margins.

LGTM!

Feb 5 2021, 4:36 PM

Feb 2 2021

bengotow closed D6226: Update the headers on the run table to call out Run ID vs Snapshot ID, pipeline more clearly.
Feb 2 2021, 10:57 PM
bengotow committed R1:15008477a463: Update the headers on the run table to call out Run ID vs Snapshot ID, pipeline… (authored by bengotow).
Update the headers on the run table to call out Run ID vs Snapshot ID, pipeline…
Feb 2 2021, 10:57 PM
bengotow closed D6232: Use a finite spinner for the partition view loading indicator.
Feb 2 2021, 10:57 PM
bengotow committed R1:4493f47fbca9: Use a finite spinner for the partition view loading indicator (authored by bengotow).
Use a finite spinner for the partition view loading indicator
Feb 2 2021, 10:57 PM
bengotow accepted D6256: [dagit] Set per-snapshot run filters as "permanent".

Ah I like this styling above the input, good call!

Feb 2 2021, 9:24 PM
bengotow accepted D6252: [dagit] Add flag to enable new left nav.

Ahh this is exciting! Look forward to trying it in the app - the code looks great to me 👍

Feb 2 2021, 9:23 PM

Feb 1 2021

bengotow accepted D6236: [dagit] Left Nav exploration.

I think we talked about this Thursday - I'm a big fan of incrementally introducing the repository concept and having this flat list of pipelines. The components look good to me!

Feb 1 2021, 10:08 PM
bengotow added a comment to D6224: toy pipeline that generates a partitioned asset.

Nice! I think that longitudinal_pipeline also has a partitioned costs_dashboard asset and I've been using that one to test the asset materialization views but it'll be nice to have one that emits metadata entries.

Feb 1 2021, 10:05 PM
bengotow accepted D6230: [dagit] Time components.

Looks good to me! I'm surprised timestampToString is used outside the time folder since it's not user-settings-aware, but we can audit that later!

Feb 1 2021, 10:03 PM
bengotow accepted D6231: [dagit] Roots for Pipelines, Settings.

Looks good to me!

Feb 1 2021, 10:01 PM