This seems like a good workflow improvement! Certainly makes the list easier to scan through and emphasizes that the graphs, etc. also only show the most recent run for the partition.
Fri, Apr 16
Thu, Apr 15
Wed, Apr 14
Tue, Apr 13
Fri, Apr 9
Thu, Apr 8
Wed, Apr 7
Seems safe to me since we don't have any objects in the system that have spaces in the names. I looked at the other "extended" operators and it doesn't seem like they'll conflict either (was a bit worried about dashes but it seems like those are safe.) LGTM!
Patched this down and played around with it, looks great! It ended up not being as much code as I'd imagined too. I vote we ship it soon and see if folks have feedback on master.
You know, I think I remember when we started doing this a long while back, and it was so that the Dagit graphql playground would work totally offline. (7376c95cecc2a02f74dc213b533be187ea45b221) I don't know that it turned out to be as important as we thought it might, so I'm a fan of this change.
Thu, Apr 1
Whoa nice! I guess we were mostly on function components already so a lot of the class component deprecations didn't matter - that's awesome!
Wed, Mar 31
Tue, Mar 30
Mon, Mar 29
This looks great to me and I think this is a good pattern to set for these sort of global config values going forward. I'm actually surprised we didn't have more hardcoded stuff, 3 variables is not bad!
This looks great, I pulled it down and ran all the scripts etc - all worked smoothly! 🙌
Mar 19 2021
Chatted about this offline, this looks good and I like using eslint rules to enforce these, but I think the styled-components/macro version is much nicer and it'd be nice to standardize in the other direction if possible!
Mar 17 2021
Per discussion with @alangenfeld, this now looks a bit nicer and has a color coding to help users understand that the iconography and the layering are related.
Rebase and update styling
I'm a fan! I pulled it down and poked at it a bit and it seems like a pretty clear improvement over the previous repo switcher and this code looks clean. Really like having a "filter" vs a "selection" concept here.
Mar 16 2021
Mar 15 2021
Update presentation of "latest materialization from"
This looks great! I think asset tags are better than expecting everyone to collect their assets into folders with the path style names. I'm a little wary of pipeline being encoded on assets via a tag because it'd be nice to have a more formal structure with the full [pipeline+mode] links we render elsewhere, but that's out of scope of this :-)
This looks great! Just left a couple nits inline. If we get really tired of the Promise.all(client.query...) it'd be fun to explore a useQuery hook that took an array of VariableType and ran N queries and flattened them, but not sure if the response __typename checking would make it hard to generalize...
This looks great! I like this multi-select concept because it makes it really clear that the repo selection is a piece of view state specific to the sidebar and not a page-wide setting. It seems more valid to view a pipeline run of repo X with repo Y in the sidebar if it's "1 of 6" and the choice is behind a "Filter" button. Code looks good!
Mar 11 2021
Thanks folks! I'll tinker with this a bit more, I agree that sentence is a bit of a mouthful, the icons could help a lot.
Mar 9 2021
Mar 8 2021
Feature flag the breadcrumb-style title to the new asset catalog design
Mar 4 2021
This seems like a nice presentation - I think we've been struggling for a while to find a consistent home for "mode" that doesn't make it look like a tag. I like having the <PipelineAndMode> component to wrap up the UI - I wonder if we could push the href generation down into that component in any way? I'm not sure how easy it'd be to retrieve repoAddress within the component...
Oh this is super cool - nice that we don't need moment for this sort of thing these days.
Mar 1 2021
This looks great to me! Also agree with getting rid of the search bars in each section 👍
Feb 23 2021
This looks awesome! Thanks for writing tests too since I imagine this will get pulled into the other places we have a tokenizing text field.
Feb 22 2021
This looks good to me, I don't think the capitalized strings in the logs are too scary...
This looks great! Nice we already had useRepositoryLocationReload, I forgot it was a hook!
This looks great to me! It does seem it'd be nice to have the fuse implementation pulled out into a helper hook because it gets a little technical, but there may not be anywhere else that we could re-use it so it's probably not worth factoring apart into two pieces.
This looks good to me!
Feb 15 2021
I'll let other folks weigh in but the JS for this looks great. I think that you're right - the dot should either display detailed info when you hover over it (as opposed to Warnings found) or they should be in a consolidated spot on the instance tab (or maybe each tab of the instance UI gets it's own yellow dot so you can click into the right tab? Probably overkill...)
This looks great! I like the new shortcut annotation styling too, matches the new sidebar a bit better 👍
Feb 11 2021
Oh this is great, I really like the slow pulsing of the queued runs. I feel like it /could/ be a little distracting if different runs on the page pulse out of sync, but I imagine there aren't many places where we'd run in to that. Let's ship it!
Oh wow this is super noticeable. I didn't think to try this, looks much nicer!
Feb 9 2021
This looks great! I like this direction and the consistency of the header + subtitle approach a lot. Just have a couple drive-by comments below, but I think we should merge this ASAP.
Feb 5 2021
Yep I think this will do it 👍 I think this must have become a problem when we started emitting logs during the "queued" phase and putting a big gap between firstLogAt and startedPipelineAt.
This looks like a great refactor to me! Big fan of making these consistent.
Feb 2 2021
Ah I like this styling above the input, good call!
Ahh this is exciting! Look forward to trying it in the app - the code looks great to me 👍
Feb 1 2021
I think we talked about this Thursday - I'm a big fan of incrementally introducing the repository concept and having this flat list of pipelines. The components look good to me!
Nice! I think that longitudinal_pipeline also has a partitioned costs_dashboard asset and I've been using that one to test the asset materialization views but it'll be nice to have one that emits metadata entries.
Looks good to me! I'm surprised timestampToString is used outside the time folder since it's not user-settings-aware, but we can audit that later!