Page MenuHomeElementl
Feed Advanced Search

Jul 13 2021

alangenfeld closed D8800: remove storage accessors from instance.
Jul 13 2021, 5:33 PM
alangenfeld committed R1:0e5e3563eb9a: remove storage accessors from instance (authored by alangenfeld).
remove storage accessors from instance
Jul 13 2021, 5:33 PM
alangenfeld accepted D8853: ensure pipeline def args get threaded through hook decorator.

thankyou

Jul 13 2021, 4:58 PM

Jul 12 2021

alangenfeld updated the diff for D8808: [dag-star] graphql endpoint.

rebase

Jul 12 2021, 9:27 PM
alangenfeld accepted D8824: crag migration guide.

i think this is a fine place to start

Jul 12 2021, 8:46 PM
alangenfeld added a comment to D8824: crag migration guide.

this sort of dances around the graph -> job coercion bit, which is admittedly hard to thread the needle on. Maybe when Job is introduced you could mention the graph case works by coercing in to one or something like that? Maybe something for a follow up iteration.

Jul 12 2021, 8:44 PM
alangenfeld accepted D8823: default schedule name when none provided.

absolute-win

Jul 12 2021, 8:43 PM
alangenfeld added inline comments to D8808: [dag-star] graphql endpoint.
Jul 12 2021, 6:01 PM
alangenfeld added inline comments to D8809: [dag-star] index html and static resources.
Jul 12 2021, 5:23 PM
alangenfeld added a comment to D8811: unbreak dagit read-only mode.

this behavior should be under test, something in python_modules/dagit/dagit_tests/test_app.py maybe

Jul 12 2021, 4:57 PM

Jul 9 2021

alangenfeld requested review of D8808: [dag-star] graphql endpoint.
Jul 9 2021, 11:08 PM
alangenfeld requested review of D8809: [dag-star] index html and static resources.
Jul 9 2021, 10:45 PM
alangenfeld requested review of D8807: [dag-star] initial starlette app for dagit.
Jul 9 2021, 9:42 PM
alangenfeld closed D8804: 0.12.1 changelog.
Jul 9 2021, 6:20 PM
alangenfeld committed R1:06d32f675d2c: 0.12.1 changelog (authored by alangenfeld).
0.12.1 changelog
Jul 9 2021, 6:20 PM
alangenfeld published D8804: 0.12.1 changelog for review.
Jul 9 2021, 5:25 PM
alangenfeld closed D8801: make get_run_records respect optional mode migration.
Jul 9 2021, 4:54 PM
alangenfeld committed R1:ea6663b38a58: make get_run_records respect optional mode migration (authored by alangenfeld).
make get_run_records respect optional mode migration
Jul 9 2021, 4:54 PM
alangenfeld accepted D8802: make asset_sensors take in jobs.

works for me

Jul 9 2021, 4:52 PM
alangenfeld published D8802: make asset_sensors take in jobs for review.
Jul 9 2021, 4:52 PM
alangenfeld published D8801: make get_run_records respect optional mode migration for review.
Jul 9 2021, 3:43 PM
alangenfeld accepted D8794: docs search: exclude crawl master/.
Jul 9 2021, 3:43 PM
alangenfeld closed D8799: fix pipeline failure sensor.
Jul 9 2021, 3:40 PM
alangenfeld committed R1:9df4536b33f7: fix pipeline failure sensor (authored by alangenfeld).
fix pipeline failure sensor
Jul 9 2021, 3:39 PM
alangenfeld updated the test plan for D8799: fix pipeline failure sensor.
Jul 9 2021, 3:39 PM
alangenfeld requested review of D8799: fix pipeline failure sensor.
Jul 9 2021, 3:26 PM
alangenfeld requested review of D8800: remove storage accessors from instance.
Jul 9 2021, 3:26 PM
alangenfeld added inline comments to D8610: event log / instance api for event_records.
Jul 9 2021, 2:40 PM

Jul 8 2021

alangenfeld closed D8784: remove defensive parent snapshot check.
Jul 8 2021, 10:37 PM
alangenfeld committed R1:06eee8bd0a64: remove defensive parent snapshot check (authored by alangenfeld).
remove defensive parent snapshot check
Jul 8 2021, 10:37 PM
alangenfeld requested review of D8784: remove defensive parent snapshot check.
Jul 8 2021, 9:56 PM
alangenfeld accepted D8780: fix master nav in doc build.
Jul 8 2021, 7:55 PM
alangenfeld closed D8774: 0.12.0 changelog.
Jul 8 2021, 7:42 PM
alangenfeld committed R1:775fa353ea40: 0.12.0 changelog (authored by alangenfeld).
0.12.0 changelog
Jul 8 2021, 7:41 PM
alangenfeld updated the diff for D8774: 0.12.0 changelog.

bug fix

Jul 8 2021, 7:25 PM
alangenfeld updated the diff for D8774: 0.12.0 changelog.

up

Jul 8 2021, 7:09 PM
alangenfeld published D8774: 0.12.0 changelog for review.
Jul 8 2021, 7:09 PM
alangenfeld accepted D8772: Add step tags to StepHandlerContext.
Jul 8 2021, 6:00 PM
alangenfeld accepted D8744: k8s executor client config.

ah only in the celery worker interesting

Jul 8 2021, 5:46 PM
alangenfeld closed D8768: [crag] DynamicOut.
Jul 8 2021, 5:16 PM
alangenfeld committed R1:bc88169f8e1c: [crag] DynamicOut (authored by alangenfeld).
[crag] DynamicOut
Jul 8 2021, 5:16 PM
alangenfeld closed D8767: [dagit] crag opt-in copy.
Jul 8 2021, 5:15 PM
alangenfeld committed R1:6b66d99869ce: [dagit] crag opt-in copy (authored by alangenfeld).
[dagit] crag opt-in copy
Jul 8 2021, 5:15 PM
alangenfeld added inline comments to D8768: [crag] DynamicOut.
Jul 8 2021, 5:15 PM
alangenfeld requested review of D8768: [crag] DynamicOut.
Jul 8 2021, 5:13 PM
alangenfeld requested review of D8767: [dagit] crag opt-in copy.
Jul 8 2021, 5:13 PM
alangenfeld accepted D8769: fix docs.
Jul 8 2021, 5:11 PM
alangenfeld foisted D8769: fix docs upon yuhan.
Jul 8 2021, 5:11 PM
alangenfeld accepted D8752: Clean up marshalling of multiple inputs.

assuming the test failed before and works now, im good with this

Jul 8 2021, 4:49 PM
alangenfeld added inline comments to D8740: add hooks arg to to_job.
Jul 8 2021, 4:45 PM
alangenfeld accepted D8771: unexperminetnalize invocation APIs.
Jul 8 2021, 4:31 PM
alangenfeld published D8771: unexperminetnalize invocation APIs for review.
Jul 8 2021, 4:31 PM
alangenfeld accepted D8762: [dagit] Crag: Add "job" to Runs filter.

redfordnod

Jul 8 2021, 4:08 PM
alangenfeld committed R1:e2de22bac0d8: clean-up bad land D8749 (authored by alangenfeld).
clean-up bad land D8749
Jul 8 2021, 3:08 PM
alangenfeld closed D8749: [crag] api docs section.
Jul 8 2021, 3:04 PM
alangenfeld committed R1:8acb65ae4f6f: [crag] api docs section (authored by alangenfeld).
[crag] api docs section
Jul 8 2021, 3:04 PM
alangenfeld added inline comments to D8744: k8s executor client config.
Jul 8 2021, 2:47 PM
alangenfeld added a comment to D8744: k8s executor client config.

why don't we use DagsterKubernetesClient for this k8s stuff?

Jul 8 2021, 2:46 PM

Jul 7 2021

alangenfeld published D8749: [crag] api docs section for review.

any and all copy edits / suggestions welcome - especially *

Jul 7 2021, 10:23 PM
alangenfeld accepted D8740: add hooks arg to to_job.
Jul 7 2021, 10:21 PM
alangenfeld abandoned D8060: [crag] graph top level export.
Jul 7 2021, 10:20 PM
alangenfeld closed D8723: add get_mapping_key to SolidExecutionContext.
Jul 7 2021, 10:10 PM
alangenfeld committed R1:fd26e3e6d4a8: add get_mapping_key to SolidExecutionContext (authored by alangenfeld).
add get_mapping_key to SolidExecutionContext
Jul 7 2021, 10:10 PM
alangenfeld accepted D8739: Bug: log k8s executor events.

concern with this approach is accidentally getting dupe events if anyone returns an event that was already logged (ie it was created with one of the static constructors that logs)

Jul 7 2021, 9:58 PM
alangenfeld accepted D8732: Create migration to extract asset_keys columns for asset catalog perf.

push_n_pray

Jul 7 2021, 9:15 PM
alangenfeld added a comment to D8732: Create migration to extract asset_keys columns for asset catalog perf.

We may want to consider the same approach for D8629.

Jul 7 2021, 8:32 PM
alangenfeld requested changes to D8741: add crag API docs section.

you can abandon this - I have one going and will steal the good parts from here

Jul 7 2021, 8:29 PM
alangenfeld resigned from D8629: [crag] Add mode to the pipeline runs filter.

defer to @prha

Jul 7 2021, 7:28 PM
alangenfeld added a reviewer for D8732: Create migration to extract asset_keys columns for asset catalog perf: cdecarolis.
Jul 7 2021, 7:28 PM
alangenfeld accepted D8685: Make context argument optional on resource definition.
Jul 7 2021, 7:27 PM
alangenfeld accepted D8739: Bug: log k8s executor events.
Jul 7 2021, 7:18 PM
alangenfeld closed D8720: graph.execute_in_process.
Jul 7 2021, 7:16 PM
alangenfeld committed R1:a176347c3e39: graph.execute_in_process (authored by alangenfeld).
graph.execute_in_process
Jul 7 2021, 7:15 PM
alangenfeld closed D8604: [job] add executor_def.
Jul 7 2021, 7:15 PM
alangenfeld committed R1:f4dd288a8858: [job] add executor_def (authored by alangenfeld).
[job] add executor_def
Jul 7 2021, 7:14 PM
alangenfeld updated the diff for D8720: graph.execute_in_process.

rebase

Jul 7 2021, 6:39 PM
alangenfeld updated the diff for D8604: [job] add executor_def.

fix tests

Jul 7 2021, 6:37 PM
alangenfeld added inline comments to D8604: [job] add executor_def.
Jul 7 2021, 6:30 PM
alangenfeld accepted D8619: retry from failure fan-in bug.

coolcoolcool

Jul 7 2021, 6:28 PM
alangenfeld updated the diff for D8604: [job] add executor_def.

rebase

Jul 7 2021, 4:55 PM
alangenfeld requested changes to D8695: executor-based IO-management.

i think this is directionally promising - but has too many risky externalities to land for tomorrows release.

Jul 7 2021, 4:25 PM
alangenfeld added a comment to D8720: graph.execute_in_process.

would we also have a job.execute_in_process, or would someone be expected to decompose down to the graph?

Jul 7 2021, 3:55 PM
alangenfeld added a comment to D8629: [crag] Add mode to the pipeline runs filter.

TEST PLAN
dagit

Jul 7 2021, 3:21 PM
alangenfeld added a comment to D8732: Create migration to extract asset_keys columns for asset catalog perf.

should this and D8629 be merged? that way its a single migration instead of 2 ?

Jul 7 2021, 3:17 PM
alangenfeld added a comment to D8684: style: adopt pre-commit for Python black formatting.

I faintly remember some weird shit around statefulness of how pre-commit worked when we had it set up but im struggling to remember the details

Jul 7 2021, 3:09 PM
alangenfeld accepted D8733: [dagit] Kill App.test.

byebye

Jul 7 2021, 2:48 PM
alangenfeld closed D8687: [crag] Pipeline.graph_name.
Jul 7 2021, 2:34 PM
alangenfeld committed R1:d1f66a9d87b5: [crag] Pipeline.graph_name (authored by alangenfeld).
[crag] Pipeline.graph_name
Jul 7 2021, 2:34 PM
alangenfeld accepted D8722: [docs] composite multiple outputs.
Jul 7 2021, 2:31 PM
alangenfeld added a comment to D8726: zlib compress repos in gRPC server.

Did you look in to setting compression at the grpc level for requests & responses? That could allow us to make this change at a more appropriate layer, without breaking

Jul 7 2021, 2:30 PM
alangenfeld requested review of D8723: add get_mapping_key to SolidExecutionContext.

dagit test flake

Jul 7 2021, 1:56 PM

Jul 6 2021

alangenfeld requested review of D8720: graph.execute_in_process.
Jul 6 2021, 10:11 PM
alangenfeld requested review of D8714: SolidHandle -> NodeHandle.
Jul 6 2021, 8:38 PM
alangenfeld closed D8706: de-experimental dynamic mapping & collect.
Jul 6 2021, 8:33 PM
alangenfeld committed R1:0c0525612508: de-experimental dynamic mapping & collect (authored by alangenfeld).
de-experimental dynamic mapping & collect
Jul 6 2021, 8:33 PM
alangenfeld accepted D8710: update docs for sensor to reflect optional context.

words

Jul 6 2021, 8:19 PM
alangenfeld requested changes to D8629: [crag] Add mode to the pipeline runs filter.

Q

Jul 6 2021, 8:02 PM
alangenfeld resigned from D8623: [op] Get rid of MultiOut, get rid of name on Out, change to accepting bare dict, clean up tuple typing implementation..

im cool with this - last pass from @sandyryza for api sign off

Jul 6 2021, 8:01 PM
alangenfeld accepted D8711: Better pipeline_code_origin back-compat.

Macro goodcatch:

Jul 6 2021, 6:46 PM
alangenfeld updated the diff for D8706: de-experimental dynamic mapping & collect.

snapshot

Jul 6 2021, 6:34 PM