Page MenuHomePhabricator
Feed Advanced Search

Nov 25 2019

alangenfeld requested changes to D1480: Add dagster instance migrate CLI tool.
Nov 25 2019, 9:26 PM
alangenfeld accepted D1478: (incremental-meta-4) Using meta to power EnvironmentSchema.

seems legit

Nov 25 2019, 9:18 PM
alangenfeld accepted D1472: Collapse WatchableEventLogStorage onto EventLogStorage.

redparty

Nov 25 2019, 8:54 PM
alangenfeld accepted D1475: (incremental-meta-3) Make dauphin config type layer dumb objects.

zubat

Nov 25 2019, 7:43 PM
alangenfeld accepted D1481: Upgrade black to 19.10b0.

if CI passes I'm cool with it

Nov 25 2019, 7:27 PM
alangenfeld accepted D1474: Rename SQL -> Sql.

slamdunk

Nov 25 2019, 6:19 PM
alangenfeld added a reviewer for D1471: Refactor SQL-based event log storages to use SQLAlchemy: themissinghlink.
Nov 25 2019, 6:19 PM
alangenfeld added a reviewer for D1473: Scaffold alembic: themissinghlink.

this one might be best to do in person walk through - not obvious what here is all machine generated artifacts vs edited / manually written

Nov 25 2019, 6:13 PM
alangenfeld requested changes to D1472: Collapse WatchableEventLogStorage onto EventLogStorage.
Nov 25 2019, 5:32 PM
alangenfeld added reviewers for D1471: Refactor SQL-based event log storages to use SQLAlchemy: prha, nate, schrockn.

I need another pair of eyes on this one -

Nov 25 2019, 5:31 PM
alangenfeld committed R1:120269fb3b29: [dagster-graphql] make --remote use post (authored by alangenfeld).
[dagster-graphql] make --remote use post
Nov 25 2019, 5:04 PM
alangenfeld closed D1468: [dagster-graphql] make --remote use post.
Nov 25 2019, 5:04 PM
alangenfeld accepted D1470: Reorganize Postgres-backed storages.

https://dagster.phacility.com/source/dagster/browse/master/python_modules/libraries/dagster-aws/dagster_aws/cli/conf/dagster.template.yaml still works so i think this is g2g

Nov 25 2019, 4:47 PM
alangenfeld resigned from D1461: add scaffolding for pipeline and trip datatype.

seems solid, defer to others for last pass

Nov 25 2019, 4:45 PM
alangenfeld accepted D1479: create schedule page, show schedule attempts.

unlinked schedule page

Nov 25 2019, 4:34 PM

Nov 22 2019

alangenfeld created D1468: [dagster-graphql] make --remote use post.
Nov 22 2019, 10:48 PM
alangenfeld closed D1315: [run launcher] RemoteDagitRunLauncher.
Nov 22 2019, 6:35 PM
alangenfeld committed R1:719cdde34aac: [run launcher] RemoteDagitRunLauncher (authored by alangenfeld).
[run launcher] RemoteDagitRunLauncher
Nov 22 2019, 6:35 PM
alangenfeld committed R1:fe39eebe49e4: [RunLauncher] basic interface (authored by alangenfeld).
[RunLauncher] basic interface
Nov 22 2019, 6:34 PM
alangenfeld closed D1296: [RunLauncher] basic interface.
Nov 22 2019, 6:34 PM
alangenfeld accepted D1466: Reorganize Postgres-backed storages.

whynot

Nov 22 2019, 5:58 PM
alangenfeld committed R1:fbe046bce564: [dagster-graphql] remove dead mutation (authored by alangenfeld).
[dagster-graphql] remove dead mutation
Nov 22 2019, 4:50 PM
alangenfeld closed D1421: [dagster-graphql] remove dead mutation.
Nov 22 2019, 4:50 PM
alangenfeld requested changes to D1457: Refactor SQL-based event log storages to use SQLAlchemy.
Nov 22 2019, 4:49 PM
alangenfeld accepted D1464: Reorganize run and event log storage.

if we decided to keep in the unlikely but still breaking change lets add it to changes.md so we dont forget

Nov 22 2019, 4:31 PM
alangenfeld added inline comments to D1465: Implement task-level retries.
Nov 22 2019, 4:16 PM
alangenfeld updated the diff for D1315: [run launcher] RemoteDagitRunLauncher.

py27

Nov 22 2019, 12:42 AM
alangenfeld added a comment to D1315: [run launcher] RemoteDagitRunLauncher.

might make sense for it to be in the dagit package or be named differently - something we can change later

Nov 22 2019, 12:26 AM
alangenfeld updated the diff for D1315: [run launcher] RemoteDagitRunLauncher.

move to dagster-graphql package

Nov 22 2019, 12:25 AM

Nov 21 2019

alangenfeld updated the diff for D1315: [run launcher] RemoteDagitRunLauncher.

rebase

Nov 21 2019, 11:59 PM
alangenfeld added reviewers for D1315: [run launcher] RemoteDagitRunLauncher: prha, schrockn, max.
Nov 21 2019, 5:49 PM
alangenfeld updated the diff for D1315: [run launcher] RemoteDagitRunLauncher.

up

Nov 21 2019, 5:48 PM
alangenfeld updated the diff for D1296: [RunLauncher] basic interface.

up

Nov 21 2019, 5:48 PM
alangenfeld updated the diff for D1296: [RunLauncher] basic interface.

add predefined query

Nov 21 2019, 5:38 PM
alangenfeld updated the test plan for D1315: [run launcher] RemoteDagitRunLauncher.
Nov 21 2019, 5:16 PM
alangenfeld retitled D1315: [run launcher] RemoteDagitRunLauncher from [execution server] RemoteDagitExecutionServer to [run launcher] RemoteDagitRunLauncher.
Nov 21 2019, 5:15 PM
alangenfeld updated the diff for D1315: [run launcher] RemoteDagitRunLauncher.

run launcher version

Nov 21 2019, 5:13 PM
alangenfeld retitled D1421: [dagster-graphql] remove dead mutation from remove k8 operator to [dagster-graphql] remove dead mutation.
Nov 21 2019, 4:58 PM
alangenfeld updated the diff for D1421: [dagster-graphql] remove dead mutation.

update

Nov 21 2019, 4:57 PM
alangenfeld updated the diff for D1296: [RunLauncher] basic interface.

test against none set

Nov 21 2019, 4:53 PM

Nov 20 2019

alangenfeld retitled D1296: [RunLauncher] basic interface from [RunQueue] basic interface to [RunLauncher] basic interface.
Nov 20 2019, 11:59 PM
alangenfeld added inline comments to D1296: [RunLauncher] basic interface.
Nov 20 2019, 11:57 PM
alangenfeld updated the diff for D1296: [RunLauncher] basic interface.

run launcher version

Nov 20 2019, 11:56 PM
alangenfeld updated the diff for D1296: [RunLauncher] basic interface.

execution_delegate version

Nov 20 2019, 11:45 PM
alangenfeld accepted D1458: Make anonymous types in config type system have stable keys.

excellent

Nov 20 2019, 11:23 PM
alangenfeld added a comment to D1423: test windows build.

note: consider not running in docker and using virtual env instead - purpose is to avoid potential docker FS issues causing slowdown

Nov 20 2019, 8:58 PM
alangenfeld committed R1:ad2232231e35: [docs] Enum & fixes (authored by alangenfeld).
[docs] Enum & fixes
Nov 20 2019, 6:59 PM
alangenfeld closed D1460: [docs] Enum & fixes.
Nov 20 2019, 6:59 PM
alangenfeld added inline comments to D1460: [docs] Enum & fixes.
Nov 20 2019, 6:59 PM
alangenfeld planned changes to D1366: [RFC] requestPipelineExecution.
Nov 20 2019, 5:38 PM
alangenfeld added a comment to D1458: Make anonymous types in config type system have stable keys.

otherwise looks solid

Nov 20 2019, 5:37 PM
alangenfeld requested changes to D1458: Make anonymous types in config type system have stable keys.

test for recursive /deeply nested dict structure

Nov 20 2019, 5:37 PM
alangenfeld requested changes to D1457: Refactor SQL-based event log storages to use SQLAlchemy.

ya lets do the back compat dance - doesnt seem to be a lot of value to be reaped from breaking changes at this juncture

Nov 20 2019, 5:32 PM
alangenfeld accepted D1456: Fix typeahead suggest token values, autoselect first completion.

yaytests

Nov 20 2019, 5:25 PM
alangenfeld updated the diff for D1460: [docs] Enum & fixes.

remove wtf line

Nov 20 2019, 5:15 PM
alangenfeld added a comment to D1454: Evaluate config mapping when solids config is empty.

this seems a touch fishy to have to special case the solid dict in this way - I dont know the config system well enough to hazard a guess at another approach. @natekupp ?

Nov 20 2019, 5:05 PM
alangenfeld updated the diff for D1460: [docs] Enum & fixes.

rebase

Nov 20 2019, 5:03 PM
alangenfeld added a comment to D1443: Resolves https://github.com/dagster-io/dagster/issues/1913.

startrek_uncertain

Nov 20 2019, 4:56 PM
alangenfeld created Image Macro "startrek_uncertain".
Nov 20 2019, 4:56 PM
alangenfeld created D1460: [docs] Enum & fixes.
Nov 20 2019, 4:54 PM
alangenfeld requested changes to D1431: Add UI for partitions in Dagit.

I assume @prha is going to commandeer this.

Nov 20 2019, 4:05 PM
alangenfeld requested changes to D1430: Introduce Partition API.
Nov 20 2019, 3:56 PM
alangenfeld requested changes to D1349: pyspark on EMR.
Nov 20 2019, 3:55 PM

Nov 19 2019

alangenfeld accepted D1429: [dagster-airflow] Fix k8s pod operator in dagster-airflow and get it under test.

verygood

Nov 19 2019, 11:45 PM
alangenfeld added a comment to D1349: pyspark on EMR.

do you want to land this stuff in a beta subfolder and remove the breaking changes?

Nov 19 2019, 9:53 PM
alangenfeld accepted D1453: Doubly nested composite failures.

excellent

Nov 19 2019, 8:57 PM
alangenfeld planned changes to D1315: [run launcher] RemoteDagitRunLauncher.
Nov 19 2019, 8:53 PM
alangenfeld planned changes to D1421: [dagster-graphql] remove dead mutation.
Nov 19 2019, 8:52 PM
alangenfeld planned changes to D1422: [exploration] execution server.
Nov 19 2019, 8:52 PM
alangenfeld accepted D1450: Remove requirements.txt.

thumbsup

Nov 19 2019, 7:12 PM
alangenfeld added inline comments to D1442: add scheduled partition execution.
Nov 19 2019, 4:02 PM
alangenfeld closed D1451: add sanity check for prod installs.
Nov 19 2019, 3:59 PM
alangenfeld committed R1:213589175d56: add sanity check for prod installs (authored by alangenfeld).
add sanity check for prod installs
Nov 19 2019, 3:59 PM
alangenfeld added inline comments to D1429: [dagster-airflow] Fix k8s pod operator in dagster-airflow and get it under test.
Nov 19 2019, 3:56 PM

Nov 18 2019

alangenfeld committed R1:534568c894c7: simple back compat test (authored by alangenfeld).
simple back compat test
Nov 18 2019, 10:34 PM
alangenfeld closed D1449: simple back compat test.
Nov 18 2019, 10:33 PM
alangenfeld committed R1:53dbe8164c18: [dagit] bug fixes (authored by alangenfeld).
[dagit] bug fixes
Nov 18 2019, 10:33 PM
alangenfeld closed D1436: [dagit] bug fixes.
Nov 18 2019, 10:33 PM
alangenfeld created D1451: add sanity check for prod installs.
Nov 18 2019, 10:32 PM
alangenfeld updated the summary of D1449: simple back compat test.
Nov 18 2019, 6:59 PM
alangenfeld created D1449: simple back compat test.
Nov 18 2019, 6:55 PM
alangenfeld closed D1433: upgrade js deps.
Nov 18 2019, 5:20 PM
alangenfeld committed R1:421bad02e155: upgrade js deps (authored by alangenfeld).
upgrade js deps
Nov 18 2019, 5:18 PM
alangenfeld committed R1:a8ec87239930: yarn lint (authored by alangenfeld).
yarn lint
Nov 18 2019, 5:15 PM
alangenfeld closed D1434: yarn lint.
Nov 18 2019, 5:15 PM
alangenfeld updated the diff for D1433: upgrade js deps.

up

Nov 18 2019, 5:07 PM
alangenfeld updated the diff for D1434: yarn lint.

up

Nov 18 2019, 5:04 PM
alangenfeld accepted D1446: Update Buildkite integration images.

thumbsup

Nov 18 2019, 4:56 PM
alangenfeld added a comment to D1443: Resolves https://github.com/dagster-io/dagster/issues/1913.

this is a lot to take in

Nov 18 2019, 4:54 PM
alangenfeld requested changes to D1429: [dagster-airflow] Fix k8s pod operator in dagster-airflow and get it under test.
Nov 18 2019, 4:17 PM
alangenfeld added inline comments to D1429: [dagster-airflow] Fix k8s pod operator in dagster-airflow and get it under test.
Nov 18 2019, 4:10 PM

Nov 15 2019

alangenfeld accepted D1439: Rename configDefinition to configField.

whynot

Nov 15 2019, 10:59 PM
alangenfeld added a comment to D1430: Introduce Partition API.

what is the current string representation of the partition?

Nov 15 2019, 10:58 PM
alangenfeld updated the diff for D1434: yarn lint.

up

Nov 15 2019, 10:41 PM
alangenfeld updated the diff for D1433: upgrade js deps.

fixes

Nov 15 2019, 10:34 PM
alangenfeld updated the summary of D1422: [exploration] execution server.
Nov 15 2019, 9:55 PM
alangenfeld retitled D1315: [run launcher] RemoteDagitRunLauncher from [RunQueue] RemoteDagitRunQueue to [execution server] RemoteDagitExecutionServer.
Nov 15 2019, 9:55 PM
alangenfeld committed R1:d522ad65a62f: fix py27 test (authored by alangenfeld).
fix py27 test
Nov 15 2019, 9:53 PM
alangenfeld closed D1438: fix py27 test.
Nov 15 2019, 9:53 PM
alangenfeld updated the diff for D1315: [run launcher] RemoteDagitRunLauncher.

up

Nov 15 2019, 9:47 PM