Page MenuHomePhabricator
Feed Advanced Search

Yesterday

alangenfeld committed R1:af062b9398d7: [core] guard against solid def name collisions (authored by alangenfeld).
[core] guard against solid def name collisions
Sat, Dec 7, 12:57 AM
alangenfeld closed D1562: [core] guard against solid def name collisions.
Sat, Dec 7, 12:57 AM
alangenfeld updated the diff for D1565: [buildkite] remove dangling images.
true
Sat, Dec 7, 12:56 AM

Fri, Dec 6

alangenfeld updated the diff for D1565: [buildkite] remove dangling images.

xargs version

Fri, Dec 6, 10:57 PM
alangenfeld created D1565: [buildkite] remove dangling images.
Fri, Dec 6, 10:08 PM
alangenfeld updated the diff for D1562: [core] guard against solid def name collisions.

fixes

Fri, Dec 6, 10:04 PM
alangenfeld committed R1:ce17aa93c97c: [dagster aws] s3 fake improvements (authored by alangenfeld).
[dagster aws] s3 fake improvements
Fri, Dec 6, 9:40 PM
alangenfeld closed D1559: [dagster aws] s3 fake improvements.
Fri, Dec 6, 9:40 PM
alangenfeld created D1562: [core] guard against solid def name collisions.
Fri, Dec 6, 8:59 PM
alangenfeld created D1559: [dagster aws] s3 fake improvements.
Fri, Dec 6, 7:09 PM
alangenfeld accepted D1554: Fix dagster-airflow k8s test flakiness.

excellent

Fri, Dec 6, 6:31 PM
alangenfeld accepted D1556: Changelog for 0.6.6.

gogogo

Fri, Dec 6, 6:28 PM
alangenfeld committed R1:98894c95e5fa: [tutorial] fix resources.py (authored by alangenfeld).
[tutorial] fix resources.py
Fri, Dec 6, 5:21 PM
alangenfeld closed D1553: [tutorial] fix resources.py.
Fri, Dec 6, 5:21 PM
alangenfeld added a comment to D1554: Fix dagster-airflow k8s test flakiness.

test plan

Fri, Dec 6, 5:07 PM
alangenfeld created D1553: [tutorial] fix resources.py.
Fri, Dec 6, 4:34 PM
alangenfeld committed R1:e77491cb75d4: [core] remove redundant step level calls (authored by alangenfeld).
[core] remove redundant step level calls
Fri, Dec 6, 1:24 AM
alangenfeld closed D1551: [core] remove redundant step level calls.
Fri, Dec 6, 1:23 AM
alangenfeld updated the diff for D1551: [core] remove redundant step level calls.

delete dont comment

Fri, Dec 6, 1:14 AM
alangenfeld created D1551: [core] remove redundant step level calls.
Fri, Dec 6, 1:11 AM
alangenfeld resigned from D1521: [EMR 1/N] Extract EMR implementation.
Fri, Dec 6, 12:23 AM
alangenfeld requested changes to D1533: Core dagster_celery engine.
Fri, Dec 6, 12:19 AM

Thu, Dec 5

alangenfeld committed R1:c5202863c527: [dagster-graphql] memoize solid handle computation (authored by alangenfeld).
[dagster-graphql] memoize solid handle computation
Thu, Dec 5, 11:41 PM
alangenfeld closed D1541: [dagster-graphql] memoize solid handle computation.
Thu, Dec 5, 11:41 PM
alangenfeld added inline comments to D1548: RFC Serialization Strategy Refactor.
Thu, Dec 5, 11:40 PM
alangenfeld requested changes to D1548: RFC Serialization Strategy Refactor.

get the tests passing - I'm interested in seeing what the callsite changes look like

Thu, Dec 5, 11:38 PM
alangenfeld updated the diff for D1541: [dagster-graphql] memoize solid handle computation.

move again

Thu, Dec 5, 11:32 PM
alangenfeld updated the diff for D1541: [dagster-graphql] memoize solid handle computation.

lru_cache + functools32

Thu, Dec 5, 11:23 PM
alangenfeld resigned from D1430: Introduce Partition API.

ill let @prha take it from here

Thu, Dec 5, 11:23 PM
alangenfeld accepted D1544: Construct all config types in environment schema.

illallowit

Thu, Dec 5, 9:44 PM
alangenfeld accepted D1540: Break pipeline explorer and sidebar queries apart, fetch only current solid layer.

once you get ts to pass

Thu, Dec 5, 9:16 PM
alangenfeld committed R1:5d23652598ba: [nightly] try to fix dagit step (authored by alangenfeld).
[nightly] try to fix dagit step
Thu, Dec 5, 9:10 PM
alangenfeld closed D1547: [nightly] try to fix dagit step.
Thu, Dec 5, 9:10 PM
alangenfeld created D1547: [nightly] try to fix dagit step.
Thu, Dec 5, 8:57 PM
alangenfeld requested changes to D1430: Introduce Partition API.

queue management

Thu, Dec 5, 6:55 PM
alangenfeld accepted D1543: Fix for Dagster errors not failing tasks in Airflow.
Thu, Dec 5, 6:51 PM
alangenfeld accepted D1537: Update snowflake deps.
Thu, Dec 5, 6:44 PM
alangenfeld added inline comments to D1543: Fix for Dagster errors not failing tasks in Airflow.
Thu, Dec 5, 6:43 PM
alangenfeld updated the diff for D1541: [dagster-graphql] memoize solid handle computation.

rebase

Thu, Dec 5, 1:18 AM
alangenfeld added a reviewer for D1541: [dagster-graphql] memoize solid handle computation: max.
Thu, Dec 5, 12:54 AM
alangenfeld added inline comments to D1541: [dagster-graphql] memoize solid handle computation.
Thu, Dec 5, 12:53 AM
alangenfeld updated the diff for D1541: [dagster-graphql] memoize solid handle computation.

now with working memoization

Thu, Dec 5, 12:52 AM
alangenfeld planned changes to D1541: [dagster-graphql] memoize solid handle computation.

bad

Thu, Dec 5, 12:05 AM

Wed, Dec 4

alangenfeld updated the diff for D1541: [dagster-graphql] memoize solid handle computation.

fixes

Wed, Dec 4, 11:01 PM
alangenfeld requested changes to D1540: Break pipeline explorer and sidebar queries apart, fetch only current solid layer.

fix lint

Wed, Dec 4, 10:50 PM
alangenfeld created D1541: [dagster-graphql] memoize solid handle computation.
Wed, Dec 4, 10:46 PM
alangenfeld committed R1:c75badfb4c11: [graphql] improve solidHandle fields (authored by alangenfeld).
[graphql] improve solidHandle fields
Wed, Dec 4, 9:59 PM
alangenfeld closed D1539: [graphql] improve solidHandle fields.
Wed, Dec 4, 9:58 PM
alangenfeld updated the diff for D1539: [graphql] improve solidHandle fields.

make graphql

Wed, Dec 4, 9:50 PM
alangenfeld updated the diff for D1539: [graphql] improve solidHandle fields.

black

Wed, Dec 4, 9:41 PM
alangenfeld updated the diff for D1539: [graphql] improve solidHandle fields.

parentHandleID

Wed, Dec 4, 9:37 PM
alangenfeld created D1539: [graphql] improve solidHandle fields.
Wed, Dec 4, 9:35 PM
alangenfeld accepted D1538: Print process on dagit load.

chefkiss

Wed, Dec 4, 9:34 PM
alangenfeld accepted D1535: fix graphql playground errors.

goodcatch

Wed, Dec 4, 7:08 PM

Tue, Dec 3

alangenfeld accepted D1534: Fixes for Airflow <> GCS and adding tests.
Tue, Dec 3, 9:46 PM
alangenfeld added a comment to D1533: Core dagster_celery engine.

redfordnod

Tue, Dec 3, 9:32 PM
alangenfeld committed R1:9c6783a1ca32: [nightly] prefix git tag with nightly- (authored by alangenfeld).
[nightly] prefix git tag with nightly-
Tue, Dec 3, 9:11 PM
alangenfeld closed D1532: [nightly] prefix git tag with nightly-.
Tue, Dec 3, 9:11 PM
alangenfeld requested changes to D1494: Add strict mode to pipelines and only initialized required resources.

from in person discussion:

  • move strict mode arg to mode (maybe rename it to describe the behavior of selective instantiation it turns on)
  • remove required_resource_keys from composite solid and resolve that change up through the graphql layer
  • explore cleaner options for providing the information currently handled by solid_def_names_in_execution
Tue, Dec 3, 9:03 PM
alangenfeld committed R1:6d9d4ddc76c6: issue-1947 :: Allow frozenlist and frozendict in check.{opt_,}{list_… (authored by Tim Chan <tim@chan.net>).
issue-1947 :: Allow frozenlist and frozendict in check.{opt_,}{list_…
Tue, Dec 3, 6:44 PM
alangenfeld created D1532: [nightly] prefix git tag with nightly-.
Tue, Dec 3, 6:38 PM
alangenfeld committed R1:0f45e106cd58: [nightly] fix setup.py-s (authored by alangenfeld).
[nightly] fix setup.py-s
Tue, Dec 3, 6:15 PM
alangenfeld closed D1531: [nightly] fix setup.py-s.
Tue, Dec 3, 6:15 PM
alangenfeld created D1531: [nightly] fix setup.py-s.
Tue, Dec 3, 5:40 PM
alangenfeld committed R1:982be3ce75af: nightly: 2019.12.03 (authored by alangenfeld).
nightly: 2019.12.03
Tue, Dec 3, 5:17 PM
alangenfeld committed R1:5f12e6e1e25a: nightly fixes (authored by alangenfeld).
nightly fixes
Tue, Dec 3, 5:17 PM
alangenfeld committed R1:57d34493052f: dagster-prometheus version (authored by alangenfeld).
dagster-prometheus version
Tue, Dec 3, 4:50 PM
alangenfeld committed R1:8cdbf6e0bc1d: [nightly] change versioning scheme (authored by alangenfeld).
[nightly] change versioning scheme
Tue, Dec 3, 4:43 PM
alangenfeld closed D1530: [nightly] change versioning scheme.
Tue, Dec 3, 4:43 PM
alangenfeld abandoned D1422: [exploration] execution server.
Tue, Dec 3, 4:38 PM
alangenfeld abandoned D1366: [RFC] requestPipelineExecution.
Tue, Dec 3, 4:38 PM
alangenfeld abandoned D1297: [RunQueue] LocalComputeQueue.
Tue, Dec 3, 4:38 PM
alangenfeld created D1530: [nightly] change versioning scheme.
Tue, Dec 3, 4:28 PM
alangenfeld accepted D1529: Hang created EnvironmentSchemas off of pipeline definition.

mmm low hanging fruit

Tue, Dec 3, 1:31 AM
alangenfeld accepted D1528: Config schema building perf improvements.

gogogo

Tue, Dec 3, 1:25 AM
alangenfeld added a comment to D1430: Introduce Partition API.

Don't need to block land on me - just throwing some ideas in the mix.

Tue, Dec 3, 12:48 AM

Mon, Dec 2

alangenfeld requested changes to D1430: Introduce Partition API.

to @sashank's queue

Mon, Dec 2, 11:10 PM
alangenfeld added inline comments to D1430: Introduce Partition API.
Mon, Dec 2, 11:07 PM
alangenfeld added a comment to D1494: Add strict mode to pipelines and only initialized required resources.

Do we have an exact game plan for all this yet? I would push for deferring landing anything and trying to jump right to the end state unless there is a clear user need to satisfy.

Mon, Dec 2, 11:00 PM
alangenfeld added a comment to D1494: Add strict mode to pipelines and only initialized required resources.

should there be a test for multiprocess engine / execute plan APIs that ensures unused resources are not instantiated?

Mon, Dec 2, 10:47 PM
alangenfeld requested changes to D1523: Move database interactions from airline demo to dagster-postgres and dagster-aws.

bringing these small utilities in libraries has a breaking-changeable surface area cost associated with it - so we should be thoughtful that the value provided surmounts that cost

Mon, Dec 2, 10:14 PM
alangenfeld accepted D1522: [EMR 2/N] Refresh Spark solid.

if you do want to land any minor breaking changes - make sure to note them in changes.md so we dont lose track

Mon, Dec 2, 10:05 PM
alangenfeld requested changes to D1521: [EMR 1/N] Extract EMR implementation.

unclear whats from mrjob and whats not - sending to your queue for another clean up pass. seems overall fine though

Mon, Dec 2, 9:54 PM
alangenfeld accepted D1519: Add dagster-prometheus.

whynot

Mon, Dec 2, 9:31 PM
alangenfeld accepted D1514: Disable deploy pipeline.

byebye

Mon, Dec 2, 8:25 PM
alangenfeld added a comment to D1512: Add pipe dep operator to easily express serial deps of single input/single output solids.

I have some hesitancy about this - I agree it is valuable but I feel like it makes things more confusing in particular where the function-based invocations meet the piped ones. I understand it since i know how it works - but I don't know of a good way to explain it to someone without just explaining how it works. To frame this feeling in another way - I think the combination of the function based capability and the pipe based capability is less than the sum of both since they combine in an unintuitive way.

Mon, Dec 2, 6:29 PM
alangenfeld requested changes to D1471: Refactor SQL-based event log storages to use SQLAlchemy.

to your queue

Mon, Dec 2, 5:24 PM
alangenfeld added a comment to D1501: Eliminate selector argument from PipelineDefinition.

goodcatch

Mon, Dec 2, 5:22 PM
alangenfeld committed R1:2d85b76fb77b: [airflow] fix error bug (authored by alangenfeld).
[airflow] fix error bug
Mon, Dec 2, 5:08 PM
alangenfeld closed D1525: [airflow] fix error bug.
Mon, Dec 2, 5:08 PM
alangenfeld requested changes to D1520: Alert in Slack on publish failure.

I feel like there has to be a way to get the nightly job to work like the main "Dagster" buildkite pipeline with that existing bot set up

Mon, Dec 2, 5:08 PM
alangenfeld added a comment to D1520: Alert in Slack on publish failure.

can't we just hook up the nightly job to our buildkite slack channel bot?

Mon, Dec 2, 4:58 PM
alangenfeld created D1525: [airflow] fix error bug.
Mon, Dec 2, 4:43 PM

Thu, Nov 28

alangenfeld accepted D1503: Update rtd reqs.

gogogo

Thu, Nov 28, 12:05 AM

Wed, Nov 27

alangenfeld accepted D1498: Allow frozenset in set_param checks.

should probably grab dict/list also - file ticket as "good first issue" if you want to defer it

Wed, Nov 27, 9:44 PM

Tue, Nov 26

alangenfeld accepted D1491: Hygiene: avoid any unexpected consequences of old-style classes..

whynot

Tue, Nov 26, 8:33 PM
alangenfeld accepted D1490: Relax more of our dependencies.

push_n_pray

Tue, Nov 26, 7:16 PM
alangenfeld accepted D1492: Revert D1475 and D1478.

abandon

Tue, Nov 26, 6:18 PM

Mon, Nov 25

alangenfeld added inline comments to D1473: Scaffold alembic.
Mon, Nov 25, 11:29 PM
alangenfeld added inline comments to D1480: Add dagster instance migrate CLI tool.
Mon, Nov 25, 9:28 PM