Page MenuHomePhabricator
Feed Advanced Search

Today

alangenfeld committed R1:e20aa4735326: multiprocessing executor doc block fix (authored by alangenfeld).
multiprocessing executor doc block fix
Tue, Oct 20, 4:41 PM
alangenfeld accepted D4817: Remove executePlan dagster-graphql call.

yeahfuckyeah

Tue, Oct 20, 4:39 PM
alangenfeld added a comment to D4817: Remove executePlan dagster-graphql call.

sobeautiful

Tue, Oct 20, 4:35 PM
alangenfeld created Image Macro "sobeautiful".
Tue, Oct 20, 4:35 PM

Yesterday

alangenfeld added a comment to D4814: rm DagsterKubernetesPodOperator and test infra around it.

As per discussion in the platform lane chat.

Mon, Oct 19, 8:50 PM
alangenfeld added inline comments to D4800: RFC: Add table to track migration of secondary indexes on the event_log table.
Mon, Oct 19, 7:39 PM
alangenfeld closed D4690: [RFC] remove dagster-flyte.
Mon, Oct 19, 7:11 PM
alangenfeld committed R1:404b0c425553: [RFC] remove dagster-flyte (authored by alangenfeld).
[RFC] remove dagster-flyte
Mon, Oct 19, 7:11 PM
alangenfeld added inline comments to D4764: add summary table for asset keys.
Mon, Oct 19, 7:02 PM
alangenfeld added inline comments to D4800: RFC: Add table to track migration of secondary indexes on the event_log table.
Mon, Oct 19, 6:43 PM
alangenfeld added a comment to D4781: RFC: allow optional configuration of parent pipeline solids for subsetted pipeline.

curious for @schrockn's thoughts but i think this is a reasonable amount of damage for the user upside

Mon, Oct 19, 4:44 PM
alangenfeld accepted D4778: default to k8s scheduler, update docs.
Mon, Oct 19, 4:34 PM
alangenfeld added a comment to D4778: default to k8s scheduler, update docs.

I think this will be fine - unless someone deploys this change in a helm upgrade that somehow doesnt take down dagit running cron.

Mon, Oct 19, 4:30 PM
alangenfeld accepted D4769: Use execute_step_with_structured_logs in DagsterDockerOperator.

thankyou

Mon, Oct 19, 4:08 PM

Fri, Oct 16

alangenfeld added inline comments to D4754: Refactor execute_step_with_structured_logs.
Fri, Oct 16, 7:38 PM
alangenfeld added a comment to D4754: Refactor execute_step_with_structured_logs.

if someone upgrade their user code but forgets to update the celery workers - how does this fail? We don't promise cross version compat so i think this "breaking" change is probably ok - as long as it fails in a clear way that someone knows what to do about it

Fri, Oct 16, 7:36 PM
alangenfeld accepted D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.

illallowit

Fri, Oct 16, 6:39 PM

Thu, Oct 15

alangenfeld accepted D4795: Changes for 0.9.15.
Thu, Oct 15, 9:38 PM
alangenfeld published D4795: Changes for 0.9.15 for review.
Thu, Oct 15, 9:38 PM
alangenfeld closed D4736: [RFC] DagsterInstance.optimize_for_dagit.
Thu, Oct 15, 9:08 PM
alangenfeld committed R1:63b02d456bf4: [RFC] DagsterInstance.optimize_for_dagit (authored by alangenfeld).
[RFC] DagsterInstance.optimize_for_dagit
Thu, Oct 15, 9:08 PM
alangenfeld requested changes to D4764: add summary table for asset keys.

your queue - re: conversations around the index opt in

Thu, Oct 15, 8:50 PM
alangenfeld requested changes to D4776: Add grpc-health-probe.

to your queue

Thu, Oct 15, 8:50 PM
alangenfeld updated the diff for D4736: [RFC] DagsterInstance.optimize_for_dagit.

up

Thu, Oct 15, 8:47 PM
alangenfeld closed D4793: grpc generated code.
Thu, Oct 15, 8:24 PM
alangenfeld committed R1:00705e5c2465: grpc generated code (authored by alangenfeld).
grpc generated code
Thu, Oct 15, 8:24 PM
alangenfeld accepted D4789: [dagit] Use parent snapshot ID to determine current-ness of snapshot.
Thu, Oct 15, 7:41 PM
alangenfeld accepted D4790: [dagit] Restore nav height fix for Safari.
Thu, Oct 15, 7:38 PM
alangenfeld updated the diff for D4736: [RFC] DagsterInstance.optimize_for_dagit.

up

Thu, Oct 15, 6:00 PM
alangenfeld updated the diff for D4736: [RFC] DagsterInstance.optimize_for_dagit.

up

Thu, Oct 15, 5:20 PM
alangenfeld updated the diff for D4736: [RFC] DagsterInstance.optimize_for_dagit.

up

Thu, Oct 15, 3:46 PM
alangenfeld updated the diff for D4736: [RFC] DagsterInstance.optimize_for_dagit.

also make psycopg2 gevent friendly

Thu, Oct 15, 3:44 PM
alangenfeld updated the diff for D4736: [RFC] DagsterInstance.optimize_for_dagit.

up

Thu, Oct 15, 3:08 PM
alangenfeld added a comment to D4736: [RFC] DagsterInstance.optimize_for_dagit.

Thu, Oct 15, 2:52 PM
alangenfeld updated the diff for D4736: [RFC] DagsterInstance.optimize_for_dagit.

test assets page - add PythonError

Thu, Oct 15, 2:50 PM
alangenfeld accepted D4771: add prefix to asset key query.

push_n_pray

Thu, Oct 15, 2:22 PM
alangenfeld updated the diff for D4736: [RFC] DagsterInstance.optimize_for_dagit.

up

Thu, Oct 15, 2:18 PM
alangenfeld closed D4783: use instance_for_test on cli tests.
Thu, Oct 15, 2:08 PM
alangenfeld committed R1:bf58946e8adf: use instance_for_test on cli tests (authored by alangenfeld).
use instance_for_test on cli tests
Thu, Oct 15, 2:07 PM

Wed, Oct 14

alangenfeld added inline comments to D4784: [dagit] Allow snapshots to re-run even if the snapshot ID is mismatched.
Wed, Oct 14, 9:45 PM
alangenfeld requested review of D4783: use instance_for_test on cli tests.
Wed, Oct 14, 9:39 PM
alangenfeld accepted D4784: [dagit] Allow snapshots to re-run even if the snapshot ID is mismatched.
Wed, Oct 14, 9:31 PM
alangenfeld added inline comments to D4784: [dagit] Allow snapshots to re-run even if the snapshot ID is mismatched.
Wed, Oct 14, 9:30 PM
alangenfeld requested changes to D4771: add prefix to asset key query.
Wed, Oct 14, 7:58 PM
alangenfeld closed D4772: steps towards getting ECSRunLauncher working.
Wed, Oct 14, 5:31 PM
alangenfeld committed R1:0cbe58e6ea39: steps towards getting ECSRunLauncher working (authored by alangenfeld).
steps towards getting ECSRunLauncher working
Wed, Oct 14, 5:31 PM
alangenfeld accepted D4773: fix graphql errors for runs using int event metadata.
Wed, Oct 14, 5:30 PM
alangenfeld closed D4686: [core] remove execute_run_in_process.
Wed, Oct 14, 5:30 PM
alangenfeld committed R1:66813263dc30: [core] remove execute_run_in_process (authored by alangenfeld).
[core] remove execute_run_in_process
Wed, Oct 14, 5:30 PM
alangenfeld updated the diff for D4686: [core] remove execute_run_in_process.

up

Wed, Oct 14, 5:01 PM
alangenfeld closed D4762: [dagit] change Preparing to Not Executed.
Wed, Oct 14, 4:54 PM
alangenfeld committed R1:81862bc1cc79: [dagit] change Preparing to Not Executed (authored by alangenfeld).
[dagit] change Preparing to Not Executed
Wed, Oct 14, 4:54 PM
alangenfeld updated the diff for D4762: [dagit] change Preparing to Not Executed.

up

Wed, Oct 14, 2:48 PM

Tue, Oct 13

alangenfeld added inline comments to D4764: add summary table for asset keys.
Tue, Oct 13, 10:14 PM
alangenfeld added inline comments to D4764: add summary table for asset keys.
Tue, Oct 13, 10:03 PM
alangenfeld added a reviewer for D4736: [RFC] DagsterInstance.optimize_for_dagit: prha.
Tue, Oct 13, 10:03 PM
alangenfeld requested review of D4772: steps towards getting ECSRunLauncher working.
Tue, Oct 13, 10:02 PM
alangenfeld accepted D4767: [easy] Add integration_tests to make black targets.

illallowit

Tue, Oct 13, 9:53 PM
alangenfeld accepted D4768: back-compat for ObjectStoreOperationResultData.

yaytests

Tue, Oct 13, 9:52 PM
alangenfeld added a comment to D4686: [core] remove execute_run_in_process.

i reached out to known users and they said they were no longer using it

Tue, Oct 13, 9:46 PM
alangenfeld accepted D4723: Get cron schedule from ExternalSchedule rather than the Schedule DB.

ya those discussions dont need to block this diff - I am not certain on the trade offs around losing tick based error reporting for this case, but if you feel good about it you can move forward

Tue, Oct 13, 9:33 PM
alangenfeld accepted D4752: Add postgres DB container to celery docker test, fix api call escaping.

maybe add a CHANGES.md entry about the breaking config changes in this diff so it doesn't get missed

Tue, Oct 13, 7:27 PM
alangenfeld accepted D4766: Delete unnecessary file, fix run row link.

gogo

Tue, Oct 13, 6:15 PM
alangenfeld updated the summary of D4762: [dagit] change Preparing to Not Executed.
Tue, Oct 13, 4:54 PM
alangenfeld requested review of D4762: [dagit] change Preparing to Not Executed.
Tue, Oct 13, 4:26 PM
alangenfeld added inline comments to D4723: Get cron schedule from ExternalSchedule rather than the Schedule DB.
Tue, Oct 13, 3:47 PM
alangenfeld added inline comments to D4752: Add postgres DB container to celery docker test, fix api call escaping.
Tue, Oct 13, 3:38 PM
alangenfeld added a comment to D4729: RFC: Don't require an initial reconciliation step to be able to start schedules that aren't in the schedule DB yet.

seems good to me - add some comments to [1] since its a bit clever whats going on

Tue, Oct 13, 3:36 PM
alangenfeld resigned from D4725: Add execution_timezone field to schedules.

defer to @sashank

Tue, Oct 13, 3:34 PM
alangenfeld added inline comments to D4723: Get cron schedule from ExternalSchedule rather than the Schedule DB.
Tue, Oct 13, 3:33 PM
alangenfeld added a comment to D4752: Add postgres DB container to celery docker test, fix api call escaping.

nice

Tue, Oct 13, 3:22 PM
alangenfeld accepted D4760: fix test_addresses_for_version on windows.

clowntown

Tue, Oct 13, 3:15 PM
alangenfeld published D4760: fix test_addresses_for_version on windows for review.
Tue, Oct 13, 3:15 PM
alangenfeld added a comment to D4709: [dagit] Separate snapshot and current pipeline permalinks.

i like the overall direction - will leave to those with stronger opinions for final choices

Tue, Oct 13, 3:12 PM
alangenfeld resigned from D4709: [dagit] Separate snapshot and current pipeline permalinks.
Tue, Oct 13, 3:12 PM
alangenfeld added inline comments to D4713: This adds a CLI to print the stored versions of each output produced by a pipeline. It can be executed by running `dagster pipeline print_versions <options>`..
Tue, Oct 13, 3:11 PM
alangenfeld updated subscribers of D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.

this week? next week? @catherinewu / @rexledesma do we have telemetry on this at all ?

Tue, Oct 13, 3:10 PM
alangenfeld added inline comments to D4713: This adds a CLI to print the stored versions of each output produced by a pipeline. It can be executed by running `dagster pipeline print_versions <options>`..
Tue, Oct 13, 3:03 PM
alangenfeld added inline comments to D4674: Add liveness probe to extra celery workers.
Tue, Oct 13, 2:47 PM

Mon, Oct 12

alangenfeld retitled D4736: [RFC] DagsterInstance.optimize_for_dagit from RFC [dagster-postgres] connection pooling to [RFC] DagsterInstance.optimize_for_dagit.
Mon, Oct 12, 10:07 PM
alangenfeld updated the diff for D4736: [RFC] DagsterInstance.optimize_for_dagit.

big change - will redo summary

Mon, Oct 12, 10:02 PM
alangenfeld requested changes to D4742: Remove legacy repo format from examples/tests, replace the default with the new standard format except when specifically testing legacy stuff.

This makes sense to land right before 0.10.0 just to put the breaking change in a major release. Ahead of removing support we should probably update all these callsites except for the explicit back compat test

Mon, Oct 12, 8:02 PM
alangenfeld added inline comments to D4671: Make scheduler timezone-aware.
Mon, Oct 12, 7:55 PM
alangenfeld added inline comments to D4671: Make scheduler timezone-aware.
Mon, Oct 12, 5:30 PM
alangenfeld planned changes to D4736: [RFC] DagsterInstance.optimize_for_dagit.
Mon, Oct 12, 5:15 PM

Fri, Oct 9

alangenfeld requested review of D4736: [RFC] DagsterInstance.optimize_for_dagit.

Any idea why we went with NullPool in the first place?

Fri, Oct 9, 3:35 PM

Thu, Oct 8

alangenfeld retitled D4736: [RFC] DagsterInstance.optimize_for_dagit from [dagster-postgres] use default connection pooling to RFC [dagster-postgres] connection pooling.
Thu, Oct 8, 11:09 PM
alangenfeld added a comment to D4736: [RFC] DagsterInstance.optimize_for_dagit.

we might need a concept of long lived vs short lived on DagsterInstance to thread down to these places - this behavior is only really key in dagit's long lived copy

Thu, Oct 8, 11:08 PM
alangenfeld requested review of D4736: [RFC] DagsterInstance.optimize_for_dagit.
Thu, Oct 8, 10:43 PM
alangenfeld committed R1:1c210615952b: [Docs] 0.9.14 (authored by alangenfeld).
[Docs] 0.9.14
Thu, Oct 8, 9:22 PM
alangenfeld committed R1:99f6540b1e3e: 0.9.14 (authored by alangenfeld).
0.9.14
Thu, Oct 8, 8:54 PM
alangenfeld accepted D4734: Helm pass userdeployment port.
Thu, Oct 8, 8:27 PM
alangenfeld published D4734: Helm pass userdeployment port for review.
Thu, Oct 8, 8:27 PM
alangenfeld committed R1:16df48cfbedd: 0.9.14.pre0 (authored by alangenfeld).
0.9.14.pre0
Thu, Oct 8, 8:12 PM
alangenfeld closed D4732: 0.9.14 release notes.
Thu, Oct 8, 8:10 PM
alangenfeld committed R1:27135a2c2cce: 0.9.14 release notes (authored by alangenfeld).
0.9.14 release notes
Thu, Oct 8, 8:10 PM
alangenfeld requested review of D4728: [docs] execution overview.
Thu, Oct 8, 7:35 PM
alangenfeld closed D4712: [dagit] print operation times.
Thu, Oct 8, 4:45 PM
alangenfeld committed R1:d3b090fdee43: [dagit] print operation times (authored by alangenfeld).
[dagit] print operation times
Thu, Oct 8, 4:45 PM
alangenfeld updated the diff for D4712: [dagit] print operation times.

use feature flag to gate debug console logging

Thu, Oct 8, 3:57 PM