Page MenuHomeElementl
Feed Advanced Search

May 25 2021

rexledesma added a reviewer for D8099: Add the mode's available resources to error message if resource requirements check fails: cdecarolis.
May 25 2021, 11:50 PM
rexledesma published D8099: Add the mode's available resources to error message if resource requirements check fails for review.
May 25 2021, 11:50 PM
rexledesma requested review of D8100: Add Helm directory to black.
May 25 2021, 10:06 PM
rexledesma accepted D8080: Add a way to run the python graphql client against the existing graphql_context fixtures (using the real graphql schema).
May 25 2021, 7:15 PM
rexledesma accepted D8083: Fix python client backcompat tests.
May 25 2021, 6:28 PM
rexledesma closed D8075: Add docs for managing separate Helm deployments for user code.
May 25 2021, 5:25 PM
rexledesma committed R1:778e4f357c32: Add docs for managing separate Helm deployments for user code (authored by rexledesma).
Add docs for managing separate Helm deployments for user code
May 25 2021, 5:25 PM
rexledesma updated the diff for D8075: Add docs for managing separate Helm deployments for user code.

up

May 25 2021, 5:24 PM
rexledesma closed D8074: Add docs for managing an external postgresql secret in Helm.
May 25 2021, 5:24 PM
rexledesma committed R1:eba7b41ad43a: Add docs for managing an external postgresql secret in Helm (authored by rexledesma).
Add docs for managing an external postgresql secret in Helm
May 25 2021, 5:24 PM
rexledesma accepted D8066: Dagit read-only k8s service.
May 25 2021, 5:08 PM
rexledesma added a comment to D8074: Add docs for managing an external postgresql secret in Helm.

good idea. added a reference to using a secret manager like Vault

May 25 2021, 5:02 PM
rexledesma updated the diff for D8074: Add docs for managing an external postgresql secret in Helm.

+johann

May 25 2021, 5:01 PM
rexledesma closed D8073: Add Artifacthub url to release message.
May 25 2021, 4:55 PM
rexledesma committed R1:c84e11656204: Add Artifacthub url to release message (authored by rexledesma).
Add Artifacthub url to release message
May 25 2021, 4:55 PM
rexledesma updated the diff for D8075: Add docs for managing separate Helm deployments for user code.

up

May 25 2021, 4:55 PM
rexledesma requested review of D8075: Add docs for managing separate Helm deployments for user code.
May 25 2021, 2:37 PM
rexledesma requested review of D8074: Add docs for managing an external postgresql secret in Helm.
May 25 2021, 7:44 AM
rexledesma requested review of D8073: Add Artifacthub url to release message.
May 25 2021, 6:38 AM

May 24 2021

rexledesma requested changes to D8066: Dagit read-only k8s service.

We should add template tests to ensure that two services are created when .Values.dagit.enableReadOnly is turned on

May 24 2021, 10:35 PM

May 21 2021

rexledesma added inline comments to D7981: Fix inclusion of partitions mapped from execution time.
May 21 2021, 5:52 PM
rexledesma abandoned D7654: [3/n] Thread schedule decorator parameters to partition parameters.

Abandoned in favor of D7981

May 21 2021, 7:07 AM

May 20 2021

rexledesma requested review of D7981: Fix inclusion of partitions mapped from execution time.
May 20 2021, 8:04 PM

May 19 2021

rexledesma added inline comments to D7976: Save partition offset in partition parameters.
May 19 2021, 10:14 PM
rexledesma closed D7987: Create alerting graphql events from event record.
May 19 2021, 6:50 PM
rexledesma committed R1:c07b5d02b0e3: Create alerting graphql events from event record (authored by rexledesma).
Create alerting graphql events from event record
May 19 2021, 6:50 PM
rexledesma requested review of D7987: Create alerting graphql events from event record.
May 19 2021, 4:42 PM
rexledesma requested review of D7976: Save partition offset in partition parameters.
May 19 2021, 2:07 AM
rexledesma updated the diff for D7654: [3/n] Thread schedule decorator parameters to partition parameters.

rebase

May 19 2021, 2:04 AM

May 18 2021

rexledesma accepted D7947: dagster-graphql custom transport and execution tags.

landable, but note validate tags in an issue if you choose not to resolve it here

May 18 2021, 6:05 PM
rexledesma requested changes to D7947: dagster-graphql custom transport and execution tags.
May 18 2021, 2:28 AM

May 17 2021

rexledesma closed D7642: Add exhaustive check for mypy.
May 17 2021, 9:52 PM
rexledesma committed R1:3d0c3cb0b196: Add exhaustive check for mypy (authored by rexledesma).
Add exhaustive check for mypy
May 17 2021, 9:52 PM
rexledesma retitled D7621: [RFC] Construct partitions using serializable parameters from [2/n][RFC] Construct partitions using user specified parameters to [RFC] Construct partitions using serializable parameters.
May 17 2021, 9:46 PM
rexledesma retitled D7642: Add exhaustive check for mypy from [1/n] Add exhaustive check for mypy to Add exhaustive check for mypy.
May 17 2021, 9:45 PM
rexledesma updated the diff for D7621: [RFC] Construct partitions using serializable parameters.

rebase

May 17 2021, 9:45 PM
rexledesma updated the diff for D7642: Add exhaustive check for mypy.

up

May 17 2021, 8:53 PM
rexledesma closed D7935: Add more retries for Helm tests.
May 17 2021, 5:41 PM
rexledesma committed R1:117d734e8447: Add more retries for Helm tests (authored by rexledesma).
Add more retries for Helm tests
May 17 2021, 5:41 PM
rexledesma closed D7923: Add documentation for Dagster Helm Chart versioning.
May 17 2021, 4:21 PM
rexledesma committed R1:69c635a60637: Add documentation for Dagster Helm Chart versioning (authored by rexledesma).
Add documentation for Dagster Helm Chart versioning
May 17 2021, 4:21 PM

May 14 2021

rexledesma requested review of D7923: Add documentation for Dagster Helm Chart versioning.
May 14 2021, 8:49 PM

May 12 2021

rexledesma closed D7868: Add Dagster alert events.
May 12 2021, 9:44 PM
rexledesma committed R1:a2181ff36e38: Add Dagster alert events (authored by rexledesma).
Add Dagster alert events
May 12 2021, 9:44 PM
rexledesma updated the diff for D7868: Add Dagster alert events.

rebase

May 12 2021, 9:06 PM
rexledesma added a comment to D7868: Add Dagster alert events.

@yuhan The call site would be in the monitoring daemon. Initially this was for the prototype, which is why ALERT_FAILURE was not included, but will do so now.

May 12 2021, 5:50 PM

May 11 2021

rexledesma requested review of D7868: Add Dagster alert events.
May 11 2021, 8:11 PM
rexledesma accepted D7847: [dagster-graphql][client] Fixing `reload_repository_location` and `submit_pipeline_execution`.
May 11 2021, 5:40 PM

May 10 2021

rexledesma requested changes to D7847: [dagster-graphql][client] Fixing `reload_repository_location` and `submit_pipeline_execution`.
May 10 2021, 11:02 PM

May 6 2021

rexledesma updated subscribers of D7476: monitor sensor prototype.
May 6 2021, 4:04 PM

May 5 2021

rexledesma accepted D7714: Add documentation for manually scheduling partition, adding to a repo.

couple of nits, looks great overall!

May 5 2021, 11:11 AM
rexledesma requested changes to D7714: Add documentation for manually scheduling partition, adding to a repo.
May 5 2021, 4:11 AM

May 3 2021

rexledesma closed D7707: Fix daemon liveness check command.
May 3 2021, 10:21 PM
rexledesma committed R1:74c7ff73739d: Fix daemon liveness check command (authored by rexledesma).
Fix daemon liveness check command
May 3 2021, 10:21 PM
rexledesma updated the diff for D7707: Fix daemon liveness check command.

up

May 3 2021, 10:20 PM
rexledesma published D7707: Fix daemon liveness check command for review.
May 3 2021, 10:16 PM
rexledesma resigned from D7665: Scaffold networking and load balancer for example ECS deployment.

following along and looks good, but will defer to johann for final signoff

May 3 2021, 5:24 PM

Apr 30 2021

rexledesma closed D7655: [mypy] repository_location.py.
Apr 30 2021, 3:13 AM
rexledesma committed R1:50db1e33943a: [mypy] repository_location.py (authored by rexledesma).
[mypy] repository_location.py
Apr 30 2021, 3:13 AM

Apr 29 2021

rexledesma accepted D7664: Add ability for a partition selector to return multiple partitions.
Apr 29 2021, 9:09 PM
rexledesma added a comment to D7621: [RFC] Construct partitions using serializable parameters.

might have to go to the drawing board to decouple partition sets from schedules... (i.e. how can we make partition sets that are not explicitly tied to one of our built in schedules?)

Apr 29 2021, 5:56 PM
rexledesma requested review of D7655: [mypy] repository_location.py.
Apr 29 2021, 6:02 AM
rexledesma requested review of D7654: [3/n] Thread schedule decorator parameters to partition parameters.
Apr 29 2021, 4:48 AM
rexledesma updated the diff for D7621: [RFC] Construct partitions using serializable parameters.

up

Apr 29 2021, 1:42 AM
rexledesma closed D7644: Fix typo in monthly schedule decorator.
Apr 29 2021, 1:11 AM
rexledesma committed R1:ed918eb165ad: Fix typo in monthly schedule decorator (authored by rexledesma).
Fix typo in monthly schedule decorator
Apr 29 2021, 1:11 AM
rexledesma retitled D7621: [RFC] Construct partitions using serializable parameters from [RFC] Construct partitions using user specified parameters to [2/n][RFC] Construct partitions using user specified parameters.
Apr 29 2021, 1:10 AM
rexledesma retitled D7642: Add exhaustive check for mypy from Add exhaustive check for mypy to [1/n] Add exhaustive check for mypy.
Apr 29 2021, 1:10 AM
rexledesma updated the summary of D7621: [RFC] Construct partitions using serializable parameters.
Apr 29 2021, 1:07 AM
rexledesma published D7621: [RFC] Construct partitions using serializable parameters for review.
Apr 29 2021, 1:05 AM

Apr 28 2021

rexledesma requested review of D7644: Fix typo in monthly schedule decorator.
Apr 28 2021, 9:44 PM
rexledesma published D7642: Add exhaustive check for mypy for review.
Apr 28 2021, 8:22 PM
rexledesma closed D7590: Remove unused partition functions.
Apr 28 2021, 4:28 AM
rexledesma committed R1:ac621c5310d2: Remove unused partition functions (authored by rexledesma).
Remove unused partition functions
Apr 28 2021, 4:28 AM

Apr 27 2021

rexledesma accepted D7586: Remove get_test_helm_namespace.
Apr 27 2021, 12:33 AM
rexledesma accepted D7585: Extract configmap, aws_configmap, and secret.
Apr 27 2021, 12:31 AM
rexledesma accepted D7584: Remove _helm_namespace_helper.
Apr 27 2021, 12:26 AM
rexledesma accepted D7602: [dagster-postgres] [easy] Quick fix in listen/notify logic.
Apr 27 2021, 12:25 AM
rexledesma accepted D7583: Extract namespace fixture.

just one comment

Apr 27 2021, 12:24 AM

Apr 26 2021

rexledesma accepted D7504: [docs] Dagster GraphQL Python Client [4/4].

The API docs for https://dagster-git-sid-python-client-elementl.vercel.app/master/_apidocs/libraries/dagster-graphql#dagster_graphql.DagsterGraphQLClient.reload_repository_location look like they need formatting, but everything else looks great

Apr 26 2021, 7:30 PM

Apr 23 2021

rexledesma requested review of D7590: Remove unused partition functions.
Apr 23 2021, 11:18 PM
rexledesma accepted D7580: Use pytestconfig fixture instead of request.
Apr 23 2021, 11:07 PM
rexledesma accepted D7582: Extract should_cleanup fixture.
Apr 23 2021, 11:07 PM
rexledesma requested changes to D7583: Extract namespace fixture.
Apr 23 2021, 11:04 PM
rexledesma accepted D7581: Get helm fixtures as a pytest plugin.

oooh did not know about this, neat

Apr 23 2021, 11:04 PM
rexledesma accepted D7568: Allow user deployment startup probes to be disabled in helm charts.

minor comments

Apr 23 2021, 11:02 PM
rexledesma added inline comments to D7583: Extract namespace fixture.
Apr 23 2021, 10:18 PM
rexledesma closed D7552: Add types to graphql workspace context.
Apr 23 2021, 6:09 PM
rexledesma committed R1:fc0128a56ae4: Add types to graphql workspace context (authored by rexledesma).
Add types to graphql workspace context
Apr 23 2021, 6:09 PM
rexledesma updated the diff for D7552: Add types to graphql workspace context.

up

Apr 23 2021, 2:01 AM
rexledesma closed D7550: Make Workspace subclass IWorkspace.
Apr 23 2021, 2:01 AM
rexledesma committed R1:2ffa67491784: Make Workspace subclass IWorkspace (authored by rexledesma).
Make Workspace subclass IWorkspace
Apr 23 2021, 2:00 AM

Apr 22 2021

rexledesma updated the diff for D7552: Add types to graphql workspace context.

up

Apr 22 2021, 9:32 PM
rexledesma updated the diff for D7550: Make Workspace subclass IWorkspace.

rebase

Apr 22 2021, 8:46 PM
rexledesma accepted D7560: Allow dagit startup probes to be disabled in helm charts.
Apr 22 2021, 8:39 PM
rexledesma accepted D7561: Allow daemon startup probes to be disabled in helm charts.
Apr 22 2021, 8:38 PM
rexledesma requested changes to D7504: [docs] Dagster GraphQL Python Client [4/4].

Restructure docs to have same format as other pages (Relevant APIs, Overview, Examples, etc)

Apr 22 2021, 8:20 PM
rexledesma added inline comments to D7561: Allow daemon startup probes to be disabled in helm charts.
Apr 22 2021, 8:17 PM
rexledesma requested changes to D7560: Allow dagit startup probes to be disabled in helm charts.

same comments from https://dagster.phacility.com/D7561

Apr 22 2021, 7:52 PM
rexledesma requested changes to D7561: Allow daemon startup probes to be disabled in helm charts.

need to update pydantic models and json schema

Apr 22 2021, 7:51 PM