Page MenuHomePhabricator
Feed Advanced Search

Fri, Jan 22

max closed D6114: Dagstermill CLI housekeeping.
Fri, Jan 22, 7:43 PM
max committed R1:9bc5d4b985da: Dagstermill CLI housekeeping (authored by max).
Dagstermill CLI housekeeping
Fri, Jan 22, 7:43 PM
max closed D6113: Repin ipykernel.
Fri, Jan 22, 7:39 PM
max committed R1:3e75d33befd6: Repin ipykernel (authored by max).
Repin ipykernel
Fri, Jan 22, 7:39 PM
max requested review of D6114: Dagstermill CLI housekeeping.
Fri, Jan 22, 7:29 PM
max requested review of D6113: Repin ipykernel.
Fri, Jan 22, 7:28 PM
max closed D6099: Rename tests.
Fri, Jan 22, 5:28 PM
max committed R1:dd2c9f05751e: Rename tests (authored by max).
Rename tests
Fri, Jan 22, 5:28 PM
max requested review of D6099: Rename tests.
Fri, Jan 22, 1:21 AM
max added inline comments to D5934: file IO manager.
Fri, Jan 22, 1:09 AM

Thu, Jan 21

max closed D6052: Actually document breaking change to Dagstermill.
Thu, Jan 21, 6:35 PM
max committed R1:bcf5f5b43d78: Actually document breaking change to Dagstermill (authored by max).
Actually document breaking change to Dagstermill
Thu, Jan 21, 6:35 PM

Wed, Jan 20

max closed D6064: Document the file managers.
Wed, Jan 20, 8:02 PM
max committed R1:7a0477bed174: Document the file managers (authored by max).
Document the file managers
Wed, Jan 20, 8:02 PM
max accepted D6065: [docs] Fix relative path of literalinclude in celery_k8s_job_executor docstring.
Wed, Jan 20, 8:01 PM
max added a comment to D6036: Make type_check_fn optional on DagsterType.

Can't dispatch in an IO manager be based on the Python type of an object?

Wed, Jan 20, 7:04 PM
max published D6064: Document the file managers for review.
Wed, Jan 20, 6:33 PM
max added inline comments to D6052: Actually document breaking change to Dagstermill.
Wed, Jan 20, 6:32 PM
max requested review of D6052: Actually document breaking change to Dagstermill.
Wed, Jan 20, 12:36 AM
max abandoned D6047: 8/ Miscellaneous Dagstermill cleanup.
Wed, Jan 20, 12:31 AM

Tue, Jan 19

max requested review of D6047: 8/ Miscellaneous Dagstermill cleanup.
Tue, Jan 19, 10:46 PM

Fri, Jan 15

max closed D6021: Changelog nits.
Fri, Jan 15, 12:21 AM
max committed R1:facf5fbc6ec7: Changelog nits (authored by max).
Changelog nits
Fri, Jan 15, 12:21 AM

Thu, Jan 14

max closed D6011: Remove dangling references to SystemStorageDefinition.
Thu, Jan 14, 9:54 PM
max committed R1:6efa3265a688: Remove dangling references to SystemStorageDefinition (authored by max).
Remove dangling references to SystemStorageDefinition
Thu, Jan 14, 9:53 PM
max requested review of D6011: Remove dangling references to SystemStorageDefinition.
Thu, Jan 14, 9:22 PM
max closed D6008: Revert "Deprecate FileManager and FileHandle #3535".
Thu, Jan 14, 8:45 PM
max added a reverting change for R1:54fcccbb0ae4: Deprecate FileManager and FileHandle #3535: R1:03883d6d98c9: Revert "Deprecate FileManager and FileHandle #3535".
Thu, Jan 14, 8:45 PM
max added a reverting change for D5981: Deprecate FileManager and FileHandle #3535: R1:03883d6d98c9: Revert "Deprecate FileManager and FileHandle #3535".
Thu, Jan 14, 8:45 PM
max committed R1:03883d6d98c9: Revert "Deprecate FileManager and FileHandle #3535" (authored by max).
Revert "Deprecate FileManager and FileHandle #3535"
Thu, Jan 14, 8:45 PM
max requested review of D6008: Revert "Deprecate FileManager and FileHandle #3535".
Thu, Jan 14, 8:42 PM
max added a reverting change for D5981: Deprecate FileManager and FileHandle #3535: D6008: Revert "Deprecate FileManager and FileHandle #3535".
Thu, Jan 14, 8:24 PM
max added a reverting change for R1:54fcccbb0ae4: Deprecate FileManager and FileHandle #3535: D6008: Revert "Deprecate FileManager and FileHandle #3535".
Thu, Jan 14, 8:24 PM

Wed, Jan 13

max closed D5973: 7/ Fix solid_config fetching.
Wed, Jan 13, 10:32 PM
max committed R1:a9404278c77c: 7/ Fix solid_config fetching (authored by max).
7/ Fix solid_config fetching
Wed, Jan 13, 10:32 PM
max updated the diff for D5973: 7/ Fix solid_config fetching.

rebase

Wed, Jan 13, 9:19 PM
max closed D5972: 6/ Add type annotations to Dagstermill context.
Wed, Jan 13, 9:17 PM
max committed R1:8ba51c685409: 6/ Add type annotations to Dagstermill context (authored by max).
6/ Add type annotations to Dagstermill context
Wed, Jan 13, 9:17 PM
max closed D5971: 5/ Upgrade moto.
Wed, Jan 13, 9:17 PM
max committed R1:681de2fb493e: 5/ Upgrade moto (authored by max).
5/ Upgrade moto
Wed, Jan 13, 9:17 PM
max closed D5970: 4/ Clarify return types and interfaces.
Wed, Jan 13, 9:16 PM
max committed R1:4f5f41ec9823: 4/ Clarify return types and interfaces (authored by max).
4/ Clarify return types and interfaces
Wed, Jan 13, 9:16 PM
max added inline comments to D5970: 4/ Clarify return types and interfaces.
Wed, Jan 13, 9:16 PM
max closed D5969: 3/ Modernize pandas example.
Wed, Jan 13, 9:14 PM
max committed R1:33eef2f2b177: 3/ Modernize pandas example (authored by max).
3/ Modernize pandas example
Wed, Jan 13, 9:14 PM
max closed D5968: 2/ Modernize examples.
Wed, Jan 13, 9:12 PM
max committed R1:08511080ba22: 2/ Modernize examples (authored by max).
2/ Modernize examples
Wed, Jan 13, 9:12 PM
max requested review of D5973: 7/ Fix solid_config fetching.
Wed, Jan 13, 8:24 PM
max closed D5963: 1/ Modernize airline_demo setup.
Wed, Jan 13, 8:24 PM
max committed R1:1ffcc61509d8: 1/ Modernize airline_demo setup (authored by max).
1/ Modernize airline_demo setup
Wed, Jan 13, 8:23 PM
max requested review of D5972: 6/ Add type annotations to Dagstermill context.
Wed, Jan 13, 8:23 PM
max requested review of D5971: 5/ Upgrade moto.

Spurious unrelated test failures

Wed, Jan 13, 8:22 PM
max requested review of D5970: 4/ Clarify return types and interfaces.
Wed, Jan 13, 8:09 PM
max requested review of D5969: 3/ Modernize pandas example.
Wed, Jan 13, 8:01 PM
max requested review of D5968: 2/ Modernize examples.
Wed, Jan 13, 7:58 PM
max updated the diff for D5963: 1/ Modernize airline_demo setup.

storage defs

Wed, Jan 13, 7:56 PM
max updated the diff for D5963: 1/ Modernize airline_demo setup.

comments

Wed, Jan 13, 7:46 PM
max requested review of D5963: 1/ Modernize airline_demo setup.
Wed, Jan 13, 7:33 PM
max abandoned D5829: Modernize dagstermill file handling.
Wed, Jan 13, 7:05 PM
max added a comment to D5829: Modernize dagstermill file handling.

feels like we have broad agreement on this approach, going to abandon this diff and open a stack

Wed, Jan 13, 7:04 PM
max updated the diff for D5829: Modernize dagstermill file handling.

up

Wed, Jan 13, 5:52 PM
max updated the diff for D5829: Modernize dagstermill file handling.

root_manager_key

Wed, Jan 13, 5:31 PM
max updated the diff for D5829: Modernize dagstermill file handling.

nits

Wed, Jan 13, 5:19 PM
max updated the diff for D5829: Modernize dagstermill file handling.

fixup

Wed, Jan 13, 5:13 PM

Tue, Jan 12

max added inline comments to D5829: Modernize dagstermill file handling.
Tue, Jan 12, 11:04 PM
max accepted D5929: py2 cleanup: remove misc uses of future.
Tue, Jan 12, 8:03 PM
max added a comment to D5929: py2 cleanup: remove misc uses of future.

grrrrrrreat

Tue, Jan 12, 8:03 PM
max added a comment to D5829: Modernize dagstermill file handling.

@alangenfeld I've reorganized and broken up the solid compute function logic to be more readable, and added support for fan-in inputs

Tue, Jan 12, 7:32 PM
max updated the diff for D5829: Modernize dagstermill file handling.

adds test for fan-in

Tue, Jan 12, 7:27 PM
max accepted D5920: remove legacy repository.yaml support.

hooray!!

Tue, Jan 12, 4:58 PM
max added a comment to D5780: eliminate Persistable.

i will defer to alex on this; maybe i should just mention that i continue to suspect that we might be well served by adopting the pickle protocol (__getnewargs_ex__/__getstate__/__setstate__)

Tue, Jan 12, 4:57 PM
max accepted D5852: mypy everything (almost).
Tue, Jan 12, 4:52 PM

Mon, Jan 11

max planned changes to D5829: Modernize dagstermill file handling.
Mon, Jan 11, 11:14 PM
max updated the diff for D5829: Modernize dagstermill file handling.

test

Mon, Jan 11, 10:58 PM
max planned changes to D5829: Modernize dagstermill file handling.
Mon, Jan 11, 10:53 PM
max updated the diff for D5829: Modernize dagstermill file handling.

defn

Mon, Jan 11, 10:49 PM
max updated the diff for D5829: Modernize dagstermill file handling.

tests

Mon, Jan 11, 10:47 PM
max updated the diff for D5829: Modernize dagstermill file handling.

cfg

Mon, Jan 11, 10:43 PM
max planned changes to D5829: Modernize dagstermill file handling.
Mon, Jan 11, 10:26 PM
max updated the diff for D5829: Modernize dagstermill file handling.

nits

Mon, Jan 11, 10:25 PM
max planned changes to D5829: Modernize dagstermill file handling.
Mon, Jan 11, 10:23 PM
max updated the diff for D5829: Modernize dagstermill file handling.

test fix

Mon, Jan 11, 10:21 PM
max planned changes to D5829: Modernize dagstermill file handling.
Mon, Jan 11, 10:13 PM
max updated the diff for D5829: Modernize dagstermill file handling.

nits

Mon, Jan 11, 10:13 PM
max planned changes to D5829: Modernize dagstermill file handling.
Mon, Jan 11, 10:09 PM
max updated the diff for D5829: Modernize dagstermill file handling.

nits

Mon, Jan 11, 10:08 PM
max planned changes to D5829: Modernize dagstermill file handling.
Mon, Jan 11, 10:00 PM
max updated the diff for D5829: Modernize dagstermill file handling.

reorg for clarity

Mon, Jan 11, 10:00 PM
max planned changes to D5829: Modernize dagstermill file handling.
Mon, Jan 11, 6:03 PM
max updated the diff for D5829: Modernize dagstermill file handling.

api change

Mon, Jan 11, 6:00 PM
max planned changes to D5829: Modernize dagstermill file handling.
Mon, Jan 11, 5:55 PM
max updated the diff for D5829: Modernize dagstermill file handling.

rebase & nits

Mon, Jan 11, 5:55 PM

Fri, Jan 8

max requested review of D5829: Modernize dagstermill file handling.
Fri, Jan 8, 9:29 PM

Wed, Jan 6

max closed D5747: Type hints for check.
Wed, Jan 6, 10:07 PM
max committed R1:585c4d790332: Type hints for check (authored by max).
Type hints for check
Wed, Jan 6, 10:07 PM
max updated the diff for D5747: Type hints for check.

rebase

Wed, Jan 6, 9:21 PM
max abandoned D5764: Run mypy on dagster core.
Wed, Jan 6, 8:29 PM
max accepted D5768: mypy.

Macro 2chainz:

Wed, Jan 6, 8:27 PM
max updated the diff for D5764: Run mypy on dagster core.

rebase

Wed, Jan 6, 1:20 AM
max added inline comments to D5764: Run mypy on dagster core.
Wed, Jan 6, 1:18 AM