Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Yesterday

max added a comment to D1281: Allow custom type_check on PythonObjectType.

I went back and forth on this, and it may make sense to actually have both facilities. Ultimately the thought I had in mind settling on this was that I might want to replace the instanceof check with some kind of duck type check -- for instance if either of two types is acceptable, or if any time implementing some interface is acceptable, but they don't inherit from a common base class. I don't think that we want people directly implementing a subclass of RuntimeType in that case -- it makes more sense to decorate a noop class of their own with @dagster_type.

Tue, Oct 15, 6:39 PM
max created D1289: Loosen enum-compat to >=0.0.1.
Tue, Oct 15, 2:24 PM
max accepted D1285: [airline demo] update guide for python 3 req.
Tue, Oct 15, 1:16 AM

Mon, Oct 14

max accepted D1283: Update wording for py3 suggestion in docs.

Lol much better.

Mon, Oct 14, 11:17 PM
max created D1281: Allow custom type_check on PythonObjectType.
Mon, Oct 14, 6:40 PM
max updated the diff for D1273: Improve type inference.

Rebase

Mon, Oct 14, 6:38 PM
max added a comment to D1273: Improve type inference.
In D1273#30664, @alangenfeld wrote:

Given that we currently don't catch custom types having serialization problems til runtime - this feature could make it very easy to accidentally introduce a problematic output to a solid in a big pipeline and not catch it til N hours in to the job when it fails. Am I mistaken and we catch these errors earlier? If not I think it would be better to add that safeguard in place before we auto up new types this aggressively.

Mon, Oct 14, 6:00 PM
max updated the diff for D1273: Improve type inference.

Eliminate nonce

Mon, Oct 14, 5:59 PM
max updated the diff for D1273: Improve type inference.
  • Nits
Mon, Oct 14, 5:56 PM
max updated the diff for D1273: Improve type inference.
  • Nits
Mon, Oct 14, 5:32 PM
max updated the diff for D1273: Improve type inference.
  • Nits
Mon, Oct 14, 5:09 PM
max updated the diff for D1273: Improve type inference.
  • Nits
Mon, Oct 14, 4:47 PM
max updated the diff for D1273: Improve type inference.
  • Nits
Mon, Oct 14, 4:46 PM

Sun, Oct 13

max updated the diff for D1273: Improve type inference.
  • Nits
Sun, Oct 13, 8:12 PM

Sat, Oct 12

max added inline comments to D1273: Improve type inference.
Sat, Oct 12, 10:17 PM
max updated the diff for D1273: Improve type inference.

Up

Sat, Oct 12, 12:27 AM
max added reviewers for D1273: Improve type inference: schrockn, alangenfeld, Restricted Project.
Sat, Oct 12, 12:26 AM
max created D1273: Improve type inference.
Sat, Oct 12, 12:15 AM

Thu, Oct 10

max abandoned D1257: Fixes for @solid documentation.
Thu, Oct 10, 5:16 PM

Wed, Oct 9

max created D1257: Fixes for @solid documentation.
Wed, Oct 9, 8:59 PM
max added inline comments to D1254: Refresh installation docs.
Wed, Oct 9, 8:59 PM
max updated the diff for D1254: Refresh installation docs.

Remove tautology

Wed, Oct 9, 8:09 PM
max created D1254: Refresh installation docs.
Wed, Oct 9, 6:55 PM
max created D1252: Add test demonstrating input injection for List[String].
Wed, Oct 9, 5:17 PM

Tue, Oct 8

max accepted D1247: DagsterExecutionStepNotFoundError report all missing steps.
Tue, Oct 8, 8:53 PM

Mon, Oct 7

max created D1244: Reenable disabled examples.
Mon, Oct 7, 11:58 PM
max created D1241: Warn instead of raising when we can't parse a schedule definition.
Mon, Oct 7, 9:54 PM
max updated the diff for D1239: Fixes for dbt/werkzeug version conflict.

Nits

Mon, Oct 7, 9:05 PM
max added a comment to D1225: Preserve folded YAML sections in the config editor.

What happens when two pipelines in different repositories share the same name?

Mon, Oct 7, 8:25 PM
max created D1239: Fixes for dbt/werkzeug version conflict.
Mon, Oct 7, 8:22 PM

Fri, Oct 4

max accepted D1209: Fix issue with dagster-aws CLI installs.
Fri, Oct 4, 12:36 AM
max created D1208: Disable pipenv tests for releases.
Fri, Oct 4, 12:18 AM
max accepted D1206: Update deployment docs.
Fri, Oct 4, 12:16 AM

Thu, Oct 3

max accepted D1205: Loosen dep of pandas from dagster-pandas.
Thu, Oct 3, 11:48 PM
max updated the diff for D1178: Order by id.

Black

Thu, Oct 3, 6:55 PM
max updated the diff for D1176: Simplify init.

Black

Thu, Oct 3, 6:54 PM
max updated the diff for D1178: Order by id.

Rebase

Thu, Oct 3, 6:52 PM
max updated the diff for D1176: Simplify init.

Rebase

Thu, Oct 3, 6:52 PM
max updated the diff for D1151: Configable Postgres-backed DagsterInstance.

Rebase

Thu, Oct 3, 6:43 PM
max updated the diff for D1174: Document the ConfigurableClass machinery.

Rebase

Thu, Oct 3, 6:39 PM
max updated the diff for D1151: Configable Postgres-backed DagsterInstance.

Up

Thu, Oct 3, 6:37 PM
max added inline comments to D1151: Configable Postgres-backed DagsterInstance.
Thu, Oct 3, 6:34 PM
max updated the diff for D1178: Order by id.

Up

Thu, Oct 3, 6:25 PM
max updated the diff for D1176: Simplify init.

Nits

Thu, Oct 3, 6:24 PM
max updated the diff for D1174: Document the ConfigurableClass machinery.

Black

Thu, Oct 3, 6:22 PM
max updated the diff for D1173: Document Postgres-backed instance.

Rework

Thu, Oct 3, 6:21 PM
max updated the diff for D1151: Configable Postgres-backed DagsterInstance.

Nits

Thu, Oct 3, 6:16 PM
max added inline comments to D1151: Configable Postgres-backed DagsterInstance.
Thu, Oct 3, 6:10 PM
max updated the diff for D1176: Simplify init.

Up

Thu, Oct 3, 3:43 PM
max created D1178: Order by id.
Thu, Oct 3, 2:04 AM
max added inline comments to D1151: Configable Postgres-backed DagsterInstance.
Thu, Oct 3, 1:58 AM
max updated the diff for D1176: Simplify init.

Sigs

Thu, Oct 3, 1:08 AM
max created D1176: Simplify init.
Thu, Oct 3, 1:03 AM
max created D1174: Document the ConfigurableClass machinery.
Thu, Oct 3, 12:30 AM

Wed, Oct 2

max accepted D1171: Load scheduled job into execution console.

ooooh

Wed, Oct 2, 11:37 PM
max updated the summary of D1151: Configable Postgres-backed DagsterInstance.
Wed, Oct 2, 11:34 PM
max updated the diff for D1151: Configable Postgres-backed DagsterInstance.

Rebase

Wed, Oct 2, 11:28 PM
max updated the diff for D1151: Configable Postgres-backed DagsterInstance.

Nits

Wed, Oct 2, 11:14 PM
max created D1173: Document Postgres-backed instance.
Wed, Oct 2, 11:11 PM
max accepted D1166: [docs] instance.
Wed, Oct 2, 11:04 PM
max added inline comments to D1166: [docs] instance.
Wed, Oct 2, 11:03 PM
max updated the summary of D1151: Configable Postgres-backed DagsterInstance.
Wed, Oct 2, 10:59 PM
max updated the diff for D1151: Configable Postgres-backed DagsterInstance.

Up

Wed, Oct 2, 10:56 PM
max updated the diff for D1151: Configable Postgres-backed DagsterInstance.

Sigh

Wed, Oct 2, 10:36 PM
max updated the diff for D1165: Improve error handling in subscription server.

Nitds

Wed, Oct 2, 6:08 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Rebase

Wed, Oct 2, 5:50 PM
max created D1165: Improve error handling in subscription server.
Wed, Oct 2, 5:45 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Nits

Wed, Oct 2, 5:38 PM
max updated the diff for D1151: Configable Postgres-backed DagsterInstance.

Rebase

Wed, Oct 2, 2:49 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Nits

Wed, Oct 2, 2:47 PM
max accepted D1147: (set-typing-1) Add dagster type for closed set type.
Wed, Oct 2, 2:40 PM
max accepted D1142: mirror s3 bucket structure to local directory.
Wed, Oct 2, 2:39 PM
max accepted D1141: Update schedules execution params modal.
Wed, Oct 2, 2:39 PM
max added inline comments to D1147: (set-typing-1) Add dagster type for closed set type.
Wed, Oct 2, 2:38 PM
max accepted D1155: (add-cancellation-8.5) use safe_tempfile_path everywhere.
Wed, Oct 2, 2:36 PM
max updated the diff for D1151: Configable Postgres-backed DagsterInstance.

Rebase

Wed, Oct 2, 2:36 PM
max updated the summary of D1129: Test Postgres-backed DagsterInstance.
Wed, Oct 2, 2:34 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Skip test on buildkite

Wed, Oct 2, 2:32 PM

Tue, Oct 1

max created D1151: Configable Postgres-backed DagsterInstance.
Tue, Oct 1, 11:47 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Up

Tue, Oct 1, 11:33 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

network

Tue, Oct 1, 10:37 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Rebase

Tue, Oct 1, 10:25 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Connection strings

Tue, Oct 1, 10:24 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Omgwtf

Tue, Oct 1, 10:04 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Nit

Tue, Oct 1, 9:52 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

debug

Tue, Oct 1, 9:44 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

debug

Tue, Oct 1, 9:29 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

env

Tue, Oct 1, 8:53 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Nits

Tue, Oct 1, 8:42 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Nits

Tue, Oct 1, 8:37 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

docker-compose

Tue, Oct 1, 8:30 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Arghgh

Tue, Oct 1, 8:22 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Nit

Tue, Oct 1, 8:10 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Styx

Tue, Oct 1, 8:07 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Stx

Tue, Oct 1, 8:04 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Lnt

Tue, Oct 1, 7:45 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Test setup

Tue, Oct 1, 7:36 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

ps -a

Tue, Oct 1, 5:30 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

debug

Tue, Oct 1, 5:26 PM
max updated the diff for D1129: Test Postgres-backed DagsterInstance.

Debug

Tue, Oct 1, 5:24 PM
Next