Page MenuHomePhabricator
Feed Advanced Search

Today

max updated the diff for D1880: Make K8s Job namespace configurable.

Debug

Sat, Jan 25, 12:10 AM
max updated the diff for D1880: Make K8s Job namespace configurable.

Debug

Sat, Jan 25, 12:07 AM

Yesterday

max updated the diff for D1880: Make K8s Job namespace configurable.

Debug

Fri, Jan 24, 11:54 PM
max updated the diff for D1880: Make K8s Job namespace configurable.

posargs

Fri, Jan 24, 11:21 PM
max updated the diff for D1880: Make K8s Job namespace configurable.

Posargs

Fri, Jan 24, 11:21 PM
max updated the diff for D1880: Make K8s Job namespace configurable.

posargs debug

Fri, Jan 24, 11:03 PM
max updated the diff for D1880: Make K8s Job namespace configurable.

Fixie

Fri, Jan 24, 10:50 PM
max updated the diff for D1880: Make K8s Job namespace configurable.

Diagnostics

Fri, Jan 24, 10:47 PM
max created D1880: Make K8s Job namespace configurable.
Fri, Jan 24, 3:00 AM

Thu, Jan 23

max created D1877: Use startPipelineExecution for K8sRunLauncher.
Thu, Jan 23, 11:45 PM
max updated the diff for D1873: Working K8sRunLauncher.

Rebase

Thu, Jan 23, 8:26 PM
max updated the diff for D1873: Working K8sRunLauncher.

Nits

Thu, Jan 23, 8:23 PM
max updated the diff for D1873: Working K8sRunLauncher.

blk

Thu, Jan 23, 8:22 PM
max updated the diff for D1873: Working K8sRunLauncher.

py27

Thu, Jan 23, 7:51 PM
max updated the diff for D1873: Working K8sRunLauncher.

Fixup py27

Thu, Jan 23, 7:26 PM
max updated the diff for D1873: Working K8sRunLauncher.

Up

Thu, Jan 23, 7:21 PM
max added inline comments to D1873: Working K8sRunLauncher.
Thu, Jan 23, 7:18 PM
max created D1873: Working K8sRunLauncher.
Thu, Jan 23, 2:33 AM

Wed, Jan 22

max requested changes to D1863: [engine] shared step iteration.

sounds like we are going to not try to paper over the differences in priority handling between celery, multiprocess[, k8s, ...] -- so let's revert the tagging change in the celery tests and reinstitute the sorting step in dagster-celery

Wed, Jan 22, 10:10 PM
max accepted D1863: [engine] shared step iteration.
Wed, Jan 22, 9:51 PM
max added inline comments to D1853: handle differing arg and input def ordering.
Wed, Jan 22, 9:45 PM
max accepted D1765: Fix issue with pyspark_solid decorator not handling inputs.
Wed, Jan 22, 9:44 PM
max added a comment to D1864: RFC: is_optional --> is_required.

if we do this, I'd like to do a deprecation process where in 0.7.x it emits warnings before going away in 0.8.0

Wed, Jan 22, 9:42 PM
max accepted D1859: dont use integration as base for test_pipeline.
Wed, Jan 22, 9:31 PM

Thu, Jan 16

max accepted D1854: Remove dagster_tests import.
Thu, Jan 16, 10:13 PM
max updated the diff for D1849: Improve local test story.

Fixup

Thu, Jan 16, 5:53 PM
max updated the diff for D1849: Improve local test story.

py23

Thu, Jan 16, 5:32 PM
max updated the diff for D1849: Improve local test story.

Blk

Thu, Jan 16, 5:29 PM
max accepted D1852: remove deprecated ReexecutionConfig.
Thu, Jan 16, 5:27 PM
max updated the diff for D1849: Improve local test story.

Up

Thu, Jan 16, 5:25 PM
max updated the diff for D1849: Improve local test story.

Up

Thu, Jan 16, 5:23 PM
max accepted D1846: [celery] emit engine event on failed broker connection.
Thu, Jan 16, 4:15 AM
max accepted D1851: Change tests using add to subtract.
Thu, Jan 16, 4:15 AM
max updated the diff for D1849: Improve local test story.

Black

Thu, Jan 16, 3:14 AM
max created D1849: Improve local test story.
Thu, Jan 16, 3:14 AM

Wed, Jan 15

max accepted D1848: Fix changelog formatting.
Wed, Jan 15, 11:39 PM

Tue, Jan 14

max accepted D1842: [core] rework engine requirments checks.
Tue, Jan 14, 10:32 PM
max updated the diff for D1793: Garbage collect completed Jobs after 100 seconds.

Fixup job spec

Tue, Jan 14, 8:07 PM
max updated the diff for D1793: Garbage collect completed Jobs after 100 seconds.

Test spec

Tue, Jan 14, 7:46 PM
max added a comment to D1835: Fix errors with GCP pipeline.

Tue, Jan 14, 7:30 PM
max accepted D1838: improve engine check error copy.
Tue, Jan 14, 7:28 PM
max accepted D1839: [dagster-celery] cleanup default application.

ok

Tue, Jan 14, 7:27 PM
max updated the diff for D1793: Garbage collect completed Jobs after 100 seconds.

Rebase

Tue, Jan 14, 7:27 PM
max added a comment to D1834: Fixup MANIFEST.in.

i can split them into a separate diff but would like to release both

Tue, Jan 14, 12:19 AM
max updated the diff for D1834: Fixup MANIFEST.in.

Use package_data

Tue, Jan 14, 12:15 AM

Mon, Jan 13

max created D1834: Fixup MANIFEST.in.
Mon, Jan 13, 11:56 PM

Sat, Jan 11

max updated the diff for D1800: Run tests locally (OS X).

Up

Sat, Jan 11, 1:36 AM
max updated the diff for D1800: Run tests locally (OS X).

Up

Sat, Jan 11, 1:28 AM
max updated the diff for D1800: Run tests locally (OS X).

Up

Sat, Jan 11, 1:14 AM
max updated the diff for D1819: Update changelog for 0.6.7.

Up

Sat, Jan 11, 1:12 AM
max updated the diff for D1819: Update changelog for 0.6.7.

Up

Sat, Jan 11, 1:09 AM
max updated the diff for D1800: Run tests locally (OS X).

Up

Sat, Jan 11, 1:08 AM
max accepted D1812: (dict-where-type-is-used-10) Eliminate wrapping subpackage.

super, see comment

Sat, Jan 11, 12:29 AM

Fri, Jan 10

max accepted D1817: (dict-where-type-is-used-12) Changelog for config changes.

Migration guide?

Fri, Jan 10, 11:51 PM
max accepted D1816: (dict-where-type-is-used-11) PermissiveDict --> Permissive.
Fri, Jan 10, 11:51 PM
max accepted D1810: (dict-where-type-is-used-9) Optional --> Noneable.
Fri, Jan 10, 11:50 PM
max created D1819: Update changelog for 0.6.7.
Fri, Jan 10, 11:49 PM

Thu, Jan 9

max accepted D1813: [k8s] misc fixes.
Thu, Jan 9, 11:58 PM
max added a comment to D1810: (dict-where-type-is-used-9) Optional --> Noneable.

ah great. I vote for Noneable

Thu, Jan 9, 11:20 PM
max added a comment to D1810: (dict-where-type-is-used-9) Optional --> Noneable.
Thu, Jan 9, 11:20 PM
max added a comment to D1810: (dict-where-type-is-used-9) Optional --> Noneable.

Omittable?

Thu, Jan 9, 11:16 PM
max added a comment to D1810: (dict-where-type-is-used-9) Optional --> Noneable.

There is some potential for confusion with both Noneable and Nullable if these are meant to imply that a value can be omitted (vs. explicitly set to Python None or to YAML/JSON null

Thu, Jan 9, 11:16 PM
max created D1814: Fix isort.
Thu, Jan 9, 10:43 PM
max updated the diff for D1800: Run tests locally (OS X).

Fixup

Thu, Jan 9, 10:13 PM
max updated the diff for D1811: Push integration images to DockerHub.

Set Dockerhub creds

Thu, Jan 9, 9:40 PM
max created D1811: Push integration images to DockerHub.
Thu, Jan 9, 8:52 PM
max updated the diff for D1800: Run tests locally (OS X).

Up

Thu, Jan 9, 7:59 PM

Wed, Jan 8

max created D1800: Run tests locally (OS X).
Wed, Jan 8, 11:39 PM
max created D1793: Garbage collect completed Jobs after 100 seconds.
Wed, Jan 8, 5:04 PM

Tue, Jan 7

max abandoned D1785: Raise a CheckError, not a KeyError.
Tue, Jan 7, 4:41 PM
max created D1785: Raise a CheckError, not a KeyError.
Tue, Jan 7, 4:40 PM

Dec 21 2019

max abandoned D1728: Hygiene: use check.string_types throughout.
Dec 21 2019, 5:54 AM
max added inline comments to D1729: Set metadata on solid instances.
Dec 21 2019, 4:36 AM

Dec 20 2019

max updated the diff for D1730: Remove step_metadata_fn.

Up

Dec 20 2019, 10:07 PM
max updated the summary of D1730: Remove step_metadata_fn.
Dec 20 2019, 10:00 PM
max created D1730: Remove step_metadata_fn.
Dec 20 2019, 9:55 PM
max created D1729: Set metadata on solid instances.
Dec 20 2019, 9:50 PM
max accepted D1712: Add missing where clause to event storage.
Dec 20 2019, 9:06 PM
max accepted D1724: [multiproc] terminate fix.
Dec 20 2019, 9:05 PM
max updated the diff for D1728: Hygiene: use check.string_types throughout.

blk

Dec 20 2019, 9:04 PM
max updated the diff for D1728: Hygiene: use check.string_types throughout.

Up

Dec 20 2019, 8:47 PM
max created D1728: Hygiene: use check.string_types throughout.
Dec 20 2019, 8:44 PM
max accepted D1720: run mypy on examples.

This makes me want to add mypy annotations to the public API. I know it's cumbersome.

Dec 20 2019, 6:39 PM
max accepted D1721: make isort.
Dec 20 2019, 6:38 PM
max added a comment to D1717: Use WAL for sqlite-backed run storages as well.

yes

Dec 20 2019, 6:37 PM

Dec 19 2019

max added a comment to D1717: Use WAL for sqlite-backed run storages as well.

but @prha can still repro

Dec 19 2019, 10:32 PM
max updated the diff for D1707: POC of retryable exception handling in Celery engine.

Rebase

Dec 19 2019, 10:27 PM
max updated the diff for D1717: Use WAL for sqlite-backed run storages as well.

Rebase

Dec 19 2019, 10:13 PM
max added a comment to D1717: Use WAL for sqlite-backed run storages as well.

can't repro @prha's backfill issue -- including before the WAL change on the event logs

Dec 19 2019, 10:12 PM
max accepted D1713: Use the same public Python images everywhere.
Dec 19 2019, 9:48 PM
max added a comment to D1716: Reinstate WAL in sqlite storages.

i played with the isolation level a little bit but couldn't identify an impact

Dec 19 2019, 9:41 PM
max updated the diff for D1702: Multiqueue execution.

Explicitly test metadata

Dec 19 2019, 9:24 PM
max added inline comments to D1702: Multiqueue execution.
Dec 19 2019, 9:23 PM
max created D1719: Bring nightly version in lockstep.
Dec 19 2019, 9:22 PM
max added inline comments to D1707: POC of retryable exception handling in Celery engine.
Dec 19 2019, 9:20 PM
max updated the diff for D1707: POC of retryable exception handling in Celery engine.

Tests

Dec 19 2019, 9:20 PM
max updated the diff for D1707: POC of retryable exception handling in Celery engine.

Tst

Dec 19 2019, 9:10 PM
max created D1717: Use WAL for sqlite-backed run storages as well.
Dec 19 2019, 7:53 PM
max updated the diff for D1716: Reinstate WAL in sqlite storages.

Up

Dec 19 2019, 7:52 PM
max updated the diff for D1707: POC of retryable exception handling in Celery engine.

Up

Dec 19 2019, 7:48 PM