adding max too

looks good! can we run the integration tests too?

amazing work!! two small notes, then good to go 💃

nice find! doesnt seem like user deployment loads the instance configmap, so looks safe to me

a few non-blocking comments. looks good!

i think we need an end-to-end integration test for "dagster-user-deployments": {"enabled": True, "enableSubchart": False} to be sure that launching runs w/o using subcharts continues to work

looks good to me, defer to @rexledesma's feedback about schema + template

after rex's comments, looks good to me. going to resign so it's out of my queue

Also wanted to second daniel's concern about running the migration while dagit is in use.

Another option is to ask users to connect to their cluster and manually run kubectl apply -f dagster-instance-migrate.yaml to create the migration job so that users aren't caught off guard? for example, some users may want to be extra safe and backup their database before migration in case something unexpected happens

a few comments; afterwards, good to go

the changes after the "accept" review were only to add the tests in helm.py that check that the label is correctly applied to the deployment

up

up

up

up

up

up

up

up

up

up

sent a snippet of user's code over Slack. yes, the flower env is different from the celery env in their case (also I think being maximally flexible for stuff like flower is preferable, so that we don't get in users' way)

up

added tests

up

up

up

up

rebase

awesome ✨

Looks good so far! Sending it back to your queue for "Add video thumbnails and move the resources center to dagster.io."

will defer to ben or sashank on the code review. the demo for this looks amazing and can't wait till users get to benefit from it 💃

feel free to merge after making one last formatting change

Awesome, looks great. one last change (and a missing .) and then it's good to ship