I think this is fine for now - doesn't need to be in this diff, but should we deprecate these enabled flags and change the helm schema to be like

cool, looks good to me. see one comment on testing; also, are there any other places we should expose the ability to add labels while you're at it?

should flower and the celery workers have different envs? or should this be shared?

see one comment, otherwise LGTM!

hmm but I think we're stuck on an older airflow before this fix went out; see: https://github.com/dagster-io/dagster/blob/master/python_modules/libraries/dagster-airflow/setup.py#L47

hmm did you try this on a clean venv? last I tried it didn't work properly

up

up

thanks for fixing - is there a scaffolding template for these that needs to get updated too?

should we just remove this file entirely? since quip is only accessible to employees?

up

up

up

hmm shouldn't this:

if the body of one solid creates a particular table in a database and the body of another solid consumes that table

be modeled w/ IOManagers instead of Nothings?

up

up

up

up

This looks really good to me now! Thanks for getting this done!!

up

up

up

yeah buildkite has an assert on their side that fails loudly if both are set, so I figured it'd be best to just fall through to their error message rather than insert our own

ambitious, I like it

up

up

up

up

up

up