Page MenuHomeElementl
Feed Advanced Search

Jun 2 2021

johann requested review of D8197: K8s executor docs.
Jun 2 2021, 3:39 PM
johann requested review of D8196: K8s executor logging.
Jun 2 2021, 2:58 PM

Jun 1 2021

johann closed D8190: Cast opt str with default to str for schedule and sensor mode.
Jun 1 2021, 11:59 PM
johann committed R1:030ddabfeb44: Cast opt str with default to str for schedule and sensor mode (authored by johann).
Cast opt str with default to str for schedule and sensor mode
Jun 1 2021, 11:59 PM
johann closed D8150: rename k8s executor.
Jun 1 2021, 10:53 PM
johann committed R1:90f26e7c8fce: rename k8s executor (authored by johann).
rename k8s executor
Jun 1 2021, 10:53 PM
johann updated the diff for D8150: rename k8s executor.

remove accidental updates

Jun 1 2021, 10:52 PM
johann closed D8137: k8s executor terminate.
Jun 1 2021, 10:50 PM
johann committed R1:0df28490b4b8: k8s executor terminate (authored by johann).
k8s executor terminate
Jun 1 2021, 10:50 PM
johann updated the diff for D8137: k8s executor terminate.

feedback

Jun 1 2021, 10:49 PM
johann added inline comments to D8137: k8s executor terminate.
Jun 1 2021, 10:45 PM
johann updated the diff for D8150: rename k8s executor.

add logging

Jun 1 2021, 9:49 PM
johann updated the diff for D8150: rename k8s executor.

feedback

Jun 1 2021, 4:01 PM
johann added a comment to D8030: [helm] Adding configurable RunCoordinator (1/n).

Sid correctly pointed out that both of the above suggestions are breaking changes. He'll file an issue so that we can address in 0.12. lgtm

Jun 1 2021, 4:00 PM
johann added a reviewer for D8036: [core][tests] Shared RunCoordinator test suite (2/n): jordansanders.

lgtm, @jordansanders might have thoughts on pytest patterns

Jun 1 2021, 3:47 PM
johann added a comment to D8030: [helm] Adding configurable RunCoordinator (1/n).

An alternative approach would be to to remove the 'enabled' field and switch to the pattern we're using for the run launcher- the DefaultRunCoordinator is equivalent to current enabled:false. I'm ok with this setup though.

Jun 1 2021, 3:43 PM
johann added a comment to D8030: [helm] Adding configurable RunCoordinator (1/n).

nit, should change the config name in values.yaml and the schema

Jun 1 2021, 3:40 PM

May 28 2021

johann accepted D8160: restore instance param on WorkspaceProcessContext.
May 28 2021, 5:24 PM
johann accepted D8157: Make run queue config numbers intsources.

I think there was a proposal floating around to just add env to the regular types, would make sense to me

May 28 2021, 3:41 PM

May 27 2021

johann requested review of D8150: rename k8s executor.
May 27 2021, 9:04 PM
johann updated the diff for D8137: k8s executor terminate.

comment on script

May 27 2021, 8:31 PM
johann updated the diff for D8137: k8s executor terminate.

rebase

May 27 2021, 8:05 PM
johann updated the diff for D8137: k8s executor terminate.

up

May 27 2021, 8:03 PM
johann added reviewers for D8137: k8s executor terminate: jordansanders, dgibson.
May 27 2021, 5:10 PM
johann published D8137: k8s executor terminate for review.
May 27 2021, 5:06 PM
johann accepted D8136: dagster-airflow dep pins.
May 27 2021, 4:06 PM
johann added a comment to D8134: Create a new k8s client on each run.

nit: it appears the k8s launcher doesn't use _core_api?

May 27 2021, 3:08 PM
johann accepted D8134: Create a new k8s client on each run.
May 27 2021, 3:06 PM

May 26 2021

johann abandoned D6717: [RFC] Instance health query.
May 26 2021, 5:19 PM
johann abandoned D7915: [RFC] Non step isolated executor.
May 26 2021, 5:19 PM
johann abandoned D7920: K8s executor non-step-isolated.
May 26 2021, 5:19 PM

May 25 2021

johann closed D8081: TestStepHandler wait for processes to exit.
May 25 2021, 8:05 PM
johann committed R1:c9fe06a4ca64: TestStepHandler wait for processes to exit (authored by johann).
TestStepHandler wait for processes to exit
May 25 2021, 8:05 PM
johann updated the diff for D8081: TestStepHandler wait for processes to exit.

up

May 25 2021, 7:16 PM
johann updated the test plan for D8081: TestStepHandler wait for processes to exit.
May 25 2021, 7:15 PM
johann updated the diff for D8081: TestStepHandler wait for processes to exit.

mypy

May 25 2021, 6:00 PM
johann closed D8066: Dagit read-only k8s service.
May 25 2021, 5:12 PM
johann committed R1:85f9c45cfed7: Dagit read-only k8s service (authored by johann).
Dagit read-only k8s service
May 25 2021, 5:12 PM
johann updated the diff for D8066: Dagit read-only k8s service.

feedback

May 25 2021, 5:12 PM
johann published D8081: TestStepHandler wait for processes to exit for review.
May 25 2021, 4:38 PM
johann accepted D8075: Add docs for managing separate Helm deployments for user code.
May 25 2021, 4:22 PM
johann updated the diff for D8066: Dagit read-only k8s service.

feedback

May 25 2021, 2:59 PM
johann accepted D8073: Add Artifacthub url to release message.
May 25 2021, 2:15 PM
johann accepted D8074: Add docs for managing an external postgresql secret in Helm.

Should we consider being explicit that this is how we can support Vault/similar?

May 25 2021, 2:01 PM

May 24 2021

johann published D8066: Dagit read-only k8s service for review.
May 24 2021, 10:03 PM
johann closed D8042: Dagit --read-only helm support.
May 24 2021, 6:54 PM
johann committed R1:9d6a20f4e02f: Dagit --read-only helm support (authored by johann).
Dagit --read-only helm support
May 24 2021, 6:54 PM
johann updated the diff for D8042: Dagit --read-only helm support.

split out parametrized test

May 24 2021, 6:53 PM
johann updated the diff for D8042: Dagit --read-only helm support.

schema apply

May 24 2021, 5:39 PM
johann updated the diff for D8042: Dagit --read-only helm support.

rebase

May 24 2021, 5:15 PM
johann updated the diff for D8042: Dagit --read-only helm support.

test ingress

May 24 2021, 4:55 PM
johann updated the diff for D8042: Dagit --read-only helm support.

add ingress config

May 24 2021, 2:40 PM
johann retitled D8042: Dagit --read-only helm support from [RFC] Dagit --read-only helm support to Dagit --read-only helm support.
May 24 2021, 2:29 PM
johann updated the diff for D8042: Dagit --read-only helm support.

fix

May 24 2021, 2:29 PM
johann added inline comments to D8042: Dagit --read-only helm support.
May 24 2021, 2:24 PM
johann added inline comments to D8042: Dagit --read-only helm support.
May 24 2021, 2:15 PM
johann updated the diff for D8042: Dagit --read-only helm support.

add schema test

May 24 2021, 2:13 PM

May 22 2021

johann published D8042: Dagit --read-only helm support for review.
May 22 2021, 4:25 AM

May 21 2021

johann updated the diff for D8027: k8s executor terminate.

up

May 21 2021, 5:26 PM
johann closed D7901: Refactor step handler to pass a context object.
May 21 2021, 5:14 PM
johann committed R1:5d38b23717fd: Refactor step handler to pass a context object (authored by johann).
Refactor step handler to pass a context object
May 21 2021, 5:14 PM
johann requested review of D8027: k8s executor terminate.
May 21 2021, 2:21 PM
johann updated the diff for D7901: Refactor step handler to pass a context object.

up

May 21 2021, 1:54 PM
johann updated the diff for D7901: Refactor step handler to pass a context object.

up

May 21 2021, 1:49 PM

May 20 2021

johann updated the diff for D7901: Refactor step handler to pass a context object.

feedback

May 20 2021, 5:36 PM

May 19 2021

johann added inline comments to D7901: Refactor step handler to pass a context object.
May 19 2021, 6:30 PM
johann updated the diff for D7901: Refactor step handler to pass a context object.

up

May 19 2021, 5:41 PM
johann updated the diff for D7901: Refactor step handler to pass a context object.

up

May 19 2021, 5:30 PM
johann updated the diff for D7901: Refactor step handler to pass a context object.

fix rebase

May 19 2021, 5:17 PM
johann updated the diff for D7901: Refactor step handler to pass a context object.

rebase

May 19 2021, 4:32 PM
johann updated the diff for D7901: Refactor step handler to pass a context object.

lint

May 19 2021, 2:57 PM

May 18 2021

johann updated the diff for D7901: Refactor step handler to pass a context object.

up

May 18 2021, 9:46 PM
johann updated the summary of D7901: Refactor step handler to pass a context object.
May 18 2021, 9:42 PM
johann retitled D7901: Refactor step handler to pass a context object from Refactor step handler to only use ExecuteStepArgs to Refactor step handler to pass a context object.
May 18 2021, 9:41 PM
johann updated the diff for D7901: Refactor step handler to pass a context object.

pass step handler context

May 18 2021, 9:35 PM
johann closed D7903: Load new image into existing kind cluster.
May 18 2021, 3:11 PM
johann committed R1:6055f457ab34: Load new image into existing kind cluster (authored by johann).
Load new image into existing kind cluster
May 18 2021, 3:11 PM
johann planned changes to D7915: [RFC] Non step isolated executor.
May 18 2021, 2:22 PM
johann planned changes to D7920: K8s executor non-step-isolated.
May 18 2021, 2:22 PM

May 17 2021

johann accepted D7894: Include container_image in recon_pipeline_from_origin and recon_repository_from_origin,.

This LGTM

May 17 2021, 10:18 PM
johann added a comment to D7901: Refactor step handler to pass a context object.

Good points. My thinking was that step handlers exist to call the dagster api execute_step call, and that they should be able to do it with these args.

May 17 2021, 2:13 PM

May 14 2021

johann updated the summary of D7920: K8s executor non-step-isolated.
May 14 2021, 7:31 PM
johann updated the summary of D7915: [RFC] Non step isolated executor.
May 14 2021, 7:29 PM
johann requested review of D7920: K8s executor non-step-isolated.
May 14 2021, 6:53 PM
johann updated the diff for D7915: [RFC] Non step isolated executor.

up

May 14 2021, 6:08 PM
johann retitled D7915: [RFC] Non step isolated executor from Non step isolated executor to [RFC] Non step isolated executor.
May 14 2021, 6:04 PM
johann requested review of D7915: [RFC] Non step isolated executor.
May 14 2021, 5:31 PM

May 13 2021

johann requested review of D7901: Refactor step handler to pass a context object.
May 13 2021, 10:38 PM
johann requested review of D7903: Load new image into existing kind cluster.
May 13 2021, 10:33 PM
johann closed D7892: Put run coordinator instance yaml under test.
May 13 2021, 3:38 PM
johann committed R1:8e3f761525f7: Put run coordinator instance yaml under test (authored by johann).
Put run coordinator instance yaml under test
May 13 2021, 3:38 PM
johann closed D7891: Allow dagster/priority tag on definitions.
May 13 2021, 2:41 PM
johann committed R1:7e121ab1e2f3: Allow dagster/priority tag on definitions (authored by johann).
Allow dagster/priority tag on definitions
May 13 2021, 2:41 PM
johann requested review of D7892: Put run coordinator instance yaml under test.
May 13 2021, 1:03 AM

May 12 2021

johann requested review of D7891: Allow dagster/priority tag on definitions.
May 12 2021, 11:09 PM
johann accepted D7883: Add an event before the create_namespaced_job call in the K8sRunLauncher.
May 12 2021, 4:46 PM

May 11 2021

johann accepted D7876: pin click.
May 11 2021, 10:22 PM
johann closed D7864: Remove executor from concepts overview page.
May 11 2021, 9:25 PM
johann committed R1:a60b2969b0c3: Remove executor from concepts overview page (authored by johann).
Remove executor from concepts overview page
May 11 2021, 9:25 PM
johann added a comment to D7864: Remove executor from concepts overview page.

It is redirected. It doesn't apply bc the page doesn't reload

May 11 2021, 5:37 PM