Page MenuHomeElementl
Feed Advanced Search

Yesterday

johann requested review of D7901: Refactor step handler to only use ExecuteStepArgs.
Thu, May 13, 10:38 PM
johann requested review of D7903: Load new image into existing kind cluster.
Thu, May 13, 10:33 PM
johann closed D7892: Put run coordinator instance yaml under test.
Thu, May 13, 3:38 PM
johann committed R1:8e3f761525f7: Put run coordinator instance yaml under test (authored by johann).
Put run coordinator instance yaml under test
Thu, May 13, 3:38 PM
johann closed D7891: Allow dagster/priority tag on definitions.
Thu, May 13, 2:41 PM
johann committed R1:7e121ab1e2f3: Allow dagster/priority tag on definitions (authored by johann).
Allow dagster/priority tag on definitions
Thu, May 13, 2:41 PM
johann requested review of D7892: Put run coordinator instance yaml under test.
Thu, May 13, 1:03 AM

Wed, May 12

johann requested review of D7891: Allow dagster/priority tag on definitions.
Wed, May 12, 11:09 PM
johann accepted D7883: Add an event before the create_namespaced_job call in the K8sRunLauncher.
Wed, May 12, 4:46 PM

Tue, May 11

johann accepted D7876: pin click.
Tue, May 11, 10:22 PM
johann closed D7864: Remove executor from concepts overview page.
Tue, May 11, 9:25 PM
johann committed R1:a60b2969b0c3: Remove executor from concepts overview page (authored by johann).
Remove executor from concepts overview page
Tue, May 11, 9:25 PM
johann added a comment to D7864: Remove executor from concepts overview page.

It is redirected. It doesn't apply bc the page doesn't reload

Tue, May 11, 5:37 PM
johann published D7864: Remove executor from concepts overview page for review.
Tue, May 11, 5:27 PM
johann closed D7857: [Easy] Remove unneccesary verify_complete calls.
Tue, May 11, 4:22 AM
johann committed R1:73ca16e043d5: [Easy] Remove unneccesary verify_complete calls (authored by johann).
[Easy] Remove unneccesary verify_complete calls
Tue, May 11, 4:22 AM
johann updated the diff for D7857: [Easy] Remove unneccesary verify_complete calls.

up

Tue, May 11, 4:03 AM
johann updated the test plan for D7857: [Easy] Remove unneccesary verify_complete calls.
Tue, May 11, 4:03 AM
johann requested review of D7857: [Easy] Remove unneccesary verify_complete calls.
Tue, May 11, 3:49 AM

Mon, May 10

johann closed D7807: Add volume mounts to dagster k8s jobs.
Mon, May 10, 5:17 PM
johann committed R1:0a8f0131d264: Add volume mounts to dagster k8s jobs (authored by johann).
Add volume mounts to dagster k8s jobs
Mon, May 10, 5:17 PM
johann updated the diff for D7807: Add volume mounts to dagster k8s jobs.

up

Mon, May 10, 4:37 PM
johann updated the diff for D7807: Add volume mounts to dagster k8s jobs.

support secret source

Mon, May 10, 2:15 PM

Fri, May 7

johann accepted D7667: Add a dagit service.
Fri, May 7, 9:44 PM
johann accepted D7666: Add a Fargate cluster.
Fri, May 7, 9:42 PM
johann updated the diff for D7807: Add volume mounts to dagster k8s jobs.

up

Fri, May 7, 6:50 PM
johann published D7807: Add volume mounts to dagster k8s jobs for review.
Fri, May 7, 6:38 PM
johann closed D7624: [RFC] Celery-less k8s executor.
Fri, May 7, 1:39 AM
johann committed R1:66998ee7bb37: [RFC] Celery-less k8s executor (authored by johann).
[RFC] Celery-less k8s executor
Fri, May 7, 1:39 AM

Thu, May 6

johann updated the diff for D7624: [RFC] Celery-less k8s executor.

up

Thu, May 6, 10:48 PM
johann updated the diff for D7624: [RFC] Celery-less k8s executor.

feedback

Thu, May 6, 10:34 PM
johann added inline comments to D7624: [RFC] Celery-less k8s executor.
Thu, May 6, 10:31 PM
johann updated the diff for D7624: [RFC] Celery-less k8s executor.

up

Thu, May 6, 1:56 PM
johann updated the diff for D7624: [RFC] Celery-less k8s executor.

up

Thu, May 6, 3:10 AM
johann updated the diff for D7624: [RFC] Celery-less k8s executor.

feedback

Thu, May 6, 2:22 AM
johann updated the diff for D7624: [RFC] Celery-less k8s executor.

up

Thu, May 6, 1:56 AM

Wed, May 5

johann closed D7742: Add dagster-celery-k8s to Api docs.
Wed, May 5, 4:34 PM
johann committed R1:6c1d9f7747f7: Add dagster-celery-k8s to Api docs (authored by johann).
Add dagster-celery-k8s to Api docs
Wed, May 5, 4:34 PM
johann published D7742: Add dagster-celery-k8s to Api docs for review.
Wed, May 5, 3:39 PM

Tue, May 4

johann accepted D7711: Add override for env_name for TestPosgresInstance.docker_compose_up.
Tue, May 4, 8:58 PM
johann closed D7517: [Docs] Reorganize deployment pages.
Tue, May 4, 5:21 PM
johann committed R1:49c8d1d8be10: [Docs] Reorganize deployment pages (authored by johann).
[Docs] Reorganize deployment pages
Tue, May 4, 5:21 PM
johann updated the diff for D7517: [Docs] Reorganize deployment pages.

redirects

Tue, May 4, 4:45 PM
johann updated the diff for D7624: [RFC] Celery-less k8s executor.

up

Tue, May 4, 4:12 PM
johann requested review of D7624: [RFC] Celery-less k8s executor.
Tue, May 4, 3:00 PM

Mon, May 3

johann accepted D7665: Scaffold networking and load balancer for example ECS deployment.

Discussed offline.

Mon, May 3, 11:06 PM

Mon, Apr 26

johann accepted D7600: Heartbeat right away in the daemon on startup.
Mon, Apr 26, 11:43 PM
johann resigned from D7603: [dagster-postgres] dont swallow exc in watcher_thread.
Mon, Apr 26, 11:40 PM

Thu, Apr 22

johann accepted D7547: report exitcode on unexpected exit.
Thu, Apr 22, 6:24 PM
johann accepted D7541: Take 2 of "Better error handling when the daemon hits an error while trying to check a heartbeat"".
Thu, Apr 22, 3:43 PM

Wed, Apr 21

johann accepted D7543: Revert "Revert "Configure celery_k8s_job_executor job timeouts"".
Wed, Apr 21, 6:58 PM
johann updated the diff for D7517: [Docs] Reorganize deployment pages.

make snapshot

Wed, Apr 21, 5:36 PM
johann closed D7364: Dump dagster debug exports in integration tests.
Wed, Apr 21, 5:24 PM
johann committed R1:c08b7c901050: Dump dagster debug exports in integration tests (authored by johann).
Dump dagster debug exports in integration tests
Wed, Apr 21, 5:24 PM
johann closed D7534: [Easy] K8s integration - Don't dump cluster info locally.
Wed, Apr 21, 4:16 PM
johann committed R1:e389110acad4: [Easy] K8s integration - Don't dump cluster info locally (authored by johann).
[Easy] K8s integration - Don't dump cluster info locally
Wed, Apr 21, 4:16 PM
johann updated the diff for D7364: Dump dagster debug exports in integration tests.

up

Wed, Apr 21, 4:08 PM
johann accepted D7535: Better error handling when the daemon hits an error while trying to check a heartbeat.

LGTM

Wed, Apr 21, 4:01 PM
johann updated the diff for D7364: Dump dagster debug exports in integration tests.

up

Wed, Apr 21, 3:42 PM
johann updated the diff for D7364: Dump dagster debug exports in integration tests.

up

Wed, Apr 21, 3:41 PM
johann updated the diff for D7364: Dump dagster debug exports in integration tests.

up

Wed, Apr 21, 2:48 PM
johann updated the diff for D7364: Dump dagster debug exports in integration tests.

lint

Wed, Apr 21, 2:47 PM
johann updated the diff for D7364: Dump dagster debug exports in integration tests.

up

Wed, Apr 21, 2:46 PM
johann requested review of D7534: [Easy] K8s integration - Don't dump cluster info locally.
Wed, Apr 21, 2:38 AM

Tue, Apr 20

johann accepted D7532: Configure celery_k8s_job_executor job timeouts.

This looks good to me. I feel bad for anyone who needs configures this, they waited a day then got their run marked as failed.

Tue, Apr 20, 10:22 PM
johann resigned from D7525: [1/2] Allow postgres url params in storage config.

Nice, this looks good to me. Will let one of the others sign off in case I'm missing something

Tue, Apr 20, 5:46 PM
johann updated the diff for D7517: [Docs] Reorganize deployment pages.

update landing page

Tue, Apr 20, 3:37 PM
johann updated the summary of D7517: [Docs] Reorganize deployment pages.
Tue, Apr 20, 2:44 PM
johann updated the summary of D7517: [Docs] Reorganize deployment pages.
Tue, Apr 20, 2:43 PM
johann requested review of D7517: [Docs] Reorganize deployment pages.
Tue, Apr 20, 1:53 PM

Mon, Apr 19

johann accepted D7495: Fix termination in docker deploy example.
Mon, Apr 19, 7:09 PM
johann accepted D7494: Refactor how we handle exceptions in daemons.

I don't think there are any big implications to waiting 30s to heartbeat. Maybe we'll end up bumping tolerance on k8s probes

Mon, Apr 19, 7:07 PM
johann accepted D7460: Recover from failed backfills, populate backfill errors.
Mon, Apr 19, 1:28 PM

Fri, Apr 16

johann added a comment to D7478: [Helm] Allow configuration of postgres connection string on storage classes.

It might be helpful to get more context from the user, are there cases where they couldn't just pull out the user/password/etc? Looks like it wouldn't be too hard postgresql://[user[:password]@][netloc][:port][/dbname][?param1=value1&...]

Fri, Apr 16, 7:35 PM

Apr 13 2021

johann accepted D7398: Change today_at_midnight default timezone to UTC.
Apr 13 2021, 2:23 PM

Apr 9 2021

johann closed D7370: K8sRunLauncher make postgres optional.
Apr 9 2021, 6:37 PM
johann committed R1:e2617ae70897: K8sRunLauncher make postgres optional (authored by johann).
K8sRunLauncher make postgres optional
Apr 9 2021, 6:37 PM
johann updated the diff for D7370: K8sRunLauncher make postgres optional.

up

Apr 9 2021, 5:56 PM
johann requested review of D7370: K8sRunLauncher make postgres optional.
Apr 9 2021, 5:15 PM
johann updated the diff for D7364: Dump dagster debug exports in integration tests.

up

Apr 9 2021, 2:01 AM
johann updated the diff for D7364: Dump dagster debug exports in integration tests.

use current test in filename

Apr 9 2021, 1:59 AM
johann published D7364: Dump dagster debug exports in integration tests for review.

@alangenfeld looks like only runs from user deployments have pipeline_snapshot_ids? Does debug export work without grpc servers?

Apr 9 2021, 1:54 AM

Apr 6 2021

johann accepted D7319: Make more dagster grpc server parameters controllable via env var.
Apr 6 2021, 8:08 PM
johann requested changes to D7319: Make more dagster grpc server parameters controllable via env var.

Just realized this is a click feature, should we use this instead? https://click.palletsprojects.com/en/7.x/options/#values-from-environment-variables

Apr 6 2021, 4:11 PM
johann closed D7292: Add docker image run tag in k8s launchers.
Apr 6 2021, 3:15 PM
johann committed R1:b55b46c2f384: Add docker image run tag in k8s launchers (authored by johann).
Add docker image run tag in k8s launchers
Apr 6 2021, 3:15 PM
johann updated the diff for D7292: Add docker image run tag in k8s launchers.

feedback

Apr 6 2021, 2:22 PM

Apr 3 2021

johann requested review of D7292: Add docker image run tag in k8s launchers.
Apr 3 2021, 1:05 AM

Apr 2 2021

alangenfeld empowered johann as an administrator.
Apr 2 2021, 6:29 PM
johann accepted D7257: Merge Helm repo index when packaging release.
Apr 2 2021, 4:24 PM
johann accepted D7272: Update Helm for 0.11.3.
Apr 2 2021, 3:07 PM

Apr 1 2021

johann accepted D7263: clarify apidoc for mode arg of sensor decorator.
Apr 1 2021, 9:23 PM
johann accepted D7253: [helm] Allow creation of workspace from dagit values.
Apr 1 2021, 8:23 PM
johann added a comment to D7253: [helm] Allow creation of workspace from dagit values.

Good point about the subchart. I don't love putting it under dagit- makes sense to us, but I don't think they seem related for users. Breaking change, but what if the subchart was under an additional yaml key? So that additional values related to user deployments could be under the userDeployments key?

Apr 1 2021, 7:38 PM
johann requested changes to D7253: [helm] Allow creation of workspace from dagit values.

I think the field would be more natural under userDeployments than dagit

Apr 1 2021, 3:04 PM
johann accepted D7252: Reorganize helm user deployment template tests.
Apr 1 2021, 2:58 PM
johann accepted D7254: Mark Helm values schema as generated.
Apr 1 2021, 2:57 PM
johann accepted D7255: Update Chart.yaml for Artifacthub.
Apr 1 2021, 2:56 PM

Mar 31 2021

johann accepted D7245: [airflow] clean up dead code.
Mar 31 2021, 6:19 PM

Mar 25 2021

johann accepted D7147: Allow global service account for Dagster Helm chart.
Mar 25 2021, 8:27 PM