Page MenuHomePhabricator
Feed Advanced Search

Thu, Sep 24

johann updated the diff for D4367: Celery run queue.

rebase

Thu, Sep 24, 10:20 PM
johann abandoned D4507: BK: wait for celery to init.
Thu, Sep 24, 1:30 PM
johann updated the diff for D4367: Celery run queue.

up

Thu, Sep 24, 1:30 PM

Wed, Sep 23

johann updated the diff for D4367: Celery run queue.

up

Wed, Sep 23, 8:50 PM
johann updated the diff for D4367: Celery run queue.

up

Wed, Sep 23, 7:37 PM
johann updated the diff for D4367: Celery run queue.

nits

Wed, Sep 23, 5:57 PM
johann added inline comments to D4367: Celery run queue.
Wed, Sep 23, 5:26 PM
johann added inline comments to D4367: Celery run queue.
Wed, Sep 23, 5:24 PM
johann added a comment to D4507: BK: wait for celery to init.

Ah you're right Cat, this is redundant. Thanks for catching.

Wed, Sep 23, 2:29 PM
johann added inline comments to D4367: Celery run queue.
Wed, Sep 23, 12:31 AM

Tue, Sep 22

johann updated the diff for D4507: BK: wait for celery to init.

up

Tue, Sep 22, 8:59 PM
johann updated the summary of D4507: BK: wait for celery to init.
Tue, Sep 22, 8:56 PM
johann updated the summary of D4507: BK: wait for celery to init.
Tue, Sep 22, 8:56 PM
johann updated the diff for D4367: Celery run queue.

rebase

Tue, Sep 22, 8:45 PM
johann updated the diff for D4367: Celery run queue.

reduce flakiness

Tue, Sep 22, 8:33 PM
johann requested review of D4507: BK: wait for celery to init.
Tue, Sep 22, 7:59 PM

Mon, Sep 21

johann updated the diff for D4367: Celery run queue.

typo

Mon, Sep 21, 8:45 PM
johann added inline comments to D4367: Celery run queue.
Mon, Sep 21, 8:43 PM
johann accepted D4492: Fixes RPC components for smoother `datalands` migration..

Lgtm, would just add a util function

Mon, Sep 21, 8:31 PM
johann accepted D4470: [toys] add crashing to error_monster.
Mon, Sep 21, 3:41 PM
johann updated the diff for D4367: Celery run queue.

rebase in black fix

Mon, Sep 21, 2:56 PM
johann committed R1:267fae8d5cf8: fix black error (authored by johann).
fix black error
Mon, Sep 21, 2:56 PM
johann closed D4490: fix black error.
Mon, Sep 21, 2:56 PM
johann added a comment to D4367: Celery run queue.

@nate @catherinewu This is ready if you guys want to take a look at the Celery and Helm changes

Mon, Sep 21, 2:13 PM
johann updated the diff for D4367: Celery run queue.

rebase and cleanup

Mon, Sep 21, 2:10 PM

Fri, Sep 18

johann updated the diff for D4367: Celery run queue.

up

Fri, Sep 18, 7:20 PM
johann updated the diff for D4367: Celery run queue.

rename

Fri, Sep 18, 6:49 PM
johann updated the diff for D4367: Celery run queue.

clean up

Fri, Sep 18, 6:46 PM
johann updated the diff for D4367: Celery run queue.

separate instance

Fri, Sep 18, 6:05 PM
johann updated the diff for D4367: Celery run queue.

up

Fri, Sep 18, 6:02 PM
johann updated the diff for D4367: Celery run queue.

enable queue in bk

Fri, Sep 18, 4:39 PM
johann updated the diff for D4367: Celery run queue.

remove helm provider

Fri, Sep 18, 4:27 PM
johann updated the diff for D4367: Celery run queue.

up

Fri, Sep 18, 3:31 PM
johann updated the diff for D4367: Celery run queue.

up

Fri, Sep 18, 3:15 PM
johann updated the diff for D4367: Celery run queue.

up

Fri, Sep 18, 2:59 PM
johann updated the diff for D4367: Celery run queue.

yeild cm

Fri, Sep 18, 2:51 PM
johann updated the diff for D4367: Celery run queue.

test bk w/o queue

Fri, Sep 18, 2:32 PM

Thu, Sep 17

johann updated the diff for D4367: Celery run queue.

up

Thu, Sep 17, 10:29 PM
johann updated the diff for D4367: Celery run queue.

pass instance

Thu, Sep 17, 10:06 PM
johann updated the diff for D4367: Celery run queue.

up

Thu, Sep 17, 9:30 PM
johann updated the diff for D4367: Celery run queue.

up

Thu, Sep 17, 9:06 PM
johann accepted D4463: Log changes for the 0.9.9 release..
Thu, Sep 17, 8:56 PM
johann published D4463: Log changes for the 0.9.9 release. for review.
Thu, Sep 17, 8:56 PM
johann updated the diff for D4367: Celery run queue.

up

Thu, Sep 17, 8:33 PM
johann updated the diff for D4367: Celery run queue.

fix comments

Thu, Sep 17, 8:29 PM
johann updated the diff for D4367: Celery run queue.

up

Thu, Sep 17, 8:17 PM
johann updated the diff for D4367: Celery run queue.

pylint

Thu, Sep 17, 7:56 PM
johann updated the diff for D4367: Celery run queue.

remove rel import in tests

Thu, Sep 17, 7:41 PM
johann updated the diff for D4367: Celery run queue.

remove cyclic import

Thu, Sep 17, 7:14 PM
johann updated the diff for D4367: Celery run queue.

add basic integration test

Thu, Sep 17, 7:07 PM
johann updated the diff for D4367: Celery run queue.

refactor helm values for integration tests

Thu, Sep 17, 6:47 PM
johann accepted D4453: Removes dedent from CLI config snippet..
Thu, Sep 17, 3:11 PM
johann committed R1:05ebf5f0ac2b: Surface more k8s client errors in Celery Worker (authored by johann).
Surface more k8s client errors in Celery Worker
Thu, Sep 17, 2:16 AM
johann closed D4447: Surface more k8s client errors in Celery Worker.
Thu, Sep 17, 2:16 AM
johann added a comment to D4447: Surface more k8s client errors in Celery Worker.

Is there a better way to serialize the ApiException? Currently comes out as (None)\nReason: None\n (replace None with actual error)

Thu, Sep 17, 12:16 AM
johann updated the diff for D4447: Surface more k8s client errors in Celery Worker.

nits and type check

Thu, Sep 17, 12:14 AM
johann added a comment to D4447: Surface more k8s client errors in Celery Worker.

Ah good catch on the type checks, I guess we've never tested raising https://github.com/dagster-io/dagster/blob/master/python_modules/libraries/dagster-celery-k8s/dagster_celery_k8s/executor.py#L408

Thu, Sep 17, 12:10 AM

Wed, Sep 16

johann requested review of D4447: Surface more k8s client errors in Celery Worker.
Wed, Sep 16, 8:42 PM
johann added a comment to D4336: Add dbt cli module.

Thanks for taking this over!

Wed, Sep 16, 7:55 PM
johann updated the diff for D4367: Celery run queue.

unit test for queue selection

Wed, Sep 16, 7:11 PM

Mon, Sep 14

johann accepted D4421: Changes `python_module`to `python_package` in tutorial..
Mon, Sep 14, 8:48 PM
johann updated the summary of D4367: Celery run queue.
Mon, Sep 14, 4:11 PM
johann updated the diff for D4367: Celery run queue.

update default queue

Mon, Sep 14, 3:42 PM
johann accepted D4419: Updates instructions for Developing Docs..

Thanks for fixing these!

Mon, Sep 14, 2:52 PM
johann updated the diff for D4367: Celery run queue.

opt param and lint

Mon, Sep 14, 2:51 PM
johann updated the diff for D4367: Celery run queue.

rebase

Mon, Sep 14, 2:19 PM

Fri, Sep 11

johann updated the diff for D4367: Celery run queue.

tags

Fri, Sep 11, 8:43 PM
johann accepted D4408: Changes `repository.yaml` to `workspace.yaml` throughout docs..
Fri, Sep 11, 7:51 PM
johann updated the diff for D4367: Celery run queue.

remove queued launcher

Fri, Sep 11, 4:09 PM
johann updated subscribers of D4367: Celery run queue.
Fri, Sep 11, 3:22 PM
johann updated the diff for D4367: Celery run queue.

rebase pt2

Fri, Sep 11, 3:21 PM
johann updated the diff for D4367: Celery run queue.

refactor p1

Fri, Sep 11, 2:54 PM

Thu, Sep 10

johann committed R1:3905a74bb0c5: Log celery worker (authored by johann).
Log celery worker
Thu, Sep 10, 8:32 PM
johann closed D4372: Log celery worker.
Thu, Sep 10, 8:32 PM
johann updated the diff for D4372: Log celery worker.

rebase

Thu, Sep 10, 8:03 PM
johann updated the diff for D4372: Log celery worker.

style

Thu, Sep 10, 7:45 PM

Wed, Sep 9

johann abandoned D4311: rename helm postgresql.enabled.
Wed, Sep 9, 8:43 PM
johann updated the test plan for D4367: Celery run queue.
Wed, Sep 9, 7:32 PM
johann requested review of D4367: Celery run queue.
Wed, Sep 9, 7:30 PM
johann committed R1:b3c4b68e2abd: add remaining editable images (authored by johann).
add remaining editable images
Wed, Sep 9, 4:27 PM
johann closed D4324: add remaining editable images.
Wed, Sep 9, 4:27 PM
johann updated the diff for D4372: Log celery worker.

separate pod name

Wed, Sep 9, 2:19 PM
johann updated the diff for D4372: Log celery worker.

up

Wed, Sep 9, 1:48 PM
johann updated the summary of D4372: Log celery worker.
Wed, Sep 9, 1:22 PM
johann updated the summary of D4372: Log celery worker.
Wed, Sep 9, 1:16 PM
johann updated the diff for D4372: Log celery worker.

move logs earlier

Wed, Sep 9, 1:14 PM
johann requested review of D4372: Log celery worker.
Wed, Sep 9, 1:11 PM

Tue, Sep 8

johann added a reviewer for D4324: add remaining editable images: nate.
Tue, Sep 8, 7:07 PM

Thu, Sep 3

johann accepted D4340: [docs] mention aws env vars in deploy docs.
Thu, Sep 3, 9:02 PM
johann added a reviewer for D4324: add remaining editable images: catherinewu.
Thu, Sep 3, 8:18 PM
johann updated the diff for D4324: add remaining editable images.

custom tag

Thu, Sep 3, 2:26 PM

Wed, Sep 2

johann added inline comments to D4311: rename helm postgresql.enabled.
Wed, Sep 2, 5:22 PM
johann requested review of D4324: add remaining editable images.
Wed, Sep 2, 4:54 PM

Tue, Sep 1

johann updated the summary of D4311: rename helm postgresql.enabled.
Tue, Sep 1, 6:13 PM
johann accepted D4317: K8s Job should not backoff 4 times, instead user can raise RetryRequested and dagster system can handle retry.
Tue, Sep 1, 4:50 PM
johann added a comment to D4317: K8s Job should not backoff 4 times, instead user can raise RetryRequested and dagster system can handle retry.

Does the dagster retry configuration only apply when RetryRequested() is returned?

Tue, Sep 1, 1:25 PM

Mon, Aug 31

johann requested review of D4311: rename helm postgresql.enabled.
Mon, Aug 31, 3:32 PM

Aug 27 2020

johann committed R1:1226bd86aae0: fix changelog typo (authored by johann).
fix changelog typo
Aug 27 2020, 7:56 PM
johann closed D4291: fix changelog typo.
Aug 27 2020, 7:56 PM
johann requested review of D4291: fix changelog typo.
Aug 27 2020, 2:39 PM