Page MenuHomeElementl
Feed Advanced Search

Jul 12 2021

prha committed R1:b14acdec328a: Revert "pin dbt for test", try removing default dbt profile dir (authored by prha).
Revert "pin dbt for test", try removing default dbt profile dir
Jul 12 2021, 10:34 PM
prha edited reviewers for D8842: Make implement NoopComputeLogManager implement CapturedLogManager interface, added: johann; removed: sandyryza.
Jul 12 2021, 10:33 PM
prha requested review of D8845: have AzureComputeLogManager implement CapturedLogManager interface.
Jul 12 2021, 10:24 PM
prha requested review of D8842: Make implement NoopComputeLogManager implement CapturedLogManager interface.
Jul 12 2021, 10:19 PM
prha requested review of D8839: Revert "pin dbt for test", try removing default dbt profile dir.
Jul 12 2021, 10:08 PM
prha edited reviewers for D8385: add captured log manager interface, added: johann; removed: sandyryza.
Jul 12 2021, 9:59 PM
prha added a reverting change for R1:fdbcecb76c5d: pin dbt for test: D8839: Revert "pin dbt for test", try removing default dbt profile dir.
Jul 12 2021, 9:44 PM
prha added a reverting change for D8831: pin dbt for test: D8839: Revert "pin dbt for test", try removing default dbt profile dir.
Jul 12 2021, 9:44 PM
prha requested review of D8833: make sure pipeline_failure_sensor is under test.
Jul 12 2021, 9:42 PM
prha updated the diff for D8385: add captured log manager interface.

update

Jul 12 2021, 9:07 PM
prha closed D8831: pin dbt for test.
Jul 12 2021, 8:47 PM
prha committed R1:fdbcecb76c5d: pin dbt for test (authored by prha).
pin dbt for test
Jul 12 2021, 8:47 PM
prha added a comment to D8831: pin dbt for test.

gonna just land this to unblock our test suite.

Jul 12 2021, 8:46 PM
prha requested review of D8831: pin dbt for test.
Jul 12 2021, 8:38 PM
prha added inline comments to D8808: [dag-star] graphql endpoint.
Jul 12 2021, 5:29 PM
prha accepted D8809: [dag-star] index html and static resources.
Jul 12 2021, 5:19 PM
prha added a comment to D8807: [dag-star] initial starlette app for dagit.

animated_excited_guy

Jul 12 2021, 5:14 PM
prha accepted D8807: [dag-star] initial starlette app for dagit.
Jul 12 2021, 5:13 PM

Jul 9 2021

prha closed D8802: make asset_sensors take in jobs.
Jul 9 2021, 5:11 PM
prha committed R1:506cb81cc5fc: make asset_sensors take in jobs (authored by prha).
make asset_sensors take in jobs
Jul 9 2021, 5:11 PM
prha accepted D8800: remove storage accessors from instance.

yeah, I should have done this when we talked about it earlier this week.

Jul 9 2021, 3:37 PM
prha accepted D8799: fix pipeline failure sensor.

thankyou

Jul 9 2021, 3:36 PM

Jul 8 2021

prha accepted D8784: remove defensive parent snapshot check.
Jul 8 2021, 10:04 PM
prha retitled D8385: add captured log manager interface from RFC: add instance log manager interface to add captured log manager interface.
Jul 8 2021, 8:56 PM
prha committed R1:55d10fa3d67b: fix mypy type (authored by prha).
fix mypy type
Jul 8 2021, 7:55 PM
prha accepted D8774: 0.12.0 changelog.
Jul 8 2021, 7:41 PM
prha closed D8778: add better asset sensor docs.
Jul 8 2021, 7:39 PM
prha committed R1:b7178be1fae1: add better asset sensor docs (authored by prha).
add better asset sensor docs
Jul 8 2021, 7:39 PM
prha published D8778: add better asset sensor docs for review.
Jul 8 2021, 7:30 PM
prha closed D8773: add migration guide.
Jul 8 2021, 7:10 PM
prha committed R1:80d7f04f4d5d: add migration guide (authored by prha).
add migration guide
Jul 8 2021, 7:10 PM
prha requested review of D8773: add migration guide.
Jul 8 2021, 7:06 PM
prha closed D8732: Create migration to extract asset_keys columns for asset catalog perf.
Jul 8 2021, 6:12 PM
prha committed R1:23d3a6b22247: Create migration to extract asset_keys columns for asset catalog perf (authored by prha).
Create migration to extract asset_keys columns for asset catalog perf
Jul 8 2021, 6:11 PM
prha updated the diff for D8732: Create migration to extract asset_keys columns for asset catalog perf.

update back compat snapshot, rebase docs snapshot

Jul 8 2021, 4:56 PM
prha updated the diff for D8732: Create migration to extract asset_keys columns for asset catalog perf.

update docs snapshots

Jul 8 2021, 3:23 PM
prha updated the diff for D8732: Create migration to extract asset_keys columns for asset catalog perf.

rebase, change the down_revision for postgres/mysql migration scripts to avoid drift

Jul 8 2021, 3:17 PM
prha abandoned D8731: migration.
Jul 8 2021, 4:00 AM
prha resigned from D6810: [core][dagster-mysql] Fixing @experimental tag to work for classes.
Jul 8 2021, 3:57 AM
prha accepted D8719: [dagit] Better usage of space in RepoNavItem.
Jul 8 2021, 2:15 AM
prha closed D8756: fix up internal, event records for get_event_records API.
Jul 8 2021, 12:34 AM
prha committed R1:8235f1aeaeac: fix up internal, event records for get_event_records API (authored by prha).
fix up internal, event records for get_event_records API
Jul 8 2021, 12:34 AM
prha published D8756: fix up internal, event records for get_event_records API for review.
Jul 8 2021, 12:10 AM

Jul 7 2021

prha accepted D8629: [crag] Add mode to the pipeline runs filter.
Jul 7 2021, 10:36 PM
prha added a comment to D8732: Create migration to extract asset_keys columns for asset catalog perf.

@cdecarolis - I was chatting w/ Sandy, and landed on this approach, which doesn't force the instance migration (e.g. doesn't throw a DBException). We can support this at the expense of the code complexity of the two code paths, checking to see if the migration has been run.

Jul 7 2021, 8:00 PM
prha updated the diff for D8732: Create migration to extract asset_keys columns for asset catalog perf.
  • make instance migration optional
Jul 7 2021, 5:56 PM
prha requested review of D8732: Create migration to extract asset_keys columns for asset catalog perf.
Jul 7 2021, 7:27 AM
prha requested review of D8731: migration.
Jul 7 2021, 7:13 AM
prha accepted D8687: [crag] Pipeline.graph_name.
Jul 7 2021, 6:39 AM

Jul 6 2021

prha added inline comments to D8629: [crag] Add mode to the pipeline runs filter.
Jul 6 2021, 11:12 PM
prha accepted D8701: RFC: add pipeline_selection to @pipeline_failure_sensor.
Jul 6 2021, 7:54 PM
prha requested changes to D8465: [RFC] daemon logger.

queue mgmt

Jul 6 2021, 4:26 PM
prha closed D8387: single asset sensor definition.
Jul 6 2021, 3:59 PM
prha committed R1:5dd9042c6be6: single asset sensor definition (authored by prha).
single asset sensor definition
Jul 6 2021, 3:59 PM

Jul 3 2021

prha updated the diff for D8387: single asset sensor definition.

fix doc snapshots

Jul 3 2021, 1:53 AM
prha updated the diff for D8387: single asset sensor definition.

fix bad merge

Jul 3 2021, 1:15 AM
prha updated the summary of D8387: single asset sensor definition.
Jul 3 2021, 12:52 AM
prha retitled D8387: single asset sensor definition from RFC: single asset sensor definition to single asset sensor definition.
Jul 3 2021, 12:52 AM
prha updated the diff for D8387: single asset sensor definition.

rebase, using new event records API

Jul 3 2021, 12:52 AM

Jul 2 2021

prha closed D8698: register event log storage to instance only once in tests.
Jul 2 2021, 9:45 PM
prha committed R1:e758c25dcd6b: register event log storage to instance only once in tests (authored by prha).
register event log storage to instance only once in tests
Jul 2 2021, 9:45 PM
prha published D8698: register event log storage to instance only once in tests for review.
Jul 2 2021, 9:41 PM
prha closed D8610: event log / instance api for event_records.
Jul 2 2021, 9:26 PM
prha committed R1:825836167c3e: event log / instance api for event_records (authored by prha).
event log / instance api for event_records
Jul 2 2021, 9:26 PM
prha accepted D8676: Dispose local compute log manager.
Jul 2 2021, 4:18 PM
prha added inline comments to D8610: event log / instance api for event_records.
Jul 2 2021, 1:15 AM
prha updated the diff for D8610: event log / instance api for event_records.

lint

Jul 2 2021, 12:38 AM
prha updated the diff for D8610: event log / instance api for event_records.

fix get_asset_events calls to get_event_record, fix python <= 3.6 call to datetime.fromisoformat

Jul 2 2021, 12:18 AM

Jul 1 2021

prha updated the diff for D8610: event log / instance api for event_records.

Fix sqlite tests, rename class to EventRecordsFilter

Jul 1 2021, 10:53 PM
prha updated the diff for D8610: event log / instance api for event_records.
  • make sure test storage has weak ref to test instance
Jul 1 2021, 8:48 PM
prha accepted D8648: rfc: add repository_name to SensorEvaluationContext + make pipeline_failure_sensor repo scoped.

yeah, I like this better, I think

Jul 1 2021, 8:08 PM
prha added inline comments to D8610: event log / instance api for event_records.
Jul 1 2021, 8:02 PM
prha updated the diff for D8610: event log / instance api for event_records.
  • unify event log record API by exposing EventLogFilter
Jul 1 2021, 7:59 PM
prha updated subscribers of D8648: rfc: add repository_name to SensorEvaluationContext + make pipeline_failure_sensor repo scoped.

Sorry for the thrash, but perhaps origin id should be an internal-only concept?

Jul 1 2021, 4:37 PM
prha closed D8650: update snapshot tests for sensor ids.
Jul 1 2021, 3:56 PM
prha committed R1:79edc7b9ebca: update snapshot tests for sensor ids (authored by prha).
update snapshot tests for sensor ids
Jul 1 2021, 3:56 PM
prha updated the diff for D8650: update snapshot tests for sensor ids.

fix individual sensor get snapshot

Jul 1 2021, 3:47 PM
prha updated the diff for D8650: update snapshot tests for sensor ids.

remove unstable id

Jul 1 2021, 3:32 PM
prha accepted D8649: merge instance_for_tempdir and instance_for_test.
Jul 1 2021, 3:08 PM
prha committed R1:fc94a35176bf: rename frontend classes that reference `Job` for schedules/sensors (authored by prha).
rename frontend classes that reference `Job` for schedules/sensors
Jul 1 2021, 1:47 AM
prha committed R1:befe7e2228b7: Rename Job graphene fields to use `Instigation` instead (authored by prha).
Rename Job graphene fields to use `Instigation` instead
Jul 1 2021, 1:47 AM

Jun 30 2021

prha added inline comments to D8610: event log / instance api for event_records.
Jun 30 2021, 10:07 PM
prha added a comment to D8629: [crag] Add mode to the pipeline runs filter.

Here's a doc on schema migrations: https://elementl.quip.com/l3XaAJ2YjRSb/Storage-migrations

Jun 30 2021, 9:04 PM
prha added inline comments to D8629: [crag] Add mode to the pipeline runs filter.
Jun 30 2021, 9:02 PM
prha added a reverting change for D8595: Rename Job graphene fields to use `Instigation` instead: R1:2d3303665bba: Revert "Rename Job graphene fields to use `Instigation` instead".
Jun 30 2021, 7:59 PM
prha added a reverting change for R1:5138167c22c7: Rename Job graphene fields to use `Instigation` instead: R1:2d3303665bba: Revert "Rename Job graphene fields to use `Instigation` instead".
Jun 30 2021, 7:59 PM
prha committed R1:2d3303665bba: Revert "Rename Job graphene fields to use `Instigation` instead" (authored by prha).
Revert "Rename Job graphene fields to use `Instigation` instead"
Jun 30 2021, 7:59 PM
prha added a reverting change for D8598: rename frontend classes that reference `Job` for schedules/sensors: R1:99dfd7088848: Revert "rename frontend classes that reference `Job` for schedules/sensors".
Jun 30 2021, 7:59 PM
prha committed R1:99dfd7088848: Revert "rename frontend classes that reference `Job` for schedules/sensors" (authored by prha).
Revert "rename frontend classes that reference `Job` for schedules/sensors"
Jun 30 2021, 7:59 PM
prha added a reverting change for R1:adc382f8c3f2: rename frontend classes that reference `Job` for schedules/sensors: R1:99dfd7088848: Revert "rename frontend classes that reference `Job` for schedules/sensors".
Jun 30 2021, 7:59 PM
prha added inline comments to D8610: event log / instance api for event_records.
Jun 30 2021, 7:17 PM
prha closed D8598: rename frontend classes that reference `Job` for schedules/sensors.
Jun 30 2021, 5:07 PM
prha committed R1:adc382f8c3f2: rename frontend classes that reference `Job` for schedules/sensors (authored by prha).
rename frontend classes that reference `Job` for schedules/sensors
Jun 30 2021, 5:07 PM
prha closed D8595: Rename Job graphene fields to use `Instigation` instead.
Jun 30 2021, 5:06 PM
prha committed R1:5138167c22c7: Rename Job graphene fields to use `Instigation` instead (authored by prha).
Rename Job graphene fields to use `Instigation` instead
Jun 30 2021, 5:06 PM
prha added a reviewer for D8595: Rename Job graphene fields to use `Instigation` instead: dgibson.
Jun 30 2021, 2:23 PM
prha abandoned D8580: asset sensor def.
Jun 30 2021, 3:39 AM
prha requested review of D8610: event log / instance api for event_records.
Jun 30 2021, 3:08 AM
prha abandoned D8607: event log / instance api for event_records.
Jun 30 2021, 2:44 AM
prha requested review of D8607: event log / instance api for event_records.
Jun 30 2021, 2:43 AM