Page MenuHomePhabricator
Feed Advanced Search

Today

prha added inline comments to D1855: Gaant-style execution plan visualization behind feature flag.
Tue, Jan 21, 9:57 PM

Thu, Jan 16

prha accepted D1852: remove deprecated ReexecutionConfig.
Thu, Jan 16, 6:23 PM
prha accepted D1847: [dagit] handle engine event errors.

lgtm

Thu, Jan 16, 5:35 PM
prha added a comment to D1852: remove deprecated ReexecutionConfig.

the error looks legit... might need to adjust the get_args py27 implementation?

Thu, Jan 16, 5:34 PM

Wed, Jan 15

prha added inline comments to D1845: add autocomplete values for config for scalar union types.
Wed, Jan 15, 7:29 PM
prha committed R1:e8bb9e3d3d09: add autocomplete values for config for scalar union types (authored by prha).
add autocomplete values for config for scalar union types
Wed, Jan 15, 6:51 PM
prha closed D1845: add autocomplete values for config for scalar union types.
Wed, Jan 15, 6:50 PM
prha updated the summary of D1845: add autocomplete values for config for scalar union types.
Wed, Jan 15, 12:40 AM
prha updated the diff for D1845: add autocomplete values for config for scalar union types.

flip token logic

Wed, Jan 15, 12:40 AM
prha created D1845: add autocomplete values for config for scalar union types.
Wed, Jan 15, 12:24 AM

Tue, Jan 14

prha added a comment to D1828: More clear name properties for config types and graphql scalar union support.

This all makes sense to me.... letting @alangenfeld take a look

Tue, Jan 14, 7:01 PM
prha requested changes to D1833: Add schedules to weather pipelines.

clearing queue

Tue, Jan 14, 6:45 PM
prha added a comment to D1833: Add schedules to weather pipelines.

As discussed offline, ideally, we'd run the backfill using a dagster pipeline backfill command instead of a custom pipeline.

Tue, Jan 14, 12:39 AM

Mon, Jan 13

prha accepted D1798: Replace playground subset selector with one that leverages solid query syntax.

This feels much better!

Mon, Jan 13, 4:54 PM
prha committed R1:14d6ea687bac: fix partition decorators to respect mode (authored by prha).
fix partition decorators to respect mode
Mon, Jan 13, 4:38 PM
prha closed D1820: fix partition decorators to respect mode.
Mon, Jan 13, 4:38 PM

Sat, Jan 11

prha added reviewers for D1820: fix partition decorators to respect mode: themissinghlink, sashank.
Sat, Jan 11, 12:37 AM
prha created D1820: fix partition decorators to respect mode.
Sat, Jan 11, 12:31 AM

Fri, Jan 10

prha committed R1:f19d0b1c621d: add changelog entry for schedule definition argument changes (authored by prha).
add changelog entry for schedule definition argument changes
Fri, Jan 10, 11:27 PM
prha closed D1818: add changelog entry for schedule definition argument changes.
Fri, Jan 10, 11:27 PM
prha updated the summary of D1818: add changelog entry for schedule definition argument changes.
Fri, Jan 10, 6:35 PM
prha created D1818: add changelog entry for schedule definition argument changes.
Fri, Jan 10, 6:26 PM
prha committed R1:ce9a7432b797: load dagit settings for queueing execution manager from dagster.yaml (authored by prha).
load dagit settings for queueing execution manager from dagster.yaml
Fri, Jan 10, 12:39 AM
prha closed D1795: load dagit settings for queueing execution manager from dagster.yaml.
Fri, Jan 10, 12:39 AM
prha updated the diff for D1795: load dagit settings for queueing execution manager from dagster.yaml.

rebase

Fri, Jan 10, 12:28 AM
prha updated the diff for D1795: load dagit settings for queueing execution manager from dagster.yaml.

add dagit settings info to dagit info panel

Fri, Jan 10, 12:20 AM

Thu, Jan 9

prha committed R1:aa100159551e: Pass instance into user-supplied env/tags functions to support complex… (authored by prha).
Pass instance into user-supplied env/tags functions to support complex…
Thu, Jan 9, 10:43 PM
prha closed D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.
Thu, Jan 9, 10:43 PM
prha updated the diff for D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.

resolve conflict with run storage refactor

Thu, Jan 9, 10:28 PM
prha updated the diff for D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.

rebase

Thu, Jan 9, 10:13 PM
prha updated the diff for D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.

use distinctly constructed context object in the scheduling context

Thu, Jan 9, 10:00 PM
prha updated the diff for D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.

renamed, moved DagsterInstanceContext to ScheduleExecutionContext, made it schedule specific.

Thu, Jan 9, 9:34 PM
prha added a comment to D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.

Ideally, we could just pass the DagsterGraphQLContext around, which would satisfy a number of interface checks (PartitionSelectionContext, SchedulingContext, etc), but it turns out to be a little awkward in Python so I punted on that to be as generic as possible.

Thu, Jan 9, 8:34 PM
prha accepted D1788: (1/n run-storage) Allow multiple tags in PipelineRunsFilter.
Thu, Jan 9, 8:04 PM
prha abandoned D1794: Relax dagster.yaml constraints to include more than instance config.
Thu, Jan 9, 8:01 PM
prha updated the diff for D1795: load dagit settings for queueing execution manager from dagster.yaml.

Adds a dagit settings section to the instance config... This keeps the dagit settings as a dictionary instead of a configurable class.

Thu, Jan 9, 7:13 PM
prha committed R1:e21036f8b16c: fix pylint error for s3 variable name (authored by prha).
fix pylint error for s3 variable name
Thu, Jan 9, 5:43 PM
prha closed D1809: fix pylint error for s3 variable name.
Thu, Jan 9, 5:43 PM
prha created D1809: fix pylint error for s3 variable name.
Thu, Jan 9, 5:39 PM
prha added a comment to D1795: load dagit settings for queueing execution manager from dagster.yaml.

that's a good question.... I always thought of dagit as being orthogonal to the dagster instance, but it makes things a lot simpler just to have this be on the instance config

Thu, Jan 9, 12:44 AM

Wed, Jan 8

prha accepted D1799: De-duplicate filter logic in SqlRunStorage.
Wed, Jan 8, 11:55 PM
prha requested changes to D1799: De-duplicate filter logic in SqlRunStorage.
Wed, Jan 8, 11:33 PM
prha accepted D1792: [RFC] Eliminate get_runs_with... methods on RunStorage and DagsterInstance.

killitwithfire

Wed, Jan 8, 11:10 PM
prha created Image Macro "killitwithfire".
Wed, Jan 8, 11:09 PM
prha accepted D1797: (2.5/n) Add get_runs_count method to RunStorage.
Wed, Jan 8, 10:55 PM
prha accepted D1791: [multiproc] handle solid subset.

yaytests

Wed, Jan 8, 10:54 PM
prha requested changes to D1797: (2.5/n) Add get_runs_count method to RunStorage.
Wed, Jan 8, 10:31 PM
prha accepted D1790: (2/n run-storage) Add get_runs method to RunStorage.
Wed, Jan 8, 10:22 PM
prha requested changes to D1798: Replace playground subset selector with one that leverages solid query syntax.
Wed, Jan 8, 10:20 PM
prha updated the test plan for D1795: load dagit settings for queueing execution manager from dagster.yaml.
Wed, Jan 8, 8:11 PM
prha added inline comments to D1790: (2/n run-storage) Add get_runs method to RunStorage.
Wed, Jan 8, 6:55 PM
prha updated the diff for D1795: load dagit settings for queueing execution manager from dagster.yaml.

fix missed callsite

Wed, Jan 8, 6:53 PM
prha updated the summary of D1794: Relax dagster.yaml constraints to include more than instance config.
Wed, Jan 8, 6:50 PM
prha created D1795: load dagit settings for queueing execution manager from dagster.yaml.
Wed, Jan 8, 6:44 PM
prha updated the diff for D1794: Relax dagster.yaml constraints to include more than instance config.

update

Wed, Jan 8, 6:37 PM
prha created D1794: Relax dagster.yaml constraints to include more than instance config.
Wed, Jan 8, 6:33 PM

Tue, Jan 7

prha abandoned D1772: enable multi-tag run filtering.
Tue, Jan 7, 10:20 PM
prha requested changes to D1790: (2/n run-storage) Add get_runs method to RunStorage.

we should add tests to test_run_storage.py

Tue, Jan 7, 9:59 PM
prha accepted D1787: (0/n run-storage) Update storage tags methods to take dictionary of tags instead of list of key values.

thankyou

Tue, Jan 7, 8:59 PM
prha added a reverting change for R1:4087f72fd9ba: Pin nbformat to less than 5.0.0: R1:546924e600f3: Revert "Pin nbformat to less than 5.0.0".
Tue, Jan 7, 8:57 PM
prha added a reverting change for D1783: Pin nbformat to less than 5.0.0: R1:546924e600f3: Revert "Pin nbformat to less than 5.0.0".
Tue, Jan 7, 8:57 PM
prha committed R1:546924e600f3: Revert "Pin nbformat to less than 5.0.0" (authored by prha).
Revert "Pin nbformat to less than 5.0.0"
Tue, Jan 7, 8:57 PM
prha closed D1789: Revert "Pin nbformat to less than 5.0.0".
Tue, Jan 7, 8:57 PM
prha committed R1:144727f745a4: Add gevent-based queue manager for SubprocessExecutionManager (authored by prha).
Add gevent-based queue manager for SubprocessExecutionManager
Tue, Jan 7, 8:54 PM
prha closed D1683: Add gevent-based queue manager for SubprocessExecutionManager.
Tue, Jan 7, 8:54 PM
prha updated the diff for D1683: Add gevent-based queue manager for SubprocessExecutionManager.

pull out run queueing into separate execution manager

Tue, Jan 7, 8:34 PM
prha added reviewers for D1789: Revert "Pin nbformat to less than 5.0.0": schrockn, max.
Tue, Jan 7, 6:25 PM
prha added a reverting change for R1:4087f72fd9ba: Pin nbformat to less than 5.0.0: D1789: Revert "Pin nbformat to less than 5.0.0".
Tue, Jan 7, 6:19 PM
prha added a reverting change for D1783: Pin nbformat to less than 5.0.0: D1789: Revert "Pin nbformat to less than 5.0.0".
Tue, Jan 7, 6:19 PM
prha created D1789: Revert "Pin nbformat to less than 5.0.0".
Tue, Jan 7, 6:19 PM
prha accepted D1781: add timeout to RemoteDagitRunLauncher.

raichu

Tue, Jan 7, 4:27 PM
prha added a comment to D1780: [dagit] add launch run button.

this just hangs for me right now...

Tue, Jan 7, 12:03 AM

Mon, Jan 6

prha committed R1:e4cf7de64780: add test coverage for backfill cli (authored by prha).
add test coverage for backfill cli
Mon, Jan 6, 11:16 PM
prha closed D1723: add test coverage for backfill cli.
Mon, Jan 6, 11:16 PM
prha updated the diff for D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.

rebase

Mon, Jan 6, 10:58 PM
prha added inline comments to D1781: add timeout to RemoteDagitRunLauncher.
Mon, Jan 6, 10:57 PM
prha abandoned D1784: pin nbformat to 4.4.0.
Mon, Jan 6, 10:38 PM
prha accepted D1783: Pin nbformat to less than 5.0.0.
Mon, Jan 6, 10:36 PM
prha added a comment to D1783: Pin nbformat to less than 5.0.0.

Can you add https://github.com/jupyter/nbformat/issues/155 to the description?

Mon, Jan 6, 10:35 PM
prha created D1784: pin nbformat to 4.4.0.
Mon, Jan 6, 10:34 PM
prha committed R1:dc2e4915f2ac: handle python 2.7 in seven.get_args (authored by prha).
handle python 2.7 in seven.get_args
Mon, Jan 6, 10:10 PM
prha closed D1779: handle python 2.7 in seven.get_args.
Mon, Jan 6, 10:10 PM
prha added inline comments to D1779: handle python 2.7 in seven.get_args.
Mon, Jan 6, 10:09 PM
prha added inline comments to D1779: handle python 2.7 in seven.get_args.
Mon, Jan 6, 10:09 PM
prha added a comment to D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.

should note, it's a breaking change that environment_dict_fn, tags_fn, and should_execute must take in the context as an arg...

Mon, Jan 6, 10:06 PM
prha updated the diff for D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.

Added context interface, for user-defined scheduler functions.

Mon, Jan 6, 9:54 PM
prha created D1779: handle python 2.7 in seven.get_args.
Mon, Jan 6, 7:09 PM
prha planned changes to D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.
Mon, Jan 6, 5:47 PM
prha committed R1:8259be8ba2da: Convert partition selectors from classes to functions (authored by prha).
Convert partition selectors from classes to functions
Mon, Jan 6, 5:36 PM
prha closed D1776: Convert partition selectors from classes to functions.
Mon, Jan 6, 5:36 PM
prha updated the diff for D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.

python 2.7 update

Mon, Jan 6, 1:21 AM

Sat, Jan 4

prha updated the diff for D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.

fix py27

Sat, Jan 4, 9:16 PM
prha created D1777: Pass instance into user-supplied env/tags functions to support complex partition selection logic.
Sat, Jan 4, 2:08 AM
prha updated the diff for D1776: Convert partition selectors from classes to functions.

update

Sat, Jan 4, 2:05 AM
prha updated the diff for D1776: Convert partition selectors from classes to functions.

tests, update

Sat, Jan 4, 1:45 AM
prha created D1776: Convert partition selectors from classes to functions.
Sat, Jan 4, 1:38 AM
prha resigned from D1775: Dagster Pandas Guide Docs.

will let other folks take a look...

Sat, Jan 4, 12:40 AM

Fri, Jan 3

prha added inline comments to D1775: Dagster Pandas Guide Docs.
Fri, Jan 3, 11:10 PM
prha accepted D1773: [dagit] add cause to PythonError.
Fri, Jan 3, 10:54 PM
prha planned changes to D1772: enable multi-tag run filtering.
Fri, Jan 3, 10:14 PM