Page MenuHomePhabricator
Feed Advanced Search

Thu, Jul 30

prha requested changes to D4038: displaying asset types in the asset menu.
Thu, Jul 30, 8:16 PM
prha committed R1:a047f403c548: mutate sys.modules instead of reassigning (authored by prha).
mutate sys.modules instead of reassigning
Thu, Jul 30, 7:10 PM
prha closed D4049: mutate sys.modules instead of reassigning.
Thu, Jul 30, 7:10 PM
prha requested review of D4049: mutate sys.modules instead of reassigning.
Thu, Jul 30, 6:39 PM
prha closed D3983: [run-repository-2] hide re-execution button based on the currently loaded repository.
Thu, Jul 30, 6:15 PM
prha committed R1:1eda9d66b1fb: [run-repository-2] hide re-execution button based on the currently loaded… (authored by prha).
[run-repository-2] hide re-execution button based on the currently loaded…
Thu, Jul 30, 6:15 PM
prha accepted D4044: docs_snippet test fix - skip download file in tests.
Thu, Jul 30, 4:42 AM

Wed, Jul 29

prha added inline comments to D4038: displaying asset types in the asset menu.
Wed, Jul 29, 11:53 PM
prha accepted D4026: fix issue with skipable output results 2.
Wed, Jul 29, 4:39 PM
prha accepted D4023: modifying metadata with prefix.

happy with how this turned out... thanks leor!

Wed, Jul 29, 4:28 PM
prha updated the diff for D3983: [run-repository-2] hide re-execution button based on the currently loaded repository.

update mocks

Wed, Jul 29, 4:25 PM
prha updated the diff for D3983: [run-repository-2] hide re-execution button based on the currently loaded repository.

update, use snapshot id

Wed, Jul 29, 2:52 AM

Tue, Jul 28

prha updated the diff for D3978: RFC: add origin information into the repository picker.
  • handle repository origin union, with grpc
Tue, Jul 28, 11:44 PM
prha added inline comments to D4023: modifying metadata with prefix.
Tue, Jul 28, 10:00 PM
prha added inline comments to D3977: solid-hook-1 @hook and HookDefinition.
Tue, Jul 28, 9:25 PM
prha added a comment to D4023: modifying metadata with prefix.

If everyone's on board with this approach, we should also update the docs for materializers.

Tue, Jul 28, 8:27 PM
prha added inline comments to D4023: modifying metadata with prefix.
Tue, Jul 28, 7:50 PM
prha abandoned D3982: [run-repository-1] add repository_name to pipeline run.

We may want to revisit this later, but for now abandoning in favor of simpler client-side checks / warnings

Tue, Jul 28, 7:38 PM
prha added a comment to D3977: solid-hook-1 @hook and HookDefinition.

I think this is looking pretty good! nice work...

Tue, Jul 28, 7:36 PM

Fri, Jul 24

prha added inline comments to D3985: Adding type info to materializations as metadata.
Fri, Jul 24, 9:39 PM
prha added inline comments to D3985: Adding type info to materializations as metadata.
Fri, Jul 24, 8:43 PM
prha added inline comments to D3985: Adding type info to materializations as metadata.
Fri, Jul 24, 8:29 PM
prha added inline comments to D3978: RFC: add origin information into the repository picker.
Fri, Jul 24, 4:28 PM

Thu, Jul 23

prha accepted D3667: dont create Executor in execute_plan.

I think this looks good to me! +1 to the Preparable homage

Thu, Jul 23, 9:35 PM
prha added inline comments to D3985: Adding type info to materializations as metadata.
Thu, Jul 23, 6:48 PM
prha added inline comments to D3985: Adding type info to materializations as metadata.
Thu, Jul 23, 6:47 PM
prha added inline comments to D3985: Adding type info to materializations as metadata.
Thu, Jul 23, 5:48 PM
prha updated the diff for D3978: RFC: add origin information into the repository picker.
  • update web tests
Thu, Jul 23, 5:34 PM
prha updated the diff for D3982: [run-repository-1] add repository_name to pipeline run.

remove example change

Thu, Jul 23, 4:24 PM
prha updated the diff for D3978: RFC: add origin information into the repository picker.
  • make code pointer metadata generic
Thu, Jul 23, 4:20 PM
prha retitled D3983: [run-repository-2] hide re-execution button based on the currently loaded repository from hide re-execution button based on the currently loaded repository to [run-repository-2] hide re-execution button based on the currently loaded repository.
Thu, Jul 23, 5:24 AM
prha added reviewers for D3982: [run-repository-1] add repository_name to pipeline run: schrockn, alangenfeld.
Thu, Jul 23, 5:23 AM
prha retitled D3982: [run-repository-1] add repository_name to pipeline run from [run-repository] add repository_name to pipeline run to [run-repository-1] add repository_name to pipeline run.
Thu, Jul 23, 5:23 AM
prha requested review of D3983: [run-repository-2] hide re-execution button based on the currently loaded repository.
Thu, Jul 23, 5:05 AM
prha requested review of D3982: [run-repository-1] add repository_name to pipeline run.
Thu, Jul 23, 5:03 AM
prha updated the diff for D3978: RFC: add origin information into the repository picker.
  • extract RepositoryInformation component
  • renamed python origin
  • added instance query, hook for dagit executable path
Thu, Jul 23, 4:31 AM

Wed, Jul 22

prha requested review of D3978: RFC: add origin information into the repository picker.
Wed, Jul 22, 10:15 PM
prha committed R1:593b166b079d: add linter for try/finally (authored by prha).
add linter for try/finally
Wed, Jul 22, 4:37 PM
prha closed D3893: add linter for try/finally.
Wed, Jul 22, 4:37 PM
prha updated the diff for D3893: add linter for try/finally.
  • allow import error handling to bubble up into register call
Wed, Jul 22, 4:32 PM
prha added inline comments to D3893: add linter for try/finally.
Wed, Jul 22, 4:01 PM

Tue, Jul 21

prha updated the diff for D3893: add linter for try/finally.
  • guard against import error
Tue, Jul 21, 4:56 PM

Mon, Jul 20

prha added inline comments to D3812: [RFC] solid hook built on top of events.
Mon, Jul 20, 8:29 PM
prha added inline comments to D3812: [RFC] solid hook built on top of events.
Mon, Jul 20, 7:59 PM
prha requested changes to D3812: [RFC] solid hook built on top of events.

This is looking pretty good!!

Mon, Jul 20, 5:38 PM
prha updated the diff for D3893: add linter for try/finally.
  • fix py27 requirements
Mon, Jul 20, 4:21 PM
prha updated the diff for D3893: add linter for try/finally.
  • add explicit dev requirement, bury yield in tree for tests
Mon, Jul 20, 3:59 PM
prha added inline comments to D3893: add linter for try/finally.
Mon, Jul 20, 3:55 PM

Fri, Jul 17

prha accepted D3889: Enable multi-selection (+cancel +deletion) of runs in the runs list #2661.

yep, this looks good to me!

Fri, Jul 17, 4:30 PM

Thu, Jul 16

prha committed R1:d3e97b762d6d: add asset_key to materialization event logs (authored by prha).
add asset_key to materialization event logs
Thu, Jul 16, 10:34 PM
prha closed D3929: add asset_key to materialization event logs.
Thu, Jul 16, 10:34 PM
prha added inline comments to D3929: add asset_key to materialization event logs.
Thu, Jul 16, 10:18 PM
prha updated the diff for D3929: add asset_key to materialization event logs.

rename Materialization => AssetMaterialization, Asset Key => asset_key

Thu, Jul 16, 10:16 PM
prha added a comment to D3929: add asset_key to materialization event logs.

Considered it, but it felt a little strange to me to be mutating the metadata entries like that.

Thu, Jul 16, 10:05 PM
prha added a comment to D3929: add asset_key to materialization event logs.
  • Fine with changing Materialization => Asset Materialization in the event type, but I don't feel that strongly about it and might be outside of the scope of this diff.
  • I think the metadata key can be completely arbitrary... there's no reason why it should be asset_key vs Asset Key. Users can specify whatever labels they want in their metadata.
  • For AssetMaterialization the asset key is the same as the label, but I was just considering relaxing that and adding an optional label parameter. At any rate, for legacy Materialization events, the two values are different, so they are not redundant in all cases.
Thu, Jul 16, 9:29 PM
prha accepted D3900: Delegate partition and scheduling method calls in dagster-graphql to the repository location instead of assuming they use the CLI API.

This all looks great.

Thu, Jul 16, 9:20 PM
prha updated the summary of D3929: add asset_key to materialization event logs.
Thu, Jul 16, 7:10 PM
prha committed R1:e7ac5a46d046: convert examples/docs/error messages to reference AssetMaterialization (authored by prha).
convert examples/docs/error messages to reference AssetMaterialization
Thu, Jul 16, 7:03 PM
prha closed D3907: convert examples/docs/error messages to reference AssetMaterialization.
Thu, Jul 16, 7:03 PM
prha requested review of D3929: add asset_key to materialization event logs.
Thu, Jul 16, 7:02 PM
prha accepted D3922: [dagster-graphql] Event.step -> Event.step_key.

push_n_pray

Thu, Jul 16, 6:57 PM
prha added a comment to D3922: [dagster-graphql] Event.step -> Event.step_key.

Code looks fine, but curious what the bug was....

Thu, Jul 16, 6:35 PM
prha updated the diff for D3907: convert examples/docs/error messages to reference AssetMaterialization.
  • remove optionally
Thu, Jul 16, 4:20 PM
prha updated the summary of D3907: convert examples/docs/error messages to reference AssetMaterialization.
Thu, Jul 16, 5:31 AM
prha updated the diff for D3907: convert examples/docs/error messages to reference AssetMaterialization.
  • add changelog; fix apidocs ref
Thu, Jul 16, 5:30 AM
prha retitled D3907: convert examples/docs/error messages to reference AssetMaterialization from convert examples to use AssetMaterialization to convert examples/docs/error messages to reference AssetMaterialization.
Thu, Jul 16, 4:56 AM
prha updated the diff for D3907: convert examples/docs/error messages to reference AssetMaterialization.
  • error messages
  • update docs
Thu, Jul 16, 4:50 AM

Wed, Jul 15

prha requested review of D3907: convert examples/docs/error messages to reference AssetMaterialization.
Wed, Jul 15, 11:40 PM
prha committed R1:542bcc820149: [asset-mat-4] convert examples/tests to use AssetMaterializations (authored by prha).
[asset-mat-4] convert examples/tests to use AssetMaterializations
Wed, Jul 15, 10:40 PM
prha closed D3870: [asset-mat-4] convert examples/tests to use AssetMaterializations.
Wed, Jul 15, 10:40 PM
prha added a comment to D3893: add linter for try/finally.

good catch, sandyryza

Wed, Jul 15, 10:29 PM
prha updated the diff for D3893: add linter for try/finally.
check linter test
Wed, Jul 15, 10:29 PM
prha updated the diff for D3870: [asset-mat-4] convert examples/tests to use AssetMaterializations.

rebase

Wed, Jul 15, 10:10 PM
prha committed R1:4f94721858fd: [asset-mat-3] Convert `file_handle_to_s3` to use `AssetMaterialization` (authored by prha).
[asset-mat-3] Convert `file_handle_to_s3` to use `AssetMaterialization`
Wed, Jul 15, 8:13 PM
prha closed D3869: [asset-mat-3] Convert `file_handle_to_s3` to use `AssetMaterialization`.
Wed, Jul 15, 8:13 PM
prha committed R1:800d9c843e72: [asset-mat-2] Have dagstermill solid automatically emit AssetMaterializations (authored by prha).
[asset-mat-2] Have dagstermill solid automatically emit AssetMaterializations
Wed, Jul 15, 8:12 PM
prha closed D3867: [asset-mat-2] Have dagstermill solid automatically emit AssetMaterializations.
Wed, Jul 15, 8:11 PM
prha committed R1:c5ec91b36d2e: [asset-mat-1] define asset materalization (authored by prha).
[asset-mat-1] define asset materalization
Wed, Jul 15, 8:10 PM
prha closed D3866: [asset-mat-1] define asset materalization.
Wed, Jul 15, 8:10 PM
prha updated the diff for D3866: [asset-mat-1] define asset materalization.

rebase, switch to constructor flag

Wed, Jul 15, 7:54 PM
prha committed R1:58be09ddb2c3: add PersistentTuple, to add layer of indirection from serialization (authored by prha).
add PersistentTuple, to add layer of indirection from serialization
Wed, Jul 15, 7:01 PM
prha closed D3809: add PersistentTuple, to add layer of indirection from serialization.
Wed, Jul 15, 7:01 PM
prha requested changes to D3889: Enable multi-selection (+cancel +deletion) of runs in the runs list #2661.
Wed, Jul 15, 5:53 PM
prha accepted D3886: Make config editor help a split pane to avoid overlapping text #2681.

lgtm!

Wed, Jul 15, 5:34 PM
prha accepted D3899: Fix confusing unmatched quote.
Wed, Jul 15, 5:27 PM
prha added a comment to D3812: [RFC] solid hook built on top of events.

Yeah, this is interesting... Do we anticipate being able to add hooks for any arbitrary event type? The signature we have at the moment is generic enough to handle that.

Wed, Jul 15, 5:25 PM
prha updated the diff for D3893: add linter for try/finally.
  • rename
Wed, Jul 15, 4:35 PM
prha added a comment to D3893: add linter for try/finally.

Probably performance-wise this should be a generic Dagster checker instead of a finally-yield specific checker. and then we could just add specific warnings.

Wed, Jul 15, 4:26 PM
prha requested review of D3893: add linter for try/finally.
Wed, Jul 15, 2:04 AM

Tue, Jul 14

prha added inline comments to D3866: [asset-mat-1] define asset materalization.
Tue, Jul 14, 5:01 PM
prha accepted D3878: Use sys.executable instead of 'python' in Popen calls.

love to hear the story on this find

Tue, Jul 14, 3:07 PM

Mon, Jul 13

prha requested review of D3870: [asset-mat-4] convert examples/tests to use AssetMaterializations.
Mon, Jul 13, 9:35 PM
prha requested review of D3869: [asset-mat-3] Convert `file_handle_to_s3` to use `AssetMaterialization`.
Mon, Jul 13, 9:35 PM
prha requested review of D3867: [asset-mat-2] Have dagstermill solid automatically emit AssetMaterializations.
Mon, Jul 13, 9:34 PM
prha requested review of D3866: [asset-mat-1] define asset materalization.
Mon, Jul 13, 9:30 PM
prha retitled D3809: add PersistentTuple, to add layer of indirection from serialization from RFC: add PersistentTuple, to add layer of indirection from serialization to add PersistentTuple, to add layer of indirection from serialization.
Mon, Jul 13, 9:09 PM
prha updated the diff for D3809: add PersistentTuple, to add layer of indirection from serialization.
  • remove default_to_storage_value default
Mon, Jul 13, 8:49 PM

Fri, Jul 10

prha updated the diff for D3809: add PersistentTuple, to add layer of indirection from serialization.
rebase
Fri, Jul 10, 11:53 PM
prha added inline comments to D3809: add PersistentTuple, to add layer of indirection from serialization.
Fri, Jul 10, 11:37 PM
prha added a comment to D3809: add PersistentTuple, to add layer of indirection from serialization.

I think _check_serdes_tuple_class_invariants is actually fine... it's checking the __new__ arguments against the underlying named tuple. None of those invariants should change, since we're still supporting the constructor both for persistable and the non-persistable...

Fri, Jul 10, 11:36 PM