Page MenuHomePhabricator
Feed Advanced Search

Yesterday

prha added inline comments to D4837: RFC: rename executable => job.
Wed, Oct 21, 10:31 PM
prha closed D4764: add summary table for asset keys.
Wed, Oct 21, 9:51 PM
prha committed R1:c9d926cb9bd5: add summary table for asset keys (authored by prha).
add summary table for asset keys
Wed, Oct 21, 9:51 PM
prha added inline comments to D4764: add summary table for asset keys.
Wed, Oct 21, 7:32 PM
prha abandoned D4852: tests for asset secondary index.
Wed, Oct 21, 7:26 PM
prha closed D4440: extract run graph utils from partition-specific graphs.
Wed, Oct 21, 7:26 PM
prha committed R1:bf11df10545b: extract run graph utils from partition-specific graphs (authored by prha).
extract run graph utils from partition-specific graphs
Wed, Oct 21, 7:26 PM
prha updated the diff for D4440: extract run graph utils from partition-specific graphs.

regen types

Wed, Oct 21, 7:17 PM
prha updated the diff for D4440: extract run graph utils from partition-specific graphs.

rebase

Wed, Oct 21, 5:55 PM
prha added inline comments to D4764: add summary table for asset keys.
Wed, Oct 21, 4:10 PM
prha requested review of D4852: tests for asset secondary index.
Wed, Oct 21, 3:25 PM
prha updated the diff for D4764: add summary table for asset keys.

tests

Wed, Oct 21, 3:19 PM
prha retitled D4837: RFC: rename executable => job from rename executable => job to RFC: rename executable => job.
Wed, Oct 21, 3:07 PM
prha closed D4800: Add table to track migration of secondary indexes on the event_log table.
Wed, Oct 21, 2:44 PM
prha committed R1:3e602b0902d6: Add table to track migration of secondary indexes on the event_log table (authored by prha).
Add table to track migration of secondary indexes on the event_log table
Wed, Oct 21, 2:44 PM
prha updated the diff for D4800: Add table to track migration of secondary indexes on the event_log table.

tests, rebase

Wed, Oct 21, 2:17 PM
prha retitled D4800: Add table to track migration of secondary indexes on the event_log table from RFC: Add table to track migration of secondary indexes on the event_log table to Add table to track migration of secondary indexes on the event_log table.
Wed, Oct 21, 2:14 PM

Tue, Oct 20

prha accepted D4841: memoize get_alembic_config.

good find

Tue, Oct 20, 10:44 PM
prha accepted D4842: short circuit canTerm logic.

should we track the API change in a GH issues somewhere?

Tue, Oct 20, 10:35 PM
prha accepted D4787: Require that start_date be on a month/day boundary for monthly/daily schedules.
Tue, Oct 20, 9:06 PM
prha accepted D4809: Clean up partitions UI and improve backfill usability.

I think the textarea could be a little beginner-friendly in terms of the syntax, but we can iterate and see what folks think

Tue, Oct 20, 9:04 PM
prha requested review of D4837: RFC: rename executable => job.
Tue, Oct 20, 8:45 PM
prha accepted D4691: Basic display of asset partition coverage / value by partition.

This looks good!

Tue, Oct 20, 6:27 PM
prha accepted D4813: Maintain backcompat in date_partition_range.
Tue, Oct 20, 6:17 PM
prha added inline comments to D4813: Maintain backcompat in date_partition_range.
Tue, Oct 20, 4:22 PM
prha added a comment to D4809: Clean up partitions UI and improve backfill usability.

I kind of like the codemirror idea... and having yaml removes the requirement to learn another DSL.

Tue, Oct 20, 4:19 PM
prha accepted D4827: Append "_location" to default repository location name.
Tue, Oct 20, 4:10 PM
prha accepted D4823: Ensure that origins don't change when we switch from cli api repos to grpc repos.
Tue, Oct 20, 4:05 PM
prha added inline comments to D4813: Maintain backcompat in date_partition_range.
Tue, Oct 20, 3:53 PM
prha requested changes to D4691: Basic display of asset partition coverage / value by partition.

Code looks okay, but hitting lots of merge conflicts... Req'ing for rebase.

Tue, Oct 20, 3:42 PM
prha closed D4812: remove backfill check for step selection.
Tue, Oct 20, 2:44 PM
prha committed R1:7806dc0e8232: remove backfill check for step selection (authored by prha).
remove backfill check for step selection
Tue, Oct 20, 2:44 PM
prha updated the diff for D4764: add summary table for asset keys.

update doc, messages

Tue, Oct 20, 2:43 PM
prha added inline comments to D4764: add summary table for asset keys.
Tue, Oct 20, 2:43 PM
prha updated the diff for D4764: add summary table for asset keys.

remove test for removed migration

Tue, Oct 20, 2:31 PM

Mon, Oct 19

prha updated the diff for D4764: add summary table for asset keys.

black

Mon, Oct 19, 10:20 PM
prha added inline comments to D4764: add summary table for asset keys.
Mon, Oct 19, 10:15 PM
prha updated the diff for D4764: add summary table for asset keys.

rebase, add more logging to migration script

Mon, Oct 19, 10:15 PM
prha updated the diff for D4800: Add table to track migration of secondary indexes on the event_log table.
comments
Mon, Oct 19, 9:55 PM
prha added inline comments to D4800: Add table to track migration of secondary indexes on the event_log table.
Mon, Oct 19, 7:15 PM
prha requested review of D4812: remove backfill check for step selection.
Mon, Oct 19, 5:54 PM
prha updated the diff for D4800: Add table to track migration of secondary indexes on the event_log table.

update

Mon, Oct 19, 5:12 PM
prha updated the diff for D4800: Add table to track migration of secondary indexes on the event_log table.

remove hard-coded version check

Mon, Oct 19, 4:14 PM
prha updated the diff for D4800: Add table to track migration of secondary indexes on the event_log table.

update, share secondary_indexes table across run, event_log storage.

Mon, Oct 19, 3:08 PM
prha requested changes to D4809: Clean up partitions UI and improve backfill usability.

Still doesn't seem possible to set subset selection for the partitions with no runs. Is that going to be part of this diff?

Mon, Oct 19, 1:16 PM
prha added a comment to D4788: RFC: Add partitions to arbitrary cron-based schedules.

Yeah, I think this looks reasonable. Let's add some tests to document the behavior we're going for?

Mon, Oct 19, 12:38 PM

Fri, Oct 16

prha updated the diff for D4764: add summary table for asset keys.

add cli argument to iterate through list of reindex migrations

Fri, Oct 16, 8:48 PM
prha updated the diff for D4764: add summary table for asset keys.

black

Fri, Oct 16, 6:20 PM
prha updated the diff for D4764: add summary table for asset keys.

fix super signature

Fri, Oct 16, 4:50 PM
prha planned changes to D4764: add summary table for asset keys.
Fri, Oct 16, 4:45 PM
prha updated the diff for D4764: add summary table for asset keys.

build upon D4800, use secondary index to track asset key table migration

Fri, Oct 16, 4:22 PM
prha accepted D4801: [easy] Fix missing param change in date_partition_range call.
Fri, Oct 16, 3:07 PM
prha updated the summary of D4800: Add table to track migration of secondary indexes on the event_log table.
Fri, Oct 16, 2:59 PM
prha requested review of D4800: Add table to track migration of secondary indexes on the event_log table.
Fri, Oct 16, 2:39 PM
prha accepted D4538: Write non-error execution logs to stdout instead of stderr, only surface stderr from child processes in host processes like the scheduler.
Fri, Oct 16, 2:20 PM

Thu, Oct 15

prha accepted D4736: [RFC] DagsterInstance.optimize_for_dagit.
Thu, Oct 15, 7:59 PM
prha closed D4771: add prefix to asset key query.
Thu, Oct 15, 2:40 PM
prha committed R1:262abbfc215a: add prefix to asset key query (authored by prha).
add prefix to asset key query
Thu, Oct 15, 2:40 PM
prha updated the diff for D4771: add prefix to asset key query.

rebase for k8s pin

Thu, Oct 15, 1:58 PM
prha updated the diff for D4771: add prefix to asset key query.

web snapshots

Thu, Oct 15, 3:23 AM
prha updated the diff for D4771: add prefix to asset key query.

refactor asset UI into root catalog, and a matching page, which first checks for exact asset key matches, and then falls back to a prefix search

Thu, Oct 15, 1:53 AM

Wed, Oct 14

prha closed D4773: fix graphql errors for runs using int event metadata.
Wed, Oct 14, 8:42 PM
prha committed R1:aba11a976646: fix graphql errors for runs using int event metadata (authored by prha).
fix graphql errors for runs using int event metadata
Wed, Oct 14, 8:41 PM
prha planned changes to D4771: add prefix to asset key query.
Wed, Oct 14, 8:03 PM
prha closed D4780: fix longitudinal config.
Wed, Oct 14, 5:21 PM
prha committed R1:7fe991fef88b: fix longitudinal config (authored by prha).
fix longitudinal config
Wed, Oct 14, 5:20 PM
prha requested review of D4780: fix longitudinal config.
Wed, Oct 14, 5:18 PM
prha updated the diff for D4764: add summary table for asset keys.

remove counter (thanks @max!!)

Wed, Oct 14, 4:47 PM
prha planned changes to D4764: add summary table for asset keys.
Wed, Oct 14, 3:46 PM
prha updated the diff for D4764: add summary table for asset keys.

use postgres upsert

Wed, Oct 14, 3:18 PM
prha added inline comments to D4764: add summary table for asset keys.
Wed, Oct 14, 2:43 PM

Tue, Oct 13

prha updated the summary of D4773: fix graphql errors for runs using int event metadata.
Tue, Oct 13, 11:15 PM
prha requested review of D4773: fix graphql errors for runs using int event metadata.
Tue, Oct 13, 11:02 PM
prha requested review of D4771: add prefix to asset key query.
Tue, Oct 13, 9:43 PM
prha updated the summary of D4764: add summary table for asset keys.
Tue, Oct 13, 6:17 PM
prha updated the summary of D4764: add summary table for asset keys.
Tue, Oct 13, 5:45 PM
prha requested review of D4764: add summary table for asset keys.
Tue, Oct 13, 5:13 PM

Mon, Oct 12

prha added a comment to D4538: Write non-error execution logs to stdout instead of stderr, only surface stderr from child processes in host processes like the scheduler.

Hmm, I'm not sure there's a reason for it to go to stderr... but it's been that way forever.

Mon, Oct 12, 10:34 PM

Sep 20 2020

prha accepted D4488: black pipeline_base.
Sep 20 2020, 7:58 PM

Sep 18 2020

prha closed D4467: TriggeredExecutionDefinition => ExecutableDefinition.
Sep 18 2020, 11:02 PM
prha committed R1:fe9ce517ebef: TriggeredExecutionDefinition => ExecutableDefinition (authored by prha).
TriggeredExecutionDefinition => ExecutableDefinition
Sep 18 2020, 11:02 PM
prha committed R1:d3874896e7d0: ExecutablePipeline => IPipeline (authored by prha).
ExecutablePipeline => IPipeline
Sep 18 2020, 11:00 PM
prha closed D4458: ExecutablePipeline => IPipeline.
Sep 18 2020, 11:00 PM
prha renamed Image Macro "flatcircle" from timeisaflatcircle to flatcircle.
Sep 18 2020, 10:59 PM
prha requested review of D4483: fix relative links in module docs.
Sep 18 2020, 8:58 PM
prha committed R1:ba44bc89db11: add instructions for setting up .env file for docs release (authored by prha).
add instructions for setting up .env file for docs release
Sep 18 2020, 5:23 PM
prha closed D4478: add instructions for setting up .env file for docs release.
Sep 18 2020, 5:23 PM
prha published D4478: add instructions for setting up .env file for docs release for review.
Sep 18 2020, 5:13 PM
prha closed D4477: look for default api key / app id values for .env file.
Sep 18 2020, 5:12 PM
prha closed D4476: add arc to docsearch repo.
Sep 18 2020, 5:12 PM
prha updated the diff for D4477: look for default api key / app id values for .env file.

update to use admin key for api key

Sep 18 2020, 5:00 PM
prha added a reviewer for D4477: look for default api key / app id values for .env file: yuhan.
Sep 18 2020, 4:51 PM
prha added a reviewer for D4476: add arc to docsearch repo: yuhan.
Sep 18 2020, 4:37 PM
prha requested review of D4477: look for default api key / app id values for .env file.
Sep 18 2020, 4:33 PM
prha requested review of D4476: add arc to docsearch repo.
Sep 18 2020, 4:31 PM
prha accepted D4460: Use react-router Link for nav.
Sep 18 2020, 3:47 PM
prha committed R1:ac4a40b54b56: remove partition graphs from schedule view (authored by prha).
remove partition graphs from schedule view
Sep 18 2020, 3:41 PM
prha closed D4448: remove partition graphs from schedule view.
Sep 18 2020, 3:41 PM
prha committed R1:c33ff597400e: Remove filler pages (authored by prha).
Remove filler pages
Sep 18 2020, 12:49 AM
prha closed D4468: Remove filler pages.
Sep 18 2020, 12:49 AM