Dec 6 2019
My only concern is that this is too tailored towards our current examples and will have an adverse effect on dags where there is no correlation between naming and distance
Safe now that https://dagster.phacility.com/D1544 landed
Dec 5 2019
actually delete test
@bengotow I think this might be the breaking point for doing a more fundamental server side rearchitecture of the config type system. there are some really problematic core aspects of it that this is exposing. I did throw up a hack that gets this working but not the best at all https://dagster.phacility.com/D1544
I'm actually seeing crashes now in the config editor with this applied
Dec 4 2019
Dec 3 2019
will look more later, but this is really smooth
I may opt-in all these pipelines into the strict mode, however
Not going to make this is the default for now.
go back to old diff (also differential is so good)
👍🏻 @alangenfeld agree let's chat when you are in tmrw
Dec 2 2019
agree with alex. i don't think these have hit the level of utility yet to warrant incorporation to a library that we are on the hook supporting
I'm going to pop this off folks' queues for now. Let's see if we actually need this.
change from skip to xfail
@alangenfeld i agree it's a concern and there's no rush to merge. in fact totally willing to wait for more instances of user feedback since it does muddy the model and injects complexity (as is evidenced by all the error conditions I needed to test for)
Dec 1 2019
yeah let's go ahead and merge this.
Migrating the test suite is a pretty modest change: https://dagster.phacility.com/D1524
Nov 30 2019
We should also consider the case where the configuration has changed and can no longer be parsed.
Also a tip of the hat to one @alangenfeld for the excellent implementation of the dep dsl. This was very straightforward to add. Vast, vast majority of the time was spent writing tests and delineating error states and helpful error messages. The core functionality is implemented in only 3 one-liner methods.
Nov 29 2019
funny enough trying the bitwise or approach over here https://dagster.phacility.com/D1512
Nov 28 2019
this is lovely
Great. Please add the comment so that we have a record for why the network-only is there.
Nov 27 2019
resigning until sashank takes a looksie. if changes are substantial plz readd me