Page MenuHomePhabricator
Feed Advanced Search

Today

schrockn accepted D1043: Improve error message with path of bad log file.
Tue, Sep 17, 12:02 AM
schrockn requested changes to D1025: [RFC] Extract scheduler from RepositoryDefinition using ExecutionTargetHandle.

why do you we need the Scheduler to take a DagsterInstance? This seems like the inverse of the dependency that we want? It looks like you only use it for _schedule_dir which is unused?

Tue, Sep 17, 12:02 AM

Yesterday

schrockn accepted D1040: Poor man's serdes compatibility.

plz heed final comments

Mon, Sep 16, 11:58 PM
schrockn requested changes to D1042: Correctly deserialize intermediate lists of custom types from multiple outputs.
Mon, Sep 16, 11:37 PM
schrockn requested changes to D1040: Poor man's serdes compatibility.

let's not use default args

Mon, Sep 16, 11:26 PM
schrockn requested changes to D1040: Poor man's serdes compatibility.
Mon, Sep 16, 7:31 PM
schrockn accepted D985: Basic implementation of search through run history.
Mon, Sep 16, 3:48 PM

Sat, Sep 14

schrockn updated the diff for D1037: Add test cases for various list combinations.

elim circular dep

Sat, Sep 14, 12:58 AM
schrockn created D1037: Add test cases for various list combinations.
Sat, Sep 14, 12:49 AM

Fri, Sep 13

schrockn abandoned D1026: See if i need to split up.
Fri, Sep 13, 10:38 PM
schrockn abandoned D1027: Extract typing_api.
Fri, Sep 13, 10:38 PM
schrockn abandoned D1028: (new-dict-api-5) Support typing.Dict.
Fri, Sep 13, 10:38 PM
schrockn committed R1:92745c226b9a: (new-dict-api-7) Solids can now accept typing.Dicts (authored by schrockn).
(new-dict-api-7) Solids can now accept typing.Dicts
Fri, Sep 13, 10:00 PM
schrockn closed D1033: (new-dict-api-7) Solids can now accept typing.Dicts.
Fri, Sep 13, 10:00 PM
schrockn updated the diff for D1033: (new-dict-api-7) Solids can now accept typing.Dicts.

up

Fri, Sep 13, 9:42 PM
schrockn updated the diff for D1033: (new-dict-api-7) Solids can now accept typing.Dicts.

up

Fri, Sep 13, 9:34 PM
schrockn updated the diff for D1033: (new-dict-api-7) Solids can now accept typing.Dicts.

don't use typehint variants any more

Fri, Sep 13, 9:30 PM
schrockn updated the diff for D1033: (new-dict-api-7) Solids can now accept typing.Dicts.

up

Fri, Sep 13, 8:52 PM
schrockn committed R1:c40886bed6a3: (new-dict-api-6) Make functions callable in python 2 and add… (authored by schrockn).
(new-dict-api-6) Make functions callable in python 2 and add…
Fri, Sep 13, 8:42 PM
schrockn closed D1032: (new-dict-api-6) Make functions callable in python 2 and add is_closed_python_dict_type.
Fri, Sep 13, 8:42 PM
schrockn committed R1:38d8853793a9: (new-dict-api-5) Make typehint functions throw in py2 (authored by schrockn).
(new-dict-api-5) Make typehint functions throw in py2
Fri, Sep 13, 8:41 PM
schrockn closed D1031: (new-dict-api-5) Make typehint functions throw in py2.
Fri, Sep 13, 8:41 PM
schrockn accepted D1024: change FS event storage to sqlite.
Fri, Sep 13, 8:39 PM
schrockn updated the diff for D1033: (new-dict-api-7) Solids can now accept typing.Dicts.

rebase

Fri, Sep 13, 6:01 PM
schrockn updated the diff for D1032: (new-dict-api-6) Make functions callable in python 2 and add is_closed_python_dict_type.

up

Fri, Sep 13, 6:00 PM
schrockn created D1033: (new-dict-api-7) Solids can now accept typing.Dicts.
Fri, Sep 13, 5:58 PM
schrockn created D1032: (new-dict-api-6) Make functions callable in python 2 and add is_closed_python_dict_type.
Fri, Sep 13, 5:36 PM
schrockn created D1031: (new-dict-api-5) Make typehint functions throw in py2.
Fri, Sep 13, 5:22 PM
schrockn updated the diff for D1028: (new-dict-api-5) Support typing.Dict.

up

Fri, Sep 13, 4:32 PM
schrockn updated the diff for D1028: (new-dict-api-5) Support typing.Dict.

up

Fri, Sep 13, 4:19 PM
schrockn updated the diff for D1028: (new-dict-api-5) Support typing.Dict.

up

Fri, Sep 13, 4:12 PM
schrockn committed R1:76cfb6685c79: (new-dict-api-4) Move typing helpers to a file to form a coherent api (authored by schrockn).
(new-dict-api-4) Move typing helpers to a file to form a coherent api
Fri, Sep 13, 3:53 PM
schrockn closed D1022: (new-dict-api-4) Move typing helpers to a file to form a coherent api.
Fri, Sep 13, 3:53 PM
schrockn committed R1:6e3d9d0bad23: (new-dict-api-3) Add typed variant of runtime dictionary (authored by schrockn).
(new-dict-api-3) Add typed variant of runtime dictionary
Fri, Sep 13, 3:29 PM
schrockn closed D1018: (new-dict-api-3) Add typed variant of runtime dictionary.
Fri, Sep 13, 3:29 PM
schrockn abandoned D942: Allow bare Dict in both runtime and config contexts (stacked on D927).
Fri, Sep 13, 1:57 PM
schrockn abandoned D927: Support python dictionaries as inputs and outputs.
Fri, Sep 13, 1:56 PM
schrockn created D1028: (new-dict-api-5) Support typing.Dict.
Fri, Sep 13, 1:09 PM
schrockn updated the diff for D1027: Extract typing_api.

up

Fri, Sep 13, 1:05 PM
schrockn updated the summary of D1027: Extract typing_api.
Fri, Sep 13, 12:59 PM
schrockn updated the diff for D1027: Extract typing_api.

up

Fri, Sep 13, 12:58 PM
schrockn updated the diff for D1027: Extract typing_api.

up

Fri, Sep 13, 12:52 PM
schrockn updated the diff for D1027: Extract typing_api.

up

Fri, Sep 13, 12:41 PM
schrockn created D1027: Extract typing_api.
Fri, Sep 13, 12:36 PM
schrockn created D1026: See if i need to split up.
Fri, Sep 13, 12:33 PM
schrockn updated the diff for D1018: (new-dict-api-3) Add typed variant of runtime dictionary.

up

Fri, Sep 13, 12:21 PM

Thu, Sep 12

schrockn added inline comments to D1024: change FS event storage to sqlite.
Thu, Sep 12, 11:01 PM
schrockn requested changes to D1024: change FS event storage to sqlite.

put close in finally block or @contextmanager

Thu, Sep 12, 10:59 PM
schrockn updated the diff for D1022: (new-dict-api-4) Move typing helpers to a file to form a coherent api.

up

Thu, Sep 12, 10:34 PM
schrockn updated the diff for D1018: (new-dict-api-3) Add typed variant of runtime dictionary.

rebase

Thu, Sep 12, 10:12 PM
schrockn committed R1:9a42662896fc: (new-dict-api-2) Support python dictionaries as inputs and outputs (authored by schrockn).
(new-dict-api-2) Support python dictionaries as inputs and outputs
Thu, Sep 12, 10:11 PM
schrockn closed D1017: (new-dict-api-2) Support python dictionaries as inputs and outputs.
Thu, Sep 12, 10:11 PM
schrockn updated the diff for D1022: (new-dict-api-4) Move typing helpers to a file to form a coherent api.

upmessage

Thu, Sep 12, 8:29 PM
schrockn updated the diff for D1018: (new-dict-api-3) Add typed variant of runtime dictionary.

up

Thu, Sep 12, 8:27 PM
schrockn updated the diff for D1017: (new-dict-api-2) Support python dictionaries as inputs and outputs.

up

Thu, Sep 12, 8:26 PM
schrockn committed R1:b59f39b3f3f9: (new-dict-api-1) Move current Dict to global object with __call__ (authored by schrockn).
(new-dict-api-1) Move current Dict to global object with __call__
Thu, Sep 12, 8:22 PM
schrockn closed D1016: (new-dict-api-1) Move current Dict to global object with __call__.
Thu, Sep 12, 8:22 PM
schrockn updated the diff for D1022: (new-dict-api-4) Move typing helpers to a file to form a coherent api.

up

Thu, Sep 12, 5:29 PM
schrockn created D1022: (new-dict-api-4) Move typing helpers to a file to form a coherent api.
Thu, Sep 12, 5:18 PM
schrockn added a comment to D1012: move core PipelineRun creation call.

seems mostly very good

Thu, Sep 12, 4:13 PM
schrockn updated the diff for D1018: (new-dict-api-3) Add typed variant of runtime dictionary.

more tests

Thu, Sep 12, 4:04 PM
schrockn abandoned D365: Add solidDefinitions root call.
Thu, Sep 12, 12:46 AM

Wed, Sep 11

schrockn updated the diff for D1018: (new-dict-api-3) Add typed variant of runtime dictionary.

upmessage

Wed, Sep 11, 11:45 PM
schrockn created D1018: (new-dict-api-3) Add typed variant of runtime dictionary.
Wed, Sep 11, 11:44 PM
schrockn updated the diff for D1017: (new-dict-api-2) Support python dictionaries as inputs and outputs.

upmessage

Wed, Sep 11, 11:22 PM
schrockn updated the diff for D1017: (new-dict-api-2) Support python dictionaries as inputs and outputs.

up

Wed, Sep 11, 11:21 PM
schrockn updated the diff for D1017: (new-dict-api-2) Support python dictionaries as inputs and outputs.

up

Wed, Sep 11, 11:19 PM
schrockn updated the diff for D1017: (new-dict-api-2) Support python dictionaries as inputs and outputs.

up

Wed, Sep 11, 11:17 PM
schrockn created D1017: (new-dict-api-2) Support python dictionaries as inputs and outputs.
Wed, Sep 11, 11:09 PM
schrockn created D1016: (new-dict-api-1) Move current Dict to global object with __call__.
Wed, Sep 11, 11:05 PM
schrockn updated the diff for D942: Allow bare Dict in both runtime and config contexts (stacked on D927).

rebase

Wed, Sep 11, 10:35 PM
schrockn updated the diff for D927: Support python dictionaries as inputs and outputs.

rebase

Wed, Sep 11, 10:35 PM
schrockn requested changes to D1011: TODO: Split into two diffs.

why are we doing airflow changes in a diff titled "Fixes for Dask execution"?

Wed, Sep 11, 10:31 PM
schrockn accepted D1000: [core] remove EventSink.
Wed, Sep 11, 10:23 PM
schrockn requested changes to D1007: RFC: rough sketch of compute function retries.

going to do run-based retry first yes?

Wed, Sep 11, 10:21 PM
schrockn accepted D1008: Display natural language representation of cron string.
Wed, Sep 11, 10:21 PM
schrockn added a comment to D1008: Display natural language representation of cron string.

can you post screenshot of UI with a complicated cron string

Wed, Sep 11, 10:15 PM
schrockn accepted D1014: remove feature flags for dagit log viewer.

makeitso

Wed, Sep 11, 10:14 PM
schrockn committed R1:f4b190de40fe: First go at postgres event watcher (authored by schrockn).
First go at postgres event watcher
Wed, Sep 11, 9:44 PM
schrockn closed D987: First go at postgres event watcher.
Wed, Sep 11, 9:44 PM
schrockn added inline comments to D987: First go at postgres event watcher.
Wed, Sep 11, 9:44 PM
schrockn updated the diff for D987: First go at postgres event watcher.

up

Wed, Sep 11, 8:35 PM
schrockn updated the diff for D987: First go at postgres event watcher.

up

Wed, Sep 11, 8:29 PM
schrockn updated the diff for D987: First go at postgres event watcher.

up

Wed, Sep 11, 8:17 PM
schrockn added inline comments to D1010: Add start and resume methods to Scheduler.
Wed, Sep 11, 4:41 PM
schrockn abandoned D997: Check out this skethcy jsonb ish.

I say we don't do this for now. I think it will be cool to have the same schema between sqlite and postgres

Wed, Sep 11, 4:34 PM
schrockn requested changes to D1008: Display natural language representation of cron string.

What do we do in the case where there is a cron string that is difficult or impossible to translate to a string?

Wed, Sep 11, 2:15 PM
schrockn accepted D918: RFC: Add mutation for executing pipeline with preset.

I'm into this.

Wed, Sep 11, 2:07 PM
schrockn accepted D1009: Rename dagster schedules command to schedule.
Wed, Sep 11, 2:01 PM
schrockn requested changes to D946: Store executionMetadata tags on PipelineRunData.
Wed, Sep 11, 2:21 AM
schrockn accepted D1003: Use executePlan within dagster-graphql-mediated execution engines.

this is great.

Wed, Sep 11, 2:13 AM
schrockn accepted D1004: fix expand view for composite solids.
Wed, Sep 11, 12:19 AM

Tue, Sep 10

schrockn added a comment to D987: First go at postgres event watcher.

Not tied to this approach. Pain in the butt to get working but there could be other ways that I haven't considered.

Tue, Sep 10, 9:51 PM
schrockn updated the diff for D987: First go at postgres event watcher.

Ready for Review

Tue, Sep 10, 9:45 PM
schrockn accepted D1001: Add examples of schedules.

🙌🏻

Tue, Sep 10, 9:32 PM
schrockn updated the diff for D987: First go at postgres event watcher.

up

Tue, Sep 10, 9:31 PM
schrockn added a comment to D1001: Add examples of schedules.

script_relative_path is hugely expensive (like 1 ms per call)

Tue, Sep 10, 9:28 PM
schrockn requested changes to D1001: Add examples of schedules.

Actually we should be encouraging use of file_relative_path

Tue, Sep 10, 9:28 PM
schrockn updated the diff for D987: First go at postgres event watcher.

up

Tue, Sep 10, 9:27 PM
schrockn updated the diff for D987: First go at postgres event watcher.

up

Tue, Sep 10, 9:17 PM