Page MenuHomePhabricator
Feed Advanced Search

Today

schrockn updated the diff for D1864: RFC: is_optional --> is_required.

rebase

Thu, Jan 23, 12:36 AM
schrockn committed R1:75d791424874: Only do python3 support for pipenv smoke (authored by schrockn).
Only do python3 support for pipenv smoke
Thu, Jan 23, 12:25 AM
schrockn closed D1872: Only do python3 support for pipenv smoke.
Thu, Jan 23, 12:25 AM
schrockn updated the diff for D1872: Only do python3 support for pipenv smoke.

upmessage

Thu, Jan 23, 12:17 AM
schrockn abandoned D1870: test pipenv.
Thu, Jan 23, 12:16 AM
schrockn updated the diff for D1872: Only do python3 support for pipenv smoke.

upmessage

Thu, Jan 23, 12:15 AM
schrockn abandoned D1869: Upgrade yarn.
Thu, Jan 23, 12:15 AM
schrockn requested review of D1869: Upgrade yarn.

I'm going to abandon this and let @bengotow do it at his leisure. This has some failures and I think I am missing some sort of process piece here. Not really a good use of my time rt now.

Thu, Jan 23, 12:15 AM
schrockn updated the diff for D1872: Only do python3 support for pipenv smoke.

up

Thu, Jan 23, 12:09 AM
schrockn created D1872: Only do python3 support for pipenv smoke.
Thu, Jan 23, 12:05 AM

Yesterday

schrockn updated the diff for D1870: test pipenv.

up

Wed, Jan 22, 11:50 PM
schrockn created D1870: test pipenv.
Wed, Jan 22, 11:30 PM
schrockn updated the diff for D1869: Upgrade yarn.

up

Wed, Jan 22, 11:28 PM
schrockn updated the diff for D1869: Upgrade yarn.

updaterc

Wed, Jan 22, 11:24 PM
schrockn created D1869: Upgrade yarn.
Wed, Jan 22, 11:15 PM
schrockn added inline comments to D1857: BUGFIX: Ensure SubprocessExecutionManager isn't leaking POSIX semaphores.
Wed, Jan 22, 11:07 PM
schrockn added a comment to D1864: RFC: is_optional --> is_required.

can you explain automated comment. i think i am missing something

Wed, Jan 22, 10:47 PM
schrockn updated the diff for D1864: RFC: is_optional --> is_required.

testing alex's changes to test image

Wed, Jan 22, 10:42 PM
schrockn added a comment to D1864: RFC: is_optional --> is_required.

I'm cool with that. Worth noting that there are a number of breaking changes in config so batching them up is an argument in the other direction

Wed, Jan 22, 10:13 PM
schrockn created D1864: RFC: is_optional --> is_required.
Wed, Jan 22, 5:23 PM

Tue, Jan 21

schrockn accepted D1856: [codemod] yaml.load -> yaml.safe_load.

cool thx for link

Tue, Jan 21, 4:03 PM
schrockn requested changes to D1856: [codemod] yaml.load -> yaml.safe_load.

seems fine, although isn't this a slightly different fix than the warning text indicates?

Tue, Jan 21, 2:23 AM

Thu, Jan 16

schrockn updated the diff for D1837: type system changes.

up

Thu, Jan 16, 7:24 PM
schrockn accepted D1844: RFC: Eliminate ConfigMappingContext.
Thu, Jan 16, 5:31 PM
schrockn accepted D1852: remove deprecated ReexecutionConfig.
Thu, Jan 16, 5:29 PM

Wed, Jan 15

schrockn accepted D1845: add autocomplete values for config for scalar union types.

very nice. thanks

Wed, Jan 15, 5:07 PM
schrockn updated the diff for D1837: type system changes.

up

Wed, Jan 15, 4:13 PM

Tue, Jan 14

schrockn accepted D1835: Fix errors with GCP pipeline.

Seems good. Not sure with _START is better than 'start'

Tue, Jan 14, 10:39 PM
schrockn accepted D1843: Eliminate execution_epoch_time.
Tue, Jan 14, 10:37 PM
schrockn added a comment to D1844: RFC: Eliminate ConfigMappingContext.

I'm into it. Add entry to CHANGES.md?

Tue, Jan 14, 10:36 PM
schrockn committed R1:d93ef664dff8: Rerun snapshots (authored by schrockn).
Rerun snapshots
Tue, Jan 14, 9:54 PM
schrockn closed D1841: Rerun snapshots.
Tue, Jan 14, 9:54 PM
schrockn created D1841: Rerun snapshots.
Tue, Jan 14, 9:49 PM
schrockn updated the diff for D1837: type system changes.

up

Tue, Jan 14, 9:41 PM
schrockn closed D1828: More clear name properties for config types and graphql scalar union support.
Tue, Jan 14, 9:36 PM
schrockn committed R1:df0011ee7796: More clear name properties for config types and graphql scalar union support (authored by schrockn).
More clear name properties for config types and graphql scalar union support
Tue, Jan 14, 9:36 PM
schrockn updated the diff for D1837: type system changes.

up

Tue, Jan 14, 9:34 PM
schrockn updated the diff for D1837: type system changes.

up

Tue, Jan 14, 9:30 PM
schrockn updated the diff for D1837: type system changes.

up

Tue, Jan 14, 9:11 PM
schrockn committed R1:caf395b99ff9: Check for duplicative runtime type names (authored by schrockn).
Check for duplicative runtime type names
Tue, Jan 14, 9:10 PM
schrockn closed D1840: Check for duplicative runtime type names.
Tue, Jan 14, 9:10 PM
schrockn updated the diff for D1837: type system changes.

up

Tue, Jan 14, 9:09 PM
schrockn updated the diff for D1837: type system changes.

up

Tue, Jan 14, 9:00 PM
schrockn updated the diff for D1840: Check for duplicative runtime type names.

upmessage

Tue, Jan 14, 8:34 PM
schrockn added a comment to D1835: Fix errors with GCP pipeline.

oof

Tue, Jan 14, 8:29 PM
schrockn updated the diff for D1840: Check for duplicative runtime type names.

up

Tue, Jan 14, 8:28 PM
schrockn created D1840: Check for duplicative runtime type names.
Tue, Jan 14, 8:20 PM
schrockn created D1837: type system changes.
Tue, Jan 14, 6:18 PM
schrockn updated the diff for D1828: More clear name properties for config types and graphql scalar union support.

upmessage

Tue, Jan 14, 6:03 PM
schrockn updated the diff for D1828: More clear name properties for config types and graphql scalar union support.

upmessage

Tue, Jan 14, 5:53 PM
schrockn added a comment to D1828: More clear name properties for config types and graphql scalar union support.

Some screenshots:

Tue, Jan 14, 5:51 PM
schrockn updated the diff for D1828: More clear name properties for config types and graphql scalar union support.

up

Tue, Jan 14, 5:48 PM
schrockn updated the diff for D1828: More clear name properties for config types and graphql scalar union support.

up

Tue, Jan 14, 5:02 AM
schrockn updated the diff for D1828: More clear name properties for config types and graphql scalar union support.

up

Tue, Jan 14, 4:53 AM
schrockn updated the diff for D1828: More clear name properties for config types and graphql scalar union support.

up

Tue, Jan 14, 4:46 AM
schrockn updated the diff for D1828: More clear name properties for config types and graphql scalar union support.

up

Tue, Jan 14, 4:41 AM
schrockn accepted D1836: Convert gcp_pipeline to use partitions.
Tue, Jan 14, 2:10 AM
schrockn added a comment to D1835: Fix errors with GCP pipeline.

why wasn't this caught by tests?

Tue, Jan 14, 2:09 AM
schrockn updated the diff for D1828: More clear name properties for config types and graphql scalar union support.

up

Tue, Jan 14, 12:33 AM
schrockn updated the diff for D1828: More clear name properties for config types and graphql scalar union support.

up

Tue, Jan 14, 12:25 AM
schrockn added a comment to D1834: Fixup MANIFEST.in.

not necessary just wanted to understand

Tue, Jan 14, 12:19 AM
schrockn accepted D1834: Fixup MANIFEST.in.

prometheus changes unrelated to core issue?

Tue, Jan 14, 12:17 AM

Mon, Jan 13

schrockn updated the diff for D1828: More clear name properties for config types and graphql scalar union support.

up

Mon, Jan 13, 9:28 PM
schrockn updated the diff for D1828: More clear name properties for config types and graphql scalar union support.

up

Mon, Jan 13, 8:47 PM
schrockn accepted D1830: [dagster-postgres] update config to Selector.

👍🏻

Mon, Jan 13, 7:22 PM
schrockn accepted D1829: Fix runtime type comparison.

cool

Mon, Jan 13, 7:22 PM
schrockn accepted D1831: [ConfigClass] remove kwargs on from_config_value.

I think i've done this a couple times in unpublished diffs.

Mon, Jan 13, 7:20 PM
schrockn updated the diff for D1828: More clear name properties for config types and graphql scalar union support.

up

Mon, Jan 13, 6:11 PM
schrockn created D1828: More clear name properties for config types and graphql scalar union support.
Mon, Jan 13, 4:51 PM
schrockn committed R1:f1bd3fc54f12: (new-types-package-org-7) Minor cleanup on ConfigType (authored by schrockn).
(new-types-package-org-7) Minor cleanup on ConfigType
Mon, Jan 13, 4:35 PM
schrockn closed D1827: (new-types-package-org-7) Minor cleanup on ConfigType.
Mon, Jan 13, 4:35 PM
schrockn committed R1:db68ca5a79ca: (new-types-package-org-6) Eliminate ConfigTypeAttributes (authored by schrockn).
(new-types-package-org-6) Eliminate ConfigTypeAttributes
Mon, Jan 13, 4:35 PM
schrockn closed D1826: (new-types-package-org-6) Eliminate ConfigTypeAttributes.
Mon, Jan 13, 4:35 PM
schrockn committed R1:b81fdb064ec8: (new-types-package-org-5) Eliminate is_system_config (authored by schrockn).
(new-types-package-org-5) Eliminate is_system_config
Mon, Jan 13, 4:34 PM
schrockn closed D1825: (new-types-package-org-5) Eliminate is_system_config.
Mon, Jan 13, 4:34 PM
schrockn committed R1:4f5bc1e8717a: (new-types-package-org-4) Make name more clear. Eliminate named dicts and… (authored by schrockn).
(new-types-package-org-4) Make name more clear. Eliminate named dicts and…
Mon, Jan 13, 4:32 PM
schrockn closed D1824: (new-types-package-org-4) Make name more clear. Eliminate named dicts and selectors.
Mon, Jan 13, 4:32 PM
schrockn committed R1:dbf5892e319c: (new-types-package-org-3) Move dagster.core.types.runtime to dagster.core.types (authored by schrockn).
(new-types-package-org-3) Move dagster.core.types.runtime to dagster.core.types
Mon, Jan 13, 4:31 PM
schrockn closed D1823: (new-types-package-org-3) Move dagster.core.types.runtime to dagster.core.types.
Mon, Jan 13, 4:31 PM
schrockn committed R1:e792d40f9202: (new-types-package-org-2) Make builtin mapping stuff a top-level submodule (authored by schrockn).
(new-types-package-org-2) Make builtin mapping stuff a top-level submodule
Mon, Jan 13, 4:30 PM
schrockn closed D1822: (new-types-package-org-2) Make builtin mapping stuff a top-level submodule.
Mon, Jan 13, 4:30 PM
schrockn added a comment to D1822: (new-types-package-org-2) Make builtin mapping stuff a top-level submodule.

going to land this and then we can bounce around renames

Mon, Jan 13, 4:30 PM
schrockn committed R1:d5833f41dd47: (new-types-package-org-1) dagster.core.types.config --> dagster.config (authored by schrockn).
(new-types-package-org-1) dagster.core.types.config --> dagster.config
Mon, Jan 13, 4:22 PM
schrockn closed D1821: (new-types-package-org-1) dagster.core.types.config --> dagster.config.
Mon, Jan 13, 4:22 PM
schrockn updated the diff for D1827: (new-types-package-org-7) Minor cleanup on ConfigType.

upmessage

Mon, Jan 13, 2:54 PM
schrockn created D1827: (new-types-package-org-7) Minor cleanup on ConfigType.
Mon, Jan 13, 2:45 PM
schrockn updated the diff for D1826: (new-types-package-org-6) Eliminate ConfigTypeAttributes.

upmessage

Mon, Jan 13, 2:42 PM
schrockn updated the diff for D1825: (new-types-package-org-5) Eliminate is_system_config.

upmessage

Mon, Jan 13, 2:41 PM
schrockn updated the diff for D1826: (new-types-package-org-6) Eliminate ConfigTypeAttributes.

up

Mon, Jan 13, 2:35 PM
schrockn updated the diff for D1825: (new-types-package-org-5) Eliminate is_system_config.

up

Mon, Jan 13, 2:34 PM
schrockn updated the diff for D1826: (new-types-package-org-6) Eliminate ConfigTypeAttributes.

up

Mon, Jan 13, 2:28 PM
schrockn updated the diff for D1825: (new-types-package-org-5) Eliminate is_system_config.

up

Mon, Jan 13, 2:27 PM
schrockn created D1826: (new-types-package-org-6) Eliminate ConfigTypeAttributes.
Mon, Jan 13, 2:25 PM
schrockn updated the diff for D1825: (new-types-package-org-5) Eliminate is_system_config.

up

Mon, Jan 13, 2:13 PM
schrockn created D1825: (new-types-package-org-5) Eliminate is_system_config.
Mon, Jan 13, 2:12 PM

Sun, Jan 12

schrockn updated the diff for D1752: Configurable Dict.

upmessage

Sun, Jan 12, 10:26 PM
schrockn updated the diff for D1823: (new-types-package-org-3) Move dagster.core.types.runtime to dagster.core.types.

upmessage

Sun, Jan 12, 9:22 PM
schrockn updated the diff for D1824: (new-types-package-org-4) Make name more clear. Eliminate named dicts and selectors.

upmessage

Sun, Jan 12, 9:21 PM
schrockn updated the diff for D1824: (new-types-package-org-4) Make name more clear. Eliminate named dicts and selectors.

upmessage

Sun, Jan 12, 6:23 PM
schrockn updated the diff for D1824: (new-types-package-org-4) Make name more clear. Eliminate named dicts and selectors.

up

Sun, Jan 12, 6:18 PM