Page MenuHomePhabricator
Feed Advanced Search

Today

schrockn requested review of D5317: Add ScopedResourceSet to thread down through the config parsing code paths.
Sat, Nov 28, 9:30 PM
schrockn requested review of D5316: (refactor-input-source-to-thunk-4) Add checks to catch errors when new source types are added.
Sat, Nov 28, 7:27 PM
schrockn requested review of D5315: (refactor-input-source-to-thunk-3) Add compute_version to StepInputSource hierarchy.
Sat, Nov 28, 7:15 PM
schrockn requested review of D5314: (refactor-input-source-to-thunk-2) Move required_resource_keys to be polymorphic on StepInputSource.
Sat, Nov 28, 7:10 PM
schrockn added inline comments to D5312: (refactor-input-source-to-thunk-1) Push loading behavior to StepInputSource and make it a thunk.
Sat, Nov 28, 6:42 PM
schrockn updated the diff for D5312: (refactor-input-source-to-thunk-1) Push loading behavior to StepInputSource and make it a thunk.

up

Sat, Nov 28, 6:41 PM
schrockn requested review of D5313: Push loading behavior to StepInputSource and make it a thunk and add versioning and required resource keys to source.
Sat, Nov 28, 6:41 PM
schrockn requested review of D5312: (refactor-input-source-to-thunk-1) Push loading behavior to StepInputSource and make it a thunk.
Sat, Nov 28, 5:44 PM
schrockn requested review of D5311: Push loading behavior to StepInputSource.
Sat, Nov 28, 5:10 PM

Yesterday

schrockn added inline comments to D5309: fix fan-in with asset stores.
Fri, Nov 27, 8:44 PM
schrockn accepted D5309: fix fan-in with asset stores.
Fri, Nov 27, 8:41 PM
schrockn added a comment to D5309: fix fan-in with asset stores.

Oh god I was doing prototyping in this area without bringing in the refactor

Fri, Nov 27, 8:41 PM
schrockn requested review of D5310: strict things.
Fri, Nov 27, 8:31 PM

Wed, Nov 25

schrockn updated the diff for D5271: Refactor configured infrastructure to eliminate "underscore" params on public definitions.

up

Wed, Nov 25, 10:00 PM
schrockn updated the diff for D5271: Refactor configured infrastructure to eliminate "underscore" params on public definitions.

up

Wed, Nov 25, 9:51 PM
schrockn requested review of D5271: Refactor configured infrastructure to eliminate "underscore" params on public definitions.
Wed, Nov 25, 9:38 PM
schrockn accepted D5217: StepInput refactor.

makes sense

Wed, Nov 25, 8:14 PM
schrockn requested changes to D5217: StepInput refactor.

My big question is why is this FromMultipleSources and not FromMultipleStepOutputs?

Wed, Nov 25, 6:00 PM
schrockn accepted D5285: on OutputDefinition, accept asset_store_key=None.

startreknod

Wed, Nov 25, 1:18 AM
schrockn published D5285: on OutputDefinition, accept asset_store_key=None for review.
Wed, Nov 25, 1:18 AM
schrockn closed D5272: Refactor environment_configs.py to share config construction code amongst configurable definitions.
Wed, Nov 25, 12:21 AM
schrockn committed R1:1ebdd065282c: Refactor environment_configs.py to share config construction code amongst… (authored by schrockn).
Refactor environment_configs.py to share config construction code amongst…
Wed, Nov 25, 12:21 AM

Tue, Nov 24

schrockn published D5272: Refactor environment_configs.py to share config construction code amongst configurable definitions for review.
Tue, Nov 24, 7:53 PM
schrockn closed D5270: [easy] eliminate is_nameless in ConfiguredMixin.
Tue, Nov 24, 7:33 PM
schrockn committed R1:2740f2b319f2: [easy] eliminate is_nameless in ConfiguredMixin (authored by schrockn).
[easy] eliminate is_nameless in ConfiguredMixin
Tue, Nov 24, 7:33 PM
schrockn requested review of D5270: [easy] eliminate is_nameless in ConfiguredMixin.
Tue, Nov 24, 6:48 PM

Mon, Nov 23

schrockn published D5256: Add presets for dbt demo for review.
Mon, Nov 23, 11:43 PM
schrockn closed D5239: Eliminate old style classes.
Mon, Nov 23, 7:03 PM
schrockn committed R1:18867720e7c3: Eliminate old style classes (authored by schrockn).
Eliminate old style classes
Mon, Nov 23, 7:03 PM
schrockn updated the diff for D5239: Eliminate old style classes.

up

Mon, Nov 23, 6:24 PM
schrockn updated the diff for D5239: Eliminate old style classes.

up

Mon, Nov 23, 6:18 PM
schrockn updated the diff for D5239: Eliminate old style classes.

up

Mon, Nov 23, 6:10 PM
schrockn updated the diff for D5239: Eliminate old style classes.

up

Mon, Nov 23, 5:32 PM
schrockn closed D5238: Kill config_field.
Mon, Nov 23, 5:28 PM
schrockn committed R1:2961d332f195: Kill config_field (authored by schrockn).
Kill config_field
Mon, Nov 23, 5:28 PM
schrockn updated the diff for D5239: Eliminate old style classes.

rebase

Mon, Nov 23, 5:26 PM

Sat, Nov 21

schrockn accepted D5241: don't include coverage commands in windows tox runs.
Sat, Nov 21, 3:50 PM
schrockn updated the diff for D5239: Eliminate old style classes.

up

Sat, Nov 21, 2:58 PM
schrockn requested review of D5238: Kill config_field.
Sat, Nov 21, 2:45 PM
schrockn requested review of D5239: Eliminate old style classes.
Sat, Nov 21, 2:41 PM

Fri, Nov 20

schrockn closed D5202: Futher configured cleanup.
Fri, Nov 20, 6:32 PM
schrockn committed R1:8a05bc3f679b: Futher configured cleanup (authored by schrockn).
Futher configured cleanup
Fri, Nov 20, 6:32 PM
schrockn closed D5192: Configured refactor: IConfigMappable --> ConfiguredMixin.
Fri, Nov 20, 6:12 PM
schrockn committed R1:273c415c281f: Configured refactor: IConfigMappable --> ConfiguredMixin (authored by schrockn).
Configured refactor: IConfigMappable --> ConfiguredMixin
Fri, Nov 20, 6:12 PM
schrockn updated the diff for D5202: Futher configured cleanup.

up

Fri, Nov 20, 6:08 PM
schrockn closed D5216: Use yield from in dagster.core.
Fri, Nov 20, 4:53 PM
schrockn committed R1:32e341604fbb: Use yield from in dagster.core (authored by schrockn).
Use yield from in dagster.core
Fri, Nov 20, 4:53 PM
schrockn added inline comments to D5215: [sensors-8] file toy sensor.
Fri, Nov 20, 3:58 PM
schrockn published D5216: Use yield from in dagster.core for review.
Fri, Nov 20, 1:09 PM
schrockn updated the diff for D5202: Futher configured cleanup.

up

Fri, Nov 20, 12:59 AM
schrockn updated the diff for D5202: Futher configured cleanup.

up

Fri, Nov 20, 12:58 AM
schrockn updated the diff for D5202: Futher configured cleanup.

up

Fri, Nov 20, 12:54 AM
schrockn updated the diff for D5192: Configured refactor: IConfigMappable --> ConfiguredMixin.

up

Fri, Nov 20, 12:43 AM
schrockn closed D5213: Bye bye Python 2.
Fri, Nov 20, 12:40 AM
schrockn committed R1:87c2f4907830: Bye bye Python 2 (authored by schrockn).
Bye bye Python 2
Fri, Nov 20, 12:40 AM
schrockn updated the diff for D5202: Futher configured cleanup.

up

Fri, Nov 20, 12:30 AM
schrockn updated the diff for D5192: Configured refactor: IConfigMappable --> ConfiguredMixin.

up

Fri, Nov 20, 12:28 AM
schrockn published D5213: Bye bye Python 2 for review.
Fri, Nov 20, 12:26 AM

Thu, Nov 19

schrockn added a comment to D5202: Futher configured cleanup.

py2 failures expected. will land on fri

Thu, Nov 19, 6:18 PM
schrockn updated the diff for D5202: Futher configured cleanup.

up

Thu, Nov 19, 5:55 PM
schrockn added a reviewer for D5202: Futher configured cleanup: sashank.
Thu, Nov 19, 5:40 PM
schrockn published D5202: Futher configured cleanup for review.

i can merge this with previous one if desired.

Thu, Nov 19, 5:40 PM

Wed, Nov 18

schrockn published D5192: Configured refactor: IConfigMappable --> ConfiguredMixin for review.

going to fail lint

Wed, Nov 18, 10:58 PM

Tue, Nov 17

schrockn closed D5170: [easy] Fix deprecation warning and do not return value from hammer_pipeline.
Tue, Nov 17, 9:49 PM
schrockn committed R1:15de4f90b3d9: [easy] Fix deprecation warning and do not return value from hammer_pipeline (authored by schrockn).
[easy] Fix deprecation warning and do not return value from hammer_pipeline
Tue, Nov 17, 9:49 PM
schrockn accepted D5173: asset store bug fix.
Tue, Nov 17, 8:58 PM
schrockn published D5173: asset store bug fix for review.
Tue, Nov 17, 8:58 PM
schrockn requested review of D5170: [easy] Fix deprecation warning and do not return value from hammer_pipeline.
Tue, Nov 17, 7:44 PM
schrockn updated the diff for D5168: RFC: composable type loaders and materializers.

up

Tue, Nov 17, 3:16 PM
schrockn requested review of D5168: RFC: composable type loaders and materializers.
Tue, Nov 17, 2:08 PM
schrockn added a comment to D5147: Asset View Improvements.

for whatever reason getting this error when running locally

Tue, Nov 17, 3:06 AM

Sun, Nov 15

schrockn added a comment to D5147: Asset View Improvements.

Wow this looks so much better

Sun, Nov 15, 2:59 PM
schrockn updated subscribers of D5147: Asset View Improvements.

Interested to get @max 's take too and to get this going on a dbt installation to make sure it all makes sense

Sun, Nov 15, 2:55 PM

Sat, Nov 14

schrockn accepted D5144: #3220 remove fan_in_fan_out_pipeline from toys repo.

thankyou

Sat, Nov 14, 7:48 PM
schrockn accepted D5143: remove warning util used for environment_dict deprecation.
Sat, Nov 14, 2:21 AM
schrockn added inline comments to D5056: asset-store public API & API Docs.
Sat, Nov 14, 1:32 AM
schrockn added a comment to D5056: asset-store public API & API Docs.

i think this looks great!

Sat, Nov 14, 1:31 AM

Fri, Nov 13

schrockn closed D5133: [easy] fix black.
Fri, Nov 13, 3:40 PM
schrockn committed R1:406ca1aaec52: [easy] fix black (authored by schrockn).
[easy] fix black
Fri, Nov 13, 3:40 PM

Thu, Nov 12

schrockn accepted D4985: Enable setting pipeline-level default asset store.

cool. plz consider final comments.

Thu, Nov 12, 3:38 AM

Wed, Nov 11

schrockn accepted D4781: allow optional configuration of parent pipeline solids for subsetted pipeline.
Wed, Nov 11, 8:56 PM
schrockn added a comment to D5098: remove graphql to dagster event code.

happycry

Wed, Nov 11, 8:47 PM
schrockn created Image Macro "happycry".
Wed, Nov 11, 8:47 PM
schrockn added inline comments to D4985: Enable setting pipeline-level default asset store.
Wed, Nov 11, 8:09 PM
schrockn requested changes to D4985: Enable setting pipeline-level default asset store.

default_asset_store is a bit of a strange formulation in this context IMO. Verbally I would say in this diff that the default asset store is the in-memory asset store, but then that is assigned to the default_asset_store key? I think it kind of assumes that there will be multiple asset stores per-pipeline and I don't think that will be the common case. asset_store makes more sense IMO. variable name default_is_default exposes this awkardness

Wed, Nov 11, 8:08 PM

Tue, Nov 10

schrockn requested changes to D4781: allow optional configuration of parent pipeline solids for subsetted pipeline.

So I think we need another test case where the subset in question does *not* have a default input. That is config is required.

Tue, Nov 10, 10:48 PM
schrockn added a comment to D5079: rm py2+windows tests.

Well i want folks a chance to weigh in. I don't consider the decision made yet. Maybe tmrw?

Tue, Nov 10, 4:37 PM

Mon, Nov 9

schrockn added a comment to D5026: [sensors-5] Redefine sensors in terms of SensorTickData / SensorRunParams.

I think one way to explore this is to ask how this API is going to expand in the future? Use cases including:

Mon, Nov 9, 4:20 PM

Sat, Nov 7

schrockn added a comment to D5026: [sensors-5] Redefine sensors in terms of SensorTickData / SensorRunParams.

I'm really confused by JobConfig. From my perspective the current JobConfig in the diff represents the parameters to a run. It represents "I have determined that in this tick there should be a run launcher, and here are the parameters". JobConfig sounds like an argument that would be passed into the *job* definition.

Sat, Nov 7, 4:16 PM

Fri, Nov 6

schrockn accepted D5048: fix @pipeline mypy issue from @graph work.

worth an early push?

Fri, Nov 6, 7:49 PM

Sun, Nov 1

schrockn requested changes to D4868: RFC: deprecate imports of lambda_solid from top level.

let's just change the warning to say it is being delete. i doubt it is very broadly used.

Sun, Nov 1, 2:28 PM
schrockn added a comment to D4868: RFC: deprecate imports of lambda_solid from top level.

I do think this is an interesting case where overdoing it on "progressive disclosure of complexity" actually did active damage. The original idea was to be able to delay the introduction of the context object, at the expense of having an increase API surface. In this case it is pretty clear that that tradeoff was incorrect

Sun, Nov 1, 2:24 PM
schrockn added a comment to D4868: RFC: deprecate imports of lambda_solid from top level.

I think we should delete it

Sun, Nov 1, 2:22 PM

Fri, Oct 30

schrockn accepted D4935: kill the cli api.

def support landing this

Fri, Oct 30, 8:34 PM
schrockn accepted D4978: Disable test on windows that involves solid crashing.
Fri, Oct 30, 6:10 PM
schrockn added a comment to D4972: use instance_for_test in test_event_callback function.

got it. I reopen-ed https://github.com/dagster-io/dagster/issues/3169 for tracking if you want to put failures somewhere

Fri, Oct 30, 4:32 PM

Thu, Oct 29

schrockn closed D4972: use instance_for_test in test_event_callback function.
Thu, Oct 29, 10:45 PM
schrockn committed R1:f0244c807da4: use instance_for_test in test_event_callback function (authored by schrockn).
use instance_for_test in test_event_callback function
Thu, Oct 29, 10:45 PM
schrockn closed D4964: [easy] s/Fileystem/Filesystem/g.
Thu, Oct 29, 10:44 PM
schrockn committed R1:00ff35b1efdb: [easy] s/Fileystem/Filesystem/g (authored by schrockn).
[easy] s/Fileystem/Filesystem/g
Thu, Oct 29, 10:44 PM