Page MenuHomePhabricator
Feed Advanced Search

Today

dgibson closed D4856: Clean up in ComputeLogManager on instance cleanup.
Thu, Oct 22, 12:42 AM
dgibson committed R1:e184ae6e4c0b: Clean up in ComputeLogManager on instance cleanup (authored by dgibson).
Clean up in ComputeLogManager on instance cleanup
Thu, Oct 22, 12:42 AM

Yesterday

dgibson added a comment to D4857: Actually fall back to repo root in automation machinery.

re: scheduler test failure, are you rebased past https://dagster.phacility.com/D4835?

Wed, Oct 21, 7:21 PM
dgibson requested review of D4856: Clean up in ComputeLogManager on instance cleanup.
Wed, Oct 21, 6:57 PM
dgibson added a comment to D4791: [RFC] Dagster native run queuing cli.

did another pass here - the one thing I think we should clarify now is where this CLI command should go - i think it might make more sense alongside the scheduler in that group, to pave the way for deploying the scheduler and the dequeuer together?

Wed, Oct 21, 1:25 PM

Tue, Oct 20

dgibson closed D4839: Speed up the scheduler tests by not checking every test against CLI API and gRPC repos.
Tue, Oct 20, 9:50 PM
dgibson committed R1:5bb9b3e938b2: Speed up the scheduler tests by not checking every test against CLI API and… (authored by dgibson).
Speed up the scheduler tests by not checking every test against CLI API and…
Tue, Oct 20, 9:50 PM
dgibson updated the diff for D4839: Speed up the scheduler tests by not checking every test against CLI API and gRPC repos.

up

Tue, Oct 20, 9:27 PM
dgibson requested review of D4839: Speed up the scheduler tests by not checking every test against CLI API and gRPC repos.
Tue, Oct 20, 9:26 PM
dgibson closed D4787: Require that start_date be on a month/day boundary for monthly/daily schedules.
Tue, Oct 20, 9:10 PM
dgibson committed R1:b171cd089a1d: Require that start_date be on a month/day boundary for monthly/daily schedules (authored by dgibson).
Require that start_date be on a month/day boundary for monthly/daily schedules
Tue, Oct 20, 9:09 PM
dgibson updated the diff for D4787: Require that start_date be on a month/day boundary for monthly/daily schedules.

switch to a warning for a less breaking change

Tue, Oct 20, 8:42 PM
dgibson updated the diff for D4787: Require that start_date be on a month/day boundary for monthly/daily schedules.

Add more descriptive comments and examples

Tue, Oct 20, 8:35 PM
dgibson added inline comments to D4787: Require that start_date be on a month/day boundary for monthly/daily schedules.
Tue, Oct 20, 8:18 PM
dgibson closed D4742: Remove legacy repo format from examples/tests, replace the default with the new standard format except when specifically testing legacy stuff.
Tue, Oct 20, 8:17 PM
dgibson committed R1:2d7d707fa3ad: Remove legacy repo format from examples/tests, replace the default with the new… (authored by dgibson).
Remove legacy repo format from examples/tests, replace the default with the new…
Tue, Oct 20, 8:17 PM
dgibson closed D4835: fix cleanupr issues in scheduler tests.
Tue, Oct 20, 8:16 PM
dgibson committed R1:4316f0edc941: fix cleanupr issues in scheduler tests (authored by dgibson).
fix cleanupr issues in scheduler tests
Tue, Oct 20, 8:16 PM
dgibson updated the diff for D4742: Remove legacy repo format from examples/tests, replace the default with the new standard format except when specifically testing legacy stuff.

up

Tue, Oct 20, 7:52 PM
dgibson updated the diff for D4835: fix cleanupr issues in scheduler tests.

up

Tue, Oct 20, 7:41 PM
dgibson closed D4805: Don't rebuild the docker image every time you run a kind test locally.
Tue, Oct 20, 7:39 PM
dgibson committed R1:d64a50978b51: Don't rebuild the docker image every time you run a kind test locally (authored by dgibson).
Don't rebuild the docker image every time you run a kind test locally
Tue, Oct 20, 7:39 PM
dgibson closed D4817: Remove executePlan dagster-graphql call.
Tue, Oct 20, 7:39 PM
dgibson committed R1:f74856e50cdf: Remove executePlan dagster-graphql call (authored by dgibson).
Remove executePlan dagster-graphql call
Tue, Oct 20, 7:38 PM
dgibson updated the diff for D4835: fix cleanupr issues in scheduler tests.

here is a more plausible fix, I guess that diff landing just before the failure was a coincidence

Tue, Oct 20, 7:27 PM
dgibson planned changes to D4835: fix cleanupr issues in scheduler tests.

new fix coming

Tue, Oct 20, 7:07 PM
dgibson added a comment to D4835: fix cleanupr issues in scheduler tests.

hmmm maybe not. I assumed it was related to https://dagster.phacility.com/D4823 where I made this change

Tue, Oct 20, 6:59 PM
dgibson published D4835: fix cleanupr issues in scheduler tests for review.
Tue, Oct 20, 6:53 PM
dgibson updated the diff for D4817: Remove executePlan dagster-graphql call.

up, remove that class you mentinoed

Tue, Oct 20, 6:37 PM
dgibson closed D4813: Maintain backcompat in date_partition_range.
Tue, Oct 20, 6:32 PM
dgibson committed R1:55da8130957e: Maintain backcompat in date_partition_range (authored by dgibson).
Maintain backcompat in date_partition_range
Tue, Oct 20, 6:32 PM
dgibson updated the diff for D4813: Maintain backcompat in date_partition_range.

up

Tue, Oct 20, 6:31 PM
dgibson closed D4827: Append "_location" to default repository location name.
Tue, Oct 20, 6:24 PM
dgibson committed R1:adb7d5f2abcd: Append "_location" to default repository location name (authored by dgibson).
Append "_location" to default repository location name
Tue, Oct 20, 6:24 PM
dgibson updated the diff for D4817: Remove executePlan dagster-graphql call.

rebase, CHANGES.md

Tue, Oct 20, 6:22 PM
dgibson closed D4814: rm DagsterKubernetesPodOperator and test infra around it.
Tue, Oct 20, 6:19 PM
dgibson committed R1:80995c9f8886: rm DagsterKubernetesPodOperator and test infra around it (authored by dgibson).
rm DagsterKubernetesPodOperator and test infra around it
Tue, Oct 20, 6:19 PM
dgibson updated the diff for D4814: rm DagsterKubernetesPodOperator and test infra around it.

CHANGES.md

Tue, Oct 20, 6:18 PM
dgibson closed D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.
Tue, Oct 20, 6:16 PM
dgibson committed R1:7aa975ca24e4: Change the default system for loading and executing user code to be gRPC… (authored by dgibson).
Change the default system for loading and executing user code to be gRPC…
Tue, Oct 20, 6:16 PM
dgibson updated the diff for D4813: Maintain backcompat in date_partition_range.

add warning (filed an issue as well for the breaking/deprecation changes to make before the 0.10.0 release)

Tue, Oct 20, 6:07 PM
dgibson planned changes to D4813: Maintain backcompat in date_partition_range.
Tue, Oct 20, 5:59 PM
dgibson updated the diff for D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.

test fix

Tue, Oct 20, 5:52 PM
dgibson updated the diff for D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.

test fix

Tue, Oct 20, 5:28 PM
dgibson updated the diff for D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.

rebase

Tue, Oct 20, 4:52 PM
dgibson closed D4823: Ensure that origins don't change when we switch from cli api repos to grpc repos.
Tue, Oct 20, 4:07 PM
dgibson committed R1:6d3e9aaac0af: Ensure that origins don't change when we switch from cli api repos to grpc repos (authored by dgibson).
Ensure that origins don't change when we switch from cli api repos to grpc repos
Tue, Oct 20, 4:07 PM
dgibson added inline comments to D4823: Ensure that origins don't change when we switch from cli api repos to grpc repos.
Tue, Oct 20, 4:07 PM
dgibson added a comment to D4821: [dagit] Create workspace routes.

Overall this makes sense to me!

Tue, Oct 20, 4:04 PM
dgibson requested review of D4827: Append "_location" to default repository location name.
Tue, Oct 20, 3:49 PM
dgibson added a reviewer for D4823: Ensure that origins don't change when we switch from cli api repos to grpc repos: sashank.
Tue, Oct 20, 2:49 PM
dgibson requested review of D4817: Remove executePlan dagster-graphql call.
Tue, Oct 20, 1:39 AM
dgibson requested review of D4824: Remove legacy repo format from loading path.
Tue, Oct 20, 1:36 AM
dgibson added a reviewer for D4813: Maintain backcompat in date_partition_range: prha.
Tue, Oct 20, 1:18 AM
dgibson updated the diff for D4742: Remove legacy repo format from examples/tests, replace the default with the new standard format except when specifically testing legacy stuff.

remove the breaking part, just update teh examples and tests for now

Tue, Oct 20, 1:14 AM
dgibson added a reviewer for D4805: Don't rebuild the docker image every time you run a kind test locally: alangenfeld.
Tue, Oct 20, 1:03 AM
dgibson abandoned D4799: test termination in BK.
Tue, Oct 20, 1:02 AM
dgibson requested review of D4823: Ensure that origins don't change when we switch from cli api repos to grpc repos.
Tue, Oct 20, 12:55 AM
dgibson updated the diff for D4814: rm DagsterKubernetesPodOperator and test infra around it.

up

Tue, Oct 20, 12:35 AM

Mon, Oct 19

dgibson updated the diff for D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.

up

Mon, Oct 19, 9:16 PM
dgibson requested review of D4814: rm DagsterKubernetesPodOperator and test infra around it.

test failures are transient/unrelated

Mon, Oct 19, 8:43 PM
dgibson requested review of D4813: Maintain backcompat in date_partition_range.
Mon, Oct 19, 7:59 PM
dgibson updated the diff for D4679: Change the default system for loading and executing user code to be gRPC instead of the CLI API.

up

Mon, Oct 19, 7:46 PM
dgibson closed D4769: Use execute_step_with_structured_logs in DagsterDockerOperator.
Mon, Oct 19, 7:40 PM
dgibson committed R1:febffd667ebb: Use execute_step_with_structured_logs in DagsterDockerOperator (authored by dgibson).
Use execute_step_with_structured_logs in DagsterDockerOperator
Mon, Oct 19, 7:40 PM
dgibson planned changes to D4788: RFC: Add partitions to arbitrary cron-based schedules.
Mon, Oct 19, 1:21 PM

Sat, Oct 17

dgibson closed D4804: Fix helm namespace lifecycle in tests.
Sat, Oct 17, 12:14 AM
dgibson committed R1:82f9303658f5: Fix helm namespace lifecycle in tests (authored by dgibson).
Fix helm namespace lifecycle in tests
Sat, Oct 17, 12:14 AM

Fri, Oct 16

dgibson requested review of D4805: Don't rebuild the docker image every time you run a kind test locally.
Fri, Oct 16, 9:05 PM
dgibson requested review of D4804: Fix helm namespace lifecycle in tests.
Fri, Oct 16, 9:02 PM
dgibson closed D4801: [easy] Fix missing param change in date_partition_range call.
Fri, Oct 16, 4:07 PM
dgibson committed R1:69cb751f7166: [easy] Fix missing param change in date_partition_range call (authored by dgibson).
[easy] Fix missing param change in date_partition_range call
Fri, Oct 16, 4:06 PM
dgibson abandoned D4538: Write non-error execution logs to stdout instead of stderr, only surface stderr from child processes in host processes like the scheduler.

I'm going to hold off on this for now, will keep it in the back pocket though

Fri, Oct 16, 3:06 PM
dgibson published D4801: [easy] Fix missing param change in date_partition_range call for review.
Fri, Oct 16, 2:55 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:48 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:48 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:48 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:47 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:47 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:47 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:47 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:46 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:46 PM
dgibson updated the diff for D4799: test termination in BK.

trial4

Fri, Oct 16, 2:46 PM
dgibson closed D4725: Add execution_timezone field to schedules.
Fri, Oct 16, 2:31 PM
dgibson committed R1:fe88d204fa88: Add execution_timezone field to schedules (authored by dgibson).
Add execution_timezone field to schedules
Fri, Oct 16, 2:31 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:29 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:29 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:29 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:29 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:28 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:28 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:28 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:27 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:27 PM
dgibson updated the diff for D4799: test termination in BK.

trial3

Fri, Oct 16, 2:27 PM
dgibson closed D4723: Get cron schedule from ExternalSchedule rather than the Schedule DB.
Fri, Oct 16, 2:13 PM
dgibson closed D4671: Make scheduler timezone-aware.
Fri, Oct 16, 2:13 PM
dgibson committed R1:c52d2d09c3a3: Get cron schedule from ExternalSchedule rather than the Schedule DB (authored by dgibson).
Get cron schedule from ExternalSchedule rather than the Schedule DB
Fri, Oct 16, 2:13 PM
dgibson committed R1:fb652b6a321f: Make scheduler timezone-aware (authored by dgibson).
Make scheduler timezone-aware
Fri, Oct 16, 2:13 PM