Page MenuHomeElementl
Feed Advanced Search

May 13 2021

dish requested review of D7897: [dagit] Use Yarn v2.
May 13 2021, 6:47 PM

May 12 2021

dish requested review of D7889: [dagit] Extract AppCache to top level, consolidate TestProvider.
May 12 2021, 9:18 PM
dish requested review of D7881: [dagit] Delete src/main.
May 12 2021, 2:38 PM

May 10 2021

dish closed D7850: [dagit] Fix sensor/schedule mutations.
May 10 2021, 11:08 PM
dish committed R1:e94f0daf6645: [dagit] Fix sensor/schedule mutations (authored by dish).
[dagit] Fix sensor/schedule mutations
May 10 2021, 11:08 PM
dish added a comment to D7850: [dagit] Fix sensor/schedule mutations.

I just broke this a couple hours ago, so I don't think so...

May 10 2021, 11:02 PM
dish published D7850: [dagit] Fix sensor/schedule mutations for review.
May 10 2021, 10:59 PM
dish closed D7839: [dagit] Permissions.
May 10 2021, 8:41 PM
dish committed R1:01092f34eaf8: [dagit] Permissions (authored by dish).
[dagit] Permissions
May 10 2021, 8:41 PM
dish added inline comments to D7839: [dagit] Permissions.
May 10 2021, 8:38 PM
dish accepted D7842: Fix regression in line height in asset history view #4156.
May 10 2021, 8:06 PM
dish requested review of D7839: [dagit] Permissions.
May 10 2021, 7:29 PM
dish accepted D7814: [dagit] Fix issue rendering Gantt for dynamic pipelines with a collect that has non-dynamic inputs.
May 10 2021, 2:04 PM

May 8 2021

dish closed D7817: [dagit] Fix lint warning.
May 8 2021, 12:43 AM
dish committed R1:553ad7fbb209: [dagit] Fix lint warning (authored by dish).
[dagit] Fix lint warning
May 8 2021, 12:43 AM

May 7 2021

dish requested review of D7817: [dagit] Fix lint warning.
May 7 2021, 9:59 PM
dish closed D7790: [dagit] Move everything out of __tests__.
May 7 2021, 9:47 PM
dish committed R1:807a35b3f270: [dagit] Move everything out of __tests__ (authored by dish).
[dagit] Move everything out of __tests__
May 7 2021, 9:47 PM
dish closed D7812: [dagit] Prepare to remove `main` file.
May 7 2021, 9:27 PM
dish committed R1:7c6da547e7f2: [dagit] Prepare to remove `main` file (authored by dish).
[dagit] Prepare to remove `main` file
May 7 2021, 9:27 PM
dish retitled D7812: [dagit] Prepare to remove `main` file from [dagit] Remove `main` file to [dagit] Prepare to remove `main` file.
May 7 2021, 9:26 PM
dish updated the diff for D7812: [dagit] Prepare to remove `main` file.

Safety

May 7 2021, 9:15 PM
dish added a comment to D7812: [dagit] Prepare to remove `main` file.

I'll put main.tsx back in temporarily for now to preserve safety, and will remove it completely in a followup.

May 7 2021, 9:14 PM
dish requested review of D7812: [dagit] Prepare to remove `main` file.
May 7 2021, 7:57 PM
dish closed D7787: [dagit] Upgrade apollo.
May 7 2021, 2:53 PM
dish committed R1:95bdac510f74: [dagit] Upgrade apollo (authored by dish).
[dagit] Upgrade apollo
May 7 2021, 2:53 PM
dish requested review of D7790: [dagit] Move everything out of __tests__.
May 7 2021, 2:21 PM
dish accepted D7688: [dagit] Make Non-Subscription GraphQL ops use HTTP.

redfordnod

May 7 2021, 1:42 PM
dish requested review of D7787: [dagit] Upgrade apollo.
May 7 2021, 1:18 PM
dish closed D7740: [dagit] Add `asOf` parameter to Asset views.
May 7 2021, 1:09 PM
dish committed R1:3c4f61c4da5c: [dagit] Add `asOf` parameter to Asset views (authored by dish).
[dagit] Add `asOf` parameter to Asset views
May 7 2021, 1:09 PM

May 6 2021

dish closed D7781: [dagit] Add a few more main exports.
May 6 2021, 11:10 PM
dish committed R1:f83bb37e555c: [dagit] Add a few more main exports (authored by dish).
[dagit] Add a few more main exports
May 6 2021, 11:10 PM
dish added a comment to D7688: [dagit] Make Non-Subscription GraphQL ops use HTTP.

JS looks fine to me.

May 6 2021, 3:55 PM
dish closed D7756: [dagit] Repair a type import.
May 6 2021, 2:15 PM
dish committed R1:19bdd3e8272f: [dagit] Repair a type import (authored by dish).
[dagit] Repair a type import
May 6 2021, 2:15 PM
dish requested review of D7756: [dagit] Repair a type import.
May 6 2021, 2:13 PM

May 5 2021

dish accepted D7709: prevent slow assets from slowing down page loads.
May 5 2021, 3:57 PM
dish requested review of D7740: [dagit] Add `asOf` parameter to Asset views.
May 5 2021, 3:28 PM

May 4 2021

dish added inline comments to D7709: prevent slow assets from slowing down page loads.
May 4 2021, 9:18 PM
dish accepted D7724: Fix beforeTimestamp comparison for event log timestamps.
May 4 2021, 9:13 PM
dish closed D7699: [dagit] Split apart Instance Health query.
May 4 2021, 1:42 PM
dish committed R1:dabbdbaa955f: [dagit] Split apart Instance Health query (authored by dish).
[dagit] Split apart Instance Health query
May 4 2021, 1:42 PM
dish added a comment to D7709: prevent slow assets from slowing down page loads.

Oh huh, I thought I had made the secondary query lazy. We can also do that, so that it won't perform the query until the user actually focuses the search input.

May 4 2021, 12:31 AM

May 3 2021

dish requested review of D7699: [dagit] Split apart Instance Health query.
May 3 2021, 7:04 PM
dish closed D7672: [dagit] Remove react-scripts from @dagit/core.
May 3 2021, 1:48 PM
dish committed R1:999f24e36398: [dagit] Remove react-scripts from @dagit/core (authored by dish).
[dagit] Remove react-scripts from @dagit/core
May 3 2021, 1:48 PM
dish closed D7685: [dagit] Make RunsSearchSpaceQuery lazy.
May 3 2021, 1:46 PM
dish committed R1:6a32fb00582d: [dagit] Make RunsSearchSpaceQuery lazy (authored by dish).
[dagit] Make RunsSearchSpaceQuery lazy
May 3 2021, 1:46 PM

Apr 30 2021

dish requested review of D7685: [dagit] Make RunsSearchSpaceQuery lazy.
Apr 30 2021, 7:36 PM
dish closed D7643: [dagit] Make logs scrolling table handles narrower.
Apr 30 2021, 4:57 PM
dish committed R1:1bb08a3f127a: [dagit] Make logs scrolling table handles narrower (authored by dish).
[dagit] Make logs scrolling table handles narrower
Apr 30 2021, 4:57 PM
dish requested review of D7672: [dagit] Remove react-scripts from @dagit/core.
Apr 30 2021, 1:18 AM

Apr 28 2021

dish closed D7628: [dagit] Display partition name tooltip if too long in matrix table.
Apr 28 2021, 9:52 PM
dish committed R1:b71efa5409a1: [dagit] Display partition name tooltip if too long in matrix table (authored by dish).
[dagit] Display partition name tooltip if too long in matrix table
Apr 28 2021, 9:51 PM
dish requested review of D7643: [dagit] Make logs scrolling table handles narrower.
Apr 28 2021, 9:04 PM
dish accepted D7632: Default to re-executing step selection of current run if one is present.
Apr 28 2021, 9:00 PM
dish accepted D7626: Storybook for PipelineGraph, stories for various DAG viz features.
Apr 28 2021, 8:58 PM
dish accepted D7609: Add storybooks for Gannt chart UI, show hh:mm:ss when clicking Gannt steps #4042.
Apr 28 2021, 8:56 PM

Apr 27 2021

dish requested review of D7628: [dagit] Display partition name tooltip if too long in matrix table.
Apr 27 2021, 8:30 PM
dish closed D7557: [dagit] Add close button to repo filter flyout.
Apr 27 2021, 2:11 PM
dish committed R1:3ce37729726b: [dagit] Add close button to repo filter flyout (authored by dish).
[dagit] Add close button to repo filter flyout
Apr 27 2021, 2:11 PM
dish closed D7572: [dagit] Link to pipeline from Run table.
Apr 27 2021, 2:10 PM
dish committed R1:e38ea3f260e6: [dagit] Link to pipeline from Run table (authored by dish).
[dagit] Link to pipeline from Run table
Apr 27 2021, 2:10 PM
dish closed D7597: [dagit] Polling query on assets page.
Apr 27 2021, 2:10 PM
dish committed R1:651dced83587: [dagit] Polling query on assets page (authored by dish).
[dagit] Polling query on assets page
Apr 27 2021, 2:10 PM
dish closed D7608: [dagit] Prevent solid selection from overlapping RunRoot header.
Apr 27 2021, 2:10 PM
dish committed R1:0c6868dbd46b: [dagit] Prevent solid selection from overlapping RunRoot header (authored by dish).
[dagit] Prevent solid selection from overlapping RunRoot header
Apr 27 2021, 2:10 PM
dish closed D7611: [dagit] Prevent overscroll on hscroll containers.
Apr 27 2021, 2:09 PM
dish committed R1:7cc69820d609: [dagit] Prevent overscroll on hscroll containers (authored by dish).
[dagit] Prevent overscroll on hscroll containers
Apr 27 2021, 2:09 PM

Apr 26 2021

dish requested review of D7611: [dagit] Prevent overscroll on hscroll containers.
Apr 26 2021, 10:26 PM
dish requested review of D7608: [dagit] Prevent solid selection from overlapping RunRoot header.
Apr 26 2021, 9:40 PM
dish requested review of D7597: [dagit] Polling query on assets page.
Apr 26 2021, 4:30 PM
dish closed D7579: [dagit] Preserve `view` value in Asset breadcrumbs.
Apr 26 2021, 4:13 PM
dish committed R1:13c3cff404da: [dagit] Preserve `view` value in Asset breadcrumbs (authored by dish).
[dagit] Preserve `view` value in Asset breadcrumbs
Apr 26 2021, 4:13 PM
dish added a comment to D7579: [dagit] Preserve `view` value in Asset breadcrumbs.

It seems like we can *just* use localStorage here, and no URL parameter at all. The URL param would be useful if I needed to link to a specific view, but I'm not sure that's really necessary since people would more likely be linking to specific assets. Lmk what you think.

Apr 26 2021, 2:17 PM
dish updated the diff for D7579: [dagit] Preserve `view` value in Asset breadcrumbs.

Use localStorage instead of URL params

Apr 26 2021, 2:16 PM

Apr 23 2021

dish added a comment to D7579: [dagit] Preserve `view` value in Asset breadcrumbs.

one user in #dagster-support was asking for a way to make the view selection sticky... maybe we could read/write to localStorage for the view and then just use the explicit url parameter on AssetEntryRoot and AssetCatalogRoot to set the localStorage value?

Apr 23 2021, 8:41 PM
dish requested review of D7579: [dagit] Preserve `view` value in Asset breadcrumbs.
Apr 23 2021, 8:14 PM
dish requested review of D7572: [dagit] Link to pipeline from Run table.
Apr 23 2021, 3:30 PM
dish closed D7567: [dagit] Fix favicon for path-prefix case.
Apr 23 2021, 3:07 PM
dish committed R1:6194a99d4cb6: [dagit] Fix favicon for path-prefix case (authored by dish).
[dagit] Fix favicon for path-prefix case
Apr 23 2021, 3:07 PM
dish closed D7566: [dagit] Give asset catalog list a new stacking context.
Apr 23 2021, 3:03 PM
dish committed R1:c2f7628f4abb: [dagit] Give asset catalog list a new stacking context (authored by dish).
[dagit] Give asset catalog list a new stacking context
Apr 23 2021, 3:03 PM

Apr 22 2021

dish requested review of D7567: [dagit] Fix favicon for path-prefix case.
Apr 22 2021, 9:32 PM
dish requested review of D7566: [dagit] Give asset catalog list a new stacking context.
Apr 22 2021, 9:11 PM
dish added a comment to D7557: [dagit] Add close button to repo filter flyout.

Screen Shot 2021-04-22 at 12.42.59 PM.png (404×1 px, 161 KB)

Apr 22 2021, 8:33 PM
dish closed D7548: [dagit] Show permanent pipeline tags on playground.
Apr 22 2021, 8:30 PM
dish committed R1:6194e919af99: [dagit] Show permanent pipeline tags on playground (authored by dish).
[dagit] Show permanent pipeline tags on playground
Apr 22 2021, 8:30 PM
dish requested review of D7557: [dagit] Add close button to repo filter flyout.
Apr 22 2021, 6:07 PM
dish accepted D7537: fix asset directory navigation.

Does there need to be a mechanism to go "up" a directory level while navigating?

Apr 22 2021, 12:57 PM

Apr 21 2021

dish requested review of D7548: [dagit] Show permanent pipeline tags on playground.
Apr 21 2021, 10:16 PM
dish closed D7540: [dagit] Make log timestamps permalinks.
Apr 21 2021, 7:29 PM
dish committed R1:e36ad6f37594: [dagit] Make log timestamps permalinks (authored by dish).
[dagit] Make log timestamps permalinks
Apr 21 2021, 7:29 PM
dish closed D7510: [dagit] React.lazy pipeline playground.
Apr 21 2021, 7:11 PM
dish committed R1:82f62369954d: [dagit] React.lazy pipeline playground (authored by dish).
[dagit] React.lazy pipeline playground
Apr 21 2021, 7:11 PM
dish requested review of D7540: [dagit] Make log timestamps permalinks.
Apr 21 2021, 5:19 PM

Apr 20 2021

dish accepted D7524: use react-router-dom to navigate from backfill table to fix prefix-path urls.
Apr 20 2021, 3:55 PM
dish published D7524: use react-router-dom to navigate from backfill table to fix prefix-path urls for review.
Apr 20 2021, 3:55 PM

Apr 19 2021

dish closed D7503: [dagit] Bucket materializations in asset grid.
Apr 19 2021, 9:55 PM