Page MenuHomeElementl
Feed Advanced Search

Feb 9 2021

dish committed R1:1901f9dc1109: [dagit] Consistent top nav (authored by dish).
[dagit] Consistent top nav
Feb 9 2021, 7:22 PM
dish updated the diff for D6367: [dagit] Consistent top nav.

Spelling

Feb 9 2021, 7:08 PM
dish updated the diff for D6367: [dagit] Consistent top nav.

Reduce RunRoot header by 8px to keep it equivalent to master height. Seems ok to me. Also changed some of the description links to stay repo-specific for now.

Feb 9 2021, 7:05 PM
dish added a comment to D6367: [dagit] Consistent top nav.

I'm a little wary of the run header taking up so much space - the rest of the page has a much higher information density than the header now. It looks nice though - if anything, maybe we make all of these headers a bit smaller / less playful if the team feels the same way.

Feb 9 2021, 6:54 PM
dish closed D6378: [dagit] Fix version number in left nav.
Feb 9 2021, 5:42 PM
dish committed R1:29815a69fc3f: [dagit] Fix version number in left nav (authored by dish).
[dagit] Fix version number in left nav
Feb 9 2021, 5:42 PM
dish requested review of D6378: [dagit] Fix version number in left nav.
Feb 9 2021, 5:28 PM
dish accepted D6332: defer schedule queries until the `Scheduled` runs tab is clicked.

I think I had included this so that it would be part of the polled/refreshed query. Is it okay that it won't refresh automatically?

Feb 9 2021, 1:56 PM

Feb 8 2021

dish added a comment to D6367: [dagit] Consistent top nav.

Screen Shot 2021-02-08 at 4.55.03 PM.png (1×2 px, 278 KB)

Feb 8 2021, 10:56 PM
dish requested review of D6367: [dagit] Consistent top nav.
Feb 8 2021, 10:55 PM
dish closed D6357: [dagit] Add ID field to DaemonHealth.
Feb 8 2021, 10:44 PM
dish committed R1:80dff2e0e87e: [dagit] Add ID field to DaemonHealth (authored by dish).
[dagit] Add ID field to DaemonHealth
Feb 8 2021, 10:44 PM
dish requested review of D6357: [dagit] Add ID field to DaemonHealth.
Feb 8 2021, 8:40 PM
dish closed D6328: [dagit] Top-level pages for Schedules, Sensors.
Feb 8 2021, 7:46 PM
dish committed R1:3210ef02437a: [dagit] Top-level pages for Schedules, Sensors (authored by dish).
[dagit] Top-level pages for Schedules, Sensors
Feb 8 2021, 7:46 PM
dish added a comment to D6328: [dagit] Top-level pages for Schedules, Sensors.

Unloadable schedules/sensors:

Feb 8 2021, 7:37 PM
dish updated the diff for D6328: [dagit] Top-level pages for Schedules, Sensors.

Rebase, regenerate types, double-check unloadables.

Feb 8 2021, 7:37 PM

Feb 5 2021

dish closed D6333: [dagit] Fix Gantt chart scale.
Feb 5 2021, 9:07 PM
dish committed R1:45d658565eb6: [dagit] Fix Gantt chart scale (authored by dish).
[dagit] Fix Gantt chart scale
Feb 5 2021, 9:07 PM
dish requested review of D6333: [dagit] Fix Gantt chart scale.
Feb 5 2021, 8:47 PM
dish requested review of D6328: [dagit] Top-level pages for Schedules, Sensors.
Feb 5 2021, 5:12 PM
dish closed D6325: [dagit] Fix Schedule root spacing.
Feb 5 2021, 5:06 PM
dish committed R1:e5e41e608ad9: [dagit] Fix Schedule root spacing (authored by dish).
[dagit] Fix Schedule root spacing
Feb 5 2021, 5:06 PM
dish requested review of D6325: [dagit] Fix Schedule root spacing.
Feb 5 2021, 4:48 PM
dish closed D6324: [dagit] QueryCountdown to consolidate some repetitive code.
Feb 5 2021, 4:47 PM
dish committed R1:35566c43faa3: [dagit] QueryCountdown to consolidate some repetitive code (authored by dish).
[dagit] QueryCountdown to consolidate some repetitive code
Feb 5 2021, 4:47 PM
dish closed D6323: Repair LeftNavSimple.stories.
Feb 5 2021, 4:44 PM
dish committed R1:283211fe4e97: Repair LeftNavSimple.stories (authored by dish).
Repair LeftNavSimple.stories
Feb 5 2021, 4:44 PM
dish closed D6322: Repair pointer-events with Group margins.
Feb 5 2021, 4:44 PM
dish committed R1:9de99ccea184: Repair pointer-events with Group margins (authored by dish).
Repair pointer-events with Group margins
Feb 5 2021, 4:44 PM
dish requested review of D6324: [dagit] QueryCountdown to consolidate some repetitive code.
Feb 5 2021, 3:57 PM
dish requested review of D6323: Repair LeftNavSimple.stories.
Feb 5 2021, 2:44 PM
dish requested review of D6322: Repair pointer-events with Group margins.
Feb 5 2021, 2:43 PM
dish closed D6308: [dagit] Fix log row expansion dialog header.
Feb 5 2021, 1:52 PM
dish committed R1:f0d1675413aa: [dagit] Fix log row expansion dialog header (authored by dish).
[dagit] Fix log row expansion dialog header
Feb 5 2021, 1:52 PM
dish closed D6304: [dagit] Handle displaying multiple daemon errors.
Feb 5 2021, 1:42 PM
dish committed R1:b76f97950ee2: [dagit] Handle displaying multiple daemon errors (authored by dish).
[dagit] Handle displaying multiple daemon errors
Feb 5 2021, 1:42 PM

Feb 4 2021

dish requested review of D6308: [dagit] Fix log row expansion dialog header.
Feb 4 2021, 7:07 PM
dish requested review of D6304: [dagit] Handle displaying multiple daemon errors.
Feb 4 2021, 5:10 PM

Feb 2 2021

dish closed D6252: [dagit] Add flag to enable new left nav.
Feb 2 2021, 9:30 PM
dish committed R1:c8e11a8291d0: [dagit] Add flag to enable new left nav (authored by dish).
[dagit] Add flag to enable new left nav
Feb 2 2021, 9:30 PM
dish closed D6256: [dagit] Set per-snapshot run filters as "permanent".
Feb 2 2021, 9:26 PM
dish committed R1:22aad5ba0621: [dagit] Set per-snapshot run filters as "permanent" (authored by dish).
[dagit] Set per-snapshot run filters as "permanent"
Feb 2 2021, 9:26 PM
dish accepted D6232: Use a finite spinner for the partition view loading indicator.
Feb 2 2021, 9:18 PM
dish accepted D6226: Update the headers on the run table to call out Run ID vs Snapshot ID, pipeline more clearly.
Feb 2 2021, 9:17 PM
dish requested review of D6256: [dagit] Set per-snapshot run filters as "permanent".
Feb 2 2021, 8:14 PM
dish requested review of D6252: [dagit] Add flag to enable new left nav.
Feb 2 2021, 7:34 PM

Feb 1 2021

dish added inline comments to D6239: Display minimum interval seconds on the sensor details page.
Feb 1 2021, 11:45 PM
dish accepted D6239: Display minimum interval seconds on the sensor details page.
Feb 1 2021, 11:23 PM
dish closed D6231: [dagit] Roots for Pipelines, Settings.
Feb 1 2021, 11:05 PM
dish closed D6230: [dagit] Time components.
Feb 1 2021, 11:04 PM
dish committed R1:fd93cf242482: [dagit] Roots for Pipelines, Settings (authored by dish).
[dagit] Roots for Pipelines, Settings
Feb 1 2021, 11:04 PM
dish committed R1:8e4d271dc87d: [dagit] Time components (authored by dish).
[dagit] Time components
Feb 1 2021, 11:04 PM
dish closed D6236: [dagit] Left Nav exploration.
Feb 1 2021, 11:03 PM
dish committed R1:79834b1010b5: [dagit] Left Nav exploration (authored by dish).
[dagit] Left Nav exploration
Feb 1 2021, 11:03 PM
dish updated the diff for D6231: [dagit] Roots for Pipelines, Settings.

Felt dirty to have the effect in the state setter, moved it back out.

Feb 1 2021, 10:54 PM
dish updated the diff for D6231: [dagit] Roots for Pipelines, Settings.

Move setFeatureFlags side effect into state setter function.

Feb 1 2021, 10:48 PM
dish added inline comments to D6231: [dagit] Roots for Pipelines, Settings.
Feb 1 2021, 10:41 PM
dish requested review of D6236: [dagit] Left Nav exploration.
Feb 1 2021, 9:35 PM
dish requested review of D6231: [dagit] Roots for Pipelines, Settings.
Feb 1 2021, 8:56 PM
dish requested review of D6230: [dagit] Time components.
Feb 1 2021, 8:53 PM
dish added a comment to D6226: Update the headers on the run table to call out Run ID vs Snapshot ID, pipeline more clearly.

Hmm, I'm not sure we have enough horizontal space for tags to have their own column. On narrower windows, I think the table already tends to run over the edge of the viewport.

Feb 1 2021, 7:08 PM
dish accepted D6215: set blank state for tick history.
Feb 1 2021, 6:53 PM
dish accepted D6227: Hide partial failure % from the run matrix unless you “Show Previous”.
Feb 1 2021, 6:52 PM
dish accepted D6228: [dagit] Fix responsiveness of partition graphs, flex:1 without min-width prevents shrinking.
Feb 1 2021, 6:52 PM
dish closed D6152: [dagit] Prompt to refresh config when repo is refreshed.
Feb 1 2021, 6:13 PM
dish committed R1:1743a4ff05a7: [dagit] Prompt to refresh config when repo is refreshed (authored by dish).
[dagit] Prompt to refresh config when repo is refreshed
Feb 1 2021, 6:13 PM
dish updated the diff for D6152: [dagit] Prompt to refresh config when repo is refreshed.

Use a stateful hook to ensure React re-renders after updating localStorage.

Feb 1 2021, 5:53 PM
dish added a comment to D6152: [dagit] Prompt to refresh config when repo is refreshed.

Good point, I'm kind of just depending on the cache clearing behavior leading to the re-render, but that is risky.

Feb 1 2021, 5:40 PM
dish closed D6169: [dagit] Clean up excess spinners on Runs page.
Feb 1 2021, 5:28 PM
dish committed R1:b6c5503d95c4: [dagit] Clean up excess spinners on Runs page (authored by dish).
[dagit] Clean up excess spinners on Runs page
Feb 1 2021, 5:28 PM
dish updated the diff for D6169: [dagit] Clean up excess spinners on Runs page.

Rebase

Feb 1 2021, 5:20 PM
dish closed D6181: [dagit] RFC: Launch runs in the same tab.
Feb 1 2021, 5:13 PM
dish committed R1:54a90705c592: [dagit] RFC: Launch runs in the same tab (authored by dish).
[dagit] RFC: Launch runs in the same tab
Feb 1 2021, 5:13 PM
dish closed D6191: [dagit] Use Spinner for Loading component.
Feb 1 2021, 5:12 PM
dish committed R1:a3b6de3ab6bd: [dagit] Use Spinner for Loading component (authored by dish).
[dagit] Use Spinner for Loading component
Feb 1 2021, 5:12 PM
dish closed D6188: [dagit] Standardize and slow down Spinner.
Feb 1 2021, 5:12 PM
dish committed R1:f13864084974: [dagit] Standardize and slow down Spinner (authored by dish).
[dagit] Standardize and slow down Spinner
Feb 1 2021, 5:12 PM
dish updated the diff for D6191: [dagit] Use Spinner for Loading component.

Rebase

Feb 1 2021, 5:03 PM
dish updated the diff for D6188: [dagit] Standardize and slow down Spinner.

Rebase

Feb 1 2021, 5:01 PM
dish added inline comments to D6188: [dagit] Standardize and slow down Spinner.
Feb 1 2021, 4:57 PM
dish added inline comments to D6188: [dagit] Standardize and slow down Spinner.
Feb 1 2021, 4:44 PM

Jan 29 2021

dish closed D6201: [dagit] Alert to replace Callout.
Jan 29 2021, 5:05 PM
dish committed R1:0b01d32d6789: [dagit] Alert to replace Callout (authored by dish).
[dagit] Alert to replace Callout
Jan 29 2021, 5:05 PM
dish closed D6187: [dagit] Use more memoization for repoAddress.
Jan 29 2021, 5:04 PM
dish committed R1:d609e1df64d3: [dagit] Use more memoization for repoAddress (authored by dish).
[dagit] Use more memoization for repoAddress
Jan 29 2021, 5:04 PM
dish closed D6148: [dagit] Better context for missing pipeline error on Run.
Jan 29 2021, 5:03 PM
dish committed R1:679b372583cb: [dagit] Better context for missing pipeline error on Run (authored by dish).
[dagit] Better context for missing pipeline error on Run
Jan 29 2021, 5:03 PM

Jan 28 2021

dish updated the diff for D6191: [dagit] Use Spinner for Loading component.

Rebase

Jan 28 2021, 9:20 PM
dish updated the diff for D6188: [dagit] Standardize and slow down Spinner.

Rebase

Jan 28 2021, 9:19 PM
dish updated the diff for D6187: [dagit] Use more memoization for repoAddress.

+prha

Jan 28 2021, 8:45 PM
dish requested review of D6201: [dagit] Alert to replace Callout.
Jan 28 2021, 8:42 PM
dish added reviewers for D6148: [dagit] Better context for missing pipeline error on Run: prha, sashank.
Jan 28 2021, 3:49 PM
dish accepted D6172: set minimum zoom range to cap the graph zoom level.
Jan 28 2021, 3:48 PM
dish accepted D6165: add time range selectors to tick history.
Jan 28 2021, 3:47 PM

Jan 27 2021

dish updated the diff for D6191: [dagit] Use Spinner for Loading component.

Oops, put loading delay back

Jan 27 2021, 11:52 PM
dish requested review of D6191: [dagit] Use Spinner for Loading component.
Jan 27 2021, 11:51 PM
dish requested review of D6188: [dagit] Standardize and slow down Spinner.
Jan 27 2021, 9:44 PM
dish requested review of D6187: [dagit] Use more memoization for repoAddress.
Jan 27 2021, 8:03 PM
dish closed D6179: [dagit] Improve duration/started/ended for queued and canceled Runs.
Jan 27 2021, 5:28 PM