Page MenuHomePhabricator
Feed Advanced Search

Yesterday

dish requested review of D6724: [dagit] Localize elapsed time and logs timestamps.
Mon, Mar 1, 8:42 PM
dish closed D6704: [dagit] Add global search to current left nav.
Mon, Mar 1, 5:38 PM
dish committed R1:a93d67ada78a: [dagit] Add global search to current left nav (authored by dish).
[dagit] Add global search to current left nav
Mon, Mar 1, 5:38 PM
dish updated the diff for D6704: [dagit] Add global search to current left nav.

Some spacing and styling tweaks

Mon, Mar 1, 5:15 PM
dish updated the diff for D6704: [dagit] Add global search to current left nav.

Lol spelling

Mon, Mar 1, 4:45 PM
dish updated the diff for D6704: [dagit] Add global search to current left nav.

Rebase, tweak alignment and style in trigger.

Mon, Mar 1, 4:45 PM
dish closed D6711: [dagit] Some dependency upgrades.
Mon, Mar 1, 4:38 PM
dish committed R1:926e12382ef1: [dagit] Some dependency upgrades (authored by dish).
[dagit] Some dependency upgrades
Mon, Mar 1, 4:38 PM
dish closed D6682: [dagit] Improve timestamp consistency and localization.
Mon, Mar 1, 4:09 PM
dish committed R1:ad4cb9d3bc0e: [dagit] Improve timestamp consistency and localization (authored by dish).
[dagit] Improve timestamp consistency and localization
Mon, Mar 1, 4:09 PM

Fri, Feb 26

dish requested review of D6711: [dagit] Some dependency upgrades.
Fri, Feb 26, 10:41 PM
dish requested review of D6704: [dagit] Add global search to current left nav.
Fri, Feb 26, 6:34 PM
dish accepted D6695: Fall back to the name of the daemon type in dagit when a new daemon type is introduced.
Fri, Feb 26, 4:03 PM

Thu, Feb 25

dish requested review of D6682: [dagit] Improve timestamp consistency and localization.
Thu, Feb 25, 11:09 PM
dish closed D6655: [dagit] Fuzzy search for log filter.
Thu, Feb 25, 3:15 AM
dish committed R1:8130a3bfd8e6: [dagit] Fuzzy search for log filter (authored by dish).
[dagit] Fuzzy search for log filter
Thu, Feb 25, 3:14 AM

Wed, Feb 24

dish requested review of D6655: [dagit] Fuzzy search for log filter.
Wed, Feb 24, 5:52 PM

Tue, Feb 23

dish closed D6645: Fix master.
Tue, Feb 23, 8:54 PM
dish committed R1:faa2c78a7cce: Fix master (authored by dish).
Fix master
Tue, Feb 23, 8:54 PM
dish closed D6642: [dagit] Enable react/jsx-no-target-blank.
Tue, Feb 23, 8:14 PM
dish committed R1:a52d0097bd3f: [dagit] Enable react/jsx-no-target-blank (authored by dish).
[dagit] Enable react/jsx-no-target-blank
Tue, Feb 23, 8:14 PM
dish added a comment to D6642: [dagit] Enable react/jsx-no-target-blank.

My thinking is:

Tue, Feb 23, 8:14 PM
dish closed D6572: [dagit] Use Python event types in log filter view.
Tue, Feb 23, 5:31 PM
dish closed D6547: [dagit] Simplify logs filtering input.
Tue, Feb 23, 5:31 PM
dish committed R1:7fe3f3edb132: [dagit] Use Python event types in log filter view (authored by dish).
[dagit] Use Python event types in log filter view
Tue, Feb 23, 5:31 PM
dish committed R1:10407b31cd64: [dagit] Simplify logs filtering input (authored by dish).
[dagit] Simplify logs filtering input
Tue, Feb 23, 5:31 PM
dish updated the diff for D6572: [dagit] Use Python event types in log filter view.

Resolve conflicts, rebase.

Tue, Feb 23, 4:53 PM
dish updated the diff for D6547: [dagit] Simplify logs filtering input.

+bengotow

Tue, Feb 23, 4:53 PM
dish added a comment to D6547: [dagit] Simplify logs filtering input.

The only possible regression I see here is that the LogsToolbar no longer accepts external modifications to filter.logsQuery, since it bakes that value into the initial value of it's state?

Tue, Feb 23, 4:42 PM
dish added a comment to D6642: [dagit] Enable react/jsx-no-target-blank.

Reading up on the lint rule a bit, it appears that noreferrer implies noopener, so the rule now just requires noreferrer.

Tue, Feb 23, 4:41 PM
dish requested review of D6642: [dagit] Enable react/jsx-no-target-blank.
Tue, Feb 23, 4:39 PM
dish accepted D6632: create blank states for sensor root table.
Tue, Feb 23, 4:05 PM
dish updated the diff for D6572: [dagit] Use Python event types in log filter view.

Rebase

Tue, Feb 23, 3:57 PM
dish updated the diff for D6547: [dagit] Simplify logs filtering input.

Rebase, fix which code is in the diff

Tue, Feb 23, 3:56 PM

Mon, Feb 22

dish closed D6589: [dagit] Add repo location reload to object headers.
Mon, Feb 22, 9:28 PM
dish committed R1:3c522865f16f: [dagit] Add repo location reload to object headers (authored by dish).
[dagit] Add repo location reload to object headers
Mon, Feb 22, 9:28 PM
dish updated the diff for D6589: [dagit] Add repo location reload to object headers.

Reduce max-width a bit further

Mon, Feb 22, 9:16 PM
dish closed D6564: [dagit] Flip hideNonMatches default.
Mon, Feb 22, 8:44 PM
dish committed R1:2c4f96107c3b: [dagit] Flip hideNonMatches default (authored by dish).
[dagit] Flip hideNonMatches default
Mon, Feb 22, 8:44 PM
dish closed D6606: [dagit] Fix Asset search selection.
Mon, Feb 22, 8:41 PM
dish committed R1:0a42eda67ff4: [dagit] Fix Asset search selection (authored by dish).
[dagit] Fix Asset search selection
Mon, Feb 22, 8:41 PM
dish closed D6628: [dagit] Add more useful things to Pipelines list.
Mon, Feb 22, 8:39 PM
dish committed R1:3a3d714a757d: [dagit] Add more useful things to Pipelines list (authored by dish).
[dagit] Add more useful things to Pipelines list
Mon, Feb 22, 8:39 PM
dish updated the diff for D6628: [dagit] Add more useful things to Pipelines list.

Nested forEach more legible than nested reduce

Mon, Feb 22, 8:26 PM
dish added a comment to D6628: [dagit] Add more useful things to Pipelines list.

It does seem it'd be nice to have the fuse implementation pulled out into a helper hook because it gets a little technical, but there may not be anywhere else that we could re-use it so it's probably not worth factoring apart into two pieces.

Mon, Feb 22, 8:20 PM
dish requested review of D6628: [dagit] Add more useful things to Pipelines list.
Mon, Feb 22, 7:26 PM
dish updated the diff for D6572: [dagit] Use Python event types in log filter view.

Rebase

Mon, Feb 22, 5:31 PM
dish updated the diff for D6572: [dagit] Use Python event types in log filter view.

Rebase

Mon, Feb 22, 5:30 PM

Fri, Feb 19

dish closed D6604: [dagit] Link backfill toast to filtered runs.
Fri, Feb 19, 6:27 PM
dish committed R1:4d0b512b5f52: [dagit] Link backfill toast to filtered runs (authored by dish).
[dagit] Link backfill toast to filtered runs
Fri, Feb 19, 6:27 PM
dish closed D6603: [dagit] Fix RunDetails timing strings.
Fri, Feb 19, 6:26 PM
dish committed R1:59472fefb6f2: [dagit] Fix RunDetails timing strings (authored by dish).
[dagit] Fix RunDetails timing strings
Fri, Feb 19, 6:26 PM
dish requested review of D6606: [dagit] Fix Asset search selection.
Fri, Feb 19, 4:09 PM
dish requested review of D6604: [dagit] Link backfill toast to filtered runs.
Fri, Feb 19, 3:51 PM
dish requested review of D6603: [dagit] Fix RunDetails timing strings.
Fri, Feb 19, 3:34 PM
dish updated the diff for D6547: [dagit] Simplify logs filtering input.

Rebase

Fri, Feb 19, 1:45 PM
dish updated the diff for D6572: [dagit] Use Python event types in log filter view.

Rebase

Fri, Feb 19, 1:44 PM

Thu, Feb 18

dish closed D6574: [dagit] Show a tooltip on InstanceWarningIcon.
Thu, Feb 18, 11:51 PM
dish committed R1:572c503f63ea: [dagit] Show a tooltip on InstanceWarningIcon (authored by dish).
[dagit] Show a tooltip on InstanceWarningIcon
Thu, Feb 18, 11:50 PM
dish requested review of D6589: [dagit] Add repo location reload to object headers.
Thu, Feb 18, 11:26 PM
dish requested review of D6572: [dagit] Use Python event types in log filter view.
Thu, Feb 18, 7:48 PM
dish requested review of D6574: [dagit] Show a tooltip on InstanceWarningIcon.
Thu, Feb 18, 6:05 PM
dish closed D6532: [dagit] Revert code splitting for ExecutionSessionContainer.
Thu, Feb 18, 4:38 PM
dish committed R1:a8487f17aaff: [dagit] Revert code splitting for ExecutionSessionContainer (authored by dish).
[dagit] Revert code splitting for ExecutionSessionContainer
Thu, Feb 18, 4:38 PM
dish requested review of D6564: [dagit] Flip hideNonMatches default.
Thu, Feb 18, 3:56 PM
dish added a comment to D6532: [dagit] Revert code splitting for ExecutionSessionContainer.

This needs to be in the release, btw.

Thu, Feb 18, 1:21 AM

Wed, Feb 17

dish accepted D6490: Force scrollbar visibility on partition matrix to make behavior more clear #3638.
Wed, Feb 17, 9:52 PM
dish requested review of D6547: [dagit] Simplify logs filtering input.
Wed, Feb 17, 8:33 PM
dish requested review of D6532: [dagit] Revert code splitting for ExecutionSessionContainer.
Wed, Feb 17, 3:15 PM

Tue, Feb 16

dish closed D6403: [dagit] RFC: Instance status dot in left nav.
Tue, Feb 16, 6:49 PM
dish committed R1:f7c0563ad1df: [dagit] RFC: Instance status dot in left nav (authored by dish).
[dagit] RFC: Instance status dot in left nav
Tue, Feb 16, 6:49 PM
dish added a comment to D6403: [dagit] RFC: Instance status dot in left nav.

Tue, Feb 16, 6:18 PM
dish updated the diff for D6403: [dagit] RFC: Instance status dot in left nav.

Use triangle icon, and only display anything when there are warnings.

Tue, Feb 16, 6:18 PM
dish added a comment to D6403: [dagit] RFC: Instance status dot in left nav.

We use status dots in a lot of places - what if we made this one a little rounded yellow triangle and hide it when instance status is OK? That might help disambiguate it from the websocket connectivity one. (edit: Actually, did we get rid of that one? This one polls rather than checking the websocket?)

Tue, Feb 16, 5:23 PM
dish closed D6447: [dagit] Some loading-state cleanup.
Tue, Feb 16, 5:13 PM
dish committed R1:ff62065e5439: [dagit] Some loading-state cleanup (authored by dish).
[dagit] Some loading-state cleanup
Tue, Feb 16, 5:13 PM
dish closed D6441: [dagit] Shortcut handlers for simple left nav.
Tue, Feb 16, 5:11 PM
dish committed R1:df7049665178: [dagit] Shortcut handlers for simple left nav (authored by dish).
[dagit] Shortcut handlers for simple left nav
Tue, Feb 16, 5:11 PM
dish added inline comments to D6441: [dagit] Shortcut handlers for simple left nav.
Tue, Feb 16, 5:05 PM

Fri, Feb 12

dish closed D6435: [dagit] Don't block viewing PythonError on Playground preview.
Fri, Feb 12, 2:10 PM
dish committed R1:a837b5c4d99e: [dagit] Don't block viewing PythonError on Playground preview (authored by dish).
[dagit] Don't block viewing PythonError on Playground preview
Fri, Feb 12, 2:10 PM
dish closed D6425: [dagit] Preserve solid selection when refreshing config.
Fri, Feb 12, 2:10 PM
dish committed R1:c60eb2507569: [dagit] Preserve solid selection when refreshing config (authored by dish).
[dagit] Preserve solid selection when refreshing config
Fri, Feb 12, 2:10 PM

Thu, Feb 11

dish requested review of D6447: [dagit] Some loading-state cleanup.
Thu, Feb 11, 11:26 PM
dish requested review of D6441: [dagit] Shortcut handlers for simple left nav.
Thu, Feb 11, 10:12 PM
dish requested review of D6435: [dagit] Don't block viewing PythonError on Playground preview.
Thu, Feb 11, 8:00 PM
dish closed D6386: [dagit] Tweak some spacing following header change.
Thu, Feb 11, 5:56 PM
dish committed R1:5fdd1def92a5: [dagit] Tweak some spacing following header change (authored by dish).
[dagit] Tweak some spacing following header change
Thu, Feb 11, 5:56 PM
dish closed D6402: [dagit] Consistent blue color for nav, search.
Thu, Feb 11, 5:52 PM
dish committed R1:9c5235a9be84: [dagit] Consistent blue color for nav, search (authored by dish).
[dagit] Consistent blue color for nav, search
Thu, Feb 11, 5:52 PM
dish closed D6413: [dagit] Adjust run status colors.
Thu, Feb 11, 5:51 PM
dish committed R1:4a0d700d4d3b: [dagit] Adjust run status colors (authored by dish).
[dagit] Adjust run status colors
Thu, Feb 11, 5:51 PM
dish requested review of D6425: [dagit] Preserve solid selection when refreshing config.
Thu, Feb 11, 5:28 PM

Wed, Feb 10

dish requested review of D6413: [dagit] Adjust run status colors.
Wed, Feb 10, 8:14 PM
dish requested review of D6405: [dagit] Font smoothing and default color.
Wed, Feb 10, 4:39 PM
dish requested review of D6402: [dagit] Consistent blue color for nav, search.
Wed, Feb 10, 3:51 PM
dish added a comment to D6403: [dagit] RFC: Instance status dot in left nav.

Wed, Feb 10, 3:37 PM
dish requested review of D6403: [dagit] RFC: Instance status dot in left nav.
Wed, Feb 10, 3:36 PM

Tue, Feb 9

dish requested review of D6386: [dagit] Tweak some spacing following header change.
Tue, Feb 9, 8:37 PM
dish closed D6367: [dagit] Consistent top nav.
Tue, Feb 9, 7:22 PM