Page MenuHomePhabricator
Feed Advanced Search

Yesterday

dish requested review of D4983: Remove `download-mocks` script.
Fri, Oct 30, 11:05 PM
dish requested review of D4981: Add a handful of tests back to App.test.
Fri, Oct 30, 8:00 PM
dish closed D4931: Upgrade Apollo.
Fri, Oct 30, 3:45 PM
dish committed R1:bfc8f0940c51: Upgrade Apollo (authored by dish).
Upgrade Apollo
Fri, Oct 30, 3:45 PM
dish updated the diff for D4931: Upgrade Apollo.

Rebase

Fri, Oct 30, 3:38 PM
dish closed D4969: [dagit] Empty definition state for empty pipelines.
Fri, Oct 30, 3:30 PM
dish committed R1:4c4699076e22: [dagit] Empty definition state for empty pipelines (authored by dish).
[dagit] Empty definition state for empty pipelines
Fri, Oct 30, 3:30 PM
dish added a comment to D4931: Upgrade Apollo.

Should note that we are removing tests for rendering the type page, solids page, and playground. But let's burn it down. Curious to see what testing structure you have in mind...

Fri, Oct 30, 3:30 PM
dish updated the diff for D4931: Upgrade Apollo.

Rebase

Fri, Oct 30, 1:18 PM
dish closed D4961: [dagit] Flip UTC offset sign in timezone picker.
Fri, Oct 30, 1:17 PM
dish committed R1:147d8493c4af: [dagit] Flip UTC offset sign in timezone picker (authored by dish).
[dagit] Flip UTC offset sign in timezone picker
Fri, Oct 30, 1:17 PM
dish closed D4970: [dagit] Use Table for /scheduler.
Fri, Oct 30, 1:16 PM
dish committed R1:4767a8ce2fad: [dagit] Use Table for /scheduler (authored by dish).
[dagit] Use Table for /scheduler
Fri, Oct 30, 1:16 PM

Thu, Oct 29

dish requested review of D4970: [dagit] Use Table for /scheduler.
Thu, Oct 29, 9:28 PM
dish requested review of D4969: [dagit] Empty definition state for empty pipelines.
Thu, Oct 29, 9:16 PM
dish requested review of D4961: [dagit] Flip UTC offset sign in timezone picker.
Thu, Oct 29, 7:38 PM
dish requested review of D4931: Upgrade Apollo.
Thu, Oct 29, 7:06 PM
dish added a comment to D4921: Store repo location loading errors on the workspace, take errors into account when loading and reloading repo locations.

I'm working on a nicer way to surface these errors in the UI, but as part of the overall nav structure changes.

Thu, Oct 29, 2:32 PM
dish added inline comments to D4898: Change partition matrix click behavior, split large files and GraphQL types.
Thu, Oct 29, 2:28 PM
dish closed D4930: Use CRA jest command.
Thu, Oct 29, 2:11 PM
dish committed R1:5ef36572f1cd: Use CRA jest command (authored by dish).
Use CRA jest command
Thu, Oct 29, 2:11 PM

Wed, Oct 28

dish requested review of D4930: Use CRA jest command.
Wed, Oct 28, 2:22 PM
dish closed D4929: Enable import/no-duplicates eslint.
Wed, Oct 28, 1:57 PM
dish committed R1:1cec5452b07d: Enable import/no-duplicates eslint (authored by dish).
Enable import/no-duplicates eslint
Wed, Oct 28, 1:57 PM

Tue, Oct 27

dish requested review of D4929: Enable import/no-duplicates eslint.
Tue, Oct 27, 10:01 PM
dish closed D4914: ApolloTestProvider.
Tue, Oct 27, 9:50 PM
dish committed R1:5122764d7659: ApolloTestProvider (authored by dish).
ApolloTestProvider
Tue, Oct 27, 9:50 PM
dish added a comment to D4914: ApolloTestProvider.

This looks good to me - I guess it replaces the MockedProvider we already have in place in App.test.tsx?

I think that our current implementation of the graphql mocking is a bit unusual but it was designed to replace defaultMocks with query results loaded from a folder of JSON files. (At the time, Apollo seemed to suggest maintaining "defaultMocks" by hand, and for our queries that'd be crazy.) The current setup allows you to run the actual GraphQL server and pull down real data to generate the folder of mocks, and then run the tests against those files. It's definitely not ideal because changes to the demo pipelines change the GraphQL mocks which change the snapshots, but it seemed like maintaining the mocks by hand was untenable.

Tue, Oct 27, 9:25 PM
dish requested review of D4914: ApolloTestProvider.
Tue, Oct 27, 3:09 PM

Mon, Oct 26

dish closed D4876: [dagit] Quick search component (experiment).
Mon, Oct 26, 7:00 PM
dish committed R1:0cbb8dece601: [dagit] Quick search component (experiment) (authored by dish).
[dagit] Quick search component (experiment)
Mon, Oct 26, 7:00 PM
dish retitled D4876: [dagit] Quick search component (experiment) from RFC [dagit] Quick search to [dagit] Quick search component (experiment).
Mon, Oct 26, 6:59 PM
dish accepted D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.
Mon, Oct 26, 6:29 PM
dish updated the diff for D4876: [dagit] Quick search component (experiment).

+bengotow, went with a dir for sample data because ts didn't like the .data.ts extension

Mon, Oct 26, 6:25 PM
dish closed D4871: [dagit] Replace Legend tables with Table.
Mon, Oct 26, 6:18 PM
dish committed R1:4396161679ee: [dagit] Replace Legend tables with Table (authored by dish).
[dagit] Replace Legend tables with Table
Mon, Oct 26, 6:18 PM
dish added inline comments to D4876: [dagit] Quick search component (experiment).
Mon, Oct 26, 6:10 PM
dish updated the diff for D4871: [dagit] Replace Legend tables with Table.

+bengotow

Mon, Oct 26, 6:05 PM
dish added inline comments to D4871: [dagit] Replace Legend tables with Table.
Mon, Oct 26, 5:55 PM
dish closed D4885: [dagit] Move fonts to src.
Mon, Oct 26, 5:49 PM
dish committed R1:2baa707c9b43: [dagit] Move fonts to src (authored by dish).
[dagit] Move fonts to src
Mon, Oct 26, 5:49 PM

Fri, Oct 23

dish requested review of D4885: [dagit] Move fonts to src.
Fri, Oct 23, 6:50 PM

Thu, Oct 22

dish requested review of D4876: [dagit] Quick search component (experiment).
Thu, Oct 22, 10:33 PM
dish requested review of D4871: [dagit] Replace Legend tables with Table.
Thu, Oct 22, 8:05 PM
dish closed D4864: [dagit] Tag truncation on Playground.
Thu, Oct 22, 3:36 PM
dish committed R1:4ff17fdc635f: [dagit] Tag truncation on Playground (authored by dish).
[dagit] Tag truncation on Playground
Thu, Oct 22, 3:36 PM
dish updated the diff for D4864: [dagit] Tag truncation on Playground.

Clean up border-radius on tag value

Thu, Oct 22, 3:08 PM
dish requested review of D4864: [dagit] Tag truncation on Playground.
Thu, Oct 22, 3:00 PM

Tue, Oct 20

dish closed D4821: [dagit] Create workspace routes.
Tue, Oct 20, 7:24 PM
dish committed R1:17c5334963d4: [dagit] Create workspace routes (authored by dish).
[dagit] Create workspace routes
Tue, Oct 20, 7:24 PM
dish retitled D4821: [dagit] Create workspace routes from RFC: [dagit] Start adding Workspace routes to [dagit] Create workspace routes.
Tue, Oct 20, 7:09 PM
dish updated the diff for D4821: [dagit] Create workspace routes.

Remove console.log

Tue, Oct 20, 7:08 PM
dish closed D4828: [dagit] Create instance routes.
Tue, Oct 20, 6:56 PM
dish committed R1:00202b96f1c4: [dagit] Create instance routes (authored by dish).
[dagit] Create instance routes
Tue, Oct 20, 6:56 PM
dish retitled D4828: [dagit] Create instance routes from RFC [dagit] Create instance routes to [dagit] Create instance routes.
Tue, Oct 20, 6:55 PM
dish added a comment to D4821: [dagit] Create workspace routes.

I'm a little bit worried that the whole concept of a repo location isn't necc. clear to users right now though, especially when they only have a single repository in each location

Tue, Oct 20, 6:52 PM
dish requested review of D4828: [dagit] Create instance routes.
Tue, Oct 20, 5:04 PM

Mon, Oct 19

dish added a comment to D4809: Clean up partitions UI and improve backfill usability.

Possibly crazy idea: can we use a yaml CodeMirror here? E.g.

Mon, Oct 19, 10:54 PM
dish requested review of D4821: [dagit] Create workspace routes.
Mon, Oct 19, 10:04 PM
dish requested changes to D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.

Direction looks great to me. Some nits inline, mostly stylistic/legibility things.

Mon, Oct 19, 7:54 PM

Fri, Oct 16

dish closed D4803: [dagit] Standardize font-family usage.
Fri, Oct 16, 7:04 PM
dish committed R1:f24d430fcbd0: [dagit] Standardize font-family usage (authored by dish).
[dagit] Standardize font-family usage
Fri, Oct 16, 7:04 PM
dish updated the diff for D4803: [dagit] Standardize font-family usage.

Accidental comment

Fri, Oct 16, 6:39 PM
dish closed D4765: [dagit] Allow copying filter state to URL on Run page.
Fri, Oct 16, 6:13 PM
dish committed R1:2fd4374e3889: [dagit] Allow copying filter state to URL on Run page (authored by dish).
[dagit] Allow copying filter state to URL on Run page
Fri, Oct 16, 6:13 PM
dish updated the diff for D4765: [dagit] Allow copying filter state to URL on Run page.

Remove rogue console.log

Fri, Oct 16, 6:01 PM
dish added a comment to D4803: [dagit] Standardize font-family usage.

Before:

Fri, Oct 16, 6:00 PM
dish requested review of D4803: [dagit] Standardize font-family usage.
Fri, Oct 16, 5:57 PM
dish added inline comments to D4765: [dagit] Allow copying filter state to URL on Run page.
Fri, Oct 16, 5:54 PM

Thu, Oct 15

dish committed R1:9b9c78e332f9: [Docs] 0.9.15 (authored by dish).
[Docs] 0.9.15
Thu, Oct 15, 10:55 PM
dish committed R1:ffc2566c127c: 0.9.15 (authored by dish).
0.9.15
Thu, Oct 15, 10:18 PM
dish committed R1:da8a0069f1c9: 0.9.15pre0 (authored by dish).
0.9.15pre0
Thu, Oct 15, 9:58 PM
dish closed D4795: Changes for 0.9.15.
Thu, Oct 15, 9:45 PM
dish committed R1:9ac36b9274f1: Changes for 0.9.15 (authored by dish).
Changes for 0.9.15
Thu, Oct 15, 9:45 PM
dish updated the diff for D4795: Changes for 0.9.15.

+alangenfeld

Thu, Oct 15, 9:40 PM
dish closed D4789: [dagit] Use parent snapshot ID to determine current-ness of snapshot.
Thu, Oct 15, 8:11 PM
dish committed R1:84a37997d508: [dagit] Use parent snapshot ID to determine current-ness of snapshot (authored by dish).
[dagit] Use parent snapshot ID to determine current-ness of snapshot
Thu, Oct 15, 8:11 PM
dish updated the diff for D4789: [dagit] Use parent snapshot ID to determine current-ness of snapshot.

Show 'Snapshot' if there is no current pipeline state

Thu, Oct 15, 7:52 PM
dish closed D4790: [dagit] Restore nav height fix for Safari.
Thu, Oct 15, 7:40 PM
dish committed R1:fd3a0fcd5479: [dagit] Restore nav height fix for Safari (authored by dish).
[dagit] Restore nav height fix for Safari
Thu, Oct 15, 7:40 PM
dish requested review of D4790: [dagit] Restore nav height fix for Safari.
Thu, Oct 15, 7:15 PM
dish requested review of D4789: [dagit] Use parent snapshot ID to determine current-ness of snapshot.
Thu, Oct 15, 5:30 PM

Wed, Oct 14

dish closed D4784: [dagit] Allow snapshots to re-run even if the snapshot ID is mismatched.
Wed, Oct 14, 9:51 PM
dish committed R1:703aa09985bf: [dagit] Allow snapshots to re-run even if the snapshot ID is mismatched (authored by dish).
[dagit] Allow snapshots to re-run even if the snapshot ID is mismatched
Wed, Oct 14, 9:51 PM
dish added inline comments to D4784: [dagit] Allow snapshots to re-run even if the snapshot ID is mismatched.
Wed, Oct 14, 9:50 PM
dish updated the diff for D4784: [dagit] Allow snapshots to re-run even if the snapshot ID is mismatched.

+alangenfeld

Wed, Oct 14, 9:44 PM
dish added inline comments to D4784: [dagit] Allow snapshots to re-run even if the snapshot ID is mismatched.
Wed, Oct 14, 9:44 PM
dish requested review of D4784: [dagit] Allow snapshots to re-run even if the snapshot ID is mismatched.
Wed, Oct 14, 9:26 PM
dish closed D4782: [dagit] Remove "historical" tag on Run table.
Wed, Oct 14, 8:54 PM
dish committed R1:67e4e6b1a7a2: [dagit] Remove "historical" tag on Run table (authored by dish).
[dagit] Remove "historical" tag on Run table
Wed, Oct 14, 8:54 PM
dish requested review of D4782: [dagit] Remove "historical" tag on Run table.
Wed, Oct 14, 8:21 PM
dish accepted D4762: [dagit] change Preparing to Not Executed.
Wed, Oct 14, 3:04 PM

Tue, Oct 13

dish accepted D4695: Incrementally fetch data for partition set UI.
Tue, Oct 13, 9:26 PM
dish added a comment to D4695: Incrementally fetch data for partition set UI.

Some minor comments -- the only one that strikes me as a maybe-bug is the pop followed by slice.

Tue, Oct 13, 9:26 PM
dish closed D4766: Delete unnecessary file, fix run row link.
Tue, Oct 13, 6:15 PM
dish committed R1:078f1b92bfc8: Delete unnecessary file, fix run row link (authored by dish).
Delete unnecessary file, fix run row link
Tue, Oct 13, 6:15 PM
dish requested review of D4766: Delete unnecessary file, fix run row link.
Tue, Oct 13, 6:08 PM
dish closed D4709: [dagit] Separate snapshot and current pipeline permalinks.
Tue, Oct 13, 5:54 PM
dish committed R1:f7dd62ecd9e2: [dagit] Separate snapshot and current pipeline permalinks (authored by dish).
[dagit] Separate snapshot and current pipeline permalinks
Tue, Oct 13, 5:54 PM
dish added inline comments to D4762: [dagit] change Preparing to Not Executed.
Tue, Oct 13, 5:52 PM