Page MenuHomeElementl
Feed Advanced Search

Apr 26 2021

sidkmenon updated the diff for D7504: [docs] Dagster GraphQL Python Client [4/4].

Responding to @sandyryza's comments

Apr 26 2021, 5:27 PM

Apr 23 2021

sidkmenon updated the diff for D7504: [docs] Dagster GraphQL Python Client [4/4].

Responding to @rexledesma's comments

Apr 23 2021, 8:31 PM
sidkmenon updated the diff for D7504: [docs] Dagster GraphQL Python Client [4/4].

Forgot to run make snapshot

Apr 23 2021, 5:30 PM
sidkmenon updated the diff for D7504: [docs] Dagster GraphQL Python Client [4/4].

restructuring docs as per @rexledesma's advice

Apr 23 2021, 5:02 PM

Apr 22 2021

sidkmenon updated the summary of D7504: [docs] Dagster GraphQL Python Client [4/4].
Apr 22 2021, 6:55 PM
sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/4].

Adding to all

Apr 22 2021, 6:52 PM
sidkmenon updated the diff for D7504: [docs] Dagster GraphQL Python Client [4/4].

Refactoring the dagster GraphQL client to its own docs page

Apr 22 2021, 6:47 PM
sidkmenon updated the summary of D7504: [docs] Dagster GraphQL Python Client [4/4].
Apr 22 2021, 6:44 PM
sidkmenon updated the diff for D7504: [docs] Dagster GraphQL Python Client [4/4].

Fixing API docs issues

Apr 22 2021, 6:07 PM
sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/4].

Addressing upstream docs comments - also (hopefully) improved error message structure for "InvalidOutputError"

Apr 22 2021, 5:54 PM
sidkmenon updated the diff for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].

Responding to more @sandyryza's comments and some upstream docs changes

Apr 22 2021, 5:51 PM
sidkmenon added inline comments to D7424: [dagster-graphql] Dagster GraphQL Python Client [3/4].
Apr 22 2021, 5:06 PM

Apr 21 2021

sidkmenon added inline comments to D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].
Apr 21 2021, 8:43 PM
sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/4].

rebasing

Apr 21 2021, 8:39 PM
sidkmenon updated the diff for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].

Responding to some of @sandyryza's comments

Apr 21 2021, 8:31 PM
sidkmenon added inline comments to D7424: [dagster-graphql] Dagster GraphQL Python Client [3/4].
Apr 21 2021, 6:06 PM
sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/4].

Addressing nits

Apr 21 2021, 4:33 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/4].

nit fixes

Apr 21 2021, 4:29 PM
sidkmenon updated the summary of D7504: [docs] Dagster GraphQL Python Client [4/4].
Apr 21 2021, 4:24 PM
sidkmenon published D7504: [docs] Dagster GraphQL Python Client [4/4] for review.
Apr 21 2021, 4:24 PM

Apr 20 2021

sidkmenon added a reviewer for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/4]: sandyryza.
Apr 20 2021, 7:18 PM
sidkmenon added a reviewer for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/4]: sandyryza.
Apr 20 2021, 7:18 PM
sidkmenon added a reviewer for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4]: sandyryza.
Apr 20 2021, 7:17 PM
sidkmenon updated the diff for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].

Fixing typo

Apr 20 2021, 7:00 PM
sidkmenon updated the diff for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].

Adding in docstrings to public-facing namedtuples

Apr 20 2021, 6:53 PM
sidkmenon updated the diff for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].

Adding experimental warning to DagsterGraphQLClient

Apr 20 2021, 6:35 PM
sidkmenon updated the diff for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].

Moving DagsterGraphQLClient to the top level

Apr 20 2021, 6:31 PM
sidkmenon added inline comments to D7424: [dagster-graphql] Dagster GraphQL Python Client [3/4].
Apr 20 2021, 5:57 PM
sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/4].

Addressing comments

Apr 20 2021, 5:23 PM

Apr 19 2021

sidkmenon retitled D7424: [dagster-graphql] Dagster GraphQL Python Client [3/4] from [dagster-graphql] Dagster GraphQL Python Client [3/3] to [dagster-graphql] Dagster GraphQL Python Client [3/4].
Apr 19 2021, 5:18 PM
sidkmenon retitled D7421: [dagster-graphql] Dagster GraphQL Python Client [2/4] from [dagster-graphql] Dagster GraphQL Python Client [2/3] to [dagster-graphql] Dagster GraphQL Python Client [2/4].
Apr 19 2021, 5:18 PM
sidkmenon retitled D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4] from [RFC] [dagster-graphql] Python Client Implementation [1/3] to [RFC] [dagster-graphql] Python Client Implementation [1/4].
Apr 19 2021, 5:16 PM
sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/4].

Modifying commit message

Apr 19 2021, 5:15 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/4].

Modifying commit message

Apr 19 2021, 5:15 PM
sidkmenon updated the diff for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].

Modifying commit message

Apr 19 2021, 5:14 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/4].

Adding README.md for the dagster-graphql-client CLI

Apr 19 2021, 4:13 PM

Apr 16 2021

sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/4].

rebasing

Apr 16 2021, 9:19 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/4].

Trying installation of dagster-graphql to fix build

Apr 16 2021, 9:10 PM
sidkmenon abandoned D7343: [Draft] [RFC] [dagster-graphql] Initial Python Client implementation.
Apr 16 2021, 8:33 PM
sidkmenon updated the test plan for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/4].
Apr 16 2021, 8:30 PM
sidkmenon added reviewers for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/4]: alangenfeld, catherinewu.
Apr 16 2021, 8:30 PM
sidkmenon added a reviewer for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4]: catherinewu.
Apr 16 2021, 8:29 PM
sidkmenon added a reviewer for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4]: alangenfeld.
Apr 16 2021, 8:29 PM
sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/4].

Rebasing

Apr 16 2021, 8:11 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/4].

Adding dagster-graphql to tox.ini and setup.py in automation

Apr 16 2021, 8:03 PM
sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/4].

Moving submit_pipeline_execution tests to the GraphQL python client's test suite

Apr 16 2021, 7:54 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/4].

Fixing are_queries_compatible

Apr 16 2021, 7:43 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/4].

Added regex check to remove redundant spacing from query strings as well

Apr 16 2021, 7:41 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/4].

Adding checks for redundant dagster-graphql-client query snapshot calls and refactoring

Apr 16 2021, 7:18 PM
sidkmenon updated the diff for D7424: [dagster-graphql] Dagster GraphQL Python Client [3/4].

Rebasing

Apr 16 2021, 6:05 PM
sidkmenon updated the diff for D7421: [dagster-graphql] Dagster GraphQL Python Client [2/4].

Responding to comments - refactoring cli to dagster-graphql-client cli

Apr 16 2021, 5:59 PM
sidkmenon added inline comments to D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].
Apr 16 2021, 3:03 PM
sidkmenon updated the diff for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].

Adding to bk python scripts

Apr 16 2021, 3:00 PM
sidkmenon updated the diff for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].

Adding marker to pytest.ini

Apr 16 2021, 12:45 AM
sidkmenon updated the diff for D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].

Addressing comments, including seperating tests into their own tox suite

Apr 16 2021, 12:30 AM

Apr 15 2021

sidkmenon published D7424: [dagster-graphql] Dagster GraphQL Python Client [3/4] for review.
Apr 15 2021, 2:29 PM

Apr 14 2021

sidkmenon updated the summary of D7421: [dagster-graphql] Dagster GraphQL Python Client [2/4].
Apr 14 2021, 5:37 PM
sidkmenon published D7421: [dagster-graphql] Dagster GraphQL Python Client [2/4] for review.
Apr 14 2021, 4:58 PM

Apr 13 2021

sidkmenon requested review of D7409: [RFC] [dagster-graphql] Python Client Implementation [1/4].
Apr 13 2021, 6:43 PM

Apr 9 2021

sidkmenon accepted D7370: K8sRunLauncher make postgres optional.

LGTM!

Apr 9 2021, 5:18 PM

Apr 7 2021

sidkmenon retitled D7343: [Draft] [RFC] [dagster-graphql] Initial Python Client implementation from [RFC] [dagster-graphql] Initial Python Client implementation to [Draft] [RFC] [dagster-graphql] Initial Python Client implementation.
Apr 7 2021, 9:18 PM
sidkmenon requested review of D7343: [Draft] [RFC] [dagster-graphql] Initial Python Client implementation.
Apr 7 2021, 9:09 PM

Mar 18 2021

sidkmenon updated the test plan for D7019: [docs] Instance Config YAML refactor.
Mar 18 2021, 5:22 PM
sidkmenon updated the diff for D7019: [docs] Instance Config YAML refactor.

Also updating MySQL docs

Mar 18 2021, 5:21 PM
sidkmenon updated the diff for D7019: [docs] Instance Config YAML refactor.

Updating API docs to include Consolidated Sqlite Storage

Mar 18 2021, 5:11 PM
sidkmenon updated the summary of D7019: [docs] Instance Config YAML refactor.
Mar 18 2021, 4:38 PM
sidkmenon updated the diff for D7019: [docs] Instance Config YAML refactor.

Ran a make build and seemed to work for MySQL stuff

Mar 18 2021, 7:53 AM
sidkmenon updated the summary of D7019: [docs] Instance Config YAML refactor.
Mar 18 2021, 7:49 AM
sidkmenon updated the diff for D7019: [docs] Instance Config YAML refactor.

Fixing more typos

Mar 18 2021, 7:38 AM
sidkmenon requested review of D7019: [docs] Instance Config YAML refactor.
Mar 18 2021, 7:35 AM

Mar 17 2021

sidkmenon updated the diff for D6898: [core] 0.11.0 Schema migrations for MySQL support.

Rebase conflicts, so making sure no issues w. build

Mar 17 2021, 8:21 PM

Mar 16 2021

sidkmenon updated the diff for D6898: [core] 0.11.0 Schema migrations for MySQL support.

UNIQUE_TEXT => UniqueText

Mar 16 2021, 11:13 PM
sidkmenon updated the diff for D6898: [core] 0.11.0 Schema migrations for MySQL support.

Adding MySQLCompatabilityTypes.UNIQUE_TEXT as a replacement for passing around UNIQUE_VARCHAR_LEN

Mar 16 2021, 6:16 PM
sidkmenon abandoned D6917: [dagster-pg] flaky test fix.
Mar 16 2021, 5:42 PM
sidkmenon added a comment to D6943: Unpin sqlalchemy: Update select label to not be `count`.

Yup, added back pin locally and still seems to work.

Mar 16 2021, 5:38 PM
sidkmenon added a comment to D6943: Unpin sqlalchemy: Update select label to not be `count`.

(you could double check by leaving in the pin locally and verifying that tests still pass after changing it to scalar)

Mar 16 2021, 5:33 PM
sidkmenon accepted D6965: Attempted fix for flaky postgres tests.

Macro absolute-win:

Mar 16 2021, 5:27 PM
sidkmenon added a comment to D6965: Attempted fix for flaky postgres tests.

So I just checked https://www.postgresql.org/docs/9.1/sql-notify.html and verified that for a NOTIFY (registered on store_event) to be registered, LISTEN must first be called; LISTEN is first called in the pynotify loop, so all events after that will be registered & checked in the loop body. This solution looks great, since it ensures that the watcher thread is ready to listen before the event storing/notifier thread can continue.

Mar 16 2021, 5:24 PM

Mar 15 2021

sidkmenon updated the diff for D6943: Unpin sqlalchemy: Update select label to not be `count`.

Updating scalar call

Mar 15 2021, 9:19 PM
sidkmenon updated the summary of D6943: Unpin sqlalchemy: Update select label to not be `count`.
Mar 15 2021, 9:18 PM
sidkmenon commandeered D6943: Unpin sqlalchemy: Update select label to not be `count`.
Mar 15 2021, 9:17 PM
sidkmenon added inline comments to D6943: Unpin sqlalchemy: Update select label to not be `count`.
Mar 15 2021, 7:44 PM
sidkmenon accepted D6931: Try increasing timeouts on postgres event log tests a bit.

This looks great to me, since only the PG tests have shown to be flaky right? Though honestly I'm pretty puzzled why test_event_log_storage_watch was flaky and why test_event_log_storage_two_watchers was not flaky? They're both such similar tests - the latter is just a more complex one than the former.

Mar 15 2021, 3:46 PM

Mar 12 2021

sidkmenon updated the diff for D6917: [dagster-pg] flaky test fix.

again

Mar 12 2021, 5:14 PM
sidkmenon requested review of D6917: [dagster-pg] flaky test fix.
Mar 12 2021, 5:05 PM
sidkmenon updated the diff for D6810: [core][dagster-mysql] Fixing @experimental tag to work for classes.

rebase

Mar 12 2021, 3:09 AM
sidkmenon added inline comments to D6898: [core] 0.11.0 Schema migrations for MySQL support.
Mar 12 2021, 2:26 AM
sidkmenon updated the diff for D6810: [core][dagster-mysql] Fixing @experimental tag to work for classes.

Adding @experimental tag to dagster-pandas as per @rexledesma's comment

Mar 12 2021, 12:49 AM
sidkmenon updated the test plan for D6898: [core] 0.11.0 Schema migrations for MySQL support.
Mar 12 2021, 12:33 AM
sidkmenon updated the test plan for D6898: [core] 0.11.0 Schema migrations for MySQL support.
Mar 12 2021, 12:33 AM
sidkmenon updated the test plan for D6898: [core] 0.11.0 Schema migrations for MySQL support.
Mar 12 2021, 12:33 AM
sidkmenon updated the test plan for D6898: [core] 0.11.0 Schema migrations for MySQL support.
Mar 12 2021, 12:26 AM
sidkmenon requested review of D6898: [core] 0.11.0 Schema migrations for MySQL support.
Mar 12 2021, 12:22 AM

Mar 11 2021

sidkmenon abandoned D6892: [dagster-postgres] Removing dead signal handling code from pynotify.
Mar 11 2021, 8:32 PM
sidkmenon updated the summary of D6892: [dagster-postgres] Removing dead signal handling code from pynotify.
Mar 11 2021, 8:31 PM
sidkmenon updated the diff for D6862: [dagster-postgres] Cleanup Event Log.

Getting rid of D6892 & just removing signal handling logic here

Mar 11 2021, 8:26 PM
sidkmenon requested review of D6892: [dagster-postgres] Removing dead signal handling code from pynotify.
Mar 11 2021, 8:12 PM
sidkmenon updated the diff for D6863: [dagster-postgres] Fixing cursor issues (GH issue #3744).

rebasing

Mar 11 2021, 6:20 PM
sidkmenon updated the diff for D6862: [dagster-postgres] Cleanup Event Log.

Rebasing

Mar 11 2021, 6:19 PM
sidkmenon added inline comments to D6863: [dagster-postgres] Fixing cursor issues (GH issue #3744).
Mar 11 2021, 6:06 AM