Page MenuHomeElementl
Feed Advanced Search

Jun 29 2021

jordansanders added a comment to D8490: Remove reference to output_manager decorator.

Did a user come across this? I didn't think we exposed OutputManager in our docs at all. I don't think we need it around anymore.

Jun 29 2021, 6:52 PM
jordansanders updated the diff for D8575: Test ECS reference deployment.

Ignore containers that aren't connected to the network

Jun 29 2021, 5:21 PM
jordansanders added inline comments to D8575: Test ECS reference deployment.
Jun 29 2021, 4:32 PM
jordansanders added inline comments to D8575: Test ECS reference deployment.
Jun 29 2021, 4:31 PM
jordansanders added inline comments to D8575: Test ECS reference deployment.
Jun 29 2021, 4:29 PM
jordansanders updated the diff for D8575: Test ECS reference deployment.

This update fixes the docker mount issues by:

Jun 29 2021, 4:26 PM
jordansanders updated the diff for D8573: Install compose-cli.

rebase

Jun 29 2021, 4:15 PM
jordansanders requested review of D8573: Install compose-cli.

https://dagster.phacility.com/D8577 should fix the failing build

Jun 29 2021, 3:25 PM
jordansanders accepted D8559: 3/ update update_version script to upload new versioned content/images to s3.
Jun 29 2021, 3:07 PM
jordansanders resigned from D8558: 2/ load versioned images from public s3 bucket.
Jun 29 2021, 3:03 PM
jordansanders resigned from D8415: 1/ load versioned mdx files from s3 instead of local .versioned_content folder.
Jun 29 2021, 3:03 PM

Jun 28 2021

jordansanders requested review of D8577: Handle LegacyVersion.
Jun 28 2021, 9:10 PM
jordansanders published D8575: Test ECS reference deployment for review.

Requesting feedback before I've gotten a clean build because I could use some advice on how we want to handle a particularly hair docker-compose-in-docker situation.

Jun 28 2021, 7:04 PM

Jun 25 2021

jordansanders closed D8530: Fixup changelog.
Jun 25 2021, 3:36 PM
jordansanders committed R1:0f6c48d5d697: Fixup changelog (authored by jordansanders).
Fixup changelog
Jun 25 2021, 3:35 PM
jordansanders added inline comments to D8530: Fixup changelog.
Jun 25 2021, 2:52 PM
jordansanders requested review of D8530: Fixup changelog.
Jun 25 2021, 2:50 PM

Jun 24 2021

jordansanders accepted D8517: 0.11.15 changelog.
Jun 24 2021, 9:12 PM
jordansanders updated subscribers of D8517: 0.11.15 changelog.
Jun 24 2021, 9:02 PM
jordansanders added inline comments to D8517: 0.11.15 changelog.
Jun 24 2021, 9:00 PM
jordansanders added inline comments to D8517: 0.11.15 changelog.
Jun 24 2021, 8:56 PM
jordansanders requested changes to D8517: 0.11.15 changelog.
Jun 24 2021, 8:55 PM
jordansanders closed D8492: Use the EcsRunLauncher in the reference deployment.
Jun 24 2021, 3:37 PM
jordansanders committed R1:f331e0eafafe: Use the EcsRunLauncher in the reference deployment (authored by jordansanders).
Use the EcsRunLauncher in the reference deployment
Jun 24 2021, 3:37 PM
jordansanders closed D8491: Cross-reference ECS reference deployment.
Jun 24 2021, 3:37 PM
jordansanders committed R1:9122845e8e81: Cross-reference ECS reference deployment (authored by jordansanders).
Cross-reference ECS reference deployment
Jun 24 2021, 3:37 PM
jordansanders closed D8292: Add a reference deployment for ECS.
Jun 24 2021, 3:37 PM
jordansanders committed R1:41434078340d: Add a reference deployment for ECS (authored by jordansanders).
Add a reference deployment for ECS
Jun 24 2021, 3:37 PM
jordansanders updated the diff for D8492: Use the EcsRunLauncher in the reference deployment.

update aws docs

Jun 24 2021, 2:22 PM
jordansanders added inline comments to D8492: Use the EcsRunLauncher in the reference deployment.
Jun 24 2021, 2:21 PM

Jun 23 2021

jordansanders requested review of D8491: Cross-reference ECS reference deployment.
Jun 23 2021, 9:30 PM
jordansanders requested review of D8492: Use the EcsRunLauncher in the reference deployment.
Jun 23 2021, 9:12 PM
jordansanders updated the diff for D8292: Add a reference deployment for ECS.

Add a simple test to satisfy tox. Otherwise, pytest raises exit code 5 (no tests collected) so tox fails the build.

Jun 23 2021, 8:43 PM
jordansanders closed D8488: Log the task arn and cluster.
Jun 23 2021, 7:45 PM
jordansanders committed R1:97894f7cb749: Log the task arn and cluster (authored by jordansanders).
Log the task arn and cluster
Jun 23 2021, 7:45 PM
jordansanders closed D8487: Decorate EcsRunLauncher as experimental.
Jun 23 2021, 7:45 PM
jordansanders closed D8486: Create a new task definition for each launch.
Jun 23 2021, 7:45 PM
jordansanders committed R1:dd19951b7260: Decorate EcsRunLauncher as experimental (authored by jordansanders).
Decorate EcsRunLauncher as experimental
Jun 23 2021, 7:45 PM
jordansanders committed R1:cb07e82a7bf9: Create a new task definition for each launch (authored by jordansanders).
Create a new task definition for each launch
Jun 23 2021, 7:45 PM
jordansanders updated the diff for D8292: Add a reference deployment for ECS.

rebase

Jun 23 2021, 5:26 PM
jordansanders updated the diff for D8488: Log the task arn and cluster.

rebase

Jun 23 2021, 5:26 PM
jordansanders updated the diff for D8487: Decorate EcsRunLauncher as experimental.

rebase

Jun 23 2021, 5:25 PM
jordansanders updated the diff for D8486: Create a new task definition for each launch.

rebase

Jun 23 2021, 5:25 PM
jordansanders closed D8475: Include ENI infornmation in ECS task stubs.
Jun 23 2021, 5:24 PM
jordansanders closed D8474: Tag runs with ECS info.
Jun 23 2021, 5:24 PM
jordansanders committed R1:242ae68c4f8b: Include ENI infornmation in ECS task stubs (authored by jordansanders).
Include ENI infornmation in ECS task stubs
Jun 23 2021, 5:24 PM
jordansanders closed D8417: Mixin ConfigurableClass with EcsRunLauncher.
Jun 23 2021, 5:24 PM
jordansanders committed R1:6fe3738d59db: Tag runs with ECS info (authored by jordansanders).
Tag runs with ECS info
Jun 23 2021, 5:24 PM
jordansanders committed R1:e28f1b83c703: Mixin ConfigurableClass with EcsRunLauncher (authored by jordansanders).
Mixin ConfigurableClass with EcsRunLauncher
Jun 23 2021, 5:24 PM
jordansanders closed D8405: Terminate ECS runs.
Jun 23 2021, 5:24 PM
jordansanders closed D8404: Launch runs in ECS.
Jun 23 2021, 5:24 PM
jordansanders committed R1:d72e4b5218c1: Terminate ECS runs (authored by jordansanders).
Terminate ECS runs
Jun 23 2021, 5:24 PM
jordansanders committed R1:74e45e06658b: Launch runs in ECS (authored by jordansanders).
Launch runs in ECS
Jun 23 2021, 5:24 PM
jordansanders closed D8493: Ignore unimplemented abstract-method from sqlalchemy.
Jun 23 2021, 5:06 PM
jordansanders committed R1:e065f7152b48: Ignore unimplemented abstract-method from sqlalchemy (authored by jordansanders).
Ignore unimplemented abstract-method from sqlalchemy
Jun 23 2021, 5:06 PM
jordansanders retitled D8493: Ignore unimplemented abstract-method from sqlalchemy from Pin sqlalchemy to Ignore unimplemented abstract-method from sqlalchemy.
Jun 23 2021, 4:41 PM
jordansanders updated the diff for D8493: Ignore unimplemented abstract-method from sqlalchemy.

Ignore pylint

Jun 23 2021, 4:39 PM
jordansanders added a comment to D8493: Ignore unimplemented abstract-method from sqlalchemy.

if its just pylint - should we #pylint: disable=abstract-method instead? i assume the run time behavior is under test

Jun 23 2021, 4:37 PM
jordansanders published D8493: Ignore unimplemented abstract-method from sqlalchemy for review.

Moving this into review to get buildkite back to green.

Jun 23 2021, 4:10 PM
jordansanders updated the diff for D8292: Add a reference deployment for ECS.

rebase

Jun 23 2021, 3:14 PM
jordansanders updated the diff for D8488: Log the task arn and cluster.

rebase

Jun 23 2021, 3:14 PM
jordansanders updated the diff for D8487: Decorate EcsRunLauncher as experimental.

rebase

Jun 23 2021, 3:13 PM
jordansanders updated the diff for D8486: Create a new task definition for each launch.

rebase

Jun 23 2021, 3:13 PM
jordansanders updated the summary of D8292: Add a reference deployment for ECS.
Jun 23 2021, 3:07 PM
jordansanders updated the diff for D8292: Add a reference deployment for ECS.

rebase

Jun 23 2021, 3:03 PM
jordansanders updated the diff for D8488: Log the task arn and cluster.

rebase

Jun 23 2021, 3:02 PM
jordansanders updated the diff for D8487: Decorate EcsRunLauncher as experimental.

rebase

Jun 23 2021, 3:02 PM
jordansanders updated the diff for D8486: Create a new task definition for each launch.

rebase

Jun 23 2021, 3:01 PM
jordansanders added inline comments to D8292: Add a reference deployment for ECS.
Jun 23 2021, 2:37 PM
jordansanders updated the diff for D8292: Add a reference deployment for ECS.

Clean up documentation, use a multi-stage dockerfile, attempt to fix tox.

Jun 23 2021, 2:34 PM

Jun 22 2021

jordansanders updated the diff for D8292: Add a reference deployment for ECS.

don't run tests (because none exist yet)

Jun 22 2021, 7:40 PM
jordansanders updated the diff for D8292: Add a reference deployment for ECS.

cherrypick onto a branch that has the EcsRunLauncher

Jun 22 2021, 7:11 PM
jordansanders abandoned D7667: Add a dagit service.

Abandoning in favor of docker-compose

Jun 22 2021, 6:59 PM
jordansanders abandoned D7666: Add a Fargate cluster.

Abandoning in favor of docker-compose

Jun 22 2021, 6:59 PM
jordansanders abandoned D7665: Scaffold networking and load balancer for example ECS deployment.

Abandoning in favor of docker-compose

Jun 22 2021, 6:59 PM
jordansanders added inline comments to D8490: Remove reference to output_manager decorator.
Jun 22 2021, 6:32 PM
jordansanders requested review of D8490: Remove reference to output_manager decorator.
Jun 22 2021, 6:29 PM

Jun 21 2021

jordansanders requested review of D8487: Decorate EcsRunLauncher as experimental.
Jun 21 2021, 10:29 PM
jordansanders requested review of D8488: Log the task arn and cluster.
Jun 21 2021, 10:15 PM
jordansanders requested review of D8486: Create a new task definition for each launch.
Jun 21 2021, 10:08 PM
jordansanders requested review of D8475: Include ENI infornmation in ECS task stubs.
Jun 21 2021, 10:05 PM
jordansanders closed D8473: Ensure AWS unit tests never run against real AWS.
Jun 21 2021, 10:03 PM
jordansanders committed R1:8b8c658674b6: Ensure AWS unit tests never run against real AWS (authored by jordansanders).
Ensure AWS unit tests never run against real AWS
Jun 21 2021, 10:03 PM
jordansanders closed D8407: Remove unused ECS Client.
Jun 21 2021, 10:03 PM
jordansanders committed R1:678d816ae168: Remove unused ECS Client (authored by jordansanders).
Remove unused ECS Client
Jun 21 2021, 10:03 PM
jordansanders updated the diff for D8474: Tag runs with ECS info.

rebase

Jun 21 2021, 9:41 PM
jordansanders updated the diff for D8417: Mixin ConfigurableClass with EcsRunLauncher.

rebase

Jun 21 2021, 9:41 PM
jordansanders updated the diff for D8405: Terminate ECS runs.

rebase

Jun 21 2021, 9:40 PM
jordansanders updated the diff for D8404: Launch runs in ECS.

rebase

Jun 21 2021, 9:37 PM
jordansanders updated the diff for D8473: Ensure AWS unit tests never run against real AWS.

rebase

Jun 21 2021, 9:37 PM
jordansanders updated the diff for D8407: Remove unused ECS Client.

rebase

Jun 21 2021, 9:35 PM
jordansanders closed D8484: Allow classes to be decorated with @experimental.
Jun 21 2021, 6:26 PM
jordansanders committed R1:a1900c231304: Allow classes to be decorated with @experimental (authored by jordansanders).
Allow classes to be decorated with @experimental
Jun 21 2021, 6:26 PM
jordansanders updated the summary of D8484: Allow classes to be decorated with @experimental.
Jun 21 2021, 6:24 PM
jordansanders updated the diff for D8484: Allow classes to be decorated with @experimental.

Include a meaningful init in tests to prove super is being called correctly

Jun 21 2021, 5:58 PM
jordansanders requested review of D8484: Allow classes to be decorated with @experimental.
Jun 21 2021, 5:08 PM

Jun 18 2021

jordansanders added a comment to D8473: Ensure AWS unit tests never run against real AWS.

We don't have any end-to-end tests that connect to a real AWS instance? or are all those in integration_tests

Jun 18 2021, 9:57 PM
jordansanders requested review of D8473: Ensure AWS unit tests never run against real AWS.
Jun 18 2021, 8:36 PM
jordansanders requested review of D8474: Tag runs with ECS info.
Jun 18 2021, 8:27 PM
jordansanders updated the diff for D8417: Mixin ConfigurableClass with EcsRunLauncher.

rebase

Jun 18 2021, 8:01 PM